{"action":"created","issue":{"url":"https://api.github.com/repos/spacetx/starfish/issues/362","repository_url":"https://api.github.com/repos/spacetx/starfish","labels_url":"https://api.github.com/repos/spacetx/starfish/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/spacetx/starfish/issues/362/comments","events_url":"https://api.github.com/repos/spacetx/starfish/issues/362/events","html_url":"https://github.com/spacetx/starfish/pull/362","id":347159458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODQ5NDY0","number":362,"title":"Check the version in the file to see if we support it.","user":{"login":"ttung","id":280924,"node_id":"MDQ6VXNlcjI4MDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/280924?v=4","gravatar_id":"","url":"https://api.github.com/users/ttung","html_url":"https://github.com/ttung","followers_url":"https://api.github.com/users/ttung/followers","following_url":"https://api.github.com/users/ttung/following{/other_user}","gists_url":"https://api.github.com/users/ttung/gists{/gist_id}","starred_url":"https://api.github.com/users/ttung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttung/subscriptions","organizations_url":"https://api.github.com/users/ttung/orgs","repos_url":"https://api.github.com/users/ttung/repos","events_url":"https://api.github.com/users/ttung/events{/privacy}","received_events_url":"https://api.github.com/users/ttung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-02T20:18:44Z","updated_at":"2018-08-02T21:18:51Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/362","html_url":"https://github.com/spacetx/starfish/pull/362","diff_url":"https://github.com/spacetx/starfish/pull/362.diff","patch_url":"https://github.com/spacetx/starfish/pull/362.patch"},"body":"Test plan: changed the MAX_SUPPORTED_VERSION to 0.0.0, and loaded up a 1.0.0 experiment.json:\r\n\r\n```\r\n[czipa1osx186 (.venv)]:~/microscopy/starfish:tonytung-types> python notebooks/allen_smFISH.py\r\nTraceback (most recent call last):\r\n  File \"notebooks/allen_smFISH.py\", line 61, in <module>\r\n    s = Stack.from_experiment_json(experiment_json)\r\n  File \"/Users/ttung/microscopy/starfish/starfish/io.py\", line 83, in from_experiment_json\r\n    stack.read(json_url)\r\n  File \"/Users/ttung/microscopy/starfish/starfish/io.py\", line 60, in read\r\n    f\"version {version} not supported.  This version of the starfish library only \"\r\nValueError: version 1.0.0 not supported.  This version of the starfish library only supports formats from 0.0.0 to 0.0.0\r\n[czipa1osx186 (.venv)]:~/microscopy/starfish:tonytung-types>\r\n```"},"comment":{"url":"https://api.github.com/repos/spacetx/starfish/issues/comments/410071129","html_url":"https://github.com/spacetx/starfish/pull/362#issuecomment-410071129","issue_url":"https://api.github.com/repos/spacetx/starfish/issues/362","id":410071129,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDA3MTEyOQ==","user":{"login":"ttung","id":280924,"node_id":"MDQ6VXNlcjI4MDkyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/280924?v=4","gravatar_id":"","url":"https://api.github.com/users/ttung","html_url":"https://github.com/ttung","followers_url":"https://api.github.com/users/ttung/followers","following_url":"https://api.github.com/users/ttung/following{/other_user}","gists_url":"https://api.github.com/users/ttung/gists{/gist_id}","starred_url":"https://api.github.com/users/ttung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttung/subscriptions","organizations_url":"https://api.github.com/users/ttung/orgs","repos_url":"https://api.github.com/users/ttung/repos","events_url":"https://api.github.com/users/ttung/events{/privacy}","received_events_url":"https://api.github.com/users/ttung/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T21:18:51Z","updated_at":"2018-08-02T21:18:51Z","author_association":"COLLABORATOR","body":"Reversed the order of the comparisons, and added unit tests."}}
{"actor":{"display_login":"ttung"}}