{"action":"created","comment":{"url":"https://api.github.com/repos/gismo/gismo/pulls/comments/165916380","pull_request_review_id":93923915,"id":165916380,"diff_hunk":"@@ -168,6 +168,9 @@ class gsMultiPatch : public gsBoxTopology, public gsFunctionSet<T>\n     /// manifold (ie. it has no boundaries)\n     bool isClosed() { return this->nBoundary() == 0; }\n \n+    /// \\brief Returns true if gsMultiPatch is empty.\n+    const bool isEmpty() const { return this->nPatches() <= 0; }","path":"src/gsCore/gsMultiPatch.h","position":5,"original_position":5,"commit_id":"d97380abba6ce7dcfbc2a7fc581277a6a3fa61ca","original_commit_id":"62a2b68d3d048f4f4e4d96afa2cf74e3a2dc4b2e","user":{"login":"filiatra","id":3185717,"avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false},"body":"To conform to std, please rename it to \"bool empty() const\", and implement as { return m_patches.empty(); }","created_at":"2018-02-05T09:23:04Z","updated_at":"2018-02-05T09:23:04Z","html_url":"https://github.com/gismo/gismo/pull/96#discussion_r165916380","pull_request_url":"https://api.github.com/repos/gismo/gismo/pulls/96","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gismo/gismo/pulls/comments/165916380"},"html":{"href":"https://github.com/gismo/gismo/pull/96#discussion_r165916380"},"pull_request":{"href":"https://api.github.com/repos/gismo/gismo/pulls/96"}},"in_reply_to_id":165633318},"pull_request":{"url":"https://api.github.com/repos/gismo/gismo/pulls/96","id":166789909,"html_url":"https://github.com/gismo/gismo/pull/96","diff_url":"https://github.com/gismo/gismo/pull/96.diff","patch_url":"https://github.com/gismo/gismo/pull/96.patch","issue_url":"https://api.github.com/repos/gismo/gismo/issues/96","number":96,"state":"open","locked":false,"title":"Remove ptrs","user":{"login":"codewerfer","id":29753931,"avatar_url":"https://avatars2.githubusercontent.com/u/29753931?v=4","gravatar_id":"","url":"https://api.github.com/users/codewerfer","html_url":"https://github.com/codewerfer","followers_url":"https://api.github.com/users/codewerfer/followers","following_url":"https://api.github.com/users/codewerfer/following{/other_user}","gists_url":"https://api.github.com/users/codewerfer/gists{/gist_id}","starred_url":"https://api.github.com/users/codewerfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewerfer/subscriptions","organizations_url":"https://api.github.com/users/codewerfer/orgs","repos_url":"https://api.github.com/users/codewerfer/repos","events_url":"https://api.github.com/users/codewerfer/events{/privacy}","received_events_url":"https://api.github.com/users/codewerfer/received_events","type":"User","site_admin":false},"body":"* remove of gsMultiPatch pointers where possible (and useful)\r\nStill needs to be done also in trunk.","created_at":"2018-02-02T12:24:41Z","updated_at":"2018-02-05T09:23:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b2fcd5965a5b02100461618436d0629f4ff42b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/gismo/gismo/pulls/96/commits","review_comments_url":"https://api.github.com/repos/gismo/gismo/pulls/96/comments","review_comment_url":"https://api.github.com/repos/gismo/gismo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gismo/gismo/issues/96/comments","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/d97380abba6ce7dcfbc2a7fc581277a6a3fa61ca","head":{"label":"gismo:remove_ptrs","ref":"remove_ptrs","sha":"d97380abba6ce7dcfbc2a7fc581277a6a3fa61ca","user":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"repo":{"id":35604128,"name":"gismo","full_name":"gismo/gismo","owner":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gismo/gismo","description":"G+Smo (pronounced gismo or gizmo) is a C++ library for isogeometric analysis (IGA). Geometry plus simulation modules aims at the seamless integration of Computer-aided Design (CAD) and Finite Element Analysis (FEA).","fork":false,"url":"https://api.github.com/repos/gismo/gismo","forks_url":"https://api.github.com/repos/gismo/gismo/forks","keys_url":"https://api.github.com/repos/gismo/gismo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gismo/gismo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gismo/gismo/teams","hooks_url":"https://api.github.com/repos/gismo/gismo/hooks","issue_events_url":"https://api.github.com/repos/gismo/gismo/issues/events{/number}","events_url":"https://api.github.com/repos/gismo/gismo/events","assignees_url":"https://api.github.com/repos/gismo/gismo/assignees{/user}","branches_url":"https://api.github.com/repos/gismo/gismo/branches{/branch}","tags_url":"https://api.github.com/repos/gismo/gismo/tags","blobs_url":"https://api.github.com/repos/gismo/gismo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gismo/gismo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gismo/gismo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gismo/gismo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/{sha}","languages_url":"https://api.github.com/repos/gismo/gismo/languages","stargazers_url":"https://api.github.com/repos/gismo/gismo/stargazers","contributors_url":"https://api.github.com/repos/gismo/gismo/contributors","subscribers_url":"https://api.github.com/repos/gismo/gismo/subscribers","subscription_url":"https://api.github.com/repos/gismo/gismo/subscription","commits_url":"https://api.github.com/repos/gismo/gismo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gismo/gismo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gismo/gismo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gismo/gismo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gismo/gismo/contents/{+path}","compare_url":"https://api.github.com/repos/gismo/gismo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gismo/gismo/merges","archive_url":"https://api.github.com/repos/gismo/gismo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gismo/gismo/downloads","issues_url":"https://api.github.com/repos/gismo/gismo/issues{/number}","pulls_url":"https://api.github.com/repos/gismo/gismo/pulls{/number}","milestones_url":"https://api.github.com/repos/gismo/gismo/milestones{/number}","notifications_url":"https://api.github.com/repos/gismo/gismo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gismo/gismo/labels{/name}","releases_url":"https://api.github.com/repos/gismo/gismo/releases{/id}","deployments_url":"https://api.github.com/repos/gismo/gismo/deployments","created_at":"2015-05-14T09:57:52Z","updated_at":"2018-02-02T13:25:35Z","pushed_at":"2018-02-05T09:20:38Z","git_url":"git://github.com/gismo/gismo.git","ssh_url":"git@github.com:gismo/gismo.git","clone_url":"https://github.com/gismo/gismo.git","svn_url":"https://github.com/gismo/gismo","homepage":"http://gs.jku.at/gismo","size":38245,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":7,"watchers":25,"default_branch":"stable"}},"base":{"label":"gismo:stable","ref":"stable","sha":"97c3dc69be5f1f6b5f94c68d6e89b7fed4323d76","user":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"repo":{"id":35604128,"name":"gismo","full_name":"gismo/gismo","owner":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gismo/gismo","description":"G+Smo (pronounced gismo or gizmo) is a C++ library for isogeometric analysis (IGA). Geometry plus simulation modules aims at the seamless integration of Computer-aided Design (CAD) and Finite Element Analysis (FEA).","fork":false,"url":"https://api.github.com/repos/gismo/gismo","forks_url":"https://api.github.com/repos/gismo/gismo/forks","keys_url":"https://api.github.com/repos/gismo/gismo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gismo/gismo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gismo/gismo/teams","hooks_url":"https://api.github.com/repos/gismo/gismo/hooks","issue_events_url":"https://api.github.com/repos/gismo/gismo/issues/events{/number}","events_url":"https://api.github.com/repos/gismo/gismo/events","assignees_url":"https://api.github.com/repos/gismo/gismo/assignees{/user}","branches_url":"https://api.github.com/repos/gismo/gismo/branches{/branch}","tags_url":"https://api.github.com/repos/gismo/gismo/tags","blobs_url":"https://api.github.com/repos/gismo/gismo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gismo/gismo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gismo/gismo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gismo/gismo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/{sha}","languages_url":"https://api.github.com/repos/gismo/gismo/languages","stargazers_url":"https://api.github.com/repos/gismo/gismo/stargazers","contributors_url":"https://api.github.com/repos/gismo/gismo/contributors","subscribers_url":"https://api.github.com/repos/gismo/gismo/subscribers","subscription_url":"https://api.github.com/repos/gismo/gismo/subscription","commits_url":"https://api.github.com/repos/gismo/gismo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gismo/gismo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gismo/gismo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gismo/gismo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gismo/gismo/contents/{+path}","compare_url":"https://api.github.com/repos/gismo/gismo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gismo/gismo/merges","archive_url":"https://api.github.com/repos/gismo/gismo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gismo/gismo/downloads","issues_url":"https://api.github.com/repos/gismo/gismo/issues{/number}","pulls_url":"https://api.github.com/repos/gismo/gismo/pulls{/number}","milestones_url":"https://api.github.com/repos/gismo/gismo/milestones{/number}","notifications_url":"https://api.github.com/repos/gismo/gismo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gismo/gismo/labels{/name}","releases_url":"https://api.github.com/repos/gismo/gismo/releases{/id}","deployments_url":"https://api.github.com/repos/gismo/gismo/deployments","created_at":"2015-05-14T09:57:52Z","updated_at":"2018-02-02T13:25:35Z","pushed_at":"2018-02-05T09:20:38Z","git_url":"git://github.com/gismo/gismo.git","ssh_url":"git@github.com:gismo/gismo.git","clone_url":"https://github.com/gismo/gismo.git","svn_url":"https://github.com/gismo/gismo","homepage":"http://gs.jku.at/gismo","size":38245,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":7,"watchers":25,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/gismo/gismo/pulls/96"},"html":{"href":"https://github.com/gismo/gismo/pull/96"},"issue":{"href":"https://api.github.com/repos/gismo/gismo/issues/96"},"comments":{"href":"https://api.github.com/repos/gismo/gismo/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/gismo/gismo/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/gismo/gismo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gismo/gismo/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/gismo/gismo/statuses/d97380abba6ce7dcfbc2a7fc581277a6a3fa61ca"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"filiatra"}}