{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/178688041","pull_request_review_id":108786447,"id":178688041,"diff_hunk":"@@ -571,6 +571,17 @@ func (ctrl *PersistentVolumeController) syncVolume(volume *v1.PersistentVolume)\n \t\t\t}\n \t\t\treturn nil\n \t\t} else if claim.Spec.VolumeName == \"\" {\n+\t\t\tif isMisMatch, err := checkVolumeModeMisMatches(&claim.Spec, &volume.Spec); err != nil || isMisMatch {\n+\t\t\t\t// Binding for the volume won't be called in syncUnboundClaim,\n+\t\t\t\t// because findBestMatchForClaim won't return the volume due to volumeMode mismatch.\n+\t\t\t\tvolumeMsg := fmt.Sprintf(\"Cannot bind PersistentVolume to requested PersistentVolumeClaim %s due to incompatible volumeMode.\", claim.Name)","path":"pkg/controller/volume/persistentvolume/pv_controller.go","position":7,"original_position":7,"commit_id":"4eea66191440aa6adc1e124b699e814324401379","original_commit_id":"4eea66191440aa6adc1e124b699e814324401379","user":{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false},"body":"I prefer %q so that the name is quoted","created_at":"2018-04-03T00:47:57Z","updated_at":"2018-04-03T00:50:42Z","html_url":"https://github.com/kubernetes/kubernetes/pull/59947#discussion_r178688041","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/178688041"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59947#discussion_r178688041"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947","id":169490153,"html_url":"https://github.com/kubernetes/kubernetes/pull/59947","diff_url":"https://github.com/kubernetes/kubernetes/pull/59947.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59947.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59947","number":59947,"state":"open","locked":false,"title":"Add binding error message for volumeMode:Block unsupported case","user":{"login":"mkimuram","id":36450643,"avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"body":"\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR adds a binding error message for volumeMode:Block\r\nunsupported case.\r\nWith this message, users can understand why PV is not bound to\r\nPVC on dynamic provisioning.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes: #59942\r\n\r\n**Special notes for your reviewer**:\r\n/cc @mtanino \r\n/sig storage\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-02-15T21:29:41Z","updated_at":"2018-04-03T00:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d3ef3b1e4feff2f070385765c79f5d1ca4f2824","assignee":{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false},"assignees":[{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mtanino","id":19844283,"avatar_url":"https://avatars0.githubusercontent.com/u/19844283?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanino","html_url":"https://github.com/mtanino","followers_url":"https://api.github.com/users/mtanino/followers","following_url":"https://api.github.com/users/mtanino/following{/other_user}","gists_url":"https://api.github.com/users/mtanino/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanino/subscriptions","organizations_url":"https://api.github.com/users/mtanino/orgs","repos_url":"https://api.github.com/users/mtanino/repos","events_url":"https://api.github.com/users/mtanino/events{/privacy}","received_events_url":"https://api.github.com/users/mtanino/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59947/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4eea66191440aa6adc1e124b699e814324401379","head":{"label":"mkimuram:issue/59942","ref":"issue/59942","sha":"4eea66191440aa6adc1e124b699e814324401379","user":{"login":"mkimuram","id":36450643,"avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"repo":{"id":121439175,"name":"kubernetes","full_name":"mkimuram/kubernetes","owner":{"login":"mkimuram","id":36450643,"avatar_url":"https://avatars2.githubusercontent.com/u/36450643?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimuram","html_url":"https://github.com/mkimuram","followers_url":"https://api.github.com/users/mkimuram/followers","following_url":"https://api.github.com/users/mkimuram/following{/other_user}","gists_url":"https://api.github.com/users/mkimuram/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimuram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimuram/subscriptions","organizations_url":"https://api.github.com/users/mkimuram/orgs","repos_url":"https://api.github.com/users/mkimuram/repos","events_url":"https://api.github.com/users/mkimuram/events{/privacy}","received_events_url":"https://api.github.com/users/mkimuram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkimuram/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mkimuram/kubernetes","forks_url":"https://api.github.com/repos/mkimuram/kubernetes/forks","keys_url":"https://api.github.com/repos/mkimuram/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkimuram/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkimuram/kubernetes/teams","hooks_url":"https://api.github.com/repos/mkimuram/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mkimuram/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mkimuram/kubernetes/events","assignees_url":"https://api.github.com/repos/mkimuram/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mkimuram/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mkimuram/kubernetes/tags","blobs_url":"https://api.github.com/repos/mkimuram/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkimuram/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkimuram/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkimuram/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkimuram/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mkimuram/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mkimuram/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mkimuram/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mkimuram/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mkimuram/kubernetes/subscription","commits_url":"https://api.github.com/repos/mkimuram/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkimuram/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkimuram/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkimuram/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkimuram/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mkimuram/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkimuram/kubernetes/merges","archive_url":"https://api.github.com/repos/mkimuram/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkimuram/kubernetes/downloads","issues_url":"https://api.github.com/repos/mkimuram/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mkimuram/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mkimuram/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mkimuram/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkimuram/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mkimuram/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mkimuram/kubernetes/deployments","created_at":"2018-02-13T21:33:13Z","updated_at":"2018-02-13T21:33:49Z","pushed_at":"2018-04-02T16:36:13Z","git_url":"git://github.com/mkimuram/kubernetes.git","ssh_url":"git@github.com:mkimuram/kubernetes.git","clone_url":"https://github.com/mkimuram/kubernetes.git","svn_url":"https://github.com/mkimuram/kubernetes","homepage":"http://kubernetes.io","size":547485,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9bd4f12c336af339c35e773e1d71a37cad342f57","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-03T00:39:04Z","pushed_at":"2018-04-03T00:13:23Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":768326,"stargazers_count":34554,"watchers_count":34554,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12237,"mirror_url":null,"archived":false,"open_issues_count":3469,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12237,"open_issues":3469,"watchers":34554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59947"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59947"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59947/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59947/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4eea66191440aa6adc1e124b699e814324401379"}},"author_association":"NONE"}}
{"actor":{"display_login":"msau42"}}