{"action":"created","comment":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/169688972","pull_request_review_id":98255874,"id":169688972,"diff_hunk":"@@ -32,6 +32,7 @@ namespace detail {\n \n // clang-format off\n #define DATA_TYPE_INFO                  \\\n+  ((uint8_t,     Bool,       \"bool\"))   \\","path":"src/lib/all_type_variant.hpp","position":4,"original_position":4,"commit_id":"0a55dbcd1eacf310a0eb7bd960c8348837b51c3c","original_commit_id":"0a55dbcd1eacf310a0eb7bd960c8348837b51c3c","user":{"login":"jfrohnhofen","id":1701977,"avatar_url":"https://avatars3.githubusercontent.com/u/1701977?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrohnhofen","html_url":"https://github.com/jfrohnhofen","followers_url":"https://api.github.com/users/jfrohnhofen/followers","following_url":"https://api.github.com/users/jfrohnhofen/following{/other_user}","gists_url":"https://api.github.com/users/jfrohnhofen/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrohnhofen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrohnhofen/subscriptions","organizations_url":"https://api.github.com/users/jfrohnhofen/orgs","repos_url":"https://api.github.com/users/jfrohnhofen/repos","events_url":"https://api.github.com/users/jfrohnhofen/events{/privacy}","received_events_url":"https://api.github.com/users/jfrohnhofen/received_events","type":"User","site_admin":false},"body":"But what happens if you statically cast the enum member, that does exist in JitType, but not DataType? With the `std::unordered_map` we would at least get a runtime exception, whether I think a static_cast will just lead to undefined behavior?","created_at":"2018-02-21T16:10:08Z","updated_at":"2018-02-21T16:10:08Z","html_url":"https://github.com/hyrise/hyrise/pull/709#discussion_r169688972","pull_request_url":"https://api.github.com/repos/hyrise/hyrise/pulls/709","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments/169688972"},"html":{"href":"https://github.com/hyrise/hyrise/pull/709#discussion_r169688972"},"pull_request":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/709"}},"in_reply_to_id":169626434},"pull_request":{"url":"https://api.github.com/repos/hyrise/hyrise/pulls/709","id":169839709,"html_url":"https://github.com/hyrise/hyrise/pull/709","diff_url":"https://github.com/hyrise/hyrise/pull/709.diff","patch_url":"https://github.com/hyrise/hyrise/pull/709.patch","issue_url":"https://api.github.com/repos/hyrise/hyrise/issues/709","number":709,"state":"open","locked":false,"title":"JIT 2: types, type dispatching, basic operations","user":{"login":"jfrohnhofen","id":1701977,"avatar_url":"https://avatars3.githubusercontent.com/u/1701977?v=4","gravatar_id":"","url":"https://api.github.com/users/jfrohnhofen","html_url":"https://github.com/jfrohnhofen","followers_url":"https://api.github.com/users/jfrohnhofen/followers","following_url":"https://api.github.com/users/jfrohnhofen/following{/other_user}","gists_url":"https://api.github.com/users/jfrohnhofen/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrohnhofen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrohnhofen/subscriptions","organizations_url":"https://api.github.com/users/jfrohnhofen/orgs","repos_url":"https://api.github.com/users/jfrohnhofen/repos","events_url":"https://api.github.com/users/jfrohnhofen/events{/privacy}","received_events_url":"https://api.github.com/users/jfrohnhofen/received_events","type":"User","site_admin":false},"body":"This PR introduces the variant types used by the jit backend, and a mechanism for dispatching types and performing computations with these variant values. I added (hopefully enough) documentation to explain the basic concepts. If something is still unclear, let me know.\r\n\r\nFor now, none of this is used anywhere in the code. But this will change in PR3, so stay tuned...","created_at":"2018-02-18T17:09:12Z","updated_at":"2018-02-21T16:10:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d70a3c144385d17ac695bafd2d416470a300ae55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyrise/hyrise/pulls/709/commits","review_comments_url":"https://api.github.com/repos/hyrise/hyrise/pulls/709/comments","review_comment_url":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyrise/hyrise/issues/709/comments","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/0a55dbcd1eacf310a0eb7bd960c8348837b51c3c","head":{"label":"hyrise:johannes/jit_pr_2_types","ref":"johannes/jit_pr_2_types","sha":"0a55dbcd1eacf310a0eb7bd960c8348837b51c3c","user":{"login":"hyrise","id":3465095,"avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"name":"hyrise","full_name":"hyrise/hyrise","owner":{"login":"hyrise","id":3465095,"avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyrise/hyrise","description":"A research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-02-02T09:29:02Z","pushed_at":"2018-02-21T15:02:21Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"git@github.com:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":11779,"stargazers_count":57,"watchers_count":57,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":74,"watchers":57,"default_branch":"master"}},"base":{"label":"hyrise:master","ref":"master","sha":"41b125f09ce78d17e4cb81826d793fa8692c13f1","user":{"login":"hyrise","id":3465095,"avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"repo":{"id":87414843,"name":"hyrise","full_name":"hyrise/hyrise","owner":{"login":"hyrise","id":3465095,"avatar_url":"https://avatars2.githubusercontent.com/u/3465095?v=4","gravatar_id":"","url":"https://api.github.com/users/hyrise","html_url":"https://github.com/hyrise","followers_url":"https://api.github.com/users/hyrise/followers","following_url":"https://api.github.com/users/hyrise/following{/other_user}","gists_url":"https://api.github.com/users/hyrise/gists{/gist_id}","starred_url":"https://api.github.com/users/hyrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyrise/subscriptions","organizations_url":"https://api.github.com/users/hyrise/orgs","repos_url":"https://api.github.com/users/hyrise/repos","events_url":"https://api.github.com/users/hyrise/events{/privacy}","received_events_url":"https://api.github.com/users/hyrise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyrise/hyrise","description":"A research in-memory database.","fork":false,"url":"https://api.github.com/repos/hyrise/hyrise","forks_url":"https://api.github.com/repos/hyrise/hyrise/forks","keys_url":"https://api.github.com/repos/hyrise/hyrise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyrise/hyrise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyrise/hyrise/teams","hooks_url":"https://api.github.com/repos/hyrise/hyrise/hooks","issue_events_url":"https://api.github.com/repos/hyrise/hyrise/issues/events{/number}","events_url":"https://api.github.com/repos/hyrise/hyrise/events","assignees_url":"https://api.github.com/repos/hyrise/hyrise/assignees{/user}","branches_url":"https://api.github.com/repos/hyrise/hyrise/branches{/branch}","tags_url":"https://api.github.com/repos/hyrise/hyrise/tags","blobs_url":"https://api.github.com/repos/hyrise/hyrise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyrise/hyrise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyrise/hyrise/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyrise/hyrise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyrise/hyrise/statuses/{sha}","languages_url":"https://api.github.com/repos/hyrise/hyrise/languages","stargazers_url":"https://api.github.com/repos/hyrise/hyrise/stargazers","contributors_url":"https://api.github.com/repos/hyrise/hyrise/contributors","subscribers_url":"https://api.github.com/repos/hyrise/hyrise/subscribers","subscription_url":"https://api.github.com/repos/hyrise/hyrise/subscription","commits_url":"https://api.github.com/repos/hyrise/hyrise/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyrise/hyrise/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyrise/hyrise/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyrise/hyrise/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyrise/hyrise/contents/{+path}","compare_url":"https://api.github.com/repos/hyrise/hyrise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyrise/hyrise/merges","archive_url":"https://api.github.com/repos/hyrise/hyrise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyrise/hyrise/downloads","issues_url":"https://api.github.com/repos/hyrise/hyrise/issues{/number}","pulls_url":"https://api.github.com/repos/hyrise/hyrise/pulls{/number}","milestones_url":"https://api.github.com/repos/hyrise/hyrise/milestones{/number}","notifications_url":"https://api.github.com/repos/hyrise/hyrise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyrise/hyrise/labels{/name}","releases_url":"https://api.github.com/repos/hyrise/hyrise/releases{/id}","deployments_url":"https://api.github.com/repos/hyrise/hyrise/deployments","created_at":"2017-04-06T10:03:31Z","updated_at":"2018-02-02T09:29:02Z","pushed_at":"2018-02-21T15:02:21Z","git_url":"git://github.com/hyrise/hyrise.git","ssh_url":"git@github.com:hyrise/hyrise.git","clone_url":"https://github.com/hyrise/hyrise.git","svn_url":"https://github.com/hyrise/hyrise","homepage":"https://hpi.de/plattner/projects/hyrise.html","size":11779,"stargazers_count":57,"watchers_count":57,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":74,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/709"},"html":{"href":"https://github.com/hyrise/hyrise/pull/709"},"issue":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/709"},"comments":{"href":"https://api.github.com/repos/hyrise/hyrise/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyrise/hyrise/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/hyrise/hyrise/statuses/0a55dbcd1eacf310a0eb7bd960c8348837b51c3c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfrohnhofen"}}