{"action":"created","issue":{"url":"https://api.github.com/repos/knative/eventing/issues/532","repository_url":"https://api.github.com/repos/knative/eventing","labels_url":"https://api.github.com/repos/knative/eventing/issues/532/labels{/name}","comments_url":"https://api.github.com/repos/knative/eventing/issues/532/comments","events_url":"https://api.github.com/repos/knative/eventing/issues/532/events","html_url":"https://github.com/knative/eventing/pull/532","id":372076358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mzc5Njg2","number":532,"title":"Remove legacy code","user":{"login":"scothis","id":302992,"node_id":"MDQ6VXNlcjMwMjk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/302992?v=4","gravatar_id":"","url":"https://api.github.com/users/scothis","html_url":"https://github.com/scothis","followers_url":"https://api.github.com/users/scothis/followers","following_url":"https://api.github.com/users/scothis/following{/other_user}","gists_url":"https://api.github.com/users/scothis/gists{/gist_id}","starred_url":"https://api.github.com/users/scothis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scothis/subscriptions","organizations_url":"https://api.github.com/users/scothis/orgs","repos_url":"https://api.github.com/users/scothis/repos","events_url":"https://api.github.com/users/scothis/events{/privacy}","received_events_url":"https://api.github.com/users/scothis/received_events","type":"User","site_admin":false},"labels":[{"id":897406231,"node_id":"MDU6TGFiZWw4OTc0MDYyMzE=","url":"https://api.github.com/repos/knative/eventing/labels/approved","name":"approved","color":"ededed","default":false},{"id":1096308746,"node_id":"MDU6TGFiZWwxMDk2MzA4NzQ2","url":"https://api.github.com/repos/knative/eventing/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":961570705,"node_id":"MDU6TGFiZWw5NjE1NzA3MDU=","url":"https://api.github.com/repos/knative/eventing/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"b60205","default":false},{"id":904029784,"node_id":"MDU6TGFiZWw5MDQwMjk3ODQ=","url":"https://api.github.com/repos/knative/eventing/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"vaikas-google","id":11279988,"node_id":"MDQ6VXNlcjExMjc5OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/11279988?v=4","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false},"assignees":[{"login":"vaikas-google","id":11279988,"node_id":"MDQ6VXNlcjExMjc5OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/11279988?v=4","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-10-19T18:54:32Z","updated_at":"2018-10-24T00:04:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/knative/eventing/pulls/532","html_url":"https://github.com/knative/eventing/pull/532","diff_url":"https://github.com/knative/eventing/pull/532.diff","patch_url":"https://github.com/knative/eventing/pull/532.patch"},"body":"## Proposed Changes\r\n\r\nremove API groups:\r\n- channels.knative.dev\r\n- feeds.knative.dev\r\n- flows.knative.dev\r\n\r\nRemove code and dependencies that depended directly on those API groups.\r\nThis includes all Buses and EventSources.\r\n\r\nWhere practical references to Channel and Subscription in\r\nchannels.knative.dev have been updated to eventing.knative.dev.\r\n\r\nThe e2e suite has been decimated and will need to be reestabilished.\r\n\r\nRemoved vendor dependencies for Samara (Kafka) and Cloud Pub/Sub.\r\n\r\nUpdated release script. Now publishes three artifacts:\r\n- eventing.yaml - core of eventing\r\n- in-memory-channel.yaml - in memory channel provisioner\r\n- release.yaml - eventing core + in memory provisioner\r\n\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```release-note\r\nAll existing EventSources and Buses are no longer supported.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/knative/eventing/issues/comments/432464498","html_url":"https://github.com/knative/eventing/pull/532#issuecomment-432464498","issue_url":"https://api.github.com/repos/knative/eventing/issues/532","id":432464498,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ2NDQ5OA==","user":{"login":"vaikas-google","id":11279988,"node_id":"MDQ6VXNlcjExMjc5OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/11279988?v=4","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T00:04:12Z","updated_at":"2018-10-24T00:04:12Z","author_association":"CONTRIBUTOR","body":"+1 I'd like to get to a state where our existing samples (or an agreed upon subset of them) actually work end-to-end with the new stuff and our docs refer to them. I'm very supportive of this PR but want to make sure we have some sort of continuity when moving towards the new object model."}}
{"actor":{"display_login":"vaikas-google"}}