{"action":"created","comment":{"url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments/218008767","pull_request_review_id":155850458,"id":218008767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODAwODc2Nw==","diff_hunk":"@@ -72,19 +72,22 @@ contract ReputationMiningCycle is ReputationMiningCycleStorage, PatriciaTreeProo\n   /// @dev A submission will only be accepted from a reputation miner if `keccak256(address, N, hash) < target`\n   /// At the beginning of the submission window, the target is set to 0 and slowly increases to 2^256 - 1 after an hour\n   modifier withinTarget(bytes32 newHash, uint256 entryIndex) {\n-    require(reputationMiningWindowOpenTimestamp > 0, \"colony-reputation-mining-cycle-not-open\");\n     // Check the ticket is a winning one.\n-    // TODO Figure out how to uncomment the next line, but not break tests sporadically.\n-    // require((now-reputationMiningWindowOpenTimestamp) <= 3600);\n-    // x = floor(uint((2**256 - 1) / 3600)\n-    if (now - reputationMiningWindowOpenTimestamp <= 3600) {\n+    if (!submissionWindowClosed()) {","path":"contracts/ReputationMiningCycle.sol","position":10,"original_position":10,"commit_id":"1d233a05e3f1b87acbaa7f0bc6bb71eedd2b079e","original_commit_id":"1d233a05e3f1b87acbaa7f0bc6bb71eedd2b079e","user":{"login":"elenadimitrova","id":703848,"node_id":"MDQ6VXNlcjcwMzg0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/703848?v=4","gravatar_id":"","url":"https://api.github.com/users/elenadimitrova","html_url":"https://github.com/elenadimitrova","followers_url":"https://api.github.com/users/elenadimitrova/followers","following_url":"https://api.github.com/users/elenadimitrova/following{/other_user}","gists_url":"https://api.github.com/users/elenadimitrova/gists{/gist_id}","starred_url":"https://api.github.com/users/elenadimitrova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenadimitrova/subscriptions","organizations_url":"https://api.github.com/users/elenadimitrova/orgs","repos_url":"https://api.github.com/users/elenadimitrova/repos","events_url":"https://api.github.com/users/elenadimitrova/events{/privacy}","received_events_url":"https://api.github.com/users/elenadimitrova/received_events","type":"User","site_admin":false},"body":"Or keep the window open until either we have 1 submission or time has elapsed, whichever is sooner?","created_at":"2018-09-17T09:53:14Z","updated_at":"2018-09-17T09:53:15Z","html_url":"https://github.com/JoinColony/colonyNetwork/pull/293#discussion_r218008767","pull_request_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments/218008767"},"html":{"href":"https://github.com/JoinColony/colonyNetwork/pull/293#discussion_r218008767"},"pull_request":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293"}},"in_reply_to_id":217632796},"pull_request":{"url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293","id":204640487,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjQwNDg3","html_url":"https://github.com/JoinColony/colonyNetwork/pull/293","diff_url":"https://github.com/JoinColony/colonyNetwork/pull/293.diff","patch_url":"https://github.com/JoinColony/colonyNetwork/pull/293.patch","issue_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/293","number":293,"state":"open","locked":false,"title":"Fix TODOs for reputation mining submission windows","user":{"login":"kronosapiens","id":1874062,"node_id":"MDQ6VXNlcjE4NzQwNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1874062?v=4","gravatar_id":"","url":"https://api.github.com/users/kronosapiens","html_url":"https://github.com/kronosapiens","followers_url":"https://api.github.com/users/kronosapiens/followers","following_url":"https://api.github.com/users/kronosapiens/following{/other_user}","gists_url":"https://api.github.com/users/kronosapiens/gists{/gist_id}","starred_url":"https://api.github.com/users/kronosapiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronosapiens/subscriptions","organizations_url":"https://api.github.com/users/kronosapiens/orgs","repos_url":"https://api.github.com/users/kronosapiens/repos","events_url":"https://api.github.com/users/kronosapiens/events{/privacy}","received_events_url":"https://api.github.com/users/kronosapiens/received_events","type":"User","site_admin":false},"body":"<!--- Related item(s) from the GitHub Issue tracker, closing the completed items via this PR -->\r\nCloses #292 #321 \r\n\r\n<!--- Summary of changes including design decisions -->\r\n\r\n","created_at":"2018-07-29T12:44:25Z","updated_at":"2018-09-17T09:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"448e87e36f87f0403129b47cb4975dddf1946bfe","assignee":{"login":"area","id":311812,"node_id":"MDQ6VXNlcjMxMTgxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/311812?v=4","gravatar_id":"","url":"https://api.github.com/users/area","html_url":"https://github.com/area","followers_url":"https://api.github.com/users/area/followers","following_url":"https://api.github.com/users/area/following{/other_user}","gists_url":"https://api.github.com/users/area/gists{/gist_id}","starred_url":"https://api.github.com/users/area/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/area/subscriptions","organizations_url":"https://api.github.com/users/area/orgs","repos_url":"https://api.github.com/users/area/repos","events_url":"https://api.github.com/users/area/events{/privacy}","received_events_url":"https://api.github.com/users/area/received_events","type":"User","site_admin":false},"assignees":[{"login":"area","id":311812,"node_id":"MDQ6VXNlcjMxMTgxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/311812?v=4","gravatar_id":"","url":"https://api.github.com/users/area","html_url":"https://github.com/area","followers_url":"https://api.github.com/users/area/followers","following_url":"https://api.github.com/users/area/following{/other_user}","gists_url":"https://api.github.com/users/area/gists{/gist_id}","starred_url":"https://api.github.com/users/area/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/area/subscriptions","organizations_url":"https://api.github.com/users/area/orgs","repos_url":"https://api.github.com/users/area/repos","events_url":"https://api.github.com/users/area/events{/privacy}","received_events_url":"https://api.github.com/users/area/received_events","type":"User","site_admin":false},{"login":"kronosapiens","id":1874062,"node_id":"MDQ6VXNlcjE4NzQwNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1874062?v=4","gravatar_id":"","url":"https://api.github.com/users/kronosapiens","html_url":"https://github.com/kronosapiens","followers_url":"https://api.github.com/users/kronosapiens/followers","following_url":"https://api.github.com/users/kronosapiens/following{/other_user}","gists_url":"https://api.github.com/users/kronosapiens/gists{/gist_id}","starred_url":"https://api.github.com/users/kronosapiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronosapiens/subscriptions","organizations_url":"https://api.github.com/users/kronosapiens/orgs","repos_url":"https://api.github.com/users/kronosapiens/repos","events_url":"https://api.github.com/users/kronosapiens/events{/privacy}","received_events_url":"https://api.github.com/users/kronosapiens/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":961061740,"node_id":"MDU6TGFiZWw5NjEwNjE3NDA=","url":"https://api.github.com/repos/JoinColony/colonyNetwork/labels/in-progress","name":"in-progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293/commits","review_comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293/comments","review_comment_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/293/comments","statuses_url":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/1d233a05e3f1b87acbaa7f0bc6bb71eedd2b079e","head":{"label":"JoinColony:bug/292-withintarget-timestamp","ref":"bug/292-withintarget-timestamp","sha":"1d233a05e3f1b87acbaa7f0bc6bb71eedd2b079e","user":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"repo":{"id":89702863,"node_id":"MDEwOlJlcG9zaXRvcnk4OTcwMjg2Mw==","name":"colonyNetwork","full_name":"JoinColony/colonyNetwork","private":false,"owner":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JoinColony/colonyNetwork","description":"Colony Network smart contracts","fork":false,"url":"https://api.github.com/repos/JoinColony/colonyNetwork","forks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/forks","keys_url":"https://api.github.com/repos/JoinColony/colonyNetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinColony/colonyNetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinColony/colonyNetwork/teams","hooks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/hooks","issue_events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/events{/number}","events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/events","assignees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/assignees{/user}","branches_url":"https://api.github.com/repos/JoinColony/colonyNetwork/branches{/branch}","tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/tags","blobs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinColony/colonyNetwork/languages","stargazers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/stargazers","contributors_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contributors","subscribers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscribers","subscription_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscription","commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contents/{+path}","compare_url":"https://api.github.com/repos/JoinColony/colonyNetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinColony/colonyNetwork/merges","archive_url":"https://api.github.com/repos/JoinColony/colonyNetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinColony/colonyNetwork/downloads","issues_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues{/number}","pulls_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinColony/colonyNetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinColony/colonyNetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinColony/colonyNetwork/labels{/name}","releases_url":"https://api.github.com/repos/JoinColony/colonyNetwork/releases{/id}","deployments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/deployments","created_at":"2017-04-28T12:11:32Z","updated_at":"2018-09-17T08:59:51Z","pushed_at":"2018-09-17T09:44:05Z","git_url":"git://github.com/JoinColony/colonyNetwork.git","ssh_url":"git@github.com:JoinColony/colonyNetwork.git","clone_url":"https://github.com/JoinColony/colonyNetwork.git","svn_url":"https://github.com/JoinColony/colonyNetwork","homepage":"https://colony.io/","size":3363,"stargazers_count":251,"watchers_count":251,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":38,"open_issues":85,"watchers":251,"default_branch":"develop"}},"base":{"label":"JoinColony:develop","ref":"develop","sha":"8a94d4dbf1a790ff68325bc29f3561fce54aae3b","user":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"repo":{"id":89702863,"node_id":"MDEwOlJlcG9zaXRvcnk4OTcwMjg2Mw==","name":"colonyNetwork","full_name":"JoinColony/colonyNetwork","private":false,"owner":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JoinColony/colonyNetwork","description":"Colony Network smart contracts","fork":false,"url":"https://api.github.com/repos/JoinColony/colonyNetwork","forks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/forks","keys_url":"https://api.github.com/repos/JoinColony/colonyNetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinColony/colonyNetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinColony/colonyNetwork/teams","hooks_url":"https://api.github.com/repos/JoinColony/colonyNetwork/hooks","issue_events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/events{/number}","events_url":"https://api.github.com/repos/JoinColony/colonyNetwork/events","assignees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/assignees{/user}","branches_url":"https://api.github.com/repos/JoinColony/colonyNetwork/branches{/branch}","tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/tags","blobs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinColony/colonyNetwork/languages","stargazers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/stargazers","contributors_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contributors","subscribers_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscribers","subscription_url":"https://api.github.com/repos/JoinColony/colonyNetwork/subscription","commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinColony/colonyNetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinColony/colonyNetwork/contents/{+path}","compare_url":"https://api.github.com/repos/JoinColony/colonyNetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinColony/colonyNetwork/merges","archive_url":"https://api.github.com/repos/JoinColony/colonyNetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinColony/colonyNetwork/downloads","issues_url":"https://api.github.com/repos/JoinColony/colonyNetwork/issues{/number}","pulls_url":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinColony/colonyNetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinColony/colonyNetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinColony/colonyNetwork/labels{/name}","releases_url":"https://api.github.com/repos/JoinColony/colonyNetwork/releases{/id}","deployments_url":"https://api.github.com/repos/JoinColony/colonyNetwork/deployments","created_at":"2017-04-28T12:11:32Z","updated_at":"2018-09-17T08:59:51Z","pushed_at":"2018-09-17T09:44:05Z","git_url":"git://github.com/JoinColony/colonyNetwork.git","ssh_url":"git@github.com:JoinColony/colonyNetwork.git","clone_url":"https://github.com/JoinColony/colonyNetwork.git","svn_url":"https://github.com/JoinColony/colonyNetwork","homepage":"https://colony.io/","size":3363,"stargazers_count":251,"watchers_count":251,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":38,"open_issues":85,"watchers":251,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293"},"html":{"href":"https://github.com/JoinColony/colonyNetwork/pull/293"},"issue":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/293"},"comments":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/JoinColony/colonyNetwork/statuses/1d233a05e3f1b87acbaa7f0bc6bb71eedd2b079e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elenadimitrova"}}