{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/208888172","pull_request_review_id":144788744,"id":208888172,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg4ODE3Mg==","diff_hunk":"@@ -44,14 +46,49 @@ public DefaultValueAttribute(Type type, string value)\n                 {\n                     _value = TimeSpan.Parse(value);\n                 }\n-                else\n+                else if (type.Module == typeof(string).Module)\n                 {\n                     _value = Convert.ChangeType(value, type, CultureInfo.InvariantCulture);\n                 }\n+                else\n+                {\n+                    _value = ConvertFromInvariantString(type, value);\n+                }\n             }\n             catch\n             {\n             }\n+\n+            object ConvertFromInvariantString(Type typeToConvert, string stringValue)","path":"src/System.Private.CoreLib/shared/System/ComponentModel/DefaultValueAttribute.cs","position":null,"original_position":43,"commit_id":"3909a3c0cc2ab38ae5d5b36568763b9eec26bc6b","original_commit_id":"e2bce7be593e5791367330ad92faef90c46f1875","user":{"login":"MarcoRossignoli","id":7894084,"node_id":"MDQ6VXNlcjc4OTQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-08-09T10:59:36Z","updated_at":"2018-08-09T10:59:36Z","html_url":"https://github.com/dotnet/coreclr/pull/19354#discussion_r208888172","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19354","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/208888172"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19354#discussion_r208888172"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19354"}},"in_reply_to_id":208663459},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19354","id":207014166,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDE0MTY2","html_url":"https://github.com/dotnet/coreclr/pull/19354","diff_url":"https://github.com/dotnet/coreclr/pull/19354.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19354.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19354","number":19354,"state":"open","locked":false,"title":"Add TypeConverter fallback to DefaultValueAttribute","user":{"login":"MarcoRossignoli","id":7894084,"node_id":"MDQ6VXNlcjc4OTQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"body":"contributes to https://github.com/dotnet/corefx/issues/30648\r\n\r\n/cc @ericstj @Anipik @jkotas ","created_at":"2018-08-08T13:48:50Z","updated_at":"2018-08-09T10:59:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66ae27fe00b6e20bd7c11ad1b9e53f292305b664","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19354/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19354/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19354/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/3909a3c0cc2ab38ae5d5b36568763b9eec26bc6b","head":{"label":"MarcoRossignoli:defaultvalueattributetypeconverter","ref":"defaultvalueattributetypeconverter","sha":"3909a3c0cc2ab38ae5d5b36568763b9eec26bc6b","user":{"login":"MarcoRossignoli","id":7894084,"node_id":"MDQ6VXNlcjc4OTQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"repo":{"id":138133310,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMzMzMTA=","name":"coreclr","full_name":"MarcoRossignoli/coreclr","owner":{"login":"MarcoRossignoli","id":7894084,"node_id":"MDQ6VXNlcjc4OTQwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7894084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoRossignoli","html_url":"https://github.com/MarcoRossignoli","followers_url":"https://api.github.com/users/MarcoRossignoli/followers","following_url":"https://api.github.com/users/MarcoRossignoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoRossignoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoRossignoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoRossignoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoRossignoli/orgs","repos_url":"https://api.github.com/users/MarcoRossignoli/repos","events_url":"https://api.github.com/users/MarcoRossignoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoRossignoli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcoRossignoli/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/MarcoRossignoli/coreclr","forks_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/forks","keys_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/teams","hooks_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/hooks","issue_events_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/events","assignees_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/tags","blobs_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/languages","stargazers_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/stargazers","contributors_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/contributors","subscribers_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/subscribers","subscription_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/subscription","commits_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/merges","archive_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/downloads","issues_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/MarcoRossignoli/coreclr/deployments","created_at":"2018-06-21T07:12:41Z","updated_at":"2018-08-08T07:45:25Z","pushed_at":"2018-08-09T10:58:49Z","git_url":"git://github.com/MarcoRossignoli/coreclr.git","ssh_url":"git@github.com:MarcoRossignoli/coreclr.git","clone_url":"https://github.com/MarcoRossignoli/coreclr.git","svn_url":"https://github.com/MarcoRossignoli/coreclr","homepage":"https://github.com/dotnet/core","size":232925,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b4131b9f9dc9c73e47b315fff886db66374b1b21","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-08-09T08:32:24Z","pushed_at":"2018-08-09T10:58:52Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":233396,"stargazers_count":9698,"watchers_count":9698,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2401,"mirror_url":null,"archived":false,"open_issues_count":1770,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2401,"open_issues":1770,"watchers":9698,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19354"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19354"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19354"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19354/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19354/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19354/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/3909a3c0cc2ab38ae5d5b36568763b9eec26bc6b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MarcoRossignoli"}}