{"action":"created","issue":{"url":"https://api.github.com/repos/certbot/certbot/issues/5606","repository_url":"https://api.github.com/repos/certbot/certbot","labels_url":"https://api.github.com/repos/certbot/certbot/issues/5606/labels{/name}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/5606/comments","events_url":"https://api.github.com/repos/certbot/certbot/issues/5606/events","html_url":"https://github.com/certbot/certbot/issues/5606","id":299218023,"number":5606,"title":"fullchain_pem should be set to a string in ClientV2 and BackwardsCompatibleClientV2","user":{"login":"ohemorange","id":1227205,"avatar_url":"https://avatars0.githubusercontent.com/u/1227205?v=4","gravatar_id":"","url":"https://api.github.com/users/ohemorange","html_url":"https://github.com/ohemorange","followers_url":"https://api.github.com/users/ohemorange/followers","following_url":"https://api.github.com/users/ohemorange/following{/other_user}","gists_url":"https://api.github.com/users/ohemorange/gists{/gist_id}","starred_url":"https://api.github.com/users/ohemorange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohemorange/subscriptions","organizations_url":"https://api.github.com/users/ohemorange/orgs","repos_url":"https://api.github.com/users/ohemorange/repos","events_url":"https://api.github.com/users/ohemorange/events{/privacy}","received_events_url":"https://api.github.com/users/ohemorange/received_events","type":"User","site_admin":false},"labels":[{"id":277074172,"url":"https://api.github.com/repos/certbot/certbot/labels/area:%20acme","name":"area: acme","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/certbot/certbot/milestones/48","html_url":"https://github.com/certbot/certbot/milestone/48","labels_url":"https://api.github.com/repos/certbot/certbot/milestones/48/labels","id":2967509,"number":48,"title":"0.22.0","description":"","creator":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":45,"state":"open","created_at":"2017-12-08T18:07:42Z","updated_at":"2018-03-01T23:11:05Z","due_on":"2018-02-07T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-02-22T04:26:42Z","updated_at":"2018-03-01T23:32:10Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Part of #5367.\r\n`fullchain_pem` in the order is bytes; set the `fullchain_pem` property of the order resource to a string"},"comment":{"url":"https://api.github.com/repos/certbot/certbot/issues/comments/369768427","html_url":"https://github.com/certbot/certbot/issues/5606#issuecomment-369768427","issue_url":"https://api.github.com/repos/certbot/certbot/issues/5606","id":369768427,"user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T23:32:10Z","updated_at":"2018-03-01T23:32:10Z","author_association":"CONTRIBUTOR","body":"My very minimal start to this issue is in `bytes-fullchain-bites` which should fix the problem on the `acme` side for ACMEv2. We still need to:\r\n\r\n1. Have the backwards compatible client set `fullchain_pem` to `unicode`/`str` for ACMEv1.\r\n2. Handle this change in Certbot (almost certainly by immediately calling `encode` on `fullchain_pem` for now).\r\n\r\nOnly other note is a function like `acme.crypto_util.dump_pyopenssl_chain` should almost certainly still return `bytes`. Why? If the function supports DER encoding (which that function does), it can't return `unicode`/`str` because that's a binary format that doesn't necessarily contain all Unicode characters. We could change the return type based on the encoding requested, but that seems like a bad idea to me."}}
{"actor":{"display_login":"bmw"}}