{"action":"closed","number":1269,"pull_request":{"url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/1269","id":216822622,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODIyNjIy","html_url":"https://github.com/PrairieLearn/PrairieLearn/pull/1269","diff_url":"https://github.com/PrairieLearn/PrairieLearn/pull/1269.diff","patch_url":"https://github.com/PrairieLearn/PrairieLearn/pull/1269.patch","issue_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/1269","number":1269,"state":"closed","locked":false,"title":"Better client socket handling on externally graded questions","user":{"login":"nwalters512","id":1476544,"node_id":"MDQ6VXNlcjE0NzY1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1476544?v=4","gravatar_id":"","url":"https://api.github.com/users/nwalters512","html_url":"https://github.com/nwalters512","followers_url":"https://api.github.com/users/nwalters512/followers","following_url":"https://api.github.com/users/nwalters512/following{/other_user}","gists_url":"https://api.github.com/users/nwalters512/gists{/gist_id}","starred_url":"https://api.github.com/users/nwalters512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwalters512/subscriptions","organizations_url":"https://api.github.com/users/nwalters512/orgs","repos_url":"https://api.github.com/users/nwalters512/repos","events_url":"https://api.github.com/users/nwalters512/events{/privacy}","received_events_url":"https://api.github.com/users/nwalters512/received_events","type":"User","site_admin":false},"body":"This will close sockets after they're no longer needed, which for us is after the first set of results that we fetch from them. On any given page load, there will be at most one question that needs results fetched, given that we cancel pending jobs when a new one is submitted.\r\n\r\nThis also checks if any submissions on a page will actually need a socket and doesn't open one if everything is either graded or canceled.","created_at":"2018-09-20T01:49:52Z","updated_at":"2018-09-20T19:40:41Z","closed_at":"2018-09-20T19:40:41Z","merged_at":"2018-09-20T19:40:41Z","merge_commit_sha":"cdcf3ec3b4270b328b6307c679d6326d231adf2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/1269/commits","review_comments_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/1269/comments","review_comment_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/1269/comments","statuses_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/statuses/bf410140177048cd94a0500494bbc7118b06ec05","head":{"label":"PrairieLearn:close-websockets-when-done","ref":"close-websockets-when-done","sha":"bf410140177048cd94a0500494bbc7118b06ec05","user":{"login":"PrairieLearn","id":4580042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODAwNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4580042?v=4","gravatar_id":"","url":"https://api.github.com/users/PrairieLearn","html_url":"https://github.com/PrairieLearn","followers_url":"https://api.github.com/users/PrairieLearn/followers","following_url":"https://api.github.com/users/PrairieLearn/following{/other_user}","gists_url":"https://api.github.com/users/PrairieLearn/gists{/gist_id}","starred_url":"https://api.github.com/users/PrairieLearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrairieLearn/subscriptions","organizations_url":"https://api.github.com/users/PrairieLearn/orgs","repos_url":"https://api.github.com/users/PrairieLearn/repos","events_url":"https://api.github.com/users/PrairieLearn/events{/privacy}","received_events_url":"https://api.github.com/users/PrairieLearn/received_events","type":"Organization","site_admin":false},"repo":{"id":20046997,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA0Njk5Nw==","name":"PrairieLearn","full_name":"PrairieLearn/PrairieLearn","private":false,"owner":{"login":"PrairieLearn","id":4580042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODAwNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4580042?v=4","gravatar_id":"","url":"https://api.github.com/users/PrairieLearn","html_url":"https://github.com/PrairieLearn","followers_url":"https://api.github.com/users/PrairieLearn/followers","following_url":"https://api.github.com/users/PrairieLearn/following{/other_user}","gists_url":"https://api.github.com/users/PrairieLearn/gists{/gist_id}","starred_url":"https://api.github.com/users/PrairieLearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrairieLearn/subscriptions","organizations_url":"https://api.github.com/users/PrairieLearn/orgs","repos_url":"https://api.github.com/users/PrairieLearn/repos","events_url":"https://api.github.com/users/PrairieLearn/events{/privacy}","received_events_url":"https://api.github.com/users/PrairieLearn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrairieLearn/PrairieLearn","description":"Online problem-driving learning system","fork":false,"url":"https://api.github.com/repos/PrairieLearn/PrairieLearn","forks_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/forks","keys_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/teams","hooks_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/hooks","issue_events_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/events{/number}","events_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/events","assignees_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/assignees{/user}","branches_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/branches{/branch}","tags_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/tags","blobs_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/statuses/{sha}","languages_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/languages","stargazers_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/stargazers","contributors_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/contributors","subscribers_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/subscribers","subscription_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/subscription","commits_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/contents/{+path}","compare_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/merges","archive_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/downloads","issues_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues{/number}","pulls_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls{/number}","milestones_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/milestones{/number}","notifications_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/labels{/name}","releases_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/releases{/id}","deployments_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/deployments","created_at":"2014-05-22T03:48:56Z","updated_at":"2018-09-19T15:49:22Z","pushed_at":"2018-09-20T19:40:41Z","git_url":"git://github.com/PrairieLearn/PrairieLearn.git","ssh_url":"git@github.com:PrairieLearn/PrairieLearn.git","clone_url":"https://github.com/PrairieLearn/PrairieLearn.git","svn_url":"https://github.com/PrairieLearn/PrairieLearn","homepage":"http://prairielearn.readthedocs.io/","size":41820,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":334,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":51,"open_issues":334,"watchers":52,"default_branch":"master"}},"base":{"label":"PrairieLearn:master","ref":"master","sha":"e240fa2df9ca83c9978f3df8983fac0d405b6427","user":{"login":"PrairieLearn","id":4580042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODAwNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4580042?v=4","gravatar_id":"","url":"https://api.github.com/users/PrairieLearn","html_url":"https://github.com/PrairieLearn","followers_url":"https://api.github.com/users/PrairieLearn/followers","following_url":"https://api.github.com/users/PrairieLearn/following{/other_user}","gists_url":"https://api.github.com/users/PrairieLearn/gists{/gist_id}","starred_url":"https://api.github.com/users/PrairieLearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrairieLearn/subscriptions","organizations_url":"https://api.github.com/users/PrairieLearn/orgs","repos_url":"https://api.github.com/users/PrairieLearn/repos","events_url":"https://api.github.com/users/PrairieLearn/events{/privacy}","received_events_url":"https://api.github.com/users/PrairieLearn/received_events","type":"Organization","site_admin":false},"repo":{"id":20046997,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA0Njk5Nw==","name":"PrairieLearn","full_name":"PrairieLearn/PrairieLearn","private":false,"owner":{"login":"PrairieLearn","id":4580042,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODAwNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4580042?v=4","gravatar_id":"","url":"https://api.github.com/users/PrairieLearn","html_url":"https://github.com/PrairieLearn","followers_url":"https://api.github.com/users/PrairieLearn/followers","following_url":"https://api.github.com/users/PrairieLearn/following{/other_user}","gists_url":"https://api.github.com/users/PrairieLearn/gists{/gist_id}","starred_url":"https://api.github.com/users/PrairieLearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrairieLearn/subscriptions","organizations_url":"https://api.github.com/users/PrairieLearn/orgs","repos_url":"https://api.github.com/users/PrairieLearn/repos","events_url":"https://api.github.com/users/PrairieLearn/events{/privacy}","received_events_url":"https://api.github.com/users/PrairieLearn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrairieLearn/PrairieLearn","description":"Online problem-driving learning system","fork":false,"url":"https://api.github.com/repos/PrairieLearn/PrairieLearn","forks_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/forks","keys_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/teams","hooks_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/hooks","issue_events_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/events{/number}","events_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/events","assignees_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/assignees{/user}","branches_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/branches{/branch}","tags_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/tags","blobs_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/statuses/{sha}","languages_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/languages","stargazers_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/stargazers","contributors_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/contributors","subscribers_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/subscribers","subscription_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/subscription","commits_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/contents/{+path}","compare_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/merges","archive_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/downloads","issues_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues{/number}","pulls_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls{/number}","milestones_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/milestones{/number}","notifications_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/labels{/name}","releases_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/releases{/id}","deployments_url":"https://api.github.com/repos/PrairieLearn/PrairieLearn/deployments","created_at":"2014-05-22T03:48:56Z","updated_at":"2018-09-19T15:49:22Z","pushed_at":"2018-09-20T19:40:41Z","git_url":"git://github.com/PrairieLearn/PrairieLearn.git","ssh_url":"git@github.com:PrairieLearn/PrairieLearn.git","clone_url":"https://github.com/PrairieLearn/PrairieLearn.git","svn_url":"https://github.com/PrairieLearn/PrairieLearn","homepage":"http://prairielearn.readthedocs.io/","size":41820,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":334,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":51,"open_issues":334,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/1269"},"html":{"href":"https://github.com/PrairieLearn/PrairieLearn/pull/1269"},"issue":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/1269"},"comments":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/issues/1269/comments"},"review_comments":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/1269/comments"},"review_comment":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/pulls/1269/commits"},"statuses":{"href":"https://api.github.com/repos/PrairieLearn/PrairieLearn/statuses/bf410140177048cd94a0500494bbc7118b06ec05"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mwest1066","id":875833,"node_id":"MDQ6VXNlcjg3NTgzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/875833?v=4","gravatar_id":"","url":"https://api.github.com/users/mwest1066","html_url":"https://github.com/mwest1066","followers_url":"https://api.github.com/users/mwest1066/followers","following_url":"https://api.github.com/users/mwest1066/following{/other_user}","gists_url":"https://api.github.com/users/mwest1066/gists{/gist_id}","starred_url":"https://api.github.com/users/mwest1066/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwest1066/subscriptions","organizations_url":"https://api.github.com/users/mwest1066/orgs","repos_url":"https://api.github.com/users/mwest1066/repos","events_url":"https://api.github.com/users/mwest1066/events{/privacy}","received_events_url":"https://api.github.com/users/mwest1066/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":28,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"mwest1066"}}