{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-net/issues/996","repository_url":"https://api.github.com/repos/aws/aws-sdk-net","labels_url":"https://api.github.com/repos/aws/aws-sdk-net/issues/996/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-net/issues/996/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-net/issues/996/events","html_url":"https://github.com/aws/aws-sdk-net/pull/996","id":338783394,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjI5NjAy","number":996,"title":"Change Unity Engine Path","user":{"login":"sunchunqiang","id":31852184,"node_id":"MDQ6VXNlcjMxODUyMTg0","avatar_url":"https://avatars3.githubusercontent.com/u/31852184?v=4","gravatar_id":"","url":"https://api.github.com/users/sunchunqiang","html_url":"https://github.com/sunchunqiang","followers_url":"https://api.github.com/users/sunchunqiang/followers","following_url":"https://api.github.com/users/sunchunqiang/following{/other_user}","gists_url":"https://api.github.com/users/sunchunqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/sunchunqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunchunqiang/subscriptions","organizations_url":"https://api.github.com/users/sunchunqiang/orgs","repos_url":"https://api.github.com/users/sunchunqiang/repos","events_url":"https://api.github.com/users/sunchunqiang/events{/privacy}","received_events_url":"https://api.github.com/users/sunchunqiang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-06T02:23:32Z","updated_at":"2018-07-23T17:03:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-net/pulls/996","html_url":"https://github.com/aws/aws-sdk-net/pull/996","diff_url":"https://github.com/aws/aws-sdk-net/pull/996.diff","patch_url":"https://github.com/aws/aws-sdk-net/pull/996.patch"},"body":"…Editor\\Data\\PlaybackEngines\\windowsstandalonesupport\\Managed\\UnityEngine.dll to C:\\Program Files\\Unity\\Editor\\Data\\Managed\\UnityEngine.dll\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n\r\nChange the path of reference UnityEngine in Unity projects from `C:\\Program Files\\Unity\\Editor\\Data\\PlaybackEngines\\windowsstandalonesupport\\Managed\\UnityEngine.dll` to `C:\\Program Files\\Unity\\Editor\\Data\\Managed\\UnityEngine.dll`.\r\n\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\n\r\nWith the latest Unity Editor installed, build of Unity projects failed. Checking C:\\Program Files\\Unity\\Editor\\Data\\PlaybackEngines\\windowsstandalonesupport\\Managed\\UnityEngine .dll  with ildasm, we found that Assembly in the module is empty and  C:\\Program Files\\Unity\\Editor\\Data\\Managed\\UnityEngine.dll contains the correct assembly.\r\n\r\n## Testing\r\n \r\nrun command [msbuild build.proj /t:full-build] under buildtools folder, the path of reference UnityEngine in the Unity projects generated should be C:\\Program Files\\Unity\\Editor\\Data\\Managed\\UnityEngine.dll  and all the Unity projects can be built successfully. \r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project\r\n- [ ] My change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the **README** document\r\n- [ ] I have added tests to cover my changes\r\n- [ ] All new and existing tests passed\r\n\r\n## License\r\n<!--- The SDK is released under the [Apache 2.0 license][license], so any code you submit will be released under that license -->\r\n<!--- For substantial contributions, we may ask you to sign a [Contributor License Agreement (CLA)][cla] -->\r\n<!--- Put an `x` in the below box if you confirm that this request can be released under the Apache 2 license -->\r\n- [x] I confirm that this pull request can be released under the Apache 2 license\r\n\r\n \r\n[issues]: https://github.com/aws/aws-sdk-net/issues\r\n[license]: http://aws.amazon.com/apache2.0/\r\n[cla]: http://en.wikipedia.org/wiki/Contributor_License_Agreement"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-net/issues/comments/407129989","html_url":"https://github.com/aws/aws-sdk-net/pull/996#issuecomment-407129989","issue_url":"https://api.github.com/repos/aws/aws-sdk-net/issues/996","id":407129989,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzEyOTk4OQ==","user":{"login":"sunchunqiang","id":31852184,"node_id":"MDQ6VXNlcjMxODUyMTg0","avatar_url":"https://avatars3.githubusercontent.com/u/31852184?v=4","gravatar_id":"","url":"https://api.github.com/users/sunchunqiang","html_url":"https://github.com/sunchunqiang","followers_url":"https://api.github.com/users/sunchunqiang/followers","following_url":"https://api.github.com/users/sunchunqiang/following{/other_user}","gists_url":"https://api.github.com/users/sunchunqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/sunchunqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunchunqiang/subscriptions","organizations_url":"https://api.github.com/users/sunchunqiang/orgs","repos_url":"https://api.github.com/users/sunchunqiang/repos","events_url":"https://api.github.com/users/sunchunqiang/events{/privacy}","received_events_url":"https://api.github.com/users/sunchunqiang/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T17:03:53Z","updated_at":"2018-07-23T17:03:53Z","author_association":"NONE","body":"Hi Kang,\r\n\r\nI revert the previous change in cs file and added the change to tt file. Please review the change.\r\n\r\n\r\nThanks!\r\n-Sun\r\n\r\nFrom: Steven Kang <notifications@github.com>\r\nSent: Friday, July 20, 2018 9:53 AM\r\nTo: aws/aws-sdk-net <aws-sdk-net@noreply.github.com>\r\nCc: sun, Chunqiang <sdechunq@amazon.com>; Mention <mention@noreply.github.com>\r\nSubject: Re: [aws/aws-sdk-net] Change Unity Engine Path (#996)\r\n\r\n\r\nWe found this at the last minute that the change is in the generated .cs file, not in the .tt. Could you update the PR?\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/aws/aws-sdk-net/pull/996#issuecomment-406660410>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AeYGmH_Yz50E-bh4NlEtsdhVhAu6FGxzks5uIgrPgaJpZM4VEyZV>.\r\n"}}
{"actor":{"display_login":"sunchunqiang"}}