{"push_id":3163398546,"size":16,"distinct_size":16,"ref":"refs/heads/master","head":"dd0659201a89301a22a96395bf81182c4aca40c3","before":"bb7d2741ace20f9fd5255122f27559ee229a9724","commits":[{"sha":"07368ef22e5ef1e49ae2e6ef6a7d1b5da480abad","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: Sender WIP\n\nMade progress towards a `Sender` that allows its users to:\n\n* Create PM sessions\n* Create PM tickets in the context of a specific session, at integrity with session params\n\nHad to commit before finishing everything because in order to best test\nthe `CreateTicket` function I must refactor `AccountManager` such that\nI can stub out the interface.\n\nOnce I get the refactoring done I can test for the ticket signature\nmore easily, as well as add some additional tests.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/07368ef22e5ef1e49ae2e6ef6a7d1b5da480abad"},{"sha":"f514810ad206ee8dc13590ab7cd95b499464ce40","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"ETH: AccountManager refactor to interface\n\nSo we can stub out `AccountManager` in tests. The immediate need is\nfor `pm.Sender`, to test for ticket signing.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/f514810ad206ee8dc13590ab7cd95b499464ce40"},{"sha":"6503be78dd94d056c885c1e00aeb48c113be14d5","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: Sender happy flow test with ticket sig","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/6503be78dd94d056c885c1e00aeb48c113be14d5"},{"sha":"70e978b5470eea358071a827daa43f57664fc611","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"Git: added livepeer binary to gitignore\n\nBecause I think it's convenient to be able to build our binary into the\nmain project folder.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/70e978b5470eea358071a827daa43f57664fc611"},{"sha":"5c1c50bb8950a4047f9442e2719bf663c9f39e13","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: Sender CreateTicket concurrency test","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/5c1c50bb8950a4047f9442e2719bf663c9f39e13"},{"sha":"20945076d70bbb87c1ff5b2679cf2b35d2ba1f2d","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: resolve race condition detector error\n\nThanks to Yondon's discovery of this tool:\nhttps://blog.golang.org/race-detector\n\nI ran the Sender tests with the race check flag `go test -race`, and\ndecided to fix the potential race in one of the stubs to keep things\nclean all around.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/20945076d70bbb87c1ff5b2679cf2b35d2ba1f2d"},{"sha":"91f64834d454c9040db7556ee0523631a3cc0788","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: Sender linter warnings fixes","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/91f64834d454c9040db7556ee0523631a3cc0788"},{"sha":"866ab5e21954609fa55d70ea95d60e48ac5faf53","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: cleanup\n\nRemoved this helper method that was unnecessary thanks to Yondon's\nfeedback.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/866ab5e21954609fa55d70ea95d60e48ac5faf53"},{"sha":"238ec455a43cbaa7e307fe0d4b944d0c9fa2759f","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: cleanup\n\nRemoved unnecessary helper thanks to Yondon's feedback.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/238ec455a43cbaa7e307fe0d4b944d0c9fa2759f"},{"sha":"dc24d3b3a926d681236e6121ce5e4315ddb05f3f","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: test cleanup","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/dc24d3b3a926d681236e6121ce5e4315ddb05f3f"},{"sha":"7c1ec79b28445eb1d80051921d1b1947b1bb9441","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: test cleanup","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/7c1ec79b28445eb1d80051921d1b1947b1bb9441"},{"sha":"5daf7271dc7295ce89b1e9a49447c8d5a4a7025f","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: cleanup","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/5daf7271dc7295ce89b1e9a49447c8d5a4a7025f"},{"sha":"7c44a259afdea3b98689240ab8082727411007db","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: struct renaming\n\nThanks to PR feedback realized that `DefaultAccountManager` did not need\nto be exported, and also clarified that unless we're exporting the\ndefault struct implementation, there's no need for the `default` prefix,\nso dropped that as well for both `accountManager` and `sender`.","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/7c44a259afdea3b98689240ab8082727411007db"},{"sha":"875717219b2437a9380f4f3c018351a8c22ab953","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: added pm folder to test script","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/875717219b2437a9380f4f3c018351a8c22ab953"},{"sha":"cd699ae98c861ff78a0b7ccad80568d3d1b801a0","author":{"name":"eladmallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"PM: added missing go get","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/cd699ae98c861ff78a0b7ccad80568d3d1b801a0"},{"sha":"dd0659201a89301a22a96395bf81182c4aca40c3","author":{"name":"Elad Mallel","email":"a8ffebd0526ddc74952a8c8b83017fa939710a54@gmail.com"},"message":"Merge pull request #651 from livepeer/em/pm-sender\n\nPM Sender","distinct":true,"url":"https://api.github.com/repos/livepeer/go-livepeer/commits/dd0659201a89301a22a96395bf81182c4aca40c3"}]}
{"actor":{"display_login":"eladmallel"}}