{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/216112232","pull_request_review_id":153533711,"id":216112232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjExMjIzMg==","diff_hunk":"@@ -497,7 +497,7 @@ private void ensureWindowsAreASet() {\n       // right, and cast the window type away here.\n       @SuppressWarnings({\"unchecked\", \"rawtypes\"})\n       Coder<Collection<? extends BoundedWindow>> collectionCoder =\n-          (Coder) CollectionCoder.of(this.windowCoder);","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowedValue.java","position":14,"original_position":14,"commit_id":"cf576c08df36cb65793611679ece866dd560635f","original_commit_id":"cf576c08df36cb65793611679ece866dd560635f","user":{"login":"reuvenlax","id":21071061,"node_id":"MDQ6VXNlcjIxMDcxMDYx","avatar_url":"https://avatars1.githubusercontent.com/u/21071061?v=4","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"body":"I believe Dataflow looks at the coder id to determine compatibility (if the coder id has changed, it assumes the update is incompatible).","created_at":"2018-09-08T00:01:49Z","updated_at":"2018-09-08T00:01:49Z","html_url":"https://github.com/apache/beam/pull/6057#discussion_r216112232","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6057","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/216112232"},"html":{"href":"https://github.com/apache/beam/pull/6057#discussion_r216112232"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6057"}},"in_reply_to_id":215113421},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6057","id":203908149,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTA4MTQ5","html_url":"https://github.com/apache/beam/pull/6057","diff_url":"https://github.com/apache/beam/pull/6057.diff","patch_url":"https://github.com/apache/beam/pull/6057.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6057","number":6057,"state":"open","locked":false,"title":"[BEAM-4863] Implement consistentWithEquals/structuralValue on FullWindowedValueCoder","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"body":"Note that I also implemented it on the iterable like coder since it is a dependency of the\r\nFullWindowedValueCoder.\r\n\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-07-25T17:24:49Z","updated_at":"2018-09-08T00:01:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76069492be56fcb9375f0971df2f8022d43e6038","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6057/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6057/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6057/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/cf576c08df36cb65793611679ece866dd560635f","head":{"label":"lukecwik:master","ref":"master","sha":"cf576c08df36cb65793611679ece866dd560635f","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"repo":{"id":52895685,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg5NTY4NQ==","name":"incubator-beam","full_name":"lukecwik/incubator-beam","owner":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukecwik/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/lukecwik/incubator-beam","forks_url":"https://api.github.com/repos/lukecwik/incubator-beam/forks","keys_url":"https://api.github.com/repos/lukecwik/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukecwik/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukecwik/incubator-beam/teams","hooks_url":"https://api.github.com/repos/lukecwik/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/lukecwik/incubator-beam/events","assignees_url":"https://api.github.com/repos/lukecwik/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/lukecwik/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/lukecwik/incubator-beam/tags","blobs_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukecwik/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/lukecwik/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/lukecwik/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/lukecwik/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/lukecwik/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/lukecwik/incubator-beam/subscription","commits_url":"https://api.github.com/repos/lukecwik/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukecwik/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukecwik/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/lukecwik/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukecwik/incubator-beam/merges","archive_url":"https://api.github.com/repos/lukecwik/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukecwik/incubator-beam/downloads","issues_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/lukecwik/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/lukecwik/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/lukecwik/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukecwik/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/lukecwik/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/lukecwik/incubator-beam/deployments","created_at":"2016-03-01T17:24:29Z","updated_at":"2018-07-25T19:58:13Z","pushed_at":"2018-09-06T00:01:00Z","git_url":"git://github.com/lukecwik/incubator-beam.git","ssh_url":"git@github.com:lukecwik/incubator-beam.git","clone_url":"https://github.com/lukecwik/incubator-beam.git","svn_url":"https://github.com/lukecwik/incubator-beam","homepage":null,"size":96349,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"091df9216334880e538583fc50a40614b43e4566","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-09-07T22:27:52Z","pushed_at":"2018-09-07T23:46:14Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":101848,"stargazers_count":2122,"watchers_count":2122,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1316,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1316,"open_issues":91,"watchers":2122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6057"},"html":{"href":"https://github.com/apache/beam/pull/6057"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6057"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6057/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6057/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6057/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/cf576c08df36cb65793611679ece866dd560635f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"reuvenlax"}}