{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/starter-theme/pulls/comments/221704985","pull_request_review_id":160419207,"id":221704985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTcwNDk4NQ==","diff_hunk":"@@ -3,53 +3,105 @@\n {%- assign featured_image = current_variant.featured_image | default: product.featured_image -%}\n \n {% if product == empty %}\n-  {%- assign section_onboarding = true -%}\n-  {%- assign onboarding_title = 'homepage.onboarding.product_title' | t -%}\n+  {%- assign default_product_title = 'homepage.onboarding.product_title' | t -%}\n {% endif %}\n \n-<div data-section-id=\"{{ section.id }}\" data-section-type=\"product\">\n+<section data-section-id=\"{{ section.id }}\" data-section-type=\"product\" class=\"featured-product\">\n \n+  <div class=\"featured-product__image-container\">\n+    {%- unless product.images == empty -%}\n+      {%- for image in product.images -%}\n+        {%- capture wrapper_class -%}\n+          {%- unless featured_image == image -%}\n+            hide\n+          {%- endunless -%}\n+        {%- endcapture -%}\n+        {%- include 'responsive-image' with\n+          image: image,\n+          max_width: 700,\n+          max_height: 800,\n+          image_attributes: \"data-product-featured-image\",\n+          wrapper_class: wrapper_class,\n+          wrapper_attributes: \"data-product-image-wrapper\",\n+        -%}\n+      {%- endfor -%}\n+      {%- if product.images.size > 1 -%}\n+        <ul class=\"featured-product__image-thumbnails\">\n+          {%- for image in product.images -%}\n+            <li>\n+              <a href=\"{{ image.src | img_url: '480x480' }}\" data-thumbnail-id=\"{{ image.id }}\" data-product-single-thumbnail>\n+                <img class=\"product-single__thumbnail-image\" src=\"{{ image.src | img_url: '160x160' }}\" alt=\"{{ image.alt | escape }}\">\n+              </a>\n+            </li>\n+          {%- endfor -%}\n+        </ul>\n+      {%- endif -%}\n+    {%- else -%}\n+      {{ 'product-1' | placeholder_svg_tag: 'placeholder-svg placeholder-svg--small featured-product__image' }}\n+    {%- endunless -%}\n+  </div>\n+\n+  <div class=\"featured-product__content\">\n \n+    <h1>{{ product.title | default: default_product_title }}</h1>\n \n-  {% for image in product.images %}\n-    {% capture wrapper_class %}\n-      {%- unless featured_image == image -%}\n-        hide\n+    <dl {% if current_variant.compare_at_price > current_variant.price %}class=\"price--on-sale\"{% endif %} data-price-wrapper>\n+\n+      {%- unless product.vendor == blank -%}\n+        <dt>\n+          <span class=\"visually-hidden\">{{ 'products.product.vendor' | t }}</span>","path":"src/sections/featured-product.liquid","position":57,"original_position":57,"commit_id":"ac5777927365224e0f46e0e3e148faba4dca9cce","original_commit_id":"270b0636f971b573d7c87b0721bede7eadba856f","user":{"login":"huguestennier","id":6691035,"node_id":"MDQ6VXNlcjY2OTEwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6691035?v=4","gravatar_id":"","url":"https://api.github.com/users/huguestennier","html_url":"https://github.com/huguestennier","followers_url":"https://api.github.com/users/huguestennier/followers","following_url":"https://api.github.com/users/huguestennier/following{/other_user}","gists_url":"https://api.github.com/users/huguestennier/gists{/gist_id}","starred_url":"https://api.github.com/users/huguestennier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguestennier/subscriptions","organizations_url":"https://api.github.com/users/huguestennier/orgs","repos_url":"https://api.github.com/users/huguestennier/repos","events_url":"https://api.github.com/users/huguestennier/events{/privacy}","received_events_url":"https://api.github.com/users/huguestennier/received_events","type":"User","site_admin":false},"body":"Since there's not white space around it, it's not needed","created_at":"2018-10-01T18:10:43Z","updated_at":"2018-10-01T18:10:43Z","html_url":"https://github.com/Shopify/starter-theme/pull/110#discussion_r221704985","pull_request_url":"https://api.github.com/repos/Shopify/starter-theme/pulls/110","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Shopify/starter-theme/pulls/comments/221704985"},"html":{"href":"https://github.com/Shopify/starter-theme/pull/110#discussion_r221704985"},"pull_request":{"href":"https://api.github.com/repos/Shopify/starter-theme/pulls/110"}},"in_reply_to_id":221698189},"pull_request":{"url":"https://api.github.com/repos/Shopify/starter-theme/pulls/110","id":219406578,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDA2NTc4","html_url":"https://github.com/Shopify/starter-theme/pull/110","diff_url":"https://github.com/Shopify/starter-theme/pull/110.diff","patch_url":"https://github.com/Shopify/starter-theme/pull/110.patch","issue_url":"https://api.github.com/repos/Shopify/starter-theme/issues/110","number":110,"state":"open","locked":false,"title":"Update featured product section","user":{"login":"huguestennier","id":6691035,"node_id":"MDQ6VXNlcjY2OTEwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6691035?v=4","gravatar_id":"","url":"https://api.github.com/users/huguestennier","html_url":"https://github.com/huguestennier","followers_url":"https://api.github.com/users/huguestennier/followers","following_url":"https://api.github.com/users/huguestennier/following{/other_user}","gists_url":"https://api.github.com/users/huguestennier/gists{/gist_id}","starred_url":"https://api.github.com/users/huguestennier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguestennier/subscriptions","organizations_url":"https://api.github.com/users/huguestennier/orgs","repos_url":"https://api.github.com/users/huguestennier/repos","events_url":"https://api.github.com/users/huguestennier/events{/privacy}","received_events_url":"https://api.github.com/users/huguestennier/received_events","type":"User","site_admin":false},"body":"Updated the featured product section, especially :\r\n\r\n- Switched price `div` and `vendor` to be combined in a `<dl>` for a11y purposes. There's more semantic and a screen reader would read something like : \r\n> Product title \r\nDefinition list, 3 items\r\nVendor - XXX\r\nRegular price - XX$\r\nSale price - X$\r\n\r\n- Placeholder when no product are selected\r\n- Some nit stuff like controlling whitespace and making sure there's no empty tag anywhere. ","created_at":"2018-10-01T14:55:22Z","updated_at":"2018-10-01T18:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04e1ce8e92cd3511768b317327a1a529eedf19d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrisberthe","id":991693,"node_id":"MDQ6VXNlcjk5MTY5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/991693?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisberthe","html_url":"https://github.com/chrisberthe","followers_url":"https://api.github.com/users/chrisberthe/followers","following_url":"https://api.github.com/users/chrisberthe/following{/other_user}","gists_url":"https://api.github.com/users/chrisberthe/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisberthe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisberthe/subscriptions","organizations_url":"https://api.github.com/users/chrisberthe/orgs","repos_url":"https://api.github.com/users/chrisberthe/repos","events_url":"https://api.github.com/users/chrisberthe/events{/privacy}","received_events_url":"https://api.github.com/users/chrisberthe/received_events","type":"User","site_admin":false},{"login":"t-kelly","id":4837696,"node_id":"MDQ6VXNlcjQ4Mzc2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4837696?v=4","gravatar_id":"","url":"https://api.github.com/users/t-kelly","html_url":"https://github.com/t-kelly","followers_url":"https://api.github.com/users/t-kelly/followers","following_url":"https://api.github.com/users/t-kelly/following{/other_user}","gists_url":"https://api.github.com/users/t-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/t-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-kelly/subscriptions","organizations_url":"https://api.github.com/users/t-kelly/orgs","repos_url":"https://api.github.com/users/t-kelly/repos","events_url":"https://api.github.com/users/t-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/t-kelly/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/starter-theme/pulls/110/commits","review_comments_url":"https://api.github.com/repos/Shopify/starter-theme/pulls/110/comments","review_comment_url":"https://api.github.com/repos/Shopify/starter-theme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/starter-theme/issues/110/comments","statuses_url":"https://api.github.com/repos/Shopify/starter-theme/statuses/ac5777927365224e0f46e0e3e148faba4dca9cce","head":{"label":"Shopify:add-featured-product","ref":"add-featured-product","sha":"ac5777927365224e0f46e0e3e148faba4dca9cce","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":110152877,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxNTI4Nzc=","name":"starter-theme","full_name":"Shopify/starter-theme","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/starter-theme","description":"The Shopify Themes Team opinionated starting point for new a Slate project","fork":false,"url":"https://api.github.com/repos/Shopify/starter-theme","forks_url":"https://api.github.com/repos/Shopify/starter-theme/forks","keys_url":"https://api.github.com/repos/Shopify/starter-theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/starter-theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/starter-theme/teams","hooks_url":"https://api.github.com/repos/Shopify/starter-theme/hooks","issue_events_url":"https://api.github.com/repos/Shopify/starter-theme/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/starter-theme/events","assignees_url":"https://api.github.com/repos/Shopify/starter-theme/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/starter-theme/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/starter-theme/tags","blobs_url":"https://api.github.com/repos/Shopify/starter-theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/starter-theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/starter-theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/starter-theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/starter-theme/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/starter-theme/languages","stargazers_url":"https://api.github.com/repos/Shopify/starter-theme/stargazers","contributors_url":"https://api.github.com/repos/Shopify/starter-theme/contributors","subscribers_url":"https://api.github.com/repos/Shopify/starter-theme/subscribers","subscription_url":"https://api.github.com/repos/Shopify/starter-theme/subscription","commits_url":"https://api.github.com/repos/Shopify/starter-theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/starter-theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/starter-theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/starter-theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/starter-theme/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/starter-theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/starter-theme/merges","archive_url":"https://api.github.com/repos/Shopify/starter-theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/starter-theme/downloads","issues_url":"https://api.github.com/repos/Shopify/starter-theme/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/starter-theme/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/starter-theme/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/starter-theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/starter-theme/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/starter-theme/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/starter-theme/deployments","created_at":"2017-11-09T18:42:22Z","updated_at":"2018-10-01T18:07:55Z","pushed_at":"2018-10-01T18:08:29Z","git_url":"git://github.com/Shopify/starter-theme.git","ssh_url":"git@github.com:Shopify/starter-theme.git","clone_url":"https://github.com/Shopify/starter-theme.git","svn_url":"https://github.com/Shopify/starter-theme","homepage":"","size":650,"stargazers_count":87,"watchers_count":87,"language":"Liquid","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":10,"watchers":87,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"07fc4fb3379220f27db9a4612c3d7c262f580d3e","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":110152877,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxNTI4Nzc=","name":"starter-theme","full_name":"Shopify/starter-theme","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/starter-theme","description":"The Shopify Themes Team opinionated starting point for new a Slate project","fork":false,"url":"https://api.github.com/repos/Shopify/starter-theme","forks_url":"https://api.github.com/repos/Shopify/starter-theme/forks","keys_url":"https://api.github.com/repos/Shopify/starter-theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/starter-theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/starter-theme/teams","hooks_url":"https://api.github.com/repos/Shopify/starter-theme/hooks","issue_events_url":"https://api.github.com/repos/Shopify/starter-theme/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/starter-theme/events","assignees_url":"https://api.github.com/repos/Shopify/starter-theme/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/starter-theme/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/starter-theme/tags","blobs_url":"https://api.github.com/repos/Shopify/starter-theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/starter-theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/starter-theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/starter-theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/starter-theme/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/starter-theme/languages","stargazers_url":"https://api.github.com/repos/Shopify/starter-theme/stargazers","contributors_url":"https://api.github.com/repos/Shopify/starter-theme/contributors","subscribers_url":"https://api.github.com/repos/Shopify/starter-theme/subscribers","subscription_url":"https://api.github.com/repos/Shopify/starter-theme/subscription","commits_url":"https://api.github.com/repos/Shopify/starter-theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/starter-theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/starter-theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/starter-theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/starter-theme/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/starter-theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/starter-theme/merges","archive_url":"https://api.github.com/repos/Shopify/starter-theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/starter-theme/downloads","issues_url":"https://api.github.com/repos/Shopify/starter-theme/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/starter-theme/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/starter-theme/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/starter-theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/starter-theme/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/starter-theme/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/starter-theme/deployments","created_at":"2017-11-09T18:42:22Z","updated_at":"2018-10-01T18:07:55Z","pushed_at":"2018-10-01T18:08:29Z","git_url":"git://github.com/Shopify/starter-theme.git","ssh_url":"git@github.com:Shopify/starter-theme.git","clone_url":"https://github.com/Shopify/starter-theme.git","svn_url":"https://github.com/Shopify/starter-theme","homepage":"","size":650,"stargazers_count":87,"watchers_count":87,"language":"Liquid","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":10,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/starter-theme/pulls/110"},"html":{"href":"https://github.com/Shopify/starter-theme/pull/110"},"issue":{"href":"https://api.github.com/repos/Shopify/starter-theme/issues/110"},"comments":{"href":"https://api.github.com/repos/Shopify/starter-theme/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/starter-theme/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/starter-theme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/starter-theme/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/starter-theme/statuses/ac5777927365224e0f46e0e3e148faba4dca9cce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"huguestennier"}}