{"action":"created","comment":{"url":"https://api.github.com/repos/rails/globalid/pulls/comments/209432591","pull_request_review_id":145452231,"id":209432591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQzMjU5MQ==","diff_hunk":"@@ -30,6 +32,9 @@ def pick_purpose(options)\n \n     private\n       def verify(sgid, options)\n+        gid = pick_verifier(options).verify(sgid, purpose: pick_purpose(options))","path":"lib/global_id/signed_global_id.rb","position":13,"original_position":13,"commit_id":"31e8b33321ce69ed0e7c22d6eceb1331f4124f2d","original_commit_id":"31e8b33321ce69ed0e7c22d6eceb1331f4124f2d","user":{"login":"kaspth","id":350807,"node_id":"MDQ6VXNlcjM1MDgwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/350807?v=4","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"body":"How about clarifying the flow and its purpose?\r\n\r\n```ruby\r\nverify_with_verifier_validated_metadata(sgid, options) || verify_with_self_validated_metadata(sgid, options)\r\n```","created_at":"2018-08-11T17:25:18Z","updated_at":"2018-08-11T17:25:20Z","html_url":"https://github.com/rails/globalid/pull/107#discussion_r209432591","pull_request_url":"https://api.github.com/repos/rails/globalid/pulls/107","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rails/globalid/pulls/comments/209432591"},"html":{"href":"https://github.com/rails/globalid/pull/107#discussion_r209432591"},"pull_request":{"href":"https://api.github.com/repos/rails/globalid/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/rails/globalid/pulls/107","id":207760146,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzYwMTQ2","html_url":"https://github.com/rails/globalid/pull/107","diff_url":"https://github.com/rails/globalid/pull/107.diff","patch_url":"https://github.com/rails/globalid/pull/107.patch","issue_url":"https://api.github.com/repos/rails/globalid/issues/107","number":107,"state":"open","locked":false,"title":"Use ActiveSupport::MessageVerifier's expiry and purpose feature in SignedGlobalID","user":{"login":"assain","id":10774488,"node_id":"MDQ6VXNlcjEwNzc0NDg4","avatar_url":"https://avatars2.githubusercontent.com/u/10774488?v=4","gravatar_id":"","url":"https://api.github.com/users/assain","html_url":"https://github.com/assain","followers_url":"https://api.github.com/users/assain/followers","following_url":"https://api.github.com/users/assain/following{/other_user}","gists_url":"https://api.github.com/users/assain/gists{/gist_id}","starred_url":"https://api.github.com/users/assain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assain/subscriptions","organizations_url":"https://api.github.com/users/assain/orgs","repos_url":"https://api.github.com/users/assain/repos","events_url":"https://api.github.com/users/assain/events{/privacy}","received_events_url":"https://api.github.com/users/assain/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-11T06:06:19Z","updated_at":"2018-08-11T17:25:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86cfe714a5b8cb0cde946093272508ee3972fae8","assignee":{"login":"jeremy","id":199,"node_id":"MDQ6VXNlcjE5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/199?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeremy","id":199,"node_id":"MDQ6VXNlcjE5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/199?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremy","html_url":"https://github.com/jeremy","followers_url":"https://api.github.com/users/jeremy/followers","following_url":"https://api.github.com/users/jeremy/following{/other_user}","gists_url":"https://api.github.com/users/jeremy/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremy/subscriptions","organizations_url":"https://api.github.com/users/jeremy/orgs","repos_url":"https://api.github.com/users/jeremy/repos","events_url":"https://api.github.com/users/jeremy/events{/privacy}","received_events_url":"https://api.github.com/users/jeremy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/globalid/pulls/107/commits","review_comments_url":"https://api.github.com/repos/rails/globalid/pulls/107/comments","review_comment_url":"https://api.github.com/repos/rails/globalid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/globalid/issues/107/comments","statuses_url":"https://api.github.com/repos/rails/globalid/statuses/31e8b33321ce69ed0e7c22d6eceb1331f4124f2d","head":{"label":"assain:use-expiry-and-purpose-feature-in-verifier","ref":"use-expiry-and-purpose-feature-in-verifier","sha":"31e8b33321ce69ed0e7c22d6eceb1331f4124f2d","user":{"login":"assain","id":10774488,"node_id":"MDQ6VXNlcjEwNzc0NDg4","avatar_url":"https://avatars2.githubusercontent.com/u/10774488?v=4","gravatar_id":"","url":"https://api.github.com/users/assain","html_url":"https://github.com/assain","followers_url":"https://api.github.com/users/assain/followers","following_url":"https://api.github.com/users/assain/following{/other_user}","gists_url":"https://api.github.com/users/assain/gists{/gist_id}","starred_url":"https://api.github.com/users/assain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assain/subscriptions","organizations_url":"https://api.github.com/users/assain/orgs","repos_url":"https://api.github.com/users/assain/repos","events_url":"https://api.github.com/users/assain/events{/privacy}","received_events_url":"https://api.github.com/users/assain/received_events","type":"User","site_admin":false},"repo":{"id":140066518,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwNjY1MTg=","name":"globalid","full_name":"assain/globalid","owner":{"login":"assain","id":10774488,"node_id":"MDQ6VXNlcjEwNzc0NDg4","avatar_url":"https://avatars2.githubusercontent.com/u/10774488?v=4","gravatar_id":"","url":"https://api.github.com/users/assain","html_url":"https://github.com/assain","followers_url":"https://api.github.com/users/assain/followers","following_url":"https://api.github.com/users/assain/following{/other_user}","gists_url":"https://api.github.com/users/assain/gists{/gist_id}","starred_url":"https://api.github.com/users/assain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assain/subscriptions","organizations_url":"https://api.github.com/users/assain/orgs","repos_url":"https://api.github.com/users/assain/repos","events_url":"https://api.github.com/users/assain/events{/privacy}","received_events_url":"https://api.github.com/users/assain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/assain/globalid","description":"Identify app models with a URI","fork":true,"url":"https://api.github.com/repos/assain/globalid","forks_url":"https://api.github.com/repos/assain/globalid/forks","keys_url":"https://api.github.com/repos/assain/globalid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assain/globalid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assain/globalid/teams","hooks_url":"https://api.github.com/repos/assain/globalid/hooks","issue_events_url":"https://api.github.com/repos/assain/globalid/issues/events{/number}","events_url":"https://api.github.com/repos/assain/globalid/events","assignees_url":"https://api.github.com/repos/assain/globalid/assignees{/user}","branches_url":"https://api.github.com/repos/assain/globalid/branches{/branch}","tags_url":"https://api.github.com/repos/assain/globalid/tags","blobs_url":"https://api.github.com/repos/assain/globalid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assain/globalid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assain/globalid/git/refs{/sha}","trees_url":"https://api.github.com/repos/assain/globalid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assain/globalid/statuses/{sha}","languages_url":"https://api.github.com/repos/assain/globalid/languages","stargazers_url":"https://api.github.com/repos/assain/globalid/stargazers","contributors_url":"https://api.github.com/repos/assain/globalid/contributors","subscribers_url":"https://api.github.com/repos/assain/globalid/subscribers","subscription_url":"https://api.github.com/repos/assain/globalid/subscription","commits_url":"https://api.github.com/repos/assain/globalid/commits{/sha}","git_commits_url":"https://api.github.com/repos/assain/globalid/git/commits{/sha}","comments_url":"https://api.github.com/repos/assain/globalid/comments{/number}","issue_comment_url":"https://api.github.com/repos/assain/globalid/issues/comments{/number}","contents_url":"https://api.github.com/repos/assain/globalid/contents/{+path}","compare_url":"https://api.github.com/repos/assain/globalid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assain/globalid/merges","archive_url":"https://api.github.com/repos/assain/globalid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assain/globalid/downloads","issues_url":"https://api.github.com/repos/assain/globalid/issues{/number}","pulls_url":"https://api.github.com/repos/assain/globalid/pulls{/number}","milestones_url":"https://api.github.com/repos/assain/globalid/milestones{/number}","notifications_url":"https://api.github.com/repos/assain/globalid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assain/globalid/labels{/name}","releases_url":"https://api.github.com/repos/assain/globalid/releases{/id}","deployments_url":"https://api.github.com/repos/assain/globalid/deployments","created_at":"2018-07-07T08:25:30Z","updated_at":"2018-07-07T08:25:32Z","pushed_at":"2018-08-11T14:52:10Z","git_url":"git://github.com/assain/globalid.git","ssh_url":"git@github.com:assain/globalid.git","clone_url":"https://github.com/assain/globalid.git","svn_url":"https://github.com/assain/globalid","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"5bfe23a8ab3ab49c9050bc3ad0668f5c01492cf6","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":22991474,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk5MTQ3NA==","name":"globalid","full_name":"rails/globalid","owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/globalid","description":"Identify app models with a URI","fork":false,"url":"https://api.github.com/repos/rails/globalid","forks_url":"https://api.github.com/repos/rails/globalid/forks","keys_url":"https://api.github.com/repos/rails/globalid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/globalid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/globalid/teams","hooks_url":"https://api.github.com/repos/rails/globalid/hooks","issue_events_url":"https://api.github.com/repos/rails/globalid/issues/events{/number}","events_url":"https://api.github.com/repos/rails/globalid/events","assignees_url":"https://api.github.com/repos/rails/globalid/assignees{/user}","branches_url":"https://api.github.com/repos/rails/globalid/branches{/branch}","tags_url":"https://api.github.com/repos/rails/globalid/tags","blobs_url":"https://api.github.com/repos/rails/globalid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/globalid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/globalid/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/globalid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/globalid/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/globalid/languages","stargazers_url":"https://api.github.com/repos/rails/globalid/stargazers","contributors_url":"https://api.github.com/repos/rails/globalid/contributors","subscribers_url":"https://api.github.com/repos/rails/globalid/subscribers","subscription_url":"https://api.github.com/repos/rails/globalid/subscription","commits_url":"https://api.github.com/repos/rails/globalid/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/globalid/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/globalid/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/globalid/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/globalid/contents/{+path}","compare_url":"https://api.github.com/repos/rails/globalid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/globalid/merges","archive_url":"https://api.github.com/repos/rails/globalid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/globalid/downloads","issues_url":"https://api.github.com/repos/rails/globalid/issues{/number}","pulls_url":"https://api.github.com/repos/rails/globalid/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/globalid/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/globalid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/globalid/labels{/name}","releases_url":"https://api.github.com/repos/rails/globalid/releases{/id}","deployments_url":"https://api.github.com/repos/rails/globalid/deployments","created_at":"2014-08-15T14:05:35Z","updated_at":"2018-07-31T14:20:22Z","pushed_at":"2018-08-11T14:52:11Z","git_url":"git://github.com/rails/globalid.git","ssh_url":"git@github.com:rails/globalid.git","clone_url":"https://github.com/rails/globalid.git","svn_url":"https://github.com/rails/globalid","homepage":null,"size":172,"stargazers_count":614,"watchers_count":614,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":68,"open_issues":4,"watchers":614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/globalid/pulls/107"},"html":{"href":"https://github.com/rails/globalid/pull/107"},"issue":{"href":"https://api.github.com/repos/rails/globalid/issues/107"},"comments":{"href":"https://api.github.com/repos/rails/globalid/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/globalid/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/globalid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/globalid/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/rails/globalid/statuses/31e8b33321ce69ed0e7c22d6eceb1331f4124f2d"}},"author_association":"NONE"}}
{"actor":{"display_login":"kaspth"}}