{"action":"closed","issue":{"url":"https://api.github.com/repos/frappe/erpnext/issues/15019","repository_url":"https://api.github.com/repos/frappe/erpnext","labels_url":"https://api.github.com/repos/frappe/erpnext/issues/15019/labels{/name}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/15019/comments","events_url":"https://api.github.com/repos/frappe/erpnext/issues/15019/events","html_url":"https://github.com/frappe/erpnext/issues/15019","id":344896600,"node_id":"MDU6SXNzdWUzNDQ4OTY2MDA=","number":15019,"title":"GST multiple tax rate error on beta.erpnext","user":{"login":"test2a","id":39449563,"node_id":"MDQ6VXNlcjM5NDQ5NTYz","avatar_url":"https://avatars2.githubusercontent.com/u/39449563?v=4","gravatar_id":"","url":"https://api.github.com/users/test2a","html_url":"https://github.com/test2a","followers_url":"https://api.github.com/users/test2a/followers","following_url":"https://api.github.com/users/test2a/following{/other_user}","gists_url":"https://api.github.com/users/test2a/gists{/gist_id}","starred_url":"https://api.github.com/users/test2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test2a/subscriptions","organizations_url":"https://api.github.com/users/test2a/orgs","repos_url":"https://api.github.com/users/test2a/repos","events_url":"https://api.github.com/users/test2a/events{/privacy}","received_events_url":"https://api.github.com/users/test2a/received_events","type":"User","site_admin":false},"labels":[{"id":467539099,"node_id":"MDU6TGFiZWw0Njc1MzkwOTk=","url":"https://api.github.com/repos/frappe/erpnext/labels/accounts","name":"accounts","color":"fbca04","default":false},{"id":593924275,"node_id":"MDU6TGFiZWw1OTM5MjQyNzU=","url":"https://api.github.com/repos/frappe/erpnext/labels/localization","name":"localization","color":"1d76db","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-26T15:35:45Z","updated_at":"2018-10-19T08:13:21Z","closed_at":"2018-10-19T08:13:21Z","author_association":"NONE","body":"![gstr1 error](https://user-images.githubusercontent.com/39449563/43271932-6eefe958-9116-11e8-9b21-d41725e2ad10.png)\r\n\r\nHello.\r\nI have been trying to test erpnext and beta being on V.11 is a good test area. I started by creating two items, \"goods @ 18%\" and \"goods @ 5%\" for whom i set tax rate at respective cgst 2.5% and cgst 9%. I created a new purchase invoice where i added the goods but it did not correctly recognise tax slab in the items and for the invoice it selected 9% cgst and sgst. \r\nAlso, submitting the invoice did not finish and it throwed the following error\r\n\r\n\r\n\"Traceback (most recent call last):\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py\", line 19, in savedocs\r\n    doc.submit()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 841, in submit\r\n    self._submit()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 830, in _submit\r\n    self.save()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 260, in save\r\n    return self._save(*args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 311, in _save\r\n    self.run_post_save_methods()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 901, in run_post_save_methods\r\n    self.run_method(\"on_submit\")\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 765, in run_method\r\n    out = Document.hook(fn)(self, *args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 1040, in composer\r\n    return composed(self, method, *args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 1023, in runner\r\n    add_to_return_value(self, fn(self, *args, **kwargs))\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 759, in <lambda>\r\n    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 318, in on_submit\r\n    self.make_gl_entries()\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 327, in make_gl_entries\r\n    gl_entries = self.get_gl_entries()\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 355, in get_gl_entries\r\n    self.make_item_gl_entries(gl_entries)\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 391, in make_item_gl_entries\r\n    warehouse_account = get_warehouse_account_map()\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/stock/__init__.py\", line 22, in get_warehouse_account_map\r\n    d.account = get_warehouse_account(d, warehouse_account)\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/stock/__init__.py\", line 36, in get_warehouse_account\r\n    account = warehouse_account.get(warehouse.parent_warehouse).account\r\nAttributeError: 'NoneType' object has no attribute 'account'\r\n\r\nTraceback (most recent call last):\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/app.py\", line 62, in application\r\n    response = frappe.handler.handle()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/handler.py\", line 22, in handle\r\n    data = execute_cmd(cmd)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/handler.py\", line 55, in execute_cmd\r\n    return frappe.call(method, **frappe.form_dict)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py\", line 942, in call\r\n    return fn(*args, **newargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py\", line 19, in savedocs\r\n    doc.submit()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 841, in submit\r\n    self._submit()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 830, in _submit\r\n    self.save()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 260, in save\r\n    return self._save(*args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 311, in _save\r\n    self.run_post_save_methods()\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 901, in run_post_save_methods\r\n    self.run_method(\"on_submit\")\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 765, in run_method\r\n    out = Document.hook(fn)(self, *args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 1040, in composer\r\n    return composed(self, method, *args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 1023, in runner\r\n    add_to_return_value(self, fn(self, *args, **kwargs))\r\n  File \"/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py\", line 759, in <lambda>\r\n    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 318, in on_submit\r\n    self.make_gl_entries()\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 327, in make_gl_entries\r\n    gl_entries = self.get_gl_entries()\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 355, in get_gl_entries\r\n    self.make_item_gl_entries(gl_entries)\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py\", line 391, in make_item_gl_entries\r\n    warehouse_account = get_warehouse_account_map()\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/stock/__init__.py\", line 22, in get_warehouse_account_map\r\n    d.account = get_warehouse_account(d, warehouse_account)\r\n  File \"/home/frappe/frappe-bench/apps/erpnext/erpnext/stock/__init__.py\", line 36, in get_warehouse_account\r\n    account = warehouse_account.get(warehouse.parent_warehouse).account\r\nAttributeError: 'NoneType' object has no attribute 'account'\""}}
{"actor":{"display_login":"PawanMeh"}}