{"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/181033465","pull_request_review_id":111561576,"id":181033465,"diff_hunk":"@@ -130,6 +131,14 @@ export async function setVersion(\n     return () => Promise.resolve();\n   }\n \n+  function buildCommitArgs(args): Array<string> {","path":"src/cli/commands/version.js","position":12,"original_position":12,"commit_id":"d388277e09af2df1a9b3b9e559924b414638b898","original_commit_id":"d388277e09af2df1a9b3b9e559924b414638b898","user":{"login":"BYK","id":126780,"avatar_url":"https://avatars3.githubusercontent.com/u/126780?v=4","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"body":"I don't think abstracting this into a separate function adds much value unless you use it in a unit test.","created_at":"2018-04-12T10:22:33Z","updated_at":"2018-04-12T10:27:46Z","html_url":"https://github.com/yarnpkg/yarn/pull/5640#discussion_r181033465","pull_request_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/181033465"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5640#discussion_r181033465"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640"}}},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640","id":180731549,"html_url":"https://github.com/yarnpkg/yarn/pull/5640","diff_url":"https://github.com/yarnpkg/yarn/pull/5640.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/5640.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5640","number":5640,"state":"open","locked":false,"title":"Ability to disable commit hooks on versioning","user":{"login":"faazshift","id":3336936,"avatar_url":"https://avatars2.githubusercontent.com/u/3336936?v=4","gravatar_id":"","url":"https://api.github.com/users/faazshift","html_url":"https://github.com/faazshift","followers_url":"https://api.github.com/users/faazshift/followers","following_url":"https://api.github.com/users/faazshift/following{/other_user}","gists_url":"https://api.github.com/users/faazshift/gists{/gist_id}","starred_url":"https://api.github.com/users/faazshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faazshift/subscriptions","organizations_url":"https://api.github.com/users/faazshift/orgs","repos_url":"https://api.github.com/users/faazshift/repos","events_url":"https://api.github.com/users/faazshift/events{/privacy}","received_events_url":"https://api.github.com/users/faazshift/received_events","type":"User","site_admin":false},"body":"**Summary**\r\n\r\nLast year I contributed the ability to disable commit hooks when versioning with npm (See [this commit](https://github.com/npm/npm/commit/2dec601c6d5a576751d50efbcf76eaef4deff31e#diff-2992be03e25e9f38300b7ce175e4f4e1)). It makes sense to add the same functionality to yarn.\r\n\r\nThe original motivation for this feature is based on a pre-commit hook that included linting and testing a large code base, taking ~20 seconds to run. When that hook is run on the preceding commits, it's unnecessary and time-taking to do so on versioning. Because of that, it's nice to have the option to disable that git hook.\r\n\r\n**Test plan**\r\n\r\nNo UI differences, but I tested a variety of cases. With default configuration and no extra CLI flags, commit hooks are run, as expected. With either `version-commit-hooks false` in `.yarnrc` or `--no-commit-hooks` on the command line, git hooks don't run, as expected with this feature.\r\n\r\nI would be happy to add Jest tests for this if desired.","created_at":"2018-04-10T21:23:38Z","updated_at":"2018-04-12T10:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4096dbeb9742205749cd08eee00cf1f6d574208b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5640/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/d388277e09af2df1a9b3b9e559924b414638b898","head":{"label":"faazshift:commit-hook-control","ref":"commit-hook-control","sha":"d388277e09af2df1a9b3b9e559924b414638b898","user":{"login":"faazshift","id":3336936,"avatar_url":"https://avatars2.githubusercontent.com/u/3336936?v=4","gravatar_id":"","url":"https://api.github.com/users/faazshift","html_url":"https://github.com/faazshift","followers_url":"https://api.github.com/users/faazshift/followers","following_url":"https://api.github.com/users/faazshift/following{/other_user}","gists_url":"https://api.github.com/users/faazshift/gists{/gist_id}","starred_url":"https://api.github.com/users/faazshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faazshift/subscriptions","organizations_url":"https://api.github.com/users/faazshift/orgs","repos_url":"https://api.github.com/users/faazshift/repos","events_url":"https://api.github.com/users/faazshift/events{/privacy}","received_events_url":"https://api.github.com/users/faazshift/received_events","type":"User","site_admin":false},"repo":{"id":128290631,"name":"yarn","full_name":"faazshift/yarn","owner":{"login":"faazshift","id":3336936,"avatar_url":"https://avatars2.githubusercontent.com/u/3336936?v=4","gravatar_id":"","url":"https://api.github.com/users/faazshift","html_url":"https://github.com/faazshift","followers_url":"https://api.github.com/users/faazshift/followers","following_url":"https://api.github.com/users/faazshift/following{/other_user}","gists_url":"https://api.github.com/users/faazshift/gists{/gist_id}","starred_url":"https://api.github.com/users/faazshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faazshift/subscriptions","organizations_url":"https://api.github.com/users/faazshift/orgs","repos_url":"https://api.github.com/users/faazshift/repos","events_url":"https://api.github.com/users/faazshift/events{/privacy}","received_events_url":"https://api.github.com/users/faazshift/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faazshift/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/faazshift/yarn","forks_url":"https://api.github.com/repos/faazshift/yarn/forks","keys_url":"https://api.github.com/repos/faazshift/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faazshift/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faazshift/yarn/teams","hooks_url":"https://api.github.com/repos/faazshift/yarn/hooks","issue_events_url":"https://api.github.com/repos/faazshift/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/faazshift/yarn/events","assignees_url":"https://api.github.com/repos/faazshift/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/faazshift/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/faazshift/yarn/tags","blobs_url":"https://api.github.com/repos/faazshift/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faazshift/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faazshift/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/faazshift/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faazshift/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/faazshift/yarn/languages","stargazers_url":"https://api.github.com/repos/faazshift/yarn/stargazers","contributors_url":"https://api.github.com/repos/faazshift/yarn/contributors","subscribers_url":"https://api.github.com/repos/faazshift/yarn/subscribers","subscription_url":"https://api.github.com/repos/faazshift/yarn/subscription","commits_url":"https://api.github.com/repos/faazshift/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/faazshift/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/faazshift/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/faazshift/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/faazshift/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/faazshift/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faazshift/yarn/merges","archive_url":"https://api.github.com/repos/faazshift/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faazshift/yarn/downloads","issues_url":"https://api.github.com/repos/faazshift/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/faazshift/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/faazshift/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/faazshift/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faazshift/yarn/labels{/name}","releases_url":"https://api.github.com/repos/faazshift/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/faazshift/yarn/deployments","created_at":"2018-04-06T02:44:04Z","updated_at":"2018-04-06T02:44:10Z","pushed_at":"2018-04-10T20:22:37Z","git_url":"git://github.com/faazshift/yarn.git","ssh_url":"git@github.com:faazshift/yarn.git","clone_url":"https://github.com/faazshift/yarn.git","svn_url":"https://github.com/faazshift/yarn","homepage":"https://yarnpkg.com","size":115328,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"077313467855c5a913f96c36cd2070878917c0ad","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2018-04-12T10:17:33Z","pushed_at":"2018-04-12T10:18:14Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":115462,"stargazers_count":31136,"watchers_count":31136,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1720,"mirror_url":null,"archived":false,"open_issues_count":1109,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1720,"open_issues":1109,"watchers":31136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5640"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5640"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5640/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5640/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/d388277e09af2df1a9b3b9e559924b414638b898"}},"author_association":"NONE"}}
{"actor":{"display_login":"BYK"}}