{"action":"created","issue":{"url":"https://api.github.com/repos/ueberauth/guardian_db/issues/93","repository_url":"https://api.github.com/repos/ueberauth/guardian_db","labels_url":"https://api.github.com/repos/ueberauth/guardian_db/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/ueberauth/guardian_db/issues/93/comments","events_url":"https://api.github.com/repos/ueberauth/guardian_db/issues/93/events","html_url":"https://github.com/ueberauth/guardian_db/issues/93","id":374100451,"node_id":"MDU6SXNzdWUzNzQxMDA0NTE=","number":93,"title":"guardian_db fails to compile with Ecto 3 rc (undefined function migrations_path/1)","user":{"login":"nathany","id":4566,"node_id":"MDQ6VXNlcjQ1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4566?v=4","gravatar_id":"","url":"https://api.github.com/users/nathany","html_url":"https://github.com/nathany","followers_url":"https://api.github.com/users/nathany/followers","following_url":"https://api.github.com/users/nathany/following{/other_user}","gists_url":"https://api.github.com/users/nathany/gists{/gist_id}","starred_url":"https://api.github.com/users/nathany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathany/subscriptions","organizations_url":"https://api.github.com/users/nathany/orgs","repos_url":"https://api.github.com/users/nathany/repos","events_url":"https://api.github.com/users/nathany/events{/privacy}","received_events_url":"https://api.github.com/users/nathany/received_events","type":"User","site_admin":false},"labels":[{"id":254542303,"node_id":"MDU6TGFiZWwyNTQ1NDIzMDM=","url":"https://api.github.com/repos/ueberauth/guardian_db/labels/Kind:Bug","name":"Kind:Bug","color":"b60205","default":false},{"id":1105998840,"node_id":"MDU6TGFiZWwxMTA1OTk4ODQw","url":"https://api.github.com/repos/ueberauth/guardian_db/labels/Status:Blocked","name":"Status:Blocked","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-10-25T19:37:26Z","updated_at":"2018-10-29T14:37:45Z","closed_at":null,"author_association":"NONE","body":"See https://github.com/elixir-ecto/ecto/issues/2763\r\n\r\n```\r\n== Compilation error in file lib/mix/tasks/guardian_db.gen.migration.ex ==\r\n** (CompileError) lib/mix/tasks/guardian_db.gen.migration.ex:21: undefined function migrations_path/1\r\n    (stdlib) lists.erl:1338: :lists.foreach/2\r\n    (stdlib) erl_eval.erl:680: :erl_eval.do_apply/6\r\n```\r\n\r\nI'm in the midst of updating a Phoenix app to use Ecto 3 (and ecto_sql), but ran into this compile failure when updating guardian_db from 0.8 to 1.1. \r\n\r\nhttps://github.com/ueberauth/guardian_db/blob/master/lib/mix/tasks/guardian_db.gen.migration.ex#L21"},"comment":{"url":"https://api.github.com/repos/ueberauth/guardian_db/issues/comments/433934410","html_url":"https://github.com/ueberauth/guardian_db/issues/93#issuecomment-433934410","issue_url":"https://api.github.com/repos/ueberauth/guardian_db/issues/93","id":433934410,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzkzNDQxMA==","user":{"login":"nathany","id":4566,"node_id":"MDQ6VXNlcjQ1NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4566?v=4","gravatar_id":"","url":"https://api.github.com/users/nathany","html_url":"https://github.com/nathany","followers_url":"https://api.github.com/users/nathany/followers","following_url":"https://api.github.com/users/nathany/following{/other_user}","gists_url":"https://api.github.com/users/nathany/gists{/gist_id}","starred_url":"https://api.github.com/users/nathany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathany/subscriptions","organizations_url":"https://api.github.com/users/nathany/orgs","repos_url":"https://api.github.com/users/nathany/repos","events_url":"https://api.github.com/users/nathany/events{/privacy}","received_events_url":"https://api.github.com/users/nathany/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T14:37:45Z","updated_at":"2018-10-29T14:37:45Z","author_association":"NONE","body":"Last week I made the mistake of working on a pull request before asking enough questions to fully understand what the maintainers of this project wanted. Instead I made assumptions based on how I've seen multiple versions of a library supported in the Ruby on Rails ecosystem, and was excited to learn that it was possible to have multiple lockfiles in Elixir too.\r\n\r\nBased on the comment from @yordis, is the plan to have a new release of guardian_db that requires ecto 3.0, and have people using ecto 2.x use an older version of guardian_db? If so, that sounds like a fine plan, and much simpler than my approach.\r\n\r\nIf instead you want to support multiple versions of ecto simultaneously, I'm curious how you would do it?\r\n\r\nIf anyone else looking at this issue is upgrading to ecto 3.0 rc, feel free to use my fork until ecto 3 is released, and a permanent solution is available.\r\n\r\n```\r\n{:guardian_db, \"~> 1.1.0\", github: \"aai/guardian_db\", branch: \"migrations\"},\r\n```\r\n\r\nFWIW, I never asked anyone to merge my pull request faster. My hope was that someone could use my work as a starting point if I wasn't able to continue working on it, as I'm often pulled from project to project. \r\n\r\nReading through my comments in #94, I recognize that I came across as an arrogant jerk, and for that I apologize.\r\n\r\nIt was a frustrating day or two, with 258 test failures upgrading guardian from 0.14 to 1.1 (thankfully now resolved). Then amplified by my open source efforts being criticized and disregarded without clear direction on how to do it better. Still, it's on me for not taking a step back and reacting in a calm manner. Sorry again, and thank you again for all your work on this library.\r\n"}}
{"actor":{"display_login":"nathany"}}