{"action":"opened","number":4801,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4801","id":211246657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjQ2NjU3","html_url":"https://github.com/grpc/grpc-java/pull/4801","diff_url":"https://github.com/grpc/grpc-java/pull/4801.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4801.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4801","number":4801,"state":"open","locked":false,"title":"core: allow Java 7 source and bytecode","user":{"login":"ericgribkoff","id":5067076,"node_id":"MDQ6VXNlcjUwNjcwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5067076?v=4","gravatar_id":"","url":"https://api.github.com/users/ericgribkoff","html_url":"https://github.com/ericgribkoff","followers_url":"https://api.github.com/users/ericgribkoff/followers","following_url":"https://api.github.com/users/ericgribkoff/following{/other_user}","gists_url":"https://api.github.com/users/ericgribkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ericgribkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericgribkoff/subscriptions","organizations_url":"https://api.github.com/users/ericgribkoff/orgs","repos_url":"https://api.github.com/users/ericgribkoff/repos","events_url":"https://api.github.com/users/ericgribkoff/events{/privacy}","received_events_url":"https://api.github.com/users/ericgribkoff/received_events","type":"User","site_admin":false},"body":"(This PR is a follow-up for an issue identified in https://github.com/grpc/grpc-java/pull/4799 and should not be merged without that change)\r\n\r\njavac can produce code that invokes Object.requireNonNull when instantiating\r\nan inner class using a instance variable. See\r\nhttps://bugs.openjdk.java.net/browse/JDK-8202137\r\n\r\n@ejona86 From the linked bug, I don't see that there is an option here other than marking the inner class non-static. It's slightly unsettling that we apparently need animalsniffer to catch javac including code that isn't present on old Android devices; I haven't had time to check if the android build system would otherwise do something fancy here to avoid issues at runtime on older devices.\r\n\r\nIf this looks alright, do you want to cherry-pick this commit into https://github.com/grpc/grpc-java/pull/4799, or keep this as a stand-alone PR?","created_at":"2018-08-27T22:13:28Z","updated_at":"2018-08-27T22:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4801/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4801/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4801/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/089e454e99edc094581cbd7440fc656ef299e844","head":{"label":"ericgribkoff:core_jdk17","ref":"core_jdk17","sha":"089e454e99edc094581cbd7440fc656ef299e844","user":{"login":"ericgribkoff","id":5067076,"node_id":"MDQ6VXNlcjUwNjcwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5067076?v=4","gravatar_id":"","url":"https://api.github.com/users/ericgribkoff","html_url":"https://github.com/ericgribkoff","followers_url":"https://api.github.com/users/ericgribkoff/followers","following_url":"https://api.github.com/users/ericgribkoff/following{/other_user}","gists_url":"https://api.github.com/users/ericgribkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ericgribkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericgribkoff/subscriptions","organizations_url":"https://api.github.com/users/ericgribkoff/orgs","repos_url":"https://api.github.com/users/ericgribkoff/repos","events_url":"https://api.github.com/users/ericgribkoff/events{/privacy}","received_events_url":"https://api.github.com/users/ericgribkoff/received_events","type":"User","site_admin":false},"repo":{"id":69692248,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5MjI0OA==","name":"grpc-java","full_name":"ericgribkoff/grpc-java","owner":{"login":"ericgribkoff","id":5067076,"node_id":"MDQ6VXNlcjUwNjcwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5067076?v=4","gravatar_id":"","url":"https://api.github.com/users/ericgribkoff","html_url":"https://github.com/ericgribkoff","followers_url":"https://api.github.com/users/ericgribkoff/followers","following_url":"https://api.github.com/users/ericgribkoff/following{/other_user}","gists_url":"https://api.github.com/users/ericgribkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ericgribkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericgribkoff/subscriptions","organizations_url":"https://api.github.com/users/ericgribkoff/orgs","repos_url":"https://api.github.com/users/ericgribkoff/repos","events_url":"https://api.github.com/users/ericgribkoff/events{/privacy}","received_events_url":"https://api.github.com/users/ericgribkoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericgribkoff/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/ericgribkoff/grpc-java","forks_url":"https://api.github.com/repos/ericgribkoff/grpc-java/forks","keys_url":"https://api.github.com/repos/ericgribkoff/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericgribkoff/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericgribkoff/grpc-java/teams","hooks_url":"https://api.github.com/repos/ericgribkoff/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/ericgribkoff/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/ericgribkoff/grpc-java/events","assignees_url":"https://api.github.com/repos/ericgribkoff/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/ericgribkoff/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/ericgribkoff/grpc-java/tags","blobs_url":"https://api.github.com/repos/ericgribkoff/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericgribkoff/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericgribkoff/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericgribkoff/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericgribkoff/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ericgribkoff/grpc-java/languages","stargazers_url":"https://api.github.com/repos/ericgribkoff/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/ericgribkoff/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/ericgribkoff/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/ericgribkoff/grpc-java/subscription","commits_url":"https://api.github.com/repos/ericgribkoff/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericgribkoff/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericgribkoff/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericgribkoff/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericgribkoff/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/ericgribkoff/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericgribkoff/grpc-java/merges","archive_url":"https://api.github.com/repos/ericgribkoff/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericgribkoff/grpc-java/downloads","issues_url":"https://api.github.com/repos/ericgribkoff/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/ericgribkoff/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ericgribkoff/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ericgribkoff/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericgribkoff/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/ericgribkoff/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/ericgribkoff/grpc-java/deployments","created_at":"2016-09-30T18:37:12Z","updated_at":"2018-02-22T15:20:07Z","pushed_at":"2018-08-27T22:07:07Z","git_url":"git://github.com/ericgribkoff/grpc-java.git","ssh_url":"git@github.com:ericgribkoff/grpc-java.git","clone_url":"https://github.com/ericgribkoff/grpc-java.git","svn_url":"https://github.com/ericgribkoff/grpc-java","homepage":"http://grpc.io","size":59913,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"b2f419c2126815d5317f37a46dc183bdee2f0047","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkyNg==","name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-08-27T14:15:45Z","pushed_at":"2018-08-27T20:33:44Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":26200,"stargazers_count":4744,"watchers_count":4744,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1535,"mirror_url":null,"archived":false,"open_issues_count":368,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1535,"open_issues":368,"watchers":4744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4801"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4801"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4801"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4801/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4801/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4801/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/089e454e99edc094581cbd7440fc656ef299e844"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ericgribkoff"}}