{"action":"created","issue":{"url":"https://api.github.com/repos/alfredh/baresip/issues/532","repository_url":"https://api.github.com/repos/alfredh/baresip","labels_url":"https://api.github.com/repos/alfredh/baresip/issues/532/labels{/name}","comments_url":"https://api.github.com/repos/alfredh/baresip/issues/532/comments","events_url":"https://api.github.com/repos/alfredh/baresip/issues/532/events","html_url":"https://github.com/alfredh/baresip/issues/532","id":359950453,"node_id":"MDU6SXNzdWUzNTk5NTA0NTM=","number":532,"title":"cannot call Reguest-URI that has parameters","user":{"login":"juha-h","id":6271940,"node_id":"MDQ6VXNlcjYyNzE5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6271940?v=4","gravatar_id":"","url":"https://api.github.com/users/juha-h","html_url":"https://github.com/juha-h","followers_url":"https://api.github.com/users/juha-h/followers","following_url":"https://api.github.com/users/juha-h/following{/other_user}","gists_url":"https://api.github.com/users/juha-h/gists{/gist_id}","starred_url":"https://api.github.com/users/juha-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juha-h/subscriptions","organizations_url":"https://api.github.com/users/juha-h/orgs","repos_url":"https://api.github.com/users/juha-h/repos","events_url":"https://api.github.com/users/juha-h/events{/privacy}","received_events_url":"https://api.github.com/users/juha-h/received_events","type":"User","site_admin":false},"labels":[{"id":79537683,"node_id":"MDU6TGFiZWw3OTUzNzY4Mw==","url":"https://api.github.com/repos/alfredh/baresip/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-09-13T15:34:10Z","updated_at":"2018-09-27T14:13:23Z","closed_at":null,"author_association":"COLLABORATOR","body":"When I try to place a call e.g. to sip:foo@bar;param=value, ;param=value is stripped from the Request-URI and call goes to sip:foo@bar.  Looks like stripping happens in src/call.c call_connect() function:\r\n````\r\n/* if the peer-address is a full SIP address then we need\r\n\t * to parse it and extract the SIP uri part.\r\n\t */\r\n\tif (0 == sip_addr_decode(&addr, paddr)) {\r\n\t\terr = pl_strdup(&call->peer_uri, &addr.auri);\r\n\t}\r\n````\r\nAccording to RFC 3261 Request-URI can contain parameters:\r\n````\r\nRequest-Line   =  Method SP Request-URI SP SIP-Version CRLF\r\nRequest-URI    =  SIP-URI / SIPS-URI / absoluteURI\r\nSIP-URI            =  \"sip:\" [ userinfo ] hostport uri-parameters [ headers ]\r\nuri-parameters  =  *( \";\" uri-parameter)\r\n````"},"comment":{"url":"https://api.github.com/repos/alfredh/baresip/issues/comments/425108395","html_url":"https://github.com/alfredh/baresip/issues/532#issuecomment-425108395","issue_url":"https://api.github.com/repos/alfredh/baresip/issues/532","id":425108395,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTEwODM5NQ==","user":{"login":"juha-h","id":6271940,"node_id":"MDQ6VXNlcjYyNzE5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/6271940?v=4","gravatar_id":"","url":"https://api.github.com/users/juha-h","html_url":"https://github.com/juha-h","followers_url":"https://api.github.com/users/juha-h/followers","following_url":"https://api.github.com/users/juha-h/following{/other_user}","gists_url":"https://api.github.com/users/juha-h/gists{/gist_id}","starred_url":"https://api.github.com/users/juha-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juha-h/subscriptions","organizations_url":"https://api.github.com/users/juha-h/orgs","repos_url":"https://api.github.com/users/juha-h/repos","events_url":"https://api.github.com/users/juha-h/events{/privacy}","received_events_url":"https://api.github.com/users/juha-h/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T14:13:23Z","updated_at":"2018-09-27T14:13:23Z","author_association":"COLLABORATOR","body":"Alfred E. Heggestad writes:\n\n> open issue is that ua_connect appends the local uri parameters,\n> for example \";transport=tcp\". this code is here:\n> \n> ```\n> \t/* Append any optional URI parameters */\n> \terr |= mbuf_write_pl(dialbuf, &ua->acc->luri.params);\n> ```\n> \n> is this still wanted/intended ?\n\nIn my opinion, it should not be done.  Request-URI contains what user\nspecifies as target of the request.  If there is an outbound proxy\ndefined, then the request is sent accordingly without touching\nRequest-URI.\n"}}
{"actor":{"display_login":"juha-h"}}