{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/daf_butler/pulls/comments/215434488","pull_request_review_id":152700126,"id":215434488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQzNDQ4OA==","diff_hunk":"@@ -314,16 +265,13 @@ def fromConfig(cls, config, builder=None):\n         Parameters\n         ----------\n         config : `SchemaConfig`\n-            `Registry` schema configuration containing \"DataUnits\",\n-            \"dataUnitRegions\", and \"dataUnitJoins\" entries.\n-        builder : `SchemaBuilder`, optional\n-            When given, create `sqlalchemy.core.Table` entries for every\n-            `DataUnit` table.\n+            `Registry` schema configuration containing \"dataUnits\",\n+            \"joins\" entries.\n         \"\"\"\n         dataUnitRegistry = cls()\n         dataUnitRegistry._initDataUnitNames(config[\"dataUnits\"])\n-        dataUnitRegistry._initDataUnits(config[\"dataUnits\"], builder)\n-        dataUnitRegistry._initDataUnitJoins(config[\"dataUnitJoins\"], builder)\n+        dataUnitRegistry._initDataUnits(config[\"dataUnits\"])","path":"python/lsst/daf/butler/core/dataUnit.py","position":167,"original_position":165,"commit_id":"a86ab9d446f095687f1dde3f2052c61b46c74ab7","original_commit_id":"d992fe3b0353e3d9857e6383730046ea76646b79","user":{"login":"TallJimbo","id":1330720,"node_id":"MDQ6VXNlcjEzMzA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1330720?v=4","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"Should be fixed now; Nate and I sort-of pair-programmed a bunch of fixes to how `DataUnitRegistries` are initialized, inspired by your slack comment.  To summarize: DataUnit configuration is now a sibling of Schema configuration - they're both nested within Registry, and are known to `ButlerConfig`. ","created_at":"2018-09-05T21:40:47Z","updated_at":"2018-09-05T21:40:47Z","html_url":"https://github.com/lsst/daf_butler/pull/68#discussion_r215434488","pull_request_url":"https://api.github.com/repos/lsst/daf_butler/pulls/68","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lsst/daf_butler/pulls/comments/215434488"},"html":{"href":"https://github.com/lsst/daf_butler/pull/68#discussion_r215434488"},"pull_request":{"href":"https://api.github.com/repos/lsst/daf_butler/pulls/68"}},"in_reply_to_id":215411312},"pull_request":{"url":"https://api.github.com/repos/lsst/daf_butler/pulls/68","id":207116671,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTE2Njcx","html_url":"https://github.com/lsst/daf_butler/pull/68","diff_url":"https://github.com/lsst/daf_butler/pull/68.diff","patch_url":"https://github.com/lsst/daf_butler/pull/68.patch","issue_url":"https://api.github.com/repos/lsst/daf_butler/issues/68","number":68,"state":"open","locked":false,"title":"DM-15336: Decouple DataUnitRegistry from Schema","user":{"login":"pschella","id":211955,"node_id":"MDQ6VXNlcjIxMTk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/211955?v=4","gravatar_id":"","url":"https://api.github.com/users/pschella","html_url":"https://github.com/pschella","followers_url":"https://api.github.com/users/pschella/followers","following_url":"https://api.github.com/users/pschella/following{/other_user}","gists_url":"https://api.github.com/users/pschella/gists{/gist_id}","starred_url":"https://api.github.com/users/pschella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschella/subscriptions","organizations_url":"https://api.github.com/users/pschella/orgs","repos_url":"https://api.github.com/users/pschella/repos","events_url":"https://api.github.com/users/pschella/events{/privacy}","received_events_url":"https://api.github.com/users/pschella/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-08T19:43:37Z","updated_at":"2018-09-05T21:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c9150a47426e5b41778284d8a9c90b519405cef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/daf_butler/pulls/68/commits","review_comments_url":"https://api.github.com/repos/lsst/daf_butler/pulls/68/comments","review_comment_url":"https://api.github.com/repos/lsst/daf_butler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/daf_butler/issues/68/comments","statuses_url":"https://api.github.com/repos/lsst/daf_butler/statuses/a86ab9d446f095687f1dde3f2052c61b46c74ab7","head":{"label":"lsst:tickets/DM-15336","ref":"tickets/DM-15336","sha":"a86ab9d446f095687f1dde3f2052c61b46c74ab7","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":106873149,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4NzMxNDk=","name":"daf_butler","full_name":"lsst/daf_butler","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/daf_butler","description":"Prototype for data access framework described in DMTN-056","fork":false,"url":"https://api.github.com/repos/lsst/daf_butler","forks_url":"https://api.github.com/repos/lsst/daf_butler/forks","keys_url":"https://api.github.com/repos/lsst/daf_butler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/daf_butler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/daf_butler/teams","hooks_url":"https://api.github.com/repos/lsst/daf_butler/hooks","issue_events_url":"https://api.github.com/repos/lsst/daf_butler/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/daf_butler/events","assignees_url":"https://api.github.com/repos/lsst/daf_butler/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/daf_butler/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/daf_butler/tags","blobs_url":"https://api.github.com/repos/lsst/daf_butler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/daf_butler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/daf_butler/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/daf_butler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/daf_butler/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/daf_butler/languages","stargazers_url":"https://api.github.com/repos/lsst/daf_butler/stargazers","contributors_url":"https://api.github.com/repos/lsst/daf_butler/contributors","subscribers_url":"https://api.github.com/repos/lsst/daf_butler/subscribers","subscription_url":"https://api.github.com/repos/lsst/daf_butler/subscription","commits_url":"https://api.github.com/repos/lsst/daf_butler/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/daf_butler/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/daf_butler/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/daf_butler/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/daf_butler/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/daf_butler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/daf_butler/merges","archive_url":"https://api.github.com/repos/lsst/daf_butler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/daf_butler/downloads","issues_url":"https://api.github.com/repos/lsst/daf_butler/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/daf_butler/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/daf_butler/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/daf_butler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/daf_butler/labels{/name}","releases_url":"https://api.github.com/repos/lsst/daf_butler/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/daf_butler/deployments","created_at":"2017-10-13T21:03:25Z","updated_at":"2018-09-01T22:54:01Z","pushed_at":"2018-09-05T21:14:20Z","git_url":"git://github.com/lsst/daf_butler.git","ssh_url":"git@github.com:lsst/daf_butler.git","clone_url":"https://github.com/lsst/daf_butler.git","svn_url":"https://github.com/lsst/daf_butler","homepage":null,"size":1170,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"873d001ffec504b78448ce04f8cd0ab4b199b8b9","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":106873149,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4NzMxNDk=","name":"daf_butler","full_name":"lsst/daf_butler","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/daf_butler","description":"Prototype for data access framework described in DMTN-056","fork":false,"url":"https://api.github.com/repos/lsst/daf_butler","forks_url":"https://api.github.com/repos/lsst/daf_butler/forks","keys_url":"https://api.github.com/repos/lsst/daf_butler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/daf_butler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/daf_butler/teams","hooks_url":"https://api.github.com/repos/lsst/daf_butler/hooks","issue_events_url":"https://api.github.com/repos/lsst/daf_butler/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/daf_butler/events","assignees_url":"https://api.github.com/repos/lsst/daf_butler/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/daf_butler/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/daf_butler/tags","blobs_url":"https://api.github.com/repos/lsst/daf_butler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/daf_butler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/daf_butler/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/daf_butler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/daf_butler/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/daf_butler/languages","stargazers_url":"https://api.github.com/repos/lsst/daf_butler/stargazers","contributors_url":"https://api.github.com/repos/lsst/daf_butler/contributors","subscribers_url":"https://api.github.com/repos/lsst/daf_butler/subscribers","subscription_url":"https://api.github.com/repos/lsst/daf_butler/subscription","commits_url":"https://api.github.com/repos/lsst/daf_butler/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/daf_butler/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/daf_butler/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/daf_butler/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/daf_butler/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/daf_butler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/daf_butler/merges","archive_url":"https://api.github.com/repos/lsst/daf_butler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/daf_butler/downloads","issues_url":"https://api.github.com/repos/lsst/daf_butler/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/daf_butler/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/daf_butler/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/daf_butler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/daf_butler/labels{/name}","releases_url":"https://api.github.com/repos/lsst/daf_butler/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/daf_butler/deployments","created_at":"2017-10-13T21:03:25Z","updated_at":"2018-09-01T22:54:01Z","pushed_at":"2018-09-05T21:14:20Z","git_url":"git://github.com/lsst/daf_butler.git","ssh_url":"git@github.com:lsst/daf_butler.git","clone_url":"https://github.com/lsst/daf_butler.git","svn_url":"https://github.com/lsst/daf_butler","homepage":null,"size":1170,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/daf_butler/pulls/68"},"html":{"href":"https://github.com/lsst/daf_butler/pull/68"},"issue":{"href":"https://api.github.com/repos/lsst/daf_butler/issues/68"},"comments":{"href":"https://api.github.com/repos/lsst/daf_butler/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/daf_butler/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/daf_butler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/daf_butler/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/daf_butler/statuses/a86ab9d446f095687f1dde3f2052c61b46c74ab7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"TallJimbo"}}