{"action":"created","issue":{"url":"https://api.github.com/repos/quipucords/quipucords/issues/1269","repository_url":"https://api.github.com/repos/quipucords/quipucords","labels_url":"https://api.github.com/repos/quipucords/quipucords/issues/1269/labels{/name}","comments_url":"https://api.github.com/repos/quipucords/quipucords/issues/1269/comments","events_url":"https://api.github.com/repos/quipucords/quipucords/issues/1269/events","html_url":"https://github.com/quipucords/quipucords/issues/1269","id":316397898,"number":1269,"title":"Investigate Process.terminate issue in docker container","user":{"login":"kholdaway","id":32331547,"avatar_url":"https://avatars0.githubusercontent.com/u/32331547?v=4","gravatar_id":"","url":"https://api.github.com/users/kholdaway","html_url":"https://github.com/kholdaway","followers_url":"https://api.github.com/users/kholdaway/followers","following_url":"https://api.github.com/users/kholdaway/following{/other_user}","gists_url":"https://api.github.com/users/kholdaway/gists{/gist_id}","starred_url":"https://api.github.com/users/kholdaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholdaway/subscriptions","organizations_url":"https://api.github.com/users/kholdaway/orgs","repos_url":"https://api.github.com/users/kholdaway/repos","events_url":"https://api.github.com/users/kholdaway/events{/privacy}","received_events_url":"https://api.github.com/users/kholdaway/received_events","type":"User","site_admin":false},"labels":[{"id":627554026,"url":"https://api.github.com/repos/quipucords/quipucords/labels/bug","name":"bug","color":"ee0701","default":true},{"id":692704126,"url":"https://api.github.com/repos/quipucords/quipucords/labels/priority%20-%20high","name":"priority - high","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/quipucords/quipucords/milestones/16","html_url":"https://github.com/quipucords/quipucords/milestone/16","labels_url":"https://api.github.com/repos/quipucords/quipucords/milestones/16/labels","id":3285293,"number":16,"title":"Sprint 21","description":"","creator":{"login":"kholdaway","id":32331547,"avatar_url":"https://avatars0.githubusercontent.com/u/32331547?v=4","gravatar_id":"","url":"https://api.github.com/users/kholdaway","html_url":"https://github.com/kholdaway","followers_url":"https://api.github.com/users/kholdaway/followers","following_url":"https://api.github.com/users/kholdaway/following{/other_user}","gists_url":"https://api.github.com/users/kholdaway/gists{/gist_id}","starred_url":"https://api.github.com/users/kholdaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholdaway/subscriptions","organizations_url":"https://api.github.com/users/kholdaway/orgs","repos_url":"https://api.github.com/users/kholdaway/repos","events_url":"https://api.github.com/users/kholdaway/events{/privacy}","received_events_url":"https://api.github.com/users/kholdaway/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":16,"state":"open","created_at":"2018-04-20T20:16:52Z","updated_at":"2018-05-02T14:51:48Z","due_on":"2018-05-04T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-04-20T20:14:18Z","updated_at":"2018-05-03T00:55:30Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Specify type:\r\n- Bug\r\n\r\n### Priority:\r\n- High\r\n___\r\n\r\n## Description:\r\nThis is a possible bug.  QE logs have shown instances where the pause/cancel task doesn't stop processing even though the python Process.terminate() method has been called.  This issue is to investigate whether the pause/cancel work differently when run in a docker container.\r\n___\r\n\r\n## Acceptance Criteria:\r\n- [ ] Verify that pause/cancel work in a docker container\r\n"},"comment":{"url":"https://api.github.com/repos/quipucords/quipucords/issues/comments/386165147","html_url":"https://github.com/quipucords/quipucords/issues/1269#issuecomment-386165147","issue_url":"https://api.github.com/repos/quipucords/quipucords/issues/1269","id":386165147,"user":{"login":"elyezer","id":48132,"avatar_url":"https://avatars1.githubusercontent.com/u/48132?v=4","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T00:55:30Z","updated_at":"2018-05-03T00:55:30Z","author_association":"OWNER","body":"Checking the logs using the dev server I see these messages:\r\n\r\n```\r\nINFO Job 2 (inspect, elapsed_time: 0s) - SIGNAL PAUSE received for scan job.\r\nINFO Job 2 (inspect, elapsed_time: 0s) - TERMINATING JOB PROCESS\r\nINFO Job 2 (inspect, elapsed_time: 0s) - Process successfully killed=False.\r\nERROR Job 2 (inspect, elapsed_time: 0s) - Request to kill process failed.\r\n```\r\n\r\nSo the job is not really being killed. On the source it is only printing some log messages:\r\n\r\n```python\r\n            job_runner.terminate()\r\n            job_runner.join()\r\n            killed = not job_runner.is_alive()\r\n            job.log_message(\r\n                'Process successfully killed=%s.' % killed)\r\n            if not killed:\r\n                job.log_message(\r\n                    'Request to kill process failed.',\r\n                    log_level=logging.ERROR)\r\n            self.current_task = None\r\n```\r\n\r\nSo before making `self.current_task = None` it should ensure the task is actually killed."}}
{"actor":{"display_login":"elyezer"}}