{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/198505926","pull_request_review_id":132446521,"id":198505926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODUwNTkyNg==","diff_hunk":"@@ -2220,6 +2221,19 @@ static int32_t TryChangeSocketEventRegistrationInner(\n                0,\n                0,\n                GetKeventUdata(data));\n+#if defined(__FreeBSD__)\n+        // FreeBSD seems to have some issue when setting read/write events together.\n+        // As a workaround use separate kevent() calls.","path":"src/Native/Unix/System.Native/pal_networking.c","position":14,"original_position":14,"commit_id":"efaba66b533ba99f9eaf778f17ef28126b7ecc0c","original_commit_id":"efaba66b533ba99f9eaf778f17ef28126b7ecc0c","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"@wfurt, is there an issue number for the investigation and that we could include here?","created_at":"2018-06-27T13:59:48Z","updated_at":"2018-06-27T13:59:48Z","html_url":"https://github.com/dotnet/corefx/pull/30688#discussion_r198505926","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/30688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/198505926"},"html":{"href":"https://github.com/dotnet/corefx/pull/30688#discussion_r198505926"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30688"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30688","id":197619417,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjE5NDE3","html_url":"https://github.com/dotnet/corefx/pull/30688","diff_url":"https://github.com/dotnet/corefx/pull/30688.diff","patch_url":"https://github.com/dotnet/corefx/pull/30688.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30688","number":30688,"state":"open","locked":false,"title":"use separate kevent() calls on FreeBSD for read and write event notifications.","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"body":"This is somewhat speculative change but it impacts only FreeBSD.\r\nWe got bootstrap cli working on FreeBSD but msbuild and Roslyn were sometimes hanging.\r\n\r\nInvestigation pointed to some problems with kqueue and named pipes. \r\nWhen socket buffer is filled, send() fails with EWOULDBLOCK.\r\nWe would use kevent() to ask kernel to notify when socket is writable but the notification would never come. Unit tests from System.IO.Pipes were also failing. \r\n\r\nAfter some experiments I found out that kevent() works as expected if I separate requests fore read and write notifications to two separate calls. From reading docs it should work as it was written but it does not. \r\n\r\nI can open issue to track this and investigate more. But this changes allows msbuild and Roslyn to function and we can build coreclr and corefx using source-build. All named pipe tests are passing now on FreeBSD.\r\n","created_at":"2018-06-27T05:25:01Z","updated_at":"2018-06-27T13:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d52145721e9aa0100cfc5948df4240a09dc07f0b","assignee":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"assignees":[{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"ncl","id":2620029,"node_id":"MDQ6VGVhbTI2MjAwMjk=","slug":"ncl","description":".NET Networking Class Libraries","privacy":"closed","url":"https://api.github.com/teams/2620029","members_url":"https://api.github.com/teams/2620029/members{/member}","repositories_url":"https://api.github.com/teams/2620029/repos","permission":"pull"}],"labels":[{"id":145399955,"node_id":"MDU6TGFiZWwxNDUzOTk5NTU=","url":"https://api.github.com/repos/dotnet/corefx/labels/bug","name":"bug","color":"207de5","default":true},{"id":205613987,"node_id":"MDU6TGFiZWwyMDU2MTM5ODc=","url":"https://api.github.com/repos/dotnet/corefx/labels/os-freebsd","name":"os-freebsd","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/30688/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/30688/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30688/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/efaba66b533ba99f9eaf778f17ef28126b7ecc0c","head":{"label":"wfurt:freebsd_kq","ref":"freebsd_kq","sha":"efaba66b533ba99f9eaf778f17ef28126b7ecc0c","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"repo":{"id":91738855,"node_id":"MDEwOlJlcG9zaXRvcnk5MTczODg1NQ==","name":"corefx","full_name":"wfurt/corefx","owner":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wfurt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/wfurt/corefx","forks_url":"https://api.github.com/repos/wfurt/corefx/forks","keys_url":"https://api.github.com/repos/wfurt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wfurt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wfurt/corefx/teams","hooks_url":"https://api.github.com/repos/wfurt/corefx/hooks","issue_events_url":"https://api.github.com/repos/wfurt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/wfurt/corefx/events","assignees_url":"https://api.github.com/repos/wfurt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/wfurt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/wfurt/corefx/tags","blobs_url":"https://api.github.com/repos/wfurt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wfurt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wfurt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/wfurt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wfurt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/wfurt/corefx/languages","stargazers_url":"https://api.github.com/repos/wfurt/corefx/stargazers","contributors_url":"https://api.github.com/repos/wfurt/corefx/contributors","subscribers_url":"https://api.github.com/repos/wfurt/corefx/subscribers","subscription_url":"https://api.github.com/repos/wfurt/corefx/subscription","commits_url":"https://api.github.com/repos/wfurt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/wfurt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/wfurt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/wfurt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/wfurt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/wfurt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wfurt/corefx/merges","archive_url":"https://api.github.com/repos/wfurt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wfurt/corefx/downloads","issues_url":"https://api.github.com/repos/wfurt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/wfurt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/wfurt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/wfurt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wfurt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/wfurt/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/wfurt/corefx/deployments","created_at":"2017-05-18T21:24:08Z","updated_at":"2018-06-21T05:16:57Z","pushed_at":"2018-06-27T05:55:06Z","git_url":"git://github.com/wfurt/corefx.git","ssh_url":"git@github.com:wfurt/corefx.git","clone_url":"https://github.com/wfurt/corefx.git","svn_url":"https://github.com/wfurt/corefx","homepage":"https://github.com/dotnet/core","size":179453,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a9aabd2b7cf913f9dd35492d2f3497b2fb269978","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-06-27T13:29:12Z","pushed_at":"2018-06-27T13:57:22Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":181931,"stargazers_count":14233,"watchers_count":14233,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4123,"mirror_url":null,"archived":false,"open_issues_count":2351,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4123,"open_issues":2351,"watchers":14233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30688"},"html":{"href":"https://github.com/dotnet/corefx/pull/30688"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30688"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30688/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30688/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30688/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/efaba66b533ba99f9eaf778f17ef28126b7ecc0c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stephentoub"}}