{"action":"created","comment":{"url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/comments/181952657","pull_request_review_id":112666529,"id":181952657,"diff_hunk":"@@ -0,0 +1,45 @@\n+/* global angular */\n+\n+(function (angular) {\n+  'use strict';\n+\n+  angular.module('crm-tasks-workflows.controllers')\n+    .controller('CaseTypeExtendedController', CaseTypeExtendedController);\n+\n+  CaseTypeExtendedController.$inject = [\n+    '$log', '$scope', 'crmApi'\n+  ];\n+\n+  function CaseTypeExtendedController ($log, $scope, crmApi) {\n+    $log.debug('Controller: CaseTypeExtendedController');\n+\n+    $scope.activityTypeOptions = [];\n+\n+    (function init () {\n+      fetchActivityTypes();\n+    })();\n+\n+    /**\n+     * Fetch activity types which are components of CiviTask or CiviDocument\n+     *\n+     * @return {Promise}\n+     */\n+    function fetchActivityTypes () {\n+      return crmApi('OptionValue', 'get', {","path":"uk.co.compucorp.civicrm.tasksassignments/js/src/crm-tasks-workflows/controllers/casetype.extended.controller.js","position":null,"original_position":28,"commit_id":"aa54de79de38bd06210c2f2f56d26d17491ca3a1","original_commit_id":"44df3070d5253ea680739446f2a7d7b9370da70c","user":{"login":"deb1990","id":5058867,"avatar_url":"https://avatars1.githubusercontent.com/u/5058867?v=4","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"body":"Oops, I forgot to add this, apologies. Done.","created_at":"2018-04-17T05:02:05Z","updated_at":"2018-04-17T05:02:05Z","html_url":"https://github.com/compucorp/civihr-tasks-assignments/pull/336#discussion_r181952657","pull_request_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/comments/181952657"},"html":{"href":"https://github.com/compucorp/civihr-tasks-assignments/pull/336#discussion_r181952657"},"pull_request":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336"}},"in_reply_to_id":181735474},"pull_request":{"url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336","id":181376459,"html_url":"https://github.com/compucorp/civihr-tasks-assignments/pull/336","diff_url":"https://github.com/compucorp/civihr-tasks-assignments/pull/336.diff","patch_url":"https://github.com/compucorp/civihr-tasks-assignments/pull/336.patch","issue_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/336","number":336,"state":"open","locked":false,"title":"PCHR-3529: Activity dropdown changes","user":{"login":"deb1990","id":5058867,"avatar_url":"https://avatars1.githubusercontent.com/u/5058867?v=4","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"body":"## Overview\r\nThe PR contains the following changes to the Activity Dropdown in New Workflow Type page\r\n - the add activity drop down placeholder now says \"Add task or document\" instead of `Add activity`\r\n - lists only activities that are marked as CiviTask and CiviDocument components\r\n\r\n## Before\r\n![3529b](https://user-images.githubusercontent.com/5058867/38811373-f617e7d8-41a6-11e8-8cb3-b6a715a8cf3c.gif)\r\n\r\n## After\r\n![3529](https://user-images.githubusercontent.com/5058867/38811309-d3a51c20-41a6-11e8-8cd3-3c02d2e02216.gif)\r\n\r\n## Technical Details\r\n1. `_tasksAssignments_change_add_activity_dropdown_placeholder ` is created inside `tasksassignments.php` to change the placeholder.\r\n\r\n2. A new angular module `crm-tasks-workflows` is created. The Proof of concept for that can be found in https://github.com/compucorp/civihr-tasks-assignments/pull/337\r\n  - New Gulp task `js-crm` is created to bundle and minify files for the new module.\r\n  - `requirejs-bundle` is renamed to `js-requirejs-bundle`.\r\n  - Previous `karma.conf.js`is moved inside `tasks-assignments` folder. And a new karma file is created under `crm-tasks-workflows` file. It was necessary to create separate files as otherwise angular is loaded twice, once for `crm-tasks-workflows`(normal version) and again from `reqangular`(requirejs version).\r\n\r\n## Comments\r\nA core PR(https://github.com/civicrm/civicrm-core/pull/11979) has been submitted to fix a issue with `crmAddName` directive. Please switch to `compucorp:fix-crm-add-name-directive` branch for `civicrm` to test.","created_at":"2018-04-13T03:17:08Z","updated_at":"2018-04-17T05:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98641c3d142c73d664a02889c43cee3394285cf8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":197989203,"url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":830330042,"url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/labels/ready%20to%20test","name":"ready to test","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336/commits","review_comments_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336/comments","review_comment_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/336/comments","statuses_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/statuses/aa54de79de38bd06210c2f2f56d26d17491ca3a1","head":{"label":"compucorp:PCHR-3529-activity-dropdown-changes","ref":"PCHR-3529-activity-dropdown-changes","sha":"aa54de79de38bd06210c2f2f56d26d17491ca3a1","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":33719821,"name":"civihr-tasks-assignments","full_name":"compucorp/civihr-tasks-assignments","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/civihr-tasks-assignments","description":"Tasks and Assignments","fork":false,"url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments","forks_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/forks","keys_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/teams","hooks_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/hooks","issue_events_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/events","assignees_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/tags","blobs_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/languages","stargazers_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/stargazers","contributors_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/contributors","subscribers_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/subscribers","subscription_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/subscription","commits_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/merges","archive_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/downloads","issues_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/deployments","created_at":"2015-04-10T09:18:16Z","updated_at":"2018-03-26T11:44:03Z","pushed_at":"2018-04-17T05:01:49Z","git_url":"git://github.com/compucorp/civihr-tasks-assignments.git","ssh_url":"git@github.com:compucorp/civihr-tasks-assignments.git","clone_url":"https://github.com/compucorp/civihr-tasks-assignments.git","svn_url":"https://github.com/compucorp/civihr-tasks-assignments","homepage":"","size":8522,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":2,"default_branch":"staging"}},"base":{"label":"compucorp:PCHR-3369-tasks-and-workflows-ux-improvements","ref":"PCHR-3369-tasks-and-workflows-ux-improvements","sha":"cf35c5d9c202fe837cf73389c979d95936281c00","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":33719821,"name":"civihr-tasks-assignments","full_name":"compucorp/civihr-tasks-assignments","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/civihr-tasks-assignments","description":"Tasks and Assignments","fork":false,"url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments","forks_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/forks","keys_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/teams","hooks_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/hooks","issue_events_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/events","assignees_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/tags","blobs_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/languages","stargazers_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/stargazers","contributors_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/contributors","subscribers_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/subscribers","subscription_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/subscription","commits_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/merges","archive_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/downloads","issues_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/deployments","created_at":"2015-04-10T09:18:16Z","updated_at":"2018-03-26T11:44:03Z","pushed_at":"2018-04-17T05:01:49Z","git_url":"git://github.com/compucorp/civihr-tasks-assignments.git","ssh_url":"git@github.com:compucorp/civihr-tasks-assignments.git","clone_url":"https://github.com/compucorp/civihr-tasks-assignments.git","svn_url":"https://github.com/compucorp/civihr-tasks-assignments","homepage":"","size":8522,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":2,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336"},"html":{"href":"https://github.com/compucorp/civihr-tasks-assignments/pull/336"},"issue":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/336"},"comments":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/civihr-tasks-assignments/statuses/aa54de79de38bd06210c2f2f56d26d17491ca3a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deb1990"}}