{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/219511380","pull_request_review_id":157708694,"id":219511380,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTUxMTM4MA==","diff_hunk":"@@ -34,12 +34,12 @@\n     <link rel=\"stylesheet\" href=\"../../../out/spec/mdc-dialog/fixture.css\">\n   </head>\n \n-  <body class=\"test-container test-container--edge-fonts\">\n+  <body class=\"test-container test-container--edge-fonts mdc-dialog-scroll-lock\">\n     <main class=\"test-viewport test-viewport--center\">\n \n       <button class=\"test-dialog-open-button\" data-test-dialog-id=\"test-dialog\" autofocus>Open Dialog</button>\n \n-      <div class=\"mdc-dialog test-dialog\"\n+      <div class=\"mdc-dialog mdc-dialog--open test-dialog test-dialog--simple\"","path":"test/screenshot/spec/mdc-dialog/classes/baseline-simple.html","position":null,"original_position":11,"commit_id":"f30c663f847ae5672dc93efda0657683bcba515e","original_commit_id":"d2fa434dd2748d9566785da1ea74de8858c15181","user":{"login":"acdvorak","id":409245,"node_id":"MDQ6VXNlcjQwOTI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/409245?v=4","gravatar_id":"","url":"https://api.github.com/users/acdvorak","html_url":"https://github.com/acdvorak","followers_url":"https://api.github.com/users/acdvorak/followers","following_url":"https://api.github.com/users/acdvorak/following{/other_user}","gists_url":"https://api.github.com/users/acdvorak/gists{/gist_id}","starred_url":"https://api.github.com/users/acdvorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdvorak/subscriptions","organizations_url":"https://api.github.com/users/acdvorak/orgs","repos_url":"https://api.github.com/users/acdvorak/repos","events_url":"https://api.github.com/users/acdvorak/events{/privacy}","received_events_url":"https://api.github.com/users/acdvorak/received_events","type":"User","site_admin":false},"body":"Removed","created_at":"2018-09-21T14:12:08Z","updated_at":"2018-09-21T14:12:08Z","html_url":"https://github.com/material-components/material-components-web/pull/3606#discussion_r219511380","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3606","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/219511380"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3606#discussion_r219511380"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3606"}},"in_reply_to_id":219486709},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/3606","id":217249892,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjQ5ODky","html_url":"https://github.com/material-components/material-components-web/pull/3606","diff_url":"https://github.com/material-components/material-components-web/pull/3606.diff","patch_url":"https://github.com/material-components/material-components-web/pull/3606.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/3606","number":3606,"state":"open","locked":false,"title":"chore(infrastructure): Reduce dialog flakiness by avoiding reflow","user":{"login":"acdvorak","id":409245,"node_id":"MDQ6VXNlcjQwOTI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/409245?v=4","gravatar_id":"","url":"https://api.github.com/users/acdvorak","html_url":"https://github.com/acdvorak","followers_url":"https://api.github.com/users/acdvorak/followers","following_url":"https://api.github.com/users/acdvorak/following{/other_user}","gists_url":"https://api.github.com/users/acdvorak/gists{/gist_id}","starred_url":"https://api.github.com/users/acdvorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdvorak/subscriptions","organizations_url":"https://api.github.com/users/acdvorak/orgs","repos_url":"https://api.github.com/users/acdvorak/repos","events_url":"https://api.github.com/users/acdvorak/events{/privacy}","received_events_url":"https://api.github.com/users/acdvorak/received_events","type":"User","site_admin":false},"body":"### What it does\r\n\r\n- Reduces text rendering flakiness on dialog pages in IE 11 💩, Edge, and Firefox\r\n- Avoids reflow by adding CSS classes directly to the HTML:\r\n    - `mdc-dialog--open`\r\n    - `mdc-dialog-scroll-lock` (without this, scrollbars flicker in IE 11 💩 and Edge)\r\n- Fixes a broken regex that caused screenshot tests to be skipped on PRs that only have HTML or YAML file changes 😞 ","created_at":"2018-09-21T11:10:44Z","updated_at":"2018-09-21T14:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"266d796e00d392b41780790f888b3f2d2f98e00e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1036895551,"node_id":"MDU6TGFiZWwxMDM2ODk1NTUx","url":"https://api.github.com/repos/material-components/material-components-web/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3606/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3606/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/3606/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/f30c663f847ae5672dc93efda0657683bcba515e","head":{"label":"material-components:chore/infra/dialog-reflow","ref":"chore/infra/dialog-reflow","sha":"f30c663f847ae5672dc93efda0657683bcba515e","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-09-21T13:56:12Z","pushed_at":"2018-09-21T14:12:06Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":69436,"stargazers_count":10390,"watchers_count":10390,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1253,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1253,"open_issues":331,"watchers":10390,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"c1bd45a523347cdf8d1fb34d939b7cc1b9c4e974","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-09-21T13:56:12Z","pushed_at":"2018-09-21T14:12:06Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":69436,"stargazers_count":10390,"watchers_count":10390,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1253,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1253,"open_issues":331,"watchers":10390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3606"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3606"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3606"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3606/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3606/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3606/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/f30c663f847ae5672dc93efda0657683bcba515e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"acdvorak"}}