{"action":"created","issue":{"url":"https://api.github.com/repos/cozy/cozy-contacts/issues/168","repository_url":"https://api.github.com/repos/cozy/cozy-contacts","labels_url":"https://api.github.com/repos/cozy/cozy-contacts/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/cozy/cozy-contacts/issues/168/comments","events_url":"https://api.github.com/repos/cozy/cozy-contacts/issues/168/events","html_url":"https://github.com/cozy/cozy-contacts/pull/168","id":327343421,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTYzNTg0","number":168,"title":"feat: Import contact vCards from a *.vcf file","user":{"login":"sebn","id":2260801,"node_id":"MDQ6VXNlcjIyNjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/2260801?v=4","gravatar_id":"","url":"https://api.github.com/users/sebn","html_url":"https://github.com/sebn","followers_url":"https://api.github.com/users/sebn/followers","following_url":"https://api.github.com/users/sebn/following{/other_user}","gists_url":"https://api.github.com/users/sebn/gists{/gist_id}","starred_url":"https://api.github.com/users/sebn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebn/subscriptions","organizations_url":"https://api.github.com/users/sebn/orgs","repos_url":"https://api.github.com/users/sebn/repos","events_url":"https://api.github.com/users/sebn/events{/privacy}","received_events_url":"https://api.github.com/users/sebn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-05-29T14:22:42Z","updated_at":"2018-06-04T08:53:42Z","closed_at":"2018-06-04T08:53:28Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cozy/cozy-contacts/pulls/168","html_url":"https://github.com/cozy/cozy-contacts/pull/168","diff_url":"https://github.com/cozy/cozy-contacts/pull/168.diff","patch_url":"https://github.com/cozy/cozy-contacts/pull/168.patch"},"body":"Title should be self-explanatory. Early feedback welcome.\r\n\r\nI'd prefer to merge it into master while disabling the feature because it's not complete, so I could switch to cozy-desktop.\r\nBut we can also keep it in a branch (although I wonder whether it'll make it harder to merge later, I already got some conflicts on the empty contacts list during development).\r\nWDYT?\r\n\r\n#### Checklist\r\n\r\n- [ ] Faithful integration of the mockups at all screen sizes => there are a few remaining issues I'll need help to fix, the main one being non-clickable empty list buttons (not sure why)\r\n- [ ] Tested on supported browsers, including responsive mode (IE11 and Edge, Chrome >= 42, 2 latest versions of Firefox and Safari) => I only tested on Firefox, I'll give a try to IE11/Edge/Chrome and fix main issues\r\n- [x] Localized in english and french => I added the english messages but assumed it was better to wait for the PR to be merged before translating everything in transifex.\r\n- [x] All changes have test coverage => I tested the domain logic separately, not the UI components.\r\n- [x] Updated README, if necessary => Added some doc in `src/importation/`\r\n- [x] Make sure commit messages rely on the [Commitizen](http://commitizen.github.io/cz-cli/) format\r\n"},"comment":{"url":"https://api.github.com/repos/cozy/cozy-contacts/issues/comments/394282172","html_url":"https://github.com/cozy/cozy-contacts/pull/168#issuecomment-394282172","issue_url":"https://api.github.com/repos/cozy/cozy-contacts/issues/168","id":394282172,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDI4MjE3Mg==","user":{"login":"y-lohse","id":2261445,"node_id":"MDQ6VXNlcjIyNjE0NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2261445?v=4","gravatar_id":"","url":"https://api.github.com/users/y-lohse","html_url":"https://github.com/y-lohse","followers_url":"https://api.github.com/users/y-lohse/followers","following_url":"https://api.github.com/users/y-lohse/following{/other_user}","gists_url":"https://api.github.com/users/y-lohse/gists{/gist_id}","starred_url":"https://api.github.com/users/y-lohse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-lohse/subscriptions","organizations_url":"https://api.github.com/users/y-lohse/orgs","repos_url":"https://api.github.com/users/y-lohse/repos","events_url":"https://api.github.com/users/y-lohse/events{/privacy}","received_events_url":"https://api.github.com/users/y-lohse/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T08:53:42Z","updated_at":"2018-06-04T08:53:42Z","author_association":"MEMBER","body":"Thanks 🎉 !"}}
{"actor":{"display_login":"y-lohse"}}