{"action":"created","comment":{"url":"https://api.github.com/repos/aragon/aragonOS/pulls/comments/218727279","pull_request_review_id":156725201,"id":218727279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODcyNzI3OQ==","diff_hunk":"@@ -31,20 +31,21 @@ contract ACL is IACL, TimeHelpers, AragonApp, ACLHelpers {\n         // op and id take less than 1 byte each so it can be kept in 1 sstore\n     }\n \n-    uint8 constant BLOCK_NUMBER_PARAM_ID = 200;\n-    uint8 constant TIMESTAMP_PARAM_ID    = 201;\n+    uint8 constant internal BLOCK_NUMBER_PARAM_ID = 200;\n+    uint8 constant internal TIMESTAMP_PARAM_ID    = 201;\n     // 202 is unused\n-    uint8 constant ORACLE_PARAM_ID       = 203;\n-    uint8 constant LOGIC_OP_PARAM_ID     = 204;\n-    uint8 constant PARAM_VALUE_PARAM_ID  = 205;\n+    uint8 constant internal ORACLE_PARAM_ID       = 203;\n+    uint8 constant internal LOGIC_OP_PARAM_ID     = 204;\n+    uint8 constant internal PARAM_VALUE_PARAM_ID  = 205;","path":"contracts/acl/ACL.sol","position":14,"original_position":14,"commit_id":"b96e224b772b1333a07951d98290c23af096f188","original_commit_id":"b96e224b772b1333a07951d98290c23af096f188","user":{"login":"bingen","id":701095,"node_id":"MDQ6VXNlcjcwMTA5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701095?v=4","gravatar_id":"","url":"https://api.github.com/users/bingen","html_url":"https://github.com/bingen","followers_url":"https://api.github.com/users/bingen/followers","following_url":"https://api.github.com/users/bingen/following{/other_user}","gists_url":"https://api.github.com/users/bingen/gists{/gist_id}","starred_url":"https://api.github.com/users/bingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingen/subscriptions","organizations_url":"https://api.github.com/users/bingen/orgs","repos_url":"https://api.github.com/users/bingen/repos","events_url":"https://api.github.com/users/bingen/events{/privacy}","received_events_url":"https://api.github.com/users/bingen/received_events","type":"User","site_admin":false},"body":"Shouldn't all of these be `internal constant`?","created_at":"2018-09-19T09:12:58Z","updated_at":"2018-09-19T09:13:43Z","html_url":"https://github.com/aragon/aragonOS/pull/424#discussion_r218727279","pull_request_url":"https://api.github.com/repos/aragon/aragonOS/pulls/424","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aragon/aragonOS/pulls/comments/218727279"},"html":{"href":"https://github.com/aragon/aragonOS/pull/424#discussion_r218727279"},"pull_request":{"href":"https://api.github.com/repos/aragon/aragonOS/pulls/424"}},"in_reply_to_id":216992739},"pull_request":{"url":"https://api.github.com/repos/aragon/aragonOS/pulls/424","id":214926738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTI2NzM4","html_url":"https://github.com/aragon/aragonOS/pull/424","diff_url":"https://github.com/aragon/aragonOS/pull/424.diff","patch_url":"https://github.com/aragon/aragonOS/pull/424.patch","issue_url":"https://api.github.com/repos/aragon/aragonOS/issues/424","number":424,"state":"open","locked":false,"title":"Fix visibility order for constants","user":{"login":"sohkai","id":4166642,"node_id":"MDQ6VXNlcjQxNjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"body":"Generally, visibility modifers are preferred before any other modifier (strong social consensus, e.g. OpenZeppelin).\r\n\r\nOur linter doesn't have a rule to check this yet (see https://github.com/duaraghav8/Solium/issues/239).","created_at":"2018-09-12T11:27:17Z","updated_at":"2018-09-19T09:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4c764f7e2e8c83ebdaabaa4ddaab7854541d658","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aragon/aragonOS/pulls/424/commits","review_comments_url":"https://api.github.com/repos/aragon/aragonOS/pulls/424/comments","review_comment_url":"https://api.github.com/repos/aragon/aragonOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aragon/aragonOS/issues/424/comments","statuses_url":"https://api.github.com/repos/aragon/aragonOS/statuses/b96e224b772b1333a07951d98290c23af096f188","head":{"label":"aragon:fix-visibility","ref":"fix-visibility","sha":"b96e224b772b1333a07951d98290c23af096f188","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":87797080,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzc5NzA4MA==","name":"aragonOS","full_name":"aragon/aragonOS","private":false,"owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aragon/aragonOS","description":"Official reference implementation for aragonOS","fork":false,"url":"https://api.github.com/repos/aragon/aragonOS","forks_url":"https://api.github.com/repos/aragon/aragonOS/forks","keys_url":"https://api.github.com/repos/aragon/aragonOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragonOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragonOS/teams","hooks_url":"https://api.github.com/repos/aragon/aragonOS/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragonOS/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragonOS/events","assignees_url":"https://api.github.com/repos/aragon/aragonOS/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragonOS/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragonOS/tags","blobs_url":"https://api.github.com/repos/aragon/aragonOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragonOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragonOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragonOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragonOS/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragonOS/languages","stargazers_url":"https://api.github.com/repos/aragon/aragonOS/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragonOS/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragonOS/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragonOS/subscription","commits_url":"https://api.github.com/repos/aragon/aragonOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragonOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragonOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragonOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragonOS/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragonOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragonOS/merges","archive_url":"https://api.github.com/repos/aragon/aragonOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragonOS/downloads","issues_url":"https://api.github.com/repos/aragon/aragonOS/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragonOS/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragonOS/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragonOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragonOS/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragonOS/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragonOS/deployments","created_at":"2017-04-10T10:11:09Z","updated_at":"2018-09-19T08:01:09Z","pushed_at":"2018-09-18T13:23:38Z","git_url":"git://github.com/aragon/aragonOS.git","ssh_url":"git@github.com:aragon/aragonOS.git","clone_url":"https://github.com/aragon/aragonOS.git","svn_url":"https://github.com/aragon/aragonOS","homepage":"https://hack.aragon.org","size":4571,"stargazers_count":337,"watchers_count":337,"language":"Solidity","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":121,"open_issues":48,"watchers":337,"default_branch":"dev"}},"base":{"label":"aragon:dev","ref":"dev","sha":"c313662569d0d85654b0838206d8e560d2c61c26","user":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"repo":{"id":87797080,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzc5NzA4MA==","name":"aragonOS","full_name":"aragon/aragonOS","private":false,"owner":{"login":"aragon","id":24612534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjEyNTM0","avatar_url":"https://avatars1.githubusercontent.com/u/24612534?v=4","gravatar_id":"","url":"https://api.github.com/users/aragon","html_url":"https://github.com/aragon","followers_url":"https://api.github.com/users/aragon/followers","following_url":"https://api.github.com/users/aragon/following{/other_user}","gists_url":"https://api.github.com/users/aragon/gists{/gist_id}","starred_url":"https://api.github.com/users/aragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragon/subscriptions","organizations_url":"https://api.github.com/users/aragon/orgs","repos_url":"https://api.github.com/users/aragon/repos","events_url":"https://api.github.com/users/aragon/events{/privacy}","received_events_url":"https://api.github.com/users/aragon/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aragon/aragonOS","description":"Official reference implementation for aragonOS","fork":false,"url":"https://api.github.com/repos/aragon/aragonOS","forks_url":"https://api.github.com/repos/aragon/aragonOS/forks","keys_url":"https://api.github.com/repos/aragon/aragonOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragon/aragonOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragon/aragonOS/teams","hooks_url":"https://api.github.com/repos/aragon/aragonOS/hooks","issue_events_url":"https://api.github.com/repos/aragon/aragonOS/issues/events{/number}","events_url":"https://api.github.com/repos/aragon/aragonOS/events","assignees_url":"https://api.github.com/repos/aragon/aragonOS/assignees{/user}","branches_url":"https://api.github.com/repos/aragon/aragonOS/branches{/branch}","tags_url":"https://api.github.com/repos/aragon/aragonOS/tags","blobs_url":"https://api.github.com/repos/aragon/aragonOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragon/aragonOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragon/aragonOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragon/aragonOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragon/aragonOS/statuses/{sha}","languages_url":"https://api.github.com/repos/aragon/aragonOS/languages","stargazers_url":"https://api.github.com/repos/aragon/aragonOS/stargazers","contributors_url":"https://api.github.com/repos/aragon/aragonOS/contributors","subscribers_url":"https://api.github.com/repos/aragon/aragonOS/subscribers","subscription_url":"https://api.github.com/repos/aragon/aragonOS/subscription","commits_url":"https://api.github.com/repos/aragon/aragonOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragon/aragonOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragon/aragonOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragon/aragonOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragon/aragonOS/contents/{+path}","compare_url":"https://api.github.com/repos/aragon/aragonOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragon/aragonOS/merges","archive_url":"https://api.github.com/repos/aragon/aragonOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragon/aragonOS/downloads","issues_url":"https://api.github.com/repos/aragon/aragonOS/issues{/number}","pulls_url":"https://api.github.com/repos/aragon/aragonOS/pulls{/number}","milestones_url":"https://api.github.com/repos/aragon/aragonOS/milestones{/number}","notifications_url":"https://api.github.com/repos/aragon/aragonOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragon/aragonOS/labels{/name}","releases_url":"https://api.github.com/repos/aragon/aragonOS/releases{/id}","deployments_url":"https://api.github.com/repos/aragon/aragonOS/deployments","created_at":"2017-04-10T10:11:09Z","updated_at":"2018-09-19T08:01:09Z","pushed_at":"2018-09-18T13:23:38Z","git_url":"git://github.com/aragon/aragonOS.git","ssh_url":"git@github.com:aragon/aragonOS.git","clone_url":"https://github.com/aragon/aragonOS.git","svn_url":"https://github.com/aragon/aragonOS","homepage":"https://hack.aragon.org","size":4571,"stargazers_count":337,"watchers_count":337,"language":"Solidity","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":121,"open_issues":48,"watchers":337,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aragon/aragonOS/pulls/424"},"html":{"href":"https://github.com/aragon/aragonOS/pull/424"},"issue":{"href":"https://api.github.com/repos/aragon/aragonOS/issues/424"},"comments":{"href":"https://api.github.com/repos/aragon/aragonOS/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/aragon/aragonOS/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/aragon/aragonOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aragon/aragonOS/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/aragon/aragonOS/statuses/b96e224b772b1333a07951d98290c23af096f188"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bingen"}}