{"action":"created","comment":{"url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/comments/193332796","pull_request_review_id":126280121,"id":193332796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzMzMjc5Ng==","diff_hunk":"@@ -12,16 +12,11 @@\n // renderer process, this will have to do.  See github issue posted here to\n // electron: https://github.com/electron/electron/issues/9312\n \n-const { ipcRenderer, remote } = require('electron');\n+const { remote, desktopCapturer } = require('electron');","path":"js/desktopCapturer/getSources.js","position":5,"original_position":5,"commit_id":"3c75e79c61d0fb7084abda42c4ccc061b6f53d25","original_commit_id":"ebb963d67b36e7880d78e0d23dc551e32dbaec8c","user":{"login":"VishwasShashidhar","id":5968790,"node_id":"MDQ6VXNlcjU5Njg3OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5968790?v=4","gravatar_id":"","url":"https://api.github.com/users/VishwasShashidhar","html_url":"https://github.com/VishwasShashidhar","followers_url":"https://api.github.com/users/VishwasShashidhar/followers","following_url":"https://api.github.com/users/VishwasShashidhar/following{/other_user}","gists_url":"https://api.github.com/users/VishwasShashidhar/gists{/gist_id}","starred_url":"https://api.github.com/users/VishwasShashidhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishwasShashidhar/subscriptions","organizations_url":"https://api.github.com/users/VishwasShashidhar/orgs","repos_url":"https://api.github.com/users/VishwasShashidhar/repos","events_url":"https://api.github.com/users/VishwasShashidhar/events{/privacy}","received_events_url":"https://api.github.com/users/VishwasShashidhar/received_events","type":"User","site_admin":false},"body":"@KiranNiranjan please add a todo / deprecated comment so we remove it in the future versions.","created_at":"2018-06-06T08:33:10Z","updated_at":"2018-06-06T08:33:41Z","html_url":"https://github.com/symphonyoss/SymphonyElectron/pull/384#discussion_r193332796","pull_request_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/comments/193332796"},"html":{"href":"https://github.com/symphonyoss/SymphonyElectron/pull/384#discussion_r193332796"},"pull_request":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384"}},"in_reply_to_id":191495815},"pull_request":{"url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384","id":190851928,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwODUxOTI4","html_url":"https://github.com/symphonyoss/SymphonyElectron/pull/384","diff_url":"https://github.com/symphonyoss/SymphonyElectron/pull/384.diff","patch_url":"https://github.com/symphonyoss/SymphonyElectron/pull/384.patch","issue_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues/384","number":384,"state":"open","locked":false,"title":"ELECTRON-508 (Fix security issue with getSource and getSources)","user":{"login":"KiranNiranjan","id":13243259,"node_id":"MDQ6VXNlcjEzMjQzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/13243259?v=4","gravatar_id":"","url":"https://api.github.com/users/KiranNiranjan","html_url":"https://github.com/KiranNiranjan","followers_url":"https://api.github.com/users/KiranNiranjan/followers","following_url":"https://api.github.com/users/KiranNiranjan/following{/other_user}","gists_url":"https://api.github.com/users/KiranNiranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/KiranNiranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiranNiranjan/subscriptions","organizations_url":"https://api.github.com/users/KiranNiranjan/orgs","repos_url":"https://api.github.com/users/KiranNiranjan/repos","events_url":"https://api.github.com/users/KiranNiranjan/events{/privacy}","received_events_url":"https://api.github.com/users/KiranNiranjan/received_events","type":"User","site_admin":false},"body":"## Description\r\nPrevents exposing Electron's EventEmitter in the preload script [ELECTRON-508](https://perzoinc.atlassian.net/browse/ELECTRON-508)\r\n\r\n\r\n## Approach\r\nHow does this change address the problem?\r\n#### Problem with the code:\r\n - Electron's EventEmitter `ipcRenderer` was returned to the web app, which is capable of sending arbitrary IPC messages and interacting directly with the Node.js runtime.\r\n#### Fix:\r\n - Removed the unnecessary return statement \r\n\r\n## Spectron tests result\r\n[Electron-508 — Spectron.pdf](https://github.com/symphonyoss/SymphonyElectron/files/2044044/Electron-508.Spectron.pdf)\r\n\r\n## Unit tests result\r\n[Electron-508 — Unit Tests.pdf](https://github.com/symphonyoss/SymphonyElectron/files/2044045/Electron-508.Unit.Tests.pdf)\r\n\r\n\r\n## Open Questions if any and Todos\r\n- [X] Unit-Tests\r\n- [X] Documentation\r\n- [X] Automation-Tests\r\nWhen solved, check the box and explain the answer.\r\n","created_at":"2018-05-28T07:09:25Z","updated_at":"2018-06-06T08:33:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39d5476c0b76ace128b55de69e985650527a8937","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":946754999,"node_id":"MDU6TGFiZWw5NDY3NTQ5OTk=","url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/labels/18.11","name":"18.11","color":"f7bd83","default":false},{"id":939508765,"node_id":"MDU6TGFiZWw5Mzk1MDg3NjU=","url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/labels/cla-present","name":"cla-present","color":"ededed","default":false},{"id":866969797,"node_id":"MDU6TGFiZWw4NjY5Njk3OTc=","url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/labels/security","name":"security","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384/commits","review_comments_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384/comments","review_comment_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues/384/comments","statuses_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/statuses/3c75e79c61d0fb7084abda42c4ccc061b6f53d25","head":{"label":"KiranNiranjan:ELECTRON-508","ref":"ELECTRON-508","sha":"3c75e79c61d0fb7084abda42c4ccc061b6f53d25","user":{"login":"KiranNiranjan","id":13243259,"node_id":"MDQ6VXNlcjEzMjQzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/13243259?v=4","gravatar_id":"","url":"https://api.github.com/users/KiranNiranjan","html_url":"https://github.com/KiranNiranjan","followers_url":"https://api.github.com/users/KiranNiranjan/followers","following_url":"https://api.github.com/users/KiranNiranjan/following{/other_user}","gists_url":"https://api.github.com/users/KiranNiranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/KiranNiranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiranNiranjan/subscriptions","organizations_url":"https://api.github.com/users/KiranNiranjan/orgs","repos_url":"https://api.github.com/users/KiranNiranjan/repos","events_url":"https://api.github.com/users/KiranNiranjan/events{/privacy}","received_events_url":"https://api.github.com/users/KiranNiranjan/received_events","type":"User","site_admin":false},"repo":{"id":89199750,"node_id":"MDEwOlJlcG9zaXRvcnk4OTE5OTc1MA==","name":"SymphonyElectron","full_name":"KiranNiranjan/SymphonyElectron","owner":{"login":"KiranNiranjan","id":13243259,"node_id":"MDQ6VXNlcjEzMjQzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/13243259?v=4","gravatar_id":"","url":"https://api.github.com/users/KiranNiranjan","html_url":"https://github.com/KiranNiranjan","followers_url":"https://api.github.com/users/KiranNiranjan/followers","following_url":"https://api.github.com/users/KiranNiranjan/following{/other_user}","gists_url":"https://api.github.com/users/KiranNiranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/KiranNiranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiranNiranjan/subscriptions","organizations_url":"https://api.github.com/users/KiranNiranjan/orgs","repos_url":"https://api.github.com/users/KiranNiranjan/repos","events_url":"https://api.github.com/users/KiranNiranjan/events{/privacy}","received_events_url":"https://api.github.com/users/KiranNiranjan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KiranNiranjan/SymphonyElectron","description":null,"fork":true,"url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron","forks_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/forks","keys_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/teams","hooks_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/hooks","issue_events_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/issues/events{/number}","events_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/events","assignees_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/assignees{/user}","branches_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/branches{/branch}","tags_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/tags","blobs_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/git/refs{/sha}","trees_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/statuses/{sha}","languages_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/languages","stargazers_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/stargazers","contributors_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/contributors","subscribers_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/subscribers","subscription_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/subscription","commits_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/commits{/sha}","git_commits_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/git/commits{/sha}","comments_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/comments{/number}","issue_comment_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/issues/comments{/number}","contents_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/contents/{+path}","compare_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/merges","archive_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/downloads","issues_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/issues{/number}","pulls_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/pulls{/number}","milestones_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/milestones{/number}","notifications_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/labels{/name}","releases_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/releases{/id}","deployments_url":"https://api.github.com/repos/KiranNiranjan/SymphonyElectron/deployments","created_at":"2017-04-24T05:04:55Z","updated_at":"2018-05-25T04:48:12Z","pushed_at":"2018-06-06T07:30:17Z","git_url":"git://github.com/KiranNiranjan/SymphonyElectron.git","ssh_url":"git@github.com:KiranNiranjan/SymphonyElectron.git","clone_url":"https://github.com/KiranNiranjan/SymphonyElectron.git","svn_url":"https://github.com/KiranNiranjan/SymphonyElectron","homepage":null,"size":30335,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symphonyoss:master","ref":"master","sha":"3c2529bbdc4c1b36c1dd87cc39f9d513d97b3b03","user":{"login":"symphonyoss","id":16778380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzc4Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/16778380?v=4","gravatar_id":"","url":"https://api.github.com/users/symphonyoss","html_url":"https://github.com/symphonyoss","followers_url":"https://api.github.com/users/symphonyoss/followers","following_url":"https://api.github.com/users/symphonyoss/following{/other_user}","gists_url":"https://api.github.com/users/symphonyoss/gists{/gist_id}","starred_url":"https://api.github.com/users/symphonyoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphonyoss/subscriptions","organizations_url":"https://api.github.com/users/symphonyoss/orgs","repos_url":"https://api.github.com/users/symphonyoss/repos","events_url":"https://api.github.com/users/symphonyoss/events{/privacy}","received_events_url":"https://api.github.com/users/symphonyoss/received_events","type":"Organization","site_admin":false},"repo":{"id":69311918,"node_id":"MDEwOlJlcG9zaXRvcnk2OTMxMTkxOA==","name":"SymphonyElectron","full_name":"symphonyoss/SymphonyElectron","owner":{"login":"symphonyoss","id":16778380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzc4Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/16778380?v=4","gravatar_id":"","url":"https://api.github.com/users/symphonyoss","html_url":"https://github.com/symphonyoss","followers_url":"https://api.github.com/users/symphonyoss/followers","following_url":"https://api.github.com/users/symphonyoss/following{/other_user}","gists_url":"https://api.github.com/users/symphonyoss/gists{/gist_id}","starred_url":"https://api.github.com/users/symphonyoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symphonyoss/subscriptions","organizations_url":"https://api.github.com/users/symphonyoss/orgs","repos_url":"https://api.github.com/users/symphonyoss/repos","events_url":"https://api.github.com/users/symphonyoss/events{/privacy}","received_events_url":"https://api.github.com/users/symphonyoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symphonyoss/SymphonyElectron","description":null,"fork":false,"url":"https://api.github.com/repos/symphonyoss/SymphonyElectron","forks_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/forks","keys_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/teams","hooks_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/hooks","issue_events_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues/events{/number}","events_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/events","assignees_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/assignees{/user}","branches_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/branches{/branch}","tags_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/tags","blobs_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/git/refs{/sha}","trees_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/statuses/{sha}","languages_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/languages","stargazers_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/stargazers","contributors_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/contributors","subscribers_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/subscribers","subscription_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/subscription","commits_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/commits{/sha}","git_commits_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/git/commits{/sha}","comments_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/comments{/number}","issue_comment_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues/comments{/number}","contents_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/contents/{+path}","compare_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/merges","archive_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/downloads","issues_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues{/number}","pulls_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls{/number}","milestones_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/milestones{/number}","notifications_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/labels{/name}","releases_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/releases{/id}","deployments_url":"https://api.github.com/repos/symphonyoss/SymphonyElectron/deployments","created_at":"2016-09-27T02:33:08Z","updated_at":"2018-06-06T08:18:07Z","pushed_at":"2018-06-06T08:18:05Z","git_url":"git://github.com/symphonyoss/SymphonyElectron.git","ssh_url":"git@github.com:symphonyoss/SymphonyElectron.git","clone_url":"https://github.com/symphonyoss/SymphonyElectron.git","svn_url":"https://github.com/symphonyoss/SymphonyElectron","homepage":null,"size":33177,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":10,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384"},"html":{"href":"https://github.com/symphonyoss/SymphonyElectron/pull/384"},"issue":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues/384"},"comments":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/symphonyoss/SymphonyElectron/statuses/3c75e79c61d0fb7084abda42c4ccc061b6f53d25"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"VishwasShashidhar"}}