{"action":"created","comment":{"url":"https://api.github.com/repos/drekle/kops/pulls/comments/240781126","pull_request_review_id":183890692,"id":240781126,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc4MTEyNg==","diff_hunk":"@@ -0,0 +1,61 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package openstack\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"github.com/gophercloud/gophercloud/openstack/blockstorage/v2/volumes\"\n+\t\"k8s.io/kops/pkg/resources\"\n+\t\"k8s.io/kops/upup/pkg/fi\"\n+\t\"k8s.io/kops/upup/pkg/fi/cloudup/openstack\"","path":"pkg/resources/openstack/blockstorage.go","position":25,"original_position":25,"commit_id":"105d79c1288199437dd3a8d07f511ff899285b9a","original_commit_id":"105d79c1288199437dd3a8d07f511ff899285b9a","user":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"body":"I believe this will be used for deletion.  Ill probably worry about deletion after merge.","created_at":"2018-12-11T20:35:12Z","updated_at":"2018-12-11T20:35:12Z","html_url":"https://github.com/drekle/kops/pull/1#discussion_r240781126","pull_request_url":"https://api.github.com/repos/drekle/kops/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/drekle/kops/pulls/comments/240781126"},"html":{"href":"https://github.com/drekle/kops/pull/1#discussion_r240781126"},"pull_request":{"href":"https://api.github.com/repos/drekle/kops/pulls/1"}},"in_reply_to_id":240678435},"pull_request":{"url":"https://api.github.com/repos/drekle/kops/pulls/1","id":232307761,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzA3NzYx","html_url":"https://github.com/drekle/kops/pull/1","diff_url":"https://github.com/drekle/kops/pull/1.diff","patch_url":"https://github.com/drekle/kops/pull/1.patch","issue_url":"https://api.github.com/repos/drekle/kops/issues/1","number":1,"state":"open","locked":false,"title":"[WIP] Openstack working branch.","user":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"body":"*This branch will not be merged.*\r\n\r\nhttps://github.com/kubernetes/kops/issues/3566\r\n\r\nWhat isn't working:\r\n- hardcoded \"nova\" as the region in `master_volumes.go`.  Our compute regions are not the same as volume regions.  Instead of supporting this, I am working to resolve the way we region as this does not make sense to me to do.  ( Fixed in provisioning, fix in protokube )\r\n- deletion","created_at":"2018-11-20T12:57:56Z","updated_at":"2018-12-11T20:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8ee3dd3dc4da1f0716e3df176122b583f3b6569","assignee":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"assignees":[{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/drekle/kops/pulls/1/commits","review_comments_url":"https://api.github.com/repos/drekle/kops/pulls/1/comments","review_comment_url":"https://api.github.com/repos/drekle/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drekle/kops/issues/1/comments","statuses_url":"https://api.github.com/repos/drekle/kops/statuses/105d79c1288199437dd3a8d07f511ff899285b9a","head":{"label":"drekle:openstackWIP","ref":"openstackWIP","sha":"105d79c1288199437dd3a8d07f511ff899285b9a","user":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"repo":{"id":150459910,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0NTk5MTA=","name":"kops","full_name":"drekle/kops","private":false,"owner":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drekle/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/drekle/kops","forks_url":"https://api.github.com/repos/drekle/kops/forks","keys_url":"https://api.github.com/repos/drekle/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drekle/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drekle/kops/teams","hooks_url":"https://api.github.com/repos/drekle/kops/hooks","issue_events_url":"https://api.github.com/repos/drekle/kops/issues/events{/number}","events_url":"https://api.github.com/repos/drekle/kops/events","assignees_url":"https://api.github.com/repos/drekle/kops/assignees{/user}","branches_url":"https://api.github.com/repos/drekle/kops/branches{/branch}","tags_url":"https://api.github.com/repos/drekle/kops/tags","blobs_url":"https://api.github.com/repos/drekle/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drekle/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drekle/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/drekle/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drekle/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/drekle/kops/languages","stargazers_url":"https://api.github.com/repos/drekle/kops/stargazers","contributors_url":"https://api.github.com/repos/drekle/kops/contributors","subscribers_url":"https://api.github.com/repos/drekle/kops/subscribers","subscription_url":"https://api.github.com/repos/drekle/kops/subscription","commits_url":"https://api.github.com/repos/drekle/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/drekle/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/drekle/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/drekle/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/drekle/kops/contents/{+path}","compare_url":"https://api.github.com/repos/drekle/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drekle/kops/merges","archive_url":"https://api.github.com/repos/drekle/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drekle/kops/downloads","issues_url":"https://api.github.com/repos/drekle/kops/issues{/number}","pulls_url":"https://api.github.com/repos/drekle/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/drekle/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/drekle/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drekle/kops/labels{/name}","releases_url":"https://api.github.com/repos/drekle/kops/releases{/id}","deployments_url":"https://api.github.com/repos/drekle/kops/deployments","created_at":"2018-09-26T16:52:17Z","updated_at":"2018-09-26T16:52:24Z","pushed_at":"2018-12-11T03:34:24Z","git_url":"git://github.com/drekle/kops.git","ssh_url":"git@github.com:drekle/kops.git","clone_url":"https://github.com/drekle/kops.git","svn_url":"https://github.com/drekle/kops","homepage":"","size":187110,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"drekle:master","ref":"master","sha":"218b43c51a3fff2d083314abc42ea2f2369054d2","user":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"repo":{"id":150459910,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0NTk5MTA=","name":"kops","full_name":"drekle/kops","private":false,"owner":{"login":"drekle","id":1883554,"node_id":"MDQ6VXNlcjE4ODM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1883554?v=4","gravatar_id":"","url":"https://api.github.com/users/drekle","html_url":"https://github.com/drekle","followers_url":"https://api.github.com/users/drekle/followers","following_url":"https://api.github.com/users/drekle/following{/other_user}","gists_url":"https://api.github.com/users/drekle/gists{/gist_id}","starred_url":"https://api.github.com/users/drekle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drekle/subscriptions","organizations_url":"https://api.github.com/users/drekle/orgs","repos_url":"https://api.github.com/users/drekle/repos","events_url":"https://api.github.com/users/drekle/events{/privacy}","received_events_url":"https://api.github.com/users/drekle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drekle/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/drekle/kops","forks_url":"https://api.github.com/repos/drekle/kops/forks","keys_url":"https://api.github.com/repos/drekle/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drekle/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drekle/kops/teams","hooks_url":"https://api.github.com/repos/drekle/kops/hooks","issue_events_url":"https://api.github.com/repos/drekle/kops/issues/events{/number}","events_url":"https://api.github.com/repos/drekle/kops/events","assignees_url":"https://api.github.com/repos/drekle/kops/assignees{/user}","branches_url":"https://api.github.com/repos/drekle/kops/branches{/branch}","tags_url":"https://api.github.com/repos/drekle/kops/tags","blobs_url":"https://api.github.com/repos/drekle/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drekle/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drekle/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/drekle/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drekle/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/drekle/kops/languages","stargazers_url":"https://api.github.com/repos/drekle/kops/stargazers","contributors_url":"https://api.github.com/repos/drekle/kops/contributors","subscribers_url":"https://api.github.com/repos/drekle/kops/subscribers","subscription_url":"https://api.github.com/repos/drekle/kops/subscription","commits_url":"https://api.github.com/repos/drekle/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/drekle/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/drekle/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/drekle/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/drekle/kops/contents/{+path}","compare_url":"https://api.github.com/repos/drekle/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drekle/kops/merges","archive_url":"https://api.github.com/repos/drekle/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drekle/kops/downloads","issues_url":"https://api.github.com/repos/drekle/kops/issues{/number}","pulls_url":"https://api.github.com/repos/drekle/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/drekle/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/drekle/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drekle/kops/labels{/name}","releases_url":"https://api.github.com/repos/drekle/kops/releases{/id}","deployments_url":"https://api.github.com/repos/drekle/kops/deployments","created_at":"2018-09-26T16:52:17Z","updated_at":"2018-09-26T16:52:24Z","pushed_at":"2018-12-11T03:34:24Z","git_url":"git://github.com/drekle/kops.git","ssh_url":"git@github.com:drekle/kops.git","clone_url":"https://github.com/drekle/kops.git","svn_url":"https://github.com/drekle/kops","homepage":"","size":187110,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drekle/kops/pulls/1"},"html":{"href":"https://github.com/drekle/kops/pull/1"},"issue":{"href":"https://api.github.com/repos/drekle/kops/issues/1"},"comments":{"href":"https://api.github.com/repos/drekle/kops/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/drekle/kops/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/drekle/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drekle/kops/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/drekle/kops/statuses/105d79c1288199437dd3a8d07f511ff899285b9a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"drekle"}}