{"action":"created","issue":{"url":"https://api.github.com/repos/gobuffalo/buffalo/issues/911","repository_url":"https://api.github.com/repos/gobuffalo/buffalo","labels_url":"https://api.github.com/repos/gobuffalo/buffalo/issues/911/labels{/name}","comments_url":"https://api.github.com/repos/gobuffalo/buffalo/issues/911/comments","events_url":"https://api.github.com/repos/gobuffalo/buffalo/issues/911/events","html_url":"https://github.com/gobuffalo/buffalo/issues/911","id":295748569,"number":911,"title":"Flashes won't clear when using redis-backed session storage","user":{"login":"lflux","id":184966,"avatar_url":"https://avatars1.githubusercontent.com/u/184966?v=4","gravatar_id":"","url":"https://api.github.com/users/lflux","html_url":"https://github.com/lflux","followers_url":"https://api.github.com/users/lflux/followers","following_url":"https://api.github.com/users/lflux/following{/other_user}","gists_url":"https://api.github.com/users/lflux/gists{/gist_id}","starred_url":"https://api.github.com/users/lflux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lflux/subscriptions","organizations_url":"https://api.github.com/users/lflux/orgs","repos_url":"https://api.github.com/users/lflux/repos","events_url":"https://api.github.com/users/lflux/events{/privacy}","received_events_url":"https://api.github.com/users/lflux/received_events","type":"User","site_admin":false},"labels":[{"id":140466188,"url":"https://api.github.com/repos/gobuffalo/buffalo/labels/Help%20wanted","name":"Help wanted","color":"159818","default":false}],"state":"open","locked":false,"assignee":{"login":"paganotoni","id":645522,"avatar_url":"https://avatars0.githubusercontent.com/u/645522?v=4","gravatar_id":"","url":"https://api.github.com/users/paganotoni","html_url":"https://github.com/paganotoni","followers_url":"https://api.github.com/users/paganotoni/followers","following_url":"https://api.github.com/users/paganotoni/following{/other_user}","gists_url":"https://api.github.com/users/paganotoni/gists{/gist_id}","starred_url":"https://api.github.com/users/paganotoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paganotoni/subscriptions","organizations_url":"https://api.github.com/users/paganotoni/orgs","repos_url":"https://api.github.com/users/paganotoni/repos","events_url":"https://api.github.com/users/paganotoni/events{/privacy}","received_events_url":"https://api.github.com/users/paganotoni/received_events","type":"User","site_admin":false},"assignees":[{"login":"paganotoni","id":645522,"avatar_url":"https://avatars0.githubusercontent.com/u/645522?v=4","gravatar_id":"","url":"https://api.github.com/users/paganotoni","html_url":"https://github.com/paganotoni","followers_url":"https://api.github.com/users/paganotoni/followers","following_url":"https://api.github.com/users/paganotoni/following{/other_user}","gists_url":"https://api.github.com/users/paganotoni/gists{/gist_id}","starred_url":"https://api.github.com/users/paganotoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paganotoni/subscriptions","organizations_url":"https://api.github.com/users/paganotoni/orgs","repos_url":"https://api.github.com/users/paganotoni/repos","events_url":"https://api.github.com/users/paganotoni/events{/privacy}","received_events_url":"https://api.github.com/users/paganotoni/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-09T04:05:00Z","updated_at":"2018-04-06T01:44:43Z","closed_at":null,"author_association":"NONE","body":"Seeing that buffalo uses gorilla's sessions package, I wanted to replace the cookie storage with a redis-backed storage from `gopkg.in/boj/redistore.v1`. When I did this, flash messages won't clear after dismissing them and reloading the page.\r\n\r\nI created a repo at [lflux/sessionthing](https://github.com/lflux/sessionthing) where you can reproduce this by:\r\n1. Setting up a Redis server at `:6379`\r\n1. Cloning the repo and running `buffalo dev`\r\n1. Visit http://localhost:3000/flash which will redirect to `/`\r\n1. See the flash message `Success flash`. Dismiss and reload the page\r\n1. The flash message will persist.\r\n\r\nBy setting `useRedis = false` in app.go which uses the default cookie storage, the flash message will no longer persist over page loads."},"comment":{"url":"https://api.github.com/repos/gobuffalo/buffalo/issues/comments/379125320","html_url":"https://github.com/gobuffalo/buffalo/issues/911#issuecomment-379125320","issue_url":"https://api.github.com/repos/gobuffalo/buffalo/issues/911","id":379125320,"user":{"login":"paganotoni","id":645522,"avatar_url":"https://avatars0.githubusercontent.com/u/645522?v=4","gravatar_id":"","url":"https://api.github.com/users/paganotoni","html_url":"https://github.com/paganotoni","followers_url":"https://api.github.com/users/paganotoni/followers","following_url":"https://api.github.com/users/paganotoni/following{/other_user}","gists_url":"https://api.github.com/users/paganotoni/gists{/gist_id}","starred_url":"https://api.github.com/users/paganotoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paganotoni/subscriptions","organizations_url":"https://api.github.com/users/paganotoni/orgs","repos_url":"https://api.github.com/users/paganotoni/repos","events_url":"https://api.github.com/users/paganotoni/events{/privacy}","received_events_url":"https://api.github.com/users/paganotoni/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T01:44:43Z","updated_at":"2018-04-06T01:44:43Z","author_association":"MEMBER","body":"I Looked into this one, our problem seems to be \r\n\r\nhttps://github.com/gobuffalo/buffalo/blob/master/flash.go#L41\r\n\r\nIf we remove the `Save` call it works for redis, but will not work for our default session store."}}
{"actor":{"display_login":"paganotoni"}}