{"action":"created","issue":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/663","repository_url":"https://api.github.com/repos/KiCad/kicad-symbols","labels_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/663/labels{/name}","comments_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/663/comments","events_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/663/events","html_url":"https://github.com/KiCad/kicad-symbols/pull/663","id":330991387,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODM5NzY5","number":663,"title":"Added 1x18650 and 2x18650 cell battery holder","user":{"login":"Misca1234","id":25547797,"node_id":"MDQ6VXNlcjI1NTQ3Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/25547797?v=4","gravatar_id":"","url":"https://api.github.com/users/Misca1234","html_url":"https://github.com/Misca1234","followers_url":"https://api.github.com/users/Misca1234/followers","following_url":"https://api.github.com/users/Misca1234/following{/other_user}","gists_url":"https://api.github.com/users/Misca1234/gists{/gist_id}","starred_url":"https://api.github.com/users/Misca1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misca1234/subscriptions","organizations_url":"https://api.github.com/users/Misca1234/orgs","repos_url":"https://api.github.com/users/Misca1234/repos","events_url":"https://api.github.com/users/Misca1234/events{/privacy}","received_events_url":"https://api.github.com/users/Misca1234/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-10T18:31:12Z","updated_at":"2018-06-16T08:20:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/pulls/663","html_url":"https://github.com/KiCad/kicad-symbols/pull/663","diff_url":"https://github.com/KiCad/kicad-symbols/pull/663.diff","patch_url":"https://github.com/KiCad/kicad-symbols/pull/663.patch"},"body":"Suggestion for symbols for battery holder\r\n\r\nWhat are your thoughts about making symbols for battery holders?\r\nI deliberately added the battery type as a suffix it in the scheme so it is visible what type of battery it is.\r\n\r\n\r\n![bild](https://user-images.githubusercontent.com/25547797/41205033-f293a8d8-6cec-11e8-892b-6b869fbdcd0c.png)\r\n\r\n![bild](https://user-images.githubusercontent.com/25547797/41205036-f7b96a00-6cec-11e8-944b-f236452eeb36.png)\r\n\r\n![bild](https://user-images.githubusercontent.com/25547797/41205038-fc632e88-6cec-11e8-99b5-6e50cbb6a2d9.png)\r\n\r\n![bild](https://user-images.githubusercontent.com/25547797/41205042-03904056-6ced-11e8-878b-6f881d3492f9.png)\r\n\r\n![bild](https://user-images.githubusercontent.com/25547797/41205048-0c5e284c-6ced-11e8-87ca-1994f56375a9.png)\r\n\r\n![bild](https://user-images.githubusercontent.com/25547797/41205050-138fec72-6ced-11e8-9ab9-4cec2536c87a.png)\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n------------\r\nThanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:\r\n\r\n- [ ] Provide a URL to a datasheet for the symbol(s) you are contributing\r\n- [ ] An example screenshot image is very helpful\r\n- [ ] Ensure that the associated footprints match the [official footprint library](https://github.com/kicad/kicad-footprints)\r\n- [ ] If there are matching footprint PRs, provide link(s) as appropriate\r\n- [ ] Check the output of the Travis automated check scripts - fix any errors as required\r\n"},"comment":{"url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/comments/397796721","html_url":"https://github.com/KiCad/kicad-symbols/pull/663#issuecomment-397796721","issue_url":"https://api.github.com/repos/KiCad/kicad-symbols/issues/663","id":397796721,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzc5NjcyMQ==","user":{"login":"Misca1234","id":25547797,"node_id":"MDQ6VXNlcjI1NTQ3Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/25547797?v=4","gravatar_id":"","url":"https://api.github.com/users/Misca1234","html_url":"https://github.com/Misca1234","followers_url":"https://api.github.com/users/Misca1234/followers","following_url":"https://api.github.com/users/Misca1234/following{/other_user}","gists_url":"https://api.github.com/users/Misca1234/gists{/gist_id}","starred_url":"https://api.github.com/users/Misca1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Misca1234/subscriptions","organizations_url":"https://api.github.com/users/Misca1234/orgs","repos_url":"https://api.github.com/users/Misca1234/repos","events_url":"https://api.github.com/users/Misca1234/events{/privacy}","received_events_url":"https://api.github.com/users/Misca1234/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T08:20:37Z","updated_at":"2018-06-16T08:20:37Z","author_association":"CONTRIBUTOR","body":"\r\nNote, some of the battery holder footprint will not work, sp I suggest we agree on a symbol, for 1x, 2x, 3x, ... battery holder and if they should have, perhaps invisible power flags, etc.\r\n\r\nThen I remove this push and create pushes unique symbols for all the battery holders.\r\n"}}
{"actor":{"display_login":"Misca1234"}}