{"action":"created","issue":{"url":"https://api.github.com/repos/uclapi/uclapi/issues/636","repository_url":"https://api.github.com/repos/uclapi/uclapi","labels_url":"https://api.github.com/repos/uclapi/uclapi/issues/636/labels{/name}","comments_url":"https://api.github.com/repos/uclapi/uclapi/issues/636/comments","events_url":"https://api.github.com/repos/uclapi/uclapi/issues/636/events","html_url":"https://github.com/uclapi/uclapi/pull/636","id":344261927,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjk5MzU1","number":636,"title":"[NO NOT MERGE] AMP Support","user":{"login":"ChristopherHammond13","id":295396,"node_id":"MDQ6VXNlcjI5NTM5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/295396?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristopherHammond13","html_url":"https://github.com/ChristopherHammond13","followers_url":"https://api.github.com/users/ChristopherHammond13/followers","following_url":"https://api.github.com/users/ChristopherHammond13/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherHammond13/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherHammond13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherHammond13/subscriptions","organizations_url":"https://api.github.com/users/ChristopherHammond13/orgs","repos_url":"https://api.github.com/users/ChristopherHammond13/repos","events_url":"https://api.github.com/users/ChristopherHammond13/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherHammond13/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-25T01:48:36Z","updated_at":"2018-07-25T01:52:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/uclapi/uclapi/pulls/636","html_url":"https://github.com/uclapi/uclapi/pull/636","diff_url":"https://github.com/uclapi/uclapi/pull/636.diff","patch_url":"https://github.com/uclapi/uclapi/pull/636.patch"},"body":"## What does this PR do?\r\nThe way modules are set up in 2018/19 is different to previous years. Support for parsing the data format is being built, and this is a start.\r\n\r\nWe will not merge this until the Timetable API fully makes use of this new data (which may be required due to the composite nature of a Module ID and its associated Instance ID). We also plan to add module data to this, showing which modules are taught in each period (e.g. Term 1 / Term 2 / etc.)\r\n\r\nThis will resolve #468.\r\n\r\nPR has been opened early for initial code review, PEP 8 checking and build testing.\r\n\r\n## ✅ Pull Request checklist\r\n\r\n- [ ] Is this code complete?\r\n- [ ] Are tests done/modified?\r\n- [ ] Are docs written for this PR? (if applicable)\r\n\r\n## 🚨 Is this a breaking change for API clients?\r\nNo\r\n\r\n## :squirrel: Deploy notes\r\nMigrate and cache update.\r\n\r\n## Anything else\r\n"},"comment":{"url":"https://api.github.com/repos/uclapi/uclapi/issues/comments/407607106","html_url":"https://github.com/uclapi/uclapi/pull/636#issuecomment-407607106","issue_url":"https://api.github.com/repos/uclapi/uclapi/issues/636","id":407607106,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzYwNzEwNg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-07-25T01:52:17Z","updated_at":"2018-07-25T01:52:17Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=h1) Report\n> Merging [#636](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=desc) into [master](https://codecov.io/gh/uclapi/uclapi/commit/9eb122243285b3be68e53e0acdb2ee6728063d40?src=pr&el=desc) will **increase** coverage by `1.65%`.\n> The diff coverage is `97.03%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/uclapi/uclapi/pull/636/graphs/tree.svg?width=650&height=150&src=pr&token=pdy0SzRFwW)](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #636      +/-   ##\n==========================================\n+ Coverage   63.76%   65.42%   +1.65%     \n==========================================\n  Files          72       73       +1     \n  Lines        4554     4787     +233     \n==========================================\n+ Hits         2904     3132     +228     \n- Misses       1650     1655       +5\n```\n\n\n| [Impacted Files](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [backend/uclapi/uclapi/dbrouters.py](https://codecov.io/gh/uclapi/uclapi/pull/636/diff?src=pr&el=tree#diff-YmFja2VuZC91Y2xhcGkvdWNsYXBpL2Ricm91dGVycy5weQ==) | `100% <ø> (ø)` | :arrow_up: |\n| [...e/management/commands/update\\_timetable\\_gencache.py](https://codecov.io/gh/uclapi/uclapi/pull/636/diff?src=pr&el=tree#diff-YmFja2VuZC91Y2xhcGkvdGltZXRhYmxlL21hbmFnZW1lbnQvY29tbWFuZHMvdXBkYXRlX3RpbWV0YWJsZV9nZW5jYWNoZS5weQ==) | `0% <ø> (ø)` | :arrow_up: |\n| [backend/uclapi/timetable/app\\_helpers.py](https://codecov.io/gh/uclapi/uclapi/pull/636/diff?src=pr&el=tree#diff-YmFja2VuZC91Y2xhcGkvdGltZXRhYmxlL2FwcF9oZWxwZXJzLnB5) | `15.59% <0%> (ø)` | :arrow_up: |\n| [backend/uclapi/timetable/tests.py](https://codecov.io/gh/uclapi/uclapi/pull/636/diff?src=pr&el=tree#diff-YmFja2VuZC91Y2xhcGkvdGltZXRhYmxlL3Rlc3RzLnB5) | `100% <100%> (ø)` | :arrow_up: |\n| [backend/uclapi/timetable/models.py](https://codecov.io/gh/uclapi/uclapi/pull/636/diff?src=pr&el=tree#diff-YmFja2VuZC91Y2xhcGkvdGltZXRhYmxlL21vZGVscy5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| [backend/uclapi/timetable/amp.py](https://codecov.io/gh/uclapi/uclapi/pull/636/diff?src=pr&el=tree#diff-YmFja2VuZC91Y2xhcGkvdGltZXRhYmxlL2FtcC5weQ==) | `94.18% <94.18%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=footer). Last update [9eb1222...b001c82](https://codecov.io/gh/uclapi/uclapi/pull/636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}