{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tfjs-layers/issues/332","repository_url":"https://api.github.com/repos/tensorflow/tfjs-layers","labels_url":"https://api.github.com/repos/tensorflow/tfjs-layers/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-layers/issues/332/comments","events_url":"https://api.github.com/repos/tensorflow/tfjs-layers/issues/332/events","html_url":"https://github.com/tensorflow/tfjs-layers/pull/332","id":366852381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDI1NzY2","number":332,"title":"Let Sequential.fromConfig() handle non-array config objects","user":{"login":"caisq","id":16824702,"node_id":"MDQ6VXNlcjE2ODI0NzAy","avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-04T15:41:31Z","updated_at":"2018-11-26T18:40:49Z","closed_at":"2018-10-04T17:27:51Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/tensorflow/tfjs-layers/pulls/332","html_url":"https://github.com/tensorflow/tfjs-layers/pull/332","diff_url":"https://github.com/tensorflow/tfjs-layers/pull/332.diff","patch_url":"https://github.com/tensorflow/tfjs-layers/pull/332.patch"},"body":"Previously, it was assumed that the config object passed to a\r\nSequential model during serialization is always an array (of\r\nlayer configs). But in TensorFlow r1.11, a change was made to\r\nthe serialization of Sequential, such that the config is now\r\nan object with the 'layers' field.\r\n\r\nThis PR makes sure that TensorFlow.js is able to load such\r\nserialized Sequential models without error.\r\n\r\nBUG\r\n\r\nFixes: https://github.com/tensorflow/tfjs/issues/744\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tensorflow/tfjs-layers/332)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tfjs-layers/issues/comments/441749939","html_url":"https://github.com/tensorflow/tfjs-layers/pull/332#issuecomment-441749939","issue_url":"https://api.github.com/repos/tensorflow/tfjs-layers/issues/332","id":441749939,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTc0OTkzOQ==","user":{"login":"cbasavaraj","id":15706875,"node_id":"MDQ6VXNlcjE1NzA2ODc1","avatar_url":"https://avatars0.githubusercontent.com/u/15706875?v=4","gravatar_id":"","url":"https://api.github.com/users/cbasavaraj","html_url":"https://github.com/cbasavaraj","followers_url":"https://api.github.com/users/cbasavaraj/followers","following_url":"https://api.github.com/users/cbasavaraj/following{/other_user}","gists_url":"https://api.github.com/users/cbasavaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/cbasavaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbasavaraj/subscriptions","organizations_url":"https://api.github.com/users/cbasavaraj/orgs","repos_url":"https://api.github.com/users/cbasavaraj/repos","events_url":"https://api.github.com/users/cbasavaraj/events{/privacy}","received_events_url":"https://api.github.com/users/cbasavaraj/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T18:40:49Z","updated_at":"2018-11-26T18:40:49Z","author_association":"NONE","body":"Hi, I still get an error when on tf.loadModel(MODEL_URL). \r\n\r\n> Unhandled Promise Rejection: Error: Sequential.fromConfig called without an array of configs\r\n\r\nI have upgraded to the latest versions of Keras and tfjs. Am I missing anything? Thanks"}}
{"actor":{"display_login":"cbasavaraj"}}