{"action":"created","issue":{"url":"https://api.github.com/repos/VulcanJS/Vulcan/issues/2127","repository_url":"https://api.github.com/repos/VulcanJS/Vulcan","labels_url":"https://api.github.com/repos/VulcanJS/Vulcan/issues/2127/labels{/name}","comments_url":"https://api.github.com/repos/VulcanJS/Vulcan/issues/2127/comments","events_url":"https://api.github.com/repos/VulcanJS/Vulcan/issues/2127/events","html_url":"https://github.com/VulcanJS/Vulcan/pull/2127","id":380982711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDU1NDg5","number":2127,"title":"Don't reset forms to default with spurious prop changes","user":{"login":"jimrandomh","id":101191,"node_id":"MDQ6VXNlcjEwMTE5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/101191?v=4","gravatar_id":"","url":"https://api.github.com/users/jimrandomh","html_url":"https://github.com/jimrandomh","followers_url":"https://api.github.com/users/jimrandomh/followers","following_url":"https://api.github.com/users/jimrandomh/following{/other_user}","gists_url":"https://api.github.com/users/jimrandomh/gists{/gist_id}","starred_url":"https://api.github.com/users/jimrandomh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimrandomh/subscriptions","organizations_url":"https://api.github.com/users/jimrandomh/orgs","repos_url":"https://api.github.com/users/jimrandomh/repos","events_url":"https://api.github.com/users/jimrandomh/events{/privacy}","received_events_url":"https://api.github.com/users/jimrandomh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-15T03:19:33Z","updated_at":"2018-11-26T10:58:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/VulcanJS/Vulcan/pulls/2127","html_url":"https://github.com/VulcanJS/Vulcan/pull/2127","diff_url":"https://github.com/VulcanJS/Vulcan/pull/2127.diff","patch_url":"https://github.com/VulcanJS/Vulcan/pull/2127.patch"},"body":"Currently, when any props of a Form change, it reinitializes the form, resetting all values to defaults. Unfortunately, it's pretty easy to accidentally end up with some spurious property changes. Due to some ugly hacks in the LessWrong codebase's form components, most fields ended up ignoring the change, leaving a subtle bug in those components which didn't."},"comment":{"url":"https://api.github.com/repos/VulcanJS/Vulcan/issues/comments/441599604","html_url":"https://github.com/VulcanJS/Vulcan/pull/2127#issuecomment-441599604","issue_url":"https://api.github.com/repos/VulcanJS/Vulcan/issues/2127","id":441599604,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTU5OTYwNA==","user":{"login":"eric-burel","id":7983005,"node_id":"MDQ6VXNlcjc5ODMwMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/7983005?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-burel","html_url":"https://github.com/eric-burel","followers_url":"https://api.github.com/users/eric-burel/followers","following_url":"https://api.github.com/users/eric-burel/following{/other_user}","gists_url":"https://api.github.com/users/eric-burel/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-burel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-burel/subscriptions","organizations_url":"https://api.github.com/users/eric-burel/orgs","repos_url":"https://api.github.com/users/eric-burel/repos","events_url":"https://api.github.com/users/eric-burel/events{/privacy}","received_events_url":"https://api.github.com/users/eric-burel/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T10:58:41Z","updated_at":"2018-11-26T10:58:41Z","author_association":"CONTRIBUTOR","body":"I am writing a PR to test this better.\r\nHere are my idea about when state should be reset or not:\r\n\r\nProps that should trigger a state reset when modified: `'collection', 'collectionName', 'typeName', 'document', 'schema', 'currentUser'`.\r\n**Props I'd specifically like to have your opinion about**: `'fields', 'removeFields', 'prefilledProps', 'client'`. I think fields should reset, prefilledProps should not, and I don't know about the others.\r\n\r\nOther props should NOT reset the state, this includes graphQL mutation, prefilledProps (would be merged), callbacks, and visual/ui config."}}
{"actor":{"display_login":"eric-burel"}}