{"action":"closed","number":42612,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42612","id":197408848,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDA4ODQ4","html_url":"https://github.com/NixOS/nixpkgs/pull/42612","diff_url":"https://github.com/NixOS/nixpkgs/pull/42612.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/42612.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42612","number":42612,"state":"closed","locked":false,"title":"configuration-hackage2nix: language-puppet","user":{"login":"PierreR","id":93115,"node_id":"MDQ6VXNlcjkzMTE1","avatar_url":"https://avatars3.githubusercontent.com/u/93115?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"body":"Enable darwin build for language-puppet.\r\n\r\n###### Motivation for this change\r\n\r\nI would like to enable `darwin`build for `language-puppet`. `filecache` now works for `OSX` so this build should succeed.\r\nI do have os x user so this build will be quite useful.\r\nI have recently had an issue with nixpkgs commit 95eb2fa40e6f0edd625abdafe7d7b76e0c722263 that fails with \r\n ```\r\nIn file included from ./security_utilities/utilities.h:32:\r\n\r\n./security_utilities/errors.h:33:10: fatal error: '/nix/store/kmfa1i8rim3big8br77jcn3lfzf8b18w-MacOS_SDK-10.10/include/MacTypes.h' file not found\r\n\r\n#include \"/nix/store/kmfa1i8rim3big8br77jcn3lfzf8b18w-MacOS_SDK-10.10/include/MacTypes.h\"\r\n```\r\nThis error is not related to `language-puppet` per se.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] macOS (succeeds with a two weeks nixpkgs commit but fails with a more recent one)\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-06-26T12:42:58Z","updated_at":"2018-11-18T12:59:39Z","closed_at":"2018-11-18T12:59:38Z","merged_at":null,"merge_commit_sha":"d24ff8e7b2d2fdc328458391a954a2b87dd544c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":99513706,"node_id":"MDU6TGFiZWw5OTUxMzcwNg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20haskell","name":"6.topic: haskell","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42612/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42612/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42612/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/21616dea7a37480facaeaac4ec6a1cfb16412a9f","head":{"label":"PierreR:patch-1","ref":"patch-1","sha":"21616dea7a37480facaeaac4ec6a1cfb16412a9f","user":{"login":"PierreR","id":93115,"node_id":"MDQ6VXNlcjkzMTE1","avatar_url":"https://avatars3.githubusercontent.com/u/93115?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"repo":{"id":132147488,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxNDc0ODg=","name":"nixpkgs","full_name":"PierreR/nixpkgs","private":false,"owner":{"login":"PierreR","id":93115,"node_id":"MDQ6VXNlcjkzMTE1","avatar_url":"https://avatars3.githubusercontent.com/u/93115?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PierreR/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/PierreR/nixpkgs","forks_url":"https://api.github.com/repos/PierreR/nixpkgs/forks","keys_url":"https://api.github.com/repos/PierreR/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PierreR/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PierreR/nixpkgs/teams","hooks_url":"https://api.github.com/repos/PierreR/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/PierreR/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/PierreR/nixpkgs/events","assignees_url":"https://api.github.com/repos/PierreR/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/PierreR/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/PierreR/nixpkgs/tags","blobs_url":"https://api.github.com/repos/PierreR/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PierreR/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PierreR/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PierreR/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PierreR/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/PierreR/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/PierreR/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/PierreR/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/PierreR/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/PierreR/nixpkgs/subscription","commits_url":"https://api.github.com/repos/PierreR/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PierreR/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PierreR/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PierreR/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PierreR/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/PierreR/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PierreR/nixpkgs/merges","archive_url":"https://api.github.com/repos/PierreR/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PierreR/nixpkgs/downloads","issues_url":"https://api.github.com/repos/PierreR/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/PierreR/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/PierreR/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/PierreR/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PierreR/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/PierreR/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/PierreR/nixpkgs/deployments","created_at":"2018-05-04T14:01:55Z","updated_at":"2018-05-04T14:02:26Z","pushed_at":"2018-06-26T20:51:38Z","git_url":"git://github.com/PierreR/nixpkgs.git","ssh_url":"git@github.com:PierreR/nixpkgs.git","clone_url":"https://github.com/PierreR/nixpkgs.git","svn_url":"https://github.com/PierreR/nixpkgs","homepage":null,"size":798516,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b8ad7ec94b472afa146bfd8c707d60cab84e6dfd","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-11-18T12:52:04Z","pushed_at":"2018-11-18T12:48:53Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":886362,"stargazers_count":3008,"watchers_count":3008,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3194,"mirror_url":null,"archived":false,"open_issues_count":3369,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3194,"open_issues":3369,"watchers":3008,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42612"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/42612"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/42612"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/42612/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42612/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42612/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/21616dea7a37480facaeaac4ec6a1cfb16412a9f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"peti"}}