{"action":"created","issue":{"url":"https://api.github.com/repos/running-away-from/ios-app/issues/36","repository_url":"https://api.github.com/repos/running-away-from/ios-app","labels_url":"https://api.github.com/repos/running-away-from/ios-app/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/running-away-from/ios-app/issues/36/comments","events_url":"https://api.github.com/repos/running-away-from/ios-app/issues/36/events","html_url":"https://github.com/running-away-from/ios-app/pull/36","id":343210009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTI3MDc1","number":36,"title":"\"Add coordinators\" or \"how I overcomplicate life\"","user":{"login":"kluufger","id":35971588,"node_id":"MDQ6VXNlcjM1OTcxNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/35971588?v=4","gravatar_id":"","url":"https://api.github.com/users/kluufger","html_url":"https://github.com/kluufger","followers_url":"https://api.github.com/users/kluufger/followers","following_url":"https://api.github.com/users/kluufger/following{/other_user}","gists_url":"https://api.github.com/users/kluufger/gists{/gist_id}","starred_url":"https://api.github.com/users/kluufger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kluufger/subscriptions","organizations_url":"https://api.github.com/users/kluufger/orgs","repos_url":"https://api.github.com/users/kluufger/repos","events_url":"https://api.github.com/users/kluufger/events{/privacy}","received_events_url":"https://api.github.com/users/kluufger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-20T18:43:24Z","updated_at":"2018-07-20T18:48:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/running-away-from/ios-app/pulls/36","html_url":"https://github.com/running-away-from/ios-app/pull/36","diff_url":"https://github.com/running-away-from/ios-app/pull/36.diff","patch_url":"https://github.com/running-away-from/ios-app/pull/36.patch"},"body":"- [ ] create a \"container\" controller which would have the map (the one and only) and an embedded (one of `PreRunViewController`, `DuringRunViewController`, `PostRunViewController`) controller"},"comment":{"url":"https://api.github.com/repos/running-away-from/ios-app/issues/comments/406694219","html_url":"https://github.com/running-away-from/ios-app/pull/36#issuecomment-406694219","issue_url":"https://api.github.com/repos/running-away-from/ios-app/issues/36","id":406694219,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjY5NDIxOQ==","user":{"login":"kluufger","id":35971588,"node_id":"MDQ6VXNlcjM1OTcxNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/35971588?v=4","gravatar_id":"","url":"https://api.github.com/users/kluufger","html_url":"https://github.com/kluufger","followers_url":"https://api.github.com/users/kluufger/followers","following_url":"https://api.github.com/users/kluufger/following{/other_user}","gists_url":"https://api.github.com/users/kluufger/gists{/gist_id}","starred_url":"https://api.github.com/users/kluufger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kluufger/subscriptions","organizations_url":"https://api.github.com/users/kluufger/orgs","repos_url":"https://api.github.com/users/kluufger/repos","events_url":"https://api.github.com/users/kluufger/events{/privacy}","received_events_url":"https://api.github.com/users/kluufger/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T18:48:35Z","updated_at":"2018-07-20T18:48:35Z","author_association":"MEMBER","body":"<!--\n  1 Error: No CHANGELOG changes made\n  20 Warnings: Needs testing on a Phone if ch...\n  0 Messages\n  0 Markdowns\n-->\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Error\">\n          1 Error\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:no_entry_sign:</td>\n      <td data-sticky=\"false\">No CHANGELOG changes made</td>\n    </tr>\n  </tbody>\n</table>\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          20 Warnings\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">Needs testing on a Phone if change is non-trivial</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">The app files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the app changes.</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAF.playground/Pages/Run Service.xcplaygroundpage/Contents.swift#L13\">RAF.playground/Pages/Run Service.xcplaygroundpage/Contents.swift#L13</a> - Limit vertical whitespace to a single empty line. Currently 2.</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/App/AppDatabase.swift#L28\">RAFiOS/App/AppDatabase.swift#L28</a> - TODOs should be resolved (maybe use database pool instea…).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/App/AppDelegate.swift#L28\">RAFiOS/App/AppDelegate.swift#L28</a> - TODOs should be resolved (memory, proper path to db).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunCoordinator.swift#L6\">RAFiOS/Flows/New Run/NewRunCoordinator.swift#L6</a> - Line should be 120 characters or less: currently 127 characters</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunCoordinator.swift#L16\">RAFiOS/Flows/New Run/NewRunCoordinator.swift#L16</a> - TODOs should be resolved (can be in init?).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunCoordinator.swift#L32\">RAFiOS/Flows/New Run/NewRunCoordinator.swift#L32</a> - TODOs should be resolved (or showNewRun?).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunViewController.swift#L17\">RAFiOS/Flows/New Run/NewRunViewController.swift#L17</a> - TODOs should be resolved (TODO TODO).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunViewController.swift#L17\">RAFiOS/Flows/New Run/NewRunViewController.swift#L17</a> - TODOs should be resolved (TODO).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunViewController.swift#L17\">RAFiOS/Flows/New Run/NewRunViewController.swift#L17</a> - TODOs should be resolved.</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunViewController.swift#L28\">RAFiOS/Flows/New Run/NewRunViewController.swift#L28</a> - TODOs should be resolved (simplify, maybe move to a prot…).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunViewController.swift#L54\">RAFiOS/Flows/New Run/NewRunViewController.swift#L54</a> - TODOs should be resolved (move to view model).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/New Run/NewRunViewController.swift#L157\">RAFiOS/Flows/New Run/NewRunViewController.swift#L157</a> - TODOs should be resolved.</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/Run Details/RunDetailsCoordinator.swift#L6\">RAFiOS/Flows/Run Details/RunDetailsCoordinator.swift#L6</a> - TODOs should be resolved (can be in init?).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/Run Details/RunDetailsViewController.swift#L3\">RAFiOS/Flows/Run Details/RunDetailsViewController.swift#L3</a> - TODOs should be resolved (move to map view controller?).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/Run Details/RunDetailsViewController.swift#L11\">RAFiOS/Flows/Run Details/RunDetailsViewController.swift#L11</a> - TODOs should be resolved (simplify, maybe move to a prot…).</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/Run Details/RunDetailsViewController.swift#L112\">RAFiOS/Flows/Run Details/RunDetailsViewController.swift#L112</a> - TODOs should be resolved.</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/Run Details/RunDetailsViewModel.swift#L1\">RAFiOS/Flows/Run Details/RunDetailsViewModel.swift#L1</a> - File shouldn’t start with whitespace: currently starts with 1 whitespace characters</td>\n    </tr>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\"><a href=\"https://github.com/running-away-from/ios-app/blob/3599a26b70d6f8582f40c08c904c4ec15acd4335/RAFiOS/Flows/Run Details/RunDetailsViewModelSpec.swift#L1\">RAFiOS/Flows/Run Details/RunDetailsViewModelSpec.swift#L1</a> - File shouldn’t start with whitespace: currently starts with 1 whitespace characters</td>\n    </tr>\n  </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"https://danger.systems/\">Danger</a>\n</p>\n"}}
{"actor":{"display_login":"kluufger"}}