{"action":"created","comment":{"url":"https://api.github.com/repos/datrs/random-access-disk/pulls/comments/181351376","pull_request_review_id":111963875,"id":181351376,"diff_hunk":"@@ -1,38 +1,39 @@\n-mod sync {","path":"tests/sync.rs","position":1,"original_position":1,"commit_id":"bbba1a97f7475edf2acd68567c86171379998583","original_commit_id":"bbba1a97f7475edf2acd68567c86171379998583","user":{"login":"yoshuawuyts","id":2467194,"avatar_url":"https://avatars3.githubusercontent.com/u/2467194?v=4","gravatar_id":"","url":"https://api.github.com/users/yoshuawuyts","html_url":"https://github.com/yoshuawuyts","followers_url":"https://api.github.com/users/yoshuawuyts/followers","following_url":"https://api.github.com/users/yoshuawuyts/following{/other_user}","gists_url":"https://api.github.com/users/yoshuawuyts/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshuawuyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshuawuyts/subscriptions","organizations_url":"https://api.github.com/users/yoshuawuyts/orgs","repos_url":"https://api.github.com/users/yoshuawuyts/repos","events_url":"https://api.github.com/users/yoshuawuyts/events{/privacy}","received_events_url":"https://api.github.com/users/yoshuawuyts/received_events","type":"User","site_admin":false},"body":":D yeah - figured it already shows which file it's part of, so that's enough scopes! :D ","created_at":"2018-04-13T10:45:07Z","updated_at":"2018-04-13T10:45:08Z","html_url":"https://github.com/datrs/random-access-disk/pull/4#discussion_r181351376","pull_request_url":"https://api.github.com/repos/datrs/random-access-disk/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/datrs/random-access-disk/pulls/comments/181351376"},"html":{"href":"https://github.com/datrs/random-access-disk/pull/4#discussion_r181351376"},"pull_request":{"href":"https://api.github.com/repos/datrs/random-access-disk/pulls/4"}},"in_reply_to_id":181206335},"pull_request":{"url":"https://api.github.com/repos/datrs/random-access-disk/pulls/4","id":181268470,"html_url":"https://github.com/datrs/random-access-disk/pull/4","diff_url":"https://github.com/datrs/random-access-disk/pull/4.diff","patch_url":"https://github.com/datrs/random-access-disk/pull/4.patch","issue_url":"https://api.github.com/repos/datrs/random-access-disk/issues/4","number":4,"state":"open","locked":false,"title":"quickcheck","user":{"login":"yoshuawuyts","id":2467194,"avatar_url":"https://avatars3.githubusercontent.com/u/2467194?v=4","gravatar_id":"","url":"https://api.github.com/users/yoshuawuyts","html_url":"https://github.com/yoshuawuyts","followers_url":"https://api.github.com/users/yoshuawuyts/followers","following_url":"https://api.github.com/users/yoshuawuyts/following{/other_user}","gists_url":"https://api.github.com/users/yoshuawuyts/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshuawuyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshuawuyts/subscriptions","organizations_url":"https://api.github.com/users/yoshuawuyts/orgs","repos_url":"https://api.github.com/users/yoshuawuyts/repos","events_url":"https://api.github.com/users/yoshuawuyts/events{/privacy}","received_events_url":"https://api.github.com/users/yoshuawuyts/received_events","type":"User","site_admin":false},"body":"As with https://github.com/datrs/random-access-memory/pull/1, we're introducing quickcheck to automate testing. Wip for now.\r\n\r\nProbably should also think about how we handle reading out of bounds, because behavior is currently different between the implementations.\r\n\r\n## Changes\r\n- added quickcheck\r\n- we now reject reads if they read beyond where a write has occurred. This is now consistent with our memory backend too!\r\n- internally we now keep track of the file length.","created_at":"2018-04-12T17:04:19Z","updated_at":"2018-04-13T10:45:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75441caef80dc584708d5a5f3bae99c2af6fe8b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datrs/random-access-disk/pulls/4/commits","review_comments_url":"https://api.github.com/repos/datrs/random-access-disk/pulls/4/comments","review_comment_url":"https://api.github.com/repos/datrs/random-access-disk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datrs/random-access-disk/issues/4/comments","statuses_url":"https://api.github.com/repos/datrs/random-access-disk/statuses/bbba1a97f7475edf2acd68567c86171379998583","head":{"label":"datrs:quickcheck","ref":"quickcheck","sha":"bbba1a97f7475edf2acd68567c86171379998583","user":{"login":"datrs","id":36766516,"avatar_url":"https://avatars1.githubusercontent.com/u/36766516?v=4","gravatar_id":"","url":"https://api.github.com/users/datrs","html_url":"https://github.com/datrs","followers_url":"https://api.github.com/users/datrs/followers","following_url":"https://api.github.com/users/datrs/following{/other_user}","gists_url":"https://api.github.com/users/datrs/gists{/gist_id}","starred_url":"https://api.github.com/users/datrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datrs/subscriptions","organizations_url":"https://api.github.com/users/datrs/orgs","repos_url":"https://api.github.com/users/datrs/repos","events_url":"https://api.github.com/users/datrs/events{/privacy}","received_events_url":"https://api.github.com/users/datrs/received_events","type":"Organization","site_admin":false},"repo":{"id":126260973,"name":"random-access-disk","full_name":"datrs/random-access-disk","owner":{"login":"datrs","id":36766516,"avatar_url":"https://avatars1.githubusercontent.com/u/36766516?v=4","gravatar_id":"","url":"https://api.github.com/users/datrs","html_url":"https://github.com/datrs","followers_url":"https://api.github.com/users/datrs/followers","following_url":"https://api.github.com/users/datrs/following{/other_user}","gists_url":"https://api.github.com/users/datrs/gists{/gist_id}","starred_url":"https://api.github.com/users/datrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datrs/subscriptions","organizations_url":"https://api.github.com/users/datrs/orgs","repos_url":"https://api.github.com/users/datrs/repos","events_url":"https://api.github.com/users/datrs/events{/privacy}","received_events_url":"https://api.github.com/users/datrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datrs/random-access-disk","description":"Continuously read/write to disk using random offsets and lengths .","fork":false,"url":"https://api.github.com/repos/datrs/random-access-disk","forks_url":"https://api.github.com/repos/datrs/random-access-disk/forks","keys_url":"https://api.github.com/repos/datrs/random-access-disk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datrs/random-access-disk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datrs/random-access-disk/teams","hooks_url":"https://api.github.com/repos/datrs/random-access-disk/hooks","issue_events_url":"https://api.github.com/repos/datrs/random-access-disk/issues/events{/number}","events_url":"https://api.github.com/repos/datrs/random-access-disk/events","assignees_url":"https://api.github.com/repos/datrs/random-access-disk/assignees{/user}","branches_url":"https://api.github.com/repos/datrs/random-access-disk/branches{/branch}","tags_url":"https://api.github.com/repos/datrs/random-access-disk/tags","blobs_url":"https://api.github.com/repos/datrs/random-access-disk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datrs/random-access-disk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datrs/random-access-disk/git/refs{/sha}","trees_url":"https://api.github.com/repos/datrs/random-access-disk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datrs/random-access-disk/statuses/{sha}","languages_url":"https://api.github.com/repos/datrs/random-access-disk/languages","stargazers_url":"https://api.github.com/repos/datrs/random-access-disk/stargazers","contributors_url":"https://api.github.com/repos/datrs/random-access-disk/contributors","subscribers_url":"https://api.github.com/repos/datrs/random-access-disk/subscribers","subscription_url":"https://api.github.com/repos/datrs/random-access-disk/subscription","commits_url":"https://api.github.com/repos/datrs/random-access-disk/commits{/sha}","git_commits_url":"https://api.github.com/repos/datrs/random-access-disk/git/commits{/sha}","comments_url":"https://api.github.com/repos/datrs/random-access-disk/comments{/number}","issue_comment_url":"https://api.github.com/repos/datrs/random-access-disk/issues/comments{/number}","contents_url":"https://api.github.com/repos/datrs/random-access-disk/contents/{+path}","compare_url":"https://api.github.com/repos/datrs/random-access-disk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datrs/random-access-disk/merges","archive_url":"https://api.github.com/repos/datrs/random-access-disk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datrs/random-access-disk/downloads","issues_url":"https://api.github.com/repos/datrs/random-access-disk/issues{/number}","pulls_url":"https://api.github.com/repos/datrs/random-access-disk/pulls{/number}","milestones_url":"https://api.github.com/repos/datrs/random-access-disk/milestones{/number}","notifications_url":"https://api.github.com/repos/datrs/random-access-disk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datrs/random-access-disk/labels{/name}","releases_url":"https://api.github.com/repos/datrs/random-access-disk/releases{/id}","deployments_url":"https://api.github.com/repos/datrs/random-access-disk/deployments","created_at":"2018-03-22T01:18:03Z","updated_at":"2018-04-08T21:13:49Z","pushed_at":"2018-04-12T19:35:48Z","git_url":"git://github.com/datrs/random-access-disk.git","ssh_url":"git@github.com:datrs/random-access-disk.git","clone_url":"https://github.com/datrs/random-access-disk.git","svn_url":"https://github.com/datrs/random-access-disk","homepage":"","size":58,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"datrs:master","ref":"master","sha":"1194824569a4b706f672af5efb858978bfa2396a","user":{"login":"datrs","id":36766516,"avatar_url":"https://avatars1.githubusercontent.com/u/36766516?v=4","gravatar_id":"","url":"https://api.github.com/users/datrs","html_url":"https://github.com/datrs","followers_url":"https://api.github.com/users/datrs/followers","following_url":"https://api.github.com/users/datrs/following{/other_user}","gists_url":"https://api.github.com/users/datrs/gists{/gist_id}","starred_url":"https://api.github.com/users/datrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datrs/subscriptions","organizations_url":"https://api.github.com/users/datrs/orgs","repos_url":"https://api.github.com/users/datrs/repos","events_url":"https://api.github.com/users/datrs/events{/privacy}","received_events_url":"https://api.github.com/users/datrs/received_events","type":"Organization","site_admin":false},"repo":{"id":126260973,"name":"random-access-disk","full_name":"datrs/random-access-disk","owner":{"login":"datrs","id":36766516,"avatar_url":"https://avatars1.githubusercontent.com/u/36766516?v=4","gravatar_id":"","url":"https://api.github.com/users/datrs","html_url":"https://github.com/datrs","followers_url":"https://api.github.com/users/datrs/followers","following_url":"https://api.github.com/users/datrs/following{/other_user}","gists_url":"https://api.github.com/users/datrs/gists{/gist_id}","starred_url":"https://api.github.com/users/datrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datrs/subscriptions","organizations_url":"https://api.github.com/users/datrs/orgs","repos_url":"https://api.github.com/users/datrs/repos","events_url":"https://api.github.com/users/datrs/events{/privacy}","received_events_url":"https://api.github.com/users/datrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datrs/random-access-disk","description":"Continuously read/write to disk using random offsets and lengths .","fork":false,"url":"https://api.github.com/repos/datrs/random-access-disk","forks_url":"https://api.github.com/repos/datrs/random-access-disk/forks","keys_url":"https://api.github.com/repos/datrs/random-access-disk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datrs/random-access-disk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datrs/random-access-disk/teams","hooks_url":"https://api.github.com/repos/datrs/random-access-disk/hooks","issue_events_url":"https://api.github.com/repos/datrs/random-access-disk/issues/events{/number}","events_url":"https://api.github.com/repos/datrs/random-access-disk/events","assignees_url":"https://api.github.com/repos/datrs/random-access-disk/assignees{/user}","branches_url":"https://api.github.com/repos/datrs/random-access-disk/branches{/branch}","tags_url":"https://api.github.com/repos/datrs/random-access-disk/tags","blobs_url":"https://api.github.com/repos/datrs/random-access-disk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datrs/random-access-disk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datrs/random-access-disk/git/refs{/sha}","trees_url":"https://api.github.com/repos/datrs/random-access-disk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datrs/random-access-disk/statuses/{sha}","languages_url":"https://api.github.com/repos/datrs/random-access-disk/languages","stargazers_url":"https://api.github.com/repos/datrs/random-access-disk/stargazers","contributors_url":"https://api.github.com/repos/datrs/random-access-disk/contributors","subscribers_url":"https://api.github.com/repos/datrs/random-access-disk/subscribers","subscription_url":"https://api.github.com/repos/datrs/random-access-disk/subscription","commits_url":"https://api.github.com/repos/datrs/random-access-disk/commits{/sha}","git_commits_url":"https://api.github.com/repos/datrs/random-access-disk/git/commits{/sha}","comments_url":"https://api.github.com/repos/datrs/random-access-disk/comments{/number}","issue_comment_url":"https://api.github.com/repos/datrs/random-access-disk/issues/comments{/number}","contents_url":"https://api.github.com/repos/datrs/random-access-disk/contents/{+path}","compare_url":"https://api.github.com/repos/datrs/random-access-disk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datrs/random-access-disk/merges","archive_url":"https://api.github.com/repos/datrs/random-access-disk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datrs/random-access-disk/downloads","issues_url":"https://api.github.com/repos/datrs/random-access-disk/issues{/number}","pulls_url":"https://api.github.com/repos/datrs/random-access-disk/pulls{/number}","milestones_url":"https://api.github.com/repos/datrs/random-access-disk/milestones{/number}","notifications_url":"https://api.github.com/repos/datrs/random-access-disk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datrs/random-access-disk/labels{/name}","releases_url":"https://api.github.com/repos/datrs/random-access-disk/releases{/id}","deployments_url":"https://api.github.com/repos/datrs/random-access-disk/deployments","created_at":"2018-03-22T01:18:03Z","updated_at":"2018-04-08T21:13:49Z","pushed_at":"2018-04-12T19:35:48Z","git_url":"git://github.com/datrs/random-access-disk.git","ssh_url":"git@github.com:datrs/random-access-disk.git","clone_url":"https://github.com/datrs/random-access-disk.git","svn_url":"https://github.com/datrs/random-access-disk","homepage":"","size":58,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datrs/random-access-disk/pulls/4"},"html":{"href":"https://github.com/datrs/random-access-disk/pull/4"},"issue":{"href":"https://api.github.com/repos/datrs/random-access-disk/issues/4"},"comments":{"href":"https://api.github.com/repos/datrs/random-access-disk/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/datrs/random-access-disk/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/datrs/random-access-disk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datrs/random-access-disk/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/datrs/random-access-disk/statuses/bbba1a97f7475edf2acd68567c86171379998583"}},"author_association":"OWNER"}}
{"actor":{"display_login":"yoshuawuyts"}}