{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/gitbase-playground/pulls/comments/190830374","pull_request_review_id":123291160,"id":190830374,"diff_hunk":"@@ -0,0 +1,34 @@\n+.sidebar {\n+    display: flex;\n+    flex-direction: column;\n+\n+    min-height: 100%;\n+\n+    .header {\n+        flex: 0 0;\n+","path":"frontend/src/components/Sidebar.less","position":9,"original_position":9,"commit_id":"8ca34118b2d338c10090581afac4c49b75e582ec","original_commit_id":"8ca34118b2d338c10090581afac4c49b75e582ec","user":{"login":"smacker","id":406916,"avatar_url":"https://avatars0.githubusercontent.com/u/406916?v=4","gravatar_id":"","url":"https://api.github.com/users/smacker","html_url":"https://github.com/smacker","followers_url":"https://api.github.com/users/smacker/followers","following_url":"https://api.github.com/users/smacker/following{/other_user}","gists_url":"https://api.github.com/users/smacker/gists{/gist_id}","starred_url":"https://api.github.com/users/smacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smacker/subscriptions","organizations_url":"https://api.github.com/users/smacker/orgs","repos_url":"https://api.github.com/users/smacker/repos","events_url":"https://api.github.com/users/smacker/events{/privacy}","received_events_url":"https://api.github.com/users/smacker/received_events","type":"User","site_admin":false},"body":"1. I don't think any linter should be enforced for css blocks with <=3 rules or even 4-5 in some cases. Making it 6 lines instead of 3 would make it ugly and more difficult.\r\n2. Using new line to split css rules to groups is quite common practice. For example:\r\n- [Foundation UI](https://github.com/zurb/foundation-sites/blob/develop/scss/components/_switch.scss#L91)\r\n- [Semantic UI](https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/elements/button.less#L24)\r\nas you could notice they also don't apply any grouping rules for classes with only a few lines\r\n3. I thought a bit about how I split the groups. I have main groups like:\r\n    1. layout mode: position/display/flex/...\r\n    2. layout dimensions: width/height/margin/padding/...\r\n    3. decoration: background/blox-shadow/...\r\n    4. text: color/font-size/text-tranform/...\r\nand use them when that makes sense. (usually when a group has more than 2 rules with layout mode as an exception)\r\n\r\nIf I didn't convince you, please be welcome to reformat it in your own style as soon as you start writing css for this project.","created_at":"2018-05-25T08:52:28Z","updated_at":"2018-05-25T08:52:28Z","html_url":"https://github.com/src-d/gitbase-playground/pull/50#discussion_r190830374","pull_request_url":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/src-d/gitbase-playground/pulls/comments/190830374"},"html":{"href":"https://github.com/src-d/gitbase-playground/pull/50#discussion_r190830374"},"pull_request":{"href":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50"}},"in_reply_to_id":190599651},"pull_request":{"url":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50","id":189968055,"html_url":"https://github.com/src-d/gitbase-playground/pull/50","diff_url":"https://github.com/src-d/gitbase-playground/pull/50.diff","patch_url":"https://github.com/src-d/gitbase-playground/pull/50.patch","issue_url":"https://api.github.com/repos/src-d/gitbase-playground/issues/50","number":50,"state":"open","locked":false,"title":"Sidebar","user":{"login":"smacker","id":406916,"avatar_url":"https://avatars0.githubusercontent.com/u/406916?v=4","gravatar_id":"","url":"https://api.github.com/users/smacker","html_url":"https://github.com/smacker","followers_url":"https://api.github.com/users/smacker/followers","following_url":"https://api.github.com/users/smacker/following{/other_user}","gists_url":"https://api.github.com/users/smacker/gists{/gist_id}","starred_url":"https://api.github.com/users/smacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smacker/subscriptions","organizations_url":"https://api.github.com/users/smacker/orgs","repos_url":"https://api.github.com/users/smacker/repos","events_url":"https://api.github.com/users/smacker/events{/privacy}","received_events_url":"https://api.github.com/users/smacker/received_events","type":"User","site_admin":false},"body":"Based on #38 \r\nFixes #19\r\n\r\nNo interaction with right side. We have another issue for it.\r\n\r\n<img width=\"1234\" alt=\"screen shot 2018-05-23 at 15 01 39\" src=\"https://user-images.githubusercontent.com/406916/40426156-9f2a1f20-5e9a-11e8-822f-e4d0b043a7b4.png\">\r\n","created_at":"2018-05-23T13:04:53Z","updated_at":"2018-05-25T08:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc65fdca0f99c01fd85b7a9ef11ce145f44eb12f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carlosms","id":1469173,"avatar_url":"https://avatars0.githubusercontent.com/u/1469173?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosms","html_url":"https://github.com/carlosms","followers_url":"https://api.github.com/users/carlosms/followers","following_url":"https://api.github.com/users/carlosms/following{/other_user}","gists_url":"https://api.github.com/users/carlosms/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosms/subscriptions","organizations_url":"https://api.github.com/users/carlosms/orgs","repos_url":"https://api.github.com/users/carlosms/repos","events_url":"https://api.github.com/users/carlosms/events{/privacy}","received_events_url":"https://api.github.com/users/carlosms/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50/commits","review_comments_url":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50/comments","review_comment_url":"https://api.github.com/repos/src-d/gitbase-playground/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/gitbase-playground/issues/50/comments","statuses_url":"https://api.github.com/repos/src-d/gitbase-playground/statuses/8ca34118b2d338c10090581afac4c49b75e582ec","head":{"label":"smacker:sidebar","ref":"sidebar","sha":"8ca34118b2d338c10090581afac4c49b75e582ec","user":{"login":"smacker","id":406916,"avatar_url":"https://avatars0.githubusercontent.com/u/406916?v=4","gravatar_id":"","url":"https://api.github.com/users/smacker","html_url":"https://github.com/smacker","followers_url":"https://api.github.com/users/smacker/followers","following_url":"https://api.github.com/users/smacker/following{/other_user}","gists_url":"https://api.github.com/users/smacker/gists{/gist_id}","starred_url":"https://api.github.com/users/smacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smacker/subscriptions","organizations_url":"https://api.github.com/users/smacker/orgs","repos_url":"https://api.github.com/users/smacker/repos","events_url":"https://api.github.com/users/smacker/events{/privacy}","received_events_url":"https://api.github.com/users/smacker/received_events","type":"User","site_admin":false},"repo":{"id":134570504,"name":"gitbase-playground","full_name":"smacker/gitbase-playground","owner":{"login":"smacker","id":406916,"avatar_url":"https://avatars0.githubusercontent.com/u/406916?v=4","gravatar_id":"","url":"https://api.github.com/users/smacker","html_url":"https://github.com/smacker","followers_url":"https://api.github.com/users/smacker/followers","following_url":"https://api.github.com/users/smacker/following{/other_user}","gists_url":"https://api.github.com/users/smacker/gists{/gist_id}","starred_url":"https://api.github.com/users/smacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smacker/subscriptions","organizations_url":"https://api.github.com/users/smacker/orgs","repos_url":"https://api.github.com/users/smacker/repos","events_url":"https://api.github.com/users/smacker/events{/privacy}","received_events_url":"https://api.github.com/users/smacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smacker/gitbase-playground","description":"gitbase playground","fork":true,"url":"https://api.github.com/repos/smacker/gitbase-playground","forks_url":"https://api.github.com/repos/smacker/gitbase-playground/forks","keys_url":"https://api.github.com/repos/smacker/gitbase-playground/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smacker/gitbase-playground/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smacker/gitbase-playground/teams","hooks_url":"https://api.github.com/repos/smacker/gitbase-playground/hooks","issue_events_url":"https://api.github.com/repos/smacker/gitbase-playground/issues/events{/number}","events_url":"https://api.github.com/repos/smacker/gitbase-playground/events","assignees_url":"https://api.github.com/repos/smacker/gitbase-playground/assignees{/user}","branches_url":"https://api.github.com/repos/smacker/gitbase-playground/branches{/branch}","tags_url":"https://api.github.com/repos/smacker/gitbase-playground/tags","blobs_url":"https://api.github.com/repos/smacker/gitbase-playground/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smacker/gitbase-playground/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smacker/gitbase-playground/git/refs{/sha}","trees_url":"https://api.github.com/repos/smacker/gitbase-playground/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smacker/gitbase-playground/statuses/{sha}","languages_url":"https://api.github.com/repos/smacker/gitbase-playground/languages","stargazers_url":"https://api.github.com/repos/smacker/gitbase-playground/stargazers","contributors_url":"https://api.github.com/repos/smacker/gitbase-playground/contributors","subscribers_url":"https://api.github.com/repos/smacker/gitbase-playground/subscribers","subscription_url":"https://api.github.com/repos/smacker/gitbase-playground/subscription","commits_url":"https://api.github.com/repos/smacker/gitbase-playground/commits{/sha}","git_commits_url":"https://api.github.com/repos/smacker/gitbase-playground/git/commits{/sha}","comments_url":"https://api.github.com/repos/smacker/gitbase-playground/comments{/number}","issue_comment_url":"https://api.github.com/repos/smacker/gitbase-playground/issues/comments{/number}","contents_url":"https://api.github.com/repos/smacker/gitbase-playground/contents/{+path}","compare_url":"https://api.github.com/repos/smacker/gitbase-playground/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smacker/gitbase-playground/merges","archive_url":"https://api.github.com/repos/smacker/gitbase-playground/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smacker/gitbase-playground/downloads","issues_url":"https://api.github.com/repos/smacker/gitbase-playground/issues{/number}","pulls_url":"https://api.github.com/repos/smacker/gitbase-playground/pulls{/number}","milestones_url":"https://api.github.com/repos/smacker/gitbase-playground/milestones{/number}","notifications_url":"https://api.github.com/repos/smacker/gitbase-playground/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smacker/gitbase-playground/labels{/name}","releases_url":"https://api.github.com/repos/smacker/gitbase-playground/releases{/id}","deployments_url":"https://api.github.com/repos/smacker/gitbase-playground/deployments","created_at":"2018-05-23T13:02:47Z","updated_at":"2018-05-23T13:02:49Z","pushed_at":"2018-05-24T14:45:01Z","git_url":"git://github.com/smacker/gitbase-playground.git","ssh_url":"git@github.com:smacker/gitbase-playground.git","clone_url":"https://github.com/smacker/gitbase-playground.git","svn_url":"https://github.com/smacker/gitbase-playground","homepage":null,"size":3780,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"5967d42c9a4c206088d2be593ada537809a13dfc","user":{"login":"src-d","id":15128793,"avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":129398671,"name":"gitbase-playground","full_name":"src-d/gitbase-playground","owner":{"login":"src-d","id":15128793,"avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/src-d/gitbase-playground","description":"gitbase playground","fork":false,"url":"https://api.github.com/repos/src-d/gitbase-playground","forks_url":"https://api.github.com/repos/src-d/gitbase-playground/forks","keys_url":"https://api.github.com/repos/src-d/gitbase-playground/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/gitbase-playground/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/gitbase-playground/teams","hooks_url":"https://api.github.com/repos/src-d/gitbase-playground/hooks","issue_events_url":"https://api.github.com/repos/src-d/gitbase-playground/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/gitbase-playground/events","assignees_url":"https://api.github.com/repos/src-d/gitbase-playground/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/gitbase-playground/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/gitbase-playground/tags","blobs_url":"https://api.github.com/repos/src-d/gitbase-playground/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/gitbase-playground/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/gitbase-playground/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/gitbase-playground/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/gitbase-playground/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/gitbase-playground/languages","stargazers_url":"https://api.github.com/repos/src-d/gitbase-playground/stargazers","contributors_url":"https://api.github.com/repos/src-d/gitbase-playground/contributors","subscribers_url":"https://api.github.com/repos/src-d/gitbase-playground/subscribers","subscription_url":"https://api.github.com/repos/src-d/gitbase-playground/subscription","commits_url":"https://api.github.com/repos/src-d/gitbase-playground/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/gitbase-playground/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/gitbase-playground/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/gitbase-playground/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/gitbase-playground/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/gitbase-playground/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/gitbase-playground/merges","archive_url":"https://api.github.com/repos/src-d/gitbase-playground/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/gitbase-playground/downloads","issues_url":"https://api.github.com/repos/src-d/gitbase-playground/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/gitbase-playground/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/gitbase-playground/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/gitbase-playground/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/gitbase-playground/labels{/name}","releases_url":"https://api.github.com/repos/src-d/gitbase-playground/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/gitbase-playground/deployments","created_at":"2018-04-13T12:22:47Z","updated_at":"2018-05-23T14:03:24Z","pushed_at":"2018-05-24T14:45:32Z","git_url":"git://github.com/src-d/gitbase-playground.git","ssh_url":"git@github.com:src-d/gitbase-playground.git","clone_url":"https://github.com/src-d/gitbase-playground.git","svn_url":"https://github.com/src-d/gitbase-playground","homepage":null,"size":1766,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":30,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50"},"html":{"href":"https://github.com/src-d/gitbase-playground/pull/50"},"issue":{"href":"https://api.github.com/repos/src-d/gitbase-playground/issues/50"},"comments":{"href":"https://api.github.com/repos/src-d/gitbase-playground/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/gitbase-playground/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/gitbase-playground/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/gitbase-playground/statuses/8ca34118b2d338c10090581afac4c49b75e582ec"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smacker"}}