{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/204140363","pull_request_review_id":139174751,"id":204140363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE0MDM2Mw==","diff_hunk":"@@ -188,6 +189,7 @@ object KubernetesClientTests {\n   implicit def strToInstant(str: String): Instant =\n     strToDate(str).get\n \n+  implicit val as = ActorSystem(\"kubernetes-client-tests-actor-system\")","path":"tests/src/test/scala/whisk/core/containerpool/kubernetes/test/KubernetesClientTests.scala","position":null,"original_position":21,"commit_id":"cbeb6d273c44b57d429e917a71ecb1c80e7b6bd1","original_commit_id":"d80e7895c63b187ed56083f61bd194209cebc63b","user":{"login":"dgrove-oss","id":5099100,"node_id":"MDQ6VXNlcjUwOTkxMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5099100?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"body":"I don't remember any particular reason;  I think it may be as simple as that since we hadn't needed to have our hands on an ActorSystem before in the stubbed out test client it wasn't plumbed through.\r\n","created_at":"2018-07-20T18:58:10Z","updated_at":"2018-07-20T18:58:10Z","html_url":"https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r204140363","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/204140363"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r204140363"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812"}},"in_reply_to_id":203981897},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812","id":197581778,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTgxNzc4","html_url":"https://github.com/apache/incubator-openwhisk/pull/3812","diff_url":"https://github.com/apache/incubator-openwhisk/pull/3812.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/3812.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3812","number":3812,"state":"open","locked":false,"title":"ContainerClient + akka http alternative to HttpUtils","user":{"login":"tysonnorris","id":1638396,"node_id":"MDQ6VXNlcjE2MzgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1638396?v=4","gravatar_id":"","url":"https://api.github.com/users/tysonnorris","html_url":"https://github.com/tysonnorris","followers_url":"https://api.github.com/users/tysonnorris/followers","following_url":"https://api.github.com/users/tysonnorris/following{/other_user}","gists_url":"https://api.github.com/users/tysonnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonnorris/subscriptions","organizations_url":"https://api.github.com/users/tysonnorris/orgs","repos_url":"https://api.github.com/users/tysonnorris/repos","events_url":"https://api.github.com/users/tysonnorris/events{/privacy}","received_events_url":"https://api.github.com/users/tysonnorris/received_events","type":"User","site_admin":false},"body":"<!--- Provide a concise summary of your changes in the Title -->\r\n\r\n## Description\r\n<!--- Provide a detailed description of your changes. -->\r\n<!--- Include details of what problem you are solving and how your changes are tested. -->\r\nHttpUtils (http client for invoker -> action container) uses org.apache.http client that is synchronous and poor performing for concurrent requests. I ran into problems using it with concurrent activation support. Instead of trying to force that client to work, this PR is to work towards replacing it (or re-replacing it) with akka http based client.\r\n\r\nThis PR provides:\r\n* add a ContainerClient trait to define the http client interface \r\n* refactoring of HttpUtils to implement this trait (HttpUtils remains default for now)\r\n* add a PoolingContainerClient to provide a akka http based impl (based on PoolingRestClient)\r\n\r\n\r\n## Related issue and scope\r\n<!--- Please include a link to a related issue if there is one. -->\r\n- [ ] I opened an issue to propose and discuss this change (#????)\r\n\r\n## My changes affect the following components\r\n<!--- Select below all system components are affected by your change. -->\r\n<!--- Enter an `x` in all applicable boxes. -->\r\n- [ ] API\r\n- [ ] Controller\r\n- [ ] Message Bus (e.g., Kafka)\r\n- [ ] Loadbalancer\r\n- [x] Invoker\r\n- [ ] Intrinsic actions (e.g., sequences, conductors)\r\n- [ ] Data stores (e.g., CouchDB)\r\n- [ ] Tests\r\n- [ ] Deployment\r\n- [ ] CLI\r\n- [ ] General tooling\r\n- [ ] Documentation\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (generally a non-breaking change which closes an issue).\r\n- [x] Enhancement or new feature (adds new functionality).\r\n- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).\r\n\r\n## Checklist:\r\n<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->\r\n\r\n- [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).\r\n- [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).\r\n- [ ] I added tests to cover my changes.\r\n- [ ] My changes require further changes to the documentation.\r\n- [ ] I updated the documentation where necessary.\r\n\r\nInitial tests using this client to support this PR (for adding concurrency support in nodejs container) https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41 were good, where tests requiring coordinated completion of 128 concurrent requests succeeded, while same tests with existing HttpUtils/org.apache.http client failed with as few as 3 concurrent requests.\r\n\r\nMore tests will be done, but wanted to get early feedback on this in general (wip labelled).","created_at":"2018-06-26T23:50:23Z","updated_at":"2018-07-20T18:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f7f75db636a3aa4dc458fda96b81db4a24a7831","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":354873442,"node_id":"MDU6TGFiZWwzNTQ4NzM0NDI=","url":"https://api.github.com/repos/apache/incubator-openwhisk/labels/invoker","name":"invoker","color":"0e8a16","default":false},{"id":401834015,"node_id":"MDU6TGFiZWw0MDE4MzQwMTU=","url":"https://api.github.com/repos/apache/incubator-openwhisk/labels/wip","name":"wip","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3812/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/cbeb6d273c44b57d429e917a71ecb1c80e7b6bd1","head":{"label":"adobe-apiplatform:invoker-http-client","ref":"invoker-http-client","sha":"cbeb6d273c44b57d429e917a71ecb1c80e7b6bd1","user":{"login":"adobe-apiplatform","id":13855477,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODU1NDc3","avatar_url":"https://avatars2.githubusercontent.com/u/13855477?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe-apiplatform","html_url":"https://github.com/adobe-apiplatform","followers_url":"https://api.github.com/users/adobe-apiplatform/followers","following_url":"https://api.github.com/users/adobe-apiplatform/following{/other_user}","gists_url":"https://api.github.com/users/adobe-apiplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-apiplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-apiplatform/subscriptions","organizations_url":"https://api.github.com/users/adobe-apiplatform/orgs","repos_url":"https://api.github.com/users/adobe-apiplatform/repos","events_url":"https://api.github.com/users/adobe-apiplatform/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-apiplatform/received_events","type":"Organization","site_admin":false},"repo":{"id":101922099,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MjIwOTk=","name":"incubator-openwhisk","full_name":"adobe-apiplatform/incubator-openwhisk","owner":{"login":"adobe-apiplatform","id":13855477,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODU1NDc3","avatar_url":"https://avatars2.githubusercontent.com/u/13855477?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe-apiplatform","html_url":"https://github.com/adobe-apiplatform","followers_url":"https://api.github.com/users/adobe-apiplatform/followers","following_url":"https://api.github.com/users/adobe-apiplatform/following{/other_user}","gists_url":"https://api.github.com/users/adobe-apiplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-apiplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-apiplatform/subscriptions","organizations_url":"https://api.github.com/users/adobe-apiplatform/orgs","repos_url":"https://api.github.com/users/adobe-apiplatform/repos","events_url":"https://api.github.com/users/adobe-apiplatform/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-apiplatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-apiplatform/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":true,"url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk","forks_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-apiplatform/incubator-openwhisk/deployments","created_at":"2017-08-30T19:43:38Z","updated_at":"2018-07-11T22:52:38Z","pushed_at":"2018-07-20T18:45:04Z","git_url":"git://github.com/adobe-apiplatform/incubator-openwhisk.git","ssh_url":"git@github.com:adobe-apiplatform/incubator-openwhisk.git","clone_url":"https://github.com/adobe-apiplatform/incubator-openwhisk.git","svn_url":"https://github.com/adobe-apiplatform/incubator-openwhisk","homepage":"http://openwhisk.org","size":62502,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e96c1bbd5a0f54c923f0153116f7c1f165275e94","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAzOTM3Mw==","name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2018-07-19T15:46:02Z","pushed_at":"2018-07-20T18:45:06Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"git@github.com:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"http://openwhisk.org","size":62185,"stargazers_count":3351,"watchers_count":3351,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":631,"mirror_url":null,"archived":false,"open_issues_count":431,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":631,"open_issues":431,"watchers":3351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/3812"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3812"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3812/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3812/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/cbeb6d273c44b57d429e917a71ecb1c80e7b6bd1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgrove-oss"}}