{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega-samples/pulls/comments/234332354","pull_request_review_id":175960833,"id":234332354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDMzMjM1NA==","diff_hunk":"@@ -85,6 +87,10 @@ protected PravegaOutputFormat(ClientFactory externalClientFactory) {\n \n     @Override\n     public RecordWriter<String, V> getRecordWriter(TaskAttemptContext context) throws IOException, InterruptedException {\n+        return getRecordWriter(context, null);\n+    }\n+\n+    public RecordWriter<String, V> getRecordWriter(TaskAttemptContext context, String segmentRoutingKey) throws IOException, InterruptedException {","path":"hadoop-connector-examples/src/main/java/io/pravega/example/hadoop/wordcount/PravegaOutputFormat.java","position":null,"original_position":16,"commit_id":"4a04b0451daf82749be1269ddea504b7190ad2a1","original_commit_id":"1e14ffb7436c6f79f3d5201936dae37f419b52c5","user":{"login":"kevinhan88","id":24516773,"node_id":"MDQ6VXNlcjI0NTE2Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/24516773?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhan88","html_url":"https://github.com/kevinhan88","followers_url":"https://api.github.com/users/kevinhan88/followers","following_url":"https://api.github.com/users/kevinhan88/following{/other_user}","gists_url":"https://api.github.com/users/kevinhan88/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhan88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhan88/subscriptions","organizations_url":"https://api.github.com/users/kevinhan88/orgs","repos_url":"https://api.github.com/users/kevinhan88/repos","events_url":"https://api.github.com/users/kevinhan88/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhan88/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-11-16T20:04:56Z","updated_at":"2018-11-16T20:04:56Z","html_url":"https://github.com/pravega/pravega-samples/pull/164#discussion_r234332354","pull_request_url":"https://api.github.com/repos/pravega/pravega-samples/pulls/164","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega-samples/pulls/comments/234332354"},"html":{"href":"https://github.com/pravega/pravega-samples/pull/164#discussion_r234332354"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega-samples/pulls/164"}},"in_reply_to_id":234138957},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega-samples/pulls/164","id":230311329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzExMzI5","html_url":"https://github.com/pravega/pravega-samples/pull/164","diff_url":"https://github.com/pravega/pravega-samples/pull/164.diff","patch_url":"https://github.com/pravega/pravega-samples/pull/164.patch","issue_url":"https://api.github.com/repos/pravega/pravega-samples/issues/164","number":164,"state":"open","locked":false,"title":"[issue-162] improve the performance of Pravega based Terasort sample code","user":{"login":"kevinhan88","id":24516773,"node_id":"MDQ6VXNlcjI0NTE2Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/24516773?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhan88","html_url":"https://github.com/kevinhan88","followers_url":"https://api.github.com/users/kevinhan88/followers","following_url":"https://api.github.com/users/kevinhan88/following{/other_user}","gists_url":"https://api.github.com/users/kevinhan88/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhan88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhan88/subscriptions","organizations_url":"https://api.github.com/users/kevinhan88/orgs","repos_url":"https://api.github.com/users/kevinhan88/repos","events_url":"https://api.github.com/users/kevinhan88/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhan88/received_events","type":"User","site_admin":false},"body":"**Change log description**\r\nMade segments of stream configurable as the existing 3 segments are too limited for large scale performance test;\r\nImproved the stream writing to keep events sequence, by overwriting event routing key with task id.\r\n\r\n**Purpose of the change**\r\nFixes #162.\r\n\r\n**What the code does**\r\nAdd optional command-line parameter for TeraGen and Terasort job:\r\n- For TeraGen job, the 5th parameter is now the optional parameter to indicate the number of segments for the stream to be created.\r\n- For TeraSort job, the option 6th parameter is to indicate the number of segments for the stream to be created.\r\n\r\n`PravegaSequenceOutputFormat` is added as the subclass of `PravegaOutputFormat`, which returns `RecordWriter` with job id embedded. With this special record writer, original event key will be replaced by job task id, in order to ensure all the events from a particular job will go to a particular segment of stream. In the end, sequence of events are kept.\r\n\r\n**How to verify it**\r\nAdd Segments of Stream command parameter to control the number of segments of stream created.\r\nRead a particular segment of a stream to verify if all the events are from a particular job.\r\n\r\nSigned-off-by: kevinhan88 <kevinhan88@gmail.com>","created_at":"2018-11-13T00:32:56Z","updated_at":"2018-11-16T20:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86997f9abf9056242e9b514c38b7c285b531b702","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega-samples/pulls/164/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega-samples/pulls/164/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega-samples/issues/164/comments","statuses_url":"https://api.github.com/repos/pravega/pravega-samples/statuses/4a04b0451daf82749be1269ddea504b7190ad2a1","head":{"label":"kevinhan88:issue-162","ref":"issue-162","sha":"4a04b0451daf82749be1269ddea504b7190ad2a1","user":{"login":"kevinhan88","id":24516773,"node_id":"MDQ6VXNlcjI0NTE2Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/24516773?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhan88","html_url":"https://github.com/kevinhan88","followers_url":"https://api.github.com/users/kevinhan88/followers","following_url":"https://api.github.com/users/kevinhan88/following{/other_user}","gists_url":"https://api.github.com/users/kevinhan88/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhan88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhan88/subscriptions","organizations_url":"https://api.github.com/users/kevinhan88/orgs","repos_url":"https://api.github.com/users/kevinhan88/repos","events_url":"https://api.github.com/users/kevinhan88/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhan88/received_events","type":"User","site_admin":false},"repo":{"id":149064248,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwNjQyNDg=","name":"pravega-samples","full_name":"kevinhan88/pravega-samples","private":false,"owner":{"login":"kevinhan88","id":24516773,"node_id":"MDQ6VXNlcjI0NTE2Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/24516773?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinhan88","html_url":"https://github.com/kevinhan88","followers_url":"https://api.github.com/users/kevinhan88/followers","following_url":"https://api.github.com/users/kevinhan88/following{/other_user}","gists_url":"https://api.github.com/users/kevinhan88/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhan88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhan88/subscriptions","organizations_url":"https://api.github.com/users/kevinhan88/orgs","repos_url":"https://api.github.com/users/kevinhan88/repos","events_url":"https://api.github.com/users/kevinhan88/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhan88/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kevinhan88/pravega-samples","description":"Sample Applications for Pravega. ","fork":true,"url":"https://api.github.com/repos/kevinhan88/pravega-samples","forks_url":"https://api.github.com/repos/kevinhan88/pravega-samples/forks","keys_url":"https://api.github.com/repos/kevinhan88/pravega-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinhan88/pravega-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinhan88/pravega-samples/teams","hooks_url":"https://api.github.com/repos/kevinhan88/pravega-samples/hooks","issue_events_url":"https://api.github.com/repos/kevinhan88/pravega-samples/issues/events{/number}","events_url":"https://api.github.com/repos/kevinhan88/pravega-samples/events","assignees_url":"https://api.github.com/repos/kevinhan88/pravega-samples/assignees{/user}","branches_url":"https://api.github.com/repos/kevinhan88/pravega-samples/branches{/branch}","tags_url":"https://api.github.com/repos/kevinhan88/pravega-samples/tags","blobs_url":"https://api.github.com/repos/kevinhan88/pravega-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinhan88/pravega-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinhan88/pravega-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinhan88/pravega-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinhan88/pravega-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinhan88/pravega-samples/languages","stargazers_url":"https://api.github.com/repos/kevinhan88/pravega-samples/stargazers","contributors_url":"https://api.github.com/repos/kevinhan88/pravega-samples/contributors","subscribers_url":"https://api.github.com/repos/kevinhan88/pravega-samples/subscribers","subscription_url":"https://api.github.com/repos/kevinhan88/pravega-samples/subscription","commits_url":"https://api.github.com/repos/kevinhan88/pravega-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinhan88/pravega-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinhan88/pravega-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinhan88/pravega-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinhan88/pravega-samples/contents/{+path}","compare_url":"https://api.github.com/repos/kevinhan88/pravega-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinhan88/pravega-samples/merges","archive_url":"https://api.github.com/repos/kevinhan88/pravega-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinhan88/pravega-samples/downloads","issues_url":"https://api.github.com/repos/kevinhan88/pravega-samples/issues{/number}","pulls_url":"https://api.github.com/repos/kevinhan88/pravega-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinhan88/pravega-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinhan88/pravega-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinhan88/pravega-samples/labels{/name}","releases_url":"https://api.github.com/repos/kevinhan88/pravega-samples/releases{/id}","deployments_url":"https://api.github.com/repos/kevinhan88/pravega-samples/deployments","created_at":"2018-09-17T03:32:08Z","updated_at":"2018-09-17T03:32:10Z","pushed_at":"2018-11-16T20:00:24Z","git_url":"git://github.com/kevinhan88/pravega-samples.git","ssh_url":"git@github.com:kevinhan88/pravega-samples.git","clone_url":"https://github.com/kevinhan88/pravega-samples.git","svn_url":"https://github.com/kevinhan88/pravega-samples","homepage":"","size":1128,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:develop","ref":"develop","sha":"50353f7f2a08e0328ada35a93a0b845fe77a7f84","user":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":82957400,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjk1NzQwMA==","name":"pravega-samples","full_name":"pravega/pravega-samples","private":false,"owner":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pravega/pravega-samples","description":"Sample Applications for Pravega. ","fork":false,"url":"https://api.github.com/repos/pravega/pravega-samples","forks_url":"https://api.github.com/repos/pravega/pravega-samples/forks","keys_url":"https://api.github.com/repos/pravega/pravega-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega-samples/teams","hooks_url":"https://api.github.com/repos/pravega/pravega-samples/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega-samples/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega-samples/events","assignees_url":"https://api.github.com/repos/pravega/pravega-samples/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega-samples/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega-samples/tags","blobs_url":"https://api.github.com/repos/pravega/pravega-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega-samples/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega-samples/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega-samples/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega-samples/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega-samples/subscription","commits_url":"https://api.github.com/repos/pravega/pravega-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega-samples/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega-samples/merges","archive_url":"https://api.github.com/repos/pravega/pravega-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega-samples/downloads","issues_url":"https://api.github.com/repos/pravega/pravega-samples/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega-samples/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega-samples/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega-samples/deployments","created_at":"2017-02-23T18:17:08Z","updated_at":"2018-09-28T16:54:18Z","pushed_at":"2018-11-16T20:00:25Z","git_url":"git://github.com/pravega/pravega-samples.git","ssh_url":"git@github.com:pravega/pravega-samples.git","clone_url":"https://github.com/pravega/pravega-samples.git","svn_url":"https://github.com/pravega/pravega-samples","homepage":"","size":1086,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":12,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega-samples/pulls/164"},"html":{"href":"https://github.com/pravega/pravega-samples/pull/164"},"issue":{"href":"https://api.github.com/repos/pravega/pravega-samples/issues/164"},"comments":{"href":"https://api.github.com/repos/pravega/pravega-samples/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega-samples/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega-samples/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega-samples/statuses/4a04b0451daf82749be1269ddea504b7190ad2a1"}},"author_association":"NONE"}}
{"actor":{"display_login":"kevinhan88"}}