{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/178460408","pull_request_review_id":108520817,"id":178460408,"diff_hunk":"@@ -285,11 +286,19 @@ public function bindMethod($method, $callback)\n      *\n      * @param  array|string $method\n      * @return string\n+     *\n+     * @throws InvalidArgumentException","path":"src/Illuminate/Container/Container.php","position":13,"original_position":13,"commit_id":"02af7ac905cf64c572425ed491fe70a61bf7c681","original_commit_id":"02af7ac905cf64c572425ed491fe70a61bf7c681","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars1.githubusercontent.com/u/2829600?v=4","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"Please add a leading slash.","created_at":"2018-04-01T15:00:12Z","updated_at":"2018-04-01T15:00:17Z","html_url":"https://github.com/laravel/framework/pull/23767#discussion_r178460408","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/23767","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/178460408"},"html":{"href":"https://github.com/laravel/framework/pull/23767#discussion_r178460408"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/23767"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/23767","id":178701526,"html_url":"https://github.com/laravel/framework/pull/23767","diff_url":"https://github.com/laravel/framework/pull/23767.diff","patch_url":"https://github.com/laravel/framework/pull/23767.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/23767","number":23767,"state":"open","locked":false,"title":"[5.6] Container bindMethod improvement","user":{"login":"TBlindaruk","id":12684601,"avatar_url":"https://avatars1.githubusercontent.com/u/12684601?v=4","gravatar_id":"","url":"https://api.github.com/users/TBlindaruk","html_url":"https://github.com/TBlindaruk","followers_url":"https://api.github.com/users/TBlindaruk/followers","following_url":"https://api.github.com/users/TBlindaruk/following{/other_user}","gists_url":"https://api.github.com/users/TBlindaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/TBlindaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBlindaruk/subscriptions","organizations_url":"https://api.github.com/users/TBlindaruk/orgs","repos_url":"https://api.github.com/users/TBlindaruk/repos","events_url":"https://api.github.com/users/TBlindaruk/events{/privacy}","received_events_url":"https://api.github.com/users/TBlindaruk/received_events","type":"User","site_admin":false},"body":"**Problem:**\r\nWhen we try to use  bindMethod with array count 1\r\n\r\n```PHP\r\n$container->bindMethod([\\Illuminate\\Tests\\Container\\ContainerTestCallStub::class], function ($stub) {\r\n            return $stub->unresolvable('foo', 'bar');\r\n        });\r\n```\r\nthen we give a notice:\r\n\r\n_Undefined offset: 1_\r\n\r\n---\r\n\r\nThis PR will give a normal exception message for the user.\r\n\r\n\r\n---\r\n\r\nWhat are you think about this PR?\r\nIn case if it will be ok, then I can make a PR for 5.7 with strict comparing:\r\n\r\n```PHP\r\nif (count($method) === 2) \r\n```\r\ninstead\r\n```PHP\r\nif (count($method) > 1) \r\n```","created_at":"2018-03-31T21:35:57Z","updated_at":"2018-04-01T15:00:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07413cc4479ad9bae2e97634619a3eb94a35ea8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/23767/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/23767/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/23767/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/02af7ac905cf64c572425ed491fe70a61bf7c681","head":{"label":"TBlindaruk:parseBindMethod_exception","ref":"parseBindMethod_exception","sha":"02af7ac905cf64c572425ed491fe70a61bf7c681","user":{"login":"TBlindaruk","id":12684601,"avatar_url":"https://avatars1.githubusercontent.com/u/12684601?v=4","gravatar_id":"","url":"https://api.github.com/users/TBlindaruk","html_url":"https://github.com/TBlindaruk","followers_url":"https://api.github.com/users/TBlindaruk/followers","following_url":"https://api.github.com/users/TBlindaruk/following{/other_user}","gists_url":"https://api.github.com/users/TBlindaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/TBlindaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBlindaruk/subscriptions","organizations_url":"https://api.github.com/users/TBlindaruk/orgs","repos_url":"https://api.github.com/users/TBlindaruk/repos","events_url":"https://api.github.com/users/TBlindaruk/events{/privacy}","received_events_url":"https://api.github.com/users/TBlindaruk/received_events","type":"User","site_admin":false},"repo":{"id":125646947,"name":"laravel_framework","full_name":"TBlindaruk/laravel_framework","owner":{"login":"TBlindaruk","id":12684601,"avatar_url":"https://avatars1.githubusercontent.com/u/12684601?v=4","gravatar_id":"","url":"https://api.github.com/users/TBlindaruk","html_url":"https://github.com/TBlindaruk","followers_url":"https://api.github.com/users/TBlindaruk/followers","following_url":"https://api.github.com/users/TBlindaruk/following{/other_user}","gists_url":"https://api.github.com/users/TBlindaruk/gists{/gist_id}","starred_url":"https://api.github.com/users/TBlindaruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBlindaruk/subscriptions","organizations_url":"https://api.github.com/users/TBlindaruk/orgs","repos_url":"https://api.github.com/users/TBlindaruk/repos","events_url":"https://api.github.com/users/TBlindaruk/events{/privacy}","received_events_url":"https://api.github.com/users/TBlindaruk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TBlindaruk/laravel_framework","description":null,"fork":true,"url":"https://api.github.com/repos/TBlindaruk/laravel_framework","forks_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/forks","keys_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/teams","hooks_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/hooks","issue_events_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/issues/events{/number}","events_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/events","assignees_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/assignees{/user}","branches_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/branches{/branch}","tags_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/tags","blobs_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/statuses/{sha}","languages_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/languages","stargazers_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/stargazers","contributors_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/contributors","subscribers_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/subscribers","subscription_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/subscription","commits_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/contents/{+path}","compare_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/merges","archive_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/downloads","issues_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/issues{/number}","pulls_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/pulls{/number}","milestones_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/milestones{/number}","notifications_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/labels{/name}","releases_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/releases{/id}","deployments_url":"https://api.github.com/repos/TBlindaruk/laravel_framework/deployments","created_at":"2018-03-17T16:12:08Z","updated_at":"2018-03-31T23:43:16Z","pushed_at":"2018-04-01T13:09:44Z","git_url":"git://github.com/TBlindaruk/laravel_framework.git","ssh_url":"git@github.com:TBlindaruk/laravel_framework.git","clone_url":"https://github.com/TBlindaruk/laravel_framework.git","svn_url":"https://github.com/TBlindaruk/laravel_framework","homepage":"http://laravel.com","size":33105,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"laravel:5.6","ref":"5.6","sha":"5fa5a65e14f1683dba1eeee41431bf653711b0ff","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2018-04-01T14:23:16Z","pushed_at":"2018-04-01T14:59:53Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":33077,"stargazers_count":11539,"watchers_count":11539,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5286,"mirror_url":null,"archived":false,"open_issues_count":265,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5286,"open_issues":265,"watchers":11539,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/23767"},"html":{"href":"https://github.com/laravel/framework/pull/23767"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/23767"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/23767/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/23767/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/23767/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/02af7ac905cf64c572425ed491fe70a61bf7c681"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GrahamCampbell"}}