{"action":"created","issue":{"url":"https://api.github.com/repos/holochain/holochain-rust/issues/149","repository_url":"https://api.github.com/repos/holochain/holochain-rust","labels_url":"https://api.github.com/repos/holochain/holochain-rust/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/issues/149/comments","events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/149/events","html_url":"https://github.com/holochain/holochain-rust/pull/149","id":342342267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjYzOTU1","number":149,"title":"Upgraded docker and Makefile","user":{"login":"sphinxc0re","id":3702016,"node_id":"MDQ6VXNlcjM3MDIwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3702016?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinxc0re","html_url":"https://github.com/sphinxc0re","followers_url":"https://api.github.com/users/sphinxc0re/followers","following_url":"https://api.github.com/users/sphinxc0re/following{/other_user}","gists_url":"https://api.github.com/users/sphinxc0re/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinxc0re/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinxc0re/subscriptions","organizations_url":"https://api.github.com/users/sphinxc0re/orgs","repos_url":"https://api.github.com/users/sphinxc0re/repos","events_url":"https://api.github.com/users/sphinxc0re/events{/privacy}","received_events_url":"https://api.github.com/users/sphinxc0re/received_events","type":"User","site_admin":false},"labels":[{"id":937673517,"node_id":"MDU6TGFiZWw5Mzc2NzM1MTc=","url":"https://api.github.com/repos/holochain/holochain-rust/labels/review","name":"review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-07-18T14:02:01Z","updated_at":"2018-07-20T08:46:18Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/149","html_url":"https://github.com/holochain/holochain-rust/pull/149","diff_url":"https://github.com/holochain/holochain-rust/pull/149.diff","patch_url":"https://github.com/holochain/holochain-rust/pull/149.patch"},"body":"## Summary\r\n\r\nWhile I was moving the docker automated build to the `holochain` org, the build of our Dockerfile errored while installing clippy. It seems like clippy is now officially supported by the rust core team and inside the component collection of `rustup`. This means better support but also that I had to do some adjustments. As of this update we will be using:\r\n\r\n - `nightly-2018-07-17` for our tools (`rustfmt`, `clippy`)\r\n - `nightly-2018-06-01` for Wasm compilation\r\n - `stable` for everything else\r\n\r\nThe upgrade of `rustfmt` again will result in some reformatting. I intentionally didn't include the changes of that because the changes will still have to go though the docker hub build. Also as I suspected, the resulting reformatting won't be too heavy since it only touches some imports.\r\n\r\nI also did some changes to the Makefile. I purposely removed the `--verbose` flag from the regular Rust build to (drum roll) reduce verbosity.\r\n\r\n~Another thing I changed was the call to clippy. It now is called without any flags to prevent unwanted behavior. We should always stick to the default community standards and this helps a lot with doing so.~ \r\n\r\n*The CI will probably fail because it will be using the old docker image*\r\n\r\n## What reviewers can do\r\nYou can check out the branch locally, run the build script (`. docker/build-ubuntu`), run the formatting script (`. docker/run-fmt`) and check whether the tests run using `. docker/run-test`"},"comment":{"url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments/406532671","html_url":"https://github.com/holochain/holochain-rust/pull/149#issuecomment-406532671","issue_url":"https://api.github.com/repos/holochain/holochain-rust/issues/149","id":406532671,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjUzMjY3MQ==","user":{"login":"sphinxc0re","id":3702016,"node_id":"MDQ6VXNlcjM3MDIwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3702016?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinxc0re","html_url":"https://github.com/sphinxc0re","followers_url":"https://api.github.com/users/sphinxc0re/followers","following_url":"https://api.github.com/users/sphinxc0re/following{/other_user}","gists_url":"https://api.github.com/users/sphinxc0re/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinxc0re/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinxc0re/subscriptions","organizations_url":"https://api.github.com/users/sphinxc0re/orgs","repos_url":"https://api.github.com/users/sphinxc0re/repos","events_url":"https://api.github.com/users/sphinxc0re/events{/privacy}","received_events_url":"https://api.github.com/users/sphinxc0re/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T08:46:18Z","updated_at":"2018-07-20T08:46:18Z","author_association":"COLLABORATOR","body":"Hmm... test are working for me."}}
{"actor":{"display_login":"sphinxc0re"}}