{"action":"opened","number":165,"pull_request":{"url":"https://api.github.com/repos/kubedb/operator/pulls/165","id":186165294,"html_url":"https://github.com/kubedb/operator/pull/165","diff_url":"https://github.com/kubedb/operator/pull/165.diff","patch_url":"https://github.com/kubedb/operator/pull/165.patch","issue_url":"https://api.github.com/repos/kubedb/operator/issues/165","number":165,"state":"open","locked":false,"title":"Disable admission controllers for webhook server","user":{"login":"tamalsaha","id":94814,"avatar_url":"https://avatars1.githubusercontent.com/u/94814?v=4","gravatar_id":"","url":"https://api.github.com/users/tamalsaha","html_url":"https://github.com/tamalsaha","followers_url":"https://api.github.com/users/tamalsaha/followers","following_url":"https://api.github.com/users/tamalsaha/following{/other_user}","gists_url":"https://api.github.com/users/tamalsaha/gists{/gist_id}","starred_url":"https://api.github.com/users/tamalsaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamalsaha/subscriptions","organizations_url":"https://api.github.com/users/tamalsaha/orgs","repos_url":"https://api.github.com/users/tamalsaha/repos","events_url":"https://api.github.com/users/tamalsaha/events{/privacy}","received_events_url":"https://api.github.com/users/tamalsaha/received_events","type":"User","site_admin":false},"body":"Since [1.10 release](https://github.com/kubernetes/apiserver/blob/release-1.10/pkg/server/options/recommended.go#L43) admission options are enabled by default . This was not the case in 1.9 release. Admission plugins seem unnecessary for a webhook server. So, I am disabling it.\r\n\r\nIf this is left enabled, then RBAC permissions need to be updated accordingly.\r\n```\r\n- apiGroups:\r\n  - admissionregistration.k8s.io\r\n  resources:\r\n    - mutatingwebhookconfigurations\r\n    - validatingwebhookconfigurations\r\n  verbs: [\"get\",\"list\"]\r\n```","created_at":"2018-05-05T16:50:56Z","updated_at":"2018-05-05T16:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubedb/operator/pulls/165/commits","review_comments_url":"https://api.github.com/repos/kubedb/operator/pulls/165/comments","review_comment_url":"https://api.github.com/repos/kubedb/operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubedb/operator/issues/165/comments","statuses_url":"https://api.github.com/repos/kubedb/operator/statuses/76e7ffbf9b3ca8aab48185872083def16c3c4126","head":{"label":"kubedb:x7","ref":"x7","sha":"76e7ffbf9b3ca8aab48185872083def16c3c4126","user":{"login":"kubedb","id":26101272,"avatar_url":"https://avatars1.githubusercontent.com/u/26101272?v=4","gravatar_id":"","url":"https://api.github.com/users/kubedb","html_url":"https://github.com/kubedb","followers_url":"https://api.github.com/users/kubedb/followers","following_url":"https://api.github.com/users/kubedb/following{/other_user}","gists_url":"https://api.github.com/users/kubedb/gists{/gist_id}","starred_url":"https://api.github.com/users/kubedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubedb/subscriptions","organizations_url":"https://api.github.com/users/kubedb/orgs","repos_url":"https://api.github.com/users/kubedb/repos","events_url":"https://api.github.com/users/kubedb/events{/privacy}","received_events_url":"https://api.github.com/users/kubedb/received_events","type":"Organization","site_admin":false},"repo":{"id":91857856,"name":"operator","full_name":"kubedb/operator","owner":{"login":"kubedb","id":26101272,"avatar_url":"https://avatars1.githubusercontent.com/u/26101272?v=4","gravatar_id":"","url":"https://api.github.com/users/kubedb","html_url":"https://github.com/kubedb","followers_url":"https://api.github.com/users/kubedb/followers","following_url":"https://api.github.com/users/kubedb/following{/other_user}","gists_url":"https://api.github.com/users/kubedb/gists{/gist_id}","starred_url":"https://api.github.com/users/kubedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubedb/subscriptions","organizations_url":"https://api.github.com/users/kubedb/orgs","repos_url":"https://api.github.com/users/kubedb/repos","events_url":"https://api.github.com/users/kubedb/events{/privacy}","received_events_url":"https://api.github.com/users/kubedb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubedb/operator","description":"KubeDB Operator","fork":false,"url":"https://api.github.com/repos/kubedb/operator","forks_url":"https://api.github.com/repos/kubedb/operator/forks","keys_url":"https://api.github.com/repos/kubedb/operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubedb/operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubedb/operator/teams","hooks_url":"https://api.github.com/repos/kubedb/operator/hooks","issue_events_url":"https://api.github.com/repos/kubedb/operator/issues/events{/number}","events_url":"https://api.github.com/repos/kubedb/operator/events","assignees_url":"https://api.github.com/repos/kubedb/operator/assignees{/user}","branches_url":"https://api.github.com/repos/kubedb/operator/branches{/branch}","tags_url":"https://api.github.com/repos/kubedb/operator/tags","blobs_url":"https://api.github.com/repos/kubedb/operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubedb/operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubedb/operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubedb/operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubedb/operator/statuses/{sha}","languages_url":"https://api.github.com/repos/kubedb/operator/languages","stargazers_url":"https://api.github.com/repos/kubedb/operator/stargazers","contributors_url":"https://api.github.com/repos/kubedb/operator/contributors","subscribers_url":"https://api.github.com/repos/kubedb/operator/subscribers","subscription_url":"https://api.github.com/repos/kubedb/operator/subscription","commits_url":"https://api.github.com/repos/kubedb/operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubedb/operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubedb/operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubedb/operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubedb/operator/contents/{+path}","compare_url":"https://api.github.com/repos/kubedb/operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubedb/operator/merges","archive_url":"https://api.github.com/repos/kubedb/operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubedb/operator/downloads","issues_url":"https://api.github.com/repos/kubedb/operator/issues{/number}","pulls_url":"https://api.github.com/repos/kubedb/operator/pulls{/number}","milestones_url":"https://api.github.com/repos/kubedb/operator/milestones{/number}","notifications_url":"https://api.github.com/repos/kubedb/operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubedb/operator/labels{/name}","releases_url":"https://api.github.com/repos/kubedb/operator/releases{/id}","deployments_url":"https://api.github.com/repos/kubedb/operator/deployments","created_at":"2017-05-20T01:43:33Z","updated_at":"2018-05-03T21:03:06Z","pushed_at":"2018-05-05T16:50:34Z","git_url":"git://github.com/kubedb/operator.git","ssh_url":"git@github.com:kubedb/operator.git","clone_url":"https://github.com/kubedb/operator.git","svn_url":"https://github.com/kubedb/operator","homepage":"https://kubedb.com","size":11805,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":44,"default_branch":"master"}},"base":{"label":"kubedb:master","ref":"master","sha":"b2c1d86d170b14112a894ee9ae7c907f340a7b85","user":{"login":"kubedb","id":26101272,"avatar_url":"https://avatars1.githubusercontent.com/u/26101272?v=4","gravatar_id":"","url":"https://api.github.com/users/kubedb","html_url":"https://github.com/kubedb","followers_url":"https://api.github.com/users/kubedb/followers","following_url":"https://api.github.com/users/kubedb/following{/other_user}","gists_url":"https://api.github.com/users/kubedb/gists{/gist_id}","starred_url":"https://api.github.com/users/kubedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubedb/subscriptions","organizations_url":"https://api.github.com/users/kubedb/orgs","repos_url":"https://api.github.com/users/kubedb/repos","events_url":"https://api.github.com/users/kubedb/events{/privacy}","received_events_url":"https://api.github.com/users/kubedb/received_events","type":"Organization","site_admin":false},"repo":{"id":91857856,"name":"operator","full_name":"kubedb/operator","owner":{"login":"kubedb","id":26101272,"avatar_url":"https://avatars1.githubusercontent.com/u/26101272?v=4","gravatar_id":"","url":"https://api.github.com/users/kubedb","html_url":"https://github.com/kubedb","followers_url":"https://api.github.com/users/kubedb/followers","following_url":"https://api.github.com/users/kubedb/following{/other_user}","gists_url":"https://api.github.com/users/kubedb/gists{/gist_id}","starred_url":"https://api.github.com/users/kubedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubedb/subscriptions","organizations_url":"https://api.github.com/users/kubedb/orgs","repos_url":"https://api.github.com/users/kubedb/repos","events_url":"https://api.github.com/users/kubedb/events{/privacy}","received_events_url":"https://api.github.com/users/kubedb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubedb/operator","description":"KubeDB Operator","fork":false,"url":"https://api.github.com/repos/kubedb/operator","forks_url":"https://api.github.com/repos/kubedb/operator/forks","keys_url":"https://api.github.com/repos/kubedb/operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubedb/operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubedb/operator/teams","hooks_url":"https://api.github.com/repos/kubedb/operator/hooks","issue_events_url":"https://api.github.com/repos/kubedb/operator/issues/events{/number}","events_url":"https://api.github.com/repos/kubedb/operator/events","assignees_url":"https://api.github.com/repos/kubedb/operator/assignees{/user}","branches_url":"https://api.github.com/repos/kubedb/operator/branches{/branch}","tags_url":"https://api.github.com/repos/kubedb/operator/tags","blobs_url":"https://api.github.com/repos/kubedb/operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubedb/operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubedb/operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubedb/operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubedb/operator/statuses/{sha}","languages_url":"https://api.github.com/repos/kubedb/operator/languages","stargazers_url":"https://api.github.com/repos/kubedb/operator/stargazers","contributors_url":"https://api.github.com/repos/kubedb/operator/contributors","subscribers_url":"https://api.github.com/repos/kubedb/operator/subscribers","subscription_url":"https://api.github.com/repos/kubedb/operator/subscription","commits_url":"https://api.github.com/repos/kubedb/operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubedb/operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubedb/operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubedb/operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubedb/operator/contents/{+path}","compare_url":"https://api.github.com/repos/kubedb/operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubedb/operator/merges","archive_url":"https://api.github.com/repos/kubedb/operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubedb/operator/downloads","issues_url":"https://api.github.com/repos/kubedb/operator/issues{/number}","pulls_url":"https://api.github.com/repos/kubedb/operator/pulls{/number}","milestones_url":"https://api.github.com/repos/kubedb/operator/milestones{/number}","notifications_url":"https://api.github.com/repos/kubedb/operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubedb/operator/labels{/name}","releases_url":"https://api.github.com/repos/kubedb/operator/releases{/id}","deployments_url":"https://api.github.com/repos/kubedb/operator/deployments","created_at":"2017-05-20T01:43:33Z","updated_at":"2018-05-03T21:03:06Z","pushed_at":"2018-05-05T16:50:34Z","git_url":"git://github.com/kubedb/operator.git","ssh_url":"git@github.com:kubedb/operator.git","clone_url":"https://github.com/kubedb/operator.git","svn_url":"https://github.com/kubedb/operator","homepage":"https://kubedb.com","size":11805,"stargazers_count":44,"watchers_count":44,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubedb/operator/pulls/165"},"html":{"href":"https://github.com/kubedb/operator/pull/165"},"issue":{"href":"https://api.github.com/repos/kubedb/operator/issues/165"},"comments":{"href":"https://api.github.com/repos/kubedb/operator/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/kubedb/operator/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/kubedb/operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubedb/operator/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/kubedb/operator/statuses/76e7ffbf9b3ca8aab48185872083def16c3c4126"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"tamalsaha"}}