{"action":"created","comment":{"url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments/220213264","pull_request_review_id":158539922,"id":220213264,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDIxMzI2NA==","diff_hunk":"@@ -315,15 +315,19 @@ class OrderBook extends EventEmitter {\n   /**\n    * Send all local orders to a given peer in an [[OrdersPacket].\n    * @param reqId the request id of a [[GetOrdersPacket]] packet that this method is responding to\n+   * @param pairIds comes from Handshakestate, to send only supported pairs to peer","path":"lib/orderbook/OrderBook.ts","position":4,"original_position":4,"commit_id":"0e1fee155fc3c1b90c462cf4ffced284692f2aed","original_commit_id":"0e1fee155fc3c1b90c462cf4ffced284692f2aed","user":{"login":"moshababo","id":17073733,"node_id":"MDQ6VXNlcjE3MDczNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/17073733?v=4","gravatar_id":"","url":"https://api.github.com/users/moshababo","html_url":"https://github.com/moshababo","followers_url":"https://api.github.com/users/moshababo/followers","following_url":"https://api.github.com/users/moshababo/following{/other_user}","gists_url":"https://api.github.com/users/moshababo/gists{/gist_id}","starred_url":"https://api.github.com/users/moshababo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshababo/subscriptions","organizations_url":"https://api.github.com/users/moshababo/orgs","repos_url":"https://api.github.com/users/moshababo/repos","events_url":"https://api.github.com/users/moshababo/events{/privacy}","received_events_url":"https://api.github.com/users/moshababo/received_events","type":"User","site_admin":false},"body":"it actually doesn't come from `handshakeState`, but from the request packet payload, which we shouldn't mention here (unless we'll rather emit the packet entirely from `Pool`). `handshakeState` supposed to be used for the unilateral `broadcastOrder`. ","created_at":"2018-09-25T14:22:20Z","updated_at":"2018-09-25T14:34:45Z","html_url":"https://github.com/ExchangeUnion/xud/pull/526#discussion_r220213264","pull_request_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments/220213264"},"html":{"href":"https://github.com/ExchangeUnion/xud/pull/526#discussion_r220213264"},"pull_request":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526"}}},"pull_request":{"url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526","id":217951759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3OTUxNzU5","html_url":"https://github.com/ExchangeUnion/xud/pull/526","diff_url":"https://github.com/ExchangeUnion/xud/pull/526.diff","patch_url":"https://github.com/ExchangeUnion/xud/pull/526.patch","issue_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/526","number":526,"state":"open","locked":false,"title":"Added fetching supported pairs for GetOrdersPacket","user":{"login":"rsercano","id":3640368,"node_id":"MDQ6VXNlcjM2NDAzNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/3640368?v=4","gravatar_id":"","url":"https://api.github.com/users/rsercano","html_url":"https://github.com/rsercano","followers_url":"https://api.github.com/users/rsercano/followers","following_url":"https://api.github.com/users/rsercano/following{/other_user}","gists_url":"https://api.github.com/users/rsercano/gists{/gist_id}","starred_url":"https://api.github.com/users/rsercano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsercano/subscriptions","organizations_url":"https://api.github.com/users/rsercano/orgs","repos_url":"https://api.github.com/users/rsercano/repos","events_url":"https://api.github.com/users/rsercano/events{/privacy}","received_events_url":"https://api.github.com/users/rsercano/received_events","type":"User","site_admin":false},"body":"Solves #454 \r\n\r\nHello Daniel,\r\n\r\nas we discussed I've changed `sendOrders` in `OrderBook` and added `pairIds`, also changed `GetOrdersPacket` to accept `pairIds` as request body.\r\n\r\nIn current state I've added a verbose log to `Pool.ts` line `363` in there I never see `pairIds` logged. I'm probably confusing something here, would you please check ?\r\n","created_at":"2018-09-25T11:52:39Z","updated_at":"2018-09-25T14:34:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc63aee2c1681ff8cba861c14e57c54d4a155509","assignee":{"login":"rsercano","id":3640368,"node_id":"MDQ6VXNlcjM2NDAzNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/3640368?v=4","gravatar_id":"","url":"https://api.github.com/users/rsercano","html_url":"https://github.com/rsercano","followers_url":"https://api.github.com/users/rsercano/followers","following_url":"https://api.github.com/users/rsercano/following{/other_user}","gists_url":"https://api.github.com/users/rsercano/gists{/gist_id}","starred_url":"https://api.github.com/users/rsercano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsercano/subscriptions","organizations_url":"https://api.github.com/users/rsercano/orgs","repos_url":"https://api.github.com/users/rsercano/repos","events_url":"https://api.github.com/users/rsercano/events{/privacy}","received_events_url":"https://api.github.com/users/rsercano/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsercano","id":3640368,"node_id":"MDQ6VXNlcjM2NDAzNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/3640368?v=4","gravatar_id":"","url":"https://api.github.com/users/rsercano","html_url":"https://github.com/rsercano","followers_url":"https://api.github.com/users/rsercano/followers","following_url":"https://api.github.com/users/rsercano/following{/other_user}","gists_url":"https://api.github.com/users/rsercano/gists{/gist_id}","starred_url":"https://api.github.com/users/rsercano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsercano/subscriptions","organizations_url":"https://api.github.com/users/rsercano/orgs","repos_url":"https://api.github.com/users/rsercano/repos","events_url":"https://api.github.com/users/rsercano/events{/privacy}","received_events_url":"https://api.github.com/users/rsercano/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sangaman","id":3440835,"node_id":"MDQ6VXNlcjM0NDA4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3440835?v=4","gravatar_id":"","url":"https://api.github.com/users/sangaman","html_url":"https://github.com/sangaman","followers_url":"https://api.github.com/users/sangaman/followers","following_url":"https://api.github.com/users/sangaman/following{/other_user}","gists_url":"https://api.github.com/users/sangaman/gists{/gist_id}","starred_url":"https://api.github.com/users/sangaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangaman/subscriptions","organizations_url":"https://api.github.com/users/sangaman/orgs","repos_url":"https://api.github.com/users/sangaman/repos","events_url":"https://api.github.com/users/sangaman/events{/privacy}","received_events_url":"https://api.github.com/users/sangaman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":930952990,"node_id":"MDU6TGFiZWw5MzA5NTI5OTA=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":911811896,"node_id":"MDU6TGFiZWw5MTE4MTE4OTY=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/p2p","name":"p2p","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526/commits","review_comments_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526/comments","review_comment_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/526/comments","statuses_url":"https://api.github.com/repos/ExchangeUnion/xud/statuses/0e1fee155fc3c1b90c462cf4ffced284692f2aed","head":{"label":"rsercano:#454","ref":"#454","sha":"0e1fee155fc3c1b90c462cf4ffced284692f2aed","user":{"login":"rsercano","id":3640368,"node_id":"MDQ6VXNlcjM2NDAzNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/3640368?v=4","gravatar_id":"","url":"https://api.github.com/users/rsercano","html_url":"https://github.com/rsercano","followers_url":"https://api.github.com/users/rsercano/followers","following_url":"https://api.github.com/users/rsercano/following{/other_user}","gists_url":"https://api.github.com/users/rsercano/gists{/gist_id}","starred_url":"https://api.github.com/users/rsercano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsercano/subscriptions","organizations_url":"https://api.github.com/users/rsercano/orgs","repos_url":"https://api.github.com/users/rsercano/repos","events_url":"https://api.github.com/users/rsercano/events{/privacy}","received_events_url":"https://api.github.com/users/rsercano/received_events","type":"User","site_admin":false},"repo":{"id":148344431,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzNDQ0MzE=","name":"xud","full_name":"rsercano/xud","private":false,"owner":{"login":"rsercano","id":3640368,"node_id":"MDQ6VXNlcjM2NDAzNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/3640368?v=4","gravatar_id":"","url":"https://api.github.com/users/rsercano","html_url":"https://github.com/rsercano","followers_url":"https://api.github.com/users/rsercano/followers","following_url":"https://api.github.com/users/rsercano/following{/other_user}","gists_url":"https://api.github.com/users/rsercano/gists{/gist_id}","starred_url":"https://api.github.com/users/rsercano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsercano/subscriptions","organizations_url":"https://api.github.com/users/rsercano/orgs","repos_url":"https://api.github.com/users/rsercano/repos","events_url":"https://api.github.com/users/rsercano/events{/privacy}","received_events_url":"https://api.github.com/users/rsercano/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rsercano/xud","description":"Exchange Union Daemon","fork":true,"url":"https://api.github.com/repos/rsercano/xud","forks_url":"https://api.github.com/repos/rsercano/xud/forks","keys_url":"https://api.github.com/repos/rsercano/xud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsercano/xud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsercano/xud/teams","hooks_url":"https://api.github.com/repos/rsercano/xud/hooks","issue_events_url":"https://api.github.com/repos/rsercano/xud/issues/events{/number}","events_url":"https://api.github.com/repos/rsercano/xud/events","assignees_url":"https://api.github.com/repos/rsercano/xud/assignees{/user}","branches_url":"https://api.github.com/repos/rsercano/xud/branches{/branch}","tags_url":"https://api.github.com/repos/rsercano/xud/tags","blobs_url":"https://api.github.com/repos/rsercano/xud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsercano/xud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsercano/xud/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsercano/xud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsercano/xud/statuses/{sha}","languages_url":"https://api.github.com/repos/rsercano/xud/languages","stargazers_url":"https://api.github.com/repos/rsercano/xud/stargazers","contributors_url":"https://api.github.com/repos/rsercano/xud/contributors","subscribers_url":"https://api.github.com/repos/rsercano/xud/subscribers","subscription_url":"https://api.github.com/repos/rsercano/xud/subscription","commits_url":"https://api.github.com/repos/rsercano/xud/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsercano/xud/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsercano/xud/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsercano/xud/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsercano/xud/contents/{+path}","compare_url":"https://api.github.com/repos/rsercano/xud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsercano/xud/merges","archive_url":"https://api.github.com/repos/rsercano/xud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsercano/xud/downloads","issues_url":"https://api.github.com/repos/rsercano/xud/issues{/number}","pulls_url":"https://api.github.com/repos/rsercano/xud/pulls{/number}","milestones_url":"https://api.github.com/repos/rsercano/xud/milestones{/number}","notifications_url":"https://api.github.com/repos/rsercano/xud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsercano/xud/labels{/name}","releases_url":"https://api.github.com/repos/rsercano/xud/releases{/id}","deployments_url":"https://api.github.com/repos/rsercano/xud/deployments","created_at":"2018-09-11T16:09:22Z","updated_at":"2018-09-25T05:23:13Z","pushed_at":"2018-09-25T11:49:21Z","git_url":"git://github.com/rsercano/xud.git","ssh_url":"git@github.com:rsercano/xud.git","clone_url":"https://github.com/rsercano/xud.git","svn_url":"https://github.com/rsercano/xud","homepage":"https://exchangeunion.com","size":1934,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ExchangeUnion:master","ref":"master","sha":"23cd9b2ae85441527717b0f4aad94b1fe385809f","user":{"login":"ExchangeUnion","id":32665502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/32665502?v=4","gravatar_id":"","url":"https://api.github.com/users/ExchangeUnion","html_url":"https://github.com/ExchangeUnion","followers_url":"https://api.github.com/users/ExchangeUnion/followers","following_url":"https://api.github.com/users/ExchangeUnion/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeUnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeUnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeUnion/subscriptions","organizations_url":"https://api.github.com/users/ExchangeUnion/orgs","repos_url":"https://api.github.com/users/ExchangeUnion/repos","events_url":"https://api.github.com/users/ExchangeUnion/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeUnion/received_events","type":"Organization","site_admin":false},"repo":{"id":120945739,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NDU3Mzk=","name":"xud","full_name":"ExchangeUnion/xud","private":false,"owner":{"login":"ExchangeUnion","id":32665502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1NTAy","avatar_url":"https://avatars3.githubusercontent.com/u/32665502?v=4","gravatar_id":"","url":"https://api.github.com/users/ExchangeUnion","html_url":"https://github.com/ExchangeUnion","followers_url":"https://api.github.com/users/ExchangeUnion/followers","following_url":"https://api.github.com/users/ExchangeUnion/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeUnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeUnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeUnion/subscriptions","organizations_url":"https://api.github.com/users/ExchangeUnion/orgs","repos_url":"https://api.github.com/users/ExchangeUnion/repos","events_url":"https://api.github.com/users/ExchangeUnion/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeUnion/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ExchangeUnion/xud","description":"Exchange Union Daemon - Connecting Digital Asset Exchanges","fork":false,"url":"https://api.github.com/repos/ExchangeUnion/xud","forks_url":"https://api.github.com/repos/ExchangeUnion/xud/forks","keys_url":"https://api.github.com/repos/ExchangeUnion/xud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExchangeUnion/xud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExchangeUnion/xud/teams","hooks_url":"https://api.github.com/repos/ExchangeUnion/xud/hooks","issue_events_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/events{/number}","events_url":"https://api.github.com/repos/ExchangeUnion/xud/events","assignees_url":"https://api.github.com/repos/ExchangeUnion/xud/assignees{/user}","branches_url":"https://api.github.com/repos/ExchangeUnion/xud/branches{/branch}","tags_url":"https://api.github.com/repos/ExchangeUnion/xud/tags","blobs_url":"https://api.github.com/repos/ExchangeUnion/xud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExchangeUnion/xud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExchangeUnion/xud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExchangeUnion/xud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExchangeUnion/xud/statuses/{sha}","languages_url":"https://api.github.com/repos/ExchangeUnion/xud/languages","stargazers_url":"https://api.github.com/repos/ExchangeUnion/xud/stargazers","contributors_url":"https://api.github.com/repos/ExchangeUnion/xud/contributors","subscribers_url":"https://api.github.com/repos/ExchangeUnion/xud/subscribers","subscription_url":"https://api.github.com/repos/ExchangeUnion/xud/subscription","commits_url":"https://api.github.com/repos/ExchangeUnion/xud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExchangeUnion/xud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExchangeUnion/xud/contents/{+path}","compare_url":"https://api.github.com/repos/ExchangeUnion/xud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExchangeUnion/xud/merges","archive_url":"https://api.github.com/repos/ExchangeUnion/xud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExchangeUnion/xud/downloads","issues_url":"https://api.github.com/repos/ExchangeUnion/xud/issues{/number}","pulls_url":"https://api.github.com/repos/ExchangeUnion/xud/pulls{/number}","milestones_url":"https://api.github.com/repos/ExchangeUnion/xud/milestones{/number}","notifications_url":"https://api.github.com/repos/ExchangeUnion/xud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/labels{/name}","releases_url":"https://api.github.com/repos/ExchangeUnion/xud/releases{/id}","deployments_url":"https://api.github.com/repos/ExchangeUnion/xud/deployments","created_at":"2018-02-09T19:18:54Z","updated_at":"2018-09-25T14:23:36Z","pushed_at":"2018-09-25T14:33:46Z","git_url":"git://github.com/ExchangeUnion/xud.git","ssh_url":"git@github.com:ExchangeUnion/xud.git","clone_url":"https://github.com/ExchangeUnion/xud.git","svn_url":"https://github.com/ExchangeUnion/xud","homepage":"https://exchangeunion.com","size":1932,"stargazers_count":39,"watchers_count":39,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":98,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526"},"html":{"href":"https://github.com/ExchangeUnion/xud/pull/526"},"issue":{"href":"https://api.github.com/repos/ExchangeUnion/xud/issues/526"},"comments":{"href":"https://api.github.com/repos/ExchangeUnion/xud/issues/526/comments"},"review_comments":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526/comments"},"review_comment":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ExchangeUnion/xud/pulls/526/commits"},"statuses":{"href":"https://api.github.com/repos/ExchangeUnion/xud/statuses/0e1fee155fc3c1b90c462cf4ffced284692f2aed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"moshababo"}}