{"action":"created","issue":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1867","repository_url":"https://api.github.com/repos/MycroftAI/mycroft-core","labels_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1867/labels{/name}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1867/comments","events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1867/events","html_url":"https://github.com/MycroftAI/mycroft-core/pull/1867","id":378139333,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTE1Mzgz","number":1867,"title":"feature/extract multiple numbers from text","user":{"login":"JarbasAl","id":33701864,"node_id":"MDQ6VXNlcjMzNzAxODY0","avatar_url":"https://avatars0.githubusercontent.com/u/33701864?v=4","gravatar_id":"","url":"https://api.github.com/users/JarbasAl","html_url":"https://github.com/JarbasAl","followers_url":"https://api.github.com/users/JarbasAl/followers","following_url":"https://api.github.com/users/JarbasAl/following{/other_user}","gists_url":"https://api.github.com/users/JarbasAl/gists{/gist_id}","starred_url":"https://api.github.com/users/JarbasAl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarbasAl/subscriptions","organizations_url":"https://api.github.com/users/JarbasAl/orgs","repos_url":"https://api.github.com/users/JarbasAl/repos","events_url":"https://api.github.com/users/JarbasAl/events{/privacy}","received_events_url":"https://api.github.com/users/JarbasAl/received_events","type":"User","site_admin":false},"labels":[{"id":664720248,"node_id":"MDU6TGFiZWw2NjQ3MjAyNDg=","url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels/CLA:%20Yes","name":"CLA: Yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-07T04:33:30Z","updated_at":"2018-11-13T03:31:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1867","html_url":"https://github.com/MycroftAI/mycroft-core/pull/1867","diff_url":"https://github.com/MycroftAI/mycroft-core/pull/1867.diff","patch_url":"https://github.com/MycroftAI/mycroft-core/pull/1867.patch"},"body":"## Description\r\n\r\nextract_number assumes only 1 number is present in text, this adds a extract_numbers method to support cases like \"test one two three\"\r\n\r\nnormalize only accounts for numbers up to 20 (word to digit), method is improved to handle all extracted numbers by above method (needs improvements in further PRs)\r\n\r\n## How to test\r\n\r\ncheck unit tests\r\n\r\n## Contributor license agreement signed?\r\nCLA [ yes] (Whether you have signed a [CLA - Contributor Licensing Agreement](https://mycroft.ai/cla/)\r\n"},"comment":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/comments/438120262","html_url":"https://github.com/MycroftAI/mycroft-core/pull/1867#issuecomment-438120262","issue_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1867","id":438120262,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODEyMDI2Mg==","user":{"login":"JarbasAl","id":33701864,"node_id":"MDQ6VXNlcjMzNzAxODY0","avatar_url":"https://avatars0.githubusercontent.com/u/33701864?v=4","gravatar_id":"","url":"https://api.github.com/users/JarbasAl","html_url":"https://github.com/JarbasAl","followers_url":"https://api.github.com/users/JarbasAl/followers","following_url":"https://api.github.com/users/JarbasAl/following{/other_user}","gists_url":"https://api.github.com/users/JarbasAl/gists{/gist_id}","starred_url":"https://api.github.com/users/JarbasAl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarbasAl/subscriptions","organizations_url":"https://api.github.com/users/JarbasAl/orgs","repos_url":"https://api.github.com/users/JarbasAl/repos","events_url":"https://api.github.com/users/JarbasAl/events{/privacy}","received_events_url":"https://api.github.com/users/JarbasAl/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T03:31:10Z","updated_at":"2018-11-13T03:31:10Z","author_association":"CONTRIBUTOR","body":"added support for more languages, but since i don't speak them i would appreciate someone to write unittests\r\n\r\nit is using the \"extract number\" logic already implemented for each language recursively, so it should be correct"}}
{"actor":{"display_login":"JarbasAl"}}