{"action":"created","comment":{"url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/comments/189220370","pull_request_review_id":121357675,"id":189220370,"diff_hunk":"@@ -48,6 +50,20 @@ object ApiRequest {\n   }\n }\n \n+trait CirceJsonBodyWritables {\n+\n+  implicit def circeJsonBodyWritable: BodyWritable[io.circe.Json] =\n+    BodyWritable(json => InMemoryBody(ByteString.fromString(json.noSpaces)), \"application/json\")","path":"ota-plus-web/app/com/advancedtelematic/api/ApiClient.scala","position":32,"original_position":32,"commit_id":"5c19a833983ccfa5675f8949ffa345c71414f4aa","original_commit_id":"5c19a833983ccfa5675f8949ffa345c71414f4aa","user":{"login":"jerrytrieu","id":7487227,"avatar_url":"https://avatars1.githubusercontent.com/u/7487227?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrytrieu","html_url":"https://github.com/jerrytrieu","followers_url":"https://api.github.com/users/jerrytrieu/followers","following_url":"https://api.github.com/users/jerrytrieu/following{/other_user}","gists_url":"https://api.github.com/users/jerrytrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrytrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrytrieu/subscriptions","organizations_url":"https://api.github.com/users/jerrytrieu/orgs","repos_url":"https://api.github.com/users/jerrytrieu/repos","events_url":"https://api.github.com/users/jerrytrieu/events{/privacy}","received_events_url":"https://api.github.com/users/jerrytrieu/received_events","type":"User","site_admin":false},"body":"This wasn't needed in other API calls?","created_at":"2018-05-18T09:57:45Z","updated_at":"2018-05-18T09:57:51Z","html_url":"https://github.com/advancedtelematic/ota-plus-server/pull/1656#discussion_r189220370","pull_request_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/comments/189220370"},"html":{"href":"https://github.com/advancedtelematic/ota-plus-server/pull/1656#discussion_r189220370"},"pull_request":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656"}}},"pull_request":{"url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656","id":188972393,"html_url":"https://github.com/advancedtelematic/ota-plus-server/pull/1656","diff_url":"https://github.com/advancedtelematic/ota-plus-server/pull/1656.diff","patch_url":"https://github.com/advancedtelematic/ota-plus-server/pull/1656.patch","issue_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/1656","number":1656,"state":"open","locked":false,"title":"Use Circe to serialize keyType","user":{"login":"jochenschneider","id":4902826,"avatar_url":"https://avatars2.githubusercontent.com/u/4902826?v=4","gravatar_id":"","url":"https://api.github.com/users/jochenschneider","html_url":"https://github.com/jochenschneider","followers_url":"https://api.github.com/users/jochenschneider/followers","following_url":"https://api.github.com/users/jochenschneider/following{/other_user}","gists_url":"https://api.github.com/users/jochenschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/jochenschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jochenschneider/subscriptions","organizations_url":"https://api.github.com/users/jochenschneider/orgs","repos_url":"https://api.github.com/users/jochenschneider/repos","events_url":"https://api.github.com/users/jochenschneider/events{/privacy}","received_events_url":"https://api.github.com/users/jochenschneider/received_events","type":"User","site_admin":false},"body":"Error was that the key type was sent as `{\"keyType\":\"\\\"RSA\\\"\"}` to the services. Added Play thingie to be able to use a circe encoder. Tested on Oslo.","created_at":"2018-05-18T09:39:07Z","updated_at":"2018-05-18T09:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e16ac00063116bc65faebf65cf73f217f599644f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/1656/comments","statuses_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/statuses/5c19a833983ccfa5675f8949ffa345c71414f4aa","head":{"label":"advancedtelematic:bugfix/PRO-5404/keyType","ref":"bugfix/PRO-5404/keyType","sha":"5c19a833983ccfa5675f8949ffa345c71414f4aa","user":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"repo":{"id":51766551,"name":"ota-plus-server","full_name":"advancedtelematic/ota-plus-server","owner":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advancedtelematic/ota-plus-server","description":"OTA Plus Admin UI","fork":false,"url":"https://api.github.com/repos/advancedtelematic/ota-plus-server","forks_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/forks","keys_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/teams","hooks_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/hooks","issue_events_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/events{/number}","events_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/events","assignees_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/assignees{/user}","branches_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/branches{/branch}","tags_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/tags","blobs_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/statuses/{sha}","languages_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/languages","stargazers_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/stargazers","contributors_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/contributors","subscribers_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/subscribers","subscription_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/subscription","commits_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/contents/{+path}","compare_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/merges","archive_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/downloads","issues_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues{/number}","pulls_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls{/number}","milestones_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/milestones{/number}","notifications_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/labels{/name}","releases_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/releases{/id}","deployments_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/deployments","created_at":"2016-02-15T15:56:09Z","updated_at":"2018-05-17T14:04:20Z","pushed_at":"2018-05-18T09:39:07Z","git_url":"git://github.com/advancedtelematic/ota-plus-server.git","ssh_url":"git@github.com:advancedtelematic/ota-plus-server.git","clone_url":"https://github.com/advancedtelematic/ota-plus-server.git","svn_url":"https://github.com/advancedtelematic/ota-plus-server","homepage":"","size":28353,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"advancedtelematic:master","ref":"master","sha":"2c1d0dec9ca363a44d06003c5ff65493db031139","user":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"repo":{"id":51766551,"name":"ota-plus-server","full_name":"advancedtelematic/ota-plus-server","owner":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars0.githubusercontent.com/u/7944633?v=4","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advancedtelematic/ota-plus-server","description":"OTA Plus Admin UI","fork":false,"url":"https://api.github.com/repos/advancedtelematic/ota-plus-server","forks_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/forks","keys_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/teams","hooks_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/hooks","issue_events_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/events{/number}","events_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/events","assignees_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/assignees{/user}","branches_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/branches{/branch}","tags_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/tags","blobs_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/statuses/{sha}","languages_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/languages","stargazers_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/stargazers","contributors_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/contributors","subscribers_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/subscribers","subscription_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/subscription","commits_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/contents/{+path}","compare_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/merges","archive_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/downloads","issues_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues{/number}","pulls_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls{/number}","milestones_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/milestones{/number}","notifications_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/labels{/name}","releases_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/releases{/id}","deployments_url":"https://api.github.com/repos/advancedtelematic/ota-plus-server/deployments","created_at":"2016-02-15T15:56:09Z","updated_at":"2018-05-17T14:04:20Z","pushed_at":"2018-05-18T09:39:07Z","git_url":"git://github.com/advancedtelematic/ota-plus-server.git","ssh_url":"git@github.com:advancedtelematic/ota-plus-server.git","clone_url":"https://github.com/advancedtelematic/ota-plus-server.git","svn_url":"https://github.com/advancedtelematic/ota-plus-server","homepage":"","size":28353,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656"},"html":{"href":"https://github.com/advancedtelematic/ota-plus-server/pull/1656"},"issue":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/1656"},"comments":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/advancedtelematic/ota-plus-server/statuses/5c19a833983ccfa5675f8949ffa345c71414f4aa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jerrytrieu"}}