{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66305","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66305/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66305/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66305/events","html_url":"https://github.com/kubernetes/kubernetes/pull/66305","id":342036132,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDMxODAy","number":66305,"title":"[WIP] update heketi to not vendor kubernetes/kubernetes","user":{"login":"sigma","id":16090,"node_id":"MDQ6VXNlcjE2MDkw","avatar_url":"https://avatars2.githubusercontent.com/u/16090?v=4","gravatar_id":"","url":"https://api.github.com/users/sigma","html_url":"https://github.com/sigma","followers_url":"https://api.github.com/users/sigma/followers","following_url":"https://api.github.com/users/sigma/following{/other_user}","gists_url":"https://api.github.com/users/sigma/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma/subscriptions","organizations_url":"https://api.github.com/users/sigma/orgs","repos_url":"https://api.github.com/users/sigma/repos","events_url":"https://api.github.com/users/sigma/events{/privacy}","received_events_url":"https://api.github.com/users/sigma/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"node_id":"MDU6TGFiZWw2ODc1NjU4MDQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":240247879,"node_id":"MDU6TGFiZWwyNDAyNDc4Nzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-07-17T18:36:10Z","updated_at":"2018-08-15T20:07:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66305","html_url":"https://github.com/kubernetes/kubernetes/pull/66305","diff_url":"https://github.com/kubernetes/kubernetes/pull/66305.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66305.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nBefore this change, heketi vendors kubernetes/kubernetes, at an old\r\nversion (1.6.4).\r\nThere are a few issues with that:\r\n- 1.6.4 is old, and unsupported, so it's not super useful\r\n- vendoring kubernetes/kubernetes is not supported\r\n- it gets in the way of vgo adoption (see #65683 for details)\r\n\r\nThis change introduces a new version of heketi that's:\r\n- much more recent (v7.0.0 instead of v4.0.0+)\r\n- uses only kubernetes/{api,apimachinery,...}\r\n\r\nAs such it should ease vgo transition, and generally cleanup our dependency\r\ngraph.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\nNot ready for merging. Would have to make it to heketi upstream first. Instead, the code currently lives in https://github.com/sigma/heketi/tree/hack/v7-k8s which will make verification fail. I'm more interested in verifying e2e glusterfs tests right now.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/413319208","html_url":"https://github.com/kubernetes/kubernetes/pull/66305#issuecomment-413319208","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66305","id":413319208,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzMxOTIwOA==","user":{"login":"sigma","id":16090,"node_id":"MDQ6VXNlcjE2MDkw","avatar_url":"https://avatars2.githubusercontent.com/u/16090?v=4","gravatar_id":"","url":"https://api.github.com/users/sigma","html_url":"https://github.com/sigma","followers_url":"https://api.github.com/users/sigma/followers","following_url":"https://api.github.com/users/sigma/following{/other_user}","gists_url":"https://api.github.com/users/sigma/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma/subscriptions","organizations_url":"https://api.github.com/users/sigma/orgs","repos_url":"https://api.github.com/users/sigma/repos","events_url":"https://api.github.com/users/sigma/events{/privacy}","received_events_url":"https://api.github.com/users/sigma/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T20:07:08Z","updated_at":"2018-08-15T20:07:08Z","author_association":"CONTRIBUTOR","body":"@obnoxxx sorry, the title is indeed slightly misleading. Should be \"update heketi to a version that doesn't vendor kubernetes/kubernetes\". And the implication is that in particular it doesn't vendor an old and incompatible version of kubernetes, which happens to be the reason why it's a problem for us.\r\n\r\nSo I guess I'm mixing the remediation and the rationale a little bit in there. Will fix :)\r\n"}}
{"actor":{"display_login":"sigma"}}