{"action":"created","comment":{"url":"https://api.github.com/repos/pcengines/coreboot/pulls/comments/186840075","pull_request_review_id":118499405,"id":186840075,"diff_hunk":"@@ -0,0 +1,56 @@\n+/*\n+ * This file is part of the coreboot project.\n+ *\n+ * Copyright (C) 2015 Timothy Pearson <tpearson@raptorengineeringinc.com>, Raptor Engineering\n+ * Copyright (C) 2007 Advanced Micro Devices, Inc.\n+ *\n+ * This program is free software; you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation; version 2 of the License.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ */\n+\n+#include <stdint.h>\n+#include <cpu/amd/microcode.h>\n+\n+struct id_mapping {\n+\tuint32_t orig_id;\n+\tuint16_t new_id;\n+};\n+\n+static u16 get_equivalent_processor_rev_id(u32 orig_id) {\n+\tstatic const struct id_mapping id_mapping_table[] = {\n+\t\t/* Family 16h */\n+\n+// TODO This equivalent processor revisions ID needs verification","path":"src/cpu/amd/pi/00730F01/update_microcode.c","position":29,"original_position":29,"commit_id":"462da24409ac89ca26078994017cb6231317f515","original_commit_id":"462da24409ac89ca26078994017cb6231317f515","user":{"login":"pietrushnic","id":1071894,"avatar_url":"https://avatars3.githubusercontent.com/u/1071894?v=4","gravatar_id":"","url":"https://api.github.com/users/pietrushnic","html_url":"https://github.com/pietrushnic","followers_url":"https://api.github.com/users/pietrushnic/followers","following_url":"https://api.github.com/users/pietrushnic/following{/other_user}","gists_url":"https://api.github.com/users/pietrushnic/gists{/gist_id}","starred_url":"https://api.github.com/users/pietrushnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietrushnic/subscriptions","organizations_url":"https://api.github.com/users/pietrushnic/orgs","repos_url":"https://api.github.com/users/pietrushnic/repos","events_url":"https://api.github.com/users/pietrushnic/events{/privacy}","received_events_url":"https://api.github.com/users/pietrushnic/received_events","type":"User","site_admin":false},"body":"@miczyg1 please use consistent comments across whole file.","created_at":"2018-05-08T19:25:21Z","updated_at":"2018-05-08T19:26:22Z","html_url":"https://github.com/pcengines/coreboot/pull/133#discussion_r186840075","pull_request_url":"https://api.github.com/repos/pcengines/coreboot/pulls/133","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pcengines/coreboot/pulls/comments/186840075"},"html":{"href":"https://github.com/pcengines/coreboot/pull/133#discussion_r186840075"},"pull_request":{"href":"https://api.github.com/repos/pcengines/coreboot/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/pcengines/coreboot/pulls/133","id":186629990,"html_url":"https://github.com/pcengines/coreboot/pull/133","diff_url":"https://github.com/pcengines/coreboot/pull/133.diff","patch_url":"https://github.com/pcengines/coreboot/pull/133.patch","issue_url":"https://api.github.com/repos/pcengines/coreboot/issues/133","number":133,"state":"open","locked":false,"title":"Add microcode update in legacy build","user":{"login":"miczyg1","id":30656491,"avatar_url":"https://avatars0.githubusercontent.com/u/30656491?v=4","gravatar_id":"","url":"https://api.github.com/users/miczyg1","html_url":"https://github.com/miczyg1","followers_url":"https://api.github.com/users/miczyg1/followers","following_url":"https://api.github.com/users/miczyg1/following{/other_user}","gists_url":"https://api.github.com/users/miczyg1/gists{/gist_id}","starred_url":"https://api.github.com/users/miczyg1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miczyg1/subscriptions","organizations_url":"https://api.github.com/users/miczyg1/orgs","repos_url":"https://api.github.com/users/miczyg1/repos","events_url":"https://api.github.com/users/miczyg1/events{/privacy}","received_events_url":"https://api.github.com/users/miczyg1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-08T13:13:20Z","updated_at":"2018-05-08T19:26:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2dba8d5e8a64843f09917a5ccdad6a3fa4e5b77","assignee":{"login":"pietrushnic","id":1071894,"avatar_url":"https://avatars3.githubusercontent.com/u/1071894?v=4","gravatar_id":"","url":"https://api.github.com/users/pietrushnic","html_url":"https://github.com/pietrushnic","followers_url":"https://api.github.com/users/pietrushnic/followers","following_url":"https://api.github.com/users/pietrushnic/following{/other_user}","gists_url":"https://api.github.com/users/pietrushnic/gists{/gist_id}","starred_url":"https://api.github.com/users/pietrushnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietrushnic/subscriptions","organizations_url":"https://api.github.com/users/pietrushnic/orgs","repos_url":"https://api.github.com/users/pietrushnic/repos","events_url":"https://api.github.com/users/pietrushnic/events{/privacy}","received_events_url":"https://api.github.com/users/pietrushnic/received_events","type":"User","site_admin":false},"assignees":[{"login":"pietrushnic","id":1071894,"avatar_url":"https://avatars3.githubusercontent.com/u/1071894?v=4","gravatar_id":"","url":"https://api.github.com/users/pietrushnic","html_url":"https://github.com/pietrushnic","followers_url":"https://api.github.com/users/pietrushnic/followers","following_url":"https://api.github.com/users/pietrushnic/following{/other_user}","gists_url":"https://api.github.com/users/pietrushnic/gists{/gist_id}","starred_url":"https://api.github.com/users/pietrushnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietrushnic/subscriptions","organizations_url":"https://api.github.com/users/pietrushnic/orgs","repos_url":"https://api.github.com/users/pietrushnic/repos","events_url":"https://api.github.com/users/pietrushnic/events{/privacy}","received_events_url":"https://api.github.com/users/pietrushnic/received_events","type":"User","site_admin":false},{"login":"miczyg1","id":30656491,"avatar_url":"https://avatars0.githubusercontent.com/u/30656491?v=4","gravatar_id":"","url":"https://api.github.com/users/miczyg1","html_url":"https://github.com/miczyg1","followers_url":"https://api.github.com/users/miczyg1/followers","following_url":"https://api.github.com/users/miczyg1/following{/other_user}","gists_url":"https://api.github.com/users/miczyg1/gists{/gist_id}","starred_url":"https://api.github.com/users/miczyg1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miczyg1/subscriptions","organizations_url":"https://api.github.com/users/miczyg1/orgs","repos_url":"https://api.github.com/users/miczyg1/repos","events_url":"https://api.github.com/users/miczyg1/events{/privacy}","received_events_url":"https://api.github.com/users/miczyg1/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"BartekLew","id":5959699,"avatar_url":"https://avatars0.githubusercontent.com/u/5959699?v=4","gravatar_id":"","url":"https://api.github.com/users/BartekLew","html_url":"https://github.com/BartekLew","followers_url":"https://api.github.com/users/BartekLew/followers","following_url":"https://api.github.com/users/BartekLew/following{/other_user}","gists_url":"https://api.github.com/users/BartekLew/gists{/gist_id}","starred_url":"https://api.github.com/users/BartekLew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BartekLew/subscriptions","organizations_url":"https://api.github.com/users/BartekLew/orgs","repos_url":"https://api.github.com/users/BartekLew/repos","events_url":"https://api.github.com/users/BartekLew/events{/privacy}","received_events_url":"https://api.github.com/users/BartekLew/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pcengines/coreboot/pulls/133/commits","review_comments_url":"https://api.github.com/repos/pcengines/coreboot/pulls/133/comments","review_comment_url":"https://api.github.com/repos/pcengines/coreboot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pcengines/coreboot/issues/133/comments","statuses_url":"https://api.github.com/repos/pcengines/coreboot/statuses/462da24409ac89ca26078994017cb6231317f515","head":{"label":"pcengines:add_ucode_legacy","ref":"add_ucode_legacy","sha":"462da24409ac89ca26078994017cb6231317f515","user":{"login":"pcengines","id":18077083,"avatar_url":"https://avatars3.githubusercontent.com/u/18077083?v=4","gravatar_id":"","url":"https://api.github.com/users/pcengines","html_url":"https://github.com/pcengines","followers_url":"https://api.github.com/users/pcengines/followers","following_url":"https://api.github.com/users/pcengines/following{/other_user}","gists_url":"https://api.github.com/users/pcengines/gists{/gist_id}","starred_url":"https://api.github.com/users/pcengines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcengines/subscriptions","organizations_url":"https://api.github.com/users/pcengines/orgs","repos_url":"https://api.github.com/users/pcengines/repos","events_url":"https://api.github.com/users/pcengines/events{/privacy}","received_events_url":"https://api.github.com/users/pcengines/received_events","type":"Organization","site_admin":false},"repo":{"id":54778884,"name":"coreboot","full_name":"pcengines/coreboot","owner":{"login":"pcengines","id":18077083,"avatar_url":"https://avatars3.githubusercontent.com/u/18077083?v=4","gravatar_id":"","url":"https://api.github.com/users/pcengines","html_url":"https://github.com/pcengines","followers_url":"https://api.github.com/users/pcengines/followers","following_url":"https://api.github.com/users/pcengines/following{/other_user}","gists_url":"https://api.github.com/users/pcengines/gists{/gist_id}","starred_url":"https://api.github.com/users/pcengines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcengines/subscriptions","organizations_url":"https://api.github.com/users/pcengines/orgs","repos_url":"https://api.github.com/users/pcengines/repos","events_url":"https://api.github.com/users/pcengines/events{/privacy}","received_events_url":"https://api.github.com/users/pcengines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pcengines/coreboot","description":"github mirror of coreboot.org's master repository","fork":true,"url":"https://api.github.com/repos/pcengines/coreboot","forks_url":"https://api.github.com/repos/pcengines/coreboot/forks","keys_url":"https://api.github.com/repos/pcengines/coreboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcengines/coreboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcengines/coreboot/teams","hooks_url":"https://api.github.com/repos/pcengines/coreboot/hooks","issue_events_url":"https://api.github.com/repos/pcengines/coreboot/issues/events{/number}","events_url":"https://api.github.com/repos/pcengines/coreboot/events","assignees_url":"https://api.github.com/repos/pcengines/coreboot/assignees{/user}","branches_url":"https://api.github.com/repos/pcengines/coreboot/branches{/branch}","tags_url":"https://api.github.com/repos/pcengines/coreboot/tags","blobs_url":"https://api.github.com/repos/pcengines/coreboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcengines/coreboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcengines/coreboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcengines/coreboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcengines/coreboot/statuses/{sha}","languages_url":"https://api.github.com/repos/pcengines/coreboot/languages","stargazers_url":"https://api.github.com/repos/pcengines/coreboot/stargazers","contributors_url":"https://api.github.com/repos/pcengines/coreboot/contributors","subscribers_url":"https://api.github.com/repos/pcengines/coreboot/subscribers","subscription_url":"https://api.github.com/repos/pcengines/coreboot/subscription","commits_url":"https://api.github.com/repos/pcengines/coreboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcengines/coreboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcengines/coreboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcengines/coreboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcengines/coreboot/contents/{+path}","compare_url":"https://api.github.com/repos/pcengines/coreboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcengines/coreboot/merges","archive_url":"https://api.github.com/repos/pcengines/coreboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcengines/coreboot/downloads","issues_url":"https://api.github.com/repos/pcengines/coreboot/issues{/number}","pulls_url":"https://api.github.com/repos/pcengines/coreboot/pulls{/number}","milestones_url":"https://api.github.com/repos/pcengines/coreboot/milestones{/number}","notifications_url":"https://api.github.com/repos/pcengines/coreboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcengines/coreboot/labels{/name}","releases_url":"https://api.github.com/repos/pcengines/coreboot/releases{/id}","deployments_url":"https://api.github.com/repos/pcengines/coreboot/deployments","created_at":"2016-03-26T12:51:13Z","updated_at":"2018-05-03T23:56:15Z","pushed_at":"2018-05-08T13:13:21Z","git_url":"git://github.com/pcengines/coreboot.git","ssh_url":"git@github.com:pcengines/coreboot.git","clone_url":"https://github.com/pcengines/coreboot.git","svn_url":"https://github.com/pcengines/coreboot","homepage":"http://www.coreboot.org/","size":100924,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":7,"open_issues":11,"watchers":20,"default_branch":"coreboot-4.0.x"}},"base":{"label":"pcengines:rel_v4.0.17","ref":"rel_v4.0.17","sha":"2f7a2128fe2a482c4cda7f59d93e84139c1255e6","user":{"login":"pcengines","id":18077083,"avatar_url":"https://avatars3.githubusercontent.com/u/18077083?v=4","gravatar_id":"","url":"https://api.github.com/users/pcengines","html_url":"https://github.com/pcengines","followers_url":"https://api.github.com/users/pcengines/followers","following_url":"https://api.github.com/users/pcengines/following{/other_user}","gists_url":"https://api.github.com/users/pcengines/gists{/gist_id}","starred_url":"https://api.github.com/users/pcengines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcengines/subscriptions","organizations_url":"https://api.github.com/users/pcengines/orgs","repos_url":"https://api.github.com/users/pcengines/repos","events_url":"https://api.github.com/users/pcengines/events{/privacy}","received_events_url":"https://api.github.com/users/pcengines/received_events","type":"Organization","site_admin":false},"repo":{"id":54778884,"name":"coreboot","full_name":"pcengines/coreboot","owner":{"login":"pcengines","id":18077083,"avatar_url":"https://avatars3.githubusercontent.com/u/18077083?v=4","gravatar_id":"","url":"https://api.github.com/users/pcengines","html_url":"https://github.com/pcengines","followers_url":"https://api.github.com/users/pcengines/followers","following_url":"https://api.github.com/users/pcengines/following{/other_user}","gists_url":"https://api.github.com/users/pcengines/gists{/gist_id}","starred_url":"https://api.github.com/users/pcengines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcengines/subscriptions","organizations_url":"https://api.github.com/users/pcengines/orgs","repos_url":"https://api.github.com/users/pcengines/repos","events_url":"https://api.github.com/users/pcengines/events{/privacy}","received_events_url":"https://api.github.com/users/pcengines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pcengines/coreboot","description":"github mirror of coreboot.org's master repository","fork":true,"url":"https://api.github.com/repos/pcengines/coreboot","forks_url":"https://api.github.com/repos/pcengines/coreboot/forks","keys_url":"https://api.github.com/repos/pcengines/coreboot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcengines/coreboot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcengines/coreboot/teams","hooks_url":"https://api.github.com/repos/pcengines/coreboot/hooks","issue_events_url":"https://api.github.com/repos/pcengines/coreboot/issues/events{/number}","events_url":"https://api.github.com/repos/pcengines/coreboot/events","assignees_url":"https://api.github.com/repos/pcengines/coreboot/assignees{/user}","branches_url":"https://api.github.com/repos/pcengines/coreboot/branches{/branch}","tags_url":"https://api.github.com/repos/pcengines/coreboot/tags","blobs_url":"https://api.github.com/repos/pcengines/coreboot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcengines/coreboot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcengines/coreboot/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcengines/coreboot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcengines/coreboot/statuses/{sha}","languages_url":"https://api.github.com/repos/pcengines/coreboot/languages","stargazers_url":"https://api.github.com/repos/pcengines/coreboot/stargazers","contributors_url":"https://api.github.com/repos/pcengines/coreboot/contributors","subscribers_url":"https://api.github.com/repos/pcengines/coreboot/subscribers","subscription_url":"https://api.github.com/repos/pcengines/coreboot/subscription","commits_url":"https://api.github.com/repos/pcengines/coreboot/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcengines/coreboot/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcengines/coreboot/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcengines/coreboot/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcengines/coreboot/contents/{+path}","compare_url":"https://api.github.com/repos/pcengines/coreboot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcengines/coreboot/merges","archive_url":"https://api.github.com/repos/pcengines/coreboot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcengines/coreboot/downloads","issues_url":"https://api.github.com/repos/pcengines/coreboot/issues{/number}","pulls_url":"https://api.github.com/repos/pcengines/coreboot/pulls{/number}","milestones_url":"https://api.github.com/repos/pcengines/coreboot/milestones{/number}","notifications_url":"https://api.github.com/repos/pcengines/coreboot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcengines/coreboot/labels{/name}","releases_url":"https://api.github.com/repos/pcengines/coreboot/releases{/id}","deployments_url":"https://api.github.com/repos/pcengines/coreboot/deployments","created_at":"2016-03-26T12:51:13Z","updated_at":"2018-05-03T23:56:15Z","pushed_at":"2018-05-08T13:13:21Z","git_url":"git://github.com/pcengines/coreboot.git","ssh_url":"git@github.com:pcengines/coreboot.git","clone_url":"https://github.com/pcengines/coreboot.git","svn_url":"https://github.com/pcengines/coreboot","homepage":"http://www.coreboot.org/","size":100924,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":7,"open_issues":11,"watchers":20,"default_branch":"coreboot-4.0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/pcengines/coreboot/pulls/133"},"html":{"href":"https://github.com/pcengines/coreboot/pull/133"},"issue":{"href":"https://api.github.com/repos/pcengines/coreboot/issues/133"},"comments":{"href":"https://api.github.com/repos/pcengines/coreboot/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/pcengines/coreboot/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/pcengines/coreboot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pcengines/coreboot/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/pcengines/coreboot/statuses/462da24409ac89ca26078994017cb6231317f515"}},"author_association":"NONE"}}
{"actor":{"display_login":"pietrushnic"}}