{"action":"created","issue":{"url":"https://api.github.com/repos/kiwix/kiwix-js/issues/410","repository_url":"https://api.github.com/repos/kiwix/kiwix-js","labels_url":"https://api.github.com/repos/kiwix/kiwix-js/issues/410/labels{/name}","comments_url":"https://api.github.com/repos/kiwix/kiwix-js/issues/410/comments","events_url":"https://api.github.com/repos/kiwix/kiwix-js/issues/410/events","html_url":"https://github.com/kiwix/kiwix-js/pull/410","id":360562566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzgxODgw","number":410,"title":"Asm-enabled compile with memory fixed at 5 x 16MiB","user":{"login":"Jaifroid","id":4304337,"node_id":"MDQ6VXNlcjQzMDQzMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/4304337?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaifroid","html_url":"https://github.com/Jaifroid","followers_url":"https://api.github.com/users/Jaifroid/followers","following_url":"https://api.github.com/users/Jaifroid/following{/other_user}","gists_url":"https://api.github.com/users/Jaifroid/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaifroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaifroid/subscriptions","organizations_url":"https://api.github.com/users/Jaifroid/orgs","repos_url":"https://api.github.com/users/Jaifroid/repos","events_url":"https://api.github.com/users/Jaifroid/events{/privacy}","received_events_url":"https://api.github.com/users/Jaifroid/received_events","type":"User","site_admin":false},"labels":[{"id":21591138,"node_id":"MDU6TGFiZWwyMTU5MTEzOA==","url":"https://api.github.com/repos/kiwix/kiwix-js/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"Jaifroid","id":4304337,"node_id":"MDQ6VXNlcjQzMDQzMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/4304337?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaifroid","html_url":"https://github.com/Jaifroid","followers_url":"https://api.github.com/users/Jaifroid/followers","following_url":"https://api.github.com/users/Jaifroid/following{/other_user}","gists_url":"https://api.github.com/users/Jaifroid/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaifroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaifroid/subscriptions","organizations_url":"https://api.github.com/users/Jaifroid/orgs","repos_url":"https://api.github.com/users/Jaifroid/repos","events_url":"https://api.github.com/users/Jaifroid/events{/privacy}","received_events_url":"https://api.github.com/users/Jaifroid/received_events","type":"User","site_admin":false},"assignees":[{"login":"Jaifroid","id":4304337,"node_id":"MDQ6VXNlcjQzMDQzMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/4304337?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaifroid","html_url":"https://github.com/Jaifroid","followers_url":"https://api.github.com/users/Jaifroid/followers","following_url":"https://api.github.com/users/Jaifroid/following{/other_user}","gists_url":"https://api.github.com/users/Jaifroid/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaifroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaifroid/subscriptions","organizations_url":"https://api.github.com/users/Jaifroid/orgs","repos_url":"https://api.github.com/users/Jaifroid/repos","events_url":"https://api.github.com/users/Jaifroid/events{/privacy}","received_events_url":"https://api.github.com/users/Jaifroid/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kiwix/kiwix-js/milestones/16","html_url":"https://github.com/kiwix/kiwix-js/milestone/16","labels_url":"https://api.github.com/repos/kiwix/kiwix-js/milestones/16/labels","id":2548205,"node_id":"MDk6TWlsZXN0b25lMjU0ODIwNQ==","number":16,"title":"v2.4","description":"","creator":{"login":"mossroy","id":890923,"node_id":"MDQ6VXNlcjg5MDkyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/890923?v=4","gravatar_id":"","url":"https://api.github.com/users/mossroy","html_url":"https://github.com/mossroy","followers_url":"https://api.github.com/users/mossroy/followers","following_url":"https://api.github.com/users/mossroy/following{/other_user}","gists_url":"https://api.github.com/users/mossroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mossroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossroy/subscriptions","organizations_url":"https://api.github.com/users/mossroy/orgs","repos_url":"https://api.github.com/users/mossroy/repos","events_url":"https://api.github.com/users/mossroy/events{/privacy}","received_events_url":"https://api.github.com/users/mossroy/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":8,"state":"open","created_at":"2017-05-29T10:58:52Z","updated_at":"2018-09-15T18:09:45Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-09-15T18:09:45Z","updated_at":"2018-09-17T09:37:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kiwix/kiwix-js/pulls/410","html_url":"https://github.com/kiwix/kiwix-js/pull/410","diff_url":"https://github.com/kiwix/kiwix-js/pull/410.diff","patch_url":"https://github.com/kiwix/kiwix-js/pull/410.patch"},"body":"This PR isn't (yet) for merging. It is for the purposes of comparison. We should also do a PR which uses logic to select between this or similar asm-compile of xzdec and a wasm compile. I don't think clients, browsers and OS's are yet sufficiently capable for us to have a wasm-only build.\r\n\r\nCompile string:\r\nemcc --memory-init-file 0 -O3 -s WASM=0 -s MALLOC=\"emmalloc\"\r\n-s TOTAL_MEMORY=83886080 -s NO_FILESYSTEM=1\r\n-s AGGRESSIVE_VARIABLE_ELIMINATION=1 -s DOUBLE_MODE=0 -s PRECISE_I64_MATH=0\r\n-s NO_DYNAMIC_EXECUTION=1 -s LEGACY_VM_SUPPORT=1\r\n-s EXPORTED_FUNCTIONS=\"['_init', '_init_decompression', '_input_empty', '_get_in_buffer',\r\n'_set_new_input', '_decompress', '_get_out_pos', '_get_out_buffer', '_out_buffer_cleared',\r\n'_release']\" -DXZ_USE_CRC64=1 -DXZ_INTERNAL_CRC64=1 *.c -o xzdec.js"},"comment":{"url":"https://api.github.com/repos/kiwix/kiwix-js/issues/comments/421944991","html_url":"https://github.com/kiwix/kiwix-js/pull/410#issuecomment-421944991","issue_url":"https://api.github.com/repos/kiwix/kiwix-js/issues/410","id":421944991,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTk0NDk5MQ==","user":{"login":"mossroy","id":890923,"node_id":"MDQ6VXNlcjg5MDkyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/890923?v=4","gravatar_id":"","url":"https://api.github.com/users/mossroy","html_url":"https://github.com/mossroy","followers_url":"https://api.github.com/users/mossroy/followers","following_url":"https://api.github.com/users/mossroy/following{/other_user}","gists_url":"https://api.github.com/users/mossroy/gists{/gist_id}","starred_url":"https://api.github.com/users/mossroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossroy/subscriptions","organizations_url":"https://api.github.com/users/mossroy/orgs","repos_url":"https://api.github.com/users/mossroy/repos","events_url":"https://api.github.com/users/mossroy/events{/privacy}","received_events_url":"https://api.github.com/users/mossroy/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T09:37:06Z","updated_at":"2018-09-17T09:37:06Z","author_association":"MEMBER","body":"You can squash and merge this PR.\r\nI'll probably test a few other emscripten attributes, to see if we can gain a bit more. Like removing the LEGACY_VM_SUPPORT or switching the wasm (which would force us to handle the fallback for old browsers)\r\nAnd I'll create another PR if they're worth it."}}
{"actor":{"display_login":"mossroy"}}