{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/32","id":235006792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDA2Nzky","html_url":"https://github.com/companieshouse/payments.web.ch.gov.uk/pull/32","diff_url":"https://github.com/companieshouse/payments.web.ch.gov.uk/pull/32.diff","patch_url":"https://github.com/companieshouse/payments.web.ch.gov.uk/pull/32.patch","issue_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/32","number":32,"state":"closed","locked":false,"title":"Call GovPay from API and redirect User ","user":{"login":"jphillips2121","id":25738992,"node_id":"MDQ6VXNlcjI1NzM4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/25738992?v=4","gravatar_id":"","url":"https://api.github.com/users/jphillips2121","html_url":"https://github.com/jphillips2121","followers_url":"https://api.github.com/users/jphillips2121/followers","following_url":"https://api.github.com/users/jphillips2121/following{/other_user}","gists_url":"https://api.github.com/users/jphillips2121/gists{/gist_id}","starred_url":"https://api.github.com/users/jphillips2121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jphillips2121/subscriptions","organizations_url":"https://api.github.com/users/jphillips2121/orgs","repos_url":"https://api.github.com/users/jphillips2121/repos","events_url":"https://api.github.com/users/jphillips2121/events{/privacy}","received_events_url":"https://api.github.com/users/jphillips2121/received_events","type":"User","site_admin":false},"body":"- Refactored GetPaymentSession to GetPayment and added to own payment service folder\r\n- Added PatchPayment which calls API to payment service folder\r\n- Created externalpayment service folder and added createExternalPayment call to API\r\n- Added Patch and createExternal to controller to call GovPay URL and redirect user \r\n- Added Unit Tests for all services\r\n\r\nResolves: CPS-156\r\n\r\n### Type of change\r\n\r\n* [X] New feature\r\n\r\n### Pull request checklist\r\n\r\n* [X] I have added unit tests for new code that I have added\r\n* [X] I have added/updated functional tests where appropriate\r\n* [X] The code follows our [coding standards](https://github.com/companieshouse/styleguides/blob/master/go.md)","created_at":"2018-11-30T14:34:26Z","updated_at":"2018-12-03T12:03:18Z","closed_at":"2018-12-03T12:03:17Z","merged_at":"2018-12-03T12:03:17Z","merge_commit_sha":"06b1eacd459349431e900fd16ea342b7017d1cd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/32/commits","review_comments_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/32/comments","review_comment_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/32/comments","statuses_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/statuses/b19395d4059c8079ba9dd50dd3e91d4a0d600465","head":{"label":"companieshouse:feature/invoke-gov-pay-journey","ref":"feature/invoke-gov-pay-journey","sha":"b19395d4059c8079ba9dd50dd3e91d4a0d600465","user":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"repo":{"id":144127833,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQxMjc4MzM=","name":"payments.web.ch.gov.uk","full_name":"companieshouse/payments.web.ch.gov.uk","private":false,"owner":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/companieshouse/payments.web.ch.gov.uk","description":"Web application for payments","fork":false,"url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk","forks_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/forks","keys_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/teams","hooks_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/hooks","issue_events_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/events{/number}","events_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/events","assignees_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/assignees{/user}","branches_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/branches{/branch}","tags_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/tags","blobs_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/refs{/sha}","trees_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/statuses/{sha}","languages_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/languages","stargazers_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/stargazers","contributors_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/contributors","subscribers_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/subscribers","subscription_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/subscription","commits_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/commits{/sha}","git_commits_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/commits{/sha}","comments_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/comments{/number}","issue_comment_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/comments{/number}","contents_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/contents/{+path}","compare_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/merges","archive_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/downloads","issues_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues{/number}","pulls_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls{/number}","milestones_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/milestones{/number}","notifications_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/labels{/name}","releases_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/releases{/id}","deployments_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/deployments","created_at":"2018-08-09T09:04:13Z","updated_at":"2018-12-03T10:23:46Z","pushed_at":"2018-12-03T12:03:17Z","git_url":"git://github.com/companieshouse/payments.web.ch.gov.uk.git","ssh_url":"git@github.com:companieshouse/payments.web.ch.gov.uk.git","clone_url":"https://github.com/companieshouse/payments.web.ch.gov.uk.git","svn_url":"https://github.com/companieshouse/payments.web.ch.gov.uk","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"companieshouse:feature/payments/ci","ref":"feature/payments/ci","sha":"aeaa68918f2d615d91280901af0e7fe2173c5f3e","user":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"repo":{"id":144127833,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQxMjc4MzM=","name":"payments.web.ch.gov.uk","full_name":"companieshouse/payments.web.ch.gov.uk","private":false,"owner":{"login":"companieshouse","id":4947323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDczMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/4947323?v=4","gravatar_id":"","url":"https://api.github.com/users/companieshouse","html_url":"https://github.com/companieshouse","followers_url":"https://api.github.com/users/companieshouse/followers","following_url":"https://api.github.com/users/companieshouse/following{/other_user}","gists_url":"https://api.github.com/users/companieshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/companieshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/companieshouse/subscriptions","organizations_url":"https://api.github.com/users/companieshouse/orgs","repos_url":"https://api.github.com/users/companieshouse/repos","events_url":"https://api.github.com/users/companieshouse/events{/privacy}","received_events_url":"https://api.github.com/users/companieshouse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/companieshouse/payments.web.ch.gov.uk","description":"Web application for payments","fork":false,"url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk","forks_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/forks","keys_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/teams","hooks_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/hooks","issue_events_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/events{/number}","events_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/events","assignees_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/assignees{/user}","branches_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/branches{/branch}","tags_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/tags","blobs_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/refs{/sha}","trees_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/statuses/{sha}","languages_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/languages","stargazers_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/stargazers","contributors_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/contributors","subscribers_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/subscribers","subscription_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/subscription","commits_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/commits{/sha}","git_commits_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/git/commits{/sha}","comments_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/comments{/number}","issue_comment_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/comments{/number}","contents_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/contents/{+path}","compare_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/merges","archive_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/downloads","issues_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues{/number}","pulls_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls{/number}","milestones_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/milestones{/number}","notifications_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/labels{/name}","releases_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/releases{/id}","deployments_url":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/deployments","created_at":"2018-08-09T09:04:13Z","updated_at":"2018-12-03T10:23:46Z","pushed_at":"2018-12-03T12:03:17Z","git_url":"git://github.com/companieshouse/payments.web.ch.gov.uk.git","ssh_url":"git@github.com:companieshouse/payments.web.ch.gov.uk.git","clone_url":"https://github.com/companieshouse/payments.web.ch.gov.uk.git","svn_url":"https://github.com/companieshouse/payments.web.ch.gov.uk","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/32"},"html":{"href":"https://github.com/companieshouse/payments.web.ch.gov.uk/pull/32"},"issue":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/32"},"comments":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/companieshouse/payments.web.ch.gov.uk/statuses/b19395d4059c8079ba9dd50dd3e91d4a0d600465"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jphillips2121","id":25738992,"node_id":"MDQ6VXNlcjI1NzM4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/25738992?v=4","gravatar_id":"","url":"https://api.github.com/users/jphillips2121","html_url":"https://github.com/jphillips2121","followers_url":"https://api.github.com/users/jphillips2121/followers","following_url":"https://api.github.com/users/jphillips2121/following{/other_user}","gists_url":"https://api.github.com/users/jphillips2121/gists{/gist_id}","starred_url":"https://api.github.com/users/jphillips2121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jphillips2121/subscriptions","organizations_url":"https://api.github.com/users/jphillips2121/orgs","repos_url":"https://api.github.com/users/jphillips2121/repos","events_url":"https://api.github.com/users/jphillips2121/events{/privacy}","received_events_url":"https://api.github.com/users/jphillips2121/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":7,"additions":415,"deletions":47,"changed_files":17}}
{"actor":{"display_login":"jphillips2121"}}