{"push_id":2928547564,"size":30,"distinct_size":0,"ref":"refs/heads/codegen-pr-507","head":"a14db979f1549e906a711b7ec73762d5e5fde290","before":"10af01f76e2d1761acbbbaef470e4ad705b33f60","commits":[{"sha":"5cf6a5d13192b5aadf01603615101a9a22a35fb3","author":{"name":"Paddy Carver","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Fix perma-diff on instance templates.\n\nWhen using instance templates, if you use one of our image shorthands at\nthe moment, you'll get a perma-diff. This is because the config gets\nresolved to another format before it is set in state, and so we need to\nset that other format in state.\n\nUnfortunately, resolving images requires network access, so we have to\ndo this with CustomizeDiff. CustomizeDiff was having trouble (I think?\nMore on this below) on setting a field as not ForceNew once the field\nwas already set, so I moved the decision for whether a field was\nForceNew or not into CustomizeDiff. I also resolved the old and new\nimages, and if they were the same, cleared the diff.\n\nUnfortunately, you can't actually clear a field on a sub-block right\nnow. You have to clear top-level fields only. So this will currently\nthrow an error. I opened hashicorp/terraform#18795 to fix that. Once\nthat's merged, and we vendor it here, this patch fixes the problem.\n\nIf hashicorp/terraform#18795 doesn't get merged, the next best\nworkaround is to keep track of _all_ the fields under `disk` with a diff\nin our CustomizeDiff, check whether they've all changed or not, and if\nthey've all changed, clear the changes on `disk`, which I _think_ will\nresolve the issue. That's just a massive pain, unfortunately.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/5cf6a5d13192b5aadf01603615101a9a22a35fb3"},{"sha":"75c20b4246b9ed776f96f68b1fb90dad451b7145","author":{"name":"Paddy Carver","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Update helper/schema vendor.\n\nUpdate the version of helper/schema we have vendored to take advantage\nof fixes to the ResourceDiff.Clear function.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/75c20b4246b9ed776f96f68b1fb90dad451b7145"},{"sha":"063f1ba4b15f1760260ab3036ed0cdf472c63126","author":{"name":"The Magician","email":"86ce7da8ad74b1c583667a2bebd347455fa06219@google.com"},"message":"Fix docs for BinAuth Policy cluster_admission_rules (#2125)\n\n<!-- This change is generated by MagicModules. -->\r\n/cc @rileykarson","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/063f1ba4b15f1760260ab3036ed0cdf472c63126"},{"sha":"1f0eae579ff66df181efee3d96b773b95204a49a","author":{"name":"The Magician","email":"86ce7da8ad74b1c583667a2bebd347455fa06219@google.com"},"message":"Bugfix: Stop reading region from Redis API. (#2133)\n\nBugfix: Stop reading region from Redis API, remove unnecessary Flatten methods.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/1f0eae579ff66df181efee3d96b773b95204a49a"},{"sha":"70faf686b5cee420bc0d807f52dc92e3aa3e11ce","author":{"name":"Alex Barron","email":"0e2507025521c3ef13d7a427a5bfe702b67821ab@users.noreply.github.com"},"message":"Add \"enable_tpu\" flag to google_container_cluster (#1974)\n\n* add enable_tpu flag\r\n\r\n* missed one\r\n\r\n* add docs\r\n\r\n* fix test\r\n\r\n* tabs\r\n\r\n* update tests to new format\r\n\r\n* formatting\r\n\r\n* formatting","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/70faf686b5cee420bc0d807f52dc92e3aa3e11ce"},{"sha":"ddfba9e5642dc015155817f345a60b9bd3886a21","author":{"name":"Dana Hoffman","email":"8f50b6bbbf47415a43bff02c2a6714e00c62b75a@google.com"},"message":"Update CHANGELOG.md","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/ddfba9e5642dc015155817f345a60b9bd3886a21"},{"sha":"aec2987415e4ce4bd3e35cfc4a577c96b1db84c3","author":{"name":"The Magician","email":"86ce7da8ad74b1c583667a2bebd347455fa06219@google.com"},"message":"use beta api for container analysis (#2135)\n\n<!-- This change is generated by MagicModules. -->\r\n/cc @danawillow","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/aec2987415e4ce4bd3e35cfc4a577c96b1db84c3"},{"sha":"98a608777c18c725bb281d37f2a43c563e91047d","author":{"name":"The Magician","email":"86ce7da8ad74b1c583667a2bebd347455fa06219@google.com"},"message":"use ga api for redis (#2136)\n\n<!-- This change is generated by MagicModules. -->\r\n/cc @danawillow","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/98a608777c18c725bb281d37f2a43c563e91047d"},{"sha":"250cfa351cb7ae96aedcc6c522f8a5bddded5de1","author":{"name":"Dana Hoffman","email":"8f50b6bbbf47415a43bff02c2a6714e00c62b75a@google.com"},"message":"fix instance template interaction with regional disks, make docs more clear about valid values (#2138)","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/250cfa351cb7ae96aedcc6c522f8a5bddded5de1"},{"sha":"436543bc370fffae891ac8cfd8a7eacdc18acdb8","author":{"name":"Dana Hoffman","email":"8f50b6bbbf47415a43bff02c2a6714e00c62b75a@google.com"},"message":"Update CHANGELOG.md","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/436543bc370fffae891ac8cfd8a7eacdc18acdb8"},{"sha":"2fc8da91e728ca2b86065ef0e1c2c501c928426a","author":{"name":"Paddy Carver","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Fix Dana's comments, expand images to self_links.\n\nFix Dana's comments, one of which exposed a bug: we weren't actually\nfixing the diff. Because resolveImage can return multiple formats, and\nonly returns a self_link if a self_link is passed in, it was diffing\nmore often than not against a self_link supplied in the config. We just\nhad a bug in our CustomizeDiff function that concealed this.\n\nI added the resolvedImageSelfLink helper function to turn the output\nfrom resolveImage into a self_link, which fixes the problem. It also has\nthe knock-on effect of fixing #2067 at the same time, which is nice. I\ndecided to add another function instead of just modifying resolveImage\nto always return a self_link because I don't want to deal with the\nbackwards compatibility problems of changing how we're storing a bunch\nof things in state this close to 1.19.0. And honestly, we should\nprobably just be storing the self_link always, _anyways_.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/2fc8da91e728ca2b86065ef0e1c2c501c928426a"},{"sha":"a8fdf4033ea38d890c2e48152c0ce1f5b73dbabc","author":{"name":"Paddy","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Fix trailing comma\n\nJSON is the worst.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/a8fdf4033ea38d890c2e48152c0ce1f5b73dbabc"},{"sha":"9ceb6444608d3590d0dd9415447a891dc5805e43","author":{"name":"Paddy Carver","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Add google_app_engine_application resource.\n\nDeprecate the app_engine sub-block of google_project, and create a\ngoogle_app_engine_application resource instead. Also, add some tests for\nits behaviour, as well as some documentation for it.\n\nNote that this is largely an implementation of the ideas discussed in\n #2118, except we're not using CustomizeDiff to reject deletions without\nour special flag set, because CustomizeDiff apparently doesn't run on\nDelete. Who knew? This leaves us rejecting the deletion at apply time,\nwhich is less than ideal, but the only other option I see is to silently\nnot delete the resource, and that's... not ideal, either.\n\nThis also stops the app_engine sub-block on google_project from forcing\nnew when it's removed, and sets it to computed, so users can safely move\nfrom using the sub-block to using the resource without state surgery or\ndeleting their entire project. This does mean it's impossible to delete\nan App Engine application from a sub-block now, but seeing as that was\nthe same situation before, and we just papered over it by making the\nproject recreate itself in that situation, and people Were Not Fans of\nthat, I'm considering that an acceptable casualty.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/9ceb6444608d3590d0dd9415447a891dc5805e43"},{"sha":"546401277a2be3a6eb6c4bbe051d357177076fe4","author":{"name":"Dana Hoffman","email":"8f50b6bbbf47415a43bff02c2a6714e00c62b75a@google.com"},"message":"Make max_pods_per_node ForceNew (#2139)\n\nI don't see any way of updating in the API, and even if there were, we aren't calling it right now.\r\n\r\nFixes #2084","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/546401277a2be3a6eb6c4bbe051d357177076fe4"},{"sha":"27bd76d9d40d0149d75a1489f83eba119a3b01d5","author":{"name":"Dana Hoffman","email":"8f50b6bbbf47415a43bff02c2a6714e00c62b75a@google.com"},"message":"Update CHANGELOG.md","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/27bd76d9d40d0149d75a1489f83eba119a3b01d5"},{"sha":"c1d404ddc1ec41600e904d68788c38168d39381c","author":{"name":"Paddy","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@carvers.co"},"message":"Merge pull request #1995 from terraform-providers/paddy_1916_diff_fix\n\nFix perma-diff on instance templates.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/c1d404ddc1ec41600e904d68788c38168d39381c"},{"sha":"b5c36b0fbf1d6a411e3d85846ecf4130978882f7","author":{"name":"Paddy","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@carvers.co"},"message":"Update CHANGELOG.md","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/b5c36b0fbf1d6a411e3d85846ecf4130978882f7"},{"sha":"3ab8e95ef6a428e9cbd2f079d8e9888406c0c79a","author":{"name":"Paddy Carver","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Pretend to delete, no error.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/3ab8e95ef6a428e9cbd2f079d8e9888406c0c79a"},{"sha":"ee4ec86bef0f42049ffc2a75f4f18db804258027","author":{"name":"Paddy Carver","email":"43d21ee07cb08ab10c932c6f7489478fcd1c182a@hashicorp.com"},"message":"Fix error in instance template read.\n\nFlattening disks involves taking the relative link of each disk. This\nonly works if you start from a self_link, but we were starting from\nanything that resolveImage returns, which includes several\nnot-self_links.\n\nThis PR adds a test that shows the failure, and then fixes it by\nexpanding the output back out to a self_link before getting the relative\nlink from it.","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/ee4ec86bef0f42049ffc2a75f4f18db804258027"},{"sha":"a4a453dc1bdc15e04df7b54797c5832f19b169b8","author":{"name":"Riley Karson","email":"1a773f0ad84731b4060512d017ba233db35a9279@users.noreply.github.com"},"message":"Deprecate assigned_nat_ip in compute_instance family (#2155)\n\nPart of #2143","distinct":false,"url":"https://api.github.com/repos/modular-magician/terraform-provider-google/commits/a4a453dc1bdc15e04df7b54797c5832f19b169b8"}]}
{"actor":{"display_login":"modular-magician"}}