{"action":"created","comment":{"url":"https://api.github.com/repos/hainproject/hain/pulls/comments/194259640","pull_request_review_id":127399435,"id":194259640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI1OTY0MA==","diff_hunk":"@@ -0,0 +1,77 @@\n+{\n+  \"type\": \"object\",\n+  \"properties\": {\n+    \"windowDraggable\": {\n+      \"type\": \"boolean\",\n+      \"title\": \"Draggable window\",\n+      \"default\": true\n+    },\n+    \"rememberWindowPosition\": {\n+      \"type\": \"boolean\",\n+      \"title\": \"Automatically remember window position\",\n+      \"default\": false\n+    },\n+\n+    \"position\": {\n+      \"type\": \"object\",\n+      \"title\": \"Position\",\n+      \"properties\": {\n+        \"positionWindow\": {\n+          \"type\": \"string\",\n+          \"title\": \"Position mode\",\n+          \"default\": \"center\",\n+          \"enum\" : [\n+            [\n+              \"center\",\n+              \"Center window on screen\"\n+            ],\n+            [\n+              \"specified\",\n+              \"Set window to specific screen position\"\n+            ]\n+          ]\n+        },\n+\n+        \"posX\": {\n+          \"condition\": \".position.positionWindow=='specified'\",","path":"app/main/server/preferences/schemas/window-windows.json","position":36,"original_position":36,"commit_id":"1106876249aedb2ac68586ae66f3b4aff666cb63","original_commit_id":"7e494b79239f15ed3f7cdaee31413467431636b7","user":{"login":"dannya","id":394687,"node_id":"MDQ6VXNlcjM5NDY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/394687?v=4","gravatar_id":"","url":"https://api.github.com/users/dannya","html_url":"https://github.com/dannya","followers_url":"https://api.github.com/users/dannya/followers","following_url":"https://api.github.com/users/dannya/following{/other_user}","gists_url":"https://api.github.com/users/dannya/gists{/gist_id}","starred_url":"https://api.github.com/users/dannya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannya/subscriptions","organizations_url":"https://api.github.com/users/dannya/orgs","repos_url":"https://api.github.com/users/dannya/repos","events_url":"https://api.github.com/users/dannya/events{/privacy}","received_events_url":"https://api.github.com/users/dannya/received_events","type":"User","site_admin":false},"body":"I actually took the condition format from the docs for the existing json-schema docs (which we seem to be implementing?):\r\n\r\nhttps://github.com/json-schema-form/json-schema-form/wiki/Documentation#condition","created_at":"2018-06-10T14:43:50Z","updated_at":"2018-06-10T14:43:50Z","html_url":"https://github.com/hainproject/hain/pull/270#discussion_r194259640","pull_request_url":"https://api.github.com/repos/hainproject/hain/pulls/270","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hainproject/hain/pulls/comments/194259640"},"html":{"href":"https://github.com/hainproject/hain/pull/270#discussion_r194259640"},"pull_request":{"href":"https://api.github.com/repos/hainproject/hain/pulls/270"}},"in_reply_to_id":194237334},"pull_request":{"url":"https://api.github.com/repos/hainproject/hain/pulls/270","id":193793159,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzkzMTU5","html_url":"https://github.com/hainproject/hain/pull/270","diff_url":"https://github.com/hainproject/hain/pull/270.diff","patch_url":"https://github.com/hainproject/hain/pull/270.patch","issue_url":"https://api.github.com/repos/hainproject/hain/issues/270","number":270,"state":"open","locked":false,"title":"Implement sophisticated draggable window functionality","user":{"login":"dannya","id":394687,"node_id":"MDQ6VXNlcjM5NDY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/394687?v=4","gravatar_id":"","url":"https://api.github.com/users/dannya","html_url":"https://github.com/dannya","followers_url":"https://api.github.com/users/dannya/followers","following_url":"https://api.github.com/users/dannya/following{/other_user}","gists_url":"https://api.github.com/users/dannya/gists{/gist_id}","starred_url":"https://api.github.com/users/dannya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannya/subscriptions","organizations_url":"https://api.github.com/users/dannya/orgs","repos_url":"https://api.github.com/users/dannya/repos","events_url":"https://api.github.com/users/dannya/events{/privacy}","received_events_url":"https://api.github.com/users/dannya/received_events","type":"User","site_admin":false},"body":"Implements #241\r\n\r\n* Refactor preferences UI with a new \"Window\" page. \r\n\r\n* Implement sophisticated draggable window functionality, with ability to specify whether or not to remember the dragged window position.\r\n\r\n* New Window preferences UI also allows us to always open the window at a specified screen position (or to ignore this and always open in the center of the screen), or on a specified screen (for multi-screen environments).","created_at":"2018-06-09T19:37:42Z","updated_at":"2018-06-10T14:43:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c008eb8b86b16701a6fed3bffe97f245e35af7f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hainproject/hain/pulls/270/commits","review_comments_url":"https://api.github.com/repos/hainproject/hain/pulls/270/comments","review_comment_url":"https://api.github.com/repos/hainproject/hain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hainproject/hain/issues/270/comments","statuses_url":"https://api.github.com/repos/hainproject/hain/statuses/1106876249aedb2ac68586ae66f3b4aff666cb63","head":{"label":"hainproject:feature/draggable-window","ref":"feature/draggable-window","sha":"1106876249aedb2ac68586ae66f3b4aff666cb63","user":{"login":"hainproject","id":25010201,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEwMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/25010201?v=4","gravatar_id":"","url":"https://api.github.com/users/hainproject","html_url":"https://github.com/hainproject","followers_url":"https://api.github.com/users/hainproject/followers","following_url":"https://api.github.com/users/hainproject/following{/other_user}","gists_url":"https://api.github.com/users/hainproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hainproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainproject/subscriptions","organizations_url":"https://api.github.com/users/hainproject/orgs","repos_url":"https://api.github.com/users/hainproject/repos","events_url":"https://api.github.com/users/hainproject/events{/privacy}","received_events_url":"https://api.github.com/users/hainproject/received_events","type":"Organization","site_admin":false},"repo":{"id":53731544,"node_id":"MDEwOlJlcG9zaXRvcnk1MzczMTU0NA==","name":"hain","full_name":"hainproject/hain","owner":{"login":"hainproject","id":25010201,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEwMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/25010201?v=4","gravatar_id":"","url":"https://api.github.com/users/hainproject","html_url":"https://github.com/hainproject","followers_url":"https://api.github.com/users/hainproject/followers","following_url":"https://api.github.com/users/hainproject/following{/other_user}","gists_url":"https://api.github.com/users/hainproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hainproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainproject/subscriptions","organizations_url":"https://api.github.com/users/hainproject/orgs","repos_url":"https://api.github.com/users/hainproject/repos","events_url":"https://api.github.com/users/hainproject/events{/privacy}","received_events_url":"https://api.github.com/users/hainproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hainproject/hain","description":"An 'alt+space' launcher for Windows, built with Electron","fork":false,"url":"https://api.github.com/repos/hainproject/hain","forks_url":"https://api.github.com/repos/hainproject/hain/forks","keys_url":"https://api.github.com/repos/hainproject/hain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hainproject/hain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hainproject/hain/teams","hooks_url":"https://api.github.com/repos/hainproject/hain/hooks","issue_events_url":"https://api.github.com/repos/hainproject/hain/issues/events{/number}","events_url":"https://api.github.com/repos/hainproject/hain/events","assignees_url":"https://api.github.com/repos/hainproject/hain/assignees{/user}","branches_url":"https://api.github.com/repos/hainproject/hain/branches{/branch}","tags_url":"https://api.github.com/repos/hainproject/hain/tags","blobs_url":"https://api.github.com/repos/hainproject/hain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hainproject/hain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hainproject/hain/git/refs{/sha}","trees_url":"https://api.github.com/repos/hainproject/hain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hainproject/hain/statuses/{sha}","languages_url":"https://api.github.com/repos/hainproject/hain/languages","stargazers_url":"https://api.github.com/repos/hainproject/hain/stargazers","contributors_url":"https://api.github.com/repos/hainproject/hain/contributors","subscribers_url":"https://api.github.com/repos/hainproject/hain/subscribers","subscription_url":"https://api.github.com/repos/hainproject/hain/subscription","commits_url":"https://api.github.com/repos/hainproject/hain/commits{/sha}","git_commits_url":"https://api.github.com/repos/hainproject/hain/git/commits{/sha}","comments_url":"https://api.github.com/repos/hainproject/hain/comments{/number}","issue_comment_url":"https://api.github.com/repos/hainproject/hain/issues/comments{/number}","contents_url":"https://api.github.com/repos/hainproject/hain/contents/{+path}","compare_url":"https://api.github.com/repos/hainproject/hain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hainproject/hain/merges","archive_url":"https://api.github.com/repos/hainproject/hain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hainproject/hain/downloads","issues_url":"https://api.github.com/repos/hainproject/hain/issues{/number}","pulls_url":"https://api.github.com/repos/hainproject/hain/pulls{/number}","milestones_url":"https://api.github.com/repos/hainproject/hain/milestones{/number}","notifications_url":"https://api.github.com/repos/hainproject/hain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hainproject/hain/labels{/name}","releases_url":"https://api.github.com/repos/hainproject/hain/releases{/id}","deployments_url":"https://api.github.com/repos/hainproject/hain/deployments","created_at":"2016-03-12T12:53:44Z","updated_at":"2018-06-10T14:30:29Z","pushed_at":"2018-06-10T14:36:36Z","git_url":"git://github.com/hainproject/hain.git","ssh_url":"git@github.com:hainproject/hain.git","clone_url":"https://github.com/hainproject/hain.git","svn_url":"https://github.com/hainproject/hain","homepage":"http://hainproject.github.io/hain/","size":9800,"stargazers_count":2728,"watchers_count":2728,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":139,"open_issues":64,"watchers":2728,"default_branch":"develop"}},"base":{"label":"hainproject:develop","ref":"develop","sha":"2a289bdeeb89b6eaa5938900a64907fccea02f60","user":{"login":"hainproject","id":25010201,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEwMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/25010201?v=4","gravatar_id":"","url":"https://api.github.com/users/hainproject","html_url":"https://github.com/hainproject","followers_url":"https://api.github.com/users/hainproject/followers","following_url":"https://api.github.com/users/hainproject/following{/other_user}","gists_url":"https://api.github.com/users/hainproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hainproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainproject/subscriptions","organizations_url":"https://api.github.com/users/hainproject/orgs","repos_url":"https://api.github.com/users/hainproject/repos","events_url":"https://api.github.com/users/hainproject/events{/privacy}","received_events_url":"https://api.github.com/users/hainproject/received_events","type":"Organization","site_admin":false},"repo":{"id":53731544,"node_id":"MDEwOlJlcG9zaXRvcnk1MzczMTU0NA==","name":"hain","full_name":"hainproject/hain","owner":{"login":"hainproject","id":25010201,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEwMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/25010201?v=4","gravatar_id":"","url":"https://api.github.com/users/hainproject","html_url":"https://github.com/hainproject","followers_url":"https://api.github.com/users/hainproject/followers","following_url":"https://api.github.com/users/hainproject/following{/other_user}","gists_url":"https://api.github.com/users/hainproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hainproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hainproject/subscriptions","organizations_url":"https://api.github.com/users/hainproject/orgs","repos_url":"https://api.github.com/users/hainproject/repos","events_url":"https://api.github.com/users/hainproject/events{/privacy}","received_events_url":"https://api.github.com/users/hainproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hainproject/hain","description":"An 'alt+space' launcher for Windows, built with Electron","fork":false,"url":"https://api.github.com/repos/hainproject/hain","forks_url":"https://api.github.com/repos/hainproject/hain/forks","keys_url":"https://api.github.com/repos/hainproject/hain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hainproject/hain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hainproject/hain/teams","hooks_url":"https://api.github.com/repos/hainproject/hain/hooks","issue_events_url":"https://api.github.com/repos/hainproject/hain/issues/events{/number}","events_url":"https://api.github.com/repos/hainproject/hain/events","assignees_url":"https://api.github.com/repos/hainproject/hain/assignees{/user}","branches_url":"https://api.github.com/repos/hainproject/hain/branches{/branch}","tags_url":"https://api.github.com/repos/hainproject/hain/tags","blobs_url":"https://api.github.com/repos/hainproject/hain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hainproject/hain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hainproject/hain/git/refs{/sha}","trees_url":"https://api.github.com/repos/hainproject/hain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hainproject/hain/statuses/{sha}","languages_url":"https://api.github.com/repos/hainproject/hain/languages","stargazers_url":"https://api.github.com/repos/hainproject/hain/stargazers","contributors_url":"https://api.github.com/repos/hainproject/hain/contributors","subscribers_url":"https://api.github.com/repos/hainproject/hain/subscribers","subscription_url":"https://api.github.com/repos/hainproject/hain/subscription","commits_url":"https://api.github.com/repos/hainproject/hain/commits{/sha}","git_commits_url":"https://api.github.com/repos/hainproject/hain/git/commits{/sha}","comments_url":"https://api.github.com/repos/hainproject/hain/comments{/number}","issue_comment_url":"https://api.github.com/repos/hainproject/hain/issues/comments{/number}","contents_url":"https://api.github.com/repos/hainproject/hain/contents/{+path}","compare_url":"https://api.github.com/repos/hainproject/hain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hainproject/hain/merges","archive_url":"https://api.github.com/repos/hainproject/hain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hainproject/hain/downloads","issues_url":"https://api.github.com/repos/hainproject/hain/issues{/number}","pulls_url":"https://api.github.com/repos/hainproject/hain/pulls{/number}","milestones_url":"https://api.github.com/repos/hainproject/hain/milestones{/number}","notifications_url":"https://api.github.com/repos/hainproject/hain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hainproject/hain/labels{/name}","releases_url":"https://api.github.com/repos/hainproject/hain/releases{/id}","deployments_url":"https://api.github.com/repos/hainproject/hain/deployments","created_at":"2016-03-12T12:53:44Z","updated_at":"2018-06-10T14:30:29Z","pushed_at":"2018-06-10T14:36:36Z","git_url":"git://github.com/hainproject/hain.git","ssh_url":"git@github.com:hainproject/hain.git","clone_url":"https://github.com/hainproject/hain.git","svn_url":"https://github.com/hainproject/hain","homepage":"http://hainproject.github.io/hain/","size":9800,"stargazers_count":2728,"watchers_count":2728,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":139,"open_issues":64,"watchers":2728,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/hainproject/hain/pulls/270"},"html":{"href":"https://github.com/hainproject/hain/pull/270"},"issue":{"href":"https://api.github.com/repos/hainproject/hain/issues/270"},"comments":{"href":"https://api.github.com/repos/hainproject/hain/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/hainproject/hain/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/hainproject/hain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hainproject/hain/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/hainproject/hain/statuses/1106876249aedb2ac68586ae66f3b4aff666cb63"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dannya"}}