{"action":"created","issue":{"url":"https://api.github.com/repos/fsharp/FAKE/issues/2188","repository_url":"https://api.github.com/repos/fsharp/FAKE","labels_url":"https://api.github.com/repos/fsharp/FAKE/issues/2188/labels{/name}","comments_url":"https://api.github.com/repos/fsharp/FAKE/issues/2188/comments","events_url":"https://api.github.com/repos/fsharp/FAKE/issues/2188/events","html_url":"https://github.com/fsharp/FAKE/pull/2188","id":377751968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NjE4NTA0","number":2188,"title":"Fixed DocFx bug","user":{"login":"DigitalFlow","id":4287938,"node_id":"MDQ6VXNlcjQyODc5Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4287938?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalFlow","html_url":"https://github.com/DigitalFlow","followers_url":"https://api.github.com/users/DigitalFlow/followers","following_url":"https://api.github.com/users/DigitalFlow/following{/other_user}","gists_url":"https://api.github.com/users/DigitalFlow/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalFlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalFlow/subscriptions","organizations_url":"https://api.github.com/users/DigitalFlow/orgs","repos_url":"https://api.github.com/users/DigitalFlow/repos","events_url":"https://api.github.com/users/DigitalFlow/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalFlow/received_events","type":"User","site_admin":false},"labels":[{"id":607298337,"node_id":"MDU6TGFiZWw2MDcyOTgzMzc=","url":"https://api.github.com/repos/fsharp/FAKE/labels/Waiting%20for%20author","name":"Waiting for author","color":"b60205","default":false},{"id":1095886572,"node_id":"MDU6TGFiZWwxMDk1ODg2NTcy","url":"https://api.github.com/repos/fsharp/FAKE/labels/needs-tests","name":"needs-tests","color":"ff99f4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-11-06T09:10:21Z","updated_at":"2018-11-18T17:15:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fsharp/FAKE/pulls/2188","html_url":"https://github.com/fsharp/FAKE/pull/2188","diff_url":"https://github.com/fsharp/FAKE/pull/2188.diff","patch_url":"https://github.com/fsharp/FAKE/pull/2188.patch"},"body":"### Description\r\nThis PR switches the DocFx module to use Args instead of the deprecated Process functions.\r\n\r\n- fixes #2187 \r\n\r\nUnfortunately neither building the project using `fake run` nor using `dotnet` builds successfully.\r\nBut this was also the case for me before I did the changes.\r\nSome hints whether the stringify functions are ok as they are would be great.\r\n\r\n## TODO\r\n- [ ] unit or integration test exists (or short reasoning why it doesn't make sense)\r\n  \r\n  > Note: Consider using the `CreateProcess` API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the `DotNet.Testing.NUnit` module)"},"comment":{"url":"https://api.github.com/repos/fsharp/FAKE/issues/comments/439709060","html_url":"https://github.com/fsharp/FAKE/pull/2188#issuecomment-439709060","issue_url":"https://api.github.com/repos/fsharp/FAKE/issues/2188","id":439709060,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTcwOTA2MA==","user":{"login":"DigitalFlow","id":4287938,"node_id":"MDQ6VXNlcjQyODc5Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4287938?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalFlow","html_url":"https://github.com/DigitalFlow","followers_url":"https://api.github.com/users/DigitalFlow/followers","following_url":"https://api.github.com/users/DigitalFlow/following{/other_user}","gists_url":"https://api.github.com/users/DigitalFlow/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalFlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalFlow/subscriptions","organizations_url":"https://api.github.com/users/DigitalFlow/orgs","repos_url":"https://api.github.com/users/DigitalFlow/repos","events_url":"https://api.github.com/users/DigitalFlow/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalFlow/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T17:15:22Z","updated_at":"2018-11-18T17:15:22Z","author_association":"CONTRIBUTOR","body":"Yes, we did no escaping, however building the strings had some issues, for example boolean options that were passed as - -option=true instead of just passing - -option.\r\nI have the feeling that we should have a central module for such stringifications, such as in ProcessHelper. "}}
{"actor":{"display_login":"DigitalFlow"}}