{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71149","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71149/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71149/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71149/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71149","id":381745427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjQ0MTEx","number":71149,"title":"Implement fmt.Stringer on rest.Config to sanitize sensitive fields","user":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"mikedanese","id":1787169,"node_id":"MDQ6VXNlcjE3ODcxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-11-16T20:17:11Z","updated_at":"2018-11-20T18:55:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71149","html_url":"https://github.com/kubernetes/kubernetes/pull/71149","diff_url":"https://github.com/kubernetes/kubernetes/pull/71149.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71149.patch"},"body":"It's very easy to add glog.Info(config) calls for debugging (or actual\r\nlogging). In some scenarios those configs will carry sensitive tokens\r\nand those tokens will end up in logs or response bodies.\r\nLeaking of those stringified configs compromises the cluster.\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one, leave it on its own line:\r\n>\r\n> /kind api-change\r\n> /kind bug\r\n/kind cleanup\r\n> /kind design\r\n> /kind documentation\r\n> /kind failing-test\r\n> /kind feature\r\n> /kind flake\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/440390062","html_url":"https://github.com/kubernetes/kubernetes/pull/71149#issuecomment-440390062","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71149","id":440390062,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDM5MDA2Mg==","user":{"login":"awly","id":1146263,"node_id":"MDQ6VXNlcjExNDYyNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1146263?v=4","gravatar_id":"","url":"https://api.github.com/users/awly","html_url":"https://github.com/awly","followers_url":"https://api.github.com/users/awly/followers","following_url":"https://api.github.com/users/awly/following{/other_user}","gists_url":"https://api.github.com/users/awly/gists{/gist_id}","starred_url":"https://api.github.com/users/awly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awly/subscriptions","organizations_url":"https://api.github.com/users/awly/orgs","repos_url":"https://api.github.com/users/awly/repos","events_url":"https://api.github.com/users/awly/events{/privacy}","received_events_url":"https://api.github.com/users/awly/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T18:55:05Z","updated_at":"2018-11-20T18:55:05Z","author_association":"CONTRIBUTOR","body":"Ok, implemented `GoStringer` too, with identical output.\r\nPTAL."}}
{"actor":{"display_login":"awly"}}