{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/sdk/issues/2330","repository_url":"https://api.github.com/repos/dotnet/sdk","labels_url":"https://api.github.com/repos/dotnet/sdk/issues/2330/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/sdk/issues/2330/comments","events_url":"https://api.github.com/repos/dotnet/sdk/issues/2330/events","html_url":"https://github.com/dotnet/sdk/pull/2330","id":332095347,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjYzMjIx","number":2330,"title":"Add warning for ref to netstandard >= 1.5 from netfx without built-in support","user":{"login":"wli3","id":6993335,"node_id":"MDQ6VXNlcjY5OTMzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"labels":[{"id":479951946,"node_id":"MDU6TGFiZWw0Nzk5NTE5NDY=","url":"https://api.github.com/repos/dotnet/sdk/labels/Approved%20to%20merge","name":"Approved to merge","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/sdk/milestones/13","html_url":"https://github.com/dotnet/sdk/milestone/13","labels_url":"https://api.github.com/repos/dotnet/sdk/milestones/13/labels","id":3199277,"node_id":"MDk6TWlsZXN0b25lMzE5OTI3Nw==","number":13,"title":"2.1.4xx","description":"","creator":{"login":"livarcocc","id":367554,"node_id":"MDQ6VXNlcjM2NzU1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/367554?v=4","gravatar_id":"","url":"https://api.github.com/users/livarcocc","html_url":"https://github.com/livarcocc","followers_url":"https://api.github.com/users/livarcocc/followers","following_url":"https://api.github.com/users/livarcocc/following{/other_user}","gists_url":"https://api.github.com/users/livarcocc/gists{/gist_id}","starred_url":"https://api.github.com/users/livarcocc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livarcocc/subscriptions","organizations_url":"https://api.github.com/users/livarcocc/orgs","repos_url":"https://api.github.com/users/livarcocc/repos","events_url":"https://api.github.com/users/livarcocc/events{/privacy}","received_events_url":"https://api.github.com/users/livarcocc/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":46,"state":"open","created_at":"2018-03-19T17:14:31Z","updated_at":"2018-07-10T21:56:39Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2018-06-13T17:40:18Z","updated_at":"2018-07-13T17:23:08Z","closed_at":"2018-06-14T00:40:19Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dotnet/sdk/pulls/2330","html_url":"https://github.com/dotnet/sdk/pull/2330","diff_url":"https://github.com/dotnet/sdk/pull/2330.diff","patch_url":"https://github.com/dotnet/sdk/pull/2330.patch"},"body":"Still TODO:\r\n\r\n- [x] Confirm final error message text with PMs\r\n- [x] Make sure fwlink points to valid content\r\n  **Use aka.ms link which owned by us. We could change the destination later. It is pointing to microsoft.com** \r\n- [x] Tests\r\n  - [x] The existing tests of the extensions adding support files probably just need to be updated to also check for the correct warning or lack thereof. The matrix is the same as the cases where we do/do not add support files:\r\n   - [x]  .NETFramework < 4.7.2 -> .NETStandard >= 1.5 --> warning\r\n   - [x] .NETFramework any -> .NETStandard < 1.5 --> no warning\r\n   - [x] .NETFramework >= 4.7.2 -> .NETStandard any --> no warning\r\n   - [x] Warning can be suppressed\r\n\r\n------\r\n   - [x] NOTE: Error code may still change as this will conflict with #2282"},"comment":{"url":"https://api.github.com/repos/dotnet/sdk/issues/comments/404898731","html_url":"https://github.com/dotnet/sdk/pull/2330#issuecomment-404898731","issue_url":"https://api.github.com/repos/dotnet/sdk/issues/2330","id":404898731,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDg5ODczMQ==","user":{"login":"nguerrera","id":75470,"node_id":"MDQ6VXNlcjc1NDcw","avatar_url":"https://avatars0.githubusercontent.com/u/75470?v=4","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T17:23:08Z","updated_at":"2018-07-13T17:23:08Z","author_association":"MEMBER","body":"In an PropertyGroup with no conditions. You probably already have one of those that you can add it to.\r\n\r\n``` xml\r\n<PropertyGroup>\r\n  <MSBuildWarningsAsMessages>NETSDK1069</MSBuildWarningsAsMessages>\r\n</PropertyGroup>\r\n```"}}
{"actor":{"display_login":"nguerrera"}}