{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/216795699","pull_request_review_id":154355696,"id":216795699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc5NTY5OQ==","diff_hunk":"@@ -1739,6 +1759,24 @@ negotiate an allowed protocol (i.e. HTTP/2 or HTTP/1.1). The event handler\n receives the socket for handling. If no listener is registered for this event,\n the connection is terminated. See the [Compatibility API][].\n \n+#### server.setTimeout([msecs][, callback])\n+<!-- YAML\n+added: v8.4.0\n+-->\n+\n+* `msecs` {number} **Default:** `120000` (2 minutes)\n+* `callback` {Function}\n+* Returns: {Http2Server}\n+\n+Used to set the timeout value for http2 secure server requests, \n+and sets a callback function that is called when there is no activity \n+on the Http2Server after `msecs` milliseconds. \n+\n+The given callback is registered as a listener on the 'timeout' event.\n+\n+In case of no callback were assigned, a new `ERR_INVALID_CALLBACK` \n+error will be throw.","path":"doc/api/http2.md","position":22,"original_position":54,"commit_id":"885ecf9f312ef106ba3f964c3b7bc6a690d70dd1","original_commit_id":"885ecf9f312ef106ba3f964c3b7bc6a690d70dd1","user":{"login":"vsemozhetbyt","id":10393198,"node_id":"MDQ6VXNlcjEwMzkzMTk4","avatar_url":"https://avatars1.githubusercontent.com/u/10393198?v=4","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"body":"throw -> thrown","created_at":"2018-09-11T19:38:23Z","updated_at":"2018-09-11T19:39:10Z","html_url":"https://github.com/nodejs/node/pull/22798#discussion_r216795699","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/22798","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/216795699"},"html":{"href":"https://github.com/nodejs/node/pull/22798#discussion_r216795699"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/22798"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22798","id":214460637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDYwNjM3","html_url":"https://github.com/nodejs/node/pull/22798","diff_url":"https://github.com/nodejs/node/pull/22798.diff","patch_url":"https://github.com/nodejs/node/pull/22798.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/22798","number":22798,"state":"open","locked":false,"title":"Http2 timeout documentation","user":{"login":"sagitsofan","id":1827994,"node_id":"MDQ6VXNlcjE4Mjc5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1827994?v=4","gravatar_id":"","url":"https://api.github.com/users/sagitsofan","html_url":"https://github.com/sagitsofan","followers_url":"https://api.github.com/users/sagitsofan/followers","following_url":"https://api.github.com/users/sagitsofan/following{/other_user}","gists_url":"https://api.github.com/users/sagitsofan/gists{/gist_id}","starred_url":"https://api.github.com/users/sagitsofan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagitsofan/subscriptions","organizations_url":"https://api.github.com/users/sagitsofan/orgs","repos_url":"https://api.github.com/users/sagitsofan/repos","events_url":"https://api.github.com/users/sagitsofan/events{/privacy}","received_events_url":"https://api.github.com/users/sagitsofan/received_events","type":"User","site_admin":false},"body":"Added into documentation new default timeout values of \"2 minutes\" under 2 classes at \"Event: 'timeout'\" section.\r\n\r\n1) Class: Http2SecureServer\r\n2) Class: Http2Server\r\n\r\nDocumentation:\r\nhttps://nodejs.org/api/http2.html#http2_event_timeout_2\r\nhttps://nodejs.org/api/http2.html#http2_event_timeout_3\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [X] documentation is changed or added\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-09-10T22:19:17Z","updated_at":"2018-09-11T19:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90099b6137fe8b62c5b4ae24ee3440dc0e4333cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":647282877,"node_id":"MDU6TGFiZWw2NDcyODI4Nzc=","url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/22798/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/22798/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22798/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/885ecf9f312ef106ba3f964c3b7bc6a690d70dd1","head":{"label":"sagitsofan:my-branch","ref":"my-branch","sha":"885ecf9f312ef106ba3f964c3b7bc6a690d70dd1","user":{"login":"sagitsofan","id":1827994,"node_id":"MDQ6VXNlcjE4Mjc5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1827994?v=4","gravatar_id":"","url":"https://api.github.com/users/sagitsofan","html_url":"https://github.com/sagitsofan","followers_url":"https://api.github.com/users/sagitsofan/followers","following_url":"https://api.github.com/users/sagitsofan/following{/other_user}","gists_url":"https://api.github.com/users/sagitsofan/gists{/gist_id}","starred_url":"https://api.github.com/users/sagitsofan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagitsofan/subscriptions","organizations_url":"https://api.github.com/users/sagitsofan/orgs","repos_url":"https://api.github.com/users/sagitsofan/repos","events_url":"https://api.github.com/users/sagitsofan/events{/privacy}","received_events_url":"https://api.github.com/users/sagitsofan/received_events","type":"User","site_admin":false},"repo":{"id":148206084,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMDYwODQ=","name":"node","full_name":"sagitsofan/node","owner":{"login":"sagitsofan","id":1827994,"node_id":"MDQ6VXNlcjE4Mjc5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1827994?v=4","gravatar_id":"","url":"https://api.github.com/users/sagitsofan","html_url":"https://github.com/sagitsofan","followers_url":"https://api.github.com/users/sagitsofan/followers","following_url":"https://api.github.com/users/sagitsofan/following{/other_user}","gists_url":"https://api.github.com/users/sagitsofan/gists{/gist_id}","starred_url":"https://api.github.com/users/sagitsofan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagitsofan/subscriptions","organizations_url":"https://api.github.com/users/sagitsofan/orgs","repos_url":"https://api.github.com/users/sagitsofan/repos","events_url":"https://api.github.com/users/sagitsofan/events{/privacy}","received_events_url":"https://api.github.com/users/sagitsofan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sagitsofan/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/sagitsofan/node","forks_url":"https://api.github.com/repos/sagitsofan/node/forks","keys_url":"https://api.github.com/repos/sagitsofan/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagitsofan/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagitsofan/node/teams","hooks_url":"https://api.github.com/repos/sagitsofan/node/hooks","issue_events_url":"https://api.github.com/repos/sagitsofan/node/issues/events{/number}","events_url":"https://api.github.com/repos/sagitsofan/node/events","assignees_url":"https://api.github.com/repos/sagitsofan/node/assignees{/user}","branches_url":"https://api.github.com/repos/sagitsofan/node/branches{/branch}","tags_url":"https://api.github.com/repos/sagitsofan/node/tags","blobs_url":"https://api.github.com/repos/sagitsofan/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagitsofan/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagitsofan/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagitsofan/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagitsofan/node/statuses/{sha}","languages_url":"https://api.github.com/repos/sagitsofan/node/languages","stargazers_url":"https://api.github.com/repos/sagitsofan/node/stargazers","contributors_url":"https://api.github.com/repos/sagitsofan/node/contributors","subscribers_url":"https://api.github.com/repos/sagitsofan/node/subscribers","subscription_url":"https://api.github.com/repos/sagitsofan/node/subscription","commits_url":"https://api.github.com/repos/sagitsofan/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagitsofan/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagitsofan/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagitsofan/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagitsofan/node/contents/{+path}","compare_url":"https://api.github.com/repos/sagitsofan/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagitsofan/node/merges","archive_url":"https://api.github.com/repos/sagitsofan/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagitsofan/node/downloads","issues_url":"https://api.github.com/repos/sagitsofan/node/issues{/number}","pulls_url":"https://api.github.com/repos/sagitsofan/node/pulls{/number}","milestones_url":"https://api.github.com/repos/sagitsofan/node/milestones{/number}","notifications_url":"https://api.github.com/repos/sagitsofan/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagitsofan/node/labels{/name}","releases_url":"https://api.github.com/repos/sagitsofan/node/releases{/id}","deployments_url":"https://api.github.com/repos/sagitsofan/node/deployments","created_at":"2018-09-10T19:12:51Z","updated_at":"2018-09-10T19:13:17Z","pushed_at":"2018-09-11T19:29:41Z","git_url":"git://github.com/sagitsofan/node.git","ssh_url":"git@github.com:sagitsofan/node.git","clone_url":"https://github.com/sagitsofan/node.git","svn_url":"https://github.com/sagitsofan/node","homepage":"https://nodejs.org","size":412742,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"121439a8ff0cd5e41517b3032890d5dab90ea44b","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-09-11T18:46:03Z","pushed_at":"2018-09-11T19:29:46Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":413532,"stargazers_count":53230,"watchers_count":53230,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11327,"mirror_url":null,"archived":false,"open_issues_count":872,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11327,"open_issues":872,"watchers":53230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/22798"},"html":{"href":"https://github.com/nodejs/node/pull/22798"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/22798"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/22798/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/22798/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/22798/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/885ecf9f312ef106ba3f964c3b7bc6a690d70dd1"}},"author_association":"NONE"}}
{"actor":{"display_login":"vsemozhetbyt"}}