{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/222110805","pull_request_review_id":160921944,"id":222110805,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjExMDgwNQ==","diff_hunk":"@@ -1892,6 +1892,104 @@\n         }\n       }\n     },\n+    \"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/guestResourceTypes/software/items\":{","path":"specification/compute/resource-manager/Microsoft.Compute/preview/2016-04-30-preview/compute.json","position":4,"original_position":4,"commit_id":"95af7671d52bf4a3cb1921b8337eb5ba2e6d88bd","original_commit_id":"95af7671d52bf4a3cb1921b8337eb5ba2e6d88bd","user":{"login":"ravbhatnagar","id":2806980,"node_id":"MDQ6VXNlcjI4MDY5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/2806980?v=4","gravatar_id":"","url":"https://api.github.com/users/ravbhatnagar","html_url":"https://github.com/ravbhatnagar","followers_url":"https://api.github.com/users/ravbhatnagar/followers","following_url":"https://api.github.com/users/ravbhatnagar/following{/other_user}","gists_url":"https://api.github.com/users/ravbhatnagar/gists{/gist_id}","starred_url":"https://api.github.com/users/ravbhatnagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravbhatnagar/subscriptions","organizations_url":"https://api.github.com/users/ravbhatnagar/orgs","repos_url":"https://api.github.com/users/ravbhatnagar/repos","events_url":"https://api.github.com/users/ravbhatnagar/events{/privacy}","received_events_url":"https://api.github.com/users/ravbhatnagar/received_events","type":"User","site_admin":false},"body":"lets make the values of guestResourceTypes as an enum and add the allowed values there.","created_at":"2018-10-02T21:02:05Z","updated_at":"2018-10-02T21:05:16Z","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/4012#discussion_r222110805","pull_request_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/222110805"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/4012#discussion_r222110805"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012","id":218427015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDI3MDE1","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/4012","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/4012.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/4012.patch","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4012","number":4012,"state":"open","locked":false,"title":"New resource: Add InGuest resource type software to Compute","user":{"login":"abhinav-ghai","id":1511158,"node_id":"MDQ6VXNlcjE1MTExNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1511158?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinav-ghai","html_url":"https://github.com/abhinav-ghai","followers_url":"https://api.github.com/users/abhinav-ghai/followers","following_url":"https://api.github.com/users/abhinav-ghai/following{/other_user}","gists_url":"https://api.github.com/users/abhinav-ghai/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav-ghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav-ghai/subscriptions","organizations_url":"https://api.github.com/users/abhinav-ghai/orgs","repos_url":"https://api.github.com/users/abhinav-ghai/repos","events_url":"https://api.github.com/users/abhinav-ghai/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav-ghai/received_events","type":"User","site_admin":false},"body":"This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.\r\n\r\n### PR information\r\n- [ ] The title of the PR is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).\r\n- [ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.\r\n- [ ] If applicable, the PR references the bug/issue that it fixes.\r\n- [ ] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).\r\n\r\n### Quality of Swagger\r\n- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] My spec meets the review criteria:\r\n  - [ ] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).\r\n  - [ ] The spec follows the guidelines described in the [Swagger checklist](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md) document.\r\n  - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.\r\n","created_at":"2018-09-26T19:22:45Z","updated_at":"2018-10-02T21:05:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"689fbc32368ada095459c94df0df5f4820189eb6","assignee":{"login":"anuchandy","id":1471612,"node_id":"MDQ6VXNlcjE0NzE2MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1471612?v=4","gravatar_id":"","url":"https://api.github.com/users/anuchandy","html_url":"https://github.com/anuchandy","followers_url":"https://api.github.com/users/anuchandy/followers","following_url":"https://api.github.com/users/anuchandy/following{/other_user}","gists_url":"https://api.github.com/users/anuchandy/gists{/gist_id}","starred_url":"https://api.github.com/users/anuchandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuchandy/subscriptions","organizations_url":"https://api.github.com/users/anuchandy/orgs","repos_url":"https://api.github.com/users/anuchandy/repos","events_url":"https://api.github.com/users/anuchandy/events{/privacy}","received_events_url":"https://api.github.com/users/anuchandy/received_events","type":"User","site_admin":false},"assignees":[{"login":"anuchandy","id":1471612,"node_id":"MDQ6VXNlcjE0NzE2MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1471612?v=4","gravatar_id":"","url":"https://api.github.com/users/anuchandy","html_url":"https://github.com/anuchandy","followers_url":"https://api.github.com/users/anuchandy/followers","following_url":"https://api.github.com/users/anuchandy/following{/other_user}","gists_url":"https://api.github.com/users/anuchandy/gists{/gist_id}","starred_url":"https://api.github.com/users/anuchandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuchandy/subscriptions","organizations_url":"https://api.github.com/users/anuchandy/orgs","repos_url":"https://api.github.com/users/anuchandy/repos","events_url":"https://api.github.com/users/anuchandy/events{/privacy}","received_events_url":"https://api.github.com/users/anuchandy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":652377569,"node_id":"MDU6TGFiZWw2NTIzNzc1Njk=","url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels/WaitForARMFeedback","name":"WaitForARMFeedback","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4012/comments","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/95af7671d52bf4a3cb1921b8337eb5ba2e6d88bd","head":{"label":"abhinav-ghai:master","ref":"master","sha":"95af7671d52bf4a3cb1921b8337eb5ba2e6d88bd","user":{"login":"abhinav-ghai","id":1511158,"node_id":"MDQ6VXNlcjE1MTExNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1511158?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinav-ghai","html_url":"https://github.com/abhinav-ghai","followers_url":"https://api.github.com/users/abhinav-ghai/followers","following_url":"https://api.github.com/users/abhinav-ghai/following{/other_user}","gists_url":"https://api.github.com/users/abhinav-ghai/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav-ghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav-ghai/subscriptions","organizations_url":"https://api.github.com/users/abhinav-ghai/orgs","repos_url":"https://api.github.com/users/abhinav-ghai/repos","events_url":"https://api.github.com/users/abhinav-ghai/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav-ghai/received_events","type":"User","site_admin":false},"repo":{"id":150343875,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzNDM4NzU=","name":"azure-rest-api-specs","full_name":"abhinav-ghai/azure-rest-api-specs","private":false,"owner":{"login":"abhinav-ghai","id":1511158,"node_id":"MDQ6VXNlcjE1MTExNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1511158?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinav-ghai","html_url":"https://github.com/abhinav-ghai","followers_url":"https://api.github.com/users/abhinav-ghai/followers","following_url":"https://api.github.com/users/abhinav-ghai/following{/other_user}","gists_url":"https://api.github.com/users/abhinav-ghai/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav-ghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav-ghai/subscriptions","organizations_url":"https://api.github.com/users/abhinav-ghai/orgs","repos_url":"https://api.github.com/users/abhinav-ghai/repos","events_url":"https://api.github.com/users/abhinav-ghai/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav-ghai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/abhinav-ghai/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":true,"url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs","forks_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/abhinav-ghai/azure-rest-api-specs/deployments","created_at":"2018-09-26T00:07:31Z","updated_at":"2018-09-28T18:54:49Z","pushed_at":"2018-09-28T18:54:47Z","git_url":"git://github.com/abhinav-ghai/azure-rest-api-specs.git","ssh_url":"git@github.com:abhinav-ghai/azure-rest-api-specs.git","clone_url":"https://github.com/abhinav-ghai/azure-rest-api-specs.git","svn_url":"https://github.com/abhinav-ghai/azure-rest-api-specs","homepage":"","size":23280,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"efea5b0ec9fbadfaf688fab2c674f71485e5bef0","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":39093389,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA5MzM4OQ==","name":"azure-rest-api-specs","full_name":"Azure/azure-rest-api-specs","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs","forks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/deployments","created_at":"2015-07-14T18:37:13Z","updated_at":"2018-10-02T20:56:47Z","pushed_at":"2018-10-02T20:59:03Z","git_url":"git://github.com/Azure/azure-rest-api-specs.git","ssh_url":"git@github.com:Azure/azure-rest-api-specs.git","clone_url":"https://github.com/Azure/azure-rest-api-specs.git","svn_url":"https://github.com/Azure/azure-rest-api-specs","homepage":"","size":24103,"stargazers_count":336,"watchers_count":336,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":957,"mirror_url":null,"archived":false,"open_issues_count":341,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":957,"open_issues":341,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/4012"},"issue":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4012"},"comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/4012/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/4012/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/95af7671d52bf4a3cb1921b8337eb5ba2e6d88bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"ravbhatnagar"}}