{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/comments/224505975","pull_request_review_id":163891232,"id":224505975,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDUwNTk3NQ==","diff_hunk":"@@ -121,10 +124,22 @@ public void testDashboard()\n \n       Nodes li = document.query(\"//li\");\n       Assert.assertTrue(li.size() > 100);\n+      ArrayList<String> coordinateList = new ArrayList<>();\n+\n       for (int i = 0; i < li.size(); i++) {\n         String coordinates = li.get(i).getValue();\n         // fails if these are not valid Maven coordinates\n         new DefaultArtifact(coordinates);\n+        coordinateList.add(coordinates);\n+      }\n+      \n+      ArrayList<String> sorted = new ArrayList<>(coordinateList);\n+      Comparator<String> comparator = new SortWithoutVersion();\n+      Collections.sort(sorted, comparator );\n+      \n+      for (int i = 0; i < sorted.size(); i++) {\n+        Assert.assertEquals(\"Coordinates are not sorted: \", sorted.get(i),\n+            coordinateList.get(i));","path":"dashboard/src/test/java/com/google/cloud/tools/opensource/dashboard/DashboardTest.java","position":29,"original_position":29,"commit_id":"20390c6207011ebae48b310a3d04e6cfec2963b7","original_commit_id":"20390c6207011ebae48b310a3d04e6cfec2963b7","user":{"login":"garrettjonesgoogle","id":13341017,"node_id":"MDQ6VXNlcjEzMzQxMDE3","avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"It seems like we could have much more concise assertions by using the `Truth` library","created_at":"2018-10-11T15:56:35Z","updated_at":"2018-10-11T15:58:15Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/141#discussion_r224505975","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/comments/224505975"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/141#discussion_r224505975"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141","id":222168681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTY4Njgx","html_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/141","diff_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/141.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/141.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/141","number":141,"state":"open","locked":false,"title":"Sort the global list of dependencies","user":{"login":"elharo","id":1005544,"node_id":"MDQ6VXNlcjEwMDU1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1005544?v=4","gravatar_id":"","url":"https://api.github.com/users/elharo","html_url":"https://github.com/elharo","followers_url":"https://api.github.com/users/elharo/followers","following_url":"https://api.github.com/users/elharo/following{/other_user}","gists_url":"https://api.github.com/users/elharo/gists{/gist_id}","starred_url":"https://api.github.com/users/elharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elharo/subscriptions","organizations_url":"https://api.github.com/users/elharo/orgs","repos_url":"https://api.github.com/users/elharo/repos","events_url":"https://api.github.com/users/elharo/events{/privacy}","received_events_url":"https://api.github.com/users/elharo/received_events","type":"User","site_admin":false},"body":"@garrettjonesgoogle @suztomo Some of the things we pull in are quite surprising. E.g Avalon?!\r\n\r\nWe may want to add some exploratory tools to this so we can easily dig in and find out where detritus like this is coming from. ","created_at":"2018-10-11T14:51:38Z","updated_at":"2018-10-11T15:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a234f00997286a4ec9ae2dbb23bfadf67fd45e66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/141/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/statuses/20390c6207011ebae48b310a3d04e6cfec2963b7","head":{"label":"GoogleCloudPlatform:global","ref":"global","sha":"20390c6207011ebae48b310a3d04e6cfec2963b7","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":134450682,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NTA2ODI=","name":"cloud-opensource-java","full_name":"GoogleCloudPlatform/cloud-opensource-java","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java","description":"Code health dashboard for GCP open source projects","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/deployments","created_at":"2018-05-22T17:24:30Z","updated_at":"2018-10-11T14:31:04Z","pushed_at":"2018-10-11T15:12:07Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-opensource-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-opensource-java.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java","homepage":"","size":1196,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":45,"watchers":4,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"3765cfff7a0def94b77d63af811b26c3c3bb23f8","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":134450682,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NTA2ODI=","name":"cloud-opensource-java","full_name":"GoogleCloudPlatform/cloud-opensource-java","private":false,"owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java","description":"Code health dashboard for GCP open source projects","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/deployments","created_at":"2018-05-22T17:24:30Z","updated_at":"2018-10-11T14:31:04Z","pushed_at":"2018-10-11T15:12:07Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-opensource-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-opensource-java.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-opensource-java","homepage":"","size":1196,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":45,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/141"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/141"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-opensource-java/statuses/20390c6207011ebae48b310a3d04e6cfec2963b7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"garrettjonesgoogle"}}