{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/comments/211429249","pull_request_review_id":147848363,"id":211429249,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQyOTI0OQ==","diff_hunk":"@@ -0,0 +1,58 @@\n+// Copyright (c) 2018 Contributors to the Eclipse Foundation\n+//\n+// See the NOTICE file(s) distributed with this work for additional\n+// information regarding copyright ownership.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+// Contributors:\n+// Emily Jiang\n+//\n+\n+= MicroProfile Config and Service Mesh\n+\n+MicroProfile Config provides a solution to externalise the configuration. The default config sources includes environment varialbles, system properties and microprofile-config.properties on the classpath. \n+\n+The properties defined in Kubernetes config map automatically transforms to environment variables. ","path":"spec/src/main/asciidoc/configuration.asciidoc","position":25,"original_position":25,"commit_id":"445e6c9b10df4a753fb84408f87d214b3f4f3aba","original_commit_id":"445e6c9b10df4a753fb84408f87d214b3f4f3aba","user":{"login":"Emily-Jiang","id":10999780,"node_id":"MDQ6VXNlcjEwOTk5Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/10999780?v=4","gravatar_id":"","url":"https://api.github.com/users/Emily-Jiang","html_url":"https://github.com/Emily-Jiang","followers_url":"https://api.github.com/users/Emily-Jiang/followers","following_url":"https://api.github.com/users/Emily-Jiang/following{/other_user}","gists_url":"https://api.github.com/users/Emily-Jiang/gists{/gist_id}","starred_url":"https://api.github.com/users/Emily-Jiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emily-Jiang/subscriptions","organizations_url":"https://api.github.com/users/Emily-Jiang/orgs","repos_url":"https://api.github.com/users/Emily-Jiang/repos","events_url":"https://api.github.com/users/Emily-Jiang/events{/privacy}","received_events_url":"https://api.github.com/users/Emily-Jiang/received_events","type":"User","site_admin":false},"body":"will update it.","created_at":"2018-08-20T22:38:12Z","updated_at":"2018-08-20T22:38:12Z","html_url":"https://github.com/eclipse/microprofile-service-mesh/pull/26#discussion_r211429249","pull_request_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/comments/211429249"},"html":{"href":"https://github.com/eclipse/microprofile-service-mesh/pull/26#discussion_r211429249"},"pull_request":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26"}},"in_reply_to_id":209195702},"pull_request":{"url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26","id":202003747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDAzNzQ3","html_url":"https://github.com/eclipse/microprofile-service-mesh/pull/26","diff_url":"https://github.com/eclipse/microprofile-service-mesh/pull/26.diff","patch_url":"https://github.com/eclipse/microprofile-service-mesh/pull/26.patch","issue_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/26","number":26,"state":"open","locked":false,"title":"#5 add config istio ecosystem chapter","user":{"login":"Emily-Jiang","id":10999780,"node_id":"MDQ6VXNlcjEwOTk5Nzgw","avatar_url":"https://avatars2.githubusercontent.com/u/10999780?v=4","gravatar_id":"","url":"https://api.github.com/users/Emily-Jiang","html_url":"https://github.com/Emily-Jiang","followers_url":"https://api.github.com/users/Emily-Jiang/followers","following_url":"https://api.github.com/users/Emily-Jiang/following{/other_user}","gists_url":"https://api.github.com/users/Emily-Jiang/gists{/gist_id}","starred_url":"https://api.github.com/users/Emily-Jiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emily-Jiang/subscriptions","organizations_url":"https://api.github.com/users/Emily-Jiang/orgs","repos_url":"https://api.github.com/users/Emily-Jiang/repos","events_url":"https://api.github.com/users/Emily-Jiang/events{/privacy}","received_events_url":"https://api.github.com/users/Emily-Jiang/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Emily Jiang <emijiang@uk.ibm.com>","created_at":"2018-07-17T16:46:37Z","updated_at":"2018-08-20T22:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b793c9bf1b678d49a0f6ef89ed968b82a28fba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kenfinnigan","id":441240,"node_id":"MDQ6VXNlcjQ0MTI0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/441240?v=4","gravatar_id":"","url":"https://api.github.com/users/kenfinnigan","html_url":"https://github.com/kenfinnigan","followers_url":"https://api.github.com/users/kenfinnigan/followers","following_url":"https://api.github.com/users/kenfinnigan/following{/other_user}","gists_url":"https://api.github.com/users/kenfinnigan/gists{/gist_id}","starred_url":"https://api.github.com/users/kenfinnigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenfinnigan/subscriptions","organizations_url":"https://api.github.com/users/kenfinnigan/orgs","repos_url":"https://api.github.com/users/kenfinnigan/repos","events_url":"https://api.github.com/users/kenfinnigan/events{/privacy}","received_events_url":"https://api.github.com/users/kenfinnigan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26/commits","review_comments_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26/comments","review_comment_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/26/comments","statuses_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/statuses/445e6c9b10df4a753fb84408f87d214b3f4f3aba","head":{"label":"eclipse:config_branch","ref":"config_branch","sha":"445e6c9b10df4a753fb84408f87d214b3f4f3aba","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":119680491,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2ODA0OTE=","name":"microprofile-service-mesh","full_name":"eclipse/microprofile-service-mesh","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/microprofile-service-mesh","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/microprofile-service-mesh","forks_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/forks","keys_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/teams","hooks_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/hooks","issue_events_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/events","assignees_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/tags","blobs_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/languages","stargazers_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/stargazers","contributors_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/contributors","subscribers_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/subscribers","subscription_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/subscription","commits_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/merges","archive_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/downloads","issues_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/deployments","created_at":"2018-01-31T11:50:16Z","updated_at":"2018-07-10T14:43:21Z","pushed_at":"2018-07-31T09:48:43Z","git_url":"git://github.com/eclipse/microprofile-service-mesh.git","ssh_url":"git@github.com:eclipse/microprofile-service-mesh.git","clone_url":"https://github.com/eclipse/microprofile-service-mesh.git","svn_url":"https://github.com/eclipse/microprofile-service-mesh","homepage":null,"size":36,"stargazers_count":3,"watchers_count":3,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":18,"watchers":3,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"9e7d0da6a4eac0c1aab793bf48d949a9c7bd811f","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":119680491,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2ODA0OTE=","name":"microprofile-service-mesh","full_name":"eclipse/microprofile-service-mesh","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/microprofile-service-mesh","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/microprofile-service-mesh","forks_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/forks","keys_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/teams","hooks_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/hooks","issue_events_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/events","assignees_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/tags","blobs_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/languages","stargazers_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/stargazers","contributors_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/contributors","subscribers_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/subscribers","subscription_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/subscription","commits_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/merges","archive_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/downloads","issues_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/microprofile-service-mesh/deployments","created_at":"2018-01-31T11:50:16Z","updated_at":"2018-07-10T14:43:21Z","pushed_at":"2018-07-31T09:48:43Z","git_url":"git://github.com/eclipse/microprofile-service-mesh.git","ssh_url":"git@github.com:eclipse/microprofile-service-mesh.git","clone_url":"https://github.com/eclipse/microprofile-service-mesh.git","svn_url":"https://github.com/eclipse/microprofile-service-mesh","homepage":null,"size":36,"stargazers_count":3,"watchers_count":3,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":18,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26"},"html":{"href":"https://github.com/eclipse/microprofile-service-mesh/pull/26"},"issue":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/26"},"comments":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/microprofile-service-mesh/statuses/445e6c9b10df4a753fb84408f87d214b3f4f3aba"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Emily-Jiang"}}