{"action":"closed","number":544,"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-table/pulls/544","id":194072701,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDcyNzAx","html_url":"https://github.com/Addepar/ember-table/pull/544","diff_url":"https://github.com/Addepar/ember-table/pull/544.diff","patch_url":"https://github.com/Addepar/ember-table/pull/544.patch","issue_url":"https://api.github.com/repos/Addepar/ember-table/issues/544","number":544,"state":"closed","locked":false,"title":"[feat] Separate row/checkbox selection, fix reordering/resizing","user":{"login":"pzuraq","id":685518,"node_id":"MDQ6VXNlcjY4NTUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/685518?v=4","gravatar_id":"","url":"https://api.github.com/users/pzuraq","html_url":"https://github.com/pzuraq","followers_url":"https://api.github.com/users/pzuraq/followers","following_url":"https://api.github.com/users/pzuraq/following{/other_user}","gists_url":"https://api.github.com/users/pzuraq/gists{/gist_id}","starred_url":"https://api.github.com/users/pzuraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzuraq/subscriptions","organizations_url":"https://api.github.com/users/pzuraq/orgs","repos_url":"https://api.github.com/users/pzuraq/repos","events_url":"https://api.github.com/users/pzuraq/events{/privacy}","received_events_url":"https://api.github.com/users/pzuraq/received_events","type":"User","site_admin":false},"body":"This PR does several things:\r\n\r\n1. Separates row and checkbox selection settings. Users can now\r\nindependently choose the how selection works with checkboxes or by\r\nclicking on rows. This creates a matrix of options that allows a number\r\nof different UX patterns with tables.\r\n\r\n2. Fixes the behavior of reordering. Before, the final drop position was\r\ndetermined by the position of the middle of the resize indicator. This\r\nwas counterintuitive since the reorder indicator could be in a\r\ncompletely different place than the cursor, and it actually did not work\r\nat all in cases where the header was larger than the column that was\r\nattempting to be reordered because headers would not travel beyond the\r\nconfines of the table. Now, the final drop position is determined by the\r\ncursor, and the reorder indicator is always centered on the cursor.\r\n\r\n3. Fixes the resizing. Before, users could begin a resize and end it\r\nwithout removing the `is-resizing` class, locking the table into having\r\nthe resizing cursor forever.","created_at":"2018-06-11T19:00:37Z","updated_at":"2018-06-11T19:37:40Z","closed_at":"2018-06-11T19:37:40Z","merged_at":"2018-06-11T19:37:40Z","merge_commit_sha":"f6b2f7c61036637f9726b0159ce91a79896198ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-table/pulls/544/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-table/pulls/544/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-table/issues/544/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-table/statuses/eabd3adb6b26daa03b2d5d160d6bca5fdc030079","head":{"label":"Addepar:pzuraq/separate-single-group-selection","ref":"pzuraq/separate-single-group-selection","sha":"eabd3adb6b26daa03b2d5d160d6bca5fdc030079","user":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":7193433,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzNDMz","name":"ember-table","full_name":"Addepar/ember-table","owner":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-table","description":null,"fork":false,"url":"https://api.github.com/repos/Addepar/ember-table","forks_url":"https://api.github.com/repos/Addepar/ember-table/forks","keys_url":"https://api.github.com/repos/Addepar/ember-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-table/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-table/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-table/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-table/events","assignees_url":"https://api.github.com/repos/Addepar/ember-table/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-table/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-table/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-table/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-table/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-table/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-table/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-table/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-table/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-table/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-table/merges","archive_url":"https://api.github.com/repos/Addepar/ember-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-table/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-table/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-table/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-table/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-table/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-table/releases{/id}","deployments_url":"https://api.github.com/repos/Addepar/ember-table/deployments","created_at":"2012-12-16T18:10:18Z","updated_at":"2018-06-06T22:22:13Z","pushed_at":"2018-06-11T19:37:40Z","git_url":"git://github.com/Addepar/ember-table.git","ssh_url":"git@github.com:Addepar/ember-table.git","clone_url":"https://github.com/Addepar/ember-table.git","svn_url":"https://github.com/Addepar/ember-table","homepage":"http://addepar.github.com/ember-table/","size":13557,"stargazers_count":1638,"watchers_count":1638,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":283,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":283,"open_issues":12,"watchers":1638,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"66f36628b995009c1ae79d015c3af07daf96e666","user":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":7193433,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzNDMz","name":"ember-table","full_name":"Addepar/ember-table","owner":{"login":"Addepar","id":847867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzg2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/847867?v=4","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-table","description":null,"fork":false,"url":"https://api.github.com/repos/Addepar/ember-table","forks_url":"https://api.github.com/repos/Addepar/ember-table/forks","keys_url":"https://api.github.com/repos/Addepar/ember-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-table/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-table/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-table/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-table/events","assignees_url":"https://api.github.com/repos/Addepar/ember-table/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-table/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-table/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-table/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-table/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-table/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-table/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-table/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-table/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-table/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-table/merges","archive_url":"https://api.github.com/repos/Addepar/ember-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-table/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-table/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-table/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-table/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-table/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-table/releases{/id}","deployments_url":"https://api.github.com/repos/Addepar/ember-table/deployments","created_at":"2012-12-16T18:10:18Z","updated_at":"2018-06-06T22:22:13Z","pushed_at":"2018-06-11T19:37:40Z","git_url":"git://github.com/Addepar/ember-table.git","ssh_url":"git@github.com:Addepar/ember-table.git","clone_url":"https://github.com/Addepar/ember-table.git","svn_url":"https://github.com/Addepar/ember-table","homepage":"http://addepar.github.com/ember-table/","size":13557,"stargazers_count":1638,"watchers_count":1638,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":283,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":283,"open_issues":12,"watchers":1638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-table/pulls/544"},"html":{"href":"https://github.com/Addepar/ember-table/pull/544"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-table/issues/544"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-table/issues/544/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-table/pulls/544/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-table/pulls/544/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-table/statuses/eabd3adb6b26daa03b2d5d160d6bca5fdc030079"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pzuraq","id":685518,"node_id":"MDQ6VXNlcjY4NTUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/685518?v=4","gravatar_id":"","url":"https://api.github.com/users/pzuraq","html_url":"https://github.com/pzuraq","followers_url":"https://api.github.com/users/pzuraq/followers","following_url":"https://api.github.com/users/pzuraq/following{/other_user}","gists_url":"https://api.github.com/users/pzuraq/gists{/gist_id}","starred_url":"https://api.github.com/users/pzuraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzuraq/subscriptions","organizations_url":"https://api.github.com/users/pzuraq/orgs","repos_url":"https://api.github.com/users/pzuraq/repos","events_url":"https://api.github.com/users/pzuraq/events{/privacy}","received_events_url":"https://api.github.com/users/pzuraq/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":614,"deletions":307,"changed_files":25}}
{"actor":{"display_login":"pzuraq"}}