{"action":"closed","number":9832,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9832","id":196568254,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTY4MjU0","html_url":"https://github.com/mozilla/pdf.js/pull/9832","diff_url":"https://github.com/mozilla/pdf.js/pull/9832.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/9832.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9832","number":9832,"state":"closed","locked":false,"title":"Fix a number of regressions/inefficiencies introduced by adding Scroll/Spread modes to the viewer (PR 9208 follow-up)","user":{"login":"Snuffleupagus","id":2692120,"node_id":"MDQ6VXNlcjI2OTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"This PR contains a couple of *very* quick patches, to address a number of regressions/inefficiencies introduced in the viewer by the Scroll/Spread modes PR.[1]\r\nIn addition, most of the new code isn't needed (at all) in `PDFSinglePageView` instances, and this PR also tries to clean that up as well.\r\n\r\nGiven the regressions, the `2.0.550` pre-release might need to be replaced once this PR lands.\r\n\r\n*Please refer to the individual commit messages for additional details.*\r\n\r\n**Edit:** Please note that the viewer is currently *unusable* in older browsers (such as IE11), refer to the first commit.\r\n\r\n---\r\n[1] There's probably room for additional clean-up, but someone else is more than welcome to do that :-)","created_at":"2018-06-21T20:36:25Z","updated_at":"2018-06-23T19:09:56Z","closed_at":"2018-06-23T19:09:56Z","merged_at":"2018-06-23T19:09:56Z","merge_commit_sha":"e8b5088370565a338f7970a2a4b0bbbbed79b11b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":164429,"node_id":"MDU6TGFiZWwxNjQ0Mjk=","url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-viewer","name":"1-viewer","color":"DDDDDD","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9832/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9832/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9832/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/bfbe2b411c3aa0925fa6b0c35a1eee3614c9ddf6","head":{"label":"Snuffleupagus:scrollMode-fixes","ref":"scrollMode-fixes","sha":"bfbe2b411c3aa0925fa6b0c35a1eee3614c9ddf6","user":{"login":"Snuffleupagus","id":2692120,"node_id":"MDQ6VXNlcjI2OTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"repo":{"id":133657641,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM2NTc2NDE=","name":"pdf.js","full_name":"Snuffleupagus/pdf.js","owner":{"login":"Snuffleupagus","id":2692120,"node_id":"MDQ6VXNlcjI2OTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Snuffleupagus/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js","forks_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/forks","keys_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/teams","hooks_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/events","assignees_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/tags","blobs_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/languages","stargazers_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/subscription","commits_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/merges","archive_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/downloads","issues_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/deployments","created_at":"2018-05-16T11:47:30Z","updated_at":"2018-06-23T12:20:46Z","pushed_at":"2018-06-23T14:50:31Z","git_url":"git://github.com/Snuffleupagus/pdf.js.git","ssh_url":"git@github.com:Snuffleupagus/pdf.js.git","clone_url":"https://github.com/Snuffleupagus/pdf.js.git","svn_url":"https://github.com/Snuffleupagus/pdf.js","homepage":"","size":72917,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"34594a5b02394a531c1512ff10b44148225abe67","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYzNDY4","name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pdf.js/deployments","created_at":"2011-04-26T06:32:03Z","updated_at":"2018-06-23T15:39:57Z","pushed_at":"2018-06-23T19:09:56Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":73439,"stargazers_count":22475,"watchers_count":22475,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5525,"mirror_url":null,"archived":false,"open_issues_count":742,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5525,"open_issues":742,"watchers":22475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9832"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/9832"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/9832"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/9832/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9832/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/9832/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/bfbe2b411c3aa0925fa6b0c35a1eee3614c9ddf6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"timvandermeij","id":1993262,"node_id":"MDQ6VXNlcjE5OTMyNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":124,"deletions":48,"changed_files":4}}
{"actor":{"display_login":"timvandermeij"}}