{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/180955584","pull_request_review_id":111468657,"id":180955584,"diff_hunk":"@@ -36,6 +36,8 @@\n \n public class IndexTaskUtils\n {\n+  public static final int DEFAULT_MAX_ROWS_IN_MEMORY = 75_000;","path":"indexing-service/src/main/java/io/druid/indexing/common/task/IndexTaskUtils.java","position":4,"original_position":4,"commit_id":"c45bf3bcc0a643c242212ab06922a4afd494b8ff","original_commit_id":"c45bf3bcc0a643c242212ab06922a4afd494b8ff","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars3.githubusercontent.com/u/1214075?v=4","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"body":"Let's use `1_000_000` here.","created_at":"2018-04-12T03:22:05Z","updated_at":"2018-04-12T04:04:38Z","html_url":"https://github.com/druid-io/druid/pull/5583#discussion_r180955584","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/5583","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/180955584"},"html":{"href":"https://github.com/druid-io/druid/pull/5583#discussion_r180955584"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5583"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/5583","id":179791378,"html_url":"https://github.com/druid-io/druid/pull/5583","diff_url":"https://github.com/druid-io/druid/pull/5583.diff","patch_url":"https://github.com/druid-io/druid/pull/5583.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/5583","number":5583,"state":"open","locked":false,"title":"'maxBytesInMemory' tuningConfig introduced for ingestion tasks","user":{"login":"surekhasaharan","id":13008746,"avatar_url":"https://avatars3.githubusercontent.com/u/13008746?v=4","gravatar_id":"","url":"https://api.github.com/users/surekhasaharan","html_url":"https://github.com/surekhasaharan","followers_url":"https://api.github.com/users/surekhasaharan/followers","following_url":"https://api.github.com/users/surekhasaharan/following{/other_user}","gists_url":"https://api.github.com/users/surekhasaharan/gists{/gist_id}","starred_url":"https://api.github.com/users/surekhasaharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surekhasaharan/subscriptions","organizations_url":"https://api.github.com/users/surekhasaharan/orgs","repos_url":"https://api.github.com/users/surekhasaharan/repos","events_url":"https://api.github.com/users/surekhasaharan/events{/privacy}","received_events_url":"https://api.github.com/users/surekhasaharan/received_events","type":"User","site_admin":false},"body":"Currently a config called 'maxRowsInMemory' is present which affects how much memory gets\r\nused for indexing. If this value is not optimal for your JVM heap size, it could lead\r\nto OutOfMemoryError sometimes. A lower value will lead to frequent persists which might\r\nbe bad for query performance and a higher value will limit number of persists but require\r\nmore jvm heap space and could lead to OOM.\r\n'maxBytesInMemory' is an attempt to solve this problem. It limits the total number of bytes\r\nkept in memory before persisting.\r\n\r\n * The default value is 1/3(Runtime.maxMemory())\r\n * To maintain the current behaviour set 'maxBytesInMemory' to -1\r\n * If both 'maxRowsInMemory' and 'maxBytesInMemory' are present, both of them\r\n   will be respected i.e. the first one to go above threshold will trigger persist","created_at":"2018-04-05T20:44:41Z","updated_at":"2018-04-12T04:04:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21649ec0b6a8521bf7c2d0392212a47d7a5996f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":297508895,"url":"https://api.github.com/repos/druid-io/druid/labels/Release%20Notes","name":"Release Notes","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/5583/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/5583/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/5583/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/c45bf3bcc0a643c242212ab06922a4afd494b8ff","head":{"label":"surekhasaharan:feature-allow-set-max-memory","ref":"feature-allow-set-max-memory","sha":"c45bf3bcc0a643c242212ab06922a4afd494b8ff","user":{"login":"surekhasaharan","id":13008746,"avatar_url":"https://avatars3.githubusercontent.com/u/13008746?v=4","gravatar_id":"","url":"https://api.github.com/users/surekhasaharan","html_url":"https://github.com/surekhasaharan","followers_url":"https://api.github.com/users/surekhasaharan/followers","following_url":"https://api.github.com/users/surekhasaharan/following{/other_user}","gists_url":"https://api.github.com/users/surekhasaharan/gists{/gist_id}","starred_url":"https://api.github.com/users/surekhasaharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surekhasaharan/subscriptions","organizations_url":"https://api.github.com/users/surekhasaharan/orgs","repos_url":"https://api.github.com/users/surekhasaharan/repos","events_url":"https://api.github.com/users/surekhasaharan/events{/privacy}","received_events_url":"https://api.github.com/users/surekhasaharan/received_events","type":"User","site_admin":false},"repo":{"id":126250162,"name":"druid","full_name":"surekhasaharan/druid","owner":{"login":"surekhasaharan","id":13008746,"avatar_url":"https://avatars3.githubusercontent.com/u/13008746?v=4","gravatar_id":"","url":"https://api.github.com/users/surekhasaharan","html_url":"https://github.com/surekhasaharan","followers_url":"https://api.github.com/users/surekhasaharan/followers","following_url":"https://api.github.com/users/surekhasaharan/following{/other_user}","gists_url":"https://api.github.com/users/surekhasaharan/gists{/gist_id}","starred_url":"https://api.github.com/users/surekhasaharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surekhasaharan/subscriptions","organizations_url":"https://api.github.com/users/surekhasaharan/orgs","repos_url":"https://api.github.com/users/surekhasaharan/repos","events_url":"https://api.github.com/users/surekhasaharan/events{/privacy}","received_events_url":"https://api.github.com/users/surekhasaharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/surekhasaharan/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/surekhasaharan/druid","forks_url":"https://api.github.com/repos/surekhasaharan/druid/forks","keys_url":"https://api.github.com/repos/surekhasaharan/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/surekhasaharan/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/surekhasaharan/druid/teams","hooks_url":"https://api.github.com/repos/surekhasaharan/druid/hooks","issue_events_url":"https://api.github.com/repos/surekhasaharan/druid/issues/events{/number}","events_url":"https://api.github.com/repos/surekhasaharan/druid/events","assignees_url":"https://api.github.com/repos/surekhasaharan/druid/assignees{/user}","branches_url":"https://api.github.com/repos/surekhasaharan/druid/branches{/branch}","tags_url":"https://api.github.com/repos/surekhasaharan/druid/tags","blobs_url":"https://api.github.com/repos/surekhasaharan/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/surekhasaharan/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/surekhasaharan/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/surekhasaharan/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/surekhasaharan/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/surekhasaharan/druid/languages","stargazers_url":"https://api.github.com/repos/surekhasaharan/druid/stargazers","contributors_url":"https://api.github.com/repos/surekhasaharan/druid/contributors","subscribers_url":"https://api.github.com/repos/surekhasaharan/druid/subscribers","subscription_url":"https://api.github.com/repos/surekhasaharan/druid/subscription","commits_url":"https://api.github.com/repos/surekhasaharan/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/surekhasaharan/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/surekhasaharan/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/surekhasaharan/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/surekhasaharan/druid/contents/{+path}","compare_url":"https://api.github.com/repos/surekhasaharan/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/surekhasaharan/druid/merges","archive_url":"https://api.github.com/repos/surekhasaharan/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/surekhasaharan/druid/downloads","issues_url":"https://api.github.com/repos/surekhasaharan/druid/issues{/number}","pulls_url":"https://api.github.com/repos/surekhasaharan/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/surekhasaharan/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/surekhasaharan/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/surekhasaharan/druid/labels{/name}","releases_url":"https://api.github.com/repos/surekhasaharan/druid/releases{/id}","deployments_url":"https://api.github.com/repos/surekhasaharan/druid/deployments","created_at":"2018-03-21T22:54:11Z","updated_at":"2018-03-21T22:54:25Z","pushed_at":"2018-04-09T20:42:52Z","git_url":"git://github.com/surekhasaharan/druid.git","ssh_url":"git@github.com:surekhasaharan/druid.git","clone_url":"https://github.com/surekhasaharan/druid.git","svn_url":"https://github.com/surekhasaharan/druid","homepage":"http://druid.io","size":135248,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"685f4063d4e63fba5f9ae11bf496c4c2575a8ebf","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars0.githubusercontent.com/u/4203474?v=4","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars0.githubusercontent.com/u/4203474?v=4","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2018-04-12T02:58:21Z","pushed_at":"2018-04-12T02:44:03Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":136536,"stargazers_count":6319,"watchers_count":6319,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1562,"mirror_url":null,"archived":false,"open_issues_count":974,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1562,"open_issues":974,"watchers":6319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5583"},"html":{"href":"https://github.com/druid-io/druid/pull/5583"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/5583"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/5583/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5583/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5583/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/c45bf3bcc0a643c242212ab06922a4afd494b8ff"}},"author_association":"NONE"}}
{"actor":{"display_login":"gianm"}}