{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/elife-bot/pulls/comments/222499401","pull_request_review_id":161401488,"id":222499401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ5OTQwMQ==","diff_hunk":"@@ -70,6 +70,10 @@ def do_activity(self, data=None):\n             if existing_digest_json.get(\"stage\") != \"published\":\n                 self.digest_content = digest_provider.set_stage(existing_digest_json, 'published')\n                 self.logger.info(\"Set Digest stage value of %s to published\" % article_id)\n+                # set the published date\n+                if not self.digest_content.get(\"published\"):","path":"activity/activity_PublishDigest.py","position":5,"original_position":5,"commit_id":"fed7150b90bbbd7553eddb63bf48dfac602efdf3","original_commit_id":"fed7150b90bbbd7553eddb63bf48dfac602efdf3","user":{"login":"gnott","id":1779115,"node_id":"MDQ6VXNlcjE3NzkxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1779115?v=4","gravatar_id":"","url":"https://api.github.com/users/gnott","html_url":"https://github.com/gnott","followers_url":"https://api.github.com/users/gnott/followers","following_url":"https://api.github.com/users/gnott/following{/other_user}","gists_url":"https://api.github.com/users/gnott/gists{/gist_id}","starred_url":"https://api.github.com/users/gnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnott/subscriptions","organizations_url":"https://api.github.com/users/gnott/orgs","repos_url":"https://api.github.com/users/gnott/repos","events_url":"https://api.github.com/users/gnott/events{/privacy}","received_events_url":"https://api.github.com/users/gnott/received_events","type":"User","site_admin":false},"body":"I agree we would probably never see a digest with a `published` date value which does not have a `stage` value `published`. We could change this to be very explicit that the `published` date is always set when the digest is marked as `published`. I was probably not sure whether it may result in overwriting a date accidentally when we do not want to.","created_at":"2018-10-03T23:34:00Z","updated_at":"2018-10-03T23:34:00Z","html_url":"https://github.com/elifesciences/elife-bot/pull/795#discussion_r222499401","pull_request_url":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-bot/pulls/comments/222499401"},"html":{"href":"https://github.com/elifesciences/elife-bot/pull/795#discussion_r222499401"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795"}},"in_reply_to_id":222250532},"pull_request":{"url":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795","id":219919527,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTE5NTI3","html_url":"https://github.com/elifesciences/elife-bot/pull/795","diff_url":"https://github.com/elifesciences/elife-bot/pull/795.diff","patch_url":"https://github.com/elifesciences/elife-bot/pull/795.patch","issue_url":"https://api.github.com/repos/elifesciences/elife-bot/issues/795","number":795,"state":"closed","locked":false,"title":"Feature digest published value","user":{"login":"gnott","id":1779115,"node_id":"MDQ6VXNlcjE3NzkxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1779115?v=4","gravatar_id":"","url":"https://api.github.com/users/gnott","html_url":"https://github.com/gnott","followers_url":"https://api.github.com/users/gnott/followers","following_url":"https://api.github.com/users/gnott/following{/other_user}","gists_url":"https://api.github.com/users/gnott/gists{/gist_id}","starred_url":"https://api.github.com/users/gnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnott/subscriptions","organizations_url":"https://api.github.com/users/gnott/orgs","repos_url":"https://api.github.com/users/gnott/repos","events_url":"https://api.github.com/users/gnott/events{/privacy}","received_events_url":"https://api.github.com/users/gnott/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/elifesciences/issues/issues/4474\r\n\r\nReady to review, I think it is feature complete.\r\n\r\nNewest `digest-parser` library does not automatically set a digest `published` date from the JATS XML file value.\r\n\r\nLax data for the `versionDate` of the first VoR version is used in the `digest_provider` to supply the date we want in `published_date_from_lax()`.\r\n\r\nIf the digest has no `published` value when it is about to be published in the `PublishDigest` activity, it is set to the value that comes from Lax.","created_at":"2018-10-03T05:33:49Z","updated_at":"2018-10-03T23:34:00Z","closed_at":"2018-10-03T10:04:40Z","merged_at":"2018-10-03T10:04:40Z","merge_commit_sha":"37bb08a5d2659260df0998997c00bd4889cd49c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795/commits","review_comments_url":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795/comments","review_comment_url":"https://api.github.com/repos/elifesciences/elife-bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/elife-bot/issues/795/comments","statuses_url":"https://api.github.com/repos/elifesciences/elife-bot/statuses/fed7150b90bbbd7553eddb63bf48dfac602efdf3","head":{"label":"elifesciences:feature-digest-published-value","ref":"feature-digest-published-value","sha":"fed7150b90bbbd7553eddb63bf48dfac602efdf3","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":7503542,"node_id":"MDEwOlJlcG9zaXRvcnk3NTAzNTQy","name":"elife-bot","full_name":"elifesciences/elife-bot","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-bot","description":"tools for creating an automatic publishing workflow. ","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-bot","forks_url":"https://api.github.com/repos/elifesciences/elife-bot/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-bot/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-bot/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-bot/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-bot/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-bot/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-bot/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-bot/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-bot/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-bot/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-bot/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-bot/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-bot/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-bot/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-bot/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-bot/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-bot/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-bot/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-bot/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-bot/deployments","created_at":"2013-01-08T15:09:54Z","updated_at":"2018-10-03T10:04:43Z","pushed_at":"2018-10-03T12:11:56Z","git_url":"git://github.com/elifesciences/elife-bot.git","ssh_url":"git@github.com:elifesciences/elife-bot.git","clone_url":"https://github.com/elifesciences/elife-bot.git","svn_url":"https://github.com/elifesciences/elife-bot","homepage":null,"size":104266,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":36,"watchers":15,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"ddebe5e4bda7090e6b05232320f308f577d9d5af","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":7503542,"node_id":"MDEwOlJlcG9zaXRvcnk3NTAzNTQy","name":"elife-bot","full_name":"elifesciences/elife-bot","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-bot","description":"tools for creating an automatic publishing workflow. ","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-bot","forks_url":"https://api.github.com/repos/elifesciences/elife-bot/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-bot/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-bot/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-bot/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-bot/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-bot/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-bot/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-bot/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-bot/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-bot/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-bot/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-bot/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-bot/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-bot/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-bot/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-bot/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-bot/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-bot/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-bot/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-bot/deployments","created_at":"2013-01-08T15:09:54Z","updated_at":"2018-10-03T10:04:43Z","pushed_at":"2018-10-03T12:11:56Z","git_url":"git://github.com/elifesciences/elife-bot.git","ssh_url":"git@github.com:elifesciences/elife-bot.git","clone_url":"https://github.com/elifesciences/elife-bot.git","svn_url":"https://github.com/elifesciences/elife-bot","homepage":null,"size":104266,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":36,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795"},"html":{"href":"https://github.com/elifesciences/elife-bot/pull/795"},"issue":{"href":"https://api.github.com/repos/elifesciences/elife-bot/issues/795"},"comments":{"href":"https://api.github.com/repos/elifesciences/elife-bot/issues/795/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/elife-bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/elife-bot/pulls/795/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/elife-bot/statuses/fed7150b90bbbd7553eddb63bf48dfac602efdf3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gnott"}}