{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/comments/207603641","pull_request_review_id":143254878,"id":207603641,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzYwMzY0MQ==","diff_hunk":"@@ -1 +1 @@\n-export default class{constructor(b){this.a=b}console(){console.log(this.a)}}\n+class a{constructor(b){this.a=b}console(){console.log(this.a)}}export default a;","path":"test/export-default/fixtures/class.esm.advanced.js","position":2,"original_position":2,"commit_id":"fc53887856edfddfef289495a4c7f132d7b6f08b","original_commit_id":"fc53887856edfddfef289495a4c7f132d7b6f08b","user":{"login":"kristoferbaxter","id":61764,"node_id":"MDQ6VXNlcjYxNzY0","avatar_url":"https://avatars1.githubusercontent.com/u/61764?v=4","gravatar_id":"","url":"https://api.github.com/users/kristoferbaxter","html_url":"https://github.com/kristoferbaxter","followers_url":"https://api.github.com/users/kristoferbaxter/followers","following_url":"https://api.github.com/users/kristoferbaxter/following{/other_user}","gists_url":"https://api.github.com/users/kristoferbaxter/gists{/gist_id}","starred_url":"https://api.github.com/users/kristoferbaxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristoferbaxter/subscriptions","organizations_url":"https://api.github.com/users/kristoferbaxter/orgs","repos_url":"https://api.github.com/users/kristoferbaxter/repos","events_url":"https://api.github.com/users/kristoferbaxter/events{/privacy}","received_events_url":"https://api.github.com/users/kristoferbaxter/received_events","type":"User","site_admin":false},"body":"Slight regression in size here, since we are no longer exporting the default defined class, but we can likely recover the delta in a future enhancement.","created_at":"2018-08-03T16:44:51Z","updated_at":"2018-08-03T16:44:52Z","html_url":"https://github.com/ampproject/rollup-plugin-closure-compiler/pull/32#discussion_r207603641","pull_request_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/comments/207603641"},"html":{"href":"https://github.com/ampproject/rollup-plugin-closure-compiler/pull/32#discussion_r207603641"},"pull_request":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32","id":206049382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDQ5Mzgy","html_url":"https://github.com/ampproject/rollup-plugin-closure-compiler/pull/32","diff_url":"https://github.com/ampproject/rollup-plugin-closure-compiler/pull/32.diff","patch_url":"https://github.com/ampproject/rollup-plugin-closure-compiler/pull/32.patch","issue_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues/32","number":32,"state":"open","locked":false,"title":"Support export * as statements","user":{"login":"TrySound","id":5635476,"node_id":"MDQ6VXNlcjU2MzU0NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"body":"The trick is simple. Rollup resolves `export *` statements into a list\r\nof exports. The only problem here could be export * from externals.","created_at":"2018-08-03T14:35:08Z","updated_at":"2018-08-03T16:44:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb201a9e79b2e6291014b46f6ce1659e1ba70c44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1009393869,"node_id":"MDU6TGFiZWwxMDA5MzkzODY5","url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/labels/cla:%20yes","name":"cla: yes","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32/commits","review_comments_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32/comments","review_comment_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues/32/comments","statuses_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/statuses/fc53887856edfddfef289495a4c7f132d7b6f08b","head":{"label":"TrySound:export-all-support","ref":"export-all-support","sha":"fc53887856edfddfef289495a4c7f132d7b6f08b","user":{"login":"TrySound","id":5635476,"node_id":"MDQ6VXNlcjU2MzU0NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"repo":{"id":143437827,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0Mzc4Mjc=","name":"rollup-plugin-closure-compiler","full_name":"TrySound/rollup-plugin-closure-compiler","owner":{"login":"TrySound","id":5635476,"node_id":"MDQ6VXNlcjU2MzU0NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/5635476?v=4","gravatar_id":"","url":"https://api.github.com/users/TrySound","html_url":"https://github.com/TrySound","followers_url":"https://api.github.com/users/TrySound/followers","following_url":"https://api.github.com/users/TrySound/following{/other_user}","gists_url":"https://api.github.com/users/TrySound/gists{/gist_id}","starred_url":"https://api.github.com/users/TrySound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrySound/subscriptions","organizations_url":"https://api.github.com/users/TrySound/orgs","repos_url":"https://api.github.com/users/TrySound/repos","events_url":"https://api.github.com/users/TrySound/events{/privacy}","received_events_url":"https://api.github.com/users/TrySound/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TrySound/rollup-plugin-closure-compiler","description":"Leverage Closure Compiler to minify and optimize JavaScript with Rollup.","fork":true,"url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler","forks_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/forks","keys_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/teams","hooks_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/events","assignees_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/tags","blobs_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/languages","stargazers_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/subscription","commits_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/merges","archive_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/downloads","issues_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/releases{/id}","deployments_url":"https://api.github.com/repos/TrySound/rollup-plugin-closure-compiler/deployments","created_at":"2018-08-03T14:33:32Z","updated_at":"2018-08-03T14:33:34Z","pushed_at":"2018-08-03T14:34:30Z","git_url":"git://github.com/TrySound/rollup-plugin-closure-compiler.git","ssh_url":"git@github.com:TrySound/rollup-plugin-closure-compiler.git","clone_url":"https://github.com/TrySound/rollup-plugin-closure-compiler.git","svn_url":"https://github.com/TrySound/rollup-plugin-closure-compiler","homepage":"","size":219,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"0ebc9f71ba90d2274d3b2b7e4fd6dadaae3fb249","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":139080902,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwODA5MDI=","name":"rollup-plugin-closure-compiler","full_name":"ampproject/rollup-plugin-closure-compiler","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/rollup-plugin-closure-compiler","description":"Leverage Closure Compiler to minify and optimize JavaScript with Rollup.","fork":false,"url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler","forks_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/forks","keys_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/teams","hooks_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/events","assignees_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/tags","blobs_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/languages","stargazers_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/subscription","commits_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/merges","archive_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/downloads","issues_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/deployments","created_at":"2018-06-29T00:12:57Z","updated_at":"2018-08-03T15:39:05Z","pushed_at":"2018-08-03T14:35:08Z","git_url":"git://github.com/ampproject/rollup-plugin-closure-compiler.git","ssh_url":"git@github.com:ampproject/rollup-plugin-closure-compiler.git","clone_url":"https://github.com/ampproject/rollup-plugin-closure-compiler.git","svn_url":"https://github.com/ampproject/rollup-plugin-closure-compiler","homepage":"","size":159,"stargazers_count":103,"watchers_count":103,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":3,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32"},"html":{"href":"https://github.com/ampproject/rollup-plugin-closure-compiler/pull/32"},"issue":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues/32"},"comments":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/rollup-plugin-closure-compiler/statuses/fc53887856edfddfef289495a4c7f132d7b6f08b"}},"author_association":"NONE"}}
{"actor":{"display_login":"kristoferbaxter"}}