{"action":"created","comment":{"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/comments/189714300","pull_request_review_id":121947808,"id":189714300,"diff_hunk":"@@ -512,10 +506,15 @@ void HAL_CAN_RxCpltCallback(CAN_HandleTypeDef* hcan)\n \n     CanRxMsgTypeDef* msg = hcan->pRxMsg;\n \n-    if (msg->StdId == ORION_MAX_MIN_VOLTAGES_STDID)\n+    if (msg->StdId == ORION_MAX_MIN_VOLTAGES_STDID && msg->DLC == 8)\n     {\n-        orionStatus.maxCellVoltage = (uint16_t)msg->Data[6]; // Max Cell voltage\n-        orionStatus.minCellVoltage = (uint16_t)msg->Data[4]; // Min Cell Voltage\n+        // Voltages are 2 bytes each, and memory is stored in little endian format\n+        orionStatus.maxCellVoltage = (uint16_t)msg->Data[6] << 8 | msg->Data[7]; // Max Cell voltage\n+        orionStatus.minCellVoltage = (uint16_t)msg->Data[4] << 8 | msg->Data[5]; // Min Cell Voltage\n+    }\n+    else if (msg->StdId == DRIVERS_INPUTS_STDID && msg->DLC == 4)\n+    {\n+        driversInput.aux = msg->Data[0] >> DRIVERS_INPUTS_AUX_BIT_POSITION & 1;","path":"EpsilonAuxBMS/Src/main.c","position":90,"original_position":90,"commit_id":"e97a4dcf047f180168c8aaee0429bf5f9b1e1b02","original_commit_id":"e97a4dcf047f180168c8aaee0429bf5f9b1e1b02","user":{"login":"bill-luu","id":15304203,"avatar_url":"https://avatars1.githubusercontent.com/u/15304203?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-luu","html_url":"https://github.com/bill-luu","followers_url":"https://api.github.com/users/bill-luu/followers","following_url":"https://api.github.com/users/bill-luu/following{/other_user}","gists_url":"https://api.github.com/users/bill-luu/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-luu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-luu/subscriptions","organizations_url":"https://api.github.com/users/bill-luu/orgs","repos_url":"https://api.github.com/users/bill-luu/repos","events_url":"https://api.github.com/users/bill-luu/events{/privacy}","received_events_url":"https://api.github.com/users/bill-luu/received_events","type":"User","site_admin":false},"body":"This should be in index 3.","created_at":"2018-05-21T21:07:13Z","updated_at":"2018-05-21T21:09:46Z","html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/71#discussion_r189714300","pull_request_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/comments/189714300"},"html":{"href":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/71#discussion_r189714300"},"pull_request":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71","id":189213574,"html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/71","diff_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/71.diff","patch_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/71.patch","issue_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/71","number":71,"state":"open","locked":false,"title":"Baba/aux bms functional","user":{"login":"bill-luu","id":15304203,"avatar_url":"https://avatars1.githubusercontent.com/u/15304203?v=4","gravatar_id":"","url":"https://api.github.com/users/bill-luu","html_url":"https://github.com/bill-luu","followers_url":"https://api.github.com/users/bill-luu/followers","following_url":"https://api.github.com/users/bill-luu/following{/other_user}","gists_url":"https://api.github.com/users/bill-luu/gists{/gist_id}","starred_url":"https://api.github.com/users/bill-luu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill-luu/subscriptions","organizations_url":"https://api.github.com/users/bill-luu/orgs","repos_url":"https://api.github.com/users/bill-luu/repos","events_url":"https://api.github.com/users/bill-luu/events{/privacy}","received_events_url":"https://api.github.com/users/bill-luu/received_events","type":"User","site_admin":false},"body":"It was getting really hard to tell the diff, so I opened this guy. Merge this, then merge the other PR!","created_at":"2018-05-20T00:53:44Z","updated_at":"2018-05-21T21:09:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a999005f41073377e35b2172b08196b4f77cb4d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"badeniran","id":15066656,"avatar_url":"https://avatars1.githubusercontent.com/u/15066656?v=4","gravatar_id":"","url":"https://api.github.com/users/badeniran","html_url":"https://github.com/badeniran","followers_url":"https://api.github.com/users/badeniran/followers","following_url":"https://api.github.com/users/badeniran/following{/other_user}","gists_url":"https://api.github.com/users/badeniran/gists{/gist_id}","starred_url":"https://api.github.com/users/badeniran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badeniran/subscriptions","organizations_url":"https://api.github.com/users/badeniran/orgs","repos_url":"https://api.github.com/users/badeniran/repos","events_url":"https://api.github.com/users/badeniran/events{/privacy}","received_events_url":"https://api.github.com/users/badeniran/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71/commits","review_comments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71/comments","review_comment_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/71/comments","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/statuses/e97a4dcf047f180168c8aaee0429bf5f9b1e1b02","head":{"label":"UCSolarCarTeam:baba/AuxBMSFunctional","ref":"baba/AuxBMSFunctional","sha":"e97a4dcf047f180168c8aaee0429bf5f9b1e1b02","user":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars0.githubusercontent.com/u/14067129?v=4","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":69643664,"name":"Epsilon-Embedded-Software","full_name":"UCSolarCarTeam/Epsilon-Embedded-Software","owner":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars0.githubusercontent.com/u/14067129?v=4","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software","description":null,"fork":false,"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software","forks_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/forks","keys_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/teams","hooks_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/hooks","issue_events_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/events{/number}","events_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/events","assignees_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/assignees{/user}","branches_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/branches{/branch}","tags_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/tags","blobs_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/languages","stargazers_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/stargazers","contributors_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/contributors","subscribers_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/subscribers","subscription_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/subscription","commits_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/contents/{+path}","compare_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/merges","archive_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/downloads","issues_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues{/number}","pulls_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/labels{/name}","releases_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/releases{/id}","deployments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/deployments","created_at":"2016-09-30T07:18:14Z","updated_at":"2018-05-21T19:37:48Z","pushed_at":"2018-05-21T19:38:12Z","git_url":"git://github.com/UCSolarCarTeam/Epsilon-Embedded-Software.git","ssh_url":"git@github.com:UCSolarCarTeam/Epsilon-Embedded-Software.git","clone_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software.git","svn_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software","homepage":null,"size":6084,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"UCSolarCarTeam:bill/AuxBmsCopy","ref":"bill/AuxBmsCopy","sha":"7a0723e26a9e66ec848536d15b88a67f6c84cac6","user":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars0.githubusercontent.com/u/14067129?v=4","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":69643664,"name":"Epsilon-Embedded-Software","full_name":"UCSolarCarTeam/Epsilon-Embedded-Software","owner":{"login":"UCSolarCarTeam","id":14067129,"avatar_url":"https://avatars0.githubusercontent.com/u/14067129?v=4","gravatar_id":"","url":"https://api.github.com/users/UCSolarCarTeam","html_url":"https://github.com/UCSolarCarTeam","followers_url":"https://api.github.com/users/UCSolarCarTeam/followers","following_url":"https://api.github.com/users/UCSolarCarTeam/following{/other_user}","gists_url":"https://api.github.com/users/UCSolarCarTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UCSolarCarTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UCSolarCarTeam/subscriptions","organizations_url":"https://api.github.com/users/UCSolarCarTeam/orgs","repos_url":"https://api.github.com/users/UCSolarCarTeam/repos","events_url":"https://api.github.com/users/UCSolarCarTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UCSolarCarTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software","description":null,"fork":false,"url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software","forks_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/forks","keys_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/teams","hooks_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/hooks","issue_events_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/events{/number}","events_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/events","assignees_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/assignees{/user}","branches_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/branches{/branch}","tags_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/tags","blobs_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/refs{/sha}","trees_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/statuses/{sha}","languages_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/languages","stargazers_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/stargazers","contributors_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/contributors","subscribers_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/subscribers","subscription_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/subscription","commits_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/commits{/sha}","git_commits_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/git/commits{/sha}","comments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/comments{/number}","issue_comment_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/comments{/number}","contents_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/contents/{+path}","compare_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/merges","archive_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/downloads","issues_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues{/number}","pulls_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls{/number}","milestones_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/milestones{/number}","notifications_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/labels{/name}","releases_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/releases{/id}","deployments_url":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/deployments","created_at":"2016-09-30T07:18:14Z","updated_at":"2018-05-21T19:37:48Z","pushed_at":"2018-05-21T19:38:12Z","git_url":"git://github.com/UCSolarCarTeam/Epsilon-Embedded-Software.git","ssh_url":"git@github.com:UCSolarCarTeam/Epsilon-Embedded-Software.git","clone_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software.git","svn_url":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software","homepage":null,"size":6084,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71"},"html":{"href":"https://github.com/UCSolarCarTeam/Epsilon-Embedded-Software/pull/71"},"issue":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/71"},"comments":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/UCSolarCarTeam/Epsilon-Embedded-Software/statuses/e97a4dcf047f180168c8aaee0429bf5f9b1e1b02"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bill-luu"}}