{"action":"created","issue":{"url":"https://api.github.com/repos/apache/metron/issues/1064","repository_url":"https://api.github.com/repos/apache/metron","labels_url":"https://api.github.com/repos/apache/metron/issues/1064/labels{/name}","comments_url":"https://api.github.com/repos/apache/metron/issues/1064/comments","events_url":"https://api.github.com/repos/apache/metron/issues/1064/events","html_url":"https://github.com/apache/metron/pull/1064","id":333002440,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzQxMzUz","number":1064,"title":"METRON-1619: Stellar empty collections should be considered false in boolean expressions","user":{"login":"cestella","id":540359,"node_id":"MDQ6VXNlcjU0MDM1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/540359?v=4","gravatar_id":"","url":"https://api.github.com/users/cestella","html_url":"https://github.com/cestella","followers_url":"https://api.github.com/users/cestella/followers","following_url":"https://api.github.com/users/cestella/following{/other_user}","gists_url":"https://api.github.com/users/cestella/gists{/gist_id}","starred_url":"https://api.github.com/users/cestella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cestella/subscriptions","organizations_url":"https://api.github.com/users/cestella/orgs","repos_url":"https://api.github.com/users/cestella/repos","events_url":"https://api.github.com/users/cestella/events{/privacy}","received_events_url":"https://api.github.com/users/cestella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-16T17:30:17Z","updated_at":"2018-06-27T13:42:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/1064","html_url":"https://github.com/apache/metron/pull/1064","diff_url":"https://github.com/apache/metron/pull/1064.diff","patch_url":"https://github.com/apache/metron/pull/1064.patch"},"body":"## Contributor Comments\r\nSimilar to #1063 we should consider empty collections and maps as falsey.  This PR builds on #1063, so it should be merged after.\r\n\r\nYou can test this in the REPL similar to #1063 except substituting `[]` for `is_alert`.\r\n\r\n\r\n## Pull Request Checklist\r\n\r\nThank you for submitting a contribution to Apache Metron.  \r\nPlease refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  \r\nPlease refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  \r\n\r\n\r\nIn order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).\r\n- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n\r\n### For code changes:\r\n- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [x] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:\r\n  ```\r\n  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh \r\n  ```\r\n\r\n- [x] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:\r\n\r\n  ```\r\n  cd site-book\r\n  mvn site\r\n  ```\r\n\r\n#### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\nIt is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/metron/issues/comments/400676058","html_url":"https://github.com/apache/metron/pull/1064#issuecomment-400676058","issue_url":"https://api.github.com/repos/apache/metron/issues/1064","id":400676058,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDY3NjA1OA==","user":{"login":"ottobackwards","id":1111551,"node_id":"MDQ6VXNlcjExMTE1NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1111551?v=4","gravatar_id":"","url":"https://api.github.com/users/ottobackwards","html_url":"https://github.com/ottobackwards","followers_url":"https://api.github.com/users/ottobackwards/followers","following_url":"https://api.github.com/users/ottobackwards/following{/other_user}","gists_url":"https://api.github.com/users/ottobackwards/gists{/gist_id}","starred_url":"https://api.github.com/users/ottobackwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottobackwards/subscriptions","organizations_url":"https://api.github.com/users/ottobackwards/orgs","repos_url":"https://api.github.com/users/ottobackwards/repos","events_url":"https://api.github.com/users/ottobackwards/events{/privacy}","received_events_url":"https://api.github.com/users/ottobackwards/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T13:42:36Z","updated_at":"2018-06-27T13:42:36Z","author_association":"CONTRIBUTOR","body":"+1 by inspection"}}
{"actor":{"display_login":"ottobackwards"}}