{"push_id":2606463462,"size":25,"distinct_size":25,"ref":"refs/heads/master","head":"cdfc27347cc7dc0889f264f96ddbce2d0fe98fb8","before":"485781561beaf5c504c24aa069da62069ea7afe9","commits":[{"sha":"636d97974cd2f31e4bffc356ba7e40ce47195b45","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Remove \"Advertise\" checkbox from the promotions UI\n\nWhile making promotions advertisable is a good feature, the \"Advertise\"\ncheckbox doesn't do anything when using `solidus_frontend` and\n`solidus_backend` out of the box.\n\nThere also isn't a clear path forward for how developers should use this\nfeature. Where should promotions be advertised? How should complex\npromotions be advertised?\n\nDevelopers can implement custom promotion advertisement features by\nusing the `advertise` attribute on `Spree::Promotion`s, but keeping this\nin the UI isn't helpful. Let's consider re-adding this to the UI if we\ncan make the usage cleared and working in the default `solidus_frontend`\nconfiguration.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/636d97974cd2f31e4bffc356ba7e40ce47195b45"},{"sha":"a80321d9c4f97927607cf4b57d4e13d045683c32","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Remove \"Path\" activation option from promotions UI\n\nWhile having a promotion activate when the customer reaches a path is a\ngreat feature idea, this this activation type is not actually wired up\nto anything. If a store admin tried to set up a path-activated\npromotion, it would not work.\n\nThis also does not provide a clear path forward for developers trying to\nset up a feature like this.\n\nThis feature may be a good candidate for an extension with additional\ndocumentation.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/a80321d9c4f97927607cf4b57d4e13d045683c32"},{"sha":"84bd4f5047929c91095fa4e8c2cca1b19a2f3fb6","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Remove unused locales strings; fix capitalization","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/84bd4f5047929c91095fa4e8c2cca1b19a2f3fb6"},{"sha":"3aeda1bf4863642ddb8bcd42c9cd9d105fd7b5e8","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Remove path promotion activation method spec","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/3aeda1bf4863642ddb8bcd42c9cd9d105fd7b5e8"},{"sha":"d2b65163c8634cf45891ed0243edfbe488030252","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Update changelog","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/d2b65163c8634cf45891ed0243edfbe488030252"},{"sha":"e5ad6b24601c3494f2bccb6cee9c4504e6a56aeb","author":{"name":"James Gayfer","email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@stembolt.com"},"message":"Fix security vulnerabilities in docs site\n\nHoek v2.16.3 has a security vulnerability. Browser-sync and node-sass\nwere both dependent on this package. I've updated browser-sync to the\nlatest version. Regarding node-sass, there is not currently a released\nversion that fixes this vulnerability. They plan on deploying a fix in\nversion 5, which is supposedly coming in a few weeks. I've gone ahead\nand upgraded us to the v5 branch of node-sass for the time being; this\nremoves our dependency on Hoek, while still allowing the project to\nbuild.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/e5ad6b24601c3494f2bccb6cee9c4504e6a56aeb"},{"sha":"c7ca201502bed6a154d84a9315a5569b7ae629f7","author":{"name":"Thomas von Deyen","email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@vondeyen.com"},"message":"Merge pull request #2747 from jgayfer/fix/docs_security_vulns\n\nFix security vulnerabilities in docs site","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/c7ca201502bed6a154d84a9315a5569b7ae629f7"},{"sha":"bd61f8b2585fa91528860b0bd709d75ad48a389e","author":{"name":"James Gayfer","email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@stembolt.com"},"message":"Remove docs index generator and index\n\nThe docs index wasn't meant to be a long term solution; it was a means\nto aid in navigating the docs while on GitHub. Since the docs will now\nlive in their own site, there won't be a need to navigate the docs on\nGitHub.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/bd61f8b2585fa91528860b0bd709d75ad48a389e"},{"sha":"fe569ae4e4c732809b8ed745d98a5ecea49e63d3","author":{"name":"James Gayfer","email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@stembolt.com"},"message":"Move guides to docs site source directory","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/fe569ae4e4c732809b8ed745d98a5ecea49e63d3"},{"sha":"c6bfc5c81490b913470937594bef76cc1bf2d9ac","author":{"name":"James Gayfer","email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@stembolt.com"},"message":"Change extension of guides from md to html.md\n\nThis is a requirement of Middleman, the platform the docs site is built\non. Otherwise, we can't generate HTML from the markdown.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/c6bfc5c81490b913470937594bef76cc1bf2d9ac"},{"sha":"6feea2019104ecbcfc2060ef394e51294fcd8485","author":{"name":"James Gayfer","email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@stembolt.com"},"message":"Change relative links in guides from .md to .html\n\nThis change allows for relative links to work in the context of the docs\nsite.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/6feea2019104ecbcfc2060ef394e51294fcd8485"},{"sha":"57dd11f63e3a32b99b8a703300b6e4b4a573bb37","author":{"name":"James Gayfer","email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@stembolt.com"},"message":"Rename docs_site directory to guides\n\nThis change keeps the original top level file/directory names as we\nhad previously.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/57dd11f63e3a32b99b8a703300b6e4b4a573bb37"},{"sha":"185344d0fd63ad1f8aea95a566ca6535d2c7726e","author":{"name":"Thomas von Deyen","email":"5f50a84c1fa3bcff146405017f36aec1a10a9e38@vondeyen.com"},"message":"Merge pull request #2740 from jgayfer/move_docs\n\nMove guides to new docs site","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/185344d0fd63ad1f8aea95a566ca6535d2c7726e"},{"sha":"7d042722d8558c4f9c949aa2859c48441b1b3a16","author":{"name":"Benjamin Willems","email":"8a85c06c4eba8aba733a4be991bd4b4c6b4e4581@benjaminwil.info"},"message":"Add initial overview documentation of solidus_api","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/7d042722d8558c4f9c949aa2859c48441b1b3a16"},{"sha":"ed3d85613ca610f195d18aeffedc27af994af03c","author":{"name":"Benjamin Willems","email":"8a85c06c4eba8aba733a4be991bd4b4c6b4e4581@benjaminwil.info"},"message":"Add stub for API endpoint documentation\n\nIdeally, this document will provide a one-page view of the Solidus API\nendpoints. At the moment, I am not able to generate a helpful, clean\ndocument with the available endpoints.\n\nFor now, this file helps API users find the existing endpoints.","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/ed3d85613ca610f195d18aeffedc27af994af03c"},{"sha":"9d6119709cb2cad6d6dfa5e3ff38ef3f10a72fe4","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Convert API discussion to Middleman format","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/9d6119709cb2cad6d6dfa5e3ff38ef3f10a72fe4"},{"sha":"2e7409c72244c766c2900d4013383b229dffcfb3","author":{"name":"Benjamin Willems","email":"8a85c06c4eba8aba733a4be991bd4b4c6b4e4581@benjaminwil.info"},"message":"Tweak upgrades documentation titles and content","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/2e7409c72244c766c2900d4013383b229dffcfb3"},{"sha":"e30250014943d4d2d99a86b6990a63eaa9605fd1","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Add initial promotions overview for admins","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/e30250014943d4d2d99a86b6990a63eaa9605fd1"},{"sha":"ade4306c987c33bcbb116e418629a2d17bdfa1bf","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Document batch promotion codes","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/ade4306c987c33bcbb116e418629a2d17bdfa1bf"},{"sha":"dc0c31e152f18add280416549de1297f16ea9c23","author":{"name":"Benjamin Willems","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@stembolt.com"},"message":"Add link for promotion rule article","distinct":true,"url":"https://api.github.com/repos/derrickp/solidus/commits/dc0c31e152f18add280416549de1297f16ea9c23"}]}
{"actor":{"display_login":"derrickp"}}