{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20282","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20282/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20282/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20282/events","html_url":"https://github.com/joomla/joomla-cms/pull/20282","id":319548962,"number":20282,"title":"Notification email on admin registration approval","user":{"login":"carlitorweb","id":3956472,"avatar_url":"https://avatars3.githubusercontent.com/u/3956472?v=4","gravatar_id":"","url":"https://api.github.com/users/carlitorweb","html_url":"https://github.com/carlitorweb","followers_url":"https://api.github.com/users/carlitorweb/followers","following_url":"https://api.github.com/users/carlitorweb/following{/other_user}","gists_url":"https://api.github.com/users/carlitorweb/gists{/gist_id}","starred_url":"https://api.github.com/users/carlitorweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlitorweb/subscriptions","organizations_url":"https://api.github.com/users/carlitorweb/orgs","repos_url":"https://api.github.com/users/carlitorweb/repos","events_url":"https://api.github.com/users/carlitorweb/events{/privacy}","received_events_url":"https://api.github.com/users/carlitorweb/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-05-02T13:18:55Z","updated_at":"2018-05-08T15:52:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20282","html_url":"https://github.com/joomla/joomla-cms/pull/20282","diff_url":"https://github.com/joomla/joomla-cms/pull/20282.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20282.patch"},"body":"Pull Request for Issue #13620 \r\n\r\n### Summary of Changes\r\nSending a notification email, after an Admin activate a user/users, on the user's list of com_users \r\n\r\n### Testing Instructions\r\n\r\n- Register as a new user\r\n- Go to the Users list inside the administration, and activate the user/users\r\n- Check the email is sent to the user, notifying him that it has been approved on the site\r\n----------------------------------------------------------------------\r\n- Edit a user that is not activated\r\n- Press the button you will find under the Account Details tab\r\n- Check the user is activated and an email is sent for notifying him that it has been approved on the site\r\n----------------------------------------------------------------------\r\n- Edit a user that is activated, but that has not yet entered in the site for the first time\r\n- Check the same button is there under the Account Details tab, and press it\r\n- Check an email is sent for notifying him that it has been approved on the site\r\n\r\n### Expected result\r\nAn email is sent to the user, notifying him that it has been approved on the site\r\n\r\n### Actual result\r\nThe user is activated but is not notified of this change\r\n\r\n### Request for feedback (SOLVED)\r\nThis change also requires that within the user edit view, a button appears that allows an administrator to activate the user from there. \r\n\r\nFor this, I added a new radio field \"activation\" for handle this under Accounts Details, but this field store a hash when the user It is registered in the site then this new field is not convenient.\r\n![new field - edit view](https://user-images.githubusercontent.com/3956472/39525193-4563a446-4de9-11e8-8939-2d73e64a08c5.png)\r\n\r\nI can create a new field under the params fields, and handle this as a param, but I not think this need be under the Basic Settings tab.\r\n\r\nSo, my doubt is, What is the best way to treat this?\r\n\r\n### Documentation Changes Required\r\n- New com_users.user button added. \r\n- Now when you activate a user on com_users list, send an email"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/387450937","html_url":"https://github.com/joomla/joomla-cms/pull/20282#issuecomment-387450937","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20282","id":387450937,"user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T15:52:45Z","updated_at":"2018-05-08T15:52:45Z","author_association":"MEMBER","body":"Looks like the strings should be correctly grouped for Reminder and Activate in the model."}}
{"actor":{"display_login":"infograf768"}}