{"action":"closed","number":202,"pull_request":{"url":"https://api.github.com/repos/haskell/hackage-security/pulls/202","id":168858153,"html_url":"https://github.com/haskell/hackage-security/pull/202","diff_url":"https://github.com/haskell/hackage-security/pull/202.diff","patch_url":"https://github.com/haskell/hackage-security/pull/202.patch","issue_url":"https://api.github.com/repos/haskell/hackage-security/issues/202","number":202,"state":"closed","locked":false,"title":"Detect asynchronous exceptions via their types #187","user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars3.githubusercontent.com/u/49415?v=4","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"body":"This commit uses the same async-exception detection mechanism as is used\r\nby the safe-exceptions package, via checking if the given exception is\r\ncast to a SomeAsyncException. (On older GHCs without SomeAsyncException,\r\nit contains a hard-coded list of async exception types.) It then ensures\r\nthat:\r\n\r\n* Throwing via throwChecked always generates a synchronous exception\r\n* Catching via catchChecked (et al) never catches an asynchronous\r\n  exception\r\n\r\nUnfortunately, I don't currently have a reliable test case to ensure\r\nthat this fixes the problems described in #187. Hopefully with this\r\npatch available we can begin testing cabal-install and Stack against the\r\nchange and see if it resolves the issues.","created_at":"2018-02-13T14:26:34Z","updated_at":"2018-02-14T11:35:06Z","closed_at":"2018-02-14T11:35:05Z","merged_at":"2018-02-14T11:35:05Z","merge_commit_sha":"5763a92829585965700e2e1a716e57e74c134d6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/hackage-security/pulls/202/commits","review_comments_url":"https://api.github.com/repos/haskell/hackage-security/pulls/202/comments","review_comment_url":"https://api.github.com/repos/haskell/hackage-security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/hackage-security/issues/202/comments","statuses_url":"https://api.github.com/repos/haskell/hackage-security/statuses/d35db7b89bacf4eb9a4341cafda3d9715745ff4e","head":{"label":"snoyberg:187-some-async","ref":"187-some-async","sha":"d35db7b89bacf4eb9a4341cafda3d9715745ff4e","user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars3.githubusercontent.com/u/49415?v=4","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"repo":{"id":42163917,"name":"hackage-security","full_name":"snoyberg/hackage-security","owner":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars3.githubusercontent.com/u/49415?v=4","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snoyberg/hackage-security","description":null,"fork":true,"url":"https://api.github.com/repos/snoyberg/hackage-security","forks_url":"https://api.github.com/repos/snoyberg/hackage-security/forks","keys_url":"https://api.github.com/repos/snoyberg/hackage-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snoyberg/hackage-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snoyberg/hackage-security/teams","hooks_url":"https://api.github.com/repos/snoyberg/hackage-security/hooks","issue_events_url":"https://api.github.com/repos/snoyberg/hackage-security/issues/events{/number}","events_url":"https://api.github.com/repos/snoyberg/hackage-security/events","assignees_url":"https://api.github.com/repos/snoyberg/hackage-security/assignees{/user}","branches_url":"https://api.github.com/repos/snoyberg/hackage-security/branches{/branch}","tags_url":"https://api.github.com/repos/snoyberg/hackage-security/tags","blobs_url":"https://api.github.com/repos/snoyberg/hackage-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snoyberg/hackage-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snoyberg/hackage-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/snoyberg/hackage-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snoyberg/hackage-security/statuses/{sha}","languages_url":"https://api.github.com/repos/snoyberg/hackage-security/languages","stargazers_url":"https://api.github.com/repos/snoyberg/hackage-security/stargazers","contributors_url":"https://api.github.com/repos/snoyberg/hackage-security/contributors","subscribers_url":"https://api.github.com/repos/snoyberg/hackage-security/subscribers","subscription_url":"https://api.github.com/repos/snoyberg/hackage-security/subscription","commits_url":"https://api.github.com/repos/snoyberg/hackage-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/snoyberg/hackage-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/snoyberg/hackage-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/snoyberg/hackage-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/snoyberg/hackage-security/contents/{+path}","compare_url":"https://api.github.com/repos/snoyberg/hackage-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snoyberg/hackage-security/merges","archive_url":"https://api.github.com/repos/snoyberg/hackage-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snoyberg/hackage-security/downloads","issues_url":"https://api.github.com/repos/snoyberg/hackage-security/issues{/number}","pulls_url":"https://api.github.com/repos/snoyberg/hackage-security/pulls{/number}","milestones_url":"https://api.github.com/repos/snoyberg/hackage-security/milestones{/number}","notifications_url":"https://api.github.com/repos/snoyberg/hackage-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snoyberg/hackage-security/labels{/name}","releases_url":"https://api.github.com/repos/snoyberg/hackage-security/releases{/id}","deployments_url":"https://api.github.com/repos/snoyberg/hackage-security/deployments","created_at":"2015-09-09T07:45:17Z","updated_at":"2017-01-20T10:04:14Z","pushed_at":"2018-02-14T11:14:04Z","git_url":"git://github.com/snoyberg/hackage-security.git","ssh_url":"git@github.com:snoyberg/hackage-security.git","clone_url":"https://github.com/snoyberg/hackage-security.git","svn_url":"https://github.com/snoyberg/hackage-security","homepage":null,"size":954,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"71a24d63f776c62a532c6d68e56aca42ece7640e","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars1.githubusercontent.com/u/450574?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":34862856,"name":"hackage-security","full_name":"haskell/hackage-security","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars1.githubusercontent.com/u/450574?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/hackage-security","description":"Hackage security framework based on TUF (The Update Framework)","fork":false,"url":"https://api.github.com/repos/haskell/hackage-security","forks_url":"https://api.github.com/repos/haskell/hackage-security/forks","keys_url":"https://api.github.com/repos/haskell/hackage-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/hackage-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/hackage-security/teams","hooks_url":"https://api.github.com/repos/haskell/hackage-security/hooks","issue_events_url":"https://api.github.com/repos/haskell/hackage-security/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/hackage-security/events","assignees_url":"https://api.github.com/repos/haskell/hackage-security/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/hackage-security/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/hackage-security/tags","blobs_url":"https://api.github.com/repos/haskell/hackage-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/hackage-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/hackage-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/hackage-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/hackage-security/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/hackage-security/languages","stargazers_url":"https://api.github.com/repos/haskell/hackage-security/stargazers","contributors_url":"https://api.github.com/repos/haskell/hackage-security/contributors","subscribers_url":"https://api.github.com/repos/haskell/hackage-security/subscribers","subscription_url":"https://api.github.com/repos/haskell/hackage-security/subscription","commits_url":"https://api.github.com/repos/haskell/hackage-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/hackage-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/hackage-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/hackage-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/hackage-security/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/hackage-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/hackage-security/merges","archive_url":"https://api.github.com/repos/haskell/hackage-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/hackage-security/downloads","issues_url":"https://api.github.com/repos/haskell/hackage-security/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/hackage-security/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/hackage-security/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/hackage-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/hackage-security/labels{/name}","releases_url":"https://api.github.com/repos/haskell/hackage-security/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/hackage-security/deployments","created_at":"2015-04-30T15:46:57Z","updated_at":"2018-01-24T07:41:51Z","pushed_at":"2018-02-14T11:35:05Z","git_url":"git://github.com/haskell/hackage-security.git","ssh_url":"git@github.com:haskell/hackage-security.git","clone_url":"https://github.com/haskell/hackage-security.git","svn_url":"https://github.com/haskell/hackage-security","homepage":"http://hackage.haskell.org/package/hackage-security","size":938,"stargazers_count":29,"watchers_count":29,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":54,"license":null,"forks":16,"open_issues":54,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/hackage-security/pulls/202"},"html":{"href":"https://github.com/haskell/hackage-security/pull/202"},"issue":{"href":"https://api.github.com/repos/haskell/hackage-security/issues/202"},"comments":{"href":"https://api.github.com/repos/haskell/hackage-security/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/hackage-security/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/hackage-security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/hackage-security/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/hackage-security/statuses/d35db7b89bacf4eb9a4341cafda3d9715745ff4e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hvr","id":285533,"avatar_url":"https://avatars3.githubusercontent.com/u/285533?v=4","gravatar_id":"","url":"https://api.github.com/users/hvr","html_url":"https://github.com/hvr","followers_url":"https://api.github.com/users/hvr/followers","following_url":"https://api.github.com/users/hvr/following{/other_user}","gists_url":"https://api.github.com/users/hvr/gists{/gist_id}","starred_url":"https://api.github.com/users/hvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvr/subscriptions","organizations_url":"https://api.github.com/users/hvr/orgs","repos_url":"https://api.github.com/users/hvr/repos","events_url":"https://api.github.com/users/hvr/events{/privacy}","received_events_url":"https://api.github.com/users/hvr/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":39,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"hvr"}}