{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/30960","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/30960/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30960/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/30960/events","html_url":"https://github.com/dotnet/corefx/issues/30960","id":339998352,"node_id":"MDU6SXNzdWUzMzk5OTgzNTI=","number":30960,"title":"Freeze netstandard refs that have a package and are inbox","user":{"login":"ViktorHofer","id":7412651,"node_id":"MDQ6VXNlcjc0MTI2NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7412651?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"labels":[{"id":174888041,"node_id":"MDU6TGFiZWwxNzQ4ODgwNDE=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-Infrastructure","name":"area-Infrastructure","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/21","html_url":"https://github.com/dotnet/corefx/milestone/21","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/21/labels","id":3242632,"node_id":"MDk6TWlsZXN0b25lMzI0MjYzMg==","number":21,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":168,"closed_issues":1152,"state":"open","created_at":"2018-04-04T16:40:10Z","updated_at":"2018-07-11T13:18:24Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-10T20:39:15Z","updated_at":"2018-07-11T15:49:38Z","closed_at":null,"author_association":"MEMBER","body":"We don't want to accidently ship new APIs in a netstandard ref in a package that is already inbox on any. We should harvest those configurations and if they are referenced by other contracts we should also binplace them into the ref folder by adding a PackageReference here: https://github.com/dotnet/corefx/blob/master/external/netstandard/netstandard.depproj#L15.\r\n\r\nWhen doing this we should also consider harvesting the impl but this needs to be considered project-wise. Freeze could be interpreted as remove if there are no live builds going into the package.\r\n\r\ncc @weshaggard @ericstj "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/404219095","html_url":"https://github.com/dotnet/corefx/issues/30960#issuecomment-404219095","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30960","id":404219095,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDIxOTA5NQ==","user":{"login":"ericstj","id":8918108,"node_id":"MDQ6VXNlcjg5MTgxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8918108?v=4","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T15:49:38Z","updated_at":"2018-07-11T15:49:38Z","author_association":"MEMBER","body":"Was chatting with @ViktorHofer  about this.  We should try to formalize and centralize how we do package harvesting.\r\n\r\nToday https://github.com/dotnet/corefx/blob/master/external/harvestPackages/harvestPackages.depproj downloads any packages that *may* be harvested.\r\n\r\nThen the individual pkgprojs decide what *will* be harvested.\r\n\r\nThen when someone decides they need the harvested asset when building (or testing) some other live build of a library we'll (usually myself) sprinkle PackageReferences in the various external depprojs most closely responsible for harvesting similar assets.  \r\n\r\nNothing really keeps us honest when we do the latter and it could result in cases where  parts of the build see harvested assets and later parts see a live build.\r\n\r\nIt feels like we can probably avoid some of this duplication and validate that we don't clash on binplacing."}}
{"actor":{"display_login":"ericstj"}}