{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments/238917878","pull_request_review_id":181528753,"id":238917878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODkxNzg3OA==","diff_hunk":"@@ -294,7 +294,7 @@ MEM_INLINE int str_printf(str_t* str, const char* format, ...)\n     }\n \n     /* Set the size */\n-    str->__mem.__size = r + 1;\n+    str->__mem.__size = (size_t)r + 1;","path":"include/openenclave/internal/str.h","position":14,"original_position":14,"commit_id":"0357f857b10437a67e50426cc9124f08963d1f04","original_commit_id":"0357f857b10437a67e50426cc9124f08963d1f04","user":{"login":"CodeMonkeyLeet","id":31784195,"node_id":"MDQ6VXNlcjMxNzg0MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/31784195?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeMonkeyLeet","html_url":"https://github.com/CodeMonkeyLeet","followers_url":"https://api.github.com/users/CodeMonkeyLeet/followers","following_url":"https://api.github.com/users/CodeMonkeyLeet/following{/other_user}","gists_url":"https://api.github.com/users/CodeMonkeyLeet/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeMonkeyLeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeMonkeyLeet/subscriptions","organizations_url":"https://api.github.com/users/CodeMonkeyLeet/orgs","repos_url":"https://api.github.com/users/CodeMonkeyLeet/repos","events_url":"https://api.github.com/users/CodeMonkeyLeet/events{/privacy}","received_events_url":"https://api.github.com/users/CodeMonkeyLeet/received_events","type":"User","site_admin":false},"body":"This is okay in our code but relies on the implicit assumption that we only build on x64 so `size_t` and the size of pointers are the same. Can you please add a static assert for `OE_STATIC_ASSERT(sizeof(size_t) == sizeof(char*));` at the beginning of the file?","created_at":"2018-12-05T03:03:26Z","updated_at":"2018-12-05T03:14:34Z","html_url":"https://github.com/Microsoft/openenclave/pull/1135#discussion_r238917878","pull_request_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments/238917878"},"html":{"href":"https://github.com/Microsoft/openenclave/pull/1135#discussion_r238917878"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135","id":234548447,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTQ4NDQ3","html_url":"https://github.com/Microsoft/openenclave/pull/1135","diff_url":"https://github.com/Microsoft/openenclave/pull/1135.diff","patch_url":"https://github.com/Microsoft/openenclave/pull/1135.patch","issue_url":"https://api.github.com/repos/Microsoft/openenclave/issues/1135","number":1135,"state":"open","locked":false,"title":"Added -Wconversion -Wpointer-arith for tools build #175","user":{"login":"berinpaul","id":43024100,"node_id":"MDQ6VXNlcjQzMDI0MTAw","avatar_url":"https://avatars2.githubusercontent.com/u/43024100?v=4","gravatar_id":"","url":"https://api.github.com/users/berinpaul","html_url":"https://github.com/berinpaul","followers_url":"https://api.github.com/users/berinpaul/followers","following_url":"https://api.github.com/users/berinpaul/following{/other_user}","gists_url":"https://api.github.com/users/berinpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/berinpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berinpaul/subscriptions","organizations_url":"https://api.github.com/users/berinpaul/orgs","repos_url":"https://api.github.com/users/berinpaul/repos","events_url":"https://api.github.com/users/berinpaul/events{/privacy}","received_events_url":"https://api.github.com/users/berinpaul/received_events","type":"User","site_admin":false},"body":"- Enabled warnings for building tools. #973","created_at":"2018-11-29T08:32:07Z","updated_at":"2018-12-05T03:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce1227ec2403a521e948df8b33e1f236fb1d4457","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johnkord","id":16021727,"node_id":"MDQ6VXNlcjE2MDIxNzI3","avatar_url":"https://avatars1.githubusercontent.com/u/16021727?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkord","html_url":"https://github.com/johnkord","followers_url":"https://api.github.com/users/johnkord/followers","following_url":"https://api.github.com/users/johnkord/following{/other_user}","gists_url":"https://api.github.com/users/johnkord/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkord/subscriptions","organizations_url":"https://api.github.com/users/johnkord/orgs","repos_url":"https://api.github.com/users/johnkord/repos","events_url":"https://api.github.com/users/johnkord/events{/privacy}","received_events_url":"https://api.github.com/users/johnkord/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":975049837,"node_id":"MDU6TGFiZWw5NzUwNDk4Mzc=","url":"https://api.github.com/repos/Microsoft/openenclave/labels/engineering","name":"engineering","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135/commits","review_comments_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135/comments","review_comment_url":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/openenclave/issues/1135/comments","statuses_url":"https://api.github.com/repos/Microsoft/openenclave/statuses/0357f857b10437a67e50426cc9124f08963d1f04","head":{"label":"Microsoft:bug/additional_warnings_tools","ref":"bug/additional_warnings_tools","sha":"0357f857b10437a67e50426cc9124f08963d1f04","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":101804230,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDQyMzA=","name":"openenclave","full_name":"Microsoft/openenclave","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/openenclave","description":"SDK for developing enclaves","fork":false,"url":"https://api.github.com/repos/Microsoft/openenclave","forks_url":"https://api.github.com/repos/Microsoft/openenclave/forks","keys_url":"https://api.github.com/repos/Microsoft/openenclave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/openenclave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/openenclave/teams","hooks_url":"https://api.github.com/repos/Microsoft/openenclave/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/openenclave/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/openenclave/events","assignees_url":"https://api.github.com/repos/Microsoft/openenclave/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/openenclave/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/openenclave/tags","blobs_url":"https://api.github.com/repos/Microsoft/openenclave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/openenclave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/openenclave/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/openenclave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/openenclave/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/openenclave/languages","stargazers_url":"https://api.github.com/repos/Microsoft/openenclave/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/openenclave/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/openenclave/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/openenclave/subscription","commits_url":"https://api.github.com/repos/Microsoft/openenclave/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/openenclave/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/openenclave/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/openenclave/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/openenclave/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/openenclave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/openenclave/merges","archive_url":"https://api.github.com/repos/Microsoft/openenclave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/openenclave/downloads","issues_url":"https://api.github.com/repos/Microsoft/openenclave/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/openenclave/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/openenclave/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/openenclave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/openenclave/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/openenclave/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/openenclave/deployments","created_at":"2017-08-29T20:31:38Z","updated_at":"2018-12-04T23:57:08Z","pushed_at":"2018-12-05T01:10:54Z","git_url":"git://github.com/Microsoft/openenclave.git","ssh_url":"git@github.com:Microsoft/openenclave.git","clone_url":"https://github.com/Microsoft/openenclave.git","svn_url":"https://github.com/Microsoft/openenclave","homepage":null,"size":46132,"stargazers_count":77,"watchers_count":77,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":186,"watchers":77,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4d045524ab4a76405bcf430d70b015db2712ce48","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":101804230,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDQyMzA=","name":"openenclave","full_name":"Microsoft/openenclave","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/openenclave","description":"SDK for developing enclaves","fork":false,"url":"https://api.github.com/repos/Microsoft/openenclave","forks_url":"https://api.github.com/repos/Microsoft/openenclave/forks","keys_url":"https://api.github.com/repos/Microsoft/openenclave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/openenclave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/openenclave/teams","hooks_url":"https://api.github.com/repos/Microsoft/openenclave/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/openenclave/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/openenclave/events","assignees_url":"https://api.github.com/repos/Microsoft/openenclave/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/openenclave/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/openenclave/tags","blobs_url":"https://api.github.com/repos/Microsoft/openenclave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/openenclave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/openenclave/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/openenclave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/openenclave/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/openenclave/languages","stargazers_url":"https://api.github.com/repos/Microsoft/openenclave/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/openenclave/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/openenclave/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/openenclave/subscription","commits_url":"https://api.github.com/repos/Microsoft/openenclave/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/openenclave/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/openenclave/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/openenclave/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/openenclave/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/openenclave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/openenclave/merges","archive_url":"https://api.github.com/repos/Microsoft/openenclave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/openenclave/downloads","issues_url":"https://api.github.com/repos/Microsoft/openenclave/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/openenclave/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/openenclave/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/openenclave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/openenclave/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/openenclave/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/openenclave/deployments","created_at":"2017-08-29T20:31:38Z","updated_at":"2018-12-04T23:57:08Z","pushed_at":"2018-12-05T01:10:54Z","git_url":"git://github.com/Microsoft/openenclave.git","ssh_url":"git@github.com:Microsoft/openenclave.git","clone_url":"https://github.com/Microsoft/openenclave.git","svn_url":"https://github.com/Microsoft/openenclave","homepage":null,"size":46132,"stargazers_count":77,"watchers_count":77,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":186,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135"},"html":{"href":"https://github.com/Microsoft/openenclave/pull/1135"},"issue":{"href":"https://api.github.com/repos/Microsoft/openenclave/issues/1135"},"comments":{"href":"https://api.github.com/repos/Microsoft/openenclave/issues/1135/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/openenclave/pulls/1135/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/openenclave/statuses/0357f857b10437a67e50426cc9124f08963d1f04"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"CodeMonkeyLeet"}}