{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4665","repository_url":"https://api.github.com/repos/ipfs/go-ipfs","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4665/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4665/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4665/events","html_url":"https://github.com/ipfs/go-ipfs/pull/4665","id":294816393,"number":4665,"title":"Golint: fix golint warnings in merkledag submodule","user":{"login":"hsanjuan","id":1027022,"avatar_url":"https://avatars3.githubusercontent.com/u/1027022?v=4","gravatar_id":"","url":"https://api.github.com/users/hsanjuan","html_url":"https://github.com/hsanjuan","followers_url":"https://api.github.com/users/hsanjuan/followers","following_url":"https://api.github.com/users/hsanjuan/following{/other_user}","gists_url":"https://api.github.com/users/hsanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanjuan/subscriptions","organizations_url":"https://api.github.com/users/hsanjuan/orgs","repos_url":"https://api.github.com/users/hsanjuan/repos","events_url":"https://api.github.com/users/hsanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsanjuan/received_events","type":"User","site_admin":false},"labels":[{"id":129070658,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"hsanjuan","id":1027022,"avatar_url":"https://avatars3.githubusercontent.com/u/1027022?v=4","gravatar_id":"","url":"https://api.github.com/users/hsanjuan","html_url":"https://github.com/hsanjuan","followers_url":"https://api.github.com/users/hsanjuan/followers","following_url":"https://api.github.com/users/hsanjuan/following{/other_user}","gists_url":"https://api.github.com/users/hsanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanjuan/subscriptions","organizations_url":"https://api.github.com/users/hsanjuan/orgs","repos_url":"https://api.github.com/users/hsanjuan/repos","events_url":"https://api.github.com/users/hsanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsanjuan/received_events","type":"User","site_admin":false},"assignees":[{"login":"hsanjuan","id":1027022,"avatar_url":"https://avatars3.githubusercontent.com/u/1027022?v=4","gravatar_id":"","url":"https://api.github.com/users/hsanjuan","html_url":"https://github.com/hsanjuan","followers_url":"https://api.github.com/users/hsanjuan/followers","following_url":"https://api.github.com/users/hsanjuan/following{/other_user}","gists_url":"https://api.github.com/users/hsanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanjuan/subscriptions","organizations_url":"https://api.github.com/users/hsanjuan/orgs","repos_url":"https://api.github.com/users/hsanjuan/repos","events_url":"https://api.github.com/users/hsanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsanjuan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-02-06T16:08:25Z","updated_at":"2018-02-06T19:32:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4665","html_url":"https://github.com/ipfs/go-ipfs/pull/4665","diff_url":"https://github.com/ipfs/go-ipfs/pull/4665.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/4665.patch"},"body":"This fixes all golint warnings in merkledag (except in protobuf generated code).\r\n\r\nMain change of note is that `NewDAGService` returns an `ipld.DAGService` and not a non-exported `dagService`."},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/363538304","html_url":"https://github.com/ipfs/go-ipfs/pull/4665#issuecomment-363538304","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4665","id":363538304,"user":{"login":"Stebalien","id":310393,"avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T19:32:12Z","updated_at":"2018-02-06T19:32:12Z","author_association":"CONTRIBUTOR","body":"> Everything except the DAGService return type LGTM... If golint really complains about that it makes me a tad bit sad.\r\n\r\nIt does this for a (possibly debatable) reason. The lint disallows returning unexported types because they can't be named outside the package."}}
{"actor":{"display_login":"Stebalien"}}