{"action":"created","comment":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/187314143","pull_request_review_id":119067456,"id":187314143,"diff_hunk":"@@ -180,5 +180,18 @@ private final void removeFromHUsScheduledToMoveList(final IQueryBuilder<I_DD_Ord\n \t\t\t\t.create()\n \t\t\t\t.deleteDirectly();\n \t}\n+\t\n+\t@Override\n+\tpublic boolean existsDDOrderLineCandidateForHUId(final int huId)\n+\t{\n+\t\tfinal IQueryBL queryBL = Services.get(IQueryBL.class);\n+\t\t\n+\t\tfinal int existingDDOrderCandidateId = queryBL.createQueryBuilder(I_DD_OrderLine_HU_Candidate.class)\n+\t\t\t\t.addEqualsFilter(I_DD_OrderLine_HU_Candidate.COLUMN_M_HU_ID, huId)\n+\t\t\t\t.create()\n+\t\t\t\t.firstIdOnly();","path":"de.metas.handlingunits.base/src/main/java/de/metas/handlingunits/ddorder/api/impl/HUDDOrderDAO.java","position":13,"original_position":13,"commit_id":"22f67611925e0061b72ce148a23d264cc89cfe82","original_commit_id":"22f67611925e0061b72ce148a23d264cc89cfe82","user":{"login":"metas-ts","id":1264789,"avatar_url":"https://avatars0.githubusercontent.com/u/1264789?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-ts","html_url":"https://github.com/metas-ts","followers_url":"https://api.github.com/users/metas-ts/followers","following_url":"https://api.github.com/users/metas-ts/following{/other_user}","gists_url":"https://api.github.com/users/metas-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-ts/subscriptions","organizations_url":"https://api.github.com/users/metas-ts/orgs","repos_url":"https://api.github.com/users/metas-ts/repos","events_url":"https://api.github.com/users/metas-ts/events{/privacy}","received_events_url":"https://api.github.com/users/metas-ts/received_events","type":"User","site_admin":false},"body":"please use `match()` instead","created_at":"2018-05-10T12:21:00Z","updated_at":"2018-05-10T12:25:35Z","html_url":"https://github.com/metasfresh/metasfresh/pull/4039#discussion_r187314143","pull_request_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/187314143"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4039#discussion_r187314143"},"pull_request":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039"}}},"pull_request":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039","id":186949723,"html_url":"https://github.com/metasfresh/metasfresh/pull/4039","diff_url":"https://github.com/metasfresh/metasfresh/pull/4039.diff","patch_url":"https://github.com/metasfresh/metasfresh/pull/4039.patch","issue_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4039","number":4039,"state":"open","locked":false,"title":"Gh4013 refactoring around lot no lock","user":{"login":"metas-rc","id":16001442,"avatar_url":"https://avatars3.githubusercontent.com/u/16001442?v=4","gravatar_id":"","url":"https://api.github.com/users/metas-rc","html_url":"https://github.com/metas-rc","followers_url":"https://api.github.com/users/metas-rc/followers","following_url":"https://api.github.com/users/metas-rc/following{/other_user}","gists_url":"https://api.github.com/users/metas-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/metas-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metas-rc/subscriptions","organizations_url":"https://api.github.com/users/metas-rc/orgs","repos_url":"https://api.github.com/users/metas-rc/repos","events_url":"https://api.github.com/users/metas-rc/events{/privacy}","received_events_url":"https://api.github.com/users/metas-rc/received_events","type":"User","site_admin":false},"body":"https://github.com/metasfresh/metasfresh/issues/4013","created_at":"2018-05-09T15:01:08Z","updated_at":"2018-05-10T12:25:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ca0bffd3ee11132826825e5dc7ff36c3f4fb9c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039/commits","review_comments_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039/comments","review_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4039/comments","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/22f67611925e0061b72ce148a23d264cc89cfe82","head":{"label":"metasfresh:gh4013","ref":"gh4013","sha":"22f67611925e0061b72ce148a23d264cc89cfe82","user":{"login":"metasfresh","id":13364239,"avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"name":"metasfresh","full_name":"metasfresh/metasfresh","owner":{"login":"metasfresh","id":13364239,"avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2018-05-10T11:51:11Z","pushed_at":"2018-05-10T12:10:23Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":74064,"stargazers_count":179,"watchers_count":179,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":774,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":81,"open_issues":774,"watchers":179,"default_branch":"master"}},"base":{"label":"metasfresh:master","ref":"master","sha":"4e2bd7446ec1ec00ac0c29e9195d91ed23a1e65b","user":{"login":"metasfresh","id":13364239,"avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"name":"metasfresh","full_name":"metasfresh/metasfresh","owner":{"login":"metasfresh","id":13364239,"avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2018-05-10T11:51:11Z","pushed_at":"2018-05-10T12:10:23Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":74064,"stargazers_count":179,"watchers_count":179,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":774,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":81,"open_issues":774,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4039"},"issue":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4039"},"comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4039/comments"},"review_comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039/comments"},"review_comment":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4039/commits"},"statuses":{"href":"https://api.github.com/repos/metasfresh/metasfresh/statuses/22f67611925e0061b72ce148a23d264cc89cfe82"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"metas-ts"}}