{"action":"created","comment":{"url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments/167228075","pull_request_review_id":95419273,"id":167228075,"diff_hunk":"@@ -57,28 +57,39 @@ pipeline {\n       }\n     }\n     stage('publish') {\n-      // Check if the build is trigged by a new git commit;\n-      // if this is a new commit, publish to NPM.\n-      when {\n-        allOf {\n-          branch 'master'\n-          expression {\n-            env.GIT_PREVIOUS_COMMIT != env.GIT_COMMIT\n-          }\n-        }\n-      }\n       steps {\n-        // let the build fail if the version does not match normal semver\n         script {\n-          def normalVersion = PACKAGE_VERSION =~ /\\d+\\.\\d+\\.\\d+/\n-          if (!normalVersion.matches()) {\n-            error('Only non RC Versions are allowed in master')\n+          def branch = env.BRANCH_NAME;\n+\n+          if (branch == 'master' && env.GIT_PREVIOUS_COMMIT != env.GIT_COMMIT) {\n+            script {\n+              // let the build fail if the version does not match normal semver\n+              def isNormalVersion = PACKAGE_VERSION =~ /\\d+\\.\\d+\\.\\d+/\n+              if (!isNormalVersion.matches()) {","path":"_templates/Jenkinsfile","position":26,"original_position":26,"commit_id":"1c5d623d797135c5707cc4eddb4d107f248e9435","original_commit_id":"1c5d623d797135c5707cc4eddb4d107f248e9435","user":{"login":"cmg-dev","id":4034128,"avatar_url":"https://avatars0.githubusercontent.com/u/4034128?v=4","gravatar_id":"","url":"https://api.github.com/users/cmg-dev","html_url":"https://github.com/cmg-dev","followers_url":"https://api.github.com/users/cmg-dev/followers","following_url":"https://api.github.com/users/cmg-dev/following{/other_user}","gists_url":"https://api.github.com/users/cmg-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cmg-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmg-dev/subscriptions","organizations_url":"https://api.github.com/users/cmg-dev/orgs","repos_url":"https://api.github.com/users/cmg-dev/repos","events_url":"https://api.github.com/users/cmg-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cmg-dev/received_events","type":"User","site_admin":false},"body":"```groovy\r\n`version_is_not_semver != PACKAGE_VERSION =~ /\\d+\\.\\d+\\.\\d+/`\r\nif (version_is_not_semver.matches()) {\r\n```\r\n\r\noder so. Aber ich hoffe die Idee kommt rüber.\r\n\r\nIch mag es immer im `if` nur einen true check zu sehen.","created_at":"2018-02-09T13:35:04Z","updated_at":"2018-02-09T13:36:41Z","html_url":"https://github.com/process-engine/process_engine_meta/pull/29#discussion_r167228075","pull_request_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments/167228075"},"html":{"href":"https://github.com/process-engine/process_engine_meta/pull/29#discussion_r167228075"},"pull_request":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29","id":168235764,"html_url":"https://github.com/process-engine/process_engine_meta/pull/29","diff_url":"https://github.com/process-engine/process_engine_meta/pull/29.diff","patch_url":"https://github.com/process-engine/process_engine_meta/pull/29.patch","issue_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/29","number":29,"state":"open","locked":false,"title":"👷 :construction_worker: Publish all Builds to npm Registry","user":{"login":"Paulomart","id":4148404,"avatar_url":"https://avatars1.githubusercontent.com/u/4148404?v=4","gravatar_id":"","url":"https://api.github.com/users/Paulomart","html_url":"https://github.com/Paulomart","followers_url":"https://api.github.com/users/Paulomart/followers","following_url":"https://api.github.com/users/Paulomart/following{/other_user}","gists_url":"https://api.github.com/users/Paulomart/gists{/gist_id}","starred_url":"https://api.github.com/users/Paulomart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paulomart/subscriptions","organizations_url":"https://api.github.com/users/Paulomart/orgs","repos_url":"https://api.github.com/users/Paulomart/repos","events_url":"https://api.github.com/users/Paulomart/events{/privacy}","received_events_url":"https://api.github.com/users/Paulomart/received_events","type":"User","site_admin":false},"body":"## What did you change?\r\nAll Builds are now Published to npm\r\n\r\n## How can others test the changes?\r\n\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [x] You can merge this PR **right now** (if not, please prefix the title with \"WIP: \")\r\n- [x] I've tested **all** changes included in this PR.\r\n- [x] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.)\r\n- [x] I've merged the `develop` branch into my branch before finishing this PR.\r\n- [x] I've **not added any other changes** than the ones described above.\r\n- [x] I've mentioned all **PRs, which relate to this one**\r\n","created_at":"2018-02-09T13:10:53Z","updated_at":"2018-02-09T13:36:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77e9f3570cf7c53f432cd91a6288350464a4d173","assignee":{"login":"Paulomart","id":4148404,"avatar_url":"https://avatars1.githubusercontent.com/u/4148404?v=4","gravatar_id":"","url":"https://api.github.com/users/Paulomart","html_url":"https://github.com/Paulomart","followers_url":"https://api.github.com/users/Paulomart/followers","following_url":"https://api.github.com/users/Paulomart/following{/other_user}","gists_url":"https://api.github.com/users/Paulomart/gists{/gist_id}","starred_url":"https://api.github.com/users/Paulomart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paulomart/subscriptions","organizations_url":"https://api.github.com/users/Paulomart/orgs","repos_url":"https://api.github.com/users/Paulomart/repos","events_url":"https://api.github.com/users/Paulomart/events{/privacy}","received_events_url":"https://api.github.com/users/Paulomart/received_events","type":"User","site_admin":false},"assignees":[{"login":"Paulomart","id":4148404,"avatar_url":"https://avatars1.githubusercontent.com/u/4148404?v=4","gravatar_id":"","url":"https://api.github.com/users/Paulomart","html_url":"https://github.com/Paulomart","followers_url":"https://api.github.com/users/Paulomart/followers","following_url":"https://api.github.com/users/Paulomart/following{/other_user}","gists_url":"https://api.github.com/users/Paulomart/gists{/gist_id}","starred_url":"https://api.github.com/users/Paulomart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paulomart/subscriptions","organizations_url":"https://api.github.com/users/Paulomart/orgs","repos_url":"https://api.github.com/users/Paulomart/repos","events_url":"https://api.github.com/users/Paulomart/events{/privacy}","received_events_url":"https://api.github.com/users/Paulomart/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zimoony","id":5462143,"avatar_url":"https://avatars2.githubusercontent.com/u/5462143?v=4","gravatar_id":"","url":"https://api.github.com/users/zimoony","html_url":"https://github.com/zimoony","followers_url":"https://api.github.com/users/zimoony/followers","following_url":"https://api.github.com/users/zimoony/following{/other_user}","gists_url":"https://api.github.com/users/zimoony/gists{/gist_id}","starred_url":"https://api.github.com/users/zimoony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimoony/subscriptions","organizations_url":"https://api.github.com/users/zimoony/orgs","repos_url":"https://api.github.com/users/zimoony/repos","events_url":"https://api.github.com/users/zimoony/events{/privacy}","received_events_url":"https://api.github.com/users/zimoony/received_events","type":"User","site_admin":false},{"login":"5ebastianMeier","id":16539774,"avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false},{"login":"Vyperus","id":17248802,"avatar_url":"https://avatars3.githubusercontent.com/u/17248802?v=4","gravatar_id":"","url":"https://api.github.com/users/Vyperus","html_url":"https://github.com/Vyperus","followers_url":"https://api.github.com/users/Vyperus/followers","following_url":"https://api.github.com/users/Vyperus/following{/other_user}","gists_url":"https://api.github.com/users/Vyperus/gists{/gist_id}","starred_url":"https://api.github.com/users/Vyperus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vyperus/subscriptions","organizations_url":"https://api.github.com/users/Vyperus/orgs","repos_url":"https://api.github.com/users/Vyperus/repos","events_url":"https://api.github.com/users/Vyperus/events{/privacy}","received_events_url":"https://api.github.com/users/Vyperus/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29/commits","review_comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29/comments","review_comment_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/29/comments","statuses_url":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/1c5d623d797135c5707cc4eddb4d107f248e9435","head":{"label":"process-engine:feature/publish-on-all-branches","ref":"feature/publish-on-all-branches","sha":"1c5d623d797135c5707cc4eddb4d107f248e9435","user":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316336,"name":"process_engine_meta","full_name":"process-engine/process_engine_meta","owner":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/process_engine_meta","description":null,"fork":false,"url":"https://api.github.com/repos/process-engine/process_engine_meta","forks_url":"https://api.github.com/repos/process-engine/process_engine_meta/forks","keys_url":"https://api.github.com/repos/process-engine/process_engine_meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/process_engine_meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/process_engine_meta/teams","hooks_url":"https://api.github.com/repos/process-engine/process_engine_meta/hooks","issue_events_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/process_engine_meta/events","assignees_url":"https://api.github.com/repos/process-engine/process_engine_meta/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/process_engine_meta/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/tags","blobs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/process_engine_meta/languages","stargazers_url":"https://api.github.com/repos/process-engine/process_engine_meta/stargazers","contributors_url":"https://api.github.com/repos/process-engine/process_engine_meta/contributors","subscribers_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscribers","subscription_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscription","commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/process_engine_meta/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/process_engine_meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/process_engine_meta/merges","archive_url":"https://api.github.com/repos/process-engine/process_engine_meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/process_engine_meta/downloads","issues_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/process_engine_meta/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/process_engine_meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/process_engine_meta/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/process_engine_meta/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/process_engine_meta/deployments","created_at":"2017-10-09T17:51:16Z","updated_at":"2018-01-25T12:34:56Z","pushed_at":"2018-02-09T13:12:15Z","git_url":"git://github.com/process-engine/process_engine_meta.git","ssh_url":"git@github.com:process-engine/process_engine_meta.git","clone_url":"https://github.com/process-engine/process_engine_meta.git","svn_url":"https://github.com/process-engine/process_engine_meta","homepage":null,"size":258,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":1,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"16337f35365d80f07f75cf7768001e7097897140","user":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316336,"name":"process_engine_meta","full_name":"process-engine/process_engine_meta","owner":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/process_engine_meta","description":null,"fork":false,"url":"https://api.github.com/repos/process-engine/process_engine_meta","forks_url":"https://api.github.com/repos/process-engine/process_engine_meta/forks","keys_url":"https://api.github.com/repos/process-engine/process_engine_meta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/process_engine_meta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/process_engine_meta/teams","hooks_url":"https://api.github.com/repos/process-engine/process_engine_meta/hooks","issue_events_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/process_engine_meta/events","assignees_url":"https://api.github.com/repos/process-engine/process_engine_meta/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/process_engine_meta/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/tags","blobs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/process_engine_meta/languages","stargazers_url":"https://api.github.com/repos/process-engine/process_engine_meta/stargazers","contributors_url":"https://api.github.com/repos/process-engine/process_engine_meta/contributors","subscribers_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscribers","subscription_url":"https://api.github.com/repos/process-engine/process_engine_meta/subscription","commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/process_engine_meta/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/process_engine_meta/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/process_engine_meta/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/process_engine_meta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/process_engine_meta/merges","archive_url":"https://api.github.com/repos/process-engine/process_engine_meta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/process_engine_meta/downloads","issues_url":"https://api.github.com/repos/process-engine/process_engine_meta/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/process_engine_meta/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/process_engine_meta/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/process_engine_meta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/process_engine_meta/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/process_engine_meta/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/process_engine_meta/deployments","created_at":"2017-10-09T17:51:16Z","updated_at":"2018-01-25T12:34:56Z","pushed_at":"2018-02-09T13:12:15Z","git_url":"git://github.com/process-engine/process_engine_meta.git","ssh_url":"git@github.com:process-engine/process_engine_meta.git","clone_url":"https://github.com/process-engine/process_engine_meta.git","svn_url":"https://github.com/process-engine/process_engine_meta","homepage":null,"size":258,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29"},"html":{"href":"https://github.com/process-engine/process_engine_meta/pull/29"},"issue":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/issues/29"},"comments":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/process_engine_meta/statuses/1c5d623d797135c5707cc4eddb4d107f248e9435"}},"author_association":"OWNER"}}
{"actor":{"display_login":"cmg-dev"}}