{"action":"created","issue":{"url":"https://api.github.com/repos/makeusabrew/bootbox/issues/566","repository_url":"https://api.github.com/repos/makeusabrew/bootbox","labels_url":"https://api.github.com/repos/makeusabrew/bootbox/issues/566/labels{/name}","comments_url":"https://api.github.com/repos/makeusabrew/bootbox/issues/566/comments","events_url":"https://api.github.com/repos/makeusabrew/bootbox/issues/566/events","html_url":"https://github.com/makeusabrew/bootbox/issues/566","id":193979328,"number":566,"title":"Required updates for Bootstrap 4 compatibility","user":{"login":"tiesont","id":420293,"avatar_url":"https://avatars2.githubusercontent.com/u/420293?v=4","gravatar_id":"","url":"https://api.github.com/users/tiesont","html_url":"https://github.com/tiesont","followers_url":"https://api.github.com/users/tiesont/followers","following_url":"https://api.github.com/users/tiesont/following{/other_user}","gists_url":"https://api.github.com/users/tiesont/gists{/gist_id}","starred_url":"https://api.github.com/users/tiesont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiesont/subscriptions","organizations_url":"https://api.github.com/users/tiesont/orgs","repos_url":"https://api.github.com/users/tiesont/repos","events_url":"https://api.github.com/users/tiesont/events{/privacy}","received_events_url":"https://api.github.com/users/tiesont/received_events","type":"User","site_admin":false},"labels":[{"id":181612,"url":"https://api.github.com/repos/makeusabrew/bootbox/labels/Task","name":"Task","color":"d7e102","default":false},{"id":718367389,"url":"https://api.github.com/repos/makeusabrew/bootbox/labels/v5","name":"v5","color":"e05e59","default":false}],"state":"closed","locked":false,"assignee":{"login":"tiesont","id":420293,"avatar_url":"https://avatars2.githubusercontent.com/u/420293?v=4","gravatar_id":"","url":"https://api.github.com/users/tiesont","html_url":"https://github.com/tiesont","followers_url":"https://api.github.com/users/tiesont/followers","following_url":"https://api.github.com/users/tiesont/following{/other_user}","gists_url":"https://api.github.com/users/tiesont/gists{/gist_id}","starred_url":"https://api.github.com/users/tiesont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiesont/subscriptions","organizations_url":"https://api.github.com/users/tiesont/orgs","repos_url":"https://api.github.com/users/tiesont/repos","events_url":"https://api.github.com/users/tiesont/events{/privacy}","received_events_url":"https://api.github.com/users/tiesont/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiesont","id":420293,"avatar_url":"https://avatars2.githubusercontent.com/u/420293?v=4","gravatar_id":"","url":"https://api.github.com/users/tiesont","html_url":"https://github.com/tiesont","followers_url":"https://api.github.com/users/tiesont/followers","following_url":"https://api.github.com/users/tiesont/following{/other_user}","gists_url":"https://api.github.com/users/tiesont/gists{/gist_id}","starred_url":"https://api.github.com/users/tiesont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiesont/subscriptions","organizations_url":"https://api.github.com/users/tiesont/orgs","repos_url":"https://api.github.com/users/tiesont/repos","events_url":"https://api.github.com/users/tiesont/events{/privacy}","received_events_url":"https://api.github.com/users/tiesont/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/makeusabrew/bootbox/milestones/7","html_url":"https://github.com/makeusabrew/bootbox/milestone/7","labels_url":"https://api.github.com/repos/makeusabrew/bootbox/milestones/7/labels","id":2711293,"number":7,"title":"5.0","description":null,"creator":{"login":"tiesont","id":420293,"avatar_url":"https://avatars2.githubusercontent.com/u/420293?v=4","gravatar_id":"","url":"https://api.github.com/users/tiesont","html_url":"https://github.com/tiesont","followers_url":"https://api.github.com/users/tiesont/followers","following_url":"https://api.github.com/users/tiesont/following{/other_user}","gists_url":"https://api.github.com/users/tiesont/gists{/gist_id}","starred_url":"https://api.github.com/users/tiesont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiesont/subscriptions","organizations_url":"https://api.github.com/users/tiesont/orgs","repos_url":"https://api.github.com/users/tiesont/repos","events_url":"https://api.github.com/users/tiesont/events{/privacy}","received_events_url":"https://api.github.com/users/tiesont/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2017-08-20T05:21:20Z","updated_at":"2018-03-30T03:44:37Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-12-07T07:44:52Z","updated_at":"2018-04-07T03:14:35Z","closed_at":"2018-02-09T01:22:22Z","author_association":"COLLABORATOR","body":"This is what I've found so far, in using Bootbox 4.4 with the **v4-alpha-6** version of Bootstrap 4.\r\n\r\n1. Line 59: Checkboxes use a new wrapper and have additional classes. If you want both BS3 and BS4 support, use:\r\n```\r\n\"<div class='form-check checkbox'><label class='form-check-label'><input class='form-check-input bootbox-input bootbox-input-checkbox' type='checkbox' /></label></div>\"\r\n```\r\n\r\nBS3 will ignore (essentially) the BS4 classes, since they don't exist.\r\n\r\n2. Line 180: `btn-default` changes to `btn-secondary`, or just use both classes.\r\n\r\n3. Line 624: `prepend` must change to `append` - Bootstrap 4 uses flexbox wherever possible, and prepending the button puts it before the header text. This yields the correct order:\r\n```\r\ndialog.find(\".modal-header\").append(closeButton);\r\n```\r\n\r\nOnce Bootstrap 4 goes to Beta or better, I'll work on a pull-request to get Bootbox 4.x updated, unless it makes more sense to push this off to Bootbox 5.\r\n\r\n**Update post Beta:**\r\n\r\nThe above changes are consistent with the current Beta release of Bootstrap 4. <s>We still don't have an ETA on either an updated 4.x release or a new 5.x version bump. </s>  <ins>I'm [currently working](https://github.com/tiesont/bootbox) on a v.5 release, although I can't promise when anything will be ready.</ins>"},"comment":{"url":"https://api.github.com/repos/makeusabrew/bootbox/issues/comments/379428093","html_url":"https://github.com/makeusabrew/bootbox/issues/566#issuecomment-379428093","issue_url":"https://api.github.com/repos/makeusabrew/bootbox/issues/566","id":379428093,"user":{"login":"gelinger777","id":184276,"avatar_url":"https://avatars2.githubusercontent.com/u/184276?v=4","gravatar_id":"","url":"https://api.github.com/users/gelinger777","html_url":"https://github.com/gelinger777","followers_url":"https://api.github.com/users/gelinger777/followers","following_url":"https://api.github.com/users/gelinger777/following{/other_user}","gists_url":"https://api.github.com/users/gelinger777/gists{/gist_id}","starred_url":"https://api.github.com/users/gelinger777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelinger777/subscriptions","organizations_url":"https://api.github.com/users/gelinger777/orgs","repos_url":"https://api.github.com/users/gelinger777/repos","events_url":"https://api.github.com/users/gelinger777/events{/privacy}","received_events_url":"https://api.github.com/users/gelinger777/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T03:14:35Z","updated_at":"2018-04-07T03:14:35Z","author_association":"NONE","body":"when do you plan to release v5?"}}
{"actor":{"display_login":"gelinger777"}}