{"action":"created","comment":{"url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/comments/212842044","pull_request_review_id":149552839,"id":212842044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjg0MjA0NA==","diff_hunk":"@@ -0,0 +1,232 @@\n+//\n+//  CompletionRequirementTests.swift\n+//  FlintCore\n+//\n+//  Created by Marc Palmer on 19/08/2018.\n+//  Copyright © 2018 Montana Floss Co. Ltd. All rights reserved.\n+//\n+\n+import XCTest\n+import FlintCore\n+\n+/// Test the `CompletionRequirement` type\n+class CompletionRequirementTests: XCTestCase {\n+\n+    override func setUp() {\n+    }\n+\n+    override func tearDown() {\n+    }","path":"FlintCoreTests/CompletionRequirementTests.swift","position":19,"original_position":19,"commit_id":"1b06c0aa1fb7901be1b361f755a4a6e0a8a6d194","original_commit_id":"1b06c0aa1fb7901be1b361f755a4a6e0a8a6d194","user":{"login":"drumnkyle","id":52436,"node_id":"MDQ6VXNlcjUyNDM2","avatar_url":"https://avatars1.githubusercontent.com/u/52436?v=4","gravatar_id":"","url":"https://api.github.com/users/drumnkyle","html_url":"https://github.com/drumnkyle","followers_url":"https://api.github.com/users/drumnkyle/followers","following_url":"https://api.github.com/users/drumnkyle/following{/other_user}","gists_url":"https://api.github.com/users/drumnkyle/gists{/gist_id}","starred_url":"https://api.github.com/users/drumnkyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drumnkyle/subscriptions","organizations_url":"https://api.github.com/users/drumnkyle/orgs","repos_url":"https://api.github.com/users/drumnkyle/repos","events_url":"https://api.github.com/users/drumnkyle/events{/privacy}","received_events_url":"https://api.github.com/users/drumnkyle/received_events","type":"User","site_admin":false},"body":"Same as above.","created_at":"2018-08-26T23:08:38Z","updated_at":"2018-08-26T23:09:26Z","html_url":"https://github.com/MontanaFlossCo/Flint/pull/162#discussion_r212842044","pull_request_url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/comments/212842044"},"html":{"href":"https://github.com/MontanaFlossCo/Flint/pull/162#discussion_r212842044"},"pull_request":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162","id":202085362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDg1MzYy","html_url":"https://github.com/MontanaFlossCo/Flint/pull/162","diff_url":"https://github.com/MontanaFlossCo/Flint/pull/162.diff","patch_url":"https://github.com/MontanaFlossCo/Flint/pull/162.patch","issue_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/162","number":162,"state":"open","locked":false,"title":"New completion idea/proposal","user":{"login":"marcpalmer","id":40849,"node_id":"MDQ6VXNlcjQwODQ5","avatar_url":"https://avatars2.githubusercontent.com/u/40849?v=4","gravatar_id":"","url":"https://api.github.com/users/marcpalmer","html_url":"https://github.com/marcpalmer","followers_url":"https://api.github.com/users/marcpalmer/followers","following_url":"https://api.github.com/users/marcpalmer/following{/other_user}","gists_url":"https://api.github.com/users/marcpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcpalmer/subscriptions","organizations_url":"https://api.github.com/users/marcpalmer/orgs","repos_url":"https://api.github.com/users/marcpalmer/repos","events_url":"https://api.github.com/users/marcpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/marcpalmer/received_events","type":"User","site_admin":false},"body":"This is a proposal to prevent callers from making mistakes where they forget to call completion on the coordinator, causing weird bugs in the authorisation flow — exactly the bug I found and fixed in FlintDemo today.","created_at":"2018-07-17T21:55:46Z","updated_at":"2018-08-26T23:09:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64fe3bcad1a075576f38334bd3c58617b46b0ee4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/MontanaFlossCo/Flint/milestones/1","html_url":"https://github.com/MontanaFlossCo/Flint/milestone/1","labels_url":"https://api.github.com/repos/MontanaFlossCo/Flint/milestones/1/labels","id":3293534,"node_id":"MDk6TWlsZXN0b25lMzI5MzUzNA==","number":1,"title":"1.0","description":"The first \"you should release apps using this\" release, with a stable API","creator":{"login":"marcpalmer","id":40849,"node_id":"MDQ6VXNlcjQwODQ5","avatar_url":"https://avatars2.githubusercontent.com/u/40849?v=4","gravatar_id":"","url":"https://api.github.com/users/marcpalmer","html_url":"https://github.com/marcpalmer","followers_url":"https://api.github.com/users/marcpalmer/followers","following_url":"https://api.github.com/users/marcpalmer/following{/other_user}","gists_url":"https://api.github.com/users/marcpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcpalmer/subscriptions","organizations_url":"https://api.github.com/users/marcpalmer/orgs","repos_url":"https://api.github.com/users/marcpalmer/repos","events_url":"https://api.github.com/users/marcpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/marcpalmer/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":83,"state":"open","created_at":"2018-04-24T16:14:32Z","updated_at":"2018-08-17T12:08:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162/commits","review_comments_url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162/comments","review_comment_url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/162/comments","statuses_url":"https://api.github.com/repos/MontanaFlossCo/Flint/statuses/1b06c0aa1fb7901be1b361f755a4a6e0a8a6d194","head":{"label":"MontanaFlossCo:marc/completion-proposal","ref":"marc/completion-proposal","sha":"1b06c0aa1fb7901be1b361f755a4a6e0a8a6d194","user":{"login":"MontanaFlossCo","id":15869069,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODY5MDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15869069?v=4","gravatar_id":"","url":"https://api.github.com/users/MontanaFlossCo","html_url":"https://github.com/MontanaFlossCo","followers_url":"https://api.github.com/users/MontanaFlossCo/followers","following_url":"https://api.github.com/users/MontanaFlossCo/following{/other_user}","gists_url":"https://api.github.com/users/MontanaFlossCo/gists{/gist_id}","starred_url":"https://api.github.com/users/MontanaFlossCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontanaFlossCo/subscriptions","organizations_url":"https://api.github.com/users/MontanaFlossCo/orgs","repos_url":"https://api.github.com/users/MontanaFlossCo/repos","events_url":"https://api.github.com/users/MontanaFlossCo/events{/privacy}","received_events_url":"https://api.github.com/users/MontanaFlossCo/received_events","type":"Organization","site_admin":false},"repo":{"id":120908184,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5MDgxODQ=","name":"Flint","full_name":"MontanaFlossCo/Flint","owner":{"login":"MontanaFlossCo","id":15869069,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODY5MDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15869069?v=4","gravatar_id":"","url":"https://api.github.com/users/MontanaFlossCo","html_url":"https://github.com/MontanaFlossCo","followers_url":"https://api.github.com/users/MontanaFlossCo/followers","following_url":"https://api.github.com/users/MontanaFlossCo/following{/other_user}","gists_url":"https://api.github.com/users/MontanaFlossCo/gists{/gist_id}","starred_url":"https://api.github.com/users/MontanaFlossCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontanaFlossCo/subscriptions","organizations_url":"https://api.github.com/users/MontanaFlossCo/orgs","repos_url":"https://api.github.com/users/MontanaFlossCo/repos","events_url":"https://api.github.com/users/MontanaFlossCo/events{/privacy}","received_events_url":"https://api.github.com/users/MontanaFlossCo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MontanaFlossCo/Flint","description":"The Flint framework for building apps on Apple platforms using Feature Driven Development","fork":false,"url":"https://api.github.com/repos/MontanaFlossCo/Flint","forks_url":"https://api.github.com/repos/MontanaFlossCo/Flint/forks","keys_url":"https://api.github.com/repos/MontanaFlossCo/Flint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MontanaFlossCo/Flint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MontanaFlossCo/Flint/teams","hooks_url":"https://api.github.com/repos/MontanaFlossCo/Flint/hooks","issue_events_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/events{/number}","events_url":"https://api.github.com/repos/MontanaFlossCo/Flint/events","assignees_url":"https://api.github.com/repos/MontanaFlossCo/Flint/assignees{/user}","branches_url":"https://api.github.com/repos/MontanaFlossCo/Flint/branches{/branch}","tags_url":"https://api.github.com/repos/MontanaFlossCo/Flint/tags","blobs_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/refs{/sha}","trees_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MontanaFlossCo/Flint/statuses/{sha}","languages_url":"https://api.github.com/repos/MontanaFlossCo/Flint/languages","stargazers_url":"https://api.github.com/repos/MontanaFlossCo/Flint/stargazers","contributors_url":"https://api.github.com/repos/MontanaFlossCo/Flint/contributors","subscribers_url":"https://api.github.com/repos/MontanaFlossCo/Flint/subscribers","subscription_url":"https://api.github.com/repos/MontanaFlossCo/Flint/subscription","commits_url":"https://api.github.com/repos/MontanaFlossCo/Flint/commits{/sha}","git_commits_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/commits{/sha}","comments_url":"https://api.github.com/repos/MontanaFlossCo/Flint/comments{/number}","issue_comment_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/comments{/number}","contents_url":"https://api.github.com/repos/MontanaFlossCo/Flint/contents/{+path}","compare_url":"https://api.github.com/repos/MontanaFlossCo/Flint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MontanaFlossCo/Flint/merges","archive_url":"https://api.github.com/repos/MontanaFlossCo/Flint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MontanaFlossCo/Flint/downloads","issues_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues{/number}","pulls_url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls{/number}","milestones_url":"https://api.github.com/repos/MontanaFlossCo/Flint/milestones{/number}","notifications_url":"https://api.github.com/repos/MontanaFlossCo/Flint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MontanaFlossCo/Flint/labels{/name}","releases_url":"https://api.github.com/repos/MontanaFlossCo/Flint/releases{/id}","deployments_url":"https://api.github.com/repos/MontanaFlossCo/Flint/deployments","created_at":"2018-02-09T13:21:18Z","updated_at":"2018-08-26T00:30:59Z","pushed_at":"2018-08-26T21:45:25Z","git_url":"git://github.com/MontanaFlossCo/Flint.git","ssh_url":"git@github.com:MontanaFlossCo/Flint.git","clone_url":"https://github.com/MontanaFlossCo/Flint.git","svn_url":"https://github.com/MontanaFlossCo/Flint","homepage":"https://flint.tools","size":1658,"stargazers_count":338,"watchers_count":338,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":83,"watchers":338,"default_branch":"master"}},"base":{"label":"MontanaFlossCo:master","ref":"master","sha":"2795a0b7cea0c41aa5b44cf2a03c27035aab7bfd","user":{"login":"MontanaFlossCo","id":15869069,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODY5MDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15869069?v=4","gravatar_id":"","url":"https://api.github.com/users/MontanaFlossCo","html_url":"https://github.com/MontanaFlossCo","followers_url":"https://api.github.com/users/MontanaFlossCo/followers","following_url":"https://api.github.com/users/MontanaFlossCo/following{/other_user}","gists_url":"https://api.github.com/users/MontanaFlossCo/gists{/gist_id}","starred_url":"https://api.github.com/users/MontanaFlossCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontanaFlossCo/subscriptions","organizations_url":"https://api.github.com/users/MontanaFlossCo/orgs","repos_url":"https://api.github.com/users/MontanaFlossCo/repos","events_url":"https://api.github.com/users/MontanaFlossCo/events{/privacy}","received_events_url":"https://api.github.com/users/MontanaFlossCo/received_events","type":"Organization","site_admin":false},"repo":{"id":120908184,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5MDgxODQ=","name":"Flint","full_name":"MontanaFlossCo/Flint","owner":{"login":"MontanaFlossCo","id":15869069,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODY5MDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15869069?v=4","gravatar_id":"","url":"https://api.github.com/users/MontanaFlossCo","html_url":"https://github.com/MontanaFlossCo","followers_url":"https://api.github.com/users/MontanaFlossCo/followers","following_url":"https://api.github.com/users/MontanaFlossCo/following{/other_user}","gists_url":"https://api.github.com/users/MontanaFlossCo/gists{/gist_id}","starred_url":"https://api.github.com/users/MontanaFlossCo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontanaFlossCo/subscriptions","organizations_url":"https://api.github.com/users/MontanaFlossCo/orgs","repos_url":"https://api.github.com/users/MontanaFlossCo/repos","events_url":"https://api.github.com/users/MontanaFlossCo/events{/privacy}","received_events_url":"https://api.github.com/users/MontanaFlossCo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MontanaFlossCo/Flint","description":"The Flint framework for building apps on Apple platforms using Feature Driven Development","fork":false,"url":"https://api.github.com/repos/MontanaFlossCo/Flint","forks_url":"https://api.github.com/repos/MontanaFlossCo/Flint/forks","keys_url":"https://api.github.com/repos/MontanaFlossCo/Flint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MontanaFlossCo/Flint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MontanaFlossCo/Flint/teams","hooks_url":"https://api.github.com/repos/MontanaFlossCo/Flint/hooks","issue_events_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/events{/number}","events_url":"https://api.github.com/repos/MontanaFlossCo/Flint/events","assignees_url":"https://api.github.com/repos/MontanaFlossCo/Flint/assignees{/user}","branches_url":"https://api.github.com/repos/MontanaFlossCo/Flint/branches{/branch}","tags_url":"https://api.github.com/repos/MontanaFlossCo/Flint/tags","blobs_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/refs{/sha}","trees_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MontanaFlossCo/Flint/statuses/{sha}","languages_url":"https://api.github.com/repos/MontanaFlossCo/Flint/languages","stargazers_url":"https://api.github.com/repos/MontanaFlossCo/Flint/stargazers","contributors_url":"https://api.github.com/repos/MontanaFlossCo/Flint/contributors","subscribers_url":"https://api.github.com/repos/MontanaFlossCo/Flint/subscribers","subscription_url":"https://api.github.com/repos/MontanaFlossCo/Flint/subscription","commits_url":"https://api.github.com/repos/MontanaFlossCo/Flint/commits{/sha}","git_commits_url":"https://api.github.com/repos/MontanaFlossCo/Flint/git/commits{/sha}","comments_url":"https://api.github.com/repos/MontanaFlossCo/Flint/comments{/number}","issue_comment_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/comments{/number}","contents_url":"https://api.github.com/repos/MontanaFlossCo/Flint/contents/{+path}","compare_url":"https://api.github.com/repos/MontanaFlossCo/Flint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MontanaFlossCo/Flint/merges","archive_url":"https://api.github.com/repos/MontanaFlossCo/Flint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MontanaFlossCo/Flint/downloads","issues_url":"https://api.github.com/repos/MontanaFlossCo/Flint/issues{/number}","pulls_url":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls{/number}","milestones_url":"https://api.github.com/repos/MontanaFlossCo/Flint/milestones{/number}","notifications_url":"https://api.github.com/repos/MontanaFlossCo/Flint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MontanaFlossCo/Flint/labels{/name}","releases_url":"https://api.github.com/repos/MontanaFlossCo/Flint/releases{/id}","deployments_url":"https://api.github.com/repos/MontanaFlossCo/Flint/deployments","created_at":"2018-02-09T13:21:18Z","updated_at":"2018-08-26T00:30:59Z","pushed_at":"2018-08-26T21:45:25Z","git_url":"git://github.com/MontanaFlossCo/Flint.git","ssh_url":"git@github.com:MontanaFlossCo/Flint.git","clone_url":"https://github.com/MontanaFlossCo/Flint.git","svn_url":"https://github.com/MontanaFlossCo/Flint","homepage":"https://flint.tools","size":1658,"stargazers_count":338,"watchers_count":338,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":83,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162"},"html":{"href":"https://github.com/MontanaFlossCo/Flint/pull/162"},"issue":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/162"},"comments":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/MontanaFlossCo/Flint/statuses/1b06c0aa1fb7901be1b361f755a4a6e0a8a6d194"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drumnkyle"}}