{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/comments/206459791","pull_request_review_id":141874178,"id":206459791,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjQ1OTc5MQ==","diff_hunk":"@@ -0,0 +1,72 @@\n+FROM registry.centos.org/che-stacks/centos-stack-base:latest\n+ENV PHP_LS_VERSION=5.4.1 \\\n+    OC_VERSION=3.9.38\n+RUN sudo yum install -y epel-release http://rpms.remirepo.net/enterprise/remi-release-7.rpm  \\\n+    sudo yum-utils && \\\n+    sudo yum-config-manager --enable remi-php70 && \\\n+    sudo yum install -y \\\n+        rpmdevtools \\\n+        php-bcmath \\\n+        php-cli \\\n+        php-fpm \\\n+        php-mysqlnd \\\n+        php-mssql \\\n+        php-xml \\\n+        php-pgsql \\\n+        php-gd \\\n+        php-mcrypt \\\n+        php-ldap \\\n+        php-imap \\\n+        php-soap \\\n+        php-tidy \\\n+        php-mbstring \\\n+        php-opcache \\\n+        php-pdo \\\n+        php-pecl-apcu \\\n+        php-pecl-apcu-bc \\\n+        php-pecl-geoip \\\n+        php-pecl-igbinary \\\n+        php-pecl-imagick \\\n+        php-pecl-redis \\\n+        unzip \\\n+        httpd && \\\n+        sudo yum --enablerepo=epel install -y fcgi && \\\n+        sudo yum clean all && \\\n+        sudo sed -i 's/\\/var\\/www\\/html/\\/projects/g'  /etc/httpd/conf/httpd.conf && \\\n+        sudo sed -i 's/Listen 80/Listen 8080/' /etc/httpd/conf/httpd.conf && \\\n+        sudo sed -i 's/None/All/g' /etc/httpd/conf/httpd.conf && \\\n+        sudo sed -i 's/index.html/index.php/g' /etc/httpd/conf/httpd.conf && \\\n+        echo \"ServerName localhost\" | sudo tee -a /etc/httpd/conf/httpd.conf && \\\n+        for f in \"/var/log/httpd\" \"/etc/httpd\" \"/run/httpd\"; do \\\n+            sudo chgrp -R 0 ${f} && \\\n+            sudo chmod -R g+rwX ${f}; \\\n+          done && \\\n+        sudo rm /etc/httpd/conf.d/welcome.conf && \\\n+        sudo sh -c 'echo -e \"; configuration for php ZendDebugger module\\n; priority=90\\nzend_extension=ZendDebugger.so\" > /etc/php.d/zenddebugger.ini'\n+\n+# since http://repos.zend.com/zend-server/9.0.2/rpm_apache2.4/x86_64/zend-server-php-7.0-common-9.0.2-372.x86_64.rpm is often down,\n+# it is safer to ADD the file that is available in the dockerfiles repo rather than remotely","path":"recipes/dockerfiles/centos_php/Dockerfile","position":null,"original_position":48,"commit_id":"8fdeb48e34f28f4ead3aebd058d4f05d52fdbd02","original_commit_id":"d3c48b4226279ab6ec4d540e35d264670a43c889","user":{"login":"eivantsov","id":5337267,"node_id":"MDQ6VXNlcjUzMzcyNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5337267?v=4","gravatar_id":"","url":"https://api.github.com/users/eivantsov","html_url":"https://github.com/eivantsov","followers_url":"https://api.github.com/users/eivantsov/followers","following_url":"https://api.github.com/users/eivantsov/following{/other_user}","gists_url":"https://api.github.com/users/eivantsov/gists{/gist_id}","starred_url":"https://api.github.com/users/eivantsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eivantsov/subscriptions","organizations_url":"https://api.github.com/users/eivantsov/orgs","repos_url":"https://api.github.com/users/eivantsov/repos","events_url":"https://api.github.com/users/eivantsov/events{/privacy}","received_events_url":"https://api.github.com/users/eivantsov/received_events","type":"User","site_admin":false},"body":"For now, let's rely on Zend repo. If it starts to fail quite often, updating Docker and using multi staged builds is the right way to go","created_at":"2018-07-31T09:38:01Z","updated_at":"2018-07-31T09:38:01Z","html_url":"https://github.com/redhat-developer/che-dockerfiles/pull/39#discussion_r206459791","pull_request_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/comments/206459791"},"html":{"href":"https://github.com/redhat-developer/che-dockerfiles/pull/39#discussion_r206459791"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39"}},"in_reply_to_id":206405704},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39","id":205003372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDAzMzcy","html_url":"https://github.com/redhat-developer/che-dockerfiles/pull/39","diff_url":"https://github.com/redhat-developer/che-dockerfiles/pull/39.diff","patch_url":"https://github.com/redhat-developer/che-dockerfiles/pull/39.patch","issue_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/39","number":39,"state":"open","locked":false,"title":"Add CentOS based php, python and ruby images","user":{"login":"eivantsov","id":5337267,"node_id":"MDQ6VXNlcjUzMzcyNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5337267?v=4","gravatar_id":"","url":"https://api.github.com/users/eivantsov","html_url":"https://github.com/eivantsov","followers_url":"https://api.github.com/users/eivantsov/followers","following_url":"https://api.github.com/users/eivantsov/following{/other_user}","gists_url":"https://api.github.com/users/eivantsov/gists{/gist_id}","starred_url":"https://api.github.com/users/eivantsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eivantsov/subscriptions","organizations_url":"https://api.github.com/users/eivantsov/orgs","repos_url":"https://api.github.com/users/eivantsov/repos","events_url":"https://api.github.com/users/eivantsov/events{/privacy}","received_events_url":"https://api.github.com/users/eivantsov/received_events","type":"User","site_admin":false},"body":"This PR:\r\n\r\n* adds php, python and ruby images (php and python language servers pre installed)\r\n* updates OC to version 3.9 in all images\r\n\r\nThere will be a PR to https://github.com/redhat-developer/rh-che/blob/master/assembly/fabric8-stacks/src/main/resources/stacks.json to add stacks that will reference these and other missing images as per https://docs.google.com/spreadsheets/d/1gxV8US5CrjngqjYmaTELlA1kqfxtxBGNWBjo0grGRrU/edit#gid=0\r\n\r\nOnce can try images: `eivantsov/centos_php(python/ruby)`\r\n\r\nA few things worth mentioning:\r\n\r\n1. There's ZendDebugger.so committed to this repo. I do understand it's not the best practice, but Zend repo is down every now and then which makes build of php image extremely unstable. Having this .so file available in Docker context solves the problem.\r\n\r\n2. While @amisevsk did a great job of moving typical operations to https://github.com/redhat-developer/che-dockerfiles/tree/master/recipes/context, some images use it (for example https://github.com/redhat-developer/che-dockerfiles/blob/master/recipes/dockerfiles/centos_jdk8/Dockerfile) while others don't (https://github.com/redhat-developer/che-dockerfiles/blob/master/recipes/dockerfiles/centos_dotnet20/Dockerfile)\r\n\r\nI was unsure if new images should use it as there's no real need to chown home dir again.","created_at":"2018-07-31T05:56:26Z","updated_at":"2018-07-31T09:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83b154f3f003eb92040f74a86229338c1f3638c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/39/comments","statuses_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/statuses/8fdeb48e34f28f4ead3aebd058d4f05d52fdbd02","head":{"label":"redhat-developer:codenvy_stacks","ref":"codenvy_stacks","sha":"8fdeb48e34f28f4ead3aebd058d4f05d52fdbd02","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":85245619,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI0NTYxOQ==","name":"che-dockerfiles","full_name":"redhat-developer/che-dockerfiles","owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-developer/che-dockerfiles","description":"Che dockerfiles extended with security in mind","fork":false,"url":"https://api.github.com/repos/redhat-developer/che-dockerfiles","forks_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/forks","keys_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/teams","hooks_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/events","assignees_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/tags","blobs_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/subscription","commits_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/merges","archive_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/downloads","issues_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/deployments","created_at":"2017-03-16T22:04:31Z","updated_at":"2018-07-25T12:48:39Z","pushed_at":"2018-07-31T09:36:41Z","git_url":"git://github.com/redhat-developer/che-dockerfiles.git","ssh_url":"git@github.com:redhat-developer/che-dockerfiles.git","clone_url":"https://github.com/redhat-developer/che-dockerfiles.git","svn_url":"https://github.com/redhat-developer/che-dockerfiles","homepage":null,"size":172,"stargazers_count":3,"watchers_count":3,"language":"Dockerfile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":13,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"15374da5a7f85e227631a51a67ba3dd795f016e5","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":85245619,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI0NTYxOQ==","name":"che-dockerfiles","full_name":"redhat-developer/che-dockerfiles","owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-developer/che-dockerfiles","description":"Che dockerfiles extended with security in mind","fork":false,"url":"https://api.github.com/repos/redhat-developer/che-dockerfiles","forks_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/forks","keys_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/teams","hooks_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/events","assignees_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/tags","blobs_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/subscription","commits_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/merges","archive_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/downloads","issues_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/che-dockerfiles/deployments","created_at":"2017-03-16T22:04:31Z","updated_at":"2018-07-25T12:48:39Z","pushed_at":"2018-07-31T09:36:41Z","git_url":"git://github.com/redhat-developer/che-dockerfiles.git","ssh_url":"git@github.com:redhat-developer/che-dockerfiles.git","clone_url":"https://github.com/redhat-developer/che-dockerfiles.git","svn_url":"https://github.com/redhat-developer/che-dockerfiles","homepage":null,"size":172,"stargazers_count":3,"watchers_count":3,"language":"Dockerfile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":13,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39"},"html":{"href":"https://github.com/redhat-developer/che-dockerfiles/pull/39"},"issue":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/39"},"comments":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/che-dockerfiles/statuses/8fdeb48e34f28f4ead3aebd058d4f05d52fdbd02"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"eivantsov"}}