{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/239988768","pull_request_review_id":182923875,"id":239988768,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk4ODc2OA==","diff_hunk":"@@ -0,0 +1,95 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.elasticsearch;\n+\n+import com.facebook.presto.testing.MaterializedResult;\n+import com.facebook.presto.testing.MaterializedRow;\n+import com.facebook.presto.testing.QueryRunner;\n+import com.facebook.presto.tests.AbstractTestIntegrationSmokeTest;\n+import com.google.common.io.Closer;\n+import io.airlift.tpch.TpchTable;\n+import org.testng.annotations.AfterClass;\n+import org.testng.annotations.BeforeClass;\n+import org.testng.annotations.Test;\n+\n+import java.io.IOException;\n+\n+import static com.facebook.presto.elasticsearch.ElasticsearchQueryRunner.createElasticsearchQueryRunner;\n+import static com.facebook.presto.elasticsearch.EmbeddedElasticsearchNode.createEmbeddedElasticsearch;\n+import static com.facebook.presto.spi.type.VarcharType.VARCHAR;\n+import static com.facebook.presto.testing.MaterializedResult.resultBuilder;\n+import static com.facebook.presto.testing.assertions.Assert.assertEquals;\n+import static java.lang.String.format;\n+\n+public class TestElasticsearchIntegrationSmoke\n+        extends AbstractTestIntegrationSmokeTest\n+{\n+    private final EmbeddedElasticsearchNode embeddedElasticsearch;\n+\n+    private QueryRunner queryRunner;\n+\n+    public TestElasticsearchIntegrationSmoke()\n+            throws Exception\n+    {\n+        this(createEmbeddedElasticsearch());\n+    }\n+\n+    public TestElasticsearchIntegrationSmoke(EmbeddedElasticsearchNode embeddedElasticsearch)\n+            throws Exception\n+    {\n+        super(() -> createElasticsearchQueryRunner(embeddedElasticsearch, TpchTable.getTables()));\n+        this.embeddedElasticsearch = embeddedElasticsearch;\n+    }\n+\n+    @BeforeClass\n+    public void setUp()\n+    {\n+        queryRunner = getQueryRunner();\n+    }\n+\n+    @AfterClass(alwaysRun = true)\n+    public final void destroy()\n+            throws IOException\n+    {\n+        try (Closer closer = Closer.create()) {\n+            closer.register(queryRunner);\n+            closer.register(embeddedElasticsearch);\n+        }\n+        queryRunner = null;\n+    }\n+\n+    @Test\n+    @Override\n+    public void testDescribeTable()\n+    {\n+        MaterializedResult actualColumns = this.computeActual(\"DESC orders\").toTestTypes();","path":"presto-elasticsearch/src/test/java/com/facebook/presto/elasticsearch/TestElasticsearchIntegrationSmoke.java","position":76,"original_position":76,"commit_id":"4ebd39a5545636daecb952fc2b5be43c82bcf8e9","original_commit_id":"4ebd39a5545636daecb952fc2b5be43c82bcf8e9","user":{"login":"nezihyigitbasi","id":1223839,"node_id":"MDQ6VXNlcjEyMjM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"body":"unnecessary `this`","created_at":"2018-12-08T01:55:21Z","updated_at":"2018-12-08T01:58:41Z","html_url":"https://github.com/prestodb/presto/pull/11942#discussion_r239988768","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/11942","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/239988768"},"html":{"href":"https://github.com/prestodb/presto/pull/11942#discussion_r239988768"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11942"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/11942","id":231428375,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDI4Mzc1","html_url":"https://github.com/prestodb/presto/pull/11942","diff_url":"https://github.com/prestodb/presto/pull/11942.diff","patch_url":"https://github.com/prestodb/presto/pull/11942.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11942","number":11942,"state":"open","locked":false,"title":"Presto Elasticsearch Connector","user":{"login":"zhenxiao","id":1274155,"node_id":"MDQ6VXNlcjEyNzQxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1274155?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"body":"continue Presto Elasticsearch Connector:\r\nhttps://github.com/prestodb/presto/pull/9459\r\n\r\n@nezihyigitbasi @kokosing ","created_at":"2018-11-16T06:26:54Z","updated_at":"2018-12-08T01:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ef70457d66555e918c827888eead569aa2931b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/11942/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/11942/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11942/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/4ebd39a5545636daecb952fc2b5be43c82bcf8e9","head":{"label":"zhenxiao:elk","ref":"elk","sha":"4ebd39a5545636daecb952fc2b5be43c82bcf8e9","user":{"login":"zhenxiao","id":1274155,"node_id":"MDQ6VXNlcjEyNzQxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1274155?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"repo":{"id":17963913,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk2MzkxMw==","name":"presto","full_name":"zhenxiao/presto","private":false,"owner":{"login":"zhenxiao","id":1274155,"node_id":"MDQ6VXNlcjEyNzQxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1274155?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenxiao","html_url":"https://github.com/zhenxiao","followers_url":"https://api.github.com/users/zhenxiao/followers","following_url":"https://api.github.com/users/zhenxiao/following{/other_user}","gists_url":"https://api.github.com/users/zhenxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenxiao/subscriptions","organizations_url":"https://api.github.com/users/zhenxiao/orgs","repos_url":"https://api.github.com/users/zhenxiao/repos","events_url":"https://api.github.com/users/zhenxiao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenxiao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhenxiao/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/zhenxiao/presto","forks_url":"https://api.github.com/repos/zhenxiao/presto/forks","keys_url":"https://api.github.com/repos/zhenxiao/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhenxiao/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhenxiao/presto/teams","hooks_url":"https://api.github.com/repos/zhenxiao/presto/hooks","issue_events_url":"https://api.github.com/repos/zhenxiao/presto/issues/events{/number}","events_url":"https://api.github.com/repos/zhenxiao/presto/events","assignees_url":"https://api.github.com/repos/zhenxiao/presto/assignees{/user}","branches_url":"https://api.github.com/repos/zhenxiao/presto/branches{/branch}","tags_url":"https://api.github.com/repos/zhenxiao/presto/tags","blobs_url":"https://api.github.com/repos/zhenxiao/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhenxiao/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhenxiao/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhenxiao/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhenxiao/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/zhenxiao/presto/languages","stargazers_url":"https://api.github.com/repos/zhenxiao/presto/stargazers","contributors_url":"https://api.github.com/repos/zhenxiao/presto/contributors","subscribers_url":"https://api.github.com/repos/zhenxiao/presto/subscribers","subscription_url":"https://api.github.com/repos/zhenxiao/presto/subscription","commits_url":"https://api.github.com/repos/zhenxiao/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhenxiao/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhenxiao/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhenxiao/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhenxiao/presto/contents/{+path}","compare_url":"https://api.github.com/repos/zhenxiao/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhenxiao/presto/merges","archive_url":"https://api.github.com/repos/zhenxiao/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhenxiao/presto/downloads","issues_url":"https://api.github.com/repos/zhenxiao/presto/issues{/number}","pulls_url":"https://api.github.com/repos/zhenxiao/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/zhenxiao/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/zhenxiao/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhenxiao/presto/labels{/name}","releases_url":"https://api.github.com/repos/zhenxiao/presto/releases{/id}","deployments_url":"https://api.github.com/repos/zhenxiao/presto/deployments","created_at":"2014-03-21T01:03:42Z","updated_at":"2018-03-22T11:08:39Z","pushed_at":"2018-12-06T10:57:56Z","git_url":"git://github.com/zhenxiao/presto.git","ssh_url":"git@github.com:zhenxiao/presto.git","clone_url":"https://github.com/zhenxiao/presto.git","svn_url":"https://github.com/zhenxiao/presto","homepage":"http://prestodb.io/","size":103887,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"65edf4963f50798ff9d449f76caa6cbd6e69ed45","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-12-07T11:14:09Z","pushed_at":"2018-12-07T22:23:17Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":104949,"stargazers_count":8393,"watchers_count":8393,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2857,"mirror_url":null,"archived":false,"open_issues_count":1479,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2857,"open_issues":1479,"watchers":8393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11942"},"html":{"href":"https://github.com/prestodb/presto/pull/11942"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/11942"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/11942/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11942/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11942/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/4ebd39a5545636daecb952fc2b5be43c82bcf8e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nezihyigitbasi"}}