{"action":"closed","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/12573","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/12573/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/12573/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/12573/events","html_url":"https://github.com/owncloud/core/issues/12573","id":50829031,"node_id":"MDU6SXNzdWU1MDgyOTAzMQ==","number":12573,"title":"Classes in apps/ should use OCA\\ namespace","user":{"login":"nickvergessen","id":213943,"node_id":"MDQ6VXNlcjIxMzk0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/213943?v=4","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"labels":[{"id":18120854,"node_id":"MDU6TGFiZWwxODEyMDg1NA==","url":"https://api.github.com/repos/owncloud/core/labels/app:files_external","name":"app:files_external","color":"02d7e1","default":false},{"id":12406436,"node_id":"MDU6TGFiZWwxMjQwNjQzNg==","url":"https://api.github.com/repos/owncloud/core/labels/enhancement","name":"enhancement","color":"02e10c","default":true},{"id":18122325,"node_id":"MDU6TGFiZWwxODEyMjMyNQ==","url":"https://api.github.com/repos/owncloud/core/labels/feature:sharing","name":"feature:sharing","color":"d4c5f9","default":false},{"id":751771728,"node_id":"MDU6TGFiZWw3NTE3NzE3Mjg=","url":"https://api.github.com/repos/owncloud/core/labels/status/STALE","name":"status/STALE","color":"ededed","default":false},{"id":126298320,"node_id":"MDU6TGFiZWwxMjYyOTgzMjA=","url":"https://api.github.com/repos/owncloud/core/labels/technical%20debt","name":"technical debt","color":"FFFF00","default":false}],"state":"closed","locked":false,"assignee":{"login":"DeepDiver1975","id":1005065,"node_id":"MDQ6VXNlcjEwMDUwNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"assignees":[{"login":"DeepDiver1975","id":1005065,"node_id":"MDQ6VXNlcjEwMDUwNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/120","html_url":"https://github.com/owncloud/core/milestone/120","labels_url":"https://api.github.com/repos/owncloud/core/milestones/120/labels","id":3031526,"node_id":"MDk6TWlsZXN0b25lMzAzMTUyNg==","number":120,"title":"development","description":"10.0.10","creator":{"login":"PVince81","id":277525,"node_id":"MDQ6VXNlcjI3NzUyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":69,"closed_issues":254,"state":"open","created_at":"2018-01-12T14:07:35Z","updated_at":"2018-07-31T11:11:08Z","due_on":"2018-08-24T07:00:00Z","closed_at":null},"comments":5,"created_at":"2014-12-03T12:03:43Z","updated_at":"2018-07-31T11:11:08Z","closed_at":"2018-07-31T11:11:08Z","author_association":"CONTRIBUTOR","body":"- Encryption uses OCA\\Encryption instead of OCA\\Files_Encryption: https://github.com/owncloud/core/pull/12568\n- Sharing is hacking itself into all kind of namespace/OC_:\n\n``` php\nOC::$CLASSPATH['OC_Share_Backend_File'] = 'files_sharing/lib/share/file.php';\nOC::$CLASSPATH['OC_Share_Backend_Folder'] = 'files_sharing/lib/share/folder.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\Shared'] = 'files_sharing/lib/sharedstorage.php';\nOC::$CLASSPATH['OC\\Files\\Cache\\Shared_Cache'] = 'files_sharing/lib/cache.php';\nOC::$CLASSPATH['OC\\Files\\Cache\\Shared_Permissions'] = 'files_sharing/lib/permissions.php';\nOC::$CLASSPATH['OC\\Files\\Cache\\Shared_Updater'] = 'files_sharing/lib/updater.php';\nOC::$CLASSPATH['OC\\Files\\Cache\\Shared_Watcher'] = 'files_sharing/lib/watcher.php';\n```\n- Same issue with the externals:\n\n``` php\nOC::$CLASSPATH['OC\\Files\\Storage\\StreamWrapper'] = 'files_external/lib/streamwrapper.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\FTP'] = 'files_external/lib/ftp.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\OwnCloud'] = 'files_external/lib/owncloud.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\Google'] = 'files_external/lib/google.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\Swift'] = 'files_external/lib/swift.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\SMB'] = 'files_external/lib/smb.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\SMB_OC'] = 'files_external/lib/smb_oc.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\AmazonS3'] = 'files_external/lib/amazons3.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\Dropbox'] = 'files_external/lib/dropbox.php';\nOC::$CLASSPATH['OC\\Files\\Storage\\SFTP'] = 'files_external/lib/sftp.php';\nOC::$CLASSPATH['OC_Mount_Config'] = 'files_external/lib/config.php';\n```\n\nNow the question is, what happens if we try to rename the storage/cache backends: @icewind1991 \n\nAlso both use `OCA\\Files\\External` / `OCA\\Files\\Share` instead of `OCA\\Files_External` / `OCA\\Files_Sharing` for some classes, that should simply be renamed:\n\n``` php\nOC::$CLASSPATH['OCA\\Files\\Share\\Api'] = 'files_sharing/lib/api.php';\nOC::$CLASSPATH['OCA\\Files\\Share\\Maintainer'] = 'files_sharing/lib/maintainer.php';\nOC::$CLASSPATH['OCA\\Files\\Share\\Proxy'] = 'files_sharing/lib/proxy.php';\n\nOC::$CLASSPATH['OCA\\Files\\External\\Api'] = 'files_external/lib/api.php';\n```\n"}}
{"actor":{"display_login":"DeepDiver1975"}}