{"action":"created","comment":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments/201564285","pull_request_review_id":136089559,"id":201564285,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTU2NDI4NQ==","diff_hunk":"@@ -74,10 +74,10 @@ public class CRLP_Operation_SVC {\n         // Get the Date value from the appropriate object. There should always be a date!\n         // It's a LOT faster the use the actual field name to retrieve the date than to use .get(fieldName).\n         // Since the Date is almost always the CloseDate field, hardcoding this performance tweak.\n-        SObject dateSObject = detailSObject;\n         if (rollup.dateObject == oppObjectName && dateField == 'CloseDate') {","path":"src/classes/CRLP_Operation_SVC.cls","position":5,"original_position":5,"commit_id":"32ec2cb9b181a11e49f72d327a6f4d7e40f4f0a1","original_commit_id":"32ec2cb9b181a11e49f72d327a6f4d7e40f4f0a1","user":{"login":"kofijohnson","id":10543596,"node_id":"MDQ6VXNlcjEwNTQzNTk2","avatar_url":"https://avatars3.githubusercontent.com/u/10543596?v=4","gravatar_id":"","url":"https://api.github.com/users/kofijohnson","html_url":"https://github.com/kofijohnson","followers_url":"https://api.github.com/users/kofijohnson/followers","following_url":"https://api.github.com/users/kofijohnson/following{/other_user}","gists_url":"https://api.github.com/users/kofijohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/kofijohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofijohnson/subscriptions","organizations_url":"https://api.github.com/users/kofijohnson/orgs","repos_url":"https://api.github.com/users/kofijohnson/repos","events_url":"https://api.github.com/users/kofijohnson/events{/privacy}","received_events_url":"https://api.github.com/users/kofijohnson/received_events","type":"User","site_admin":false},"body":"@randi274, Do we need this if block here. We can remove the lines 77-80 and make the if block on line 80 simpler:\r\nif (dateField != null && dateSObject.get(dateField) != null)","created_at":"2018-07-11T04:50:32Z","updated_at":"2018-07-11T04:58:23Z","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3412#discussion_r201564285","pull_request_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments/201564285"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3412#discussion_r201564285"},"pull_request":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412"}}},"pull_request":{"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412","id":199757584,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzU3NTg0","html_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3412","diff_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3412.diff","patch_url":"https://github.com/SalesforceFoundation/Cumulus/pull/3412.patch","issue_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3412","number":3412,"state":"open","locked":false,"title":"Feature/rollups  invalid field date bug","user":{"login":"randi274","id":9795193,"node_id":"MDQ6VXNlcjk3OTUxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/9795193?v=4","gravatar_id":"","url":"https://api.github.com/users/randi274","html_url":"https://github.com/randi274","followers_url":"https://api.github.com/users/randi274/followers","following_url":"https://api.github.com/users/randi274/following{/other_user}","gists_url":"https://api.github.com/users/randi274/gists{/gist_id}","starred_url":"https://api.github.com/users/randi274/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randi274/subscriptions","organizations_url":"https://api.github.com/users/randi274/orgs","repos_url":"https://api.github.com/users/randi274/repos","events_url":"https://api.github.com/users/randi274/events{/privacy}","received_events_url":"https://api.github.com/users/randi274/received_events","type":"User","site_admin":false},"body":"# Critical Changes\r\n\r\n# Changes\r\n\r\n# Issues Closed\r\n- Fix #3395 \r\n# New Metadata\r\n\r\n# Deleted Metadata\r\n","created_at":"2018-07-06T14:05:25Z","updated_at":"2018-07-11T04:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94a6e1dd24c532131578aa5564bff696c3531fd7","assignee":{"login":"kofijohnson","id":10543596,"node_id":"MDQ6VXNlcjEwNTQzNTk2","avatar_url":"https://avatars3.githubusercontent.com/u/10543596?v=4","gravatar_id":"","url":"https://api.github.com/users/kofijohnson","html_url":"https://github.com/kofijohnson","followers_url":"https://api.github.com/users/kofijohnson/followers","following_url":"https://api.github.com/users/kofijohnson/following{/other_user}","gists_url":"https://api.github.com/users/kofijohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/kofijohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofijohnson/subscriptions","organizations_url":"https://api.github.com/users/kofijohnson/orgs","repos_url":"https://api.github.com/users/kofijohnson/repos","events_url":"https://api.github.com/users/kofijohnson/events{/privacy}","received_events_url":"https://api.github.com/users/kofijohnson/received_events","type":"User","site_admin":false},"assignees":[{"login":"kofijohnson","id":10543596,"node_id":"MDQ6VXNlcjEwNTQzNTk2","avatar_url":"https://avatars3.githubusercontent.com/u/10543596?v=4","gravatar_id":"","url":"https://api.github.com/users/kofijohnson","html_url":"https://github.com/kofijohnson","followers_url":"https://api.github.com/users/kofijohnson/followers","following_url":"https://api.github.com/users/kofijohnson/following{/other_user}","gists_url":"https://api.github.com/users/kofijohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/kofijohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofijohnson/subscriptions","organizations_url":"https://api.github.com/users/kofijohnson/orgs","repos_url":"https://api.github.com/users/kofijohnson/repos","events_url":"https://api.github.com/users/kofijohnson/events{/privacy}","received_events_url":"https://api.github.com/users/kofijohnson/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dgamboni","id":3886084,"node_id":"MDQ6VXNlcjM4ODYwODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3886084?v=4","gravatar_id":"","url":"https://api.github.com/users/dgamboni","html_url":"https://github.com/dgamboni","followers_url":"https://api.github.com/users/dgamboni/followers","following_url":"https://api.github.com/users/dgamboni/following{/other_user}","gists_url":"https://api.github.com/users/dgamboni/gists{/gist_id}","starred_url":"https://api.github.com/users/dgamboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgamboni/subscriptions","organizations_url":"https://api.github.com/users/dgamboni/orgs","repos_url":"https://api.github.com/users/dgamboni/repos","events_url":"https://api.github.com/users/dgamboni/events{/privacy}","received_events_url":"https://api.github.com/users/dgamboni/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412/commits","review_comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412/comments","review_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3412/comments","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/32ec2cb9b181a11e49f72d327a6f4d7e40f4f0a1","head":{"label":"SalesforceFoundation:feature/rollups__invalid-field-date-bug","ref":"feature/rollups__invalid-field-date-bug","sha":"32ec2cb9b181a11e49f72d327a6f4d7e40f4f0a1","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-07-10T23:25:51Z","pushed_at":"2018-07-10T23:56:01Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":90717,"stargazers_count":233,"watchers_count":233,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":197,"open_issues":322,"watchers":233,"default_branch":"master"}},"base":{"label":"SalesforceFoundation:feature/rollups","ref":"feature/rollups","sha":"b3d917cad7af9d3ba87b85afc924155aaec2b4ca","user":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":13108586,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwODU4Ng==","name":"Cumulus","full_name":"SalesforceFoundation/Cumulus","owner":{"login":"SalesforceFoundation","id":972305,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MjMwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/972305?v=4","gravatar_id":"","url":"https://api.github.com/users/SalesforceFoundation","html_url":"https://github.com/SalesforceFoundation","followers_url":"https://api.github.com/users/SalesforceFoundation/followers","following_url":"https://api.github.com/users/SalesforceFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SalesforceFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SalesforceFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SalesforceFoundation/subscriptions","organizations_url":"https://api.github.com/users/SalesforceFoundation/orgs","repos_url":"https://api.github.com/users/SalesforceFoundation/repos","events_url":"https://api.github.com/users/SalesforceFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SalesforceFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SalesforceFoundation/Cumulus","description":"The current version of the Salesforce.org Nonprofit Success Pack","fork":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus","forks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/forks","keys_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/teams","hooks_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/hooks","issue_events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/events","assignees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/tags","blobs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/languages","stargazers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/stargazers","contributors_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contributors","subscribers_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscribers","subscription_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/subscription","commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/merges","archive_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/downloads","issues_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/labels{/name}","releases_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/deployments","created_at":"2013-09-25T23:56:49Z","updated_at":"2018-07-10T23:25:51Z","pushed_at":"2018-07-10T23:56:01Z","git_url":"git://github.com/SalesforceFoundation/Cumulus.git","ssh_url":"git@github.com:SalesforceFoundation/Cumulus.git","clone_url":"https://github.com/SalesforceFoundation/Cumulus.git","svn_url":"https://github.com/SalesforceFoundation/Cumulus","homepage":"http://www.salesforce.org/nonprofit/nonprofit-success-pack/","size":90717,"stargazers_count":233,"watchers_count":233,"language":"Apex","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":197,"open_issues":322,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412"},"html":{"href":"https://github.com/SalesforceFoundation/Cumulus/pull/3412"},"issue":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3412"},"comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/issues/3412/comments"},"review_comments":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412/comments"},"review_comment":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/pulls/3412/commits"},"statuses":{"href":"https://api.github.com/repos/SalesforceFoundation/Cumulus/statuses/32ec2cb9b181a11e49f72d327a6f4d7e40f4f0a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kofijohnson"}}