{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/virtualenv/pulls/comments/239475623","pull_request_review_id":182268091,"id":239475623,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTQ3NTYyMw==","diff_hunk":"@@ -332,3 +334,38 @@ def test_relative_symlink(tmpdir):\n     shutil.rmtree(workdir)\n \n     assert os.path.exists(lib64)\n+\n+\n+def test_missing_certifi_pem(tmpdir):\n+    \"\"\"Make sure that we can still create virtual environment if pip is\n+    patched to not use certifi's cacert.pem and the file is removed.\n+    This can happen if pip is packaged by Linux distributions.\"\"\"\n+    tests_dir = os.path.dirname(__file__)\n+    support_original = os.path.join(tests_dir, \"../src/virtualenv_support/\")","path":"tests/test_virtualenv.py","position":22,"original_position":22,"commit_id":"4a5e1d225d33a644bbee20108ba8a6b44fd078e0","original_commit_id":"4a5e1d225d33a644bbee20108ba8a6b44fd078e0","user":{"login":"gaborbernat","id":690238,"node_id":"MDQ6VXNlcjY5MDIzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/690238?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborbernat","html_url":"https://github.com/gaborbernat","followers_url":"https://api.github.com/users/gaborbernat/followers","following_url":"https://api.github.com/users/gaborbernat/following{/other_user}","gists_url":"https://api.github.com/users/gaborbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborbernat/subscriptions","organizations_url":"https://api.github.com/users/gaborbernat/orgs","repos_url":"https://api.github.com/users/gaborbernat/repos","events_url":"https://api.github.com/users/gaborbernat/events{/privacy}","received_events_url":"https://api.github.com/users/gaborbernat/received_events","type":"User","site_admin":false},"body":"this most certainly will fail on Windows; and indeed it has https://dev.azure.com/pypa/virtualenv/_build/results?buildId=3008 (not sure why the build does not show up here as Github check, although the job did start, you can see new jobs at https://dev.azure.com/pypa/virtualenv/_build?definitionId=11&_a=summary)","created_at":"2018-12-06T14:37:06Z","updated_at":"2018-12-06T14:37:10Z","html_url":"https://github.com/pypa/virtualenv/pull/1252#discussion_r239475623","pull_request_url":"https://api.github.com/repos/pypa/virtualenv/pulls/1252","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/comments/239475623"},"html":{"href":"https://github.com/pypa/virtualenv/pull/1252#discussion_r239475623"},"pull_request":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1252"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/virtualenv/pulls/1252","id":236211185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjExMTg1","html_url":"https://github.com/pypa/virtualenv/pull/1252","diff_url":"https://github.com/pypa/virtualenv/pull/1252.diff","patch_url":"https://github.com/pypa/virtualenv/pull/1252.patch","issue_url":"https://api.github.com/repos/pypa/virtualenv/issues/1252","number":1252,"state":"open","locked":false,"title":"Don't fail on missing pip/certifi's cacert.pem","user":{"login":"hroncok","id":2401856,"node_id":"MDQ6VXNlcjI0MDE4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2401856?v=4","gravatar_id":"","url":"https://api.github.com/users/hroncok","html_url":"https://github.com/hroncok","followers_url":"https://api.github.com/users/hroncok/followers","following_url":"https://api.github.com/users/hroncok/following{/other_user}","gists_url":"https://api.github.com/users/hroncok/gists{/gist_id}","starred_url":"https://api.github.com/users/hroncok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroncok/subscriptions","organizations_url":"https://api.github.com/users/hroncok/orgs","repos_url":"https://api.github.com/users/hroncok/repos","events_url":"https://api.github.com/users/hroncok/events{/privacy}","received_events_url":"https://api.github.com/users/hroncok/received_events","type":"User","site_admin":false},"body":"See https://github.com/pypa/pip/blob/master/src/pip/_vendor/README.rst\r\n\r\nIt is acceptable to remove the pip/_vendor/requests/cacert.pem file from pip\r\n\r\nVirtualenv should not error on that","created_at":"2018-12-05T15:15:27Z","updated_at":"2018-12-06T14:37:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95504243a01be3dc205f0d84363e1bcb8d44ce9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/virtualenv/pulls/1252/commits","review_comments_url":"https://api.github.com/repos/pypa/virtualenv/pulls/1252/comments","review_comment_url":"https://api.github.com/repos/pypa/virtualenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/virtualenv/issues/1252/comments","statuses_url":"https://api.github.com/repos/pypa/virtualenv/statuses/4a5e1d225d33a644bbee20108ba8a6b44fd078e0","head":{"label":"hroncok:nopem","ref":"nopem","sha":"4a5e1d225d33a644bbee20108ba8a6b44fd078e0","user":{"login":"hroncok","id":2401856,"node_id":"MDQ6VXNlcjI0MDE4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2401856?v=4","gravatar_id":"","url":"https://api.github.com/users/hroncok","html_url":"https://github.com/hroncok","followers_url":"https://api.github.com/users/hroncok/followers","following_url":"https://api.github.com/users/hroncok/following{/other_user}","gists_url":"https://api.github.com/users/hroncok/gists{/gist_id}","starred_url":"https://api.github.com/users/hroncok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroncok/subscriptions","organizations_url":"https://api.github.com/users/hroncok/orgs","repos_url":"https://api.github.com/users/hroncok/repos","events_url":"https://api.github.com/users/hroncok/events{/privacy}","received_events_url":"https://api.github.com/users/hroncok/received_events","type":"User","site_admin":false},"repo":{"id":160536324,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1MzYzMjQ=","name":"virtualenv","full_name":"hroncok/virtualenv","private":false,"owner":{"login":"hroncok","id":2401856,"node_id":"MDQ6VXNlcjI0MDE4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2401856?v=4","gravatar_id":"","url":"https://api.github.com/users/hroncok","html_url":"https://github.com/hroncok","followers_url":"https://api.github.com/users/hroncok/followers","following_url":"https://api.github.com/users/hroncok/following{/other_user}","gists_url":"https://api.github.com/users/hroncok/gists{/gist_id}","starred_url":"https://api.github.com/users/hroncok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hroncok/subscriptions","organizations_url":"https://api.github.com/users/hroncok/orgs","repos_url":"https://api.github.com/users/hroncok/repos","events_url":"https://api.github.com/users/hroncok/events{/privacy}","received_events_url":"https://api.github.com/users/hroncok/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hroncok/virtualenv","description":"Virtual Python Environment builder","fork":true,"url":"https://api.github.com/repos/hroncok/virtualenv","forks_url":"https://api.github.com/repos/hroncok/virtualenv/forks","keys_url":"https://api.github.com/repos/hroncok/virtualenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hroncok/virtualenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hroncok/virtualenv/teams","hooks_url":"https://api.github.com/repos/hroncok/virtualenv/hooks","issue_events_url":"https://api.github.com/repos/hroncok/virtualenv/issues/events{/number}","events_url":"https://api.github.com/repos/hroncok/virtualenv/events","assignees_url":"https://api.github.com/repos/hroncok/virtualenv/assignees{/user}","branches_url":"https://api.github.com/repos/hroncok/virtualenv/branches{/branch}","tags_url":"https://api.github.com/repos/hroncok/virtualenv/tags","blobs_url":"https://api.github.com/repos/hroncok/virtualenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hroncok/virtualenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hroncok/virtualenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/hroncok/virtualenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hroncok/virtualenv/statuses/{sha}","languages_url":"https://api.github.com/repos/hroncok/virtualenv/languages","stargazers_url":"https://api.github.com/repos/hroncok/virtualenv/stargazers","contributors_url":"https://api.github.com/repos/hroncok/virtualenv/contributors","subscribers_url":"https://api.github.com/repos/hroncok/virtualenv/subscribers","subscription_url":"https://api.github.com/repos/hroncok/virtualenv/subscription","commits_url":"https://api.github.com/repos/hroncok/virtualenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/hroncok/virtualenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/hroncok/virtualenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/hroncok/virtualenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/hroncok/virtualenv/contents/{+path}","compare_url":"https://api.github.com/repos/hroncok/virtualenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hroncok/virtualenv/merges","archive_url":"https://api.github.com/repos/hroncok/virtualenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hroncok/virtualenv/downloads","issues_url":"https://api.github.com/repos/hroncok/virtualenv/issues{/number}","pulls_url":"https://api.github.com/repos/hroncok/virtualenv/pulls{/number}","milestones_url":"https://api.github.com/repos/hroncok/virtualenv/milestones{/number}","notifications_url":"https://api.github.com/repos/hroncok/virtualenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hroncok/virtualenv/labels{/name}","releases_url":"https://api.github.com/repos/hroncok/virtualenv/releases{/id}","deployments_url":"https://api.github.com/repos/hroncok/virtualenv/deployments","created_at":"2018-12-05T15:11:22Z","updated_at":"2018-12-05T15:11:24Z","pushed_at":"2018-12-06T14:33:43Z","git_url":"git://github.com/hroncok/virtualenv.git","ssh_url":"git@github.com:hroncok/virtualenv.git","clone_url":"https://github.com/hroncok/virtualenv.git","svn_url":"https://github.com/hroncok/virtualenv","homepage":"virtualenv.pypa.io","size":63123,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"75f3a2b7bb9d5f943ade6c2943ee6228a62a090e","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446474,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NDc0","name":"virtualenv","full_name":"pypa/virtualenv","private":false,"owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypa/virtualenv","description":"Virtual Python Environment builder","fork":false,"url":"https://api.github.com/repos/pypa/virtualenv","forks_url":"https://api.github.com/repos/pypa/virtualenv/forks","keys_url":"https://api.github.com/repos/pypa/virtualenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/virtualenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/virtualenv/teams","hooks_url":"https://api.github.com/repos/pypa/virtualenv/hooks","issue_events_url":"https://api.github.com/repos/pypa/virtualenv/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/virtualenv/events","assignees_url":"https://api.github.com/repos/pypa/virtualenv/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/virtualenv/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/virtualenv/tags","blobs_url":"https://api.github.com/repos/pypa/virtualenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/virtualenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/virtualenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/virtualenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/virtualenv/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/virtualenv/languages","stargazers_url":"https://api.github.com/repos/pypa/virtualenv/stargazers","contributors_url":"https://api.github.com/repos/pypa/virtualenv/contributors","subscribers_url":"https://api.github.com/repos/pypa/virtualenv/subscribers","subscription_url":"https://api.github.com/repos/pypa/virtualenv/subscription","commits_url":"https://api.github.com/repos/pypa/virtualenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/virtualenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/virtualenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/virtualenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/virtualenv/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/virtualenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/virtualenv/merges","archive_url":"https://api.github.com/repos/pypa/virtualenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/virtualenv/downloads","issues_url":"https://api.github.com/repos/pypa/virtualenv/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/virtualenv/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/virtualenv/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/virtualenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/virtualenv/labels{/name}","releases_url":"https://api.github.com/repos/pypa/virtualenv/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/virtualenv/deployments","created_at":"2011-03-06T14:33:27Z","updated_at":"2018-12-06T01:04:48Z","pushed_at":"2018-12-06T14:33:45Z","git_url":"git://github.com/pypa/virtualenv.git","ssh_url":"git@github.com:pypa/virtualenv.git","clone_url":"https://github.com/pypa/virtualenv.git","svn_url":"https://github.com/pypa/virtualenv","homepage":"virtualenv.pypa.io","size":63156,"stargazers_count":2864,"watchers_count":2864,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":697,"mirror_url":null,"archived":false,"open_issues_count":404,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":697,"open_issues":404,"watchers":2864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1252"},"html":{"href":"https://github.com/pypa/virtualenv/pull/1252"},"issue":{"href":"https://api.github.com/repos/pypa/virtualenv/issues/1252"},"comments":{"href":"https://api.github.com/repos/pypa/virtualenv/issues/1252/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1252/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/virtualenv/pulls/1252/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/virtualenv/statuses/4a5e1d225d33a644bbee20108ba8a6b44fd078e0"}},"author_association":"NONE"}}
{"actor":{"display_login":"gaborbernat"}}