{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20425","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20425/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20425/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20425/events","html_url":"https://github.com/nodejs/node/pull/20425","id":318920212,"number":20425,"title":"n-api: document that native strings are copied","user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars2.githubusercontent.com/u/976081?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"labels":[{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"eb6420","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":574036893,"url":"https://api.github.com/repos/nodejs/node/labels/n-api","name":"n-api","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-30T14:55:40Z","updated_at":"2018-04-30T15:32:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20425","html_url":"https://github.com/nodejs/node/pull/20425","diff_url":"https://github.com/nodejs/node/pull/20425.diff","patch_url":"https://github.com/nodejs/node/pull/20425.patch"},"body":"Mention that a copy is made of the native string by the\r\nnapi_create_string_* APIs.\r\n\r\nFixes: https://github.com/nodejs/abi-stable-node/issues/304\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/385435509","html_url":"https://github.com/nodejs/node/pull/20425#issuecomment-385435509","issue_url":"https://api.github.com/repos/nodejs/node/issues/20425","id":385435509,"user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars1.githubusercontent.com/u/10393198?v=4","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T15:32:37Z","updated_at":"2018-04-30T15:32:37Z","author_association":"MEMBER","body":"CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/633/"}}
{"actor":{"display_login":"vsemozhetbyt"}}