{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/173682383","pull_request_review_id":102908343,"id":173682383,"diff_hunk":"@@ -76,10 +79,10 @@ protected override void InitializeConfiguration()\n                     new BaseMergedExtractor(new PortugueseMergedExtractorConfiguration(options))));\r\n \r\n             RegisterModel<DateTimeModel>(\r\n-                Culture.German,\r\n-                (options) => new DateTimeModel(\r\n-                    new BaseMergedParser(new GermanMergedParserConfiguration(options)),\r\n-                    new BaseMergedExtractor(new GermanMergedExtractorConfiguration(options))));\r\n+              Culture.Italian,\r","path":".NET/Microsoft.Recognizers.Text.DateTime/DateTimeRecognizer.cs","position":18,"original_position":18,"commit_id":"cd3b7cc72a8f75dfa4d6fbba7161fe2cfabb1425","original_commit_id":"cd3b7cc72a8f75dfa4d6fbba7161fe2cfabb1425","user":{"login":"tellarin","id":628614,"avatar_url":"https://avatars0.githubusercontent.com/u/628614?v=4","gravatar_id":"","url":"https://api.github.com/users/tellarin","html_url":"https://github.com/tellarin","followers_url":"https://api.github.com/users/tellarin/followers","following_url":"https://api.github.com/users/tellarin/following{/other_user}","gists_url":"https://api.github.com/users/tellarin/gists{/gist_id}","starred_url":"https://api.github.com/users/tellarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tellarin/subscriptions","organizations_url":"https://api.github.com/users/tellarin/orgs","repos_url":"https://api.github.com/users/tellarin/repos","events_url":"https://api.github.com/users/tellarin/events{/privacy}","received_events_url":"https://api.github.com/users/tellarin/received_events","type":"User","site_admin":false},"body":"In order to merge PRs for new languages, they should not be registered at the recognizer level until all their tests pass (or the majority, if there's already enough value-add).\r\nPlease remove the registration for now.","created_at":"2018-03-12T02:10:03Z","updated_at":"2018-03-12T02:15:21Z","html_url":"https://github.com/Microsoft/Recognizers-Text/pull/397#discussion_r173682383","pull_request_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/173682383"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/397#discussion_r173682383"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397","id":174239268,"html_url":"https://github.com/Microsoft/Recognizers-Text/pull/397","diff_url":"https://github.com/Microsoft/Recognizers-Text/pull/397.diff","patch_url":"https://github.com/Microsoft/Recognizers-Text/pull/397.patch","issue_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/397","number":397,"state":"open","locked":false,"title":"Italian Language update","user":{"login":"maurobennici","id":7203292,"avatar_url":"https://avatars3.githubusercontent.com/u/7203292?v=4","gravatar_id":"","url":"https://api.github.com/users/maurobennici","html_url":"https://github.com/maurobennici","followers_url":"https://api.github.com/users/maurobennici/followers","following_url":"https://api.github.com/users/maurobennici/following{/other_user}","gists_url":"https://api.github.com/users/maurobennici/gists{/gist_id}","starred_url":"https://api.github.com/users/maurobennici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurobennici/subscriptions","organizations_url":"https://api.github.com/users/maurobennici/orgs","repos_url":"https://api.github.com/users/maurobennici/repos","events_url":"https://api.github.com/users/maurobennici/events{/privacy}","received_events_url":"https://api.github.com/users/maurobennici/received_events","type":"User","site_admin":false},"body":"The Italian extractor and parser are now updated.\r\nAll the tests are translated following the French examples.","created_at":"2018-03-11T20:01:31Z","updated_at":"2018-03-12T02:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b4145e56bc326d8f19f4c9dd081a7a8e6d0fe7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397/commits","review_comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397/comments","review_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/397/comments","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/cd3b7cc72a8f75dfa4d6fbba7161fe2cfabb1425","head":{"label":"maurobennici:master","ref":"master","sha":"cd3b7cc72a8f75dfa4d6fbba7161fe2cfabb1425","user":{"login":"maurobennici","id":7203292,"avatar_url":"https://avatars3.githubusercontent.com/u/7203292?v=4","gravatar_id":"","url":"https://api.github.com/users/maurobennici","html_url":"https://github.com/maurobennici","followers_url":"https://api.github.com/users/maurobennici/followers","following_url":"https://api.github.com/users/maurobennici/following{/other_user}","gists_url":"https://api.github.com/users/maurobennici/gists{/gist_id}","starred_url":"https://api.github.com/users/maurobennici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurobennici/subscriptions","organizations_url":"https://api.github.com/users/maurobennici/orgs","repos_url":"https://api.github.com/users/maurobennici/repos","events_url":"https://api.github.com/users/maurobennici/events{/privacy}","received_events_url":"https://api.github.com/users/maurobennici/received_events","type":"User","site_admin":false},"repo":{"id":121363032,"name":"Recognizers-Text","full_name":"maurobennici/Recognizers-Text","owner":{"login":"maurobennici","id":7203292,"avatar_url":"https://avatars3.githubusercontent.com/u/7203292?v=4","gravatar_id":"","url":"https://api.github.com/users/maurobennici","html_url":"https://github.com/maurobennici","followers_url":"https://api.github.com/users/maurobennici/followers","following_url":"https://api.github.com/users/maurobennici/following{/other_user}","gists_url":"https://api.github.com/users/maurobennici/gists{/gist_id}","starred_url":"https://api.github.com/users/maurobennici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurobennici/subscriptions","organizations_url":"https://api.github.com/users/maurobennici/orgs","repos_url":"https://api.github.com/users/maurobennici/repos","events_url":"https://api.github.com/users/maurobennici/events{/privacy}","received_events_url":"https://api.github.com/users/maurobennici/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maurobennici/Recognizers-Text","description":"Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, and date/time expressed in multiple languages (Chinese, English, French, Spanish, and Portuguese. Partial support for German). Contributions are greatly welcome! Packages are available at https://www.nuget.org/profiles/Recognizers.Text and https://www.npmjs.com/~recognizers.text","fork":true,"url":"https://api.github.com/repos/maurobennici/Recognizers-Text","forks_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/maurobennici/Recognizers-Text/deployments","created_at":"2018-02-13T09:27:10Z","updated_at":"2018-02-13T09:27:14Z","pushed_at":"2018-03-11T20:37:18Z","git_url":"git://github.com/maurobennici/Recognizers-Text.git","ssh_url":"git@github.com:maurobennici/Recognizers-Text.git","clone_url":"https://github.com/maurobennici/Recognizers-Text.git","svn_url":"https://github.com/maurobennici/Recognizers-Text","homepage":"","size":8112,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"ad4ff9ecf98ac7bfa44592624a862823e682b968","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":88544417,"name":"Recognizers-Text","full_name":"Microsoft/Recognizers-Text","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/Recognizers-Text","description":"Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, and date/time expressed in multiple languages (Chinese, English, French, Spanish, and Portuguese. Partial support for German). Contributions are greatly welcome! Packages are available at https://www.nuget.org/profiles/Recognizers.Text and https://www.npmjs.com/~recognizers.text","fork":false,"url":"https://api.github.com/repos/Microsoft/Recognizers-Text","forks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/deployments","created_at":"2017-04-17T19:45:47Z","updated_at":"2018-03-11T14:17:16Z","pushed_at":"2018-03-11T20:37:20Z","git_url":"git://github.com/Microsoft/Recognizers-Text.git","ssh_url":"git@github.com:Microsoft/Recognizers-Text.git","clone_url":"https://github.com/Microsoft/Recognizers-Text.git","svn_url":"https://github.com/Microsoft/Recognizers-Text","homepage":"","size":7968,"stargazers_count":108,"watchers_count":108,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":61,"open_issues":39,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/397"},"issue":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/397"},"comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/cd3b7cc72a8f75dfa4d6fbba7161fe2cfabb1425"}},"author_association":"NONE"}}
{"actor":{"display_login":"tellarin"}}