{"action":"created","issue":{"url":"https://api.github.com/repos/wiremod/wire/issues/1533","repository_url":"https://api.github.com/repos/wiremod/wire","labels_url":"https://api.github.com/repos/wiremod/wire/issues/1533/labels{/name}","comments_url":"https://api.github.com/repos/wiremod/wire/issues/1533/comments","events_url":"https://api.github.com/repos/wiremod/wire/issues/1533/events","html_url":"https://github.com/wiremod/wire/pull/1533","id":291157214,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0ODA5NzQ0","number":1533,"title":"Update Von from v1.1.0 -> v1.3.4","user":{"login":"Nebual","id":1627867,"node_id":"MDQ6VXNlcjE2Mjc4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1627867?v=4","gravatar_id":"","url":"https://api.github.com/users/Nebual","html_url":"https://github.com/Nebual","followers_url":"https://api.github.com/users/Nebual/followers","following_url":"https://api.github.com/users/Nebual/following{/other_user}","gists_url":"https://api.github.com/users/Nebual/gists{/gist_id}","starred_url":"https://api.github.com/users/Nebual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nebual/subscriptions","organizations_url":"https://api.github.com/users/Nebual/orgs","repos_url":"https://api.github.com/users/Nebual/repos","events_url":"https://api.github.com/users/Nebual/events{/privacy}","received_events_url":"https://api.github.com/users/Nebual/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-24T10:30:02Z","updated_at":"2018-08-17T21:04:46Z","closed_at":"2018-08-17T20:32:43Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wiremod/wire/pulls/1533","html_url":"https://github.com/wiremod/wire/pull/1533","diff_url":"https://github.com/wiremod/wire/pull/1533.diff","patch_url":"https://github.com/wiremod/wire/pull/1533.patch"},"body":"Probably backwards compatible deserialization for Wire's purposes. I don't see anything in the deserialization code that should cause us any BC issues - there's a new shorter string syntax, but the old one's still there. A new nested table reference syntax, not having it won't hurt. Repeated numbers can now be stored shorter, but it still seems to parse the longer ones fine. I think it previously stored some Player/Vehicle/Weapon/Entities as the wrong type, but E2 would always be storing/retrieving plain Entities anyway, so shouldn't be an issue?\r\n\r\nMy test E2 of trying to decode/encode\r\n```\r\nvonEncode(table(5,6,entity(1),\"hey\", \"this has a \\\" quote\", table(7, owner())))\r\n```\r\nbetween versions works fine going from old -> new.\r\nWould recommend someone who's actually stored lots of stuff with von tries decoding it with this (you can easily switch to new von by checking out this branch, and then running in console `lua_openscript wire/von.lua`)\r\nFixes #923"},"comment":{"url":"https://api.github.com/repos/wiremod/wire/issues/comments/413987909","html_url":"https://github.com/wiremod/wire/pull/1533#issuecomment-413987909","issue_url":"https://api.github.com/repos/wiremod/wire/issues/1533","id":413987909,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzk4NzkwOQ==","user":{"login":"oldmud0","id":5247009,"node_id":"MDQ6VXNlcjUyNDcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5247009?v=4","gravatar_id":"","url":"https://api.github.com/users/oldmud0","html_url":"https://github.com/oldmud0","followers_url":"https://api.github.com/users/oldmud0/followers","following_url":"https://api.github.com/users/oldmud0/following{/other_user}","gists_url":"https://api.github.com/users/oldmud0/gists{/gist_id}","starred_url":"https://api.github.com/users/oldmud0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldmud0/subscriptions","organizations_url":"https://api.github.com/users/oldmud0/orgs","repos_url":"https://api.github.com/users/oldmud0/repos","events_url":"https://api.github.com/users/oldmud0/events{/privacy}","received_events_url":"https://api.github.com/users/oldmud0/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T21:04:46Z","updated_at":"2018-08-17T21:04:46Z","author_association":"NONE","body":"If they're potentially breaking changes, why wasn't this a major version bump? ([oh, this question was already brought up 3 years ago...](https://github.com/vercas/vON/commit/1de75ea67cb6560efd25913b03657a06ad14bf0b#commitcomment-15290949))"}}
{"actor":{"display_login":"oldmud0"}}