{"action":"closed","issue":{"url":"https://api.github.com/repos/henrypp/simplewall/issues/135","repository_url":"https://api.github.com/repos/henrypp/simplewall","labels_url":"https://api.github.com/repos/henrypp/simplewall/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/henrypp/simplewall/issues/135/comments","events_url":"https://api.github.com/repos/henrypp/simplewall/issues/135/events","html_url":"https://github.com/henrypp/simplewall/issues/135","id":302364615,"number":135,"title":"[UI] 2.2 Beta - Consider not boldening \"simplewall.exe\" (self) in the IDC_LISTVIEW","user":{"login":"xEBFE","id":33581353,"avatar_url":"https://avatars1.githubusercontent.com/u/33581353?v=4","gravatar_id":"","url":"https://api.github.com/users/xEBFE","html_url":"https://github.com/xEBFE","followers_url":"https://api.github.com/users/xEBFE/followers","following_url":"https://api.github.com/users/xEBFE/following{/other_user}","gists_url":"https://api.github.com/users/xEBFE/gists{/gist_id}","starred_url":"https://api.github.com/users/xEBFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xEBFE/subscriptions","organizations_url":"https://api.github.com/users/xEBFE/orgs","repos_url":"https://api.github.com/users/xEBFE/repos","events_url":"https://api.github.com/users/xEBFE/events{/privacy}","received_events_url":"https://api.github.com/users/xEBFE/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-05T16:20:20Z","updated_at":"2018-03-14T09:26:27Z","closed_at":"2018-03-14T09:26:27Z","author_association":"NONE","body":"@henrypp Thank you for addressing #106 in a fair way.\r\nI'm fine with simplewall automatically whitelisting itself if it's not on the \"Allowed apps\" or \"Blocked apps\":\r\n```\r\n3097\t_app_addapplication (hwnd, app.GetBinaryPath (), 0, false, (app.ConfigGet (L\"Mode\", ModeWhitelist).AsUint () == ModeWhitelist) ? true : false, true);\r\n```\r\nAnd I'm fine with it exempting itself from deletion since we can toggle it between being Allowed/Blocked.\r\n```\r\n8335\tapps_undelete[config.myhash] = true; // disable deletion for me ;)\r\n```\r\nThese two changes are fair and sufficient but I don't agree with simplewall boldening itself in the IDC_LISTVIEW. It seems to just distract from the simplistic UI and looks out of place in the IDC_LISTVIEW.\r\n```\r\n1516\t\tif (hdc && hash == config.myhash && config.hfont_bold)\r\n1517\t\t\tSelectObject (hdc, config.hfont_bold);\r\n```\r\nI hope you consider not boldening it to look consistent and conform to the display of the other items in the IDC_LISTVIEW."}}
{"actor":{"display_login":"henrypp"}}