{"action":"created","issue":{"url":"https://api.github.com/repos/herrvigg/qtranslate-x/issues/78","repository_url":"https://api.github.com/repos/herrvigg/qtranslate-x","labels_url":"https://api.github.com/repos/herrvigg/qtranslate-x/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/herrvigg/qtranslate-x/issues/78/comments","events_url":"https://api.github.com/repos/herrvigg/qtranslate-x/issues/78/events","html_url":"https://github.com/herrvigg/qtranslate-x/issues/78","id":334228841,"node_id":"MDU6SXNzdWUzMzQyMjg4NDE=","number":78,"title":"[CLOSED] qtranslate-x-2.8 + qtranslate-slugs is broken","user":{"login":"herrvigg","id":19155375,"node_id":"MDQ6VXNlcjE5MTU1Mzc1","avatar_url":"https://avatars2.githubusercontent.com/u/19155375?v=4","gravatar_id":"","url":"https://api.github.com/users/herrvigg","html_url":"https://github.com/herrvigg","followers_url":"https://api.github.com/users/herrvigg/followers","following_url":"https://api.github.com/users/herrvigg/following{/other_user}","gists_url":"https://api.github.com/users/herrvigg/gists{/gist_id}","starred_url":"https://api.github.com/users/herrvigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrvigg/subscriptions","organizations_url":"https://api.github.com/users/herrvigg/orgs","repos_url":"https://api.github.com/users/herrvigg/repos","events_url":"https://api.github.com/users/herrvigg/events{/privacy}","received_events_url":"https://api.github.com/users/herrvigg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-06-20T20:02:37Z","updated_at":"2018-06-20T20:02:47Z","closed_at":null,"author_association":"OWNER","body":"<a href=\"https://github.com/beheist\"><img src=\"https://avatars3.githubusercontent.com/u/10347669?v=4\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [beheist](https://github.com/beheist)**\n_Saturday Jan 10, 2015 at 08:10 GMT_\n_Originally opened as https://github.com/qTranslate-Team/qtranslate-x/issues/1_\n\n----\n\nGood morning John,\n\nI just upgraded my blog to qTranslate-X 2.8. After doing that, none of my posts were reachable anymore - everything resulted in 404s. When I disabled qTranslate-slugs, my posts were reachable again, so there seems something in qTranslate-X 2.8 that breaks if slugs is also used.\nThis issue has made me rethink the current approach with qTranslate-X and qTranslate slugs. I think we're running into a fundamental issue here - as long as the two plugins are separate and are thus not always tested together, issues like these will keep cropping up. Of course, it'd be possible to try and fix slugs everytime qTX gets upgraded (or the other way round), but that would lead to a lot of uncertainty and frustration for users because it's not ensured that a working combination is installed.\nSo I'd like to discuss whether you think it makes sense to include the slugs functionality in qTranslate-X itself. If you agree (and also if @LC43 doesn't see a problem with that since it's his code) I would volunteer to include that functionality. What do you think?\n\nBest regards,\nBastian\n\n"},"comment":{"url":"https://api.github.com/repos/herrvigg/qtranslate-x/issues/comments/398878277","html_url":"https://github.com/herrvigg/qtranslate-x/issues/78#issuecomment-398878277","issue_url":"https://api.github.com/repos/herrvigg/qtranslate-x/issues/78","id":398878277,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODg3ODI3Nw==","user":{"login":"herrvigg","id":19155375,"node_id":"MDQ6VXNlcjE5MTU1Mzc1","avatar_url":"https://avatars2.githubusercontent.com/u/19155375?v=4","gravatar_id":"","url":"https://api.github.com/users/herrvigg","html_url":"https://github.com/herrvigg","followers_url":"https://api.github.com/users/herrvigg/followers","following_url":"https://api.github.com/users/herrvigg/following{/other_user}","gists_url":"https://api.github.com/users/herrvigg/gists{/gist_id}","starred_url":"https://api.github.com/users/herrvigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrvigg/subscriptions","organizations_url":"https://api.github.com/users/herrvigg/orgs","repos_url":"https://api.github.com/users/herrvigg/repos","events_url":"https://api.github.com/users/herrvigg/events{/privacy}","received_events_url":"https://api.github.com/users/herrvigg/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T20:02:47Z","updated_at":"2018-06-20T20:02:47Z","author_association":"OWNER","body":"<a href=\"https://github.com/johnclause\"><img src=\"https://avatars2.githubusercontent.com/u/5491361?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [johnclause](https://github.com/johnclause)**\n_Monday Jan 12, 2015 at 17:13 GMT_\n\n----\n\nHi Pedro, I am really sorry, I get frustrated with other people changes sometimes too :) It is a period of birth and quick grow. It will stabilize after a while.\n\nOn this particular case, in fact, I did not remove it, it was not there already to begin with in zTranslate, which I started with. And it is not needed for qTranslate-X. That one was the source of main problem of original qTranslate and I felt very relieved to see it go away in zTranslate. The name of that piece was good, \"wphacks\", and \"WP hacks\" is exactly what we should not do to survive WP updates without changes. Did you know that on last WP update to 4.1 all other forks of qTranslate got broken and had to do some adjustments, except qTranslate-X, which kept working just as it was?\n\nIf you use those functions, I do not understand how did you get away so far without them? They could have been defined in other active plugin during the testing - yeah, this is how it was probably.\n\nAnyway, please, add back those on your plugin for now with `If(function_exists)` wrapper and it will be good. qTranslate-X will never need them anymore.\n\nI think it would be eventually a good idea to adjust your slug management to the same logic as it was done with title fields and apply it to \"slug\" field. We now need one \"slug\" field only and Language Switching Buttons will put value needed per language there. I understand that this is a much bigger change for -slug, and we do not need to do it right away. I believe this would belong to my plate, and I can get busy with this after the things are stabilized.\n\n"}}
{"actor":{"display_login":"herrvigg"}}