{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/196042670","pull_request_review_id":129519501,"id":196042670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA0MjY3MA==","diff_hunk":"@@ -226,6 +226,14 @@ var queries = []struct {\n \t\t\t{\"     └─ Column(s, TEXT, nullable=false)\"},\n \t\t},\n \t},\n+\t{\n+\t\t`SELECT split(s,\" \") FROM mytable`,","path":"engine_test.go","position":5,"original_position":5,"commit_id":"9dbcc631add01cf98aac60962b7bd8882013db7f","original_commit_id":"9dbcc631add01cf98aac60962b7bd8882013db7f","user":{"login":"ajnavarro","id":1196465,"node_id":"MDQ6VXNlcjExOTY0NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1196465?v=4","gravatar_id":"","url":"https://api.github.com/users/ajnavarro","html_url":"https://github.com/ajnavarro","followers_url":"https://api.github.com/users/ajnavarro/followers","following_url":"https://api.github.com/users/ajnavarro/following{/other_user}","gists_url":"https://api.github.com/users/ajnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/ajnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajnavarro/subscriptions","organizations_url":"https://api.github.com/users/ajnavarro/orgs","repos_url":"https://api.github.com/users/ajnavarro/repos","events_url":"https://api.github.com/users/ajnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/ajnavarro/received_events","type":"User","site_admin":false},"body":"can you split by, per example, `s`?","created_at":"2018-06-18T11:21:30Z","updated_at":"2018-06-18T11:21:40Z","html_url":"https://github.com/src-d/go-mysql-server/pull/225#discussion_r196042670","pull_request_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/196042670"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/225#discussion_r196042670"},"pull_request":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225","id":195482645,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDgyNjQ1","html_url":"https://github.com/src-d/go-mysql-server/pull/225","diff_url":"https://github.com/src-d/go-mysql-server/pull/225.diff","patch_url":"https://github.com/src-d/go-mysql-server/pull/225.patch","issue_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/225","number":225,"state":"open","locked":false,"title":"sql/expression/function: add function split to the default functions to add to the registry","user":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"body":"The `split` function was implemented but not added to the default functions to be registered.\r\n","created_at":"2018-06-18T10:32:14Z","updated_at":"2018-06-18T11:21:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c742a26842cdc4b3276ff6371f3c5bd531a80a18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225/commits","review_comments_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225/comments","review_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/225/comments","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/9dbcc631add01cf98aac60962b7bd8882013db7f","head":{"label":"mcarmonaa:fix/register-split-function","ref":"fix/register-split-function","sha":"9dbcc631add01cf98aac60962b7bd8882013db7f","user":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"repo":{"id":121612822,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2MTI4MjI=","name":"go-mysql-server","full_name":"mcarmonaa/go-mysql-server","owner":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcarmonaa/go-mysql-server","description":null,"fork":true,"url":"https://api.github.com/repos/mcarmonaa/go-mysql-server","forks_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/forks","keys_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/events","assignees_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/merges","archive_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/mcarmonaa/go-mysql-server/deployments","created_at":"2018-02-15T09:48:54Z","updated_at":"2018-05-30T08:24:26Z","pushed_at":"2018-06-18T11:20:49Z","git_url":"git://github.com/mcarmonaa/go-mysql-server.git","ssh_url":"git@github.com:mcarmonaa/go-mysql-server.git","clone_url":"https://github.com/mcarmonaa/go-mysql-server.git","svn_url":"https://github.com/mcarmonaa/go-mysql-server","homepage":null,"size":796,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"e5a02e1ea1025b95825220793f8424f4e061d52b","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":121319560,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzMTk1NjA=","name":"go-mysql-server","full_name":"src-d/go-mysql-server","owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/src-d/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":false,"url":"https://api.github.com/repos/src-d/go-mysql-server","forks_url":"https://api.github.com/repos/src-d/go-mysql-server/forks","keys_url":"https://api.github.com/repos/src-d/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/src-d/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/go-mysql-server/events","assignees_url":"https://api.github.com/repos/src-d/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/src-d/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/src-d/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/src-d/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/src-d/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/src-d/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/go-mysql-server/merges","archive_url":"https://api.github.com/repos/src-d/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/src-d/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/src-d/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/go-mysql-server/deployments","created_at":"2018-02-13T00:24:19Z","updated_at":"2018-06-18T10:52:08Z","pushed_at":"2018-06-18T11:20:50Z","git_url":"git://github.com/src-d/go-mysql-server.git","ssh_url":"git@github.com:src-d/go-mysql-server.git","clone_url":"https://github.com/src-d/go-mysql-server.git","svn_url":"https://github.com/src-d/go-mysql-server","homepage":"","size":874,"stargazers_count":50,"watchers_count":50,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":27,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/225"},"issue":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/225"},"comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/go-mysql-server/statuses/9dbcc631add01cf98aac60962b7bd8882013db7f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ajnavarro"}}