{"action":"closed","number":119,"pull_request":{"url":"https://api.github.com/repos/taskcluster/generic-worker/pulls/119","id":206318069,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzE4MDY5","html_url":"https://github.com/taskcluster/generic-worker/pull/119","diff_url":"https://github.com/taskcluster/generic-worker/pull/119.diff","patch_url":"https://github.com/taskcluster/generic-worker/pull/119.patch","issue_url":"https://api.github.com/repos/taskcluster/generic-worker/issues/119","number":119,"state":"closed","locked":false,"title":"Bug 1480412 - allow empty osGroups list on non-Windows platforms","user":{"login":"petemoore","id":190790,"node_id":"MDQ6VXNlcjE5MDc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/190790?v=4","gravatar_id":"","url":"https://api.github.com/users/petemoore","html_url":"https://github.com/petemoore","followers_url":"https://api.github.com/users/petemoore/followers","following_url":"https://api.github.com/users/petemoore/following{/other_user}","gists_url":"https://api.github.com/users/petemoore/gists{/gist_id}","starred_url":"https://api.github.com/users/petemoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemoore/subscriptions","organizations_url":"https://api.github.com/users/petemoore/orgs","repos_url":"https://api.github.com/users/petemoore/repos","events_url":"https://api.github.com/users/petemoore/events{/privacy}","received_events_url":"https://api.github.com/users/petemoore/received_events","type":"User","site_admin":false},"body":"See [bug 1480412](https://bugzil.la/1480412) for more details.\r\n\r\nSince `osGroups` feature isn't supported on non-Windows platforms currently, in the most recent release (10.11.2) I had moved the `osGroups` code into the Windows codebase (`*_windows.go` files) from the cross platform go files. I hadn't realised that the gecko task generation code was creating non-Windows tasks specifying an empty `osGroups` list (`[]`). Rather than fix the task generation in all gecko trees/branches (and any other projects that might be doing the same) not to allow `osGroups` for platforms where this feature is not implemented, this PR ensures that the only acceptable value for `osGroups` on a non-Windows platform is the empty list (i.e. \"no groups\").\r\n\r\nThe reason it isn't implemented on those other platforms is that the tasks run as the same user as the worker process. Since the user cannot grant itself more privileges than it already has, this feature only makes sense on platforms where the task runs as a different user to the worker process, which currently is only Windows.\r\n\r\nSpecifying a non-empty list will result in a malformed-payload exception.\r\n\r\nThis PR is mostly the undoing of the previous refactor, i.e. moving the code from windows-only go files (`*_windows_*.go` files) back to the cross platform (`*.go`) files and a couple of tests to ensure it works.","created_at":"2018-08-06T08:00:40Z","updated_at":"2018-08-07T08:27:33Z","closed_at":"2018-08-07T08:27:33Z","merged_at":"2018-08-07T08:27:33Z","merge_commit_sha":"9c251ae47a23769980bfa5bced1b5f0b74665265","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/generic-worker/pulls/119/commits","review_comments_url":"https://api.github.com/repos/taskcluster/generic-worker/pulls/119/comments","review_comment_url":"https://api.github.com/repos/taskcluster/generic-worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/generic-worker/issues/119/comments","statuses_url":"https://api.github.com/repos/taskcluster/generic-worker/statuses/f9298685b3237eb368aecdb52ba81f26d151b3af","head":{"label":"taskcluster:bug1480412","ref":"bug1480412","sha":"f9298685b3237eb368aecdb52ba81f26d151b3af","user":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":31899192,"node_id":"MDEwOlJlcG9zaXRvcnkzMTg5OTE5Mg==","name":"generic-worker","full_name":"taskcluster/generic-worker","owner":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/generic-worker","description":"A generic worker for TaskCluster, written in go","fork":false,"url":"https://api.github.com/repos/taskcluster/generic-worker","forks_url":"https://api.github.com/repos/taskcluster/generic-worker/forks","keys_url":"https://api.github.com/repos/taskcluster/generic-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/generic-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/generic-worker/teams","hooks_url":"https://api.github.com/repos/taskcluster/generic-worker/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/generic-worker/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/generic-worker/events","assignees_url":"https://api.github.com/repos/taskcluster/generic-worker/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/generic-worker/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/generic-worker/tags","blobs_url":"https://api.github.com/repos/taskcluster/generic-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/generic-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/generic-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/generic-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/generic-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/generic-worker/languages","stargazers_url":"https://api.github.com/repos/taskcluster/generic-worker/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/generic-worker/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/generic-worker/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/generic-worker/subscription","commits_url":"https://api.github.com/repos/taskcluster/generic-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/generic-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/generic-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/generic-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/generic-worker/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/generic-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/generic-worker/merges","archive_url":"https://api.github.com/repos/taskcluster/generic-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/generic-worker/downloads","issues_url":"https://api.github.com/repos/taskcluster/generic-worker/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/generic-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/generic-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/generic-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/generic-worker/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/generic-worker/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/generic-worker/deployments","created_at":"2015-03-09T13:17:28Z","updated_at":"2018-08-02T19:49:56Z","pushed_at":"2018-08-07T08:27:33Z","git_url":"git://github.com/taskcluster/generic-worker.git","ssh_url":"git@github.com:taskcluster/generic-worker.git","clone_url":"https://github.com/taskcluster/generic-worker.git","svn_url":"https://github.com/taskcluster/generic-worker","homepage":"","size":2921,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":18,"open_issues":10,"watchers":10,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"5e4ea9732014c04e65a6b2a313ddae28b7fabc30","user":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":31899192,"node_id":"MDEwOlJlcG9zaXRvcnkzMTg5OTE5Mg==","name":"generic-worker","full_name":"taskcluster/generic-worker","owner":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/generic-worker","description":"A generic worker for TaskCluster, written in go","fork":false,"url":"https://api.github.com/repos/taskcluster/generic-worker","forks_url":"https://api.github.com/repos/taskcluster/generic-worker/forks","keys_url":"https://api.github.com/repos/taskcluster/generic-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/generic-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/generic-worker/teams","hooks_url":"https://api.github.com/repos/taskcluster/generic-worker/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/generic-worker/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/generic-worker/events","assignees_url":"https://api.github.com/repos/taskcluster/generic-worker/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/generic-worker/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/generic-worker/tags","blobs_url":"https://api.github.com/repos/taskcluster/generic-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/generic-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/generic-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/generic-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/generic-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/generic-worker/languages","stargazers_url":"https://api.github.com/repos/taskcluster/generic-worker/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/generic-worker/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/generic-worker/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/generic-worker/subscription","commits_url":"https://api.github.com/repos/taskcluster/generic-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/generic-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/generic-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/generic-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/generic-worker/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/generic-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/generic-worker/merges","archive_url":"https://api.github.com/repos/taskcluster/generic-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/generic-worker/downloads","issues_url":"https://api.github.com/repos/taskcluster/generic-worker/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/generic-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/generic-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/generic-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/generic-worker/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/generic-worker/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/generic-worker/deployments","created_at":"2015-03-09T13:17:28Z","updated_at":"2018-08-02T19:49:56Z","pushed_at":"2018-08-07T08:27:33Z","git_url":"git://github.com/taskcluster/generic-worker.git","ssh_url":"git@github.com:taskcluster/generic-worker.git","clone_url":"https://github.com/taskcluster/generic-worker.git","svn_url":"https://github.com/taskcluster/generic-worker","homepage":"","size":2921,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":18,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/generic-worker/pulls/119"},"html":{"href":"https://github.com/taskcluster/generic-worker/pull/119"},"issue":{"href":"https://api.github.com/repos/taskcluster/generic-worker/issues/119"},"comments":{"href":"https://api.github.com/repos/taskcluster/generic-worker/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/generic-worker/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/generic-worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/generic-worker/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/generic-worker/statuses/f9298685b3237eb368aecdb52ba81f26d151b3af"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"petemoore","id":190790,"node_id":"MDQ6VXNlcjE5MDc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/190790?v=4","gravatar_id":"","url":"https://api.github.com/users/petemoore","html_url":"https://github.com/petemoore","followers_url":"https://api.github.com/users/petemoore/followers","following_url":"https://api.github.com/users/petemoore/following{/other_user}","gists_url":"https://api.github.com/users/petemoore/gists{/gist_id}","starred_url":"https://api.github.com/users/petemoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemoore/subscriptions","organizations_url":"https://api.github.com/users/petemoore/orgs","repos_url":"https://api.github.com/users/petemoore/repos","events_url":"https://api.github.com/users/petemoore/events{/privacy}","received_events_url":"https://api.github.com/users/petemoore/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":144,"deletions":51,"changed_files":9}}
{"actor":{"display_login":"petemoore"}}