{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/2502","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/2502/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2502/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/2502/events","html_url":"https://github.com/eclipse/omr/pull/2502","id":317763868,"number":2502,"title":"CMake: Enable exception handling","user":{"login":"samolisov","id":134115,"avatar_url":"https://avatars3.githubusercontent.com/u/134115?v=4","gravatar_id":"","url":"https://api.github.com/users/samolisov","html_url":"https://github.com/samolisov","followers_url":"https://api.github.com/users/samolisov/followers","following_url":"https://api.github.com/users/samolisov/following{/other_user}","gists_url":"https://api.github.com/users/samolisov/gists{/gist_id}","starred_url":"https://api.github.com/users/samolisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samolisov/subscriptions","organizations_url":"https://api.github.com/users/samolisov/orgs","repos_url":"https://api.github.com/users/samolisov/repos","events_url":"https://api.github.com/users/samolisov/events{/privacy}","received_events_url":"https://api.github.com/users/samolisov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-25T19:32:15Z","updated_at":"2018-04-25T22:18:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2502","html_url":"https://github.com/eclipse/omr/pull/2502","diff_url":"https://github.com/eclipse/omr/pull/2502.diff","patch_url":"https://github.com/eclipse/omr/pull/2502.patch"},"body":"Clang/LLVM isn't able to compile the compilator's code when exception handling\r\nis not enabled:\r\n\r\n```\r\nerror: cannot use 'throw' with exceptions disabled\r\n       throw Exception();\r\n```\r\n\r\nWarning C4291:\r\n\r\n```\r\n..\\omr\\OMR_Agent.cpp(145): warning C4291: 'void *OMR_Agent::operator\r\nnew(::size_t,void *)': no matching operator delete found; memory will\r\nnot be freed if initialization throws an exception\r\nomr\\include_core\\OMR_Agent.hpp(136): note: see declaration of\r\n'OMR_Agent::operator new'\r\n```\r\n\r\nhas also been fixed.\r\n\r\nSigned-off-by: Pavel Samolysov <samolisov@gmail.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/384451868","html_url":"https://github.com/eclipse/omr/pull/2502#issuecomment-384451868","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2502","id":384451868,"user":{"login":"rwy0717","id":2774689,"avatar_url":"https://avatars2.githubusercontent.com/u/2774689?v=4","gravatar_id":"","url":"https://api.github.com/users/rwy0717","html_url":"https://github.com/rwy0717","followers_url":"https://api.github.com/users/rwy0717/followers","following_url":"https://api.github.com/users/rwy0717/following{/other_user}","gists_url":"https://api.github.com/users/rwy0717/gists{/gist_id}","starred_url":"https://api.github.com/users/rwy0717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwy0717/subscriptions","organizations_url":"https://api.github.com/users/rwy0717/orgs","repos_url":"https://api.github.com/users/rwy0717/repos","events_url":"https://api.github.com/users/rwy0717/events{/privacy}","received_events_url":"https://api.github.com/users/rwy0717/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T22:18:49Z","updated_at":"2018-04-25T22:18:49Z","author_association":"CONTRIBUTOR","body":"It would be better if exceptions were an optional feature, possibly called `OMR_CXX_EXCEPTIONS` in cmake. We would also want to respect this option on all supported platforms, not just windows.\r\n\r\nTo explain, most of our code does not use exceptions at all, and is not exception safe. Exceptions also require some symbols from the C++ std lib, which j9 can not link against. We are stuck supporting `-nostdlib`."}}
{"actor":{"display_login":"rwy0717"}}