{"action":"created","comment":{"url":"https://api.github.com/repos/samvera/hyrax/pulls/comments/229403717","pull_request_review_id":169896768,"id":229403717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQwMzcxNw==","diff_hunk":"@@ -55,15 +55,24 @@ def download_url\n       Hyrax::Engine.routes.url_helpers.download_url(representative_presenter, host: request.host)\n     end\n \n-    # @return [Boolean] render the UniversalViewer\n-    def universal_viewer?\n+    # @return [Boolean] render a IIIF viewer\n+    def iiif_viewer?\n       representative_id.present? &&\n         representative_presenter.present? &&\n         representative_presenter.image? &&\n         Hyrax.config.iiif_image_server? &&\n         members_include_viewable_image?\n     end\n \n+    alias universal_viewer? iiif_viewer?\n+    deprecation_deprecate universal_viewer?: \"use iiif_viewer? instead\"\n+\n+    # Override this method to declare a different iiif viewer for your work type","path":"app/presenters/hyrax/work_show_presenter.rb","position":18,"original_position":18,"commit_id":"659e90aa198f68edca5ddf02356aaf508c5bc339","original_commit_id":"659e90aa198f68edca5ddf02356aaf508c5bc339","user":{"login":"cjcolvar","id":1053603,"node_id":"MDQ6VXNlcjEwNTM2MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1053603?v=4","gravatar_id":"","url":"https://api.github.com/users/cjcolvar","html_url":"https://github.com/cjcolvar","followers_url":"https://api.github.com/users/cjcolvar/followers","following_url":"https://api.github.com/users/cjcolvar/following{/other_user}","gists_url":"https://api.github.com/users/cjcolvar/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcolvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcolvar/subscriptions","organizations_url":"https://api.github.com/users/cjcolvar/orgs","repos_url":"https://api.github.com/users/cjcolvar/repos","events_url":"https://api.github.com/users/cjcolvar/events{/privacy}","received_events_url":"https://api.github.com/users/cjcolvar/received_events","type":"User","site_admin":false},"body":"WorkShowPresenter is inherited by the work presenter generated as part of a work type.  I was expecting overrides to happen at that level in the downstream app's work presenter.  What do you think would be clearer language to suggest that pattern?  Do you think the `@example` you suggest would serve this purpose?","created_at":"2018-10-30T17:15:43Z","updated_at":"2018-10-30T17:15:44Z","html_url":"https://github.com/samvera/hyrax/pull/3360#discussion_r229403717","pull_request_url":"https://api.github.com/repos/samvera/hyrax/pulls/3360","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/comments/229403717"},"html":{"href":"https://github.com/samvera/hyrax/pull/3360#discussion_r229403717"},"pull_request":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/3360"}},"in_reply_to_id":229393605},"pull_request":{"url":"https://api.github.com/repos/samvera/hyrax/pulls/3360","id":226991217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTkxMjE3","html_url":"https://github.com/samvera/hyrax/pull/3360","diff_url":"https://github.com/samvera/hyrax/pull/3360.diff","patch_url":"https://github.com/samvera/hyrax/pull/3360.patch","issue_url":"https://api.github.com/repos/samvera/hyrax/issues/3360","number":3360,"state":"open","locked":false,"title":"IIIF viewer choice","user":{"login":"cjcolvar","id":1053603,"node_id":"MDQ6VXNlcjEwNTM2MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1053603?v=4","gravatar_id":"","url":"https://api.github.com/users/cjcolvar","html_url":"https://github.com/cjcolvar","followers_url":"https://api.github.com/users/cjcolvar/followers","following_url":"https://api.github.com/users/cjcolvar/following{/other_user}","gists_url":"https://api.github.com/users/cjcolvar/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcolvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcolvar/subscriptions","organizations_url":"https://api.github.com/users/cjcolvar/orgs","repos_url":"https://api.github.com/users/cjcolvar/repos","events_url":"https://api.github.com/users/cjcolvar/events{/privacy}","received_events_url":"https://api.github.com/users/cjcolvar/received_events","type":"User","site_admin":false},"body":"Pulls in work from https://github.com/samvera-labs/hyrax-iiif_av to generalize the IIIF viewer support to any IIIF viewer and not assuming Universal Viewer.  In the future other viewers could be added to core Hyrax but this PR at least allows a downstream app the ability to customize the IIIF view partial without overriding.  This is helpful for more experimental viewers like the Avalon react player for IIIF Presentation 3.0 AV manifests.  Possible documentation for how to use a custom IIIF viewer is below.\r\n\r\nThis PR has some view partial changes so I'd hope that it would be considered for Hyrax 3.0.\r\n\r\n@samvera/hyrax-code-reviewers\r\n\r\n\r\n# Adding a custom IIIF viewer\r\n\r\nCreate a new file in your Hyrax app at `app/views/hyrax/base/iiif_viewers/_my_iiif_viewer.html.erb`:\r\n```\r\n<h3>My IIIF Viewer!</h3>\r\n<a href=<%= main_app.polymorphic_path([main_app, :manifest, presenter], { locale: nil }) %>>Manifest</a>\r\n```\r\n\r\nOverride `#iiif_viewer` in your work presenter `app/presenters/hyrax/generic_work_presenter.rb`:\r\n```\r\ndef iiif_viewer\r\n  :my_iiif_viewer\r\nend\r\n```\r\n\r\n","created_at":"2018-10-30T16:23:44Z","updated_at":"2018-10-30T17:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0cec1cf37ff109f1ca55353a044818aa9f9d9e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":503705298,"node_id":"MDU6TGFiZWw1MDM3MDUyOTg=","url":"https://api.github.com/repos/samvera/hyrax/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/samvera/hyrax/milestones/12","html_url":"https://github.com/samvera/hyrax/milestone/12","labels_url":"https://api.github.com/repos/samvera/hyrax/milestones/12/labels","id":2781115,"node_id":"MDk6TWlsZXN0b25lMjc4MTExNQ==","number":12,"title":"2.x series","description":"This milestone is for issues that have been slated to go into a 1.x release. When a release is being planned, create a version-specific milestone for that release and pull issues from this milestone into the new version-specific milestone.","creator":{"login":"mjgiarlo","id":131982,"node_id":"MDQ6VXNlcjEzMTk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/131982?v=4","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"open_issues":118,"closed_issues":92,"state":"open","created_at":"2017-09-20T17:58:54Z","updated_at":"2018-10-30T16:57:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/samvera/hyrax/pulls/3360/commits","review_comments_url":"https://api.github.com/repos/samvera/hyrax/pulls/3360/comments","review_comment_url":"https://api.github.com/repos/samvera/hyrax/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samvera/hyrax/issues/3360/comments","statuses_url":"https://api.github.com/repos/samvera/hyrax/statuses/659e90aa198f68edca5ddf02356aaf508c5bc339","head":{"label":"samvera:iiif_viewer_choice","ref":"iiif_viewer_choice","sha":"659e90aa198f68edca5ddf02356aaf508c5bc339","user":{"login":"samvera","id":109426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTQyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"repo":{"id":75130658,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEzMDY1OA==","name":"hyrax","full_name":"samvera/hyrax","private":false,"owner":{"login":"samvera","id":109426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTQyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samvera/hyrax","description":"Hyrax is a front-end based on the robust Samvera framework, providing a user interface for common repository features","fork":false,"url":"https://api.github.com/repos/samvera/hyrax","forks_url":"https://api.github.com/repos/samvera/hyrax/forks","keys_url":"https://api.github.com/repos/samvera/hyrax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samvera/hyrax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samvera/hyrax/teams","hooks_url":"https://api.github.com/repos/samvera/hyrax/hooks","issue_events_url":"https://api.github.com/repos/samvera/hyrax/issues/events{/number}","events_url":"https://api.github.com/repos/samvera/hyrax/events","assignees_url":"https://api.github.com/repos/samvera/hyrax/assignees{/user}","branches_url":"https://api.github.com/repos/samvera/hyrax/branches{/branch}","tags_url":"https://api.github.com/repos/samvera/hyrax/tags","blobs_url":"https://api.github.com/repos/samvera/hyrax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samvera/hyrax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samvera/hyrax/git/refs{/sha}","trees_url":"https://api.github.com/repos/samvera/hyrax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samvera/hyrax/statuses/{sha}","languages_url":"https://api.github.com/repos/samvera/hyrax/languages","stargazers_url":"https://api.github.com/repos/samvera/hyrax/stargazers","contributors_url":"https://api.github.com/repos/samvera/hyrax/contributors","subscribers_url":"https://api.github.com/repos/samvera/hyrax/subscribers","subscription_url":"https://api.github.com/repos/samvera/hyrax/subscription","commits_url":"https://api.github.com/repos/samvera/hyrax/commits{/sha}","git_commits_url":"https://api.github.com/repos/samvera/hyrax/git/commits{/sha}","comments_url":"https://api.github.com/repos/samvera/hyrax/comments{/number}","issue_comment_url":"https://api.github.com/repos/samvera/hyrax/issues/comments{/number}","contents_url":"https://api.github.com/repos/samvera/hyrax/contents/{+path}","compare_url":"https://api.github.com/repos/samvera/hyrax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samvera/hyrax/merges","archive_url":"https://api.github.com/repos/samvera/hyrax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samvera/hyrax/downloads","issues_url":"https://api.github.com/repos/samvera/hyrax/issues{/number}","pulls_url":"https://api.github.com/repos/samvera/hyrax/pulls{/number}","milestones_url":"https://api.github.com/repos/samvera/hyrax/milestones{/number}","notifications_url":"https://api.github.com/repos/samvera/hyrax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samvera/hyrax/labels{/name}","releases_url":"https://api.github.com/repos/samvera/hyrax/releases{/id}","deployments_url":"https://api.github.com/repos/samvera/hyrax/deployments","created_at":"2016-11-29T23:09:59Z","updated_at":"2018-10-30T12:56:55Z","pushed_at":"2018-10-30T16:23:44Z","git_url":"git://github.com/samvera/hyrax.git","ssh_url":"git@github.com:samvera/hyrax.git","clone_url":"https://github.com/samvera/hyrax.git","svn_url":"https://github.com/samvera/hyrax","homepage":"http://hyr.ax/","size":68128,"stargazers_count":87,"watchers_count":87,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":490,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":490,"watchers":87,"default_branch":"master"}},"base":{"label":"samvera:master","ref":"master","sha":"c4e76f37850e4d5b689ec44f3643859f427b14f4","user":{"login":"samvera","id":109426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTQyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"repo":{"id":75130658,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEzMDY1OA==","name":"hyrax","full_name":"samvera/hyrax","private":false,"owner":{"login":"samvera","id":109426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTQyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/109426?v=4","gravatar_id":"","url":"https://api.github.com/users/samvera","html_url":"https://github.com/samvera","followers_url":"https://api.github.com/users/samvera/followers","following_url":"https://api.github.com/users/samvera/following{/other_user}","gists_url":"https://api.github.com/users/samvera/gists{/gist_id}","starred_url":"https://api.github.com/users/samvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samvera/subscriptions","organizations_url":"https://api.github.com/users/samvera/orgs","repos_url":"https://api.github.com/users/samvera/repos","events_url":"https://api.github.com/users/samvera/events{/privacy}","received_events_url":"https://api.github.com/users/samvera/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samvera/hyrax","description":"Hyrax is a front-end based on the robust Samvera framework, providing a user interface for common repository features","fork":false,"url":"https://api.github.com/repos/samvera/hyrax","forks_url":"https://api.github.com/repos/samvera/hyrax/forks","keys_url":"https://api.github.com/repos/samvera/hyrax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samvera/hyrax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samvera/hyrax/teams","hooks_url":"https://api.github.com/repos/samvera/hyrax/hooks","issue_events_url":"https://api.github.com/repos/samvera/hyrax/issues/events{/number}","events_url":"https://api.github.com/repos/samvera/hyrax/events","assignees_url":"https://api.github.com/repos/samvera/hyrax/assignees{/user}","branches_url":"https://api.github.com/repos/samvera/hyrax/branches{/branch}","tags_url":"https://api.github.com/repos/samvera/hyrax/tags","blobs_url":"https://api.github.com/repos/samvera/hyrax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samvera/hyrax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samvera/hyrax/git/refs{/sha}","trees_url":"https://api.github.com/repos/samvera/hyrax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samvera/hyrax/statuses/{sha}","languages_url":"https://api.github.com/repos/samvera/hyrax/languages","stargazers_url":"https://api.github.com/repos/samvera/hyrax/stargazers","contributors_url":"https://api.github.com/repos/samvera/hyrax/contributors","subscribers_url":"https://api.github.com/repos/samvera/hyrax/subscribers","subscription_url":"https://api.github.com/repos/samvera/hyrax/subscription","commits_url":"https://api.github.com/repos/samvera/hyrax/commits{/sha}","git_commits_url":"https://api.github.com/repos/samvera/hyrax/git/commits{/sha}","comments_url":"https://api.github.com/repos/samvera/hyrax/comments{/number}","issue_comment_url":"https://api.github.com/repos/samvera/hyrax/issues/comments{/number}","contents_url":"https://api.github.com/repos/samvera/hyrax/contents/{+path}","compare_url":"https://api.github.com/repos/samvera/hyrax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samvera/hyrax/merges","archive_url":"https://api.github.com/repos/samvera/hyrax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samvera/hyrax/downloads","issues_url":"https://api.github.com/repos/samvera/hyrax/issues{/number}","pulls_url":"https://api.github.com/repos/samvera/hyrax/pulls{/number}","milestones_url":"https://api.github.com/repos/samvera/hyrax/milestones{/number}","notifications_url":"https://api.github.com/repos/samvera/hyrax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samvera/hyrax/labels{/name}","releases_url":"https://api.github.com/repos/samvera/hyrax/releases{/id}","deployments_url":"https://api.github.com/repos/samvera/hyrax/deployments","created_at":"2016-11-29T23:09:59Z","updated_at":"2018-10-30T12:56:55Z","pushed_at":"2018-10-30T16:23:44Z","git_url":"git://github.com/samvera/hyrax.git","ssh_url":"git@github.com:samvera/hyrax.git","clone_url":"https://github.com/samvera/hyrax.git","svn_url":"https://github.com/samvera/hyrax","homepage":"http://hyr.ax/","size":68128,"stargazers_count":87,"watchers_count":87,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":490,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":490,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/3360"},"html":{"href":"https://github.com/samvera/hyrax/pull/3360"},"issue":{"href":"https://api.github.com/repos/samvera/hyrax/issues/3360"},"comments":{"href":"https://api.github.com/repos/samvera/hyrax/issues/3360/comments"},"review_comments":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/3360/comments"},"review_comment":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samvera/hyrax/pulls/3360/commits"},"statuses":{"href":"https://api.github.com/repos/samvera/hyrax/statuses/659e90aa198f68edca5ddf02356aaf508c5bc339"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cjcolvar"}}