{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/alces-software/inventoryware/pulls/8","id":236867463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODY3NDYz","html_url":"https://github.com/alces-software/inventoryware/pull/8","diff_url":"https://github.com/alces-software/inventoryware/pull/8.diff","patch_url":"https://github.com/alces-software/inventoryware/pull/8.patch","issue_url":"https://api.github.com/repos/alces-software/inventoryware/issues/8","number":8,"state":"closed","locked":false,"title":"Add os mapping capability","user":{"login":"DavidMarchant","id":24327288,"node_id":"MDQ6VXNlcjI0MzI3Mjg4","avatar_url":"https://avatars0.githubusercontent.com/u/24327288?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidMarchant","html_url":"https://github.com/DavidMarchant","followers_url":"https://api.github.com/users/DavidMarchant/followers","following_url":"https://api.github.com/users/DavidMarchant/following{/other_user}","gists_url":"https://api.github.com/users/DavidMarchant/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidMarchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidMarchant/subscriptions","organizations_url":"https://api.github.com/users/DavidMarchant/orgs","repos_url":"https://api.github.com/users/DavidMarchant/repos","events_url":"https://api.github.com/users/DavidMarchant/events{/privacy}","received_events_url":"https://api.github.com/users/DavidMarchant/received_events","type":"User","site_admin":false},"body":"To prevent needing to redefine templates based on the target node's OS (as different node OS presents different lshw output)\r\nCreate hash to store various fields based on OS.\r\nOS is currently passed as a CLI option that is necessary if a template is being used. This will likely change to being scrubbed when more input data is added.\r\n\r\n@ColonelPanicks:\r\nThe template syntax looks like so: `<%= cpu[mapping['cpu_model']] %>` How's this with you?\r\n\r\n& I defined the mapping in a ruby hash in a separate module (mapper) , how is this solution with you?\r\nI saw that you wrote it in a psuedo yaml style, would this be better?","created_at":"2018-12-07T13:26:13Z","updated_at":"2018-12-10T15:32:04Z","closed_at":"2018-12-10T15:32:04Z","merged_at":"2018-12-10T15:32:04Z","merge_commit_sha":"36b6aa510ec5e5115f369b4f0a7e7795f8583595","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mjtko","id":206834,"node_id":"MDQ6VXNlcjIwNjgzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/206834?v=4","gravatar_id":"","url":"https://api.github.com/users/mjtko","html_url":"https://github.com/mjtko","followers_url":"https://api.github.com/users/mjtko/followers","following_url":"https://api.github.com/users/mjtko/following{/other_user}","gists_url":"https://api.github.com/users/mjtko/gists{/gist_id}","starred_url":"https://api.github.com/users/mjtko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjtko/subscriptions","organizations_url":"https://api.github.com/users/mjtko/orgs","repos_url":"https://api.github.com/users/mjtko/repos","events_url":"https://api.github.com/users/mjtko/events{/privacy}","received_events_url":"https://api.github.com/users/mjtko/received_events","type":"User","site_admin":false},{"login":"ColonelPanicks","id":27725639,"node_id":"MDQ6VXNlcjI3NzI1NjM5","avatar_url":"https://avatars2.githubusercontent.com/u/27725639?v=4","gravatar_id":"","url":"https://api.github.com/users/ColonelPanicks","html_url":"https://github.com/ColonelPanicks","followers_url":"https://api.github.com/users/ColonelPanicks/followers","following_url":"https://api.github.com/users/ColonelPanicks/following{/other_user}","gists_url":"https://api.github.com/users/ColonelPanicks/gists{/gist_id}","starred_url":"https://api.github.com/users/ColonelPanicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColonelPanicks/subscriptions","organizations_url":"https://api.github.com/users/ColonelPanicks/orgs","repos_url":"https://api.github.com/users/ColonelPanicks/repos","events_url":"https://api.github.com/users/ColonelPanicks/events{/privacy}","received_events_url":"https://api.github.com/users/ColonelPanicks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alces-software/inventoryware/pulls/8/commits","review_comments_url":"https://api.github.com/repos/alces-software/inventoryware/pulls/8/comments","review_comment_url":"https://api.github.com/repos/alces-software/inventoryware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alces-software/inventoryware/issues/8/comments","statuses_url":"https://api.github.com/repos/alces-software/inventoryware/statuses/57f4c5e8f93c1c5fffbc5d5e643716195f76d1a0","head":{"label":"alces-software:dev/os-based-field-mapping","ref":"dev/os-based-field-mapping","sha":"57f4c5e8f93c1c5fffbc5d5e643716195f76d1a0","user":{"login":"alces-software","id":945288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTI4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"repo":{"id":159329657,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzMjk2NTc=","name":"inventoryware","full_name":"alces-software/inventoryware","private":false,"owner":{"login":"alces-software","id":945288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTI4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alces-software/inventoryware","description":"Parser of various hardware information into workable unified formats","fork":false,"url":"https://api.github.com/repos/alces-software/inventoryware","forks_url":"https://api.github.com/repos/alces-software/inventoryware/forks","keys_url":"https://api.github.com/repos/alces-software/inventoryware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alces-software/inventoryware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alces-software/inventoryware/teams","hooks_url":"https://api.github.com/repos/alces-software/inventoryware/hooks","issue_events_url":"https://api.github.com/repos/alces-software/inventoryware/issues/events{/number}","events_url":"https://api.github.com/repos/alces-software/inventoryware/events","assignees_url":"https://api.github.com/repos/alces-software/inventoryware/assignees{/user}","branches_url":"https://api.github.com/repos/alces-software/inventoryware/branches{/branch}","tags_url":"https://api.github.com/repos/alces-software/inventoryware/tags","blobs_url":"https://api.github.com/repos/alces-software/inventoryware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alces-software/inventoryware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alces-software/inventoryware/git/refs{/sha}","trees_url":"https://api.github.com/repos/alces-software/inventoryware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alces-software/inventoryware/statuses/{sha}","languages_url":"https://api.github.com/repos/alces-software/inventoryware/languages","stargazers_url":"https://api.github.com/repos/alces-software/inventoryware/stargazers","contributors_url":"https://api.github.com/repos/alces-software/inventoryware/contributors","subscribers_url":"https://api.github.com/repos/alces-software/inventoryware/subscribers","subscription_url":"https://api.github.com/repos/alces-software/inventoryware/subscription","commits_url":"https://api.github.com/repos/alces-software/inventoryware/commits{/sha}","git_commits_url":"https://api.github.com/repos/alces-software/inventoryware/git/commits{/sha}","comments_url":"https://api.github.com/repos/alces-software/inventoryware/comments{/number}","issue_comment_url":"https://api.github.com/repos/alces-software/inventoryware/issues/comments{/number}","contents_url":"https://api.github.com/repos/alces-software/inventoryware/contents/{+path}","compare_url":"https://api.github.com/repos/alces-software/inventoryware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alces-software/inventoryware/merges","archive_url":"https://api.github.com/repos/alces-software/inventoryware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alces-software/inventoryware/downloads","issues_url":"https://api.github.com/repos/alces-software/inventoryware/issues{/number}","pulls_url":"https://api.github.com/repos/alces-software/inventoryware/pulls{/number}","milestones_url":"https://api.github.com/repos/alces-software/inventoryware/milestones{/number}","notifications_url":"https://api.github.com/repos/alces-software/inventoryware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alces-software/inventoryware/labels{/name}","releases_url":"https://api.github.com/repos/alces-software/inventoryware/releases{/id}","deployments_url":"https://api.github.com/repos/alces-software/inventoryware/deployments","created_at":"2018-11-27T12:08:38Z","updated_at":"2018-12-07T17:30:18Z","pushed_at":"2018-12-10T15:32:04Z","git_url":"git://github.com/alces-software/inventoryware.git","ssh_url":"git@github.com:alces-software/inventoryware.git","clone_url":"https://github.com/alces-software/inventoryware.git","svn_url":"https://github.com/alces-software/inventoryware","homepage":"","size":58,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alces-software:master","ref":"master","sha":"96801cdc7ea08f20bf7a8103f53d1e13601014a3","user":{"login":"alces-software","id":945288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTI4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"repo":{"id":159329657,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzMjk2NTc=","name":"inventoryware","full_name":"alces-software/inventoryware","private":false,"owner":{"login":"alces-software","id":945288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTI4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/945288?v=4","gravatar_id":"","url":"https://api.github.com/users/alces-software","html_url":"https://github.com/alces-software","followers_url":"https://api.github.com/users/alces-software/followers","following_url":"https://api.github.com/users/alces-software/following{/other_user}","gists_url":"https://api.github.com/users/alces-software/gists{/gist_id}","starred_url":"https://api.github.com/users/alces-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alces-software/subscriptions","organizations_url":"https://api.github.com/users/alces-software/orgs","repos_url":"https://api.github.com/users/alces-software/repos","events_url":"https://api.github.com/users/alces-software/events{/privacy}","received_events_url":"https://api.github.com/users/alces-software/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alces-software/inventoryware","description":"Parser of various hardware information into workable unified formats","fork":false,"url":"https://api.github.com/repos/alces-software/inventoryware","forks_url":"https://api.github.com/repos/alces-software/inventoryware/forks","keys_url":"https://api.github.com/repos/alces-software/inventoryware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alces-software/inventoryware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alces-software/inventoryware/teams","hooks_url":"https://api.github.com/repos/alces-software/inventoryware/hooks","issue_events_url":"https://api.github.com/repos/alces-software/inventoryware/issues/events{/number}","events_url":"https://api.github.com/repos/alces-software/inventoryware/events","assignees_url":"https://api.github.com/repos/alces-software/inventoryware/assignees{/user}","branches_url":"https://api.github.com/repos/alces-software/inventoryware/branches{/branch}","tags_url":"https://api.github.com/repos/alces-software/inventoryware/tags","blobs_url":"https://api.github.com/repos/alces-software/inventoryware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alces-software/inventoryware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alces-software/inventoryware/git/refs{/sha}","trees_url":"https://api.github.com/repos/alces-software/inventoryware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alces-software/inventoryware/statuses/{sha}","languages_url":"https://api.github.com/repos/alces-software/inventoryware/languages","stargazers_url":"https://api.github.com/repos/alces-software/inventoryware/stargazers","contributors_url":"https://api.github.com/repos/alces-software/inventoryware/contributors","subscribers_url":"https://api.github.com/repos/alces-software/inventoryware/subscribers","subscription_url":"https://api.github.com/repos/alces-software/inventoryware/subscription","commits_url":"https://api.github.com/repos/alces-software/inventoryware/commits{/sha}","git_commits_url":"https://api.github.com/repos/alces-software/inventoryware/git/commits{/sha}","comments_url":"https://api.github.com/repos/alces-software/inventoryware/comments{/number}","issue_comment_url":"https://api.github.com/repos/alces-software/inventoryware/issues/comments{/number}","contents_url":"https://api.github.com/repos/alces-software/inventoryware/contents/{+path}","compare_url":"https://api.github.com/repos/alces-software/inventoryware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alces-software/inventoryware/merges","archive_url":"https://api.github.com/repos/alces-software/inventoryware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alces-software/inventoryware/downloads","issues_url":"https://api.github.com/repos/alces-software/inventoryware/issues{/number}","pulls_url":"https://api.github.com/repos/alces-software/inventoryware/pulls{/number}","milestones_url":"https://api.github.com/repos/alces-software/inventoryware/milestones{/number}","notifications_url":"https://api.github.com/repos/alces-software/inventoryware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alces-software/inventoryware/labels{/name}","releases_url":"https://api.github.com/repos/alces-software/inventoryware/releases{/id}","deployments_url":"https://api.github.com/repos/alces-software/inventoryware/deployments","created_at":"2018-11-27T12:08:38Z","updated_at":"2018-12-07T17:30:18Z","pushed_at":"2018-12-10T15:32:04Z","git_url":"git://github.com/alces-software/inventoryware.git","ssh_url":"git@github.com:alces-software/inventoryware.git","clone_url":"https://github.com/alces-software/inventoryware.git","svn_url":"https://github.com/alces-software/inventoryware","homepage":"","size":58,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alces-software/inventoryware/pulls/8"},"html":{"href":"https://github.com/alces-software/inventoryware/pull/8"},"issue":{"href":"https://api.github.com/repos/alces-software/inventoryware/issues/8"},"comments":{"href":"https://api.github.com/repos/alces-software/inventoryware/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/alces-software/inventoryware/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/alces-software/inventoryware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alces-software/inventoryware/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/alces-software/inventoryware/statuses/57f4c5e8f93c1c5fffbc5d5e643716195f76d1a0"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DavidMarchant","id":24327288,"node_id":"MDQ6VXNlcjI0MzI3Mjg4","avatar_url":"https://avatars0.githubusercontent.com/u/24327288?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidMarchant","html_url":"https://github.com/DavidMarchant","followers_url":"https://api.github.com/users/DavidMarchant/followers","following_url":"https://api.github.com/users/DavidMarchant/following{/other_user}","gists_url":"https://api.github.com/users/DavidMarchant/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidMarchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidMarchant/subscriptions","organizations_url":"https://api.github.com/users/DavidMarchant/orgs","repos_url":"https://api.github.com/users/DavidMarchant/repos","events_url":"https://api.github.com/users/DavidMarchant/events{/privacy}","received_events_url":"https://api.github.com/users/DavidMarchant/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":38,"deletions":7,"changed_files":5}}
{"actor":{"display_login":"DavidMarchant"}}