{"action":"created","issue":{"url":"https://api.github.com/repos/ninia/jep/issues/154","repository_url":"https://api.github.com/repos/ninia/jep","labels_url":"https://api.github.com/repos/ninia/jep/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/ninia/jep/issues/154/comments","events_url":"https://api.github.com/repos/ninia/jep/issues/154/events","html_url":"https://github.com/ninia/jep/issues/154","id":351139150,"node_id":"MDU6SXNzdWUzNTExMzkxNTA=","number":154,"title":"Bug in test of shared modules.","user":{"login":"karpierz","id":7438703,"node_id":"MDQ6VXNlcjc0Mzg3MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7438703?v=4","gravatar_id":"","url":"https://api.github.com/users/karpierz","html_url":"https://github.com/karpierz","followers_url":"https://api.github.com/users/karpierz/followers","following_url":"https://api.github.com/users/karpierz/following{/other_user}","gists_url":"https://api.github.com/users/karpierz/gists{/gist_id}","starred_url":"https://api.github.com/users/karpierz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karpierz/subscriptions","organizations_url":"https://api.github.com/users/karpierz/orgs","repos_url":"https://api.github.com/users/karpierz/repos","events_url":"https://api.github.com/users/karpierz/events{/privacy}","received_events_url":"https://api.github.com/users/karpierz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-16T10:06:20Z","updated_at":"2018-08-16T16:08:08Z","closed_at":null,"author_association":"NONE","body":"- OS Platform, Distribution, and Version: All\r\n- Python Distribution and Version: 3.6\r\n- Java Distribution and Version: Oracle Java 1.8\r\n- Jep Version: 3.8.2\r\n\r\nBug in test of shared modules.\r\n\r\nTrivial patch:\r\n```\r\n--- src\\test\\python\\test_shared_modules.py.org\t2018-08-10 19:19:42.000000000 +0200\r\n+++ src\\test\\python\\test_shared_modules.py\t2018-08-16 11:58:07.691470600 +0200\r\n@@ -25,9 +25,9 @@\r\n \r\n     def test_unshared(self):\r\n         # The default jep has no shared modules so it should not be possible\r\n-        # to access topInterpreterModules\r\n+        # to access mainInterpreterModules\r\n         with self.assertRaises(AttributeError):\r\n-            jep.topInterpreterModules\r\n+            jep.mainInterpreterModules\r\n     \r\n     def test_shared_argv(self):\r\n         jep_pipe(build_java_process_cmd('jep.test.TestSharedArgv'))\r\n```\r\nThanks,\r\nAdam Karpierz\r\n"},"comment":{"url":"https://api.github.com/repos/ninia/jep/issues/comments/413598984","html_url":"https://github.com/ninia/jep/issues/154#issuecomment-413598984","issue_url":"https://api.github.com/repos/ninia/jep/issues/154","id":413598984,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzU5ODk4NA==","user":{"login":"ndjensen","id":5747885,"node_id":"MDQ6VXNlcjU3NDc4ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/5747885?v=4","gravatar_id":"","url":"https://api.github.com/users/ndjensen","html_url":"https://github.com/ndjensen","followers_url":"https://api.github.com/users/ndjensen/followers","following_url":"https://api.github.com/users/ndjensen/following{/other_user}","gists_url":"https://api.github.com/users/ndjensen/gists{/gist_id}","starred_url":"https://api.github.com/users/ndjensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndjensen/subscriptions","organizations_url":"https://api.github.com/users/ndjensen/orgs","repos_url":"https://api.github.com/users/ndjensen/repos","events_url":"https://api.github.com/users/ndjensen/events{/privacy}","received_events_url":"https://api.github.com/users/ndjensen/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T16:08:08Z","updated_at":"2018-08-16T16:08:08Z","author_association":"MEMBER","body":"Thanks.  These appear to be code review comments, not actual issues.  Which thankfully means our code must be fairly readable.  If there's another release of Jep 3.8 (dependent on what issues are reported), we'll probably include this on the next Jep 3.8 release, otherwise it will go into Jep 3.9."}}
{"actor":{"display_login":"ndjensen"}}