{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/238722777","pull_request_review_id":181333738,"id":238722777,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODcyMjc3Nw==","diff_hunk":"@@ -298,82 +311,93 @@ private ClientInfo getClientInfo() {\n     }\n \n     @Override\n-    public AccumuloClient build() throws AccumuloException, AccumuloSecurityException {\n+    public T build() {\n+      return builderFunction.build(this);\n+    }\n+\n+    public static ClientBuilderImpl<AccumuloClient> newClientBuilder() {\n+      return new ClientBuilderImpl<>(ClientBuilderImpl::buildClient);\n+    }\n+\n+    public static ClientBuilderImpl<Properties> newPropertiesBuilder() {\n+      return new ClientBuilderImpl<>(ClientBuilderImpl::buildProps);\n+    }\n+\n+    private static AccumuloClient buildClient(ClientBuilderImpl<AccumuloClient> cbi) {\n       SingletonReservation reservation = SingletonManager.getClientReservation();\n       try {\n-        return new AccumuloClientImpl(reservation, new ClientContext(getClientInfo()));\n-      } catch (AccumuloException | AccumuloSecurityException | RuntimeException e) {\n+        return new AccumuloClientImpl(reservation, new ClientContext(cbi.getClientInfo()));\n+      } catch (RuntimeException e) {","path":"core/src/main/java/org/apache/accumulo/core/clientImpl/AccumuloClientImpl.java","position":127,"original_position":136,"commit_id":"9361de64c246617d2c35348dcf727d779bfe6dd3","original_commit_id":"bb7ff5e1c2e98d5632fe7b987342a031a3a63195","user":{"login":"mikewalch","id":730698,"node_id":"MDQ6VXNlcjczMDY5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/730698?v=4","gravatar_id":"","url":"https://api.github.com/users/mikewalch","html_url":"https://github.com/mikewalch","followers_url":"https://api.github.com/users/mikewalch/followers","following_url":"https://api.github.com/users/mikewalch/following{/other_user}","gists_url":"https://api.github.com/users/mikewalch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewalch/subscriptions","organizations_url":"https://api.github.com/users/mikewalch/orgs","repos_url":"https://api.github.com/users/mikewalch/repos","events_url":"https://api.github.com/users/mikewalch/events{/privacy}","received_events_url":"https://api.github.com/users/mikewalch/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-12-04T15:56:13Z","updated_at":"2018-12-04T15:56:13Z","html_url":"https://github.com/apache/accumulo/pull/792#discussion_r238722777","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/792","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/238722777"},"html":{"href":"https://github.com/apache/accumulo/pull/792#discussion_r238722777"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/792"}},"in_reply_to_id":238028784},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/792","id":235124868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTI0ODY4","html_url":"https://github.com/apache/accumulo/pull/792","diff_url":"https://github.com/apache/accumulo/pull/792.diff","patch_url":"https://github.com/apache/accumulo/pull/792.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/792","number":792,"state":"open","locked":false,"title":"Updates to client builder API","user":{"login":"mikewalch","id":730698,"node_id":"MDQ6VXNlcjczMDY5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/730698?v=4","gravatar_id":"","url":"https://api.github.com/users/mikewalch","html_url":"https://github.com/mikewalch","followers_url":"https://api.github.com/users/mikewalch/followers","following_url":"https://api.github.com/users/mikewalch/following{/other_user}","gists_url":"https://api.github.com/users/mikewalch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewalch/subscriptions","organizations_url":"https://api.github.com/users/mikewalch/orgs","repos_url":"https://api.github.com/users/mikewalch/repos","events_url":"https://api.github.com/users/mikewalch/events{/privacy}","received_events_url":"https://api.github.com/users/mikewalch/received_events","type":"User","site_admin":false},"body":"* Removed use ClientInfo in AccumuloClient\r\n* Removed changeUser method from AccumuloClient\r\n* Created Accumulo.newClientProperties() for building client properties\r\n* Added authenticate() method to AccumuloClient to verify client creds\r\n* Removed client verification from AccumuloClient constructor\r\n* Added properties() method to AccumuloClient","created_at":"2018-11-30T21:47:07Z","updated_at":"2018-12-04T15:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68e18734f3bc39ce8435748049bf84e2a8965fa5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/792/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/792/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/792/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/9361de64c246617d2c35348dcf727d779bfe6dd3","head":{"label":"mikewalch:remove-info","ref":"remove-info","sha":"9361de64c246617d2c35348dcf727d779bfe6dd3","user":{"login":"mikewalch","id":730698,"node_id":"MDQ6VXNlcjczMDY5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/730698?v=4","gravatar_id":"","url":"https://api.github.com/users/mikewalch","html_url":"https://github.com/mikewalch","followers_url":"https://api.github.com/users/mikewalch/followers","following_url":"https://api.github.com/users/mikewalch/following{/other_user}","gists_url":"https://api.github.com/users/mikewalch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewalch/subscriptions","organizations_url":"https://api.github.com/users/mikewalch/orgs","repos_url":"https://api.github.com/users/mikewalch/repos","events_url":"https://api.github.com/users/mikewalch/events{/privacy}","received_events_url":"https://api.github.com/users/mikewalch/received_events","type":"User","site_admin":false},"repo":{"id":21337602,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMzNzYwMg==","name":"accumulo","full_name":"mikewalch/accumulo","private":false,"owner":{"login":"mikewalch","id":730698,"node_id":"MDQ6VXNlcjczMDY5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/730698?v=4","gravatar_id":"","url":"https://api.github.com/users/mikewalch","html_url":"https://github.com/mikewalch","followers_url":"https://api.github.com/users/mikewalch/followers","following_url":"https://api.github.com/users/mikewalch/following{/other_user}","gists_url":"https://api.github.com/users/mikewalch/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewalch/subscriptions","organizations_url":"https://api.github.com/users/mikewalch/orgs","repos_url":"https://api.github.com/users/mikewalch/repos","events_url":"https://api.github.com/users/mikewalch/events{/privacy}","received_events_url":"https://api.github.com/users/mikewalch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikewalch/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/mikewalch/accumulo","forks_url":"https://api.github.com/repos/mikewalch/accumulo/forks","keys_url":"https://api.github.com/repos/mikewalch/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikewalch/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikewalch/accumulo/teams","hooks_url":"https://api.github.com/repos/mikewalch/accumulo/hooks","issue_events_url":"https://api.github.com/repos/mikewalch/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/mikewalch/accumulo/events","assignees_url":"https://api.github.com/repos/mikewalch/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/mikewalch/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/mikewalch/accumulo/tags","blobs_url":"https://api.github.com/repos/mikewalch/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikewalch/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikewalch/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikewalch/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikewalch/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/mikewalch/accumulo/languages","stargazers_url":"https://api.github.com/repos/mikewalch/accumulo/stargazers","contributors_url":"https://api.github.com/repos/mikewalch/accumulo/contributors","subscribers_url":"https://api.github.com/repos/mikewalch/accumulo/subscribers","subscription_url":"https://api.github.com/repos/mikewalch/accumulo/subscription","commits_url":"https://api.github.com/repos/mikewalch/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikewalch/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikewalch/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikewalch/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikewalch/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/mikewalch/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikewalch/accumulo/merges","archive_url":"https://api.github.com/repos/mikewalch/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikewalch/accumulo/downloads","issues_url":"https://api.github.com/repos/mikewalch/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/mikewalch/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/mikewalch/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/mikewalch/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikewalch/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/mikewalch/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/mikewalch/accumulo/deployments","created_at":"2014-06-30T02:41:14Z","updated_at":"2018-04-17T20:19:43Z","pushed_at":"2018-12-04T15:54:31Z","git_url":"git://github.com/mikewalch/accumulo.git","ssh_url":"git@github.com:mikewalch/accumulo.git","clone_url":"https://github.com/mikewalch/accumulo.git","svn_url":"https://github.com/mikewalch/accumulo","homepage":"","size":65912,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2723e5de67e17a8ca2de4253019e0daf9490472f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"node_id":"MDEwOlJlcG9zaXRvcnkyNTI0NDg4","name":"accumulo","full_name":"apache/accumulo","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/accumulo","description":"Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2018-12-04T03:28:39Z","pushed_at":"2018-12-04T15:54:33Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"https://accumulo.apache.org","size":65863,"stargazers_count":417,"watchers_count":417,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":232,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":232,"open_issues":75,"watchers":417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/792"},"html":{"href":"https://github.com/apache/accumulo/pull/792"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/792"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/792/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/792/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/792/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/9361de64c246617d2c35348dcf727d779bfe6dd3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mikewalch"}}