{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/nimbus/issues/199","repository_url":"https://api.github.com/repos/status-im/nimbus","labels_url":"https://api.github.com/repos/status-im/nimbus/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/status-im/nimbus/issues/199/comments","events_url":"https://api.github.com/repos/status-im/nimbus/issues/199/events","html_url":"https://github.com/status-im/nimbus/pull/199","id":391109597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzIwMzM4","number":199,"title":"better error handling [nimbus]","user":{"login":"stefantalpalaru","id":495550,"node_id":"MDQ6VXNlcjQ5NTU1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/495550?v=4","gravatar_id":"","url":"https://api.github.com/users/stefantalpalaru","html_url":"https://github.com/stefantalpalaru","followers_url":"https://api.github.com/users/stefantalpalaru/followers","following_url":"https://api.github.com/users/stefantalpalaru/following{/other_user}","gists_url":"https://api.github.com/users/stefantalpalaru/gists{/gist_id}","starred_url":"https://api.github.com/users/stefantalpalaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefantalpalaru/subscriptions","organizations_url":"https://api.github.com/users/stefantalpalaru/orgs","repos_url":"https://api.github.com/users/stefantalpalaru/repos","events_url":"https://api.github.com/users/stefantalpalaru/events{/privacy}","received_events_url":"https://api.github.com/users/stefantalpalaru/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-12-14T13:23:42Z","updated_at":"2018-12-14T14:54:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/status-im/nimbus/pulls/199","html_url":"https://github.com/status-im/nimbus/pull/199","diff_url":"https://github.com/status-im/nimbus/pull/199.diff","patch_url":"https://github.com/status-im/nimbus/pull/199.patch"},"body":"[this is in relation to https://github.com/status-im/nimbus/issues/198]\r\n\r\n- added some useful `chronicles` defines in the top-level nim.cfg\r\n- converted some assert() calls to doAssert() to avoid a reported\r\n  segfault with -d:release\r\n- the exceptions raised by doAssert() are being recovered from, in\r\n  eth_p2p\r\n- the only case that's a show stopper exits the program explicitly"},"comment":{"url":"https://api.github.com/repos/status-im/nimbus/issues/comments/447348529","html_url":"https://github.com/status-im/nimbus/pull/199#issuecomment-447348529","issue_url":"https://api.github.com/repos/status-im/nimbus/issues/199","id":447348529,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzM0ODUyOQ==","user":{"login":"mratsim","id":22738317,"node_id":"MDQ6VXNlcjIyNzM4MzE3","avatar_url":"https://avatars3.githubusercontent.com/u/22738317?v=4","gravatar_id":"","url":"https://api.github.com/users/mratsim","html_url":"https://github.com/mratsim","followers_url":"https://api.github.com/users/mratsim/followers","following_url":"https://api.github.com/users/mratsim/following{/other_user}","gists_url":"https://api.github.com/users/mratsim/gists{/gist_id}","starred_url":"https://api.github.com/users/mratsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mratsim/subscriptions","organizations_url":"https://api.github.com/users/mratsim/orgs","repos_url":"https://api.github.com/users/mratsim/repos","events_url":"https://api.github.com/users/mratsim/events{/privacy}","received_events_url":"https://api.github.com/users/mratsim/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T14:54:01Z","updated_at":"2018-12-14T14:54:01Z","author_association":"MEMBER","body":"I suggest we start to add `proc checkFoo` in one place like there: https://github.com/status-im/nimbus/blob/f8d3d0e721f836048719e216745091053af33c39/nimbus/errors.nim\r\n\r\nThose `checkFoo` should raise the proper error and be in charge of logging as well.\r\nI agree that asserts were used to detect bugs during rapid development and do not tag recoverable errors.\r\n\r\nThis is mentioned in this wiki page: https://github.com/status-im/nimbus/wiki/Exceptions-and-errors\r\n\r\n![2018-12-14_15-53-18](https://user-images.githubusercontent.com/22738317/50009883-63e7c880-ffb8-11e8-94cb-bb720835a3b9.png)\r\n\r\nI.e. once we are ready to recover from an error or exception, it should not be an assert anymore."}}
{"actor":{"display_login":"mratsim"}}