{"action":"closed","number":29955,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29955","id":224749653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzQ5NjUz","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29955","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29955.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29955.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29955","number":29955,"state":"closed","locked":false,"title":"Add makeup-keyboard-trap definitions","user":{"login":"darkwebdev","id":2737310,"node_id":"MDQ6VXNlcjI3MzczMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2737310?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwebdev","html_url":"https://github.com/darkwebdev","followers_url":"https://api.github.com/users/darkwebdev/followers","following_url":"https://api.github.com/users/darkwebdev/following{/other_user}","gists_url":"https://api.github.com/users/darkwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwebdev/subscriptions","organizations_url":"https://api.github.com/users/darkwebdev/orgs","repos_url":"https://api.github.com/users/darkwebdev/repos","events_url":"https://api.github.com/users/darkwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/darkwebdev/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [x] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [x] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [x] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n","created_at":"2018-10-22T17:17:00Z","updated_at":"2018-11-01T22:11:11Z","closed_at":"2018-11-01T22:11:11Z","merged_at":null,"merge_commit_sha":"aee6ff789159bad88ed9af49226596c9e623acf6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644095882,"node_id":"MDU6TGFiZWw2NDQwOTU4ODI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:YSYL","name":"Merge:YSYL","color":"bfdadc","default":false},{"id":646788888,"node_id":"MDU6TGFiZWw2NDY3ODg4ODg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/New%20Definition","name":"New Definition","color":"4eca56","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29955/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29955/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29955/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/ace7dbcd8b4b921b0cf81197b265e973eb34fd21","head":{"label":"darkwebdev:makeup-keyboard-trap","ref":"makeup-keyboard-trap","sha":"ace7dbcd8b4b921b0cf81197b265e973eb34fd21","user":{"login":"darkwebdev","id":2737310,"node_id":"MDQ6VXNlcjI3MzczMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2737310?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwebdev","html_url":"https://github.com/darkwebdev","followers_url":"https://api.github.com/users/darkwebdev/followers","following_url":"https://api.github.com/users/darkwebdev/following{/other_user}","gists_url":"https://api.github.com/users/darkwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwebdev/subscriptions","organizations_url":"https://api.github.com/users/darkwebdev/orgs","repos_url":"https://api.github.com/users/darkwebdev/repos","events_url":"https://api.github.com/users/darkwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/darkwebdev/received_events","type":"User","site_admin":false},"repo":{"id":110432863,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA0MzI4NjM=","name":"DefinitelyTyped","full_name":"darkwebdev/DefinitelyTyped","private":false,"owner":{"login":"darkwebdev","id":2737310,"node_id":"MDQ6VXNlcjI3MzczMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2737310?v=4","gravatar_id":"","url":"https://api.github.com/users/darkwebdev","html_url":"https://github.com/darkwebdev","followers_url":"https://api.github.com/users/darkwebdev/followers","following_url":"https://api.github.com/users/darkwebdev/following{/other_user}","gists_url":"https://api.github.com/users/darkwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/darkwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkwebdev/subscriptions","organizations_url":"https://api.github.com/users/darkwebdev/orgs","repos_url":"https://api.github.com/users/darkwebdev/repos","events_url":"https://api.github.com/users/darkwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/darkwebdev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/darkwebdev/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped","forks_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/darkwebdev/DefinitelyTyped/deployments","created_at":"2017-11-12T12:59:22Z","updated_at":"2018-10-29T12:51:00Z","pushed_at":"2018-10-30T12:39:15Z","git_url":"git://github.com/darkwebdev/DefinitelyTyped.git","ssh_url":"git@github.com:darkwebdev/DefinitelyTyped.git","clone_url":"https://github.com/darkwebdev/DefinitelyTyped.git","svn_url":"https://github.com/darkwebdev/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":372428,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"3ea5ad14c4b453916df64fbec2bf3530d15c9184","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-11-01T22:09:49Z","pushed_at":"2018-11-01T22:10:41Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":373144,"stargazers_count":18275,"watchers_count":18275,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15196,"mirror_url":null,"archived":false,"open_issues_count":2506,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15196,"open_issues":2506,"watchers":18275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29955"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29955"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29955"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/29955/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29955/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/29955/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/ace7dbcd8b4b921b0cf81197b265e973eb34fd21"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":43,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"DanielRosenwasser"}}