{"action":"opened","issue":{"url":"https://api.github.com/repos/nucypher/nucypher/issues/443","repository_url":"https://api.github.com/repos/nucypher/nucypher","labels_url":"https://api.github.com/repos/nucypher/nucypher/issues/443/labels{/name}","comments_url":"https://api.github.com/repos/nucypher/nucypher/issues/443/comments","events_url":"https://api.github.com/repos/nucypher/nucypher/issues/443/events","html_url":"https://github.com/nucypher/nucypher/issues/443","id":362672077,"node_id":"MDU6SXNzdWUzNjI2NzIwNzc=","number":443,"title":"Check that common name from acquired cert actually matches address.","user":{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-21T15:41:53Z","updated_at":"2018-09-21T15:41:53Z","closed_at":null,"author_association":"MEMBER","body":"We always set the common name on the cert to the checksum address of the node.  Cool - not particularly meaningful, but keeps things orderly.\r\n\r\nHowever, we never check that they match.  If they don't, we probably need to reject the cert and tell the node to get their house in order.\r\n\r\nThis isn't a security issue, just a housekeeping issue - we already check that the node has the keypair associated with the address (which we include separately in the bytes representation).  However, we don't want nodes spraying certs all over the network with addresses that don't match - let's keep it clean."}}
{"actor":{"display_login":"jMyles"}}