{"action":"created","issue":{"url":"https://api.github.com/repos/pingcap/tidb/issues/8625","repository_url":"https://api.github.com/repos/pingcap/tidb","labels_url":"https://api.github.com/repos/pingcap/tidb/issues/8625/labels{/name}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/8625/comments","events_url":"https://api.github.com/repos/pingcap/tidb/issues/8625/events","html_url":"https://github.com/pingcap/tidb/pull/8625","id":388957160,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDkwMDIw","number":8625,"title":"sessionctx: Error/warning on unsupported isolation levels","user":{"login":"morgo","id":57982,"node_id":"MDQ6VXNlcjU3OTgy","avatar_url":"https://avatars2.githubusercontent.com/u/57982?v=4","gravatar_id":"","url":"https://api.github.com/users/morgo","html_url":"https://github.com/morgo","followers_url":"https://api.github.com/users/morgo/followers","following_url":"https://api.github.com/users/morgo/following{/other_user}","gists_url":"https://api.github.com/users/morgo/gists{/gist_id}","starred_url":"https://api.github.com/users/morgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgo/subscriptions","organizations_url":"https://api.github.com/users/morgo/orgs","repos_url":"https://api.github.com/users/morgo/repos","events_url":"https://api.github.com/users/morgo/events{/privacy}","received_events_url":"https://api.github.com/users/morgo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-08T20:37:32Z","updated_at":"2018-12-09T16:32:33Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/8625","html_url":"https://github.com/pingcap/tidb/pull/8625","diff_url":"https://github.com/pingcap/tidb/pull/8625.diff","patch_url":"https://github.com/pingcap/tidb/pull/8625.patch"},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nFixes https://github.com/pingcap/tidb/issues/2712\r\n\r\n### What is changed and how it works?\r\n\r\nFor isolation levels, the following behavior is provided:\r\n- read-uncommitted: error (unsupported)\r\n- read-committed: warning (not recommended)\r\n- repeatable-read: clean\r\n- serializable: error (unsupported)\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n - Manual test (add detailed scripts or steps below)\r\n\r\nCode changes\r\n\r\n - minimal\r\n\r\nSide effects\r\n\r\n - Breaking backward compatibility (biggest risk: there may be some apps which check for warnings on read-committed which may break.  since we do not want to encourage read committed, we have to decide this is an intended consequence.)\r\n\r\nRelated changes\r\n\r\n - Need to update the documentation\r\n - Need to be included in the release note\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pingcap/tidb/8625)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/pingcap/tidb/issues/comments/445551526","html_url":"https://github.com/pingcap/tidb/pull/8625#issuecomment-445551526","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/8625","id":445551526,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTU1MTUyNg==","user":{"login":"morgo","id":57982,"node_id":"MDQ6VXNlcjU3OTgy","avatar_url":"https://avatars2.githubusercontent.com/u/57982?v=4","gravatar_id":"","url":"https://api.github.com/users/morgo","html_url":"https://github.com/morgo","followers_url":"https://api.github.com/users/morgo/followers","following_url":"https://api.github.com/users/morgo/following{/other_user}","gists_url":"https://api.github.com/users/morgo/gists{/gist_id}","starred_url":"https://api.github.com/users/morgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgo/subscriptions","organizations_url":"https://api.github.com/users/morgo/orgs","repos_url":"https://api.github.com/users/morgo/repos","events_url":"https://api.github.com/users/morgo/events{/privacy}","received_events_url":"https://api.github.com/users/morgo/received_events","type":"User","site_admin":false},"created_at":"2018-12-09T16:32:33Z","updated_at":"2018-12-09T16:32:33Z","author_association":"MEMBER","body":"I have changed `read-uncommitted` to be an error now, and updated the description.  `read-committed` also uses a new error class of `NotRecommended`."}}
{"actor":{"display_login":"morgo"}}