{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments/243279161","pull_request_review_id":187005471,"id":243279161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzI3OTE2MQ==","diff_hunk":"@@ -16,12 +16,12 @@ Deploy KubeVirt resources onto a cluster.\n |registry_url | docker.io | |Container image registry.|\n | storage_role | storage-none | <ul><li>storage-none</li><li>storage-demo</li><li>storage-glusterfs</li></ul> | Storage role to install with KubeVirt.|\n | network_role | network-multus | <ul><li>network-none</li><li>network-multus</li></ul> | Network role to install with KubeVirt.|\n-| version |0.9.6|<ul><li>0.9.6</li><li>0.8.0</li><li>0.7.0</li><li>0.6.0</li><li>0.5.0</li><li>0.4.1</li><li>0.4.0</li><li>0.3.0</li><li>0.2.0</li><li>0.1.0</li></ul>|KubeVirt release version.|\n+| version |v0.12.0-alpha.2|<ul><li>v0.12.0-alpha.2</li><li>0.9.6</li><li>0.8.0</li><li>0.7.0</li><li>0.6.0</li><li>0.5.0</li><li>0.4.1</li><li>0.4.0</li><li>0.3.0</li><li>0.2.0</li><li>0.1.0</li></ul>|KubeVirt release version.|\n |default_vm_templates|<ul><li>vm-template-fedora</li><li>vm-template-windows2012r2</li><li>vm-template-rhel7></ul>|| Default vm templates to deploy with KubeVirt.|\n |offline_template_dir| /opt/apb/kubevirt-templates || Offline VM template location specifed in the APB Dockerfile.|\n \n ### Usage\n \n ```\n-ansible-playbook -i inventory  -e version=0.8.0 -e apb_action=provision playbooks/kubevirt.yml\n+ansible-playbook -i inventory  -e version=v0.12.0-alpha.2 -e apb_action=provision playbooks/kubevirt.yml","path":"roles/kubevirt/README.md","position":13,"original_position":13,"commit_id":"f50c363eac9c36fa795eeb9da85306e3804ba73f","original_commit_id":"f50c363eac9c36fa795eeb9da85306e3804ba73f","user":{"login":"lukas-bednar","id":1505684,"node_id":"MDQ6VXNlcjE1MDU2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1505684?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-bednar","html_url":"https://github.com/lukas-bednar","followers_url":"https://api.github.com/users/lukas-bednar/followers","following_url":"https://api.github.com/users/lukas-bednar/following{/other_user}","gists_url":"https://api.github.com/users/lukas-bednar/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-bednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-bednar/subscriptions","organizations_url":"https://api.github.com/users/lukas-bednar/orgs","repos_url":"https://api.github.com/users/lukas-bednar/repos","events_url":"https://api.github.com/users/lukas-bednar/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-bednar/received_events","type":"User","site_admin":false},"body":"isn't here extra v?","created_at":"2018-12-20T13:55:37Z","updated_at":"2018-12-20T13:56:33Z","html_url":"https://github.com/kubevirt/kubevirt-ansible/pull/523#discussion_r243279161","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments/243279161"},"html":{"href":"https://github.com/kubevirt/kubevirt-ansible/pull/523#discussion_r243279161"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523","id":240174711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMTc0NzEx","html_url":"https://github.com/kubevirt/kubevirt-ansible/pull/523","diff_url":"https://github.com/kubevirt/kubevirt-ansible/pull/523.diff","patch_url":"https://github.com/kubevirt/kubevirt-ansible/pull/523.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/523","number":523,"state":"open","locked":false,"title":"Update kubevirt","user":{"login":"kbidarkar","id":373096,"node_id":"MDQ6VXNlcjM3MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/373096?v=4","gravatar_id":"","url":"https://api.github.com/users/kbidarkar","html_url":"https://github.com/kbidarkar","followers_url":"https://api.github.com/users/kbidarkar/followers","following_url":"https://api.github.com/users/kbidarkar/following{/other_user}","gists_url":"https://api.github.com/users/kbidarkar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbidarkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbidarkar/subscriptions","organizations_url":"https://api.github.com/users/kbidarkar/orgs","repos_url":"https://api.github.com/users/kbidarkar/repos","events_url":"https://api.github.com/users/kbidarkar/events{/privacy}","received_events_url":"https://api.github.com/users/kbidarkar/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**: updated kubevirt to v0.12.0-alpha.2\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:  If, ok, plan is to merge registryDisk related commits as separate PR in #522 \r\nCurrently I just cherry-picked those commits from that PR as  they are required for tests to PASS as there are some major API changes , where in registryDisk has been renamed to containerDisk.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```\r\nCNV-1.4 would most likely be based on 0.12 and hence updating kubevirt to it.\r\n\r\n```\r\n","created_at":"2018-12-20T13:42:33Z","updated_at":"2018-12-20T13:56:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c68754860666bfe539e47b0a035fbb8fe8b0b5e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1080239013,"node_id":"MDU6TGFiZWwxMDgwMjM5MDEz","url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":1080241986,"node_id":"MDU6TGFiZWwxMDgwMjQxOTg2","url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/523/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/statuses/f50c363eac9c36fa795eeb9da85306e3804ba73f","head":{"label":"kbidarkar:update-kubevirt","ref":"update-kubevirt","sha":"f50c363eac9c36fa795eeb9da85306e3804ba73f","user":{"login":"kbidarkar","id":373096,"node_id":"MDQ6VXNlcjM3MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/373096?v=4","gravatar_id":"","url":"https://api.github.com/users/kbidarkar","html_url":"https://github.com/kbidarkar","followers_url":"https://api.github.com/users/kbidarkar/followers","following_url":"https://api.github.com/users/kbidarkar/following{/other_user}","gists_url":"https://api.github.com/users/kbidarkar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbidarkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbidarkar/subscriptions","organizations_url":"https://api.github.com/users/kbidarkar/orgs","repos_url":"https://api.github.com/users/kbidarkar/repos","events_url":"https://api.github.com/users/kbidarkar/events{/privacy}","received_events_url":"https://api.github.com/users/kbidarkar/received_events","type":"User","site_admin":false},"repo":{"id":155906405,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5MDY0MDU=","name":"kubevirt-ansible","full_name":"kbidarkar/kubevirt-ansible","private":false,"owner":{"login":"kbidarkar","id":373096,"node_id":"MDQ6VXNlcjM3MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/373096?v=4","gravatar_id":"","url":"https://api.github.com/users/kbidarkar","html_url":"https://github.com/kbidarkar","followers_url":"https://api.github.com/users/kbidarkar/followers","following_url":"https://api.github.com/users/kbidarkar/following{/other_user}","gists_url":"https://api.github.com/users/kbidarkar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbidarkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbidarkar/subscriptions","organizations_url":"https://api.github.com/users/kbidarkar/orgs","repos_url":"https://api.github.com/users/kbidarkar/repos","events_url":"https://api.github.com/users/kbidarkar/events{/privacy}","received_events_url":"https://api.github.com/users/kbidarkar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kbidarkar/kubevirt-ansible","description":"Set of Ansible roles & playbooks for KubeVirt deployment","fork":true,"url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible","forks_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/forks","keys_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/teams","hooks_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/hooks","issue_events_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/events","assignees_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/tags","blobs_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/languages","stargazers_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/stargazers","contributors_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/contributors","subscribers_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/subscribers","subscription_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/subscription","commits_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/merges","archive_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/downloads","issues_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/labels{/name}","releases_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/kbidarkar/kubevirt-ansible/deployments","created_at":"2018-11-02T18:27:26Z","updated_at":"2018-11-02T18:27:29Z","pushed_at":"2018-12-20T13:48:44Z","git_url":"git://github.com/kbidarkar/kubevirt-ansible.git","ssh_url":"git@github.com:kbidarkar/kubevirt-ansible.git","clone_url":"https://github.com/kbidarkar/kubevirt-ansible.git","svn_url":"https://github.com/kbidarkar/kubevirt-ansible","homepage":"","size":80165,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"a1a44831c9f52c42ddd71f39a010c574a85b3997","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":103531813,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1MzE4MTM=","name":"kubevirt-ansible","full_name":"kubevirt/kubevirt-ansible","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/kubevirt-ansible","description":"Set of Ansible roles & playbooks for KubeVirt deployment","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt-ansible","forks_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt-ansible/deployments","created_at":"2017-09-14T12:52:28Z","updated_at":"2018-12-18T18:29:00Z","pushed_at":"2018-12-20T13:48:46Z","git_url":"git://github.com/kubevirt/kubevirt-ansible.git","ssh_url":"git@github.com:kubevirt/kubevirt-ansible.git","clone_url":"https://github.com/kubevirt/kubevirt-ansible.git","svn_url":"https://github.com/kubevirt/kubevirt-ansible","homepage":"","size":80166,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":60,"open_issues":62,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523"},"html":{"href":"https://github.com/kubevirt/kubevirt-ansible/pull/523"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/523"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt-ansible/statuses/f50c363eac9c36fa795eeb9da85306e3804ba73f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lukas-bednar"}}