{"action":"created","comment":{"url":"https://api.github.com/repos/cw75/tiered-storage/pulls/comments/203204785","pull_request_review_id":138048895,"id":203204785,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzIwNDc4NQ==","diff_hunk":"@@ -37,5 +36,5 @@ void seed_handler(\n \n   std::string serialized;\n   membership.SerializeToString(&serialized);\n-  zmq_util::send_string(serialized, addr_responder);\n+  return serialized;","path":"src/bedrock/route/seed_handler.cpp","position":20,"original_position":20,"commit_id":"788a12cae7369131bb9630e633b5ff6457583c18","original_commit_id":"788a12cae7369131bb9630e633b5ff6457583c18","user":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"body":"because we decided to not include the zmq socket in the handler","created_at":"2018-07-17T22:44:35Z","updated_at":"2018-07-17T22:44:36Z","html_url":"https://github.com/cw75/tiered-storage/pull/102#discussion_r203204785","pull_request_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/102","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/comments/203204785"},"html":{"href":"https://github.com/cw75/tiered-storage/pull/102#discussion_r203204785"},"pull_request":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/102"}},"in_reply_to_id":202896277},"pull_request":{"url":"https://api.github.com/repos/cw75/tiered-storage/pulls/102","id":201792683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzkyNjgz","html_url":"https://github.com/cw75/tiered-storage/pull/102","diff_url":"https://github.com/cw75/tiered-storage/pull/102.diff","patch_url":"https://github.com/cw75/tiered-storage/pull/102.patch","issue_url":"https://api.github.com/repos/cw75/tiered-storage/issues/102","number":102,"state":"open","locked":false,"title":"Mock","user":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"body":"1. removed zmq socket arguments from the handlers\r\n2. set up google test framework for unit testing\r\n3. mock `send_string` and `get_responsible_threads`\r\n4. basic lattice test should work\r\n5. add very simple tests for some server handlers (node join, node depart, self depart)\r\n6. logger is disabled but not mocked (opens \"mock.txt\" and write nothing)\r\n7. refactor functions in `hash_ring.hpp`\r\n8. wrapped all functions in `hash_ring.hpp` and `zmq_util.hpp` in classes","created_at":"2018-07-17T00:12:16Z","updated_at":"2018-07-17T22:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24c4007b53080e7bc1aedcde696c425a4fb46dc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/102/commits","review_comments_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/102/comments","review_comment_url":"https://api.github.com/repos/cw75/tiered-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cw75/tiered-storage/issues/102/comments","statuses_url":"https://api.github.com/repos/cw75/tiered-storage/statuses/788a12cae7369131bb9630e633b5ff6457583c18","head":{"label":"cw75:mock","ref":"mock","sha":"788a12cae7369131bb9630e633b5ff6457583c18","user":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"repo":{"id":59505746,"node_id":"MDEwOlJlcG9zaXRvcnk1OTUwNTc0Ng==","name":"tiered-storage","full_name":"cw75/tiered-storage","owner":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cw75/tiered-storage","description":"An Elastic, Tiered-Storage Service","fork":false,"url":"https://api.github.com/repos/cw75/tiered-storage","forks_url":"https://api.github.com/repos/cw75/tiered-storage/forks","keys_url":"https://api.github.com/repos/cw75/tiered-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cw75/tiered-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cw75/tiered-storage/teams","hooks_url":"https://api.github.com/repos/cw75/tiered-storage/hooks","issue_events_url":"https://api.github.com/repos/cw75/tiered-storage/issues/events{/number}","events_url":"https://api.github.com/repos/cw75/tiered-storage/events","assignees_url":"https://api.github.com/repos/cw75/tiered-storage/assignees{/user}","branches_url":"https://api.github.com/repos/cw75/tiered-storage/branches{/branch}","tags_url":"https://api.github.com/repos/cw75/tiered-storage/tags","blobs_url":"https://api.github.com/repos/cw75/tiered-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cw75/tiered-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cw75/tiered-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/cw75/tiered-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cw75/tiered-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/cw75/tiered-storage/languages","stargazers_url":"https://api.github.com/repos/cw75/tiered-storage/stargazers","contributors_url":"https://api.github.com/repos/cw75/tiered-storage/contributors","subscribers_url":"https://api.github.com/repos/cw75/tiered-storage/subscribers","subscription_url":"https://api.github.com/repos/cw75/tiered-storage/subscription","commits_url":"https://api.github.com/repos/cw75/tiered-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/cw75/tiered-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/cw75/tiered-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/cw75/tiered-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/cw75/tiered-storage/contents/{+path}","compare_url":"https://api.github.com/repos/cw75/tiered-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cw75/tiered-storage/merges","archive_url":"https://api.github.com/repos/cw75/tiered-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cw75/tiered-storage/downloads","issues_url":"https://api.github.com/repos/cw75/tiered-storage/issues{/number}","pulls_url":"https://api.github.com/repos/cw75/tiered-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/cw75/tiered-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/cw75/tiered-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cw75/tiered-storage/labels{/name}","releases_url":"https://api.github.com/repos/cw75/tiered-storage/releases{/id}","deployments_url":"https://api.github.com/repos/cw75/tiered-storage/deployments","created_at":"2016-05-23T17:50:34Z","updated_at":"2018-07-17T21:01:55Z","pushed_at":"2018-07-17T21:01:53Z","git_url":"git://github.com/cw75/tiered-storage.git","ssh_url":"git@github.com:cw75/tiered-storage.git","clone_url":"https://github.com/cw75/tiered-storage.git","svn_url":"https://github.com/cw75/tiered-storage","homepage":"","size":4926,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":14,"watchers":19,"default_branch":"master"}},"base":{"label":"cw75:master","ref":"master","sha":"40f058e2e8aed3da22d86927fe09a12a6639fcae","user":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"repo":{"id":59505746,"node_id":"MDEwOlJlcG9zaXRvcnk1OTUwNTc0Ng==","name":"tiered-storage","full_name":"cw75/tiered-storage","owner":{"login":"cw75","id":6820919,"node_id":"MDQ6VXNlcjY4MjA5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6820919?v=4","gravatar_id":"","url":"https://api.github.com/users/cw75","html_url":"https://github.com/cw75","followers_url":"https://api.github.com/users/cw75/followers","following_url":"https://api.github.com/users/cw75/following{/other_user}","gists_url":"https://api.github.com/users/cw75/gists{/gist_id}","starred_url":"https://api.github.com/users/cw75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw75/subscriptions","organizations_url":"https://api.github.com/users/cw75/orgs","repos_url":"https://api.github.com/users/cw75/repos","events_url":"https://api.github.com/users/cw75/events{/privacy}","received_events_url":"https://api.github.com/users/cw75/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cw75/tiered-storage","description":"An Elastic, Tiered-Storage Service","fork":false,"url":"https://api.github.com/repos/cw75/tiered-storage","forks_url":"https://api.github.com/repos/cw75/tiered-storage/forks","keys_url":"https://api.github.com/repos/cw75/tiered-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cw75/tiered-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cw75/tiered-storage/teams","hooks_url":"https://api.github.com/repos/cw75/tiered-storage/hooks","issue_events_url":"https://api.github.com/repos/cw75/tiered-storage/issues/events{/number}","events_url":"https://api.github.com/repos/cw75/tiered-storage/events","assignees_url":"https://api.github.com/repos/cw75/tiered-storage/assignees{/user}","branches_url":"https://api.github.com/repos/cw75/tiered-storage/branches{/branch}","tags_url":"https://api.github.com/repos/cw75/tiered-storage/tags","blobs_url":"https://api.github.com/repos/cw75/tiered-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cw75/tiered-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cw75/tiered-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/cw75/tiered-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cw75/tiered-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/cw75/tiered-storage/languages","stargazers_url":"https://api.github.com/repos/cw75/tiered-storage/stargazers","contributors_url":"https://api.github.com/repos/cw75/tiered-storage/contributors","subscribers_url":"https://api.github.com/repos/cw75/tiered-storage/subscribers","subscription_url":"https://api.github.com/repos/cw75/tiered-storage/subscription","commits_url":"https://api.github.com/repos/cw75/tiered-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/cw75/tiered-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/cw75/tiered-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/cw75/tiered-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/cw75/tiered-storage/contents/{+path}","compare_url":"https://api.github.com/repos/cw75/tiered-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cw75/tiered-storage/merges","archive_url":"https://api.github.com/repos/cw75/tiered-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cw75/tiered-storage/downloads","issues_url":"https://api.github.com/repos/cw75/tiered-storage/issues{/number}","pulls_url":"https://api.github.com/repos/cw75/tiered-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/cw75/tiered-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/cw75/tiered-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cw75/tiered-storage/labels{/name}","releases_url":"https://api.github.com/repos/cw75/tiered-storage/releases{/id}","deployments_url":"https://api.github.com/repos/cw75/tiered-storage/deployments","created_at":"2016-05-23T17:50:34Z","updated_at":"2018-07-17T21:01:55Z","pushed_at":"2018-07-17T21:01:53Z","git_url":"git://github.com/cw75/tiered-storage.git","ssh_url":"git@github.com:cw75/tiered-storage.git","clone_url":"https://github.com/cw75/tiered-storage.git","svn_url":"https://github.com/cw75/tiered-storage","homepage":"","size":4926,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":14,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/102"},"html":{"href":"https://github.com/cw75/tiered-storage/pull/102"},"issue":{"href":"https://api.github.com/repos/cw75/tiered-storage/issues/102"},"comments":{"href":"https://api.github.com/repos/cw75/tiered-storage/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cw75/tiered-storage/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/cw75/tiered-storage/statuses/788a12cae7369131bb9630e633b5ff6457583c18"}},"author_association":"OWNER"}}
{"actor":{"display_login":"cw75"}}