{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/14198","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/14198/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/14198/comments","events_url":"https://api.github.com/repos/facebook/react/issues/14198/events","html_url":"https://github.com/facebook/react/pull/14198","id":379902636,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjMwMjQx","number":14198,"title":"Fix findDOMNode incorrectly failing inside Suspense","user":{"login":"gaearon","id":810438,"node_id":"MDQ6VXNlcjgxMDQzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/810438?v=4","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-12T18:35:42Z","updated_at":"2018-12-07T04:01:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/14198","html_url":"https://github.com/facebook/react/pull/14198","diff_url":"https://github.com/facebook/react/pull/14198.diff","patch_url":"https://github.com/facebook/react/pull/14198.patch"},"body":"Builds on https://github.com/facebook/react/pull/14197. Second test ~~is failing~~ is now fixed.\r\n\r\nBased on the test in https://github.com/facebook/react/issues/14188#issuecomment-437705392 found by @arianon. Unlike the issue from https://github.com/facebook/react/pull/14197, this one seems like it existed even before the Suspense refactorings. So maybe it was always there."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/445115657","html_url":"https://github.com/facebook/react/pull/14198#issuecomment-445115657","issue_url":"https://api.github.com/repos/facebook/react/issues/14198","id":445115657,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTExNTY1Nw==","user":{"login":"sebmarkbage","id":63648,"node_id":"MDQ6VXNlcjYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T04:01:15Z","updated_at":"2018-12-07T04:01:15Z","author_association":"MEMBER","body":"I need to take 7 hours to think about this. Not so sure about this.\r\n\r\nBut also if you don’t want it to error you should test that the return value is what you expect it to be.\r\n\r\nIt’s better to error than return the wrong value. "}}
{"actor":{"display_login":"sebmarkbage"}}