{"action":"reopened","issue":{"url":"https://api.github.com/repos/concrete5/cloudflare_proxy/issues/2","repository_url":"https://api.github.com/repos/concrete5/cloudflare_proxy","labels_url":"https://api.github.com/repos/concrete5/cloudflare_proxy/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/cloudflare_proxy/issues/2/comments","events_url":"https://api.github.com/repos/concrete5/cloudflare_proxy/issues/2/events","html_url":"https://github.com/concrete5/cloudflare_proxy/issues/2","id":328466292,"node_id":"MDU6SXNzdWUzMjg0NjYyOTI=","number":2,"title":"Use default concrete.security.trusted_proxies.ips configuration key?","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-01T10:31:44Z","updated_at":"2018-06-01T17:45:56Z","closed_at":null,"author_association":"NONE","body":"[Since version 8.0.0](https://github.com/concrete5/concrete5/blob/8.0/concrete/src/Foundation/Runtime/Boot/DefaultBooter.php#L358), concrete5 calls `Request::setTrustedProxies` when it boots, reading the `concrete.security.trusted_proxies.ips` configuration key.\r\n\r\nSince this `cloudflare_proxy` package requires concrete5 8.2.0+, is there any reason to save the trusted IPs in another configuration key and call `Request::setTrustedProxies` another time?"}}
{"actor":{"display_login":"KorvinSzanto"}}