{"action":"closed","issue":{"url":"https://api.github.com/repos/Azure/autorest.typescript/issues/40","repository_url":"https://api.github.com/repos/Azure/autorest.typescript","labels_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/40/comments","events_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/40/events","html_url":"https://github.com/Azure/autorest.typescript/issues/40","id":308373589,"number":40,"title":"Determine what types to use for stream request/response bodies on browser and Node","user":{"login":"RikkiGibson","id":5833655,"avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-25T18:36:50Z","updated_at":"2018-04-20T22:07:41Z","closed_at":"2018-04-20T22:07:41Z","author_association":"MEMBER","body":"I noticed the generated return type for getFile() is a `Response` type which requires we compile with the `lib: [\"dom\", ...]` argument in tsconfig.json. I don't think this is quite right as I can see that the [test case](https://github.com/Azure/autorest.typescript/blob/2cac0b1efd1e4a213d49fed03f11316f486828a0/test/vanilla/AcceptanceTests/acceptanceTests.ts#L1809) requires type asserting the response as `any`.\r\n\r\nAt a glance it looks like the `\"dom\"` lib adds all the DOM-only APIs to the global scope. We probably don't want that in an isomorphic lib, right? I'm not going to track that down yet as part of my \"make CI pass\" work, but we'll want to address it at some point because good server and browser interchangeable APIs for streaming I/O will be needed."}}
{"actor":{"display_login":"RikkiGibson"}}