{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/217961558","pull_request_review_id":155793860,"id":217961558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzk2MTU1OA==","diff_hunk":"@@ -0,0 +1,96 @@\n+/*\n+ * Licensed to Elasticsearch under one or more contributor\n+ * license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright\n+ * ownership. Elasticsearch licenses this file to you under\n+ * the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package org.elasticsearch.client.security.support.expressiondsl.fields;\n+\n+import org.elasticsearch.client.security.support.expressiondsl.RoleMapperExpression;\n+import org.elasticsearch.common.xcontent.XContentBuilder;\n+\n+import java.io.IOException;\n+import java.util.Arrays;\n+import java.util.Collections;\n+import java.util.List;\n+import java.util.Objects;\n+\n+/**\n+ * An expression that evaluates to <code>true</code> if a field (map element) matches\n+ * the provided values. A <em>field</em> expression may have more than one provided value, in which\n+ * case the expression is true if <em>any</em> of the values are matched.\n+ */\n+public abstract class FieldExpressionBase implements RoleMapperExpression {","path":"client/rest-high-level/src/main/java/org/elasticsearch/client/security/support/expressiondsl/fields/FieldExpressionBase.java","position":36,"original_position":36,"commit_id":"8df2db74b7ead5061bc9f03b2850b7b655a7b1f1","original_commit_id":"8df2db74b7ead5061bc9f03b2850b7b655a7b1f1","user":{"login":"tvernum","id":2244393,"node_id":"MDQ6VXNlcjIyNDQzOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2244393?v=4","gravatar_id":"","url":"https://api.github.com/users/tvernum","html_url":"https://github.com/tvernum","followers_url":"https://api.github.com/users/tvernum/followers","following_url":"https://api.github.com/users/tvernum/following{/other_user}","gists_url":"https://api.github.com/users/tvernum/gists{/gist_id}","starred_url":"https://api.github.com/users/tvernum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvernum/subscriptions","organizations_url":"https://api.github.com/users/tvernum/orgs","repos_url":"https://api.github.com/users/tvernum/repos","events_url":"https://api.github.com/users/tvernum/events{/privacy}","received_events_url":"https://api.github.com/users/tvernum/received_events","type":"User","site_admin":false},"body":"What's the purpose of having different types for the different fields? The JSON isn't any different based on the field type...","created_at":"2018-09-17T06:43:54Z","updated_at":"2018-09-17T06:49:28Z","html_url":"https://github.com/elastic/elasticsearch/pull/33745#discussion_r217961558","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/217961558"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/33745#discussion_r217961558"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745","id":215881624,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODgxNjI0","html_url":"https://github.com/elastic/elasticsearch/pull/33745","diff_url":"https://github.com/elastic/elasticsearch/pull/33745.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/33745.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33745","number":33745,"state":"open","locked":false,"title":"[HLRC] Support for role mapper expression dsl","user":{"login":"bizybot","id":902768,"node_id":"MDQ6VXNlcjkwMjc2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/902768?v=4","gravatar_id":"","url":"https://api.github.com/users/bizybot","html_url":"https://github.com/bizybot","followers_url":"https://api.github.com/users/bizybot/followers","following_url":"https://api.github.com/users/bizybot/following{/other_user}","gists_url":"https://api.github.com/users/bizybot/gists{/gist_id}","starred_url":"https://api.github.com/users/bizybot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bizybot/subscriptions","organizations_url":"https://api.github.com/users/bizybot/orgs","repos_url":"https://api.github.com/users/bizybot/repos","events_url":"https://api.github.com/users/bizybot/events{/privacy}","received_events_url":"https://api.github.com/users/bizybot/received_events","type":"User","site_admin":false},"body":"This commit adds support for role mapping expression dsl.\r\nFunctionally it is similar to what we have on the server side\r\nexcept for the rule evaluation which is not required on the client.\r\n\r\nThe role mapper expression can either be field expression or\r\ncomposite expression of one or more expressions. Role mapper\r\nexpression parser is used to parse json dsl to list of expressions.\r\n\r\nThis forms the base for role mapping APIs (get, post/put and delete)","created_at":"2018-09-17T06:18:47Z","updated_at":"2018-09-17T06:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c96f613c15b770c569249856b8945c80addcdd5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jkakavas","id":10281256,"node_id":"MDQ6VXNlcjEwMjgxMjU2","avatar_url":"https://avatars2.githubusercontent.com/u/10281256?v=4","gravatar_id":"","url":"https://api.github.com/users/jkakavas","html_url":"https://github.com/jkakavas","followers_url":"https://api.github.com/users/jkakavas/followers","following_url":"https://api.github.com/users/jkakavas/following{/other_user}","gists_url":"https://api.github.com/users/jkakavas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkakavas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkakavas/subscriptions","organizations_url":"https://api.github.com/users/jkakavas/orgs","repos_url":"https://api.github.com/users/jkakavas/repos","events_url":"https://api.github.com/users/jkakavas/events{/privacy}","received_events_url":"https://api.github.com/users/jkakavas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":493198109,"node_id":"MDU6TGFiZWw0OTMxOTgxMDk=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Core/Java%20High%20Level%20REST%20Client","name":":Core/Java High Level REST Client","color":"0e8a16","default":false},{"id":912838209,"node_id":"MDU6TGFiZWw5MTI4MzgyMDk=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Security/Authorization","name":":Security/Authorization","color":"0e8a16","default":false},{"id":962378555,"node_id":"MDU6TGFiZWw5NjIzNzg1NTU=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.5.0","name":"v6.5.0","color":"Dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33745/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/8df2db74b7ead5061bc9f03b2850b7b655a7b1f1","head":{"label":"bizybot:expressiondsl-hl-api","ref":"expressiondsl-hl-api","sha":"8df2db74b7ead5061bc9f03b2850b7b655a7b1f1","user":{"login":"bizybot","id":902768,"node_id":"MDQ6VXNlcjkwMjc2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/902768?v=4","gravatar_id":"","url":"https://api.github.com/users/bizybot","html_url":"https://github.com/bizybot","followers_url":"https://api.github.com/users/bizybot/followers","following_url":"https://api.github.com/users/bizybot/following{/other_user}","gists_url":"https://api.github.com/users/bizybot/gists{/gist_id}","starred_url":"https://api.github.com/users/bizybot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bizybot/subscriptions","organizations_url":"https://api.github.com/users/bizybot/orgs","repos_url":"https://api.github.com/users/bizybot/repos","events_url":"https://api.github.com/users/bizybot/events{/privacy}","received_events_url":"https://api.github.com/users/bizybot/received_events","type":"User","site_admin":false},"repo":{"id":116604667,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY2MDQ2Njc=","name":"elasticsearch","full_name":"bizybot/elasticsearch","private":false,"owner":{"login":"bizybot","id":902768,"node_id":"MDQ6VXNlcjkwMjc2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/902768?v=4","gravatar_id":"","url":"https://api.github.com/users/bizybot","html_url":"https://github.com/bizybot","followers_url":"https://api.github.com/users/bizybot/followers","following_url":"https://api.github.com/users/bizybot/following{/other_user}","gists_url":"https://api.github.com/users/bizybot/gists{/gist_id}","starred_url":"https://api.github.com/users/bizybot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bizybot/subscriptions","organizations_url":"https://api.github.com/users/bizybot/orgs","repos_url":"https://api.github.com/users/bizybot/repos","events_url":"https://api.github.com/users/bizybot/events{/privacy}","received_events_url":"https://api.github.com/users/bizybot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bizybot/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/bizybot/elasticsearch","forks_url":"https://api.github.com/repos/bizybot/elasticsearch/forks","keys_url":"https://api.github.com/repos/bizybot/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bizybot/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bizybot/elasticsearch/teams","hooks_url":"https://api.github.com/repos/bizybot/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/bizybot/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/bizybot/elasticsearch/events","assignees_url":"https://api.github.com/repos/bizybot/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/bizybot/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/bizybot/elasticsearch/tags","blobs_url":"https://api.github.com/repos/bizybot/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bizybot/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bizybot/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/bizybot/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bizybot/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/bizybot/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/bizybot/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/bizybot/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/bizybot/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/bizybot/elasticsearch/subscription","commits_url":"https://api.github.com/repos/bizybot/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/bizybot/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/bizybot/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/bizybot/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/bizybot/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/bizybot/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bizybot/elasticsearch/merges","archive_url":"https://api.github.com/repos/bizybot/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bizybot/elasticsearch/downloads","issues_url":"https://api.github.com/repos/bizybot/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/bizybot/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/bizybot/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/bizybot/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bizybot/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/bizybot/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/bizybot/elasticsearch/deployments","created_at":"2018-01-07T22:38:15Z","updated_at":"2018-09-16T23:20:29Z","pushed_at":"2018-09-17T05:47:09Z","git_url":"git://github.com/bizybot/elasticsearch.git","ssh_url":"git@github.com:bizybot/elasticsearch.git","clone_url":"https://github.com/bizybot/elasticsearch.git","svn_url":"https://github.com/bizybot/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":501609,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"34379887b4734f713db0e01b48835c5e7384d9ad","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-09-17T06:36:28Z","pushed_at":"2018-09-17T06:18:48Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":513017,"stargazers_count":34420,"watchers_count":34420,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11681,"mirror_url":null,"archived":false,"open_issues_count":1649,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11681,"open_issues":1649,"watchers":34420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/33745"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/33745"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/33745/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/33745/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/8df2db74b7ead5061bc9f03b2850b7b655a7b1f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tvernum"}}