{"action":"created","issue":{"url":"https://api.github.com/repos/ant-design/ant-design/issues/12714","repository_url":"https://api.github.com/repos/ant-design/ant-design","labels_url":"https://api.github.com/repos/ant-design/ant-design/issues/12714/labels{/name}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/12714/comments","events_url":"https://api.github.com/repos/ant-design/ant-design/issues/12714/events","html_url":"https://github.com/ant-design/ant-design/issues/12714","id":371533547,"node_id":"MDU6SXNzdWUzNzE1MzM1NDc=","number":12714,"title":"[Tabs] onChange method is firing when activeKey doesn't change","user":{"login":"byzyk","id":1867692,"node_id":"MDQ6VXNlcjE4Njc2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1867692?v=4","gravatar_id":"","url":"https://api.github.com/users/byzyk","html_url":"https://github.com/byzyk","followers_url":"https://api.github.com/users/byzyk/followers","following_url":"https://api.github.com/users/byzyk/following{/other_user}","gists_url":"https://api.github.com/users/byzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/byzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byzyk/subscriptions","organizations_url":"https://api.github.com/users/byzyk/orgs","repos_url":"https://api.github.com/users/byzyk/repos","events_url":"https://api.github.com/users/byzyk/events{/privacy}","received_events_url":"https://api.github.com/users/byzyk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"yesmeck","id":465125,"node_id":"MDQ6VXNlcjQ2NTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/465125?v=4","gravatar_id":"","url":"https://api.github.com/users/yesmeck","html_url":"https://github.com/yesmeck","followers_url":"https://api.github.com/users/yesmeck/followers","following_url":"https://api.github.com/users/yesmeck/following{/other_user}","gists_url":"https://api.github.com/users/yesmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/yesmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesmeck/subscriptions","organizations_url":"https://api.github.com/users/yesmeck/orgs","repos_url":"https://api.github.com/users/yesmeck/repos","events_url":"https://api.github.com/users/yesmeck/events{/privacy}","received_events_url":"https://api.github.com/users/yesmeck/received_events","type":"User","site_admin":false},"assignees":[{"login":"yesmeck","id":465125,"node_id":"MDQ6VXNlcjQ2NTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/465125?v=4","gravatar_id":"","url":"https://api.github.com/users/yesmeck","html_url":"https://github.com/yesmeck","followers_url":"https://api.github.com/users/yesmeck/followers","following_url":"https://api.github.com/users/yesmeck/following{/other_user}","gists_url":"https://api.github.com/users/yesmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/yesmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesmeck/subscriptions","organizations_url":"https://api.github.com/users/yesmeck/orgs","repos_url":"https://api.github.com/users/yesmeck/repos","events_url":"https://api.github.com/users/yesmeck/events{/privacy}","received_events_url":"https://api.github.com/users/yesmeck/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-18T13:34:51Z","updated_at":"2018-10-18T16:29:04Z","closed_at":"2018-10-18T15:22:02Z","author_association":"CONTRIBUTOR","body":"- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.\r\n\r\n### Version\r\n3.10.1\r\n\r\n### Environment\r\nmacOS 10.13.6, Chrome 69, react: ^16.3.1\r\n\r\n### Reproduction link\r\n[![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/lxlm00328l)\r\n\r\n### Steps to reproduce\r\nTry to click on `Second` tab. It will prevent tabs from changing since bounded to the component state via `activeKey`\r\n\r\n### What is expected?\r\nTabs don't change, `onChange` callback **is not** firing\r\n\r\n### What is actually happening?\r\nTabs don't change, `onChange` callback **is** firing\r\n\r\n\r\n<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->"},"comment":{"url":"https://api.github.com/repos/ant-design/ant-design/issues/comments/431075513","html_url":"https://github.com/ant-design/ant-design/issues/12714#issuecomment-431075513","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/12714","id":431075513,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTA3NTUxMw==","user":{"login":"byzyk","id":1867692,"node_id":"MDQ6VXNlcjE4Njc2OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1867692?v=4","gravatar_id":"","url":"https://api.github.com/users/byzyk","html_url":"https://github.com/byzyk","followers_url":"https://api.github.com/users/byzyk/followers","following_url":"https://api.github.com/users/byzyk/following{/other_user}","gists_url":"https://api.github.com/users/byzyk/gists{/gist_id}","starred_url":"https://api.github.com/users/byzyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byzyk/subscriptions","organizations_url":"https://api.github.com/users/byzyk/orgs","repos_url":"https://api.github.com/users/byzyk/repos","events_url":"https://api.github.com/users/byzyk/events{/privacy}","received_events_url":"https://api.github.com/users/byzyk/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T16:29:04Z","updated_at":"2018-10-18T16:29:04Z","author_association":"CONTRIBUTOR","body":"@afc163 I see, but could you explain why it's implemented in such way? `onChange` triggers while nothing actually changed, it doesn't really make sense to me but perhaps I'm missing something."}}
{"actor":{"display_login":"byzyk"}}