{"action":"created","comment":{"url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments/205855375","pull_request_review_id":141213922,"id":205855375,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTg1NTM3NQ==","diff_hunk":"@@ -326,7 +326,10 @@ noit_metric_tagset_is_taggable_key(const char *val, size_t len)\n mtev_boolean\n noit_metric_tagset_is_taggable_value(const char *val, size_t len)\n {\n-  return noit_metric_tagset_is_taggable_part(val, len, noit_metric_tagset_is_taggable_value_char);\n+  /* accept blank string, blank base64 encoded string, and acceptable taggable_value_chars as values */\n+  return len == 0 ||\n+    memcmp(\"b\\\"\\\"\", val, MIN(len,3)) == 0 ||","path":"src/noit_metric.c","position":7,"original_position":7,"commit_id":"bcf6b3435e5bac5405f62adaf8c41fa6e573d8a1","original_commit_id":"bcf6b3435e5bac5405f62adaf8c41fa6e573d8a1","user":{"login":"postwait","id":335748,"node_id":"MDQ6VXNlcjMzNTc0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/335748?v=4","gravatar_id":"","url":"https://api.github.com/users/postwait","html_url":"https://github.com/postwait","followers_url":"https://api.github.com/users/postwait/followers","following_url":"https://api.github.com/users/postwait/following{/other_user}","gists_url":"https://api.github.com/users/postwait/gists{/gist_id}","starred_url":"https://api.github.com/users/postwait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postwait/subscriptions","organizations_url":"https://api.github.com/users/postwait/orgs","repos_url":"https://api.github.com/users/postwait/repos","events_url":"https://api.github.com/users/postwait/events{/privacy}","received_events_url":"https://api.github.com/users/postwait/received_events","type":"User","site_admin":false},"body":"This will match `\"b\"` and `b\"`...\r\n\r\nYou want `(len == 3 && memcmp(\"b\\\"\\\"\", val, 3))`","created_at":"2018-07-27T18:04:54Z","updated_at":"2018-07-27T18:05:00Z","html_url":"https://github.com/circonus-labs/reconnoiter/pull/471#discussion_r205855375","pull_request_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments/205855375"},"html":{"href":"https://github.com/circonus-labs/reconnoiter/pull/471#discussion_r205855375"},"pull_request":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471","id":204247149,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjQ3MTQ5","html_url":"https://github.com/circonus-labs/reconnoiter/pull/471","diff_url":"https://github.com/circonus-labs/reconnoiter/pull/471.diff","patch_url":"https://github.com/circonus-labs/reconnoiter/pull/471.patch","issue_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/471","number":471,"state":"open","locked":false,"title":"accept tags with a category but a blank value","user":{"login":"rileyberton","id":2903565,"node_id":"MDQ6VXNlcjI5MDM1NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2903565?v=4","gravatar_id":"","url":"https://api.github.com/users/rileyberton","html_url":"https://github.com/rileyberton","followers_url":"https://api.github.com/users/rileyberton/followers","following_url":"https://api.github.com/users/rileyberton/following{/other_user}","gists_url":"https://api.github.com/users/rileyberton/gists{/gist_id}","starred_url":"https://api.github.com/users/rileyberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rileyberton/subscriptions","organizations_url":"https://api.github.com/users/rileyberton/orgs","repos_url":"https://api.github.com/users/rileyberton/repos","events_url":"https://api.github.com/users/rileyberton/events{/privacy}","received_events_url":"https://api.github.com/users/rileyberton/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-26T19:44:42Z","updated_at":"2018-07-27T18:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be28548f413cbec4e4d62876b130a3131d01111","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471/commits","review_comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471/comments","review_comment_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/471/comments","statuses_url":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/bcf6b3435e5bac5405f62adaf8c41fa6e573d8a1","head":{"label":"circonus-labs:allow_blank_tag_value","ref":"allow_blank_tag_value","sha":"bcf6b3435e5bac5405f62adaf8c41fa6e573d8a1","user":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":1585344,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg1MzQ0","name":"reconnoiter","full_name":"circonus-labs/reconnoiter","owner":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circonus-labs/reconnoiter","description":"Large-scale Monitoring and Trend Analysis System","fork":false,"url":"https://api.github.com/repos/circonus-labs/reconnoiter","forks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/forks","keys_url":"https://api.github.com/repos/circonus-labs/reconnoiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circonus-labs/reconnoiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circonus-labs/reconnoiter/teams","hooks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/hooks","issue_events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/events{/number}","events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/events","assignees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/assignees{/user}","branches_url":"https://api.github.com/repos/circonus-labs/reconnoiter/branches{/branch}","tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/tags","blobs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/{sha}","languages_url":"https://api.github.com/repos/circonus-labs/reconnoiter/languages","stargazers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/stargazers","contributors_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contributors","subscribers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscribers","subscription_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscription","commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contents/{+path}","compare_url":"https://api.github.com/repos/circonus-labs/reconnoiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circonus-labs/reconnoiter/merges","archive_url":"https://api.github.com/repos/circonus-labs/reconnoiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circonus-labs/reconnoiter/downloads","issues_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues{/number}","pulls_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls{/number}","milestones_url":"https://api.github.com/repos/circonus-labs/reconnoiter/milestones{/number}","notifications_url":"https://api.github.com/repos/circonus-labs/reconnoiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circonus-labs/reconnoiter/labels{/name}","releases_url":"https://api.github.com/repos/circonus-labs/reconnoiter/releases{/id}","deployments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/deployments","created_at":"2011-04-08T01:26:26Z","updated_at":"2018-07-26T19:54:06Z","pushed_at":"2018-07-26T19:54:04Z","git_url":"git://github.com/circonus-labs/reconnoiter.git","ssh_url":"git@github.com:circonus-labs/reconnoiter.git","clone_url":"https://github.com/circonus-labs/reconnoiter.git","svn_url":"https://github.com/circonus-labs/reconnoiter","homepage":"","size":34735,"stargazers_count":237,"watchers_count":237,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":6,"watchers":237,"default_branch":"master"}},"base":{"label":"circonus-labs:master","ref":"master","sha":"facd150093ce4b0702db38ea49df3102c92a5476","user":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":1585344,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg1MzQ0","name":"reconnoiter","full_name":"circonus-labs/reconnoiter","owner":{"login":"circonus-labs","id":2091329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTEzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/2091329?v=4","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circonus-labs/reconnoiter","description":"Large-scale Monitoring and Trend Analysis System","fork":false,"url":"https://api.github.com/repos/circonus-labs/reconnoiter","forks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/forks","keys_url":"https://api.github.com/repos/circonus-labs/reconnoiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circonus-labs/reconnoiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circonus-labs/reconnoiter/teams","hooks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/hooks","issue_events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/events{/number}","events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/events","assignees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/assignees{/user}","branches_url":"https://api.github.com/repos/circonus-labs/reconnoiter/branches{/branch}","tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/tags","blobs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/{sha}","languages_url":"https://api.github.com/repos/circonus-labs/reconnoiter/languages","stargazers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/stargazers","contributors_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contributors","subscribers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscribers","subscription_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscription","commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contents/{+path}","compare_url":"https://api.github.com/repos/circonus-labs/reconnoiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circonus-labs/reconnoiter/merges","archive_url":"https://api.github.com/repos/circonus-labs/reconnoiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circonus-labs/reconnoiter/downloads","issues_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues{/number}","pulls_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls{/number}","milestones_url":"https://api.github.com/repos/circonus-labs/reconnoiter/milestones{/number}","notifications_url":"https://api.github.com/repos/circonus-labs/reconnoiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circonus-labs/reconnoiter/labels{/name}","releases_url":"https://api.github.com/repos/circonus-labs/reconnoiter/releases{/id}","deployments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/deployments","created_at":"2011-04-08T01:26:26Z","updated_at":"2018-07-26T19:54:06Z","pushed_at":"2018-07-26T19:54:04Z","git_url":"git://github.com/circonus-labs/reconnoiter.git","ssh_url":"git@github.com:circonus-labs/reconnoiter.git","clone_url":"https://github.com/circonus-labs/reconnoiter.git","svn_url":"https://github.com/circonus-labs/reconnoiter","homepage":"","size":34735,"stargazers_count":237,"watchers_count":237,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":6,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471"},"html":{"href":"https://github.com/circonus-labs/reconnoiter/pull/471"},"issue":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/471"},"comments":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/bcf6b3435e5bac5405f62adaf8c41fa6e573d8a1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"postwait"}}