{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/8469","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/8469/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8469/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/8469/events","html_url":"https://github.com/systemd/systemd/pull/8469","id":306009990,"number":8469,"title":"shutdown: Don't limit unmount attempts prematurely","user":{"login":"medhefgo","id":7892635,"avatar_url":"https://avatars2.githubusercontent.com/u/7892635?v=4","gravatar_id":"","url":"https://api.github.com/users/medhefgo","html_url":"https://github.com/medhefgo","followers_url":"https://api.github.com/users/medhefgo/followers","following_url":"https://api.github.com/users/medhefgo/following{/other_user}","gists_url":"https://api.github.com/users/medhefgo/gists{/gist_id}","starred_url":"https://api.github.com/users/medhefgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/medhefgo/subscriptions","organizations_url":"https://api.github.com/users/medhefgo/orgs","repos_url":"https://api.github.com/users/medhefgo/repos","events_url":"https://api.github.com/users/medhefgo/events{/privacy}","received_events_url":"https://api.github.com/users/medhefgo/received_events","type":"User","site_admin":false},"labels":[{"id":221925707,"url":"https://api.github.com/repos/systemd/systemd/labels/pid1","name":"pid1","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-16T17:14:38Z","updated_at":"2018-03-18T18:39:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/8469","html_url":"https://github.com/systemd/systemd/pull/8469","diff_url":"https://github.com/systemd/systemd/pull/8469.diff","patch_url":"https://github.com/systemd/systemd/pull/8469.patch"},"body":"Once upon a time shutdown.c didn't have the logic to check whether any\nunmount attempts succeeded or not. So instead it kept looping for\na fixed amount and hoped all was right. Nowadays, we do know if we\nchanged anything during a iteration and also stop looping then, but\nwe still limit ourselves to FINALIZE_ATTEMPTS.\n\nBut, theoretically, we could have such a complicated and nested\nsetup that would survive that limit, leaving stuff around we\nmight actually be able to unmount. Aand we could also end up in a\nsituation where the extra loop with raised unmount error level could\nbe skipped too.\n\nSo let's just drop the retries logic and rely fully on the changed\nflag."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/374030530","html_url":"https://github.com/systemd/systemd/pull/8469#issuecomment-374030530","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8469","id":374030530,"user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T18:39:26Z","updated_at":"2018-03-18T18:39:26Z","author_association":"OWNER","body":"LGTM."}}
{"actor":{"display_login":"keszybz"}}