{"action":"created","issue":{"url":"https://api.github.com/repos/boostorg/spirit/issues/380","repository_url":"https://api.github.com/repos/boostorg/spirit","labels_url":"https://api.github.com/repos/boostorg/spirit/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/boostorg/spirit/issues/380/comments","events_url":"https://api.github.com/repos/boostorg/spirit/issues/380/events","html_url":"https://github.com/boostorg/spirit/pull/380","id":306302703,"number":380,"title":"X3: x3::variant fixes","user":{"login":"Kojoley","id":2743474,"avatar_url":"https://avatars3.githubusercontent.com/u/2743474?v=4","gravatar_id":"","url":"https://api.github.com/users/Kojoley","html_url":"https://github.com/Kojoley","followers_url":"https://api.github.com/users/Kojoley/followers","following_url":"https://api.github.com/users/Kojoley/following{/other_user}","gists_url":"https://api.github.com/users/Kojoley/gists{/gist_id}","starred_url":"https://api.github.com/users/Kojoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kojoley/subscriptions","organizations_url":"https://api.github.com/users/Kojoley/orgs","repos_url":"https://api.github.com/users/Kojoley/repos","events_url":"https://api.github.com/users/Kojoley/events{/privacy}","received_events_url":"https://api.github.com/users/Kojoley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-19T00:46:18Z","updated_at":"2018-03-22T23:46:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/boostorg/spirit/pulls/380","html_url":"https://github.com/boostorg/spirit/pull/380","diff_url":"https://github.com/boostorg/spirit/pull/380.diff","patch_url":"https://github.com/boostorg/spirit/pull/380.patch"},"body":"Supersedes #379"},"comment":{"url":"https://api.github.com/repos/boostorg/spirit/issues/comments/375493891","html_url":"https://github.com/boostorg/spirit/pull/380#issuecomment-375493891","issue_url":"https://api.github.com/repos/boostorg/spirit/issues/380","id":375493891,"user":{"login":"mjcaisse","id":230295,"avatar_url":"https://avatars2.githubusercontent.com/u/230295?v=4","gravatar_id":"","url":"https://api.github.com/users/mjcaisse","html_url":"https://github.com/mjcaisse","followers_url":"https://api.github.com/users/mjcaisse/followers","following_url":"https://api.github.com/users/mjcaisse/following{/other_user}","gists_url":"https://api.github.com/users/mjcaisse/gists{/gist_id}","starred_url":"https://api.github.com/users/mjcaisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjcaisse/subscriptions","organizations_url":"https://api.github.com/users/mjcaisse/orgs","repos_url":"https://api.github.com/users/mjcaisse/repos","events_url":"https://api.github.com/users/mjcaisse/events{/privacy}","received_events_url":"https://api.github.com/users/mjcaisse/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T23:46:29Z","updated_at":"2018-03-22T23:46:29Z","author_association":"OWNER","body":"Hi @Kojoley -\r\n\r\nI'll quickly address the hyperbole. It isn't the specific use of the word _abomination_ that is a problem. It is the general tone that you portray when using it. You sound rude, conceited, and make it hard to work with.\r\n\r\nIf you look at the history of `variant.hpp` you will see that it was committed May 1, 2014 by Joel. I don't know of anybody that would call Joel's work an _abomination_. There are also a few things that I might know that you haven't considered. Two weeks after that initial commit, Joel and I are going to speak on X3 in a 3-hour lecture and workshop at C++Now. At that same event, X3 will be officially released for public consumption. There is a lot going on and C++14 is young.\r\n\r\nIt may very well be that `x3::variant` is a horrible mess, poorly designed, and sloppily implemented. I doubt it is that bad ... but lets assume it is. A far better approach than declaring it an abomination or disaster (or any term that doesn't add value) is simply to point out where improvements can be made. Note problems and offer solutions.\r\n\r\nSomebody wrote the code you are criticizing. A variety of trade-offs are made all the time: compiler support, time, compatibility, ... . You may not understand some of the constraints or it might be that the implementation needs to be improved. By being specific about your concerns and the possible improvements that can be made, we can simply make things better. \r\n\r\nYou might be really clever and smart; however, your tone constantly portrays arrogance and an air of hard-to-work-with. Joel and I have been working together for many years. I know he has no ego and simply wants to collaborate and see the libraries improve.\r\n\r\nIt makes it easier for all of us to collaborate when we don't use hyperbole. The irony in me writing this note is that I love sarcasm and hyperbole! They just aren't very useful for collaboration.\r\n\r\nThank you for the effort you put into X3. It makes a difference!"}}
{"actor":{"display_login":"mjcaisse"}}