{"action":"created","comment":{"url":"https://api.github.com/repos/cake-build/cake/pulls/comments/166551461","pull_request_review_id":94629444,"id":166551461,"diff_hunk":"@@ -31,17 +31,35 @@ public static bool Is64BitOperativeSystem()\n         public static PlatformFamily GetPlatformFamily()\n         {\n #if NETCORE\n-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))\n+            try","path":"src/Cake.Core/Polyfill/EnvironmentHelper.cs","position":38,"original_position":38,"commit_id":"b0b1e8f96a74ab622c813e134b9bb43d6b29e5cc","original_commit_id":"b0b1e8f96a74ab622c813e134b9bb43d6b29e5cc","user":{"login":"adamhathcock","id":527620,"avatar_url":"https://avatars1.githubusercontent.com/u/527620?v=4","gravatar_id":"","url":"https://api.github.com/users/adamhathcock","html_url":"https://github.com/adamhathcock","followers_url":"https://api.github.com/users/adamhathcock/followers","following_url":"https://api.github.com/users/adamhathcock/following{/other_user}","gists_url":"https://api.github.com/users/adamhathcock/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhathcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhathcock/subscriptions","organizations_url":"https://api.github.com/users/adamhathcock/orgs","repos_url":"https://api.github.com/users/adamhathcock/repos","events_url":"https://api.github.com/users/adamhathcock/events{/privacy}","received_events_url":"https://api.github.com/users/adamhathcock/received_events","type":"User","site_admin":false},"body":"Not all platforms support this kind of probing.  I saw this in another code base that was doing the same thing to try to determine the environment.","created_at":"2018-02-07T08:55:17Z","updated_at":"2018-02-07T08:55:17Z","html_url":"https://github.com/cake-build/cake/pull/1812#discussion_r166551461","pull_request_url":"https://api.github.com/repos/cake-build/cake/pulls/1812","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cake-build/cake/pulls/comments/166551461"},"html":{"href":"https://github.com/cake-build/cake/pull/1812#discussion_r166551461"},"pull_request":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1812"}},"in_reply_to_id":164548704},"pull_request":{"url":"https://api.github.com/repos/cake-build/cake/pulls/1812","id":141897773,"html_url":"https://github.com/cake-build/cake/pull/1812","diff_url":"https://github.com/cake-build/cake/pull/1812.diff","patch_url":"https://github.com/cake-build/cake/pull/1812.patch","issue_url":"https://api.github.com/repos/cake-build/cake/issues/1812","number":1812,"state":"open","locked":false,"title":"[GH1781] .NET Core 2 support","user":{"login":"adamhathcock","id":527620,"avatar_url":"https://avatars1.githubusercontent.com/u/527620?v=4","gravatar_id":"","url":"https://api.github.com/users/adamhathcock","html_url":"https://github.com/adamhathcock","followers_url":"https://api.github.com/users/adamhathcock/followers","following_url":"https://api.github.com/users/adamhathcock/following{/other_user}","gists_url":"https://api.github.com/users/adamhathcock/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhathcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhathcock/subscriptions","organizations_url":"https://api.github.com/users/adamhathcock/orgs","repos_url":"https://api.github.com/users/adamhathcock/repos","events_url":"https://api.github.com/users/adamhathcock/events{/privacy}","received_events_url":"https://api.github.com/users/adamhathcock/received_events","type":"User","site_admin":false},"body":"https://github.com/cake-build/cake/issues/1781\r\n\r\nTests and Cake.exe all target - net461;netcoreapp2.0\r\nCake DLLs all target - netstandard2.0\r\n\r\nUpdated/adjustment references where necessary.\r\n\r\nNotes:\r\n- [x] Unit test with Encoding not working on `net461` and `netcoreapp2.0` but works on `netcoreapp1.0` (bug report filed https://github.com/dotnet/corefx/issues/26544 )\r\n- [x] Need to figure out how to run integration tests.\r\n- [x] Adjust building for `netcoreapp2.0`\r\n- [x] Adjust packaging for `netcoreapp2.0`\r\n- [x] Adjust integration tests for `netcoreapp2.0`\r\n\r\nLooking for:\r\n- Notes if this is the right path\r\n- What else to needs looking at.\r\n  ","created_at":"2017-09-19T16:32:21Z","updated_at":"2018-02-07T08:55:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da81d3cd94deaedb68537e0ffd8827f052bcc015","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/cake-build/cake/pulls/1812/commits","review_comments_url":"https://api.github.com/repos/cake-build/cake/pulls/1812/comments","review_comment_url":"https://api.github.com/repos/cake-build/cake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cake-build/cake/issues/1812/comments","statuses_url":"https://api.github.com/repos/cake-build/cake/statuses/b0b1e8f96a74ab622c813e134b9bb43d6b29e5cc","head":{"label":"adamhathcock:netcore2","ref":"netcore2","sha":"b0b1e8f96a74ab622c813e134b9bb43d6b29e5cc","user":{"login":"adamhathcock","id":527620,"avatar_url":"https://avatars1.githubusercontent.com/u/527620?v=4","gravatar_id":"","url":"https://api.github.com/users/adamhathcock","html_url":"https://github.com/adamhathcock","followers_url":"https://api.github.com/users/adamhathcock/followers","following_url":"https://api.github.com/users/adamhathcock/following{/other_user}","gists_url":"https://api.github.com/users/adamhathcock/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhathcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhathcock/subscriptions","organizations_url":"https://api.github.com/users/adamhathcock/orgs","repos_url":"https://api.github.com/users/adamhathcock/repos","events_url":"https://api.github.com/users/adamhathcock/events{/privacy}","received_events_url":"https://api.github.com/users/adamhathcock/received_events","type":"User","site_admin":false},"repo":{"id":56611168,"name":"cake","full_name":"adamhathcock/cake","owner":{"login":"adamhathcock","id":527620,"avatar_url":"https://avatars1.githubusercontent.com/u/527620?v=4","gravatar_id":"","url":"https://api.github.com/users/adamhathcock","html_url":"https://github.com/adamhathcock","followers_url":"https://api.github.com/users/adamhathcock/followers","following_url":"https://api.github.com/users/adamhathcock/following{/other_user}","gists_url":"https://api.github.com/users/adamhathcock/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhathcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhathcock/subscriptions","organizations_url":"https://api.github.com/users/adamhathcock/orgs","repos_url":"https://api.github.com/users/adamhathcock/repos","events_url":"https://api.github.com/users/adamhathcock/events{/privacy}","received_events_url":"https://api.github.com/users/adamhathcock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamhathcock/cake","description":"Cake (C# Make) is a cross platform build automation system.","fork":true,"url":"https://api.github.com/repos/adamhathcock/cake","forks_url":"https://api.github.com/repos/adamhathcock/cake/forks","keys_url":"https://api.github.com/repos/adamhathcock/cake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamhathcock/cake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamhathcock/cake/teams","hooks_url":"https://api.github.com/repos/adamhathcock/cake/hooks","issue_events_url":"https://api.github.com/repos/adamhathcock/cake/issues/events{/number}","events_url":"https://api.github.com/repos/adamhathcock/cake/events","assignees_url":"https://api.github.com/repos/adamhathcock/cake/assignees{/user}","branches_url":"https://api.github.com/repos/adamhathcock/cake/branches{/branch}","tags_url":"https://api.github.com/repos/adamhathcock/cake/tags","blobs_url":"https://api.github.com/repos/adamhathcock/cake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamhathcock/cake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamhathcock/cake/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamhathcock/cake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamhathcock/cake/statuses/{sha}","languages_url":"https://api.github.com/repos/adamhathcock/cake/languages","stargazers_url":"https://api.github.com/repos/adamhathcock/cake/stargazers","contributors_url":"https://api.github.com/repos/adamhathcock/cake/contributors","subscribers_url":"https://api.github.com/repos/adamhathcock/cake/subscribers","subscription_url":"https://api.github.com/repos/adamhathcock/cake/subscription","commits_url":"https://api.github.com/repos/adamhathcock/cake/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamhathcock/cake/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamhathcock/cake/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamhathcock/cake/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamhathcock/cake/contents/{+path}","compare_url":"https://api.github.com/repos/adamhathcock/cake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamhathcock/cake/merges","archive_url":"https://api.github.com/repos/adamhathcock/cake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamhathcock/cake/downloads","issues_url":"https://api.github.com/repos/adamhathcock/cake/issues{/number}","pulls_url":"https://api.github.com/repos/adamhathcock/cake/pulls{/number}","milestones_url":"https://api.github.com/repos/adamhathcock/cake/milestones{/number}","notifications_url":"https://api.github.com/repos/adamhathcock/cake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamhathcock/cake/labels{/name}","releases_url":"https://api.github.com/repos/adamhathcock/cake/releases{/id}","deployments_url":"https://api.github.com/repos/adamhathcock/cake/deployments","created_at":"2016-04-19T15:56:50Z","updated_at":"2016-04-19T15:56:52Z","pushed_at":"2018-01-28T21:07:34Z","git_url":"git://github.com/adamhathcock/cake.git","ssh_url":"git@github.com:adamhathcock/cake.git","clone_url":"https://github.com/adamhathcock/cake.git","svn_url":"https://github.com/adamhathcock/cake","homepage":"http://cakebuild.net/","size":7923,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cake-build:develop","ref":"develop","sha":"e86afcfc923c9d5d16d7e8643bfd4ba27698af12","user":{"login":"cake-build","id":7738262,"avatar_url":"https://avatars1.githubusercontent.com/u/7738262?v=4","gravatar_id":"","url":"https://api.github.com/users/cake-build","html_url":"https://github.com/cake-build","followers_url":"https://api.github.com/users/cake-build/followers","following_url":"https://api.github.com/users/cake-build/following{/other_user}","gists_url":"https://api.github.com/users/cake-build/gists{/gist_id}","starred_url":"https://api.github.com/users/cake-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cake-build/subscriptions","organizations_url":"https://api.github.com/users/cake-build/orgs","repos_url":"https://api.github.com/users/cake-build/repos","events_url":"https://api.github.com/users/cake-build/events{/privacy}","received_events_url":"https://api.github.com/users/cake-build/received_events","type":"Organization","site_admin":false},"repo":{"id":20094029,"name":"cake","full_name":"cake-build/cake","owner":{"login":"cake-build","id":7738262,"avatar_url":"https://avatars1.githubusercontent.com/u/7738262?v=4","gravatar_id":"","url":"https://api.github.com/users/cake-build","html_url":"https://github.com/cake-build","followers_url":"https://api.github.com/users/cake-build/followers","following_url":"https://api.github.com/users/cake-build/following{/other_user}","gists_url":"https://api.github.com/users/cake-build/gists{/gist_id}","starred_url":"https://api.github.com/users/cake-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cake-build/subscriptions","organizations_url":"https://api.github.com/users/cake-build/orgs","repos_url":"https://api.github.com/users/cake-build/repos","events_url":"https://api.github.com/users/cake-build/events{/privacy}","received_events_url":"https://api.github.com/users/cake-build/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cake-build/cake","description":"Cake (C# Make) is a cross platform build automation system.","fork":false,"url":"https://api.github.com/repos/cake-build/cake","forks_url":"https://api.github.com/repos/cake-build/cake/forks","keys_url":"https://api.github.com/repos/cake-build/cake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cake-build/cake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cake-build/cake/teams","hooks_url":"https://api.github.com/repos/cake-build/cake/hooks","issue_events_url":"https://api.github.com/repos/cake-build/cake/issues/events{/number}","events_url":"https://api.github.com/repos/cake-build/cake/events","assignees_url":"https://api.github.com/repos/cake-build/cake/assignees{/user}","branches_url":"https://api.github.com/repos/cake-build/cake/branches{/branch}","tags_url":"https://api.github.com/repos/cake-build/cake/tags","blobs_url":"https://api.github.com/repos/cake-build/cake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cake-build/cake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cake-build/cake/git/refs{/sha}","trees_url":"https://api.github.com/repos/cake-build/cake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cake-build/cake/statuses/{sha}","languages_url":"https://api.github.com/repos/cake-build/cake/languages","stargazers_url":"https://api.github.com/repos/cake-build/cake/stargazers","contributors_url":"https://api.github.com/repos/cake-build/cake/contributors","subscribers_url":"https://api.github.com/repos/cake-build/cake/subscribers","subscription_url":"https://api.github.com/repos/cake-build/cake/subscription","commits_url":"https://api.github.com/repos/cake-build/cake/commits{/sha}","git_commits_url":"https://api.github.com/repos/cake-build/cake/git/commits{/sha}","comments_url":"https://api.github.com/repos/cake-build/cake/comments{/number}","issue_comment_url":"https://api.github.com/repos/cake-build/cake/issues/comments{/number}","contents_url":"https://api.github.com/repos/cake-build/cake/contents/{+path}","compare_url":"https://api.github.com/repos/cake-build/cake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cake-build/cake/merges","archive_url":"https://api.github.com/repos/cake-build/cake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cake-build/cake/downloads","issues_url":"https://api.github.com/repos/cake-build/cake/issues{/number}","pulls_url":"https://api.github.com/repos/cake-build/cake/pulls{/number}","milestones_url":"https://api.github.com/repos/cake-build/cake/milestones{/number}","notifications_url":"https://api.github.com/repos/cake-build/cake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cake-build/cake/labels{/name}","releases_url":"https://api.github.com/repos/cake-build/cake/releases{/id}","deployments_url":"https://api.github.com/repos/cake-build/cake/deployments","created_at":"2014-05-23T09:26:54Z","updated_at":"2018-02-06T17:22:37Z","pushed_at":"2018-02-05T19:59:49Z","git_url":"git://github.com/cake-build/cake.git","ssh_url":"git@github.com:cake-build/cake.git","clone_url":"https://github.com/cake-build/cake.git","svn_url":"https://github.com/cake-build/cake","homepage":"http://cakebuild.net/","size":7847,"stargazers_count":1591,"watchers_count":1591,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"open_issues_count":241,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":411,"open_issues":241,"watchers":1591,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1812"},"html":{"href":"https://github.com/cake-build/cake/pull/1812"},"issue":{"href":"https://api.github.com/repos/cake-build/cake/issues/1812"},"comments":{"href":"https://api.github.com/repos/cake-build/cake/issues/1812/comments"},"review_comments":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1812/comments"},"review_comment":{"href":"https://api.github.com/repos/cake-build/cake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cake-build/cake/pulls/1812/commits"},"statuses":{"href":"https://api.github.com/repos/cake-build/cake/statuses/b0b1e8f96a74ab622c813e134b9bb43d6b29e5cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adamhathcock"}}