{"action":"created","comment":{"url":"https://api.github.com/repos/datamill-co/target-postgres/pulls/comments/232802420","pull_request_review_id":174081775,"id":232802420,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjgwMjQyMA==","diff_hunk":"@@ -14,30 +14,32 @@ A [Singer](https://singer.io/) postgres target, for use with Singer streams gene\n \n ## Usage\n \n-Create a config file with postgres connection information and target postgres schema.\n-\n-```json\n-{\n-  \"postgres_host\": \"locahost\",\n-  \"postgres_port\": 5432,\n-  \"postgres_database\": \"my_analytics\",\n-  \"postgres_username\": \"myuser\",\n-  \"postgres_password\": \"1234\",\n-  \"postgres_schema\": \"mytapname\"\n-}\n-```\n+1. Follow the\n+   [Singer.io Best Practices](https://github.com/singer-io/getting-started/blob/master/docs/RUNNING_AND_DEVELOPING.md#running-a-singer-tap-with-a-singer-target)\n+   for setting up separate `tap` and `target` virtualenvs to avoid version\n+   conflicts.\n \n-Run `target-postgres` against a [Singer](https://singer.io) stream.\n+1. Create a config file with postgres connection information and target\n+   postgres schema.\n \n-```sh\n-\ttap-something | target-postgres --config config.json\n-```\n+   ```\n+   cp config-example.json /tmp/tap_config.json","path":"README.md","position":29,"original_position":29,"commit_id":"5ca53c8b89c3c1c9680be838e9e3cc4a7ab9da5c","original_commit_id":"5ca53c8b89c3c1c9680be838e9e3cc4a7ab9da5c","user":{"login":"awm33","id":3846080,"node_id":"MDQ6VXNlcjM4NDYwODA=","avatar_url":"https://avatars0.githubusercontent.com/u/3846080?v=4","gravatar_id":"","url":"https://api.github.com/users/awm33","html_url":"https://github.com/awm33","followers_url":"https://api.github.com/users/awm33/followers","following_url":"https://api.github.com/users/awm33/following{/other_user}","gists_url":"https://api.github.com/users/awm33/gists{/gist_id}","starred_url":"https://api.github.com/users/awm33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awm33/subscriptions","organizations_url":"https://api.github.com/users/awm33/orgs","repos_url":"https://api.github.com/users/awm33/repos","events_url":"https://api.github.com/users/awm33/events{/privacy}","received_events_url":"https://api.github.com/users/awm33/received_events","type":"User","site_admin":false},"body":"Also, this is a target, the file name has tap","created_at":"2018-11-12T20:33:12Z","updated_at":"2018-11-12T20:33:12Z","html_url":"https://github.com/datamill-co/target-postgres/pull/25#discussion_r232802420","pull_request_url":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/datamill-co/target-postgres/pulls/comments/232802420"},"html":{"href":"https://github.com/datamill-co/target-postgres/pull/25#discussion_r232802420"},"pull_request":{"href":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25"}},"in_reply_to_id":232800128},"pull_request":{"url":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25","id":230251700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjUxNzAw","html_url":"https://github.com/datamill-co/target-postgres/pull/25","diff_url":"https://github.com/datamill-co/target-postgres/pull/25.diff","patch_url":"https://github.com/datamill-co/target-postgres/pull/25.patch","issue_url":"https://api.github.com/repos/datamill-co/target-postgres/issues/25","number":25,"state":"open","locked":false,"title":"Update README with best practices","user":{"login":"timvisher","id":34676,"node_id":"MDQ6VXNlcjM0Njc2","avatar_url":"https://avatars3.githubusercontent.com/u/34676?v=4","gravatar_id":"","url":"https://api.github.com/users/timvisher","html_url":"https://github.com/timvisher","followers_url":"https://api.github.com/users/timvisher/followers","following_url":"https://api.github.com/users/timvisher/following{/other_user}","gists_url":"https://api.github.com/users/timvisher/gists{/gist_id}","starred_url":"https://api.github.com/users/timvisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvisher/subscriptions","organizations_url":"https://api.github.com/users/timvisher/orgs","repos_url":"https://api.github.com/users/timvisher/repos","events_url":"https://api.github.com/users/timvisher/events{/privacy}","received_events_url":"https://api.github.com/users/timvisher/received_events","type":"User","site_admin":false},"body":"Motivation\r\n----------\r\n\r\nThe README had a smill spelling error and also suggested running the\r\n`target` and `tap` in the same virtualenv. This updates it to be a bit\r\nmore in keeping with current best practices.","created_at":"2018-11-12T20:00:59Z","updated_at":"2018-11-12T20:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a29788ea707df100a8f7fa41a9517f83febb3a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25/commits","review_comments_url":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25/comments","review_comment_url":"https://api.github.com/repos/datamill-co/target-postgres/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datamill-co/target-postgres/issues/25/comments","statuses_url":"https://api.github.com/repos/datamill-co/target-postgres/statuses/5ca53c8b89c3c1c9680be838e9e3cc4a7ab9da5c","head":{"label":"timvisher:fix/readme-best-practices","ref":"fix/readme-best-practices","sha":"5ca53c8b89c3c1c9680be838e9e3cc4a7ab9da5c","user":{"login":"timvisher","id":34676,"node_id":"MDQ6VXNlcjM0Njc2","avatar_url":"https://avatars3.githubusercontent.com/u/34676?v=4","gravatar_id":"","url":"https://api.github.com/users/timvisher","html_url":"https://github.com/timvisher","followers_url":"https://api.github.com/users/timvisher/followers","following_url":"https://api.github.com/users/timvisher/following{/other_user}","gists_url":"https://api.github.com/users/timvisher/gists{/gist_id}","starred_url":"https://api.github.com/users/timvisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvisher/subscriptions","organizations_url":"https://api.github.com/users/timvisher/orgs","repos_url":"https://api.github.com/users/timvisher/repos","events_url":"https://api.github.com/users/timvisher/events{/privacy}","received_events_url":"https://api.github.com/users/timvisher/received_events","type":"User","site_admin":false},"repo":{"id":157267234,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNjcyMzQ=","name":"target-postgres","full_name":"timvisher/target-postgres","private":false,"owner":{"login":"timvisher","id":34676,"node_id":"MDQ6VXNlcjM0Njc2","avatar_url":"https://avatars3.githubusercontent.com/u/34676?v=4","gravatar_id":"","url":"https://api.github.com/users/timvisher","html_url":"https://github.com/timvisher","followers_url":"https://api.github.com/users/timvisher/followers","following_url":"https://api.github.com/users/timvisher/following{/other_user}","gists_url":"https://api.github.com/users/timvisher/gists{/gist_id}","starred_url":"https://api.github.com/users/timvisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvisher/subscriptions","organizations_url":"https://api.github.com/users/timvisher/orgs","repos_url":"https://api.github.com/users/timvisher/repos","events_url":"https://api.github.com/users/timvisher/events{/privacy}","received_events_url":"https://api.github.com/users/timvisher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/timvisher/target-postgres","description":"A Singer.io Target for Postgres","fork":true,"url":"https://api.github.com/repos/timvisher/target-postgres","forks_url":"https://api.github.com/repos/timvisher/target-postgres/forks","keys_url":"https://api.github.com/repos/timvisher/target-postgres/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timvisher/target-postgres/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timvisher/target-postgres/teams","hooks_url":"https://api.github.com/repos/timvisher/target-postgres/hooks","issue_events_url":"https://api.github.com/repos/timvisher/target-postgres/issues/events{/number}","events_url":"https://api.github.com/repos/timvisher/target-postgres/events","assignees_url":"https://api.github.com/repos/timvisher/target-postgres/assignees{/user}","branches_url":"https://api.github.com/repos/timvisher/target-postgres/branches{/branch}","tags_url":"https://api.github.com/repos/timvisher/target-postgres/tags","blobs_url":"https://api.github.com/repos/timvisher/target-postgres/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timvisher/target-postgres/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timvisher/target-postgres/git/refs{/sha}","trees_url":"https://api.github.com/repos/timvisher/target-postgres/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timvisher/target-postgres/statuses/{sha}","languages_url":"https://api.github.com/repos/timvisher/target-postgres/languages","stargazers_url":"https://api.github.com/repos/timvisher/target-postgres/stargazers","contributors_url":"https://api.github.com/repos/timvisher/target-postgres/contributors","subscribers_url":"https://api.github.com/repos/timvisher/target-postgres/subscribers","subscription_url":"https://api.github.com/repos/timvisher/target-postgres/subscription","commits_url":"https://api.github.com/repos/timvisher/target-postgres/commits{/sha}","git_commits_url":"https://api.github.com/repos/timvisher/target-postgres/git/commits{/sha}","comments_url":"https://api.github.com/repos/timvisher/target-postgres/comments{/number}","issue_comment_url":"https://api.github.com/repos/timvisher/target-postgres/issues/comments{/number}","contents_url":"https://api.github.com/repos/timvisher/target-postgres/contents/{+path}","compare_url":"https://api.github.com/repos/timvisher/target-postgres/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timvisher/target-postgres/merges","archive_url":"https://api.github.com/repos/timvisher/target-postgres/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timvisher/target-postgres/downloads","issues_url":"https://api.github.com/repos/timvisher/target-postgres/issues{/number}","pulls_url":"https://api.github.com/repos/timvisher/target-postgres/pulls{/number}","milestones_url":"https://api.github.com/repos/timvisher/target-postgres/milestones{/number}","notifications_url":"https://api.github.com/repos/timvisher/target-postgres/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timvisher/target-postgres/labels{/name}","releases_url":"https://api.github.com/repos/timvisher/target-postgres/releases{/id}","deployments_url":"https://api.github.com/repos/timvisher/target-postgres/deployments","created_at":"2018-11-12T19:46:48Z","updated_at":"2018-11-12T19:46:50Z","pushed_at":"2018-11-12T20:00:08Z","git_url":"git://github.com/timvisher/target-postgres.git","ssh_url":"git@github.com:timvisher/target-postgres.git","clone_url":"https://github.com/timvisher/target-postgres.git","svn_url":"https://github.com/timvisher/target-postgres","homepage":"","size":89,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"datamill-co:master","ref":"master","sha":"eb6c8b8ed35207cfd4115f46745ac6b417166ff2","user":{"login":"datamill-co","id":37855644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODU1NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/37855644?v=4","gravatar_id":"","url":"https://api.github.com/users/datamill-co","html_url":"https://github.com/datamill-co","followers_url":"https://api.github.com/users/datamill-co/followers","following_url":"https://api.github.com/users/datamill-co/following{/other_user}","gists_url":"https://api.github.com/users/datamill-co/gists{/gist_id}","starred_url":"https://api.github.com/users/datamill-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamill-co/subscriptions","organizations_url":"https://api.github.com/users/datamill-co/orgs","repos_url":"https://api.github.com/users/datamill-co/repos","events_url":"https://api.github.com/users/datamill-co/events{/privacy}","received_events_url":"https://api.github.com/users/datamill-co/received_events","type":"Organization","site_admin":false},"repo":{"id":124483019,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0ODMwMTk=","name":"target-postgres","full_name":"datamill-co/target-postgres","private":false,"owner":{"login":"datamill-co","id":37855644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODU1NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/37855644?v=4","gravatar_id":"","url":"https://api.github.com/users/datamill-co","html_url":"https://github.com/datamill-co","followers_url":"https://api.github.com/users/datamill-co/followers","following_url":"https://api.github.com/users/datamill-co/following{/other_user}","gists_url":"https://api.github.com/users/datamill-co/gists{/gist_id}","starred_url":"https://api.github.com/users/datamill-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamill-co/subscriptions","organizations_url":"https://api.github.com/users/datamill-co/orgs","repos_url":"https://api.github.com/users/datamill-co/repos","events_url":"https://api.github.com/users/datamill-co/events{/privacy}","received_events_url":"https://api.github.com/users/datamill-co/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datamill-co/target-postgres","description":"A Singer.io Target for Postgres","fork":false,"url":"https://api.github.com/repos/datamill-co/target-postgres","forks_url":"https://api.github.com/repos/datamill-co/target-postgres/forks","keys_url":"https://api.github.com/repos/datamill-co/target-postgres/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamill-co/target-postgres/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamill-co/target-postgres/teams","hooks_url":"https://api.github.com/repos/datamill-co/target-postgres/hooks","issue_events_url":"https://api.github.com/repos/datamill-co/target-postgres/issues/events{/number}","events_url":"https://api.github.com/repos/datamill-co/target-postgres/events","assignees_url":"https://api.github.com/repos/datamill-co/target-postgres/assignees{/user}","branches_url":"https://api.github.com/repos/datamill-co/target-postgres/branches{/branch}","tags_url":"https://api.github.com/repos/datamill-co/target-postgres/tags","blobs_url":"https://api.github.com/repos/datamill-co/target-postgres/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamill-co/target-postgres/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamill-co/target-postgres/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamill-co/target-postgres/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamill-co/target-postgres/statuses/{sha}","languages_url":"https://api.github.com/repos/datamill-co/target-postgres/languages","stargazers_url":"https://api.github.com/repos/datamill-co/target-postgres/stargazers","contributors_url":"https://api.github.com/repos/datamill-co/target-postgres/contributors","subscribers_url":"https://api.github.com/repos/datamill-co/target-postgres/subscribers","subscription_url":"https://api.github.com/repos/datamill-co/target-postgres/subscription","commits_url":"https://api.github.com/repos/datamill-co/target-postgres/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamill-co/target-postgres/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamill-co/target-postgres/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamill-co/target-postgres/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamill-co/target-postgres/contents/{+path}","compare_url":"https://api.github.com/repos/datamill-co/target-postgres/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamill-co/target-postgres/merges","archive_url":"https://api.github.com/repos/datamill-co/target-postgres/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamill-co/target-postgres/downloads","issues_url":"https://api.github.com/repos/datamill-co/target-postgres/issues{/number}","pulls_url":"https://api.github.com/repos/datamill-co/target-postgres/pulls{/number}","milestones_url":"https://api.github.com/repos/datamill-co/target-postgres/milestones{/number}","notifications_url":"https://api.github.com/repos/datamill-co/target-postgres/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamill-co/target-postgres/labels{/name}","releases_url":"https://api.github.com/repos/datamill-co/target-postgres/releases{/id}","deployments_url":"https://api.github.com/repos/datamill-co/target-postgres/deployments","created_at":"2018-03-09T03:34:12Z","updated_at":"2018-11-12T17:49:09Z","pushed_at":"2018-11-12T20:01:00Z","git_url":"git://github.com/datamill-co/target-postgres.git","ssh_url":"git@github.com:datamill-co/target-postgres.git","clone_url":"https://github.com/datamill-co/target-postgres.git","svn_url":"https://github.com/datamill-co/target-postgres","homepage":"","size":89,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":3,"open_issues":15,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25"},"html":{"href":"https://github.com/datamill-co/target-postgres/pull/25"},"issue":{"href":"https://api.github.com/repos/datamill-co/target-postgres/issues/25"},"comments":{"href":"https://api.github.com/repos/datamill-co/target-postgres/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/datamill-co/target-postgres/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datamill-co/target-postgres/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/datamill-co/target-postgres/statuses/5ca53c8b89c3c1c9680be838e9e3cc4a7ab9da5c"}},"author_association":"NONE"}}
{"actor":{"display_login":"awm33"}}