{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8810","repository_url":"https://api.github.com/repos/DynamoDS/Dynamo","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8810/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8810/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8810/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/8810","id":319058818,"number":8810,"title":"Fix type checking for integers on IsOutput serialization","user":{"login":"saintentropy","id":2145751,"avatar_url":"https://avatars1.githubusercontent.com/u/2145751?v=4","gravatar_id":"","url":"https://api.github.com/users/saintentropy","html_url":"https://github.com/saintentropy","followers_url":"https://api.github.com/users/saintentropy/followers","following_url":"https://api.github.com/users/saintentropy/following{/other_user}","gists_url":"https://api.github.com/users/saintentropy/gists{/gist_id}","starred_url":"https://api.github.com/users/saintentropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintentropy/subscriptions","organizations_url":"https://api.github.com/users/saintentropy/orgs","repos_url":"https://api.github.com/users/saintentropy/repos","events_url":"https://api.github.com/users/saintentropy/events{/privacy}","received_events_url":"https://api.github.com/users/saintentropy/received_events","type":"User","site_admin":false},"labels":[{"id":270895791,"url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/Waiting%20for%20feedback","name":"Waiting for feedback","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-30T22:34:04Z","updated_at":"2018-05-01T11:33:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/8810","html_url":"https://github.com/DynamoDS/Dynamo/pull/8810","diff_url":"https://github.com/DynamoDS/Dynamo/pull/8810.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/8810.patch"},"body":"### Purpose\r\n\r\nThe purpose of this PR is to correct a bug in the serialization of nodes using the IsOutput UI.  Previously nodes with a return type of integer were being set as _Unknown_.  This issue is tracked with  \r\n[QNTM-4085](https://jira.autodesk.com/browse/QNTM-4085) and is a dependency of [QNTM-3458]( https://jira.autodesk.com/browse/QNTM-3458).\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [X] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n- [ ] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n\r\n@QilongTang @ramramps \r\n\r\n### FYIs\r\n\r\n@nonoesp "},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/385651579","html_url":"https://github.com/DynamoDS/Dynamo/pull/8810#issuecomment-385651579","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/8810","id":385651579,"user":{"login":"saintentropy","id":2145751,"avatar_url":"https://avatars1.githubusercontent.com/u/2145751?v=4","gravatar_id":"","url":"https://api.github.com/users/saintentropy","html_url":"https://github.com/saintentropy","followers_url":"https://api.github.com/users/saintentropy/followers","following_url":"https://api.github.com/users/saintentropy/following{/other_user}","gists_url":"https://api.github.com/users/saintentropy/gists{/gist_id}","starred_url":"https://api.github.com/users/saintentropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintentropy/subscriptions","organizations_url":"https://api.github.com/users/saintentropy/orgs","repos_url":"https://api.github.com/users/saintentropy/repos","events_url":"https://api.github.com/users/saintentropy/events{/privacy}","received_events_url":"https://api.github.com/users/saintentropy/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T11:33:37Z","updated_at":"2018-05-01T11:33:37Z","author_association":"CONTRIBUTOR","body":"@mjkkirschner... Let's do this.  Let me change the enum of supported types on NodeInputData.cs so that we are covered on type checking regardless of what happens on the Slider.  "}}
{"actor":{"display_login":"saintentropy"}}