{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/23053","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/23053/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/23053/comments","events_url":"https://api.github.com/repos/apache/spark/issues/23053/events","html_url":"https://github.com/apache/spark/pull/23053","id":381404273,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzg1MjY0","number":23053,"title":"[SPARK-25957][K8S] Add ability to skip building optional k8s docker i…","user":{"login":"ramaddepally","id":26662402,"node_id":"MDQ6VXNlcjI2NjYyNDAy","avatar_url":"https://avatars3.githubusercontent.com/u/26662402?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaddepally","html_url":"https://github.com/ramaddepally","followers_url":"https://api.github.com/users/ramaddepally/followers","following_url":"https://api.github.com/users/ramaddepally/following{/other_user}","gists_url":"https://api.github.com/users/ramaddepally/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaddepally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaddepally/subscriptions","organizations_url":"https://api.github.com/users/ramaddepally/orgs","repos_url":"https://api.github.com/users/ramaddepally/repos","events_url":"https://api.github.com/users/ramaddepally/events{/privacy}","received_events_url":"https://api.github.com/users/ramaddepally/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-16T01:04:27Z","updated_at":"2018-11-17T00:03:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23053","html_url":"https://github.com/apache/spark/pull/23053","diff_url":"https://github.com/apache/spark/pull/23053.diff","patch_url":"https://github.com/apache/spark/pull/23053.patch"},"body":"…mages\r\n## What changes were proposed in this pull request?\r\nbin/docker-image-tool.sh tries to build all docker images (JVM, PySpark\r\nand SparkR) by default. But not all spark distributions are built with\r\nSparkR and hence this script will fail on such distros.\r\n\r\nWith this change,\r\n- We should be able to skip building optional docker\r\n  images (PySpark and SparkR) by specifying -pskip or -Rskip flags.\r\n- We autodetect if SparkR is not installed in the build and skip building\r\n  SparkR docker image.\r\n- We skip pushing docker images that are not available locally.\r\n\r\n## How was this patch tested?\r\n\r\nTested following scenarios.\r\n- On source code and distro with SparkR support\r\n  - Run bin/docker-image-tool.sh -r <repo> -t <tag> build. Verify that JVM, PySpark and SparkR docker images are built.\r\n  - Run bin/docker-image-tool.sh -r <repo> -t <tag> -Rskip -pskip build. Verify that only JVM docker image is built. Building PySpark and SparkR images is skipped.\r\n- On source code and distro without SparkR support\r\n  - Run bin/docker-image-tool.sh -r <repo> -t <tag> build. Verify that only JVM, PySpark docker images are built. Building SparkR image is skipped.\r\n- On system with JVM, PySpark and SparkR images built,\r\n  - Run bin/docker-image-tool.sh -r <repo> -t <tag> push. Verify that all images are pushed to docker registry.\r\n- On system with only JVM and PySpark images built.\r\n  - Run bin/docker-image-tool.sh -r <repo> -t <tag> push. Verify that only JVM and PySpark images are pushed. Pushing SparkR images is skipped.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/439565136","html_url":"https://github.com/apache/spark/pull/23053#issuecomment-439565136","issue_url":"https://api.github.com/repos/apache/spark/issues/23053","id":439565136,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTU2NTEzNg==","user":{"login":"vanzin","id":1694083,"node_id":"MDQ6VXNlcjE2OTQwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T00:03:41Z","updated_at":"2018-11-17T00:03:41Z","author_association":"CONTRIBUTOR","body":"Can you fix the title to include the part that github wraps by default?"}}
{"actor":{"display_login":"vanzin"}}