{"action":"closed","number":1681,"pull_request":{"url":"https://api.github.com/repos/enactjs/enact/pulls/1681","id":191214387,"html_url":"https://github.com/enactjs/enact/pull/1681","diff_url":"https://github.com/enactjs/enact/pull/1681.diff","patch_url":"https://github.com/enactjs/enact/pull/1681.patch","issue_url":"https://api.github.com/repos/enactjs/enact/issues/1681","number":1681,"state":"closed","locked":false,"title":"ENYO-5299: Forward onDismiss and stop propagation only if defined","user":{"login":"viodragon2","id":3284947,"avatar_url":"https://avatars0.githubusercontent.com/u/3284947?v=4","gravatar_id":"","url":"https://api.github.com/users/viodragon2","html_url":"https://github.com/viodragon2","followers_url":"https://api.github.com/users/viodragon2/followers","following_url":"https://api.github.com/users/viodragon2/following{/other_user}","gists_url":"https://api.github.com/users/viodragon2/gists{/gist_id}","starred_url":"https://api.github.com/users/viodragon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viodragon2/subscriptions","organizations_url":"https://api.github.com/users/viodragon2/orgs","repos_url":"https://api.github.com/users/viodragon2/repos","events_url":"https://api.github.com/users/viodragon2/events{/privacy}","received_events_url":"https://api.github.com/users/viodragon2/received_events","type":"User","site_admin":false},"body":"### Issue Resolved / Feature Added\r\n[//]: # (Describe the issue resolved or feature added by this pull request)\r\n`FloatingLayer` stops every cancel event even if not handled (see #1666). Changed to forward onDismiss and stop propagation only if it is handled. \r\n\r\nEnact-DCO-1.0-Signed-off-by: Stephen Choi <stephen.choi@lge.com>\r\n","created_at":"2018-05-29T17:14:50Z","updated_at":"2018-05-30T04:31:46Z","closed_at":"2018-05-30T04:31:46Z","merged_at":"2018-05-30T04:31:45Z","merge_commit_sha":"9a63c0fb8101770188afaa1662ab1f0b715a87b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enactjs/enact/pulls/1681/commits","review_comments_url":"https://api.github.com/repos/enactjs/enact/pulls/1681/comments","review_comment_url":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enactjs/enact/issues/1681/comments","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/6e1ca266be8b0e86749002ab43051ddcb806396f","head":{"label":"enactjs:feature/ENYO-5299-stephen","ref":"feature/ENYO-5299-stephen","sha":"6e1ca266be8b0e86749002ab43051ddcb806396f","user":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-05-27T06:06:27Z","pushed_at":"2018-05-30T04:31:45Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":14879,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":55,"watchers":63,"default_branch":"master"}},"base":{"label":"enactjs:release/2.0.0-beta.5","ref":"release/2.0.0-beta.5","sha":"fc41e2c3e899e45c9cb8d08e75fc4074bee4a572","user":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-05-27T06:06:27Z","pushed_at":"2018-05-30T04:31:45Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":14879,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":55,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1681"},"html":{"href":"https://github.com/enactjs/enact/pull/1681"},"issue":{"href":"https://api.github.com/repos/enactjs/enact/issues/1681"},"comments":{"href":"https://api.github.com/repos/enactjs/enact/issues/1681/comments"},"review_comments":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1681/comments"},"review_comment":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1681/commits"},"statuses":{"href":"https://api.github.com/repos/enactjs/enact/statuses/6e1ca266be8b0e86749002ab43051ddcb806396f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ryanjduffy","id":788456,"avatar_url":"https://avatars3.githubusercontent.com/u/788456?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ryanjduffy"}}