{"action":"created","comment":{"url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/comments/243775679","pull_request_review_id":187632469,"id":243775679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc3NTY3OQ==","diff_hunk":"@@ -189,4 +178,4 @@ def unshape(x):\n                   query_len, key_len)[:, 0, :, :] \\\n             .contiguous()\n \n-        return output, top_attn\n+        return output, top_attn","path":"onmt/modules/multi_headed_attn.py","position":54,"original_position":54,"commit_id":"6ae13455db905feba772237892a7d6120e057b8b","original_commit_id":"6ae13455db905feba772237892a7d6120e057b8b","user":{"login":"vince62s","id":15141326,"node_id":"MDQ6VXNlcjE1MTQxMzI2","avatar_url":"https://avatars3.githubusercontent.com/u/15141326?v=4","gravatar_id":"","url":"https://api.github.com/users/vince62s","html_url":"https://github.com/vince62s","followers_url":"https://api.github.com/users/vince62s/followers","following_url":"https://api.github.com/users/vince62s/following{/other_user}","gists_url":"https://api.github.com/users/vince62s/gists{/gist_id}","starred_url":"https://api.github.com/users/vince62s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vince62s/subscriptions","organizations_url":"https://api.github.com/users/vince62s/orgs","repos_url":"https://api.github.com/users/vince62s/repos","events_url":"https://api.github.com/users/vince62s/events{/privacy}","received_events_url":"https://api.github.com/users/vince62s/received_events","type":"User","site_admin":false},"body":"you got to fix flake but I think you're change is not good anyway, see my other comment.","created_at":"2018-12-23T21:01:48Z","updated_at":"2018-12-23T21:01:49Z","html_url":"https://github.com/OpenNMT/OpenNMT-py/pull/1130#discussion_r243775679","pull_request_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/comments/243775679"},"html":{"href":"https://github.com/OpenNMT/OpenNMT-py/pull/1130#discussion_r243775679"},"pull_request":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130"}}},"pull_request":{"url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130","id":240693689,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjkzNjg5","html_url":"https://github.com/OpenNMT/OpenNMT-py/pull/1130","diff_url":"https://github.com/OpenNMT/OpenNMT-py/pull/1130.diff","patch_url":"https://github.com/OpenNMT/OpenNMT-py/pull/1130.patch","issue_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues/1130","number":1130,"state":"open","locked":false,"title":"Simplify multi head attention","user":{"login":"ishanch","id":10178066,"node_id":"MDQ6VXNlcjEwMTc4MDY2","avatar_url":"https://avatars0.githubusercontent.com/u/10178066?v=4","gravatar_id":"","url":"https://api.github.com/users/ishanch","html_url":"https://github.com/ishanch","followers_url":"https://api.github.com/users/ishanch/followers","following_url":"https://api.github.com/users/ishanch/following{/other_user}","gists_url":"https://api.github.com/users/ishanch/gists{/gist_id}","starred_url":"https://api.github.com/users/ishanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishanch/subscriptions","organizations_url":"https://api.github.com/users/ishanch/orgs","repos_url":"https://api.github.com/users/ishanch/repos","events_url":"https://api.github.com/users/ishanch/events{/privacy}","received_events_url":"https://api.github.com/users/ishanch/received_events","type":"User","site_admin":false},"body":"I observed that certain things like linear_keys, shape(..) are scattered throughout the multi headed attention file.\r\n","created_at":"2018-12-23T17:54:43Z","updated_at":"2018-12-23T21:01:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f77d50c114fd6dd595bbc9c582751f53907edaa6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130/commits","review_comments_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130/comments","review_comment_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues/1130/comments","statuses_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/statuses/6ae13455db905feba772237892a7d6120e057b8b","head":{"label":"ishanch:master","ref":"master","sha":"6ae13455db905feba772237892a7d6120e057b8b","user":{"login":"ishanch","id":10178066,"node_id":"MDQ6VXNlcjEwMTc4MDY2","avatar_url":"https://avatars0.githubusercontent.com/u/10178066?v=4","gravatar_id":"","url":"https://api.github.com/users/ishanch","html_url":"https://github.com/ishanch","followers_url":"https://api.github.com/users/ishanch/followers","following_url":"https://api.github.com/users/ishanch/following{/other_user}","gists_url":"https://api.github.com/users/ishanch/gists{/gist_id}","starred_url":"https://api.github.com/users/ishanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishanch/subscriptions","organizations_url":"https://api.github.com/users/ishanch/orgs","repos_url":"https://api.github.com/users/ishanch/repos","events_url":"https://api.github.com/users/ishanch/events{/privacy}","received_events_url":"https://api.github.com/users/ishanch/received_events","type":"User","site_admin":false},"repo":{"id":147997708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5OTc3MDg=","name":"OpenNMT-py","full_name":"ishanch/OpenNMT-py","private":false,"owner":{"login":"ishanch","id":10178066,"node_id":"MDQ6VXNlcjEwMTc4MDY2","avatar_url":"https://avatars0.githubusercontent.com/u/10178066?v=4","gravatar_id":"","url":"https://api.github.com/users/ishanch","html_url":"https://github.com/ishanch","followers_url":"https://api.github.com/users/ishanch/followers","following_url":"https://api.github.com/users/ishanch/following{/other_user}","gists_url":"https://api.github.com/users/ishanch/gists{/gist_id}","starred_url":"https://api.github.com/users/ishanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishanch/subscriptions","organizations_url":"https://api.github.com/users/ishanch/orgs","repos_url":"https://api.github.com/users/ishanch/repos","events_url":"https://api.github.com/users/ishanch/events{/privacy}","received_events_url":"https://api.github.com/users/ishanch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ishanch/OpenNMT-py","description":"Open Source Neural Machine Translation in PyTorch","fork":true,"url":"https://api.github.com/repos/ishanch/OpenNMT-py","forks_url":"https://api.github.com/repos/ishanch/OpenNMT-py/forks","keys_url":"https://api.github.com/repos/ishanch/OpenNMT-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ishanch/OpenNMT-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ishanch/OpenNMT-py/teams","hooks_url":"https://api.github.com/repos/ishanch/OpenNMT-py/hooks","issue_events_url":"https://api.github.com/repos/ishanch/OpenNMT-py/issues/events{/number}","events_url":"https://api.github.com/repos/ishanch/OpenNMT-py/events","assignees_url":"https://api.github.com/repos/ishanch/OpenNMT-py/assignees{/user}","branches_url":"https://api.github.com/repos/ishanch/OpenNMT-py/branches{/branch}","tags_url":"https://api.github.com/repos/ishanch/OpenNMT-py/tags","blobs_url":"https://api.github.com/repos/ishanch/OpenNMT-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ishanch/OpenNMT-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ishanch/OpenNMT-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/ishanch/OpenNMT-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ishanch/OpenNMT-py/statuses/{sha}","languages_url":"https://api.github.com/repos/ishanch/OpenNMT-py/languages","stargazers_url":"https://api.github.com/repos/ishanch/OpenNMT-py/stargazers","contributors_url":"https://api.github.com/repos/ishanch/OpenNMT-py/contributors","subscribers_url":"https://api.github.com/repos/ishanch/OpenNMT-py/subscribers","subscription_url":"https://api.github.com/repos/ishanch/OpenNMT-py/subscription","commits_url":"https://api.github.com/repos/ishanch/OpenNMT-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/ishanch/OpenNMT-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/ishanch/OpenNMT-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/ishanch/OpenNMT-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/ishanch/OpenNMT-py/contents/{+path}","compare_url":"https://api.github.com/repos/ishanch/OpenNMT-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ishanch/OpenNMT-py/merges","archive_url":"https://api.github.com/repos/ishanch/OpenNMT-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ishanch/OpenNMT-py/downloads","issues_url":"https://api.github.com/repos/ishanch/OpenNMT-py/issues{/number}","pulls_url":"https://api.github.com/repos/ishanch/OpenNMT-py/pulls{/number}","milestones_url":"https://api.github.com/repos/ishanch/OpenNMT-py/milestones{/number}","notifications_url":"https://api.github.com/repos/ishanch/OpenNMT-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ishanch/OpenNMT-py/labels{/name}","releases_url":"https://api.github.com/repos/ishanch/OpenNMT-py/releases{/id}","deployments_url":"https://api.github.com/repos/ishanch/OpenNMT-py/deployments","created_at":"2018-09-09T06:00:55Z","updated_at":"2018-12-23T17:53:39Z","pushed_at":"2018-12-23T17:53:38Z","git_url":"git://github.com/ishanch/OpenNMT-py.git","ssh_url":"git@github.com:ishanch/OpenNMT-py.git","clone_url":"https://github.com/ishanch/OpenNMT-py.git","svn_url":"https://github.com/ishanch/OpenNMT-py","homepage":"http://opennmt.net/","size":147725,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenNMT:master","ref":"master","sha":"94cc2b62990b7eeb382a6b74a7268230e2a572b5","user":{"login":"OpenNMT","id":23035727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDM1NzI3","avatar_url":"https://avatars2.githubusercontent.com/u/23035727?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenNMT","html_url":"https://github.com/OpenNMT","followers_url":"https://api.github.com/users/OpenNMT/followers","following_url":"https://api.github.com/users/OpenNMT/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMT/subscriptions","organizations_url":"https://api.github.com/users/OpenNMT/orgs","repos_url":"https://api.github.com/users/OpenNMT/repos","events_url":"https://api.github.com/users/OpenNMT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMT/received_events","type":"Organization","site_admin":false},"repo":{"id":82841862,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjg0MTg2Mg==","name":"OpenNMT-py","full_name":"OpenNMT/OpenNMT-py","private":false,"owner":{"login":"OpenNMT","id":23035727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDM1NzI3","avatar_url":"https://avatars2.githubusercontent.com/u/23035727?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenNMT","html_url":"https://github.com/OpenNMT","followers_url":"https://api.github.com/users/OpenNMT/followers","following_url":"https://api.github.com/users/OpenNMT/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMT/subscriptions","organizations_url":"https://api.github.com/users/OpenNMT/orgs","repos_url":"https://api.github.com/users/OpenNMT/repos","events_url":"https://api.github.com/users/OpenNMT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMT/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenNMT/OpenNMT-py","description":"Open Source Neural Machine Translation in PyTorch","fork":false,"url":"https://api.github.com/repos/OpenNMT/OpenNMT-py","forks_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/forks","keys_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/teams","hooks_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/hooks","issue_events_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/events","assignees_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/tags","blobs_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/languages","stargazers_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/stargazers","contributors_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/contributors","subscribers_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/subscribers","subscription_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/subscription","commits_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/merges","archive_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/downloads","issues_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMT/OpenNMT-py/deployments","created_at":"2017-02-22T19:01:50Z","updated_at":"2018-12-23T05:23:28Z","pushed_at":"2018-12-23T17:54:44Z","git_url":"git://github.com/OpenNMT/OpenNMT-py.git","ssh_url":"git@github.com:OpenNMT/OpenNMT-py.git","clone_url":"https://github.com/OpenNMT/OpenNMT-py.git","svn_url":"https://github.com/OpenNMT/OpenNMT-py","homepage":"http://opennmt.net/","size":147903,"stargazers_count":2321,"watchers_count":2321,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":948,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":948,"open_issues":26,"watchers":2321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130"},"html":{"href":"https://github.com/OpenNMT/OpenNMT-py/pull/1130"},"issue":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues/1130"},"comments":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/issues/1130/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/pulls/1130/commits"},"statuses":{"href":"https://api.github.com/repos/OpenNMT/OpenNMT-py/statuses/6ae13455db905feba772237892a7d6120e057b8b"}},"author_association":"NONE"}}
{"actor":{"display_login":"vince62s"}}