{"action":"created","comment":{"url":"https://api.github.com/repos/postgis/postgis/pulls/comments/169630072","pull_request_review_id":98185122,"id":169630072,"diff_hunk":"@@ -101,23 +101,18 @@ ptarray_from_GEOSCoordSeq(const GEOSCoordSequence* cs, char want3d)\n \n /* Return an LWGEOM from a Geometry */\n LWGEOM*\n-GEOS2LWGEOM(const GEOSGeometry* geom, char want3d)\n+GEOS2LWGEOM(const GEOSGeometry* geom, uint32_t want3d)","path":"liblwgeom/lwgeom_geos.c","position":5,"original_position":5,"commit_id":"b127dbcebdcdfb130d535d77015655773d213c6e","original_commit_id":"b127dbcebdcdfb130d535d77015655773d213c6e","user":{"login":"Komzpa","id":810638,"avatar_url":"https://avatars1.githubusercontent.com/u/810638?v=4","gravatar_id":"","url":"https://api.github.com/users/Komzpa","html_url":"https://github.com/Komzpa","followers_url":"https://api.github.com/users/Komzpa/followers","following_url":"https://api.github.com/users/Komzpa/following{/other_user}","gists_url":"https://api.github.com/users/Komzpa/gists{/gist_id}","starred_url":"https://api.github.com/users/Komzpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Komzpa/subscriptions","organizations_url":"https://api.github.com/users/Komzpa/orgs","repos_url":"https://api.github.com/users/Komzpa/repos","events_url":"https://api.github.com/users/Komzpa/events{/privacy}","received_events_url":"https://api.github.com/users/Komzpa/received_events","type":"User","site_admin":false},"body":"it's `int` in functions and `char` here.","created_at":"2018-02-21T13:07:55Z","updated_at":"2018-02-21T13:07:55Z","html_url":"https://github.com/postgis/postgis/pull/217#discussion_r169630072","pull_request_url":"https://api.github.com/repos/postgis/postgis/pulls/217","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/postgis/postgis/pulls/comments/169630072"},"html":{"href":"https://github.com/postgis/postgis/pull/217#discussion_r169630072"},"pull_request":{"href":"https://api.github.com/repos/postgis/postgis/pulls/217"}},"in_reply_to_id":169629774},"pull_request":{"url":"https://api.github.com/repos/postgis/postgis/pulls/217","id":170458326,"html_url":"https://github.com/postgis/postgis/pull/217","diff_url":"https://github.com/postgis/postgis/pull/217.diff","patch_url":"https://github.com/postgis/postgis/pull/217.patch","issue_url":"https://api.github.com/repos/postgis/postgis/issues/217","number":217,"state":"open","locked":false,"title":"lwgeom_geos.c: clean up copy-paste","user":{"login":"Komzpa","id":810638,"avatar_url":"https://avatars1.githubusercontent.com/u/810638?v=4","gravatar_id":"","url":"https://api.github.com/users/Komzpa","html_url":"https://github.com/Komzpa","followers_url":"https://api.github.com/users/Komzpa/followers","following_url":"https://api.github.com/users/Komzpa/following{/other_user}","gists_url":"https://api.github.com/users/Komzpa/gists{/gist_id}","starred_url":"https://api.github.com/users/Komzpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Komzpa/subscriptions","organizations_url":"https://api.github.com/users/Komzpa/orgs","repos_url":"https://api.github.com/users/Komzpa/repos","events_url":"https://api.github.com/users/Komzpa/events{/privacy}","received_events_url":"https://api.github.com/users/Komzpa/received_events","type":"User","site_admin":false},"body":"A large part of `lwgeom_geos.c` is error-handling copy-pasted from function to function. \r\n\r\nThere are a number of similar headers/footers and error clean up branches. \"Let's do this on exit\" or \"let's validate input more thoroughly for paranoia mode\" aren't easy as they will lead to increasingly more copy-paste.\r\n\r\nCopy-paste artifacts in comments and error messages are also cleaned up.","created_at":"2018-02-21T12:39:07Z","updated_at":"2018-02-21T13:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bdd6de239a4989d9c924a30ff22ba8dea76baad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":766630606,"url":"https://api.github.com/repos/postgis/postgis/labels/work%20in%20progress","name":"work in progress","color":"4d01af","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/postgis/postgis/pulls/217/commits","review_comments_url":"https://api.github.com/repos/postgis/postgis/pulls/217/comments","review_comment_url":"https://api.github.com/repos/postgis/postgis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postgis/postgis/issues/217/comments","statuses_url":"https://api.github.com/repos/postgis/postgis/statuses/b127dbcebdcdfb130d535d77015655773d213c6e","head":{"label":"Komzpa:geos_fortify","ref":"geos_fortify","sha":"b127dbcebdcdfb130d535d77015655773d213c6e","user":{"login":"Komzpa","id":810638,"avatar_url":"https://avatars1.githubusercontent.com/u/810638?v=4","gravatar_id":"","url":"https://api.github.com/users/Komzpa","html_url":"https://github.com/Komzpa","followers_url":"https://api.github.com/users/Komzpa/followers","following_url":"https://api.github.com/users/Komzpa/following{/other_user}","gists_url":"https://api.github.com/users/Komzpa/gists{/gist_id}","starred_url":"https://api.github.com/users/Komzpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Komzpa/subscriptions","organizations_url":"https://api.github.com/users/Komzpa/orgs","repos_url":"https://api.github.com/users/Komzpa/repos","events_url":"https://api.github.com/users/Komzpa/events{/privacy}","received_events_url":"https://api.github.com/users/Komzpa/received_events","type":"User","site_admin":false},"repo":{"id":21570405,"name":"postgis","full_name":"Komzpa/postgis","owner":{"login":"Komzpa","id":810638,"avatar_url":"https://avatars1.githubusercontent.com/u/810638?v=4","gravatar_id":"","url":"https://api.github.com/users/Komzpa","html_url":"https://github.com/Komzpa","followers_url":"https://api.github.com/users/Komzpa/followers","following_url":"https://api.github.com/users/Komzpa/following{/other_user}","gists_url":"https://api.github.com/users/Komzpa/gists{/gist_id}","starred_url":"https://api.github.com/users/Komzpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Komzpa/subscriptions","organizations_url":"https://api.github.com/users/Komzpa/orgs","repos_url":"https://api.github.com/users/Komzpa/repos","events_url":"https://api.github.com/users/Komzpa/events{/privacy}","received_events_url":"https://api.github.com/users/Komzpa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Komzpa/postgis","description":"PostGIS spatial database extension to PostgreSQL","fork":true,"url":"https://api.github.com/repos/Komzpa/postgis","forks_url":"https://api.github.com/repos/Komzpa/postgis/forks","keys_url":"https://api.github.com/repos/Komzpa/postgis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Komzpa/postgis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Komzpa/postgis/teams","hooks_url":"https://api.github.com/repos/Komzpa/postgis/hooks","issue_events_url":"https://api.github.com/repos/Komzpa/postgis/issues/events{/number}","events_url":"https://api.github.com/repos/Komzpa/postgis/events","assignees_url":"https://api.github.com/repos/Komzpa/postgis/assignees{/user}","branches_url":"https://api.github.com/repos/Komzpa/postgis/branches{/branch}","tags_url":"https://api.github.com/repos/Komzpa/postgis/tags","blobs_url":"https://api.github.com/repos/Komzpa/postgis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Komzpa/postgis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Komzpa/postgis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Komzpa/postgis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Komzpa/postgis/statuses/{sha}","languages_url":"https://api.github.com/repos/Komzpa/postgis/languages","stargazers_url":"https://api.github.com/repos/Komzpa/postgis/stargazers","contributors_url":"https://api.github.com/repos/Komzpa/postgis/contributors","subscribers_url":"https://api.github.com/repos/Komzpa/postgis/subscribers","subscription_url":"https://api.github.com/repos/Komzpa/postgis/subscription","commits_url":"https://api.github.com/repos/Komzpa/postgis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Komzpa/postgis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Komzpa/postgis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Komzpa/postgis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Komzpa/postgis/contents/{+path}","compare_url":"https://api.github.com/repos/Komzpa/postgis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Komzpa/postgis/merges","archive_url":"https://api.github.com/repos/Komzpa/postgis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Komzpa/postgis/downloads","issues_url":"https://api.github.com/repos/Komzpa/postgis/issues{/number}","pulls_url":"https://api.github.com/repos/Komzpa/postgis/pulls{/number}","milestones_url":"https://api.github.com/repos/Komzpa/postgis/milestones{/number}","notifications_url":"https://api.github.com/repos/Komzpa/postgis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Komzpa/postgis/labels{/name}","releases_url":"https://api.github.com/repos/Komzpa/postgis/releases{/id}","deployments_url":"https://api.github.com/repos/Komzpa/postgis/deployments","created_at":"2014-07-07T12:52:27Z","updated_at":"2017-10-10T12:34:19Z","pushed_at":"2018-02-21T13:00:59Z","git_url":"git://github.com/Komzpa/postgis.git","ssh_url":"git@github.com:Komzpa/postgis.git","clone_url":"https://github.com/Komzpa/postgis.git","svn_url":"https://github.com/Komzpa/postgis","homepage":null,"size":52528,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"svn-trunk"}},"base":{"label":"postgis:svn-trunk","ref":"svn-trunk","sha":"459c5006c44d2b78b652378bace8ef63fa8bebd9","user":{"login":"postgis","id":1759716,"avatar_url":"https://avatars1.githubusercontent.com/u/1759716?v=4","gravatar_id":"","url":"https://api.github.com/users/postgis","html_url":"https://github.com/postgis","followers_url":"https://api.github.com/users/postgis/followers","following_url":"https://api.github.com/users/postgis/following{/other_user}","gists_url":"https://api.github.com/users/postgis/gists{/gist_id}","starred_url":"https://api.github.com/users/postgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postgis/subscriptions","organizations_url":"https://api.github.com/users/postgis/orgs","repos_url":"https://api.github.com/users/postgis/repos","events_url":"https://api.github.com/users/postgis/events{/privacy}","received_events_url":"https://api.github.com/users/postgis/received_events","type":"Organization","site_admin":false},"repo":{"id":4407129,"name":"postgis","full_name":"postgis/postgis","owner":{"login":"postgis","id":1759716,"avatar_url":"https://avatars1.githubusercontent.com/u/1759716?v=4","gravatar_id":"","url":"https://api.github.com/users/postgis","html_url":"https://github.com/postgis","followers_url":"https://api.github.com/users/postgis/followers","following_url":"https://api.github.com/users/postgis/following{/other_user}","gists_url":"https://api.github.com/users/postgis/gists{/gist_id}","starred_url":"https://api.github.com/users/postgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postgis/subscriptions","organizations_url":"https://api.github.com/users/postgis/orgs","repos_url":"https://api.github.com/users/postgis/repos","events_url":"https://api.github.com/users/postgis/events{/privacy}","received_events_url":"https://api.github.com/users/postgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postgis/postgis","description":"PostGIS spatial database extension to PostgreSQL [mirror]","fork":false,"url":"https://api.github.com/repos/postgis/postgis","forks_url":"https://api.github.com/repos/postgis/postgis/forks","keys_url":"https://api.github.com/repos/postgis/postgis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postgis/postgis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postgis/postgis/teams","hooks_url":"https://api.github.com/repos/postgis/postgis/hooks","issue_events_url":"https://api.github.com/repos/postgis/postgis/issues/events{/number}","events_url":"https://api.github.com/repos/postgis/postgis/events","assignees_url":"https://api.github.com/repos/postgis/postgis/assignees{/user}","branches_url":"https://api.github.com/repos/postgis/postgis/branches{/branch}","tags_url":"https://api.github.com/repos/postgis/postgis/tags","blobs_url":"https://api.github.com/repos/postgis/postgis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postgis/postgis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postgis/postgis/git/refs{/sha}","trees_url":"https://api.github.com/repos/postgis/postgis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postgis/postgis/statuses/{sha}","languages_url":"https://api.github.com/repos/postgis/postgis/languages","stargazers_url":"https://api.github.com/repos/postgis/postgis/stargazers","contributors_url":"https://api.github.com/repos/postgis/postgis/contributors","subscribers_url":"https://api.github.com/repos/postgis/postgis/subscribers","subscription_url":"https://api.github.com/repos/postgis/postgis/subscription","commits_url":"https://api.github.com/repos/postgis/postgis/commits{/sha}","git_commits_url":"https://api.github.com/repos/postgis/postgis/git/commits{/sha}","comments_url":"https://api.github.com/repos/postgis/postgis/comments{/number}","issue_comment_url":"https://api.github.com/repos/postgis/postgis/issues/comments{/number}","contents_url":"https://api.github.com/repos/postgis/postgis/contents/{+path}","compare_url":"https://api.github.com/repos/postgis/postgis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postgis/postgis/merges","archive_url":"https://api.github.com/repos/postgis/postgis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postgis/postgis/downloads","issues_url":"https://api.github.com/repos/postgis/postgis/issues{/number}","pulls_url":"https://api.github.com/repos/postgis/postgis/pulls{/number}","milestones_url":"https://api.github.com/repos/postgis/postgis/milestones{/number}","notifications_url":"https://api.github.com/repos/postgis/postgis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postgis/postgis/labels{/name}","releases_url":"https://api.github.com/repos/postgis/postgis/releases{/id}","deployments_url":"https://api.github.com/repos/postgis/postgis/deployments","created_at":"2012-05-22T13:31:25Z","updated_at":"2018-02-20T22:35:00Z","pushed_at":"2018-02-21T13:01:00Z","git_url":"git://github.com/postgis/postgis.git","ssh_url":"git@github.com:postgis/postgis.git","clone_url":"https://github.com/postgis/postgis.git","svn_url":"https://github.com/postgis/postgis","homepage":"","size":54873,"stargazers_count":459,"watchers_count":459,"language":"PLpgSQL","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":206,"open_issues":9,"watchers":459,"default_branch":"svn-trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/postgis/postgis/pulls/217"},"html":{"href":"https://github.com/postgis/postgis/pull/217"},"issue":{"href":"https://api.github.com/repos/postgis/postgis/issues/217"},"comments":{"href":"https://api.github.com/repos/postgis/postgis/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/postgis/postgis/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/postgis/postgis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postgis/postgis/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/postgis/postgis/statuses/b127dbcebdcdfb130d535d77015655773d213c6e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Komzpa"}}