{"action":"created","issue":{"url":"https://api.github.com/repos/numpy/numpy/issues/11303","repository_url":"https://api.github.com/repos/numpy/numpy","labels_url":"https://api.github.com/repos/numpy/numpy/issues/11303/labels{/name}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11303/comments","events_url":"https://api.github.com/repos/numpy/numpy/issues/11303/events","html_url":"https://github.com/numpy/numpy/pull/11303","id":331072950,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODk0Mjgw","number":11303,"title":"DOC: revision of NEP-18 (__array_function__)","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-11T07:26:42Z","updated_at":"2018-06-11T17:36:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11303","html_url":"https://github.com/numpy/numpy/pull/11303","diff_url":"https://github.com/numpy/numpy/pull/11303.diff","patch_url":"https://github.com/numpy/numpy/pull/11303.patch"},"body":"I would particularly like to highlight a draft implementation (in pure Python\r\nfor now). Hopefuly this will be a useful for driving the discussion forward:\r\nhttps://nbviewer.jupyter.org/gist/shoyer/1f0a308a06cd96df20879a1ddb8f0006\r\n\r\nTODOs before merging:\r\n\r\n- [ ] review from @mrocklin\r\n\r\nOther TODOs:\r\n\r\n- [ ] decide if we want to change what is passed on to `__array_function__`\r\n      implementations: should we include `overloaded_args` and/or\r\n      `relevant_args` as well or instead?\r\n- [ ] add some discussion about static typing / PEP-484?\r\n\r\n@mhvk @hameerabbasi @ngoldbaum @mattip please leave a note if there's anything I missed from our previous discussion that you would like to see addressed in the NEP itself. Detailed discussion should of course be saved for the mailing list."},"comment":{"url":"https://api.github.com/repos/numpy/numpy/issues/comments/396324083","html_url":"https://github.com/numpy/numpy/pull/11303#issuecomment-396324083","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11303","id":396324083,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjMyNDA4Mw==","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T17:36:41Z","updated_at":"2018-06-11T17:36:41Z","author_association":"MEMBER","body":"> the code could be made much more efficient if the wrapper created a function with the right signature and made the args from that\r\n\r\nI think this would require using some sort of dynamic code generation, perhaps inspired by or using the [`decorator` module](https://github.com/micheles/decorator). Implementation wise this would be a little tricky, but in principle I agree it could work."}}
{"actor":{"display_login":"shoyer"}}