{"push_id":2788905693,"size":4,"distinct_size":4,"ref":"refs/heads/upstream/try","head":"79875fd549f251d287d880260ec557b413e32b00","before":"3e0509a9d5dfc83ade7f68694b4efe692180be1c","commits":[{"sha":"9251c71244f5b1d41ac5a5ab53c87aa065bd5ee8","author":{"name":"Diogo Sousa","email":"a6f611a574df45e1d030f975c9e59a1013701e2e@gmail.com"},"message":"Typos and style fixes.","distinct":true,"url":"https://api.github.com/repos/fuchsia-mirror/third_party-rust/commits/9251c71244f5b1d41ac5a5ab53c87aa065bd5ee8"},{"sha":"158c8f25f0d345d3a694b9b26ad525c5054b7d8a","author":{"name":"Diogo Sousa","email":"a6f611a574df45e1d030f975c9e59a1013701e2e@gmail.com"},"message":"Avoid redundant nested predicate in `SelectContext::vtable_auto_impl()`.\n\nWe now do not add a nested predicate that is the same as the parent for\ncoinductive traits, since they will always be trivially satisfied.","distinct":true,"url":"https://api.github.com/repos/fuchsia-mirror/third_party-rust/commits/158c8f25f0d345d3a694b9b26ad525c5054b7d8a"},{"sha":"fc66ffedc67921ef5cb70190c13734a609228595","author":{"name":"Diogo Sousa","email":"a6f611a574df45e1d030f975c9e59a1013701e2e@gmail.com"},"message":"The trait resolver now automatically accepts coinductive predicates if they are found up in the proof tree.\n\nFixes #40827.\nRef #30977, https://github.com/rust-lang/rust/pull/30533#issuecomment-170705871.","distinct":true,"url":"https://api.github.com/repos/fuchsia-mirror/third_party-rust/commits/fc66ffedc67921ef5cb70190c13734a609228595"},{"sha":"79875fd549f251d287d880260ec557b413e32b00","author":{"name":"bors","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org"},"message":"Auto merge of #53255 - orium:fix-bug-overflow-send, r=<try>\n\nMake the trait resolver accept coinductive predicates if they are found up in the proof tree\n\nThis implements part of what @nikomatsakis mentioned in  https://github.com/rust-lang/rust/pull/30533#issuecomment-170705871:\n\n> 1. If you find that a new obligation is a duplicate of one already in the tree, the proper processing is:\n>      * if that other location is your parent, you should abort with a cycle error (or accept it, if coinductive)\n>      * if that other location is not an ancestor, you can safely ignore the new obligation\n\nIn particular it implements the \"if that other location is your parent accept it, if coinductive\" part.  This fixes #40827.\n\nI have to say that I'm not 100% confident that this is rock solid.  This is my first pull request :tada:, and I didn't know anything about the trait resolver before this.  In particular I'm not totally sure that comparing predicates is enough (for instance, do we need to compare `param_env` as well?).  Also, I'm not sure what @nikomatsakis mentions [here](https://github.com/rust-lang/rust/issues/30977#issue-127091096), but it might be something that affects this PR:\n\n> In particular, I am wary of getting things wrong around inference variables! We can always add things to the set in their current state, and if unifications occur then the obligation is just kind of out-of-date, but I want to be sure we don't accidentally fail to notice that something is our ancestor. I decided this was subtle enough to merit its own PR.\n\nAnyway, go ahead and review :slightly_smiling_face:.\n\nRef #30977.\n\n# Performance\n\nWe are now copying vectors around, so I decided to do some benchmarking.  A simple benchmark shows that this does not seem to affect performance in a measurable way:\n\nI ran `cargo clean && cargo build` 20 times on actix-web (84b27db) and these are the results:\n\n```text\nrustc master:\n\n            Mean        Std.Dev.    Min         Median      Max\nreal        66.637      2.996       57.220      67.714      69.314\nuser        307.293     14.741      258.093     312.209     320.702\nsys         12.524      0.653       10.499      12.726      13.193\n\nrustc fix-bug-overflow-send:\n\n            Mean        Std.Dev.    Min         Median      Max\nreal        66.297      4.310       53.532      67.516      70.348\nuser        306.812     22.371      236.917     314.748     326.229\nsys         12.757      0.952       9.671       13.125      13.544\n```\n\nI will do a more comprehensive benchmark (compiling rustc stage1) and post the results.\n\nr? @nikomatsakis, @nnethercote\n\nPS: It is better to review this commit-by-commit.","distinct":true,"url":"https://api.github.com/repos/fuchsia-mirror/third_party-rust/commits/79875fd549f251d287d880260ec557b413e32b00"}]}
{"actor":{"display_login":"fuchsia-infra-bot"}}