{"action":"created","comment":{"url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/comments/227559297","pull_request_review_id":167630348,"id":227559297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzU1OTI5Nw==","diff_hunk":"@@ -37,8 +37,10 @@ class QFrame;\n \n #if QT_VERSION >= 0x050000\n static inline QString COLORNAME( QColor c ) { return c.name(QColor::HexArgb); }\n+static inline QString COLORVALUE( QString s ) { return s; }\n #else\n static inline QString COLORNAME( QColor c ) { return ('#'+QString::number(c.rgba(),16)); }\n+static inline QString COLORVALUE( QString s ) { if ((s[0]=='#') && (s.size()==9)) return s.remove(1,2); else return s; }","path":"libscidavis/src/ColorButton.h","position":7,"original_position":7,"commit_id":"bd22981ba1cd41406a663cfc477928d4006837ec","original_commit_id":"bd22981ba1cd41406a663cfc477928d4006837ec","user":{"login":"highperformancecoder","id":3075825,"node_id":"MDQ6VXNlcjMwNzU4MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3075825?v=4","gravatar_id":"","url":"https://api.github.com/users/highperformancecoder","html_url":"https://github.com/highperformancecoder","followers_url":"https://api.github.com/users/highperformancecoder/followers","following_url":"https://api.github.com/users/highperformancecoder/following{/other_user}","gists_url":"https://api.github.com/users/highperformancecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/highperformancecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highperformancecoder/subscriptions","organizations_url":"https://api.github.com/users/highperformancecoder/orgs","repos_url":"https://api.github.com/users/highperformancecoder/repos","events_url":"https://api.github.com/users/highperformancecoder/events{/privacy}","received_events_url":"https://api.github.com/users/highperformancecoder/received_events","type":"User","site_admin":false},"body":"The downside of this approach is that all the colours are assumed to be opaque. But the workaround (extracting the alpha channel component and setting that separately) is probably not worth doing, given we're moving onto Qt5 shortly anyway,","created_at":"2018-10-23T20:51:06Z","updated_at":"2018-10-23T20:51:06Z","html_url":"https://github.com/highperformancecoder/scidavis/pull/106#discussion_r227559297","pull_request_url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/comments/227559297"},"html":{"href":"https://github.com/highperformancecoder/scidavis/pull/106#discussion_r227559297"},"pull_request":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106","id":225142225,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTQyMjI1","html_url":"https://github.com/highperformancecoder/scidavis/pull/106","diff_url":"https://github.com/highperformancecoder/scidavis/pull/106.diff","patch_url":"https://github.com/highperformancecoder/scidavis/pull/106.patch","issue_url":"https://api.github.com/repos/highperformancecoder/scidavis/issues/106","number":106,"state":"open","locked":false,"title":"Fix loading of color setttings in Qt4","user":{"login":"gbm19","id":20240062,"node_id":"MDQ6VXNlcjIwMjQwMDYy","avatar_url":"https://avatars3.githubusercontent.com/u/20240062?v=4","gravatar_id":"","url":"https://api.github.com/users/gbm19","html_url":"https://github.com/gbm19","followers_url":"https://api.github.com/users/gbm19/followers","following_url":"https://api.github.com/users/gbm19/following{/other_user}","gists_url":"https://api.github.com/users/gbm19/gists{/gist_id}","starred_url":"https://api.github.com/users/gbm19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbm19/subscriptions","organizations_url":"https://api.github.com/users/gbm19/orgs","repos_url":"https://api.github.com/users/gbm19/repos","events_url":"https://api.github.com/users/gbm19/events{/privacy}","received_events_url":"https://api.github.com/users/gbm19/received_events","type":"User","site_admin":false},"body":"Qt4 cannot read color values in `#aarrggbb` format. \r\nThis PR solves the problem.","created_at":"2018-10-23T18:31:19Z","updated_at":"2018-10-23T20:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05d98e68290cb232aa4801dcf7fb961f6f82afc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106/commits","review_comments_url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106/comments","review_comment_url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highperformancecoder/scidavis/issues/106/comments","statuses_url":"https://api.github.com/repos/highperformancecoder/scidavis/statuses/bd22981ba1cd41406a663cfc477928d4006837ec","head":{"label":"gbm19:colorenhance","ref":"colorenhance","sha":"bd22981ba1cd41406a663cfc477928d4006837ec","user":{"login":"gbm19","id":20240062,"node_id":"MDQ6VXNlcjIwMjQwMDYy","avatar_url":"https://avatars3.githubusercontent.com/u/20240062?v=4","gravatar_id":"","url":"https://api.github.com/users/gbm19","html_url":"https://github.com/gbm19","followers_url":"https://api.github.com/users/gbm19/followers","following_url":"https://api.github.com/users/gbm19/following{/other_user}","gists_url":"https://api.github.com/users/gbm19/gists{/gist_id}","starred_url":"https://api.github.com/users/gbm19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbm19/subscriptions","organizations_url":"https://api.github.com/users/gbm19/orgs","repos_url":"https://api.github.com/users/gbm19/repos","events_url":"https://api.github.com/users/gbm19/events{/privacy}","received_events_url":"https://api.github.com/users/gbm19/received_events","type":"User","site_admin":false},"repo":{"id":86329127,"node_id":"MDEwOlJlcG9zaXRvcnk4NjMyOTEyNw==","name":"scidavis","full_name":"gbm19/scidavis","private":false,"owner":{"login":"gbm19","id":20240062,"node_id":"MDQ6VXNlcjIwMjQwMDYy","avatar_url":"https://avatars3.githubusercontent.com/u/20240062?v=4","gravatar_id":"","url":"https://api.github.com/users/gbm19","html_url":"https://github.com/gbm19","followers_url":"https://api.github.com/users/gbm19/followers","following_url":"https://api.github.com/users/gbm19/following{/other_user}","gists_url":"https://api.github.com/users/gbm19/gists{/gist_id}","starred_url":"https://api.github.com/users/gbm19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbm19/subscriptions","organizations_url":"https://api.github.com/users/gbm19/orgs","repos_url":"https://api.github.com/users/gbm19/repos","events_url":"https://api.github.com/users/gbm19/events{/privacy}","received_events_url":"https://api.github.com/users/gbm19/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gbm19/scidavis","description":"SciDAVis is a user-friendly data analysis and visualization program primarily aimed at high-quality plotting of scientific data. It strives to combine an intuitive, easy-to-use graphical user interface with powerful features such as Python scriptability.","fork":true,"url":"https://api.github.com/repos/gbm19/scidavis","forks_url":"https://api.github.com/repos/gbm19/scidavis/forks","keys_url":"https://api.github.com/repos/gbm19/scidavis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbm19/scidavis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbm19/scidavis/teams","hooks_url":"https://api.github.com/repos/gbm19/scidavis/hooks","issue_events_url":"https://api.github.com/repos/gbm19/scidavis/issues/events{/number}","events_url":"https://api.github.com/repos/gbm19/scidavis/events","assignees_url":"https://api.github.com/repos/gbm19/scidavis/assignees{/user}","branches_url":"https://api.github.com/repos/gbm19/scidavis/branches{/branch}","tags_url":"https://api.github.com/repos/gbm19/scidavis/tags","blobs_url":"https://api.github.com/repos/gbm19/scidavis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbm19/scidavis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbm19/scidavis/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbm19/scidavis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbm19/scidavis/statuses/{sha}","languages_url":"https://api.github.com/repos/gbm19/scidavis/languages","stargazers_url":"https://api.github.com/repos/gbm19/scidavis/stargazers","contributors_url":"https://api.github.com/repos/gbm19/scidavis/contributors","subscribers_url":"https://api.github.com/repos/gbm19/scidavis/subscribers","subscription_url":"https://api.github.com/repos/gbm19/scidavis/subscription","commits_url":"https://api.github.com/repos/gbm19/scidavis/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbm19/scidavis/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbm19/scidavis/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbm19/scidavis/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbm19/scidavis/contents/{+path}","compare_url":"https://api.github.com/repos/gbm19/scidavis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbm19/scidavis/merges","archive_url":"https://api.github.com/repos/gbm19/scidavis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbm19/scidavis/downloads","issues_url":"https://api.github.com/repos/gbm19/scidavis/issues{/number}","pulls_url":"https://api.github.com/repos/gbm19/scidavis/pulls{/number}","milestones_url":"https://api.github.com/repos/gbm19/scidavis/milestones{/number}","notifications_url":"https://api.github.com/repos/gbm19/scidavis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbm19/scidavis/labels{/name}","releases_url":"https://api.github.com/repos/gbm19/scidavis/releases{/id}","deployments_url":"https://api.github.com/repos/gbm19/scidavis/deployments","created_at":"2017-03-27T11:50:27Z","updated_at":"2018-10-21T11:56:43Z","pushed_at":"2018-10-23T20:33:19Z","git_url":"git://github.com/gbm19/scidavis.git","ssh_url":"git@github.com:gbm19/scidavis.git","clone_url":"https://github.com/gbm19/scidavis.git","svn_url":"https://github.com/gbm19/scidavis","homepage":null,"size":35501,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highperformancecoder:master","ref":"master","sha":"72fca5aebe197661c5531c8c4f9c12d76fbb39c2","user":{"login":"highperformancecoder","id":3075825,"node_id":"MDQ6VXNlcjMwNzU4MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3075825?v=4","gravatar_id":"","url":"https://api.github.com/users/highperformancecoder","html_url":"https://github.com/highperformancecoder","followers_url":"https://api.github.com/users/highperformancecoder/followers","following_url":"https://api.github.com/users/highperformancecoder/following{/other_user}","gists_url":"https://api.github.com/users/highperformancecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/highperformancecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highperformancecoder/subscriptions","organizations_url":"https://api.github.com/users/highperformancecoder/orgs","repos_url":"https://api.github.com/users/highperformancecoder/repos","events_url":"https://api.github.com/users/highperformancecoder/events{/privacy}","received_events_url":"https://api.github.com/users/highperformancecoder/received_events","type":"User","site_admin":false},"repo":{"id":38276816,"node_id":"MDEwOlJlcG9zaXRvcnkzODI3NjgxNg==","name":"scidavis","full_name":"highperformancecoder/scidavis","private":false,"owner":{"login":"highperformancecoder","id":3075825,"node_id":"MDQ6VXNlcjMwNzU4MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3075825?v=4","gravatar_id":"","url":"https://api.github.com/users/highperformancecoder","html_url":"https://github.com/highperformancecoder","followers_url":"https://api.github.com/users/highperformancecoder/followers","following_url":"https://api.github.com/users/highperformancecoder/following{/other_user}","gists_url":"https://api.github.com/users/highperformancecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/highperformancecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highperformancecoder/subscriptions","organizations_url":"https://api.github.com/users/highperformancecoder/orgs","repos_url":"https://api.github.com/users/highperformancecoder/repos","events_url":"https://api.github.com/users/highperformancecoder/events{/privacy}","received_events_url":"https://api.github.com/users/highperformancecoder/received_events","type":"User","site_admin":false},"html_url":"https://github.com/highperformancecoder/scidavis","description":"SciDAVis is a user-friendly data analysis and visualization program primarily aimed at high-quality plotting of scientific data. It strives to combine an intuitive, easy-to-use graphical user interface with powerful features such as Python scriptability.","fork":false,"url":"https://api.github.com/repos/highperformancecoder/scidavis","forks_url":"https://api.github.com/repos/highperformancecoder/scidavis/forks","keys_url":"https://api.github.com/repos/highperformancecoder/scidavis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highperformancecoder/scidavis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highperformancecoder/scidavis/teams","hooks_url":"https://api.github.com/repos/highperformancecoder/scidavis/hooks","issue_events_url":"https://api.github.com/repos/highperformancecoder/scidavis/issues/events{/number}","events_url":"https://api.github.com/repos/highperformancecoder/scidavis/events","assignees_url":"https://api.github.com/repos/highperformancecoder/scidavis/assignees{/user}","branches_url":"https://api.github.com/repos/highperformancecoder/scidavis/branches{/branch}","tags_url":"https://api.github.com/repos/highperformancecoder/scidavis/tags","blobs_url":"https://api.github.com/repos/highperformancecoder/scidavis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highperformancecoder/scidavis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highperformancecoder/scidavis/git/refs{/sha}","trees_url":"https://api.github.com/repos/highperformancecoder/scidavis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highperformancecoder/scidavis/statuses/{sha}","languages_url":"https://api.github.com/repos/highperformancecoder/scidavis/languages","stargazers_url":"https://api.github.com/repos/highperformancecoder/scidavis/stargazers","contributors_url":"https://api.github.com/repos/highperformancecoder/scidavis/contributors","subscribers_url":"https://api.github.com/repos/highperformancecoder/scidavis/subscribers","subscription_url":"https://api.github.com/repos/highperformancecoder/scidavis/subscription","commits_url":"https://api.github.com/repos/highperformancecoder/scidavis/commits{/sha}","git_commits_url":"https://api.github.com/repos/highperformancecoder/scidavis/git/commits{/sha}","comments_url":"https://api.github.com/repos/highperformancecoder/scidavis/comments{/number}","issue_comment_url":"https://api.github.com/repos/highperformancecoder/scidavis/issues/comments{/number}","contents_url":"https://api.github.com/repos/highperformancecoder/scidavis/contents/{+path}","compare_url":"https://api.github.com/repos/highperformancecoder/scidavis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highperformancecoder/scidavis/merges","archive_url":"https://api.github.com/repos/highperformancecoder/scidavis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highperformancecoder/scidavis/downloads","issues_url":"https://api.github.com/repos/highperformancecoder/scidavis/issues{/number}","pulls_url":"https://api.github.com/repos/highperformancecoder/scidavis/pulls{/number}","milestones_url":"https://api.github.com/repos/highperformancecoder/scidavis/milestones{/number}","notifications_url":"https://api.github.com/repos/highperformancecoder/scidavis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highperformancecoder/scidavis/labels{/name}","releases_url":"https://api.github.com/repos/highperformancecoder/scidavis/releases{/id}","deployments_url":"https://api.github.com/repos/highperformancecoder/scidavis/deployments","created_at":"2015-06-29T23:35:40Z","updated_at":"2018-10-22T04:21:55Z","pushed_at":"2018-10-23T20:34:31Z","git_url":"git://github.com/highperformancecoder/scidavis.git","ssh_url":"git@github.com:highperformancecoder/scidavis.git","clone_url":"https://github.com/highperformancecoder/scidavis.git","svn_url":"https://github.com/highperformancecoder/scidavis","homepage":null,"size":46373,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":8,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106"},"html":{"href":"https://github.com/highperformancecoder/scidavis/pull/106"},"issue":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/issues/106"},"comments":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/highperformancecoder/scidavis/statuses/bd22981ba1cd41406a663cfc477928d4006837ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"highperformancecoder"}}