{"action":"opened","number":1100,"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1100","id":240832480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODMyNDgw","html_url":"https://github.com/wxWidgets/wxWidgets/pull/1100","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/1100.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/1100.patch","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1100","number":1100,"state":"open","locked":false,"title":"CMake: Fix monolithic build","user":{"login":"jbfove","id":22759056,"node_id":"MDQ6VXNlcjIyNzU5MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/22759056?v=4","gravatar_id":"","url":"https://api.github.com/users/jbfove","html_url":"https://github.com/jbfove","followers_url":"https://api.github.com/users/jbfove/followers","following_url":"https://api.github.com/users/jbfove/following{/other_user}","gists_url":"https://api.github.com/users/jbfove/gists{/gist_id}","starred_url":"https://api.github.com/users/jbfove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbfove/subscriptions","organizations_url":"https://api.github.com/users/jbfove/orgs","repos_url":"https://api.github.com/users/jbfove/repos","events_url":"https://api.github.com/users/jbfove/events{/privacy}","received_events_url":"https://api.github.com/users/jbfove/received_events","type":"User","site_admin":false},"body":"Monolithic build regressed with commit 815d288c4fedba044a9863c883d6dd9f53526668\r\n\"Set wx-config base, gui and built libraries\"\r\n\r\nThe code queries each possible target name and creates lists of the valid targets.\r\nIn the monolithic build, none of the normal target names exist, so the list is empty.\r\nThe empty list is then passed to STRIP, causing cmake to fail due to not having enough arguments.\r\n\r\nBy quoting the STRIP params we can pass an empty argument and thus prevent the error of not-enough arguments.\r\n\r\nThe monolithic target (mono) is also added to the target search list for completeness.\r\n\r\n\r\n\r\nThe other option would simply be to remove the block of code here that computes BUILT_WX_LIBS, STD_BASE_LIBS, and STD_GUI_LIBS. I tested this and it appears to work fine. I can't find the uses of these variables at all, other than they mirror similar variables in the autotools stuff. That said, this code modified here was updated recently so I figure it's safer to update it rather than remove it.","created_at":"2018-12-25T05:02:37Z","updated_at":"2018-12-25T05:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1100/comments","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/d2effbf22932cb8bd5ae77ed48a7c9de4494e6f9","head":{"label":"jbfove:master","ref":"master","sha":"d2effbf22932cb8bd5ae77ed48a7c9de4494e6f9","user":{"login":"jbfove","id":22759056,"node_id":"MDQ6VXNlcjIyNzU5MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/22759056?v=4","gravatar_id":"","url":"https://api.github.com/users/jbfove","html_url":"https://github.com/jbfove","followers_url":"https://api.github.com/users/jbfove/followers","following_url":"https://api.github.com/users/jbfove/following{/other_user}","gists_url":"https://api.github.com/users/jbfove/gists{/gist_id}","starred_url":"https://api.github.com/users/jbfove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbfove/subscriptions","organizations_url":"https://api.github.com/users/jbfove/orgs","repos_url":"https://api.github.com/users/jbfove/repos","events_url":"https://api.github.com/users/jbfove/events{/privacy}","received_events_url":"https://api.github.com/users/jbfove/received_events","type":"User","site_admin":false},"repo":{"id":133193186,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxOTMxODY=","name":"wxWidgets","full_name":"jbfove/wxWidgets","private":false,"owner":{"login":"jbfove","id":22759056,"node_id":"MDQ6VXNlcjIyNzU5MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/22759056?v=4","gravatar_id":"","url":"https://api.github.com/users/jbfove","html_url":"https://github.com/jbfove","followers_url":"https://api.github.com/users/jbfove/followers","following_url":"https://api.github.com/users/jbfove/following{/other_user}","gists_url":"https://api.github.com/users/jbfove/gists{/gist_id}","starred_url":"https://api.github.com/users/jbfove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbfove/subscriptions","organizations_url":"https://api.github.com/users/jbfove/orgs","repos_url":"https://api.github.com/users/jbfove/repos","events_url":"https://api.github.com/users/jbfove/events{/privacy}","received_events_url":"https://api.github.com/users/jbfove/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbfove/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":true,"url":"https://api.github.com/repos/jbfove/wxWidgets","forks_url":"https://api.github.com/repos/jbfove/wxWidgets/forks","keys_url":"https://api.github.com/repos/jbfove/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbfove/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbfove/wxWidgets/teams","hooks_url":"https://api.github.com/repos/jbfove/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/jbfove/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/jbfove/wxWidgets/events","assignees_url":"https://api.github.com/repos/jbfove/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/jbfove/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/jbfove/wxWidgets/tags","blobs_url":"https://api.github.com/repos/jbfove/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbfove/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbfove/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbfove/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbfove/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/jbfove/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/jbfove/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/jbfove/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/jbfove/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/jbfove/wxWidgets/subscription","commits_url":"https://api.github.com/repos/jbfove/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbfove/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbfove/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbfove/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbfove/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/jbfove/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbfove/wxWidgets/merges","archive_url":"https://api.github.com/repos/jbfove/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbfove/wxWidgets/downloads","issues_url":"https://api.github.com/repos/jbfove/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/jbfove/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/jbfove/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/jbfove/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbfove/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/jbfove/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/jbfove/wxWidgets/deployments","created_at":"2018-05-13T00:21:15Z","updated_at":"2018-12-25T04:06:23Z","pushed_at":"2018-12-25T04:06:21Z","git_url":"git://github.com/jbfove/wxWidgets.git","ssh_url":"git@github.com:jbfove/wxWidgets.git","clone_url":"https://github.com/jbfove/wxWidgets.git","svn_url":"https://github.com/jbfove/wxWidgets","homepage":"https://www.wxwidgets.org/","size":312761,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wxWidgets:master","ref":"master","sha":"a207862210dcc0d7e5bd58d67747217493718879","user":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"repo":{"id":1764646,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0NjQ2","name":"wxWidgets","full_name":"wxWidgets/wxWidgets","private":false,"owner":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wxWidgets/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":false,"url":"https://api.github.com/repos/wxWidgets/wxWidgets","forks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/forks","keys_url":"https://api.github.com/repos/wxWidgets/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wxWidgets/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wxWidgets/wxWidgets/teams","hooks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/events","assignees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/wxWidgets/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/tags","blobs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/wxWidgets/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscription","commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/wxWidgets/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wxWidgets/wxWidgets/merges","archive_url":"https://api.github.com/repos/wxWidgets/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wxWidgets/wxWidgets/downloads","issues_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/wxWidgets/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/wxWidgets/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/wxWidgets/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/deployments","created_at":"2011-05-18T05:54:03Z","updated_at":"2018-12-24T18:08:51Z","pushed_at":"2018-12-24T17:41:46Z","git_url":"git://github.com/wxWidgets/wxWidgets.git","ssh_url":"git@github.com:wxWidgets/wxWidgets.git","clone_url":"https://github.com/wxWidgets/wxWidgets.git","svn_url":"https://github.com/wxWidgets/wxWidgets","homepage":"https://www.wxwidgets.org/","size":313157,"stargazers_count":2238,"watchers_count":2238,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":843,"mirror_url":null,"archived":false,"open_issues_count":36,"license":null,"forks":843,"open_issues":36,"watchers":2238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1100"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/1100"},"issue":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1100"},"comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/d2effbf22932cb8bd5ae77ed48a7c9de4494e6f9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"jbfove"}}