{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/iot/pulls/comments/245418768","pull_request_review_id":189526165,"id":245418768,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQxODc2OA==","diff_hunk":"@@ -8,7 +8,7 @@ public class OpCode\n     {\n         public static byte GetOpCode(int deviceAddress, bool isReadCommand)\n         {\n-            int opCode = 0b0100_0000 | (deviceAddress << 1);\n+            int opCode = deviceAddress << 1;","path":"src/devices/Mcp23xxx/OpCode.cs","position":5,"original_position":5,"commit_id":"005975080824355f07272a98bf2a6fbeea21a76c","original_commit_id":"005975080824355f07272a98bf2a6fbeea21a76c","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"I know it is not from this PR but should this class be static given that it only has one static method.","created_at":"2019-01-04T20:57:51Z","updated_at":"2019-01-04T20:57:51Z","html_url":"https://github.com/dotnet/iot/pull/130#discussion_r245418768","pull_request_url":"https://api.github.com/repos/dotnet/iot/pulls/130","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/iot/pulls/comments/245418768"},"html":{"href":"https://github.com/dotnet/iot/pull/130#discussion_r245418768"},"pull_request":{"href":"https://api.github.com/repos/dotnet/iot/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/iot/pulls/130","id":241525112,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTI1MTEy","html_url":"https://github.com/dotnet/iot/pull/130","diff_url":"https://github.com/dotnet/iot/pull/130.diff","patch_url":"https://github.com/dotnet/iot/pull/130.patch","issue_url":"https://api.github.com/repos/dotnet/iot/issues/130","number":130,"state":"open","locked":false,"title":"Added pin options, abstract class and I2C","user":{"login":"shaggygi","id":2956825,"node_id":"MDQ6VXNlcjI5NTY4MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2956825?v=4","gravatar_id":"","url":"https://api.github.com/users/shaggygi","html_url":"https://github.com/shaggygi","followers_url":"https://api.github.com/users/shaggygi/followers","following_url":"https://api.github.com/users/shaggygi/following{/other_user}","gists_url":"https://api.github.com/users/shaggygi/gists{/gist_id}","starred_url":"https://api.github.com/users/shaggygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaggygi/subscriptions","organizations_url":"https://api.github.com/users/shaggygi/orgs","repos_url":"https://api.github.com/users/shaggygi/repos","events_url":"https://api.github.com/users/shaggygi/events{/privacy}","received_events_url":"https://api.github.com/users/shaggygi/received_events","type":"User","site_admin":false},"body":"Created an abstract and separated for I2C and SPI.\r\n\r\nModified addressing approach to instantiate binding with device instead of being able to address multiple devices within Read/Write methods.  This fits better with the connection settings.\r\n\r\nAdded controller pin options for reset and interrupt pins.  Events are planned for future PR.\r\n\r\nUpdated samples and documentation.\r\n\r\nSee https://github.com/dotnet/iot/issues/88 for future details.\r\n","created_at":"2018-12-31T04:34:25Z","updated_at":"2019-01-04T20:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daa42650a21d2d0f6a412db1be539b04b4e45b9e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tarekgh","id":10833894,"node_id":"MDQ6VXNlcjEwODMzODk0","avatar_url":"https://avatars2.githubusercontent.com/u/10833894?v=4","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},{"login":"buyaa-n","id":45579687,"node_id":"MDQ6VXNlcjQ1NTc5Njg3","avatar_url":"https://avatars0.githubusercontent.com/u/45579687?v=4","gravatar_id":"","url":"https://api.github.com/users/buyaa-n","html_url":"https://github.com/buyaa-n","followers_url":"https://api.github.com/users/buyaa-n/followers","following_url":"https://api.github.com/users/buyaa-n/following{/other_user}","gists_url":"https://api.github.com/users/buyaa-n/gists{/gist_id}","starred_url":"https://api.github.com/users/buyaa-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buyaa-n/subscriptions","organizations_url":"https://api.github.com/users/buyaa-n/orgs","repos_url":"https://api.github.com/users/buyaa-n/repos","events_url":"https://api.github.com/users/buyaa-n/events{/privacy}","received_events_url":"https://api.github.com/users/buyaa-n/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/iot/pulls/130/commits","review_comments_url":"https://api.github.com/repos/dotnet/iot/pulls/130/comments","review_comment_url":"https://api.github.com/repos/dotnet/iot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/iot/issues/130/comments","statuses_url":"https://api.github.com/repos/dotnet/iot/statuses/005975080824355f07272a98bf2a6fbeea21a76c","head":{"label":"shaggygi:mcp23xxx-pin-additions","ref":"mcp23xxx-pin-additions","sha":"005975080824355f07272a98bf2a6fbeea21a76c","user":{"login":"shaggygi","id":2956825,"node_id":"MDQ6VXNlcjI5NTY4MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2956825?v=4","gravatar_id":"","url":"https://api.github.com/users/shaggygi","html_url":"https://github.com/shaggygi","followers_url":"https://api.github.com/users/shaggygi/followers","following_url":"https://api.github.com/users/shaggygi/following{/other_user}","gists_url":"https://api.github.com/users/shaggygi/gists{/gist_id}","starred_url":"https://api.github.com/users/shaggygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaggygi/subscriptions","organizations_url":"https://api.github.com/users/shaggygi/orgs","repos_url":"https://api.github.com/users/shaggygi/repos","events_url":"https://api.github.com/users/shaggygi/events{/privacy}","received_events_url":"https://api.github.com/users/shaggygi/received_events","type":"User","site_admin":false},"repo":{"id":162653315,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI2NTMzMTU=","name":"iot","full_name":"shaggygi/iot","private":false,"owner":{"login":"shaggygi","id":2956825,"node_id":"MDQ6VXNlcjI5NTY4MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2956825?v=4","gravatar_id":"","url":"https://api.github.com/users/shaggygi","html_url":"https://github.com/shaggygi","followers_url":"https://api.github.com/users/shaggygi/followers","following_url":"https://api.github.com/users/shaggygi/following{/other_user}","gists_url":"https://api.github.com/users/shaggygi/gists{/gist_id}","starred_url":"https://api.github.com/users/shaggygi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaggygi/subscriptions","organizations_url":"https://api.github.com/users/shaggygi/orgs","repos_url":"https://api.github.com/users/shaggygi/repos","events_url":"https://api.github.com/users/shaggygi/events{/privacy}","received_events_url":"https://api.github.com/users/shaggygi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shaggygi/iot","description":"This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.","fork":true,"url":"https://api.github.com/repos/shaggygi/iot","forks_url":"https://api.github.com/repos/shaggygi/iot/forks","keys_url":"https://api.github.com/repos/shaggygi/iot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaggygi/iot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaggygi/iot/teams","hooks_url":"https://api.github.com/repos/shaggygi/iot/hooks","issue_events_url":"https://api.github.com/repos/shaggygi/iot/issues/events{/number}","events_url":"https://api.github.com/repos/shaggygi/iot/events","assignees_url":"https://api.github.com/repos/shaggygi/iot/assignees{/user}","branches_url":"https://api.github.com/repos/shaggygi/iot/branches{/branch}","tags_url":"https://api.github.com/repos/shaggygi/iot/tags","blobs_url":"https://api.github.com/repos/shaggygi/iot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaggygi/iot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaggygi/iot/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaggygi/iot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaggygi/iot/statuses/{sha}","languages_url":"https://api.github.com/repos/shaggygi/iot/languages","stargazers_url":"https://api.github.com/repos/shaggygi/iot/stargazers","contributors_url":"https://api.github.com/repos/shaggygi/iot/contributors","subscribers_url":"https://api.github.com/repos/shaggygi/iot/subscribers","subscription_url":"https://api.github.com/repos/shaggygi/iot/subscription","commits_url":"https://api.github.com/repos/shaggygi/iot/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaggygi/iot/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaggygi/iot/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaggygi/iot/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaggygi/iot/contents/{+path}","compare_url":"https://api.github.com/repos/shaggygi/iot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaggygi/iot/merges","archive_url":"https://api.github.com/repos/shaggygi/iot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaggygi/iot/downloads","issues_url":"https://api.github.com/repos/shaggygi/iot/issues{/number}","pulls_url":"https://api.github.com/repos/shaggygi/iot/pulls{/number}","milestones_url":"https://api.github.com/repos/shaggygi/iot/milestones{/number}","notifications_url":"https://api.github.com/repos/shaggygi/iot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaggygi/iot/labels{/name}","releases_url":"https://api.github.com/repos/shaggygi/iot/releases{/id}","deployments_url":"https://api.github.com/repos/shaggygi/iot/deployments","created_at":"2018-12-21T02:07:27Z","updated_at":"2018-12-31T15:02:36Z","pushed_at":"2019-01-03T23:03:28Z","git_url":"git://github.com/shaggygi/iot.git","ssh_url":"git@github.com:shaggygi/iot.git","clone_url":"https://github.com/shaggygi/iot.git","svn_url":"https://github.com/shaggygi/iot","homepage":"","size":5836,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"41b58736382033dcafa103281d53ae7946ade09b","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":151623607,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MjM2MDc=","name":"iot","full_name":"dotnet/iot","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/iot","description":"This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.","fork":false,"url":"https://api.github.com/repos/dotnet/iot","forks_url":"https://api.github.com/repos/dotnet/iot/forks","keys_url":"https://api.github.com/repos/dotnet/iot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/iot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/iot/teams","hooks_url":"https://api.github.com/repos/dotnet/iot/hooks","issue_events_url":"https://api.github.com/repos/dotnet/iot/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/iot/events","assignees_url":"https://api.github.com/repos/dotnet/iot/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/iot/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/iot/tags","blobs_url":"https://api.github.com/repos/dotnet/iot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/iot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/iot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/iot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/iot/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/iot/languages","stargazers_url":"https://api.github.com/repos/dotnet/iot/stargazers","contributors_url":"https://api.github.com/repos/dotnet/iot/contributors","subscribers_url":"https://api.github.com/repos/dotnet/iot/subscribers","subscription_url":"https://api.github.com/repos/dotnet/iot/subscription","commits_url":"https://api.github.com/repos/dotnet/iot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/iot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/iot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/iot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/iot/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/iot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/iot/merges","archive_url":"https://api.github.com/repos/dotnet/iot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/iot/downloads","issues_url":"https://api.github.com/repos/dotnet/iot/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/iot/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/iot/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/iot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/iot/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/iot/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/iot/deployments","created_at":"2018-10-04T19:15:33Z","updated_at":"2019-01-03T17:11:11Z","pushed_at":"2019-01-03T22:56:15Z","git_url":"git://github.com/dotnet/iot.git","ssh_url":"git@github.com:dotnet/iot.git","clone_url":"https://github.com/dotnet/iot.git","svn_url":"https://github.com/dotnet/iot","homepage":"","size":5782,"stargazers_count":169,"watchers_count":169,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":51,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/iot/pulls/130"},"html":{"href":"https://github.com/dotnet/iot/pull/130"},"issue":{"href":"https://api.github.com/repos/dotnet/iot/issues/130"},"comments":{"href":"https://api.github.com/repos/dotnet/iot/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/iot/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/iot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/iot/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/iot/statuses/005975080824355f07272a98bf2a6fbeea21a76c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"joperezr"}}