{"action":"created","comment":{"url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/comments/232814415","pull_request_review_id":174096581,"id":232814415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjgxNDQxNQ==","diff_hunk":"@@ -413,7 +415,7 @@ export default Service.extend({\n     @param {EmberInfinity.InfinityModel} infinityModel\n    */\n   _notifyInfinityModelUpdated(queryObject, infinityModel) {\n-    const totalPages = get(this, '_totalPages');\n+    const totalPages = get(infinityModel, '_totalPages');","path":"addon/services/infinity.js","position":21,"original_position":21,"commit_id":"1b897a202c7501975ee0b35c94d979f510693302","original_commit_id":"1b897a202c7501975ee0b35c94d979f510693302","user":{"login":"johncalvinyoung","id":1924520,"node_id":"MDQ6VXNlcjE5MjQ1MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1924520?v=4","gravatar_id":"","url":"https://api.github.com/users/johncalvinyoung","html_url":"https://github.com/johncalvinyoung","followers_url":"https://api.github.com/users/johncalvinyoung/followers","following_url":"https://api.github.com/users/johncalvinyoung/following{/other_user}","gists_url":"https://api.github.com/users/johncalvinyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/johncalvinyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johncalvinyoung/subscriptions","organizations_url":"https://api.github.com/users/johncalvinyoung/orgs","repos_url":"https://api.github.com/users/johncalvinyoung/repos","events_url":"https://api.github.com/users/johncalvinyoung/events{/privacy}","received_events_url":"https://api.github.com/users/johncalvinyoung/received_events","type":"User","site_admin":false},"body":"Not positive how this is connected to other changes.","created_at":"2018-11-12T21:16:31Z","updated_at":"2018-11-12T21:16:31Z","html_url":"https://github.com/ember-infinity/ember-infinity/pull/338#discussion_r232814415","pull_request_url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/comments/232814415"},"html":{"href":"https://github.com/ember-infinity/ember-infinity/pull/338#discussion_r232814415"},"pull_request":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338","id":230256932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjU2OTMy","html_url":"https://github.com/ember-infinity/ember-infinity/pull/338","diff_url":"https://github.com/ember-infinity/ember-infinity/pull/338.diff","patch_url":"https://github.com/ember-infinity/ember-infinity/pull/338.patch","issue_url":"https://api.github.com/repos/ember-infinity/ember-infinity/issues/338","number":338,"state":"open","locked":false,"title":"Fix infinity model container so services can be injected on it","user":{"login":"callovarne","id":984702,"node_id":"MDQ6VXNlcjk4NDcwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/984702?v=4","gravatar_id":"","url":"https://api.github.com/users/callovarne","html_url":"https://github.com/callovarne","followers_url":"https://api.github.com/users/callovarne/followers","following_url":"https://api.github.com/users/callovarne/following{/other_user}","gists_url":"https://api.github.com/users/callovarne/gists{/gist_id}","starred_url":"https://api.github.com/users/callovarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callovarne/subscriptions","organizations_url":"https://api.github.com/users/callovarne/orgs","repos_url":"https://api.github.com/users/callovarne/repos","events_url":"https://api.github.com/users/callovarne/events{/privacy}","received_events_url":"https://api.github.com/users/callovarne/received_events","type":"User","site_admin":false},"body":"Injecting services on the extended infinity model was failing because the instance is created without a container. This seems like the right fix?\r\n\r\nWith the 1.0 API changes, _infinityModelLoaded_ and _infinityModelUpdated_ no longer have the context they did as members of the route. Now, an intermediary (e.g. a service) appears to be required to effect a change in the context of the route or controller, e.g.:\r\n\r\n```js\r\nimport InfinityModel from 'ember-infinity/lib/infinity-model';\r\n\r\nexport default InfinityModel.extend({\r\n  infinityModelUpdated({ lastPageLoaded, totalPages }) {\r\n    if (totalPages > lastPageLoaded) {\r\n      // Hide footer until all records are loaded\r\n      set(this, 'memoryStorage.hasActiveInfiniteScroll', true);\r\n    }\r\n  }\r\n});\r\n```\r\n\r\n```hbs\r\n{{! app/templates/application.hbs}}\r\n{{#unless memoryStorage.hasActiveInfiniteScroll}}\r\n  {{footer-stuff}}\r\n{{/unless}}\r\n```","created_at":"2018-11-12T20:21:07Z","updated_at":"2018-11-12T21:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d4bef3e8439c90fbc2b1c55571f5d410b7ab5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338/commits","review_comments_url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338/comments","review_comment_url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-infinity/ember-infinity/issues/338/comments","statuses_url":"https://api.github.com/repos/ember-infinity/ember-infinity/statuses/1b897a202c7501975ee0b35c94d979f510693302","head":{"label":"callovarne:container-fix","ref":"container-fix","sha":"1b897a202c7501975ee0b35c94d979f510693302","user":{"login":"callovarne","id":984702,"node_id":"MDQ6VXNlcjk4NDcwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/984702?v=4","gravatar_id":"","url":"https://api.github.com/users/callovarne","html_url":"https://github.com/callovarne","followers_url":"https://api.github.com/users/callovarne/followers","following_url":"https://api.github.com/users/callovarne/following{/other_user}","gists_url":"https://api.github.com/users/callovarne/gists{/gist_id}","starred_url":"https://api.github.com/users/callovarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callovarne/subscriptions","organizations_url":"https://api.github.com/users/callovarne/orgs","repos_url":"https://api.github.com/users/callovarne/repos","events_url":"https://api.github.com/users/callovarne/events{/privacy}","received_events_url":"https://api.github.com/users/callovarne/received_events","type":"User","site_admin":false},"repo":{"id":157139081,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxMzkwODE=","name":"ember-infinity","full_name":"callovarne/ember-infinity","private":false,"owner":{"login":"callovarne","id":984702,"node_id":"MDQ6VXNlcjk4NDcwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/984702?v=4","gravatar_id":"","url":"https://api.github.com/users/callovarne","html_url":"https://github.com/callovarne","followers_url":"https://api.github.com/users/callovarne/followers","following_url":"https://api.github.com/users/callovarne/following{/other_user}","gists_url":"https://api.github.com/users/callovarne/gists{/gist_id}","starred_url":"https://api.github.com/users/callovarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callovarne/subscriptions","organizations_url":"https://api.github.com/users/callovarne/orgs","repos_url":"https://api.github.com/users/callovarne/repos","events_url":"https://api.github.com/users/callovarne/events{/privacy}","received_events_url":"https://api.github.com/users/callovarne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/callovarne/ember-infinity","description":":zap: Simple, flexible Infinite Scroll for Ember CLI Apps.","fork":true,"url":"https://api.github.com/repos/callovarne/ember-infinity","forks_url":"https://api.github.com/repos/callovarne/ember-infinity/forks","keys_url":"https://api.github.com/repos/callovarne/ember-infinity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callovarne/ember-infinity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callovarne/ember-infinity/teams","hooks_url":"https://api.github.com/repos/callovarne/ember-infinity/hooks","issue_events_url":"https://api.github.com/repos/callovarne/ember-infinity/issues/events{/number}","events_url":"https://api.github.com/repos/callovarne/ember-infinity/events","assignees_url":"https://api.github.com/repos/callovarne/ember-infinity/assignees{/user}","branches_url":"https://api.github.com/repos/callovarne/ember-infinity/branches{/branch}","tags_url":"https://api.github.com/repos/callovarne/ember-infinity/tags","blobs_url":"https://api.github.com/repos/callovarne/ember-infinity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callovarne/ember-infinity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callovarne/ember-infinity/git/refs{/sha}","trees_url":"https://api.github.com/repos/callovarne/ember-infinity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callovarne/ember-infinity/statuses/{sha}","languages_url":"https://api.github.com/repos/callovarne/ember-infinity/languages","stargazers_url":"https://api.github.com/repos/callovarne/ember-infinity/stargazers","contributors_url":"https://api.github.com/repos/callovarne/ember-infinity/contributors","subscribers_url":"https://api.github.com/repos/callovarne/ember-infinity/subscribers","subscription_url":"https://api.github.com/repos/callovarne/ember-infinity/subscription","commits_url":"https://api.github.com/repos/callovarne/ember-infinity/commits{/sha}","git_commits_url":"https://api.github.com/repos/callovarne/ember-infinity/git/commits{/sha}","comments_url":"https://api.github.com/repos/callovarne/ember-infinity/comments{/number}","issue_comment_url":"https://api.github.com/repos/callovarne/ember-infinity/issues/comments{/number}","contents_url":"https://api.github.com/repos/callovarne/ember-infinity/contents/{+path}","compare_url":"https://api.github.com/repos/callovarne/ember-infinity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callovarne/ember-infinity/merges","archive_url":"https://api.github.com/repos/callovarne/ember-infinity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callovarne/ember-infinity/downloads","issues_url":"https://api.github.com/repos/callovarne/ember-infinity/issues{/number}","pulls_url":"https://api.github.com/repos/callovarne/ember-infinity/pulls{/number}","milestones_url":"https://api.github.com/repos/callovarne/ember-infinity/milestones{/number}","notifications_url":"https://api.github.com/repos/callovarne/ember-infinity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callovarne/ember-infinity/labels{/name}","releases_url":"https://api.github.com/repos/callovarne/ember-infinity/releases{/id}","deployments_url":"https://api.github.com/repos/callovarne/ember-infinity/deployments","created_at":"2018-11-12T01:22:55Z","updated_at":"2018-11-12T01:22:58Z","pushed_at":"2018-11-12T20:07:16Z","git_url":"git://github.com/callovarne/ember-infinity.git","ssh_url":"git@github.com:callovarne/ember-infinity.git","clone_url":"https://github.com/callovarne/ember-infinity.git","svn_url":"https://github.com/callovarne/ember-infinity","homepage":"","size":21391,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-infinity:master","ref":"master","sha":"8eb9d1c6ead9b7cea9dfc767e42ce09c8acae5e2","user":{"login":"ember-infinity","id":36015125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/36015125?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-infinity","html_url":"https://github.com/ember-infinity","followers_url":"https://api.github.com/users/ember-infinity/followers","following_url":"https://api.github.com/users/ember-infinity/following{/other_user}","gists_url":"https://api.github.com/users/ember-infinity/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-infinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-infinity/subscriptions","organizations_url":"https://api.github.com/users/ember-infinity/orgs","repos_url":"https://api.github.com/users/ember-infinity/repos","events_url":"https://api.github.com/users/ember-infinity/events{/privacy}","received_events_url":"https://api.github.com/users/ember-infinity/received_events","type":"Organization","site_admin":false},"repo":{"id":32656538,"node_id":"MDEwOlJlcG9zaXRvcnkzMjY1NjUzOA==","name":"ember-infinity","full_name":"ember-infinity/ember-infinity","private":false,"owner":{"login":"ember-infinity","id":36015125,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/36015125?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-infinity","html_url":"https://github.com/ember-infinity","followers_url":"https://api.github.com/users/ember-infinity/followers","following_url":"https://api.github.com/users/ember-infinity/following{/other_user}","gists_url":"https://api.github.com/users/ember-infinity/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-infinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-infinity/subscriptions","organizations_url":"https://api.github.com/users/ember-infinity/orgs","repos_url":"https://api.github.com/users/ember-infinity/repos","events_url":"https://api.github.com/users/ember-infinity/events{/privacy}","received_events_url":"https://api.github.com/users/ember-infinity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ember-infinity/ember-infinity","description":":zap: Simple, flexible Infinite Scroll for Ember CLI Apps.","fork":false,"url":"https://api.github.com/repos/ember-infinity/ember-infinity","forks_url":"https://api.github.com/repos/ember-infinity/ember-infinity/forks","keys_url":"https://api.github.com/repos/ember-infinity/ember-infinity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-infinity/ember-infinity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-infinity/ember-infinity/teams","hooks_url":"https://api.github.com/repos/ember-infinity/ember-infinity/hooks","issue_events_url":"https://api.github.com/repos/ember-infinity/ember-infinity/issues/events{/number}","events_url":"https://api.github.com/repos/ember-infinity/ember-infinity/events","assignees_url":"https://api.github.com/repos/ember-infinity/ember-infinity/assignees{/user}","branches_url":"https://api.github.com/repos/ember-infinity/ember-infinity/branches{/branch}","tags_url":"https://api.github.com/repos/ember-infinity/ember-infinity/tags","blobs_url":"https://api.github.com/repos/ember-infinity/ember-infinity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-infinity/ember-infinity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-infinity/ember-infinity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-infinity/ember-infinity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-infinity/ember-infinity/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-infinity/ember-infinity/languages","stargazers_url":"https://api.github.com/repos/ember-infinity/ember-infinity/stargazers","contributors_url":"https://api.github.com/repos/ember-infinity/ember-infinity/contributors","subscribers_url":"https://api.github.com/repos/ember-infinity/ember-infinity/subscribers","subscription_url":"https://api.github.com/repos/ember-infinity/ember-infinity/subscription","commits_url":"https://api.github.com/repos/ember-infinity/ember-infinity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-infinity/ember-infinity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-infinity/ember-infinity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-infinity/ember-infinity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-infinity/ember-infinity/contents/{+path}","compare_url":"https://api.github.com/repos/ember-infinity/ember-infinity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-infinity/ember-infinity/merges","archive_url":"https://api.github.com/repos/ember-infinity/ember-infinity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-infinity/ember-infinity/downloads","issues_url":"https://api.github.com/repos/ember-infinity/ember-infinity/issues{/number}","pulls_url":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-infinity/ember-infinity/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-infinity/ember-infinity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-infinity/ember-infinity/labels{/name}","releases_url":"https://api.github.com/repos/ember-infinity/ember-infinity/releases{/id}","deployments_url":"https://api.github.com/repos/ember-infinity/ember-infinity/deployments","created_at":"2015-03-22T01:00:39Z","updated_at":"2018-11-01T20:34:37Z","pushed_at":"2018-11-12T20:21:08Z","git_url":"git://github.com/ember-infinity/ember-infinity.git","ssh_url":"git@github.com:ember-infinity/ember-infinity.git","clone_url":"https://github.com/ember-infinity/ember-infinity.git","svn_url":"https://github.com/ember-infinity/ember-infinity","homepage":"","size":21390,"stargazers_count":339,"watchers_count":339,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":103,"open_issues":13,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338"},"html":{"href":"https://github.com/ember-infinity/ember-infinity/pull/338"},"issue":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/issues/338"},"comments":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/ember-infinity/ember-infinity/statuses/1b897a202c7501975ee0b35c94d979f510693302"}},"author_association":"NONE"}}
{"actor":{"display_login":"johncalvinyoung"}}