{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/174917930","pull_request_review_id":104361242,"id":174917930,"diff_hunk":"@@ -120,28 +123,61 @@ You now have a docker registry which is HA with persistent storage.\n #### Kernel Version Requirement\n If the Rook cluster has more than one filesystem and the application pod is scheduled to a node with kernel version older than 4.7, inconsistent results may arise since kernels older than 4.7 do not support specifying filesystem namespaces.\n \n-## Test the storage\n+## Consume the Shared File System: Toolbox and the Ceph tools\n \n Once you have pushed an image to the registry (see the [instructions](https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/registry) to expose and use the kube-registry), verify that kube-registry is using the filesystem that was configured above by mounting the shared file system in the toolbox pod.\n+This is just a simple way to validate the Ceph file system and is not recommended for production Kubernetes pods.\n \n-Start and connect to the [Rook toolbox](toolbox.md).\n+Start and connect to the [Rook toolbox](toolbox.md) to mount the same filesystem that the kube-registry is using.\n \n ```bash\n-# Mount the same filesystem that the kube-registry is using\n+# Create the directory\n mkdir /tmp/registry\n-rookctl filesystem mount --name myfs --path /tmp/registry","path":"Documentation/filesystem.md","position":46,"original_position":46,"commit_id":"d9457f57fe138f94b1826328c4f21337a7753892","original_commit_id":"d9457f57fe138f94b1826328c4f21337a7753892","user":{"login":"jbw976","id":4313439,"avatar_url":"https://avatars2.githubusercontent.com/u/4313439?v=4","gravatar_id":"","url":"https://api.github.com/users/jbw976","html_url":"https://github.com/jbw976","followers_url":"https://api.github.com/users/jbw976/followers","following_url":"https://api.github.com/users/jbw976/following{/other_user}","gists_url":"https://api.github.com/users/jbw976/gists{/gist_id}","starred_url":"https://api.github.com/users/jbw976/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbw976/subscriptions","organizations_url":"https://api.github.com/users/jbw976/orgs","repos_url":"https://api.github.com/users/jbw976/repos","events_url":"https://api.github.com/users/jbw976/events{/privacy}","received_events_url":"https://api.github.com/users/jbw976/received_events","type":"User","site_admin":false},"body":"not a fan of how much more complicated these manual steps got without `rookctl`! RIP `rookctl` :(","created_at":"2018-03-15T20:15:19Z","updated_at":"2018-03-15T20:21:22Z","html_url":"https://github.com/rook/rook/pull/1573#discussion_r174917930","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/1573","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/174917930"},"html":{"href":"https://github.com/rook/rook/pull/1573#discussion_r174917930"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/1573"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/1573","id":174810962,"html_url":"https://github.com/rook/rook/pull/1573","diff_url":"https://github.com/rook/rook/pull/1573.diff","patch_url":"https://github.com/rook/rook/pull/1573.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/1573","number":1573,"state":"open","locked":false,"title":"Remove the Rook REST API service and rookctl tool","user":{"login":"travisn","id":1048514,"avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"body":"Removing deprecated components: rook-api and rookctl\r\n- Remove the REST API service. All operations in the cluster are either done by CRDs or ceph tools in the various daemon pods or toolbox.\r\n- Remove dependency of the e2e tests on the REST API. The tests will run ceph commands in the toolbox pod\r\n- The model namespace is removed\r\n- `rookctl` is removed from the toolbox. It isn't necessary anymore since ceph tools can be used for status and configuration.\r\n\r\nWhich issue is resolved by this Pull Request:\r\nRelated to #1122, #704 and #1412 (PR: #1471)\r\nReplaces PR #1474\r\nResolves #1122\r\n\r\nChecklist:\r\n- [x] Documentation has been updated, if necessary.\r\n- [x] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n","created_at":"2018-03-13T22:47:23Z","updated_at":"2018-03-15T20:21:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"585ef714a971452c4020d2520ea9f924731ebc72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/1573/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/1573/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/1573/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/d9457f57fe138f94b1826328c4f21337a7753892","head":{"label":"travisn:remove-api","ref":"remove-api","sha":"d9457f57fe138f94b1826328c4f21337a7753892","user":{"login":"travisn","id":1048514,"avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"repo":{"id":73165238,"name":"rook","full_name":"travisn/rook","owner":{"login":"travisn","id":1048514,"avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/travisn/rook","description":"Open, Universal, Cloud Native, Distributed Storage","fork":true,"url":"https://api.github.com/repos/travisn/rook","forks_url":"https://api.github.com/repos/travisn/rook/forks","keys_url":"https://api.github.com/repos/travisn/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travisn/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travisn/rook/teams","hooks_url":"https://api.github.com/repos/travisn/rook/hooks","issue_events_url":"https://api.github.com/repos/travisn/rook/issues/events{/number}","events_url":"https://api.github.com/repos/travisn/rook/events","assignees_url":"https://api.github.com/repos/travisn/rook/assignees{/user}","branches_url":"https://api.github.com/repos/travisn/rook/branches{/branch}","tags_url":"https://api.github.com/repos/travisn/rook/tags","blobs_url":"https://api.github.com/repos/travisn/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travisn/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travisn/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/travisn/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travisn/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/travisn/rook/languages","stargazers_url":"https://api.github.com/repos/travisn/rook/stargazers","contributors_url":"https://api.github.com/repos/travisn/rook/contributors","subscribers_url":"https://api.github.com/repos/travisn/rook/subscribers","subscription_url":"https://api.github.com/repos/travisn/rook/subscription","commits_url":"https://api.github.com/repos/travisn/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/travisn/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/travisn/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/travisn/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/travisn/rook/contents/{+path}","compare_url":"https://api.github.com/repos/travisn/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travisn/rook/merges","archive_url":"https://api.github.com/repos/travisn/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travisn/rook/downloads","issues_url":"https://api.github.com/repos/travisn/rook/issues{/number}","pulls_url":"https://api.github.com/repos/travisn/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/travisn/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/travisn/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travisn/rook/labels{/name}","releases_url":"https://api.github.com/repos/travisn/rook/releases{/id}","deployments_url":"https://api.github.com/repos/travisn/rook/deployments","created_at":"2016-11-08T08:30:24Z","updated_at":"2016-11-08T08:30:25Z","pushed_at":"2018-03-15T17:19:31Z","git_url":"git://github.com/travisn/rook.git","ssh_url":"git@github.com:travisn/rook.git","clone_url":"https://github.com/travisn/rook.git","svn_url":"https://github.com/travisn/rook","homepage":"http://rook.io","size":4440,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"bfc8ec65b47b90beb51bc042bfcf2e508263a559","user":{"login":"rook","id":22860722,"avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"name":"rook","full_name":"rook/rook","owner":{"login":"rook","id":22860722,"avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rook/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2018-03-15T19:00:35Z","pushed_at":"2018-03-15T20:08:59Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":4459,"stargazers_count":2491,"watchers_count":2491,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":246,"open_issues":165,"watchers":2491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/1573"},"html":{"href":"https://github.com/rook/rook/pull/1573"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/1573"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/1573/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/1573/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/1573/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/d9457f57fe138f94b1826328c4f21337a7753892"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jbw976"}}