{"action":"opened","number":19,"pull_request":{"url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/19","id":205758369,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzU4MzY5","html_url":"https://github.com/carryprotocol/carry-token-crowdsale/pull/19","diff_url":"https://github.com/carryprotocol/carry-token-crowdsale/pull/19.diff","patch_url":"https://github.com/carryprotocol/carry-token-crowdsale/pull/19.patch","issue_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/19","number":19,"state":"open","locked":false,"title":"Fixed token delivery due date & optimize gas efficiency","user":{"login":"dahlia","id":12431,"node_id":"MDQ6VXNlcjEyNDMx","avatar_url":"https://avatars1.githubusercontent.com/u/12431?v=4","gravatar_id":"","url":"https://api.github.com/users/dahlia","html_url":"https://github.com/dahlia","followers_url":"https://api.github.com/users/dahlia/followers","following_url":"https://api.github.com/users/dahlia/following{/other_user}","gists_url":"https://api.github.com/users/dahlia/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlia/subscriptions","organizations_url":"https://api.github.com/users/dahlia/orgs","repos_url":"https://api.github.com/users/dahlia/repos","events_url":"https://api.github.com/users/dahlia/events{/privacy}","received_events_url":"https://api.github.com/users/dahlia/received_events","type":"User","site_admin":false},"body":"This patch has several improvements.  The main changes are adding the fixed due date of token delivery, and optimization to decrease gas consumption.\r\n\r\n- As token purchasers maybe concerned that we never call `setWithdrawal(true)`, to dispel these worries, `_tokenDeliveryDue` field was added.  `whenWithdrawable` modifier will allow purchasers to withdraw their tokens after the due date even if we don't call `setWithdrawal(true)` ever.\r\n- Since the past timestamps are no more used, make the `_individualMaxCaps` table automatically trimmed.\r\n\r\n@longfin @qria @segfault87 Please review this.","created_at":"2018-08-02T14:40:07Z","updated_at":"2018-08-02T14:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"dahlia","id":12431,"node_id":"MDQ6VXNlcjEyNDMx","avatar_url":"https://avatars1.githubusercontent.com/u/12431?v=4","gravatar_id":"","url":"https://api.github.com/users/dahlia","html_url":"https://github.com/dahlia","followers_url":"https://api.github.com/users/dahlia/followers","following_url":"https://api.github.com/users/dahlia/following{/other_user}","gists_url":"https://api.github.com/users/dahlia/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlia/subscriptions","organizations_url":"https://api.github.com/users/dahlia/orgs","repos_url":"https://api.github.com/users/dahlia/repos","events_url":"https://api.github.com/users/dahlia/events{/privacy}","received_events_url":"https://api.github.com/users/dahlia/received_events","type":"User","site_admin":false},"assignees":[{"login":"dahlia","id":12431,"node_id":"MDQ6VXNlcjEyNDMx","avatar_url":"https://avatars1.githubusercontent.com/u/12431?v=4","gravatar_id":"","url":"https://api.github.com/users/dahlia","html_url":"https://github.com/dahlia","followers_url":"https://api.github.com/users/dahlia/followers","following_url":"https://api.github.com/users/dahlia/following{/other_user}","gists_url":"https://api.github.com/users/dahlia/gists{/gist_id}","starred_url":"https://api.github.com/users/dahlia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahlia/subscriptions","organizations_url":"https://api.github.com/users/dahlia/orgs","repos_url":"https://api.github.com/users/dahlia/repos","events_url":"https://api.github.com/users/dahlia/events{/privacy}","received_events_url":"https://api.github.com/users/dahlia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":919397265,"node_id":"MDU6TGFiZWw5MTkzOTcyNjU=","url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/19/commits","review_comments_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/19/comments","review_comment_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/19/comments","statuses_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/statuses/2acabffb4c35cf9c16fa96cbc97bd77aa004c164","head":{"label":"carryprotocol:fixed-token-delivery-due","ref":"fixed-token-delivery-due","sha":"2acabffb4c35cf9c16fa96cbc97bd77aa004c164","user":{"login":"carryprotocol","id":36441889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDQxODg5","avatar_url":"https://avatars0.githubusercontent.com/u/36441889?v=4","gravatar_id":"","url":"https://api.github.com/users/carryprotocol","html_url":"https://github.com/carryprotocol","followers_url":"https://api.github.com/users/carryprotocol/followers","following_url":"https://api.github.com/users/carryprotocol/following{/other_user}","gists_url":"https://api.github.com/users/carryprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/carryprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carryprotocol/subscriptions","organizations_url":"https://api.github.com/users/carryprotocol/orgs","repos_url":"https://api.github.com/users/carryprotocol/repos","events_url":"https://api.github.com/users/carryprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/carryprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":131724229,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3MjQyMjk=","name":"carry-token-crowdsale","full_name":"carryprotocol/carry-token-crowdsale","owner":{"login":"carryprotocol","id":36441889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDQxODg5","avatar_url":"https://avatars0.githubusercontent.com/u/36441889?v=4","gravatar_id":"","url":"https://api.github.com/users/carryprotocol","html_url":"https://github.com/carryprotocol","followers_url":"https://api.github.com/users/carryprotocol/followers","following_url":"https://api.github.com/users/carryprotocol/following{/other_user}","gists_url":"https://api.github.com/users/carryprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/carryprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carryprotocol/subscriptions","organizations_url":"https://api.github.com/users/carryprotocol/orgs","repos_url":"https://api.github.com/users/carryprotocol/repos","events_url":"https://api.github.com/users/carryprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/carryprotocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/carryprotocol/carry-token-crowdsale","description":"Carry token crowdsale","fork":false,"url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale","forks_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/forks","keys_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/teams","hooks_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/hooks","issue_events_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/events{/number}","events_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/events","assignees_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/assignees{/user}","branches_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/branches{/branch}","tags_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/tags","blobs_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/refs{/sha}","trees_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/statuses/{sha}","languages_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/languages","stargazers_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/stargazers","contributors_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/contributors","subscribers_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/subscribers","subscription_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/subscription","commits_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/commits{/sha}","git_commits_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/commits{/sha}","comments_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/comments{/number}","issue_comment_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/comments{/number}","contents_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/contents/{+path}","compare_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/merges","archive_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/downloads","issues_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues{/number}","pulls_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls{/number}","milestones_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/milestones{/number}","notifications_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/labels{/name}","releases_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/releases{/id}","deployments_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/deployments","created_at":"2018-05-01T14:42:36Z","updated_at":"2018-07-26T04:28:44Z","pushed_at":"2018-08-02T14:32:04Z","git_url":"git://github.com/carryprotocol/carry-token-crowdsale.git","ssh_url":"git@github.com:carryprotocol/carry-token-crowdsale.git","clone_url":"https://github.com/carryprotocol/carry-token-crowdsale.git","svn_url":"https://github.com/carryprotocol/carry-token-crowdsale","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"carryprotocol:master","ref":"master","sha":"5d3b0ba9476be0bd060cc15a2371441482441ec9","user":{"login":"carryprotocol","id":36441889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDQxODg5","avatar_url":"https://avatars0.githubusercontent.com/u/36441889?v=4","gravatar_id":"","url":"https://api.github.com/users/carryprotocol","html_url":"https://github.com/carryprotocol","followers_url":"https://api.github.com/users/carryprotocol/followers","following_url":"https://api.github.com/users/carryprotocol/following{/other_user}","gists_url":"https://api.github.com/users/carryprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/carryprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carryprotocol/subscriptions","organizations_url":"https://api.github.com/users/carryprotocol/orgs","repos_url":"https://api.github.com/users/carryprotocol/repos","events_url":"https://api.github.com/users/carryprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/carryprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":131724229,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3MjQyMjk=","name":"carry-token-crowdsale","full_name":"carryprotocol/carry-token-crowdsale","owner":{"login":"carryprotocol","id":36441889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDQxODg5","avatar_url":"https://avatars0.githubusercontent.com/u/36441889?v=4","gravatar_id":"","url":"https://api.github.com/users/carryprotocol","html_url":"https://github.com/carryprotocol","followers_url":"https://api.github.com/users/carryprotocol/followers","following_url":"https://api.github.com/users/carryprotocol/following{/other_user}","gists_url":"https://api.github.com/users/carryprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/carryprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carryprotocol/subscriptions","organizations_url":"https://api.github.com/users/carryprotocol/orgs","repos_url":"https://api.github.com/users/carryprotocol/repos","events_url":"https://api.github.com/users/carryprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/carryprotocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/carryprotocol/carry-token-crowdsale","description":"Carry token crowdsale","fork":false,"url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale","forks_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/forks","keys_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/teams","hooks_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/hooks","issue_events_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/events{/number}","events_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/events","assignees_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/assignees{/user}","branches_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/branches{/branch}","tags_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/tags","blobs_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/refs{/sha}","trees_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/statuses/{sha}","languages_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/languages","stargazers_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/stargazers","contributors_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/contributors","subscribers_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/subscribers","subscription_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/subscription","commits_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/commits{/sha}","git_commits_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/git/commits{/sha}","comments_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/comments{/number}","issue_comment_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/comments{/number}","contents_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/contents/{+path}","compare_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/merges","archive_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/downloads","issues_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues{/number}","pulls_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls{/number}","milestones_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/milestones{/number}","notifications_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/labels{/name}","releases_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/releases{/id}","deployments_url":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/deployments","created_at":"2018-05-01T14:42:36Z","updated_at":"2018-07-26T04:28:44Z","pushed_at":"2018-08-02T14:32:04Z","git_url":"git://github.com/carryprotocol/carry-token-crowdsale.git","ssh_url":"git@github.com:carryprotocol/carry-token-crowdsale.git","clone_url":"https://github.com/carryprotocol/carry-token-crowdsale.git","svn_url":"https://github.com/carryprotocol/carry-token-crowdsale","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/19"},"html":{"href":"https://github.com/carryprotocol/carry-token-crowdsale/pull/19"},"issue":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/19"},"comments":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/carryprotocol/carry-token-crowdsale/statuses/2acabffb4c35cf9c16fa96cbc97bd77aa004c164"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":139,"deletions":73,"changed_files":4}}
{"actor":{"display_login":"dahlia"}}