{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6372","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6372/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6372/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6372/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6372","id":268034346,"number":6372,"title":"System sizing adjust std 62 1 refactor","user":{"login":"EnergyArchmage","id":8754769,"avatar_url":"https://avatars0.githubusercontent.com/u/8754769?v=4","gravatar_id":"","url":"https://api.github.com/users/EnergyArchmage","html_url":"https://github.com/EnergyArchmage","followers_url":"https://api.github.com/users/EnergyArchmage/followers","following_url":"https://api.github.com/users/EnergyArchmage/following{/other_user}","gists_url":"https://api.github.com/users/EnergyArchmage/gists{/gist_id}","starred_url":"https://api.github.com/users/EnergyArchmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnergyArchmage/subscriptions","organizations_url":"https://api.github.com/users/EnergyArchmage/orgs","repos_url":"https://api.github.com/users/EnergyArchmage/repos","events_url":"https://api.github.com/users/EnergyArchmage/events{/privacy}","received_events_url":"https://api.github.com/users/EnergyArchmage/received_events","type":"User","site_admin":false},"labels":[{"id":74843628,"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Defect","name":"Defect","color":"e11d21","default":false},{"id":429517840,"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/IDDChange","name":"IDDChange","color":"006b75","default":false},{"id":244051192,"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Refactoring","name":"Refactoring","color":"0000FF","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7","html_url":"https://github.com/NREL/EnergyPlus/milestone/7","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7/labels","id":2668648,"number":7,"title":"EnergyPlus 8.9.0","description":"Tentative on the naming.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":38,"state":"open","created_at":"2017-07-29T02:49:31Z","updated_at":"2018-02-21T12:59:56Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":27,"created_at":"2017-10-24T13:34:42Z","updated_at":"2018-02-21T14:35:46Z","closed_at":"2018-02-20T18:47:07Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6372","html_url":"https://github.com/NREL/EnergyPlus/pull/6372","diff_url":"https://github.com/NREL/EnergyPlus/pull/6372.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6372.patch"},"body":"Pull request overview\r\n---------------------\r\nThis PR is a contribution from Trane.  Set of code changes involves adding a new method for adjusting air system system sizing by mining data from each of the air terminal units attached to the system.  Standard 62.1 system level sizes and table reporting code has been refactored to correct for adjusted system sizes.  The central heating air flow ratio can now be autosized. \r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/367345532","html_url":"https://github.com/NREL/EnergyPlus/pull/6372#issuecomment-367345532","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6372","id":367345532,"user":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T14:35:46Z","updated_at":"2018-02-21T14:35:46Z","author_association":"CONTRIBUTOR","body":"@EnergyArchmage @rraustad Some of the TU vs OA stuff may get fixed in #6338. I've posted some followup needs in #6481. You can add the VRP idf to that list or make a separate issue.  The Std62 sizing changes also slowed down the performance tests by about 10%. Any idea where the extra time would be coming from here?"}}
{"actor":{"display_login":"mjwitte"}}