{"action":"created","issue":{"url":"https://api.github.com/repos/multiformats/clj-multihash/issues/10","repository_url":"https://api.github.com/repos/multiformats/clj-multihash","labels_url":"https://api.github.com/repos/multiformats/clj-multihash/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/multiformats/clj-multihash/issues/10/comments","events_url":"https://api.github.com/repos/multiformats/clj-multihash/issues/10/events","html_url":"https://github.com/multiformats/clj-multihash/pull/10","id":361159427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjAwNjU4","number":10,"title":"[cljs] Use type symbol when extending base type","user":{"login":"plexus","id":32212,"node_id":"MDQ6VXNlcjMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/32212?v=4","gravatar_id":"","url":"https://api.github.com/users/plexus","html_url":"https://github.com/plexus","followers_url":"https://api.github.com/users/plexus/followers","following_url":"https://api.github.com/users/plexus/following{/other_user}","gists_url":"https://api.github.com/users/plexus/gists{/gist_id}","starred_url":"https://api.github.com/users/plexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexus/subscriptions","organizations_url":"https://api.github.com/users/plexus/orgs","repos_url":"https://api.github.com/users/plexus/repos","events_url":"https://api.github.com/users/plexus/events{/privacy}","received_events_url":"https://api.github.com/users/plexus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-18T06:53:08Z","updated_at":"2018-09-18T07:04:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/multiformats/clj-multihash/pulls/10","html_url":"https://github.com/multiformats/clj-multihash/pull/10","diff_url":"https://github.com/multiformats/clj-multihash/pull/10.diff","patch_url":"https://github.com/multiformats/clj-multihash/pull/10.patch"},"body":"As per https://cljs.github.io/api/cljs.core/extend-type when extending js/String\r\nthe special symbol 'string should be used. This still makes the protocol work\r\nwith strings but without changing the js/String prototype.\r\n\r\nThis removes a compile-time warning."},"comment":{"url":"https://api.github.com/repos/multiformats/clj-multihash/issues/comments/422278863","html_url":"https://github.com/multiformats/clj-multihash/pull/10#issuecomment-422278863","issue_url":"https://api.github.com/repos/multiformats/clj-multihash/issues/10","id":422278863,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjI3ODg2Mw==","user":{"login":"plexus","id":32212,"node_id":"MDQ6VXNlcjMyMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/32212?v=4","gravatar_id":"","url":"https://api.github.com/users/plexus","html_url":"https://github.com/plexus","followers_url":"https://api.github.com/users/plexus/followers","following_url":"https://api.github.com/users/plexus/following{/other_user}","gists_url":"https://api.github.com/users/plexus/gists{/gist_id}","starred_url":"https://api.github.com/users/plexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexus/subscriptions","organizations_url":"https://api.github.com/users/plexus/orgs","repos_url":"https://api.github.com/users/plexus/repos","events_url":"https://api.github.com/users/plexus/events{/privacy}","received_events_url":"https://api.github.com/users/plexus/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T07:04:04Z","updated_at":"2018-09-18T07:04:04Z","author_association":"NONE","body":"There's a bit more info in this thread\r\n\r\nhttps://groups.google.com/forum/#!msg/clojurescript/MKEZ9CBU77o/h7ejrbNFCgAJ\r\n\r\nextending JS base types like js/String can trigger dramatic de-optimization in JS engines (dixit David Nolen), which is why extend-type handles these separately."}}
{"actor":{"display_login":"plexus"}}