{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1658","repository_url":"https://api.github.com/repos/apache/incubator-dubbo","labels_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1658/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1658/comments","events_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1658/events","html_url":"https://github.com/apache/incubator-dubbo/pull/1658","id":316731051,"number":1658,"title":"[Dubbo-1637] Fix When using hibernate-validator, class 'org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl' is wrong with hessian deserialization.","user":{"login":"ningyu1","id":3387548,"avatar_url":"https://avatars0.githubusercontent.com/u/3387548?v=4","gravatar_id":"","url":"https://api.github.com/users/ningyu1","html_url":"https://github.com/ningyu1","followers_url":"https://api.github.com/users/ningyu1/followers","following_url":"https://api.github.com/users/ningyu1/following{/other_user}","gists_url":"https://api.github.com/users/ningyu1/gists{/gist_id}","starred_url":"https://api.github.com/users/ningyu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ningyu1/subscriptions","organizations_url":"https://api.github.com/users/ningyu1/orgs","repos_url":"https://api.github.com/users/ningyu1/repos","events_url":"https://api.github.com/users/ningyu1/events{/privacy}","received_events_url":"https://api.github.com/users/ningyu1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-23T09:26:11Z","updated_at":"2018-04-26T07:25:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-dubbo/pulls/1658","html_url":"https://github.com/apache/incubator-dubbo/pull/1658","diff_url":"https://github.com/apache/incubator-dubbo/pull/1658.diff","patch_url":"https://github.com/apache/incubator-dubbo/pull/1658.patch"},"body":"bugfix：When using hibernate-validator, class 'org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl' is wrong with hessian deserialization.\r\n\r\n## What is the purpose of the change\r\n\r\nWhen jsr303 uses hibernate-validator，Dubbo serialization using hessian，Set validation=true on the provider side，Client cannot receive validation information，The error is as follows：com.alibaba.com.caucho.hessian.io.HessianProtocolException: 'org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl' could not be instantiated\r\n\r\n## Brief changelog\r\n\r\n1. add class: com.alibaba.dubbo.validation.support.jsr303.DubboConstraintViolation\r\n2. add class: com.alibaba.dubbo.validation.support.jsr303.DubboConstraintViolationException\r\n3. modify class: com.alibaba.dubbo.validation.filter.ValidationFilter\r\n\r\nFixes #1637"},"comment":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/comments/384540852","html_url":"https://github.com/apache/incubator-dubbo/pull/1658#issuecomment-384540852","issue_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/1658","id":384540852,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T07:25:45Z","updated_at":"2018-04-26T07:25:45Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=h1) Report\n> Merging [#1658](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a2a7706a07897bc7d0dc79923dc724159766da78?src=pr&el=desc) will **increase** coverage by `0.04%`.\n> The diff coverage is `61.11%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/graphs/tree.svg?token=VnEIkiFQT0&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #1658      +/-   ##\n============================================\n+ Coverage     35.42%   35.46%   +0.04%     \n- Complexity     3777     3778       +1     \n============================================\n  Files           628      628              \n  Lines         30994    30976      -18     \n  Branches       5456     5448       -8     \n============================================\n+ Hits          10979    10987       +8     \n+ Misses        18124    18094      -30     \n- Partials       1891     1895       +4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |\n| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2Uvc3VwcG9ydC9oZWFkZXIvSGVhZGVyRXhjaGFuZ2VTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvUnBjQ29udGV4dC5qYXZh) | `30.93% <0%> (+3.89%)` | `27 <0> (ø)` | :arrow_down: |\n| [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.34% <0%> (-0.19%)` | `42 <0> (ø)` | |\n| [.../java/com/alibaba/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `34.02% <100%> (+2.27%)` | `39 <0> (ø)` | :arrow_down: |\n| [...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `84.82% <83.33%> (-0.36%)` | `34 <2> (+1)` | |\n| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1658/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=footer). Last update [a2a7706...f32429a](https://codecov.io/gh/apache/incubator-dubbo/pull/1658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}