{"action":"created","comment":{"url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/comments/233632046","pull_request_review_id":175093684,"id":233632046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzYzMjA0Ng==","diff_hunk":"@@ -8,13 +8,17 @@ class SmokeTester {\n   }\n   \n   def runSmokeTest(path) {\n-    def test = path.execute().text\n-    if (test.contains(\"smoketest failed\")) {\n-        script.error (\"'${test}'\")\n-        return \"smoke test failed\"\n+    \n+    def url = script.SMOKE_TEST_URL ?: \"test\"\n+    def cmd = [path, url]\n+    def test = cmd.execute().text\n+    if (test.contains(\"smoketest passed\")) {\n+        script.echo \"smoke test passed\"\n+        return \"smoke test passed\"\n     }\n-    script.echo \"smoke test passed\"\n-    return \"smoke test passed\"\n+    script.error (\"'${test}'\")\n+    script.echo \"smoke test failed\"\n+    return \"smoke test failed\"","path":"src/gov/ca/cwds/jenkins/SmokeTester.groovy","position":20,"original_position":20,"commit_id":"089be06f2559847190d4f77464408a8abfb1660c","original_commit_id":"089be06f2559847190d4f77464408a8abfb1660c","user":{"login":"mariamcws","id":20781223,"node_id":"MDQ6VXNlcjIwNzgxMjIz","avatar_url":"https://avatars2.githubusercontent.com/u/20781223?v=4","gravatar_id":"","url":"https://api.github.com/users/mariamcws","html_url":"https://github.com/mariamcws","followers_url":"https://api.github.com/users/mariamcws/followers","following_url":"https://api.github.com/users/mariamcws/following{/other_user}","gists_url":"https://api.github.com/users/mariamcws/gists{/gist_id}","starred_url":"https://api.github.com/users/mariamcws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariamcws/subscriptions","organizations_url":"https://api.github.com/users/mariamcws/orgs","repos_url":"https://api.github.com/users/mariamcws/repos","events_url":"https://api.github.com/users/mariamcws/events{/privacy}","received_events_url":"https://api.github.com/users/mariamcws/received_events","type":"User","site_admin":false},"body":"I will remove that line, it is failed by Jenkins before that because of the ```script.error (\"'${test}'\")```","created_at":"2018-11-14T21:45:40Z","updated_at":"2018-11-14T21:45:40Z","html_url":"https://github.com/ca-cwds/jenkins-pipeline-utils/pull/9#discussion_r233632046","pull_request_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/comments/233632046"},"html":{"href":"https://github.com/ca-cwds/jenkins-pipeline-utils/pull/9#discussion_r233632046"},"pull_request":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9"}},"in_reply_to_id":233625838},"pull_request":{"url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9","id":230954440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTU0NDQw","html_url":"https://github.com/ca-cwds/jenkins-pipeline-utils/pull/9","diff_url":"https://github.com/ca-cwds/jenkins-pipeline-utils/pull/9.diff","patch_url":"https://github.com/ca-cwds/jenkins-pipeline-utils/pull/9.patch","issue_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/9","number":9,"state":"open","locked":false,"title":"FIT-237 Add Hooks for Smoke Tests in Jenkins File for Dashboard Project","user":{"login":"mariamcws","id":20781223,"node_id":"MDQ6VXNlcjIwNzgxMjIz","avatar_url":"https://avatars2.githubusercontent.com/u/20781223?v=4","gravatar_id":"","url":"https://api.github.com/users/mariamcws","html_url":"https://github.com/mariamcws","followers_url":"https://api.github.com/users/mariamcws/followers","following_url":"https://api.github.com/users/mariamcws/following{/other_user}","gists_url":"https://api.github.com/users/mariamcws/gists{/gist_id}","starred_url":"https://api.github.com/users/mariamcws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariamcws/subscriptions","organizations_url":"https://api.github.com/users/mariamcws/orgs","repos_url":"https://api.github.com/users/mariamcws/repos","events_url":"https://api.github.com/users/mariamcws/events{/privacy}","received_events_url":"https://api.github.com/users/mariamcws/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdd Hooks for Smoke Tests in Jenkins File for Dashboard Project and make it available for other projects via jenkins pipeline\r\n## Jira Issue link\r\n<!--- Provide the link to Jira -->\r\n[Add Hooks for Smoke Tests in Jenkins File for Dashboard Project](https://osi-cwds.atlassian.net/browse/FIT-237)\r\n\r\n## Tests\r\n- [x] I have included unit tests \r\n\r\n## Types of changes\r\n- [x] New feature (non-breaking change which adds functionality)\r\n","created_at":"2018-11-14T19:30:33Z","updated_at":"2018-11-14T21:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a8f1ddb0dbf9b333566f2f605379a6df2f3a3c5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"osi-richbach","id":20209882,"node_id":"MDQ6VXNlcjIwMjA5ODgy","avatar_url":"https://avatars3.githubusercontent.com/u/20209882?v=4","gravatar_id":"","url":"https://api.github.com/users/osi-richbach","html_url":"https://github.com/osi-richbach","followers_url":"https://api.github.com/users/osi-richbach/followers","following_url":"https://api.github.com/users/osi-richbach/following{/other_user}","gists_url":"https://api.github.com/users/osi-richbach/gists{/gist_id}","starred_url":"https://api.github.com/users/osi-richbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osi-richbach/subscriptions","organizations_url":"https://api.github.com/users/osi-richbach/orgs","repos_url":"https://api.github.com/users/osi-richbach/repos","events_url":"https://api.github.com/users/osi-richbach/events{/privacy}","received_events_url":"https://api.github.com/users/osi-richbach/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/9/comments","statuses_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/statuses/089be06f2559847190d4f77464408a8abfb1660c","head":{"label":"ca-cwds:FIT-237-Add-Hooks-for-Smoke-Tests-in-Jenkins-File-for-Dashboard-Project","ref":"FIT-237-Add-Hooks-for-Smoke-Tests-in-Jenkins-File-for-Dashboard-Project","sha":"089be06f2559847190d4f77464408a8abfb1660c","user":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":153693729,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2OTM3Mjk=","name":"jenkins-pipeline-utils","full_name":"ca-cwds/jenkins-pipeline-utils","private":false,"owner":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ca-cwds/jenkins-pipeline-utils","description":"Contains Jenkins Shared Library files","fork":false,"url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils","forks_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/forks","keys_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/teams","hooks_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/events","assignees_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/tags","blobs_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/subscription","commits_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/merges","archive_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/downloads","issues_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/deployments","created_at":"2018-10-18T22:11:23Z","updated_at":"2018-11-13T18:55:13Z","pushed_at":"2018-11-14T20:56:40Z","git_url":"git://github.com/ca-cwds/jenkins-pipeline-utils.git","ssh_url":"git@github.com:ca-cwds/jenkins-pipeline-utils.git","clone_url":"https://github.com/ca-cwds/jenkins-pipeline-utils.git","svn_url":"https://github.com/ca-cwds/jenkins-pipeline-utils","homepage":null,"size":131,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ca-cwds:master","ref":"master","sha":"eb647cdefd9aa158af68069d1737b514568c0c0a","user":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":153693729,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2OTM3Mjk=","name":"jenkins-pipeline-utils","full_name":"ca-cwds/jenkins-pipeline-utils","private":false,"owner":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ca-cwds/jenkins-pipeline-utils","description":"Contains Jenkins Shared Library files","fork":false,"url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils","forks_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/forks","keys_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/teams","hooks_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/events","assignees_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/tags","blobs_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/subscription","commits_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/merges","archive_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/downloads","issues_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/deployments","created_at":"2018-10-18T22:11:23Z","updated_at":"2018-11-13T18:55:13Z","pushed_at":"2018-11-14T20:56:40Z","git_url":"git://github.com/ca-cwds/jenkins-pipeline-utils.git","ssh_url":"git@github.com:ca-cwds/jenkins-pipeline-utils.git","clone_url":"https://github.com/ca-cwds/jenkins-pipeline-utils.git","svn_url":"https://github.com/ca-cwds/jenkins-pipeline-utils","homepage":null,"size":131,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9"},"html":{"href":"https://github.com/ca-cwds/jenkins-pipeline-utils/pull/9"},"issue":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/9"},"comments":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ca-cwds/jenkins-pipeline-utils/statuses/089be06f2559847190d4f77464408a8abfb1660c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mariamcws"}}