{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments/214550228","pull_request_review_id":151630298,"id":214550228,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDU1MDIyOA==","diff_hunk":"@@ -292,7 +292,11 @@ func (s *Setup) installDefaultPlugins(httpClient *httpclient.Client) error {\n \tif errCore != nil {\n \t\treturn errCore\n \t}\n-\treturn errEnterprise\n+\n+\tif errEnterprise != nil {\n+\t\ts.logger.Errorf(\"Cluster setup was successful but dcos-enterprise-cli could not be installed: %s.\", errEnterprise)","path":"pkg/setup/setup.go","position":7,"original_position":7,"commit_id":"9e3b2cc8994805faf1289fde9c07740ada671333","original_commit_id":"9e3b2cc8994805faf1289fde9c07740ada671333","user":{"login":"bamarni","id":1205386,"node_id":"MDQ6VXNlcjEyMDUzODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1205386?v=4","gravatar_id":"","url":"https://api.github.com/users/bamarni","html_url":"https://github.com/bamarni","followers_url":"https://api.github.com/users/bamarni/followers","following_url":"https://api.github.com/users/bamarni/following{/other_user}","gists_url":"https://api.github.com/users/bamarni/gists{/gist_id}","starred_url":"https://api.github.com/users/bamarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamarni/subscriptions","organizations_url":"https://api.github.com/users/bamarni/orgs","repos_url":"https://api.github.com/users/bamarni/repos","events_url":"https://api.github.com/users/bamarni/events{/privacy}","received_events_url":"https://api.github.com/users/bamarni/received_events","type":"User","site_admin":false},"body":"Can we print `In order to install the \"dcos-enterprise-cli\" plugin, make sure your user has the \"dcos:adminrouter:package\" permission and run \"dcos package install dcos-enterprise-cli\".`?\r\n\r\nThen once we have instructions for air-gapped we'll also add a note about that. ","created_at":"2018-09-02T19:12:27Z","updated_at":"2018-09-02T19:12:27Z","html_url":"https://github.com/dcos/dcos-cli/pull/1320#discussion_r214550228","pull_request_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments/214550228"},"html":{"href":"https://github.com/dcos/dcos-cli/pull/1320#discussion_r214550228"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320","id":212124460,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTI0NDYw","html_url":"https://github.com/dcos/dcos-cli/pull/1320","diff_url":"https://github.com/dcos/dcos-cli/pull/1320.diff","patch_url":"https://github.com/dcos/dcos-cli/pull/1320.patch","issue_url":"https://api.github.com/repos/dcos/dcos-cli/issues/1320","number":1320,"state":"open","locked":false,"title":"CLI will no longer return error return code if a cluster was successfully set up except but dcos-enterprise-cli fails to install.","user":{"login":"br-lewis","id":553488,"node_id":"MDQ6VXNlcjU1MzQ4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/553488?v=4","gravatar_id":"","url":"https://api.github.com/users/br-lewis","html_url":"https://github.com/br-lewis","followers_url":"https://api.github.com/users/br-lewis/followers","following_url":"https://api.github.com/users/br-lewis/following{/other_user}","gists_url":"https://api.github.com/users/br-lewis/gists{/gist_id}","starred_url":"https://api.github.com/users/br-lewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/br-lewis/subscriptions","organizations_url":"https://api.github.com/users/br-lewis/orgs","repos_url":"https://api.github.com/users/br-lewis/repos","events_url":"https://api.github.com/users/br-lewis/events{/privacy}","received_events_url":"https://api.github.com/users/br-lewis/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-30T15:40:46Z","updated_at":"2018-09-02T19:12:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25ee66d4b712697a8f7c2cab1d58b39c053c5aa8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-cli/issues/1320/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-cli/statuses/9e3b2cc8994805faf1289fde9c07740ada671333","head":{"label":"br-lewis:enterprise-install-return-code","ref":"enterprise-install-return-code","sha":"9e3b2cc8994805faf1289fde9c07740ada671333","user":{"login":"br-lewis","id":553488,"node_id":"MDQ6VXNlcjU1MzQ4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/553488?v=4","gravatar_id":"","url":"https://api.github.com/users/br-lewis","html_url":"https://github.com/br-lewis","followers_url":"https://api.github.com/users/br-lewis/followers","following_url":"https://api.github.com/users/br-lewis/following{/other_user}","gists_url":"https://api.github.com/users/br-lewis/gists{/gist_id}","starred_url":"https://api.github.com/users/br-lewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/br-lewis/subscriptions","organizations_url":"https://api.github.com/users/br-lewis/orgs","repos_url":"https://api.github.com/users/br-lewis/repos","events_url":"https://api.github.com/users/br-lewis/events{/privacy}","received_events_url":"https://api.github.com/users/br-lewis/received_events","type":"User","site_admin":false},"repo":{"id":126178859,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxNzg4NTk=","name":"dcos-cli","full_name":"br-lewis/dcos-cli","owner":{"login":"br-lewis","id":553488,"node_id":"MDQ6VXNlcjU1MzQ4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/553488?v=4","gravatar_id":"","url":"https://api.github.com/users/br-lewis","html_url":"https://github.com/br-lewis","followers_url":"https://api.github.com/users/br-lewis/followers","following_url":"https://api.github.com/users/br-lewis/following{/other_user}","gists_url":"https://api.github.com/users/br-lewis/gists{/gist_id}","starred_url":"https://api.github.com/users/br-lewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/br-lewis/subscriptions","organizations_url":"https://api.github.com/users/br-lewis/orgs","repos_url":"https://api.github.com/users/br-lewis/repos","events_url":"https://api.github.com/users/br-lewis/events{/privacy}","received_events_url":"https://api.github.com/users/br-lewis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/br-lewis/dcos-cli","description":"The command line for your datacenter! ","fork":true,"url":"https://api.github.com/repos/br-lewis/dcos-cli","forks_url":"https://api.github.com/repos/br-lewis/dcos-cli/forks","keys_url":"https://api.github.com/repos/br-lewis/dcos-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/br-lewis/dcos-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/br-lewis/dcos-cli/teams","hooks_url":"https://api.github.com/repos/br-lewis/dcos-cli/hooks","issue_events_url":"https://api.github.com/repos/br-lewis/dcos-cli/issues/events{/number}","events_url":"https://api.github.com/repos/br-lewis/dcos-cli/events","assignees_url":"https://api.github.com/repos/br-lewis/dcos-cli/assignees{/user}","branches_url":"https://api.github.com/repos/br-lewis/dcos-cli/branches{/branch}","tags_url":"https://api.github.com/repos/br-lewis/dcos-cli/tags","blobs_url":"https://api.github.com/repos/br-lewis/dcos-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/br-lewis/dcos-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/br-lewis/dcos-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/br-lewis/dcos-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/br-lewis/dcos-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/br-lewis/dcos-cli/languages","stargazers_url":"https://api.github.com/repos/br-lewis/dcos-cli/stargazers","contributors_url":"https://api.github.com/repos/br-lewis/dcos-cli/contributors","subscribers_url":"https://api.github.com/repos/br-lewis/dcos-cli/subscribers","subscription_url":"https://api.github.com/repos/br-lewis/dcos-cli/subscription","commits_url":"https://api.github.com/repos/br-lewis/dcos-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/br-lewis/dcos-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/br-lewis/dcos-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/br-lewis/dcos-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/br-lewis/dcos-cli/contents/{+path}","compare_url":"https://api.github.com/repos/br-lewis/dcos-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/br-lewis/dcos-cli/merges","archive_url":"https://api.github.com/repos/br-lewis/dcos-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/br-lewis/dcos-cli/downloads","issues_url":"https://api.github.com/repos/br-lewis/dcos-cli/issues{/number}","pulls_url":"https://api.github.com/repos/br-lewis/dcos-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/br-lewis/dcos-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/br-lewis/dcos-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/br-lewis/dcos-cli/labels{/name}","releases_url":"https://api.github.com/repos/br-lewis/dcos-cli/releases{/id}","deployments_url":"https://api.github.com/repos/br-lewis/dcos-cli/deployments","created_at":"2018-03-21T12:58:23Z","updated_at":"2018-08-30T14:53:32Z","pushed_at":"2018-08-31T14:38:35Z","git_url":"git://github.com/br-lewis/dcos-cli.git","ssh_url":"git@github.com:br-lewis/dcos-cli.git","clone_url":"https://github.com/br-lewis/dcos-cli.git","svn_url":"https://github.com/br-lewis/dcos-cli","homepage":"https://dcos.io/docs/latest/cli/","size":40466,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"09b27c664a3dc7635a07ee3f71fa9ef0f7e88f33","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":26653348,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY1MzM0OA==","name":"dcos-cli","full_name":"dcos/dcos-cli","owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-cli","description":"The command line for DC/OS.","fork":false,"url":"https://api.github.com/repos/dcos/dcos-cli","forks_url":"https://api.github.com/repos/dcos/dcos-cli/forks","keys_url":"https://api.github.com/repos/dcos/dcos-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-cli/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-cli/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-cli/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-cli/events","assignees_url":"https://api.github.com/repos/dcos/dcos-cli/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-cli/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-cli/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-cli/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-cli/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-cli/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-cli/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-cli/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-cli/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-cli/merges","archive_url":"https://api.github.com/repos/dcos/dcos-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-cli/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-cli/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-cli/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-cli/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-cli/deployments","created_at":"2014-11-14T19:11:48Z","updated_at":"2018-08-30T16:56:38Z","pushed_at":"2018-09-02T13:03:05Z","git_url":"git://github.com/dcos/dcos-cli.git","ssh_url":"git@github.com:dcos/dcos-cli.git","clone_url":"https://github.com/dcos/dcos-cli.git","svn_url":"https://github.com/dcos/dcos-cli","homepage":"https://dcos.io/docs/latest/cli/","size":18217,"stargazers_count":215,"watchers_count":215,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":120,"open_issues":58,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320"},"html":{"href":"https://github.com/dcos/dcos-cli/pull/1320"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-cli/issues/1320"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-cli/issues/1320/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-cli/pulls/1320/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-cli/statuses/9e3b2cc8994805faf1289fde9c07740ada671333"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bamarni"}}