{"action":"created","comment":{"url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/comments/182309405","pull_request_review_id":113077463,"id":182309405,"diff_hunk":"@@ -1,11 +1,18 @@\n-﻿namespace GeekLearning.Email\n+namespace GeekLearning.Email\n {\n     using System.Collections.Generic;\n     using System.Threading.Tasks;\n-\n+    using MimeKit;\n+    \n     public interface IEmailProvider\n     {\n-        Task SendEmailAsync(IEmailAddress from, IEnumerable<IEmailAddress> recipients, string subject, string bodyText, string bodyHtml);\n+        Task SendEmailAsync(","path":"src/GeekLearning.Email/IEmailProvider.cs","position":12,"original_position":12,"commit_id":"2a1cf739c25425f5378d4ae9213ac3f6a7360902","original_commit_id":"2a1cf739c25425f5378d4ae9213ac3f6a7360902","user":{"login":"Budsy","id":8251833,"avatar_url":"https://avatars3.githubusercontent.com/u/8251833?v=4","gravatar_id":"","url":"https://api.github.com/users/Budsy","html_url":"https://github.com/Budsy","followers_url":"https://api.github.com/users/Budsy/followers","following_url":"https://api.github.com/users/Budsy/following{/other_user}","gists_url":"https://api.github.com/users/Budsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Budsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Budsy/subscriptions","organizations_url":"https://api.github.com/users/Budsy/orgs","repos_url":"https://api.github.com/users/Budsy/repos","events_url":"https://api.github.com/users/Budsy/events{/privacy}","received_events_url":"https://api.github.com/users/Budsy/received_events","type":"User","site_admin":false},"body":"My idea was to be able to define a complete email transaction in one call. You might want to send to two (or more) different addresses, Cc: another, and Bcc: yet another, and also have a ReplyTo: for the message that is different that the From: address. (some hosting services required the From address to match the authentication user name, which might not be the same as the 'sender' of the immediate message). Using an attribute parameter for the email address implies a single target transaction. Slower if the app wants to send to several targets.","created_at":"2018-04-18T05:01:21Z","updated_at":"2018-04-18T05:01:21Z","html_url":"https://github.com/geeklearningio/gl-dotnet-email/pull/33#discussion_r182309405","pull_request_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/comments/182309405"},"html":{"href":"https://github.com/geeklearningio/gl-dotnet-email/pull/33#discussion_r182309405"},"pull_request":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33"}},"in_reply_to_id":182275144},"pull_request":{"url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33","id":182328961,"html_url":"https://github.com/geeklearningio/gl-dotnet-email/pull/33","diff_url":"https://github.com/geeklearningio/gl-dotnet-email/pull/33.diff","patch_url":"https://github.com/geeklearningio/gl-dotnet-email/pull/33.patch","issue_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues/33","number":33,"state":"open","locked":false,"title":"gl-dotnet-email changes for Cc, Bcc, ReplyTo, and attachments","user":{"login":"Budsy","id":8251833,"avatar_url":"https://avatars3.githubusercontent.com/u/8251833?v=4","gravatar_id":"","url":"https://api.github.com/users/Budsy","html_url":"https://github.com/Budsy","followers_url":"https://api.github.com/users/Budsy/followers","following_url":"https://api.github.com/users/Budsy/following{/other_user}","gists_url":"https://api.github.com/users/Budsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Budsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Budsy/subscriptions","organizations_url":"https://api.github.com/users/Budsy/orgs","repos_url":"https://api.github.com/users/Budsy/repos","events_url":"https://api.github.com/users/Budsy/events{/privacy}","received_events_url":"https://api.github.com/users/Budsy/received_events","type":"User","site_admin":false},"body":"Edit: Addresses #14 and #15 \r\n\r\nOk. This should be a little cleaner. My usage is mostly for the Smtp methods, but I added code to the InMemory and Sendgrid parts so that they would be still compatible with changes to the Smtp section.\r\n\r\nDiscussion:  breaking code changes? Also, I'm not sure email address validation inside these classes is best. I prefer validation in higher level code. Anyway, these libraries will really be improved by allowing attachments and targeting addresses to Bcc and Cc and so on. So, see what you think. ","created_at":"2018-04-17T23:14:10Z","updated_at":"2018-04-18T05:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c28216d0b4535eaa0c0f7952403d4f67a8475c2b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asiffermann","id":12293953,"avatar_url":"https://avatars3.githubusercontent.com/u/12293953?v=4","gravatar_id":"","url":"https://api.github.com/users/asiffermann","html_url":"https://github.com/asiffermann","followers_url":"https://api.github.com/users/asiffermann/followers","following_url":"https://api.github.com/users/asiffermann/following{/other_user}","gists_url":"https://api.github.com/users/asiffermann/gists{/gist_id}","starred_url":"https://api.github.com/users/asiffermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asiffermann/subscriptions","organizations_url":"https://api.github.com/users/asiffermann/orgs","repos_url":"https://api.github.com/users/asiffermann/repos","events_url":"https://api.github.com/users/asiffermann/events{/privacy}","received_events_url":"https://api.github.com/users/asiffermann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33/commits","review_comments_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33/comments","review_comment_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues/33/comments","statuses_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/statuses/2a1cf739c25425f5378d4ae9213ac3f6a7360902","head":{"label":"Budsy:develop","ref":"develop","sha":"2a1cf739c25425f5378d4ae9213ac3f6a7360902","user":{"login":"Budsy","id":8251833,"avatar_url":"https://avatars3.githubusercontent.com/u/8251833?v=4","gravatar_id":"","url":"https://api.github.com/users/Budsy","html_url":"https://github.com/Budsy","followers_url":"https://api.github.com/users/Budsy/followers","following_url":"https://api.github.com/users/Budsy/following{/other_user}","gists_url":"https://api.github.com/users/Budsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Budsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Budsy/subscriptions","organizations_url":"https://api.github.com/users/Budsy/orgs","repos_url":"https://api.github.com/users/Budsy/repos","events_url":"https://api.github.com/users/Budsy/events{/privacy}","received_events_url":"https://api.github.com/users/Budsy/received_events","type":"User","site_admin":false},"repo":{"id":129949695,"name":"gl-dotnet-email","full_name":"Budsy/gl-dotnet-email","owner":{"login":"Budsy","id":8251833,"avatar_url":"https://avatars3.githubusercontent.com/u/8251833?v=4","gravatar_id":"","url":"https://api.github.com/users/Budsy","html_url":"https://github.com/Budsy","followers_url":"https://api.github.com/users/Budsy/followers","following_url":"https://api.github.com/users/Budsy/following{/other_user}","gists_url":"https://api.github.com/users/Budsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Budsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Budsy/subscriptions","organizations_url":"https://api.github.com/users/Budsy/orgs","repos_url":"https://api.github.com/users/Budsy/repos","events_url":"https://api.github.com/users/Budsy/events{/privacy}","received_events_url":"https://api.github.com/users/Budsy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Budsy/gl-dotnet-email","description":".NET Core Email abstractions with SendGrid, SMTP and InMemory providers","fork":true,"url":"https://api.github.com/repos/Budsy/gl-dotnet-email","forks_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/forks","keys_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/teams","hooks_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/hooks","issue_events_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/issues/events{/number}","events_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/events","assignees_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/assignees{/user}","branches_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/branches{/branch}","tags_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/tags","blobs_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/git/refs{/sha}","trees_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/statuses/{sha}","languages_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/languages","stargazers_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/stargazers","contributors_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/contributors","subscribers_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/subscribers","subscription_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/subscription","commits_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/commits{/sha}","git_commits_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/git/commits{/sha}","comments_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/comments{/number}","issue_comment_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/issues/comments{/number}","contents_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/contents/{+path}","compare_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/merges","archive_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/downloads","issues_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/issues{/number}","pulls_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/pulls{/number}","milestones_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/milestones{/number}","notifications_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/labels{/name}","releases_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/releases{/id}","deployments_url":"https://api.github.com/repos/Budsy/gl-dotnet-email/deployments","created_at":"2018-04-17T18:40:14Z","updated_at":"2018-04-17T23:07:27Z","pushed_at":"2018-04-17T23:07:26Z","git_url":"git://github.com/Budsy/gl-dotnet-email.git","ssh_url":"git@github.com:Budsy/gl-dotnet-email.git","clone_url":"https://github.com/Budsy/gl-dotnet-email.git","svn_url":"https://github.com/Budsy/gl-dotnet-email","homepage":"","size":590,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"geeklearningio:develop","ref":"develop","sha":"869c3e735d4faeeb0978c0614114a54baec13908","user":{"login":"geeklearningio","id":18627475,"avatar_url":"https://avatars1.githubusercontent.com/u/18627475?v=4","gravatar_id":"","url":"https://api.github.com/users/geeklearningio","html_url":"https://github.com/geeklearningio","followers_url":"https://api.github.com/users/geeklearningio/followers","following_url":"https://api.github.com/users/geeklearningio/following{/other_user}","gists_url":"https://api.github.com/users/geeklearningio/gists{/gist_id}","starred_url":"https://api.github.com/users/geeklearningio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeklearningio/subscriptions","organizations_url":"https://api.github.com/users/geeklearningio/orgs","repos_url":"https://api.github.com/users/geeklearningio/repos","events_url":"https://api.github.com/users/geeklearningio/events{/privacy}","received_events_url":"https://api.github.com/users/geeklearningio/received_events","type":"Organization","site_admin":false},"repo":{"id":57404035,"name":"gl-dotnet-email","full_name":"geeklearningio/gl-dotnet-email","owner":{"login":"geeklearningio","id":18627475,"avatar_url":"https://avatars1.githubusercontent.com/u/18627475?v=4","gravatar_id":"","url":"https://api.github.com/users/geeklearningio","html_url":"https://github.com/geeklearningio","followers_url":"https://api.github.com/users/geeklearningio/followers","following_url":"https://api.github.com/users/geeklearningio/following{/other_user}","gists_url":"https://api.github.com/users/geeklearningio/gists{/gist_id}","starred_url":"https://api.github.com/users/geeklearningio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeklearningio/subscriptions","organizations_url":"https://api.github.com/users/geeklearningio/orgs","repos_url":"https://api.github.com/users/geeklearningio/repos","events_url":"https://api.github.com/users/geeklearningio/events{/privacy}","received_events_url":"https://api.github.com/users/geeklearningio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geeklearningio/gl-dotnet-email","description":".NET Core Email abstractions with SendGrid, SMTP and InMemory providers","fork":false,"url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email","forks_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/forks","keys_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/teams","hooks_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/hooks","issue_events_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues/events{/number}","events_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/events","assignees_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/assignees{/user}","branches_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/branches{/branch}","tags_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/tags","blobs_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/git/refs{/sha}","trees_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/statuses/{sha}","languages_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/languages","stargazers_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/stargazers","contributors_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/contributors","subscribers_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/subscribers","subscription_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/subscription","commits_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/commits{/sha}","git_commits_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/git/commits{/sha}","comments_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/comments{/number}","issue_comment_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues/comments{/number}","contents_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/contents/{+path}","compare_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/merges","archive_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/downloads","issues_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues{/number}","pulls_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls{/number}","milestones_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/milestones{/number}","notifications_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/labels{/name}","releases_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/releases{/id}","deployments_url":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/deployments","created_at":"2016-04-29T18:10:42Z","updated_at":"2018-04-12T04:44:50Z","pushed_at":"2018-04-17T23:14:12Z","git_url":"git://github.com/geeklearningio/gl-dotnet-email.git","ssh_url":"git@github.com:geeklearningio/gl-dotnet-email.git","clone_url":"https://github.com/geeklearningio/gl-dotnet-email.git","svn_url":"https://github.com/geeklearningio/gl-dotnet-email","homepage":"","size":570,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":6,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33"},"html":{"href":"https://github.com/geeklearningio/gl-dotnet-email/pull/33"},"issue":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues/33"},"comments":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/geeklearningio/gl-dotnet-email/statuses/2a1cf739c25425f5378d4ae9213ac3f6a7360902"}},"author_association":"NONE"}}
{"actor":{"display_login":"Budsy"}}