{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/yoast-components/issues/457","repository_url":"https://api.github.com/repos/Yoast/yoast-components","labels_url":"https://api.github.com/repos/Yoast/yoast-components/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/yoast-components/issues/457/comments","events_url":"https://api.github.com/repos/Yoast/yoast-components/issues/457/events","html_url":"https://github.com/Yoast/yoast-components/pull/457","id":310063906,"number":457,"title":"Add overall score to the redux state","user":{"login":"danielFangstrom","id":7872022,"avatar_url":"https://avatars3.githubusercontent.com/u/7872022?v=4","gravatar_id":"","url":"https://api.github.com/users/danielFangstrom","html_url":"https://github.com/danielFangstrom","followers_url":"https://api.github.com/users/danielFangstrom/followers","following_url":"https://api.github.com/users/danielFangstrom/following{/other_user}","gists_url":"https://api.github.com/users/danielFangstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/danielFangstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielFangstrom/subscriptions","organizations_url":"https://api.github.com/users/danielFangstrom/orgs","repos_url":"https://api.github.com/users/danielFangstrom/repos","events_url":"https://api.github.com/users/danielFangstrom/events{/privacy}","received_events_url":"https://api.github.com/users/danielFangstrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-30T13:17:10Z","updated_at":"2018-04-16T11:38:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yoast/yoast-components/pulls/457","html_url":"https://github.com/Yoast/yoast-components/pull/457","diff_url":"https://github.com/Yoast/yoast-components/pull/457.diff","patch_url":"https://github.com/Yoast/yoast-components/pull/457.patch"},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Adds the overall score for each type of analysis to the redux state\r\n\r\n## Relevant technical choices:\r\n\r\n* Adds actions and reducers for overall scores to the content analysis reducer\r\n\r\n## Test instructions\r\n\r\nThis PR can be tested by following these steps:\r\n\r\n* Run `yarn install` and `yarn test`, and check whether the tests pass\r\n* You can also expose the store and the action to the window in edit.js, and dispatch it (store.dispatch( action() ) and check whether the state was changed correctly regarding the overall scores. Readability results and SEO results should have separate overall scores, and SEO should also have an overall score for each keyword.\r\n\r\nFixes https://github.com/Yoast/wordpress-seo/issues/9308"},"comment":{"url":"https://api.github.com/repos/Yoast/yoast-components/issues/comments/381570084","html_url":"https://github.com/Yoast/yoast-components/pull/457#issuecomment-381570084","issue_url":"https://api.github.com/repos/Yoast/yoast-components/issues/457","id":381570084,"user":{"login":"IreneStr","id":17744553,"avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T11:38:46Z","updated_at":"2018-04-16T11:38:46Z","author_association":"CONTRIBUTOR","body":"I've removed the unused `overallScoreReducer `, and moved `setOverallSeoScore` and `setOverallReadabilityScore` to the `keywordResultsReducer.js ` and the `readabilityResultsReducer.js` respectively. \r\n\r\nWhen you run the tests, some checkboxtests are failing. This is also the case on `feature/content-analysis-in-sidebar`, which means the failing tests are not part of this issue/PR. I'll look into this later. "}}
{"actor":{"display_login":"IreneStr"}}