{"action":"closed","number":2322,"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2322","id":177430680,"html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/2322","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/2322.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/2322.patch","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2322","number":2322,"state":"closed","locked":false,"title":"fix for ds18b20 negative decimals","user":{"login":"peturdainn","id":14952899,"avatar_url":"https://avatars3.githubusercontent.com/u/14952899?v=4","gravatar_id":"","url":"https://api.github.com/users/peturdainn","html_url":"https://github.com/peturdainn","followers_url":"https://api.github.com/users/peturdainn/followers","following_url":"https://api.github.com/users/peturdainn/following{/other_user}","gists_url":"https://api.github.com/users/peturdainn/gists{/gist_id}","starred_url":"https://api.github.com/users/peturdainn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peturdainn/subscriptions","organizations_url":"https://api.github.com/users/peturdainn/orgs","repos_url":"https://api.github.com/users/peturdainn/repos","events_url":"https://api.github.com/users/peturdainn/events{/privacy}","received_events_url":"https://api.github.com/users/peturdainn/received_events","type":"User","site_admin":false},"body":"Fixes ds18b20 negative decimals bug by changing the way temp and temp_dec are calculated, taking care not to lose the sign of the decimals part\r\n\r\nFixes #2313\r\n\r\n- [x] This PR is for the `dev` branch rather than for `master`.\r\n- [x] This PR is compliant with the [other contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) as well (if not, please describe why).\r\n- [x] I have thoroughly tested my contribution.\r\n\r\nds18b20 decimals do not take into account the sign bit. Since the original calculation was not so readable, rewritten in readable way that also fixes the bug. Same code as PR against master.","created_at":"2018-03-26T12:30:01Z","updated_at":"2018-04-27T10:35:08Z","closed_at":"2018-04-27T10:35:07Z","merged_at":"2018-04-27T10:35:07Z","merge_commit_sha":"45fea23d661733417e66fe0650e9ab67285ed5fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":510509761,"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/labels/bugfix","name":"bugfix","color":"fc2929","default":false}],"milestone":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones/9","html_url":"https://github.com/nodemcu/nodemcu-firmware/milestone/9","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones/9/labels","id":3236151,"number":9,"title":"2.2-follow-up","description":"- `tmr.suspend() tmr.suspend_all() tmr.resume() tmr.resume_all()` removed","creator":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars0.githubusercontent.com/u/624195?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2018-04-02T19:03:32Z","updated_at":"2018-04-27T10:35:08Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2322/commits","review_comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2322/comments","review_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2322/comments","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/a1e02fc6a898475316d18a27f61092eabcefccb0","head":{"label":"peturdainn:peturdainn-patch-1","ref":"peturdainn-patch-1","sha":"a1e02fc6a898475316d18a27f61092eabcefccb0","user":{"login":"peturdainn","id":14952899,"avatar_url":"https://avatars3.githubusercontent.com/u/14952899?v=4","gravatar_id":"","url":"https://api.github.com/users/peturdainn","html_url":"https://github.com/peturdainn","followers_url":"https://api.github.com/users/peturdainn/followers","following_url":"https://api.github.com/users/peturdainn/following{/other_user}","gists_url":"https://api.github.com/users/peturdainn/gists{/gist_id}","starred_url":"https://api.github.com/users/peturdainn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peturdainn/subscriptions","organizations_url":"https://api.github.com/users/peturdainn/orgs","repos_url":"https://api.github.com/users/peturdainn/repos","events_url":"https://api.github.com/users/peturdainn/events{/privacy}","received_events_url":"https://api.github.com/users/peturdainn/received_events","type":"User","site_admin":false},"repo":{"id":126649327,"name":"nodemcu-firmware","full_name":"peturdainn/nodemcu-firmware","owner":{"login":"peturdainn","id":14952899,"avatar_url":"https://avatars3.githubusercontent.com/u/14952899?v=4","gravatar_id":"","url":"https://api.github.com/users/peturdainn","html_url":"https://github.com/peturdainn","followers_url":"https://api.github.com/users/peturdainn/followers","following_url":"https://api.github.com/users/peturdainn/following{/other_user}","gists_url":"https://api.github.com/users/peturdainn/gists{/gist_id}","starred_url":"https://api.github.com/users/peturdainn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peturdainn/subscriptions","organizations_url":"https://api.github.com/users/peturdainn/orgs","repos_url":"https://api.github.com/users/peturdainn/repos","events_url":"https://api.github.com/users/peturdainn/events{/privacy}","received_events_url":"https://api.github.com/users/peturdainn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peturdainn/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":true,"url":"https://api.github.com/repos/peturdainn/nodemcu-firmware","forks_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/peturdainn/nodemcu-firmware/deployments","created_at":"2018-03-24T23:43:07Z","updated_at":"2018-03-24T23:43:13Z","pushed_at":"2018-03-25T21:01:16Z","git_url":"git://github.com/peturdainn/nodemcu-firmware.git","ssh_url":"git@github.com:peturdainn/nodemcu-firmware.git","clone_url":"https://github.com/peturdainn/nodemcu-firmware.git","svn_url":"https://github.com/peturdainn/nodemcu-firmware","homepage":"http://nodemcu.com","size":106208,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodemcu:dev","ref":"dev","sha":"519d6df62c0696f6222411b836328b9b4bb3a6ee","user":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars0.githubusercontent.com/u/9865736?v=4","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"repo":{"id":26917568,"name":"nodemcu-firmware","full_name":"nodemcu/nodemcu-firmware","owner":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars0.githubusercontent.com/u/9865736?v=4","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nodemcu/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":false,"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","forks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/deployments","created_at":"2014-11-20T15:06:45Z","updated_at":"2018-04-26T23:30:07Z","pushed_at":"2018-04-27T10:35:07Z","git_url":"git://github.com/nodemcu/nodemcu-firmware.git","ssh_url":"git@github.com:nodemcu/nodemcu-firmware.git","clone_url":"https://github.com/nodemcu/nodemcu-firmware.git","svn_url":"https://github.com/nodemcu/nodemcu-firmware","homepage":"http://nodemcu.com","size":106270,"stargazers_count":4391,"watchers_count":4391,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1994,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1994,"open_issues":199,"watchers":4391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2322"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/2322"},"issue":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2322"},"comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2322/comments"},"review_comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2322/comments"},"review_comment":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/2322/commits"},"statuses":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/a1e02fc6a898475316d18a27f61092eabcefccb0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"TerryE","id":690173,"avatar_url":"https://avatars3.githubusercontent.com/u/690173?v=4","gravatar_id":"","url":"https://api.github.com/users/TerryE","html_url":"https://github.com/TerryE","followers_url":"https://api.github.com/users/TerryE/followers","following_url":"https://api.github.com/users/TerryE/following{/other_user}","gists_url":"https://api.github.com/users/TerryE/gists{/gist_id}","starred_url":"https://api.github.com/users/TerryE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerryE/subscriptions","organizations_url":"https://api.github.com/users/TerryE/orgs","repos_url":"https://api.github.com/users/TerryE/repos","events_url":"https://api.github.com/users/TerryE/events{/privacy}","received_events_url":"https://api.github.com/users/TerryE/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"TerryE"}}