{"action":"created","issue":{"url":"https://api.github.com/repos/LanguageMachines/LamaEvents/issues/4","repository_url":"https://api.github.com/repos/LanguageMachines/LamaEvents","labels_url":"https://api.github.com/repos/LanguageMachines/LamaEvents/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/LanguageMachines/LamaEvents/issues/4/comments","events_url":"https://api.github.com/repos/LanguageMachines/LamaEvents/issues/4/events","html_url":"https://github.com/LanguageMachines/LamaEvents/issues/4","id":304695181,"number":4,"title":"Tweets are not shown in event details page","user":{"login":"ErkanBasar","id":6985467,"avatar_url":"https://avatars0.githubusercontent.com/u/6985467?v=4","gravatar_id":"","url":"https://api.github.com/users/ErkanBasar","html_url":"https://github.com/ErkanBasar","followers_url":"https://api.github.com/users/ErkanBasar/followers","following_url":"https://api.github.com/users/ErkanBasar/following{/other_user}","gists_url":"https://api.github.com/users/ErkanBasar/gists{/gist_id}","starred_url":"https://api.github.com/users/ErkanBasar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErkanBasar/subscriptions","organizations_url":"https://api.github.com/users/ErkanBasar/orgs","repos_url":"https://api.github.com/users/ErkanBasar/repos","events_url":"https://api.github.com/users/ErkanBasar/events{/privacy}","received_events_url":"https://api.github.com/users/ErkanBasar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ghiathghanem","id":35560701,"avatar_url":"https://avatars2.githubusercontent.com/u/35560701?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiathghanem","html_url":"https://github.com/ghiathghanem","followers_url":"https://api.github.com/users/ghiathghanem/followers","following_url":"https://api.github.com/users/ghiathghanem/following{/other_user}","gists_url":"https://api.github.com/users/ghiathghanem/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiathghanem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiathghanem/subscriptions","organizations_url":"https://api.github.com/users/ghiathghanem/orgs","repos_url":"https://api.github.com/users/ghiathghanem/repos","events_url":"https://api.github.com/users/ghiathghanem/events{/privacy}","received_events_url":"https://api.github.com/users/ghiathghanem/received_events","type":"User","site_admin":false},"assignees":[{"login":"ghiathghanem","id":35560701,"avatar_url":"https://avatars2.githubusercontent.com/u/35560701?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiathghanem","html_url":"https://github.com/ghiathghanem","followers_url":"https://api.github.com/users/ghiathghanem/followers","following_url":"https://api.github.com/users/ghiathghanem/following{/other_user}","gists_url":"https://api.github.com/users/ghiathghanem/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiathghanem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiathghanem/subscriptions","organizations_url":"https://api.github.com/users/ghiathghanem/orgs","repos_url":"https://api.github.com/users/ghiathghanem/repos","events_url":"https://api.github.com/users/ghiathghanem/events{/privacy}","received_events_url":"https://api.github.com/users/ghiathghanem/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-03-13T09:55:45Z","updated_at":"2018-03-15T09:05:23Z","closed_at":null,"author_association":"MEMBER","body":"### Description\r\nWhen a user clicks on an event in the calendar, the tweets relating to that event should be displayed. Right now, nothing displayed under the title \"Tweets over dit event\".\r\n\r\n### Possible Problems\r\n* ~~Data structure might be incorrect. Thus it may not be able to find what to display.~~\r\n* ~~There might be something wrong with the Twitter widgets, e.g. using an old version, a change in the widget URL or problem with API key.~~\r\n\r\n### Decision\r\nAfter having a discussion with @fkunneman, we concluded that this is normal for some of the events, specifically labelled as `Voorspeld`. They simply are not formed from tweets, so there is no tweet to be displayed. Therefore this is not a bug but rather about giving users appropriate feedback.\r\n\r\n### Solution\r\nRight now, when there is no tweet, it looks like something is broken in the system. If there is no tweet to be displayed, at least a message that indicates the reason should appear to clear out the confusion.  "},"comment":{"url":"https://api.github.com/repos/LanguageMachines/LamaEvents/issues/comments/373307053","html_url":"https://github.com/LanguageMachines/LamaEvents/issues/4#issuecomment-373307053","issue_url":"https://api.github.com/repos/LanguageMachines/LamaEvents/issues/4","id":373307053,"user":{"login":"ghiathghanem","id":35560701,"avatar_url":"https://avatars2.githubusercontent.com/u/35560701?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiathghanem","html_url":"https://github.com/ghiathghanem","followers_url":"https://api.github.com/users/ghiathghanem/followers","following_url":"https://api.github.com/users/ghiathghanem/following{/other_user}","gists_url":"https://api.github.com/users/ghiathghanem/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiathghanem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiathghanem/subscriptions","organizations_url":"https://api.github.com/users/ghiathghanem/orgs","repos_url":"https://api.github.com/users/ghiathghanem/repos","events_url":"https://api.github.com/users/ghiathghanem/events{/privacy}","received_events_url":"https://api.github.com/users/ghiathghanem/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T09:05:23Z","updated_at":"2018-03-15T09:05:23Z","author_association":"COLLABORATOR","body":"I saw the same thing. It was a good idea to discuss that with Florian. I agree with you to display a message to the user to let him knows that nothing went wrong.Thanks Erkan.here is another problem: if we select this date, we will get this result: \n Zaterdag 18 maart 2017\n  Vermoedelijke locatie voor dit event:  Geen locatie bekend voor deze gebeurtenis   \n Periodiciteit: ieder jaar op de 3e zaterdag van maart \n\n Eerdere edities: \n  \n 2014-03-15 - visio   \n 2015-03-21 - visio   \n 2016-03-19 - visio   \n 2017-03-18 - visio   \n 2017-03-18 - visio, bethesda  But when we click on the last one (visio, bethesda) we get page with this message(\nDoesNotExist at /58ce553e385ee419d84a7545/eventDetail\n) with coding page.\n \n\n    On Wednesday, March 14, 2018, 3:05:47 PM GMT+1, M. Erkan Başar <notifications@github.com> wrote:  \n \n \nI have checked it again and see the tweets under \"Eerderde edities\" for some of the events. Thus it can not be caused by a problem with Twitter widgets or API. Therefore, this is probably caused by the data.\n\nI have also discussed this with @fkunneman and we concluded that this is normal for some of the events, specifically labelled as Voorspeld. They simply are not formed from tweets, so there is no tweet to be displayed. In this case, a message should be displayed for users to clear out any confusions and to save it from looking like broken. So, this task turns out to be about giving sufficient feedback to the users. I'm updating the issue and the initial comment.\n\n\n—\nYou are receiving this because you were assigned.\nReply to this email directly, view it on GitHub, or mute the thread.   "}}
{"actor":{"display_login":"ghiathghanem"}}