{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1705","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1705/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1705/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1705/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1705","id":330086346,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTgxOTA5","number":1705,"title":"[WIP] Effects Refactoring","user":{"login":"kshitij98","id":12982388,"node_id":"MDQ6VXNlcjEyOTgyMzg4","avatar_url":"https://avatars0.githubusercontent.com/u/12982388?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij98","html_url":"https://github.com/kshitij98","followers_url":"https://api.github.com/users/kshitij98/followers","following_url":"https://api.github.com/users/kshitij98/following{/other_user}","gists_url":"https://api.github.com/users/kshitij98/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij98/subscriptions","organizations_url":"https://api.github.com/users/kshitij98/orgs","repos_url":"https://api.github.com/users/kshitij98/repos","events_url":"https://api.github.com/users/kshitij98/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij98/received_events","type":"User","site_admin":false},"labels":[{"id":519656126,"node_id":"MDU6TGFiZWw1MTk2NTYxMjY=","url":"https://api.github.com/repos/mixxxdj/mixxx/labels/effects","name":"effects","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mixxxdj/mixxx/milestones/8","html_url":"https://github.com/mixxxdj/mixxx/milestone/8","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones/8/labels","id":3280972,"node_id":"MDk6TWlsZXN0b25lMzI4MDk3Mg==","number":8,"title":"2.3.0","description":"","creator":{"login":"Be-ing","id":9455094,"node_id":"MDQ6VXNlcjk0NTUwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9455094?v=4","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":1,"state":"open","created_at":"2018-04-19T13:09:05Z","updated_at":"2018-06-27T20:43:02Z","due_on":"2019-04-02T07:00:00Z","closed_at":null},"comments":38,"created_at":"2018-06-07T01:33:04Z","updated_at":"2018-06-28T20:53:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1705","html_url":"https://github.com/mixxxdj/mixxx/pull/1705","diff_url":"https://github.com/mixxxdj/mixxx/pull/1705.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1705.patch"},"body":"The pull request is at a very initial stage and a lot of work still needs to be done on it.\r\n\r\nThe current scope of this PR is:\r\n- [x] Consolidate `EffectChain` and `EffectChainSlot` class\r\n- [x] Remove EffectChainManager\r\n- [x] Remove EngineEffectRack\r\n- [ ] Remove EffectRack\r\n- [ ] Consolidate Effect/EffectSlot\r\n- [ ] Consolidate EffectParameter/EffectParameterSlot\r\n- [ ] Reimplement saving/loading from XML with new EffectChainPreset & EffectPreset classes.\r\n\r\n\r\n<br/>\r\n\r\nThere is some confusion with the current naming of classes. The newly proposed class names are:\r\n- [ ] EffectState -> EffectProcessorState\r\n- [ ] EffectChain/EffectChainSlot -> EffectRack\r\n- [ ] EngineEffectChain -> EngineEffectRack (loaded using EffectRackPreset)\r\n- [ ] Effect/EffectSlot -> EffectSlot\r\n- [ ] EngineEffect -> EngineEffectSlot (loaded using EffectPreset)\r\n- [ ] EffectProcessor -> EffectProcessor\r\n\r\n<i><b>NOTE</b>: XML loading and saving has been commented out and will be re-implemented with the new `Preset` classes</i>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/401170047","html_url":"https://github.com/mixxxdj/mixxx/pull/1705#issuecomment-401170047","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1705","id":401170047,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTE3MDA0Nw==","user":{"login":"Be-ing","id":9455094,"node_id":"MDQ6VXNlcjk0NTUwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9455094?v=4","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T20:53:58Z","updated_at":"2018-06-28T20:53:58Z","author_association":"CONTRIBUTOR","body":"There are a lot of member variables and methods of EffectChainSlot that are private but now I realize they should be protected."}}
{"actor":{"display_login":"Be-ing"}}