{"action":"created","issue":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2517","repository_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit","labels_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2517/labels{/name}","comments_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2517/comments","events_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2517/events","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2517","id":365340226,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjgyOTkw","number":2517,"title":"Fix DataGrid colours not adapting to Dark Theme","user":{"login":"danimart1991","id":5982912,"node_id":"MDQ6VXNlcjU5ODI5MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5982912?v=4","gravatar_id":"","url":"https://api.github.com/users/danimart1991","html_url":"https://github.com/danimart1991","followers_url":"https://api.github.com/users/danimart1991/followers","following_url":"https://api.github.com/users/danimart1991/following{/other_user}","gists_url":"https://api.github.com/users/danimart1991/gists{/gist_id}","starred_url":"https://api.github.com/users/danimart1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danimart1991/subscriptions","organizations_url":"https://api.github.com/users/danimart1991/orgs","repos_url":"https://api.github.com/users/danimart1991/repos","events_url":"https://api.github.com/users/danimart1991/events{/privacy}","received_events_url":"https://api.github.com/users/danimart1991/received_events","type":"User","site_admin":false},"labels":[{"id":936600972,"node_id":"MDU6TGFiZWw5MzY2MDA5NzI=","url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels/DataGrid","name":"DataGrid","color":"2f17b7","default":false},{"id":415293891,"node_id":"MDU6TGFiZWw0MTUyOTM4OTE=","url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels/controls","name":"controls","color":"fef2c0","default":false},{"id":446241994,"node_id":"MDU6TGFiZWw0NDYyNDE5OTQ=","url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/labels/reviewers%20wanted","name":"reviewers wanted","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-01T07:34:09Z","updated_at":"2018-10-04T21:33:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/pulls/2517","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2517","diff_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2517.diff","patch_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2517.patch"},"body":"Issue: #2373\r\n<!-- Link to relevant issue. All PRs should be asociated with an issue -->\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n<!-- Please uncomment one ore more that apply to this PR -->\r\n\r\nBugfix\r\n<!-- - Feature -->\r\n<!-- - Code style update (formatting) -->\r\n<!-- - Refactoring (no functional changes, no api changes) -->\r\n<!-- - Build or CI related changes -->\r\n<!-- - Documentation content changes -->\r\n<!-- - Sample app changes -->\r\n<!-- - Other... Please describe: -->\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nSee issue. DataGrid control is not adapting it's colors to Dark Mode.\r\n\r\n## What is the new behavior?\r\nDataGrid control adapts it's colors to Dark Mode.\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [X] Tested code with current [supported SDKs](../readme.md#supported)\r\n- [ ] Docs have been added/updated which fit [documentation template](https://github.com/Microsoft/UWPCommunityToolkit/blob/master/docs/.template.md). (for bug fixes / features)\r\n- [ ] Sample in sample app has been added / updated (for bug fixes / features)\r\n    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/Microsoft/UWPCommunityToolkit-design-assets)\r\n- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)\r\n- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)\r\n- [X] Contains **NO** breaking changes\r\n\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. \r\n     Please note that breaking changes are likely to be rejected -->"},"comment":{"url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/comments/427177120","html_url":"https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/2517#issuecomment-427177120","issue_url":"https://api.github.com/repos/windows-toolkit/WindowsCommunityToolkit/issues/2517","id":427177120,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzE3NzEyMA==","user":{"login":"MSRegisB","id":36547063,"node_id":"MDQ6VXNlcjM2NTQ3MDYz","avatar_url":"https://avatars3.githubusercontent.com/u/36547063?v=4","gravatar_id":"","url":"https://api.github.com/users/MSRegisB","html_url":"https://github.com/MSRegisB","followers_url":"https://api.github.com/users/MSRegisB/followers","following_url":"https://api.github.com/users/MSRegisB/following{/other_user}","gists_url":"https://api.github.com/users/MSRegisB/gists{/gist_id}","starred_url":"https://api.github.com/users/MSRegisB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSRegisB/subscriptions","organizations_url":"https://api.github.com/users/MSRegisB/orgs","repos_url":"https://api.github.com/users/MSRegisB/repos","events_url":"https://api.github.com/users/MSRegisB/events{/privacy}","received_events_url":"https://api.github.com/users/MSRegisB/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T21:33:46Z","updated_at":"2018-10-04T21:33:46Z","author_association":"COLLABORATOR","body":"Daniel, it looks like you're changing the colors for DataGridColumnHeaderBackgroundBrush and SystemControlGridLinesBaseMediumLowBrush. I'm afraid we cannot change colors that easily. Our designer is very specific about the control's look and we would need her approval. Thanks!"}}
{"actor":{"display_login":"MSRegisB"}}