{"action":"created","comment":{"url":"https://api.github.com/repos/lorenzb/proveth/pulls/comments/220983728","pull_request_review_id":159523248,"id":220983728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDk4MzcyOA==","diff_hunk":"@@ -190,26 +186,19 @@ contract ProvethVerifier {\n         bytes32 blockHash,\n         bytes proofBlob\n     ) internal returns (uint8 result, uint256 index, Transaction memory t) {\n-        result = TX_PROOF_RESULT_INVALID;","path":"onchain/ProvethVerifier.sol","position":61,"original_position":61,"commit_id":"6ae6b50a1387a54994df45c1c68c85d4c432eff7","original_commit_id":"6ae6b50a1387a54994df45c1c68c85d4c432eff7","user":{"login":"lorenzb","id":1148586,"node_id":"MDQ6VXNlcjExNDg1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1148586?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzb","html_url":"https://github.com/lorenzb","followers_url":"https://api.github.com/users/lorenzb/followers","following_url":"https://api.github.com/users/lorenzb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzb/subscriptions","organizations_url":"https://api.github.com/users/lorenzb/orgs","repos_url":"https://api.github.com/users/lorenzb/repos","events_url":"https://api.github.com/users/lorenzb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzb/received_events","type":"User","site_admin":false},"body":"I got rid of `TX_PROOF_RESULT_INVALID`, since we now `revert` on invalid proofs.\r\nBut I could probably kick out \r\n```\r\nresult = 0;\r\nindex = 0;\r\n``` \r\nsince that's the default anyways.","created_at":"2018-09-27T16:04:29Z","updated_at":"2018-09-27T16:04:29Z","html_url":"https://github.com/lorenzb/proveth/pull/15#discussion_r220983728","pull_request_url":"https://api.github.com/repos/lorenzb/proveth/pulls/15","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lorenzb/proveth/pulls/comments/220983728"},"html":{"href":"https://github.com/lorenzb/proveth/pull/15#discussion_r220983728"},"pull_request":{"href":"https://api.github.com/repos/lorenzb/proveth/pulls/15"}},"in_reply_to_id":220981754},"pull_request":{"url":"https://api.github.com/repos/lorenzb/proveth/pulls/15","id":210719249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzE5MjQ5","html_url":"https://github.com/lorenzb/proveth/pull/15","diff_url":"https://github.com/lorenzb/proveth/pull/15.diff","patch_url":"https://github.com/lorenzb/proveth/pull/15.patch","issue_url":"https://api.github.com/repos/lorenzb/proveth/issues/15","number":15,"state":"open","locked":false,"title":"Invalid proofs","user":{"login":"lorenzb","id":1148586,"node_id":"MDQ6VXNlcjExNDg1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1148586?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzb","html_url":"https://github.com/lorenzb","followers_url":"https://api.github.com/users/lorenzb/followers","following_url":"https://api.github.com/users/lorenzb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzb/subscriptions","organizations_url":"https://api.github.com/users/lorenzb/orgs","repos_url":"https://api.github.com/users/lorenzb/repos","events_url":"https://api.github.com/users/lorenzb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzb/received_events","type":"User","site_admin":false},"body":"This pull requests depends on #14 \r\n\r\nIt currently implements the first part of #9, i.e. reverting on invalid proofs.","created_at":"2018-08-24T11:54:22Z","updated_at":"2018-09-27T16:04:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9938d2d1e8093cd720d0c1f1adf32c06a3d6416","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lorenzb/proveth/pulls/15/commits","review_comments_url":"https://api.github.com/repos/lorenzb/proveth/pulls/15/comments","review_comment_url":"https://api.github.com/repos/lorenzb/proveth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lorenzb/proveth/issues/15/comments","statuses_url":"https://api.github.com/repos/lorenzb/proveth/statuses/6ae6b50a1387a54994df45c1c68c85d4c432eff7","head":{"label":"lorenzb:invalid_proofs","ref":"invalid_proofs","sha":"6ae6b50a1387a54994df45c1c68c85d4c432eff7","user":{"login":"lorenzb","id":1148586,"node_id":"MDQ6VXNlcjExNDg1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1148586?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzb","html_url":"https://github.com/lorenzb","followers_url":"https://api.github.com/users/lorenzb/followers","following_url":"https://api.github.com/users/lorenzb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzb/subscriptions","organizations_url":"https://api.github.com/users/lorenzb/orgs","repos_url":"https://api.github.com/users/lorenzb/repos","events_url":"https://api.github.com/users/lorenzb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzb/received_events","type":"User","site_admin":false},"repo":{"id":142331737,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzE3Mzc=","name":"proveth","full_name":"lorenzb/proveth","private":false,"owner":{"login":"lorenzb","id":1148586,"node_id":"MDQ6VXNlcjExNDg1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1148586?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzb","html_url":"https://github.com/lorenzb","followers_url":"https://api.github.com/users/lorenzb/followers","following_url":"https://api.github.com/users/lorenzb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzb/subscriptions","organizations_url":"https://api.github.com/users/lorenzb/orgs","repos_url":"https://api.github.com/users/lorenzb/repos","events_url":"https://api.github.com/users/lorenzb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lorenzb/proveth","description":"Generate & verify Merkle-Patricia-proofs for Ethereum","fork":false,"url":"https://api.github.com/repos/lorenzb/proveth","forks_url":"https://api.github.com/repos/lorenzb/proveth/forks","keys_url":"https://api.github.com/repos/lorenzb/proveth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorenzb/proveth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorenzb/proveth/teams","hooks_url":"https://api.github.com/repos/lorenzb/proveth/hooks","issue_events_url":"https://api.github.com/repos/lorenzb/proveth/issues/events{/number}","events_url":"https://api.github.com/repos/lorenzb/proveth/events","assignees_url":"https://api.github.com/repos/lorenzb/proveth/assignees{/user}","branches_url":"https://api.github.com/repos/lorenzb/proveth/branches{/branch}","tags_url":"https://api.github.com/repos/lorenzb/proveth/tags","blobs_url":"https://api.github.com/repos/lorenzb/proveth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorenzb/proveth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorenzb/proveth/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorenzb/proveth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorenzb/proveth/statuses/{sha}","languages_url":"https://api.github.com/repos/lorenzb/proveth/languages","stargazers_url":"https://api.github.com/repos/lorenzb/proveth/stargazers","contributors_url":"https://api.github.com/repos/lorenzb/proveth/contributors","subscribers_url":"https://api.github.com/repos/lorenzb/proveth/subscribers","subscription_url":"https://api.github.com/repos/lorenzb/proveth/subscription","commits_url":"https://api.github.com/repos/lorenzb/proveth/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorenzb/proveth/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorenzb/proveth/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorenzb/proveth/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorenzb/proveth/contents/{+path}","compare_url":"https://api.github.com/repos/lorenzb/proveth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorenzb/proveth/merges","archive_url":"https://api.github.com/repos/lorenzb/proveth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorenzb/proveth/downloads","issues_url":"https://api.github.com/repos/lorenzb/proveth/issues{/number}","pulls_url":"https://api.github.com/repos/lorenzb/proveth/pulls{/number}","milestones_url":"https://api.github.com/repos/lorenzb/proveth/milestones{/number}","notifications_url":"https://api.github.com/repos/lorenzb/proveth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorenzb/proveth/labels{/name}","releases_url":"https://api.github.com/repos/lorenzb/proveth/releases{/id}","deployments_url":"https://api.github.com/repos/lorenzb/proveth/deployments","created_at":"2018-07-25T17:21:37Z","updated_at":"2018-09-15T16:23:02Z","pushed_at":"2018-09-25T18:39:05Z","git_url":"git://github.com/lorenzb/proveth.git","ssh_url":"git@github.com:lorenzb/proveth.git","clone_url":"https://github.com/lorenzb/proveth.git","svn_url":"https://github.com/lorenzb/proveth","homepage":"","size":202,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":8,"watchers":17,"default_branch":"master"}},"base":{"label":"lorenzb:master","ref":"master","sha":"120db0d8fe8500032a22eaf1c0ceab80e931ed3e","user":{"login":"lorenzb","id":1148586,"node_id":"MDQ6VXNlcjExNDg1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1148586?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzb","html_url":"https://github.com/lorenzb","followers_url":"https://api.github.com/users/lorenzb/followers","following_url":"https://api.github.com/users/lorenzb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzb/subscriptions","organizations_url":"https://api.github.com/users/lorenzb/orgs","repos_url":"https://api.github.com/users/lorenzb/repos","events_url":"https://api.github.com/users/lorenzb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzb/received_events","type":"User","site_admin":false},"repo":{"id":142331737,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzE3Mzc=","name":"proveth","full_name":"lorenzb/proveth","private":false,"owner":{"login":"lorenzb","id":1148586,"node_id":"MDQ6VXNlcjExNDg1ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1148586?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzb","html_url":"https://github.com/lorenzb","followers_url":"https://api.github.com/users/lorenzb/followers","following_url":"https://api.github.com/users/lorenzb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzb/subscriptions","organizations_url":"https://api.github.com/users/lorenzb/orgs","repos_url":"https://api.github.com/users/lorenzb/repos","events_url":"https://api.github.com/users/lorenzb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lorenzb/proveth","description":"Generate & verify Merkle-Patricia-proofs for Ethereum","fork":false,"url":"https://api.github.com/repos/lorenzb/proveth","forks_url":"https://api.github.com/repos/lorenzb/proveth/forks","keys_url":"https://api.github.com/repos/lorenzb/proveth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorenzb/proveth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorenzb/proveth/teams","hooks_url":"https://api.github.com/repos/lorenzb/proveth/hooks","issue_events_url":"https://api.github.com/repos/lorenzb/proveth/issues/events{/number}","events_url":"https://api.github.com/repos/lorenzb/proveth/events","assignees_url":"https://api.github.com/repos/lorenzb/proveth/assignees{/user}","branches_url":"https://api.github.com/repos/lorenzb/proveth/branches{/branch}","tags_url":"https://api.github.com/repos/lorenzb/proveth/tags","blobs_url":"https://api.github.com/repos/lorenzb/proveth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorenzb/proveth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorenzb/proveth/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorenzb/proveth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorenzb/proveth/statuses/{sha}","languages_url":"https://api.github.com/repos/lorenzb/proveth/languages","stargazers_url":"https://api.github.com/repos/lorenzb/proveth/stargazers","contributors_url":"https://api.github.com/repos/lorenzb/proveth/contributors","subscribers_url":"https://api.github.com/repos/lorenzb/proveth/subscribers","subscription_url":"https://api.github.com/repos/lorenzb/proveth/subscription","commits_url":"https://api.github.com/repos/lorenzb/proveth/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorenzb/proveth/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorenzb/proveth/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorenzb/proveth/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorenzb/proveth/contents/{+path}","compare_url":"https://api.github.com/repos/lorenzb/proveth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorenzb/proveth/merges","archive_url":"https://api.github.com/repos/lorenzb/proveth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorenzb/proveth/downloads","issues_url":"https://api.github.com/repos/lorenzb/proveth/issues{/number}","pulls_url":"https://api.github.com/repos/lorenzb/proveth/pulls{/number}","milestones_url":"https://api.github.com/repos/lorenzb/proveth/milestones{/number}","notifications_url":"https://api.github.com/repos/lorenzb/proveth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorenzb/proveth/labels{/name}","releases_url":"https://api.github.com/repos/lorenzb/proveth/releases{/id}","deployments_url":"https://api.github.com/repos/lorenzb/proveth/deployments","created_at":"2018-07-25T17:21:37Z","updated_at":"2018-09-15T16:23:02Z","pushed_at":"2018-09-25T18:39:05Z","git_url":"git://github.com/lorenzb/proveth.git","ssh_url":"git@github.com:lorenzb/proveth.git","clone_url":"https://github.com/lorenzb/proveth.git","svn_url":"https://github.com/lorenzb/proveth","homepage":"","size":202,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":8,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lorenzb/proveth/pulls/15"},"html":{"href":"https://github.com/lorenzb/proveth/pull/15"},"issue":{"href":"https://api.github.com/repos/lorenzb/proveth/issues/15"},"comments":{"href":"https://api.github.com/repos/lorenzb/proveth/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/lorenzb/proveth/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/lorenzb/proveth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lorenzb/proveth/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/lorenzb/proveth/statuses/6ae6b50a1387a54994df45c1c68c85d4c432eff7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"lorenzb"}}