{"action":"closed","number":112,"pull_request":{"url":"https://api.github.com/repos/Taller-2018-1/core/pulls/112","id":208638228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjM4MjI4","html_url":"https://github.com/Taller-2018-1/core/pull/112","diff_url":"https://github.com/Taller-2018-1/core/pull/112.diff","patch_url":"https://github.com/Taller-2018-1/core/pull/112.patch","issue_url":"https://api.github.com/repos/Taller-2018-1/core/issues/112","number":112,"state":"closed","locked":false,"title":"Fix error when page gets reloaded","user":{"login":"Vreyesm","id":12416901,"node_id":"MDQ6VXNlcjEyNDE2OTAx","avatar_url":"https://avatars3.githubusercontent.com/u/12416901?v=4","gravatar_id":"","url":"https://api.github.com/users/Vreyesm","html_url":"https://github.com/Vreyesm","followers_url":"https://api.github.com/users/Vreyesm/followers","following_url":"https://api.github.com/users/Vreyesm/following{/other_user}","gists_url":"https://api.github.com/users/Vreyesm/gists{/gist_id}","starred_url":"https://api.github.com/users/Vreyesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vreyesm/subscriptions","organizations_url":"https://api.github.com/users/Vreyesm/orgs","repos_url":"https://api.github.com/users/Vreyesm/repos","events_url":"https://api.github.com/users/Vreyesm/events{/privacy}","received_events_url":"https://api.github.com/users/Vreyesm/received_events","type":"User","site_admin":false},"body":"We detect two problems:\r\n1. When the page gets reloaded, the user session persist, but the role get deleted. So, you can't  `role.roleToken of undefined`.\r\n2. When the user start a session, sometimes the page asks for the role of the user before the http call that asks for the role info to the api gets completed. And, again, you can't  `role.roleToken of undefined`.\r\n\r\nSolution:\r\nThe role always starts as `null`, and if you ask for the role... the method will verify if the role is null. If it's null, we call to the api for the info. When the subscribe gets completed, the role object will be returned.\r\n\r\nAlso, the `Authorize` on the role api (`GET`) was deleted(*commented*) because in some cases it returns `Error: 401` and screwp up everything (for some reason the http call is repeated indefinitely).","created_at":"2018-08-15T18:12:15Z","updated_at":"2018-08-17T13:38:41Z","closed_at":"2018-08-17T13:38:41Z","merged_at":"2018-08-17T13:38:41Z","merge_commit_sha":"163a3613256b3dae015fa40ee922f0cd0daf1fd1","assignee":{"login":"arashinishi","id":11673191,"node_id":"MDQ6VXNlcjExNjczMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/11673191?v=4","gravatar_id":"","url":"https://api.github.com/users/arashinishi","html_url":"https://github.com/arashinishi","followers_url":"https://api.github.com/users/arashinishi/followers","following_url":"https://api.github.com/users/arashinishi/following{/other_user}","gists_url":"https://api.github.com/users/arashinishi/gists{/gist_id}","starred_url":"https://api.github.com/users/arashinishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arashinishi/subscriptions","organizations_url":"https://api.github.com/users/arashinishi/orgs","repos_url":"https://api.github.com/users/arashinishi/repos","events_url":"https://api.github.com/users/arashinishi/events{/privacy}","received_events_url":"https://api.github.com/users/arashinishi/received_events","type":"User","site_admin":false},"assignees":[{"login":"arashinishi","id":11673191,"node_id":"MDQ6VXNlcjExNjczMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/11673191?v=4","gravatar_id":"","url":"https://api.github.com/users/arashinishi","html_url":"https://github.com/arashinishi","followers_url":"https://api.github.com/users/arashinishi/followers","following_url":"https://api.github.com/users/arashinishi/following{/other_user}","gists_url":"https://api.github.com/users/arashinishi/gists{/gist_id}","starred_url":"https://api.github.com/users/arashinishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arashinishi/subscriptions","organizations_url":"https://api.github.com/users/arashinishi/orgs","repos_url":"https://api.github.com/users/arashinishi/repos","events_url":"https://api.github.com/users/arashinishi/events{/privacy}","received_events_url":"https://api.github.com/users/arashinishi/received_events","type":"User","site_admin":false},{"login":"Vreyesm","id":12416901,"node_id":"MDQ6VXNlcjEyNDE2OTAx","avatar_url":"https://avatars3.githubusercontent.com/u/12416901?v=4","gravatar_id":"","url":"https://api.github.com/users/Vreyesm","html_url":"https://github.com/Vreyesm","followers_url":"https://api.github.com/users/Vreyesm/followers","following_url":"https://api.github.com/users/Vreyesm/following{/other_user}","gists_url":"https://api.github.com/users/Vreyesm/gists{/gist_id}","starred_url":"https://api.github.com/users/Vreyesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vreyesm/subscriptions","organizations_url":"https://api.github.com/users/Vreyesm/orgs","repos_url":"https://api.github.com/users/Vreyesm/repos","events_url":"https://api.github.com/users/Vreyesm/events{/privacy}","received_events_url":"https://api.github.com/users/Vreyesm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Taller-2018-1/core/pulls/112/commits","review_comments_url":"https://api.github.com/repos/Taller-2018-1/core/pulls/112/comments","review_comment_url":"https://api.github.com/repos/Taller-2018-1/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Taller-2018-1/core/issues/112/comments","statuses_url":"https://api.github.com/repos/Taller-2018-1/core/statuses/cfb3f5b82edf7681ab7d8b93e54610124cfc10c6","head":{"label":"Taller-2018-1:Fix/RoleLoad","ref":"Fix/RoleLoad","sha":"cfb3f5b82edf7681ab7d8b93e54610124cfc10c6","user":{"login":"Taller-2018-1","id":38169484,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTY5NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/38169484?v=4","gravatar_id":"","url":"https://api.github.com/users/Taller-2018-1","html_url":"https://github.com/Taller-2018-1","followers_url":"https://api.github.com/users/Taller-2018-1/followers","following_url":"https://api.github.com/users/Taller-2018-1/following{/other_user}","gists_url":"https://api.github.com/users/Taller-2018-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Taller-2018-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taller-2018-1/subscriptions","organizations_url":"https://api.github.com/users/Taller-2018-1/orgs","repos_url":"https://api.github.com/users/Taller-2018-1/repos","events_url":"https://api.github.com/users/Taller-2018-1/events{/privacy}","received_events_url":"https://api.github.com/users/Taller-2018-1/received_events","type":"Organization","site_admin":false},"repo":{"id":128579852,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg1Nzk4NTI=","name":"core","full_name":"Taller-2018-1/core","owner":{"login":"Taller-2018-1","id":38169484,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTY5NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/38169484?v=4","gravatar_id":"","url":"https://api.github.com/users/Taller-2018-1","html_url":"https://github.com/Taller-2018-1","followers_url":"https://api.github.com/users/Taller-2018-1/followers","following_url":"https://api.github.com/users/Taller-2018-1/following{/other_user}","gists_url":"https://api.github.com/users/Taller-2018-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Taller-2018-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taller-2018-1/subscriptions","organizations_url":"https://api.github.com/users/Taller-2018-1/orgs","repos_url":"https://api.github.com/users/Taller-2018-1/repos","events_url":"https://api.github.com/users/Taller-2018-1/events{/privacy}","received_events_url":"https://api.github.com/users/Taller-2018-1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Taller-2018-1/core","description":".NETCore + Angular2+ application","fork":false,"url":"https://api.github.com/repos/Taller-2018-1/core","forks_url":"https://api.github.com/repos/Taller-2018-1/core/forks","keys_url":"https://api.github.com/repos/Taller-2018-1/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taller-2018-1/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taller-2018-1/core/teams","hooks_url":"https://api.github.com/repos/Taller-2018-1/core/hooks","issue_events_url":"https://api.github.com/repos/Taller-2018-1/core/issues/events{/number}","events_url":"https://api.github.com/repos/Taller-2018-1/core/events","assignees_url":"https://api.github.com/repos/Taller-2018-1/core/assignees{/user}","branches_url":"https://api.github.com/repos/Taller-2018-1/core/branches{/branch}","tags_url":"https://api.github.com/repos/Taller-2018-1/core/tags","blobs_url":"https://api.github.com/repos/Taller-2018-1/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taller-2018-1/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taller-2018-1/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taller-2018-1/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taller-2018-1/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Taller-2018-1/core/languages","stargazers_url":"https://api.github.com/repos/Taller-2018-1/core/stargazers","contributors_url":"https://api.github.com/repos/Taller-2018-1/core/contributors","subscribers_url":"https://api.github.com/repos/Taller-2018-1/core/subscribers","subscription_url":"https://api.github.com/repos/Taller-2018-1/core/subscription","commits_url":"https://api.github.com/repos/Taller-2018-1/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taller-2018-1/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taller-2018-1/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taller-2018-1/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taller-2018-1/core/contents/{+path}","compare_url":"https://api.github.com/repos/Taller-2018-1/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taller-2018-1/core/merges","archive_url":"https://api.github.com/repos/Taller-2018-1/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taller-2018-1/core/downloads","issues_url":"https://api.github.com/repos/Taller-2018-1/core/issues{/number}","pulls_url":"https://api.github.com/repos/Taller-2018-1/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Taller-2018-1/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Taller-2018-1/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taller-2018-1/core/labels{/name}","releases_url":"https://api.github.com/repos/Taller-2018-1/core/releases{/id}","deployments_url":"https://api.github.com/repos/Taller-2018-1/core/deployments","created_at":"2018-04-08T00:21:34Z","updated_at":"2018-08-02T15:42:35Z","pushed_at":"2018-08-17T13:38:41Z","git_url":"git://github.com/Taller-2018-1/core.git","ssh_url":"git@github.com:Taller-2018-1/core.git","clone_url":"https://github.com/Taller-2018-1/core.git","svn_url":"https://github.com/Taller-2018-1/core","homepage":null,"size":3760,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Taller-2018-1:staging","ref":"staging","sha":"19591a2abae00a4ac38dfc1c609a6705f50fb3bd","user":{"login":"Taller-2018-1","id":38169484,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTY5NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/38169484?v=4","gravatar_id":"","url":"https://api.github.com/users/Taller-2018-1","html_url":"https://github.com/Taller-2018-1","followers_url":"https://api.github.com/users/Taller-2018-1/followers","following_url":"https://api.github.com/users/Taller-2018-1/following{/other_user}","gists_url":"https://api.github.com/users/Taller-2018-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Taller-2018-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taller-2018-1/subscriptions","organizations_url":"https://api.github.com/users/Taller-2018-1/orgs","repos_url":"https://api.github.com/users/Taller-2018-1/repos","events_url":"https://api.github.com/users/Taller-2018-1/events{/privacy}","received_events_url":"https://api.github.com/users/Taller-2018-1/received_events","type":"Organization","site_admin":false},"repo":{"id":128579852,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg1Nzk4NTI=","name":"core","full_name":"Taller-2018-1/core","owner":{"login":"Taller-2018-1","id":38169484,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTY5NDg0","avatar_url":"https://avatars0.githubusercontent.com/u/38169484?v=4","gravatar_id":"","url":"https://api.github.com/users/Taller-2018-1","html_url":"https://github.com/Taller-2018-1","followers_url":"https://api.github.com/users/Taller-2018-1/followers","following_url":"https://api.github.com/users/Taller-2018-1/following{/other_user}","gists_url":"https://api.github.com/users/Taller-2018-1/gists{/gist_id}","starred_url":"https://api.github.com/users/Taller-2018-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taller-2018-1/subscriptions","organizations_url":"https://api.github.com/users/Taller-2018-1/orgs","repos_url":"https://api.github.com/users/Taller-2018-1/repos","events_url":"https://api.github.com/users/Taller-2018-1/events{/privacy}","received_events_url":"https://api.github.com/users/Taller-2018-1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Taller-2018-1/core","description":".NETCore + Angular2+ application","fork":false,"url":"https://api.github.com/repos/Taller-2018-1/core","forks_url":"https://api.github.com/repos/Taller-2018-1/core/forks","keys_url":"https://api.github.com/repos/Taller-2018-1/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taller-2018-1/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taller-2018-1/core/teams","hooks_url":"https://api.github.com/repos/Taller-2018-1/core/hooks","issue_events_url":"https://api.github.com/repos/Taller-2018-1/core/issues/events{/number}","events_url":"https://api.github.com/repos/Taller-2018-1/core/events","assignees_url":"https://api.github.com/repos/Taller-2018-1/core/assignees{/user}","branches_url":"https://api.github.com/repos/Taller-2018-1/core/branches{/branch}","tags_url":"https://api.github.com/repos/Taller-2018-1/core/tags","blobs_url":"https://api.github.com/repos/Taller-2018-1/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taller-2018-1/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taller-2018-1/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taller-2018-1/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taller-2018-1/core/statuses/{sha}","languages_url":"https://api.github.com/repos/Taller-2018-1/core/languages","stargazers_url":"https://api.github.com/repos/Taller-2018-1/core/stargazers","contributors_url":"https://api.github.com/repos/Taller-2018-1/core/contributors","subscribers_url":"https://api.github.com/repos/Taller-2018-1/core/subscribers","subscription_url":"https://api.github.com/repos/Taller-2018-1/core/subscription","commits_url":"https://api.github.com/repos/Taller-2018-1/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taller-2018-1/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taller-2018-1/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taller-2018-1/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taller-2018-1/core/contents/{+path}","compare_url":"https://api.github.com/repos/Taller-2018-1/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taller-2018-1/core/merges","archive_url":"https://api.github.com/repos/Taller-2018-1/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taller-2018-1/core/downloads","issues_url":"https://api.github.com/repos/Taller-2018-1/core/issues{/number}","pulls_url":"https://api.github.com/repos/Taller-2018-1/core/pulls{/number}","milestones_url":"https://api.github.com/repos/Taller-2018-1/core/milestones{/number}","notifications_url":"https://api.github.com/repos/Taller-2018-1/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taller-2018-1/core/labels{/name}","releases_url":"https://api.github.com/repos/Taller-2018-1/core/releases{/id}","deployments_url":"https://api.github.com/repos/Taller-2018-1/core/deployments","created_at":"2018-04-08T00:21:34Z","updated_at":"2018-08-02T15:42:35Z","pushed_at":"2018-08-17T13:38:41Z","git_url":"git://github.com/Taller-2018-1/core.git","ssh_url":"git@github.com:Taller-2018-1/core.git","clone_url":"https://github.com/Taller-2018-1/core.git","svn_url":"https://github.com/Taller-2018-1/core","homepage":null,"size":3760,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Taller-2018-1/core/pulls/112"},"html":{"href":"https://github.com/Taller-2018-1/core/pull/112"},"issue":{"href":"https://api.github.com/repos/Taller-2018-1/core/issues/112"},"comments":{"href":"https://api.github.com/repos/Taller-2018-1/core/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/Taller-2018-1/core/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/Taller-2018-1/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Taller-2018-1/core/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/Taller-2018-1/core/statuses/cfb3f5b82edf7681ab7d8b93e54610124cfc10c6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Alisboa13","id":38052151,"node_id":"MDQ6VXNlcjM4MDUyMTUx","avatar_url":"https://avatars0.githubusercontent.com/u/38052151?v=4","gravatar_id":"","url":"https://api.github.com/users/Alisboa13","html_url":"https://github.com/Alisboa13","followers_url":"https://api.github.com/users/Alisboa13/followers","following_url":"https://api.github.com/users/Alisboa13/following{/other_user}","gists_url":"https://api.github.com/users/Alisboa13/gists{/gist_id}","starred_url":"https://api.github.com/users/Alisboa13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alisboa13/subscriptions","organizations_url":"https://api.github.com/users/Alisboa13/orgs","repos_url":"https://api.github.com/users/Alisboa13/repos","events_url":"https://api.github.com/users/Alisboa13/events{/privacy}","received_events_url":"https://api.github.com/users/Alisboa13/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":181,"deletions":113,"changed_files":14}}
{"actor":{"display_login":"Alisboa13"}}