{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/185375772","pull_request_review_id":116750571,"id":185375772,"diff_hunk":"@@ -1195,38 +1299,88 @@ private void build() {\n         return ret;\n     }\n \n+    private void checkIfAttributes(Map<String, JobVariable> ret, Node variableNode, NamedNodeMap attrs) {\n+        if (attrs != null && variableNode.hasAttributes()) {\n+            String name = extractNodeValue(attrs, KEY_OF_NAME);\n+            String value = extractNodeValue(attrs, KEY_OF_VALUE);\n+            String model = extractNodeValue(attrs, KEY_OF_MODEL);\n+            createJobVariable(ret, name, value, model);\n+        }\n+    }\n+\n+    private void createJobVariable(Map<String, JobVariable> ret, String name, String value, String model) {\n+        if (name != null && value != null) {\n+            if (name.matches(\"[A-Za-z0-9._]+\")) {","path":"scheduler-portal/src/main/java/org/ow2/proactive_grid_cloud_portal/scheduler/client/SubmitWindow.java","position":624,"original_position":624,"commit_id":"893c6ff6fa0d3a47cf88aa384650704584ad2957","original_commit_id":"893c6ff6fa0d3a47cf88aa384650704584ad2957","user":{"login":"sonarqube-activeeon","id":14940028,"avatar_url":"https://avatars1.githubusercontent.com/u/14940028?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Merge this if statement with the enclosing one. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1066)\n","created_at":"2018-05-02T01:32:00Z","updated_at":"2018-05-02T01:32:00Z","html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/440#discussion_r185375772","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/185375772"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/440#discussion_r185375772"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440","id":181780873,"html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/440","diff_url":"https://github.com/ow2-proactive/scheduling-portal/pull/440.diff","patch_url":"https://github.com/ow2-proactive/scheduling-portal/pull/440.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/440","number":440,"state":"open","locked":false,"title":"Retrieve icon - Documentation link and bucket name information","user":{"login":"cdiop","id":13251306,"avatar_url":"https://avatars3.githubusercontent.com/u/13251306?v=4","gravatar_id":"","url":"https://api.github.com/users/cdiop","html_url":"https://github.com/cdiop","followers_url":"https://api.github.com/users/cdiop/followers","following_url":"https://api.github.com/users/cdiop/following{/other_user}","gists_url":"https://api.github.com/users/cdiop/gists{/gist_id}","starred_url":"https://api.github.com/users/cdiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdiop/subscriptions","organizations_url":"https://api.github.com/users/cdiop/orgs","repos_url":"https://api.github.com/users/cdiop/repos","events_url":"https://api.github.com/users/cdiop/events{/privacy}","received_events_url":"https://api.github.com/users/cdiop/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-16T08:03:46Z","updated_at":"2018-05-02T01:32:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1790e73210f644c076f442a6751d44b4ebef1490","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/440/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/893c6ff6fa0d3a47cf88aa384650704584ad2957","head":{"label":"ow2-proactive:submitForm","ref":"submitForm","sha":"893c6ff6fa0d3a47cf88aa384650704584ad2957","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725080,"name":"scheduling-portal","full_name":"ow2-proactive/scheduling-portal","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling-portal","description":null,"fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-04-27T15:06:12Z","pushed_at":"2018-05-02T01:21:27Z","git_url":"git://github.com/ow2-proactive/scheduling-portal.git","ssh_url":"git@github.com:ow2-proactive/scheduling-portal.git","clone_url":"https://github.com/ow2-proactive/scheduling-portal.git","svn_url":"https://github.com/ow2-proactive/scheduling-portal","homepage":"http://try.activeeon.com","size":118931,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":29,"open_issues":59,"watchers":3,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"20c4cbc82a952812d3c08bbb5f844c4623fce34a","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725080,"name":"scheduling-portal","full_name":"ow2-proactive/scheduling-portal","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling-portal","description":null,"fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-04-27T15:06:12Z","pushed_at":"2018-05-02T01:21:27Z","git_url":"git://github.com/ow2-proactive/scheduling-portal.git","ssh_url":"git@github.com:ow2-proactive/scheduling-portal.git","clone_url":"https://github.com/ow2-proactive/scheduling-portal.git","svn_url":"https://github.com/ow2-proactive/scheduling-portal","homepage":"http://try.activeeon.com","size":118931,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":29,"open_issues":59,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/440"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/440"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/440/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/440/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/893c6ff6fa0d3a47cf88aa384650704584ad2957"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sonarqube-activeeon"}}