{"action":"created","issue":{"url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/220","repository_url":"https://api.github.com/repos/DataBiosphere/job-manager","labels_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/220/comments","events_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/220/events","html_url":"https://github.com/DataBiosphere/job-manager/pull/220","id":299483338,"number":220,"title":"Remove job list header on details page","user":{"login":"dmohs","id":1545444,"avatar_url":"https://avatars2.githubusercontent.com/u/1545444?v=4","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T19:45:15Z","updated_at":"2018-02-22T20:44:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DataBiosphere/job-manager/pulls/220","html_url":"https://github.com/DataBiosphere/job-manager/pull/220","diff_url":"https://github.com/DataBiosphere/job-manager/pull/220.diff","patch_url":"https://github.com/DataBiosphere/job-manager/pull/220.patch"},"body":"This is my proposed solution to https://elastc.com/c/4pbVV8SQ/216-filter-bar-appears-on-job-details-page.\r\n\r\nLooking at the header component, my judgement is that it isn't so much a general header as a job list header, and so does not belong on the job details page. If that is true, I'd suggest a follow-up PR to rename as such. I think it would be appropriate to create a separate header for the job details page if/when that seems like a good idea (e.g., to add a link back to the jobs list)."},"comment":{"url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/comments/367816040","html_url":"https://github.com/DataBiosphere/job-manager/pull/220#issuecomment-367816040","issue_url":"https://api.github.com/repos/DataBiosphere/job-manager/issues/220","id":367816040,"user":{"login":"calbach","id":822298,"avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T20:44:46Z","updated_at":"2018-02-22T20:44:46Z","author_association":"CONTRIBUTOR","body":"Agree with your judgement in the PR description - composing the query builder into different headers (if needed) would be cleaner.\r\n\r\nRE: actual proposed change, I'm a bit on the fence. I'm +.5 on dropping the query builder from the details view, but -1 from losing our only breadcrumb back to the query page. If we do this I think ideally we'd replace this with a back button. If others are currently complaining about the pop-up query builder issue, then I'm +1 to going ahead with this as-is (for a net of +.5); were you able to reproduce this?\r\n\r\nFor more context, the current guidance from Marty w.r.t. the query builder being shown on the details page is as follows:\r\n\r\n  - On the details page, add another chip e.g. job-id which scopes it to a particular job; the query builder is now in a reasonable looking state on this page (albeit slightly confusing, since had you formed that query on your own - we'd need to decide which page you're going to land on and what the logic would be)\r\n  - If the above introduces too many issues, remove the query builder from the details page entirely"}}
{"actor":{"display_login":"calbach"}}