{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/comments/186445128","pull_request_review_id":118023184,"id":186445128,"diff_hunk":"@@ -134,8 +134,8 @@ def get_target_class_from_url(url, marker=False):\n     kwargs = {}\n     if issubclass(target_class, HdfsTarget) and url.endswith('/'):\n         kwargs['format'] = hdfs_format.PlainDir\n-    if issubclass(target_class, luigi.LocalTarget) or parsed_url.scheme == 'hdfs':\n-        # LocalTarget and HdfsTarget both expect paths without any scheme, netloc etc, just bare paths. So strip","path":"edx/analytics/tasks/util/url.py","position":5,"original_position":5,"commit_id":"83331b696760636bc522ba2bde0d60444d3fde23","original_commit_id":"83331b696760636bc522ba2bde0d60444d3fde23","user":{"login":"rao-abdul-mannan","id":8604174,"avatar_url":"https://avatars3.githubusercontent.com/u/8604174?v=4","gravatar_id":"","url":"https://api.github.com/users/rao-abdul-mannan","html_url":"https://github.com/rao-abdul-mannan","followers_url":"https://api.github.com/users/rao-abdul-mannan/followers","following_url":"https://api.github.com/users/rao-abdul-mannan/following{/other_user}","gists_url":"https://api.github.com/users/rao-abdul-mannan/gists{/gist_id}","starred_url":"https://api.github.com/users/rao-abdul-mannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rao-abdul-mannan/subscriptions","organizations_url":"https://api.github.com/users/rao-abdul-mannan/orgs","repos_url":"https://api.github.com/users/rao-abdul-mannan/repos","events_url":"https://api.github.com/users/rao-abdul-mannan/events{/privacy}","received_events_url":"https://api.github.com/users/rao-abdul-mannan/received_events","type":"User","site_admin":false},"body":"@brianhw I ran acceptance tests in docker devstack ( full suite ) and only few ( related to hadoop & hive ) in vagrant devstack and both worked perfectly fine. Just curious about what forced DE to place that check for hdfs targets?","created_at":"2018-05-07T14:44:02Z","updated_at":"2018-05-07T14:44:03Z","html_url":"https://github.com/edx/edx-analytics-pipeline/pull/499#discussion_r186445128","pull_request_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/comments/186445128"},"html":{"href":"https://github.com/edx/edx-analytics-pipeline/pull/499#discussion_r186445128"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499","id":185632775,"html_url":"https://github.com/edx/edx-analytics-pipeline/pull/499","diff_url":"https://github.com/edx/edx-analytics-pipeline/pull/499.diff","patch_url":"https://github.com/edx/edx-analytics-pipeline/pull/499.patch","issue_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/499","number":499,"state":"open","locked":false,"title":"add support for docker devstack","user":{"login":"rao-abdul-mannan","id":8604174,"avatar_url":"https://avatars3.githubusercontent.com/u/8604174?v=4","gravatar_id":"","url":"https://api.github.com/users/rao-abdul-mannan","html_url":"https://github.com/rao-abdul-mannan","followers_url":"https://api.github.com/users/rao-abdul-mannan/followers","following_url":"https://api.github.com/users/rao-abdul-mannan/following{/other_user}","gists_url":"https://api.github.com/users/rao-abdul-mannan/gists{/gist_id}","starred_url":"https://api.github.com/users/rao-abdul-mannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rao-abdul-mannan/subscriptions","organizations_url":"https://api.github.com/users/rao-abdul-mannan/orgs","repos_url":"https://api.github.com/users/rao-abdul-mannan/repos","events_url":"https://api.github.com/users/rao-abdul-mannan/events{/privacy}","received_events_url":"https://api.github.com/users/rao-abdul-mannan/received_events","type":"User","site_admin":false},"body":"Support for docker devstack & also allow running acceptance tests with it.\r\nFollow instructions on [Devstack PR](https://github.com/edx/devstack/pull/298) for docker devstack installation.\r\n\r\nReference [PR-490](https://github.com/edx/edx-analytics-pipeline/pull/490)","created_at":"2018-05-03T07:14:49Z","updated_at":"2018-05-07T14:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a115cf1085f8f01c5129339bf13f952dc3a1be4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"macdiesel","id":67862,"avatar_url":"https://avatars3.githubusercontent.com/u/67862?v=4","gravatar_id":"","url":"https://api.github.com/users/macdiesel","html_url":"https://github.com/macdiesel","followers_url":"https://api.github.com/users/macdiesel/followers","following_url":"https://api.github.com/users/macdiesel/following{/other_user}","gists_url":"https://api.github.com/users/macdiesel/gists{/gist_id}","starred_url":"https://api.github.com/users/macdiesel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macdiesel/subscriptions","organizations_url":"https://api.github.com/users/macdiesel/orgs","repos_url":"https://api.github.com/users/macdiesel/repos","events_url":"https://api.github.com/users/macdiesel/events{/privacy}","received_events_url":"https://api.github.com/users/macdiesel/received_events","type":"User","site_admin":false},{"login":"azafty468","id":2340843,"avatar_url":"https://avatars0.githubusercontent.com/u/2340843?v=4","gravatar_id":"","url":"https://api.github.com/users/azafty468","html_url":"https://github.com/azafty468","followers_url":"https://api.github.com/users/azafty468/followers","following_url":"https://api.github.com/users/azafty468/following{/other_user}","gists_url":"https://api.github.com/users/azafty468/gists{/gist_id}","starred_url":"https://api.github.com/users/azafty468/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azafty468/subscriptions","organizations_url":"https://api.github.com/users/azafty468/orgs","repos_url":"https://api.github.com/users/azafty468/repos","events_url":"https://api.github.com/users/azafty468/events{/privacy}","received_events_url":"https://api.github.com/users/azafty468/received_events","type":"User","site_admin":false},{"login":"HassanJaveed84","id":5018044,"avatar_url":"https://avatars1.githubusercontent.com/u/5018044?v=4","gravatar_id":"","url":"https://api.github.com/users/HassanJaveed84","html_url":"https://github.com/HassanJaveed84","followers_url":"https://api.github.com/users/HassanJaveed84/followers","following_url":"https://api.github.com/users/HassanJaveed84/following{/other_user}","gists_url":"https://api.github.com/users/HassanJaveed84/gists{/gist_id}","starred_url":"https://api.github.com/users/HassanJaveed84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HassanJaveed84/subscriptions","organizations_url":"https://api.github.com/users/HassanJaveed84/orgs","repos_url":"https://api.github.com/users/HassanJaveed84/repos","events_url":"https://api.github.com/users/HassanJaveed84/events{/privacy}","received_events_url":"https://api.github.com/users/HassanJaveed84/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499/commits","review_comments_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499/comments","review_comment_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/499/comments","statuses_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/statuses/83331b696760636bc522ba2bde0d60444d3fde23","head":{"label":"edx:amannan/dockerize-analytics-pipeline","ref":"amannan/dockerize-analytics-pipeline","sha":"83331b696760636bc522ba2bde0d60444d3fde23","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":22929261,"name":"edx-analytics-pipeline","full_name":"edx/edx-analytics-pipeline","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-analytics-pipeline","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-analytics-pipeline","forks_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/forks","keys_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/teams","hooks_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/events","assignees_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/tags","blobs_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/languages","stargazers_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/subscription","commits_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/merges","archive_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/downloads","issues_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/deployments","created_at":"2014-08-13T19:57:17Z","updated_at":"2018-04-27T09:43:07Z","pushed_at":"2018-05-07T14:15:55Z","git_url":"git://github.com/edx/edx-analytics-pipeline.git","ssh_url":"git@github.com:edx/edx-analytics-pipeline.git","clone_url":"https://github.com/edx/edx-analytics-pipeline.git","svn_url":"https://github.com/edx/edx-analytics-pipeline","homepage":null,"size":5220,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":85,"open_issues":15,"watchers":52,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"f3b00385b28fbf325d18fc8edd1c0aa50cbd397f","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":22929261,"name":"edx-analytics-pipeline","full_name":"edx/edx-analytics-pipeline","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-analytics-pipeline","description":null,"fork":false,"url":"https://api.github.com/repos/edx/edx-analytics-pipeline","forks_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/forks","keys_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/teams","hooks_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/events","assignees_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/tags","blobs_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/languages","stargazers_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/subscription","commits_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/merges","archive_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/downloads","issues_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-analytics-pipeline/deployments","created_at":"2014-08-13T19:57:17Z","updated_at":"2018-04-27T09:43:07Z","pushed_at":"2018-05-07T14:15:55Z","git_url":"git://github.com/edx/edx-analytics-pipeline.git","ssh_url":"git@github.com:edx/edx-analytics-pipeline.git","clone_url":"https://github.com/edx/edx-analytics-pipeline.git","svn_url":"https://github.com/edx/edx-analytics-pipeline","homepage":null,"size":5220,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":85,"open_issues":15,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499"},"html":{"href":"https://github.com/edx/edx-analytics-pipeline/pull/499"},"issue":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/499"},"comments":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-analytics-pipeline/statuses/83331b696760636bc522ba2bde0d60444d3fde23"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rao-abdul-mannan"}}