{"action":"created","comment":{"url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/comments/183206325","pull_request_review_id":114169006,"id":183206325,"diff_hunk":"@@ -18,10 +18,16 @@\n  * \\b 1.9.0\n  *\n  * 1.9.0 is not yet released. The following changes are not set in stone yet.\n+ * \\li GSClientList","path":"src/script/api/game_changelog.hpp","position":4,"original_position":4,"commit_id":"d2a540d06407c1d88748603aa63a1f7d2ded18a8","original_commit_id":"d2a540d06407c1d88748603aa63a1f7d2ded18a8","user":{"login":"frosch123","id":23150643,"avatar_url":"https://avatars3.githubusercontent.com/u/23150643?v=4","gravatar_id":"","url":"https://api.github.com/users/frosch123","html_url":"https://github.com/frosch123","followers_url":"https://api.github.com/users/frosch123/followers","following_url":"https://api.github.com/users/frosch123/following{/other_user}","gists_url":"https://api.github.com/users/frosch123/gists{/gist_id}","starred_url":"https://api.github.com/users/frosch123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frosch123/subscriptions","organizations_url":"https://api.github.com/users/frosch123/orgs","repos_url":"https://api.github.com/users/frosch123/repos","events_url":"https://api.github.com/users/frosch123/events{/privacy}","received_events_url":"https://api.github.com/users/frosch123/received_events","type":"User","site_admin":false},"body":"When touching this, I guess when adding new classes we also only mention the class, instead of listing individual methods.","created_at":"2018-04-21T10:12:19Z","updated_at":"2018-04-21T10:12:19Z","html_url":"https://github.com/OpenTTD/OpenTTD/pull/6736#discussion_r183206325","pull_request_url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/comments/183206325"},"html":{"href":"https://github.com/OpenTTD/OpenTTD/pull/6736#discussion_r183206325"},"pull_request":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736"}},"in_reply_to_id":183206256},"pull_request":{"url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736","id":182286545,"html_url":"https://github.com/OpenTTD/OpenTTD/pull/6736","diff_url":"https://github.com/OpenTTD/OpenTTD/pull/6736.diff","patch_url":"https://github.com/OpenTTD/OpenTTD/pull/6736.patch","issue_url":"https://api.github.com/repos/OpenTTD/OpenTTD/issues/6736","number":6736,"state":"open","locked":false,"title":"API for querying network clients from GS","user":{"login":"ldpl","id":413570,"avatar_url":"https://avatars2.githubusercontent.com/u/413570?v=4","gravatar_id":"","url":"https://api.github.com/users/ldpl","html_url":"https://github.com/ldpl","followers_url":"https://api.github.com/users/ldpl/followers","following_url":"https://api.github.com/users/ldpl/following{/other_user}","gists_url":"https://api.github.com/users/ldpl/gists{/gist_id}","starred_url":"https://api.github.com/users/ldpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldpl/subscriptions","organizations_url":"https://api.github.com/users/ldpl/orgs","repos_url":"https://api.github.com/users/ldpl/repos","events_url":"https://api.github.com/users/ldpl/events{/privacy}","received_events_url":"https://api.github.com/users/ldpl/received_events","type":"User","site_admin":false},"body":"PR for #6459 \r\n\r\nAdds GSClient namespace with ResolveClientID, GetName, GetCompany, GetJoinedDate\r\nAlso GSClientList, GSClientList_Company\r\n\r\nProbably doesn't have much use on its own, but is a necessary prerequisite to allow methods that work with clients. Two obvious patches that I'll do once it's settled are:\r\n- Method to send messages to a single client (similar to GSGoal.Question)\r\n- Method to scroll client's viewport (like #6422)\r\n\r\nSimple testing GS(updated version) that prints this client info to GS log:\r\n[testclients.tar.gz](https://github.com/OpenTTD/OpenTTD/files/1921453/testclients.tar.gz)\r\n\r\n\r\n\r\n","created_at":"2018-04-17T20:28:33Z","updated_at":"2018-04-21T10:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a2f701db02bfa1c41eacc3997863415b88da3f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736/commits","review_comments_url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736/comments","review_comment_url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenTTD/OpenTTD/issues/6736/comments","statuses_url":"https://api.github.com/repos/OpenTTD/OpenTTD/statuses/d2a540d06407c1d88748603aa63a1f7d2ded18a8","head":{"label":"ldpl:gs/clients_api","ref":"gs/clients_api","sha":"d2a540d06407c1d88748603aa63a1f7d2ded18a8","user":{"login":"ldpl","id":413570,"avatar_url":"https://avatars2.githubusercontent.com/u/413570?v=4","gravatar_id":"","url":"https://api.github.com/users/ldpl","html_url":"https://github.com/ldpl","followers_url":"https://api.github.com/users/ldpl/followers","following_url":"https://api.github.com/users/ldpl/following{/other_user}","gists_url":"https://api.github.com/users/ldpl/gists{/gist_id}","starred_url":"https://api.github.com/users/ldpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldpl/subscriptions","organizations_url":"https://api.github.com/users/ldpl/orgs","repos_url":"https://api.github.com/users/ldpl/repos","events_url":"https://api.github.com/users/ldpl/events{/privacy}","received_events_url":"https://api.github.com/users/ldpl/received_events","type":"User","site_admin":false},"repo":{"id":129620268,"name":"OpenTTD","full_name":"ldpl/OpenTTD","owner":{"login":"ldpl","id":413570,"avatar_url":"https://avatars2.githubusercontent.com/u/413570?v=4","gravatar_id":"","url":"https://api.github.com/users/ldpl","html_url":"https://github.com/ldpl","followers_url":"https://api.github.com/users/ldpl/followers","following_url":"https://api.github.com/users/ldpl/following{/other_user}","gists_url":"https://api.github.com/users/ldpl/gists{/gist_id}","starred_url":"https://api.github.com/users/ldpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldpl/subscriptions","organizations_url":"https://api.github.com/users/ldpl/orgs","repos_url":"https://api.github.com/users/ldpl/repos","events_url":"https://api.github.com/users/ldpl/events{/privacy}","received_events_url":"https://api.github.com/users/ldpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldpl/OpenTTD","description":"OpenTTD is an open source simulation game based upon Transport Tycoon Deluxe","fork":true,"url":"https://api.github.com/repos/ldpl/OpenTTD","forks_url":"https://api.github.com/repos/ldpl/OpenTTD/forks","keys_url":"https://api.github.com/repos/ldpl/OpenTTD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldpl/OpenTTD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldpl/OpenTTD/teams","hooks_url":"https://api.github.com/repos/ldpl/OpenTTD/hooks","issue_events_url":"https://api.github.com/repos/ldpl/OpenTTD/issues/events{/number}","events_url":"https://api.github.com/repos/ldpl/OpenTTD/events","assignees_url":"https://api.github.com/repos/ldpl/OpenTTD/assignees{/user}","branches_url":"https://api.github.com/repos/ldpl/OpenTTD/branches{/branch}","tags_url":"https://api.github.com/repos/ldpl/OpenTTD/tags","blobs_url":"https://api.github.com/repos/ldpl/OpenTTD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldpl/OpenTTD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldpl/OpenTTD/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldpl/OpenTTD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldpl/OpenTTD/statuses/{sha}","languages_url":"https://api.github.com/repos/ldpl/OpenTTD/languages","stargazers_url":"https://api.github.com/repos/ldpl/OpenTTD/stargazers","contributors_url":"https://api.github.com/repos/ldpl/OpenTTD/contributors","subscribers_url":"https://api.github.com/repos/ldpl/OpenTTD/subscribers","subscription_url":"https://api.github.com/repos/ldpl/OpenTTD/subscription","commits_url":"https://api.github.com/repos/ldpl/OpenTTD/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldpl/OpenTTD/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldpl/OpenTTD/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldpl/OpenTTD/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldpl/OpenTTD/contents/{+path}","compare_url":"https://api.github.com/repos/ldpl/OpenTTD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldpl/OpenTTD/merges","archive_url":"https://api.github.com/repos/ldpl/OpenTTD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldpl/OpenTTD/downloads","issues_url":"https://api.github.com/repos/ldpl/OpenTTD/issues{/number}","pulls_url":"https://api.github.com/repos/ldpl/OpenTTD/pulls{/number}","milestones_url":"https://api.github.com/repos/ldpl/OpenTTD/milestones{/number}","notifications_url":"https://api.github.com/repos/ldpl/OpenTTD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldpl/OpenTTD/labels{/name}","releases_url":"https://api.github.com/repos/ldpl/OpenTTD/releases{/id}","deployments_url":"https://api.github.com/repos/ldpl/OpenTTD/deployments","created_at":"2018-04-15T14:51:59Z","updated_at":"2018-04-15T14:52:07Z","pushed_at":"2018-04-19T17:12:57Z","git_url":"git://github.com/ldpl/OpenTTD.git","ssh_url":"git@github.com:ldpl/OpenTTD.git","clone_url":"https://github.com/ldpl/OpenTTD.git","svn_url":"https://github.com/ldpl/OpenTTD","homepage":"https://www.openttd.org/","size":100261,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenTTD:master","ref":"master","sha":"9175c349dac23cb236aa981e93bac28a4857c19e","user":{"login":"OpenTTD","id":5037546,"avatar_url":"https://avatars0.githubusercontent.com/u/5037546?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenTTD","html_url":"https://github.com/OpenTTD","followers_url":"https://api.github.com/users/OpenTTD/followers","following_url":"https://api.github.com/users/OpenTTD/following{/other_user}","gists_url":"https://api.github.com/users/OpenTTD/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenTTD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenTTD/subscriptions","organizations_url":"https://api.github.com/users/OpenTTD/orgs","repos_url":"https://api.github.com/users/OpenTTD/repos","events_url":"https://api.github.com/users/OpenTTD/events{/privacy}","received_events_url":"https://api.github.com/users/OpenTTD/received_events","type":"Organization","site_admin":false},"repo":{"id":128430621,"name":"OpenTTD","full_name":"OpenTTD/OpenTTD","owner":{"login":"OpenTTD","id":5037546,"avatar_url":"https://avatars0.githubusercontent.com/u/5037546?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenTTD","html_url":"https://github.com/OpenTTD","followers_url":"https://api.github.com/users/OpenTTD/followers","following_url":"https://api.github.com/users/OpenTTD/following{/other_user}","gists_url":"https://api.github.com/users/OpenTTD/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenTTD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenTTD/subscriptions","organizations_url":"https://api.github.com/users/OpenTTD/orgs","repos_url":"https://api.github.com/users/OpenTTD/repos","events_url":"https://api.github.com/users/OpenTTD/events{/privacy}","received_events_url":"https://api.github.com/users/OpenTTD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenTTD/OpenTTD","description":"OpenTTD is an open source simulation game based upon Transport Tycoon Deluxe","fork":false,"url":"https://api.github.com/repos/OpenTTD/OpenTTD","forks_url":"https://api.github.com/repos/OpenTTD/OpenTTD/forks","keys_url":"https://api.github.com/repos/OpenTTD/OpenTTD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenTTD/OpenTTD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenTTD/OpenTTD/teams","hooks_url":"https://api.github.com/repos/OpenTTD/OpenTTD/hooks","issue_events_url":"https://api.github.com/repos/OpenTTD/OpenTTD/issues/events{/number}","events_url":"https://api.github.com/repos/OpenTTD/OpenTTD/events","assignees_url":"https://api.github.com/repos/OpenTTD/OpenTTD/assignees{/user}","branches_url":"https://api.github.com/repos/OpenTTD/OpenTTD/branches{/branch}","tags_url":"https://api.github.com/repos/OpenTTD/OpenTTD/tags","blobs_url":"https://api.github.com/repos/OpenTTD/OpenTTD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenTTD/OpenTTD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenTTD/OpenTTD/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenTTD/OpenTTD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenTTD/OpenTTD/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenTTD/OpenTTD/languages","stargazers_url":"https://api.github.com/repos/OpenTTD/OpenTTD/stargazers","contributors_url":"https://api.github.com/repos/OpenTTD/OpenTTD/contributors","subscribers_url":"https://api.github.com/repos/OpenTTD/OpenTTD/subscribers","subscription_url":"https://api.github.com/repos/OpenTTD/OpenTTD/subscription","commits_url":"https://api.github.com/repos/OpenTTD/OpenTTD/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenTTD/OpenTTD/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenTTD/OpenTTD/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenTTD/OpenTTD/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenTTD/OpenTTD/contents/{+path}","compare_url":"https://api.github.com/repos/OpenTTD/OpenTTD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenTTD/OpenTTD/merges","archive_url":"https://api.github.com/repos/OpenTTD/OpenTTD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenTTD/OpenTTD/downloads","issues_url":"https://api.github.com/repos/OpenTTD/OpenTTD/issues{/number}","pulls_url":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenTTD/OpenTTD/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenTTD/OpenTTD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenTTD/OpenTTD/labels{/name}","releases_url":"https://api.github.com/repos/OpenTTD/OpenTTD/releases{/id}","deployments_url":"https://api.github.com/repos/OpenTTD/OpenTTD/deployments","created_at":"2018-04-06T18:06:22Z","updated_at":"2018-04-21T09:05:41Z","pushed_at":"2018-04-21T09:05:39Z","git_url":"git://github.com/OpenTTD/OpenTTD.git","ssh_url":"git@github.com:OpenTTD/OpenTTD.git","clone_url":"https://github.com/OpenTTD/OpenTTD.git","svn_url":"https://github.com/OpenTTD/OpenTTD","homepage":"https://www.openttd.org/","size":100258,"stargazers_count":119,"watchers_count":119,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":235,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":28,"open_issues":235,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736"},"html":{"href":"https://github.com/OpenTTD/OpenTTD/pull/6736"},"issue":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/issues/6736"},"comments":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/issues/6736/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/pulls/6736/commits"},"statuses":{"href":"https://api.github.com/repos/OpenTTD/OpenTTD/statuses/d2a540d06407c1d88748603aa63a1f7d2ded18a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"frosch123"}}