{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1089","repository_url":"https://api.github.com/repos/tensorflow/tfjs-core","labels_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1089/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1089/comments","events_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1089/events","html_url":"https://github.com/tensorflow/tfjs-core/pull/1089","id":330396103,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDE3Mjg2","number":1089,"title":"Inference model","user":{"login":"pyu10055","id":4018,"node_id":"MDQ6VXNlcjQwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4018?v=4","gravatar_id":"","url":"https://api.github.com/users/pyu10055","html_url":"https://github.com/pyu10055","followers_url":"https://api.github.com/users/pyu10055/followers","following_url":"https://api.github.com/users/pyu10055/following{/other_user}","gists_url":"https://api.github.com/users/pyu10055/gists{/gist_id}","starred_url":"https://api.github.com/users/pyu10055/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyu10055/subscriptions","organizations_url":"https://api.github.com/users/pyu10055/orgs","repos_url":"https://api.github.com/users/pyu10055/repos","events_url":"https://api.github.com/users/pyu10055/events{/privacy}","received_events_url":"https://api.github.com/users/pyu10055/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-07T19:00:28Z","updated_at":"2018-06-09T23:38:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/pulls/1089","html_url":"https://github.com/tensorflow/tfjs-core/pull/1089","diff_url":"https://github.com/tensorflow/tfjs-core/pull/1089.diff","patch_url":"https://github.com/tensorflow/tfjs-core/pull/1089.patch"},"body":"add input/output info to the inference model interface.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tensorflow/tfjs-core/1089)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/comments/396006408","html_url":"https://github.com/tensorflow/tfjs-core/pull/1089#issuecomment-396006408","issue_url":"https://api.github.com/repos/tensorflow/tfjs-core/issues/1089","id":396006408,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjAwNjQwOA==","user":{"login":"pyu10055","id":4018,"node_id":"MDQ6VXNlcjQwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4018?v=4","gravatar_id":"","url":"https://api.github.com/users/pyu10055","html_url":"https://github.com/pyu10055","followers_url":"https://api.github.com/users/pyu10055/followers","following_url":"https://api.github.com/users/pyu10055/following{/other_user}","gists_url":"https://api.github.com/users/pyu10055/gists{/gist_id}","starred_url":"https://api.github.com/users/pyu10055/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyu10055/subscriptions","organizations_url":"https://api.github.com/users/pyu10055/orgs","repos_url":"https://api.github.com/users/pyu10055/repos","events_url":"https://api.github.com/users/pyu10055/events{/privacy}","received_events_url":"https://api.github.com/users/pyu10055/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T23:38:20Z","updated_at":"2018-06-09T23:38:20Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[src/types.ts, line 151 at r1](https://reviewable.io/reviews/tensorflow/tfjs-core/1089#-LESAUxWAq8vfkSCqlm-:-LEau2xmDP8E3h6yzkQm:b-896fix) ([raw file](https://github.com/tensorflow/tfjs-core/blob/996810db6c76bb26a6552fc0d99d29138359e135/src/types.ts#L151)):*\n<details><summary><i>Previously, caisq (Shanqing Cai) wrote…</i></summary><blockquote>\n\n> ```\n> // ten\n> ```\n\nNit.  Capitalize first letter to be consistent with above. Same below.\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/types.ts, line 152 at r1](https://reviewable.io/reviews/tensorflow/tfjs-core/1089#-LESAZr165BrZFXNsGkR:-LEau3T8D7ymdzRK6Gcu:b-i70d6q) ([raw file](https://github.com/tensorflow/tfjs-core/blob/996810db6c76bb26a6552fc0d99d29138359e135/src/types.ts#L152)):*\n<details><summary><i>Previously, caisq (Shanqing Cai) wrote…</i></summary><blockquote>\n\n> ```\n> shape?:\n> ```\n\nWhy is shape optional? Under what circumstance can shape be missing? Why is dtype not optional?\n</blockquote></details>\n\nWhen the shape information is not set, it means it can take any shape of tensor. Take a look at https://www.tensorflow.org/api_docs/python/tf/placeholder\n\n---\n\n*[src/types.ts, line 153 at r1](https://reviewable.io/reviews/tensorflow/tfjs-core/1089#-LESAhmHEf5xoOdroyeY:-LEauY6-Ab2tPl9meQSQ:b-896fix) ([raw file](https://github.com/tensorflow/tfjs-core/blob/996810db6c76bb26a6552fc0d99d29138359e135/src/types.ts#L153)):*\n<details><summary><i>Previously, caisq (Shanqing Cai) wrote…</i></summary><blockquote>\n\n> ```\n>  data type\n> ```\n\nNit: end with a period.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/tensorflow/tfjs-core/1089)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"pyu10055"}}