{"action":"created","issue":{"url":"https://api.github.com/repos/bakerstu/openmrn/issues/186","repository_url":"https://api.github.com/repos/bakerstu/openmrn","labels_url":"https://api.github.com/repos/bakerstu/openmrn/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/bakerstu/openmrn/issues/186/comments","events_url":"https://api.github.com/repos/bakerstu/openmrn/issues/186/events","html_url":"https://github.com/bakerstu/openmrn/pull/186","id":394267881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDU1OTYy","number":186,"title":"Add servo min/max rotation options to nucleo_io CDI.","user":{"login":"szabodabo","id":1310902,"node_id":"MDQ6VXNlcjEzMTA5MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1310902?v=4","gravatar_id":"","url":"https://api.github.com/users/szabodabo","html_url":"https://github.com/szabodabo","followers_url":"https://api.github.com/users/szabodabo/followers","following_url":"https://api.github.com/users/szabodabo/following{/other_user}","gists_url":"https://api.github.com/users/szabodabo/gists{/gist_id}","starred_url":"https://api.github.com/users/szabodabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szabodabo/subscriptions","organizations_url":"https://api.github.com/users/szabodabo/orgs","repos_url":"https://api.github.com/users/szabodabo/repos","events_url":"https://api.github.com/users/szabodabo/events{/privacy}","received_events_url":"https://api.github.com/users/szabodabo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-27T01:13:49Z","updated_at":"2018-12-30T23:48:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bakerstu/openmrn/pulls/186","html_url":"https://github.com/bakerstu/openmrn/pull/186","diff_url":"https://github.com/bakerstu/openmrn/pull/186.diff","patch_url":"https://github.com/bakerstu/openmrn/pull/186.patch"},"body":"* Since PWMGPO isn't a singleton, GPIOBit wasn't directly compatible (because of the HW::instance() default argument in the second constructor). Not sure if there's a cleaner way to do this.\r\n\r\n* \"online\" config changes appear not to work, though I *think* this may be an issue with ConfiguredConsumer-based consumers as well. I always need to reset the MCU for any config change to take effect. Not a big issue, but maybe you have ideas on how to fix.\r\n\r\n* ServoConsumer's PWMGPO instance is heap-allocated because I want it to be nullptr until first config. Not sure if there's a better way to do it.\r\n\r\n* Removed references to servos 5-8 (I don't think they're currently hooked up (I remember a discussion on software PWM)). I could bring them back, but the CDI gets really huge.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bakerstu/openmrn/issues/comments/450594976","html_url":"https://github.com/bakerstu/openmrn/pull/186#issuecomment-450594976","issue_url":"https://api.github.com/repos/bakerstu/openmrn/issues/186","id":450594976,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU5NDk3Ng==","user":{"login":"balazsracz","id":3719690,"node_id":"MDQ6VXNlcjM3MTk2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3719690?v=4","gravatar_id":"","url":"https://api.github.com/users/balazsracz","html_url":"https://github.com/balazsracz","followers_url":"https://api.github.com/users/balazsracz/followers","following_url":"https://api.github.com/users/balazsracz/following{/other_user}","gists_url":"https://api.github.com/users/balazsracz/gists{/gist_id}","starred_url":"https://api.github.com/users/balazsracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balazsracz/subscriptions","organizations_url":"https://api.github.com/users/balazsracz/orgs","repos_url":"https://api.github.com/users/balazsracz/repos","events_url":"https://api.github.com/users/balazsracz/events{/privacy}","received_events_url":"https://api.github.com/users/balazsracz/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T23:48:29Z","updated_at":"2018-12-30T23:48:29Z","author_association":"COLLABORATOR","body":"Probably the best construction argument would be pwm count per millisecond.\n\n--\nSent from my mobile device\n"}}
{"actor":{"display_login":"balazsracz"}}