{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/215507265","pull_request_review_id":152785630,"id":215507265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTUwNzI2NQ==","diff_hunk":"@@ -0,0 +1,130 @@\n+import {Construct, Output} from '@aws-cdk/cdk';\n+import {cloudformation, FileSystemId} from './efs.generated';\n+\n+/**\n+ * Properties of a reference to an Elastic File System.\n+ *\n+ * @see FileSystemRef#import\n+ * @see FileSystemRef#export\n+ */\n+export interface FileSystemRefProps {\n+    /**\n+     * The physical, human-readable Id of the EFS we're referencing.\n+     * The EFS must be in the same account and region as the root Stack.\n+     */\n+    fileSystemId: FileSystemId;\n+}\n+\n+/* tslint:disable:max-line-length */\n+export interface FileSystemProps {\n+    /**\n+     * The throughput, measured in MiB/s, that you want to provision for a file system that\n+     * you're creating. The limit on throughput is 1024 MiB/s. You can get these limits\n+     * increased by contacting AWS Support. Must be greater than or equal to 1.0MiB/s\n+     *\n+     * https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-filesystem.html#cfn-elasticfilesystem-filesystem-provisionedthroughputinmibps\n+     * @default 100\n+     */\n+    throughputMiB?: number;\n+\n+    /**\n+     * The throughput mode for the file system to be created. There are two throughput modes to\n+     * choose from for your file system: bursting and provisioned. You can decrease your file\n+     * system's throughput in Provisioned Throughput mode or change between the throughput modes\n+     * as long as it’s been more than 24 hours since the last decrease or throughput mode change.\n+     *\n+     * https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-filesystem.html#cfn-elasticfilesystem-filesystem-throughputmode\n+     * @default ThroughputMode.Bursting\n+     */\n+    throughputMode?: ThroughputMode\n+\n+    /**\n+     * The PerformanceMode of the file system. We recommend generalPurpose performance mode for\n+     * most file systems. File systems using the maxIO performance mode can scale to higher levels\n+     * of aggregate throughput and operations per second with a tradeoff of slightly higher\n+     * latencies for most file operations. This can't be changed after the file system has\n+     * been created.\n+     *\n+     * https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-filesystem.html#cfn-efs-filesystem-performancemode\n+     * @default PerformanceMode.GeneralPurpose\n+     */\n+    performanceMode?: PerformanceMode\n+}\n+/* tslint:enable:max-line-length */\n+\n+/**\n+ * Provides a Elastic File System (EFS).\n+ */\n+export class FileSystem extends Construct {\n+\n+    public readonly fileSystemId: FileSystemId;\n+\n+    private readonly fileSystem: cloudformation.FileSystemResource;\n+\n+    constructor(parent: Construct, id: string, props: FileSystemProps = {}) {\n+        super(parent, id);\n+\n+        const throughput = props.throughputMiB === undefined ? 100 : props.throughputMiB;\n+        if (throughput < 1.0) {\n+            throw new Error(`Provisioned throughput can\\'t be set to a value less than 1.0 MiB/s, provided value: ${props.throughputMiB} `);","path":"packages/@aws-cdk/aws-efs/lib/filesystem.ts","position":69,"original_position":69,"commit_id":"242470604e73ddc21a004ccf4fe9feab78a2f63c","original_commit_id":"242470604e73ddc21a004ccf4fe9feab78a2f63c","user":{"login":"eladb","id":598796,"node_id":"MDQ6VXNlcjU5ODc5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/598796?v=4","gravatar_id":"","url":"https://api.github.com/users/eladb","html_url":"https://github.com/eladb","followers_url":"https://api.github.com/users/eladb/followers","following_url":"https://api.github.com/users/eladb/following{/other_user}","gists_url":"https://api.github.com/users/eladb/gists{/gist_id}","starred_url":"https://api.github.com/users/eladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladb/subscriptions","organizations_url":"https://api.github.com/users/eladb/orgs","repos_url":"https://api.github.com/users/eladb/repos","events_url":"https://api.github.com/users/eladb/events{/privacy}","received_events_url":"https://api.github.com/users/eladb/received_events","type":"User","site_admin":false},"body":"Redundant space at the end of the string","created_at":"2018-09-06T06:21:26Z","updated_at":"2018-09-06T06:27:04Z","html_url":"https://github.com/awslabs/aws-cdk/pull/654#discussion_r215507265","pull_request_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/215507265"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/654#discussion_r215507265"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654","id":212528373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTI4Mzcz","html_url":"https://github.com/awslabs/aws-cdk/pull/654","diff_url":"https://github.com/awslabs/aws-cdk/pull/654.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/654.patch","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/654","number":654,"state":"open","locked":false,"title":"Added construct library for creating an EFS","user":{"login":"rhboyd","id":24552947,"node_id":"MDQ6VXNlcjI0NTUyOTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24552947?v=4","gravatar_id":"","url":"https://api.github.com/users/rhboyd","html_url":"https://github.com/rhboyd","followers_url":"https://api.github.com/users/rhboyd/followers","following_url":"https://api.github.com/users/rhboyd/following{/other_user}","gists_url":"https://api.github.com/users/rhboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/rhboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhboyd/subscriptions","organizations_url":"https://api.github.com/users/rhboyd/orgs","repos_url":"https://api.github.com/users/rhboyd/repos","events_url":"https://api.github.com/users/rhboyd/events{/privacy}","received_events_url":"https://api.github.com/users/rhboyd/received_events","type":"User","site_admin":false},"body":"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.\r\n\r\n- Created an EFS Construct Library. It accepts a no-arg (other than parent/name) constructor that creates an encrypted EFS with the default key and sets the throughput to 100mb/s.\r\n- Users can override all of defaults, except encryption. The thought was that I would send a separate PR with more features centered on encryption (e.g. custom KMS key)\r\n","created_at":"2018-09-01T04:22:16Z","updated_at":"2018-09-06T06:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49d8f21355839bb0ec9e66509828509e42190a4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/654/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/242470604e73ddc21a004ccf4fe9feab78a2f63c","head":{"label":"rhboyd:master","ref":"master","sha":"242470604e73ddc21a004ccf4fe9feab78a2f63c","user":{"login":"rhboyd","id":24552947,"node_id":"MDQ6VXNlcjI0NTUyOTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24552947?v=4","gravatar_id":"","url":"https://api.github.com/users/rhboyd","html_url":"https://github.com/rhboyd","followers_url":"https://api.github.com/users/rhboyd/followers","following_url":"https://api.github.com/users/rhboyd/following{/other_user}","gists_url":"https://api.github.com/users/rhboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/rhboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhboyd/subscriptions","organizations_url":"https://api.github.com/users/rhboyd/orgs","repos_url":"https://api.github.com/users/rhboyd/repos","events_url":"https://api.github.com/users/rhboyd/events{/privacy}","received_events_url":"https://api.github.com/users/rhboyd/received_events","type":"User","site_admin":false},"repo":{"id":146398562,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzOTg1NjI=","name":"aws-cdk","full_name":"rhboyd/aws-cdk","owner":{"login":"rhboyd","id":24552947,"node_id":"MDQ6VXNlcjI0NTUyOTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/24552947?v=4","gravatar_id":"","url":"https://api.github.com/users/rhboyd","html_url":"https://github.com/rhboyd","followers_url":"https://api.github.com/users/rhboyd/followers","following_url":"https://api.github.com/users/rhboyd/following{/other_user}","gists_url":"https://api.github.com/users/rhboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/rhboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhboyd/subscriptions","organizations_url":"https://api.github.com/users/rhboyd/orgs","repos_url":"https://api.github.com/users/rhboyd/repos","events_url":"https://api.github.com/users/rhboyd/events{/privacy}","received_events_url":"https://api.github.com/users/rhboyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhboyd/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":true,"url":"https://api.github.com/repos/rhboyd/aws-cdk","forks_url":"https://api.github.com/repos/rhboyd/aws-cdk/forks","keys_url":"https://api.github.com/repos/rhboyd/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhboyd/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhboyd/aws-cdk/teams","hooks_url":"https://api.github.com/repos/rhboyd/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/rhboyd/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/rhboyd/aws-cdk/events","assignees_url":"https://api.github.com/repos/rhboyd/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/rhboyd/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/rhboyd/aws-cdk/tags","blobs_url":"https://api.github.com/repos/rhboyd/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhboyd/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhboyd/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhboyd/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhboyd/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/rhboyd/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/rhboyd/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/rhboyd/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/rhboyd/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/rhboyd/aws-cdk/subscription","commits_url":"https://api.github.com/repos/rhboyd/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhboyd/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhboyd/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhboyd/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhboyd/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/rhboyd/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhboyd/aws-cdk/merges","archive_url":"https://api.github.com/repos/rhboyd/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhboyd/aws-cdk/downloads","issues_url":"https://api.github.com/repos/rhboyd/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/rhboyd/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/rhboyd/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/rhboyd/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhboyd/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/rhboyd/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/rhboyd/aws-cdk/deployments","created_at":"2018-08-28T05:55:57Z","updated_at":"2018-09-05T16:45:04Z","pushed_at":"2018-09-05T16:45:02Z","git_url":"git://github.com/rhboyd/aws-cdk.git","ssh_url":"git@github.com:rhboyd/aws-cdk.git","clone_url":"https://github.com/rhboyd/aws-cdk.git","svn_url":"https://github.com/rhboyd/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":80312,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"feae63c164289e492b5260c80c508f14218590e6","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-09-06T05:57:31Z","pushed_at":"2018-09-06T05:57:30Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"git@github.com:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":80455,"stargazers_count":829,"watchers_count":829,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":221,"watchers":829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/654"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/654"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-cdk/statuses/242470604e73ddc21a004ccf4fe9feab78a2f63c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eladb"}}