{"action":"created","issue":{"url":"https://api.github.com/repos/TGAC/miso-lims/issues/1656","repository_url":"https://api.github.com/repos/TGAC/miso-lims","labels_url":"https://api.github.com/repos/TGAC/miso-lims/issues/1656/labels{/name}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/issues/1656/comments","events_url":"https://api.github.com/repos/TGAC/miso-lims/issues/1656/events","html_url":"https://github.com/TGAC/miso-lims/pull/1656","id":358148498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTkxMzg0","number":1656,"title":"GLT-2453: set default concentration for dilutions and single-dilution pools","user":{"login":"djcooke","id":12240540,"node_id":"MDQ6VXNlcjEyMjQwNTQw","avatar_url":"https://avatars2.githubusercontent.com/u/12240540?v=4","gravatar_id":"","url":"https://api.github.com/users/djcooke","html_url":"https://github.com/djcooke","followers_url":"https://api.github.com/users/djcooke/followers","following_url":"https://api.github.com/users/djcooke/following{/other_user}","gists_url":"https://api.github.com/users/djcooke/gists{/gist_id}","starred_url":"https://api.github.com/users/djcooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djcooke/subscriptions","organizations_url":"https://api.github.com/users/djcooke/orgs","repos_url":"https://api.github.com/users/djcooke/repos","events_url":"https://api.github.com/users/djcooke/events{/privacy}","received_events_url":"https://api.github.com/users/djcooke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T17:22:12Z","updated_at":"2018-09-07T19:06:57Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/1656","html_url":"https://github.com/TGAC/miso-lims/pull/1656","diff_url":"https://github.com/TGAC/miso-lims/pull/1656.diff","patch_url":"https://github.com/TGAC/miso-lims/pull/1656.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/TGAC/miso-lims/issues/comments/419536528","html_url":"https://github.com/TGAC/miso-lims/pull/1656#issuecomment-419536528","issue_url":"https://api.github.com/repos/TGAC/miso-lims/issues/1656","id":419536528,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUzNjUyOA==","user":{"login":"sqwci","id":11527338,"node_id":"MDQ6VXNlcjExNTI3MzM4","avatar_url":"https://avatars2.githubusercontent.com/u/11527338?v=4","gravatar_id":"","url":"https://api.github.com/users/sqwci","html_url":"https://github.com/sqwci","followers_url":"https://api.github.com/users/sqwci/followers","following_url":"https://api.github.com/users/sqwci/following{/other_user}","gists_url":"https://api.github.com/users/sqwci/gists{/gist_id}","starred_url":"https://api.github.com/users/sqwci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqwci/subscriptions","organizations_url":"https://api.github.com/users/sqwci/orgs","repos_url":"https://api.github.com/users/sqwci/repos","events_url":"https://api.github.com/users/sqwci/events{/privacy}","received_events_url":"https://api.github.com/users/sqwci/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T19:06:57Z","updated_at":"2018-09-07T19:06:57Z","author_association":"COLLABORATOR","body":"SonarQube analysis reported 9 issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![CRITICAL][CRITICAL] [EditLibraryController.java#L550](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L550): Define a constant instead of duplicating this literal \"title\" 3 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [EditLibraryController.java#L576](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L576): Define a constant instead of duplicating this literal \"library\" 4 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [EditLibraryController.java#L627](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L627): Define a constant instead of duplicating this literal \"Libraries\" 4 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [EditLibraryController.java#L853](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L853): Define a constant instead of duplicating this literal \"Dilutions\" 4 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [EditLibraryController.java#L905](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L905): Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1186)\n1. ![CRITICAL][CRITICAL] [EditLibraryController.java#L973](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L973): Define a constant instead of duplicating this literal \"_POOL\" 3 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![MAJOR][MAJOR] [EditLibraryController.java#L463](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L463): Format specifiers should be used instead of string concatenation. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n1. ![MINOR][MINOR] [EditLibraryController.java#L402](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L402): Remove the declaration of thrown exception 'java.lang.IllegalArgumentException' which is a runtime exception. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3ARedundantThrowsDeclarationCheck)\n1. ![MINOR][MINOR] [EditLibraryController.java#L705](https://github.com/TGAC/miso-lims/blob/ef08e012970bcc2dc5a0ae02b2351b6c91d93279/miso-web/src/main/java/uk/ac/bbsrc/tgac/miso/webapp/controller/EditLibraryController.java#L705): Replace this lambda with a method reference. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1612)\n\n[CRITICAL]: https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"sqwci"}}