{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/comments/171247675","pull_request_review_id":100065564,"id":171247675,"diff_hunk":"@@ -12,36 +12,31 @@\n # See the License for the specific language governing permissions and\n # limitations under the License.\n \n-IMAGE = k8scsi/csi-provisioner\n-VERSION = v0.2.0\n+IMAGE_NAME = quay.io/k8scsi/csi-provisioner\n+IMAGE_VERSION = v0.2.0\n \n-container: build quick-container\n-.PHONY: container\n+ifdef V\n+TESTARGS = -v -args -alsologtostderr -v 5\n+else\n+TESTARGS =\n+endif\n \n-clean:\n-\trm -f external-provisioner\n-\trm -rf _output\n-.PHONY: clean\n-\n-format:\n-\t gofmt -w -s ./\n-.PHONY: format\n+all: csi-provisioner\n \n-deps:\n-\tdep ensure -update\n-.PHONY: deps\n+csi-provisioner:\n+\tmkdir -p bin\n+\tCGO_ENABLED=0 GOOS=linux go build -a -ldflags '-extldflags \"-static\"' -o ./bin/csi-provisioner ./cmd/csi-provisioner \n \n-quick-container:\n-\tsudo ./hack/build-container.sh\n-\t@echo \"\"\n-\t@echo \"Container quay.io/k8scsi/csi-provisioner:canary created\"\n-.PHONY: quick-container\n+clean:\n+\trm -rf bin deploy/docker/csi-provisioner\n \n-provisioner:\n-\tmkdir -p _output\n-\tgo build -i -o _output/csi-provisioner ./cmd/csi-provisioner/\n-.PHONY: provisioner\n+container: csi-provisioner\n+\tcp bin/csi-provisioner .","path":"Makefile","position":47,"original_position":47,"commit_id":"40bfd382b411ce998dc09cec31dd62f106d55b07","original_commit_id":"40bfd382b411ce998dc09cec31dd62f106d55b07","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-02-28T13:43:55Z","updated_at":"2018-02-28T13:43:56Z","html_url":"https://github.com/kubernetes-csi/external-provisioner/pull/46#discussion_r171247675","pull_request_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/comments/171247675"},"html":{"href":"https://github.com/kubernetes-csi/external-provisioner/pull/46#discussion_r171247675"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46"}},"in_reply_to_id":171172886},"pull_request":{"url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46","id":171435976,"html_url":"https://github.com/kubernetes-csi/external-provisioner/pull/46","diff_url":"https://github.com/kubernetes-csi/external-provisioner/pull/46.diff","patch_url":"https://github.com/kubernetes-csi/external-provisioner/pull/46.patch","issue_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues/46","number":46,"state":"open","locked":false,"title":"refactor provisioner to use new api objects","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"body":"Latest PV API changes allow using credentials, VolumeAttributes and new CSI namespace v0.","created_at":"2018-02-26T17:09:05Z","updated_at":"2018-02-28T13:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7321b07df0de7cbae2efd44e637b89526a0e5b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46/commits","review_comments_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46/comments","review_comment_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues/46/comments","statuses_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/statuses/40bfd382b411ce998dc09cec31dd62f106d55b07","head":{"label":"sbezverk:csi_core_credentials","ref":"csi_core_credentials","sha":"40bfd382b411ce998dc09cec31dd62f106d55b07","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"repo":{"id":117004081,"name":"external-provisioner","full_name":"sbezverk/external-provisioner","owner":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbezverk/external-provisioner","description":"Sidecar container that watches Kubernetes PersistentVolumeClaim objects and triggers CreateVolume/DeleteVolume against a CSI endpoint","fork":true,"url":"https://api.github.com/repos/sbezverk/external-provisioner","forks_url":"https://api.github.com/repos/sbezverk/external-provisioner/forks","keys_url":"https://api.github.com/repos/sbezverk/external-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbezverk/external-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbezverk/external-provisioner/teams","hooks_url":"https://api.github.com/repos/sbezverk/external-provisioner/hooks","issue_events_url":"https://api.github.com/repos/sbezverk/external-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/sbezverk/external-provisioner/events","assignees_url":"https://api.github.com/repos/sbezverk/external-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/sbezverk/external-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/sbezverk/external-provisioner/tags","blobs_url":"https://api.github.com/repos/sbezverk/external-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbezverk/external-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbezverk/external-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbezverk/external-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbezverk/external-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/sbezverk/external-provisioner/languages","stargazers_url":"https://api.github.com/repos/sbezverk/external-provisioner/stargazers","contributors_url":"https://api.github.com/repos/sbezverk/external-provisioner/contributors","subscribers_url":"https://api.github.com/repos/sbezverk/external-provisioner/subscribers","subscription_url":"https://api.github.com/repos/sbezverk/external-provisioner/subscription","commits_url":"https://api.github.com/repos/sbezverk/external-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbezverk/external-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbezverk/external-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbezverk/external-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbezverk/external-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/sbezverk/external-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbezverk/external-provisioner/merges","archive_url":"https://api.github.com/repos/sbezverk/external-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbezverk/external-provisioner/downloads","issues_url":"https://api.github.com/repos/sbezverk/external-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/sbezverk/external-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/sbezverk/external-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/sbezverk/external-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbezverk/external-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/sbezverk/external-provisioner/releases{/id}","deployments_url":"https://api.github.com/repos/sbezverk/external-provisioner/deployments","created_at":"2018-01-10T19:56:28Z","updated_at":"2018-01-10T19:56:31Z","pushed_at":"2018-02-27T23:10:10Z","git_url":"git://github.com/sbezverk/external-provisioner.git","ssh_url":"git@github.com:sbezverk/external-provisioner.git","clone_url":"https://github.com/sbezverk/external-provisioner.git","svn_url":"https://github.com/sbezverk/external-provisioner","homepage":"","size":45851,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-csi:master","ref":"master","sha":"20f02395dafb0f53e9b8db3c733c9c43c8c7fbd4","user":{"login":"kubernetes-csi","id":33050221,"avatar_url":"https://avatars0.githubusercontent.com/u/33050221?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-csi","html_url":"https://github.com/kubernetes-csi","followers_url":"https://api.github.com/users/kubernetes-csi/followers","following_url":"https://api.github.com/users/kubernetes-csi/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-csi/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-csi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-csi/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-csi/orgs","repos_url":"https://api.github.com/users/kubernetes-csi/repos","events_url":"https://api.github.com/users/kubernetes-csi/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-csi/received_events","type":"Organization","site_admin":false},"repo":{"id":108562487,"name":"external-provisioner","full_name":"kubernetes-csi/external-provisioner","owner":{"login":"kubernetes-csi","id":33050221,"avatar_url":"https://avatars0.githubusercontent.com/u/33050221?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-csi","html_url":"https://github.com/kubernetes-csi","followers_url":"https://api.github.com/users/kubernetes-csi/followers","following_url":"https://api.github.com/users/kubernetes-csi/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-csi/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-csi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-csi/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-csi/orgs","repos_url":"https://api.github.com/users/kubernetes-csi/repos","events_url":"https://api.github.com/users/kubernetes-csi/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-csi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-csi/external-provisioner","description":"Sidecar container that watches Kubernetes PersistentVolumeClaim objects and triggers CreateVolume/DeleteVolume against a CSI endpoint","fork":false,"url":"https://api.github.com/repos/kubernetes-csi/external-provisioner","forks_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/forks","keys_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/teams","hooks_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/events","assignees_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/tags","blobs_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/languages","stargazers_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/subscription","commits_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/merges","archive_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/downloads","issues_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-csi/external-provisioner/deployments","created_at":"2017-10-27T15:24:12Z","updated_at":"2018-02-08T08:39:43Z","pushed_at":"2018-02-27T23:10:11Z","git_url":"git://github.com/kubernetes-csi/external-provisioner.git","ssh_url":"git@github.com:kubernetes-csi/external-provisioner.git","clone_url":"https://github.com/kubernetes-csi/external-provisioner.git","svn_url":"https://github.com/kubernetes-csi/external-provisioner","homepage":"","size":44190,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":11,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46"},"html":{"href":"https://github.com/kubernetes-csi/external-provisioner/pull/46"},"issue":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues/46"},"comments":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-csi/external-provisioner/statuses/40bfd382b411ce998dc09cec31dd62f106d55b07"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sbezverk"}}