{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/189138472","pull_request_review_id":121260684,"id":189138472,"diff_hunk":"@@ -133,6 +162,10 @@ public static FileSystemContext create(Subject subject, MasterInquireClient mast\n    */\n   private FileSystemContext(Subject subject) {\n     mParentSubject = subject;\n+    mExecutorService = Executors.newFixedThreadPool(1,\n+        ThreadFactoryUtils.build(\"metrics-master-heartbeat-%d\", true));\n+    mId = IdUtils.createFileSystemContextId();\n+    LOG.info(\"Created filesystem context with id \" + mId);","path":"core/client/fs/src/main/java/alluxio/client/file/FileSystemContext.java","position":86,"original_position":86,"commit_id":"8828f2a74c88bc1135b7d3efdb0f9c4e7ce8461a","original_commit_id":"8828f2a74c88bc1135b7d3efdb0f9c4e7ce8461a","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars1.githubusercontent.com/u/13425258?v=4","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-18T00:40:48Z","updated_at":"2018-05-18T00:40:49Z","html_url":"https://github.com/Alluxio/alluxio/pull/7251#discussion_r189138472","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/189138472"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7251#discussion_r189138472"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251"}},"in_reply_to_id":189061930},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251","id":186466496,"html_url":"https://github.com/Alluxio/alluxio/pull/7251","diff_url":"https://github.com/Alluxio/alluxio/pull/7251.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7251.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7251","number":7251,"state":"open","locked":false,"title":"[ALLUXIO-2182]  Added a metrics master for aggregating the client metrics","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars1.githubusercontent.com/u/13425258?v=4","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-2182\r\n\r\nWorking in progress\r\n\r\nEach client sends over the metrics to the master in its heartbeat. And the new metrics master will aggregate the metrics defined by the aggregators.\r\n\r\nThis PR adds a client-master heartbeat to send the client-side metrics info. More test coverage improvement will be added once we agree on the architecture.","created_at":"2018-05-07T21:13:49Z","updated_at":"2018-05-18T00:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4e5df8aa829fe29e2e8a75dd67781edd1fa64fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7251/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/8828f2a74c88bc1135b7d3efdb0f9c4e7ce8461a","head":{"label":"yupeng9:client-metr","ref":"client-metr","sha":"8828f2a74c88bc1135b7d3efdb0f9c4e7ce8461a","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars1.githubusercontent.com/u/13425258?v=4","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"repo":{"id":39411244,"name":"tachyon","full_name":"yupeng9/tachyon","owner":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars1.githubusercontent.com/u/13425258?v=4","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yupeng9/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/yupeng9/tachyon","forks_url":"https://api.github.com/repos/yupeng9/tachyon/forks","keys_url":"https://api.github.com/repos/yupeng9/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yupeng9/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yupeng9/tachyon/teams","hooks_url":"https://api.github.com/repos/yupeng9/tachyon/hooks","issue_events_url":"https://api.github.com/repos/yupeng9/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/yupeng9/tachyon/events","assignees_url":"https://api.github.com/repos/yupeng9/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/yupeng9/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/yupeng9/tachyon/tags","blobs_url":"https://api.github.com/repos/yupeng9/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yupeng9/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yupeng9/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/yupeng9/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yupeng9/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/yupeng9/tachyon/languages","stargazers_url":"https://api.github.com/repos/yupeng9/tachyon/stargazers","contributors_url":"https://api.github.com/repos/yupeng9/tachyon/contributors","subscribers_url":"https://api.github.com/repos/yupeng9/tachyon/subscribers","subscription_url":"https://api.github.com/repos/yupeng9/tachyon/subscription","commits_url":"https://api.github.com/repos/yupeng9/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/yupeng9/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/yupeng9/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/yupeng9/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/yupeng9/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/yupeng9/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yupeng9/tachyon/merges","archive_url":"https://api.github.com/repos/yupeng9/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yupeng9/tachyon/downloads","issues_url":"https://api.github.com/repos/yupeng9/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/yupeng9/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/yupeng9/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/yupeng9/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yupeng9/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/yupeng9/tachyon/releases{/id}","deployments_url":"https://api.github.com/repos/yupeng9/tachyon/deployments","created_at":"2015-07-20T22:20:20Z","updated_at":"2016-01-12T00:26:44Z","pushed_at":"2018-05-17T16:28:21Z","git_url":"git://github.com/yupeng9/tachyon.git","ssh_url":"git@github.com:yupeng9/tachyon.git","clone_url":"https://github.com/yupeng9/tachyon.git","svn_url":"https://github.com/yupeng9/tachyon","homepage":"http://tachyon-project.org","size":88669,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:metrics-enhancement","ref":"metrics-enhancement","sha":"b5fdfdab1c2e485d74c096c15420f7ce88448f2f","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-05-17T23:59:03Z","pushed_at":"2018-05-17T23:58:50Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":88204,"stargazers_count":3487,"watchers_count":3487,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1896,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1896,"open_issues":45,"watchers":3487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7251"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7251"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7251/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7251/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/8828f2a74c88bc1135b7d3efdb0f9c4e7ce8461a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yupeng9"}}