{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50527","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50527/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50527/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50527/events","html_url":"https://github.com/NixOS/nixpkgs/pull/50527","id":381905138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzU0MjUy","number":50527,"title":"Add check phase to ninja setup hook","user":{"login":"matthewbauer","id":19036,"node_id":"MDQ6VXNlcjE5MDM2","avatar_url":"https://avatars0.githubusercontent.com/u/19036?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewbauer","html_url":"https://github.com/matthewbauer","followers_url":"https://api.github.com/users/matthewbauer/followers","following_url":"https://api.github.com/users/matthewbauer/following{/other_user}","gists_url":"https://api.github.com/users/matthewbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewbauer/subscriptions","organizations_url":"https://api.github.com/users/matthewbauer/orgs","repos_url":"https://api.github.com/users/matthewbauer/repos","events_url":"https://api.github.com/users/matthewbauer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewbauer/received_events","type":"User","site_admin":false},"labels":[{"id":737692408,"node_id":"MDU6TGFiZWw3Mzc2OTI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin-stdenv","name":"10.rebuild-darwin-stdenv","color":"b60205","default":false},{"id":731735740,"node_id":"MDU6TGFiZWw3MzE3MzU3NDA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20501+","name":"10.rebuild-darwin: 501+","color":"b60205","default":false},{"id":731734523,"node_id":"MDU6TGFiZWw3MzE3MzQ1MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":9820195,"node_id":"MDU6TGFiZWw5ODIwMTk1","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-17T21:59:50Z","updated_at":"2018-11-17T22:15:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50527","html_url":"https://github.com/NixOS/nixpkgs/pull/50527","diff_url":"https://github.com/NixOS/nixpkgs/pull/50527.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/50527.patch"},"body":"###### Motivation for this change\r\n\r\nMost tests in Ninja packages were not getting run because the default check phase assumes you have a Makefile. This adds a check phase to Ninja's setup-hook to fix this. Here is what I changed:\r\n\r\n- Respect installFlags\r\n- Automatically add checkPhase (can be disabled with dontUseNinjaCheck\r\n  in the same way as dontUseNinjaBuild and dontUseNinjaInstall). Tests\r\n  are only run when \"ninja test\" exists.\r\n- Error in build phase when build.ninja is missing. We don’t have a\r\n  way to fall back to other build methods, so it’s best to be very\r\n  clear when we aren’t able to build with ninja\r\n- Set -l flag to 1 when enableParallelBuilding is disabled\r\n\r\nIntended as an alternative to #50323."},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/439651499","html_url":"https://github.com/NixOS/nixpkgs/pull/50527#issuecomment-439651499","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50527","id":439651499,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTY1MTQ5OQ==","user":{"login":"GrahamcOfBorg","id":25447658,"node_id":"MDQ6VXNlcjI1NDQ3NjU4","avatar_url":"https://avatars2.githubusercontent.com/u/25447658?v=4","gravatar_id":"","url":"https://api.github.com/users/GrahamcOfBorg","html_url":"https://github.com/GrahamcOfBorg","followers_url":"https://api.github.com/users/GrahamcOfBorg/followers","following_url":"https://api.github.com/users/GrahamcOfBorg/following{/other_user}","gists_url":"https://api.github.com/users/GrahamcOfBorg/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamcOfBorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamcOfBorg/subscriptions","organizations_url":"https://api.github.com/users/GrahamcOfBorg/orgs","repos_url":"https://api.github.com/users/GrahamcOfBorg/repos","events_url":"https://api.github.com/users/GrahamcOfBorg/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamcOfBorg/received_events","type":"User","site_admin":false},"created_at":"2018-11-17T22:15:41Z","updated_at":"2018-11-17T22:15:41Z","author_association":"NONE","body":"<!--REQUEST_ID=f17529d7-d2f4-4e01-adcd-753242f49f57-->\nSuccess on x86_64-linux [(full log)](https://logs.nix.ci/?key=nixos/nixpkgs.50527&attempt_id=21d61028-81e0-4ac7-aec2-fc52058c500f)\n\nAttempted: glib, ninja\n\n<details><summary>Partial log (click to expand)</summary><p>\n\n```\nstrip is /nix/store/j13c9z0z495wxdc97if8z451x53m1j25-binutils-2.30/bin/strip\nstripping (with command strip and flags -S) in /nix/store/cayd6cjsjsv745w5xia2kxnvff5jn8lx-glib-2.56.0-dev/lib  /nix/store/cayd6cjsjsv745w5xia2kxnvff5jn8lx-glib-2.56.0-dev/bin\npatching script interpreter paths in /nix/store/cayd6cjsjsv745w5xia2kxnvff5jn8lx-glib-2.56.0-dev\n/nix/store/cayd6cjsjsv745w5xia2kxnvff5jn8lx-glib-2.56.0-dev/bin/glib-gettextize: interpreter directive changed from \" /bin/sh\" to \"/nix/store/qnp0bgn3icxrwcnnhz4pcjynxbcnxfv9-bash-4.4-p23/bin/sh\"\n/nix/store/cayd6cjsjsv745w5xia2kxnvff5jn8lx-glib-2.56.0-dev/bin/gdbus-codegen: interpreter directive changed from \"/usr/bin/env /nix/store/47rm1s86gm284237b1gkv2kdq37jhb6j-python-2.7.15/bin/python\" to \"/nix/store/47rm1s86gm284237b1gkv2kdq37jhb6j-python-2.7.15/bin/python\"\nchecking for references to /build/ in /nix/store/cayd6cjsjsv745w5xia2kxnvff5jn8lx-glib-2.56.0-dev...\nshrinking RPATHs of ELF executables and libraries in /nix/store/gqk0ml9793dhv648wv25bx67rsjx9fl0-glib-2.56.0-devdoc\nstrip is /nix/store/j13c9z0z495wxdc97if8z451x53m1j25-binutils-2.30/bin/strip\npatching script interpreter paths in /nix/store/gqk0ml9793dhv648wv25bx67rsjx9fl0-glib-2.56.0-devdoc\nchecking for references to /build/ in /nix/store/gqk0ml9793dhv648wv25bx67rsjx9fl0-glib-2.56.0-devdoc...\n```\n</p></details>\n\n"}}
{"actor":{"display_login":"GrahamcOfBorg"}}