{"action":"created","issue":{"url":"https://api.github.com/repos/python-hyper/hyperlink/issues/63","repository_url":"https://api.github.com/repos/python-hyper/hyperlink","labels_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/63/comments","events_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/63/events","html_url":"https://github.com/python-hyper/hyperlink/pull/63","id":315255695,"number":63,"title":"Make first examples work","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars2.githubusercontent.com/u/857609?v=4","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-17T21:54:21Z","updated_at":"2018-04-17T21:57:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/python-hyper/hyperlink/pulls/63","html_url":"https://github.com/python-hyper/hyperlink/pull/63","diff_url":"https://github.com/python-hyper/hyperlink/pull/63.diff","patch_url":"https://github.com/python-hyper/hyperlink/pull/63.patch"},"body":"The examples were broken in several ways, probably due to changes in the library since they were first written:\r\n\r\n* Replacing `scheme` from 'http' to 'https' seems to also require replacing `port` to match, otherwise it is maintained as port 80\r\n* The `click` function on the github URL (without a trailing slash) takes one to `github.com/` rather than the org URL\r\n* The URL referred to has moved, since the project was moved from `github.com/mahmoud` to `github.com/python-hyper` :)\r\n* I also thought `str()` is more natural than `to_text()`"},"comment":{"url":"https://api.github.com/repos/python-hyper/hyperlink/issues/comments/382164594","html_url":"https://github.com/python-hyper/hyperlink/pull/63#issuecomment-382164594","issue_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/63","id":382164594,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T21:57:17Z","updated_at":"2018-04-17T21:57:17Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/python-hyper/hyperlink/pull/63?src=pr&el=h1) Report\n> Merging [#63](https://codecov.io/gh/python-hyper/hyperlink/pull/63?src=pr&el=desc) into [master](https://codecov.io/gh/python-hyper/hyperlink/commit/7ae2e09a5ad7ed413b293daa571d3db1a9b83cdb?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/python-hyper/hyperlink/pull/63/graphs/tree.svg?src=pr&token=yw7ziHMEc7&width=650&height=150)](https://codecov.io/gh/python-hyper/hyperlink/pull/63?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #63   +/-   ##\n=======================================\n  Coverage   98.11%   98.11%           \n=======================================\n  Files           8        8           \n  Lines        1433     1433           \n  Branches      165      165           \n=======================================\n  Hits         1406     1406           \n  Misses         13       13           \n  Partials       14       14\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/python-hyper/hyperlink/pull/63?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/python-hyper/hyperlink/pull/63?src=pr&el=footer). Last update [7ae2e09...534cc5f](https://codecov.io/gh/python-hyper/hyperlink/pull/63?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}