{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/issues/122","repository_url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n","labels_url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/issues/122/comments","events_url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/issues/122/events","html_url":"https://github.com/solidusio-contrib/solidus_i18n/pull/122","id":312125785,"number":122,"title":"Version 2.0","user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars3.githubusercontent.com/u/131752?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-06T21:32:00Z","updated_at":"2018-04-26T23:55:19Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/pulls/122","html_url":"https://github.com/solidusio-contrib/solidus_i18n/pull/122","diff_url":"https://github.com/solidusio-contrib/solidus_i18n/pull/122.diff","patch_url":"https://github.com/solidusio-contrib/solidus_i18n/pull/122.patch"},"body":"This removes almost all of the functionality from the extension in favour of the new functionality which is built-in to Solidus itself.\r\n\r\nThis proposed version 2.0 of solidus_i18n provides nothing other than locale files, doesn't require deface, and doesn't do any `class_eval` or module prepends.\r\n\r\nFunctionality moved to Solidus itself:\r\n* Frontend locale selector  solidusio/solidus#2683\r\n* Per-store locales  solidusio/solidus#2674\r\n* LocaleController override solidusio/solidus#2626\r\n* `set_user_language` behaviour https://github.com/solidusio/solidus/pull/2559/commits/568ca0b584d720ebcac6211001262fb77a4a0775\r\n\r\nRemoved functionality:\r\n* Remove SolidusI18n::Config (this shouldn't exist now that there are per-store locales)\r\n* Remove weird country name magic (we want to remove this anyways, see #108, #106)\r\n* Remove routing filter (this can be added by users, and should be recommended in the README)\r\n\r\nTODO:\r\n* [x] Upgrade instructions/changelog\r\n* [x] README instructions for routing-filter gem\r\n* [ ] Should this support solidus < 2.6?\r\n* [x] Remove rails-i18n and kaminari-i18n\r\n* [x] Remove specs"},"comment":{"url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/issues/comments/384822892","html_url":"https://github.com/solidusio-contrib/solidus_i18n/pull/122#issuecomment-384822892","issue_url":"https://api.github.com/repos/solidusio-contrib/solidus_i18n/issues/122","id":384822892,"user":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars3.githubusercontent.com/u/131752?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T23:55:19Z","updated_at":"2018-04-26T23:55:19Z","author_association":"OWNER","body":"This is ready to go :shipit:\r\n\r\nI'm not sure what we should do to support versions < 2.6. Maybe a `solidus_i18n_backports` gem?"}}
{"actor":{"display_login":"jhawthorn"}}