{"action":"created","issue":{"url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/issues/358","repository_url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket","labels_url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/issues/358/comments","events_url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/issues/358/events","html_url":"https://github.com/ngx-rocket/generator-ngx-rocket/pull/358","id":349770918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Nzk2OTIw","number":358,"title":"[WIP] Feature/ionic4","user":{"login":"iocaste","id":33830954,"node_id":"MDQ6VXNlcjMzODMwOTU0","avatar_url":"https://avatars0.githubusercontent.com/u/33830954?v=4","gravatar_id":"","url":"https://api.github.com/users/iocaste","html_url":"https://github.com/iocaste","followers_url":"https://api.github.com/users/iocaste/followers","following_url":"https://api.github.com/users/iocaste/following{/other_user}","gists_url":"https://api.github.com/users/iocaste/gists{/gist_id}","starred_url":"https://api.github.com/users/iocaste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocaste/subscriptions","organizations_url":"https://api.github.com/users/iocaste/orgs","repos_url":"https://api.github.com/users/iocaste/repos","events_url":"https://api.github.com/users/iocaste/events{/privacy}","received_events_url":"https://api.github.com/users/iocaste/received_events","type":"User","site_admin":false},"labels":[{"id":365213598,"node_id":"MDU6TGFiZWwzNjUyMTM1OTg=","url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/labels/feature","name":"feature","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-11T23:21:11Z","updated_at":"2018-08-23T11:58:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/pulls/358","html_url":"https://github.com/ngx-rocket/generator-ngx-rocket/pull/358","diff_url":"https://github.com/ngx-rocket/generator-ngx-rocket/pull/358.diff","patch_url":"https://github.com/ngx-rocket/generator-ngx-rocket/pull/358.patch"},"body":"I have taken https://github.com/ngx-rocket/generator-ngx-rocket/pull/335, fixed comments regarding typescript and ported to work with latest changes that master has regarding #231\r\n\r\nStarted porting to Ionic v4\r\n"},"comment":{"url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/issues/comments/415389287","html_url":"https://github.com/ngx-rocket/generator-ngx-rocket/pull/358#issuecomment-415389287","issue_url":"https://api.github.com/repos/ngx-rocket/generator-ngx-rocket/issues/358","id":415389287,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTM4OTI4Nw==","user":{"login":"iocaste","id":33830954,"node_id":"MDQ6VXNlcjMzODMwOTU0","avatar_url":"https://avatars0.githubusercontent.com/u/33830954?v=4","gravatar_id":"","url":"https://api.github.com/users/iocaste","html_url":"https://github.com/iocaste","followers_url":"https://api.github.com/users/iocaste/followers","following_url":"https://api.github.com/users/iocaste/following{/other_user}","gists_url":"https://api.github.com/users/iocaste/gists{/gist_id}","starred_url":"https://api.github.com/users/iocaste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocaste/subscriptions","organizations_url":"https://api.github.com/users/iocaste/orgs","repos_url":"https://api.github.com/users/iocaste/repos","events_url":"https://api.github.com/users/iocaste/events{/privacy}","received_events_url":"https://api.github.com/users/iocaste/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T11:58:40Z","updated_at":"2018-08-23T11:58:40Z","author_association":"NONE","body":"@sinedied Can you accept this PR https://github.com/ngx-rocket/generator-ngx-rocket/pull/361 ?\r\nLooks like only thing that you wanted, was commit squash, it can be done from your side. This PR is needed so that we could have ionic-4 version with tabs and sidebar."}}
{"actor":{"display_login":"iocaste"}}