{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/187808474","pull_request_review_id":119661795,"id":187808474,"diff_hunk":"@@ -2983,9 +2985,11 @@ then\n     posix_threads=yes\n elif test \"$ac_cv_pthread\" = \"yes\"\n then\n-    CC=\"$CC -pthread\"\n+    CC=\"$CC\"\n+    BASECFLAGS=\"-pthread\"\n     if test \"$ac_cv_cxx_thread\" = \"yes\"; then\n-        CXX=\"$CXX -pthread\"\n+        CXX=\"$CXX\"\n+\tBASECXXFLAGS=\"-pthread\"","path":"configure.ac","position":41,"original_position":41,"commit_id":"3162aedc5ae07bcf66f3ff4c17825e5acb2faea6","original_commit_id":"3162aedc5ae07bcf66f3ff4c17825e5acb2faea6","user":{"login":"benjaminp","id":219470,"avatar_url":"https://avatars1.githubusercontent.com/u/219470?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminp","html_url":"https://github.com/benjaminp","followers_url":"https://api.github.com/users/benjaminp/followers","following_url":"https://api.github.com/users/benjaminp/following{/other_user}","gists_url":"https://api.github.com/users/benjaminp/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminp/subscriptions","organizations_url":"https://api.github.com/users/benjaminp/orgs","repos_url":"https://api.github.com/users/benjaminp/repos","events_url":"https://api.github.com/users/benjaminp/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminp/received_events","type":"User","site_admin":false},"body":"Won't this now stomp over whatever `BASECFLAGS` was before?","created_at":"2018-05-13T17:48:14Z","updated_at":"2018-05-13T17:48:14Z","html_url":"https://github.com/python/cpython/pull/6771#discussion_r187808474","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/6771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/187808474"},"html":{"href":"https://github.com/python/cpython/pull/6771#discussion_r187808474"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/6771"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/6771","id":187629716,"html_url":"https://github.com/python/cpython/pull/6771","diff_url":"https://github.com/python/cpython/pull/6771.diff","patch_url":"https://github.com/python/cpython/pull/6771.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/6771","number":6771,"state":"open","locked":false,"title":"bpo-33473: Be slightly better about CFLAGS, LDFLAGS, and related","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars1.githubusercontent.com/u/433817?v=4","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":"- \"-pthread\" is a part of the C compiler and linker flags. It is not\npart of the compiler. In particular 'make CC=clang' ought to work\n- checking for pthreads support is a link time issue, not run time\n\nNot done in this patch:\n- convert from \"gcc\" to \"cc\" to more correctly infer the current\ncompiler\n- regenerate generated code such as \"configure\" or \"aclocal.m4\"\n\n<!-- issue-number: bpo-33473 -->\nhttps://bugs.python.org/issue33473\n<!-- /issue-number -->\n","created_at":"2018-05-12T16:48:34Z","updated_at":"2018-05-13T17:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c16f0e104a82d87c68cd8ca1550b1d34a24331c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/6771/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/6771/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/6771/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/3162aedc5ae07bcf66f3ff4c17825e5acb2faea6","head":{"label":"grimreaper:eax/pthread/pthread_pass_correct","ref":"eax/pthread/pthread_pass_correct","sha":"3162aedc5ae07bcf66f3ff4c17825e5acb2faea6","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars1.githubusercontent.com/u/433817?v=4","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"repo":{"id":120946933,"name":"cpython","full_name":"grimreaper/cpython","owner":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars1.githubusercontent.com/u/433817?v=4","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grimreaper/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/grimreaper/cpython","forks_url":"https://api.github.com/repos/grimreaper/cpython/forks","keys_url":"https://api.github.com/repos/grimreaper/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grimreaper/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grimreaper/cpython/teams","hooks_url":"https://api.github.com/repos/grimreaper/cpython/hooks","issue_events_url":"https://api.github.com/repos/grimreaper/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/grimreaper/cpython/events","assignees_url":"https://api.github.com/repos/grimreaper/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/grimreaper/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/grimreaper/cpython/tags","blobs_url":"https://api.github.com/repos/grimreaper/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grimreaper/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grimreaper/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/grimreaper/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grimreaper/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/grimreaper/cpython/languages","stargazers_url":"https://api.github.com/repos/grimreaper/cpython/stargazers","contributors_url":"https://api.github.com/repos/grimreaper/cpython/contributors","subscribers_url":"https://api.github.com/repos/grimreaper/cpython/subscribers","subscription_url":"https://api.github.com/repos/grimreaper/cpython/subscription","commits_url":"https://api.github.com/repos/grimreaper/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/grimreaper/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/grimreaper/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/grimreaper/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/grimreaper/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/grimreaper/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grimreaper/cpython/merges","archive_url":"https://api.github.com/repos/grimreaper/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grimreaper/cpython/downloads","issues_url":"https://api.github.com/repos/grimreaper/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/grimreaper/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/grimreaper/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/grimreaper/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grimreaper/cpython/labels{/name}","releases_url":"https://api.github.com/repos/grimreaper/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/grimreaper/cpython/deployments","created_at":"2018-02-09T19:31:37Z","updated_at":"2018-02-09T19:32:00Z","pushed_at":"2018-05-12T17:08:06Z","git_url":"git://github.com/grimreaper/cpython.git","ssh_url":"git@github.com:grimreaper/cpython.git","clone_url":"https://github.com/grimreaper/cpython.git","svn_url":"https://github.com/grimreaper/cpython","homepage":"https://www.python.org/","size":232904,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"7ec8f28656ea9d84048e9b5655375c6a74a59f53","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-05-13T17:41:33Z","pushed_at":"2018-05-13T16:28:05Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":235328,"stargazers_count":17624,"watchers_count":17624,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5329,"mirror_url":null,"archived":false,"open_issues_count":691,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5329,"open_issues":691,"watchers":17624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/6771"},"html":{"href":"https://github.com/python/cpython/pull/6771"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/6771"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/6771/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/6771/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/6771/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/3162aedc5ae07bcf66f3ff4c17825e5acb2faea6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjaminp"}}