{"action":"created","issue":{"url":"https://api.github.com/repos/percona/go-mysql/issues/26","repository_url":"https://api.github.com/repos/percona/go-mysql","labels_url":"https://api.github.com/repos/percona/go-mysql/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/percona/go-mysql/issues/26/comments","events_url":"https://api.github.com/repos/percona/go-mysql/issues/26/events","html_url":"https://github.com/percona/go-mysql/pull/26","id":297202865,"number":26,"title":"PMM-1834: Filter out empty comments and \"# explain:\" for MariaDB.","user":{"login":"arvenil","id":450355,"avatar_url":"https://avatars0.githubusercontent.com/u/450355?v=4","gravatar_id":"","url":"https://api.github.com/users/arvenil","html_url":"https://github.com/arvenil","followers_url":"https://api.github.com/users/arvenil/followers","following_url":"https://api.github.com/users/arvenil/following{/other_user}","gists_url":"https://api.github.com/users/arvenil/gists{/gist_id}","starred_url":"https://api.github.com/users/arvenil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvenil/subscriptions","organizations_url":"https://api.github.com/users/arvenil/orgs","repos_url":"https://api.github.com/users/arvenil/repos","events_url":"https://api.github.com/users/arvenil/events{/privacy}","received_events_url":"https://api.github.com/users/arvenil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"arvenil","id":450355,"avatar_url":"https://avatars0.githubusercontent.com/u/450355?v=4","gravatar_id":"","url":"https://api.github.com/users/arvenil","html_url":"https://github.com/arvenil","followers_url":"https://api.github.com/users/arvenil/followers","following_url":"https://api.github.com/users/arvenil/following{/other_user}","gists_url":"https://api.github.com/users/arvenil/gists{/gist_id}","starred_url":"https://api.github.com/users/arvenil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvenil/subscriptions","organizations_url":"https://api.github.com/users/arvenil/orgs","repos_url":"https://api.github.com/users/arvenil/repos","events_url":"https://api.github.com/users/arvenil/events{/privacy}","received_events_url":"https://api.github.com/users/arvenil/received_events","type":"User","site_admin":false},"assignees":[{"login":"arvenil","id":450355,"avatar_url":"https://avatars0.githubusercontent.com/u/450355?v=4","gravatar_id":"","url":"https://api.github.com/users/arvenil","html_url":"https://github.com/arvenil","followers_url":"https://api.github.com/users/arvenil/followers","following_url":"https://api.github.com/users/arvenil/following{/other_user}","gists_url":"https://api.github.com/users/arvenil/gists{/gist_id}","starred_url":"https://api.github.com/users/arvenil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvenil/subscriptions","organizations_url":"https://api.github.com/users/arvenil/orgs","repos_url":"https://api.github.com/users/arvenil/repos","events_url":"https://api.github.com/users/arvenil/events{/privacy}","received_events_url":"https://api.github.com/users/arvenil/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-02-14T18:42:34Z","updated_at":"2018-02-15T09:57:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/percona/go-mysql/pulls/26","html_url":"https://github.com/percona/go-mysql/pull/26","diff_url":"https://github.com/percona/go-mysql/pull/26.diff","patch_url":"https://github.com/percona/go-mysql/pull/26.patch"},"body":"* [PMM-1834: Slow log parse error: explain as part of a fingerprint](https://jira.percona.com/browse/PMM-1834)\r\n  This slow log:\r\n  ```\r\n  mysqld, Version: 10.2.13-MariaDB-10.2.13+maria~jessie-log (mariadb.org binary distribution). started with:\r\n  Tcp port: 0  Unix socket: /var/run/mysqld/mysqld.sock\r\n  Time                 Id Command    Argument\r\n  # Time: 180214 16:18:07\r\n  # User@Host: root[root] @ localhost []\r\n  # Thread_id: 8  Schema:   QC_hit: No\r\n  # Query_time: 0.000277  Lock_time: 0.000000  Rows_sent: 1  Rows_examined: 0\r\n  # Rows_affected: 0\r\n  #\r\n  # explain: id\tselect_type\ttable\ttype\tpossible_keys\tkey\tkey_len\tref\trows\tr_rows\tfiltered\tr_filtered\tExtra\r\n  # explain: 1\tSIMPLE\tNULL\tNULL\tNULL\tNULL\tNULL\tNULL\tNULL\tNULL\t  NULL\tNULL\tNo tables used\r\n  #\r\n  SET timestamp=1518625087;\r\n  SELECT 1;\r\n  ```\r\n  was resulting in this query:\r\n  ```\r\n  #\\n# explain: id\\tselect_type\\ttable\\ttype\\tpossible_keys\\tkey\\tkey_len\\tref\\trows\\tr_rows\\tfiltered\\tr_filtered\\tExtra\\n# explain: 1\\tSIMPLE\\tNULL\\tNULL\\tNULL\\tNULL\\tNULL\\tNULL\\tNULL\\tNULL\\tNULL\\tNULL\\tNo tables used\\n#\\nSELECT 1\r\n  ```\r\n  instead of just:\r\n  ```\r\n  SELECT 1\r\n  ```\r\n* `-update` flag to update test data without hassle."},"comment":{"url":"https://api.github.com/repos/percona/go-mysql/issues/comments/365877836","html_url":"https://github.com/percona/go-mysql/pull/26#issuecomment-365877836","issue_url":"https://api.github.com/repos/percona/go-mysql/issues/26","id":365877836,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-02-15T09:57:32Z","updated_at":"2018-02-15T09:57:32Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=h1) Report\n> Merging [#26](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=desc) into [master](https://codecov.io/gh/percona/go-mysql/commit/d51f8c078ee32ca0b6d242ce8b4757a70d06494f?src=pr&el=desc) will **increase** coverage by `0.29%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/percona/go-mysql/pull/26/graphs/tree.svg?width=650&height=150&src=pr&token=sJM3OqQ7us)](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #26      +/-   ##\n==========================================\n+ Coverage   66.82%   67.12%   +0.29%     \n==========================================\n  Files           8        8              \n  Lines        1245     1247       +2     \n==========================================\n+ Hits          832      837       +5     \n+ Misses        317      315       -2     \n+ Partials       96       95       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [test/test.go](https://codecov.io/gh/percona/go-mysql/pull/26/diff?src=pr&el=tree#diff-dGVzdC90ZXN0Lmdv) | `77.77% <ø> (ø)` | :arrow_up: |\n| [log/slow/parser.go](https://codecov.io/gh/percona/go-mysql/pull/26/diff?src=pr&el=tree#diff-bG9nL3Nsb3cvcGFyc2VyLmdv) | `69.92% <100%> (+0.23%)` | :arrow_up: |\n| [event/class.go](https://codecov.io/gh/percona/go-mysql/pull/26/diff?src=pr&el=tree#diff-ZXZlbnQvY2xhc3MuZ28=) | `87.5% <0%> (+3.4%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=footer). Last update [d51f8c0...b51b60a](https://codecov.io/gh/percona/go-mysql/pull/26?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}