{"push_id":2379634611,"size":52,"distinct_size":52,"ref":"refs/heads/mac68k-queue","head":"b56390f01fd5b25dfbf0a34f7ebe1a135c3f219f","before":"2e89907ad0e94b8bbecb97f3a8d03b783ccc38c1","commits":[{"sha":"2a075b962f5e3e792d79daae6661915bb5f386d4","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"m68k: Revive dead code in bus_error030()\n\nThe only sensible place for the !(mmusr & MMU_I) test is inside the\n(mmusr & (MMU_I | MMU_WP)) branch. It is redundant when used in the\nelse branch.\n\nMoreover, when used in the else branch it defeats the remaining\nconditionals. Hence the (mmusr & (MMU_B|MMU_L|MMU_S)) branch is\nunreachable, along with the final else branch.\n\nMake the dead code live again. The final else clause now catches\naccess faults caused by device drivers, so make allowances for that.\nSee also commit 3b17f136bf32 (\"m68k: Handle 68040 bus faults\").","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/2a075b962f5e3e792d79daae6661915bb5f386d4"},{"sha":"00e4f29e229b445bb415e35414e69ab8d4adee3f","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Avoid array underflow and overflow\n\nCheck array indices. Avoid sprintf. Use buffers of sufficient size.\nUse appropriate types for array length parameters.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/00e4f29e229b445bb415e35414e69ab8d4adee3f"},{"sha":"cc0570fcd1fcc5b8213702c89c26d1798b57c3e4","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Fix up header split\n\nDue to the '#ifdef __KERNEL__' being located in the wrong place, some\ndefinitions from the kernel API were placed in the UAPI header during\nthe scripted header split. Fix this. Also, remove the duplicate comment\nwhich is only relevant to the UAPI header.\n\nFixes: 607ca46e97a1 (\"UAPI: (Scripted) Disintegrate include/linux\")\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/cc0570fcd1fcc5b8213702c89c26d1798b57c3e4"},{"sha":"d28686367d2a4a54b0592c9f4a5275148144c7e5","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Use static functions where possible\n\nThis fixes a couple of warnings from 'make W=1':\ndrivers/nubus/nubus.c:790: warning: no previous prototype for 'nubus_probe_slot'\ndrivers/nubus/nubus.c:824: warning: no previous prototype for 'nubus_scan_bus'\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/d28686367d2a4a54b0592c9f4a5275148144c7e5"},{"sha":"d208c148a164224332b2f98fce3a249f5bf3aa10","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Fix log spam\n\nTesting shows that a single Radius PrecisionColor 24X display board,\nwhich has 95 functional resources, produces over a thousand lines of\nlog messages. Suppress these messages with pr_debug().\nRemove some redundant messages relating to nubus_get_subdir() calls.\nFix the format block debug messages as the sequence of entries is\nbackwards (my bad).\nMove the \"scanning slots\" message to its proper location.\n\nFixes: 71ae40e4cf33 (\"nubus: Clean up printk calls\")\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/d208c148a164224332b2f98fce3a249f5bf3aa10"},{"sha":"4f55b0853013971b1c2d078794fc3c4380e28f9e","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Validate slot resource IDs\n\nWhile we are here, include the slot number in the related error messages.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/4f55b0853013971b1c2d078794fc3c4380e28f9e"},{"sha":"0d9d33e2849857416a75201595c6c36ac3339a7c","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Call proc_mkdir() not more than once per slot directory\n\nThis patch fixes the following WARNING.\n\nproc_dir_entry 'nubus/a' already registered\nModules linked in:\nCPU: 0 PID: 1 Comm: swapper Tainted: G        W       4.13.0-00036-gd57552077387 #1\nStack from 01c1bd9c:\n        01c1bd9c 003c2c8b 01c1bdc0 0001b0fe 00000000 00322f4a 01c43a20 01c43b0c\n        01c8c420 01c1bde8 0001b1b8 003a4ac3 00000148 000faa26 00000009 00000000\n        01c1bde0 003a4b6c 01c1bdfc 01c1be20 000faa26 003a4ac3 00000148 003a4b6c\n        01c43a71 01c8c471 01c10000 00326430 0043d00c 00000005 01c71a00 0020bce0\n        00322964 01c1be38 000fac04 01c43a20 01c8c420 01c1bee0 01c8c420 01c1be50\n        000fac4c 01c1bee0 00000000 01c43a20 00000000 01c1bee8 0020bd26 01c1bee0\nCall Trace: [<0001b0fe>] __warn+0xae/0xde\n [<00322f4a>] memcmp+0x0/0x5c\n [<0001b1b8>] warn_slowpath_fmt+0x2e/0x36\n [<000faa26>] proc_register+0xbe/0xd8\n [<000faa26>] proc_register+0xbe/0xd8\n [<00326430>] sprintf+0x0/0x20\n [<0020bce0>] nubus_proc_attach_device+0x0/0x1b8\n [<00322964>] strcpy+0x0/0x22\n [<000fac04>] proc_mkdir_data+0x64/0x96\n [<000fac4c>] proc_mkdir+0x16/0x1c\n [<0020bd26>] nubus_proc_attach_device+0x46/0x1b8\n [<0020bce0>] nubus_proc_attach_device+0x0/0x1b8\n [<00322964>] strcpy+0x0/0x22\n [<00001ba6>] kernel_pg_dir+0xba6/0x1000\n [<004339a2>] proc_bus_nubus_add_devices+0x1a/0x2e\n [<000faa40>] proc_create_data+0x0/0xf2\n [<0003297c>] parse_args+0x0/0x2d4\n [<00433a08>] nubus_proc_init+0x52/0x5a\n [<00433944>] nubus_init+0x0/0x44\n [<00433982>] nubus_init+0x3e/0x44\n [<000020dc>] do_one_initcall+0x38/0x196\n [<000020a4>] do_one_initcall+0x0/0x196\n [<0003297c>] parse_args+0x0/0x2d4\n [<00322964>] strcpy+0x0/0x22\n [<00040004>] __up_read+0xe/0x40\n [<004231d4>] repair_env_string+0x0/0x7a\n [<0042312e>] kernel_init_freeable+0xee/0x194\n [<00423146>] kernel_init_freeable+0x106/0x194\n [<00433944>] nubus_init+0x0/0x44\n [<000a6000>] kfree+0x0/0x156\n [<0032768c>] kernel_init+0x0/0xda\n [<00327698>] kernel_init+0xc/0xda\n [<0032768c>] kernel_init+0x0/0xda\n [<00002a90>] ret_from_kernel_thread+0xc/0x14\n---[ end trace 14a6d619908ea253 ]---\n------------[ cut here ]------------\n\nThis gets repeated with each additional functional reasource.\n\nThe problem here is the call to proc_mkdir() when the directory already\nexists. Each nubus_board gets a directory, such as /proc/bus/nubus/s/\nwhere s is the hex slot number. Therefore, store the 'procdir' pointer\nin struct nubus_board instead of struct nubus_dev.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/0d9d33e2849857416a75201595c6c36ac3339a7c"},{"sha":"b7c6720a1d9e329a02e25ee45fd1a69c87a4565a","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Remove redundant code\n\nEliminate unused values from struct nubus_dev to save wasted memory\n(a Radius PrecisionColor 24X card has about 95 functional resources\nand up to six such cards may be fitted). Also remove redundant static\nvariable initialization, an unreachable !MACH_IS_MAC conditional,\nthe unused nubus_find_device() function, the bogus get_nubus_list()\nprototype and the pointless card_present temporary variable.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/b7c6720a1d9e329a02e25ee45fd1a69c87a4565a"},{"sha":"9881ad01cd96bf454d824c6673db8295c0711ff5","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Clean up whitespace\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/9881ad01cd96bf454d824c6673db8295c0711ff5"},{"sha":"be127b6c533ad734d64d43bf73fc27a16147de1e","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Generalize block resource handling\n\nScrap the specialized code to unpack video mode name resources and\ndriver resources. It isn't useful.\nInstead, add a re-usable function to handle lists of block resources of\nany kind, and descend into the video mode table resource directory.\nRename callers as nubus_get_foo(), consistent with their purpose and\nwith related functions in the same file.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/be127b6c533ad734d64d43bf73fc27a16147de1e"},{"sha":"0417cdda4c955fddf9975ce29e1707834a13ecd9","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Rework /proc/bus/nubus/s/ implementation\n\nThe /proc/bus/nubus/s/ directory tree for any slot s is missing a lot\nof information. The struct file_operations methods have long been left\nunimplemented (hence the familiar compile-time warning, \"Need to set\nsome I/O handlers here\").\n\nSlot resources have a complex structure which varies depending on board\nfunction. The logic for interpreting these ROM data structures is found\nin nubus.c. Let's not duplicate that logic in proc.c.\n\nCreate the /proc/bus/nubus/s/ inodes while scanning slot s. During\ndescent through slot resource subdirectories, call the new\nnubus_proc_add_foo() functions to create the procfs inodes.\n\nAlso add a new function, nubus_seq_write_rsrc_mem(), to write the\ncontents of a particular slot resource to a given seq_file. This is\nused by the procfs file_operations methods, to finally give userspace\naccess to slot ROM information, such as the available video modes.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/0417cdda4c955fddf9975ce29e1707834a13ecd9"},{"sha":"0706d97a86d69601855761e5979f98497016e53c","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Rename struct nubus_dev\n\nIt is misleading to call a functional resource a \"device\". In adopting\nthe Linux Driver Model, the struct device will be embedded in struct\nnubus_board. That will compound the terminlogy problem because drivers\nwill bind with boards, not with functional resources. Avoid this by\nrenaming struct nubus_dev as struct nubus_rsrc. \"Functional resource\"\nis the vendor's terminology so this helps avoid confusion.\n\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>\nAcked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/0706d97a86d69601855761e5979f98497016e53c"},{"sha":"311792c05d1ed0093d6d3f48b5915213eef80559","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Adopt standard linked list implementation\n\nThis increases code re-use and improves readability.\n\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>\nAcked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/311792c05d1ed0093d6d3f48b5915213eef80559"},{"sha":"7ea828b1d02089f2f6d487b3f8b0edd05f0bce30","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Add expansion_type values for various Mac models\n\nAdd an expansion slot attribute to allow drivers to properly handle\ncards like Comm Slot cards and PDS cards without declaration ROMs.\nThis clarifies the logic for the Centris 610 model which has no\nComm Slot but has an optional on-board SONIC device.\n\nCc: \"David S. Miller\" <davem@davemloft.net>\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/7ea828b1d02089f2f6d487b3f8b0edd05f0bce30"},{"sha":"10066e3eeb3b8ee7d0efe7d7425d9998a429b834","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"nubus: Add support for the driver model\n\nThis patch brings basic support for the Linux Driver Model to the\nNuBus subsystem.\n\nFor flexibility, the matching of boards with drivers is left up to the\ndrivers. This is also the approach taken by NetBSD. A board may have\nmany functions, and drivers may have to consider many functional\nresources and board resources in order to match a device.\n\nThis implementation does not bind drivers to resources (nor does it bind\nmany drivers to the same board). Apple's NuBus declaration ROM design\nis flexible enough to allow that, but I don't see a need to support it\nas we don't use the \"slot zero\" resources (in the main logic board ROM).\n\nEliminate the global nubus_boards linked list by rewriting the procfs\nboard iterator around bus_for_each_dev(). Hence the nubus device refcount\ncan be used to determine the lifespan of board objects.\n\nCc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\nReviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\n\n---\nThe conversion of Mac network drivers from the Space.c convention to\nthe Driver Model takes place in a separate patch series, archived at\nhttps://lkml.org/lkml/2017/11/11/25\nThat series motivates parts of this design, such as the definition of\n'for_each_board_func_rsrc'.\n\nChanges since v3:\n- Added Reviewed-by tag.\n- Moved the SPDX tag in bus.c to the first line of the file.","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/10066e3eeb3b8ee7d0efe7d7425d9998a429b834"},{"sha":"69cb285c85f3102aaf8ca0714cd2956e6f25c295","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"net/8390: Remove redundant make dependencies\n\nThe hydra, zorro8390 and mcf8390 drivers all #include \"lib8390.c\" and\nhave no need for 8390.o. modinfo confirms no dependency on 8390.ko.\nDrop the redundant dependency from the Makefile. objdump confirms\nthat this patch has no effect on the module binaries.\n\nThe superfluous additions of 8390.o were introduced in\ncommit 644570b83026 (\"8390: Move the 8390 related drivers\").\n\nCc: Greg Ungerer <gerg@linux-m68k.org>\nCc: Geert Uytterhoeven <geert@linux-m68k.org>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\nAcked-by: Geert Uytterhoeven <geert@linux-m68k.org>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/69cb285c85f3102aaf8ca0714cd2956e6f25c295"},{"sha":"087398577595578d59dd727f628b2797e41229ac","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"net/8390: Fix msg_enable patch snafu\n\nThe lib8390 module parameter 'msg_enable' doesn't do anything useful:\nit causes an ancient version string to be logged.\n\nRemove redundant code that logs the same string.\n\nIn ne.c and wd.c, the value of ei_local->msg_enable is used before\nbeing assigned. Use ne_msg_enable and wd_msg_enable, respectively.\n\nMost of the other 8390 drivers never assign ei_local->msg_enable.\nUse the 'msg_enable' module parameter from lib8390 as the default\nvalue.\n\nEliminate the pointless static and local variables.\n\nClean up an indentation mistake.\n\nAll of these issues originated from the same patch.\n\nCc: Russell King <linux@armlinux.org.uk>\nFixes: c45f812f0280 (\"8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature\")\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>\n---\nOnly the mac8390.c and lib8390.c changes have been tested. The other\nchanges are similar but untested.","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/087398577595578d59dd727f628b2797e41229ac"},{"sha":"e46690b30f3fa0cbe189bba6c428981c731729f1","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"net/mac8390: Convert to nubus_driver\n\nThis resolves an old bug that constrained this driver to no more than\none card.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/e46690b30f3fa0cbe189bba6c428981c731729f1"},{"sha":"38b6ef0e10e9ebab8cff6d5315b4d6b8dfe24559","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"net/mac8390: Fix log messages\n\nUse dev_foo() to log the slot number instead of the unexpanded \"eth%d\"\nformat string.\nDisambiguate the two identical \"Card type %s is unsupported\" messages.\n\nTested-by: Stan Johnson <userm57@yahoo.com>\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/38b6ef0e10e9ebab8cff6d5315b4d6b8dfe24559"},{"sha":"50adc33366709b6fbabc1a26f9bf537ee32b97c3","author":{"name":"Finn Thain","email":"86b390fcaaea23e6369bd6b019cb5ffd1fadc018@telegraphics.com.au"},"message":"net/mac89x0: Remove redundant code\n\nSigned-off-by: Finn Thain <fthain@telegraphics.com.au>","distinct":true,"url":"https://api.github.com/repos/fthain/linux/commits/50adc33366709b6fbabc1a26f9bf537ee32b97c3"}]}
{"actor":{"display_login":"fthain"}}