{"action":"created","issue":{"url":"https://api.github.com/repos/epfl-ecps/channelflow/issues/9","repository_url":"https://api.github.com/repos/epfl-ecps/channelflow","labels_url":"https://api.github.com/repos/epfl-ecps/channelflow/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/epfl-ecps/channelflow/issues/9/comments","events_url":"https://api.github.com/repos/epfl-ecps/channelflow/issues/9/events","html_url":"https://github.com/epfl-ecps/channelflow/pull/9","id":384969528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDQ3NDgy","number":9,"title":"Generalized laminarProfile() for ASBL with dPdx and Ubulk","user":{"login":"johnfgibson","id":14895195,"node_id":"MDQ6VXNlcjE0ODk1MTk1","avatar_url":"https://avatars2.githubusercontent.com/u/14895195?v=4","gravatar_id":"","url":"https://api.github.com/users/johnfgibson","html_url":"https://github.com/johnfgibson","followers_url":"https://api.github.com/users/johnfgibson/followers","following_url":"https://api.github.com/users/johnfgibson/following{/other_user}","gists_url":"https://api.github.com/users/johnfgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/johnfgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnfgibson/subscriptions","organizations_url":"https://api.github.com/users/johnfgibson/orgs","repos_url":"https://api.github.com/users/johnfgibson/repos","events_url":"https://api.github.com/users/johnfgibson/events{/privacy}","received_events_url":"https://api.github.com/users/johnfgibson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-27T20:20:37Z","updated_at":"2018-11-28T19:50:35Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/epfl-ecps/channelflow/pulls/9","html_url":"https://github.com/epfl-ecps/channelflow/pull/9","diff_url":"https://github.com/epfl-ecps/channelflow/pull/9.diff","patch_url":"https://github.com/epfl-ecps/channelflow/pull/9.patch"},"body":"Reogranized and generalized the `ChebyCoeff laminarProfile(Real nu, MeanConstraint constraint, ...)` function to handle ASBL (Vsuck != 0) conditions with bulk velocity constraint and nonzero pressure gradient. While at it modified the regular ASBL profile code to call `expm1` function rather than computing `exp(x) -1`, which loses digits for small x, and reformulated so that the args of these functions are always of form `y-a` rather than plain old `y`. \r\n\r\nAdded a `laminarTest.cpp` to the test suite. This calls `laminarProfile`  for 1000 random laminar flow conditions and verifies the resulting U(y) satisfies momentum balance, boundary condtions, and the constraint. \r\n\r\nThis was triggered by trying to describe the baseflow + perturbation decomposition for the channelflow-2.0 paper. Having the general case covered makes it easier to describe."},"comment":{"url":"https://api.github.com/repos/epfl-ecps/channelflow/issues/comments/442581386","html_url":"https://github.com/epfl-ecps/channelflow/pull/9#issuecomment-442581386","issue_url":"https://api.github.com/repos/epfl-ecps/channelflow/issues/9","id":442581386,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjU4MTM4Ng==","user":{"login":"mirkofarano","id":40035281,"node_id":"MDQ6VXNlcjQwMDM1Mjgx","avatar_url":"https://avatars2.githubusercontent.com/u/40035281?v=4","gravatar_id":"","url":"https://api.github.com/users/mirkofarano","html_url":"https://github.com/mirkofarano","followers_url":"https://api.github.com/users/mirkofarano/followers","following_url":"https://api.github.com/users/mirkofarano/following{/other_user}","gists_url":"https://api.github.com/users/mirkofarano/gists{/gist_id}","starred_url":"https://api.github.com/users/mirkofarano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirkofarano/subscriptions","organizations_url":"https://api.github.com/users/mirkofarano/orgs","repos_url":"https://api.github.com/users/mirkofarano/repos","events_url":"https://api.github.com/users/mirkofarano/events{/privacy}","received_events_url":"https://api.github.com/users/mirkofarano/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T19:50:35Z","updated_at":"2018-11-28T19:50:35Z","author_association":"COLLABORATOR","body":"The CI is complaining again.\r\n```\r\n/home/travis/build/epfl-ecps/channelflow/tests/laminarTest.cpp:154:5: error: expected unqualified-id before ‘return’\r\n     return (passtest == true) ? 0 : 1;\r\n     ^~~~~~\r\n/home/travis/build/epfl-ecps/channelflow/tests/laminarTest.cpp:155:1: error: expected declaration before ‘}’ token\r\n }\r\n```"}}
{"actor":{"display_login":"mirkofarano"}}