{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/14010","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/14010/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/14010/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/14010/events","html_url":"https://github.com/brave/browser-laptop/pull/14010","id":320004669,"number":14010,"title":"Adding re-inclusion for deleted publishers via context menu.","user":{"login":"ryanml","id":8732757,"avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"labels":[{"id":714300836,"url":"https://api.github.com/repos/brave/browser-laptop/labels/PR/pending-review","name":"PR/pending-review","color":"006b75","default":false},{"id":408464251,"url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ledger","name":"feature/ledger","color":"ff5000","default":false}],"state":"closed","locked":false,"assignee":{"login":"ryanml","id":8732757,"avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryanml","id":8732757,"avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/109","html_url":"https://github.com/brave/browser-laptop/milestone/109","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/109/labels","id":3246523,"number":109,"title":"0.22.x Release 3 (Beta channel)","description":"Single-webview","creator":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":116,"state":"open","created_at":"2018-04-05T23:58:53Z","updated_at":"2018-05-05T07:56:44Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-05-03T17:05:49Z","updated_at":"2018-05-05T07:58:55Z","closed_at":"2018-05-05T07:56:44Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/14010","html_url":"https://github.com/brave/browser-laptop/pull/14010","diff_url":"https://github.com/brave/browser-laptop/pull/14010.diff","patch_url":"https://github.com/brave/browser-laptop/pull/14010.patch"},"body":"Fixes #13994\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review). (Ask a Brave employee to help if you cannot access this document.)\r\n\r\n## Test Plan:\r\n\r\n  1. Clean install Brave\r\n  2. Enable payments, visit some sites to add in ledger table\r\n  3. Delete one of the publisher from the list\r\n  4. Open about:history and right click on the publisher deleted\r\n  5. Ensure that that the `Include this publisher` option is not present.\r\n  6. Clear the above site out of deleted sites in `about:preferences#payments`\r\n  7. Go back to about:history, ensure that the entry now has the `Include this publisher option`\r\n  8. Click the option, ensure that it is again present in the ledger.\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review) if one was not already requested.\r\n\r\nTests\r\n\r\n\r\n- [x] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/386788165","html_url":"https://github.com/brave/browser-laptop/pull/14010#issuecomment-386788165","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/14010","id":386788165,"user":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T07:58:55Z","updated_at":"2018-05-05T07:58:55Z","author_association":"MEMBER","body":"master bca6936\r\n0.23 4eaa2da80\r\n0.22-release3 7f4d52db9"}}
{"actor":{"display_login":"NejcZdovc"}}