{"action":"closed","number":51,"pull_request":{"url":"https://api.github.com/repos/videolan/vlc-ios/pulls/51","id":184587244,"html_url":"https://github.com/videolan/vlc-ios/pull/51","diff_url":"https://github.com/videolan/vlc-ios/pull/51.diff","patch_url":"https://github.com/videolan/vlc-ios/pull/51.patch","issue_url":"https://api.github.com/repos/videolan/vlc-ios/issues/51","number":51,"state":"closed","locked":false,"title":"Lazy services","user":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for contributing to _vlc-ios_! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->\r\n\r\n### Checklist\r\n- [x] I've run `bundle exec fastlane test` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the [vlc-ios code style](Docs/CodingStyle.md) and run `bundle exec fastlane lint` to ensure the code style is valid\r\n- [x] I've read the [Contribution Guidelines](https://github.com/videolan/vlc-ios#contribute)\r\n- [x] I've updated the documentation if necessary.\r\n\r\n### Description\r\n<!-- Describe your changes in detail -->\r\nI want to make sure that the Services are really just instantiated once and that was the best way I could think of :/ Is there a better way than this? \r\n","created_at":"2018-04-27T10:46:12Z","updated_at":"2018-04-27T14:48:07Z","closed_at":"2018-04-27T14:48:07Z","merged_at":null,"merge_commit_sha":"64dce1023365e5e34a842ec3d851d0cf434b0fd8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dcordero","id":2320840,"avatar_url":"https://avatars2.githubusercontent.com/u/2320840?v=4","gravatar_id":"","url":"https://api.github.com/users/dcordero","html_url":"https://github.com/dcordero","followers_url":"https://api.github.com/users/dcordero/followers","following_url":"https://api.github.com/users/dcordero/following{/other_user}","gists_url":"https://api.github.com/users/dcordero/gists{/gist_id}","starred_url":"https://api.github.com/users/dcordero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcordero/subscriptions","organizations_url":"https://api.github.com/users/dcordero/orgs","repos_url":"https://api.github.com/users/dcordero/repos","events_url":"https://api.github.com/users/dcordero/events{/privacy}","received_events_url":"https://api.github.com/users/dcordero/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/51/commits","review_comments_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/51/comments","review_comment_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videolan/vlc-ios/issues/51/comments","statuses_url":"https://api.github.com/repos/videolan/vlc-ios/statuses/3c5954acbbdf5c479704515d41310ce1ea63a2f7","head":{"label":"carolanitz:lazyServices","ref":"lazyServices","sha":"3c5954acbbdf5c479704515d41310ce1ea63a2f7","user":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"repo":{"id":122180782,"name":"vlc-ios","full_name":"carolanitz/vlc-ios","owner":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carolanitz/vlc-ios","description":"VLC for iOS official mirror","fork":true,"url":"https://api.github.com/repos/carolanitz/vlc-ios","forks_url":"https://api.github.com/repos/carolanitz/vlc-ios/forks","keys_url":"https://api.github.com/repos/carolanitz/vlc-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carolanitz/vlc-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carolanitz/vlc-ios/teams","hooks_url":"https://api.github.com/repos/carolanitz/vlc-ios/hooks","issue_events_url":"https://api.github.com/repos/carolanitz/vlc-ios/issues/events{/number}","events_url":"https://api.github.com/repos/carolanitz/vlc-ios/events","assignees_url":"https://api.github.com/repos/carolanitz/vlc-ios/assignees{/user}","branches_url":"https://api.github.com/repos/carolanitz/vlc-ios/branches{/branch}","tags_url":"https://api.github.com/repos/carolanitz/vlc-ios/tags","blobs_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carolanitz/vlc-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/carolanitz/vlc-ios/languages","stargazers_url":"https://api.github.com/repos/carolanitz/vlc-ios/stargazers","contributors_url":"https://api.github.com/repos/carolanitz/vlc-ios/contributors","subscribers_url":"https://api.github.com/repos/carolanitz/vlc-ios/subscribers","subscription_url":"https://api.github.com/repos/carolanitz/vlc-ios/subscription","commits_url":"https://api.github.com/repos/carolanitz/vlc-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/carolanitz/vlc-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/carolanitz/vlc-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/carolanitz/vlc-ios/contents/{+path}","compare_url":"https://api.github.com/repos/carolanitz/vlc-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carolanitz/vlc-ios/merges","archive_url":"https://api.github.com/repos/carolanitz/vlc-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carolanitz/vlc-ios/downloads","issues_url":"https://api.github.com/repos/carolanitz/vlc-ios/issues{/number}","pulls_url":"https://api.github.com/repos/carolanitz/vlc-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/carolanitz/vlc-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/carolanitz/vlc-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carolanitz/vlc-ios/labels{/name}","releases_url":"https://api.github.com/repos/carolanitz/vlc-ios/releases{/id}","deployments_url":"https://api.github.com/repos/carolanitz/vlc-ios/deployments","created_at":"2018-02-20T09:56:28Z","updated_at":"2018-04-27T09:19:28Z","pushed_at":"2018-04-27T12:08:20Z","git_url":"git://github.com/carolanitz/vlc-ios.git","ssh_url":"git@github.com:carolanitz/vlc-ios.git","clone_url":"https://github.com/carolanitz/vlc-ios.git","svn_url":"https://github.com/carolanitz/vlc-ios","homepage":null,"size":43450,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videolan:master","ref":"master","sha":"5fb0f5b36438370acc87d1d444a0e97350ba1c33","user":{"login":"videolan","id":1389585,"avatar_url":"https://avatars1.githubusercontent.com/u/1389585?v=4","gravatar_id":"","url":"https://api.github.com/users/videolan","html_url":"https://github.com/videolan","followers_url":"https://api.github.com/users/videolan/followers","following_url":"https://api.github.com/users/videolan/following{/other_user}","gists_url":"https://api.github.com/users/videolan/gists{/gist_id}","starred_url":"https://api.github.com/users/videolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolan/subscriptions","organizations_url":"https://api.github.com/users/videolan/orgs","repos_url":"https://api.github.com/users/videolan/repos","events_url":"https://api.github.com/users/videolan/events{/privacy}","received_events_url":"https://api.github.com/users/videolan/received_events","type":"Organization","site_admin":false},"repo":{"id":120193302,"name":"vlc-ios","full_name":"videolan/vlc-ios","owner":{"login":"videolan","id":1389585,"avatar_url":"https://avatars1.githubusercontent.com/u/1389585?v=4","gravatar_id":"","url":"https://api.github.com/users/videolan","html_url":"https://github.com/videolan","followers_url":"https://api.github.com/users/videolan/followers","following_url":"https://api.github.com/users/videolan/following{/other_user}","gists_url":"https://api.github.com/users/videolan/gists{/gist_id}","starred_url":"https://api.github.com/users/videolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolan/subscriptions","organizations_url":"https://api.github.com/users/videolan/orgs","repos_url":"https://api.github.com/users/videolan/repos","events_url":"https://api.github.com/users/videolan/events{/privacy}","received_events_url":"https://api.github.com/users/videolan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videolan/vlc-ios","description":"VLC for iOS official mirror","fork":false,"url":"https://api.github.com/repos/videolan/vlc-ios","forks_url":"https://api.github.com/repos/videolan/vlc-ios/forks","keys_url":"https://api.github.com/repos/videolan/vlc-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videolan/vlc-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videolan/vlc-ios/teams","hooks_url":"https://api.github.com/repos/videolan/vlc-ios/hooks","issue_events_url":"https://api.github.com/repos/videolan/vlc-ios/issues/events{/number}","events_url":"https://api.github.com/repos/videolan/vlc-ios/events","assignees_url":"https://api.github.com/repos/videolan/vlc-ios/assignees{/user}","branches_url":"https://api.github.com/repos/videolan/vlc-ios/branches{/branch}","tags_url":"https://api.github.com/repos/videolan/vlc-ios/tags","blobs_url":"https://api.github.com/repos/videolan/vlc-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videolan/vlc-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videolan/vlc-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/videolan/vlc-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videolan/vlc-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/videolan/vlc-ios/languages","stargazers_url":"https://api.github.com/repos/videolan/vlc-ios/stargazers","contributors_url":"https://api.github.com/repos/videolan/vlc-ios/contributors","subscribers_url":"https://api.github.com/repos/videolan/vlc-ios/subscribers","subscription_url":"https://api.github.com/repos/videolan/vlc-ios/subscription","commits_url":"https://api.github.com/repos/videolan/vlc-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/videolan/vlc-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/videolan/vlc-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/videolan/vlc-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/videolan/vlc-ios/contents/{+path}","compare_url":"https://api.github.com/repos/videolan/vlc-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videolan/vlc-ios/merges","archive_url":"https://api.github.com/repos/videolan/vlc-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videolan/vlc-ios/downloads","issues_url":"https://api.github.com/repos/videolan/vlc-ios/issues{/number}","pulls_url":"https://api.github.com/repos/videolan/vlc-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/videolan/vlc-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/videolan/vlc-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videolan/vlc-ios/labels{/name}","releases_url":"https://api.github.com/repos/videolan/vlc-ios/releases{/id}","deployments_url":"https://api.github.com/repos/videolan/vlc-ios/deployments","created_at":"2018-02-04T14:44:05Z","updated_at":"2018-04-27T13:30:45Z","pushed_at":"2018-04-27T14:37:52Z","git_url":"git://github.com/videolan/vlc-ios.git","ssh_url":"git@github.com:videolan/vlc-ios.git","clone_url":"https://github.com/videolan/vlc-ios.git","svn_url":"https://github.com/videolan/vlc-ios","homepage":null,"size":43584,"stargazers_count":176,"watchers_count":176,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":23,"open_issues":6,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/51"},"html":{"href":"https://github.com/videolan/vlc-ios/pull/51"},"issue":{"href":"https://api.github.com/repos/videolan/vlc-ios/issues/51"},"comments":{"href":"https://api.github.com/repos/videolan/vlc-ios/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/videolan/vlc-ios/statuses/3c5954acbbdf5c479704515d41310ce1ea63a2f7"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":40,"deletions":106,"changed_files":17}}
{"actor":{"display_login":"Mikanbu"}}