{"action":"created","comment":{"url":"https://api.github.com/repos/omise/omise-java/pulls/comments/199693433","pull_request_review_id":133860266,"id":199693433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTY5MzQzMw==","diff_hunk":"@@ -21,7 +21,7 @@\n \n     @Test(expected = NullPointerException.class)\n     public void testCreator() throws ClientException {\n-        new Client(null);\n+        new Client((String) null);","path":"src/test/java/co/omise/ClientTest.java","position":5,"original_position":5,"commit_id":"7fe0ba6d641f45ad0c158fc82e4973e63ce3f88f","original_commit_id":"7fe0ba6d641f45ad0c158fc82e4973e63ce3f88f","user":{"login":"nuxzero","id":2638321,"node_id":"MDQ6VXNlcjI2MzgzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2638321?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxzero","html_url":"https://github.com/nuxzero","followers_url":"https://api.github.com/users/nuxzero/followers","following_url":"https://api.github.com/users/nuxzero/following{/other_user}","gists_url":"https://api.github.com/users/nuxzero/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxzero/subscriptions","organizations_url":"https://api.github.com/users/nuxzero/orgs","repos_url":"https://api.github.com/users/nuxzero/repos","events_url":"https://api.github.com/users/nuxzero/events{/privacy}","received_events_url":"https://api.github.com/users/nuxzero/received_events","type":"User","site_admin":false},"body":"Can we just delete `(String)`?","created_at":"2018-07-03T06:16:46Z","updated_at":"2018-07-03T06:16:46Z","html_url":"https://github.com/omise/omise-java/pull/32#discussion_r199693433","pull_request_url":"https://api.github.com/repos/omise/omise-java/pulls/32","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/omise/omise-java/pulls/comments/199693433"},"html":{"href":"https://github.com/omise/omise-java/pull/32#discussion_r199693433"},"pull_request":{"href":"https://api.github.com/repos/omise/omise-java/pulls/32"}},"in_reply_to_id":199693081},"pull_request":{"url":"https://api.github.com/repos/omise/omise-java/pulls/32","id":198857474,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODU3NDc0","html_url":"https://github.com/omise/omise-java/pull/32","diff_url":"https://github.com/omise/omise-java/pull/32.diff","patch_url":"https://github.com/omise/omise-java/pull/32.patch","issue_url":"https://api.github.com/repos/omise/omise-java/issues/32","number":32,"state":"open","locked":false,"title":"Fixed the client's third constructor in a way that it would only take…","user":{"login":"Namiii","id":5729822,"node_id":"MDQ6VXNlcjU3Mjk4MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/5729822?v=4","gravatar_id":"","url":"https://api.github.com/users/Namiii","html_url":"https://github.com/Namiii","followers_url":"https://api.github.com/users/Namiii/followers","following_url":"https://api.github.com/users/Namiii/following{/other_user}","gists_url":"https://api.github.com/users/Namiii/gists{/gist_id}","starred_url":"https://api.github.com/users/Namiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Namiii/subscriptions","organizations_url":"https://api.github.com/users/Namiii/orgs","repos_url":"https://api.github.com/users/Namiii/repos","events_url":"https://api.github.com/users/Namiii/events{/privacy}","received_events_url":"https://api.github.com/users/Namiii/received_events","type":"User","site_admin":false},"body":"Quick fix PR to change the client in a way that can be easily used in the dashboard without the need for any keys to be supplied in.\r\n\r\nIt changes the client constructor from \r\n \r\n```\r\npublic Client(String publicKey, String secretKey, Requester requester) throws ClientException {\r\nPreconditions.checkNotNull(secretKey);\r\nConfig config = new Config(Endpoint.API_VERSION, publicKey, secretKey);\r\nhttpClient = buildHttpClient(config);\r\n\r\nthis.requester = requester;\r\n\r\ninitResources();\r\n}\r\n```\r\n\r\nto \r\n\r\n```\r\npublic Client(Requester requester) {\r\nthis.requester = requester;\r\nthis.httpClient = requester.getHttpClient();\r\n}\r\n```\r\n\r\nThis is a temp fix and the need for having the httpclient retrieved in the requester constructor would no longer be there when v3.0 is fully done. In the meantime, it allows us to use the client in the dashboard app.","created_at":"2018-07-03T06:01:00Z","updated_at":"2018-07-03T06:16:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa58387be6e31a3b8352e23266d12bdffc815c3c","assignee":{"login":"chakrit","id":45545,"node_id":"MDQ6VXNlcjQ1NTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/45545?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrit","html_url":"https://github.com/chakrit","followers_url":"https://api.github.com/users/chakrit/followers","following_url":"https://api.github.com/users/chakrit/following{/other_user}","gists_url":"https://api.github.com/users/chakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrit/subscriptions","organizations_url":"https://api.github.com/users/chakrit/orgs","repos_url":"https://api.github.com/users/chakrit/repos","events_url":"https://api.github.com/users/chakrit/events{/privacy}","received_events_url":"https://api.github.com/users/chakrit/received_events","type":"User","site_admin":false},"assignees":[{"login":"chakrit","id":45545,"node_id":"MDQ6VXNlcjQ1NTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/45545?v=4","gravatar_id":"","url":"https://api.github.com/users/chakrit","html_url":"https://github.com/chakrit","followers_url":"https://api.github.com/users/chakrit/followers","following_url":"https://api.github.com/users/chakrit/following{/other_user}","gists_url":"https://api.github.com/users/chakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrit/subscriptions","organizations_url":"https://api.github.com/users/chakrit/orgs","repos_url":"https://api.github.com/users/chakrit/repos","events_url":"https://api.github.com/users/chakrit/events{/privacy}","received_events_url":"https://api.github.com/users/chakrit/received_events","type":"User","site_admin":false},{"login":"pitiphong-p","id":426153,"node_id":"MDQ6VXNlcjQyNjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/426153?v=4","gravatar_id":"","url":"https://api.github.com/users/pitiphong-p","html_url":"https://github.com/pitiphong-p","followers_url":"https://api.github.com/users/pitiphong-p/followers","following_url":"https://api.github.com/users/pitiphong-p/following{/other_user}","gists_url":"https://api.github.com/users/pitiphong-p/gists{/gist_id}","starred_url":"https://api.github.com/users/pitiphong-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitiphong-p/subscriptions","organizations_url":"https://api.github.com/users/pitiphong-p/orgs","repos_url":"https://api.github.com/users/pitiphong-p/repos","events_url":"https://api.github.com/users/pitiphong-p/events{/privacy}","received_events_url":"https://api.github.com/users/pitiphong-p/received_events","type":"User","site_admin":false},{"login":"nuxzero","id":2638321,"node_id":"MDQ6VXNlcjI2MzgzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2638321?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxzero","html_url":"https://github.com/nuxzero","followers_url":"https://api.github.com/users/nuxzero/followers","following_url":"https://api.github.com/users/nuxzero/following{/other_user}","gists_url":"https://api.github.com/users/nuxzero/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxzero/subscriptions","organizations_url":"https://api.github.com/users/nuxzero/orgs","repos_url":"https://api.github.com/users/nuxzero/repos","events_url":"https://api.github.com/users/nuxzero/events{/privacy}","received_events_url":"https://api.github.com/users/nuxzero/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pitiphong-p","id":426153,"node_id":"MDQ6VXNlcjQyNjE1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/426153?v=4","gravatar_id":"","url":"https://api.github.com/users/pitiphong-p","html_url":"https://github.com/pitiphong-p","followers_url":"https://api.github.com/users/pitiphong-p/followers","following_url":"https://api.github.com/users/pitiphong-p/following{/other_user}","gists_url":"https://api.github.com/users/pitiphong-p/gists{/gist_id}","starred_url":"https://api.github.com/users/pitiphong-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitiphong-p/subscriptions","organizations_url":"https://api.github.com/users/pitiphong-p/orgs","repos_url":"https://api.github.com/users/pitiphong-p/repos","events_url":"https://api.github.com/users/pitiphong-p/events{/privacy}","received_events_url":"https://api.github.com/users/pitiphong-p/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":176328712,"node_id":"MDU6TGFiZWwxNzYzMjg3MTI=","url":"https://api.github.com/repos/omise/omise-java/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/omise/omise-java/pulls/32/commits","review_comments_url":"https://api.github.com/repos/omise/omise-java/pulls/32/comments","review_comment_url":"https://api.github.com/repos/omise/omise-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omise/omise-java/issues/32/comments","statuses_url":"https://api.github.com/repos/omise/omise-java/statuses/7fe0ba6d641f45ad0c158fc82e4973e63ce3f88f","head":{"label":"omise:fix-client-requester-constructor","ref":"fix-client-requester-constructor","sha":"7fe0ba6d641f45ad0c158fc82e4973e63ce3f88f","user":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"repo":{"id":30686774,"node_id":"MDEwOlJlcG9zaXRvcnkzMDY4Njc3NA==","name":"omise-java","full_name":"omise/omise-java","owner":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omise/omise-java","description":"Omise Java Library","fork":false,"url":"https://api.github.com/repos/omise/omise-java","forks_url":"https://api.github.com/repos/omise/omise-java/forks","keys_url":"https://api.github.com/repos/omise/omise-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omise/omise-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omise/omise-java/teams","hooks_url":"https://api.github.com/repos/omise/omise-java/hooks","issue_events_url":"https://api.github.com/repos/omise/omise-java/issues/events{/number}","events_url":"https://api.github.com/repos/omise/omise-java/events","assignees_url":"https://api.github.com/repos/omise/omise-java/assignees{/user}","branches_url":"https://api.github.com/repos/omise/omise-java/branches{/branch}","tags_url":"https://api.github.com/repos/omise/omise-java/tags","blobs_url":"https://api.github.com/repos/omise/omise-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omise/omise-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omise/omise-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/omise/omise-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omise/omise-java/statuses/{sha}","languages_url":"https://api.github.com/repos/omise/omise-java/languages","stargazers_url":"https://api.github.com/repos/omise/omise-java/stargazers","contributors_url":"https://api.github.com/repos/omise/omise-java/contributors","subscribers_url":"https://api.github.com/repos/omise/omise-java/subscribers","subscription_url":"https://api.github.com/repos/omise/omise-java/subscription","commits_url":"https://api.github.com/repos/omise/omise-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/omise/omise-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/omise/omise-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/omise/omise-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/omise/omise-java/contents/{+path}","compare_url":"https://api.github.com/repos/omise/omise-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omise/omise-java/merges","archive_url":"https://api.github.com/repos/omise/omise-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omise/omise-java/downloads","issues_url":"https://api.github.com/repos/omise/omise-java/issues{/number}","pulls_url":"https://api.github.com/repos/omise/omise-java/pulls{/number}","milestones_url":"https://api.github.com/repos/omise/omise-java/milestones{/number}","notifications_url":"https://api.github.com/repos/omise/omise-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omise/omise-java/labels{/name}","releases_url":"https://api.github.com/repos/omise/omise-java/releases{/id}","deployments_url":"https://api.github.com/repos/omise/omise-java/deployments","created_at":"2015-02-12T05:10:50Z","updated_at":"2018-07-02T05:15:44Z","pushed_at":"2018-07-03T06:01:01Z","git_url":"git://github.com/omise/omise-java.git","ssh_url":"git@github.com:omise/omise-java.git","clone_url":"https://github.com/omise/omise-java.git","svn_url":"https://github.com/omise/omise-java","homepage":null,"size":665,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"omise:v3.0","ref":"v3.0","sha":"d68dc6e28241c36b6bffccd5f0a32551c608cb40","user":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"repo":{"id":30686774,"node_id":"MDEwOlJlcG9zaXRvcnkzMDY4Njc3NA==","name":"omise-java","full_name":"omise/omise-java","owner":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omise/omise-java","description":"Omise Java Library","fork":false,"url":"https://api.github.com/repos/omise/omise-java","forks_url":"https://api.github.com/repos/omise/omise-java/forks","keys_url":"https://api.github.com/repos/omise/omise-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omise/omise-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omise/omise-java/teams","hooks_url":"https://api.github.com/repos/omise/omise-java/hooks","issue_events_url":"https://api.github.com/repos/omise/omise-java/issues/events{/number}","events_url":"https://api.github.com/repos/omise/omise-java/events","assignees_url":"https://api.github.com/repos/omise/omise-java/assignees{/user}","branches_url":"https://api.github.com/repos/omise/omise-java/branches{/branch}","tags_url":"https://api.github.com/repos/omise/omise-java/tags","blobs_url":"https://api.github.com/repos/omise/omise-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omise/omise-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omise/omise-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/omise/omise-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omise/omise-java/statuses/{sha}","languages_url":"https://api.github.com/repos/omise/omise-java/languages","stargazers_url":"https://api.github.com/repos/omise/omise-java/stargazers","contributors_url":"https://api.github.com/repos/omise/omise-java/contributors","subscribers_url":"https://api.github.com/repos/omise/omise-java/subscribers","subscription_url":"https://api.github.com/repos/omise/omise-java/subscription","commits_url":"https://api.github.com/repos/omise/omise-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/omise/omise-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/omise/omise-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/omise/omise-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/omise/omise-java/contents/{+path}","compare_url":"https://api.github.com/repos/omise/omise-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omise/omise-java/merges","archive_url":"https://api.github.com/repos/omise/omise-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omise/omise-java/downloads","issues_url":"https://api.github.com/repos/omise/omise-java/issues{/number}","pulls_url":"https://api.github.com/repos/omise/omise-java/pulls{/number}","milestones_url":"https://api.github.com/repos/omise/omise-java/milestones{/number}","notifications_url":"https://api.github.com/repos/omise/omise-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omise/omise-java/labels{/name}","releases_url":"https://api.github.com/repos/omise/omise-java/releases{/id}","deployments_url":"https://api.github.com/repos/omise/omise-java/deployments","created_at":"2015-02-12T05:10:50Z","updated_at":"2018-07-02T05:15:44Z","pushed_at":"2018-07-03T06:01:01Z","git_url":"git://github.com/omise/omise-java.git","ssh_url":"git@github.com:omise/omise-java.git","clone_url":"https://github.com/omise/omise-java.git","svn_url":"https://github.com/omise/omise-java","homepage":null,"size":665,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omise/omise-java/pulls/32"},"html":{"href":"https://github.com/omise/omise-java/pull/32"},"issue":{"href":"https://api.github.com/repos/omise/omise-java/issues/32"},"comments":{"href":"https://api.github.com/repos/omise/omise-java/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/omise/omise-java/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/omise/omise-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omise/omise-java/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/omise/omise-java/statuses/7fe0ba6d641f45ad0c158fc82e4973e63ce3f88f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nuxzero"}}