{"action":"created","comment":{"url":"https://api.github.com/repos/afTrolle/teammates/pulls/comments/170899030","pull_request_review_id":99655708,"id":170899030,"diff_hunk":"@@ -38,4 +38,25 @@ public void checkAllParametersTestNull(){\n        boolean b = a.checkAllParameters(\"null\");\n        assertTrue(b);\n     }\n+\n+    @Test\n+    public void checkAllParametersTestNotNull(){\n+        //checkAllParmas(\"notNull\") should return true when ALL values of\n+        // startDate,endDate,startHour,endHour,startMin,endMin and timeZone\n+        // are separated from null or the whitespace character(\"\")","path":"src/test/java/teammates/test/cases/action/AdminSessionsPageActionTest.java","position":18,"original_position":18,"commit_id":"be3b2097a23fa3a4fa0ef094d00dbc843c47d0b8","original_commit_id":"be3b2097a23fa3a4fa0ef094d00dbc843c47d0b8","user":{"login":"gingemarsson","id":3681132,"avatar_url":"https://avatars1.githubusercontent.com/u/3681132?v=4","gravatar_id":"","url":"https://api.github.com/users/gingemarsson","html_url":"https://github.com/gingemarsson","followers_url":"https://api.github.com/users/gingemarsson/followers","following_url":"https://api.github.com/users/gingemarsson/following{/other_user}","gists_url":"https://api.github.com/users/gingemarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/gingemarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingemarsson/subscriptions","organizations_url":"https://api.github.com/users/gingemarsson/orgs","repos_url":"https://api.github.com/users/gingemarsson/repos","events_url":"https://api.github.com/users/gingemarsson/events{/privacy}","received_events_url":"https://api.github.com/users/gingemarsson/received_events","type":"User","site_admin":false},"body":"Shouldn't it be \"...null AND the whitespace character\"?","created_at":"2018-02-27T11:58:49Z","updated_at":"2018-02-27T11:58:49Z","html_url":"https://github.com/afTrolle/teammates/pull/75#discussion_r170899030","pull_request_url":"https://api.github.com/repos/afTrolle/teammates/pulls/75","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/afTrolle/teammates/pulls/comments/170899030"},"html":{"href":"https://github.com/afTrolle/teammates/pull/75#discussion_r170899030"},"pull_request":{"href":"https://api.github.com/repos/afTrolle/teammates/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/afTrolle/teammates/pulls/75","id":171615796,"html_url":"https://github.com/afTrolle/teammates/pull/75","diff_url":"https://github.com/afTrolle/teammates/pull/75.diff","patch_url":"https://github.com/afTrolle/teammates/pull/75.patch","issue_url":"https://api.github.com/repos/afTrolle/teammates/issues/75","number":75,"state":"open","locked":false,"title":"Test: Added AdminSessionsPageActionTest:: checkAllParametersTestNotNull (Resolves #45)","user":{"login":"Filipjansson95","id":17430769,"avatar_url":"https://avatars1.githubusercontent.com/u/17430769?v=4","gravatar_id":"","url":"https://api.github.com/users/Filipjansson95","html_url":"https://github.com/Filipjansson95","followers_url":"https://api.github.com/users/Filipjansson95/followers","following_url":"https://api.github.com/users/Filipjansson95/following{/other_user}","gists_url":"https://api.github.com/users/Filipjansson95/gists{/gist_id}","starred_url":"https://api.github.com/users/Filipjansson95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Filipjansson95/subscriptions","organizations_url":"https://api.github.com/users/Filipjansson95/orgs","repos_url":"https://api.github.com/users/Filipjansson95/repos","events_url":"https://api.github.com/users/Filipjansson95/events{/privacy}","received_events_url":"https://api.github.com/users/Filipjansson95/received_events","type":"User","site_admin":false},"body":"Tests the behavior of AdminSessionsPage::checkAllParameters with \"notNull\" as condition.\r\nResolves #45 \r\n","created_at":"2018-02-27T10:11:01Z","updated_at":"2018-02-27T11:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd8cd4c6eca9a47ae8918a6695bfcf35da86da44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":848623267,"url":"https://api.github.com/repos/afTrolle/teammates/labels/create%20tests","name":"create tests","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/afTrolle/teammates/pulls/75/commits","review_comments_url":"https://api.github.com/repos/afTrolle/teammates/pulls/75/comments","review_comment_url":"https://api.github.com/repos/afTrolle/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/afTrolle/teammates/issues/75/comments","statuses_url":"https://api.github.com/repos/afTrolle/teammates/statuses/be3b2097a23fa3a4fa0ef094d00dbc843c47d0b8","head":{"label":"afTrolle:filip/check-params-not-null","ref":"filip/check-params-not-null","sha":"be3b2097a23fa3a4fa0ef094d00dbc843c47d0b8","user":{"login":"afTrolle","id":1321086,"avatar_url":"https://avatars1.githubusercontent.com/u/1321086?v=4","gravatar_id":"","url":"https://api.github.com/users/afTrolle","html_url":"https://github.com/afTrolle","followers_url":"https://api.github.com/users/afTrolle/followers","following_url":"https://api.github.com/users/afTrolle/following{/other_user}","gists_url":"https://api.github.com/users/afTrolle/gists{/gist_id}","starred_url":"https://api.github.com/users/afTrolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afTrolle/subscriptions","organizations_url":"https://api.github.com/users/afTrolle/orgs","repos_url":"https://api.github.com/users/afTrolle/repos","events_url":"https://api.github.com/users/afTrolle/events{/privacy}","received_events_url":"https://api.github.com/users/afTrolle/received_events","type":"User","site_admin":false},"repo":{"id":122201885,"name":"teammates","full_name":"afTrolle/teammates","owner":{"login":"afTrolle","id":1321086,"avatar_url":"https://avatars1.githubusercontent.com/u/1321086?v=4","gravatar_id":"","url":"https://api.github.com/users/afTrolle","html_url":"https://github.com/afTrolle","followers_url":"https://api.github.com/users/afTrolle/followers","following_url":"https://api.github.com/users/afTrolle/following{/other_user}","gists_url":"https://api.github.com/users/afTrolle/gists{/gist_id}","starred_url":"https://api.github.com/users/afTrolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afTrolle/subscriptions","organizations_url":"https://api.github.com/users/afTrolle/orgs","repos_url":"https://api.github.com/users/afTrolle/repos","events_url":"https://api.github.com/users/afTrolle/events{/privacy}","received_events_url":"https://api.github.com/users/afTrolle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afTrolle/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/afTrolle/teammates","forks_url":"https://api.github.com/repos/afTrolle/teammates/forks","keys_url":"https://api.github.com/repos/afTrolle/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afTrolle/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afTrolle/teammates/teams","hooks_url":"https://api.github.com/repos/afTrolle/teammates/hooks","issue_events_url":"https://api.github.com/repos/afTrolle/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/afTrolle/teammates/events","assignees_url":"https://api.github.com/repos/afTrolle/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/afTrolle/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/afTrolle/teammates/tags","blobs_url":"https://api.github.com/repos/afTrolle/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afTrolle/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afTrolle/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/afTrolle/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afTrolle/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/afTrolle/teammates/languages","stargazers_url":"https://api.github.com/repos/afTrolle/teammates/stargazers","contributors_url":"https://api.github.com/repos/afTrolle/teammates/contributors","subscribers_url":"https://api.github.com/repos/afTrolle/teammates/subscribers","subscription_url":"https://api.github.com/repos/afTrolle/teammates/subscription","commits_url":"https://api.github.com/repos/afTrolle/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/afTrolle/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/afTrolle/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/afTrolle/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/afTrolle/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/afTrolle/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afTrolle/teammates/merges","archive_url":"https://api.github.com/repos/afTrolle/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afTrolle/teammates/downloads","issues_url":"https://api.github.com/repos/afTrolle/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/afTrolle/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/afTrolle/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/afTrolle/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afTrolle/teammates/labels{/name}","releases_url":"https://api.github.com/repos/afTrolle/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/afTrolle/teammates/deployments","created_at":"2018-02-20T13:30:07Z","updated_at":"2018-02-22T10:55:18Z","pushed_at":"2018-02-27T11:55:00Z","git_url":"git://github.com/afTrolle/teammates.git","ssh_url":"git@github.com:afTrolle/teammates.git","clone_url":"https://github.com/afTrolle/teammates.git","svn_url":"https://github.com/afTrolle/teammates","homepage":"https://teammatesv4.appspot.com/","size":193642,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":53,"watchers":0,"default_branch":"master"}},"base":{"label":"afTrolle:g21/extend-coverage","ref":"g21/extend-coverage","sha":"c5e15b26be9e86a758631f5de2ab104fd162db08","user":{"login":"afTrolle","id":1321086,"avatar_url":"https://avatars1.githubusercontent.com/u/1321086?v=4","gravatar_id":"","url":"https://api.github.com/users/afTrolle","html_url":"https://github.com/afTrolle","followers_url":"https://api.github.com/users/afTrolle/followers","following_url":"https://api.github.com/users/afTrolle/following{/other_user}","gists_url":"https://api.github.com/users/afTrolle/gists{/gist_id}","starred_url":"https://api.github.com/users/afTrolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afTrolle/subscriptions","organizations_url":"https://api.github.com/users/afTrolle/orgs","repos_url":"https://api.github.com/users/afTrolle/repos","events_url":"https://api.github.com/users/afTrolle/events{/privacy}","received_events_url":"https://api.github.com/users/afTrolle/received_events","type":"User","site_admin":false},"repo":{"id":122201885,"name":"teammates","full_name":"afTrolle/teammates","owner":{"login":"afTrolle","id":1321086,"avatar_url":"https://avatars1.githubusercontent.com/u/1321086?v=4","gravatar_id":"","url":"https://api.github.com/users/afTrolle","html_url":"https://github.com/afTrolle","followers_url":"https://api.github.com/users/afTrolle/followers","following_url":"https://api.github.com/users/afTrolle/following{/other_user}","gists_url":"https://api.github.com/users/afTrolle/gists{/gist_id}","starred_url":"https://api.github.com/users/afTrolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afTrolle/subscriptions","organizations_url":"https://api.github.com/users/afTrolle/orgs","repos_url":"https://api.github.com/users/afTrolle/repos","events_url":"https://api.github.com/users/afTrolle/events{/privacy}","received_events_url":"https://api.github.com/users/afTrolle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afTrolle/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/afTrolle/teammates","forks_url":"https://api.github.com/repos/afTrolle/teammates/forks","keys_url":"https://api.github.com/repos/afTrolle/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afTrolle/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afTrolle/teammates/teams","hooks_url":"https://api.github.com/repos/afTrolle/teammates/hooks","issue_events_url":"https://api.github.com/repos/afTrolle/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/afTrolle/teammates/events","assignees_url":"https://api.github.com/repos/afTrolle/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/afTrolle/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/afTrolle/teammates/tags","blobs_url":"https://api.github.com/repos/afTrolle/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afTrolle/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afTrolle/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/afTrolle/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afTrolle/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/afTrolle/teammates/languages","stargazers_url":"https://api.github.com/repos/afTrolle/teammates/stargazers","contributors_url":"https://api.github.com/repos/afTrolle/teammates/contributors","subscribers_url":"https://api.github.com/repos/afTrolle/teammates/subscribers","subscription_url":"https://api.github.com/repos/afTrolle/teammates/subscription","commits_url":"https://api.github.com/repos/afTrolle/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/afTrolle/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/afTrolle/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/afTrolle/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/afTrolle/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/afTrolle/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afTrolle/teammates/merges","archive_url":"https://api.github.com/repos/afTrolle/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afTrolle/teammates/downloads","issues_url":"https://api.github.com/repos/afTrolle/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/afTrolle/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/afTrolle/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/afTrolle/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afTrolle/teammates/labels{/name}","releases_url":"https://api.github.com/repos/afTrolle/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/afTrolle/teammates/deployments","created_at":"2018-02-20T13:30:07Z","updated_at":"2018-02-22T10:55:18Z","pushed_at":"2018-02-27T11:55:00Z","git_url":"git://github.com/afTrolle/teammates.git","ssh_url":"git@github.com:afTrolle/teammates.git","clone_url":"https://github.com/afTrolle/teammates.git","svn_url":"https://github.com/afTrolle/teammates","homepage":"https://teammatesv4.appspot.com/","size":193642,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":53,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/afTrolle/teammates/pulls/75"},"html":{"href":"https://github.com/afTrolle/teammates/pull/75"},"issue":{"href":"https://api.github.com/repos/afTrolle/teammates/issues/75"},"comments":{"href":"https://api.github.com/repos/afTrolle/teammates/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/afTrolle/teammates/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/afTrolle/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/afTrolle/teammates/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/afTrolle/teammates/statuses/be3b2097a23fa3a4fa0ef094d00dbc843c47d0b8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gingemarsson"}}