{"action":"created","issue":{"url":"https://api.github.com/repos/acquia/blt/issues/2633","repository_url":"https://api.github.com/repos/acquia/blt","labels_url":"https://api.github.com/repos/acquia/blt/issues/2633/labels{/name}","comments_url":"https://api.github.com/repos/acquia/blt/issues/2633/comments","events_url":"https://api.github.com/repos/acquia/blt/issues/2633/events","html_url":"https://github.com/acquia/blt/issues/2633","id":304892169,"number":2633,"title":"BLT git hooks symlinks are broken outside the VM","user":{"login":"timwood","id":91050,"avatar_url":"https://avatars0.githubusercontent.com/u/91050?v=4","gravatar_id":"","url":"https://api.github.com/users/timwood","html_url":"https://github.com/timwood","followers_url":"https://api.github.com/users/timwood/followers","following_url":"https://api.github.com/users/timwood/following{/other_user}","gists_url":"https://api.github.com/users/timwood/gists{/gist_id}","starred_url":"https://api.github.com/users/timwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timwood/subscriptions","organizations_url":"https://api.github.com/users/timwood/orgs","repos_url":"https://api.github.com/users/timwood/repos","events_url":"https://api.github.com/users/timwood/events{/privacy}","received_events_url":"https://api.github.com/users/timwood/received_events","type":"User","site_admin":false},"labels":[{"id":365209873,"url":"https://api.github.com/repos/acquia/blt/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-13T18:51:45Z","updated_at":"2018-03-16T13:07:29Z","closed_at":null,"author_association":"NONE","body":"My system information:\r\n* Operating system type: Mac / Drupal VM 4.8.1\r\n* Operating system version: Sierra / beet/box\r\n* BLT version: 9.0.3\r\n\r\nOutput of `blt doctor`:\r\n```\r\n$ blt doctor\r\n[warning] The xDebug extension is loaded. This will significantly decrease performance.\r\n+---------------------------+---------------------------------------------------------+\r\n| Property                  | Value                                                   |\r\n+---------------------------+---------------------------------------------------------+\r\n| %paths.%root              | /var/www/mfgov-d8/docroot                               |\r\n| %paths.%site              | sites/default                                           |\r\n| %paths.%modules           | sites/all/modules                                       |\r\n| %paths.%themes            | sites/all/themes                                        |\r\n| %paths.%config-sync       | /var/www/mfgov-d8/config/default                        |\r\n| %paths.%files             | sites/default/files                                     |\r\n| %paths.%temp              | /tmp                                                    |\r\n| %paths.%private           | /var/www/mfgov-d8/files-private                         |\r\n| admin-theme               | seven                                                   |\r\n| alias-searchpaths.0       | /var/www/mfgov-d8/drush/sites                           |\r\n| blt-version               | 9.0.3                                                   |\r\n| bootstrap                 | Successful                                              |\r\n| composer-version          | Composer version 1.6.3 2018-01-31 16:28:17              |\r\n| config-sync               | /var/www/mfgov-d8/config/default                        |\r\n| db-driver                 | mysql                                                   |\r\n| db-hostname               | localhost                                               |\r\n| db-name                   | drupal                                                  |\r\n| db-password               | drupal                                                  |\r\n| db-port                   | 3306                                                    |\r\n| db-status                 | Connected                                               |\r\n| db-username               | drupal                                                  |\r\n| drupal-settings-file      | sites/default/settings.php                              |\r\n| drupal-version            | 8.5.0                                                   |\r\n| drush-alias-files.0       | /var/www/mfgov-d8/drush/sites/mfgov.site.yml            |\r\n| drush-conf.0              | /var/www/mfgov-d8/vendor/drush/drush/drush.yml          |\r\n| drush-conf.1              | /var/www/mfgov-d8/drush/drush.yml                       |\r\n| drush-conf.2              | /var/www/mfgov-d8/docroot/sites/default/local.drush.yml |\r\n| drush-script              | /var/www/mfgov-d8/vendor/bin/drush                      |\r\n| drush-temp                | /tmp                                                    |\r\n| drush-version             | 9.2.1                                                   |\r\n| files                     | sites/default/files                                     |\r\n| install-profile           | lightning                                               |\r\n| modules                   | sites/all/modules                                       |\r\n| php-bin                   | /usr/bin/php7.1                                         |\r\n| php-conf.0                | /etc/php/7.1/cli/php.ini                                |\r\n| php-os                    | Linux                                                   |\r\n| private                   | /var/www/mfgov-d8/files-private                         |\r\n| root                      | /var/www/mfgov-d8/docroot                               |\r\n| site                      | sites/default                                           |\r\n| stacks.drupal-vm.inited   | true                                                    |\r\n| stacks.dev-desktop.inited | false                                                   |\r\n| temp                      | /tmp                                                    |\r\n| theme                     | uswds_mfgov                                             |\r\n| themes                    | sites/all/themes                                        |\r\n| uri                       | https://local.manufacturing.test                        |\r\n+---------------------------+---------------------------------------------------------+\r\n+--------------------------------------+-----------------------------------------------------------+\r\n| Check                                | Problem                                                   |\r\n+--------------------------------------+-----------------------------------------------------------+\r\n| NodeCheck:checkNodeVersionFileExists | Neither .nvmrc nor .node-version file found in repo root. |\r\n| WebUriCheck:checkHttps               | The SSL certificate for your local site appears to be     |\r\n|                                      | invalid for https://local.manufacturing.test.             |\r\n+--------------------------------------+-----------------------------------------------------------+\r\n[error]  BLT Doctor discovered one or more critical issues. \r\n```\r\n\r\nWhen I run this command (from outside the VM):\r\n```\r\ngit commit -m \"This is my invalid, not very good commit message?\"\r\n```\r\n\r\nI get the following output (a successful commit, but no pre-commit checks or commit message validation):\r\n```\r\n[OAM-131 a733b22] This is my invalid, not very good commit message?\r\n 1 file changed, 1 insertion(+)\r\n```\r\n\r\nAnd I expected this to happen:\r\nGit to complain about my improperly formatted commit message as defined in .git/hooks/commit-msg (a symlink to /var/www/mfgov-d8/vendor/acquia/blt/scripts/git-hooks/commit-msg). Obviously this symlink is bad/incorrect outside the VM.\r\n\r\nDoes BLT recommend that even git commits be performed inside the VM?\r\n\r\nCould the BLT Robo task which creates the symlink make it a relative one, so it will work inside and outside the VM?"},"comment":{"url":"https://api.github.com/repos/acquia/blt/issues/comments/373707632","html_url":"https://github.com/acquia/blt/issues/2633#issuecomment-373707632","issue_url":"https://api.github.com/repos/acquia/blt/issues/2633","id":373707632,"user":{"login":"grasmash","id":539205,"avatar_url":"https://avatars0.githubusercontent.com/u/539205?v=4","gravatar_id":"","url":"https://api.github.com/users/grasmash","html_url":"https://github.com/grasmash","followers_url":"https://api.github.com/users/grasmash/followers","following_url":"https://api.github.com/users/grasmash/following{/other_user}","gists_url":"https://api.github.com/users/grasmash/gists{/gist_id}","starred_url":"https://api.github.com/users/grasmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grasmash/subscriptions","organizations_url":"https://api.github.com/users/grasmash/orgs","repos_url":"https://api.github.com/users/grasmash/repos","events_url":"https://api.github.com/users/grasmash/events{/privacy}","received_events_url":"https://api.github.com/users/grasmash/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T13:07:29Z","updated_at":"2018-03-16T13:07:29Z","author_association":"COLLABORATOR","body":"Hm. We're using a stock Symfony filesystem method the determine the location: https://github.com/acquia/blt/commit/741cfbf359205f8ba4679a5a971532ae1ade51c0#diff-82f049ca6fb91a65494ab7f81bdb45b0R223\r\n\r\nNot sure why that wouldn't work.\r\n\r\nSeems like we need to update https://github.com/acquia/blt/blob/9.x/tests/phpunit/BltProject/SetupGitHooksTest.php#L19 to follow the symlink and ensure that the source file exists, then work backwards from there."}}
{"actor":{"display_login":"grasmash"}}