{"action":"created","issue":{"url":"https://api.github.com/repos/ESCOMP/ctsm/issues/66","repository_url":"https://api.github.com/repos/ESCOMP/ctsm","labels_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/66/comments","events_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/66/events","html_url":"https://github.com/ESCOMP/ctsm/issues/66","id":282647935,"number":66,"title":"Clm45BgcCrop case dies due to negative leafn","user":{"login":"billsacks","id":6266741,"avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"labels":[{"id":780654193,"url":"https://api.github.com/repos/ESCOMP/ctsm/labels/severity:%20critical","name":"severity: critical","color":"ef13e8","default":false},{"id":831439459,"url":"https://api.github.com/repos/ESCOMP/ctsm/labels/type:%20bug%20-%20other","name":"type: bug - other","color":"cc0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ESCOMP/ctsm/milestones/1","html_url":"https://github.com/ESCOMP/ctsm/milestone/1","labels_url":"https://api.github.com/repos/ESCOMP/ctsm/milestones/1/labels","id":2984067,"number":1,"title":"clm5","description":null,"creator":{"login":"billsacks","id":6266741,"avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"open_issues":127,"closed_issues":8,"state":"open","created_at":"2017-12-16T20:05:45Z","updated_at":"2018-02-09T20:51:58Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2017-12-16T20:21:16Z","updated_at":"2018-02-23T22:37:39Z","closed_at":null,"author_association":"OWNER","body":"**Bill Sacks < sacks@ucar.edu > - 2017-07-06 13:21:37 -0600**\n**Bugzilla Id:** [2489](http://bugz.cgd.ucar.edu/show_bug.cgi?id=2489)\n**Bugzilla CC:**  andre@ucar.edu,  dlawren@ucar.edu,  dll@ucar.edu,  oleson@ucar.edu,  rfisher@ucar.edu, \n\nIn the compsetchanges branch (soon to be clm4_5_16_r249), this test is dying:\n\nERP_D.f10_f10_musgs.IHistClm50Bgc.yellowstone_gnu.clm-decStart\n\nwith message:\n\n28: ERROR: Carbon or Nitrogen patch negative =    30.5688132018826\n28:  -6.01119011968369\n28: ERROR: limits =   -60.0000000000000       -6.00000000000000\n28: ENDRUN:\n28: ERROR: carbon or nitrogen state critically negative ERROR in CNPrecisionControl\n28: Mod.F90 at line 207\n\nThis is from this call:\n\n      ! leaf C and N\n      call TruncateCandNStates( bounds, filter_soilp, num_soilp, cs%leafc_patch(bounds%begp:bounds%endp), &\n                                ns%leafn_patch(bounds%begp:bounds%endp), &\n                                pc(bounds%begp:), pn(bounds%begp:), __LINE__, &\n                                c13=c13cs%leafc_patch, c14=c14cs%leafc_patch, &\n                                pc13=pc13(bounds%begp:), pc14=pc14(bounds%begp:) )\n\nwhich I'm pretty sure means that the problem is in leafn_patch."},"comment":{"url":"https://api.github.com/repos/ESCOMP/ctsm/issues/comments/368158628","html_url":"https://github.com/ESCOMP/ctsm/issues/66#issuecomment-368158628","issue_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/66","id":368158628,"user":{"login":"ekluzek","id":11545792,"avatar_url":"https://avatars1.githubusercontent.com/u/11545792?v=4","gravatar_id":"","url":"https://api.github.com/users/ekluzek","html_url":"https://github.com/ekluzek","followers_url":"https://api.github.com/users/ekluzek/followers","following_url":"https://api.github.com/users/ekluzek/following{/other_user}","gists_url":"https://api.github.com/users/ekluzek/gists{/gist_id}","starred_url":"https://api.github.com/users/ekluzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekluzek/subscriptions","organizations_url":"https://api.github.com/users/ekluzek/orgs","repos_url":"https://api.github.com/users/ekluzek/repos","events_url":"https://api.github.com/users/ekluzek/events{/privacy}","received_events_url":"https://api.github.com/users/ekluzek/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T22:37:39Z","updated_at":"2018-02-23T22:37:39Z","author_association":"CONTRIBUTOR","body":"These are the changes needed to get the namelist working correctly: \r\n\r\n```\r\ndiff --git a/bld/CLMBuildNamelist.pm b/bld/CLMBuildNamelist.pm\r\nindex a831476..626a0bc 100755\r\n--- a/bld/CLMBuildNamelist.pm\r\n+++ b/bld/CLMBuildNamelist.pm\r\n@@ -2105,7 +2105,7 @@ sub setup_logic_cnfire {\r\n sub setup_logic_cnprec {\r\n   my ($opts, $nl_flags, $definition, $defaults, $nl, $physv) = @_;\r\n \r\n-  if ( $physv->as_long() >= $physv->as_long(\"clm5_0\") && &value_is_true($nl->get_value('use_cn')) ) {\r\n+  if ( $physv->as_long() >= $physv->as_long(\"clm4_5\") && &value_is_true($nl_flags->{'use_cn'}) ) {\r\n      add_default($opts, $nl_flags->{'inputdata_rootdir'}, $definition, $defaults,\r\n                  $nl, 'ncrit', 'use_cn'=>$nl_flags->{'use_cn'});\r\n      add_default($opts, $nl_flags->{'inputdata_rootdir'}, $definition, $defaults,\r\ndiff --git a/bld/namelist_files/namelist_defaults_clm4_5.xml b/bld/namelist_files/namelist_defaults_clm4_5.xml\r\nindex f78b54e..325c358 100644\r\n--- a/bld/namelist_files/namelist_defaults_clm4_5.xml\r\n+++ b/bld/namelist_files/namelist_defaults_clm4_5.xml\r\n@@ -434,6 +434,7 @@ attributes from the config_cache.xml file (with keys converted to upper-case).\r\n <use_nguardrail phys=\"clm5_0\" use_cn=\".true.\" >.true.</use_nguardrail>\r\n \r\n <ncrit    phys=\"clm5_0\" use_cn=\".true.\">1.d-9</ncrit>\r\n+<ncrit    phys=\"clm4_5\" use_cn=\".true.\">1.d-8</ncrit>\r\n <cnegcrit phys=\"clm5_0\" use_cn=\".true.\">-6.d+1</cnegcrit>\r\n <nnegcrit phys=\"clm5_0\" use_cn=\".true.\">-6.d+0</nnegcrit>\r\n <cnegcrit phys=\"clm4_5\" use_cn=\".true.\">-6.d+2</cnegcrit>\r\n\r\n```"}}
{"actor":{"display_login":"ekluzek"}}