{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/168","repository_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/168/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/168/events","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/168","id":317627090,"number":168,"title":"Update selection models to work with simplified HasValue","user":{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-04-25T13:25:29Z","updated_at":"2018-04-26T13:44:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/pulls/168","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/168","diff_url":"https://github.com/vaadin/vaadin-grid-flow/pull/168.diff","patch_url":"https://github.com/vaadin/vaadin-grid-flow/pull/168.patch"},"body":"Makes things compile again after vaadin/flow#4003\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/168)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/comments/384645948","html_url":"https://github.com/vaadin/vaadin-grid-flow/pull/168#issuecomment-384645948","issue_url":"https://api.github.com/repos/vaadin/vaadin-grid-flow/issues/168","id":384645948,"user":{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T13:44:36Z","updated_at":"2018-04-26T13:44:36Z","author_association":"MEMBER","body":"\n\n\n\nReview status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n*[a discussion](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/168#-LAx91gnCwz9BtH_13wG:-LB1B9hs2w3dTes10Ay8:b-jquc02) (no related file):*\n<details><summary><i>Previously, gilberto-torrezan (Gilberto Torrezan) wrote…</i></summary><blockquote>\n\nThe header/footer rows patch changed a lot of stuff inside Grid, this will need to be rebased.\n</blockquote></details>\n\nThere are no merge conflicts, but this patch won't compile until vaadin/flow#4003 has been merged and CheckBox and TextField have been updated to use new generated components (and maybe also recompiled against a Flow after merging vaadin/flow#4003).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/vaadin-grid-flow/168)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Legioth"}}