{"action":"created","issue":{"url":"https://api.github.com/repos/reactos/reactos/issues/308","repository_url":"https://api.github.com/repos/reactos/reactos","labels_url":"https://api.github.com/repos/reactos/reactos/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/308/comments","events_url":"https://api.github.com/repos/reactos/reactos/issues/308/events","html_url":"https://github.com/reactos/reactos/pull/308","id":290267673,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0MTcyMDY1","number":308,"title":"[USBSTOR_NEW] Bring-in the USB Storage device driver by Vadim Galyant.","user":{"login":"AmineKhaldi","id":352225,"node_id":"MDQ6VXNlcjM1MjIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/352225?v=4","gravatar_id":"","url":"https://api.github.com/users/AmineKhaldi","html_url":"https://github.com/AmineKhaldi","followers_url":"https://api.github.com/users/AmineKhaldi/followers","following_url":"https://api.github.com/users/AmineKhaldi/following{/other_user}","gists_url":"https://api.github.com/users/AmineKhaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/AmineKhaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmineKhaldi/subscriptions","organizations_url":"https://api.github.com/users/AmineKhaldi/orgs","repos_url":"https://api.github.com/users/AmineKhaldi/repos","events_url":"https://api.github.com/users/AmineKhaldi/events{/privacy}","received_events_url":"https://api.github.com/users/AmineKhaldi/received_events","type":"User","site_admin":false},"labels":[{"id":709291171,"node_id":"MDU6TGFiZWw3MDkyOTExNzE=","url":"https://api.github.com/repos/reactos/reactos/labels/enhancement","name":"enhancement","color":"59f9ac","default":true},{"id":893623856,"node_id":"MDU6TGFiZWw4OTM2MjM4NTY=","url":"https://api.github.com/repos/reactos/reactos/labels/review%20pending","name":"review pending","color":"f2a89b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/reactos/reactos/milestones/1","html_url":"https://github.com/reactos/reactos/milestone/1","labels_url":"https://api.github.com/repos/reactos/reactos/milestones/1/labels","id":3053677,"node_id":"MDk6TWlsZXN0b25lMzA1MzY3Nw==","number":1,"title":"USB Bringup","description":null,"creator":{"login":"AmineKhaldi","id":352225,"node_id":"MDQ6VXNlcjM1MjIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/352225?v=4","gravatar_id":"","url":"https://api.github.com/users/AmineKhaldi","html_url":"https://github.com/AmineKhaldi","followers_url":"https://api.github.com/users/AmineKhaldi/followers","following_url":"https://api.github.com/users/AmineKhaldi/following{/other_user}","gists_url":"https://api.github.com/users/AmineKhaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/AmineKhaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmineKhaldi/subscriptions","organizations_url":"https://api.github.com/users/AmineKhaldi/orgs","repos_url":"https://api.github.com/users/AmineKhaldi/repos","events_url":"https://api.github.com/users/AmineKhaldi/events{/privacy}","received_events_url":"https://api.github.com/users/AmineKhaldi/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2018-01-22T13:00:21Z","updated_at":"2018-09-10T07:05:36Z","due_on":null,"closed_at":null},"comments":20,"created_at":"2018-01-21T12:09:30Z","updated_at":"2018-09-10T10:14:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/308","html_url":"https://github.com/reactos/reactos/pull/308","diff_url":"https://github.com/reactos/reactos/pull/308.diff","patch_url":"https://github.com/reactos/reactos/pull/308.patch"},"body":"This is based on the existing usbstor driver."},"comment":{"url":"https://api.github.com/repos/reactos/reactos/issues/comments/419862001","html_url":"https://github.com/reactos/reactos/pull/308#issuecomment-419862001","issue_url":"https://api.github.com/repos/reactos/reactos/issues/308","id":419862001,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTg2MjAwMQ==","user":{"login":"ThFabba","id":18138474,"node_id":"MDQ6VXNlcjE4MTM4NDc0","avatar_url":"https://avatars3.githubusercontent.com/u/18138474?v=4","gravatar_id":"","url":"https://api.github.com/users/ThFabba","html_url":"https://github.com/ThFabba","followers_url":"https://api.github.com/users/ThFabba/followers","following_url":"https://api.github.com/users/ThFabba/following{/other_user}","gists_url":"https://api.github.com/users/ThFabba/gists{/gist_id}","starred_url":"https://api.github.com/users/ThFabba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThFabba/subscriptions","organizations_url":"https://api.github.com/users/ThFabba/orgs","repos_url":"https://api.github.com/users/ThFabba/repos","events_url":"https://api.github.com/users/ThFabba/events{/privacy}","received_events_url":"https://api.github.com/users/ThFabba/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T10:14:50Z","updated_at":"2018-09-10T10:14:50Z","author_association":"CONTRIBUTOR","body":"I'm not sure how to proceed with this. The history is a mess that gives no clue as to the reason or even the context for these changes; some changes are completely irrelevant and are simply a matter of style; and it's impossible to tell which of the functional changes are just unimportant improvements (like power IRP handling) and which are required for USB boot.\r\n\r\nUnless someone has a better idea, here's what I'm gonna do:\r\n* pick out changes that are obvious to me and merge them directly to master, then rebase this branch\r\n* because this approach would require making all changes in master to both usbstor and usbstor_new, I'll also likely get rid of usbstor_new and rebase these changes to be against usbstor instead\r\n* find changes that I understand code-wise but have no context for, and try to group them into logical commits\r\n* for each logical commit, either try to create a test that shows its correctness or experimentally show that it is required for USB boot, then merge it to master based on those results\r\n\r\nThe timeline for this is going to be YEARS, and there is no guarantee that I will ever finish this process, or even make consistent process. So if someone wants to take this over or offer an improved approach, I'm all ears!"}}
{"actor":{"display_login":"ThFabba"}}