{"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/165695949","pull_request_review_id":93680767,"id":165695949,"diff_hunk":"@@ -100,12 +91,17 @@ public void setRemoteAddr(String remoteIpAddress) {\n      *  on which the request was received.\n      */\n     public String getLocalAddr() {\n-        if (null == localAddress.getAddress()) {\n-            return null;\n-        }\n+        InetSocketAddress localAddress = localAddress();\n+        if (localAddress.getAddress() == null) return null;\n         return localAddress.getAddress().getHostAddress();\n     }\n \n+    protected InetSocketAddress localAddress() {","path":"jdisc_http_service/src/main/java/com/yahoo/jdisc/http/filter/DiscFilterRequest.java","position":null,"original_position":52,"commit_id":"5164e5516582bdb33be21400c788780f832fbdc4","original_commit_id":"72cf365f4843064f8e413e381cff44ec47210b1a","user":{"login":"bratseth","id":16574012,"avatar_url":"https://avatars2.githubusercontent.com/u/16574012?v=4","gravatar_id":"","url":"https://api.github.com/users/bratseth","html_url":"https://github.com/bratseth","followers_url":"https://api.github.com/users/bratseth/followers","following_url":"https://api.github.com/users/bratseth/following{/other_user}","gists_url":"https://api.github.com/users/bratseth/gists{/gist_id}","starred_url":"https://api.github.com/users/bratseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bratseth/subscriptions","organizations_url":"https://api.github.com/users/bratseth/orgs","repos_url":"https://api.github.com/users/bratseth/repos","events_url":"https://api.github.com/users/bratseth/events{/privacy}","received_events_url":"https://api.github.com/users/bratseth/received_events","type":"User","site_admin":false},"body":"My reasoning was that the field was protected for a reason, but ok.","created_at":"2018-02-02T16:42:58Z","updated_at":"2018-02-02T16:42:58Z","html_url":"https://github.com/vespa-engine/vespa/pull/4902#discussion_r165695949","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/165695949"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/4902#discussion_r165695949"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902"}},"in_reply_to_id":165671047},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902","id":166816348,"html_url":"https://github.com/vespa-engine/vespa/pull/4902","diff_url":"https://github.com/vespa-engine/vespa/pull/4902.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/4902.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/4902","number":4902,"state":"open","locked":false,"title":"Skip DNS lookup that is not used","user":{"login":"bratseth","id":16574012,"avatar_url":"https://avatars2.githubusercontent.com/u/16574012?v=4","gravatar_id":"","url":"https://api.github.com/users/bratseth","html_url":"https://github.com/bratseth","followers_url":"https://api.github.com/users/bratseth/followers","following_url":"https://api.github.com/users/bratseth/following{/other_user}","gists_url":"https://api.github.com/users/bratseth/gists{/gist_id}","starred_url":"https://api.github.com/users/bratseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bratseth/subscriptions","organizations_url":"https://api.github.com/users/bratseth/orgs","repos_url":"https://api.github.com/users/bratseth/repos","events_url":"https://api.github.com/users/bratseth/events{/privacy}","received_events_url":"https://api.github.com/users/bratseth/received_events","type":"User","site_admin":false},"body":"Look up the local address on demand only.\r\nSince this field was (errounously) made protected,\r\nthis is strictly an API change, however I could not find any use\r\nof the field in any known repo using Vespa.\r\n\r\ncc @baldersheim ","created_at":"2018-02-02T14:32:32Z","updated_at":"2018-02-02T16:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70825ebdc2d5f7617d4ec87a802da069570f5a1a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/4902/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/5164e5516582bdb33be21400c788780f832fbdc4","head":{"label":"vespa-engine:bratseth/skip-unnecessary-dns-lookup","ref":"bratseth/skip-unnecessary-dns-lookup","sha":"5164e5516582bdb33be21400c788780f832fbdc4","user":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-02-02T08:31:40Z","pushed_at":"2018-02-02T16:42:02Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":60224,"stargazers_count":2417,"watchers_count":2417,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":272,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":272,"open_issues":39,"watchers":2417,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"f8da381ac81190935eb1a5d25e5c4bb522e99d85","user":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-02-02T08:31:40Z","pushed_at":"2018-02-02T16:42:02Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":60224,"stargazers_count":2417,"watchers_count":2417,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":272,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":272,"open_issues":39,"watchers":2417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/4902"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/4902"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/4902/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/4902/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/5164e5516582bdb33be21400c788780f832fbdc4"}},"author_association":"OWNER"}}
{"actor":{"display_login":"bratseth"}}