{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/217534726","pull_request_review_id":155273158,"id":217534726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzUzNDcyNg==","diff_hunk":"@@ -508,6 +500,32 @@ internal NamespaceOrTypeOrAliasSymbolWithAnnotations BindNamespaceOrTypeOrAliasS\n                 default:\n                     throw ExceptionUtilities.UnexpectedValue(syntax.Kind());\n             }\n+\n+            void reportNullableReferenceTypesIfNeeded(SyntaxToken questionToken, TypeSymbolWithAnnotations typeArgument = default)\n+            {\n+                if (InExecutableBinder)\n+                {\n+                    // Inside a method body or other executable code, we can pull on NonNullTypes symbol or question IsValueType without causing cycles.\n+                    // We still need to delay that check when binding in an attribute argument\n+                    if (!ShouldCheckConstraintsNullability)\n+                    {\n+                        diagnostics.Add(new LazyMissingNonNullTypesContextDiagnosticInfo(Compilation, NonNullTypesContext, typeArgument), questionToken.GetLocation());\n+                    }","path":"src/Compilers/CSharp/Portable/Binder/Binder_Symbols.cs","position":55,"original_position":55,"commit_id":"f1636e49308cdc5dd7ed4dc4e0fed3b985a8b8fe","original_commit_id":"f1636e49308cdc5dd7ed4dc4e0fed3b985a8b8fe","user":{"login":"AlekseyTs","id":10522107,"node_id":"MDQ6VXNlcjEwNTIyMTA3","avatar_url":"https://avatars0.githubusercontent.com/u/10522107?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"> Please combine these checks to reduce the number of code paths:\r\n\r\nI will follow up on this in the next PR\r\n\r\n---\r\nIn reply to: [217506307](https://github.com/dotnet/roslyn/pull/29809#discussion_r217506307) [](ancestors = 217506307,217495231)","created_at":"2018-09-13T21:08:00Z","updated_at":"2018-09-13T21:08:00Z","html_url":"https://github.com/dotnet/roslyn/pull/29809#discussion_r217534726","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29809","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/217534726"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29809#discussion_r217534726"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29809"}},"in_reply_to_id":217495231},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/29809","id":215040933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDQwOTMz","html_url":"https://github.com/dotnet/roslyn/pull/29809","diff_url":"https://github.com/dotnet/roslyn/pull/29809.diff","patch_url":"https://github.com/dotnet/roslyn/pull/29809.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/29809","number":29809,"state":"open","locked":false,"title":"Support Object type as a generic type constraint.","user":{"login":"AlekseyTs","id":10522107,"node_id":"MDQ6VXNlcjEwNTIyMTA3","avatar_url":"https://avatars0.githubusercontent.com/u/10522107?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-12T17:35:05Z","updated_at":"2018-09-13T21:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e17e4bde07abfec685157d830e1f3c0be30a9ecd","assignee":{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":344899605,"node_id":"MDU6TGFiZWwzNDQ4OTk2MDU=","url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Nullable%20Reference%20Types","name":"New Language Feature - Nullable Reference Types","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1147,"closed_issues":646,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-09-13T20:37:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29809/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29809/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/29809/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/f1636e49308cdc5dd7ed4dc4e0fed3b985a8b8fe","head":{"label":"AlekseyTs:ObjectGenericTypeConstraint","ref":"ObjectGenericTypeConstraint","sha":"f1636e49308cdc5dd7ed4dc4e0fed3b985a8b8fe","user":{"login":"AlekseyTs","id":10522107,"node_id":"MDQ6VXNlcjEwNTIyMTA3","avatar_url":"https://avatars0.githubusercontent.com/u/10522107?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"repo":{"id":32701567,"node_id":"MDEwOlJlcG9zaXRvcnkzMjcwMTU2Nw==","name":"roslyn","full_name":"AlekseyTs/roslyn","owner":{"login":"AlekseyTs","id":10522107,"node_id":"MDQ6VXNlcjEwNTIyMTA3","avatar_url":"https://avatars0.githubusercontent.com/u/10522107?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlekseyTs/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/AlekseyTs/roslyn","forks_url":"https://api.github.com/repos/AlekseyTs/roslyn/forks","keys_url":"https://api.github.com/repos/AlekseyTs/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlekseyTs/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlekseyTs/roslyn/teams","hooks_url":"https://api.github.com/repos/AlekseyTs/roslyn/hooks","issue_events_url":"https://api.github.com/repos/AlekseyTs/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/AlekseyTs/roslyn/events","assignees_url":"https://api.github.com/repos/AlekseyTs/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/AlekseyTs/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/AlekseyTs/roslyn/tags","blobs_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlekseyTs/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/AlekseyTs/roslyn/languages","stargazers_url":"https://api.github.com/repos/AlekseyTs/roslyn/stargazers","contributors_url":"https://api.github.com/repos/AlekseyTs/roslyn/contributors","subscribers_url":"https://api.github.com/repos/AlekseyTs/roslyn/subscribers","subscription_url":"https://api.github.com/repos/AlekseyTs/roslyn/subscription","commits_url":"https://api.github.com/repos/AlekseyTs/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlekseyTs/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlekseyTs/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlekseyTs/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/AlekseyTs/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlekseyTs/roslyn/merges","archive_url":"https://api.github.com/repos/AlekseyTs/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlekseyTs/roslyn/downloads","issues_url":"https://api.github.com/repos/AlekseyTs/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/AlekseyTs/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/AlekseyTs/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/AlekseyTs/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlekseyTs/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/AlekseyTs/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/AlekseyTs/roslyn/deployments","created_at":"2015-03-22T23:43:35Z","updated_at":"2016-01-27T17:38:54Z","pushed_at":"2018-09-12T21:32:56Z","git_url":"git://github.com/AlekseyTs/roslyn.git","ssh_url":"git@github.com:AlekseyTs/roslyn.git","clone_url":"https://github.com/AlekseyTs/roslyn.git","svn_url":"https://github.com/AlekseyTs/roslyn","homepage":"","size":376244,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:features/NullableReferenceTypes","ref":"features/NullableReferenceTypes","sha":"1d7d5d73352ef0e36b00333e659aeced3b924d8a","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-09-13T17:50:45Z","pushed_at":"2018-09-13T20:55:50Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":447120,"stargazers_count":9830,"watchers_count":9830,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2344,"mirror_url":null,"archived":false,"open_issues_count":5081,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2344,"open_issues":5081,"watchers":9830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29809"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29809"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29809"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29809/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29809/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29809/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/f1636e49308cdc5dd7ed4dc4e0fed3b985a8b8fe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlekseyTs"}}