{"action":"created","issue":{"url":"https://api.github.com/repos/google/filament/issues/185","repository_url":"https://api.github.com/repos/google/filament","labels_url":"https://api.github.com/repos/google/filament/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/google/filament/issues/185/comments","events_url":"https://api.github.com/repos/google/filament/issues/185/events","html_url":"https://github.com/google/filament/pull/185","id":355713607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTc5MDI0","number":185,"title":"Visual studio compiler","user":{"login":"sergeyreznik","id":1440331,"node_id":"MDQ6VXNlcjE0NDAzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1440331?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyreznik","html_url":"https://github.com/sergeyreznik","followers_url":"https://api.github.com/users/sergeyreznik/followers","following_url":"https://api.github.com/users/sergeyreznik/following{/other_user}","gists_url":"https://api.github.com/users/sergeyreznik/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyreznik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyreznik/subscriptions","organizations_url":"https://api.github.com/users/sergeyreznik/orgs","repos_url":"https://api.github.com/users/sergeyreznik/repos","events_url":"https://api.github.com/users/sergeyreznik/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyreznik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-30T19:00:26Z","updated_at":"2018-09-04T05:54:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/google/filament/pulls/185","html_url":"https://github.com/google/filament/pull/185","diff_url":"https://github.com/google/filament/pull/185.diff","patch_url":"https://github.com/google/filament/pull/185.patch"},"body":"There is still several unresolved issues:\r\n1) sdl2main library - not being added to project and linked to the sample projects, causing linker errors;\r\n2) when adding sdl2main manually, there a stack overflow in unterminated recursive calls to `robin_hash::insert_value`;\r\n3) fxaa shader is way too big, to fit in one sequential string in msvc (see details [here](https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2026?view=vs-2017))\r\n4) not all clang directives ported to msvc, those are marked with `MSVC_PORT_TODO` comment."},"comment":{"url":"https://api.github.com/repos/google/filament/issues/comments/418249263","html_url":"https://github.com/google/filament/pull/185#issuecomment-418249263","issue_url":"https://api.github.com/repos/google/filament/issues/185","id":418249263,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODI0OTI2Mw==","user":{"login":"sergeyreznik","id":1440331,"node_id":"MDQ6VXNlcjE0NDAzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1440331?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyreznik","html_url":"https://github.com/sergeyreznik","followers_url":"https://api.github.com/users/sergeyreznik/followers","following_url":"https://api.github.com/users/sergeyreznik/following{/other_user}","gists_url":"https://api.github.com/users/sergeyreznik/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyreznik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyreznik/subscriptions","organizations_url":"https://api.github.com/users/sergeyreznik/orgs","repos_url":"https://api.github.com/users/sergeyreznik/repos","events_url":"https://api.github.com/users/sergeyreznik/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyreznik/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T05:54:20Z","updated_at":"2018-09-04T05:54:20Z","author_association":"NONE","body":"@shartte this PR should not be merged anyway :)\r\nBut I completely agree with you about hiding attributes under the defines.\r\nAnother similar but more important issue is compiler flags, explicitly defined in CMake."}}
{"actor":{"display_login":"sergeyreznik"}}