{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments/241840531","pull_request_review_id":185221250,"id":241840531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTg0MDUzMQ==","diff_hunk":"@@ -42,12 +50,18 @@ if [ -z \"${TAG_NAME}\" ]; then\n   TAG_NAME=$(date +v%Y%m%d)-$(git describe --tags --always --dirty)-$(git diff | shasum -a256 | cut -c -6)\n fi\n \n+TF_VERSION=1.6.0","path":"components/kubeflow/dnntrainer/build_image.sh","position":null,"original_position":39,"commit_id":"1dd1a2ec6e85d759f05425c44d78e23fb8f4b4f9","original_commit_id":"4c8c252cbf8b95ca55b387a0d99cad96667facf5","user":{"login":"hongye-sun","id":43763191,"node_id":"MDQ6VXNlcjQzNzYzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/43763191?v=4","gravatar_id":"","url":"https://api.github.com/users/hongye-sun","html_url":"https://github.com/hongye-sun","followers_url":"https://api.github.com/users/hongye-sun/followers","following_url":"https://api.github.com/users/hongye-sun/following{/other_user}","gists_url":"https://api.github.com/users/hongye-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/hongye-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongye-sun/subscriptions","organizations_url":"https://api.github.com/users/hongye-sun/orgs","repos_url":"https://api.github.com/users/hongye-sun/repos","events_url":"https://api.github.com/users/hongye-sun/events{/privacy}","received_events_url":"https://api.github.com/users/hongye-sun/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-12-14T18:01:52Z","updated_at":"2018-12-14T18:01:52Z","html_url":"https://github.com/kubeflow/pipelines/pull/530#discussion_r241840531","pull_request_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/530","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments/241840531"},"html":{"href":"https://github.com/kubeflow/pipelines/pull/530#discussion_r241840531"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/530"}},"in_reply_to_id":241296397},"pull_request":{"url":"https://api.github.com/repos/kubeflow/pipelines/pulls/530","id":238223546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjIzNTQ2","html_url":"https://github.com/kubeflow/pipelines/pull/530","diff_url":"https://github.com/kubeflow/pipelines/pull/530.diff","patch_url":"https://github.com/kubeflow/pipelines/pull/530.patch","issue_url":"https://api.github.com/repos/kubeflow/pipelines/issues/530","number":530,"state":"open","locked":false,"title":"Support GPU image for dnntrainer component","user":{"login":"hongye-sun","id":43763191,"node_id":"MDQ6VXNlcjQzNzYzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/43763191?v=4","gravatar_id":"","url":"https://api.github.com/users/hongye-sun","html_url":"https://github.com/hongye-sun","followers_url":"https://api.github.com/users/hongye-sun/followers","following_url":"https://api.github.com/users/hongye-sun/following{/other_user}","gists_url":"https://api.github.com/users/hongye-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/hongye-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongye-sun/subscriptions","organizations_url":"https://api.github.com/users/hongye-sun/orgs","repos_url":"https://api.github.com/users/hongye-sun/repos","events_url":"https://api.github.com/users/hongye-sun/events{/privacy}","received_events_url":"https://api.github.com/users/hongye-sun/received_events","type":"User","site_admin":false},"body":"Changes:\r\n* Parameterize dnntrainer build script to support build gpu image\r\n* Update dnntrainer dockerfile to base from tensorflow image\r\n* Update build script to push gpu image to gcr and update tags in release script\r\n\r\nFuture changes:\r\n* Update tfx taxi predict sample and notebook sample to support gpu mode\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/pipelines/530)\n<!-- Reviewable:end -->\n","created_at":"2018-12-13T00:02:47Z","updated_at":"2018-12-14T18:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14778d6d90c792b3d68de3c80465c11e44c3bea2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gaoning777","id":3826739,"node_id":"MDQ6VXNlcjM4MjY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3826739?v=4","gravatar_id":"","url":"https://api.github.com/users/gaoning777","html_url":"https://github.com/gaoning777","followers_url":"https://api.github.com/users/gaoning777/followers","following_url":"https://api.github.com/users/gaoning777/following{/other_user}","gists_url":"https://api.github.com/users/gaoning777/gists{/gist_id}","starred_url":"https://api.github.com/users/gaoning777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaoning777/subscriptions","organizations_url":"https://api.github.com/users/gaoning777/orgs","repos_url":"https://api.github.com/users/gaoning777/repos","events_url":"https://api.github.com/users/gaoning777/events{/privacy}","received_events_url":"https://api.github.com/users/gaoning777/received_events","type":"User","site_admin":false},{"login":"qimingj","id":13439553,"node_id":"MDQ6VXNlcjEzNDM5NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13439553?v=4","gravatar_id":"","url":"https://api.github.com/users/qimingj","html_url":"https://github.com/qimingj","followers_url":"https://api.github.com/users/qimingj/followers","following_url":"https://api.github.com/users/qimingj/following{/other_user}","gists_url":"https://api.github.com/users/qimingj/gists{/gist_id}","starred_url":"https://api.github.com/users/qimingj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qimingj/subscriptions","organizations_url":"https://api.github.com/users/qimingj/orgs","repos_url":"https://api.github.com/users/qimingj/repos","events_url":"https://api.github.com/users/qimingj/events{/privacy}","received_events_url":"https://api.github.com/users/qimingj/received_events","type":"User","site_admin":false},{"login":"vicaire","id":25757005,"node_id":"MDQ6VXNlcjI1NzU3MDA1","avatar_url":"https://avatars2.githubusercontent.com/u/25757005?v=4","gravatar_id":"","url":"https://api.github.com/users/vicaire","html_url":"https://github.com/vicaire","followers_url":"https://api.github.com/users/vicaire/followers","following_url":"https://api.github.com/users/vicaire/following{/other_user}","gists_url":"https://api.github.com/users/vicaire/gists{/gist_id}","starred_url":"https://api.github.com/users/vicaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicaire/subscriptions","organizations_url":"https://api.github.com/users/vicaire/orgs","repos_url":"https://api.github.com/users/vicaire/repos","events_url":"https://api.github.com/users/vicaire/events{/privacy}","received_events_url":"https://api.github.com/users/vicaire/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":952830767,"node_id":"MDU6TGFiZWw5NTI4MzA3Njc=","url":"https://api.github.com/repos/kubeflow/pipelines/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/530/commits","review_comments_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/530/comments","review_comment_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/issues/530/comments","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/1dd1a2ec6e85d759f05425c44d78e23fb8f4b4f9","head":{"label":"hongye-sun:gpu","ref":"gpu","sha":"1dd1a2ec6e85d759f05425c44d78e23fb8f4b4f9","user":{"login":"hongye-sun","id":43763191,"node_id":"MDQ6VXNlcjQzNzYzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/43763191?v=4","gravatar_id":"","url":"https://api.github.com/users/hongye-sun","html_url":"https://github.com/hongye-sun","followers_url":"https://api.github.com/users/hongye-sun/followers","following_url":"https://api.github.com/users/hongye-sun/following{/other_user}","gists_url":"https://api.github.com/users/hongye-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/hongye-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongye-sun/subscriptions","organizations_url":"https://api.github.com/users/hongye-sun/orgs","repos_url":"https://api.github.com/users/hongye-sun/repos","events_url":"https://api.github.com/users/hongye-sun/events{/privacy}","received_events_url":"https://api.github.com/users/hongye-sun/received_events","type":"User","site_admin":false},"repo":{"id":160721067,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA3MjEwNjc=","name":"pipelines","full_name":"hongye-sun/pipelines","private":false,"owner":{"login":"hongye-sun","id":43763191,"node_id":"MDQ6VXNlcjQzNzYzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/43763191?v=4","gravatar_id":"","url":"https://api.github.com/users/hongye-sun","html_url":"https://github.com/hongye-sun","followers_url":"https://api.github.com/users/hongye-sun/followers","following_url":"https://api.github.com/users/hongye-sun/following{/other_user}","gists_url":"https://api.github.com/users/hongye-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/hongye-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongye-sun/subscriptions","organizations_url":"https://api.github.com/users/hongye-sun/orgs","repos_url":"https://api.github.com/users/hongye-sun/repos","events_url":"https://api.github.com/users/hongye-sun/events{/privacy}","received_events_url":"https://api.github.com/users/hongye-sun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hongye-sun/pipelines","description":"Machine Learning Pipelines for Kubeflow","fork":true,"url":"https://api.github.com/repos/hongye-sun/pipelines","forks_url":"https://api.github.com/repos/hongye-sun/pipelines/forks","keys_url":"https://api.github.com/repos/hongye-sun/pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hongye-sun/pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hongye-sun/pipelines/teams","hooks_url":"https://api.github.com/repos/hongye-sun/pipelines/hooks","issue_events_url":"https://api.github.com/repos/hongye-sun/pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/hongye-sun/pipelines/events","assignees_url":"https://api.github.com/repos/hongye-sun/pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/hongye-sun/pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/hongye-sun/pipelines/tags","blobs_url":"https://api.github.com/repos/hongye-sun/pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hongye-sun/pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hongye-sun/pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/hongye-sun/pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hongye-sun/pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/hongye-sun/pipelines/languages","stargazers_url":"https://api.github.com/repos/hongye-sun/pipelines/stargazers","contributors_url":"https://api.github.com/repos/hongye-sun/pipelines/contributors","subscribers_url":"https://api.github.com/repos/hongye-sun/pipelines/subscribers","subscription_url":"https://api.github.com/repos/hongye-sun/pipelines/subscription","commits_url":"https://api.github.com/repos/hongye-sun/pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/hongye-sun/pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/hongye-sun/pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/hongye-sun/pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/hongye-sun/pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/hongye-sun/pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hongye-sun/pipelines/merges","archive_url":"https://api.github.com/repos/hongye-sun/pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hongye-sun/pipelines/downloads","issues_url":"https://api.github.com/repos/hongye-sun/pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/hongye-sun/pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/hongye-sun/pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/hongye-sun/pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hongye-sun/pipelines/labels{/name}","releases_url":"https://api.github.com/repos/hongye-sun/pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/hongye-sun/pipelines/deployments","created_at":"2018-12-06T19:21:29Z","updated_at":"2018-12-06T19:21:33Z","pushed_at":"2018-12-14T18:01:37Z","git_url":"git://github.com/hongye-sun/pipelines.git","ssh_url":"git@github.com:hongye-sun/pipelines.git","clone_url":"https://github.com/hongye-sun/pipelines.git","svn_url":"https://github.com/hongye-sun/pipelines","homepage":"","size":14330,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"0c0d8a2b917c2fd6404151870affa5f9f601427d","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":133100880,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMDA4ODA=","name":"pipelines","full_name":"kubeflow/pipelines","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/pipelines","description":"Machine Learning Pipelines for Kubeflow","fork":false,"url":"https://api.github.com/repos/kubeflow/pipelines","forks_url":"https://api.github.com/repos/kubeflow/pipelines/forks","keys_url":"https://api.github.com/repos/kubeflow/pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/pipelines/teams","hooks_url":"https://api.github.com/repos/kubeflow/pipelines/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/pipelines/events","assignees_url":"https://api.github.com/repos/kubeflow/pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/pipelines/tags","blobs_url":"https://api.github.com/repos/kubeflow/pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/pipelines/languages","stargazers_url":"https://api.github.com/repos/kubeflow/pipelines/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/pipelines/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/pipelines/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/pipelines/subscription","commits_url":"https://api.github.com/repos/kubeflow/pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/pipelines/merges","archive_url":"https://api.github.com/repos/kubeflow/pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/pipelines/downloads","issues_url":"https://api.github.com/repos/kubeflow/pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/pipelines/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/pipelines/deployments","created_at":"2018-05-12T00:31:47Z","updated_at":"2018-12-14T08:18:39Z","pushed_at":"2018-12-14T18:01:47Z","git_url":"git://github.com/kubeflow/pipelines.git","ssh_url":"git@github.com:kubeflow/pipelines.git","clone_url":"https://github.com/kubeflow/pipelines.git","svn_url":"https://github.com/kubeflow/pipelines","homepage":"","size":15382,"stargazers_count":560,"watchers_count":560,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":185,"watchers":560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/530"},"html":{"href":"https://github.com/kubeflow/pipelines/pull/530"},"issue":{"href":"https://api.github.com/repos/kubeflow/pipelines/issues/530"},"comments":{"href":"https://api.github.com/repos/kubeflow/pipelines/issues/530/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/530/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/530/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/pipelines/statuses/1dd1a2ec6e85d759f05425c44d78e23fb8f4b4f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hongye-sun"}}