{"action":"created","issue":{"url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/issues/119","repository_url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp","labels_url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/issues/119/comments","events_url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/issues/119/events","html_url":"https://github.com/JohnSnowLabs/spark-nlp/pull/119","id":299905302,"number":119,"title":"Automatic generation of getters for all python annotator's params","user":{"login":"showy","id":2026148,"avatar_url":"https://avatars0.githubusercontent.com/u/2026148?v=4","gravatar_id":"","url":"https://api.github.com/users/showy","html_url":"https://github.com/showy","followers_url":"https://api.github.com/users/showy/followers","following_url":"https://api.github.com/users/showy/following{/other_user}","gists_url":"https://api.github.com/users/showy/gists{/gist_id}","starred_url":"https://api.github.com/users/showy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/showy/subscriptions","organizations_url":"https://api.github.com/users/showy/orgs","repos_url":"https://api.github.com/users/showy/repos","events_url":"https://api.github.com/users/showy/events{/privacy}","received_events_url":"https://api.github.com/users/showy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-24T02:59:21Z","updated_at":"2018-02-25T19:38:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/pulls/119","html_url":"https://github.com/JohnSnowLabs/spark-nlp/pull/119","diff_url":"https://github.com/JohnSnowLabs/spark-nlp/pull/119.diff","patch_url":"https://github.com/JohnSnowLabs/spark-nlp/pull/119.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nAutomatic generation of getters for all python annotator's params\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n - Added a new class ParamsGetters which creates a callback to resolve \"get*\" methods for the python annotators returning the corresponding param (*) value.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nPython annotators didn't provide getters for the params\r\n\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\nSpecific tests in the python test suite\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [X] Code improvements with no or little impact\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X ] My code follows the code style of this project.\r\n- [X] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the [CONTRIBUTING](http://nlp.johnsnowlabs.com/contribute.html) page.\r\n- [X] I have added tests to cover my changes.\r\n- [X] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/issues/comments/368337860","html_url":"https://github.com/JohnSnowLabs/spark-nlp/pull/119#issuecomment-368337860","issue_url":"https://api.github.com/repos/JohnSnowLabs/spark-nlp/issues/119","id":368337860,"user":{"login":"saifjsl","id":27952699,"avatar_url":"https://avatars3.githubusercontent.com/u/27952699?v=4","gravatar_id":"","url":"https://api.github.com/users/saifjsl","html_url":"https://github.com/saifjsl","followers_url":"https://api.github.com/users/saifjsl/followers","following_url":"https://api.github.com/users/saifjsl/following{/other_user}","gists_url":"https://api.github.com/users/saifjsl/gists{/gist_id}","starred_url":"https://api.github.com/users/saifjsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saifjsl/subscriptions","organizations_url":"https://api.github.com/users/saifjsl/orgs","repos_url":"https://api.github.com/users/saifjsl/repos","events_url":"https://api.github.com/users/saifjsl/events{/privacy}","received_events_url":"https://api.github.com/users/saifjsl/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T19:38:15Z","updated_at":"2018-02-25T19:38:15Z","author_association":"CONTRIBUTOR","body":"Very elegant and convenient! thank you @showy "}}
{"actor":{"display_login":"saifjsl"}}