{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/800","repository_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev","labels_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/800/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/800/comments","events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/800/events","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/issues/800","id":315159896,"number":800,"title":"Make lint preset throw if included after other presets","user":{"login":"edmorley","id":501702,"avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"labels":[{"id":749140796,"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/labels/breaking%20change","name":"breaking change","color":"f2527f","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/milestones/6","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/milestone/6","labels_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/milestones/6/labels","id":3272176,"number":6,"title":"v9","description":"This release is the next major version, which includes webpack v4 and Babel 7.","creator":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":12,"state":"open","created_at":"2018-04-16T22:31:33Z","updated_at":"2018-04-17T17:32:58Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-04-17T17:32:49Z","updated_at":"2018-04-17T17:37:32Z","closed_at":null,"author_association":"MEMBER","body":"As seen in #763 and elsewhere, if the linter presets are included after the other presets, then they don't work as expected.\r\n\r\nTo help make this case more obvious to users, it seems to make sense for the lint presets to throw if not declared first. eg in eslint preset: \r\n```js\r\nif neutrino.config.module.rules.has('compile') {\r\n  throw new Error('Linter presets must be declared before any other presets.');\r\n}"},"comment":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/comments/382078914","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/issues/800#issuecomment-382078914","issue_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/800","id":382078914,"user":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T17:37:32Z","updated_at":"2018-04-17T17:37:32Z","author_association":"OWNER","body":"We would also need to make sure that another instance hasn't already been set:\r\n\r\n```js\r\nif (\r\n  neutrino.config.module.rules.has('compile') &&\r\n  !neutrino.config.module.rules.has('lint')\r\n) {\r\n```"}}
{"actor":{"display_login":"eliperelman"}}