{"action":"created","issue":{"url":"https://api.github.com/repos/creare-com/podpac/issues/59","repository_url":"https://api.github.com/repos/creare-com/podpac","labels_url":"https://api.github.com/repos/creare-com/podpac/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/creare-com/podpac/issues/59/comments","events_url":"https://api.github.com/repos/creare-com/podpac/issues/59/events","html_url":"https://github.com/creare-com/podpac/issues/59","id":331687045,"node_id":"MDU6SXNzdWUzMzE2ODcwNDU=","number":59,"title":"Coordinates intersect and DataSource get_data() interface","user":{"login":"mlshapiro","id":8190979,"node_id":"MDQ6VXNlcjgxOTA5Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8190979?v=4","gravatar_id":"","url":"https://api.github.com/users/mlshapiro","html_url":"https://github.com/mlshapiro","followers_url":"https://api.github.com/users/mlshapiro/followers","following_url":"https://api.github.com/users/mlshapiro/following{/other_user}","gists_url":"https://api.github.com/users/mlshapiro/gists{/gist_id}","starred_url":"https://api.github.com/users/mlshapiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlshapiro/subscriptions","organizations_url":"https://api.github.com/users/mlshapiro/orgs","repos_url":"https://api.github.com/users/mlshapiro/repos","events_url":"https://api.github.com/users/mlshapiro/events{/privacy}","received_events_url":"https://api.github.com/users/mlshapiro/received_events","type":"User","site_admin":false},"labels":[{"id":865812938,"node_id":"MDU6TGFiZWw4NjU4MTI5Mzg=","url":"https://api.github.com/repos/creare-com/podpac/labels/discussion","name":"discussion","color":"910a40","default":false},{"id":865784012,"node_id":"MDU6TGFiZWw4NjU3ODQwMTI=","url":"https://api.github.com/repos/creare-com/podpac/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"mlshapiro","id":8190979,"node_id":"MDQ6VXNlcjgxOTA5Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8190979?v=4","gravatar_id":"","url":"https://api.github.com/users/mlshapiro","html_url":"https://github.com/mlshapiro","followers_url":"https://api.github.com/users/mlshapiro/followers","following_url":"https://api.github.com/users/mlshapiro/following{/other_user}","gists_url":"https://api.github.com/users/mlshapiro/gists{/gist_id}","starred_url":"https://api.github.com/users/mlshapiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlshapiro/subscriptions","organizations_url":"https://api.github.com/users/mlshapiro/orgs","repos_url":"https://api.github.com/users/mlshapiro/repos","events_url":"https://api.github.com/users/mlshapiro/events{/privacy}","received_events_url":"https://api.github.com/users/mlshapiro/received_events","type":"User","site_admin":false},"assignees":[{"login":"mlshapiro","id":8190979,"node_id":"MDQ6VXNlcjgxOTA5Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8190979?v=4","gravatar_id":"","url":"https://api.github.com/users/mlshapiro","html_url":"https://github.com/mlshapiro","followers_url":"https://api.github.com/users/mlshapiro/followers","following_url":"https://api.github.com/users/mlshapiro/following{/other_user}","gists_url":"https://api.github.com/users/mlshapiro/gists{/gist_id}","starred_url":"https://api.github.com/users/mlshapiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlshapiro/subscriptions","organizations_url":"https://api.github.com/users/mlshapiro/orgs","repos_url":"https://api.github.com/users/mlshapiro/repos","events_url":"https://api.github.com/users/mlshapiro/events{/privacy}","received_events_url":"https://api.github.com/users/mlshapiro/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-12T17:42:32Z","updated_at":"2018-06-12T17:53:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Description**\r\n\r\n- Coordinates.intersect() takes optional argument `ind`. I propose we change this `return_index` to make it clear that would you are asking for is the method to return the index of the coordinates.\r\n   - Does it make any sense to have a `CoordinateIndex()` class? This may be overengeering, and this is also a discussion for a different topic/time.\r\n- DataSource.get_data() takes two inputs: `coordinates` and `coordinates_slice`.  `coordinates_slice` is what gets returned from `coordinates.intersect(return_index=True)`, so its really the index of coordinates. We should rename this to be an index, not a slice, so we should rename this to be one of:\r\n  - `coordinates_index`\r\n  - `coordinates_idx`\r\n  - `index`"},"comment":{"url":"https://api.github.com/repos/creare-com/podpac/issues/comments/396678056","html_url":"https://github.com/creare-com/podpac/issues/59#issuecomment-396678056","issue_url":"https://api.github.com/repos/creare-com/podpac/issues/59","id":396678056,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjY3ODA1Ng==","user":{"login":"mpu-creare","id":12446685,"node_id":"MDQ6VXNlcjEyNDQ2Njg1","avatar_url":"https://avatars0.githubusercontent.com/u/12446685?v=4","gravatar_id":"","url":"https://api.github.com/users/mpu-creare","html_url":"https://github.com/mpu-creare","followers_url":"https://api.github.com/users/mpu-creare/followers","following_url":"https://api.github.com/users/mpu-creare/following{/other_user}","gists_url":"https://api.github.com/users/mpu-creare/gists{/gist_id}","starred_url":"https://api.github.com/users/mpu-creare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpu-creare/subscriptions","organizations_url":"https://api.github.com/users/mpu-creare/orgs","repos_url":"https://api.github.com/users/mpu-creare/repos","events_url":"https://api.github.com/users/mpu-creare/events{/privacy}","received_events_url":"https://api.github.com/users/mpu-creare/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T17:53:41Z","updated_at":"2018-06-12T17:53:41Z","author_association":"CONTRIBUTOR","body":"Incidentally, we should decide what could be contained as part of the index -- and that has to be matched by the coordinates produces when `return_index=False`.\r\n\r\nFor example, `index` could be:\r\n1. A list of slice objects\r\n   * Strided, or just start, end\r\n2. A boolean array\r\n3. A flat integer array \r\n4. An integer array of multi-dimensional indices\r\n\r\nDifferent types of datasources may only support a subset of the above. \r\n* I believe numpy arrays support 1-3 with no modification. \r\n* OpenDAP only supports 1, barely supporting strided data. \r\n* Asking people to support 4. essentially requires everyone writing a datasource node to implement that last half of nearest neighbor lookups. \r\n\r\nPerhaps we can have a flag where a user can specify which level of indexing they support in their node. "}}
{"actor":{"display_login":"mpu-creare"}}