{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/3202","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3202/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3202/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3202/events","html_url":"https://github.com/apache/incubator-airflow/pull/3202","id":312492059,"number":3202,"title":"[AIRFLOW-2291] Add optional params to ML Engine Training operator","user":{"login":"dlebech","id":292796,"avatar_url":"https://avatars2.githubusercontent.com/u/292796?v=4","gravatar_id":"","url":"https://api.github.com/users/dlebech","html_url":"https://github.com/dlebech","followers_url":"https://api.github.com/users/dlebech/followers","following_url":"https://api.github.com/users/dlebech/following{/other_user}","gists_url":"https://api.github.com/users/dlebech/gists{/gist_id}","starred_url":"https://api.github.com/users/dlebech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlebech/subscriptions","organizations_url":"https://api.github.com/users/dlebech/orgs","repos_url":"https://api.github.com/users/dlebech/repos","events_url":"https://api.github.com/users/dlebech/events{/privacy}","received_events_url":"https://api.github.com/users/dlebech/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-09T11:22:20Z","updated_at":"2018-04-11T12:17:23Z","closed_at":"2018-04-11T12:16:04Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3202","html_url":"https://github.com/apache/incubator-airflow/pull/3202","diff_url":"https://github.com/apache/incubator-airflow/pull/3202.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3202.patch"},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### JIRA\r\n- [X] My PR addresses the following [Airflow JIRA](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n    - https://issues.apache.org/jira/browse/AIRFLOW-2291\r\n\r\n### Description\r\n- [X] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\nThis PR adds three extra optional parameters to the `MLEngineTrainingOperator` as well as a new unit tes for the `MLEngineVersionOperator`\r\n\r\n### Tests\r\n- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n- `testSuccessCreateTrainingJobWithOptionalArgs` for the extra parameters\r\n- `testSuccessCreateVersion` for creating a new ML Model Version (no tests existed at all for this operator before)\r\n\r\n### Commits\r\n- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n    1. Subject is separated from body by a blank line\r\n    2. Subject is limited to 50 characters\r\n    3. Subject does not end with a period\r\n    4. Subject uses the imperative mood (\"add\", not \"adding\")\r\n    5. Body wraps at 72 characters\r\n    6. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n- [X] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n\r\nThere are a bunch of other errors *unrelated to this PR*"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/380431147","html_url":"https://github.com/apache/incubator-airflow/pull/3202#issuecomment-380431147","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3202","id":380431147,"user":{"login":"Fokko","id":1134248,"avatar_url":"https://avatars0.githubusercontent.com/u/1134248?v=4","gravatar_id":"","url":"https://api.github.com/users/Fokko","html_url":"https://github.com/Fokko","followers_url":"https://api.github.com/users/Fokko/followers","following_url":"https://api.github.com/users/Fokko/following{/other_user}","gists_url":"https://api.github.com/users/Fokko/gists{/gist_id}","starred_url":"https://api.github.com/users/Fokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fokko/subscriptions","organizations_url":"https://api.github.com/users/Fokko/orgs","repos_url":"https://api.github.com/users/Fokko/repos","events_url":"https://api.github.com/users/Fokko/events{/privacy}","received_events_url":"https://api.github.com/users/Fokko/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T12:17:23Z","updated_at":"2018-04-11T12:17:23Z","author_association":"CONTRIBUTOR","body":"Thanks @dlebech, merged to master"}}
{"actor":{"display_login":"Fokko"}}