{"action":"created","comment":{"url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/comments/175120552","pull_request_review_id":104603369,"id":175120552,"diff_hunk":"@@ -117,19 +127,32 @@ def initialize(args)\n         @options.msg_content_type = msg_content_type\n       end\n \n+      # Content type\n+      @opt_parser.on(\n+        \"--content-type TYPE\",\n+        %w(string int long float bool),\n+        \"cast --msg-content, -list-item, and =values of -map-item\" +\n+        \"and --msg-property to this type, default: #{Defaults::DEFAULT_CONTENT_TYPE}\"\n+      ) do |content_type|\n+        @options.content_type = content_type\n+      end\n+\n       # Message property\n       @opt_parser.on(\n         \"-P\",\n         \"--msg-property KEY=VALUE\",\n         String,\n         \"property specified as KEY=VALUE (use '~' instead of '=' for auto-casting)\"\n       ) do |msg_property|\n-        if @options.msg_properties.nil?\n-          @options.msg_properties = {}\n-        end\n+        _ = parse_kv(msg_property)  # ensure correct option format","path":"lib/options/sender_option_parser.rb","position":66,"original_position":66,"commit_id":"e8e56d01074b0902618dd1fd67c4d48807a7bd2a","original_commit_id":"e8e56d01074b0902618dd1fd67c4d48807a7bd2a","user":{"login":"jdanekrh","id":17877663,"avatar_url":"https://avatars3.githubusercontent.com/u/17877663?v=4","gravatar_id":"","url":"https://api.github.com/users/jdanekrh","html_url":"https://github.com/jdanekrh","followers_url":"https://api.github.com/users/jdanekrh/followers","following_url":"https://api.github.com/users/jdanekrh/following{/other_user}","gists_url":"https://api.github.com/users/jdanekrh/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanekrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanekrh/subscriptions","organizations_url":"https://api.github.com/users/jdanekrh/orgs","repos_url":"https://api.github.com/users/jdanekrh/repos","events_url":"https://api.github.com/users/jdanekrh/events{/privacy}","received_events_url":"https://api.github.com/users/jdanekrh/received_events","type":"User","site_admin":false},"body":"`_ =` suppresses the warning about unused return value","created_at":"2018-03-16T15:09:40Z","updated_at":"2018-03-16T15:09:41Z","html_url":"https://github.com/rh-messaging/cli-proton-ruby/pull/26#discussion_r175120552","pull_request_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/comments/175120552"},"html":{"href":"https://github.com/rh-messaging/cli-proton-ruby/pull/26#discussion_r175120552"},"pull_request":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26"}},"in_reply_to_id":175056372},"pull_request":{"url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26","id":175482618,"html_url":"https://github.com/rh-messaging/cli-proton-ruby/pull/26","diff_url":"https://github.com/rh-messaging/cli-proton-ruby/pull/26.diff","patch_url":"https://github.com/rh-messaging/cli-proton-ruby/pull/26.patch","issue_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues/26","number":26,"state":"open","locked":false,"title":"NEW(options) --content-type sender option","user":{"login":"jdanekrh","id":17877663,"avatar_url":"https://avatars3.githubusercontent.com/u/17877663?v=4","gravatar_id":"","url":"https://api.github.com/users/jdanekrh","html_url":"https://github.com/jdanekrh","followers_url":"https://api.github.com/users/jdanekrh/followers","following_url":"https://api.github.com/users/jdanekrh/following{/other_user}","gists_url":"https://api.github.com/users/jdanekrh/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanekrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanekrh/subscriptions","organizations_url":"https://api.github.com/users/jdanekrh/orgs","repos_url":"https://api.github.com/users/jdanekrh/repos","events_url":"https://api.github.com/users/jdanekrh/events{/privacy}","received_events_url":"https://api.github.com/users/jdanekrh/received_events","type":"User","site_admin":false},"body":"This closes #9","created_at":"2018-03-16T09:43:15Z","updated_at":"2018-03-16T15:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6146ce793264ebd7da6c6699ab81d41b6d986abd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26/commits","review_comments_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26/comments","review_comment_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues/26/comments","statuses_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/statuses/e8e56d01074b0902618dd1fd67c4d48807a7bd2a","head":{"label":"jdanekrh:jd_contentType","ref":"jd_contentType","sha":"e8e56d01074b0902618dd1fd67c4d48807a7bd2a","user":{"login":"jdanekrh","id":17877663,"avatar_url":"https://avatars3.githubusercontent.com/u/17877663?v=4","gravatar_id":"","url":"https://api.github.com/users/jdanekrh","html_url":"https://github.com/jdanekrh","followers_url":"https://api.github.com/users/jdanekrh/followers","following_url":"https://api.github.com/users/jdanekrh/following{/other_user}","gists_url":"https://api.github.com/users/jdanekrh/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanekrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanekrh/subscriptions","organizations_url":"https://api.github.com/users/jdanekrh/orgs","repos_url":"https://api.github.com/users/jdanekrh/repos","events_url":"https://api.github.com/users/jdanekrh/events{/privacy}","received_events_url":"https://api.github.com/users/jdanekrh/received_events","type":"User","site_admin":false},"repo":{"id":110270986,"name":"cli-proton-ruby","full_name":"jdanekrh/cli-proton-ruby","owner":{"login":"jdanekrh","id":17877663,"avatar_url":"https://avatars3.githubusercontent.com/u/17877663?v=4","gravatar_id":"","url":"https://api.github.com/users/jdanekrh","html_url":"https://github.com/jdanekrh","followers_url":"https://api.github.com/users/jdanekrh/followers","following_url":"https://api.github.com/users/jdanekrh/following{/other_user}","gists_url":"https://api.github.com/users/jdanekrh/gists{/gist_id}","starred_url":"https://api.github.com/users/jdanekrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdanekrh/subscriptions","organizations_url":"https://api.github.com/users/jdanekrh/orgs","repos_url":"https://api.github.com/users/jdanekrh/repos","events_url":"https://api.github.com/users/jdanekrh/events{/privacy}","received_events_url":"https://api.github.com/users/jdanekrh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdanekrh/cli-proton-ruby","description":"A proton ruby client used for testing a publisher:subscriber broker set up.","fork":true,"url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby","forks_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/forks","keys_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/teams","hooks_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/hooks","issue_events_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/events","assignees_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/tags","blobs_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/languages","stargazers_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/stargazers","contributors_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/contributors","subscribers_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/subscribers","subscription_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/subscription","commits_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/merges","archive_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/downloads","issues_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/labels{/name}","releases_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/jdanekrh/cli-proton-ruby/deployments","created_at":"2017-11-10T16:56:51Z","updated_at":"2018-03-12T09:24:21Z","pushed_at":"2018-03-16T10:46:30Z","git_url":"git://github.com/jdanekrh/cli-proton-ruby.git","ssh_url":"git@github.com:jdanekrh/cli-proton-ruby.git","clone_url":"https://github.com/jdanekrh/cli-proton-ruby.git","svn_url":"https://github.com/jdanekrh/cli-proton-ruby","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rh-messaging:master","ref":"master","sha":"d0b74aac512c0308365bb9938ed6a7db7ec649bb","user":{"login":"rh-messaging","id":13945201,"avatar_url":"https://avatars1.githubusercontent.com/u/13945201?v=4","gravatar_id":"","url":"https://api.github.com/users/rh-messaging","html_url":"https://github.com/rh-messaging","followers_url":"https://api.github.com/users/rh-messaging/followers","following_url":"https://api.github.com/users/rh-messaging/following{/other_user}","gists_url":"https://api.github.com/users/rh-messaging/gists{/gist_id}","starred_url":"https://api.github.com/users/rh-messaging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rh-messaging/subscriptions","organizations_url":"https://api.github.com/users/rh-messaging/orgs","repos_url":"https://api.github.com/users/rh-messaging/repos","events_url":"https://api.github.com/users/rh-messaging/events{/privacy}","received_events_url":"https://api.github.com/users/rh-messaging/received_events","type":"Organization","site_admin":false},"repo":{"id":110133477,"name":"cli-proton-ruby","full_name":"rh-messaging/cli-proton-ruby","owner":{"login":"rh-messaging","id":13945201,"avatar_url":"https://avatars1.githubusercontent.com/u/13945201?v=4","gravatar_id":"","url":"https://api.github.com/users/rh-messaging","html_url":"https://github.com/rh-messaging","followers_url":"https://api.github.com/users/rh-messaging/followers","following_url":"https://api.github.com/users/rh-messaging/following{/other_user}","gists_url":"https://api.github.com/users/rh-messaging/gists{/gist_id}","starred_url":"https://api.github.com/users/rh-messaging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rh-messaging/subscriptions","organizations_url":"https://api.github.com/users/rh-messaging/orgs","repos_url":"https://api.github.com/users/rh-messaging/repos","events_url":"https://api.github.com/users/rh-messaging/events{/privacy}","received_events_url":"https://api.github.com/users/rh-messaging/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rh-messaging/cli-proton-ruby","description":"cli-proton-ruby is a collection of commandline messaging clients suitable for interacting with Message Oriented Middleware such as ActiveMQ Artemis broker or Qpid Dispatch router. ","fork":false,"url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby","forks_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/forks","keys_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/teams","hooks_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/hooks","issue_events_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/events","assignees_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/tags","blobs_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/languages","stargazers_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/stargazers","contributors_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/contributors","subscribers_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/subscribers","subscription_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/subscription","commits_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/merges","archive_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/downloads","issues_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/deployments","created_at":"2017-11-09T15:37:06Z","updated_at":"2018-03-16T10:40:46Z","pushed_at":"2018-03-16T10:46:32Z","git_url":"git://github.com/rh-messaging/cli-proton-ruby.git","ssh_url":"git@github.com:rh-messaging/cli-proton-ruby.git","clone_url":"https://github.com/rh-messaging/cli-proton-ruby.git","svn_url":"https://github.com/rh-messaging/cli-proton-ruby","homepage":"","size":147,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26"},"html":{"href":"https://github.com/rh-messaging/cli-proton-ruby/pull/26"},"issue":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues/26"},"comments":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/rh-messaging/cli-proton-ruby/statuses/e8e56d01074b0902618dd1fd67c4d48807a7bd2a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jdanekrh"}}