{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/218306046","pull_request_review_id":156212267,"id":218306046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODMwNjA0Ng==","diff_hunk":"@@ -0,0 +1,68 @@\n+// Flags: --expose-internals\n+'use strict';\n+const common = require('../common');\n+const assert = require('assert');\n+const { dnsException } = require('internal/errors');\n+const { internalBinding } = require('internal/test/binding');\n+const { getaddrinfo, GetAddrInfoReqWrap } = internalBinding('cares_wrap');\n+const dns = require('dns');\n+\n+// Stub `getaddrinfo` to *always* error.","path":"test/parallel/test-dns-onlookup.js","position":10,"original_position":10,"commit_id":"7d162fd9a32870a18859254fee06e257ded95e7a","original_commit_id":"7d162fd9a32870a18859254fee06e257ded95e7a","user":{"login":"Trott","id":718899,"node_id":"MDQ6VXNlcjcxODg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"??? Where is the stub?","created_at":"2018-09-18T05:56:14Z","updated_at":"2018-09-18T05:56:14Z","html_url":"https://github.com/nodejs/node/pull/22897#discussion_r218306046","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/22897","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/218306046"},"html":{"href":"https://github.com/nodejs/node/pull/22897#discussion_r218306046"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/22897"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22897","id":215937633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTM3NjMz","html_url":"https://github.com/nodejs/node/pull/22897","diff_url":"https://github.com/nodejs/node/pull/22897.diff","patch_url":"https://github.com/nodejs/node/pull/22897.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/22897","number":22897,"state":"open","locked":false,"title":"added test for dns/promise-onlookup.js","user":{"login":"mritunjaygoutam12","id":22472097,"node_id":"MDQ6VXNlcjIyNDcyMDk3","avatar_url":"https://avatars0.githubusercontent.com/u/22472097?v=4","gravatar_id":"","url":"https://api.github.com/users/mritunjaygoutam12","html_url":"https://github.com/mritunjaygoutam12","followers_url":"https://api.github.com/users/mritunjaygoutam12/followers","following_url":"https://api.github.com/users/mritunjaygoutam12/following{/other_user}","gists_url":"https://api.github.com/users/mritunjaygoutam12/gists{/gist_id}","starred_url":"https://api.github.com/users/mritunjaygoutam12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mritunjaygoutam12/subscriptions","organizations_url":"https://api.github.com/users/mritunjaygoutam12/orgs","repos_url":"https://api.github.com/users/mritunjaygoutam12/repos","events_url":"https://api.github.com/users/mritunjaygoutam12/events{/privacy}","received_events_url":"https://api.github.com/users/mritunjaygoutam12/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\ntest for onlookup promise return of dns/promise \r\n#22471 \r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-09-17T10:39:01Z","updated_at":"2018-09-18T05:56:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"543717fb7ed1cf4f95c0eac5d6e727f3ad78314d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/22897/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/22897/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22897/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/7d162fd9a32870a18859254fee06e257ded95e7a","head":{"label":"mritunjaygoutam12:test-onlook","ref":"test-onlook","sha":"7d162fd9a32870a18859254fee06e257ded95e7a","user":{"login":"mritunjaygoutam12","id":22472097,"node_id":"MDQ6VXNlcjIyNDcyMDk3","avatar_url":"https://avatars0.githubusercontent.com/u/22472097?v=4","gravatar_id":"","url":"https://api.github.com/users/mritunjaygoutam12","html_url":"https://github.com/mritunjaygoutam12","followers_url":"https://api.github.com/users/mritunjaygoutam12/followers","following_url":"https://api.github.com/users/mritunjaygoutam12/following{/other_user}","gists_url":"https://api.github.com/users/mritunjaygoutam12/gists{/gist_id}","starred_url":"https://api.github.com/users/mritunjaygoutam12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mritunjaygoutam12/subscriptions","organizations_url":"https://api.github.com/users/mritunjaygoutam12/orgs","repos_url":"https://api.github.com/users/mritunjaygoutam12/repos","events_url":"https://api.github.com/users/mritunjaygoutam12/events{/privacy}","received_events_url":"https://api.github.com/users/mritunjaygoutam12/received_events","type":"User","site_admin":false},"repo":{"id":149075240,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwNzUyNDA=","name":"node","full_name":"mritunjaygoutam12/node","private":false,"owner":{"login":"mritunjaygoutam12","id":22472097,"node_id":"MDQ6VXNlcjIyNDcyMDk3","avatar_url":"https://avatars0.githubusercontent.com/u/22472097?v=4","gravatar_id":"","url":"https://api.github.com/users/mritunjaygoutam12","html_url":"https://github.com/mritunjaygoutam12","followers_url":"https://api.github.com/users/mritunjaygoutam12/followers","following_url":"https://api.github.com/users/mritunjaygoutam12/following{/other_user}","gists_url":"https://api.github.com/users/mritunjaygoutam12/gists{/gist_id}","starred_url":"https://api.github.com/users/mritunjaygoutam12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mritunjaygoutam12/subscriptions","organizations_url":"https://api.github.com/users/mritunjaygoutam12/orgs","repos_url":"https://api.github.com/users/mritunjaygoutam12/repos","events_url":"https://api.github.com/users/mritunjaygoutam12/events{/privacy}","received_events_url":"https://api.github.com/users/mritunjaygoutam12/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mritunjaygoutam12/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/mritunjaygoutam12/node","forks_url":"https://api.github.com/repos/mritunjaygoutam12/node/forks","keys_url":"https://api.github.com/repos/mritunjaygoutam12/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mritunjaygoutam12/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mritunjaygoutam12/node/teams","hooks_url":"https://api.github.com/repos/mritunjaygoutam12/node/hooks","issue_events_url":"https://api.github.com/repos/mritunjaygoutam12/node/issues/events{/number}","events_url":"https://api.github.com/repos/mritunjaygoutam12/node/events","assignees_url":"https://api.github.com/repos/mritunjaygoutam12/node/assignees{/user}","branches_url":"https://api.github.com/repos/mritunjaygoutam12/node/branches{/branch}","tags_url":"https://api.github.com/repos/mritunjaygoutam12/node/tags","blobs_url":"https://api.github.com/repos/mritunjaygoutam12/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mritunjaygoutam12/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mritunjaygoutam12/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mritunjaygoutam12/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mritunjaygoutam12/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mritunjaygoutam12/node/languages","stargazers_url":"https://api.github.com/repos/mritunjaygoutam12/node/stargazers","contributors_url":"https://api.github.com/repos/mritunjaygoutam12/node/contributors","subscribers_url":"https://api.github.com/repos/mritunjaygoutam12/node/subscribers","subscription_url":"https://api.github.com/repos/mritunjaygoutam12/node/subscription","commits_url":"https://api.github.com/repos/mritunjaygoutam12/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mritunjaygoutam12/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mritunjaygoutam12/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mritunjaygoutam12/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mritunjaygoutam12/node/contents/{+path}","compare_url":"https://api.github.com/repos/mritunjaygoutam12/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mritunjaygoutam12/node/merges","archive_url":"https://api.github.com/repos/mritunjaygoutam12/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mritunjaygoutam12/node/downloads","issues_url":"https://api.github.com/repos/mritunjaygoutam12/node/issues{/number}","pulls_url":"https://api.github.com/repos/mritunjaygoutam12/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mritunjaygoutam12/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mritunjaygoutam12/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mritunjaygoutam12/node/labels{/name}","releases_url":"https://api.github.com/repos/mritunjaygoutam12/node/releases{/id}","deployments_url":"https://api.github.com/repos/mritunjaygoutam12/node/deployments","created_at":"2018-09-17T05:51:16Z","updated_at":"2018-09-17T05:51:39Z","pushed_at":"2018-09-17T19:09:50Z","git_url":"git://github.com/mritunjaygoutam12/node.git","ssh_url":"git@github.com:mritunjaygoutam12/node.git","clone_url":"https://github.com/mritunjaygoutam12/node.git","svn_url":"https://github.com/mritunjaygoutam12/node","homepage":"https://nodejs.org","size":414476,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"1747d707d77f459f061d51fcd551cda9db6ed1cf","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-09-18T05:54:04Z","pushed_at":"2018-09-18T05:40:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":413774,"stargazers_count":53426,"watchers_count":53426,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11379,"mirror_url":null,"archived":false,"open_issues_count":884,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11379,"open_issues":884,"watchers":53426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/22897"},"html":{"href":"https://github.com/nodejs/node/pull/22897"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/22897"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/22897/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/22897/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/22897/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/7d162fd9a32870a18859254fee06e257ded95e7a"}},"author_association":"NONE"}}
{"actor":{"display_login":"Trott"}}