{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/207055962","pull_request_review_id":142590878,"id":207055962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA1NTk2Mg==","diff_hunk":"@@ -530,8 +542,8 @@ def close(\n             self,\n             channel_identifier: typing.ChannelID,\n             partner: typing.Address,\n-            nonce: typing.Nonce,\n             balance_hash: typing.BalanceHash,\n+            nonce: typing.Nonce,","path":"raiden/network/proxies/token_network.py","position":78,"original_position":78,"commit_id":"ccc0ead711198b3d196a3e6b41307df4f4961a21","original_commit_id":"ccc0ead711198b3d196a3e6b41307df4f4961a21","user":{"login":"LefterisJP","id":1658405,"node_id":"MDQ6VXNlcjE2NTg0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1658405?v=4","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"also here why the change of the nonce argument position?","created_at":"2018-08-01T22:49:25Z","updated_at":"2018-08-01T22:50:56Z","html_url":"https://github.com/raiden-network/raiden/pull/2018#discussion_r207055962","pull_request_url":"https://api.github.com/repos/raiden-network/raiden/pulls/2018","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/207055962"},"html":{"href":"https://github.com/raiden-network/raiden/pull/2018#discussion_r207055962"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2018"}}},"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/2018","id":205155982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTU1OTgy","html_url":"https://github.com/raiden-network/raiden/pull/2018","diff_url":"https://github.com/raiden-network/raiden/pull/2018.diff","patch_url":"https://github.com/raiden-network/raiden/pull/2018.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/2018","number":2018,"state":"closed","locked":false,"title":"Adjust proxies for changed ChannelID","user":{"login":"err508","id":22775390,"node_id":"MDQ6VXNlcjIyNzc1Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/22775390?v=4","gravatar_id":"","url":"https://api.github.com/users/err508","html_url":"https://github.com/err508","followers_url":"https://api.github.com/users/err508/followers","following_url":"https://api.github.com/users/err508/following{/other_user}","gists_url":"https://api.github.com/users/err508/gists{/gist_id}","starred_url":"https://api.github.com/users/err508/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/err508/subscriptions","organizations_url":"https://api.github.com/users/err508/orgs","repos_url":"https://api.github.com/users/err508/repos","events_url":"https://api.github.com/users/err508/events{/privacy}","received_events_url":"https://api.github.com/users/err508/received_events","type":"User","site_admin":false},"body":"As implied by [current](https://github.com/raiden-network/raiden-contracts/pull/198) changes of  signatures of contract functions and some helpers (As described in #1940 and specified [here](https://github.com/raiden-network/raiden-contracts/issues/193))\r\n\r\nWhat has been done w.r.t. #1940: \r\n- `ChannelID` type from `bytes` to `int`\r\n- `detail_participant` and `detail_channel` have been changed to work with the new channel identifier\r\n(as well as functions composed from those, i.e. `detail_participants`, `detail`)\r\n\r\n- Added an overflow/underflow check for the `channel_identifier`\r\n- added appropriate arguments to `set_total_deposit` function\r\n- inverted the argument order of `balance_hash/nonce` in close\r\nto be consistent with the contracts (optional)\r\n- inverted the argument order of `balance_hash/nonce` in update_transfer\r\nto be consistent with the contracts (optional)\r\n- added `channel_identifier` to `unlock`\r\n\r\n-  added `channel_identifier` + `partner` to\r\n`token_network.setTotalDeposit` call inside `set_total_deposit`\r\n- reordered `close` arguments to be consistent with contracts (optional)\r\n- reordered `update_transfer` arguments to be consistent with contracts (optional)\r\n- added `channel_identifer` to `token_network.updateNonClosingBalanceProof `call\r\ninside update_transfer\r\n- added `channel_identifier` to `token_network.unlock` call inside `unlock`\r\n- added `channel_identifier` to `token_network.settleChannel` call inside `settle`\r\nfor both cases","created_at":"2018-07-31T15:38:41Z","updated_at":"2018-08-01T22:50:56Z","closed_at":"2018-08-01T22:27:37Z","merged_at":null,"merge_commit_sha":"043afdd362e09281c62e5dbfe64f1f7c164b9c3c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/2018/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/2018/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/2018/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/ccc0ead711198b3d196a3e6b41307df4f4961a21","head":{"label":"err508:refactor_channel_id","ref":"refactor_channel_id","sha":"ccc0ead711198b3d196a3e6b41307df4f4961a21","user":{"login":"err508","id":22775390,"node_id":"MDQ6VXNlcjIyNzc1Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/22775390?v=4","gravatar_id":"","url":"https://api.github.com/users/err508","html_url":"https://github.com/err508","followers_url":"https://api.github.com/users/err508/followers","following_url":"https://api.github.com/users/err508/following{/other_user}","gists_url":"https://api.github.com/users/err508/gists{/gist_id}","starred_url":"https://api.github.com/users/err508/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/err508/subscriptions","organizations_url":"https://api.github.com/users/err508/orgs","repos_url":"https://api.github.com/users/err508/repos","events_url":"https://api.github.com/users/err508/events{/privacy}","received_events_url":"https://api.github.com/users/err508/received_events","type":"User","site_admin":false},"repo":{"id":124102304,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMDIzMDQ=","name":"raiden","full_name":"err508/raiden","owner":{"login":"err508","id":22775390,"node_id":"MDQ6VXNlcjIyNzc1Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/22775390?v=4","gravatar_id":"","url":"https://api.github.com/users/err508","html_url":"https://github.com/err508","followers_url":"https://api.github.com/users/err508/followers","following_url":"https://api.github.com/users/err508/following{/other_user}","gists_url":"https://api.github.com/users/err508/gists{/gist_id}","starred_url":"https://api.github.com/users/err508/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/err508/subscriptions","organizations_url":"https://api.github.com/users/err508/orgs","repos_url":"https://api.github.com/users/err508/repos","events_url":"https://api.github.com/users/err508/events{/privacy}","received_events_url":"https://api.github.com/users/err508/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/err508/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/err508/raiden","forks_url":"https://api.github.com/repos/err508/raiden/forks","keys_url":"https://api.github.com/repos/err508/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/err508/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/err508/raiden/teams","hooks_url":"https://api.github.com/repos/err508/raiden/hooks","issue_events_url":"https://api.github.com/repos/err508/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/err508/raiden/events","assignees_url":"https://api.github.com/repos/err508/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/err508/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/err508/raiden/tags","blobs_url":"https://api.github.com/repos/err508/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/err508/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/err508/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/err508/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/err508/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/err508/raiden/languages","stargazers_url":"https://api.github.com/repos/err508/raiden/stargazers","contributors_url":"https://api.github.com/repos/err508/raiden/contributors","subscribers_url":"https://api.github.com/repos/err508/raiden/subscribers","subscription_url":"https://api.github.com/repos/err508/raiden/subscription","commits_url":"https://api.github.com/repos/err508/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/err508/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/err508/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/err508/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/err508/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/err508/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/err508/raiden/merges","archive_url":"https://api.github.com/repos/err508/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/err508/raiden/downloads","issues_url":"https://api.github.com/repos/err508/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/err508/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/err508/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/err508/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/err508/raiden/labels{/name}","releases_url":"https://api.github.com/repos/err508/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/err508/raiden/deployments","created_at":"2018-03-06T15:57:30Z","updated_at":"2018-03-26T17:50:03Z","pushed_at":"2018-08-01T16:04:48Z","git_url":"git://github.com/err508/raiden.git","ssh_url":"git@github.com:err508/raiden.git","clone_url":"https://github.com/err508/raiden.git","svn_url":"https://github.com/err508/raiden","homepage":null,"size":8426,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"353388897337d14d4ffbfae347c7beae83e1d8b1","user":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY0Njc2Nw==","name":"raiden","full_name":"raiden-network/raiden","owner":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2018-08-01T21:59:50Z","pushed_at":"2018-08-01T22:26:12Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":null,"size":8466,"stargazers_count":1486,"watchers_count":1486,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":296,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":296,"open_issues":170,"watchers":1486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2018"},"html":{"href":"https://github.com/raiden-network/raiden/pull/2018"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/2018"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/2018/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2018/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/2018/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/ccc0ead711198b3d196a3e6b41307df4f4961a21"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"LefterisJP"}}