{"action":"created","comment":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/214001567","pull_request_review_id":150957664,"id":214001567,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDAwMTU2Nw==","diff_hunk":"@@ -603,6 +603,9 @@ void BaseDaemon::reloadConfiguration()\n       */\n     config_path = config().getString(\"config-file\", \"config.xml\");\n     loaded_config = ConfigProcessor(config_path, false, true).loadConfig(/* allow_zk_includes = */ true);\n+\n+    ConfigProcessor::main_config_path = Poco::Path(config_path).makeParent().toString();","path":"libs/libdaemon/src/BaseDaemon.cpp","position":5,"original_position":5,"commit_id":"30b591e70d9f9b2a7ec736f124cb1c201814aa35","original_commit_id":"30b591e70d9f9b2a7ec736f124cb1c201814aa35","user":{"login":"alexey-milovidov","id":18581488,"node_id":"MDQ6VXNlcjE4NTgxNDg4","avatar_url":"https://avatars3.githubusercontent.com/u/18581488?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-milovidov","html_url":"https://github.com/alexey-milovidov","followers_url":"https://api.github.com/users/alexey-milovidov/followers","following_url":"https://api.github.com/users/alexey-milovidov/following{/other_user}","gists_url":"https://api.github.com/users/alexey-milovidov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-milovidov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-milovidov/subscriptions","organizations_url":"https://api.github.com/users/alexey-milovidov/orgs","repos_url":"https://api.github.com/users/alexey-milovidov/repos","events_url":"https://api.github.com/users/alexey-milovidov/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-milovidov/received_events","type":"User","site_admin":false},"body":"Using global variables with non-trivial constructor across translation units is undefined behaviour.","created_at":"2018-08-30T11:56:02Z","updated_at":"2018-08-30T11:56:02Z","html_url":"https://github.com/yandex/ClickHouse/pull/2443#discussion_r214001567","pull_request_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments/214001567"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/2443#discussion_r214001567"},"pull_request":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443"}}},"pull_request":{"url":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443","id":191267271,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjY3Mjcx","html_url":"https://github.com/yandex/ClickHouse/pull/2443","diff_url":"https://github.com/yandex/ClickHouse/pull/2443.diff","patch_url":"https://github.com/yandex/ClickHouse/pull/2443.patch","issue_url":"https://api.github.com/repos/yandex/ClickHouse/issues/2443","number":2443,"state":"open","locked":false,"title":" Do not write preprocessed configs to /etc/","user":{"login":"proller","id":1752192,"node_id":"MDQ6VXNlcjE3NTIxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1752192?v=4","gravatar_id":"","url":"https://api.github.com/users/proller","html_url":"https://github.com/proller","followers_url":"https://api.github.com/users/proller/followers","following_url":"https://api.github.com/users/proller/following{/other_user}","gists_url":"https://api.github.com/users/proller/gists{/gist_id}","starred_url":"https://api.github.com/users/proller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proller/subscriptions","organizations_url":"https://api.github.com/users/proller/orgs","repos_url":"https://api.github.com/users/proller/repos","events_url":"https://api.github.com/users/proller/events{/privacy}","received_events_url":"https://api.github.com/users/proller/received_events","type":"User","site_admin":false},"body":"I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en\r\n","created_at":"2018-05-29T20:54:03Z","updated_at":"2018-08-30T11:56:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda457b19a94f6e0124697112343e295865e22d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443/commits","review_comments_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443/comments","review_comment_url":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/issues/2443/comments","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/30b591e70d9f9b2a7ec736f124cb1c201814aa35","head":{"label":"proller:fix14","ref":"fix14","sha":"30b591e70d9f9b2a7ec736f124cb1c201814aa35","user":{"login":"proller","id":1752192,"node_id":"MDQ6VXNlcjE3NTIxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1752192?v=4","gravatar_id":"","url":"https://api.github.com/users/proller","html_url":"https://github.com/proller","followers_url":"https://api.github.com/users/proller/followers","following_url":"https://api.github.com/users/proller/following{/other_user}","gists_url":"https://api.github.com/users/proller/gists{/gist_id}","starred_url":"https://api.github.com/users/proller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proller/subscriptions","organizations_url":"https://api.github.com/users/proller/orgs","repos_url":"https://api.github.com/users/proller/repos","events_url":"https://api.github.com/users/proller/events{/privacy}","received_events_url":"https://api.github.com/users/proller/received_events","type":"User","site_admin":false},"repo":{"id":73570956,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU3MDk1Ng==","name":"ClickHouse","full_name":"proller/ClickHouse","owner":{"login":"proller","id":1752192,"node_id":"MDQ6VXNlcjE3NTIxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1752192?v=4","gravatar_id":"","url":"https://api.github.com/users/proller","html_url":"https://github.com/proller","followers_url":"https://api.github.com/users/proller/followers","following_url":"https://api.github.com/users/proller/following{/other_user}","gists_url":"https://api.github.com/users/proller/gists{/gist_id}","starred_url":"https://api.github.com/users/proller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proller/subscriptions","organizations_url":"https://api.github.com/users/proller/orgs","repos_url":"https://api.github.com/users/proller/repos","events_url":"https://api.github.com/users/proller/events{/privacy}","received_events_url":"https://api.github.com/users/proller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/proller/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":true,"url":"https://api.github.com/repos/proller/ClickHouse","forks_url":"https://api.github.com/repos/proller/ClickHouse/forks","keys_url":"https://api.github.com/repos/proller/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proller/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proller/ClickHouse/teams","hooks_url":"https://api.github.com/repos/proller/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/proller/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/proller/ClickHouse/events","assignees_url":"https://api.github.com/repos/proller/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/proller/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/proller/ClickHouse/tags","blobs_url":"https://api.github.com/repos/proller/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proller/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proller/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/proller/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proller/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/proller/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/proller/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/proller/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/proller/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/proller/ClickHouse/subscription","commits_url":"https://api.github.com/repos/proller/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/proller/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/proller/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/proller/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/proller/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/proller/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proller/ClickHouse/merges","archive_url":"https://api.github.com/repos/proller/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proller/ClickHouse/downloads","issues_url":"https://api.github.com/repos/proller/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/proller/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/proller/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/proller/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proller/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/proller/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/proller/ClickHouse/deployments","created_at":"2016-11-12T18:34:14Z","updated_at":"2018-08-16T19:35:15Z","pushed_at":"2018-08-30T11:53:09Z","git_url":"git://github.com/proller/ClickHouse.git","ssh_url":"git@github.com:proller/ClickHouse.git","clone_url":"https://github.com/proller/ClickHouse.git","svn_url":"https://github.com/proller/ClickHouse","homepage":null,"size":91283,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yandex:master","ref":"master","sha":"ba3a20073c26ff4e2eed5139db49979b1b70c3d5","user":{"login":"yandex","id":7409213,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MDkyMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7409213?v=4","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"repo":{"id":60246359,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0NjM1OQ==","name":"ClickHouse","full_name":"yandex/ClickHouse","owner":{"login":"yandex","id":7409213,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MDkyMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7409213?v=4","gravatar_id":"","url":"https://api.github.com/users/yandex","html_url":"https://github.com/yandex","followers_url":"https://api.github.com/users/yandex/followers","following_url":"https://api.github.com/users/yandex/following{/other_user}","gists_url":"https://api.github.com/users/yandex/gists{/gist_id}","starred_url":"https://api.github.com/users/yandex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yandex/subscriptions","organizations_url":"https://api.github.com/users/yandex/orgs","repos_url":"https://api.github.com/users/yandex/repos","events_url":"https://api.github.com/users/yandex/events{/privacy}","received_events_url":"https://api.github.com/users/yandex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yandex/ClickHouse","description":"ClickHouse is a free analytic DBMS for big data.","fork":false,"url":"https://api.github.com/repos/yandex/ClickHouse","forks_url":"https://api.github.com/repos/yandex/ClickHouse/forks","keys_url":"https://api.github.com/repos/yandex/ClickHouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yandex/ClickHouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yandex/ClickHouse/teams","hooks_url":"https://api.github.com/repos/yandex/ClickHouse/hooks","issue_events_url":"https://api.github.com/repos/yandex/ClickHouse/issues/events{/number}","events_url":"https://api.github.com/repos/yandex/ClickHouse/events","assignees_url":"https://api.github.com/repos/yandex/ClickHouse/assignees{/user}","branches_url":"https://api.github.com/repos/yandex/ClickHouse/branches{/branch}","tags_url":"https://api.github.com/repos/yandex/ClickHouse/tags","blobs_url":"https://api.github.com/repos/yandex/ClickHouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yandex/ClickHouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yandex/ClickHouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/yandex/ClickHouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yandex/ClickHouse/statuses/{sha}","languages_url":"https://api.github.com/repos/yandex/ClickHouse/languages","stargazers_url":"https://api.github.com/repos/yandex/ClickHouse/stargazers","contributors_url":"https://api.github.com/repos/yandex/ClickHouse/contributors","subscribers_url":"https://api.github.com/repos/yandex/ClickHouse/subscribers","subscription_url":"https://api.github.com/repos/yandex/ClickHouse/subscription","commits_url":"https://api.github.com/repos/yandex/ClickHouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/yandex/ClickHouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/yandex/ClickHouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/yandex/ClickHouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/yandex/ClickHouse/contents/{+path}","compare_url":"https://api.github.com/repos/yandex/ClickHouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yandex/ClickHouse/merges","archive_url":"https://api.github.com/repos/yandex/ClickHouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yandex/ClickHouse/downloads","issues_url":"https://api.github.com/repos/yandex/ClickHouse/issues{/number}","pulls_url":"https://api.github.com/repos/yandex/ClickHouse/pulls{/number}","milestones_url":"https://api.github.com/repos/yandex/ClickHouse/milestones{/number}","notifications_url":"https://api.github.com/repos/yandex/ClickHouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yandex/ClickHouse/labels{/name}","releases_url":"https://api.github.com/repos/yandex/ClickHouse/releases{/id}","deployments_url":"https://api.github.com/repos/yandex/ClickHouse/deployments","created_at":"2016-06-02T08:28:18Z","updated_at":"2018-08-30T11:20:16Z","pushed_at":"2018-08-30T11:50:03Z","git_url":"git://github.com/yandex/ClickHouse.git","ssh_url":"git@github.com:yandex/ClickHouse.git","clone_url":"https://github.com/yandex/ClickHouse.git","svn_url":"https://github.com/yandex/ClickHouse","homepage":"https://clickhouse.yandex","size":93968,"stargazers_count":4584,"watchers_count":4584,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":711,"mirror_url":null,"archived":false,"open_issues_count":522,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":711,"open_issues":522,"watchers":4584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443"},"html":{"href":"https://github.com/yandex/ClickHouse/pull/2443"},"issue":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/2443"},"comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/issues/2443/comments"},"review_comments":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443/comments"},"review_comment":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yandex/ClickHouse/pulls/2443/commits"},"statuses":{"href":"https://api.github.com/repos/yandex/ClickHouse/statuses/30b591e70d9f9b2a7ec736f124cb1c201814aa35"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexey-milovidov"}}