{"action":"created","comment":{"url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/comments/211113533","pull_request_review_id":147469249,"id":211113533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTExMzUzMw==","diff_hunk":"@@ -66,7 +69,7 @@ func (p *Patrol) GetBombSquadConfig() BombSquadMetricConfig {\n func (p *Patrol) ListSuppressedMetrics() {\n \tb := p.GetBombSquadConfig()\n \tfor metric, labels := range b.SuppressedMetrics {\n-\t\tfor label, _ := range labels {\n+\t\tfor label := range labels {","path":"patrol/patrol.go","position":44,"original_position":44,"commit_id":"e69212f316000c061e3e592adf7e3792fef7e111","original_commit_id":"7f3b2a38923dd1d73ff2dd327c5f216a22b0f702","user":{"login":"cboggs","id":3492944,"node_id":"MDQ6VXNlcjM0OTI5NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3492944?v=4","gravatar_id":"","url":"https://api.github.com/users/cboggs","html_url":"https://github.com/cboggs","followers_url":"https://api.github.com/users/cboggs/followers","following_url":"https://api.github.com/users/cboggs/following{/other_user}","gists_url":"https://api.github.com/users/cboggs/gists{/gist_id}","starred_url":"https://api.github.com/users/cboggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboggs/subscriptions","organizations_url":"https://api.github.com/users/cboggs/orgs","repos_url":"https://api.github.com/users/cboggs/repos","events_url":"https://api.github.com/users/cboggs/events{/privacy}","received_events_url":"https://api.github.com/users/cboggs/received_events","type":"User","site_admin":false},"body":"Oops, nevermind me. :-)","created_at":"2018-08-19T20:03:54Z","updated_at":"2018-08-19T20:03:54Z","html_url":"https://github.com/Fresh-Tracks/bomb-squad/pull/19#discussion_r211113533","pull_request_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/comments/211113533"},"html":{"href":"https://github.com/Fresh-Tracks/bomb-squad/pull/19#discussion_r211113533"},"pull_request":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19"}},"in_reply_to_id":210906358},"pull_request":{"url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19","id":208998641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTk4NjQx","html_url":"https://github.com/Fresh-Tracks/bomb-squad/pull/19","diff_url":"https://github.com/Fresh-Tracks/bomb-squad/pull/19.diff","patch_url":"https://github.com/Fresh-Tracks/bomb-squad/pull/19.patch","issue_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues/19","number":19,"state":"open","locked":false,"title":"Add first test","user":{"login":"pcarranza","id":4496338,"node_id":"MDQ6VXNlcjQ0OTYzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4496338?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarranza","html_url":"https://github.com/pcarranza","followers_url":"https://api.github.com/users/pcarranza/followers","following_url":"https://api.github.com/users/pcarranza/following{/other_user}","gists_url":"https://api.github.com/users/pcarranza/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarranza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarranza/subscriptions","organizations_url":"https://api.github.com/users/pcarranza/orgs","repos_url":"https://api.github.com/users/pcarranza/repos","events_url":"https://api.github.com/users/pcarranza/events{/privacy}","received_events_url":"https://api.github.com/users/pcarranza/received_events","type":"User","site_admin":false},"body":"This is just a quick spike to add the first test, there are a couple of extra changes around removing the URL handling as a string and doing it all with actual URL objects, and some other improvements in error handling to make it more \"explicit\" as in where is it failing.","created_at":"2018-08-16T22:11:07Z","updated_at":"2018-08-19T20:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf07069b30e0e9e9442ebad5c56bf38c52eab532","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues/19/comments","statuses_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/statuses/e69212f316000c061e3e592adf7e3792fef7e111","head":{"label":"pcarranza:pc/add-first-test","ref":"pc/add-first-test","sha":"e69212f316000c061e3e592adf7e3792fef7e111","user":{"login":"pcarranza","id":4496338,"node_id":"MDQ6VXNlcjQ0OTYzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4496338?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarranza","html_url":"https://github.com/pcarranza","followers_url":"https://api.github.com/users/pcarranza/followers","following_url":"https://api.github.com/users/pcarranza/following{/other_user}","gists_url":"https://api.github.com/users/pcarranza/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarranza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarranza/subscriptions","organizations_url":"https://api.github.com/users/pcarranza/orgs","repos_url":"https://api.github.com/users/pcarranza/repos","events_url":"https://api.github.com/users/pcarranza/events{/privacy}","received_events_url":"https://api.github.com/users/pcarranza/received_events","type":"User","site_admin":false},"repo":{"id":145040086,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwNDAwODY=","name":"bomb-squad","full_name":"pcarranza/bomb-squad","owner":{"login":"pcarranza","id":4496338,"node_id":"MDQ6VXNlcjQ0OTYzMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4496338?v=4","gravatar_id":"","url":"https://api.github.com/users/pcarranza","html_url":"https://github.com/pcarranza","followers_url":"https://api.github.com/users/pcarranza/followers","following_url":"https://api.github.com/users/pcarranza/following{/other_user}","gists_url":"https://api.github.com/users/pcarranza/gists{/gist_id}","starred_url":"https://api.github.com/users/pcarranza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcarranza/subscriptions","organizations_url":"https://api.github.com/users/pcarranza/orgs","repos_url":"https://api.github.com/users/pcarranza/repos","events_url":"https://api.github.com/users/pcarranza/events{/privacy}","received_events_url":"https://api.github.com/users/pcarranza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcarranza/bomb-squad","description":"Automatic detection and silencing of high cardinality series in Prometheus.","fork":true,"url":"https://api.github.com/repos/pcarranza/bomb-squad","forks_url":"https://api.github.com/repos/pcarranza/bomb-squad/forks","keys_url":"https://api.github.com/repos/pcarranza/bomb-squad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcarranza/bomb-squad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcarranza/bomb-squad/teams","hooks_url":"https://api.github.com/repos/pcarranza/bomb-squad/hooks","issue_events_url":"https://api.github.com/repos/pcarranza/bomb-squad/issues/events{/number}","events_url":"https://api.github.com/repos/pcarranza/bomb-squad/events","assignees_url":"https://api.github.com/repos/pcarranza/bomb-squad/assignees{/user}","branches_url":"https://api.github.com/repos/pcarranza/bomb-squad/branches{/branch}","tags_url":"https://api.github.com/repos/pcarranza/bomb-squad/tags","blobs_url":"https://api.github.com/repos/pcarranza/bomb-squad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcarranza/bomb-squad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcarranza/bomb-squad/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcarranza/bomb-squad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcarranza/bomb-squad/statuses/{sha}","languages_url":"https://api.github.com/repos/pcarranza/bomb-squad/languages","stargazers_url":"https://api.github.com/repos/pcarranza/bomb-squad/stargazers","contributors_url":"https://api.github.com/repos/pcarranza/bomb-squad/contributors","subscribers_url":"https://api.github.com/repos/pcarranza/bomb-squad/subscribers","subscription_url":"https://api.github.com/repos/pcarranza/bomb-squad/subscription","commits_url":"https://api.github.com/repos/pcarranza/bomb-squad/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcarranza/bomb-squad/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcarranza/bomb-squad/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcarranza/bomb-squad/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcarranza/bomb-squad/contents/{+path}","compare_url":"https://api.github.com/repos/pcarranza/bomb-squad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcarranza/bomb-squad/merges","archive_url":"https://api.github.com/repos/pcarranza/bomb-squad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcarranza/bomb-squad/downloads","issues_url":"https://api.github.com/repos/pcarranza/bomb-squad/issues{/number}","pulls_url":"https://api.github.com/repos/pcarranza/bomb-squad/pulls{/number}","milestones_url":"https://api.github.com/repos/pcarranza/bomb-squad/milestones{/number}","notifications_url":"https://api.github.com/repos/pcarranza/bomb-squad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcarranza/bomb-squad/labels{/name}","releases_url":"https://api.github.com/repos/pcarranza/bomb-squad/releases{/id}","deployments_url":"https://api.github.com/repos/pcarranza/bomb-squad/deployments","created_at":"2018-08-16T21:17:43Z","updated_at":"2018-08-16T21:17:44Z","pushed_at":"2018-08-18T07:14:43Z","git_url":"git://github.com/pcarranza/bomb-squad.git","ssh_url":"git@github.com:pcarranza/bomb-squad.git","clone_url":"https://github.com/pcarranza/bomb-squad.git","svn_url":"https://github.com/pcarranza/bomb-squad","homepage":"","size":5431,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Fresh-Tracks:master","ref":"master","sha":"122c801d29cd1a59ead7644aa51f80e1825a095c","user":{"login":"Fresh-Tracks","id":25691482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjkxNDgy","avatar_url":"https://avatars1.githubusercontent.com/u/25691482?v=4","gravatar_id":"","url":"https://api.github.com/users/Fresh-Tracks","html_url":"https://github.com/Fresh-Tracks","followers_url":"https://api.github.com/users/Fresh-Tracks/followers","following_url":"https://api.github.com/users/Fresh-Tracks/following{/other_user}","gists_url":"https://api.github.com/users/Fresh-Tracks/gists{/gist_id}","starred_url":"https://api.github.com/users/Fresh-Tracks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fresh-Tracks/subscriptions","organizations_url":"https://api.github.com/users/Fresh-Tracks/orgs","repos_url":"https://api.github.com/users/Fresh-Tracks/repos","events_url":"https://api.github.com/users/Fresh-Tracks/events{/privacy}","received_events_url":"https://api.github.com/users/Fresh-Tracks/received_events","type":"Organization","site_admin":false},"repo":{"id":139904809,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MDQ4MDk=","name":"bomb-squad","full_name":"Fresh-Tracks/bomb-squad","owner":{"login":"Fresh-Tracks","id":25691482,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjkxNDgy","avatar_url":"https://avatars1.githubusercontent.com/u/25691482?v=4","gravatar_id":"","url":"https://api.github.com/users/Fresh-Tracks","html_url":"https://github.com/Fresh-Tracks","followers_url":"https://api.github.com/users/Fresh-Tracks/followers","following_url":"https://api.github.com/users/Fresh-Tracks/following{/other_user}","gists_url":"https://api.github.com/users/Fresh-Tracks/gists{/gist_id}","starred_url":"https://api.github.com/users/Fresh-Tracks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fresh-Tracks/subscriptions","organizations_url":"https://api.github.com/users/Fresh-Tracks/orgs","repos_url":"https://api.github.com/users/Fresh-Tracks/repos","events_url":"https://api.github.com/users/Fresh-Tracks/events{/privacy}","received_events_url":"https://api.github.com/users/Fresh-Tracks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fresh-Tracks/bomb-squad","description":"Automatic detection and silencing of high cardinality series in Prometheus.","fork":false,"url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad","forks_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/forks","keys_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/teams","hooks_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/hooks","issue_events_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues/events{/number}","events_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/events","assignees_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/assignees{/user}","branches_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/branches{/branch}","tags_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/tags","blobs_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/statuses/{sha}","languages_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/languages","stargazers_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/stargazers","contributors_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/contributors","subscribers_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/subscribers","subscription_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/subscription","commits_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/contents/{+path}","compare_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/merges","archive_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/downloads","issues_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues{/number}","pulls_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls{/number}","milestones_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/milestones{/number}","notifications_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/labels{/name}","releases_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/releases{/id}","deployments_url":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/deployments","created_at":"2018-07-05T22:01:27Z","updated_at":"2018-08-18T03:30:23Z","pushed_at":"2018-08-18T07:14:45Z","git_url":"git://github.com/Fresh-Tracks/bomb-squad.git","ssh_url":"git@github.com:Fresh-Tracks/bomb-squad.git","clone_url":"https://github.com/Fresh-Tracks/bomb-squad.git","svn_url":"https://github.com/Fresh-Tracks/bomb-squad","homepage":"","size":5428,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":10,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19"},"html":{"href":"https://github.com/Fresh-Tracks/bomb-squad/pull/19"},"issue":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues/19"},"comments":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Fresh-Tracks/bomb-squad/statuses/e69212f316000c061e3e592adf7e3792fef7e111"}},"author_association":"NONE"}}
{"actor":{"display_login":"cboggs"}}