{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12830","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12830/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12830/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12830/events","html_url":"https://github.com/bitcoin/bitcoin/pull/12830","id":309796463,"number":12830,"title":"[qt] [tests] Clarify address book error messages, add tests","user":{"login":"jamesob","id":73197,"avatar_url":"https://avatars0.githubusercontent.com/u/73197?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesob","html_url":"https://github.com/jamesob","followers_url":"https://api.github.com/users/jamesob/followers","following_url":"https://api.github.com/users/jamesob/following{/other_user}","gists_url":"https://api.github.com/users/jamesob/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesob/subscriptions","organizations_url":"https://api.github.com/users/jamesob/orgs","repos_url":"https://api.github.com/users/jamesob/repos","events_url":"https://api.github.com/users/jamesob/events{/privacy}","received_events_url":"https://api.github.com/users/jamesob/received_events","type":"User","site_admin":false},"labels":[{"id":135946,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/GUI","name":"GUI","color":"02d7e1","default":false},{"id":62963516,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-03-29T15:17:29Z","updated_at":"2018-04-10T23:31:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12830","html_url":"https://github.com/bitcoin/bitcoin/pull/12830","diff_url":"https://github.com/bitcoin/bitcoin/pull/12830.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12830.patch"},"body":"Addresses https://github.com/bitcoin/bitcoin/issues/12796.\r\n\r\nWhen a user attempts to add to the address book a sending address which is already present as a receiving address, they're presented with a confusing error indicating the address is already present in the book, despite the fact that this row is currently invisible. \r\n\r\n![selection_011](https://user-images.githubusercontent.com/73197/38096704-8a2948d2-3341-11e8-9632-7d563201f28c.jpg)\r\n\r\nThis change adds a more specific error message indicating its existence as a receiving address (as discussed in the linked issue).\r\n\r\n![selection_016](https://user-images.githubusercontent.com/73197/38198467-fa26164e-365a-11e8-8fc5-ddab9caf2fbd.jpg)\r\n\r\nThis change also adds some tests exercising use of the address book via QT. Adding so much test code for such a trivial change may seem weird, but it's my hope that this will make further test-writing for address book usage (and other QT features) more approachable."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/380279527","html_url":"https://github.com/bitcoin/bitcoin/pull/12830#issuecomment-380279527","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12830","id":380279527,"user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T23:31:10Z","updated_at":"2018-04-10T23:31:10Z","author_association":"MEMBER","body":"utACK e6e1da33783408182e52fa73a11b6559ee0022f7"}}
{"actor":{"display_login":"jnewbery"}}