{"action":"created","comment":{"url":"https://api.github.com/repos/commaai/openpilot/pulls/comments/244094241","pull_request_review_id":188016915,"id":244094241,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDA5NDI0MQ==","diff_hunk":"@@ -26,21 +26,23 @@ def create_lkas11(packer, car_fingerprint, apply_steer, steer_req, cnt, enabled,\n     \"CF_Lkas_FcwCollisionWarning\": lkas11[\"CF_Lkas_FcwCollisionWarning\"] if keep_stock else 0,\n     \"CF_Lkas_FusionState\": lkas11[\"CF_Lkas_FusionState\"] if keep_stock else 0,\n     \"CF_Lkas_Chksum\": 0,\n-    \"CF_Lkas_FcwOpt_USM\": 2 if enabled else 1,\n+    \"CF_Lkas_FcwOpt_USM\": lkas11[\"CF_Lkas_FcwOpt_USM\"] if keep_stock else (2 if enabled else 1),\n     \"CF_Lkas_LdwsOpt_USM\": lkas11[\"CF_Lkas_LdwsOpt_USM\"] if keep_stock else 3,\n+    \"CF_Lkas_Unknown1\": lkas11[\"CF_Lkas_Unknown1\"] if keep_stock else 0,\n+    \"CF_Lkas_Unknown2\": lkas11[\"CF_Lkas_Unknown2\"] if keep_stock else 0,","path":"selfdrive/car/hyundai/hyundaican.py","position":24,"original_position":24,"commit_id":"0b4c01579b84bc55617873522011179dfddf44f1","original_commit_id":"73316047f4e7c70b06c4c9264458066e90204c12","user":{"login":"rbiasini","id":17696146,"node_id":"MDQ6VXNlcjE3Njk2MTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/17696146?v=4","gravatar_id":"","url":"https://api.github.com/users/rbiasini","html_url":"https://github.com/rbiasini","followers_url":"https://api.github.com/users/rbiasini/followers","following_url":"https://api.github.com/users/rbiasini/following{/other_user}","gists_url":"https://api.github.com/users/rbiasini/gists{/gist_id}","starred_url":"https://api.github.com/users/rbiasini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbiasini/subscriptions","organizations_url":"https://api.github.com/users/rbiasini/orgs","repos_url":"https://api.github.com/users/rbiasini/repos","events_url":"https://api.github.com/users/rbiasini/events{/privacy}","received_events_url":"https://api.github.com/users/rbiasini/received_events","type":"User","site_admin":false},"body":"but these are not defined in the dbc file. Eventually the can packer should return an error (right now it might not, but not by design)","created_at":"2018-12-27T07:07:05Z","updated_at":"2018-12-27T07:07:05Z","html_url":"https://github.com/commaai/openpilot/pull/485#discussion_r244094241","pull_request_url":"https://api.github.com/repos/commaai/openpilot/pulls/485","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/comments/244094241"},"html":{"href":"https://github.com/commaai/openpilot/pull/485#discussion_r244094241"},"pull_request":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/485"}},"in_reply_to_id":243949103},"pull_request":{"url":"https://api.github.com/repos/commaai/openpilot/pulls/485","id":240923595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTIzNTk1","html_url":"https://github.com/commaai/openpilot/pull/485","diff_url":"https://github.com/commaai/openpilot/pull/485.diff","patch_url":"https://github.com/commaai/openpilot/pull/485.patch","issue_url":"https://api.github.com/repos/commaai/openpilot/issues/485","number":485,"state":"open","locked":false,"title":"Better Hyundai and Genesis Support, Better future model scaling","user":{"login":"emmertex","id":5079957,"node_id":"MDQ6VXNlcjUwNzk5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5079957?v=4","gravatar_id":"","url":"https://api.github.com/users/emmertex","html_url":"https://github.com/emmertex","followers_url":"https://api.github.com/users/emmertex/followers","following_url":"https://api.github.com/users/emmertex/following{/other_user}","gists_url":"https://api.github.com/users/emmertex/gists{/gist_id}","starred_url":"https://api.github.com/users/emmertex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmertex/subscriptions","organizations_url":"https://api.github.com/users/emmertex/orgs","repos_url":"https://api.github.com/users/emmertex/repos","events_url":"https://api.github.com/users/emmertex/events{/privacy}","received_events_url":"https://api.github.com/users/emmertex/received_events","type":"User","site_admin":false},"body":"This includes https://github.com/commaai/openpilot/pull/481\r\nSo should be merged only after #481 is merged\r\n\r\nComments I will place in changes","created_at":"2018-12-26T06:31:55Z","updated_at":"2018-12-27T07:07:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a2cf0f59da91c84e8b848028e218e2e8064380f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/commaai/openpilot/pulls/485/commits","review_comments_url":"https://api.github.com/repos/commaai/openpilot/pulls/485/comments","review_comment_url":"https://api.github.com/repos/commaai/openpilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commaai/openpilot/issues/485/comments","statuses_url":"https://api.github.com/repos/commaai/openpilot/statuses/0b4c01579b84bc55617873522011179dfddf44f1","head":{"label":"emmertex:comma_release2_b","ref":"comma_release2_b","sha":"0b4c01579b84bc55617873522011179dfddf44f1","user":{"login":"emmertex","id":5079957,"node_id":"MDQ6VXNlcjUwNzk5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5079957?v=4","gravatar_id":"","url":"https://api.github.com/users/emmertex","html_url":"https://github.com/emmertex","followers_url":"https://api.github.com/users/emmertex/followers","following_url":"https://api.github.com/users/emmertex/following{/other_user}","gists_url":"https://api.github.com/users/emmertex/gists{/gist_id}","starred_url":"https://api.github.com/users/emmertex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmertex/subscriptions","organizations_url":"https://api.github.com/users/emmertex/orgs","repos_url":"https://api.github.com/users/emmertex/repos","events_url":"https://api.github.com/users/emmertex/events{/privacy}","received_events_url":"https://api.github.com/users/emmertex/received_events","type":"User","site_admin":false},"repo":{"id":142501631,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1MDE2MzE=","name":"openpilot","full_name":"emmertex/openpilot","private":false,"owner":{"login":"emmertex","id":5079957,"node_id":"MDQ6VXNlcjUwNzk5NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5079957?v=4","gravatar_id":"","url":"https://api.github.com/users/emmertex","html_url":"https://github.com/emmertex","followers_url":"https://api.github.com/users/emmertex/followers","following_url":"https://api.github.com/users/emmertex/following{/other_user}","gists_url":"https://api.github.com/users/emmertex/gists{/gist_id}","starred_url":"https://api.github.com/users/emmertex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmertex/subscriptions","organizations_url":"https://api.github.com/users/emmertex/orgs","repos_url":"https://api.github.com/users/emmertex/repos","events_url":"https://api.github.com/users/emmertex/events{/privacy}","received_events_url":"https://api.github.com/users/emmertex/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emmertex/openpilot","description":"The better way to drive a Kia or Hyundai","fork":true,"url":"https://api.github.com/repos/emmertex/openpilot","forks_url":"https://api.github.com/repos/emmertex/openpilot/forks","keys_url":"https://api.github.com/repos/emmertex/openpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emmertex/openpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emmertex/openpilot/teams","hooks_url":"https://api.github.com/repos/emmertex/openpilot/hooks","issue_events_url":"https://api.github.com/repos/emmertex/openpilot/issues/events{/number}","events_url":"https://api.github.com/repos/emmertex/openpilot/events","assignees_url":"https://api.github.com/repos/emmertex/openpilot/assignees{/user}","branches_url":"https://api.github.com/repos/emmertex/openpilot/branches{/branch}","tags_url":"https://api.github.com/repos/emmertex/openpilot/tags","blobs_url":"https://api.github.com/repos/emmertex/openpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emmertex/openpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emmertex/openpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/emmertex/openpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emmertex/openpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/emmertex/openpilot/languages","stargazers_url":"https://api.github.com/repos/emmertex/openpilot/stargazers","contributors_url":"https://api.github.com/repos/emmertex/openpilot/contributors","subscribers_url":"https://api.github.com/repos/emmertex/openpilot/subscribers","subscription_url":"https://api.github.com/repos/emmertex/openpilot/subscription","commits_url":"https://api.github.com/repos/emmertex/openpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/emmertex/openpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/emmertex/openpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/emmertex/openpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/emmertex/openpilot/contents/{+path}","compare_url":"https://api.github.com/repos/emmertex/openpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emmertex/openpilot/merges","archive_url":"https://api.github.com/repos/emmertex/openpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emmertex/openpilot/downloads","issues_url":"https://api.github.com/repos/emmertex/openpilot/issues{/number}","pulls_url":"https://api.github.com/repos/emmertex/openpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/emmertex/openpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/emmertex/openpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emmertex/openpilot/labels{/name}","releases_url":"https://api.github.com/repos/emmertex/openpilot/releases{/id}","deployments_url":"https://api.github.com/repos/emmertex/openpilot/deployments","created_at":"2018-07-26T22:49:14Z","updated_at":"2018-12-23T04:00:07Z","pushed_at":"2018-12-27T06:19:40Z","git_url":"git://github.com/emmertex/openpilot.git","ssh_url":"git@github.com:emmertex/openpilot.git","clone_url":"https://github.com/emmertex/openpilot.git","svn_url":"https://github.com/emmertex/openpilot","homepage":"","size":392064,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":0,"watchers":7,"default_branch":"community"}},"base":{"label":"commaai:devel","ref":"devel","sha":"4d2ff103d6fbebcaa92189ebb07b9f89290373ad","user":{"login":"commaai","id":16128714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTI4NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/16128714?v=4","gravatar_id":"","url":"https://api.github.com/users/commaai","html_url":"https://github.com/commaai","followers_url":"https://api.github.com/users/commaai/followers","following_url":"https://api.github.com/users/commaai/following{/other_user}","gists_url":"https://api.github.com/users/commaai/gists{/gist_id}","starred_url":"https://api.github.com/users/commaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commaai/subscriptions","organizations_url":"https://api.github.com/users/commaai/orgs","repos_url":"https://api.github.com/users/commaai/repos","events_url":"https://api.github.com/users/commaai/events{/privacy}","received_events_url":"https://api.github.com/users/commaai/received_events","type":"Organization","site_admin":false},"repo":{"id":74627617,"node_id":"MDEwOlJlcG9zaXRvcnk3NDYyNzYxNw==","name":"openpilot","full_name":"commaai/openpilot","private":false,"owner":{"login":"commaai","id":16128714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTI4NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/16128714?v=4","gravatar_id":"","url":"https://api.github.com/users/commaai","html_url":"https://github.com/commaai","followers_url":"https://api.github.com/users/commaai/followers","following_url":"https://api.github.com/users/commaai/following{/other_user}","gists_url":"https://api.github.com/users/commaai/gists{/gist_id}","starred_url":"https://api.github.com/users/commaai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commaai/subscriptions","organizations_url":"https://api.github.com/users/commaai/orgs","repos_url":"https://api.github.com/users/commaai/repos","events_url":"https://api.github.com/users/commaai/events{/privacy}","received_events_url":"https://api.github.com/users/commaai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commaai/openpilot","description":"open source driving agent","fork":false,"url":"https://api.github.com/repos/commaai/openpilot","forks_url":"https://api.github.com/repos/commaai/openpilot/forks","keys_url":"https://api.github.com/repos/commaai/openpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commaai/openpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commaai/openpilot/teams","hooks_url":"https://api.github.com/repos/commaai/openpilot/hooks","issue_events_url":"https://api.github.com/repos/commaai/openpilot/issues/events{/number}","events_url":"https://api.github.com/repos/commaai/openpilot/events","assignees_url":"https://api.github.com/repos/commaai/openpilot/assignees{/user}","branches_url":"https://api.github.com/repos/commaai/openpilot/branches{/branch}","tags_url":"https://api.github.com/repos/commaai/openpilot/tags","blobs_url":"https://api.github.com/repos/commaai/openpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commaai/openpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commaai/openpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/commaai/openpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commaai/openpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/commaai/openpilot/languages","stargazers_url":"https://api.github.com/repos/commaai/openpilot/stargazers","contributors_url":"https://api.github.com/repos/commaai/openpilot/contributors","subscribers_url":"https://api.github.com/repos/commaai/openpilot/subscribers","subscription_url":"https://api.github.com/repos/commaai/openpilot/subscription","commits_url":"https://api.github.com/repos/commaai/openpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/commaai/openpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/commaai/openpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/commaai/openpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/commaai/openpilot/contents/{+path}","compare_url":"https://api.github.com/repos/commaai/openpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commaai/openpilot/merges","archive_url":"https://api.github.com/repos/commaai/openpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commaai/openpilot/downloads","issues_url":"https://api.github.com/repos/commaai/openpilot/issues{/number}","pulls_url":"https://api.github.com/repos/commaai/openpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/commaai/openpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/commaai/openpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commaai/openpilot/labels{/name}","releases_url":"https://api.github.com/repos/commaai/openpilot/releases{/id}","deployments_url":"https://api.github.com/repos/commaai/openpilot/deployments","created_at":"2016-11-24T01:33:30Z","updated_at":"2018-12-27T05:43:13Z","pushed_at":"2018-12-27T06:19:42Z","git_url":"git://github.com/commaai/openpilot.git","ssh_url":"git@github.com:commaai/openpilot.git","clone_url":"https://github.com/commaai/openpilot.git","svn_url":"https://github.com/commaai/openpilot","homepage":"","size":385137,"stargazers_count":9068,"watchers_count":9068,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2210,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2210,"open_issues":83,"watchers":9068,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/485"},"html":{"href":"https://github.com/commaai/openpilot/pull/485"},"issue":{"href":"https://api.github.com/repos/commaai/openpilot/issues/485"},"comments":{"href":"https://api.github.com/repos/commaai/openpilot/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commaai/openpilot/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/commaai/openpilot/statuses/0b4c01579b84bc55617873522011179dfddf44f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rbiasini"}}