{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27378","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27378/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27378/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27378/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27378","id":342130416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTA2MDk3","number":27378,"title":"[prop-types] use conditional types for better prop type inference","user":{"login":"ferdaber","id":12239873,"node_id":"MDQ6VXNlcjEyMjM5ODcz","avatar_url":"https://avatars2.githubusercontent.com/u/12239873?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdaber","html_url":"https://github.com/ferdaber","followers_url":"https://api.github.com/users/ferdaber/followers","following_url":"https://api.github.com/users/ferdaber/following{/other_user}","gists_url":"https://api.github.com/users/ferdaber/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdaber/subscriptions","organizations_url":"https://api.github.com/users/ferdaber/orgs","repos_url":"https://api.github.com/users/ferdaber/repos","events_url":"https://api.github.com/users/ferdaber/events{/privacy}","received_events_url":"https://api.github.com/users/ferdaber/received_events","type":"User","site_admin":false},"labels":[{"id":644095236,"node_id":"MDU6TGFiZWw2NDQwOTUyMzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:Express","name":"Merge:Express","color":"00AA00","default":false},{"id":905334095,"node_id":"MDU6TGFiZWw5MDUzMzQwOTU=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Owner%20Approved","name":"Owner Approved","color":"0e8a16","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-07-18T00:05:13Z","updated_at":"2018-08-01T01:41:28Z","closed_at":"2018-07-21T12:41:16Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/27378","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27378","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27378.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27378.patch"},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nThis PR is the split first part of this closed PR:\r\nhttps://github.com/DefinitelyTyped/DefinitelyTyped/pull/27267\r\nFurther context for what we want to ultimately achieve:\r\nhttps://github.com/Microsoft/TypeScript/pull/24422"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/409420951","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27378#issuecomment-409420951","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27378","id":409420951,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTQyMDk1MQ==","user":{"login":"weswigham","id":2932786,"node_id":"MDQ6VXNlcjI5MzI3ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/2932786?v=4","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T01:41:28Z","updated_at":"2018-08-01T01:41:28Z","author_association":"CONTRIBUTOR","body":"Although @ferdaber it may be worth using something akin to @ajafff 's\r\n```ts\r\ntype KnownKeys<T> = {\r\n    [K in keyof T]: string extends K ? never : number extends K ? never : K\r\n} extends {[_ in keyof T]: infer U} ? U : never;\r\n```\r\nto work around the problem as well - that should allow it to work right now."}}
{"actor":{"display_login":"weswigham"}}