{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-react/pulls/comments/235728702","pull_request_review_id":177660626,"id":235728702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTcyODcwMg==","diff_hunk":"@@ -3,38 +3,71 @@\n   (:require [status-im.ui.components.react :as react]\n             [status-im.ui.components.status-bar.view :as status-bar]\n             [status-im.ui.components.icons.vector-icons :as vi]\n-            [status-im.ui.screens.wallet.styles :as wallet.styles]\n+            [status-im.react-native.resources :as resources]\n             [status-im.ui.screens.wallet.transaction-sent.styles :as styles]\n-            [status-im.ui.components.styles :as components.styles]\n             [re-frame.core :as re-frame]\n-            [status-im.ui.screens.wallet.components.views :as components]\n             [status-im.i18n :as i18n]\n             [status-im.utils.platform :as platform]\n             [status-im.ui.components.colors :as colors]))\n \n-(defview transaction-sent [& [modal?]]\n+(defn- ok-circle []\n+  [react/view {:background-color \"rgba(0,0,0,0.1)\"\n+               :width            160\n+               :height           160\n+               :border-radius    81\n+               :align-items      :center\n+               :justify-content  :center}\n+   [react/view {:background-color colors/white\n+                :width            80\n+                :height           80\n+                :border-radius    41\n+                :shadowRadius     4\n+                :shadow-offset    {:width 0 :height 2}\n+                :shadowOpacity    0.8\n+                :shadowColor      \"rgba(43, 59, 71, 0.12)\"\n+                :align-items      :center\n+                :justify-content  :center}\n+    [vi/icon :icons/tiny-check {:color colors/blue}]]])\n+\n+(defn- transaction-sent-message []\n+  [react/view {:align-items :center}\n+   [react/text {:style               styles/transaction-sent\n+                :font                (if platform/android? :medium :default)\n+                :accessibility-label :transaction-sent-text}\n+    (i18n/label :t/transaction-sent)]\n+   [react/i18n-text {:style styles/transaction-sent-description\n+                     :key   :transaction-description}]])\n+\n+(defn- bottom-action-button [on-next]\n+  [react/touchable-highlight {:on-press on-next\n+                              :style {:border-top-width 1\n+                                      :border-color     \"rgba(255, 255, 255, 0.1)\"}","path":"src/status_im/ui/screens/wallet/transaction_sent/views.cljs","position":null,"original_position":46,"commit_id":"977a3204473b55f6d5bbb8aeb47de40cd24807be","original_commit_id":"d0aa0c20b2351e8b8075160664135752c7423eb5","user":{"login":"bhauman","id":2624,"node_id":"MDQ6VXNlcjI2MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2624?v=4","gravatar_id":"","url":"https://api.github.com/users/bhauman","html_url":"https://github.com/bhauman","followers_url":"https://api.github.com/users/bhauman/followers","following_url":"https://api.github.com/users/bhauman/following{/other_user}","gists_url":"https://api.github.com/users/bhauman/gists{/gist_id}","starred_url":"https://api.github.com/users/bhauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhauman/subscriptions","organizations_url":"https://api.github.com/users/bhauman/orgs","repos_url":"https://api.github.com/users/bhauman/repos","events_url":"https://api.github.com/users/bhauman/events{/privacy}","received_events_url":"https://api.github.com/users/bhauman/received_events","type":"User","site_admin":false},"body":"fixed!","created_at":"2018-11-22T13:38:55Z","updated_at":"2018-11-22T13:38:55Z","html_url":"https://github.com/status-im/status-react/pull/6832#discussion_r235728702","pull_request_url":"https://api.github.com/repos/status-im/status-react/pulls/6832","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments/235728702"},"html":{"href":"https://github.com/status-im/status-react/pull/6832#discussion_r235728702"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6832"}},"in_reply_to_id":235642965},"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/6832","id":232741774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzQxNzc0","html_url":"https://github.com/status-im/status-react/pull/6832","diff_url":"https://github.com/status-im/status-react/pull/6832.diff","patch_url":"https://github.com/status-im/status-react/pull/6832.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/6832","number":6832,"state":"open","locked":false,"title":"[#6815] restyle sent-transaction screen","user":{"login":"bhauman","id":2624,"node_id":"MDQ6VXNlcjI2MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2624?v=4","gravatar_id":"","url":"https://api.github.com/users/bhauman","html_url":"https://github.com/bhauman","followers_url":"https://api.github.com/users/bhauman/followers","following_url":"https://api.github.com/users/bhauman/following{/other_user}","gists_url":"https://api.github.com/users/bhauman/gists{/gist_id}","starred_url":"https://api.github.com/users/bhauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhauman/subscriptions","organizations_url":"https://api.github.com/users/bhauman/orgs","repos_url":"https://api.github.com/users/bhauman/repos","events_url":"https://api.github.com/users/bhauman/events{/privacy}","received_events_url":"https://api.github.com/users/bhauman/received_events","type":"User","site_admin":false},"body":"fixes #6815 \r\n\r\n### Summary:\r\n\r\nThis restyles the Wallet's final transaction sent screen. This was done according the `Transaction Sent` screen in the following figma.\r\n\r\nhttps://www.figma.com/file/SIeZPHvrX7KUwEBW8VQct8C5/WIP_New-send-transaction?node-id=0%3A1\r\n\r\n### Review notes:\r\n\r\nI have taken much care in this commit to make the code clear and meaningful.  The reviewer will see that I have inlined styles in quite a few instances. It is my opinion that abstractions like `component/flex` which means `{:flex 1}` are detrimental to the understanding of the code. When abstracting and naming things they need to merit abstraction and provide value  (i.e `map` is a good abstraction and `components/flex` isn't). If an abstraction is just a name that doesn't mean anything, all that name does is remove meaning from the immediate and it obfuscates it.\r\n\r\nInlining simple styles so that it helps the reader understand why this `react/view` component is being used is very very helpful.\r\n\r\nI have also inlined style that creates a graphical figure because that is the full meaning of the code to abstract that removes meaning from the location where you are actually looking for it.\r\n\r\nIf a style removes meaning from the view or if it is complex and reused I say yes abstract it, and if you do abstract it give it a meaningful name.\r\n\r\n### Testing notes:\r\n\r\nJust ensure that the Transaction sent screen is displayed as it is in the figma file.\r\n\r\n#### Platforms\r\n- Android\r\n- iOS\r\n\r\n#### Areas that maybe impacted (optional)\r\n**Functional**\r\n- wallet / transactions\r\n\r\n### Steps to test:\r\n- Open Status\r\n- Send a transaction and view the final fabulous Transaction Sent screen\r\n- Hit the done button and see that it behaves correctly\r\n\r\nstatus: ready\r\n\r\n\r\n<blockquote><img src=\"/file/SIeZPHvrX7KUwEBW8VQct8C5/thumbnail?ver=thumbnails/07cb8fe4-f735-4817-8a2f-c90f8d72fa38\" width=\"48\" align=\"right\"><div><img src=\"https://static.figma.com/app/icon/1/favicon.svg\" height=\"14\"> Figma</div><div><strong><a href=\"https://www.figma.com/file/SIeZPHvrX7KUwEBW8VQct8C5/WIP_New-send-transaction\">Figma</a></strong></div><div>Created with Figma</div></blockquote>","created_at":"2018-11-21T17:14:18Z","updated_at":"2018-11-22T13:38:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe1bedb684a516c2b91d140891121e31abb3bc03","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yenda","id":1181225,"node_id":"MDQ6VXNlcjExODEyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1181225?v=4","gravatar_id":"","url":"https://api.github.com/users/yenda","html_url":"https://github.com/yenda","followers_url":"https://api.github.com/users/yenda/followers","following_url":"https://api.github.com/users/yenda/following{/other_user}","gists_url":"https://api.github.com/users/yenda/gists{/gist_id}","starred_url":"https://api.github.com/users/yenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenda/subscriptions","organizations_url":"https://api.github.com/users/yenda/orgs","repos_url":"https://api.github.com/users/yenda/repos","events_url":"https://api.github.com/users/yenda/events{/privacy}","received_events_url":"https://api.github.com/users/yenda/received_events","type":"User","site_admin":false},{"login":"flexsurfer","id":11790366,"node_id":"MDQ6VXNlcjExNzkwMzY2","avatar_url":"https://avatars1.githubusercontent.com/u/11790366?v=4","gravatar_id":"","url":"https://api.github.com/users/flexsurfer","html_url":"https://github.com/flexsurfer","followers_url":"https://api.github.com/users/flexsurfer/followers","following_url":"https://api.github.com/users/flexsurfer/following{/other_user}","gists_url":"https://api.github.com/users/flexsurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/flexsurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flexsurfer/subscriptions","organizations_url":"https://api.github.com/users/flexsurfer/orgs","repos_url":"https://api.github.com/users/flexsurfer/repos","events_url":"https://api.github.com/users/flexsurfer/events{/privacy}","received_events_url":"https://api.github.com/users/flexsurfer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/6832/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/6832/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/6832/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/977a3204473b55f6d5bbb8aeb47de40cd24807be","head":{"label":"status-im:feature/restyle-transaction-sent-screen-6815","ref":"feature/restyle-transaction-sent-screen-6815","sha":"977a3204473b55f6d5bbb8aeb47de40cd24807be","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","private":false,"owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-11-22T13:29:03Z","pushed_at":"2018-11-22T13:38:31Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":76907,"stargazers_count":2490,"watchers_count":2490,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":606,"mirror_url":null,"archived":false,"open_issues_count":571,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":606,"open_issues":571,"watchers":2490,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"f1b457677c9775376190c6a16e5cf2607f2bf90d","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","private":false,"owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-11-22T13:29:03Z","pushed_at":"2018-11-22T13:38:31Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":76907,"stargazers_count":2490,"watchers_count":2490,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":606,"mirror_url":null,"archived":false,"open_issues_count":571,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":606,"open_issues":571,"watchers":2490,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6832"},"html":{"href":"https://github.com/status-im/status-react/pull/6832"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/6832"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/6832/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6832/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6832/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/977a3204473b55f6d5bbb8aeb47de40cd24807be"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bhauman"}}