{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/7613","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/7613/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/7613/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/7613/events","html_url":"https://github.com/qgis/QGIS/pull/7613","id":350509642,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzQ0MzUz","number":7613,"title":"Mesh layer fixes and improvements","user":{"login":"wonder-sk","id":193367,"node_id":"MDQ6VXNlcjE5MzM2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/193367?v=4","gravatar_id":"","url":"https://api.github.com/users/wonder-sk","html_url":"https://github.com/wonder-sk","followers_url":"https://api.github.com/users/wonder-sk/followers","following_url":"https://api.github.com/users/wonder-sk/following{/other_user}","gists_url":"https://api.github.com/users/wonder-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/wonder-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonder-sk/subscriptions","organizations_url":"https://api.github.com/users/wonder-sk/orgs","repos_url":"https://api.github.com/users/wonder-sk/repos","events_url":"https://api.github.com/users/wonder-sk/events{/privacy}","received_events_url":"https://api.github.com/users/wonder-sk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-14T16:44:50Z","updated_at":"2018-08-14T18:16:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/7613","html_url":"https://github.com/qgis/QGIS/pull/7613","diff_url":"https://github.com/qgis/QGIS/pull/7613.diff","patch_url":"https://github.com/qgis/QGIS/pull/7613.patch"},"body":"I have planned to fix a few issues but in the end the branch started to grow and grow, with changes dependent on each other. Here's a summary of all changes:\r\n\r\n- loading and saving of mesh layer styling in project files\r\n- extra datasets added to mesh layer get stored in project files\r\n- legend support for mesh layers\r\n- each quantity of mesh layer has its own styling independent from other quantities\r\n- the whole rendering configuration is encapsulated in one class: QgsMeshRendererSettings\r\n- datasets get assigned \"cold to hot\" color ramp by default (independent from QSettings)\r\n- unit tests write output to the HTML report\r\n- assortment of mesh layer styling GUI fixes\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/412967092","html_url":"https://github.com/qgis/QGIS/pull/7613#issuecomment-412967092","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/7613","id":412967092,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjk2NzA5Mg==","user":{"login":"nyalldawson","id":1829991,"node_id":"MDQ6VXNlcjE4Mjk5OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1829991?v=4","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T18:16:20Z","updated_at":"2018-08-14T18:16:20Z","author_association":"CONTRIBUTOR","body":"I can't comment on the logic, but the code cleanups look great!\r\n\r\nOne thing the stands out is this:\r\n\r\n```\r\nstops << QgsGradientStop( 0.25, QColor( 0, 255, 255 ) );\r\n  stops << QgsGradientStop( 0.5, QColor( 0, 255, 0 ) );\r\n  stops << QgsGradientStop( 0.75, QColor( 255, 255, 0 ) );\r\n  return new QgsGradientColorRamp( QColor( 0, 0, 255 ), QColor( 255, 0, 0 ), false, stops );\r\n```\r\n\r\nThat colour ramp makes me nervous (given the current scrutiny under which ramps are exposed for misleading representations). Couldn't we use a more perceptively accurate ramp here? "}}
{"actor":{"display_login":"nyalldawson"}}