{"action":"closed","number":4744,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/4744","id":203054899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDU0ODk5","html_url":"https://github.com/facebook/osquery/pull/4744","diff_url":"https://github.com/facebook/osquery/pull/4744.diff","patch_url":"https://github.com/facebook/osquery/pull/4744.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/4744","number":4744,"state":"closed","locked":false,"title":"pvs-studio errors and warnings fix","user":{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false},"body":"Using pvs-studio, I detected various issues in osquery.\r\ninteger overflow\r\ninserting the same key several times\r\nDead code.\r\n","created_at":"2018-07-22T12:31:07Z","updated_at":"2018-07-30T22:51:36Z","closed_at":"2018-07-30T22:51:36Z","merged_at":"2018-07-30T22:51:35Z","merge_commit_sha":"ac4cbbe062ab1f457a4c6832286a20196da1f192","assignee":{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false},"assignees":[{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"muffins","id":1328916,"node_id":"MDQ6VXNlcjEzMjg5MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1328916?v=4","gravatar_id":"","url":"https://api.github.com/users/muffins","html_url":"https://github.com/muffins","followers_url":"https://api.github.com/users/muffins/followers","following_url":"https://api.github.com/users/muffins/following{/other_user}","gists_url":"https://api.github.com/users/muffins/gists{/gist_id}","starred_url":"https://api.github.com/users/muffins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffins/subscriptions","organizations_url":"https://api.github.com/users/muffins/orgs","repos_url":"https://api.github.com/users/muffins/repos","events_url":"https://api.github.com/users/muffins/events{/privacy}","received_events_url":"https://api.github.com/users/muffins/received_events","type":"User","site_admin":false},{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":117911471,"node_id":"MDU6TGFiZWwxMTc5MTE0NzE=","url":"https://api.github.com/repos/facebook/osquery/labels/bug","name":"bug","color":"fc2929","default":true},{"id":196858822,"node_id":"MDU6TGFiZWwxOTY4NTg4MjI=","url":"https://api.github.com/repos/facebook/osquery/labels/cla%20signed","name":"cla signed","color":"ededed","default":false},{"id":998924279,"node_id":"MDU6TGFiZWw5OTg5MjQyNzk=","url":"https://api.github.com/repos/facebook/osquery/labels/dead%20code","name":"dead code","color":"a5f7c6","default":false},{"id":119503507,"node_id":"MDU6TGFiZWwxMTk1MDM1MDc=","url":"https://api.github.com/repos/facebook/osquery/labels/ready%20for%20review","name":"ready for review","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/4744/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/4744/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/4744/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/c51adf1573215e592efb594bc24eb466c566062e","head":{"label":"guliashvili:unicornfix","ref":"unicornfix","sha":"c51adf1573215e592efb594bc24eb466c566062e","user":{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false},"repo":{"id":133583256,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1ODMyNTY=","name":"osquery","full_name":"guliashvili/osquery","owner":{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guliashvili/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":true,"url":"https://api.github.com/repos/guliashvili/osquery","forks_url":"https://api.github.com/repos/guliashvili/osquery/forks","keys_url":"https://api.github.com/repos/guliashvili/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guliashvili/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guliashvili/osquery/teams","hooks_url":"https://api.github.com/repos/guliashvili/osquery/hooks","issue_events_url":"https://api.github.com/repos/guliashvili/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/guliashvili/osquery/events","assignees_url":"https://api.github.com/repos/guliashvili/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/guliashvili/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/guliashvili/osquery/tags","blobs_url":"https://api.github.com/repos/guliashvili/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guliashvili/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guliashvili/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/guliashvili/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guliashvili/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/guliashvili/osquery/languages","stargazers_url":"https://api.github.com/repos/guliashvili/osquery/stargazers","contributors_url":"https://api.github.com/repos/guliashvili/osquery/contributors","subscribers_url":"https://api.github.com/repos/guliashvili/osquery/subscribers","subscription_url":"https://api.github.com/repos/guliashvili/osquery/subscription","commits_url":"https://api.github.com/repos/guliashvili/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/guliashvili/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/guliashvili/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/guliashvili/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/guliashvili/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/guliashvili/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guliashvili/osquery/merges","archive_url":"https://api.github.com/repos/guliashvili/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guliashvili/osquery/downloads","issues_url":"https://api.github.com/repos/guliashvili/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/guliashvili/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/guliashvili/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/guliashvili/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guliashvili/osquery/labels{/name}","releases_url":"https://api.github.com/repos/guliashvili/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/guliashvili/osquery/deployments","created_at":"2018-05-15T23:16:42Z","updated_at":"2018-07-30T15:06:16Z","pushed_at":"2018-07-30T22:50:08Z","git_url":"git://github.com/guliashvili/osquery.git","ssh_url":"git@github.com:guliashvili/osquery.git","clone_url":"https://github.com/guliashvili/osquery.git","svn_url":"https://github.com/guliashvili/osquery","homepage":"https://osquery.io","size":15752,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"54e0bf3f5f0e903a2a03dd8a535534b8b42cdaf9","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM5NDM1Nw==","name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/osquery/deployments","created_at":"2014-07-29T20:27:33Z","updated_at":"2018-07-30T22:30:17Z","pushed_at":"2018-07-30T22:51:35Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":15628,"stargazers_count":12861,"watchers_count":12861,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1510,"mirror_url":null,"archived":false,"open_issues_count":259,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1510,"open_issues":259,"watchers":12861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4744"},"html":{"href":"https://github.com/facebook/osquery/pull/4744"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/4744"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/4744/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4744/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4744/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/c51adf1573215e592efb594bc24eb466c566062e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":13,"deletions":25,"changed_files":7}}
{"actor":{"display_login":"guliashvili"}}