{"action":"created","comment":{"url":"https://api.github.com/repos/ca-cwds/cans/pulls/comments/225184194","pull_request_review_id":164707605,"id":225184194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTE4NDE5NA==","diff_hunk":"@@ -1,36 +1,47 @@\n-version: '3.2'","path":"docker-compose.yml","position":1,"original_position":1,"commit_id":"00a14c32e1fe6aa9e22c52331205afa5610ebcf9","original_commit_id":"cf1a98cdcce8fed8a289febbae48070dd6981350","user":{"login":"edgibbs","id":100718,"node_id":"MDQ6VXNlcjEwMDcxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/100718?v=4","gravatar_id":"","url":"https://api.github.com/users/edgibbs","html_url":"https://github.com/edgibbs","followers_url":"https://api.github.com/users/edgibbs/followers","following_url":"https://api.github.com/users/edgibbs/following{/other_user}","gists_url":"https://api.github.com/users/edgibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/edgibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgibbs/subscriptions","organizations_url":"https://api.github.com/users/edgibbs/orgs","repos_url":"https://api.github.com/users/edgibbs/repos","events_url":"https://api.github.com/users/edgibbs/events{/privacy}","received_events_url":"https://api.github.com/users/edgibbs/received_events","type":"User","site_admin":false},"body":"So a few things:\r\n\r\n* As a default downgrading is not preferable\r\n* Adding a simple check with wait-for-it or something would guarantee the service is up in a usable state and gets rid of the need for any sleeping \r\n* County Admin had issues where depends_on didn't operate properly for them, Kevin may be able to give more context.","created_at":"2018-10-15T14:22:02Z","updated_at":"2018-10-15T14:31:00Z","html_url":"https://github.com/ca-cwds/cans/pull/209#discussion_r225184194","pull_request_url":"https://api.github.com/repos/ca-cwds/cans/pulls/209","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/cans/pulls/comments/225184194"},"html":{"href":"https://github.com/ca-cwds/cans/pull/209#discussion_r225184194"},"pull_request":{"href":"https://api.github.com/repos/ca-cwds/cans/pulls/209"}},"in_reply_to_id":224627112},"pull_request":{"url":"https://api.github.com/repos/ca-cwds/cans/pulls/209","id":221913083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTEzMDgz","html_url":"https://github.com/ca-cwds/cans/pull/209","diff_url":"https://github.com/ca-cwds/cans/pull/209.diff","patch_url":"https://github.com/ca-cwds/cans/pull/209.patch","issue_url":"https://api.github.com/repos/ca-cwds/cans/issues/209","number":209,"state":"open","locked":false,"title":"CANS-411 Optimize Build processes","user":{"login":"igor-chornobay-engagepoint","id":26773681,"node_id":"MDQ6VXNlcjI2NzczNjgx","avatar_url":"https://avatars0.githubusercontent.com/u/26773681?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-chornobay-engagepoint","html_url":"https://github.com/igor-chornobay-engagepoint","followers_url":"https://api.github.com/users/igor-chornobay-engagepoint/followers","following_url":"https://api.github.com/users/igor-chornobay-engagepoint/following{/other_user}","gists_url":"https://api.github.com/users/igor-chornobay-engagepoint/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-chornobay-engagepoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-chornobay-engagepoint/subscriptions","organizations_url":"https://api.github.com/users/igor-chornobay-engagepoint/orgs","repos_url":"https://api.github.com/users/igor-chornobay-engagepoint/repos","events_url":"https://api.github.com/users/igor-chornobay-engagepoint/events{/privacy}","received_events_url":"https://api.github.com/users/igor-chornobay-engagepoint/received_events","type":"User","site_admin":false},"body":"[CANS-411 Optimize Build processes](https://osi-cwds.atlassian.net/browse/CANS-411)\r\n## Description\r\n<!--- Provide a description with context for those that don't know what this pull request is about. -->\r\nSplit the docker build in two parts: \r\n- base image (not needed to be built every time. most time consuming)\r\n- application deployment\r\n\r\nSome changes in docker-compose for controlled startup of services\r\nThe above allowed to change sleep time in Jenkins acceptance tests from 120 s to 30 s  removing 1.5 minute of unconditional wait time\r\n\r\n## Tests\r\n<!--- Please indicate applicable tests -->\r\n- [ ] I used TDD to develop the feature\r\n- [ ] I have included unit tests\r\n- [ ] I have included new acceptance tests or modified existing ones\r\n- [x] I have included other tests\r\n \r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Refactoring (No behavioral changes)\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. -->\r\n- [x] My code follows the code style of this project.\r\n- [x] I ran all my tests locally which were green.\r\n- [x] My code adds no new issues to Code Climate\r\n- [x] I ran all the linters for the project.\r\n- [x] My code is in a stable state ready to be deployable, but not necessarily complete.\r\n- [x] I promise on my honor as a CWDS developer to ensure I don't break the build (or bring donuts if I leave things broken), to check linters, use best practices, to leave the code in better shape than I found it, and to have a good day.\r\n","created_at":"2018-10-10T19:55:18Z","updated_at":"2018-10-15T14:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ebf9231ab09b66a135b75a544f3a9dc56836215","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LeonidMarushevskyi","id":3201038,"node_id":"MDQ6VXNlcjMyMDEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3201038?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonidMarushevskyi","html_url":"https://github.com/LeonidMarushevskyi","followers_url":"https://api.github.com/users/LeonidMarushevskyi/followers","following_url":"https://api.github.com/users/LeonidMarushevskyi/following{/other_user}","gists_url":"https://api.github.com/users/LeonidMarushevskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonidMarushevskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonidMarushevskyi/subscriptions","organizations_url":"https://api.github.com/users/LeonidMarushevskyi/orgs","repos_url":"https://api.github.com/users/LeonidMarushevskyi/repos","events_url":"https://api.github.com/users/LeonidMarushevskyi/events{/privacy}","received_events_url":"https://api.github.com/users/LeonidMarushevskyi/received_events","type":"User","site_admin":false},{"login":"denys-davydov","id":11778272,"node_id":"MDQ6VXNlcjExNzc4Mjcy","avatar_url":"https://avatars3.githubusercontent.com/u/11778272?v=4","gravatar_id":"","url":"https://api.github.com/users/denys-davydov","html_url":"https://github.com/denys-davydov","followers_url":"https://api.github.com/users/denys-davydov/followers","following_url":"https://api.github.com/users/denys-davydov/following{/other_user}","gists_url":"https://api.github.com/users/denys-davydov/gists{/gist_id}","starred_url":"https://api.github.com/users/denys-davydov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denys-davydov/subscriptions","organizations_url":"https://api.github.com/users/denys-davydov/orgs","repos_url":"https://api.github.com/users/denys-davydov/repos","events_url":"https://api.github.com/users/denys-davydov/events{/privacy}","received_events_url":"https://api.github.com/users/denys-davydov/received_events","type":"User","site_admin":false},{"login":"eckdanny-osi","id":30477263,"node_id":"MDQ6VXNlcjMwNDc3MjYz","avatar_url":"https://avatars2.githubusercontent.com/u/30477263?v=4","gravatar_id":"","url":"https://api.github.com/users/eckdanny-osi","html_url":"https://github.com/eckdanny-osi","followers_url":"https://api.github.com/users/eckdanny-osi/followers","following_url":"https://api.github.com/users/eckdanny-osi/following{/other_user}","gists_url":"https://api.github.com/users/eckdanny-osi/gists{/gist_id}","starred_url":"https://api.github.com/users/eckdanny-osi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eckdanny-osi/subscriptions","organizations_url":"https://api.github.com/users/eckdanny-osi/orgs","repos_url":"https://api.github.com/users/eckdanny-osi/repos","events_url":"https://api.github.com/users/eckdanny-osi/events{/privacy}","received_events_url":"https://api.github.com/users/eckdanny-osi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ca-cwds/cans/pulls/209/commits","review_comments_url":"https://api.github.com/repos/ca-cwds/cans/pulls/209/comments","review_comment_url":"https://api.github.com/repos/ca-cwds/cans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ca-cwds/cans/issues/209/comments","statuses_url":"https://api.github.com/repos/ca-cwds/cans/statuses/00a14c32e1fe6aa9e22c52331205afa5610ebcf9","head":{"label":"ca-cwds:Igor_CANS-411","ref":"Igor_CANS-411","sha":"00a14c32e1fe6aa9e22c52331205afa5610ebcf9","user":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":132033011,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMzMwMTE=","name":"cans","full_name":"ca-cwds/cans","private":false,"owner":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ca-cwds/cans","description":"The CANS application repository","fork":false,"url":"https://api.github.com/repos/ca-cwds/cans","forks_url":"https://api.github.com/repos/ca-cwds/cans/forks","keys_url":"https://api.github.com/repos/ca-cwds/cans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/cans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/cans/teams","hooks_url":"https://api.github.com/repos/ca-cwds/cans/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/cans/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/cans/events","assignees_url":"https://api.github.com/repos/ca-cwds/cans/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/cans/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/cans/tags","blobs_url":"https://api.github.com/repos/ca-cwds/cans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/cans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/cans/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/cans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/cans/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/cans/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/cans/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/cans/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/cans/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/cans/subscription","commits_url":"https://api.github.com/repos/ca-cwds/cans/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/cans/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/cans/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/cans/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/cans/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/cans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/cans/merges","archive_url":"https://api.github.com/repos/ca-cwds/cans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/cans/downloads","issues_url":"https://api.github.com/repos/ca-cwds/cans/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/cans/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/cans/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/cans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/cans/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/cans/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/cans/deployments","created_at":"2018-05-03T18:11:52Z","updated_at":"2018-10-11T23:02:31Z","pushed_at":"2018-10-13T00:01:07Z","git_url":"git://github.com/ca-cwds/cans.git","ssh_url":"git@github.com:ca-cwds/cans.git","clone_url":"https://github.com/ca-cwds/cans.git","svn_url":"https://github.com/ca-cwds/cans","homepage":null,"size":1249,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ca-cwds:master","ref":"master","sha":"d4a36ee5e88852a36518fc9866722dcb2e647d6f","user":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":132033011,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMzMwMTE=","name":"cans","full_name":"ca-cwds/cans","private":false,"owner":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ca-cwds/cans","description":"The CANS application repository","fork":false,"url":"https://api.github.com/repos/ca-cwds/cans","forks_url":"https://api.github.com/repos/ca-cwds/cans/forks","keys_url":"https://api.github.com/repos/ca-cwds/cans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/cans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/cans/teams","hooks_url":"https://api.github.com/repos/ca-cwds/cans/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/cans/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/cans/events","assignees_url":"https://api.github.com/repos/ca-cwds/cans/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/cans/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/cans/tags","blobs_url":"https://api.github.com/repos/ca-cwds/cans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/cans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/cans/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/cans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/cans/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/cans/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/cans/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/cans/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/cans/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/cans/subscription","commits_url":"https://api.github.com/repos/ca-cwds/cans/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/cans/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/cans/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/cans/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/cans/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/cans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/cans/merges","archive_url":"https://api.github.com/repos/ca-cwds/cans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/cans/downloads","issues_url":"https://api.github.com/repos/ca-cwds/cans/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/cans/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/cans/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/cans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/cans/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/cans/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/cans/deployments","created_at":"2018-05-03T18:11:52Z","updated_at":"2018-10-11T23:02:31Z","pushed_at":"2018-10-13T00:01:07Z","git_url":"git://github.com/ca-cwds/cans.git","ssh_url":"git@github.com:ca-cwds/cans.git","clone_url":"https://github.com/ca-cwds/cans.git","svn_url":"https://github.com/ca-cwds/cans","homepage":null,"size":1249,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/cans/pulls/209"},"html":{"href":"https://github.com/ca-cwds/cans/pull/209"},"issue":{"href":"https://api.github.com/repos/ca-cwds/cans/issues/209"},"comments":{"href":"https://api.github.com/repos/ca-cwds/cans/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/ca-cwds/cans/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/ca-cwds/cans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ca-cwds/cans/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/ca-cwds/cans/statuses/00a14c32e1fe6aa9e22c52331205afa5610ebcf9"}},"author_association":"NONE"}}
{"actor":{"display_login":"edgibbs"}}