{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/224581402","pull_request_review_id":163985368,"id":224581402,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU4MTQwMg==","diff_hunk":"@@ -19,6 +19,8 @@ export PATH=$PATH:/work/texlive/bin/x86_64-linux\n \n ccache -z\n \n+# We don't need debug symbols during CI and we are able to reduce memory","path":".travis/BuildLinux.sh","position":4,"original_position":4,"commit_id":"a90fdc58fa15b143d87362208a68255df342831e","original_commit_id":"a90fdc58fa15b143d87362208a68255df342831e","user":{"login":"fmahebert","id":881747,"node_id":"MDQ6VXNlcjg4MTc0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/881747?v=4","gravatar_id":"","url":"https://api.github.com/users/fmahebert","html_url":"https://github.com/fmahebert","followers_url":"https://api.github.com/users/fmahebert/followers","following_url":"https://api.github.com/users/fmahebert/following{/other_user}","gists_url":"https://api.github.com/users/fmahebert/gists{/gist_id}","starred_url":"https://api.github.com/users/fmahebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmahebert/subscriptions","organizations_url":"https://api.github.com/users/fmahebert/orgs","repos_url":"https://api.github.com/users/fmahebert/repos","events_url":"https://api.github.com/users/fmahebert/events{/privacy}","received_events_url":"https://api.github.com/users/fmahebert/received_events","type":"User","site_admin":false},"body":"\"during CI and we are\" -> \"during CI, so, by turning off the symbols, we are\"\r\n\r\n(same in MacOsBuild.sh)","created_at":"2018-10-11T19:47:25Z","updated_at":"2018-10-11T19:47:53Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/1049#discussion_r224581402","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/224581402"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1049#discussion_r224581402"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049","id":222252625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjUyNjI1","html_url":"https://github.com/sxs-collaboration/spectre/pull/1049","diff_url":"https://github.com/sxs-collaboration/spectre/pull/1049.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/1049.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1049","number":1049,"state":"open","locked":false,"title":"Allow disabling debug flags","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\n- Disabling debug symbols reduces memory usage by ~1.5x with GCC (clang it also is reduced but I can't remember how much)\r\n- Disable debug symbols on TravisCI to avoid OOM errors and timeouts.\r\n\r\n### Types of changes:\r\n\r\n- [x] Bugfix\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n- [ ] Documentation\r\n- [x] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc...\r\n-->\r\n","created_at":"2018-10-11T19:28:27Z","updated_at":"2018-10-11T19:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a296ed393f4b059f9f8ff66e8e3f2dda60ec5d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1049/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a90fdc58fa15b143d87362208a68255df342831e","head":{"label":"nilsdeppe:allow_disabling_debug_flags","ref":"allow_disabling_debug_flags","sha":"a90fdc58fa15b143d87362208a68255df342831e","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"repo":{"id":87580722,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU4MDcyMg==","name":"spectre","full_name":"nilsdeppe/spectre","private":false,"owner":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nilsdeppe/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/nilsdeppe/spectre","forks_url":"https://api.github.com/repos/nilsdeppe/spectre/forks","keys_url":"https://api.github.com/repos/nilsdeppe/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nilsdeppe/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nilsdeppe/spectre/teams","hooks_url":"https://api.github.com/repos/nilsdeppe/spectre/hooks","issue_events_url":"https://api.github.com/repos/nilsdeppe/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/nilsdeppe/spectre/events","assignees_url":"https://api.github.com/repos/nilsdeppe/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/nilsdeppe/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/nilsdeppe/spectre/tags","blobs_url":"https://api.github.com/repos/nilsdeppe/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nilsdeppe/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nilsdeppe/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/nilsdeppe/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nilsdeppe/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/nilsdeppe/spectre/languages","stargazers_url":"https://api.github.com/repos/nilsdeppe/spectre/stargazers","contributors_url":"https://api.github.com/repos/nilsdeppe/spectre/contributors","subscribers_url":"https://api.github.com/repos/nilsdeppe/spectre/subscribers","subscription_url":"https://api.github.com/repos/nilsdeppe/spectre/subscription","commits_url":"https://api.github.com/repos/nilsdeppe/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/nilsdeppe/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/nilsdeppe/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/nilsdeppe/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/nilsdeppe/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/nilsdeppe/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nilsdeppe/spectre/merges","archive_url":"https://api.github.com/repos/nilsdeppe/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nilsdeppe/spectre/downloads","issues_url":"https://api.github.com/repos/nilsdeppe/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/nilsdeppe/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/nilsdeppe/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/nilsdeppe/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nilsdeppe/spectre/labels{/name}","releases_url":"https://api.github.com/repos/nilsdeppe/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/nilsdeppe/spectre/deployments","created_at":"2017-04-07T19:36:13Z","updated_at":"2018-10-11T14:54:59Z","pushed_at":"2018-10-11T17:20:42Z","git_url":"git://github.com/nilsdeppe/spectre.git","ssh_url":"git@github.com:nilsdeppe/spectre.git","clone_url":"https://github.com/nilsdeppe/spectre.git","svn_url":"https://github.com/nilsdeppe/spectre","homepage":null,"size":50206,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"614773cf0dcd2fc73f00efe950ff1753b1cd15f8","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","private":false,"owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-10-11T14:25:52Z","pushed_at":"2018-10-11T19:28:27Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":11900,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":141,"watchers":28,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/1049"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1049"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/1049/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/1049/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/a90fdc58fa15b143d87362208a68255df342831e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fmahebert"}}