{"action":"created","comment":{"url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/comments/186379406","pull_request_review_id":117943636,"id":186379406,"diff_hunk":"@@ -2834,7 +2834,16 @@ builder_manifest_finish (BuilderManifest *self,\n \n       if (self->build_runtime)\n         {\n-          debuginfo_dir = g_file_resolve_relative_path (app_dir, \"usr/lib/debug\");\n+          const char * libdir = builder_options_get_libdir (self->build_options, context);","path":"src/builder-manifest.c","position":5,"original_position":5,"commit_id":"e861aaf888500d264a26ba5be82120d53226893b","original_commit_id":"d649c8e20862fe5d5d24841bce16d3cdf29c7397","user":{"login":"alexlarsson","id":990736,"avatar_url":"https://avatars2.githubusercontent.com/u/990736?v=4","gravatar_id":"","url":"https://api.github.com/users/alexlarsson","html_url":"https://github.com/alexlarsson","followers_url":"https://api.github.com/users/alexlarsson/followers","following_url":"https://api.github.com/users/alexlarsson/following{/other_user}","gists_url":"https://api.github.com/users/alexlarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlarsson/subscriptions","organizations_url":"https://api.github.com/users/alexlarsson/orgs","repos_url":"https://api.github.com/users/alexlarsson/repos","events_url":"https://api.github.com/users/alexlarsson/events{/privacy}","received_events_url":"https://api.github.com/users/alexlarsson/received_events","type":"User","site_admin":false},"body":"I don't think we want to modify /usr/lib/debug actually. It already contains the full path below it. For example `/usr/lib/debug/usr/lib/libglib-2.0.so.0.5200.3.debug`.","created_at":"2018-05-07T09:56:44Z","updated_at":"2018-05-07T09:56:45Z","html_url":"https://github.com/flatpak/flatpak-builder/pull/142#discussion_r186379406","pull_request_url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/comments/186379406"},"html":{"href":"https://github.com/flatpak/flatpak-builder/pull/142#discussion_r186379406"},"pull_request":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142","id":185542146,"html_url":"https://github.com/flatpak/flatpak-builder/pull/142","diff_url":"https://github.com/flatpak/flatpak-builder/pull/142.diff","patch_url":"https://github.com/flatpak/flatpak-builder/pull/142.patch","issue_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/142","number":142,"state":"open","locked":false,"title":"Load libdir and flags from SDK configuration file","user":{"login":"valentindavid","id":432830,"avatar_url":"https://avatars0.githubusercontent.com/u/432830?v=4","gravatar_id":"","url":"https://api.github.com/users/valentindavid","html_url":"https://github.com/valentindavid","followers_url":"https://api.github.com/users/valentindavid/followers","following_url":"https://api.github.com/users/valentindavid/following{/other_user}","gists_url":"https://api.github.com/users/valentindavid/gists{/gist_id}","starred_url":"https://api.github.com/users/valentindavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentindavid/subscriptions","organizations_url":"https://api.github.com/users/valentindavid/orgs","repos_url":"https://api.github.com/users/valentindavid/repos","events_url":"https://api.github.com/users/valentindavid/events{/privacy}","received_events_url":"https://api.github.com/users/valentindavid/received_events","type":"User","site_admin":false},"body":"This is a rewrite of #139 using `/etc/flatpak-builder/defaults.json` configuration file from SDK instead of detecting libdir from GCC.\r\n\r\nShould we create BuilderSdkConfig as soon as we have checked out `init` and then pass it around? For the moment I read the configuration every time I need.\r\n\r\nDebug directory also needs to be moved. This is in order to provide .Debug extension for Compat extensions in the future.","created_at":"2018-05-02T19:47:22Z","updated_at":"2018-05-07T09:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38e33a4b4ff8aca2b6e7cf2da2833094698a1d55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142/commits","review_comments_url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142/comments","review_comment_url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/142/comments","statuses_url":"https://api.github.com/repos/flatpak/flatpak-builder/statuses/e861aaf888500d264a26ba5be82120d53226893b","head":{"label":"valentindavid:multiarch-libdir-2","ref":"multiarch-libdir-2","sha":"e861aaf888500d264a26ba5be82120d53226893b","user":{"login":"valentindavid","id":432830,"avatar_url":"https://avatars0.githubusercontent.com/u/432830?v=4","gravatar_id":"","url":"https://api.github.com/users/valentindavid","html_url":"https://github.com/valentindavid","followers_url":"https://api.github.com/users/valentindavid/followers","following_url":"https://api.github.com/users/valentindavid/following{/other_user}","gists_url":"https://api.github.com/users/valentindavid/gists{/gist_id}","starred_url":"https://api.github.com/users/valentindavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentindavid/subscriptions","organizations_url":"https://api.github.com/users/valentindavid/orgs","repos_url":"https://api.github.com/users/valentindavid/repos","events_url":"https://api.github.com/users/valentindavid/events{/privacy}","received_events_url":"https://api.github.com/users/valentindavid/received_events","type":"User","site_admin":false},"repo":{"id":129775089,"name":"flatpak-builder","full_name":"valentindavid/flatpak-builder","owner":{"login":"valentindavid","id":432830,"avatar_url":"https://avatars0.githubusercontent.com/u/432830?v=4","gravatar_id":"","url":"https://api.github.com/users/valentindavid","html_url":"https://github.com/valentindavid","followers_url":"https://api.github.com/users/valentindavid/followers","following_url":"https://api.github.com/users/valentindavid/following{/other_user}","gists_url":"https://api.github.com/users/valentindavid/gists{/gist_id}","starred_url":"https://api.github.com/users/valentindavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentindavid/subscriptions","organizations_url":"https://api.github.com/users/valentindavid/orgs","repos_url":"https://api.github.com/users/valentindavid/repos","events_url":"https://api.github.com/users/valentindavid/events{/privacy}","received_events_url":"https://api.github.com/users/valentindavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valentindavid/flatpak-builder","description":"Tool to build flatpaks from source","fork":true,"url":"https://api.github.com/repos/valentindavid/flatpak-builder","forks_url":"https://api.github.com/repos/valentindavid/flatpak-builder/forks","keys_url":"https://api.github.com/repos/valentindavid/flatpak-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valentindavid/flatpak-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valentindavid/flatpak-builder/teams","hooks_url":"https://api.github.com/repos/valentindavid/flatpak-builder/hooks","issue_events_url":"https://api.github.com/repos/valentindavid/flatpak-builder/issues/events{/number}","events_url":"https://api.github.com/repos/valentindavid/flatpak-builder/events","assignees_url":"https://api.github.com/repos/valentindavid/flatpak-builder/assignees{/user}","branches_url":"https://api.github.com/repos/valentindavid/flatpak-builder/branches{/branch}","tags_url":"https://api.github.com/repos/valentindavid/flatpak-builder/tags","blobs_url":"https://api.github.com/repos/valentindavid/flatpak-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valentindavid/flatpak-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valentindavid/flatpak-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/valentindavid/flatpak-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valentindavid/flatpak-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/valentindavid/flatpak-builder/languages","stargazers_url":"https://api.github.com/repos/valentindavid/flatpak-builder/stargazers","contributors_url":"https://api.github.com/repos/valentindavid/flatpak-builder/contributors","subscribers_url":"https://api.github.com/repos/valentindavid/flatpak-builder/subscribers","subscription_url":"https://api.github.com/repos/valentindavid/flatpak-builder/subscription","commits_url":"https://api.github.com/repos/valentindavid/flatpak-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/valentindavid/flatpak-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/valentindavid/flatpak-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/valentindavid/flatpak-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/valentindavid/flatpak-builder/contents/{+path}","compare_url":"https://api.github.com/repos/valentindavid/flatpak-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valentindavid/flatpak-builder/merges","archive_url":"https://api.github.com/repos/valentindavid/flatpak-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valentindavid/flatpak-builder/downloads","issues_url":"https://api.github.com/repos/valentindavid/flatpak-builder/issues{/number}","pulls_url":"https://api.github.com/repos/valentindavid/flatpak-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/valentindavid/flatpak-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/valentindavid/flatpak-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valentindavid/flatpak-builder/labels{/name}","releases_url":"https://api.github.com/repos/valentindavid/flatpak-builder/releases{/id}","deployments_url":"https://api.github.com/repos/valentindavid/flatpak-builder/deployments","created_at":"2018-04-16T16:39:20Z","updated_at":"2018-04-16T16:39:22Z","pushed_at":"2018-05-03T16:32:37Z","git_url":"git://github.com/valentindavid/flatpak-builder.git","ssh_url":"git@github.com:valentindavid/flatpak-builder.git","clone_url":"https://github.com/valentindavid/flatpak-builder.git","svn_url":"https://github.com/valentindavid/flatpak-builder","homepage":null,"size":7693,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flatpak:master","ref":"master","sha":"a6afcda4ca14d34fcaec15a21e35fc7c87abff72","user":{"login":"flatpak","id":19473042,"avatar_url":"https://avatars0.githubusercontent.com/u/19473042?v=4","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"repo":{"id":101387884,"name":"flatpak-builder","full_name":"flatpak/flatpak-builder","owner":{"login":"flatpak","id":19473042,"avatar_url":"https://avatars0.githubusercontent.com/u/19473042?v=4","gravatar_id":"","url":"https://api.github.com/users/flatpak","html_url":"https://github.com/flatpak","followers_url":"https://api.github.com/users/flatpak/followers","following_url":"https://api.github.com/users/flatpak/following{/other_user}","gists_url":"https://api.github.com/users/flatpak/gists{/gist_id}","starred_url":"https://api.github.com/users/flatpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flatpak/subscriptions","organizations_url":"https://api.github.com/users/flatpak/orgs","repos_url":"https://api.github.com/users/flatpak/repos","events_url":"https://api.github.com/users/flatpak/events{/privacy}","received_events_url":"https://api.github.com/users/flatpak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flatpak/flatpak-builder","description":"Tool to build flatpaks from source","fork":false,"url":"https://api.github.com/repos/flatpak/flatpak-builder","forks_url":"https://api.github.com/repos/flatpak/flatpak-builder/forks","keys_url":"https://api.github.com/repos/flatpak/flatpak-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flatpak/flatpak-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flatpak/flatpak-builder/teams","hooks_url":"https://api.github.com/repos/flatpak/flatpak-builder/hooks","issue_events_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/events{/number}","events_url":"https://api.github.com/repos/flatpak/flatpak-builder/events","assignees_url":"https://api.github.com/repos/flatpak/flatpak-builder/assignees{/user}","branches_url":"https://api.github.com/repos/flatpak/flatpak-builder/branches{/branch}","tags_url":"https://api.github.com/repos/flatpak/flatpak-builder/tags","blobs_url":"https://api.github.com/repos/flatpak/flatpak-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flatpak/flatpak-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flatpak/flatpak-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/flatpak/flatpak-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flatpak/flatpak-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/flatpak/flatpak-builder/languages","stargazers_url":"https://api.github.com/repos/flatpak/flatpak-builder/stargazers","contributors_url":"https://api.github.com/repos/flatpak/flatpak-builder/contributors","subscribers_url":"https://api.github.com/repos/flatpak/flatpak-builder/subscribers","subscription_url":"https://api.github.com/repos/flatpak/flatpak-builder/subscription","commits_url":"https://api.github.com/repos/flatpak/flatpak-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/flatpak/flatpak-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/flatpak/flatpak-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/flatpak/flatpak-builder/contents/{+path}","compare_url":"https://api.github.com/repos/flatpak/flatpak-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flatpak/flatpak-builder/merges","archive_url":"https://api.github.com/repos/flatpak/flatpak-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flatpak/flatpak-builder/downloads","issues_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues{/number}","pulls_url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/flatpak/flatpak-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/flatpak/flatpak-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flatpak/flatpak-builder/labels{/name}","releases_url":"https://api.github.com/repos/flatpak/flatpak-builder/releases{/id}","deployments_url":"https://api.github.com/repos/flatpak/flatpak-builder/deployments","created_at":"2017-08-25T09:18:35Z","updated_at":"2018-05-03T18:08:50Z","pushed_at":"2018-05-07T09:15:30Z","git_url":"git://github.com/flatpak/flatpak-builder.git","ssh_url":"git@github.com:flatpak/flatpak-builder.git","clone_url":"https://github.com/flatpak/flatpak-builder.git","svn_url":"https://github.com/flatpak/flatpak-builder","homepage":null,"size":7660,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":15,"open_issues":61,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142"},"html":{"href":"https://github.com/flatpak/flatpak-builder/pull/142"},"issue":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/issues/142"},"comments":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/flatpak/flatpak-builder/statuses/e861aaf888500d264a26ba5be82120d53226893b"}},"author_association":"NONE"}}
{"actor":{"display_login":"alexlarsson"}}