{"action":"created","issue":{"url":"https://api.github.com/repos/murarth/linefeed/issues/54","repository_url":"https://api.github.com/repos/murarth/linefeed","labels_url":"https://api.github.com/repos/murarth/linefeed/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/murarth/linefeed/issues/54/comments","events_url":"https://api.github.com/repos/murarth/linefeed/issues/54/events","html_url":"https://github.com/murarth/linefeed/issues/54","id":379636124,"node_id":"MDU6SXNzdWUzNzk2MzYxMjQ=","number":54,"title":"Unicode Issue on Path Completion","user":{"login":"mitnk","id":177049,"node_id":"MDQ6VXNlcjE3NzA0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/177049?v=4","gravatar_id":"","url":"https://api.github.com/users/mitnk","html_url":"https://github.com/mitnk","followers_url":"https://api.github.com/users/mitnk/followers","following_url":"https://api.github.com/users/mitnk/following{/other_user}","gists_url":"https://api.github.com/users/mitnk/gists{/gist_id}","starred_url":"https://api.github.com/users/mitnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitnk/subscriptions","organizations_url":"https://api.github.com/users/mitnk/orgs","repos_url":"https://api.github.com/users/mitnk/repos","events_url":"https://api.github.com/users/mitnk/events{/privacy}","received_events_url":"https://api.github.com/users/mitnk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-12T06:17:23Z","updated_at":"2018-11-12T17:11:53Z","closed_at":"2018-11-12T17:11:53Z","author_association":"NONE","body":"I encountered that linefeed panic when do path completion. I checked and found `longest_common_prefix()` does not consider unicode chars. `cargo test` would fail with following cases:\r\n\r\n```\r\n        # case 1 - fail\r\n        assert_eq!(longest_common_prefix([\"hi我的123\", \"hi我的134\"].iter()),\r\n            Some(\"hi我的1\"));\r\n        # case 2 - panic\r\n        assert_eq!(longest_common_prefix([\"hi我的世界123\", \"hi我的世界134\"].iter()),\r\n            Some(\"hi我的世界1\"));\r\n```"},"comment":{"url":"https://api.github.com/repos/murarth/linefeed/issues/comments/437959110","html_url":"https://github.com/murarth/linefeed/issues/54#issuecomment-437959110","issue_url":"https://api.github.com/repos/murarth/linefeed/issues/54","id":437959110,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzk1OTExMA==","user":{"login":"murarth","id":1332722,"node_id":"MDQ6VXNlcjEzMzI3MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1332722?v=4","gravatar_id":"","url":"https://api.github.com/users/murarth","html_url":"https://github.com/murarth","followers_url":"https://api.github.com/users/murarth/followers","following_url":"https://api.github.com/users/murarth/following{/other_user}","gists_url":"https://api.github.com/users/murarth/gists{/gist_id}","starred_url":"https://api.github.com/users/murarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murarth/subscriptions","organizations_url":"https://api.github.com/users/murarth/orgs","repos_url":"https://api.github.com/users/murarth/repos","events_url":"https://api.github.com/users/murarth/events{/privacy}","received_events_url":"https://api.github.com/users/murarth/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T17:11:53Z","updated_at":"2018-11-12T17:11:53Z","author_association":"OWNER","body":"Just pushed a commit to fix this. Thanks for the issue."}}
{"actor":{"display_login":"murarth"}}