{"action":"closed","number":100,"pull_request":{"url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/100","id":241472798,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDcyNzk4","html_url":"https://github.com/bailicangdu/vue2-happyfri/pull/100","diff_url":"https://github.com/bailicangdu/vue2-happyfri/pull/100.diff","patch_url":"https://github.com/bailicangdu/vue2-happyfri/pull/100.patch","issue_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues/100","number":100,"state":"closed","locked":false,"title":"fix vulnerabilities issues & image loading issue","user":{"login":"Shun2014","id":7112019,"node_id":"MDQ6VXNlcjcxMTIwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7112019?v=4","gravatar_id":"","url":"https://api.github.com/users/Shun2014","html_url":"https://github.com/Shun2014","followers_url":"https://api.github.com/users/Shun2014/followers","following_url":"https://api.github.com/users/Shun2014/following{/other_user}","gists_url":"https://api.github.com/users/Shun2014/gists{/gist_id}","starred_url":"https://api.github.com/users/Shun2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shun2014/subscriptions","organizations_url":"https://api.github.com/users/Shun2014/orgs","repos_url":"https://api.github.com/users/Shun2014/repos","events_url":"https://api.github.com/users/Shun2014/events{/privacy}","received_events_url":"https://api.github.com/users/Shun2014/received_events","type":"User","site_admin":false},"body":"1.  fix vulnerabilities issues\r\n```added 788 packages from 593 contributors and audited 5443 packages in 67.641s\r\nfound 7 vulnerabilities (5 moderate, 1 high, 1 critical)\r\n  run `npm audit fix` to fix them, or `npm audit` for details\r\n```\r\n\r\n2. fix image loading issue at runtime\r\n\r\n```\r\nnpm run dev\r\n\r\n> happyfri@1.0.2 dev E:\\workspace\\vue\\vue2VueRouterVuexExample\r\n> node build/dev-server.js\r\n\r\nListening at http://localhost:8088\r\n\r\nwebpack built 709705647cea3ec43a5d in 2295ms\r\nHash: 709705647cea3ec43a5d\r\nVersion: webpack 1.15.0\r\nTime: 2295ms\r\n     Asset     Size  Chunks       Chunk Names\r\n    app.js  1.68 MB       0       app\r\n 1.item.js   104 kB       1       item\r\n 2.home.js   104 kB       2       home\r\n3.score.js  65.6 kB       3       score\r\n\r\nERROR in ./src/images/4-4.png\r\nModule build failed: Error: emitFile is required from module system\r\n    at Object.module.exports (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\file-loader\\index.js:9:27)\r\n    at Object.loader (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\url-loader\\dist\\index.js:76:19)\r\n @ ./~/vue-loader/lib/template-compiler.js?id=data-v-f3db88c8!./~/vue-loader/lib/selector.js?type=template&index=0!./src/page/score/index.vue 42:13-44\r\n\r\nERROR in ./src/images/4-2.png\r\nModule build failed: Error: emitFile is required from module system\r\n    at Object.module.exports (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\file-loader\\index.js:9:27)\r\n    at Object.loader (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\url-loader\\dist\\index.js:76:19)\r\n @ ./~/css-loader!./~/vue-loader/lib/style-rewriter.js?id=data-v-f3db88c8!./~/less-loader!./~/vue-loader/lib/selector.js?type=styles&index=0!./src/page/score/index.vue 6:215-246\r\n\r\nERROR in ./src/images/1-2.png\r\nModule build failed: Error: emitFile is required from module system\r\n    at Object.module.exports (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\file-loader\\index.js:9:27)\r\n    at Object.loader (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\url-loader\\dist\\index.js:76:19)\r\n @ ./~/css-loader!./~/vue-loader/lib/style-rewriter.js?id=data-v-3a4bf6c8!./~/less-loader!./~/vue-loader/lib/selector.js?type=styles&index=0!./src/components/itemcontainer.vue 6:701-729\r\n\r\nERROR in ./src/images/1-1.jpg\r\nModule build failed: Error: emitFile is required from module system\r\n    at Object.module.exports (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\file-loader\\index.js:9:27)\r\n    at Object.loader (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\url-loader\\dist\\index.js:76:19)\r\n @ ./~/css-loader!./~/less-loader!./src/style/common.less 6:938-966\r\n\r\nERROR in ./src/images/4-1.jpg\r\nModule build failed: Error: emitFile is required from module system\r\n    at Object.module.exports (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\file-loader\\index.js:9:27)\r\n    at Object.loader (E:\\workspace\\vue\\vue2VueRouterVuexExample\\node_modules\\url-loader\\dist\\index.js:76:19)\r\n @ ./~/css-loader!./~/vue-loader/lib/style-rewriter.js?id=data-v-f3db88c8!./~/less-loader!./~/vue-loader/lib/selector.js?type=styles&index=0!./src/page/score/index.vue 6:64-95\r\nChild html-webpack-plugin for \"index.html\":\r\n         Asset     Size  Chunks       Chunk Names\r\n    index.html  1.47 MB       0\r\nwebpack: Failed to compile.\r\n```\r\n\r\n\r\n\r\n","created_at":"2018-12-30T02:23:58Z","updated_at":"2018-12-30T06:48:38Z","closed_at":"2018-12-30T06:48:38Z","merged_at":"2018-12-30T06:48:38Z","merge_commit_sha":"3e9ba454efb9bc1a27830dda6364c6b83e9413f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/100/commits","review_comments_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/100/comments","review_comment_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues/100/comments","statuses_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/statuses/14cd4d9867a9ab7047797366cda4a3c21dddf3db","head":{"label":"Shun2014:master","ref":"master","sha":"14cd4d9867a9ab7047797366cda4a3c21dddf3db","user":{"login":"Shun2014","id":7112019,"node_id":"MDQ6VXNlcjcxMTIwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7112019?v=4","gravatar_id":"","url":"https://api.github.com/users/Shun2014","html_url":"https://github.com/Shun2014","followers_url":"https://api.github.com/users/Shun2014/followers","following_url":"https://api.github.com/users/Shun2014/following{/other_user}","gists_url":"https://api.github.com/users/Shun2014/gists{/gist_id}","starred_url":"https://api.github.com/users/Shun2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shun2014/subscriptions","organizations_url":"https://api.github.com/users/Shun2014/orgs","repos_url":"https://api.github.com/users/Shun2014/repos","events_url":"https://api.github.com/users/Shun2014/events{/privacy}","received_events_url":"https://api.github.com/users/Shun2014/received_events","type":"User","site_admin":false},"repo":{"id":163552084,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM1NTIwODQ=","name":"vue2-happyfri","full_name":"Shun2014/vue2-happyfri","private":false,"owner":{"login":"Shun2014","id":7112019,"node_id":"MDQ6VXNlcjcxMTIwMTk=","avatar_url":"https://avatars0.githubusercontent.com/u/7112019?v=4","gravatar_id":"","url":"https://api.github.com/users/Shun2014","html_url":"https://github.com/Shun2014","followers_url":"https://api.github.com/users/Shun2014/followers","following_url":"https://api.github.com/users/Shun2014/following{/other_user}","gists_url":"https://api.github.com/users/Shun2014/gists{/gist_id}","starred_url":"https://api.github.com/users/Shun2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shun2014/subscriptions","organizations_url":"https://api.github.com/users/Shun2014/orgs","repos_url":"https://api.github.com/users/Shun2014/repos","events_url":"https://api.github.com/users/Shun2014/events{/privacy}","received_events_url":"https://api.github.com/users/Shun2014/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shun2014/vue2-happyfri","description":"vue2 + vue-router + vuex  入门项目","fork":true,"url":"https://api.github.com/repos/Shun2014/vue2-happyfri","forks_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/forks","keys_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/teams","hooks_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/hooks","issue_events_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/issues/events{/number}","events_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/events","assignees_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/assignees{/user}","branches_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/branches{/branch}","tags_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/tags","blobs_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/statuses/{sha}","languages_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/languages","stargazers_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/stargazers","contributors_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/contributors","subscribers_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/subscribers","subscription_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/subscription","commits_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/contents/{+path}","compare_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/merges","archive_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/downloads","issues_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/issues{/number}","pulls_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/pulls{/number}","milestones_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/milestones{/number}","notifications_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/labels{/name}","releases_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/releases{/id}","deployments_url":"https://api.github.com/repos/Shun2014/vue2-happyfri/deployments","created_at":"2018-12-30T01:03:28Z","updated_at":"2018-12-30T03:13:07Z","pushed_at":"2018-12-30T03:13:05Z","git_url":"git://github.com/Shun2014/vue2-happyfri.git","ssh_url":"git@github.com:Shun2014/vue2-happyfri.git","clone_url":"https://github.com/Shun2014/vue2-happyfri.git","svn_url":"https://github.com/Shun2014/vue2-happyfri","homepage":"","size":5061,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bailicangdu:master","ref":"master","sha":"f338fc5fd16d02a5740a4a26abac2184d86befda","user":{"login":"bailicangdu","id":20297227,"node_id":"MDQ6VXNlcjIwMjk3MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/20297227?v=4","gravatar_id":"","url":"https://api.github.com/users/bailicangdu","html_url":"https://github.com/bailicangdu","followers_url":"https://api.github.com/users/bailicangdu/followers","following_url":"https://api.github.com/users/bailicangdu/following{/other_user}","gists_url":"https://api.github.com/users/bailicangdu/gists{/gist_id}","starred_url":"https://api.github.com/users/bailicangdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bailicangdu/subscriptions","organizations_url":"https://api.github.com/users/bailicangdu/orgs","repos_url":"https://api.github.com/users/bailicangdu/repos","events_url":"https://api.github.com/users/bailicangdu/events{/privacy}","received_events_url":"https://api.github.com/users/bailicangdu/received_events","type":"User","site_admin":false},"repo":{"id":75890962,"node_id":"MDEwOlJlcG9zaXRvcnk3NTg5MDk2Mg==","name":"vue2-happyfri","full_name":"bailicangdu/vue2-happyfri","private":false,"owner":{"login":"bailicangdu","id":20297227,"node_id":"MDQ6VXNlcjIwMjk3MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/20297227?v=4","gravatar_id":"","url":"https://api.github.com/users/bailicangdu","html_url":"https://github.com/bailicangdu","followers_url":"https://api.github.com/users/bailicangdu/followers","following_url":"https://api.github.com/users/bailicangdu/following{/other_user}","gists_url":"https://api.github.com/users/bailicangdu/gists{/gist_id}","starred_url":"https://api.github.com/users/bailicangdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bailicangdu/subscriptions","organizations_url":"https://api.github.com/users/bailicangdu/orgs","repos_url":"https://api.github.com/users/bailicangdu/repos","events_url":"https://api.github.com/users/bailicangdu/events{/privacy}","received_events_url":"https://api.github.com/users/bailicangdu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bailicangdu/vue2-happyfri","description":"vue2 + vue-router + vuex  入门项目","fork":false,"url":"https://api.github.com/repos/bailicangdu/vue2-happyfri","forks_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/forks","keys_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/teams","hooks_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/hooks","issue_events_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues/events{/number}","events_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/events","assignees_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/assignees{/user}","branches_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/branches{/branch}","tags_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/tags","blobs_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/git/refs{/sha}","trees_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/statuses/{sha}","languages_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/languages","stargazers_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/stargazers","contributors_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/contributors","subscribers_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/subscribers","subscription_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/subscription","commits_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/commits{/sha}","git_commits_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/git/commits{/sha}","comments_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/comments{/number}","issue_comment_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues/comments{/number}","contents_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/contents/{+path}","compare_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/merges","archive_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/downloads","issues_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues{/number}","pulls_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls{/number}","milestones_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/milestones{/number}","notifications_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/labels{/name}","releases_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/releases{/id}","deployments_url":"https://api.github.com/repos/bailicangdu/vue2-happyfri/deployments","created_at":"2016-12-08T01:28:47Z","updated_at":"2018-12-29T11:33:21Z","pushed_at":"2018-12-30T06:48:38Z","git_url":"git://github.com/bailicangdu/vue2-happyfri.git","ssh_url":"git@github.com:bailicangdu/vue2-happyfri.git","clone_url":"https://github.com/bailicangdu/vue2-happyfri.git","svn_url":"https://github.com/bailicangdu/vue2-happyfri","homepage":"","size":5063,"stargazers_count":6221,"watchers_count":6221,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2028,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2028,"open_issues":4,"watchers":6221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/100"},"html":{"href":"https://github.com/bailicangdu/vue2-happyfri/pull/100"},"issue":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues/100"},"comments":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/bailicangdu/vue2-happyfri/statuses/14cd4d9867a9ab7047797366cda4a3c21dddf3db"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bailicangdu","id":20297227,"node_id":"MDQ6VXNlcjIwMjk3MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/20297227?v=4","gravatar_id":"","url":"https://api.github.com/users/bailicangdu","html_url":"https://github.com/bailicangdu","followers_url":"https://api.github.com/users/bailicangdu/followers","following_url":"https://api.github.com/users/bailicangdu/following{/other_user}","gists_url":"https://api.github.com/users/bailicangdu/gists{/gist_id}","starred_url":"https://api.github.com/users/bailicangdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bailicangdu/subscriptions","organizations_url":"https://api.github.com/users/bailicangdu/orgs","repos_url":"https://api.github.com/users/bailicangdu/repos","events_url":"https://api.github.com/users/bailicangdu/events{/privacy}","received_events_url":"https://api.github.com/users/bailicangdu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":8,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"bailicangdu"}}