{"action":"created","comment":{"url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/comments/176429509","pull_request_review_id":106126696,"id":176429509,"diff_hunk":"@@ -38,6 +40,23 @@ class Server {\n       this.httpsApp = express();\n     }\n     this.app = Config.httpsEnabled ? this.httpsApp : this.httpApp;\n+    if (Config.pingEnabled) {\n+        this.app.use(health.ping('/' + Config.pingEndpoint));\n+    }\n+    if (Config.logRequests) {","path":"src/server.ts","position":18,"original_position":18,"commit_id":"baac5ff0886497c907e869ad53e53c1891974783","original_commit_id":"baac5ff0886497c907e869ad53e53c1891974783","user":{"login":"jaapvanblaaderen","id":25052965,"avatar_url":"https://avatars1.githubusercontent.com/u/25052965?v=4","gravatar_id":"","url":"https://api.github.com/users/jaapvanblaaderen","html_url":"https://github.com/jaapvanblaaderen","followers_url":"https://api.github.com/users/jaapvanblaaderen/followers","following_url":"https://api.github.com/users/jaapvanblaaderen/following{/other_user}","gists_url":"https://api.github.com/users/jaapvanblaaderen/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapvanblaaderen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapvanblaaderen/subscriptions","organizations_url":"https://api.github.com/users/jaapvanblaaderen/orgs","repos_url":"https://api.github.com/users/jaapvanblaaderen/repos","events_url":"https://api.github.com/users/jaapvanblaaderen/events{/privacy}","received_events_url":"https://api.github.com/users/jaapvanblaaderen/received_events","type":"User","site_admin":false},"body":"I would opt to enable the \"daily\" property in order to get a logfile per day.","created_at":"2018-03-22T14:00:49Z","updated_at":"2018-03-22T14:08:29Z","html_url":"https://github.com/WoodWing/elvis-image-recognition/pull/4#discussion_r176429509","pull_request_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/comments/176429509"},"html":{"href":"https://github.com/WoodWing/elvis-image-recognition/pull/4#discussion_r176429509"},"pull_request":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4","id":176478866,"html_url":"https://github.com/WoodWing/elvis-image-recognition/pull/4","diff_url":"https://github.com/WoodWing/elvis-image-recognition/pull/4.diff","patch_url":"https://github.com/WoodWing/elvis-image-recognition/pull/4.patch","issue_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues/4","number":4,"state":"open","locked":false,"title":"Add option to log requests","user":{"login":"siebrand","id":210297,"avatar_url":"https://avatars0.githubusercontent.com/u/210297?v=4","gravatar_id":"","url":"https://api.github.com/users/siebrand","html_url":"https://github.com/siebrand","followers_url":"https://api.github.com/users/siebrand/followers","following_url":"https://api.github.com/users/siebrand/following{/other_user}","gists_url":"https://api.github.com/users/siebrand/gists{/gist_id}","starred_url":"https://api.github.com/users/siebrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siebrand/subscriptions","organizations_url":"https://api.github.com/users/siebrand/orgs","repos_url":"https://api.github.com/users/siebrand/repos","events_url":"https://api.github.com/users/siebrand/events{/privacy}","received_events_url":"https://api.github.com/users/siebrand/received_events","type":"User","site_admin":false},"body":"Logging is disabled by default. When logging is enabled, log files will be\r\nrotated daily.\r\n\r\nSettings added:\r\n* logRequests: boolean: Whether requests should be logged. Default: false.\r\n* logFile: string: File to log requests to. Default: requests.log.\r\n* logMaxFiles: integrer: Number of log files to keep. Default: 31.\r\n\r\nLibrary used: https://www.npmjs.com/package/logger-request","created_at":"2018-03-21T13:40:36Z","updated_at":"2018-03-22T14:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314dbb6bd44e48530b3a874a4336588d6312ed99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4/commits","review_comments_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4/comments","review_comment_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues/4/comments","statuses_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/statuses/baac5ff0886497c907e869ad53e53c1891974783","head":{"label":"siebrand:logging","ref":"logging","sha":"baac5ff0886497c907e869ad53e53c1891974783","user":{"login":"siebrand","id":210297,"avatar_url":"https://avatars0.githubusercontent.com/u/210297?v=4","gravatar_id":"","url":"https://api.github.com/users/siebrand","html_url":"https://github.com/siebrand","followers_url":"https://api.github.com/users/siebrand/followers","following_url":"https://api.github.com/users/siebrand/following{/other_user}","gists_url":"https://api.github.com/users/siebrand/gists{/gist_id}","starred_url":"https://api.github.com/users/siebrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siebrand/subscriptions","organizations_url":"https://api.github.com/users/siebrand/orgs","repos_url":"https://api.github.com/users/siebrand/repos","events_url":"https://api.github.com/users/siebrand/events{/privacy}","received_events_url":"https://api.github.com/users/siebrand/received_events","type":"User","site_admin":false},"repo":{"id":126168119,"name":"elvis-image-recognition","full_name":"siebrand/elvis-image-recognition","owner":{"login":"siebrand","id":210297,"avatar_url":"https://avatars0.githubusercontent.com/u/210297?v=4","gravatar_id":"","url":"https://api.github.com/users/siebrand","html_url":"https://github.com/siebrand","followers_url":"https://api.github.com/users/siebrand/followers","following_url":"https://api.github.com/users/siebrand/following{/other_user}","gists_url":"https://api.github.com/users/siebrand/gists{/gist_id}","starred_url":"https://api.github.com/users/siebrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siebrand/subscriptions","organizations_url":"https://api.github.com/users/siebrand/orgs","repos_url":"https://api.github.com/users/siebrand/repos","events_url":"https://api.github.com/users/siebrand/events{/privacy}","received_events_url":"https://api.github.com/users/siebrand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siebrand/elvis-image-recognition","description":"Elvis integration with AI based image recognition services from AWS, Google and Clarifai","fork":true,"url":"https://api.github.com/repos/siebrand/elvis-image-recognition","forks_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/forks","keys_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/teams","hooks_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/hooks","issue_events_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/issues/events{/number}","events_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/events","assignees_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/assignees{/user}","branches_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/branches{/branch}","tags_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/tags","blobs_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/git/refs{/sha}","trees_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/statuses/{sha}","languages_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/languages","stargazers_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/stargazers","contributors_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/contributors","subscribers_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/subscribers","subscription_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/subscription","commits_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/commits{/sha}","git_commits_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/git/commits{/sha}","comments_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/comments{/number}","issue_comment_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/issues/comments{/number}","contents_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/contents/{+path}","compare_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/merges","archive_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/downloads","issues_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/issues{/number}","pulls_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/pulls{/number}","milestones_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/milestones{/number}","notifications_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/labels{/name}","releases_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/releases{/id}","deployments_url":"https://api.github.com/repos/siebrand/elvis-image-recognition/deployments","created_at":"2018-03-21T11:23:55Z","updated_at":"2018-03-21T13:38:41Z","pushed_at":"2018-03-22T11:13:17Z","git_url":"git://github.com/siebrand/elvis-image-recognition.git","ssh_url":"git@github.com:siebrand/elvis-image-recognition.git","clone_url":"https://github.com/siebrand/elvis-image-recognition.git","svn_url":"https://github.com/siebrand/elvis-image-recognition","homepage":null,"size":2546,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"WoodWing:master","ref":"master","sha":"e6c5e45879d11026002459d95b43de45aa4666a8","user":{"login":"WoodWing","id":11189625,"avatar_url":"https://avatars3.githubusercontent.com/u/11189625?v=4","gravatar_id":"","url":"https://api.github.com/users/WoodWing","html_url":"https://github.com/WoodWing","followers_url":"https://api.github.com/users/WoodWing/followers","following_url":"https://api.github.com/users/WoodWing/following{/other_user}","gists_url":"https://api.github.com/users/WoodWing/gists{/gist_id}","starred_url":"https://api.github.com/users/WoodWing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WoodWing/subscriptions","organizations_url":"https://api.github.com/users/WoodWing/orgs","repos_url":"https://api.github.com/users/WoodWing/repos","events_url":"https://api.github.com/users/WoodWing/events{/privacy}","received_events_url":"https://api.github.com/users/WoodWing/received_events","type":"Organization","site_admin":false},"repo":{"id":87904456,"name":"elvis-image-recognition","full_name":"WoodWing/elvis-image-recognition","owner":{"login":"WoodWing","id":11189625,"avatar_url":"https://avatars3.githubusercontent.com/u/11189625?v=4","gravatar_id":"","url":"https://api.github.com/users/WoodWing","html_url":"https://github.com/WoodWing","followers_url":"https://api.github.com/users/WoodWing/followers","following_url":"https://api.github.com/users/WoodWing/following{/other_user}","gists_url":"https://api.github.com/users/WoodWing/gists{/gist_id}","starred_url":"https://api.github.com/users/WoodWing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WoodWing/subscriptions","organizations_url":"https://api.github.com/users/WoodWing/orgs","repos_url":"https://api.github.com/users/WoodWing/repos","events_url":"https://api.github.com/users/WoodWing/events{/privacy}","received_events_url":"https://api.github.com/users/WoodWing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WoodWing/elvis-image-recognition","description":"Elvis integration with AI based image recognition services from AWS, Google and Clarifai","fork":false,"url":"https://api.github.com/repos/WoodWing/elvis-image-recognition","forks_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/forks","keys_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/teams","hooks_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/hooks","issue_events_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues/events{/number}","events_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/events","assignees_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/assignees{/user}","branches_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/branches{/branch}","tags_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/tags","blobs_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/git/refs{/sha}","trees_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/statuses/{sha}","languages_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/languages","stargazers_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/stargazers","contributors_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/contributors","subscribers_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/subscribers","subscription_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/subscription","commits_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/commits{/sha}","git_commits_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/git/commits{/sha}","comments_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/comments{/number}","issue_comment_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues/comments{/number}","contents_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/contents/{+path}","compare_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/merges","archive_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/downloads","issues_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues{/number}","pulls_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls{/number}","milestones_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/milestones{/number}","notifications_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/labels{/name}","releases_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/releases{/id}","deployments_url":"https://api.github.com/repos/WoodWing/elvis-image-recognition/deployments","created_at":"2017-04-11T07:38:07Z","updated_at":"2018-03-16T11:51:03Z","pushed_at":"2018-03-22T11:13:18Z","git_url":"git://github.com/WoodWing/elvis-image-recognition.git","ssh_url":"git@github.com:WoodWing/elvis-image-recognition.git","clone_url":"https://github.com/WoodWing/elvis-image-recognition.git","svn_url":"https://github.com/WoodWing/elvis-image-recognition","homepage":null,"size":2548,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4"},"html":{"href":"https://github.com/WoodWing/elvis-image-recognition/pull/4"},"issue":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues/4"},"comments":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/WoodWing/elvis-image-recognition/statuses/baac5ff0886497c907e869ad53e53c1891974783"}},"author_association":"NONE"}}
{"actor":{"display_login":"jaapvanblaaderen"}}