{"action":"created","issue":{"url":"https://api.github.com/repos/libarchive/libarchive/issues/1023","repository_url":"https://api.github.com/repos/libarchive/libarchive","labels_url":"https://api.github.com/repos/libarchive/libarchive/issues/1023/labels{/name}","comments_url":"https://api.github.com/repos/libarchive/libarchive/issues/1023/comments","events_url":"https://api.github.com/repos/libarchive/libarchive/issues/1023/events","html_url":"https://github.com/libarchive/libarchive/pull/1023","id":328357507,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTE4NDE5","number":1023,"title":"Always create files owner-writable.","user":{"login":"eborisch","id":5131911,"node_id":"MDQ6VXNlcjUxMzE5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/5131911?v=4","gravatar_id":"","url":"https://api.github.com/users/eborisch","html_url":"https://github.com/eborisch","followers_url":"https://api.github.com/users/eborisch/followers","following_url":"https://api.github.com/users/eborisch/following{/other_user}","gists_url":"https://api.github.com/users/eborisch/gists{/gist_id}","starred_url":"https://api.github.com/users/eborisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eborisch/subscriptions","organizations_url":"https://api.github.com/users/eborisch/orgs","repos_url":"https://api.github.com/users/eborisch/repos","events_url":"https://api.github.com/users/eborisch/events{/privacy}","received_events_url":"https://api.github.com/users/eborisch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-01T02:20:45Z","updated_at":"2018-07-28T23:56:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/libarchive/libarchive/pulls/1023","html_url":"https://github.com/libarchive/libarchive/pull/1023","diff_url":"https://github.com/libarchive/libarchive/pull/1023.diff","patch_url":"https://github.com/libarchive/libarchive/pull/1023.patch"},"body":"Keeps TODO_MODE around if final_mode isn't owner writable, but lets\r\nfsetxattr() succeed for non-root users. (Required for HFS+ compression.)\r\n\r\nThis is an attempt at fixing #497 but certainly needs attention from the maintainers. I'm making use of the fact that if mode != final_mode at the end of create_filesystem_object(), then TODO_MODE is left set and cleaned up later. If the final mode includes 0200, this should make no additional system calls. Tries to only have the new behavior when needed (I know it's needed for non-root HFS extraction of read-only files, I'm guessing from the issue report it may be needed elsewhere for [f]setxattr() calls.\r\n\r\nOn my (OSX 10.13.4) platform, `make check` return the same set of failures with and without these changes. (Clearly extracting read-only HFS-compressed files isn't tested.) On my reproducer of HFS extraction failures (non-root, read-only files) this fixes the issue."},"comment":{"url":"https://api.github.com/repos/libarchive/libarchive/issues/comments/408642343","html_url":"https://github.com/libarchive/libarchive/pull/1023#issuecomment-408642343","issue_url":"https://api.github.com/repos/libarchive/libarchive/issues/1023","id":408642343,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY0MjM0Mw==","user":{"login":"mmatuska","id":924604,"node_id":"MDQ6VXNlcjkyNDYwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/924604?v=4","gravatar_id":"","url":"https://api.github.com/users/mmatuska","html_url":"https://github.com/mmatuska","followers_url":"https://api.github.com/users/mmatuska/followers","following_url":"https://api.github.com/users/mmatuska/following{/other_user}","gists_url":"https://api.github.com/users/mmatuska/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatuska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatuska/subscriptions","organizations_url":"https://api.github.com/users/mmatuska/orgs","repos_url":"https://api.github.com/users/mmatuska/repos","events_url":"https://api.github.com/users/mmatuska/events{/privacy}","received_events_url":"https://api.github.com/users/mmatuska/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T23:56:27Z","updated_at":"2018-07-28T23:56:27Z","author_association":"MEMBER","body":"@kientzle what do you think, are we going to commit this?"}}
{"actor":{"display_login":"mmatuska"}}