{"action":"created","comment":{"url":"https://api.github.com/repos/binaris/binaris/pulls/comments/229737836","pull_request_review_id":170306050,"id":229737836,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTczNzgzNg==","diff_hunk":"@@ -0,0 +1,130 @@\n+- test: Test js input\n+  steps:\n+    -   in: bn create node8 returnInput\n+    -   in: |-\n+            echo 'exports.handler = (input) => ({ inputType: typeof input, input});' >function.js\n+    -   in: bn deploy returnInput\n+    -   in: curl -s \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnInput\"\n+        out: '{\"inputType\":\"object\",\"input\":{}}'\n+    -   in: curl -s --data '{\"' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnInput\"\n+        out: '{\"inputType\":\"undefined\"}'\n+    -   in: curl -s --data '{}' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnInput\"\n+        out: '{\"inputType\":\"object\",\"input\":{}}'\n+    -   in: curl -s --data '{\"foo\":\"bar\",\"yet\":123}' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnInput\"\n+        out: '{\"inputType\":\"object\",\"input\":{\"foo\":\"bar\",\"yet\":123}}'\n+    -   in: curl -s --data '[\"foo\",\"bar\"]' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnInput\"\n+        out: '{\"inputType\":\"object\",\"input\":[\"foo\",\"bar\"]}'\n+    -   in: bn remove returnInput\n+- test: Test js method \n+  steps:\n+    -   in: bn create node8 returnMethod\n+    -   in: |-\n+            echo 'exports.handler = (_, req) => req.method;' >function.js\n+    -   in: bn deploy returnMethod\n+    -   in: curl -s -X GET \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+        out: '\"GET\"'\n+#    -   in: curl -s -X HEAD \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+#        out: '\"HEAD\"'\n+    -   in: curl -s -X POST \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+        out: '\"POST\"'\n+    -   in: curl -s -X PUT \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+        out: '\"PUT\"'\n+    -   in: curl -s -X DELETE \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+        out: '\"DELETE\"'\n+#    -   in: curl -s -X CONNECT \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+#        out: '\"CONNECT\"'\n+    -   in: curl -s -X OPTIONS \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+        out: '\"OPTIONS\"'\n+#    -   in: curl -s -X TRACE \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+#        out: '\"TRACE\"'\n+    -   in: curl -s -X PATCH \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnMethod\"\n+        out: '\"PATCH\"'\n+    -   in: bn remove returnMethod\n+- test: Test js data input\n+  steps:\n+    -   in: bn create node8 returnReqBody\n+    -   in: |-\n+            echo 'exports.handler = (_, req) => req.body;' >function.js\n+    -   in: bn deploy returnReqBody\n+    -   in: curl -s \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[]}'\n+    -   in: curl -s --data '{' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[123]}'\n+    -   in: curl -s --data '{}' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[123,125]}'\n+    -   in: curl -s --data ' ' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[32]}'\n+    -   in: curl -s --data-urlencode ' ' \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[37,50,48]}'\n+    -   in: echo | curl -s --data-binary @- \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[10]}'\n+    -   in: echo | gzip -n | curl -s --data-binary @- \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqBody\"\n+        out: '{\"type\":\"Buffer\",\"data\":[31,139,8,0,0,0,0,0,0,3,227,2,0,147,6,215,50,1,0,0,0]}'\n+    -   in: bn remove returnReqBody\n+- test: Test js headers input\n+  steps:\n+    -   in: bn create node8 returnReqTestHeader\n+    -   in: |-\n+            echo 'exports.handler = (_, req) => req.headers.test;' >function.js\n+    -   in: bn deploy returnReqTestHeader\n+    -   in: curl -s \"https://${BINARIS_INVOKE_ENDPOINT}/v1/run/${BINARIS_API_KEY}/returnReqTestHeader\"\n+        out: ''\n+    -   in: |-","path":"test/jsApi.yml","position":66,"original_position":72,"commit_id":"04bf4e9788191445123a10780fabc0485230fc48","original_commit_id":"81bc46bfe38bbcccd64497087430fb3e5c57d8e8","user":{"login":"rylandg","id":27736122,"node_id":"MDQ6VXNlcjI3NzM2MTIy","avatar_url":"https://avatars0.githubusercontent.com/u/27736122?v=4","gravatar_id":"","url":"https://api.github.com/users/rylandg","html_url":"https://github.com/rylandg","followers_url":"https://api.github.com/users/rylandg/followers","following_url":"https://api.github.com/users/rylandg/following{/other_user}","gists_url":"https://api.github.com/users/rylandg/gists{/gist_id}","starred_url":"https://api.github.com/users/rylandg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylandg/subscriptions","organizations_url":"https://api.github.com/users/rylandg/orgs","repos_url":"https://api.github.com/users/rylandg/repos","events_url":"https://api.github.com/users/rylandg/events{/privacy}","received_events_url":"https://api.github.com/users/rylandg/received_events","type":"User","site_admin":false},"body":"Mostly just a preference question. Why use `|-` operator instead of single quoting the curl statements? ","created_at":"2018-10-31T15:13:18Z","updated_at":"2018-10-31T15:13:35Z","html_url":"https://github.com/binaris/binaris/pull/362#discussion_r229737836","pull_request_url":"https://api.github.com/repos/binaris/binaris/pulls/362","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/binaris/binaris/pulls/comments/229737836"},"html":{"href":"https://github.com/binaris/binaris/pull/362#discussion_r229737836"},"pull_request":{"href":"https://api.github.com/repos/binaris/binaris/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/binaris/binaris/pulls/362","id":227228330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjI4MzMw","html_url":"https://github.com/binaris/binaris/pull/362","diff_url":"https://github.com/binaris/binaris/pull/362.diff","patch_url":"https://github.com/binaris/binaris/pull/362.patch","issue_url":"https://api.github.com/repos/binaris/binaris/issues/362","number":362,"state":"open","locked":false,"title":"add js api behaviour tests","user":{"login":"michaeladda","id":23503072,"node_id":"MDQ6VXNlcjIzNTAzMDcy","avatar_url":"https://avatars1.githubusercontent.com/u/23503072?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeladda","html_url":"https://github.com/michaeladda","followers_url":"https://api.github.com/users/michaeladda/followers","following_url":"https://api.github.com/users/michaeladda/following{/other_user}","gists_url":"https://api.github.com/users/michaeladda/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeladda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeladda/subscriptions","organizations_url":"https://api.github.com/users/michaeladda/orgs","repos_url":"https://api.github.com/users/michaeladda/repos","events_url":"https://api.github.com/users/michaeladda/events{/privacy}","received_events_url":"https://api.github.com/users/michaeladda/received_events","type":"User","site_admin":false},"body":"dependent on binaris/bolt#96","created_at":"2018-10-31T10:17:43Z","updated_at":"2018-10-31T15:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb93a87b77b4804dfba62903b3885575828886d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binaris/binaris/pulls/362/commits","review_comments_url":"https://api.github.com/repos/binaris/binaris/pulls/362/comments","review_comment_url":"https://api.github.com/repos/binaris/binaris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binaris/binaris/issues/362/comments","statuses_url":"https://api.github.com/repos/binaris/binaris/statuses/04bf4e9788191445123a10780fabc0485230fc48","head":{"label":"binaris:feature-separate-app-bolt","ref":"feature-separate-app-bolt","sha":"04bf4e9788191445123a10780fabc0485230fc48","user":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"repo":{"id":103460196,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NjAxOTY=","name":"binaris","full_name":"binaris/binaris","private":false,"owner":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binaris/binaris","description":"Binaris Function as a Service CLI","fork":false,"url":"https://api.github.com/repos/binaris/binaris","forks_url":"https://api.github.com/repos/binaris/binaris/forks","keys_url":"https://api.github.com/repos/binaris/binaris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binaris/binaris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binaris/binaris/teams","hooks_url":"https://api.github.com/repos/binaris/binaris/hooks","issue_events_url":"https://api.github.com/repos/binaris/binaris/issues/events{/number}","events_url":"https://api.github.com/repos/binaris/binaris/events","assignees_url":"https://api.github.com/repos/binaris/binaris/assignees{/user}","branches_url":"https://api.github.com/repos/binaris/binaris/branches{/branch}","tags_url":"https://api.github.com/repos/binaris/binaris/tags","blobs_url":"https://api.github.com/repos/binaris/binaris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binaris/binaris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binaris/binaris/git/refs{/sha}","trees_url":"https://api.github.com/repos/binaris/binaris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binaris/binaris/statuses/{sha}","languages_url":"https://api.github.com/repos/binaris/binaris/languages","stargazers_url":"https://api.github.com/repos/binaris/binaris/stargazers","contributors_url":"https://api.github.com/repos/binaris/binaris/contributors","subscribers_url":"https://api.github.com/repos/binaris/binaris/subscribers","subscription_url":"https://api.github.com/repos/binaris/binaris/subscription","commits_url":"https://api.github.com/repos/binaris/binaris/commits{/sha}","git_commits_url":"https://api.github.com/repos/binaris/binaris/git/commits{/sha}","comments_url":"https://api.github.com/repos/binaris/binaris/comments{/number}","issue_comment_url":"https://api.github.com/repos/binaris/binaris/issues/comments{/number}","contents_url":"https://api.github.com/repos/binaris/binaris/contents/{+path}","compare_url":"https://api.github.com/repos/binaris/binaris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binaris/binaris/merges","archive_url":"https://api.github.com/repos/binaris/binaris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binaris/binaris/downloads","issues_url":"https://api.github.com/repos/binaris/binaris/issues{/number}","pulls_url":"https://api.github.com/repos/binaris/binaris/pulls{/number}","milestones_url":"https://api.github.com/repos/binaris/binaris/milestones{/number}","notifications_url":"https://api.github.com/repos/binaris/binaris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binaris/binaris/labels{/name}","releases_url":"https://api.github.com/repos/binaris/binaris/releases{/id}","deployments_url":"https://api.github.com/repos/binaris/binaris/deployments","created_at":"2017-09-13T22:57:26Z","updated_at":"2018-10-29T21:07:52Z","pushed_at":"2018-10-31T15:12:46Z","git_url":"git://github.com/binaris/binaris.git","ssh_url":"git@github.com:binaris/binaris.git","clone_url":"https://github.com/binaris/binaris.git","svn_url":"https://github.com/binaris/binaris","homepage":"https://dev.binaris.com/","size":420,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":29,"watchers":8,"default_branch":"master"}},"base":{"label":"binaris:master","ref":"master","sha":"41a810fd433774f717b88ee0e2a00cf2a0c517a2","user":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"repo":{"id":103460196,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NjAxOTY=","name":"binaris","full_name":"binaris/binaris","private":false,"owner":{"login":"binaris","id":27725492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/27725492?v=4","gravatar_id":"","url":"https://api.github.com/users/binaris","html_url":"https://github.com/binaris","followers_url":"https://api.github.com/users/binaris/followers","following_url":"https://api.github.com/users/binaris/following{/other_user}","gists_url":"https://api.github.com/users/binaris/gists{/gist_id}","starred_url":"https://api.github.com/users/binaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaris/subscriptions","organizations_url":"https://api.github.com/users/binaris/orgs","repos_url":"https://api.github.com/users/binaris/repos","events_url":"https://api.github.com/users/binaris/events{/privacy}","received_events_url":"https://api.github.com/users/binaris/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binaris/binaris","description":"Binaris Function as a Service CLI","fork":false,"url":"https://api.github.com/repos/binaris/binaris","forks_url":"https://api.github.com/repos/binaris/binaris/forks","keys_url":"https://api.github.com/repos/binaris/binaris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binaris/binaris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binaris/binaris/teams","hooks_url":"https://api.github.com/repos/binaris/binaris/hooks","issue_events_url":"https://api.github.com/repos/binaris/binaris/issues/events{/number}","events_url":"https://api.github.com/repos/binaris/binaris/events","assignees_url":"https://api.github.com/repos/binaris/binaris/assignees{/user}","branches_url":"https://api.github.com/repos/binaris/binaris/branches{/branch}","tags_url":"https://api.github.com/repos/binaris/binaris/tags","blobs_url":"https://api.github.com/repos/binaris/binaris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binaris/binaris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binaris/binaris/git/refs{/sha}","trees_url":"https://api.github.com/repos/binaris/binaris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binaris/binaris/statuses/{sha}","languages_url":"https://api.github.com/repos/binaris/binaris/languages","stargazers_url":"https://api.github.com/repos/binaris/binaris/stargazers","contributors_url":"https://api.github.com/repos/binaris/binaris/contributors","subscribers_url":"https://api.github.com/repos/binaris/binaris/subscribers","subscription_url":"https://api.github.com/repos/binaris/binaris/subscription","commits_url":"https://api.github.com/repos/binaris/binaris/commits{/sha}","git_commits_url":"https://api.github.com/repos/binaris/binaris/git/commits{/sha}","comments_url":"https://api.github.com/repos/binaris/binaris/comments{/number}","issue_comment_url":"https://api.github.com/repos/binaris/binaris/issues/comments{/number}","contents_url":"https://api.github.com/repos/binaris/binaris/contents/{+path}","compare_url":"https://api.github.com/repos/binaris/binaris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binaris/binaris/merges","archive_url":"https://api.github.com/repos/binaris/binaris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binaris/binaris/downloads","issues_url":"https://api.github.com/repos/binaris/binaris/issues{/number}","pulls_url":"https://api.github.com/repos/binaris/binaris/pulls{/number}","milestones_url":"https://api.github.com/repos/binaris/binaris/milestones{/number}","notifications_url":"https://api.github.com/repos/binaris/binaris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binaris/binaris/labels{/name}","releases_url":"https://api.github.com/repos/binaris/binaris/releases{/id}","deployments_url":"https://api.github.com/repos/binaris/binaris/deployments","created_at":"2017-09-13T22:57:26Z","updated_at":"2018-10-29T21:07:52Z","pushed_at":"2018-10-31T15:12:46Z","git_url":"git://github.com/binaris/binaris.git","ssh_url":"git@github.com:binaris/binaris.git","clone_url":"https://github.com/binaris/binaris.git","svn_url":"https://github.com/binaris/binaris","homepage":"https://dev.binaris.com/","size":420,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":29,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binaris/binaris/pulls/362"},"html":{"href":"https://github.com/binaris/binaris/pull/362"},"issue":{"href":"https://api.github.com/repos/binaris/binaris/issues/362"},"comments":{"href":"https://api.github.com/repos/binaris/binaris/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/binaris/binaris/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/binaris/binaris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binaris/binaris/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/binaris/binaris/statuses/04bf4e9788191445123a10780fabc0485230fc48"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rylandg"}}