{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/211330149","pull_request_review_id":147727640,"id":211330149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTMzMDE0OQ==","diff_hunk":"@@ -1,3 +1,4 @@\n+//#define DO_THROW_UNINITIALIZED","path":"DataFormats/TrackerRecHit2D/src/BaseTrackerRecHit.cc","position":1,"original_position":1,"commit_id":"9f570dd65cb8a6477c09be037e2bae3de4094c24","original_commit_id":"9f570dd65cb8a6477c09be037e2bae3de4094c24","user":{"login":"slava77","id":4676718,"node_id":"MDQ6VXNlcjQ2NzY3MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"shouldn't this be in .h file?\r\nIf define is added only here, then in all cases where the compiler decides to not inline the call of ```check``` where it's used, there will be a problem with one definition rule.","created_at":"2018-08-20T16:42:06Z","updated_at":"2018-08-20T16:42:06Z","html_url":"https://github.com/cms-sw/cmssw/pull/24311#discussion_r211330149","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/211330149"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/24311#discussion_r211330149"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311","id":208641717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjQxNzE3","html_url":"https://github.com/cms-sw/cmssw/pull/24311","diff_url":"https://github.com/cms-sw/cmssw/pull/24311.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/24311.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24311","number":24311,"state":"open","locked":false,"title":"Hide testing functions within appropriate CPP macros","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"Functions which are only used during debugging were being reported\r\nby a clang warning as unused. Moving them into the same CPP macros\r\nas their calling code makes them only available if they will be\r\ncalled.","created_at":"2018-08-15T18:26:06Z","updated_at":"2018-08-20T16:42:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55095edd460f05379beb56b799cea1f643944671","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"node_id":"MDU6TGFiZWw4ODY0NTQ3OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131195,"node_id":"MDU6TGFiZWw1NjEzMTE5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77","html_url":"https://github.com/cms-sw/cmssw/milestone/77","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/77/labels","id":3502981,"node_id":"MDk6TWlsZXN0b25lMzUwMjk4MQ==","number":77,"title":"CMSSW_10_3_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":398,"state":"open","created_at":"2018-07-17T14:14:12Z","updated_at":"2018-08-20T16:33:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/24311/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/9f570dd65cb8a6477c09be037e2bae3de4094c24","head":{"label":"Dr15Jones:clangWarningDataFormatsTrackerRecHit2D","ref":"clangWarningDataFormatsTrackerRecHit2D","sha":"9f570dd65cb8a6477c09be037e2bae3de4094c24","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"repo":{"id":10974606,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3NDYwNg==","name":"cmssw","full_name":"Dr15Jones/cmssw","owner":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dr15Jones/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/Dr15Jones/cmssw","forks_url":"https://api.github.com/repos/Dr15Jones/cmssw/forks","keys_url":"https://api.github.com/repos/Dr15Jones/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dr15Jones/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dr15Jones/cmssw/teams","hooks_url":"https://api.github.com/repos/Dr15Jones/cmssw/hooks","issue_events_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/Dr15Jones/cmssw/events","assignees_url":"https://api.github.com/repos/Dr15Jones/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/Dr15Jones/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/Dr15Jones/cmssw/tags","blobs_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dr15Jones/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/Dr15Jones/cmssw/languages","stargazers_url":"https://api.github.com/repos/Dr15Jones/cmssw/stargazers","contributors_url":"https://api.github.com/repos/Dr15Jones/cmssw/contributors","subscribers_url":"https://api.github.com/repos/Dr15Jones/cmssw/subscribers","subscription_url":"https://api.github.com/repos/Dr15Jones/cmssw/subscription","commits_url":"https://api.github.com/repos/Dr15Jones/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dr15Jones/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dr15Jones/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/Dr15Jones/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dr15Jones/cmssw/merges","archive_url":"https://api.github.com/repos/Dr15Jones/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dr15Jones/cmssw/downloads","issues_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/Dr15Jones/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/Dr15Jones/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/Dr15Jones/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dr15Jones/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/Dr15Jones/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/Dr15Jones/cmssw/deployments","created_at":"2013-06-26T17:40:38Z","updated_at":"2018-08-08T14:46:07Z","pushed_at":"2018-08-20T16:41:39Z","git_url":"git://github.com/Dr15Jones/cmssw.git","ssh_url":"git@github.com:Dr15Jones/cmssw.git","clone_url":"https://github.com/Dr15Jones/cmssw.git","svn_url":"https://github.com/Dr15Jones/cmssw","homepage":null,"size":891866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"ecf3d87d96e1d10ebe70175622900abf4cca9de3","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-08-20T06:52:48Z","pushed_at":"2018-08-20T16:41:45Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1027643,"stargazers_count":572,"watchers_count":572,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2663,"mirror_url":null,"archived":false,"open_issues_count":474,"license":null,"forks":2663,"open_issues":474,"watchers":572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/24311"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/24311"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/24311/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/24311/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/9f570dd65cb8a6477c09be037e2bae3de4094c24"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slava77"}}