{"action":"created","comment":{"url":"https://api.github.com/repos/runelite/runelite/pulls/comments/186983282","pull_request_review_id":118668293,"id":186983282,"diff_hunk":"@@ -56,7 +56,12 @@\n \t\t\tproperties.load(in);\n \n \t\t\tversion = properties.getProperty(\"runelite.version\");\n-\t\t\trsVersion = Integer.parseInt(properties.getProperty(\"rs.version\"));\n+\t\t\tString strRsVersion = properties.getProperty(\"rs.version\");\n+\t\t\tif (\"${rs.version}\".equals(strRsVersion))","path":"http-api/src/main/java/net/runelite/http/api/RuneLiteAPI.java","position":6,"original_position":6,"commit_id":"1ca2bed2830cc4ebfa3aa9779663f5c1d5e0b8cb","original_commit_id":"1ca2bed2830cc4ebfa3aa9779663f5c1d5e0b8cb","user":{"login":"Abextm","id":12366911,"avatar_url":"https://avatars2.githubusercontent.com/u/12366911?v=4","gravatar_id":"","url":"https://api.github.com/users/Abextm","html_url":"https://github.com/Abextm","followers_url":"https://api.github.com/users/Abextm/followers","following_url":"https://api.github.com/users/Abextm/following{/other_user}","gists_url":"https://api.github.com/users/Abextm/gists{/gist_id}","starred_url":"https://api.github.com/users/Abextm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abextm/subscriptions","organizations_url":"https://api.github.com/users/Abextm/orgs","repos_url":"https://api.github.com/users/Abextm/repos","events_url":"https://api.github.com/users/Abextm/events{/privacy}","received_events_url":"https://api.github.com/users/Abextm/received_events","type":"User","site_admin":false},"body":"No, I wanted a `java.lang.VerifyError` because by classpath is not in a valid state, so I should throw a relevant exception. Though it should probably be a `IncompatibleClassChangeError`","created_at":"2018-05-09T09:25:40Z","updated_at":"2018-05-09T09:25:40Z","html_url":"https://github.com/runelite/runelite/pull/2506#discussion_r186983282","pull_request_url":"https://api.github.com/repos/runelite/runelite/pulls/2506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments/186983282"},"html":{"href":"https://github.com/runelite/runelite/pull/2506#discussion_r186983282"},"pull_request":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2506"}},"in_reply_to_id":186979969},"pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/2506","id":186852897,"html_url":"https://github.com/runelite/runelite/pull/2506","diff_url":"https://github.com/runelite/runelite/pull/2506.diff","patch_url":"https://github.com/runelite/runelite/pull/2506.patch","issue_url":"https://api.github.com/repos/runelite/runelite/issues/2506","number":2506,"state":"open","locked":false,"title":"http-api: Print a more helpful error message when maven has not worked","user":{"login":"Abextm","id":12366911,"avatar_url":"https://avatars2.githubusercontent.com/u/12366911?v=4","gravatar_id":"","url":"https://api.github.com/users/Abextm","html_url":"https://github.com/Abextm","followers_url":"https://api.github.com/users/Abextm/followers","following_url":"https://api.github.com/users/Abextm/following{/other_user}","gists_url":"https://api.github.com/users/Abextm/gists{/gist_id}","starred_url":"https://api.github.com/users/Abextm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abextm/subscriptions","organizations_url":"https://api.github.com/users/Abextm/orgs","repos_url":"https://api.github.com/users/Abextm/repos","events_url":"https://api.github.com/users/Abextm/events{/privacy}","received_events_url":"https://api.github.com/users/Abextm/received_events","type":"User","site_admin":false},"body":"We get a minimum of one person a day having this error because maven can't build correctly on first run. This makes throws a more useful exception when this happens.","created_at":"2018-05-09T08:36:08Z","updated_at":"2018-05-09T09:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea742716ff973851376ff7ca40fb1e10abfbaaa8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":366780282,"url":"https://api.github.com/repos/runelite/runelite/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/runelite/runelite/pulls/2506/commits","review_comments_url":"https://api.github.com/repos/runelite/runelite/pulls/2506/comments","review_comment_url":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/2506/comments","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/1ca2bed2830cc4ebfa3aa9779663f5c1d5e0b8cb","head":{"label":"Abextm:rs-version-helpful","ref":"rs-version-helpful","sha":"1ca2bed2830cc4ebfa3aa9779663f5c1d5e0b8cb","user":{"login":"Abextm","id":12366911,"avatar_url":"https://avatars2.githubusercontent.com/u/12366911?v=4","gravatar_id":"","url":"https://api.github.com/users/Abextm","html_url":"https://github.com/Abextm","followers_url":"https://api.github.com/users/Abextm/followers","following_url":"https://api.github.com/users/Abextm/following{/other_user}","gists_url":"https://api.github.com/users/Abextm/gists{/gist_id}","starred_url":"https://api.github.com/users/Abextm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abextm/subscriptions","organizations_url":"https://api.github.com/users/Abextm/orgs","repos_url":"https://api.github.com/users/Abextm/repos","events_url":"https://api.github.com/users/Abextm/events{/privacy}","received_events_url":"https://api.github.com/users/Abextm/received_events","type":"User","site_admin":false},"repo":{"id":116477461,"name":"runelite","full_name":"Abextm/runelite","owner":{"login":"Abextm","id":12366911,"avatar_url":"https://avatars2.githubusercontent.com/u/12366911?v=4","gravatar_id":"","url":"https://api.github.com/users/Abextm","html_url":"https://github.com/Abextm","followers_url":"https://api.github.com/users/Abextm/followers","following_url":"https://api.github.com/users/Abextm/following{/other_user}","gists_url":"https://api.github.com/users/Abextm/gists{/gist_id}","starred_url":"https://api.github.com/users/Abextm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abextm/subscriptions","organizations_url":"https://api.github.com/users/Abextm/orgs","repos_url":"https://api.github.com/users/Abextm/repos","events_url":"https://api.github.com/users/Abextm/events{/privacy}","received_events_url":"https://api.github.com/users/Abextm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Abextm/runelite","description":"Open source Old School RuneScape client","fork":true,"url":"https://api.github.com/repos/Abextm/runelite","forks_url":"https://api.github.com/repos/Abextm/runelite/forks","keys_url":"https://api.github.com/repos/Abextm/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Abextm/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Abextm/runelite/teams","hooks_url":"https://api.github.com/repos/Abextm/runelite/hooks","issue_events_url":"https://api.github.com/repos/Abextm/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/Abextm/runelite/events","assignees_url":"https://api.github.com/repos/Abextm/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/Abextm/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/Abextm/runelite/tags","blobs_url":"https://api.github.com/repos/Abextm/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Abextm/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Abextm/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Abextm/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Abextm/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/Abextm/runelite/languages","stargazers_url":"https://api.github.com/repos/Abextm/runelite/stargazers","contributors_url":"https://api.github.com/repos/Abextm/runelite/contributors","subscribers_url":"https://api.github.com/repos/Abextm/runelite/subscribers","subscription_url":"https://api.github.com/repos/Abextm/runelite/subscription","commits_url":"https://api.github.com/repos/Abextm/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Abextm/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Abextm/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Abextm/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Abextm/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/Abextm/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Abextm/runelite/merges","archive_url":"https://api.github.com/repos/Abextm/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Abextm/runelite/downloads","issues_url":"https://api.github.com/repos/Abextm/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/Abextm/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/Abextm/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/Abextm/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Abextm/runelite/labels{/name}","releases_url":"https://api.github.com/repos/Abextm/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/Abextm/runelite/deployments","created_at":"2018-01-06T11:28:25Z","updated_at":"2018-03-23T05:47:11Z","pushed_at":"2018-05-09T08:35:13Z","git_url":"git://github.com/Abextm/runelite.git","ssh_url":"git@github.com:Abextm/runelite.git","clone_url":"https://github.com/Abextm/runelite.git","svn_url":"https://github.com/Abextm/runelite","homepage":"https://runelite.net","size":39710,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"runelite:master","ref":"master","sha":"5556c64fae66e12f556c66145af8e2ba13a040ce","user":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"repo":{"id":57461213,"name":"runelite","full_name":"runelite/runelite","owner":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runelite/runelite","description":"Open source Old School RuneScape client","fork":false,"url":"https://api.github.com/repos/runelite/runelite","forks_url":"https://api.github.com/repos/runelite/runelite/forks","keys_url":"https://api.github.com/repos/runelite/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runelite/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runelite/runelite/teams","hooks_url":"https://api.github.com/repos/runelite/runelite/hooks","issue_events_url":"https://api.github.com/repos/runelite/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/runelite/runelite/events","assignees_url":"https://api.github.com/repos/runelite/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/runelite/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/runelite/runelite/tags","blobs_url":"https://api.github.com/repos/runelite/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runelite/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runelite/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/runelite/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/runelite/runelite/languages","stargazers_url":"https://api.github.com/repos/runelite/runelite/stargazers","contributors_url":"https://api.github.com/repos/runelite/runelite/contributors","subscribers_url":"https://api.github.com/repos/runelite/runelite/subscribers","subscription_url":"https://api.github.com/repos/runelite/runelite/subscription","commits_url":"https://api.github.com/repos/runelite/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/runelite/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/runelite/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/runelite/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/runelite/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/runelite/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runelite/runelite/merges","archive_url":"https://api.github.com/repos/runelite/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runelite/runelite/downloads","issues_url":"https://api.github.com/repos/runelite/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/runelite/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/runelite/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/runelite/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runelite/runelite/labels{/name}","releases_url":"https://api.github.com/repos/runelite/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/runelite/runelite/deployments","created_at":"2016-04-30T20:48:02Z","updated_at":"2018-05-09T08:23:11Z","pushed_at":"2018-05-09T09:06:26Z","git_url":"git://github.com/runelite/runelite.git","ssh_url":"git@github.com:runelite/runelite.git","clone_url":"https://github.com/runelite/runelite.git","svn_url":"https://github.com/runelite/runelite","homepage":"https://runelite.net","size":39300,"stargazers_count":503,"watchers_count":503,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":456,"mirror_url":null,"archived":false,"open_issues_count":719,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":456,"open_issues":719,"watchers":503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2506"},"html":{"href":"https://github.com/runelite/runelite/pull/2506"},"issue":{"href":"https://api.github.com/repos/runelite/runelite/issues/2506"},"comments":{"href":"https://api.github.com/repos/runelite/runelite/issues/2506/comments"},"review_comments":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2506/comments"},"review_comment":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runelite/runelite/pulls/2506/commits"},"statuses":{"href":"https://api.github.com/repos/runelite/runelite/statuses/1ca2bed2830cc4ebfa3aa9779663f5c1d5e0b8cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Abextm"}}