{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/192376031","pull_request_review_id":125098331,"id":192376031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM3NjAzMQ==","diff_hunk":"@@ -383,6 +386,100 @@ public String select(Map<String, List<Event>> pattern) {\n \t\tenv.execute();\n \t}\n \n+\t@Test\n+\tpublic void testSimpleKeyedPatternEventTimeWithSideOutput() throws Exception {","path":"flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java","position":28,"original_position":28,"commit_id":"cf853bc1aacbb54f906ecaaa4a4edd5de49322a2","original_commit_id":"cf853bc1aacbb54f906ecaaa4a4edd5de49322a2","user":{"login":"dawidwys","id":6242259,"node_id":"MDQ6VXNlcjYyNDIyNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6242259?v=4","gravatar_id":"","url":"https://api.github.com/users/dawidwys","html_url":"https://github.com/dawidwys","followers_url":"https://api.github.com/users/dawidwys/followers","following_url":"https://api.github.com/users/dawidwys/following{/other_user}","gists_url":"https://api.github.com/users/dawidwys/gists{/gist_id}","starred_url":"https://api.github.com/users/dawidwys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawidwys/subscriptions","organizations_url":"https://api.github.com/users/dawidwys/orgs","repos_url":"https://api.github.com/users/dawidwys/repos","events_url":"https://api.github.com/users/dawidwys/events{/privacy}","received_events_url":"https://api.github.com/users/dawidwys/received_events","type":"User","site_admin":false},"body":"How about to simplify the test a bit? \r\n\r\nI would be in favour of implementing this test with `OperatorTestHarness` (in CepOperatorTest). This way we it is way easier to follow which events are late.\r\n\r\nAlso I would use a simpler Pattern here... Don't see a reason for using 3 part one.","created_at":"2018-06-01T12:09:36Z","updated_at":"2018-06-01T12:11:14Z","html_url":"https://github.com/apache/flink/pull/6104#discussion_r192376031","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6104","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/192376031"},"html":{"href":"https://github.com/apache/flink/pull/6104#discussion_r192376031"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6104"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6104","id":191501481,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTAxNDgx","html_url":"https://github.com/apache/flink/pull/6104","diff_url":"https://github.com/apache/flink/pull/6104.diff","patch_url":"https://github.com/apache/flink/pull/6104.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6104","number":6104,"state":"open","locked":false,"title":"[FLINK-9476]Emit late elements in CEP as sideOutPut","user":{"login":"Aitozi","id":9486140,"node_id":"MDQ6VXNlcjk0ODYxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9486140?v=4","gravatar_id":"","url":"https://api.github.com/users/Aitozi","html_url":"https://github.com/Aitozi","followers_url":"https://api.github.com/users/Aitozi/followers","following_url":"https://api.github.com/users/Aitozi/following{/other_user}","gists_url":"https://api.github.com/users/Aitozi/gists{/gist_id}","starred_url":"https://api.github.com/users/Aitozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aitozi/subscriptions","organizations_url":"https://api.github.com/users/Aitozi/orgs","repos_url":"https://api.github.com/users/Aitozi/repos","events_url":"https://api.github.com/users/Aitozi/events{/privacy}","received_events_url":"https://api.github.com/users/Aitozi/received_events","type":"User","site_admin":false},"body":"Now, when use with Eventtime in CEP library, elements come later than watermark will be dropped,we can put it in side Output with outPutTag","created_at":"2018-05-30T15:53:43Z","updated_at":"2018-06-01T12:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"115ccd1267df782b204eec92c6b273182c74fac8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6104/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6104/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6104/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/cf853bc1aacbb54f906ecaaa4a4edd5de49322a2","head":{"label":"Aitozi:FLINK-9476","ref":"FLINK-9476","sha":"cf853bc1aacbb54f906ecaaa4a4edd5de49322a2","user":{"login":"Aitozi","id":9486140,"node_id":"MDQ6VXNlcjk0ODYxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9486140?v=4","gravatar_id":"","url":"https://api.github.com/users/Aitozi","html_url":"https://github.com/Aitozi","followers_url":"https://api.github.com/users/Aitozi/followers","following_url":"https://api.github.com/users/Aitozi/following{/other_user}","gists_url":"https://api.github.com/users/Aitozi/gists{/gist_id}","starred_url":"https://api.github.com/users/Aitozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aitozi/subscriptions","organizations_url":"https://api.github.com/users/Aitozi/orgs","repos_url":"https://api.github.com/users/Aitozi/repos","events_url":"https://api.github.com/users/Aitozi/events{/privacy}","received_events_url":"https://api.github.com/users/Aitozi/received_events","type":"User","site_admin":false},"repo":{"id":96601256,"node_id":"MDEwOlJlcG9zaXRvcnk5NjYwMTI1Ng==","name":"flink","full_name":"Aitozi/flink","owner":{"login":"Aitozi","id":9486140,"node_id":"MDQ6VXNlcjk0ODYxNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/9486140?v=4","gravatar_id":"","url":"https://api.github.com/users/Aitozi","html_url":"https://github.com/Aitozi","followers_url":"https://api.github.com/users/Aitozi/followers","following_url":"https://api.github.com/users/Aitozi/following{/other_user}","gists_url":"https://api.github.com/users/Aitozi/gists{/gist_id}","starred_url":"https://api.github.com/users/Aitozi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aitozi/subscriptions","organizations_url":"https://api.github.com/users/Aitozi/orgs","repos_url":"https://api.github.com/users/Aitozi/repos","events_url":"https://api.github.com/users/Aitozi/events{/privacy}","received_events_url":"https://api.github.com/users/Aitozi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aitozi/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/Aitozi/flink","forks_url":"https://api.github.com/repos/Aitozi/flink/forks","keys_url":"https://api.github.com/repos/Aitozi/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aitozi/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aitozi/flink/teams","hooks_url":"https://api.github.com/repos/Aitozi/flink/hooks","issue_events_url":"https://api.github.com/repos/Aitozi/flink/issues/events{/number}","events_url":"https://api.github.com/repos/Aitozi/flink/events","assignees_url":"https://api.github.com/repos/Aitozi/flink/assignees{/user}","branches_url":"https://api.github.com/repos/Aitozi/flink/branches{/branch}","tags_url":"https://api.github.com/repos/Aitozi/flink/tags","blobs_url":"https://api.github.com/repos/Aitozi/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aitozi/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aitozi/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aitozi/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aitozi/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/Aitozi/flink/languages","stargazers_url":"https://api.github.com/repos/Aitozi/flink/stargazers","contributors_url":"https://api.github.com/repos/Aitozi/flink/contributors","subscribers_url":"https://api.github.com/repos/Aitozi/flink/subscribers","subscription_url":"https://api.github.com/repos/Aitozi/flink/subscription","commits_url":"https://api.github.com/repos/Aitozi/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aitozi/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aitozi/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aitozi/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aitozi/flink/contents/{+path}","compare_url":"https://api.github.com/repos/Aitozi/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aitozi/flink/merges","archive_url":"https://api.github.com/repos/Aitozi/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aitozi/flink/downloads","issues_url":"https://api.github.com/repos/Aitozi/flink/issues{/number}","pulls_url":"https://api.github.com/repos/Aitozi/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/Aitozi/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/Aitozi/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aitozi/flink/labels{/name}","releases_url":"https://api.github.com/repos/Aitozi/flink/releases{/id}","deployments_url":"https://api.github.com/repos/Aitozi/flink/deployments","created_at":"2017-07-08T06:45:18Z","updated_at":"2017-07-08T06:45:41Z","pushed_at":"2018-05-31T04:51:32Z","git_url":"git://github.com/Aitozi/flink.git","ssh_url":"git@github.com:Aitozi/flink.git","clone_url":"https://github.com/Aitozi/flink.git","svn_url":"https://github.com/Aitozi/flink","homepage":null,"size":154182,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b6448015f485b5051e5e920b82b4b3ee71c55974","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-06-01T10:02:31Z","pushed_at":"2018-06-01T11:50:46Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":156655,"stargazers_count":3773,"watchers_count":3773,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2558,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2558,"open_issues":349,"watchers":3773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6104"},"html":{"href":"https://github.com/apache/flink/pull/6104"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6104"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6104/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6104/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6104/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/cf853bc1aacbb54f906ecaaa4a4edd5de49322a2"}},"author_association":"NONE"}}
{"actor":{"display_login":"dawidwys"}}