{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/180562690","pull_request_review_id":111004931,"id":180562690,"diff_hunk":"@@ -176,6 +178,70 @@ public void basicClientServerIntegrationTest() throws Exception {\n     client.unaryRpc(SimpleRequest.getDefaultInstance());\n   }\n \n+  /**\n+   * Same as basicClientServerIntegrationTest except we test the InputStream based certs API.\n+   */\n+  @Test\n+  public void basicClientServerIntegrationTestInputStreamCerts() throws Exception {\n+    InputStream serverCertChain = null;","path":"netty/src/test/java/io/grpc/netty/TlsTest.java","position":19,"original_position":19,"commit_id":"0d64fc350f0aedd106b4d1a464c6034b116c41da","original_commit_id":"0d64fc350f0aedd106b4d1a464c6034b116c41da","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"These assigned to on lines 193/194 , 218/219 and used immediately after.","created_at":"2018-04-10T20:48:11Z","updated_at":"2018-04-10T20:48:12Z","html_url":"https://github.com/grpc/grpc-java/pull/4316#discussion_r180562690","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/180562690"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4316#discussion_r180562690"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4316"}},"in_reply_to_id":180260529},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/4316","id":180073174,"html_url":"https://github.com/grpc/grpc-java/pull/4316","diff_url":"https://github.com/grpc/grpc-java/pull/4316.diff","patch_url":"https://github.com/grpc/grpc-java/pull/4316.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4316","number":4316,"state":"open","locked":false,"title":"core, netty: allow InputStream based certs","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"body":"Allow ServerBuilder to read certs from InputStream, not just from a\r\nFile.\r\n\r\nThis PR revives https://github.com/grpc/grpc-java/issues/1881","created_at":"2018-04-06T23:13:29Z","updated_at":"2018-04-10T20:48:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20e7d201a85fea9ecc561263f6e8fd0b9633bc37","assignee":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"assignees":[{"login":"ejona86","id":2811396,"avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4316/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/4316/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4316/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/0d64fc350f0aedd106b4d1a464c6034b116c41da","head":{"label":"zpencer:ssl-inputstream-2","ref":"ssl-inputstream-2","sha":"0d64fc350f0aedd106b4d1a464c6034b116c41da","user":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"repo":{"id":89497167,"name":"grpc-java","full_name":"zpencer/grpc-java","owner":{"login":"zpencer","id":2819812,"avatar_url":"https://avatars0.githubusercontent.com/u/2819812?v=4","gravatar_id":"","url":"https://api.github.com/users/zpencer","html_url":"https://github.com/zpencer","followers_url":"https://api.github.com/users/zpencer/followers","following_url":"https://api.github.com/users/zpencer/following{/other_user}","gists_url":"https://api.github.com/users/zpencer/gists{/gist_id}","starred_url":"https://api.github.com/users/zpencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpencer/subscriptions","organizations_url":"https://api.github.com/users/zpencer/orgs","repos_url":"https://api.github.com/users/zpencer/repos","events_url":"https://api.github.com/users/zpencer/events{/privacy}","received_events_url":"https://api.github.com/users/zpencer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zpencer/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/zpencer/grpc-java","forks_url":"https://api.github.com/repos/zpencer/grpc-java/forks","keys_url":"https://api.github.com/repos/zpencer/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zpencer/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zpencer/grpc-java/teams","hooks_url":"https://api.github.com/repos/zpencer/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/zpencer/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/zpencer/grpc-java/events","assignees_url":"https://api.github.com/repos/zpencer/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/zpencer/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/zpencer/grpc-java/tags","blobs_url":"https://api.github.com/repos/zpencer/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zpencer/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zpencer/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/zpencer/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zpencer/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/zpencer/grpc-java/languages","stargazers_url":"https://api.github.com/repos/zpencer/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/zpencer/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/zpencer/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/zpencer/grpc-java/subscription","commits_url":"https://api.github.com/repos/zpencer/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/zpencer/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/zpencer/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/zpencer/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/zpencer/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/zpencer/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zpencer/grpc-java/merges","archive_url":"https://api.github.com/repos/zpencer/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zpencer/grpc-java/downloads","issues_url":"https://api.github.com/repos/zpencer/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/zpencer/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/zpencer/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/zpencer/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zpencer/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/zpencer/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/zpencer/grpc-java/deployments","created_at":"2017-04-26T15:28:10Z","updated_at":"2017-04-26T15:28:13Z","pushed_at":"2018-04-09T22:29:34Z","git_url":"git://github.com/zpencer/grpc-java.git","ssh_url":"git@github.com:zpencer/grpc-java.git","clone_url":"https://github.com/zpencer/grpc-java.git","svn_url":"https://github.com/zpencer/grpc-java","homepage":"http://grpc.io","size":21208,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"d68b2cd74a6af1b0487d67e82a4ce0a443b2cf95","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2018-04-10T13:25:02Z","pushed_at":"2018-04-10T20:23:19Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"https://grpc.io","size":23272,"stargazers_count":4072,"watchers_count":4072,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1322,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1322,"open_issues":344,"watchers":4072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4316"},"html":{"href":"https://github.com/grpc/grpc-java/pull/4316"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4316"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/4316/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4316/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/4316/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/0d64fc350f0aedd106b4d1a464c6034b116c41da"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zpencer"}}