{"action":"closed","number":773,"pull_request":{"url":"https://api.github.com/repos/Shopify/slate/pulls/773","id":217761031,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzYxMDMx","html_url":"https://github.com/Shopify/slate/pull/773","diff_url":"https://github.com/Shopify/slate/pull/773.diff","patch_url":"https://github.com/Shopify/slate/pull/773.patch","issue_url":"https://api.github.com/repos/Shopify/slate/issues/773","number":773,"state":"closed","locked":false,"title":"Add configuration to disable external testing using local IP","user":{"login":"t-kelly","id":4837696,"node_id":"MDQ6VXNlcjQ4Mzc2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4837696?v=4","gravatar_id":"","url":"https://api.github.com/users/t-kelly","html_url":"https://github.com/t-kelly","followers_url":"https://api.github.com/users/t-kelly/followers","following_url":"https://api.github.com/users/t-kelly/following{/other_user}","gists_url":"https://api.github.com/users/t-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/t-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-kelly/subscriptions","organizations_url":"https://api.github.com/users/t-kelly/orgs","repos_url":"https://api.github.com/users/t-kelly/repos","events_url":"https://api.github.com/users/t-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/t-kelly/received_events","type":"User","site_admin":false},"body":"### What are you trying to accomplish with this PR?\r\n\r\nFix #757 \r\n\r\nAdds `'network.externalTesting'` config which will toggle using localhost or your local IP for referencing development assets. If you use localhost, you will probably encounter problems with SSL authentication when visiting your dev shop from an external device.\r\n","created_at":"2018-09-24T19:22:02Z","updated_at":"2018-09-25T16:35:21Z","closed_at":"2018-09-25T16:35:21Z","merged_at":"2018-09-25T16:35:21Z","merge_commit_sha":"8d285353e15e3611b408f3ea227688a4d60e9c1b","assignee":{"login":"t-kelly","id":4837696,"node_id":"MDQ6VXNlcjQ4Mzc2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4837696?v=4","gravatar_id":"","url":"https://api.github.com/users/t-kelly","html_url":"https://github.com/t-kelly","followers_url":"https://api.github.com/users/t-kelly/followers","following_url":"https://api.github.com/users/t-kelly/following{/other_user}","gists_url":"https://api.github.com/users/t-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/t-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-kelly/subscriptions","organizations_url":"https://api.github.com/users/t-kelly/orgs","repos_url":"https://api.github.com/users/t-kelly/repos","events_url":"https://api.github.com/users/t-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/t-kelly/received_events","type":"User","site_admin":false},"assignees":[{"login":"t-kelly","id":4837696,"node_id":"MDQ6VXNlcjQ4Mzc2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4837696?v=4","gravatar_id":"","url":"https://api.github.com/users/t-kelly","html_url":"https://github.com/t-kelly","followers_url":"https://api.github.com/users/t-kelly/followers","following_url":"https://api.github.com/users/t-kelly/following{/other_user}","gists_url":"https://api.github.com/users/t-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/t-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-kelly/subscriptions","organizations_url":"https://api.github.com/users/t-kelly/orgs","repos_url":"https://api.github.com/users/t-kelly/repos","events_url":"https://api.github.com/users/t-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/t-kelly/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":428946136,"node_id":"MDU6TGFiZWw0Mjg5NDYxMzY=","url":"https://api.github.com/repos/Shopify/slate/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":843919768,"node_id":"MDU6TGFiZWw4NDM5MTk3Njg=","url":"https://api.github.com/repos/Shopify/slate/labels/v1.x","name":"v1.x","color":"99e8ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/slate/pulls/773/commits","review_comments_url":"https://api.github.com/repos/Shopify/slate/pulls/773/comments","review_comment_url":"https://api.github.com/repos/Shopify/slate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/slate/issues/773/comments","statuses_url":"https://api.github.com/repos/Shopify/slate/statuses/1e7b68cde78a24a59e2dca9417f39aaac1c1ba72","head":{"label":"Shopify:add-external-dev-config","ref":"add-external-dev-config","sha":"1e7b68cde78a24a59e2dca9417f39aaac1c1ba72","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":66284109,"node_id":"MDEwOlJlcG9zaXRvcnk2NjI4NDEwOQ==","name":"slate","full_name":"Shopify/slate","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/slate","description":"Slate is toolkit for developing Shopify themes, designed to assist your workflow and speed up the process of developing, testing, and deploying themes.","fork":false,"url":"https://api.github.com/repos/Shopify/slate","forks_url":"https://api.github.com/repos/Shopify/slate/forks","keys_url":"https://api.github.com/repos/Shopify/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/slate/teams","hooks_url":"https://api.github.com/repos/Shopify/slate/hooks","issue_events_url":"https://api.github.com/repos/Shopify/slate/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/slate/events","assignees_url":"https://api.github.com/repos/Shopify/slate/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/slate/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/slate/tags","blobs_url":"https://api.github.com/repos/Shopify/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/slate/languages","stargazers_url":"https://api.github.com/repos/Shopify/slate/stargazers","contributors_url":"https://api.github.com/repos/Shopify/slate/contributors","subscribers_url":"https://api.github.com/repos/Shopify/slate/subscribers","subscription_url":"https://api.github.com/repos/Shopify/slate/subscription","commits_url":"https://api.github.com/repos/Shopify/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/slate/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/slate/merges","archive_url":"https://api.github.com/repos/Shopify/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/slate/downloads","issues_url":"https://api.github.com/repos/Shopify/slate/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/slate/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/slate/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/slate/deployments","created_at":"2016-08-22T15:24:08Z","updated_at":"2018-09-25T16:34:52Z","pushed_at":"2018-09-25T16:35:21Z","git_url":"git://github.com/Shopify/slate.git","ssh_url":"git@github.com:Shopify/slate.git","clone_url":"https://github.com/Shopify/slate.git","svn_url":"https://github.com/Shopify/slate","homepage":"","size":3562,"stargazers_count":744,"watchers_count":744,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":153,"open_issues":80,"watchers":744,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"663b32958a20025ccaa9cd5afdbe3b4cfc1ffdf3","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":66284109,"node_id":"MDEwOlJlcG9zaXRvcnk2NjI4NDEwOQ==","name":"slate","full_name":"Shopify/slate","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/slate","description":"Slate is toolkit for developing Shopify themes, designed to assist your workflow and speed up the process of developing, testing, and deploying themes.","fork":false,"url":"https://api.github.com/repos/Shopify/slate","forks_url":"https://api.github.com/repos/Shopify/slate/forks","keys_url":"https://api.github.com/repos/Shopify/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/slate/teams","hooks_url":"https://api.github.com/repos/Shopify/slate/hooks","issue_events_url":"https://api.github.com/repos/Shopify/slate/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/slate/events","assignees_url":"https://api.github.com/repos/Shopify/slate/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/slate/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/slate/tags","blobs_url":"https://api.github.com/repos/Shopify/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/slate/languages","stargazers_url":"https://api.github.com/repos/Shopify/slate/stargazers","contributors_url":"https://api.github.com/repos/Shopify/slate/contributors","subscribers_url":"https://api.github.com/repos/Shopify/slate/subscribers","subscription_url":"https://api.github.com/repos/Shopify/slate/subscription","commits_url":"https://api.github.com/repos/Shopify/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/slate/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/slate/merges","archive_url":"https://api.github.com/repos/Shopify/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/slate/downloads","issues_url":"https://api.github.com/repos/Shopify/slate/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/slate/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/slate/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/slate/deployments","created_at":"2016-08-22T15:24:08Z","updated_at":"2018-09-25T16:34:52Z","pushed_at":"2018-09-25T16:35:21Z","git_url":"git://github.com/Shopify/slate.git","ssh_url":"git@github.com:Shopify/slate.git","clone_url":"https://github.com/Shopify/slate.git","svn_url":"https://github.com/Shopify/slate","homepage":"","size":3562,"stargazers_count":744,"watchers_count":744,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":153,"open_issues":80,"watchers":744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/slate/pulls/773"},"html":{"href":"https://github.com/Shopify/slate/pull/773"},"issue":{"href":"https://api.github.com/repos/Shopify/slate/issues/773"},"comments":{"href":"https://api.github.com/repos/Shopify/slate/issues/773/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/slate/pulls/773/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/slate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/slate/pulls/773/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/slate/statuses/1e7b68cde78a24a59e2dca9417f39aaac1c1ba72"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"t-kelly","id":4837696,"node_id":"MDQ6VXNlcjQ4Mzc2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4837696?v=4","gravatar_id":"","url":"https://api.github.com/users/t-kelly","html_url":"https://github.com/t-kelly","followers_url":"https://api.github.com/users/t-kelly/followers","following_url":"https://api.github.com/users/t-kelly/following{/other_user}","gists_url":"https://api.github.com/users/t-kelly/gists{/gist_id}","starred_url":"https://api.github.com/users/t-kelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-kelly/subscriptions","organizations_url":"https://api.github.com/users/t-kelly/orgs","repos_url":"https://api.github.com/users/t-kelly/repos","events_url":"https://api.github.com/users/t-kelly/events{/privacy}","received_events_url":"https://api.github.com/users/t-kelly/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"t-kelly"}}