{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/171019769","pull_request_review_id":99799748,"id":171019769,"diff_hunk":"@@ -165,7 +165,7 @@ FORWARDING_HANDLER::OnExecuteRequestHandler()\n     //\n     // Mark request as websocket if upgrade header is present.\n     //\n-    if (g_fWebSocketSupported)\n+    if (pApplication->QueryConfig()->QueryWebSocketEnable())","path":"src/RequestHandler/outofprocess/forwardinghandler.cpp","position":null,"original_position":5,"commit_id":"129ecf8fa41c332822ac3591bea15f6a27fca047","original_commit_id":"6d188a407cad62ad0bd94d25306e10871c94806d","user":{"login":"jkotalik","id":8302101,"avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"Then shouldn't g_fWebSocketedSupported be equal to pApplication->QueryConfig()->QueryWebSocketEnabled()?","created_at":"2018-02-27T18:25:37Z","updated_at":"2018-02-27T18:25:37Z","html_url":"https://github.com/aspnet/IISIntegration/pull/612#discussion_r171019769","pull_request_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/171019769"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/612#discussion_r171019769"},"pull_request":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612"}},"in_reply_to_id":170818832},"pull_request":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612","id":171471423,"html_url":"https://github.com/aspnet/IISIntegration/pull/612","diff_url":"https://github.com/aspnet/IISIntegration/pull/612.diff","patch_url":"https://github.com/aspnet/IISIntegration/pull/612.patch","issue_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/612","number":612,"state":"open","locked":false,"title":"websocket enabled check","user":{"login":"pan-wang","id":18172635,"avatar_url":"https://avatars0.githubusercontent.com/u/18172635?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-wang","html_url":"https://github.com/pan-wang","followers_url":"https://api.github.com/users/pan-wang/followers","following_url":"https://api.github.com/users/pan-wang/following{/other_user}","gists_url":"https://api.github.com/users/pan-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-wang/subscriptions","organizations_url":"https://api.github.com/users/pan-wang/orgs","repos_url":"https://api.github.com/users/pan-wang/repos","events_url":"https://api.github.com/users/pan-wang/events{/privacy}","received_events_url":"https://api.github.com/users/pan-wang/received_events","type":"User","site_admin":false},"body":"check whether websocket is enabled in configuration. So that we will not forward the upgrade header if websocket is not enabled. Also add Release cal to avoid memory leak","created_at":"2018-02-26T19:39:41Z","updated_at":"2018-02-27T18:25:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"041f7bdf86abc1636537e51f9df7dd9768188446","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bariscaglar","id":1233208,"avatar_url":"https://avatars0.githubusercontent.com/u/1233208?v=4","gravatar_id":"","url":"https://api.github.com/users/bariscaglar","html_url":"https://github.com/bariscaglar","followers_url":"https://api.github.com/users/bariscaglar/followers","following_url":"https://api.github.com/users/bariscaglar/following{/other_user}","gists_url":"https://api.github.com/users/bariscaglar/gists{/gist_id}","starred_url":"https://api.github.com/users/bariscaglar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bariscaglar/subscriptions","organizations_url":"https://api.github.com/users/bariscaglar/orgs","repos_url":"https://api.github.com/users/bariscaglar/repos","events_url":"https://api.github.com/users/bariscaglar/events{/privacy}","received_events_url":"https://api.github.com/users/bariscaglar/received_events","type":"User","site_admin":false},{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars3.githubusercontent.com/u/1821173?v=4","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},{"login":"shirhatti","id":4734691,"avatar_url":"https://avatars1.githubusercontent.com/u/4734691?v=4","gravatar_id":"","url":"https://api.github.com/users/shirhatti","html_url":"https://github.com/shirhatti","followers_url":"https://api.github.com/users/shirhatti/followers","following_url":"https://api.github.com/users/shirhatti/following{/other_user}","gists_url":"https://api.github.com/users/shirhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/shirhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shirhatti/subscriptions","organizations_url":"https://api.github.com/users/shirhatti/orgs","repos_url":"https://api.github.com/users/shirhatti/repos","events_url":"https://api.github.com/users/shirhatti/events{/privacy}","received_events_url":"https://api.github.com/users/shirhatti/received_events","type":"User","site_admin":false},{"login":"jhkimnew","id":20650163,"avatar_url":"https://avatars2.githubusercontent.com/u/20650163?v=4","gravatar_id":"","url":"https://api.github.com/users/jhkimnew","html_url":"https://github.com/jhkimnew","followers_url":"https://api.github.com/users/jhkimnew/followers","following_url":"https://api.github.com/users/jhkimnew/following{/other_user}","gists_url":"https://api.github.com/users/jhkimnew/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkimnew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkimnew/subscriptions","organizations_url":"https://api.github.com/users/jhkimnew/orgs","repos_url":"https://api.github.com/users/jhkimnew/repos","events_url":"https://api.github.com/users/jhkimnew/events{/privacy}","received_events_url":"https://api.github.com/users/jhkimnew/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612/commits","review_comments_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612/comments","review_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/612/comments","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/129ecf8fa41c332822ac3591bea15f6a27fca047","head":{"label":"aspnet:panwang/websocket","ref":"panwang/websocket","sha":"129ecf8fa41c332822ac3591bea15f6a27fca047","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-02-16T17:19:23Z","pushed_at":"2018-02-27T17:56:27Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":2692,"stargazers_count":80,"watchers_count":80,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":37,"open_issues":65,"watchers":80,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"8df5b8931bd6dd18840b656813296ab742571a70","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-02-16T17:19:23Z","pushed_at":"2018-02-27T17:56:27Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":2692,"stargazers_count":80,"watchers_count":80,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":37,"open_issues":65,"watchers":80,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/612"},"issue":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/612"},"comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/612/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/612/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/IISIntegration/statuses/129ecf8fa41c332822ac3591bea15f6a27fca047"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jkotalik"}}