{"action":"closed","number":16715,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/16715","id":222169595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTY5NTk1","html_url":"https://github.com/angular/angular.js/pull/16715","diff_url":"https://github.com/angular/angular.js/pull/16715.diff","patch_url":"https://github.com/angular/angular.js/pull/16715.patch","issue_url":"https://api.github.com/repos/angular/angular.js/issues/16715","number":16715,"state":"closed","locked":false,"title":"fix(urlUtils): make IPv6 URL's hostname wrapped in square brackets in IE/Edge","user":{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"<!-- General PR submission guidelines https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#submit-pr -->\r\n**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\n\r\nA bug fix.\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\n\r\nIn IE 9-11 and Edge 16-17 (not in 18 Preview) `$location.host()` incorrectly returns hostnames of IPv6 addresses without wrapping in square brackets.\r\n\r\nThis is caused by and IE/Edge bug which incorrectly don't wrap IPv6 addresses' hostnames in square brackets when parsed out of an anchor element which is used by `$location` for the purpose of URL parsing.\r\n\r\nIssue: #16692\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\n\r\nFor all supported browsers `$location.host()` returns an IPv6 address wrapped in square brackets.\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nNo\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our [guidelines](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits)\r\n- [ ] Fix/Feature: [Docs](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#documentation) have been added/updated\r\n- [x] Fix/Feature: Tests have been added; existing tests pass\r\n\r\n**Other information**:\r\n\r\n","created_at":"2018-10-11T14:54:01Z","updated_at":"2018-10-18T09:45:10Z","closed_at":"2018-10-18T09:45:10Z","merged_at":"2018-10-18T09:45:10Z","merge_commit_sha":"b4e409bf6cd81307f57e51f2f1281b05ceb6cbf2","assignee":{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"assignees":[{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":250549575,"node_id":"MDU6TGFiZWwyNTA1NDk1NzU=","url":"https://api.github.com/repos/angular/angular.js/labels/browser:%20Edge","name":"browser: Edge","color":"0052cc","default":false},{"id":70943842,"node_id":"MDU6TGFiZWw3MDk0Mzg0Mg==","url":"https://api.github.com/repos/angular/angular.js/labels/browser:%20IE10","name":"browser: IE10","color":"d4c5f9","default":false},{"id":71455499,"node_id":"MDU6TGFiZWw3MTQ1NTQ5OQ==","url":"https://api.github.com/repos/angular/angular.js/labels/browser:%20IE11","name":"browser: IE11","color":"207de5","default":false},{"id":54049807,"node_id":"MDU6TGFiZWw1NDA0OTgwNw==","url":"https://api.github.com/repos/angular/angular.js/labels/browser:%20IE9","name":"browser: IE9","color":"c7def8","default":false},{"id":53200617,"node_id":"MDU6TGFiZWw1MzIwMDYxNw==","url":"https://api.github.com/repos/angular/angular.js/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false},{"id":69000822,"node_id":"MDU6TGFiZWw2OTAwMDgyMg==","url":"https://api.github.com/repos/angular/angular.js/labels/component:%20$location","name":"component: $location","color":"fef2c0","default":false},{"id":83182243,"node_id":"MDU6TGFiZWw4MzE4MjI0Mw==","url":"https://api.github.com/repos/angular/angular.js/labels/severity:%20broken%20expected%20use","name":"severity: broken expected use","color":"fbda00","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/144","html_url":"https://github.com/angular/angular.js/milestone/144","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/144/labels","id":3261234,"node_id":"MDk6TWlsZXN0b25lMzI2MTIzNA==","number":144,"title":"1.7.x","description":"","creator":{"login":"Narretz","id":1153097,"node_id":"MDQ6VXNlcjExNTMwOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1153097?v=4","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":98,"state":"open","created_at":"2018-04-12T08:43:23Z","updated_at":"2018-10-18T09:45:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular.js/pulls/16715/commits","review_comments_url":"https://api.github.com/repos/angular/angular.js/pulls/16715/comments","review_comment_url":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/16715/comments","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/d1e5a65059b61dc8c6c492ab2fb5dbaa9e84c6a7","head":{"label":"mgol:ipv6-ie-edge","ref":"ipv6-ie-edge","sha":"d1e5a65059b61dc8c6c492ab2fb5dbaa9e84c6a7","user":{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"repo":{"id":9753166,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUzMTY2","name":"angular.js","full_name":"mgol/angular.js","private":false,"owner":{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mgol/angular.js","description":null,"fork":true,"url":"https://api.github.com/repos/mgol/angular.js","forks_url":"https://api.github.com/repos/mgol/angular.js/forks","keys_url":"https://api.github.com/repos/mgol/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgol/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgol/angular.js/teams","hooks_url":"https://api.github.com/repos/mgol/angular.js/hooks","issue_events_url":"https://api.github.com/repos/mgol/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/mgol/angular.js/events","assignees_url":"https://api.github.com/repos/mgol/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/mgol/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/mgol/angular.js/tags","blobs_url":"https://api.github.com/repos/mgol/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgol/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgol/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgol/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgol/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mgol/angular.js/languages","stargazers_url":"https://api.github.com/repos/mgol/angular.js/stargazers","contributors_url":"https://api.github.com/repos/mgol/angular.js/contributors","subscribers_url":"https://api.github.com/repos/mgol/angular.js/subscribers","subscription_url":"https://api.github.com/repos/mgol/angular.js/subscription","commits_url":"https://api.github.com/repos/mgol/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgol/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgol/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgol/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgol/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/mgol/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgol/angular.js/merges","archive_url":"https://api.github.com/repos/mgol/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgol/angular.js/downloads","issues_url":"https://api.github.com/repos/mgol/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/mgol/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mgol/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mgol/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgol/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/mgol/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/mgol/angular.js/deployments","created_at":"2013-04-29T16:57:39Z","updated_at":"2018-08-08T19:19:50Z","pushed_at":"2018-10-17T19:28:46Z","git_url":"git://github.com/mgol/angular.js.git","ssh_url":"git@github.com:mgol/angular.js.git","clone_url":"https://github.com/mgol/angular.js.git","svn_url":"https://github.com/mgol/angular.js","homepage":"http://angularjs.org","size":99148,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"3e380325d8f64f30a6715578b117c6c161aee57b","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":460078,"node_id":"MDEwOlJlcG9zaXRvcnk0NjAwNzg=","name":"angular.js","full_name":"angular/angular.js","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular.js","description":"AngularJS - HTML enhanced for web apps!","fork":false,"url":"https://api.github.com/repos/angular/angular.js","forks_url":"https://api.github.com/repos/angular/angular.js/forks","keys_url":"https://api.github.com/repos/angular/angular.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular.js/teams","hooks_url":"https://api.github.com/repos/angular/angular.js/hooks","issue_events_url":"https://api.github.com/repos/angular/angular.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular.js/events","assignees_url":"https://api.github.com/repos/angular/angular.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular.js/tags","blobs_url":"https://api.github.com/repos/angular/angular.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular.js/languages","stargazers_url":"https://api.github.com/repos/angular/angular.js/stargazers","contributors_url":"https://api.github.com/repos/angular/angular.js/contributors","subscribers_url":"https://api.github.com/repos/angular/angular.js/subscribers","subscription_url":"https://api.github.com/repos/angular/angular.js/subscription","commits_url":"https://api.github.com/repos/angular/angular.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular.js/merges","archive_url":"https://api.github.com/repos/angular/angular.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular.js/downloads","issues_url":"https://api.github.com/repos/angular/angular.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular.js/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular.js/deployments","created_at":"2010-01-06T00:34:37Z","updated_at":"2018-10-18T02:26:28Z","pushed_at":"2018-10-18T09:45:10Z","git_url":"git://github.com/angular/angular.js.git","ssh_url":"git@github.com:angular/angular.js.git","clone_url":"https://github.com/angular/angular.js.git","svn_url":"https://github.com/angular/angular.js","homepage":"https://angularjs.org","size":99609,"stargazers_count":59176,"watchers_count":59176,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29021,"mirror_url":null,"archived":false,"open_issues_count":492,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29021,"open_issues":492,"watchers":59176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular.js/pulls/16715"},"html":{"href":"https://github.com/angular/angular.js/pull/16715"},"issue":{"href":"https://api.github.com/repos/angular/angular.js/issues/16715"},"comments":{"href":"https://api.github.com/repos/angular/angular.js/issues/16715/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular.js/pulls/16715/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular.js/pulls/16715/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular.js/statuses/d1e5a65059b61dc8c6c492ab2fb5dbaa9e84c6a7"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mgol"}}