{"action":"created","comment":{"url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/comments/182864125","pull_request_review_id":113751455,"id":182864125,"diff_hunk":"@@ -16,6 +16,7 @@ This article discusses options and issues in Fakes code generation and compilati\n **Requirements**\n \n -   Visual Studio Enterprise\n+-   Only for .NET Framework projects. Currently, there is not support for .NET Framework projects that target .NET Standard. ","path":"docs/test/code-generation-compilation-and-naming-conventions-in-microsoft-fakes.md","position":4,"original_position":4,"commit_id":"83772ef11d93d2bab706fd302f471bd678233f40","original_commit_id":"83772ef11d93d2bab706fd302f471bd678233f40","user":{"login":"gewarren","id":24882762,"avatar_url":"https://avatars3.githubusercontent.com/u/24882762?v=4","gravatar_id":"","url":"https://api.github.com/users/gewarren","html_url":"https://github.com/gewarren","followers_url":"https://api.github.com/users/gewarren/followers","following_url":"https://api.github.com/users/gewarren/following{/other_user}","gists_url":"https://api.github.com/users/gewarren/gists{/gist_id}","starred_url":"https://api.github.com/users/gewarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gewarren/subscriptions","organizations_url":"https://api.github.com/users/gewarren/orgs","repos_url":"https://api.github.com/users/gewarren/repos","events_url":"https://api.github.com/users/gewarren/events{/privacy}","received_events_url":"https://api.github.com/users/gewarren/received_events","type":"User","site_admin":false},"body":"@kendrahavens I find this sentence a tiny bit confusing because it says only for .NET Fx, but then not for some .NET Fx. To make it a little clearer, and to match the tense/structure of the first requirement, how about:\r\n\r\n- a .NET Framework project\r\n\r\n> [!NOTE]\r\n> .NET Standard projects are not supported.","created_at":"2018-04-19T19:46:48Z","updated_at":"2018-04-19T19:46:49Z","html_url":"https://github.com/MicrosoftDocs/visualstudio-docs/pull/829#discussion_r182864125","pull_request_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/comments/182864125"},"html":{"href":"https://github.com/MicrosoftDocs/visualstudio-docs/pull/829#discussion_r182864125"},"pull_request":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829"}}},"pull_request":{"url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829","id":182634076,"html_url":"https://github.com/MicrosoftDocs/visualstudio-docs/pull/829","diff_url":"https://github.com/MicrosoftDocs/visualstudio-docs/pull/829.diff","patch_url":"https://github.com/MicrosoftDocs/visualstudio-docs/pull/829.patch","issue_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues/829","number":829,"state":"open","locked":false,"title":"Add Requirement for only .NET Framework projects","user":{"login":"kendrahavens","id":8293542,"avatar_url":"https://avatars2.githubusercontent.com/u/8293542?v=4","gravatar_id":"","url":"https://api.github.com/users/kendrahavens","html_url":"https://github.com/kendrahavens","followers_url":"https://api.github.com/users/kendrahavens/followers","following_url":"https://api.github.com/users/kendrahavens/following{/other_user}","gists_url":"https://api.github.com/users/kendrahavens/gists{/gist_id}","starred_url":"https://api.github.com/users/kendrahavens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kendrahavens/subscriptions","organizations_url":"https://api.github.com/users/kendrahavens/orgs","repos_url":"https://api.github.com/users/kendrahavens/repos","events_url":"https://api.github.com/users/kendrahavens/events{/privacy}","received_events_url":"https://api.github.com/users/kendrahavens/received_events","type":"User","site_admin":false},"body":"Fakes only supports .NET Framework projects. It also cannot support a .NET Framework that targets .NET Standard.","created_at":"2018-04-19T00:02:51Z","updated_at":"2018-04-19T19:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34496cc7e10b29fca4d2dc4add351056ad725388","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829/commits","review_comments_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829/comments","review_comment_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues/829/comments","statuses_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/statuses/83772ef11d93d2bab706fd302f471bd678233f40","head":{"label":"kendrahavens:patch-3","ref":"patch-3","sha":"83772ef11d93d2bab706fd302f471bd678233f40","user":{"login":"kendrahavens","id":8293542,"avatar_url":"https://avatars2.githubusercontent.com/u/8293542?v=4","gravatar_id":"","url":"https://api.github.com/users/kendrahavens","html_url":"https://github.com/kendrahavens","followers_url":"https://api.github.com/users/kendrahavens/followers","following_url":"https://api.github.com/users/kendrahavens/following{/other_user}","gists_url":"https://api.github.com/users/kendrahavens/gists{/gist_id}","starred_url":"https://api.github.com/users/kendrahavens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kendrahavens/subscriptions","organizations_url":"https://api.github.com/users/kendrahavens/orgs","repos_url":"https://api.github.com/users/kendrahavens/repos","events_url":"https://api.github.com/users/kendrahavens/events{/privacy}","received_events_url":"https://api.github.com/users/kendrahavens/received_events","type":"User","site_admin":false},"repo":{"id":120655870,"name":"visualstudio-docs","full_name":"kendrahavens/visualstudio-docs","owner":{"login":"kendrahavens","id":8293542,"avatar_url":"https://avatars2.githubusercontent.com/u/8293542?v=4","gravatar_id":"","url":"https://api.github.com/users/kendrahavens","html_url":"https://github.com/kendrahavens","followers_url":"https://api.github.com/users/kendrahavens/followers","following_url":"https://api.github.com/users/kendrahavens/following{/other_user}","gists_url":"https://api.github.com/users/kendrahavens/gists{/gist_id}","starred_url":"https://api.github.com/users/kendrahavens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kendrahavens/subscriptions","organizations_url":"https://api.github.com/users/kendrahavens/orgs","repos_url":"https://api.github.com/users/kendrahavens/repos","events_url":"https://api.github.com/users/kendrahavens/events{/privacy}","received_events_url":"https://api.github.com/users/kendrahavens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kendrahavens/visualstudio-docs","description":"This repo is the home of the official Visual Studio, Visual Studio for Mac, Visual Studio Subscriptions, and Scripting Technologies documentation for Microsoft.","fork":true,"url":"https://api.github.com/repos/kendrahavens/visualstudio-docs","forks_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/forks","keys_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/teams","hooks_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/hooks","issue_events_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/issues/events{/number}","events_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/events","assignees_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/assignees{/user}","branches_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/branches{/branch}","tags_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/tags","blobs_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/languages","stargazers_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/stargazers","contributors_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/contributors","subscribers_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/subscribers","subscription_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/subscription","commits_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/contents/{+path}","compare_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/merges","archive_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/downloads","issues_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/issues{/number}","pulls_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/labels{/name}","releases_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/releases{/id}","deployments_url":"https://api.github.com/repos/kendrahavens/visualstudio-docs/deployments","created_at":"2018-02-07T18:42:51Z","updated_at":"2018-02-07T18:43:07Z","pushed_at":"2018-04-19T00:02:45Z","git_url":"git://github.com/kendrahavens/visualstudio-docs.git","ssh_url":"git@github.com:kendrahavens/visualstudio-docs.git","clone_url":"https://github.com/kendrahavens/visualstudio-docs.git","svn_url":"https://github.com/kendrahavens/visualstudio-docs","homepage":"","size":398702,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MicrosoftDocs:master","ref":"master","sha":"0fc959a8e873ed26f5a3e622999488f3c27e0ca7","user":{"login":"MicrosoftDocs","id":22479449,"avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"repo":{"id":73740273,"name":"visualstudio-docs","full_name":"MicrosoftDocs/visualstudio-docs","owner":{"login":"MicrosoftDocs","id":22479449,"avatar_url":"https://avatars2.githubusercontent.com/u/22479449?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftDocs","html_url":"https://github.com/MicrosoftDocs","followers_url":"https://api.github.com/users/MicrosoftDocs/followers","following_url":"https://api.github.com/users/MicrosoftDocs/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftDocs/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftDocs/orgs","repos_url":"https://api.github.com/users/MicrosoftDocs/repos","events_url":"https://api.github.com/users/MicrosoftDocs/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftDocs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MicrosoftDocs/visualstudio-docs","description":"This repo is the home of the official Visual Studio, Visual Studio for Mac, Visual Studio Subscriptions, and Scripting Technologies documentation for Microsoft.","fork":false,"url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs","forks_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/forks","keys_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/teams","hooks_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/hooks","issue_events_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues/events{/number}","events_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/events","assignees_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/assignees{/user}","branches_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/branches{/branch}","tags_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/tags","blobs_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/languages","stargazers_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/stargazers","contributors_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/contributors","subscribers_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/subscribers","subscription_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/subscription","commits_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/contents/{+path}","compare_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/merges","archive_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/downloads","issues_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues{/number}","pulls_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/labels{/name}","releases_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/releases{/id}","deployments_url":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/deployments","created_at":"2016-11-14T19:36:53Z","updated_at":"2018-04-19T19:30:24Z","pushed_at":"2018-04-19T19:45:11Z","git_url":"git://github.com/MicrosoftDocs/visualstudio-docs.git","ssh_url":"git@github.com:MicrosoftDocs/visualstudio-docs.git","clone_url":"https://github.com/MicrosoftDocs/visualstudio-docs.git","svn_url":"https://github.com/MicrosoftDocs/visualstudio-docs","homepage":"","size":398656,"stargazers_count":160,"watchers_count":160,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":416,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":416,"open_issues":118,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829"},"html":{"href":"https://github.com/MicrosoftDocs/visualstudio-docs/pull/829"},"issue":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues/829"},"comments":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/issues/829/comments"},"review_comments":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829/comments"},"review_comment":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/pulls/829/commits"},"statuses":{"href":"https://api.github.com/repos/MicrosoftDocs/visualstudio-docs/statuses/83772ef11d93d2bab706fd302f471bd678233f40"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gewarren"}}