{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18423","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18423/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18423/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18423/events","html_url":"https://github.com/magento/magento2/pull/18423","id":367470195,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODk0ODUw","number":18423,"title":"[BACKPORT] Use version_compare to compare version strings correctly","user":{"login":"lewisvoncken","id":6040343,"node_id":"MDQ6VXNlcjYwNDAzNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6040343?v=4","gravatar_id":"","url":"https://api.github.com/users/lewisvoncken","html_url":"https://github.com/lewisvoncken","followers_url":"https://api.github.com/users/lewisvoncken/followers","following_url":"https://api.github.com/users/lewisvoncken/following{/other_user}","gists_url":"https://api.github.com/users/lewisvoncken/gists{/gist_id}","starred_url":"https://api.github.com/users/lewisvoncken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewisvoncken/subscriptions","organizations_url":"https://api.github.com/users/lewisvoncken/orgs","repos_url":"https://api.github.com/users/lewisvoncken/repos","events_url":"https://api.github.com/users/lewisvoncken/events{/privacy}","received_events_url":"https://api.github.com/users/lewisvoncken/received_events","type":"User","site_admin":false},"labels":[{"id":964581182,"node_id":"MDU6TGFiZWw5NjQ1ODExODI=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Framework/Module","name":"Component: Framework/Module","color":"7fb703","default":false},{"id":1080899176,"node_id":"MDU6TGFiZWwxMDgwODk5MTc2","url":"https://api.github.com/repos/magento/magento2/labels/Event:%20squashtoberfest","name":"Event: squashtoberfest","color":"ededed","default":false},{"id":923849989,"node_id":"MDU6TGFiZWw5MjM4NDk5ODk=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Experius","name":"Partner: Experius","color":"f9d0c4","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-06T15:59:37Z","updated_at":"2018-10-07T10:12:28Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18423","html_url":"https://github.com/magento/magento2/pull/18423","diff_url":"https://github.com/magento/magento2/pull/18423.diff","patch_url":"https://github.com/magento/magento2/pull/18423.patch"},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\nBackport of PR #18173\r\n\r\nVersion numbers were compared with regular alphanumeric string comparison `<`, which results in `1.10 < 1.9`. Instead, `version_compare` should be used\r\n\r\n### Manual testing scenarios\r\n1. Update a module from version 1.9.0 to 1.10.0 and open the shop in the browser\r\n2. Expected message: \"run setup:upgrade\", not \"run composer install\"\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/427641342","html_url":"https://github.com/magento/magento2/pull/18423#issuecomment-427641342","issue_url":"https://api.github.com/repos/magento/magento2/issues/18423","id":427641342,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY0MTM0Mg==","user":{"login":"okorshenko","id":7325075,"node_id":"MDQ6VXNlcjczMjUwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/7325075?v=4","gravatar_id":"","url":"https://api.github.com/users/okorshenko","html_url":"https://github.com/okorshenko","followers_url":"https://api.github.com/users/okorshenko/followers","following_url":"https://api.github.com/users/okorshenko/following{/other_user}","gists_url":"https://api.github.com/users/okorshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/okorshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okorshenko/subscriptions","organizations_url":"https://api.github.com/users/okorshenko/orgs","repos_url":"https://api.github.com/users/okorshenko/repos","events_url":"https://api.github.com/users/okorshenko/events{/privacy}","received_events_url":"https://api.github.com/users/okorshenko/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T10:12:28Z","updated_at":"2018-10-07T10:12:28Z","author_association":"CONTRIBUTOR","body":"Hi @lewisvoncken \r\nPlease look at the broken tests. Thank you"}}
{"actor":{"display_login":"okorshenko"}}