{"action":"created","comment":{"url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments/174279786","pull_request_review_id":103607499,"id":174279786,"diff_hunk":"@@ -6,13 +6,10 @@ it should be added here as a variable. Changing the value\n of these variables will affect the colors sitewide. */\n $futura-regular: \"futura-pt\", Arial, sans-serif;\n $futura-condensed: \"futura-pt-condensed\", Arial, sans-serif;\n-$proxima-nova: \"proxima-nova\", Arial, sans-serif;\n $arial: Arial, sans-serif;\n \n-$font-stack-body: $proxima-nova;\n-$font-stack-body-new: $arial;\n+$font-stack-body: $arial;\n $font-stack-heading: $futura-regular;","path":"app/assets/stylesheets/base/variables.scss","position":10,"original_position":10,"commit_id":"56ad3e399126ee8a827919f5f032178875145ba8","original_commit_id":"c72f340553f5f97fd715c86703943cecbe5ce8f0","user":{"login":"mandythomas","id":7851724,"avatar_url":"https://avatars0.githubusercontent.com/u/7851724?v=4","gravatar_id":"","url":"https://api.github.com/users/mandythomas","html_url":"https://github.com/mandythomas","followers_url":"https://api.github.com/users/mandythomas/followers","following_url":"https://api.github.com/users/mandythomas/following{/other_user}","gists_url":"https://api.github.com/users/mandythomas/gists{/gist_id}","starred_url":"https://api.github.com/users/mandythomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandythomas/subscriptions","organizations_url":"https://api.github.com/users/mandythomas/orgs","repos_url":"https://api.github.com/users/mandythomas/repos","events_url":"https://api.github.com/users/mandythomas/events{/privacy}","received_events_url":"https://api.github.com/users/mandythomas/received_events","type":"User","site_admin":false},"body":"I talked to Ross about where the condensed font is used, trying to see if we could have a variable name in the scss that better described it's purpose than the -emphasis in $font-stack-heading-emphasis. He said it's mostly for the homepage for those short 2-word headings at the top of the Hero Panel and the Undergraduate Facts panel eg. the Experiment Boldly phrase. I'm drawing a blank on the right word to describe that so unless Kayla objects or has a better suggestion I guess just leave it at $font-stack-heading-emphasis.","created_at":"2018-03-13T20:51:14Z","updated_at":"2018-03-13T20:51:14Z","html_url":"https://github.com/chapmanu/cascade-assets/pull/325#discussion_r174279786","pull_request_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments/174279786"},"html":{"href":"https://github.com/chapmanu/cascade-assets/pull/325#discussion_r174279786"},"pull_request":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325"}},"in_reply_to_id":173973153},"pull_request":{"url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325","id":174459061,"html_url":"https://github.com/chapmanu/cascade-assets/pull/325","diff_url":"https://github.com/chapmanu/cascade-assets/pull/325.diff","patch_url":"https://github.com/chapmanu/cascade-assets/pull/325.patch","issue_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/325","number":325,"state":"open","locked":false,"title":"Remove Proxima Nova and Verdana","user":{"login":"sharissis-brei","id":7881244,"avatar_url":"https://avatars1.githubusercontent.com/u/7881244?v=4","gravatar_id":"","url":"https://api.github.com/users/sharissis-brei","html_url":"https://github.com/sharissis-brei","followers_url":"https://api.github.com/users/sharissis-brei/followers","following_url":"https://api.github.com/users/sharissis-brei/following{/other_user}","gists_url":"https://api.github.com/users/sharissis-brei/gists{/gist_id}","starred_url":"https://api.github.com/users/sharissis-brei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharissis-brei/subscriptions","organizations_url":"https://api.github.com/users/sharissis-brei/orgs","repos_url":"https://api.github.com/users/sharissis-brei/repos","events_url":"https://api.github.com/users/sharissis-brei/events{/privacy}","received_events_url":"https://api.github.com/users/sharissis-brei/received_events","type":"User","site_admin":false},"body":"- Removed all instances of Proxima Nova and Verdana in CSS used on site\r\n- Removed and replaced font variables prefixed with \"new\"\r\n- Removed \"new-font-theme\" from body tag in local template files","created_at":"2018-03-12T18:39:35Z","updated_at":"2018-03-13T20:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56d029a8903fa29bff0c5f03bc644fbb53342c74","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mandythomas","id":7851724,"avatar_url":"https://avatars0.githubusercontent.com/u/7851724?v=4","gravatar_id":"","url":"https://api.github.com/users/mandythomas","html_url":"https://github.com/mandythomas","followers_url":"https://api.github.com/users/mandythomas/followers","following_url":"https://api.github.com/users/mandythomas/following{/other_user}","gists_url":"https://api.github.com/users/mandythomas/gists{/gist_id}","starred_url":"https://api.github.com/users/mandythomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandythomas/subscriptions","organizations_url":"https://api.github.com/users/mandythomas/orgs","repos_url":"https://api.github.com/users/mandythomas/repos","events_url":"https://api.github.com/users/mandythomas/events{/privacy}","received_events_url":"https://api.github.com/users/mandythomas/received_events","type":"User","site_admin":false},{"login":"cbryant24","id":29960336,"avatar_url":"https://avatars1.githubusercontent.com/u/29960336?v=4","gravatar_id":"","url":"https://api.github.com/users/cbryant24","html_url":"https://github.com/cbryant24","followers_url":"https://api.github.com/users/cbryant24/followers","following_url":"https://api.github.com/users/cbryant24/following{/other_user}","gists_url":"https://api.github.com/users/cbryant24/gists{/gist_id}","starred_url":"https://api.github.com/users/cbryant24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbryant24/subscriptions","organizations_url":"https://api.github.com/users/cbryant24/orgs","repos_url":"https://api.github.com/users/cbryant24/repos","events_url":"https://api.github.com/users/cbryant24/events{/privacy}","received_events_url":"https://api.github.com/users/cbryant24/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325/commits","review_comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325/comments","review_comment_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/325/comments","statuses_url":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/56ad3e399126ee8a827919f5f032178875145ba8","head":{"label":"sharissis-brei:remove-proxima-nova-and-verdana","ref":"remove-proxima-nova-and-verdana","sha":"56ad3e399126ee8a827919f5f032178875145ba8","user":{"login":"sharissis-brei","id":7881244,"avatar_url":"https://avatars1.githubusercontent.com/u/7881244?v=4","gravatar_id":"","url":"https://api.github.com/users/sharissis-brei","html_url":"https://github.com/sharissis-brei","followers_url":"https://api.github.com/users/sharissis-brei/followers","following_url":"https://api.github.com/users/sharissis-brei/following{/other_user}","gists_url":"https://api.github.com/users/sharissis-brei/gists{/gist_id}","starred_url":"https://api.github.com/users/sharissis-brei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharissis-brei/subscriptions","organizations_url":"https://api.github.com/users/sharissis-brei/orgs","repos_url":"https://api.github.com/users/sharissis-brei/repos","events_url":"https://api.github.com/users/sharissis-brei/events{/privacy}","received_events_url":"https://api.github.com/users/sharissis-brei/received_events","type":"User","site_admin":false},"repo":{"id":115124193,"name":"cascade-assets","full_name":"sharissis-brei/cascade-assets","owner":{"login":"sharissis-brei","id":7881244,"avatar_url":"https://avatars1.githubusercontent.com/u/7881244?v=4","gravatar_id":"","url":"https://api.github.com/users/sharissis-brei","html_url":"https://github.com/sharissis-brei","followers_url":"https://api.github.com/users/sharissis-brei/followers","following_url":"https://api.github.com/users/sharissis-brei/following{/other_user}","gists_url":"https://api.github.com/users/sharissis-brei/gists{/gist_id}","starred_url":"https://api.github.com/users/sharissis-brei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharissis-brei/subscriptions","organizations_url":"https://api.github.com/users/sharissis-brei/orgs","repos_url":"https://api.github.com/users/sharissis-brei/repos","events_url":"https://api.github.com/users/sharissis-brei/events{/privacy}","received_events_url":"https://api.github.com/users/sharissis-brei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharissis-brei/cascade-assets","description":"Manage assets outside of cascade.","fork":true,"url":"https://api.github.com/repos/sharissis-brei/cascade-assets","forks_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/forks","keys_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/teams","hooks_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/hooks","issue_events_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/issues/events{/number}","events_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/events","assignees_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/assignees{/user}","branches_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/branches{/branch}","tags_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/tags","blobs_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/statuses/{sha}","languages_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/languages","stargazers_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/stargazers","contributors_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/contributors","subscribers_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/subscribers","subscription_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/subscription","commits_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/contents/{+path}","compare_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/merges","archive_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/downloads","issues_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/issues{/number}","pulls_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/pulls{/number}","milestones_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/milestones{/number}","notifications_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/labels{/name}","releases_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/releases{/id}","deployments_url":"https://api.github.com/repos/sharissis-brei/cascade-assets/deployments","created_at":"2017-12-22T14:48:42Z","updated_at":"2017-12-22T14:48:46Z","pushed_at":"2018-03-13T20:50:35Z","git_url":"git://github.com/sharissis-brei/cascade-assets.git","ssh_url":"git@github.com:sharissis-brei/cascade-assets.git","clone_url":"https://github.com/sharissis-brei/cascade-assets.git","svn_url":"https://github.com/sharissis-brei/cascade-assets","homepage":null,"size":37101,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"chapmanu:development","ref":"development","sha":"ffd29121b9ea409738f78bd0a37af60f416fe4bf","user":{"login":"chapmanu","id":5008659,"avatar_url":"https://avatars0.githubusercontent.com/u/5008659?v=4","gravatar_id":"","url":"https://api.github.com/users/chapmanu","html_url":"https://github.com/chapmanu","followers_url":"https://api.github.com/users/chapmanu/followers","following_url":"https://api.github.com/users/chapmanu/following{/other_user}","gists_url":"https://api.github.com/users/chapmanu/gists{/gist_id}","starred_url":"https://api.github.com/users/chapmanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapmanu/subscriptions","organizations_url":"https://api.github.com/users/chapmanu/orgs","repos_url":"https://api.github.com/users/chapmanu/repos","events_url":"https://api.github.com/users/chapmanu/events{/privacy}","received_events_url":"https://api.github.com/users/chapmanu/received_events","type":"Organization","site_admin":false},"repo":{"id":31608435,"name":"cascade-assets","full_name":"chapmanu/cascade-assets","owner":{"login":"chapmanu","id":5008659,"avatar_url":"https://avatars0.githubusercontent.com/u/5008659?v=4","gravatar_id":"","url":"https://api.github.com/users/chapmanu","html_url":"https://github.com/chapmanu","followers_url":"https://api.github.com/users/chapmanu/followers","following_url":"https://api.github.com/users/chapmanu/following{/other_user}","gists_url":"https://api.github.com/users/chapmanu/gists{/gist_id}","starred_url":"https://api.github.com/users/chapmanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapmanu/subscriptions","organizations_url":"https://api.github.com/users/chapmanu/orgs","repos_url":"https://api.github.com/users/chapmanu/repos","events_url":"https://api.github.com/users/chapmanu/events{/privacy}","received_events_url":"https://api.github.com/users/chapmanu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapmanu/cascade-assets","description":"Manage assets outside of cascade.","fork":false,"url":"https://api.github.com/repos/chapmanu/cascade-assets","forks_url":"https://api.github.com/repos/chapmanu/cascade-assets/forks","keys_url":"https://api.github.com/repos/chapmanu/cascade-assets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapmanu/cascade-assets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapmanu/cascade-assets/teams","hooks_url":"https://api.github.com/repos/chapmanu/cascade-assets/hooks","issue_events_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/events{/number}","events_url":"https://api.github.com/repos/chapmanu/cascade-assets/events","assignees_url":"https://api.github.com/repos/chapmanu/cascade-assets/assignees{/user}","branches_url":"https://api.github.com/repos/chapmanu/cascade-assets/branches{/branch}","tags_url":"https://api.github.com/repos/chapmanu/cascade-assets/tags","blobs_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/{sha}","languages_url":"https://api.github.com/repos/chapmanu/cascade-assets/languages","stargazers_url":"https://api.github.com/repos/chapmanu/cascade-assets/stargazers","contributors_url":"https://api.github.com/repos/chapmanu/cascade-assets/contributors","subscribers_url":"https://api.github.com/repos/chapmanu/cascade-assets/subscribers","subscription_url":"https://api.github.com/repos/chapmanu/cascade-assets/subscription","commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapmanu/cascade-assets/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapmanu/cascade-assets/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapmanu/cascade-assets/contents/{+path}","compare_url":"https://api.github.com/repos/chapmanu/cascade-assets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapmanu/cascade-assets/merges","archive_url":"https://api.github.com/repos/chapmanu/cascade-assets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapmanu/cascade-assets/downloads","issues_url":"https://api.github.com/repos/chapmanu/cascade-assets/issues{/number}","pulls_url":"https://api.github.com/repos/chapmanu/cascade-assets/pulls{/number}","milestones_url":"https://api.github.com/repos/chapmanu/cascade-assets/milestones{/number}","notifications_url":"https://api.github.com/repos/chapmanu/cascade-assets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapmanu/cascade-assets/labels{/name}","releases_url":"https://api.github.com/repos/chapmanu/cascade-assets/releases{/id}","deployments_url":"https://api.github.com/repos/chapmanu/cascade-assets/deployments","created_at":"2015-03-03T16:26:42Z","updated_at":"2018-03-13T16:38:45Z","pushed_at":"2018-03-13T20:50:36Z","git_url":"git://github.com/chapmanu/cascade-assets.git","ssh_url":"git@github.com:chapmanu/cascade-assets.git","clone_url":"https://github.com/chapmanu/cascade-assets.git","svn_url":"https://github.com/chapmanu/cascade-assets","homepage":null,"size":34956,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325"},"html":{"href":"https://github.com/chapmanu/cascade-assets/pull/325"},"issue":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/issues/325"},"comments":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/chapmanu/cascade-assets/statuses/56ad3e399126ee8a827919f5f032178875145ba8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mandythomas"}}