{"action":"created","comment":{"url":"https://api.github.com/repos/Unidata/MetPy/pulls/comments/192251908","pull_request_review_id":124993564,"id":192251908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI1MTkwOA==","diff_hunk":"@@ -114,8 +123,8 @@ def wind_components(speed, wdir):\n \n     \"\"\"\n     wdir = _check_radians(wdir, max_radians=4 * np.pi)\n-    u = -speed * np.sin(wdir)\n-    v = -speed * np.cos(wdir)\n+    u = np.nan_to_num(-speed.magnitude * np.sin(wdir)) * speed.units","path":"metpy/calc/basic.py","position":113,"original_position":68,"commit_id":"cc7f22c2a70b5b83015c97cc3086cfcc5bf5b1b7","original_commit_id":"cc7f22c2a70b5b83015c97cc3086cfcc5bf5b1b7","user":{"login":"jthielen","id":3460034,"node_id":"MDQ6VXNlcjM0NjAwMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3460034?v=4","gravatar_id":"","url":"https://api.github.com/users/jthielen","html_url":"https://github.com/jthielen","followers_url":"https://api.github.com/users/jthielen/followers","following_url":"https://api.github.com/users/jthielen/following{/other_user}","gists_url":"https://api.github.com/users/jthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/jthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthielen/subscriptions","organizations_url":"https://api.github.com/users/jthielen/orgs","repos_url":"https://api.github.com/users/jthielen/repos","events_url":"https://api.github.com/users/jthielen/events{/privacy}","received_events_url":"https://api.github.com/users/jthielen/received_events","type":"User","site_admin":false},"body":"This is trying to handle wind directions of NaN for calm winds. Looking at it again, I think I should just wrap the direction, not the full product, which should also solve the quantity/series issue. But, if we just have the calm->0, north->360 like mentioned above, we wouldn't have to worry about it?","created_at":"2018-05-31T22:07:34Z","updated_at":"2018-05-31T22:07:34Z","html_url":"https://github.com/Unidata/MetPy/pull/868#discussion_r192251908","pull_request_url":"https://api.github.com/repos/Unidata/MetPy/pulls/868","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/comments/192251908"},"html":{"href":"https://github.com/Unidata/MetPy/pull/868#discussion_r192251908"},"pull_request":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/868"}},"in_reply_to_id":192185968},"pull_request":{"url":"https://api.github.com/repos/Unidata/MetPy/pulls/868","id":191579142,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTc5MTQy","html_url":"https://github.com/Unidata/MetPy/pull/868","diff_url":"https://github.com/Unidata/MetPy/pull/868.diff","patch_url":"https://github.com/Unidata/MetPy/pull/868.patch","issue_url":"https://api.github.com/repos/Unidata/MetPy/issues/868","number":868,"state":"open","locked":false,"title":"Update Wind Functions","user":{"login":"jthielen","id":3460034,"node_id":"MDQ6VXNlcjM0NjAwMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3460034?v=4","gravatar_id":"","url":"https://api.github.com/users/jthielen","html_url":"https://github.com/jthielen","followers_url":"https://api.github.com/users/jthielen/followers","following_url":"https://api.github.com/users/jthielen/following{/other_user}","gists_url":"https://api.github.com/users/jthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/jthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthielen/subscriptions","organizations_url":"https://api.github.com/users/jthielen/orgs","repos_url":"https://api.github.com/users/jthielen/repos","events_url":"https://api.github.com/users/jthielen/events{/privacy}","received_events_url":"https://api.github.com/users/jthielen/received_events","type":"User","site_admin":false},"body":"This PR addresses two issues relating to the wind functions in `calc/basics.py`. First, fixes #865 by renaming the functions as described in the issue and deprecating the old functions. Additionally, fixes #794 by adding a flag to specify the behavior for `wind_direction` (formerly `get_wind_dir`) in regards to calm and north winds.\r\n\r\nAlso, I think that we will need to open a \"Removals/Deprecations in 0.12\" issue once the renaming goes through.\r\n\r\nFeedback, especially on the approach of handling the calm and north wind issue, is greatly appreciated!","created_at":"2018-05-30T20:59:33Z","updated_at":"2018-05-31T22:07:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66d319de24be6fc24e17c9f6f80ecf3556909088","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jrleeman","id":325269,"node_id":"MDQ6VXNlcjMyNTI2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/325269?v=4","gravatar_id":"","url":"https://api.github.com/users/jrleeman","html_url":"https://github.com/jrleeman","followers_url":"https://api.github.com/users/jrleeman/followers","following_url":"https://api.github.com/users/jrleeman/following{/other_user}","gists_url":"https://api.github.com/users/jrleeman/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleeman/subscriptions","organizations_url":"https://api.github.com/users/jrleeman/orgs","repos_url":"https://api.github.com/users/jrleeman/repos","events_url":"https://api.github.com/users/jrleeman/events{/privacy}","received_events_url":"https://api.github.com/users/jrleeman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":317073835,"node_id":"MDU6TGFiZWwzMTcwNzM4MzU=","url":"https://api.github.com/repos/Unidata/MetPy/labels/Area:%20Calc","name":"Area: Calc","color":"c7def8","default":false},{"id":442808479,"node_id":"MDU6TGFiZWw0NDI4MDg0Nzk=","url":"https://api.github.com/repos/Unidata/MetPy/labels/Type:%20API%20Change","name":"Type: API Change","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/Unidata/MetPy/milestones/17","html_url":"https://github.com/Unidata/MetPy/milestone/17","labels_url":"https://api.github.com/repos/Unidata/MetPy/milestones/17/labels","id":2980564,"node_id":"MDk6TWlsZXN0b25lMjk4MDU2NA==","number":17,"title":"0.9","description":"MetPy 0.9 - Summer 2018 Release Estimated","creator":{"login":"jrleeman","id":325269,"node_id":"MDQ6VXNlcjMyNTI2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/325269?v=4","gravatar_id":"","url":"https://api.github.com/users/jrleeman","html_url":"https://github.com/jrleeman","followers_url":"https://api.github.com/users/jrleeman/followers","following_url":"https://api.github.com/users/jrleeman/following{/other_user}","gists_url":"https://api.github.com/users/jrleeman/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleeman/subscriptions","organizations_url":"https://api.github.com/users/jrleeman/orgs","repos_url":"https://api.github.com/users/jrleeman/repos","events_url":"https://api.github.com/users/jrleeman/events{/privacy}","received_events_url":"https://api.github.com/users/jrleeman/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":0,"state":"open","created_at":"2017-12-14T19:34:07Z","updated_at":"2018-05-31T17:48:56Z","due_on":"2018-08-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Unidata/MetPy/pulls/868/commits","review_comments_url":"https://api.github.com/repos/Unidata/MetPy/pulls/868/comments","review_comment_url":"https://api.github.com/repos/Unidata/MetPy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unidata/MetPy/issues/868/comments","statuses_url":"https://api.github.com/repos/Unidata/MetPy/statuses/cc7f22c2a70b5b83015c97cc3086cfcc5bf5b1b7","head":{"label":"jthielen:update-wind-functions","ref":"update-wind-functions","sha":"cc7f22c2a70b5b83015c97cc3086cfcc5bf5b1b7","user":{"login":"jthielen","id":3460034,"node_id":"MDQ6VXNlcjM0NjAwMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3460034?v=4","gravatar_id":"","url":"https://api.github.com/users/jthielen","html_url":"https://github.com/jthielen","followers_url":"https://api.github.com/users/jthielen/followers","following_url":"https://api.github.com/users/jthielen/following{/other_user}","gists_url":"https://api.github.com/users/jthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/jthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthielen/subscriptions","organizations_url":"https://api.github.com/users/jthielen/orgs","repos_url":"https://api.github.com/users/jthielen/repos","events_url":"https://api.github.com/users/jthielen/events{/privacy}","received_events_url":"https://api.github.com/users/jthielen/received_events","type":"User","site_admin":false},"repo":{"id":108058581,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwNTg1ODE=","name":"MetPy","full_name":"jthielen/MetPy","owner":{"login":"jthielen","id":3460034,"node_id":"MDQ6VXNlcjM0NjAwMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3460034?v=4","gravatar_id":"","url":"https://api.github.com/users/jthielen","html_url":"https://github.com/jthielen","followers_url":"https://api.github.com/users/jthielen/followers","following_url":"https://api.github.com/users/jthielen/following{/other_user}","gists_url":"https://api.github.com/users/jthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/jthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthielen/subscriptions","organizations_url":"https://api.github.com/users/jthielen/orgs","repos_url":"https://api.github.com/users/jthielen/repos","events_url":"https://api.github.com/users/jthielen/events{/privacy}","received_events_url":"https://api.github.com/users/jthielen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jthielen/MetPy","description":"MetPy is a collection of tools in Python for reading, visualizing and performing calculations with weather data.","fork":true,"url":"https://api.github.com/repos/jthielen/MetPy","forks_url":"https://api.github.com/repos/jthielen/MetPy/forks","keys_url":"https://api.github.com/repos/jthielen/MetPy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jthielen/MetPy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jthielen/MetPy/teams","hooks_url":"https://api.github.com/repos/jthielen/MetPy/hooks","issue_events_url":"https://api.github.com/repos/jthielen/MetPy/issues/events{/number}","events_url":"https://api.github.com/repos/jthielen/MetPy/events","assignees_url":"https://api.github.com/repos/jthielen/MetPy/assignees{/user}","branches_url":"https://api.github.com/repos/jthielen/MetPy/branches{/branch}","tags_url":"https://api.github.com/repos/jthielen/MetPy/tags","blobs_url":"https://api.github.com/repos/jthielen/MetPy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jthielen/MetPy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jthielen/MetPy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jthielen/MetPy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jthielen/MetPy/statuses/{sha}","languages_url":"https://api.github.com/repos/jthielen/MetPy/languages","stargazers_url":"https://api.github.com/repos/jthielen/MetPy/stargazers","contributors_url":"https://api.github.com/repos/jthielen/MetPy/contributors","subscribers_url":"https://api.github.com/repos/jthielen/MetPy/subscribers","subscription_url":"https://api.github.com/repos/jthielen/MetPy/subscription","commits_url":"https://api.github.com/repos/jthielen/MetPy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jthielen/MetPy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jthielen/MetPy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jthielen/MetPy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jthielen/MetPy/contents/{+path}","compare_url":"https://api.github.com/repos/jthielen/MetPy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jthielen/MetPy/merges","archive_url":"https://api.github.com/repos/jthielen/MetPy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jthielen/MetPy/downloads","issues_url":"https://api.github.com/repos/jthielen/MetPy/issues{/number}","pulls_url":"https://api.github.com/repos/jthielen/MetPy/pulls{/number}","milestones_url":"https://api.github.com/repos/jthielen/MetPy/milestones{/number}","notifications_url":"https://api.github.com/repos/jthielen/MetPy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jthielen/MetPy/labels{/name}","releases_url":"https://api.github.com/repos/jthielen/MetPy/releases{/id}","deployments_url":"https://api.github.com/repos/jthielen/MetPy/deployments","created_at":"2017-10-24T00:56:00Z","updated_at":"2018-05-21T16:14:45Z","pushed_at":"2018-05-30T20:50:59Z","git_url":"git://github.com/jthielen/MetPy.git","ssh_url":"git@github.com:jthielen/MetPy.git","clone_url":"https://github.com/jthielen/MetPy.git","svn_url":"https://github.com/jthielen/MetPy","homepage":"https://unidata.github.io/MetPy","size":173567,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Unidata:master","ref":"master","sha":"987935135ac4770bd39c2902d48643866f29ef7e","user":{"login":"Unidata","id":613345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzM0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/613345?v=4","gravatar_id":"","url":"https://api.github.com/users/Unidata","html_url":"https://github.com/Unidata","followers_url":"https://api.github.com/users/Unidata/followers","following_url":"https://api.github.com/users/Unidata/following{/other_user}","gists_url":"https://api.github.com/users/Unidata/gists{/gist_id}","starred_url":"https://api.github.com/users/Unidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unidata/subscriptions","organizations_url":"https://api.github.com/users/Unidata/orgs","repos_url":"https://api.github.com/users/Unidata/repos","events_url":"https://api.github.com/users/Unidata/events{/privacy}","received_events_url":"https://api.github.com/users/Unidata/received_events","type":"Organization","site_admin":false},"repo":{"id":1409621,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA5NjIx","name":"MetPy","full_name":"Unidata/MetPy","owner":{"login":"Unidata","id":613345,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzM0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/613345?v=4","gravatar_id":"","url":"https://api.github.com/users/Unidata","html_url":"https://github.com/Unidata","followers_url":"https://api.github.com/users/Unidata/followers","following_url":"https://api.github.com/users/Unidata/following{/other_user}","gists_url":"https://api.github.com/users/Unidata/gists{/gist_id}","starred_url":"https://api.github.com/users/Unidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unidata/subscriptions","organizations_url":"https://api.github.com/users/Unidata/orgs","repos_url":"https://api.github.com/users/Unidata/repos","events_url":"https://api.github.com/users/Unidata/events{/privacy}","received_events_url":"https://api.github.com/users/Unidata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unidata/MetPy","description":"MetPy is a collection of tools in Python for reading, visualizing and performing calculations with weather data.","fork":false,"url":"https://api.github.com/repos/Unidata/MetPy","forks_url":"https://api.github.com/repos/Unidata/MetPy/forks","keys_url":"https://api.github.com/repos/Unidata/MetPy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unidata/MetPy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unidata/MetPy/teams","hooks_url":"https://api.github.com/repos/Unidata/MetPy/hooks","issue_events_url":"https://api.github.com/repos/Unidata/MetPy/issues/events{/number}","events_url":"https://api.github.com/repos/Unidata/MetPy/events","assignees_url":"https://api.github.com/repos/Unidata/MetPy/assignees{/user}","branches_url":"https://api.github.com/repos/Unidata/MetPy/branches{/branch}","tags_url":"https://api.github.com/repos/Unidata/MetPy/tags","blobs_url":"https://api.github.com/repos/Unidata/MetPy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unidata/MetPy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unidata/MetPy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unidata/MetPy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unidata/MetPy/statuses/{sha}","languages_url":"https://api.github.com/repos/Unidata/MetPy/languages","stargazers_url":"https://api.github.com/repos/Unidata/MetPy/stargazers","contributors_url":"https://api.github.com/repos/Unidata/MetPy/contributors","subscribers_url":"https://api.github.com/repos/Unidata/MetPy/subscribers","subscription_url":"https://api.github.com/repos/Unidata/MetPy/subscription","commits_url":"https://api.github.com/repos/Unidata/MetPy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unidata/MetPy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unidata/MetPy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unidata/MetPy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unidata/MetPy/contents/{+path}","compare_url":"https://api.github.com/repos/Unidata/MetPy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unidata/MetPy/merges","archive_url":"https://api.github.com/repos/Unidata/MetPy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unidata/MetPy/downloads","issues_url":"https://api.github.com/repos/Unidata/MetPy/issues{/number}","pulls_url":"https://api.github.com/repos/Unidata/MetPy/pulls{/number}","milestones_url":"https://api.github.com/repos/Unidata/MetPy/milestones{/number}","notifications_url":"https://api.github.com/repos/Unidata/MetPy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unidata/MetPy/labels{/name}","releases_url":"https://api.github.com/repos/Unidata/MetPy/releases{/id}","deployments_url":"https://api.github.com/repos/Unidata/MetPy/deployments","created_at":"2011-02-25T04:20:25Z","updated_at":"2018-05-28T13:53:01Z","pushed_at":"2018-05-31T00:51:26Z","git_url":"git://github.com/Unidata/MetPy.git","ssh_url":"git@github.com:Unidata/MetPy.git","clone_url":"https://github.com/Unidata/MetPy.git","svn_url":"https://github.com/Unidata/MetPy","homepage":"https://unidata.github.io/MetPy","size":199890,"stargazers_count":283,"watchers_count":283,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":134,"open_issues":163,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/868"},"html":{"href":"https://github.com/Unidata/MetPy/pull/868"},"issue":{"href":"https://api.github.com/repos/Unidata/MetPy/issues/868"},"comments":{"href":"https://api.github.com/repos/Unidata/MetPy/issues/868/comments"},"review_comments":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/868/comments"},"review_comment":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/868/commits"},"statuses":{"href":"https://api.github.com/repos/Unidata/MetPy/statuses/cc7f22c2a70b5b83015c97cc3086cfcc5bf5b1b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jthielen"}}