{"action":"created","comment":{"url":"https://api.github.com/repos/elm-explorations/test/pulls/comments/189442318","pull_request_review_id":121626969,"id":189442318,"diff_hunk":"@@ -94,19 +95,19 @@ tests =\n     , Test.concat\n         [ fuzz int \"top-level fuzz tests don't affect subsequent top-level fuzz tests, since they use their labels to get different seeds\" <|\n             \\num ->\n-                Expect.equal num 409469537\n+                Expect.equal num -8\n         , describe \"Seed test\"\n             [ fuzzTest ]\n         , describe \"another top-level fuzz test\"\n             [ fuzz int \"it still gets different values, due to computing the seed as a hash of the label, and these labels must be unique\" <|\n                 \\num ->\n-                    Expect.equal num 0\n+                    Expect.equal num -1079557009","path":"tests/src/SeedTests.elm","position":40,"original_position":40,"commit_id":"cdd1efa51753f255a464fcbb510604925a8492cb","original_commit_id":"ab1ee071ac48259b2b8a77e2dcd7ebac5b8b35d8","user":{"login":"mgold","id":1191970,"avatar_url":"https://avatars3.githubusercontent.com/u/1191970?v=4","gravatar_id":"","url":"https://api.github.com/users/mgold","html_url":"https://github.com/mgold","followers_url":"https://api.github.com/users/mgold/followers","following_url":"https://api.github.com/users/mgold/following{/other_user}","gists_url":"https://api.github.com/users/mgold/gists{/gist_id}","starred_url":"https://api.github.com/users/mgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgold/subscriptions","organizations_url":"https://api.github.com/users/mgold/orgs","repos_url":"https://api.github.com/users/mgold/repos","events_url":"https://api.github.com/users/mgold/events{/privacy}","received_events_url":"https://api.github.com/users/mgold/received_events","type":"User","site_admin":false},"body":"I know it has to do with [generating the seeds based on a hash of the descriptions](https://github.com/elm-community/elm-test/issues/238#issuecomment-386096275). Whether zero is important or not, I don't know.","created_at":"2018-05-19T19:02:37Z","updated_at":"2018-05-19T19:04:07Z","html_url":"https://github.com/elm-explorations/test/pull/3#discussion_r189442318","pull_request_url":"https://api.github.com/repos/elm-explorations/test/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elm-explorations/test/pulls/comments/189442318"},"html":{"href":"https://github.com/elm-explorations/test/pull/3#discussion_r189442318"},"pull_request":{"href":"https://api.github.com/repos/elm-explorations/test/pulls/3"}},"in_reply_to_id":189441160},"pull_request":{"url":"https://api.github.com/repos/elm-explorations/test/pulls/3","id":189156083,"html_url":"https://github.com/elm-explorations/test/pull/3","diff_url":"https://github.com/elm-explorations/test/pull/3.diff","patch_url":"https://github.com/elm-explorations/test/pull/3.patch","issue_url":"https://api.github.com/repos/elm-explorations/test/issues/3","number":3,"state":"open","locked":false,"title":"Tests pass in Elm 0.19 (and implements `toString`)","user":{"login":"avh4","id":1222,"avatar_url":"https://avatars1.githubusercontent.com/u/1222?v=4","gravatar_id":"","url":"https://api.github.com/users/avh4","html_url":"https://github.com/avh4","followers_url":"https://api.github.com/users/avh4/followers","following_url":"https://api.github.com/users/avh4/following{/other_user}","gists_url":"https://api.github.com/users/avh4/gists{/gist_id}","starred_url":"https://api.github.com/users/avh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avh4/subscriptions","organizations_url":"https://api.github.com/users/avh4/orgs","repos_url":"https://api.github.com/users/avh4/repos","events_url":"https://api.github.com/users/avh4/events{/privacy}","received_events_url":"https://api.github.com/users/avh4/received_events","type":"User","site_admin":false},"body":"Depends on #2; this PR starts at 18444a9\r\n\r\n~This seems to be blocked by Platform.worker triggering a compiler bug: https://github.com/elm-lang/elm-compiler/issues/1706~\r\n\r\n~It appears that `elm make` only allows package projects to contain kernel code (since application projects don't have a name, so it doesn't know we're an elm-explorations project); so this tries to convert the tests to a package project, but that means we can't have multiple source-directories, so a bunch of symlinks into ../src/* are added.  With `Main.main = Platform.worker` commented out (see https://github.com/elm-lang/elm-compiler/issues/1706), everything compiles, but `elm make` doesn't write an output file if there's no `main`!~\r\n\r\n  - [x] change `Main.main` to be a Browser.program (or wait for https://github.com/elm-lang/elm-compiler/issues/1706 to be fixed), then we should be able to get an output js file, and try to run it in node or have a js file that calls something in the compiled elm js to evaluate the tests.\r\n  - [x] uncomment the SeedTests (in Main.elm), and\r\n     - [x] figure out why it doesn't print the name of the failing tests\r\n     - [x] figure out why some tests are failing","created_at":"2018-05-18T23:31:26Z","updated_at":"2018-05-19T19:04:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9de483f9bf8fa73f6e3bd05053f4d35c5b489628","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elm-explorations/test/pulls/3/commits","review_comments_url":"https://api.github.com/repos/elm-explorations/test/pulls/3/comments","review_comment_url":"https://api.github.com/repos/elm-explorations/test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elm-explorations/test/issues/3/comments","statuses_url":"https://api.github.com/repos/elm-explorations/test/statuses/cdd1efa51753f255a464fcbb510604925a8492cb","head":{"label":"avh4:tests-run-0.19","ref":"tests-run-0.19","sha":"cdd1efa51753f255a464fcbb510604925a8492cb","user":{"login":"avh4","id":1222,"avatar_url":"https://avatars1.githubusercontent.com/u/1222?v=4","gravatar_id":"","url":"https://api.github.com/users/avh4","html_url":"https://github.com/avh4","followers_url":"https://api.github.com/users/avh4/followers","following_url":"https://api.github.com/users/avh4/following{/other_user}","gists_url":"https://api.github.com/users/avh4/gists{/gist_id}","starred_url":"https://api.github.com/users/avh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avh4/subscriptions","organizations_url":"https://api.github.com/users/avh4/orgs","repos_url":"https://api.github.com/users/avh4/repos","events_url":"https://api.github.com/users/avh4/events{/privacy}","received_events_url":"https://api.github.com/users/avh4/received_events","type":"User","site_admin":false},"repo":{"id":134009811,"name":"new-elm-test","full_name":"avh4/new-elm-test","owner":{"login":"avh4","id":1222,"avatar_url":"https://avatars1.githubusercontent.com/u/1222?v=4","gravatar_id":"","url":"https://api.github.com/users/avh4","html_url":"https://github.com/avh4","followers_url":"https://api.github.com/users/avh4/followers","following_url":"https://api.github.com/users/avh4/following{/other_user}","gists_url":"https://api.github.com/users/avh4/gists{/gist_id}","starred_url":"https://api.github.com/users/avh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avh4/subscriptions","organizations_url":"https://api.github.com/users/avh4/orgs","repos_url":"https://api.github.com/users/avh4/repos","events_url":"https://api.github.com/users/avh4/events{/privacy}","received_events_url":"https://api.github.com/users/avh4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avh4/new-elm-test","description":"Write unit and fuzz tests for Elm code.","fork":true,"url":"https://api.github.com/repos/avh4/new-elm-test","forks_url":"https://api.github.com/repos/avh4/new-elm-test/forks","keys_url":"https://api.github.com/repos/avh4/new-elm-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avh4/new-elm-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avh4/new-elm-test/teams","hooks_url":"https://api.github.com/repos/avh4/new-elm-test/hooks","issue_events_url":"https://api.github.com/repos/avh4/new-elm-test/issues/events{/number}","events_url":"https://api.github.com/repos/avh4/new-elm-test/events","assignees_url":"https://api.github.com/repos/avh4/new-elm-test/assignees{/user}","branches_url":"https://api.github.com/repos/avh4/new-elm-test/branches{/branch}","tags_url":"https://api.github.com/repos/avh4/new-elm-test/tags","blobs_url":"https://api.github.com/repos/avh4/new-elm-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avh4/new-elm-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avh4/new-elm-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/avh4/new-elm-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avh4/new-elm-test/statuses/{sha}","languages_url":"https://api.github.com/repos/avh4/new-elm-test/languages","stargazers_url":"https://api.github.com/repos/avh4/new-elm-test/stargazers","contributors_url":"https://api.github.com/repos/avh4/new-elm-test/contributors","subscribers_url":"https://api.github.com/repos/avh4/new-elm-test/subscribers","subscription_url":"https://api.github.com/repos/avh4/new-elm-test/subscription","commits_url":"https://api.github.com/repos/avh4/new-elm-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/avh4/new-elm-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/avh4/new-elm-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/avh4/new-elm-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/avh4/new-elm-test/contents/{+path}","compare_url":"https://api.github.com/repos/avh4/new-elm-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avh4/new-elm-test/merges","archive_url":"https://api.github.com/repos/avh4/new-elm-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avh4/new-elm-test/downloads","issues_url":"https://api.github.com/repos/avh4/new-elm-test/issues{/number}","pulls_url":"https://api.github.com/repos/avh4/new-elm-test/pulls{/number}","milestones_url":"https://api.github.com/repos/avh4/new-elm-test/milestones{/number}","notifications_url":"https://api.github.com/repos/avh4/new-elm-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avh4/new-elm-test/labels{/name}","releases_url":"https://api.github.com/repos/avh4/new-elm-test/releases{/id}","deployments_url":"https://api.github.com/repos/avh4/new-elm-test/deployments","created_at":"2018-05-18T22:30:32Z","updated_at":"2018-05-18T22:31:02Z","pushed_at":"2018-05-19T18:26:37Z","git_url":"git://github.com/avh4/new-elm-test.git","ssh_url":"git@github.com:avh4/new-elm-test.git","clone_url":"https://github.com/avh4/new-elm-test.git","svn_url":"https://github.com/avh4/new-elm-test","homepage":"https://package.elm-lang.org/packages/elm-explorations/test/latest","size":732,"stargazers_count":0,"watchers_count":0,"language":"Elm","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elm-explorations:0.19","ref":"0.19","sha":"9b485c4be14fb34df89f414cc590a83291ccef87","user":{"login":"elm-explorations","id":26491321,"avatar_url":"https://avatars1.githubusercontent.com/u/26491321?v=4","gravatar_id":"","url":"https://api.github.com/users/elm-explorations","html_url":"https://github.com/elm-explorations","followers_url":"https://api.github.com/users/elm-explorations/followers","following_url":"https://api.github.com/users/elm-explorations/following{/other_user}","gists_url":"https://api.github.com/users/elm-explorations/gists{/gist_id}","starred_url":"https://api.github.com/users/elm-explorations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elm-explorations/subscriptions","organizations_url":"https://api.github.com/users/elm-explorations/orgs","repos_url":"https://api.github.com/users/elm-explorations/repos","events_url":"https://api.github.com/users/elm-explorations/events{/privacy}","received_events_url":"https://api.github.com/users/elm-explorations/received_events","type":"Organization","site_admin":false},"repo":{"id":131324198,"name":"test","full_name":"elm-explorations/test","owner":{"login":"elm-explorations","id":26491321,"avatar_url":"https://avatars1.githubusercontent.com/u/26491321?v=4","gravatar_id":"","url":"https://api.github.com/users/elm-explorations","html_url":"https://github.com/elm-explorations","followers_url":"https://api.github.com/users/elm-explorations/followers","following_url":"https://api.github.com/users/elm-explorations/following{/other_user}","gists_url":"https://api.github.com/users/elm-explorations/gists{/gist_id}","starred_url":"https://api.github.com/users/elm-explorations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elm-explorations/subscriptions","organizations_url":"https://api.github.com/users/elm-explorations/orgs","repos_url":"https://api.github.com/users/elm-explorations/repos","events_url":"https://api.github.com/users/elm-explorations/events{/privacy}","received_events_url":"https://api.github.com/users/elm-explorations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elm-explorations/test","description":"Write unit and fuzz tests for Elm code.","fork":false,"url":"https://api.github.com/repos/elm-explorations/test","forks_url":"https://api.github.com/repos/elm-explorations/test/forks","keys_url":"https://api.github.com/repos/elm-explorations/test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elm-explorations/test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elm-explorations/test/teams","hooks_url":"https://api.github.com/repos/elm-explorations/test/hooks","issue_events_url":"https://api.github.com/repos/elm-explorations/test/issues/events{/number}","events_url":"https://api.github.com/repos/elm-explorations/test/events","assignees_url":"https://api.github.com/repos/elm-explorations/test/assignees{/user}","branches_url":"https://api.github.com/repos/elm-explorations/test/branches{/branch}","tags_url":"https://api.github.com/repos/elm-explorations/test/tags","blobs_url":"https://api.github.com/repos/elm-explorations/test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elm-explorations/test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elm-explorations/test/git/refs{/sha}","trees_url":"https://api.github.com/repos/elm-explorations/test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elm-explorations/test/statuses/{sha}","languages_url":"https://api.github.com/repos/elm-explorations/test/languages","stargazers_url":"https://api.github.com/repos/elm-explorations/test/stargazers","contributors_url":"https://api.github.com/repos/elm-explorations/test/contributors","subscribers_url":"https://api.github.com/repos/elm-explorations/test/subscribers","subscription_url":"https://api.github.com/repos/elm-explorations/test/subscription","commits_url":"https://api.github.com/repos/elm-explorations/test/commits{/sha}","git_commits_url":"https://api.github.com/repos/elm-explorations/test/git/commits{/sha}","comments_url":"https://api.github.com/repos/elm-explorations/test/comments{/number}","issue_comment_url":"https://api.github.com/repos/elm-explorations/test/issues/comments{/number}","contents_url":"https://api.github.com/repos/elm-explorations/test/contents/{+path}","compare_url":"https://api.github.com/repos/elm-explorations/test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elm-explorations/test/merges","archive_url":"https://api.github.com/repos/elm-explorations/test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elm-explorations/test/downloads","issues_url":"https://api.github.com/repos/elm-explorations/test/issues{/number}","pulls_url":"https://api.github.com/repos/elm-explorations/test/pulls{/number}","milestones_url":"https://api.github.com/repos/elm-explorations/test/milestones{/number}","notifications_url":"https://api.github.com/repos/elm-explorations/test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elm-explorations/test/labels{/name}","releases_url":"https://api.github.com/repos/elm-explorations/test/releases{/id}","deployments_url":"https://api.github.com/repos/elm-explorations/test/deployments","created_at":"2018-04-27T17:06:19Z","updated_at":"2018-05-19T16:11:08Z","pushed_at":"2018-05-19T18:26:38Z","git_url":"git://github.com/elm-explorations/test.git","ssh_url":"git@github.com:elm-explorations/test.git","clone_url":"https://github.com/elm-explorations/test.git","svn_url":"https://github.com/elm-explorations/test","homepage":"https://package.elm-lang.org/packages/elm-explorations/test/latest","size":708,"stargazers_count":5,"watchers_count":5,"language":"Elm","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elm-explorations/test/pulls/3"},"html":{"href":"https://github.com/elm-explorations/test/pull/3"},"issue":{"href":"https://api.github.com/repos/elm-explorations/test/issues/3"},"comments":{"href":"https://api.github.com/repos/elm-explorations/test/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/elm-explorations/test/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/elm-explorations/test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elm-explorations/test/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/elm-explorations/test/statuses/cdd1efa51753f255a464fcbb510604925a8492cb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mgold"}}