{"action":"created","issue":{"url":"https://api.github.com/repos/earlephilhower/ESP8266Audio/issues/74","repository_url":"https://api.github.com/repos/earlephilhower/ESP8266Audio","labels_url":"https://api.github.com/repos/earlephilhower/ESP8266Audio/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/earlephilhower/ESP8266Audio/issues/74/comments","events_url":"https://api.github.com/repos/earlephilhower/ESP8266Audio/issues/74/events","html_url":"https://github.com/earlephilhower/ESP8266Audio/issues/74","id":306649822,"node_id":"MDU6SXNzdWUzMDY2NDk4MjI=","number":74,"title":"document best practices","user":{"login":"mcuadros","id":1573114,"node_id":"MDQ6VXNlcjE1NzMxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1573114?v=4","gravatar_id":"","url":"https://api.github.com/users/mcuadros","html_url":"https://github.com/mcuadros","followers_url":"https://api.github.com/users/mcuadros/followers","following_url":"https://api.github.com/users/mcuadros/following{/other_user}","gists_url":"https://api.github.com/users/mcuadros/gists{/gist_id}","starred_url":"https://api.github.com/users/mcuadros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcuadros/subscriptions","organizations_url":"https://api.github.com/users/mcuadros/orgs","repos_url":"https://api.github.com/users/mcuadros/repos","events_url":"https://api.github.com/users/mcuadros/events{/privacy}","received_events_url":"https://api.github.com/users/mcuadros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-19T21:48:04Z","updated_at":"2018-08-23T19:37:20Z","closed_at":null,"author_association":"NONE","body":"I am using the library intensively I found that sometimes cause the resent, for example, if you are using `AudioFileSourceICYStream` you should check that the URL request was ok, Otherwise may cause a \r\n\r\n```cpp\r\n  file = new AudioFileSourceICYStream(url);\r\n  if (!file->isOpen()) {\r\n    Serial.println(\"Unable to open URL\");\r\n    return;\r\n  }\r\n```\r\n\r\nAlso, `AudioFileSourceBuffer` has `isOpen`  but I am not sure if the buffer may fail.\r\n\r\nAnother good example is how to clean up the objects to avoid memory leaks like; \r\n\r\n```cpp\r\n  mp3->stop();\r\n  buff->close();\r\n  file->close();\r\n  delete mp3;\r\n  delete buff;\r\n  delete file;\r\n  mp3 = NULL;\r\n```\r\n\r\nThat's I am asking if a complex example or something similar can be written in order to help newbies like me, to have a rock solid code. \r\n"},"comment":{"url":"https://api.github.com/repos/earlephilhower/ESP8266Audio/issues/comments/415545030","html_url":"https://github.com/earlephilhower/ESP8266Audio/issues/74#issuecomment-415545030","issue_url":"https://api.github.com/repos/earlephilhower/ESP8266Audio/issues/74","id":415545030,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTU0NTAzMA==","user":{"login":"mixographer","id":5832940,"node_id":"MDQ6VXNlcjU4MzI5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5832940?v=4","gravatar_id":"","url":"https://api.github.com/users/mixographer","html_url":"https://github.com/mixographer","followers_url":"https://api.github.com/users/mixographer/followers","following_url":"https://api.github.com/users/mixographer/following{/other_user}","gists_url":"https://api.github.com/users/mixographer/gists{/gist_id}","starred_url":"https://api.github.com/users/mixographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixographer/subscriptions","organizations_url":"https://api.github.com/users/mixographer/orgs","repos_url":"https://api.github.com/users/mixographer/repos","events_url":"https://api.github.com/users/mixographer/events{/privacy}","received_events_url":"https://api.github.com/users/mixographer/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T19:37:20Z","updated_at":"2018-08-23T19:37:20Z","author_association":"NONE","body":"Good to know. I'm running up against buffer underflow errors, so I'll keep working on that. \r\n"}}
{"actor":{"display_login":"mixographer"}}