{"action":"created","issue":{"url":"https://api.github.com/repos/tarent/loginsrv/issues/72","repository_url":"https://api.github.com/repos/tarent/loginsrv","labels_url":"https://api.github.com/repos/tarent/loginsrv/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/tarent/loginsrv/issues/72/comments","events_url":"https://api.github.com/repos/tarent/loginsrv/issues/72/events","html_url":"https://github.com/tarent/loginsrv/pull/72","id":304196581,"number":72,"title":"Adjust behavior on empty username and token refresh","user":{"login":"magikstm","id":24783458,"avatar_url":"https://avatars2.githubusercontent.com/u/24783458?v=4","gravatar_id":"","url":"https://api.github.com/users/magikstm","html_url":"https://github.com/magikstm","followers_url":"https://api.github.com/users/magikstm/followers","following_url":"https://api.github.com/users/magikstm/following{/other_user}","gists_url":"https://api.github.com/users/magikstm/gists{/gist_id}","starred_url":"https://api.github.com/users/magikstm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magikstm/subscriptions","organizations_url":"https://api.github.com/users/magikstm/orgs","repos_url":"https://api.github.com/users/magikstm/repos","events_url":"https://api.github.com/users/magikstm/events{/privacy}","received_events_url":"https://api.github.com/users/magikstm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-11T21:37:52Z","updated_at":"2018-03-11T21:42:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tarent/loginsrv/pulls/72","html_url":"https://github.com/tarent/loginsrv/pull/72","diff_url":"https://github.com/tarent/loginsrv/pull/72.diff","patch_url":"https://github.com/tarent/loginsrv/pull/72.patch"},"body":"This PR is a try to adjust behavior to resolve #71.\r\n\r\nIt changes behavior in 3 cases:\r\n1) empty username now returns a 403 instead of a page with `Bad Request: Method or content-type not supported`\r\n2) Refreshing an expired token returns a 403 instead of a 400\r\n3) Refreshing an invalid token returns a 403 instead of a 400\r\n\r\n@smancke please review it and confirm if these behavior are acceptable in these cases."},"comment":{"url":"https://api.github.com/repos/tarent/loginsrv/issues/comments/372152019","html_url":"https://github.com/tarent/loginsrv/pull/72#issuecomment-372152019","issue_url":"https://api.github.com/repos/tarent/loginsrv/issues/72","id":372152019,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-03-11T21:42:12Z","updated_at":"2018-03-11T21:42:12Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/15918617/badge)](https://coveralls.io/builds/15918617)\n\nCoverage decreased (-0.09%) to 90.458% when pulling **db9e6df95175d67bde2d9f68bed7e345043d7f61 on magikstm:Issue-71** into **cd718ade49acce53135107c302de94f75895c91f on tarent:master**.\n"}}
{"actor":{"display_login":"coveralls"}}