{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/184830508","pull_request_review_id":116111443,"id":184830508,"diff_hunk":"@@ -74,6 +78,11 @@ func initializeNodeTransientInfo() nodeTransientInfo {\n \treturn nodeTransientInfo{AllocatableVolumesCount: 0, RequestedVolumes: 0}\n }\n \n+func incrementGeneration() int64 {","path":"pkg/scheduler/schedulercache/node_info.go","position":null,"original_position":24,"commit_id":"afe5e37bf7054ccf1dcb743ebcc7525caeae5f12","original_commit_id":"b90892fa958d38d2ac14de43db29ef6c96471fcd","user":{"login":"bsalamat","id":14308438,"avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"body":"It is not too late :)","created_at":"2018-04-28T00:04:04Z","updated_at":"2018-04-28T00:04:27Z","html_url":"https://github.com/kubernetes/kubernetes/pull/63264#discussion_r184830508","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/184830508"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63264#discussion_r184830508"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264"}},"in_reply_to_id":184807780},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264","id":184724152,"html_url":"https://github.com/kubernetes/kubernetes/pull/63264","diff_url":"https://github.com/kubernetes/kubernetes/pull/63264.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63264.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63264","number":63264,"state":"open","locked":false,"title":"Increase scheduler cache generation number monotonically in order to avoid collision","user":{"login":"bsalamat","id":14308438,"avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nIncrements the scheduler cache generation number monotonically to avoid collision of the generation numbers. More context in #63262.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #63262.\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nIncrease scheduler cache generation number monotonically in order to avoid collision and use of stale information in scheduler.\r\n```\r\n","created_at":"2018-04-27T20:47:18Z","updated_at":"2018-04-28T00:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b80155e8a189f641298de93de5428613a607eddf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ravisantoshgudimetla","id":11657829,"avatar_url":"https://avatars3.githubusercontent.com/u/11657829?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":711852570,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/milestone/incomplete-labels","name":"milestone/incomplete-labels","color":"ededed","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":125550211,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":70,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-04-27T20:47:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63264/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/afe5e37bf7054ccf1dcb743ebcc7525caeae5f12","head":{"label":"bsalamat:monotonic_generation","ref":"monotonic_generation","sha":"afe5e37bf7054ccf1dcb743ebcc7525caeae5f12","user":{"login":"bsalamat","id":14308438,"avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"repo":{"id":62752414,"name":"kubernetes","full_name":"bsalamat/kubernetes","owner":{"login":"bsalamat","id":14308438,"avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsalamat/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/bsalamat/kubernetes","forks_url":"https://api.github.com/repos/bsalamat/kubernetes/forks","keys_url":"https://api.github.com/repos/bsalamat/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsalamat/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsalamat/kubernetes/teams","hooks_url":"https://api.github.com/repos/bsalamat/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/bsalamat/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/bsalamat/kubernetes/events","assignees_url":"https://api.github.com/repos/bsalamat/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/bsalamat/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/bsalamat/kubernetes/tags","blobs_url":"https://api.github.com/repos/bsalamat/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsalamat/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsalamat/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsalamat/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsalamat/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/bsalamat/kubernetes/languages","stargazers_url":"https://api.github.com/repos/bsalamat/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/bsalamat/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/bsalamat/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/bsalamat/kubernetes/subscription","commits_url":"https://api.github.com/repos/bsalamat/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsalamat/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsalamat/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsalamat/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsalamat/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/bsalamat/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsalamat/kubernetes/merges","archive_url":"https://api.github.com/repos/bsalamat/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsalamat/kubernetes/downloads","issues_url":"https://api.github.com/repos/bsalamat/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/bsalamat/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/bsalamat/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/bsalamat/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsalamat/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/bsalamat/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/bsalamat/kubernetes/deployments","created_at":"2016-07-06T20:50:22Z","updated_at":"2018-04-27T04:04:24Z","pushed_at":"2018-04-28T00:03:24Z","git_url":"git://github.com/bsalamat/kubernetes.git","ssh_url":"git@github.com:bsalamat/kubernetes.git","clone_url":"https://github.com/bsalamat/kubernetes.git","svn_url":"https://github.com/bsalamat/kubernetes","homepage":"http://kubernetes.io","size":547244,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a8a963c98396ef8b5cd08911d0d4d7edbfff78fd","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-28T00:03:13Z","pushed_at":"2018-04-28T00:03:29Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":774243,"stargazers_count":35628,"watchers_count":35628,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12601,"mirror_url":null,"archived":false,"open_issues_count":3410,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12601,"open_issues":3410,"watchers":35628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63264"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63264"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63264/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63264/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/afe5e37bf7054ccf1dcb743ebcc7525caeae5f12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bsalamat"}}