{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/205931453","pull_request_review_id":141306089,"id":205931453,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkzMTQ1Mw==","diff_hunk":"@@ -111,27 +110,33 @@ public static ColumnIO getArrayElementColumn(ColumnIO columnIO)\n         return columnIO;\n     }\n \n-    public static Map<List<String>, RichColumnDescriptor> getDescriptors(MessageType fileSchema, MessageType requestedSchema)\n+    public static Map<List<String>, RichColumnDescriptor> getDescriptors(MessageType fileSchema, MessageType requestedSchema, Map<parquet.schema.Type, HiveColumnHandle> typeColumns)","path":"presto-hive/src/main/java/com/facebook/presto/hive/parquet/ParquetTypeUtils.java","position":25,"original_position":25,"commit_id":"9ddd30e1abb89d9ff7d38e4f0d2605599b84c327","original_commit_id":"9ddd30e1abb89d9ff7d38e4f0d2605599b84c327","user":{"login":"nezihyigitbasi","id":1223839,"node_id":"MDQ6VXNlcjEyMjM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"body":"We can put one parameter per line as this line is long:\r\n\r\n```\r\n    public static Map<List<String>, RichColumnDescriptor> getDescriptors(\r\n            MessageType fileSchema,\r\n            MessageType requestedSchema,\r\n            Map<parquet.schema.Type, HiveColumnHandle> typeColumns)\r\n    {\r\n```","created_at":"2018-07-28T03:42:16Z","updated_at":"2018-07-28T03:59:02Z","html_url":"https://github.com/prestodb/presto/pull/11118#discussion_r205931453","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/11118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/205931453"},"html":{"href":"https://github.com/prestodb/presto/pull/11118#discussion_r205931453"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11118"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/11118","id":203385601,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzg1NjAx","html_url":"https://github.com/prestodb/presto/pull/11118","diff_url":"https://github.com/prestodb/presto/pull/11118.diff","patch_url":"https://github.com/prestodb/presto/pull/11118.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11118","number":11118,"state":"open","locked":false,"title":"cleanup fix for type mismatch in Parquet predicate pushdown","user":{"login":"nishantrayan","id":312902,"node_id":"MDQ6VXNlcjMxMjkwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/312902?v=4","gravatar_id":"","url":"https://api.github.com/users/nishantrayan","html_url":"https://github.com/nishantrayan","followers_url":"https://api.github.com/users/nishantrayan/followers","following_url":"https://api.github.com/users/nishantrayan/following{/other_user}","gists_url":"https://api.github.com/users/nishantrayan/gists{/gist_id}","starred_url":"https://api.github.com/users/nishantrayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishantrayan/subscriptions","organizations_url":"https://api.github.com/users/nishantrayan/orgs","repos_url":"https://api.github.com/users/nishantrayan/repos","events_url":"https://api.github.com/users/nishantrayan/events{/privacy}","received_events_url":"https://api.github.com/users/nishantrayan/received_events","type":"User","site_admin":false},"body":"follow up from https://github.com/prestodb/presto/pull/9975 to clean up the logic \r\n","created_at":"2018-07-24T01:26:32Z","updated_at":"2018-07-28T03:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c24bfe9fced8432c187148fef00e6bcb5aab992","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/11118/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/11118/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11118/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/9ddd30e1abb89d9ff7d38e4f0d2605599b84c327","head":{"label":"lyft:predicate_fix_cleanup","ref":"predicate_fix_cleanup","sha":"9ddd30e1abb89d9ff7d38e4f0d2605599b84c327","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":121577853,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1Nzc4NTM=","name":"presto","full_name":"lyft/presto","owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/lyft/presto","forks_url":"https://api.github.com/repos/lyft/presto/forks","keys_url":"https://api.github.com/repos/lyft/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/presto/teams","hooks_url":"https://api.github.com/repos/lyft/presto/hooks","issue_events_url":"https://api.github.com/repos/lyft/presto/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/presto/events","assignees_url":"https://api.github.com/repos/lyft/presto/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/presto/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/presto/tags","blobs_url":"https://api.github.com/repos/lyft/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/presto/languages","stargazers_url":"https://api.github.com/repos/lyft/presto/stargazers","contributors_url":"https://api.github.com/repos/lyft/presto/contributors","subscribers_url":"https://api.github.com/repos/lyft/presto/subscribers","subscription_url":"https://api.github.com/repos/lyft/presto/subscription","commits_url":"https://api.github.com/repos/lyft/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/presto/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/presto/merges","archive_url":"https://api.github.com/repos/lyft/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/presto/downloads","issues_url":"https://api.github.com/repos/lyft/presto/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/presto/labels{/name}","releases_url":"https://api.github.com/repos/lyft/presto/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/presto/deployments","created_at":"2018-02-15T00:38:24Z","updated_at":"2018-04-26T00:02:02Z","pushed_at":"2018-07-28T01:08:22Z","git_url":"git://github.com/lyft/presto.git","ssh_url":"git@github.com:lyft/presto.git","clone_url":"https://github.com/lyft/presto.git","svn_url":"https://github.com/lyft/presto","homepage":"https://prestodb.io","size":94917,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"d3c9272f3d02233f6a8549d95ab491be70afd465","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-07-28T02:44:43Z","pushed_at":"2018-07-28T03:16:07Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":95190,"stargazers_count":7828,"watchers_count":7828,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2662,"mirror_url":null,"archived":false,"open_issues_count":1344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2662,"open_issues":1344,"watchers":7828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11118"},"html":{"href":"https://github.com/prestodb/presto/pull/11118"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/11118"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/11118/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11118/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11118/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/9ddd30e1abb89d9ff7d38e4f0d2605599b84c327"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nezihyigitbasi"}}