{"action":"created","comment":{"url":"https://api.github.com/repos/cyberark/conjur/pulls/comments/212702159","pull_request_review_id":149394849,"id":212702159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjcwMjE1OQ==","diff_hunk":"@@ -0,0 +1,41 @@\n+Given(/^I have an intermediate CA$/) do\n+  @root_ca ||= generate_root_ca\n+  @intermediate_ca = generate_intermediate_ca(@root_ca)\n+end\n+\n+Given(/^I add the intermediate CA private key to the resource \"([^\"]*)\"$/) do |resource_id|\n+  Secret.create resource_id: resource_id, value: @intermediate_ca.key.to_pem\n+end\n+\n+Given(/^I add the intermediate CA cert chain to the resource \"([^\"]*)\"$/) do |resource_id|\n+  chain = [\n+    @intermediate_ca.cert.to_pem,\n+    @root_ca.cert.to_pem\n+  ].join(\"\\n\")\n+  Secret.create resource_id: resource_id, value: chain\n+end\n+\n+When(/^I send a CSR for \"([^\"]*)\" to the \"([^\"]*)\" CA with a ttl of \"([^\"]*)\" and CN of \"([^\"]*)\"$/) do |host_name, service_name, ttl, common_name|","path":"cucumber/api/features/step_definitions/ca_steps.rb","position":18,"original_position":18,"commit_id":"2e47c5a5e442d7d3e58c3aaf3fef46db07f5db90","original_commit_id":"2e47c5a5e442d7d3e58c3aaf3fef46db07f5db90","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Unused block argument - `host_name`. If it's necessary, use `_` or `_host_name` as an argument name to indicate that it won't be used.","created_at":"2018-08-24T17:38:38Z","updated_at":"2018-08-24T17:38:38Z","html_url":"https://github.com/cyberark/conjur/pull/689#discussion_r212702159","pull_request_url":"https://api.github.com/repos/cyberark/conjur/pulls/689","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/comments/212702159"},"html":{"href":"https://github.com/cyberark/conjur/pull/689#discussion_r212702159"},"pull_request":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/689"}}},"pull_request":{"url":"https://api.github.com/repos/cyberark/conjur/pulls/689","id":208962725,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTYyNzI1","html_url":"https://github.com/cyberark/conjur/pull/689","diff_url":"https://github.com/cyberark/conjur/pull/689.diff","patch_url":"https://github.com/cyberark/conjur/pull/689.patch","issue_url":"https://api.github.com/repos/cyberark/conjur/issues/689","number":689,"state":"open","locked":false,"title":"WIP Conjur CA Services","user":{"login":"micahlee","id":1534633,"node_id":"MDQ6VXNlcjE1MzQ2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1534633?v=4","gravatar_id":"","url":"https://api.github.com/users/micahlee","html_url":"https://github.com/micahlee","followers_url":"https://api.github.com/users/micahlee/followers","following_url":"https://api.github.com/users/micahlee/following{/other_user}","gists_url":"https://api.github.com/users/micahlee/gists{/gist_id}","starred_url":"https://api.github.com/users/micahlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahlee/subscriptions","organizations_url":"https://api.github.com/users/micahlee/orgs","repos_url":"https://api.github.com/users/micahlee/repos","events_url":"https://api.github.com/users/micahlee/events{/privacy}","received_events_url":"https://api.github.com/users/micahlee/received_events","type":"User","site_admin":false},"body":"Closes #684 \r\n\r\n#### What does this pull request do?\r\n\r\nThis PR add support for certificate authority (CA) services to be configured using Conjur policy that are capable of signing host CSRs using a provided CA certificate.\r\n\r\n#### What background context can you provide?\r\n\r\nThis is in support of the epic #651.\r\n\r\n#### Where should the reviewer start?\r\n\r\nThe best place to start to understand how the feature works is with the\r\ncucumber tests in `cucumber/api/features/certificate_authority.feature`.\r\n\r\n#### How should this be manually tested?\r\n\r\nThis can be manually tested using cucumber:\r\n* `cd dev && ./start` and `conjurctl server` in the container\r\n* In a new bash session, `cd dev && ./cli exec` and in the container:\r\n    ```sh-session\r\n    bundle exec cucumber --profile api cucumber/api/features/certificate_authority.feature\r\n    ```\r\n\r\n#### Link to build in Jenkins (if appropriate)\r\n\r\nhttps://jenkins.conjur.net/job/cyberark--conjur/job/ca_signing_service/\r\n\r\n#### Questions:\r\n> Does this have automated Cucumber tests?\r\nYes\r\n\r\n> Can we make a blog post, video, or animated GIF out of this?\r\nProbably\r\n\r\n> Is this explained in documentation?\r\nNot yet. This is being tracked in #688\r\n\r\n> Does the knowledge base need an update?\r\n\r\n","created_at":"2018-08-16T19:37:26Z","updated_at":"2018-08-24T17:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f662f0479b8dff366656a2a06a03080c5bbd61b9","assignee":{"login":"micahlee","id":1534633,"node_id":"MDQ6VXNlcjE1MzQ2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1534633?v=4","gravatar_id":"","url":"https://api.github.com/users/micahlee","html_url":"https://github.com/micahlee","followers_url":"https://api.github.com/users/micahlee/followers","following_url":"https://api.github.com/users/micahlee/following{/other_user}","gists_url":"https://api.github.com/users/micahlee/gists{/gist_id}","starred_url":"https://api.github.com/users/micahlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahlee/subscriptions","organizations_url":"https://api.github.com/users/micahlee/orgs","repos_url":"https://api.github.com/users/micahlee/repos","events_url":"https://api.github.com/users/micahlee/events{/privacy}","received_events_url":"https://api.github.com/users/micahlee/received_events","type":"User","site_admin":false},"assignees":[{"login":"micahlee","id":1534633,"node_id":"MDQ6VXNlcjE1MzQ2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1534633?v=4","gravatar_id":"","url":"https://api.github.com/users/micahlee","html_url":"https://github.com/micahlee","followers_url":"https://api.github.com/users/micahlee/followers","following_url":"https://api.github.com/users/micahlee/following{/other_user}","gists_url":"https://api.github.com/users/micahlee/gists{/gist_id}","starred_url":"https://api.github.com/users/micahlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahlee/subscriptions","organizations_url":"https://api.github.com/users/micahlee/orgs","repos_url":"https://api.github.com/users/micahlee/repos","events_url":"https://api.github.com/users/micahlee/events{/privacy}","received_events_url":"https://api.github.com/users/micahlee/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":631459098,"node_id":"MDU6TGFiZWw2MzE0NTkwOTg=","url":"https://api.github.com/repos/cyberark/conjur/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":999180579,"node_id":"MDU6TGFiZWw5OTkxODA1Nzk=","url":"https://api.github.com/repos/cyberark/conjur/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cyberark/conjur/pulls/689/commits","review_comments_url":"https://api.github.com/repos/cyberark/conjur/pulls/689/comments","review_comment_url":"https://api.github.com/repos/cyberark/conjur/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyberark/conjur/issues/689/comments","statuses_url":"https://api.github.com/repos/cyberark/conjur/statuses/2e47c5a5e442d7d3e58c3aaf3fef46db07f5db90","head":{"label":"cyberark:ca_signing_service","ref":"ca_signing_service","sha":"2e47c5a5e442d7d3e58c3aaf3fef46db07f5db90","user":{"login":"cyberark","id":30869256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODY5MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"repo":{"id":62174977,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3NDk3Nw==","name":"conjur","full_name":"cyberark/conjur","owner":{"login":"cyberark","id":30869256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODY5MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyberark/conjur","description":"CyberArk Conjur automatically secures secrets used by privileged users and machine identities","fork":false,"url":"https://api.github.com/repos/cyberark/conjur","forks_url":"https://api.github.com/repos/cyberark/conjur/forks","keys_url":"https://api.github.com/repos/cyberark/conjur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberark/conjur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberark/conjur/teams","hooks_url":"https://api.github.com/repos/cyberark/conjur/hooks","issue_events_url":"https://api.github.com/repos/cyberark/conjur/issues/events{/number}","events_url":"https://api.github.com/repos/cyberark/conjur/events","assignees_url":"https://api.github.com/repos/cyberark/conjur/assignees{/user}","branches_url":"https://api.github.com/repos/cyberark/conjur/branches{/branch}","tags_url":"https://api.github.com/repos/cyberark/conjur/tags","blobs_url":"https://api.github.com/repos/cyberark/conjur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberark/conjur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberark/conjur/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberark/conjur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberark/conjur/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberark/conjur/languages","stargazers_url":"https://api.github.com/repos/cyberark/conjur/stargazers","contributors_url":"https://api.github.com/repos/cyberark/conjur/contributors","subscribers_url":"https://api.github.com/repos/cyberark/conjur/subscribers","subscription_url":"https://api.github.com/repos/cyberark/conjur/subscription","commits_url":"https://api.github.com/repos/cyberark/conjur/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberark/conjur/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberark/conjur/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberark/conjur/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberark/conjur/contents/{+path}","compare_url":"https://api.github.com/repos/cyberark/conjur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberark/conjur/merges","archive_url":"https://api.github.com/repos/cyberark/conjur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberark/conjur/downloads","issues_url":"https://api.github.com/repos/cyberark/conjur/issues{/number}","pulls_url":"https://api.github.com/repos/cyberark/conjur/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberark/conjur/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberark/conjur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberark/conjur/labels{/name}","releases_url":"https://api.github.com/repos/cyberark/conjur/releases{/id}","deployments_url":"https://api.github.com/repos/cyberark/conjur/deployments","created_at":"2016-06-28T21:18:07Z","updated_at":"2018-08-22T20:07:07Z","pushed_at":"2018-08-24T17:37:57Z","git_url":"git://github.com/cyberark/conjur.git","ssh_url":"git@github.com:cyberark/conjur.git","clone_url":"https://github.com/cyberark/conjur.git","svn_url":"https://github.com/cyberark/conjur","homepage":"https://conjur.org","size":4031,"stargazers_count":163,"watchers_count":163,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":34,"open_issues":71,"watchers":163,"default_branch":"master"}},"base":{"label":"cyberark:master","ref":"master","sha":"9e8117d6df2bd93639fffea6d9dabdd08bf02f09","user":{"login":"cyberark","id":30869256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODY5MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"repo":{"id":62174977,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3NDk3Nw==","name":"conjur","full_name":"cyberark/conjur","owner":{"login":"cyberark","id":30869256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODY5MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyberark/conjur","description":"CyberArk Conjur automatically secures secrets used by privileged users and machine identities","fork":false,"url":"https://api.github.com/repos/cyberark/conjur","forks_url":"https://api.github.com/repos/cyberark/conjur/forks","keys_url":"https://api.github.com/repos/cyberark/conjur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberark/conjur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberark/conjur/teams","hooks_url":"https://api.github.com/repos/cyberark/conjur/hooks","issue_events_url":"https://api.github.com/repos/cyberark/conjur/issues/events{/number}","events_url":"https://api.github.com/repos/cyberark/conjur/events","assignees_url":"https://api.github.com/repos/cyberark/conjur/assignees{/user}","branches_url":"https://api.github.com/repos/cyberark/conjur/branches{/branch}","tags_url":"https://api.github.com/repos/cyberark/conjur/tags","blobs_url":"https://api.github.com/repos/cyberark/conjur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberark/conjur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberark/conjur/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberark/conjur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberark/conjur/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberark/conjur/languages","stargazers_url":"https://api.github.com/repos/cyberark/conjur/stargazers","contributors_url":"https://api.github.com/repos/cyberark/conjur/contributors","subscribers_url":"https://api.github.com/repos/cyberark/conjur/subscribers","subscription_url":"https://api.github.com/repos/cyberark/conjur/subscription","commits_url":"https://api.github.com/repos/cyberark/conjur/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberark/conjur/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberark/conjur/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberark/conjur/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberark/conjur/contents/{+path}","compare_url":"https://api.github.com/repos/cyberark/conjur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberark/conjur/merges","archive_url":"https://api.github.com/repos/cyberark/conjur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberark/conjur/downloads","issues_url":"https://api.github.com/repos/cyberark/conjur/issues{/number}","pulls_url":"https://api.github.com/repos/cyberark/conjur/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberark/conjur/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberark/conjur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberark/conjur/labels{/name}","releases_url":"https://api.github.com/repos/cyberark/conjur/releases{/id}","deployments_url":"https://api.github.com/repos/cyberark/conjur/deployments","created_at":"2016-06-28T21:18:07Z","updated_at":"2018-08-22T20:07:07Z","pushed_at":"2018-08-24T17:37:57Z","git_url":"git://github.com/cyberark/conjur.git","ssh_url":"git@github.com:cyberark/conjur.git","clone_url":"https://github.com/cyberark/conjur.git","svn_url":"https://github.com/cyberark/conjur","homepage":"https://conjur.org","size":4031,"stargazers_count":163,"watchers_count":163,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":34,"open_issues":71,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/689"},"html":{"href":"https://github.com/cyberark/conjur/pull/689"},"issue":{"href":"https://api.github.com/repos/cyberark/conjur/issues/689"},"comments":{"href":"https://api.github.com/repos/cyberark/conjur/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyberark/conjur/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/cyberark/conjur/statuses/2e47c5a5e442d7d3e58c3aaf3fef46db07f5db90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codeclimate"}}