{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/comments/200281856","pull_request_review_id":134564694,"id":200281856,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDI4MTg1Ng==","diff_hunk":"@@ -2,6 +2,14 @@\n \n Records breaking changes from major version bumps\n \n+## 18.0.0\n+\n+PR: [#151](https://github.com/alphagov/digitalmarketplace-apiclient/pull/151)\n+\n+The default request error message for unrecognised/unhandled errors has changed from 'Request failed' to 'Unknown request failure in dmapiclient'. 'Request failed' should be seen only in exceptional circumstances - most exceptions raised from failed requests should now hold the str() and repr() calls of the request error as their message.\n+\n+Any code that relies on the specific format of the request errors raised by the apiclient will need to be updated.","path":"CHANGELOG.md","position":10,"original_position":10,"commit_id":"06910a99388ba11af5fc7d59dfbf55cbeec4d66e","original_commit_id":"06910a99388ba11af5fc7d59dfbf55cbeec4d66e","user":{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"body":"This is one of those \"as someone who doesn't know the whole of `digitalmarketplace-foo-frontend` like the back of my hand, *how the hell* am I expected to check for this?\" lines... not your fault though, just an issue with the whole \"not my problem (except it actually is)\" philosophy of our architecture.","created_at":"2018-07-05T09:07:00Z","updated_at":"2018-07-05T09:07:00Z","html_url":"https://github.com/alphagov/digitalmarketplace-apiclient/pull/151#discussion_r200281856","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/comments/200281856"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-apiclient/pull/151#discussion_r200281856"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151","id":199399836,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Mzk5ODM2","html_url":"https://github.com/alphagov/digitalmarketplace-apiclient/pull/151","diff_url":"https://github.com/alphagov/digitalmarketplace-apiclient/pull/151.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-apiclient/pull/151.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/151","number":151,"state":"open","locked":false,"title":"Log more detail on request exceptions","user":{"login":"samuelhwilliams","id":2920760,"node_id":"MDQ6VXNlcjI5MjA3NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2920760?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelhwilliams","html_url":"https://github.com/samuelhwilliams","followers_url":"https://api.github.com/users/samuelhwilliams/followers","following_url":"https://api.github.com/users/samuelhwilliams/following{/other_user}","gists_url":"https://api.github.com/users/samuelhwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelhwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelhwilliams/subscriptions","organizations_url":"https://api.github.com/users/samuelhwilliams/orgs","repos_url":"https://api.github.com/users/samuelhwilliams/repos","events_url":"https://api.github.com/users/samuelhwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/samuelhwilliams/received_events","type":"User","site_admin":false},"body":" ## Summary\r\nWe have been getting some mystery 503s in the buyer-frontend and don't\r\nget any useful error information from the apiclient. This update causes\r\nthe apiclient to emit more useful information via the str() and repr()\r\ncalls on the base error.","created_at":"2018-07-05T08:50:50Z","updated_at":"2018-07-05T09:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80aeaaca95352a837ecae49f2d3e3bf28ffe0bf6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benvand","id":3469840,"node_id":"MDQ6VXNlcjM0Njk4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3469840?v=4","gravatar_id":"","url":"https://api.github.com/users/benvand","html_url":"https://github.com/benvand","followers_url":"https://api.github.com/users/benvand/followers","following_url":"https://api.github.com/users/benvand/following{/other_user}","gists_url":"https://api.github.com/users/benvand/gists{/gist_id}","starred_url":"https://api.github.com/users/benvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvand/subscriptions","organizations_url":"https://api.github.com/users/benvand/orgs","repos_url":"https://api.github.com/users/benvand/repos","events_url":"https://api.github.com/users/benvand/events{/privacy}","received_events_url":"https://api.github.com/users/benvand/received_events","type":"User","site_admin":false},{"login":"Wynndow","id":13836290,"node_id":"MDQ6VXNlcjEzODM2Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/13836290?v=4","gravatar_id":"","url":"https://api.github.com/users/Wynndow","html_url":"https://github.com/Wynndow","followers_url":"https://api.github.com/users/Wynndow/followers","following_url":"https://api.github.com/users/Wynndow/following{/other_user}","gists_url":"https://api.github.com/users/Wynndow/gists{/gist_id}","starred_url":"https://api.github.com/users/Wynndow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wynndow/subscriptions","organizations_url":"https://api.github.com/users/Wynndow/orgs","repos_url":"https://api.github.com/users/Wynndow/repos","events_url":"https://api.github.com/users/Wynndow/events{/privacy}","received_events_url":"https://api.github.com/users/Wynndow/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/151/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/statuses/06910a99388ba11af5fc7d59dfbf55cbeec4d66e","head":{"label":"alphagov:shw-log-error-message","ref":"shw-log-error-message","sha":"06910a99388ba11af5fc7d59dfbf55cbeec4d66e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":48757766,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc1Nzc2Ng==","name":"digitalmarketplace-apiclient","full_name":"alphagov/digitalmarketplace-apiclient","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-apiclient","description":"Digital Marketplace Data and Search API clients","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/deployments","created_at":"2015-12-29T16:58:38Z","updated_at":"2018-06-28T11:02:11Z","pushed_at":"2018-07-05T08:58:11Z","git_url":"git://github.com/alphagov/digitalmarketplace-apiclient.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-apiclient.git","clone_url":"https://github.com/alphagov/digitalmarketplace-apiclient.git","svn_url":"https://github.com/alphagov/digitalmarketplace-apiclient","homepage":null,"size":440,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"aad4bb3aaf2963443da92a669089448b623dc26e","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":48757766,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc1Nzc2Ng==","name":"digitalmarketplace-apiclient","full_name":"alphagov/digitalmarketplace-apiclient","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-apiclient","description":"Digital Marketplace Data and Search API clients","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/deployments","created_at":"2015-12-29T16:58:38Z","updated_at":"2018-06-28T11:02:11Z","pushed_at":"2018-07-05T08:58:11Z","git_url":"git://github.com/alphagov/digitalmarketplace-apiclient.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-apiclient.git","clone_url":"https://github.com/alphagov/digitalmarketplace-apiclient.git","svn_url":"https://github.com/alphagov/digitalmarketplace-apiclient","homepage":null,"size":440,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-apiclient/pull/151"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/151"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-apiclient/statuses/06910a99388ba11af5fc7d59dfbf55cbeec4d66e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"risicle"}}