{"action":"created","issue":{"url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/issues/70","repository_url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador","labels_url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/issues/70/comments","events_url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/issues/70/events","html_url":"https://github.com/jhu-digital-manuscripts/mirador/pull/70","id":359989156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzU1MzUy","number":70,"title":"Aor2 pull slot address from save controller","user":{"login":"jabrah","id":5167587,"node_id":"MDQ6VXNlcjUxNjc1ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/5167587?v=4","gravatar_id":"","url":"https://api.github.com/users/jabrah","html_url":"https://github.com/jabrah","followers_url":"https://api.github.com/users/jabrah/followers","following_url":"https://api.github.com/users/jabrah/following{/other_user}","gists_url":"https://api.github.com/users/jabrah/gists{/gist_id}","starred_url":"https://api.github.com/users/jabrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabrah/subscriptions","organizations_url":"https://api.github.com/users/jabrah/orgs","repos_url":"https://api.github.com/users/jabrah/repos","events_url":"https://api.github.com/users/jabrah/events{/privacy}","received_events_url":"https://api.github.com/users/jabrah/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-13T17:20:48Z","updated_at":"2018-09-17T13:15:18Z","closed_at":"2018-09-13T17:49:25Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/pulls/70","html_url":"https://github.com/jhu-digital-manuscripts/mirador/pull/70","diff_url":"https://github.com/jhu-digital-manuscripts/mirador/pull/70.diff","patch_url":"https://github.com/jhu-digital-manuscripts/mirador/pull/70.patch"},"body":"Previously, each relevant component would be initialized with a value for `slotAddress` signifying the current slot in which the component lives. When one of these components wants to spawn a new window or modify the current window, it would refer to its `slotAddress` in order for Mirador to mutate the slots arrangement. However, this slot address is not constant - when the window arrangement is modified, the slot address necessarily changes as well. These components were not aware of this change, so any further window operations were failed, because Mirador would not be able to find the \"old\" slot address.\r\n\r\nThis change forces components to directly pull the slot address from Mirador's central `saveController` using the window ID, which is always kept up to date."},"comment":{"url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/issues/comments/422010947","html_url":"https://github.com/jhu-digital-manuscripts/mirador/pull/70#issuecomment-422010947","issue_url":"https://api.github.com/repos/jhu-digital-manuscripts/mirador/issues/70","id":422010947,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjAxMDk0Nw==","user":{"login":"jabrah","id":5167587,"node_id":"MDQ6VXNlcjUxNjc1ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/5167587?v=4","gravatar_id":"","url":"https://api.github.com/users/jabrah","html_url":"https://github.com/jabrah","followers_url":"https://api.github.com/users/jabrah/followers","following_url":"https://api.github.com/users/jabrah/following{/other_user}","gists_url":"https://api.github.com/users/jabrah/gists{/gist_id}","starred_url":"https://api.github.com/users/jabrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jabrah/subscriptions","organizations_url":"https://api.github.com/users/jabrah/orgs","repos_url":"https://api.github.com/users/jabrah/repos","events_url":"https://api.github.com/users/jabrah/events{/privacy}","received_events_url":"https://api.github.com/users/jabrah/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T13:15:18Z","updated_at":"2018-09-17T13:15:18Z","author_association":"NONE","body":"should have resolved https://github.com/jhu-digital-manuscripts/rosa2/issues/362"}}
{"actor":{"display_login":"jabrah"}}