{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/200065009","pull_request_review_id":134303645,"id":200065009,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA2NTAwOQ==","diff_hunk":"@@ -41,6 +41,11 @@ public SweepableTimestamps(KeyValueService kvs, WriteInfoPartitioner partitioner\n         super(kvs, TargetedSweepTableFactory.of().getSweepableTimestampsTable(null).getTableRef(), partitioner, null);\n     }\n \n+    @Override\n+    Map<Cell, byte[]> populateReferences(PartitionInfo partitionInfo, List<WriteInfo> writes) {\n+        return ImmutableMap.of();\n+    }","path":"atlasdb-impl-shared/src/main/java/com/palantir/atlasdb/sweep/queue/SweepableTimestamps.java","position":7,"original_position":7,"commit_id":"43c5be12426fc8c401d88a128f8d97ffe3d604b0","original_commit_id":"43c5be12426fc8c401d88a128f8d97ffe3d604b0","user":{"login":"jeremyk-91","id":5955510,"node_id":"MDQ6VXNlcjU5NTU1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5955510?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyk-91","html_url":"https://github.com/jeremyk-91","followers_url":"https://api.github.com/users/jeremyk-91/followers","following_url":"https://api.github.com/users/jeremyk-91/following{/other_user}","gists_url":"https://api.github.com/users/jeremyk-91/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyk-91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyk-91/subscriptions","organizations_url":"https://api.github.com/users/jeremyk-91/orgs","repos_url":"https://api.github.com/users/jeremyk-91/repos","events_url":"https://api.github.com/users/jeremyk-91/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyk-91/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-07-04T09:31:39Z","updated_at":"2018-07-04T09:37:32Z","html_url":"https://github.com/palantir/atlasdb/pull/3342#discussion_r200065009","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3342","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/200065009"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3342#discussion_r200065009"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3342"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/3342","id":199031026,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDMxMDI2","html_url":"https://github.com/palantir/atlasdb/pull/3342","diff_url":"https://github.com/palantir/atlasdb/pull/3342.diff","patch_url":"https://github.com/palantir/atlasdb/pull/3342.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/3342","number":3342,"state":"open","locked":false,"title":"[TS] Write to sweep queue at start timestamp","user":{"login":"gmaretic","id":23168027,"node_id":"MDQ6VXNlcjIzMTY4MDI3","avatar_url":"https://avatars0.githubusercontent.com/u/23168027?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaretic","html_url":"https://github.com/gmaretic","followers_url":"https://api.github.com/users/gmaretic/followers","following_url":"https://api.github.com/users/gmaretic/following{/other_user}","gists_url":"https://api.github.com/users/gmaretic/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaretic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaretic/subscriptions","organizations_url":"https://api.github.com/users/gmaretic/orgs","repos_url":"https://api.github.com/users/gmaretic/repos","events_url":"https://api.github.com/users/gmaretic/events{/privacy}","received_events_url":"https://api.github.com/users/gmaretic/received_events","type":"User","site_admin":false},"body":"**Goals (and why)**:\r\nDo not write to sweepable cells and sweepable timestamps at timestamp 0, use the transaction's start timestamp instead. Also, use multiPut, and ensure references are written first.\r\n\r\n**Concerns (what feedback would you like?)**:\r\nIs always reading at `Long.MAX_VALUE` reasonable?\r\n\r\n@j-baker @ashrayjain for SA\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/3342)\n<!-- Reviewable:end -->\n","created_at":"2018-07-03T17:15:10Z","updated_at":"2018-07-04T09:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b990414093090b2044ecefd1d1a126b0c000415","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sandorw","id":8271534,"node_id":"MDQ6VXNlcjgyNzE1MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8271534?v=4","gravatar_id":"","url":"https://api.github.com/users/sandorw","html_url":"https://github.com/sandorw","followers_url":"https://api.github.com/users/sandorw/followers","following_url":"https://api.github.com/users/sandorw/following{/other_user}","gists_url":"https://api.github.com/users/sandorw/gists{/gist_id}","starred_url":"https://api.github.com/users/sandorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandorw/subscriptions","organizations_url":"https://api.github.com/users/sandorw/orgs","repos_url":"https://api.github.com/users/sandorw/repos","events_url":"https://api.github.com/users/sandorw/events{/privacy}","received_events_url":"https://api.github.com/users/sandorw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3342/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/3342/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/3342/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/43c5be12426fc8c401d88a128f8d97ffe3d604b0","head":{"label":"palantir:fix/targeted-sweep-write-ts","ref":"fix/targeted-sweep-write-ts","sha":"43c5be12426fc8c401d88a128f8d97ffe3d604b0","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDYzNw==","name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-07-04T00:02:10Z","pushed_at":"2018-07-04T09:03:48Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":70644,"stargazers_count":599,"watchers_count":599,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":314,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":314,"watchers":599,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"4dc4e9cee44a7f7c1f65933e129c59be5978539e","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk2MDYzNw==","name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2018-07-04T00:02:10Z","pushed_at":"2018-07-04T09:03:48Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":70644,"stargazers_count":599,"watchers_count":599,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":314,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":314,"watchers":599,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3342"},"html":{"href":"https://github.com/palantir/atlasdb/pull/3342"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3342"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/3342/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3342/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/3342/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/43c5be12426fc8c401d88a128f8d97ffe3d604b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeremyk-91"}}