{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/228746570","pull_request_review_id":169090243,"id":228746570,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc0NjU3MA==","diff_hunk":"@@ -0,0 +1,78 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import { Row, Col } from 'patternfly-react';\n+import cx from 'classnames';\n+import ChartBox from '../statistics/ChartBox';\n+import { translate as __ } from '../../common/I18n';\n+import { STATUS } from '../../constants';\n+\n+const ConfigReports = (props) => {\n+  const {\n+    metricsChartData,\n+    statusChartData,\n+    metricsData: { tableData, tableClasses, total },\n+  } = props.data;\n+\n+  const createRow = (metric, i) => (","path":"webpack/assets/javascripts/react_app/components/ConfigReports/index.js","position":16,"original_position":16,"commit_id":"8eacd55b7cab85e8872dcd6768cfc66deae22785","original_commit_id":"8eacd55b7cab85e8872dcd6768cfc66deae22785","user":{"login":"amirfefer","id":11807069,"node_id":"MDQ6VXNlcjExODA3MDY5","avatar_url":"https://avatars2.githubusercontent.com/u/11807069?v=4","gravatar_id":"","url":"https://api.github.com/users/amirfefer","html_url":"https://github.com/amirfefer","followers_url":"https://api.github.com/users/amirfefer/followers","following_url":"https://api.github.com/users/amirfefer/following{/other_user}","gists_url":"https://api.github.com/users/amirfefer/gists{/gist_id}","starred_url":"https://api.github.com/users/amirfefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirfefer/subscriptions","organizations_url":"https://api.github.com/users/amirfefer/orgs","repos_url":"https://api.github.com/users/amirfefer/repos","events_url":"https://api.github.com/users/amirfefer/events{/privacy}","received_events_url":"https://api.github.com/users/amirfefer/received_events","type":"User","site_admin":false},"body":"nitpick: please use array destructing here:\r\n```js\r\nconst createRow = ([name, value], i) => (\r\n    <tr key={i}>\r\n      <td className=\"break-me\">{name}</td>\r\n      <td>{value}</td>\r\n    </tr>\r\n);\r\n```","created_at":"2018-10-28T12:28:50Z","updated_at":"2018-10-28T12:58:31Z","html_url":"https://github.com/theforeman/foreman/pull/5718#discussion_r228746570","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/5718","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/228746570"},"html":{"href":"https://github.com/theforeman/foreman/pull/5718#discussion_r228746570"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5718"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/5718","id":196052870,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDUyODcw","html_url":"https://github.com/theforeman/foreman/pull/5718","diff_url":"https://github.com/theforeman/foreman/pull/5718.diff","patch_url":"https://github.com/theforeman/foreman/pull/5718.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/5718","number":5718,"state":"open","locked":false,"title":"Fixes #24011 - Add Patternfly bar chart support","user":{"login":"lizagilman","id":15361156,"node_id":"MDQ6VXNlcjE1MzYxMTU2","avatar_url":"https://avatars1.githubusercontent.com/u/15361156?v=4","gravatar_id":"","url":"https://api.github.com/users/lizagilman","html_url":"https://github.com/lizagilman","followers_url":"https://api.github.com/users/lizagilman/followers","following_url":"https://api.github.com/users/lizagilman/following{/other_user}","gists_url":"https://api.github.com/users/lizagilman/gists{/gist_id}","starred_url":"https://api.github.com/users/lizagilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizagilman/subscriptions","organizations_url":"https://api.github.com/users/lizagilman/orgs","repos_url":"https://api.github.com/users/lizagilman/repos","events_url":"https://api.github.com/users/lizagilman/events{/privacy}","received_events_url":"https://api.github.com/users/lizagilman/received_events","type":"User","site_admin":false},"body":"\r\nTo do:\r\n\r\n- [x] fix legend\r\n- [x] fix labels\r\n- [x] add tests\r\n- [x] add to storybook\r\n- [x] possibly increase the size of the chart ?\r\n- [x] align chart\r\n- [x] move to chartbox\r\n- [x] add tests to wrapper component  \r\n\r\n\r\nedit:\r\n\r\nupdated screenshot -\r\n\r\n![image](https://user-images.githubusercontent.com/15361156/47022742-d1b57680-d166-11e8-9c62-b9c5e03a8ea5.png)\r\n\r\n\r\n\r\n<!---\r\n\r\nThank you for contributing to The Foreman, please read the\r\n[following guide](https://www.theforeman.org/contribute.html), in short:\r\n\r\n* [Create an issue](https://projects.theforeman.org/projects/foreman/issues)\r\n* Reference the issue via `Fixes #1234` or `Refs #1234` in the commit message\r\n* Prefer present-tense, imperative-style commit messages\r\n* Extract all strings for i18n, see [Translating section in the guide]\r\n(https://projects.theforeman.org/projects/foreman/wiki/Translating)\r\n* Prepend `[WIP]` for work in progress from bots triggering actions\r\n* Be patient, we will do our best to take a look as soon as we can\r\n* Explain the purpose of the PR, attach screenshots if applicable\r\n* Be nice and respectful\r\n\r\nWe are running bots that will poke you if you miss an item from the list :-)\r\n\r\n--->\r\n","created_at":"2018-06-20T08:03:50Z","updated_at":"2018-10-28T12:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"906302a7c7ae2c5c3f05063a9640532a66526fb9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":79040160,"node_id":"MDU6TGFiZWw3OTA0MDE2MA==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc","default":false},{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":778856900,"node_id":"MDU6TGFiZWw3Nzg4NTY5MDA=","url":"https://api.github.com/repos/theforeman/foreman/labels/UI","name":"UI","color":"f7f29b","default":false},{"id":994349953,"node_id":"MDU6TGFiZWw5OTQzNDk5NTM=","url":"https://api.github.com/repos/theforeman/foreman/labels/WIP","name":"WIP","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/5718/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/5718/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/5718/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/8eacd55b7cab85e8872dcd6768cfc66deae22785","head":{"label":"lizagilman:bar-chart","ref":"bar-chart","sha":"8eacd55b7cab85e8872dcd6768cfc66deae22785","user":{"login":"lizagilman","id":15361156,"node_id":"MDQ6VXNlcjE1MzYxMTU2","avatar_url":"https://avatars1.githubusercontent.com/u/15361156?v=4","gravatar_id":"","url":"https://api.github.com/users/lizagilman","html_url":"https://github.com/lizagilman","followers_url":"https://api.github.com/users/lizagilman/followers","following_url":"https://api.github.com/users/lizagilman/following{/other_user}","gists_url":"https://api.github.com/users/lizagilman/gists{/gist_id}","starred_url":"https://api.github.com/users/lizagilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizagilman/subscriptions","organizations_url":"https://api.github.com/users/lizagilman/orgs","repos_url":"https://api.github.com/users/lizagilman/repos","events_url":"https://api.github.com/users/lizagilman/events{/privacy}","received_events_url":"https://api.github.com/users/lizagilman/received_events","type":"User","site_admin":false},"repo":{"id":79233326,"node_id":"MDEwOlJlcG9zaXRvcnk3OTIzMzMyNg==","name":"foreman","full_name":"lizagilman/foreman","private":false,"owner":{"login":"lizagilman","id":15361156,"node_id":"MDQ6VXNlcjE1MzYxMTU2","avatar_url":"https://avatars1.githubusercontent.com/u/15361156?v=4","gravatar_id":"","url":"https://api.github.com/users/lizagilman","html_url":"https://github.com/lizagilman","followers_url":"https://api.github.com/users/lizagilman/followers","following_url":"https://api.github.com/users/lizagilman/following{/other_user}","gists_url":"https://api.github.com/users/lizagilman/gists{/gist_id}","starred_url":"https://api.github.com/users/lizagilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizagilman/subscriptions","organizations_url":"https://api.github.com/users/lizagilman/orgs","repos_url":"https://api.github.com/users/lizagilman/repos","events_url":"https://api.github.com/users/lizagilman/events{/privacy}","received_events_url":"https://api.github.com/users/lizagilman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lizagilman/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/lizagilman/foreman","forks_url":"https://api.github.com/repos/lizagilman/foreman/forks","keys_url":"https://api.github.com/repos/lizagilman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lizagilman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lizagilman/foreman/teams","hooks_url":"https://api.github.com/repos/lizagilman/foreman/hooks","issue_events_url":"https://api.github.com/repos/lizagilman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/lizagilman/foreman/events","assignees_url":"https://api.github.com/repos/lizagilman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/lizagilman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/lizagilman/foreman/tags","blobs_url":"https://api.github.com/repos/lizagilman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lizagilman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lizagilman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/lizagilman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lizagilman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/lizagilman/foreman/languages","stargazers_url":"https://api.github.com/repos/lizagilman/foreman/stargazers","contributors_url":"https://api.github.com/repos/lizagilman/foreman/contributors","subscribers_url":"https://api.github.com/repos/lizagilman/foreman/subscribers","subscription_url":"https://api.github.com/repos/lizagilman/foreman/subscription","commits_url":"https://api.github.com/repos/lizagilman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/lizagilman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/lizagilman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/lizagilman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/lizagilman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/lizagilman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lizagilman/foreman/merges","archive_url":"https://api.github.com/repos/lizagilman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lizagilman/foreman/downloads","issues_url":"https://api.github.com/repos/lizagilman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/lizagilman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/lizagilman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/lizagilman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lizagilman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/lizagilman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/lizagilman/foreman/deployments","created_at":"2017-01-17T14:03:42Z","updated_at":"2017-01-17T14:03:49Z","pushed_at":"2018-10-25T15:41:24Z","git_url":"git://github.com/lizagilman/foreman.git","ssh_url":"git@github.com:lizagilman/foreman.git","clone_url":"https://github.com/lizagilman/foreman.git","svn_url":"https://github.com/lizagilman/foreman","homepage":"http://theforeman.org","size":71812,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"0c08b71336684e60669fe952ca65e36bd4f7c133","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg3NTA=","name":"foreman","full_name":"theforeman/foreman","private":false,"owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2018-10-28T10:07:03Z","pushed_at":"2018-10-28T12:57:24Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":83599,"stargazers_count":1524,"watchers_count":1524,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":762,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":762,"open_issues":115,"watchers":1524,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5718"},"html":{"href":"https://github.com/theforeman/foreman/pull/5718"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/5718"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/5718/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5718/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5718/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/8eacd55b7cab85e8872dcd6768cfc66deae22785"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"amirfefer"}}