{"action":"created","comment":{"url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments/187289000","pull_request_review_id":119031071,"id":187289000,"diff_hunk":"@@ -512,13 +727,13 @@ _.assign(Response, /** @lends Response */ {\n         if (!(type && _.isString(type))) { return; }\n \n         var normalised = mimeFormat.lookup(type),\n-            info = {};\n-\n+            info = {},\n+            fileNameObj = parseContentDispositionHeader(disposition, normalised.source);\n         _.assign(info, {\n             type: normalised.type, // sanitised mime type base\n             format: normalised.format, // format specific to the type returned\n-            name: DEFAULT_RESPONSE_FILENAME, // @todo - get from disposition\n-            ext: mimeType.extension(normalised.source) || E, // file extension from sanitised content type\n+            name: fileNameObj.name,","path":"lib/collection/response.js","position":248,"original_position":241,"commit_id":"5cc52d0467a9719e63327a40b1e2f91a03b40c1f","original_commit_id":"161a8449c2fbe3dec934752501543ec4c3df4935","user":{"login":"kamalaknn","id":8401064,"avatar_url":"https://avatars3.githubusercontent.com/u/8401064?v=4","gravatar_id":"","url":"https://api.github.com/users/kamalaknn","html_url":"https://github.com/kamalaknn","followers_url":"https://api.github.com/users/kamalaknn/followers","following_url":"https://api.github.com/users/kamalaknn/following{/other_user}","gists_url":"https://api.github.com/users/kamalaknn/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalaknn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalaknn/subscriptions","organizations_url":"https://api.github.com/users/kamalaknn/orgs","repos_url":"https://api.github.com/users/kamalaknn/repos","events_url":"https://api.github.com/users/kamalaknn/events{/privacy}","received_events_url":"https://api.github.com/users/kamalaknn/received_events","type":"User","site_admin":false},"body":"`fileNameObj` -> `parsedFileName`","created_at":"2018-05-10T10:00:43Z","updated_at":"2018-05-10T10:35:14Z","html_url":"https://github.com/postmanlabs/postman-collection/pull/633#discussion_r187289000","pull_request_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments/187289000"},"html":{"href":"https://github.com/postmanlabs/postman-collection/pull/633#discussion_r187289000"},"pull_request":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633"}}},"pull_request":{"url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633","id":186322253,"html_url":"https://github.com/postmanlabs/postman-collection/pull/633","diff_url":"https://github.com/postmanlabs/postman-collection/pull/633.diff","patch_url":"https://github.com/postmanlabs/postman-collection/pull/633.patch","issue_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/633","number":633,"state":"open","locked":false,"title":"Extract and decode filename from content-disposition header","user":{"login":"dhineshwiz","id":10631268,"avatar_url":"https://avatars2.githubusercontent.com/u/10631268?v=4","gravatar_id":"","url":"https://api.github.com/users/dhineshwiz","html_url":"https://github.com/dhineshwiz","followers_url":"https://api.github.com/users/dhineshwiz/followers","following_url":"https://api.github.com/users/dhineshwiz/following{/other_user}","gists_url":"https://api.github.com/users/dhineshwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/dhineshwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhineshwiz/subscriptions","organizations_url":"https://api.github.com/users/dhineshwiz/orgs","repos_url":"https://api.github.com/users/dhineshwiz/repos","events_url":"https://api.github.com/users/dhineshwiz/events{/privacy}","received_events_url":"https://api.github.com/users/dhineshwiz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-07T11:14:38Z","updated_at":"2018-05-10T10:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84a0b091cef6c4d17a48db865b0467effa6ece65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SamvelRaja","id":5114052,"avatar_url":"https://avatars1.githubusercontent.com/u/5114052?v=4","gravatar_id":"","url":"https://api.github.com/users/SamvelRaja","html_url":"https://github.com/SamvelRaja","followers_url":"https://api.github.com/users/SamvelRaja/followers","following_url":"https://api.github.com/users/SamvelRaja/following{/other_user}","gists_url":"https://api.github.com/users/SamvelRaja/gists{/gist_id}","starred_url":"https://api.github.com/users/SamvelRaja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamvelRaja/subscriptions","organizations_url":"https://api.github.com/users/SamvelRaja/orgs","repos_url":"https://api.github.com/users/SamvelRaja/repos","events_url":"https://api.github.com/users/SamvelRaja/events{/privacy}","received_events_url":"https://api.github.com/users/SamvelRaja/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633/commits","review_comments_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633/comments","review_comment_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/633/comments","statuses_url":"https://api.github.com/repos/postmanlabs/postman-collection/statuses/5cc52d0467a9719e63327a40b1e2f91a03b40c1f","head":{"label":"dhineshwiz:feature/parse-content-dispostion-header","ref":"feature/parse-content-dispostion-header","sha":"5cc52d0467a9719e63327a40b1e2f91a03b40c1f","user":{"login":"dhineshwiz","id":10631268,"avatar_url":"https://avatars2.githubusercontent.com/u/10631268?v=4","gravatar_id":"","url":"https://api.github.com/users/dhineshwiz","html_url":"https://github.com/dhineshwiz","followers_url":"https://api.github.com/users/dhineshwiz/followers","following_url":"https://api.github.com/users/dhineshwiz/following{/other_user}","gists_url":"https://api.github.com/users/dhineshwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/dhineshwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhineshwiz/subscriptions","organizations_url":"https://api.github.com/users/dhineshwiz/orgs","repos_url":"https://api.github.com/users/dhineshwiz/repos","events_url":"https://api.github.com/users/dhineshwiz/events{/privacy}","received_events_url":"https://api.github.com/users/dhineshwiz/received_events","type":"User","site_admin":false},"repo":{"id":130977949,"name":"postman-collection","full_name":"dhineshwiz/postman-collection","owner":{"login":"dhineshwiz","id":10631268,"avatar_url":"https://avatars2.githubusercontent.com/u/10631268?v=4","gravatar_id":"","url":"https://api.github.com/users/dhineshwiz","html_url":"https://github.com/dhineshwiz","followers_url":"https://api.github.com/users/dhineshwiz/followers","following_url":"https://api.github.com/users/dhineshwiz/following{/other_user}","gists_url":"https://api.github.com/users/dhineshwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/dhineshwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhineshwiz/subscriptions","organizations_url":"https://api.github.com/users/dhineshwiz/orgs","repos_url":"https://api.github.com/users/dhineshwiz/repos","events_url":"https://api.github.com/users/dhineshwiz/events{/privacy}","received_events_url":"https://api.github.com/users/dhineshwiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhineshwiz/postman-collection","description":"Javascript module that allows a developer to work with Postman Collections","fork":true,"url":"https://api.github.com/repos/dhineshwiz/postman-collection","forks_url":"https://api.github.com/repos/dhineshwiz/postman-collection/forks","keys_url":"https://api.github.com/repos/dhineshwiz/postman-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhineshwiz/postman-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhineshwiz/postman-collection/teams","hooks_url":"https://api.github.com/repos/dhineshwiz/postman-collection/hooks","issue_events_url":"https://api.github.com/repos/dhineshwiz/postman-collection/issues/events{/number}","events_url":"https://api.github.com/repos/dhineshwiz/postman-collection/events","assignees_url":"https://api.github.com/repos/dhineshwiz/postman-collection/assignees{/user}","branches_url":"https://api.github.com/repos/dhineshwiz/postman-collection/branches{/branch}","tags_url":"https://api.github.com/repos/dhineshwiz/postman-collection/tags","blobs_url":"https://api.github.com/repos/dhineshwiz/postman-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhineshwiz/postman-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhineshwiz/postman-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhineshwiz/postman-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhineshwiz/postman-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/dhineshwiz/postman-collection/languages","stargazers_url":"https://api.github.com/repos/dhineshwiz/postman-collection/stargazers","contributors_url":"https://api.github.com/repos/dhineshwiz/postman-collection/contributors","subscribers_url":"https://api.github.com/repos/dhineshwiz/postman-collection/subscribers","subscription_url":"https://api.github.com/repos/dhineshwiz/postman-collection/subscription","commits_url":"https://api.github.com/repos/dhineshwiz/postman-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhineshwiz/postman-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhineshwiz/postman-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhineshwiz/postman-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhineshwiz/postman-collection/contents/{+path}","compare_url":"https://api.github.com/repos/dhineshwiz/postman-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhineshwiz/postman-collection/merges","archive_url":"https://api.github.com/repos/dhineshwiz/postman-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhineshwiz/postman-collection/downloads","issues_url":"https://api.github.com/repos/dhineshwiz/postman-collection/issues{/number}","pulls_url":"https://api.github.com/repos/dhineshwiz/postman-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/dhineshwiz/postman-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/dhineshwiz/postman-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhineshwiz/postman-collection/labels{/name}","releases_url":"https://api.github.com/repos/dhineshwiz/postman-collection/releases{/id}","deployments_url":"https://api.github.com/repos/dhineshwiz/postman-collection/deployments","created_at":"2018-04-25T08:51:48Z","updated_at":"2018-04-25T08:51:50Z","pushed_at":"2018-05-10T10:09:28Z","git_url":"git://github.com/dhineshwiz/postman-collection.git","ssh_url":"git@github.com:dhineshwiz/postman-collection.git","clone_url":"https://github.com/dhineshwiz/postman-collection.git","svn_url":"https://github.com/dhineshwiz/postman-collection","homepage":"https://www.getpostman.com/","size":2069,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"postmanlabs:develop","ref":"develop","sha":"fea5a446df28e7c71e8a87f6b9d1537e23525b1e","user":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars2.githubusercontent.com/u/10251060?v=4","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":52270857,"name":"postman-collection","full_name":"postmanlabs/postman-collection","owner":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars2.githubusercontent.com/u/10251060?v=4","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmanlabs/postman-collection","description":"Javascript module that allows a developer to work with Postman Collections","fork":false,"url":"https://api.github.com/repos/postmanlabs/postman-collection","forks_url":"https://api.github.com/repos/postmanlabs/postman-collection/forks","keys_url":"https://api.github.com/repos/postmanlabs/postman-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmanlabs/postman-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmanlabs/postman-collection/teams","hooks_url":"https://api.github.com/repos/postmanlabs/postman-collection/hooks","issue_events_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/events{/number}","events_url":"https://api.github.com/repos/postmanlabs/postman-collection/events","assignees_url":"https://api.github.com/repos/postmanlabs/postman-collection/assignees{/user}","branches_url":"https://api.github.com/repos/postmanlabs/postman-collection/branches{/branch}","tags_url":"https://api.github.com/repos/postmanlabs/postman-collection/tags","blobs_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmanlabs/postman-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/postmanlabs/postman-collection/languages","stargazers_url":"https://api.github.com/repos/postmanlabs/postman-collection/stargazers","contributors_url":"https://api.github.com/repos/postmanlabs/postman-collection/contributors","subscribers_url":"https://api.github.com/repos/postmanlabs/postman-collection/subscribers","subscription_url":"https://api.github.com/repos/postmanlabs/postman-collection/subscription","commits_url":"https://api.github.com/repos/postmanlabs/postman-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmanlabs/postman-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmanlabs/postman-collection/contents/{+path}","compare_url":"https://api.github.com/repos/postmanlabs/postman-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmanlabs/postman-collection/merges","archive_url":"https://api.github.com/repos/postmanlabs/postman-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmanlabs/postman-collection/downloads","issues_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues{/number}","pulls_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/postmanlabs/postman-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/postmanlabs/postman-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmanlabs/postman-collection/labels{/name}","releases_url":"https://api.github.com/repos/postmanlabs/postman-collection/releases{/id}","deployments_url":"https://api.github.com/repos/postmanlabs/postman-collection/deployments","created_at":"2016-02-22T12:08:36Z","updated_at":"2018-05-09T09:52:17Z","pushed_at":"2018-05-10T10:09:30Z","git_url":"git://github.com/postmanlabs/postman-collection.git","ssh_url":"git@github.com:postmanlabs/postman-collection.git","clone_url":"https://github.com/postmanlabs/postman-collection.git","svn_url":"https://github.com/postmanlabs/postman-collection","homepage":"https://www.getpostman.com/","size":1953,"stargazers_count":89,"watchers_count":89,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":40,"open_issues":35,"watchers":89,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633"},"html":{"href":"https://github.com/postmanlabs/postman-collection/pull/633"},"issue":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/issues/633"},"comments":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/statuses/5cc52d0467a9719e63327a40b1e2f91a03b40c1f"}},"author_association":"NONE"}}
{"actor":{"display_login":"kamalaknn"}}