{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/238067133","pull_request_review_id":180527780,"id":238067133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA2NzEzMw==","diff_hunk":"@@ -257,6 +267,26 @@ IPCCommandResult WFSI::IOCtl(const IOCtlRequest& request)\n   case IOCTL_WFSI_FINALIZE_TITLE_INSTALL:\n   {\n     std::string tmd_path;\n+    if (m_patch_type == PATCH_TYPE_2)\n+    {\n+      // Delete content's default.dol\n+      const std::string title_content_dir =\n+          StringFromFormat(\"/vol/%s/title/%s/%s/content/\", m_device_name.c_str(),\n+                           m_current_group_id_str.c_str(), m_current_title_id_str.c_str());\n+      File::Delete(WFS::NativePath(title_content_dir + \"default.dol\"));\n+\n+      // Copy content's _default.dol to patch's directory\n+      const std::string patch_dir =\n+          StringFromFormat(\"/vol/%s/title/%s/%s/_patch/\", m_device_name.c_str(),\n+                           m_current_group_id_str.c_str(), m_current_title_id_str.c_str());\n+      const std::string patch_content_dir = patch_dir + \"content/\";\n+      File::CreateDir(WFS::NativePath(patch_dir));\n+      File::CreateDir(WFS::NativePath(patch_content_dir));\n+      File::Rename(WFS::NativePath(title_content_dir + \"_default.dol\"),\n+                   WFS::NativePath(patch_content_dir + \"default.dol\"));\n+\n+      FinalizePatchInstall();","path":"Source/Core/Core/IOS/WFS/WFSI.cpp","position":46,"original_position":46,"commit_id":"3d81e8fae96e60995386204146e89283edfb9641","original_commit_id":"3d81e8fae96e60995386204146e89283edfb9641","user":{"login":"sepalani","id":7890055,"node_id":"MDQ6VXNlcjc4OTAwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7890055?v=4","gravatar_id":"","url":"https://api.github.com/users/sepalani","html_url":"https://github.com/sepalani","followers_url":"https://api.github.com/users/sepalani/followers","following_url":"https://api.github.com/users/sepalani/following{/other_user}","gists_url":"https://api.github.com/users/sepalani/gists{/gist_id}","starred_url":"https://api.github.com/users/sepalani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepalani/subscriptions","organizations_url":"https://api.github.com/users/sepalani/orgs","repos_url":"https://api.github.com/users/sepalani/repos","events_url":"https://api.github.com/users/sepalani/events{/privacy}","received_events_url":"https://api.github.com/users/sepalani/received_events","type":"User","site_admin":false},"body":"I can't find any log of `IOCTL_WFSI_FINALIZE_PATCH_INSTALL` for titles other than S4MJGD (DQXv1). It seems DQXv2 (S4SJGD) and above don't rely on that IOCtl.","created_at":"2018-12-01T15:37:16Z","updated_at":"2018-12-01T15:37:16Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/7598#discussion_r238067133","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/238067133"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7598#discussion_r238067133"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598"}},"in_reply_to_id":238066033},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598","id":235180822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTgwODIy","html_url":"https://github.com/dolphin-emu/dolphin/pull/7598","diff_url":"https://github.com/dolphin-emu/dolphin/pull/7598.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/7598.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7598","number":7598,"state":"open","locked":false,"title":"WFSI: Fix Dragon Quest X (all-in-one, v2, v3) installers","user":{"login":"sepalani","id":7890055,"node_id":"MDQ6VXNlcjc4OTAwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7890055?v=4","gravatar_id":"","url":"https://api.github.com/users/sepalani","html_url":"https://github.com/sepalani","followers_url":"https://api.github.com/users/sepalani/followers","following_url":"https://api.github.com/users/sepalani/following{/other_user}","gists_url":"https://api.github.com/users/sepalani/gists{/gist_id}","starred_url":"https://api.github.com/users/sepalani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepalani/subscriptions","organizations_url":"https://api.github.com/users/sepalani/orgs","repos_url":"https://api.github.com/users/sepalani/repos","events_url":"https://api.github.com/users/sepalani/events{/privacy}","received_events_url":"https://api.github.com/users/sepalani/received_events","type":"User","site_admin":false},"body":"This PR implements WFSI's IOCtl 0x18 which is necessary for Dragon Quest X installers (the ones after version 1) to complete.\r\n\r\n~~However, there's still one flaw. At the moment, these installers don't move back `_default.dol` to `default.dol`. I think, it's irrelevant to that PR/IOCtl but I'm going to double check just to be sure.~~ *(Fixed by the 2nd commit)*\r\n\r\nRegardless, it allows to install properly DQX v2 and v3 on Dolphin. ~~You'll also need to bump up the IOS version to boot the new DQX channel, otherwise you'll have ERROR 002 (I'm preparing a PR for that one).~~ *(Fixed by the 3rd commit)*\r\n\r\nPing @delroth & @leoetlino since you both worked on the WFS implementation.\r\n\r\nReady to be reviewed.","created_at":"2018-12-01T08:49:45Z","updated_at":"2018-12-01T15:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fdc5a37bb7da44685b96e9c110d750ebdfe8409","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7598/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3d81e8fae96e60995386204146e89283edfb9641","head":{"label":"sepalani:wfsi","ref":"wfsi","sha":"3d81e8fae96e60995386204146e89283edfb9641","user":{"login":"sepalani","id":7890055,"node_id":"MDQ6VXNlcjc4OTAwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7890055?v=4","gravatar_id":"","url":"https://api.github.com/users/sepalani","html_url":"https://github.com/sepalani","followers_url":"https://api.github.com/users/sepalani/followers","following_url":"https://api.github.com/users/sepalani/following{/other_user}","gists_url":"https://api.github.com/users/sepalani/gists{/gist_id}","starred_url":"https://api.github.com/users/sepalani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepalani/subscriptions","organizations_url":"https://api.github.com/users/sepalani/orgs","repos_url":"https://api.github.com/users/sepalani/repos","events_url":"https://api.github.com/users/sepalani/events{/privacy}","received_events_url":"https://api.github.com/users/sepalani/received_events","type":"User","site_admin":false},"repo":{"id":36597702,"node_id":"MDEwOlJlcG9zaXRvcnkzNjU5NzcwMg==","name":"dolphin","full_name":"sepalani/dolphin","private":false,"owner":{"login":"sepalani","id":7890055,"node_id":"MDQ6VXNlcjc4OTAwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7890055?v=4","gravatar_id":"","url":"https://api.github.com/users/sepalani","html_url":"https://github.com/sepalani","followers_url":"https://api.github.com/users/sepalani/followers","following_url":"https://api.github.com/users/sepalani/following{/other_user}","gists_url":"https://api.github.com/users/sepalani/gists{/gist_id}","starred_url":"https://api.github.com/users/sepalani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepalani/subscriptions","organizations_url":"https://api.github.com/users/sepalani/orgs","repos_url":"https://api.github.com/users/sepalani/repos","events_url":"https://api.github.com/users/sepalani/events{/privacy}","received_events_url":"https://api.github.com/users/sepalani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sepalani/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/sepalani/dolphin","forks_url":"https://api.github.com/repos/sepalani/dolphin/forks","keys_url":"https://api.github.com/repos/sepalani/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sepalani/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sepalani/dolphin/teams","hooks_url":"https://api.github.com/repos/sepalani/dolphin/hooks","issue_events_url":"https://api.github.com/repos/sepalani/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/sepalani/dolphin/events","assignees_url":"https://api.github.com/repos/sepalani/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/sepalani/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/sepalani/dolphin/tags","blobs_url":"https://api.github.com/repos/sepalani/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sepalani/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sepalani/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sepalani/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sepalani/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/sepalani/dolphin/languages","stargazers_url":"https://api.github.com/repos/sepalani/dolphin/stargazers","contributors_url":"https://api.github.com/repos/sepalani/dolphin/contributors","subscribers_url":"https://api.github.com/repos/sepalani/dolphin/subscribers","subscription_url":"https://api.github.com/repos/sepalani/dolphin/subscription","commits_url":"https://api.github.com/repos/sepalani/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sepalani/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sepalani/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sepalani/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sepalani/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/sepalani/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sepalani/dolphin/merges","archive_url":"https://api.github.com/repos/sepalani/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sepalani/dolphin/downloads","issues_url":"https://api.github.com/repos/sepalani/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/sepalani/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/sepalani/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/sepalani/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sepalani/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/sepalani/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/sepalani/dolphin/deployments","created_at":"2015-05-31T10:13:24Z","updated_at":"2018-11-30T18:52:19Z","pushed_at":"2018-12-01T14:35:12Z","git_url":"git://github.com/sepalani/dolphin.git","ssh_url":"git@github.com:sepalani/dolphin.git","clone_url":"https://github.com/sepalani/dolphin.git","svn_url":"https://github.com/sepalani/dolphin","homepage":"https://dolphin-emu.org/","size":332175,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"8f2d4c1b5dad0b324e8975487266ab8fee937924","user":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NzMwNA==","name":"dolphin","full_name":"dolphin-emu/dolphin","private":false,"owner":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2018-12-01T10:57:55Z","pushed_at":"2018-12-01T14:35:14Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":370710,"stargazers_count":4858,"watchers_count":4858,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1139,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1139,"open_issues":117,"watchers":4858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/7598"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7598"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7598/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7598/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3d81e8fae96e60995386204146e89283edfb9641"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sepalani"}}