{"action":"created","issue":{"url":"https://api.github.com/repos/tikki-fi/tikki-app/issues/12","repository_url":"https://api.github.com/repos/tikki-fi/tikki-app","labels_url":"https://api.github.com/repos/tikki-fi/tikki-app/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/tikki-fi/tikki-app/issues/12/comments","events_url":"https://api.github.com/repos/tikki-fi/tikki-app/issues/12/events","html_url":"https://github.com/tikki-fi/tikki-app/pull/12","id":389954517,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODI3ODk5","number":12,"title":"Refactor cleanup","user":{"login":"IlmariKu","id":39652086,"node_id":"MDQ6VXNlcjM5NjUyMDg2","avatar_url":"https://avatars1.githubusercontent.com/u/39652086?v=4","gravatar_id":"","url":"https://api.github.com/users/IlmariKu","html_url":"https://github.com/IlmariKu","followers_url":"https://api.github.com/users/IlmariKu/followers","following_url":"https://api.github.com/users/IlmariKu/following{/other_user}","gists_url":"https://api.github.com/users/IlmariKu/gists{/gist_id}","starred_url":"https://api.github.com/users/IlmariKu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlmariKu/subscriptions","organizations_url":"https://api.github.com/users/IlmariKu/orgs","repos_url":"https://api.github.com/users/IlmariKu/repos","events_url":"https://api.github.com/users/IlmariKu/events{/privacy}","received_events_url":"https://api.github.com/users/IlmariKu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-11T21:08:54Z","updated_at":"2018-12-12T07:56:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tikki-fi/tikki-app/pulls/12","html_url":"https://github.com/tikki-fi/tikki-app/pull/12","diff_url":"https://github.com/tikki-fi/tikki-app/pull/12.diff","patch_url":"https://github.com/tikki-fi/tikki-app/pull/12.patch"},"body":"- Linted the JS-codebase, below are some things which came to mind while fixing and thought i could share them.\r\n- - **TODO-DEBUG** now reads after every line where i didn't want to make a change to possible functionality, but it would be good if you'd check those out\r\n- - Would suggest you to add a mandatory linter to the project if possible, used js-hint myself with Atom. Lots of redundant code and styling errors.\r\n- - Lots of spacebar + tabs-combinations, always use tabs\r\n- - 5 if's --> 1 if and 4 else if, this will be significant on bigger scale & flow control\r\n- - Commented out code shouldn't be on repo, only while debugging or working on a branch\r\n- - if you want to return a true/false from function result, just return the answer without if-else\r\n- - Ternary-operators, they're really good in terms of saving space\r\n\r\nfixes #9 \r\n"},"comment":{"url":"https://api.github.com/repos/tikki-fi/tikki-app/issues/comments/446495429","html_url":"https://github.com/tikki-fi/tikki-app/pull/12#issuecomment-446495429","issue_url":"https://api.github.com/repos/tikki-fi/tikki-app/issues/12","id":446495429,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ5NTQyOQ==","user":{"login":"IlmariKu","id":39652086,"node_id":"MDQ6VXNlcjM5NjUyMDg2","avatar_url":"https://avatars1.githubusercontent.com/u/39652086?v=4","gravatar_id":"","url":"https://api.github.com/users/IlmariKu","html_url":"https://github.com/IlmariKu","followers_url":"https://api.github.com/users/IlmariKu/followers","following_url":"https://api.github.com/users/IlmariKu/following{/other_user}","gists_url":"https://api.github.com/users/IlmariKu/gists{/gist_id}","starred_url":"https://api.github.com/users/IlmariKu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlmariKu/subscriptions","organizations_url":"https://api.github.com/users/IlmariKu/orgs","repos_url":"https://api.github.com/users/IlmariKu/repos","events_url":"https://api.github.com/users/IlmariKu/events{/privacy}","received_events_url":"https://api.github.com/users/IlmariKu/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T07:56:42Z","updated_at":"2018-12-12T07:56:42Z","author_association":"CONTRIBUTOR","body":"I did do a regular pull on the repo and figured that if the head is at the same point it's fine. The previous PR was from master-branch and this one from its own branch. I'll msg you on Slack later on the evening if need"}}
{"actor":{"display_login":"IlmariKu"}}