{"action":"created","issue":{"url":"https://api.github.com/repos/rchain/rchain/issues/1545","repository_url":"https://api.github.com/repos/rchain/rchain","labels_url":"https://api.github.com/repos/rchain/rchain/issues/1545/labels{/name}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1545/comments","events_url":"https://api.github.com/repos/rchain/rchain/issues/1545/events","html_url":"https://github.com/rchain/rchain/pull/1545","id":363287633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzYyNTUy","number":1545,"title":"Add ChargingRSpace","user":{"login":"goral09","id":5120801,"node_id":"MDQ6VXNlcjUxMjA4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false},"assignees":[{"login":"ArturGajowy","id":460141,"node_id":"MDQ6VXNlcjQ2MDE0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460141?v=4","gravatar_id":"","url":"https://api.github.com/users/ArturGajowy","html_url":"https://github.com/ArturGajowy","followers_url":"https://api.github.com/users/ArturGajowy/followers","following_url":"https://api.github.com/users/ArturGajowy/following{/other_user}","gists_url":"https://api.github.com/users/ArturGajowy/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturGajowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturGajowy/subscriptions","organizations_url":"https://api.github.com/users/ArturGajowy/orgs","repos_url":"https://api.github.com/users/ArturGajowy/repos","events_url":"https://api.github.com/users/ArturGajowy/events{/privacy}","received_events_url":"https://api.github.com/users/ArturGajowy/received_events","type":"User","site_admin":false},{"login":"guardbotmk3","id":33846152,"node_id":"MDQ6VXNlcjMzODQ2MTUy","avatar_url":"https://avatars1.githubusercontent.com/u/33846152?v=4","gravatar_id":"","url":"https://api.github.com/users/guardbotmk3","html_url":"https://github.com/guardbotmk3","followers_url":"https://api.github.com/users/guardbotmk3/followers","following_url":"https://api.github.com/users/guardbotmk3/following{/other_user}","gists_url":"https://api.github.com/users/guardbotmk3/gists{/gist_id}","starred_url":"https://api.github.com/users/guardbotmk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardbotmk3/subscriptions","organizations_url":"https://api.github.com/users/guardbotmk3/orgs","repos_url":"https://api.github.com/users/guardbotmk3/repos","events_url":"https://api.github.com/users/guardbotmk3/events{/privacy}","received_events_url":"https://api.github.com/users/guardbotmk3/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-24T19:28:07Z","updated_at":"2018-09-24T20:50:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1545","html_url":"https://github.com/rchain/rchain/pull/1545","diff_url":"https://github.com/rchain/rchain/pull/1545.diff","patch_url":"https://github.com/rchain/rchain/pull/1545.patch"},"body":"## Overview\r\nAdds `ChargingRSpace` that encapsulates the logic of charging for interaction with the RSpace. It also replaces the `PureRSpace` with `ChargingRSpace` in `Registry` and `TuplespaceAlg`. \r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nAdd link to corresponding JIRA issue.\r\n\r\n### Complete this checklist before you submit the PR\r\n- [ ] This PR contains no more than 200 lines of code, excluding test code.\r\n- [ ] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [ ] You assigned one person to review this PR\r\n\r\n### If you are not a member of the core development team, please confirm:\r\n- [ ] You signed the commit. Merging requires a signature. Please see the [developer wiki](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain) for instructions.\r\n- [ ] Your GitHub account is also an account with [Travis CI](https://travis-ci.org). Unit tests will not run on your PR unless you have an account with Travis. Merge requires passed unit tests.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n"},"comment":{"url":"https://api.github.com/repos/rchain/rchain/issues/comments/424120235","html_url":"https://github.com/rchain/rchain/pull/1545#issuecomment-424120235","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1545","id":424120235,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDEyMDIzNQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/marketplace/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-24T20:50:36Z","updated_at":"2018-09-24T20:50:36Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=h1) Report\n> Merging [#1545](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=desc) into [dev](https://codecov.io/gh/rchain/rchain/commit/8e7c2548aab8999a9af58d447e86b7fd3270af0a?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `88%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/rchain/rchain/pull/1545/graphs/tree.svg?width=650&token=MnvcTlDgD0&height=150&src=pr)](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##              dev    #1545      +/-   ##\n==========================================\n- Coverage   70.87%   70.85%   -0.03%     \n==========================================\n  Files         246      247       +1     \n  Lines        9763     9774      +11     \n  Branches      655      658       +3     \n==========================================\n+ Hits         6920     6925       +5     \n- Misses       2843     2849       +6\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #blockstorage | `93.44% <ø> (ø)` | :arrow_up: |\n| #casper | `79.74% <ø> (ø)` | :arrow_up: |\n| #comm | `53.25% <ø> (ø)` | :arrow_up: |\n| #crypto | `91.27% <ø> (ø)` | :arrow_up: |\n| #node | `1.96% <ø> (ø)` | :arrow_up: |\n| #rholang | `83.69% <88%> (-0.13%)` | :arrow_down: |\n| #roscala | `84.76% <ø> (ø)` | :arrow_up: |\n| #rspace | `86.25% <ø> (-0.07%)` | :arrow_down: |\n| #shared | `60.37% <ø> (ø)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...ala/coop/rchain/rholang/interpreter/dispatch.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL2Rpc3BhdGNoLnNjYWxh) | `76.92% <ø> (-1.65%)` | :arrow_down: |\n| [...ain/scala/coop/rchain/rspace/pure/PureRSpace.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cnNwYWNlL3NyYy9tYWluL3NjYWxhL2Nvb3AvcmNoYWluL3JzcGFjZS9wdXJlL1B1cmVSU3BhY2Uuc2NhbGE=) | `50% <ø> (-12.5%)` | :arrow_down: |\n| [...cala/coop/rchain/rholang/interpreter/Runtime.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL1J1bnRpbWUuc2NhbGE=) | `92.22% <100%> (+0.08%)` | :arrow_up: |\n| [...rchain/rholang/interpreter/storage/implicits.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL3N0b3JhZ2UvaW1wbGljaXRzLnNjYWxh) | `95.23% <100%> (+0.23%)` | :arrow_up: |\n| [...ang/interpreter/accounting/CostAccountingAlg.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL2FjY291bnRpbmcvQ29zdEFjY291bnRpbmdBbGcuc2NhbGE=) | `100% <100%> (ø)` | :arrow_up: |\n| [...scala/coop/rchain/rholang/interpreter/Reduce.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL1JlZHVjZS5zY2FsYQ==) | `82.72% <100%> (-0.25%)` | :arrow_down: |\n| [...p/rchain/rholang/interpreter/SystemProcesses.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL1N5c3RlbVByb2Nlc3Nlcy5zY2FsYQ==) | `68.96% <100%> (+1.1%)` | :arrow_up: |\n| [...in/rholang/interpreter/storage/TuplespaceAlg.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL3N0b3JhZ2UvVHVwbGVzcGFjZUFsZy5zY2FsYQ==) | `85% <84.61%> (-11.97%)` | :arrow_down: |\n| [...n/rholang/interpreter/storage/ChargingRSpace.scala](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree#diff-cmhvbGFuZy9zcmMvbWFpbi9zY2FsYS9jb29wL3JjaGFpbi9yaG9sYW5nL2ludGVycHJldGVyL3N0b3JhZ2UvQ2hhcmdpbmdSU3BhY2Uuc2NhbGE=) | `86.66% <86.66%> (ø)` | |\n| ... and [1 more](https://codecov.io/gh/rchain/rchain/pull/1545/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=footer). Last update [8e7c254...4354e3b](https://codecov.io/gh/rchain/rchain/pull/1545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}