{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20321","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20321/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20321/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20321/events","html_url":"https://github.com/joomla/joomla-cms/pull/20321","id":321469104,"number":20321,"title":"[Deprecate _QQ_ 3] Mark _QQ_ as deprecated and normalize language ini parsing","user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-09T08:00:40Z","updated_at":"2018-05-09T17:34:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20321","html_url":"https://github.com/joomla/joomla-cms/pull/20321","diff_url":"https://github.com/joomla/joomla-cms/pull/20321.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20321.patch"},"body":"This is a redo of #13451 ### Summary of Changes\r\n\r\nAs discussed in https://github.com/joomla/joomla-cms/issues/13421\r\n\r\nDeprecate `_QQ_` and normalize parsing of ini language files.\r\n- creates a new method JLanguageHelper::parseIniFile and marks LanguagesHelper::parseFile (helper of com_languages) as deprecated.\r\n- makes the necessary adaptations\r\n\r\n### Testing Instructions\r\n\r\n1. Apply patch\r\n\r\n2. Check all language strings show as usual. Including the ones with `\"_QQ_\"`\r\n\r\n3. Confirm language debug still works.\r\nEnable debug language in global config and system debug plugin.manually make some parsing errors in the en-GB.ini file and reload the page\r\n\r\n4. Confirm language overrrides still works.\r\nFor instance, load a language string that uses escaped quotes (ex: JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED) and make some changes in the override. Save it and load it again to check if ok.\r\n\r\n5. Confirm quoting in server side and client side still works (ex: add to isis template index.php)\r\n```php\r\n$app->enqueueMessage('Server side Test 1 (click to proceed to Client side Test 3): ' . JText::_('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED'));\r\nJText::script('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED');\r\n$this->addScriptDeclaration(\"alert('Client side Test 1: ' + Joomla.JText._('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED'));\");\r\n$this->addScriptDeclaration(\"alert('Client side Test 2: \" . JText::_('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED', true) . \"');\");\r\n$this->addScriptDeclaration(\"window.addEventListener('click', function () { Joomla.renderMessages({'error': ['Client side Test 3: ' + Joomla.JText._('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED')]}) });\");\r\n```\r\n\r\n6. Any other test you could remember\r\n\r\n### Documentation Changes Required\r\n\r\nNone"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/387816300","html_url":"https://github.com/joomla/joomla-cms/pull/20321#issuecomment-387816300","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20321","id":387816300,"user":{"login":"ReLater","id":20780646,"avatar_url":"https://avatars2.githubusercontent.com/u/20780646?v=4","gravatar_id":"","url":"https://api.github.com/users/ReLater","html_url":"https://github.com/ReLater","followers_url":"https://api.github.com/users/ReLater/followers","following_url":"https://api.github.com/users/ReLater/following{/other_user}","gists_url":"https://api.github.com/users/ReLater/gists{/gist_id}","starred_url":"https://api.github.com/users/ReLater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReLater/subscriptions","organizations_url":"https://api.github.com/users/ReLater/orgs","repos_url":"https://api.github.com/users/ReLater/repos","events_url":"https://api.github.com/users/ReLater/events{/privacy}","received_events_url":"https://api.github.com/users/ReLater/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T17:34:48Z","updated_at":"2018-05-09T17:34:48Z","author_association":"CONTRIBUTOR","body":"I have tested this item :white_check_mark: successfully on 724b56f1833846cac3ded43516e394eaa1cc729c<br /><br />Tested with no changes in language files.\nTested after replacement of \"_QQ_\" with \\\" in all language files.\nTested with and without Debug Language mode.\ntested in FE and BE.<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/20321\">issues.joomla.org/tracker/joomla-cms/20321</a>.</sub>"}}
{"actor":{"display_login":"ReLater"}}