{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/21310","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21310/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21310/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21310/events","html_url":"https://github.com/pandas-dev/pandas/pull/21310","id":328960119,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzM1NDc0","number":21310,"title":"REGR: allow merging on object boolean columns","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"labels":[{"id":32815646,"node_id":"MDU6TGFiZWwzMjgxNTY0Ng==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Regression","name":"Regression","color":"e11d21","default":false},{"id":13098779,"node_id":"MDU6TGFiZWwxMzA5ODc3OQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Reshaping","name":"Reshaping","color":"02d7e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/56","html_url":"https://github.com/pandas-dev/pandas/milestone/56","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/56/labels","id":3267242,"node_id":"MDk6TWlsZXN0b25lMzI2NzI0Mg==","number":56,"title":"0.23.1","description":"","creator":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":93,"state":"open","created_at":"2018-04-14T14:52:46Z","updated_at":"2018-06-08T16:27:14Z","due_on":"2018-06-08T07:00:00Z","closed_at":null},"comments":20,"created_at":"2018-06-04T08:41:20Z","updated_at":"2018-06-08T16:31:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21310","html_url":"https://github.com/pandas-dev/pandas/pull/21310","diff_url":"https://github.com/pandas-dev/pandas/pull/21310.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/21310.patch"},"body":"Fixes https://github.com/pandas-dev/pandas/issues/21119\r\n\r\nThis is a quick/hacky fix for the specific case in that issue, i.e. merging boolean / object boolean columns. \r\n\r\nHowever, I have the feeling we should do a more general solution for cases where object dtyped columns might be actually mergeable. The problem is that inferring the type can be costly? (and eg when having actual strings object columns, this inferring was also unnecessary and thus will unneeded slow down `merge`?)"},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/395815785","html_url":"https://github.com/pandas-dev/pandas/pull/21310#issuecomment-395815785","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21310","id":395815785,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTgxNTc4NQ==","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T16:31:44Z","updated_at":"2018-06-08T16:31:44Z","author_association":"CONTRIBUTOR","body":"lgtm @jorisvandenbossche if you want to create an issue to show a warning as suggested above then ok, otherwise merge on pass."}}
{"actor":{"display_login":"jreback"}}