{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/comments/232203435","pull_request_review_id":173348111,"id":232203435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjIwMzQzNQ==","diff_hunk":"@@ -602,6 +602,7 @@ func indexesToLabels(indexOids []int, metric *config.Metric, oidToPdu map[string\n \t\t}\n \t\tif pdu, ok := oidToPdu[oid]; ok {\n \t\t\tlabels[lookup.Labelname] = pduValueAsString(&pdu, lookup.Type)\n+\t\t\tlabelOids[lookup.Labelname] = oidToList(labels[lookup.Labelname])","path":"collector.go","position":4,"original_position":4,"commit_id":"5e37265e38036e276061625831416bdc7e59c067","original_commit_id":"5e37265e38036e276061625831416bdc7e59c067","user":{"login":"brian-brazil","id":7115638,"node_id":"MDQ6VXNlcjcxMTU2Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7115638?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"You're presuming that the value is an oid, which isn't generally true.","created_at":"2018-11-09T10:15:34Z","updated_at":"2018-11-09T10:15:34Z","html_url":"https://github.com/prometheus/snmp_exporter/pull/352#discussion_r232203435","pull_request_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/comments/232203435"},"html":{"href":"https://github.com/prometheus/snmp_exporter/pull/352#discussion_r232203435"},"pull_request":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352","id":229473535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDczNTM1","html_url":"https://github.com/prometheus/snmp_exporter/pull/352","diff_url":"https://github.com/prometheus/snmp_exporter/pull/352.diff","patch_url":"https://github.com/prometheus/snmp_exporter/pull/352.patch","issue_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/352","number":352,"state":"open","locked":false,"title":"Add looked up labels into LabelOids to allow using new label as a label for lookup","user":{"login":"jon88","id":5424354,"node_id":"MDQ6VXNlcjU0MjQzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5424354?v=4","gravatar_id":"","url":"https://api.github.com/users/jon88","html_url":"https://github.com/jon88","followers_url":"https://api.github.com/users/jon88/followers","following_url":"https://api.github.com/users/jon88/following{/other_user}","gists_url":"https://api.github.com/users/jon88/gists{/gist_id}","starred_url":"https://api.github.com/users/jon88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon88/subscriptions","organizations_url":"https://api.github.com/users/jon88/orgs","repos_url":"https://api.github.com/users/jon88/repos","events_url":"https://api.github.com/users/jon88/events{/privacy}","received_events_url":"https://api.github.com/users/jon88/received_events","type":"User","site_admin":false},"body":"This allows to use a label which is generated by lookups to also be used in lookups.\r\nFor example: \r\n```\r\n  metrics:\r\n  - name: mpegVideoSessionState\r\n    oid: 1.3.6.1.4.1.5591.1.11.5.4.1.1.4.1.5\r\n    type: gauge\r\n    help: active means in-use, provisioned means not-in-use or active such as video\r\n      session provisioned for redundant source. - 1.3.6.1.4.1.5591.1.11.5.4.1.1.4.1.5\r\n    indexes:\r\n    - labelname: mpegVideoSessionIndex\r\n      type: gauge\r\n    lookups:\r\n    - labels:\r\n      - mpegVideoSessionIndex\r\n      - mpegVideoSessionIndex\r\n      labelname: mmpegOutputUdpDestinationIfIndex\r\n      oid: 1.3.6.1.4.1.5591.1.11.5.4.1.1.2.6.1.3\r\n      type: gauge\r\n    - labels:\r\n      - mmpegOutputUdpDestinationIfIndex\r\n      labelname: qamChannelFrequency\r\n      oid: 1.3.6.1.4.1.5591.1.11.5.3.1.1.1.1.1\r\n      type: gauge\r\n```\r\n","created_at":"2018-11-08T18:58:32Z","updated_at":"2018-11-09T10:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b22f4d38d9bf124e61914c41022975f6887e3e25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352/commits","review_comments_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352/comments","review_comment_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/352/comments","statuses_url":"https://api.github.com/repos/prometheus/snmp_exporter/statuses/5e37265e38036e276061625831416bdc7e59c067","head":{"label":"jon88:master","ref":"master","sha":"5e37265e38036e276061625831416bdc7e59c067","user":{"login":"jon88","id":5424354,"node_id":"MDQ6VXNlcjU0MjQzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5424354?v=4","gravatar_id":"","url":"https://api.github.com/users/jon88","html_url":"https://github.com/jon88","followers_url":"https://api.github.com/users/jon88/followers","following_url":"https://api.github.com/users/jon88/following{/other_user}","gists_url":"https://api.github.com/users/jon88/gists{/gist_id}","starred_url":"https://api.github.com/users/jon88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon88/subscriptions","organizations_url":"https://api.github.com/users/jon88/orgs","repos_url":"https://api.github.com/users/jon88/repos","events_url":"https://api.github.com/users/jon88/events{/privacy}","received_events_url":"https://api.github.com/users/jon88/received_events","type":"User","site_admin":false},"repo":{"id":156752815,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY3NTI4MTU=","name":"snmp_exporter","full_name":"jon88/snmp_exporter","private":false,"owner":{"login":"jon88","id":5424354,"node_id":"MDQ6VXNlcjU0MjQzNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5424354?v=4","gravatar_id":"","url":"https://api.github.com/users/jon88","html_url":"https://github.com/jon88","followers_url":"https://api.github.com/users/jon88/followers","following_url":"https://api.github.com/users/jon88/following{/other_user}","gists_url":"https://api.github.com/users/jon88/gists{/gist_id}","starred_url":"https://api.github.com/users/jon88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon88/subscriptions","organizations_url":"https://api.github.com/users/jon88/orgs","repos_url":"https://api.github.com/users/jon88/repos","events_url":"https://api.github.com/users/jon88/events{/privacy}","received_events_url":"https://api.github.com/users/jon88/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jon88/snmp_exporter","description":"SNMP Exporter for Prometheus","fork":true,"url":"https://api.github.com/repos/jon88/snmp_exporter","forks_url":"https://api.github.com/repos/jon88/snmp_exporter/forks","keys_url":"https://api.github.com/repos/jon88/snmp_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jon88/snmp_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jon88/snmp_exporter/teams","hooks_url":"https://api.github.com/repos/jon88/snmp_exporter/hooks","issue_events_url":"https://api.github.com/repos/jon88/snmp_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/jon88/snmp_exporter/events","assignees_url":"https://api.github.com/repos/jon88/snmp_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/jon88/snmp_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/jon88/snmp_exporter/tags","blobs_url":"https://api.github.com/repos/jon88/snmp_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jon88/snmp_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jon88/snmp_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jon88/snmp_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jon88/snmp_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/jon88/snmp_exporter/languages","stargazers_url":"https://api.github.com/repos/jon88/snmp_exporter/stargazers","contributors_url":"https://api.github.com/repos/jon88/snmp_exporter/contributors","subscribers_url":"https://api.github.com/repos/jon88/snmp_exporter/subscribers","subscription_url":"https://api.github.com/repos/jon88/snmp_exporter/subscription","commits_url":"https://api.github.com/repos/jon88/snmp_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jon88/snmp_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jon88/snmp_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jon88/snmp_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jon88/snmp_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/jon88/snmp_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jon88/snmp_exporter/merges","archive_url":"https://api.github.com/repos/jon88/snmp_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jon88/snmp_exporter/downloads","issues_url":"https://api.github.com/repos/jon88/snmp_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/jon88/snmp_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/jon88/snmp_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/jon88/snmp_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jon88/snmp_exporter/labels{/name}","releases_url":"https://api.github.com/repos/jon88/snmp_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/jon88/snmp_exporter/deployments","created_at":"2018-11-08T18:42:27Z","updated_at":"2018-11-08T18:59:28Z","pushed_at":"2018-11-08T18:59:26Z","git_url":"git://github.com/jon88/snmp_exporter.git","ssh_url":"git@github.com:jon88/snmp_exporter.git","clone_url":"https://github.com/jon88/snmp_exporter.git","svn_url":"https://github.com/jon88/snmp_exporter","homepage":null,"size":5748,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"4cc7adbf33a5bec7cfd1431145ede69dee4a8dd3","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":31185891,"node_id":"MDEwOlJlcG9zaXRvcnkzMTE4NTg5MQ==","name":"snmp_exporter","full_name":"prometheus/snmp_exporter","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/snmp_exporter","description":"SNMP Exporter for Prometheus","fork":false,"url":"https://api.github.com/repos/prometheus/snmp_exporter","forks_url":"https://api.github.com/repos/prometheus/snmp_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/snmp_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/snmp_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/snmp_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/snmp_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/snmp_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/snmp_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/snmp_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/snmp_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/snmp_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/snmp_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/snmp_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/snmp_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/snmp_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/snmp_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/snmp_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/snmp_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/snmp_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/snmp_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/snmp_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/snmp_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/snmp_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/snmp_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/snmp_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/snmp_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/snmp_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/snmp_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/snmp_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/snmp_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/snmp_exporter/deployments","created_at":"2015-02-22T23:24:16Z","updated_at":"2018-11-07T10:12:48Z","pushed_at":"2018-11-08T18:59:27Z","git_url":"git://github.com/prometheus/snmp_exporter.git","ssh_url":"git@github.com:prometheus/snmp_exporter.git","clone_url":"https://github.com/prometheus/snmp_exporter.git","svn_url":"https://github.com/prometheus/snmp_exporter","homepage":null,"size":5745,"stargazers_count":253,"watchers_count":253,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":132,"open_issues":26,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352"},"html":{"href":"https://github.com/prometheus/snmp_exporter/pull/352"},"issue":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/issues/352"},"comments":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/snmp_exporter/statuses/5e37265e38036e276061625831416bdc7e59c067"}},"author_association":"NONE"}}
{"actor":{"display_login":"brian-brazil"}}