{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/30863","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/30863/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/30863/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/30863/events","html_url":"https://github.com/owncloud/core/pull/30863","id":307500915,"number":30863,"title":"Cleanup double-slash URLs in acceptance tests","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":632044673,"url":"https://api.github.com/repos/owncloud/core/labels/dev:acceptance-tests","name":"dev:acceptance-tests","color":"ff9966","default":false}],"state":"closed","locked":false,"assignee":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"assignees":[{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/119","html_url":"https://github.com/owncloud/core/milestone/119","labels_url":"https://api.github.com/repos/owncloud/core/milestones/119/labels","id":2827584,"number":119,"title":"development","description":"10.0.8","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":123,"closed_issues":556,"state":"open","created_at":"2017-10-10T13:37:01Z","updated_at":"2018-03-28T14:21:49Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-03-22T04:17:49Z","updated_at":"2018-03-28T15:06:01Z","closed_at":"2018-03-22T05:29:41Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/30863","html_url":"https://github.com/owncloud/core/pull/30863","diff_url":"https://github.com/owncloud/core/pull/30863.diff","patch_url":"https://github.com/owncloud/core/pull/30863.patch"},"body":"## Description\r\nIn places where the acceptance tests use ``baseURL`` and append stuff to it, add checks that put a ``/`` after ``baseURL`` only if ``baseURL`` does not already end in a ``/``\r\n\r\nThat makes it flexible to have ``baseURL`` passed in with or without a trailing slash, and to not get double-slash sent in API requests.\r\n\r\n## Related Issue\r\nhttps://github.com/owncloud/QA/issues/517\r\n\r\n## Motivation and Context\r\nWhen running acceptance tests, on the PHP server we see requests like:\r\n```\r\n[Thu Mar 22 10:00:06 2018] 127.0.0.1:45804 [200]: /ocs//v1.php/apps/testing/api/v1/increasefileid\r\n[Thu Mar 22 10:00:06 2018] 127.0.0.1:45806 [200]: //ocs/v1.php/cloud/capabilities\r\n[Thu Mar 22 10:00:06 2018] 127.0.0.1:45808 [200]: //ocs/v1.php/apps/testing/api/v1/apps\r\n[Thu Mar 22 10:00:07 2018] 127.0.0.1:45810 [200]: //ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled\r\n[Thu Mar 22 10:00:07 2018] 127.0.0.1:45812 [200]: //ocs/v1.php/cloud/capabilities\r\n[Thu Mar 22 10:00:07 2018] 127.0.0.1:45814 [200]: //ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled\r\n```\r\nNothing bad goes wrong, ownCloud copes with \"random\" double-slash in the URI. But it makes people ask questions when they notice this in acceptance test output. So it is good to clean it up.\r\n\r\n## How Has This Been Tested?\r\nLocal runs of some API acceptance tests now give requests like:\r\n```\r\n[Thu Mar 22 09:53:57 2018] 127.0.0.1:45418 [200]: /ocs/v1.php/apps/testing/api/v1/increasefileid\r\n[Thu Mar 22 09:53:57 2018] 127.0.0.1:45420 [200]: /ocs/v1.php/cloud/capabilities\r\n[Thu Mar 22 09:53:57 2018] 127.0.0.1:45422 [200]: /ocs/v1.php/apps/testing/api/v1/apps\r\n[Thu Mar 22 09:53:57 2018] 127.0.0.1:45424 [200]: /ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled\r\n[Thu Mar 22 09:53:57 2018] 127.0.0.1:45426 [200]: /ocs/v1.php/cloud/capabilities\r\n[Thu Mar 22 09:53:57 2018] 127.0.0.1:45428 [200]: /ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled\r\n```\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] Acceptance test refactoring\r\n\r\n## Checklist:\r\n- [x My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/376920501","html_url":"https://github.com/owncloud/core/pull/30863#issuecomment-376920501","issue_url":"https://api.github.com/repos/owncloud/core/issues/30863","id":376920501,"user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars1.githubusercontent.com/u/1535615?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T15:06:01Z","updated_at":"2018-03-28T15:06:01Z","author_association":"CONTRIBUTOR","body":"Backport ``stable10`` #30864 "}}
{"actor":{"display_login":"phil-davis"}}