{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/5920","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/5920/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/5920/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/5920/events","html_url":"https://github.com/openssl/openssl/pull/5920","id":312877053,"number":5920,"title":"DRBG: implement get_nonce() callback","user":{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"labels":[{"id":314766253,"url":"https://api.github.com/repos/openssl/openssl/labels/ready","name":"ready","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"assignees":[{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/9","html_url":"https://github.com/openssl/openssl/milestone/9","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/9/labels","id":2145708,"number":9,"title":"1.1.1","description":"","creator":{"login":"levitte","id":698918,"avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"open_issues":179,"closed_issues":171,"state":"open","created_at":"2016-11-19T09:18:52Z","updated_at":"2018-04-13T18:51:46Z","due_on":null,"closed_at":null},"comments":28,"created_at":"2018-04-10T11:12:50Z","updated_at":"2018-04-13T18:58:59Z","closed_at":"2018-04-13T18:51:46Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/5920","html_url":"https://github.com/openssl/openssl/pull/5920","diff_url":"https://github.com/openssl/openssl/pull/5920.diff","patch_url":"https://github.com/openssl/openssl/pull/5920.patch"},"body":"In commit 2a70d65b99e1 (pr #5503) a fallback was added which adds a random nonce\r\nof security_strength/2 bits if no nonce callback is provided. This raises the\r\nentropy requirements form 256 to 384 bit, which can cause problems on some\r\nplatforms (e.g. VMS, see issue #5849).\r\n\r\nThe requirements for the nonce are given in section 8.6.7 of NIST SP 800-90Ar1:\r\n\r\n  A nonce may be required in the construction of a seed during instantiation\r\n  in order to provide a security cushion to block certain attacks.\r\n  The nonce shall be either:\r\n\r\n  a. A value with at least (security_strength/2) bits of entropy, or\r\n\r\n  b. A value that is expected to repeat no more often than a\r\n     (security_strength/2)-bit random string would be expected to repeat.\r\n\r\n  Each nonce shall be unique to the cryptographic module in which instantiation\r\n  is performed, but need not be secret. When used, the nonce shall be considered\r\n  to be a critical security parameter.\r\n\r\nThis commit implements a nonce of type b in order to lower the entropy\r\nrequirements during instantiation back to 256 bits.\r\n\r\nThe formulation \"shall be unique to the cryptographic module\" above implies\r\nthat the nonce needs to be unique among (with high probability) among all\r\nDRBG instances in \"space\" and \"time\". We try to achieve this goal by creating a\r\nnonce of the following form\r\n\r\n    nonce = app-specific-data || high-resolution-utc-timestamp || counter\r\n\r\nWhere || denotes concatenation. The application specific data can be something\r\nlike the process or group id of the application. A utc timestamp is used because\r\nit increases monotonically, provided the system time is synchronized.\r\n\r\nThis approach may not be perfect yet for a FIPS evaluation, but it should be good\r\nenough for the moment.\r\n\r\n<!--\r\nThank you for your pull request. Please review these requirements:\r\n\r\nContributors guide: https://github.com/openssl/openssl/blob/master/CONTRIBUTING\r\n\r\nOther than that, provide a description above this comment if there isn't one already\r\n\r\nIf this fixes a github issue, make sure to have a line saying 'Fixes #XXXX' (without quotes) in the commit message.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [ ] documentation is added or updated\r\n- [ ] tests are added or updated\r\n"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/381231287","html_url":"https://github.com/openssl/openssl/pull/5920#issuecomment-381231287","issue_url":"https://api.github.com/repos/openssl/openssl/issues/5920","id":381231287,"user":{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T18:58:59Z","updated_at":"2018-04-13T18:58:59Z","author_association":"CONTRIBUTOR","body":"Wow! I hit the 22,000! :champagne: :champagne: :champagne: \r\n\r\n![22000](https://user-images.githubusercontent.com/11467854/38753022-62d43530-3f5d-11e8-8229-0d129dab52fd.png)\r\n"}}
{"actor":{"display_login":"mspncp"}}