{"action":"created","comment":{"url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/comments/200218977","pull_request_review_id":134490945,"id":200218977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDIxODk3Nw==","diff_hunk":"@@ -87,19 +87,19 @@ private void sequenceNumberSeen(Optional<SequenceNumber> seq) {\n     seq.ifPresent(sid -> lastSeenSequenceNumber = Optional.of(sid));\n   }\n \n-  @SuppressWarnings(\"unchecked\")\n+  private void warnOnClosing(RxWebSocketEvent evt) {\n+    if (evt instanceof RxWebSocketEvent.Closing || evt instanceof RxWebSocketEvent.Closed) {\n+      LOG.warn(\"Websocket closing: {}\", evt);","path":"src/main/java/com/github/princesslana/eriscasper/gateway/Gateway.java","position":23,"original_position":23,"commit_id":"906c5a95fda2e611704ca1b56d8c29f661c6a08d","original_commit_id":"906c5a95fda2e611704ca1b56d8c29f661c6a08d","user":{"login":"CoreyShupe","id":37425956,"node_id":"MDQ6VXNlcjM3NDI1OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/37425956?v=4","gravatar_id":"","url":"https://api.github.com/users/CoreyShupe","html_url":"https://github.com/CoreyShupe","followers_url":"https://api.github.com/users/CoreyShupe/followers","following_url":"https://api.github.com/users/CoreyShupe/following{/other_user}","gists_url":"https://api.github.com/users/CoreyShupe/gists{/gist_id}","starred_url":"https://api.github.com/users/CoreyShupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoreyShupe/subscriptions","organizations_url":"https://api.github.com/users/CoreyShupe/orgs","repos_url":"https://api.github.com/users/CoreyShupe/repos","events_url":"https://api.github.com/users/CoreyShupe/events{/privacy}","received_events_url":"https://api.github.com/users/CoreyShupe/received_events","type":"User","site_admin":false},"body":"I think debugging and finding ways to show information for bugs should be done later when we're producing 1.0.0, not now, I don't think it's necessary to provide general debugging for users when the lib isn't even in a stable version yet.","created_at":"2018-07-05T02:07:03Z","updated_at":"2018-07-05T02:07:03Z","html_url":"https://github.com/princesslana/ErisCasper.java/pull/183#discussion_r200218977","pull_request_url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/comments/200218977"},"html":{"href":"https://github.com/princesslana/ErisCasper.java/pull/183#discussion_r200218977"},"pull_request":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183"}},"in_reply_to_id":200218816},"pull_request":{"url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183","id":199342694,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzQyNjk0","html_url":"https://github.com/princesslana/ErisCasper.java/pull/183","diff_url":"https://github.com/princesslana/ErisCasper.java/pull/183.diff","patch_url":"https://github.com/princesslana/ErisCasper.java/pull/183.patch","issue_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/183","number":183,"state":"open","locked":false,"title":"Clean shutdown on websocket closing","user":{"login":"ianagbip1oti","id":26780798,"node_id":"MDQ6VXNlcjI2NzgwNzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26780798?v=4","gravatar_id":"","url":"https://api.github.com/users/ianagbip1oti","html_url":"https://github.com/ianagbip1oti","followers_url":"https://api.github.com/users/ianagbip1oti/followers","following_url":"https://api.github.com/users/ianagbip1oti/following{/other_user}","gists_url":"https://api.github.com/users/ianagbip1oti/gists{/gist_id}","starred_url":"https://api.github.com/users/ianagbip1oti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianagbip1oti/subscriptions","organizations_url":"https://api.github.com/users/ianagbip1oti/orgs","repos_url":"https://api.github.com/users/ianagbip1oti/repos","events_url":"https://api.github.com/users/ianagbip1oti/events{/privacy}","received_events_url":"https://api.github.com/users/ianagbip1oti/received_events","type":"User","site_admin":false},"body":"The changes here:\r\n* Remove the exception on websocket closing. I tend to agree with this: https://rongi.github.io/kotlin-blog/rxjava/rx/2017/08/01/error-handling-in-rxjava.html, in that things that aren't bugs throw Exceptions works out badly in RxJava. So *for now* we just log at a warning level.\r\n* Add `cleanupDaemonThreads` to the maven build - otherwise we have to wait for OkHttp daemon threads to shutdown (there is no force shutdown for the daemon threads)\r\n* Refactor ErisCasper.run so that the bot is in the Event stream - this means the event stream completing means completion in the run method.\r\n* Add cleanup of RxJava and OkHttp (what we can) when the bot completes\r\n\r\nThe end result of this is an immediate shutdown if a bad bot token is passed, with out a 1k long stacktrace.\r\n\r\nAddress #71 ","created_at":"2018-07-05T01:51:01Z","updated_at":"2018-07-05T02:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29c82e4845ada3711f117bf4a9120acde9abf9c2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CoreyShupe","id":37425956,"node_id":"MDQ6VXNlcjM3NDI1OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/37425956?v=4","gravatar_id":"","url":"https://api.github.com/users/CoreyShupe","html_url":"https://github.com/CoreyShupe","followers_url":"https://api.github.com/users/CoreyShupe/followers","following_url":"https://api.github.com/users/CoreyShupe/following{/other_user}","gists_url":"https://api.github.com/users/CoreyShupe/gists{/gist_id}","starred_url":"https://api.github.com/users/CoreyShupe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoreyShupe/subscriptions","organizations_url":"https://api.github.com/users/CoreyShupe/orgs","repos_url":"https://api.github.com/users/CoreyShupe/repos","events_url":"https://api.github.com/users/CoreyShupe/events{/privacy}","received_events_url":"https://api.github.com/users/CoreyShupe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183/commits","review_comments_url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183/comments","review_comment_url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/183/comments","statuses_url":"https://api.github.com/repos/princesslana/ErisCasper.java/statuses/906c5a95fda2e611704ca1b56d8c29f661c6a08d","head":{"label":"princesslana:heartbeat_stop","ref":"heartbeat_stop","sha":"906c5a95fda2e611704ca1b56d8c29f661c6a08d","user":{"login":"princesslana","id":37023754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDIzNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/37023754?v=4","gravatar_id":"","url":"https://api.github.com/users/princesslana","html_url":"https://github.com/princesslana","followers_url":"https://api.github.com/users/princesslana/followers","following_url":"https://api.github.com/users/princesslana/following{/other_user}","gists_url":"https://api.github.com/users/princesslana/gists{/gist_id}","starred_url":"https://api.github.com/users/princesslana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princesslana/subscriptions","organizations_url":"https://api.github.com/users/princesslana/orgs","repos_url":"https://api.github.com/users/princesslana/repos","events_url":"https://api.github.com/users/princesslana/events{/privacy}","received_events_url":"https://api.github.com/users/princesslana/received_events","type":"Organization","site_admin":false},"repo":{"id":122770409,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3NzA0MDk=","name":"ErisCasper.java","full_name":"princesslana/ErisCasper.java","owner":{"login":"princesslana","id":37023754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDIzNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/37023754?v=4","gravatar_id":"","url":"https://api.github.com/users/princesslana","html_url":"https://github.com/princesslana","followers_url":"https://api.github.com/users/princesslana/followers","following_url":"https://api.github.com/users/princesslana/following{/other_user}","gists_url":"https://api.github.com/users/princesslana/gists{/gist_id}","starred_url":"https://api.github.com/users/princesslana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princesslana/subscriptions","organizations_url":"https://api.github.com/users/princesslana/orgs","repos_url":"https://api.github.com/users/princesslana/repos","events_url":"https://api.github.com/users/princesslana/events{/privacy}","received_events_url":"https://api.github.com/users/princesslana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/princesslana/ErisCasper.java","description":"Java library for making Discord bots","fork":false,"url":"https://api.github.com/repos/princesslana/ErisCasper.java","forks_url":"https://api.github.com/repos/princesslana/ErisCasper.java/forks","keys_url":"https://api.github.com/repos/princesslana/ErisCasper.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/princesslana/ErisCasper.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/princesslana/ErisCasper.java/teams","hooks_url":"https://api.github.com/repos/princesslana/ErisCasper.java/hooks","issue_events_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/events{/number}","events_url":"https://api.github.com/repos/princesslana/ErisCasper.java/events","assignees_url":"https://api.github.com/repos/princesslana/ErisCasper.java/assignees{/user}","branches_url":"https://api.github.com/repos/princesslana/ErisCasper.java/branches{/branch}","tags_url":"https://api.github.com/repos/princesslana/ErisCasper.java/tags","blobs_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/princesslana/ErisCasper.java/statuses/{sha}","languages_url":"https://api.github.com/repos/princesslana/ErisCasper.java/languages","stargazers_url":"https://api.github.com/repos/princesslana/ErisCasper.java/stargazers","contributors_url":"https://api.github.com/repos/princesslana/ErisCasper.java/contributors","subscribers_url":"https://api.github.com/repos/princesslana/ErisCasper.java/subscribers","subscription_url":"https://api.github.com/repos/princesslana/ErisCasper.java/subscription","commits_url":"https://api.github.com/repos/princesslana/ErisCasper.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/princesslana/ErisCasper.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/princesslana/ErisCasper.java/contents/{+path}","compare_url":"https://api.github.com/repos/princesslana/ErisCasper.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/princesslana/ErisCasper.java/merges","archive_url":"https://api.github.com/repos/princesslana/ErisCasper.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/princesslana/ErisCasper.java/downloads","issues_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues{/number}","pulls_url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls{/number}","milestones_url":"https://api.github.com/repos/princesslana/ErisCasper.java/milestones{/number}","notifications_url":"https://api.github.com/repos/princesslana/ErisCasper.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/princesslana/ErisCasper.java/labels{/name}","releases_url":"https://api.github.com/repos/princesslana/ErisCasper.java/releases{/id}","deployments_url":"https://api.github.com/repos/princesslana/ErisCasper.java/deployments","created_at":"2018-02-24T19:03:27Z","updated_at":"2018-07-04T20:27:09Z","pushed_at":"2018-07-05T01:58:04Z","git_url":"git://github.com/princesslana/ErisCasper.java.git","ssh_url":"git@github.com:princesslana/ErisCasper.java.git","clone_url":"https://github.com/princesslana/ErisCasper.java.git","svn_url":"https://github.com/princesslana/ErisCasper.java","homepage":"https://princesslana.github.io/ErisCasper.java/","size":28619,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":10,"watchers":11,"default_branch":"master"}},"base":{"label":"princesslana:master","ref":"master","sha":"511d957542475e130238015adee61167ed39adcc","user":{"login":"princesslana","id":37023754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDIzNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/37023754?v=4","gravatar_id":"","url":"https://api.github.com/users/princesslana","html_url":"https://github.com/princesslana","followers_url":"https://api.github.com/users/princesslana/followers","following_url":"https://api.github.com/users/princesslana/following{/other_user}","gists_url":"https://api.github.com/users/princesslana/gists{/gist_id}","starred_url":"https://api.github.com/users/princesslana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princesslana/subscriptions","organizations_url":"https://api.github.com/users/princesslana/orgs","repos_url":"https://api.github.com/users/princesslana/repos","events_url":"https://api.github.com/users/princesslana/events{/privacy}","received_events_url":"https://api.github.com/users/princesslana/received_events","type":"Organization","site_admin":false},"repo":{"id":122770409,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3NzA0MDk=","name":"ErisCasper.java","full_name":"princesslana/ErisCasper.java","owner":{"login":"princesslana","id":37023754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDIzNzU0","avatar_url":"https://avatars3.githubusercontent.com/u/37023754?v=4","gravatar_id":"","url":"https://api.github.com/users/princesslana","html_url":"https://github.com/princesslana","followers_url":"https://api.github.com/users/princesslana/followers","following_url":"https://api.github.com/users/princesslana/following{/other_user}","gists_url":"https://api.github.com/users/princesslana/gists{/gist_id}","starred_url":"https://api.github.com/users/princesslana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/princesslana/subscriptions","organizations_url":"https://api.github.com/users/princesslana/orgs","repos_url":"https://api.github.com/users/princesslana/repos","events_url":"https://api.github.com/users/princesslana/events{/privacy}","received_events_url":"https://api.github.com/users/princesslana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/princesslana/ErisCasper.java","description":"Java library for making Discord bots","fork":false,"url":"https://api.github.com/repos/princesslana/ErisCasper.java","forks_url":"https://api.github.com/repos/princesslana/ErisCasper.java/forks","keys_url":"https://api.github.com/repos/princesslana/ErisCasper.java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/princesslana/ErisCasper.java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/princesslana/ErisCasper.java/teams","hooks_url":"https://api.github.com/repos/princesslana/ErisCasper.java/hooks","issue_events_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/events{/number}","events_url":"https://api.github.com/repos/princesslana/ErisCasper.java/events","assignees_url":"https://api.github.com/repos/princesslana/ErisCasper.java/assignees{/user}","branches_url":"https://api.github.com/repos/princesslana/ErisCasper.java/branches{/branch}","tags_url":"https://api.github.com/repos/princesslana/ErisCasper.java/tags","blobs_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/refs{/sha}","trees_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/princesslana/ErisCasper.java/statuses/{sha}","languages_url":"https://api.github.com/repos/princesslana/ErisCasper.java/languages","stargazers_url":"https://api.github.com/repos/princesslana/ErisCasper.java/stargazers","contributors_url":"https://api.github.com/repos/princesslana/ErisCasper.java/contributors","subscribers_url":"https://api.github.com/repos/princesslana/ErisCasper.java/subscribers","subscription_url":"https://api.github.com/repos/princesslana/ErisCasper.java/subscription","commits_url":"https://api.github.com/repos/princesslana/ErisCasper.java/commits{/sha}","git_commits_url":"https://api.github.com/repos/princesslana/ErisCasper.java/git/commits{/sha}","comments_url":"https://api.github.com/repos/princesslana/ErisCasper.java/comments{/number}","issue_comment_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/comments{/number}","contents_url":"https://api.github.com/repos/princesslana/ErisCasper.java/contents/{+path}","compare_url":"https://api.github.com/repos/princesslana/ErisCasper.java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/princesslana/ErisCasper.java/merges","archive_url":"https://api.github.com/repos/princesslana/ErisCasper.java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/princesslana/ErisCasper.java/downloads","issues_url":"https://api.github.com/repos/princesslana/ErisCasper.java/issues{/number}","pulls_url":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls{/number}","milestones_url":"https://api.github.com/repos/princesslana/ErisCasper.java/milestones{/number}","notifications_url":"https://api.github.com/repos/princesslana/ErisCasper.java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/princesslana/ErisCasper.java/labels{/name}","releases_url":"https://api.github.com/repos/princesslana/ErisCasper.java/releases{/id}","deployments_url":"https://api.github.com/repos/princesslana/ErisCasper.java/deployments","created_at":"2018-02-24T19:03:27Z","updated_at":"2018-07-04T20:27:09Z","pushed_at":"2018-07-05T01:58:04Z","git_url":"git://github.com/princesslana/ErisCasper.java.git","ssh_url":"git@github.com:princesslana/ErisCasper.java.git","clone_url":"https://github.com/princesslana/ErisCasper.java.git","svn_url":"https://github.com/princesslana/ErisCasper.java","homepage":"https://princesslana.github.io/ErisCasper.java/","size":28619,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":10,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183"},"html":{"href":"https://github.com/princesslana/ErisCasper.java/pull/183"},"issue":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/183"},"comments":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/princesslana/ErisCasper.java/statuses/906c5a95fda2e611704ca1b56d8c29f661c6a08d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CoreyShupe"}}