{"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments/185478232","pull_request_review_id":116873821,"id":185478232,"diff_hunk":"@@ -383,13 +390,28 @@ const ALARM_COLUMNS = [\n   },\n ]\n \n+@addSubscriptions({\n+  schedules: subscribeSchedules,\n+})\n @connectStore(() => {\n   const getOrphanVdiSnapshots = createGetObjectsOfType('VDI-snapshot')\n     .filter([_ => !_.$snapshot_of && _.$VBDs.length === 0])\n     .sort()\n   const getOrphanVmSnapshots = createGetObjectsOfType('VM-snapshot')\n     .filter([snapshot => !snapshot.$snapshot_of])\n     .sort()\n+  const getLoneBackupSnapshots = createGetObjectsOfType('VM-snapshot').filter(\n+    createSelector(\n+      (_, props) => props.schedules,\n+      schedules => {\n+        const schedulesByIds = keyBy(schedules, 'id')\n+        return _ => {\n+          const scheduleId = _.other['xo:backup:schedule']\n+          return scheduleId !== undefined && !(scheduleId in schedulesByIds)\n+        }","path":"packages/xo-web/src/xo-app/dashboard/health/index.js","position":56,"original_position":56,"commit_id":"fd57f93e8ebde1b4be59458abd7132312679e7c6","original_commit_id":"fd57f93e8ebde1b4be59458abd7132312679e7c6","user":{"login":"pdonias","id":10992860,"avatar_url":"https://avatars1.githubusercontent.com/u/10992860?v=4","gravatar_id":"","url":"https://api.github.com/users/pdonias","html_url":"https://github.com/pdonias","followers_url":"https://api.github.com/users/pdonias/followers","following_url":"https://api.github.com/users/pdonias/following{/other_user}","gists_url":"https://api.github.com/users/pdonias/gists{/gist_id}","starred_url":"https://api.github.com/users/pdonias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdonias/subscriptions","organizations_url":"https://api.github.com/users/pdonias/orgs","repos_url":"https://api.github.com/users/pdonias/repos","events_url":"https://api.github.com/users/pdonias/events{/privacy}","received_events_url":"https://api.github.com/users/pdonias/received_events","type":"User","site_admin":false},"body":"Actually, we don't need the schedule objects:\r\n```js\r\nconst getLoneBackupSnapshots = createGetObjectsOfType('VM-snapshot').filter(\r\n  createSelector(\r\n    createSelector((_, props) => map(props.schedules, 'id')),\r\n    scheduleIds =>\r\n      _ => includes(scheduleIds, _.other['xo:backup:schedule'])\r\n  )\r\n)\r\n```","created_at":"2018-05-02T12:27:40Z","updated_at":"2018-05-02T12:39:00Z","html_url":"https://github.com/vatesfr/xen-orchestra/pull/2899#discussion_r185478232","pull_request_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments/185478232"},"html":{"href":"https://github.com/vatesfr/xen-orchestra/pull/2899#discussion_r185478232"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899","id":184272279,"html_url":"https://github.com/vatesfr/xen-orchestra/pull/2899","diff_url":"https://github.com/vatesfr/xen-orchestra/pull/2899.diff","patch_url":"https://github.com/vatesfr/xen-orchestra/pull/2899.patch","issue_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/2899","number":2899,"state":"open","locked":false,"title":"(xo-web/ Health): Add list VM snapshots related to non-existing backup","user":{"login":"Rajaa-BARHTAOUI","id":7724491,"avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"body":"fix #2828","created_at":"2018-04-26T09:06:15Z","updated_at":"2018-05-02T12:39:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"740850a8e2eb10fc9c9523ca0caa9e9f251b6f2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/2899/comments","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/fd57f93e8ebde1b4be59458abd7132312679e7c6","head":{"label":"Rajaa-BARHTAOUI:health_list_snapshot","ref":"health_list_snapshot","sha":"fd57f93e8ebde1b4be59458abd7132312679e7c6","user":{"login":"Rajaa-BARHTAOUI","id":7724491,"avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"repo":{"id":106420206,"name":"xo-web","full_name":"Rajaa-BARHTAOUI/xo-web","owner":{"login":"Rajaa-BARHTAOUI","id":7724491,"avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rajaa-BARHTAOUI/xo-web","description":"Interface part of Xen Orchestra.","fork":true,"url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web","forks_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/forks","keys_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/teams","hooks_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/hooks","issue_events_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues/events{/number}","events_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/events","assignees_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/assignees{/user}","branches_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/branches{/branch}","tags_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/tags","blobs_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/languages","stargazers_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/stargazers","contributors_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/contributors","subscribers_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/subscribers","subscription_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/subscription","commits_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/contents/{+path}","compare_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/merges","archive_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/downloads","issues_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues{/number}","pulls_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/labels{/name}","releases_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/releases{/id}","deployments_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/deployments","created_at":"2017-10-10T13:23:32Z","updated_at":"2018-05-02T08:37:09Z","pushed_at":"2018-05-02T12:14:17Z","git_url":"git://github.com/Rajaa-BARHTAOUI/xo-web.git","ssh_url":"git@github.com:Rajaa-BARHTAOUI/xo-web.git","clone_url":"https://github.com/Rajaa-BARHTAOUI/xo-web.git","svn_url":"https://github.com/Rajaa-BARHTAOUI/xo-web","homepage":"","size":19055,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vatesfr:master","ref":"master","sha":"c6f3b2b1ceb7070ca3b8218e9b6ce7213b3df066","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"name":"xen-orchestra","full_name":"vatesfr/xen-orchestra","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xen-orchestra","description":"The complete web solution for XenServer/XCP-ng","fork":false,"url":"https://api.github.com/repos/vatesfr/xen-orchestra","forks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/forks","keys_url":"https://api.github.com/repos/vatesfr/xen-orchestra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xen-orchestra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xen-orchestra/teams","hooks_url":"https://api.github.com/repos/vatesfr/xen-orchestra/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xen-orchestra/events","assignees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xen-orchestra/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/tags","blobs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xen-orchestra/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xen-orchestra/subscription","commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xen-orchestra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xen-orchestra/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xen-orchestra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xen-orchestra/merges","archive_url":"https://api.github.com/repos/vatesfr/xen-orchestra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xen-orchestra/downloads","issues_url":"https://api.github.com/repos/vatesfr/xen-orchestra/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xen-orchestra/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xen-orchestra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xen-orchestra/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xen-orchestra/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xen-orchestra/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2018-05-02T12:17:19Z","pushed_at":"2018-05-02T12:18:38Z","git_url":"git://github.com/vatesfr/xen-orchestra.git","ssh_url":"git@github.com:vatesfr/xen-orchestra.git","clone_url":"https://github.com/vatesfr/xen-orchestra.git","svn_url":"https://github.com/vatesfr/xen-orchestra","homepage":"","size":19434,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":331,"license":null,"forks":50,"open_issues":331,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899"},"html":{"href":"https://github.com/vatesfr/xen-orchestra/pull/2899"},"issue":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/2899"},"comments":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/issues/2899/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/pulls/2899/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xen-orchestra/statuses/fd57f93e8ebde1b4be59458abd7132312679e7c6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pdonias"}}