{"action":"created","comment":{"url":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments/216502505","pull_request_review_id":153998502,"id":216502505,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjUwMjUwNQ==","diff_hunk":"@@ -809,6 +848,18 @@ public boolean onFling(final float posX, final float posY, final float velocityX\n                 }\n                 return true;\n             }\n+\n+            @Override\n+            public boolean onCancelFling() {\n+                if (responder == null || !responder.onCancelFling()) {\n+                    if (panGesturesEnabled) {\n+                        cancelCameraAnimation();\n+                        // TODO: Ideally should call onRegionDidChange if map state \"InChanging\" - VT(09/10/2018)\n+                        mapChangeListener.onRegionDidChange(true);","path":"platforms/android/tangram/src/main/java/com/mapzen/tangram/MapController.java","position":145,"original_position":145,"commit_id":"58f0f0913fcccb625a585263a0735be4050bff3d","original_commit_id":"58f0f0913fcccb625a585263a0735be4050bff3d","user":{"login":"matteblair","id":3371850,"node_id":"MDQ6VXNlcjMzNzE4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3371850?v=4","gravatar_id":"","url":"https://api.github.com/users/matteblair","html_url":"https://github.com/matteblair","followers_url":"https://api.github.com/users/matteblair/followers","following_url":"https://api.github.com/users/matteblair/following{/other_user}","gists_url":"https://api.github.com/users/matteblair/gists{/gist_id}","starred_url":"https://api.github.com/users/matteblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteblair/subscriptions","organizations_url":"https://api.github.com/users/matteblair/orgs","repos_url":"https://api.github.com/users/matteblair/repos","events_url":"https://api.github.com/users/matteblair/events{/privacy}","received_events_url":"https://api.github.com/users/matteblair/received_events","type":"User","site_admin":false},"body":"This doesn't seem right - it results in the listener receiving `onRegionDidChange` as the first event whenever a touch begins. Is this what your comment refers to?","created_at":"2018-09-10T23:06:30Z","updated_at":"2018-09-10T23:06:30Z","html_url":"https://github.com/tangrams/tangram-es/pull/1852#discussion_r216502505","pull_request_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments/216502505"},"html":{"href":"https://github.com/tangrams/tangram-es/pull/1852#discussion_r216502505"},"pull_request":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852"}}},"pull_request":{"url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852","id":207702410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzAyNDEw","html_url":"https://github.com/tangrams/tangram-es/pull/1852","diff_url":"https://github.com/tangrams/tangram-es/pull/1852.diff","patch_url":"https://github.com/tangrams/tangram-es/pull/1852.patch","issue_url":"https://api.github.com/repos/tangrams/tangram-es/issues/1852","number":1852,"state":"open","locked":false,"title":"MapChangeListener interface for android","user":{"login":"tallytalwar","id":360641,"node_id":"MDQ6VXNlcjM2MDY0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/360641?v=4","gravatar_id":"","url":"https://api.github.com/users/tallytalwar","html_url":"https://github.com/tallytalwar","followers_url":"https://api.github.com/users/tallytalwar/followers","following_url":"https://api.github.com/users/tallytalwar/following{/other_user}","gists_url":"https://api.github.com/users/tallytalwar/gists{/gist_id}","starred_url":"https://api.github.com/users/tallytalwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallytalwar/subscriptions","organizations_url":"https://api.github.com/users/tallytalwar/orgs","repos_url":"https://api.github.com/users/tallytalwar/repos","events_url":"https://api.github.com/users/tallytalwar/events{/privacy}","received_events_url":"https://api.github.com/users/tallytalwar/received_events","type":"User","site_admin":false},"body":"- Adds MapChangeListener for android platform:\r\n        - onRegionWillChangeAnimated\r\n        - onRegionIsChanging\r\n        - onRegionDidChangeAnimated\r\n        - onViewComplete\r\n\r\n- Adds begin/end interfaces for touch gesture responder interfaces:\r\n  - [x] Pan Responder\r\n    - [x] generic logic to determine begin/end for pan gestures.\r\n  - [x] Shove Responder\r\n  - [x] Scale Responder\r\n  - [x] Rotate Responder\r\n\r\n- Provides mechanism to set mapChangeListener from client via MapController.\r\n- [ ] Handle mapIsChanging calls for when map is animating due to camera animation. (Will be handled in a subsequent PR)","created_at":"2018-08-10T19:28:31Z","updated_at":"2018-09-10T23:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfe10049f0988675556963c400172c9098c3691d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hjanetzek","id":1747,"node_id":"MDQ6VXNlcjE3NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1747?v=4","gravatar_id":"","url":"https://api.github.com/users/hjanetzek","html_url":"https://github.com/hjanetzek","followers_url":"https://api.github.com/users/hjanetzek/followers","following_url":"https://api.github.com/users/hjanetzek/following{/other_user}","gists_url":"https://api.github.com/users/hjanetzek/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanetzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanetzek/subscriptions","organizations_url":"https://api.github.com/users/hjanetzek/orgs","repos_url":"https://api.github.com/users/hjanetzek/repos","events_url":"https://api.github.com/users/hjanetzek/events{/privacy}","received_events_url":"https://api.github.com/users/hjanetzek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852/commits","review_comments_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852/comments","review_comment_url":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/issues/1852/comments","statuses_url":"https://api.github.com/repos/tangrams/tangram-es/statuses/58f0f0913fcccb625a585263a0735be4050bff3d","head":{"label":"tangrams:android-map-change-events","ref":"android-map-change-events","sha":"58f0f0913fcccb625a585263a0735be4050bff3d","user":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":23391501,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM5MTUwMQ==","name":"tangram-es","full_name":"tangrams/tangram-es","owner":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/tangram-es","description":"2D and 3D map renderer using OpenGL ES","fork":false,"url":"https://api.github.com/repos/tangrams/tangram-es","forks_url":"https://api.github.com/repos/tangrams/tangram-es/forks","keys_url":"https://api.github.com/repos/tangrams/tangram-es/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram-es/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram-es/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram-es/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram-es/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram-es/events","assignees_url":"https://api.github.com/repos/tangrams/tangram-es/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram-es/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram-es/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram-es/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram-es/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram-es/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram-es/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram-es/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram-es/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram-es/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram-es/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram-es/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram-es/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram-es/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram-es/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram-es/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram-es/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram-es/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram-es/merges","archive_url":"https://api.github.com/repos/tangrams/tangram-es/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram-es/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram-es/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram-es/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram-es/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram-es/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram-es/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram-es/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram-es/deployments","created_at":"2014-08-27T13:56:56Z","updated_at":"2018-09-08T14:15:47Z","pushed_at":"2018-09-10T22:09:21Z","git_url":"git://github.com/tangrams/tangram-es.git","ssh_url":"git@github.com:tangrams/tangram-es.git","clone_url":"https://github.com/tangrams/tangram-es.git","svn_url":"https://github.com/tangrams/tangram-es","homepage":"","size":36877,"stargazers_count":436,"watchers_count":436,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":151,"open_issues":133,"watchers":436,"default_branch":"master"}},"base":{"label":"tangrams:master","ref":"master","sha":"3556db60b017dfe2313fffa0b04fc166cb19fd0e","user":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":23391501,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM5MTUwMQ==","name":"tangram-es","full_name":"tangrams/tangram-es","owner":{"login":"tangrams","id":8495302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0OTUzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8495302?v=4","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/tangram-es","description":"2D and 3D map renderer using OpenGL ES","fork":false,"url":"https://api.github.com/repos/tangrams/tangram-es","forks_url":"https://api.github.com/repos/tangrams/tangram-es/forks","keys_url":"https://api.github.com/repos/tangrams/tangram-es/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram-es/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram-es/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram-es/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram-es/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram-es/events","assignees_url":"https://api.github.com/repos/tangrams/tangram-es/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram-es/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram-es/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram-es/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram-es/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram-es/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram-es/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram-es/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram-es/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram-es/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram-es/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram-es/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram-es/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram-es/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram-es/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram-es/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram-es/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram-es/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram-es/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram-es/merges","archive_url":"https://api.github.com/repos/tangrams/tangram-es/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram-es/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram-es/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram-es/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram-es/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram-es/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram-es/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram-es/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram-es/deployments","created_at":"2014-08-27T13:56:56Z","updated_at":"2018-09-08T14:15:47Z","pushed_at":"2018-09-10T22:09:21Z","git_url":"git://github.com/tangrams/tangram-es.git","ssh_url":"git@github.com:tangrams/tangram-es.git","clone_url":"https://github.com/tangrams/tangram-es.git","svn_url":"https://github.com/tangrams/tangram-es","homepage":"","size":36877,"stargazers_count":436,"watchers_count":436,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":151,"open_issues":133,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852"},"html":{"href":"https://github.com/tangrams/tangram-es/pull/1852"},"issue":{"href":"https://api.github.com/repos/tangrams/tangram-es/issues/1852"},"comments":{"href":"https://api.github.com/repos/tangrams/tangram-es/issues/1852/comments"},"review_comments":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852/comments"},"review_comment":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tangrams/tangram-es/pulls/1852/commits"},"statuses":{"href":"https://api.github.com/repos/tangrams/tangram-es/statuses/58f0f0913fcccb625a585263a0735be4050bff3d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matteblair"}}