{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/221981187","pull_request_review_id":160759395,"id":221981187,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk4MTE4Nw==","diff_hunk":"@@ -62,6 +64,8 @@ def __rnd_pca_test_helper(self, data, n_com, min_xpl_var):\n         proj = np.dot(data.X - pca_model.mean_, pca_model.components_.T)\n         np.testing.assert_almost_equal(pca_model(data).X, proj)\n \n+    @unittest.skipIf(sklearn_version.startswith('0.20'),","path":"Orange/tests/test_pca.py","position":22,"original_position":22,"commit_id":"d8c9f2429486a4b45be7eaf88690d9146b40a3ad","original_commit_id":"d8c9f2429486a4b45be7eaf88690d9146b40a3ad","user":{"login":"janezd","id":2387315,"node_id":"MDQ6VXNlcjIzODczMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2387315?v=4","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"body":"I didn't understand what @kernc meant. I prefer @lanzagar's way, also because it will force us to recheck this with every new version of scikit-learn.","created_at":"2018-10-02T14:45:50Z","updated_at":"2018-10-02T14:45:50Z","html_url":"https://github.com/biolab/orange3/pull/3280#discussion_r221981187","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/3280","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/221981187"},"html":{"href":"https://github.com/biolab/orange3/pull/3280#discussion_r221981187"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/3280"}},"in_reply_to_id":221964154},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/3280","id":219706481,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzA2NDgx","html_url":"https://github.com/biolab/orange3/pull/3280","diff_url":"https://github.com/biolab/orange3/pull/3280.diff","patch_url":"https://github.com/biolab/orange3/pull/3280.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/3280","number":3280,"state":"open","locked":false,"title":"Skip failing Incremental PCA test","user":{"login":"lanzagar","id":4579717,"node_id":"MDQ6VXNlcjQ1Nzk3MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4579717?v=4","gravatar_id":"","url":"https://api.github.com/users/lanzagar","html_url":"https://github.com/lanzagar","followers_url":"https://api.github.com/users/lanzagar/followers","following_url":"https://api.github.com/users/lanzagar/following{/other_user}","gists_url":"https://api.github.com/users/lanzagar/gists{/gist_id}","starred_url":"https://api.github.com/users/lanzagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanzagar/subscriptions","organizations_url":"https://api.github.com/users/lanzagar/orgs","repos_url":"https://api.github.com/users/lanzagar/repos","events_url":"https://api.github.com/users/lanzagar/events{/privacy}","received_events_url":"https://api.github.com/users/lanzagar/received_events","type":"User","site_admin":false},"body":"Skip Inremental PCA test which started failing in scikit-learn 0.20.\r\nSee https://github.com/scikit-learn/scikit-learn/issues/12234\r\n\r\nDepending on the upstream solution, we should do something about the problem itself too. However, Inremental PCA is not actually available in Orange Canvas (except as a prototype in combination with remote orange), so skipping the test for now should be ok and give us some time to decide what to do.\r\n","created_at":"2018-10-02T13:37:37Z","updated_at":"2018-10-02T14:45:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b392a6c4c966ea15ad285928cf062f1c3ed84f9e","assignee":{"login":"janezd","id":2387315,"node_id":"MDQ6VXNlcjIzODczMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2387315?v=4","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"assignees":[{"login":"janezd","id":2387315,"node_id":"MDQ6VXNlcjIzODczMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2387315?v=4","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/3280/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/3280/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/3280/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/d8c9f2429486a4b45be7eaf88690d9146b40a3ad","head":{"label":"lanzagar:ipca","ref":"ipca","sha":"d8c9f2429486a4b45be7eaf88690d9146b40a3ad","user":{"login":"lanzagar","id":4579717,"node_id":"MDQ6VXNlcjQ1Nzk3MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4579717?v=4","gravatar_id":"","url":"https://api.github.com/users/lanzagar","html_url":"https://github.com/lanzagar","followers_url":"https://api.github.com/users/lanzagar/followers","following_url":"https://api.github.com/users/lanzagar/following{/other_user}","gists_url":"https://api.github.com/users/lanzagar/gists{/gist_id}","starred_url":"https://api.github.com/users/lanzagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanzagar/subscriptions","organizations_url":"https://api.github.com/users/lanzagar/orgs","repos_url":"https://api.github.com/users/lanzagar/repos","events_url":"https://api.github.com/users/lanzagar/events{/privacy}","received_events_url":"https://api.github.com/users/lanzagar/received_events","type":"User","site_admin":false},"repo":{"id":22258081,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI1ODA4MQ==","name":"orange3","full_name":"lanzagar/orange3","private":false,"owner":{"login":"lanzagar","id":4579717,"node_id":"MDQ6VXNlcjQ1Nzk3MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4579717?v=4","gravatar_id":"","url":"https://api.github.com/users/lanzagar","html_url":"https://github.com/lanzagar","followers_url":"https://api.github.com/users/lanzagar/followers","following_url":"https://api.github.com/users/lanzagar/following{/other_user}","gists_url":"https://api.github.com/users/lanzagar/gists{/gist_id}","starred_url":"https://api.github.com/users/lanzagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanzagar/subscriptions","organizations_url":"https://api.github.com/users/lanzagar/orgs","repos_url":"https://api.github.com/users/lanzagar/repos","events_url":"https://api.github.com/users/lanzagar/events{/privacy}","received_events_url":"https://api.github.com/users/lanzagar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lanzagar/orange3","description":null,"fork":true,"url":"https://api.github.com/repos/lanzagar/orange3","forks_url":"https://api.github.com/repos/lanzagar/orange3/forks","keys_url":"https://api.github.com/repos/lanzagar/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanzagar/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanzagar/orange3/teams","hooks_url":"https://api.github.com/repos/lanzagar/orange3/hooks","issue_events_url":"https://api.github.com/repos/lanzagar/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/lanzagar/orange3/events","assignees_url":"https://api.github.com/repos/lanzagar/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/lanzagar/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/lanzagar/orange3/tags","blobs_url":"https://api.github.com/repos/lanzagar/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanzagar/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanzagar/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanzagar/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanzagar/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/lanzagar/orange3/languages","stargazers_url":"https://api.github.com/repos/lanzagar/orange3/stargazers","contributors_url":"https://api.github.com/repos/lanzagar/orange3/contributors","subscribers_url":"https://api.github.com/repos/lanzagar/orange3/subscribers","subscription_url":"https://api.github.com/repos/lanzagar/orange3/subscription","commits_url":"https://api.github.com/repos/lanzagar/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanzagar/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanzagar/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanzagar/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanzagar/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/lanzagar/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanzagar/orange3/merges","archive_url":"https://api.github.com/repos/lanzagar/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanzagar/orange3/downloads","issues_url":"https://api.github.com/repos/lanzagar/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/lanzagar/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/lanzagar/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/lanzagar/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanzagar/orange3/labels{/name}","releases_url":"https://api.github.com/repos/lanzagar/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/lanzagar/orange3/deployments","created_at":"2014-07-25T13:38:53Z","updated_at":"2017-01-13T15:40:05Z","pushed_at":"2018-10-02T13:39:26Z","git_url":"git://github.com/lanzagar/orange3.git","ssh_url":"git@github.com:lanzagar/orange3.git","clone_url":"https://github.com/lanzagar/orange3.git","svn_url":"https://github.com/lanzagar/orange3","homepage":null,"size":71796,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"a782062a514f8376c5b2371c8f89aa1c460842e9","user":{"login":"biolab","id":555189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTE4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/555189?v=4","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU3MjI3","name":"orange3","full_name":"biolab/orange3","private":false,"owner":{"login":"biolab","id":555189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTE4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/555189?v=4","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/biolab/orange3","description":"🍊 :bar_chart: :bulb: Orange: Interactive data analysis https://orange.biolab.si","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3/deployments","created_at":"2013-02-22T12:52:56Z","updated_at":"2018-09-30T16:23:54Z","pushed_at":"2018-10-02T13:39:27Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":71752,"stargazers_count":1467,"watchers_count":1467,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":228,"watchers":1467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/3280"},"html":{"href":"https://github.com/biolab/orange3/pull/3280"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/3280"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/3280/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/3280/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/3280/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/d8c9f2429486a4b45be7eaf88690d9146b40a3ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janezd"}}