{"push_id":2567436550,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"b0c964e217ce07b3af4554640e65f5a8b62886d0","before":"818966cc36997618cb03d0007113ac134ea7f09c","commits":[{"sha":"61d7193814b88a417b18cf36fe314ed6937c4e52","author":{"name":"Nathan Hawes","email":"519de0445f5d026953674b4caa743d60a369200e@apple.com"},"message":"[migrator] Treat the top-level argument parens of function types as an index level in the ChildIndexFinder\n\nThe APIDiffMigrator pass was ignoring them in all cases, but function type\nargument parens are significant and the API differ includes them as an index\nlevel in the generated json. This was causing a segmentation fault when trying\nto migrate anything inside a function type argument. E.g given the function\nbelow:\n\nfunc member(_ x: ([Any]?) -> Void) {}\n\nto migrate Any to Int, the API differ produces an index into the signauture of\n1:1:0:0:0, meant to indicate Any. The APIDiffMigratorPass was interpreting this\nincorrectly, however:\n\n1: The type of first parameter of member: ([Any]?) -> Void\n   Migrator agreed.\n1: The type of the function type's argument: ([Any]?)\n   Migrator saw this as [Any]? due to the parens not being an index level\n0: The 0th child of the paren type: [Any]?\n   Migrator saw the 0th child of the optional, [Any]\n0: the 0th child of the optional type, [Any]\n   Migrator saw the 0th child of the array, Any\n0: the 0th child of the array type, Any\n  Migrator tried to look up the 0th child of Any, causing a crash.\n\nResolves rdar://problem/40225476.","distinct":true,"url":"https://api.github.com/repos/apple/swift/commits/61d7193814b88a417b18cf36fe314ed6937c4e52"},{"sha":"b0c964e217ce07b3af4554640e65f5a8b62886d0","author":{"name":"Nathan Hawes","email":"519de0445f5d026953674b4caa743d60a369200e@apple.com"},"message":"Merge pull request #16637 from nathawes/rdar40225476-segfault-migrating-type-inside-function-type-argument\n\n[migrator] Treat the top-level argument parens of function types as an index level in the ChildIndexFinder","distinct":true,"url":"https://api.github.com/repos/apple/swift/commits/b0c964e217ce07b3af4554640e65f5a8b62886d0"}]}
{"actor":{"display_login":"nathawes"}}