{"action":"created","issue":{"url":"https://api.github.com/repos/petergeneric/stdlib/issues/35","repository_url":"https://api.github.com/repos/petergeneric/stdlib","labels_url":"https://api.github.com/repos/petergeneric/stdlib/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/petergeneric/stdlib/issues/35/comments","events_url":"https://api.github.com/repos/petergeneric/stdlib/issues/35/events","html_url":"https://github.com/petergeneric/stdlib/pull/35","id":304378081,"number":35,"title":"change the type of is_enabled on oauth_service table","user":{"login":"bmcleodcd","id":5772487,"avatar_url":"https://avatars2.githubusercontent.com/u/5772487?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcleodcd","html_url":"https://github.com/bmcleodcd","followers_url":"https://api.github.com/users/bmcleodcd/followers","following_url":"https://api.github.com/users/bmcleodcd/following{/other_user}","gists_url":"https://api.github.com/users/bmcleodcd/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcleodcd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcleodcd/subscriptions","organizations_url":"https://api.github.com/users/bmcleodcd/orgs","repos_url":"https://api.github.com/users/bmcleodcd/repos","events_url":"https://api.github.com/users/bmcleodcd/events{/privacy}","received_events_url":"https://api.github.com/users/bmcleodcd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-12T13:48:06Z","updated_at":"2018-03-12T14:14:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/petergeneric/stdlib/pulls/35","html_url":"https://github.com/petergeneric/stdlib/pull/35","diff_url":"https://github.com/petergeneric/stdlib/pull/35.diff","patch_url":"https://github.com/petergeneric/stdlib/pull/35.patch"},"body":"the BIT type used wasn't playing nicely with postgres, so dropped and recreated the column to switch to more general 'boolean' type\r\n\r\nnb. data can be lost due to this update but afiak its only used in one place so its a one off query to fix"},"comment":{"url":"https://api.github.com/repos/petergeneric/stdlib/issues/comments/372323893","html_url":"https://github.com/petergeneric/stdlib/pull/35#issuecomment-372323893","issue_url":"https://api.github.com/repos/petergeneric/stdlib/issues/35","id":372323893,"user":{"login":"petergeneric","id":870655,"avatar_url":"https://avatars3.githubusercontent.com/u/870655?v=4","gravatar_id":"","url":"https://api.github.com/users/petergeneric","html_url":"https://github.com/petergeneric","followers_url":"https://api.github.com/users/petergeneric/followers","following_url":"https://api.github.com/users/petergeneric/following{/other_user}","gists_url":"https://api.github.com/users/petergeneric/gists{/gist_id}","starred_url":"https://api.github.com/users/petergeneric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petergeneric/subscriptions","organizations_url":"https://api.github.com/users/petergeneric/orgs","repos_url":"https://api.github.com/users/petergeneric/repos","events_url":"https://api.github.com/users/petergeneric/events{/privacy}","received_events_url":"https://api.github.com/users/petergeneric/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T14:14:36Z","updated_at":"2018-03-12T14:14:36Z","author_association":"OWNER","body":"This migration will only work on an empty db, however I think setting an is_enabled default to true would be reasonable (given that we've not disabled any services), as long as we have a note in the commit and PR that it'll re-enable all disabled services(!)\r\n\r\nThere are other BIT columns that should be migrated to BOOLEAN too then:\r\n\r\n- ```oauth_session.is_active```\r\n- ```oauth_session_contect.is_active```\r\n\r\nThese can both be safely defaulted to false (if we do this then users will be asked to re-approve access by the services to their personal information).\r\n\r\nIn instances where we don't want to trouble users with this (where all services are first-party) we can add the following to the service config:\r\n\r\n```\r\nauth.interactive.create-new-session-context-if-necessary=true\r\n```\r\n\r\nN.B. this shouldn't be set where there are third-party services"}}
{"actor":{"display_login":"petergeneric"}}