{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/191389992","pull_request_review_id":123950418,"id":191389992,"diff_hunk":"@@ -5,20 +5,15 @@\n #include \"Emu/RSX/GSRender.h\"\n #include \"Emu/IdManager.h\"\n #include \"Emu/Cell/ErrorCodes.h\"\n+#include \"Emu/Cell/Modules/cellGcmSys.h\"","path":"rpcs3/Emu/Cell/lv2/sys_rsx.cpp","position":4,"original_position":4,"commit_id":"5bc5340c728625b65cf90b0de1e5890459e76d6e","original_commit_id":"5bc5340c728625b65cf90b0de1e5890459e76d6e","user":{"login":"elad335","id":18193363,"avatar_url":"https://avatars0.githubusercontent.com/u/18193363?v=4","gravatar_id":"","url":"https://api.github.com/users/elad335","html_url":"https://github.com/elad335","followers_url":"https://api.github.com/users/elad335/followers","following_url":"https://api.github.com/users/elad335/following{/other_user}","gists_url":"https://api.github.com/users/elad335/gists{/gist_id}","starred_url":"https://api.github.com/users/elad335/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elad335/subscriptions","organizations_url":"https://api.github.com/users/elad335/orgs","repos_url":"https://api.github.com/users/elad335/repos","events_url":"https://api.github.com/users/elad335/events{/privacy}","received_events_url":"https://api.github.com/users/elad335/received_events","type":"User","site_admin":false},"body":"though maybe I should remove this since no game would use a mix of cellgcm and sys_rsx calls like that.","created_at":"2018-05-29T11:29:43Z","updated_at":"2018-05-29T11:29:43Z","html_url":"https://github.com/RPCS3/rpcs3/pull/4660#discussion_r191389992","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/191389992"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4660#discussion_r191389992"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660"}},"in_reply_to_id":191387740},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660","id":190738692,"html_url":"https://github.com/RPCS3/rpcs3/pull/4660","diff_url":"https://github.com/RPCS3/rpcs3/pull/4660.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/4660.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4660","number":4660,"state":"open","locked":false,"title":"Rsx: Naughty fixes","user":{"login":"elad335","id":18193363,"avatar_url":"https://avatars0.githubusercontent.com/u/18193363?v=4","gravatar_id":"","url":"https://api.github.com/users/elad335","html_url":"https://github.com/elad335","followers_url":"https://api.github.com/users/elad335/followers","following_url":"https://api.github.com/users/elad335/following{/other_user}","gists_url":"https://api.github.com/users/elad335/gists{/gist_id}","starred_url":"https://api.github.com/users/elad335/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elad335/subscriptions","organizations_url":"https://api.github.com/users/elad335/orgs","repos_url":"https://api.github.com/users/elad335/repos","events_url":"https://api.github.com/users/elad335/events{/privacy}","received_events_url":"https://api.github.com/users/elad335/received_events","type":"User","site_admin":false},"body":"Allow sys_mmapper to unmap rsx mapped memory - a little background\r\nfrom hw testing, when `sys_mmapper` unmaps memory that was mapped to rsx memory, it notifies the kernel that this memory can be remapped for rsx later on, doing that fixes `cellGcmMapMainMemory` offset return values.\r\nthe fix for this was different in hle and lle `cellgcm`\r\n`cellgcm` hle fix- set memory \"unmapped\" status values in the rsx offset table in `sys_mmapper` and check them later in `cellGcmMapMainMemory`.\r\n`cellgcm` lle fix- notify the gcm interrupt thread about freeing rsx mappped memory in sys_mmapper\r\n(credit to @jarveson for figuring out how sys_mmapper communicates with cellgcm, I figured the data's encryption in the notification event and how the gcm knows the address and the size of the memory that was unmapped.)\r\na few naughty dog games not only use this feature but check the offset values returned from this call.\r\n\r\n\r\n\r\n# games improved\r\n**Uncharted 2 can now go ingame!** (with lle libvdec)\r\n**Uncharted 3 goes to menu for the first time!**\r\n**The Last Of Us no longer traps on cutscenes** (but still requires a save because of a segfault in video closing sequance.)\r\n\r\n![image](https://user-images.githubusercontent.com/18193363/40575766-9e93d5fa-60f3-11e8-8a73-ad868bce8902.png)\r\n\r\ncheers!\r\n","created_at":"2018-05-26T11:47:42Z","updated_at":"2018-05-29T11:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e922e301cd4094a01fcbe0d98fe880bbb114633","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4660/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/5bc5340c728625b65cf90b0de1e5890459e76d6e","head":{"label":"elad335:rsx_stuff","ref":"rsx_stuff","sha":"5bc5340c728625b65cf90b0de1e5890459e76d6e","user":{"login":"elad335","id":18193363,"avatar_url":"https://avatars0.githubusercontent.com/u/18193363?v=4","gravatar_id":"","url":"https://api.github.com/users/elad335","html_url":"https://github.com/elad335","followers_url":"https://api.github.com/users/elad335/followers","following_url":"https://api.github.com/users/elad335/following{/other_user}","gists_url":"https://api.github.com/users/elad335/gists{/gist_id}","starred_url":"https://api.github.com/users/elad335/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elad335/subscriptions","organizations_url":"https://api.github.com/users/elad335/orgs","repos_url":"https://api.github.com/users/elad335/repos","events_url":"https://api.github.com/users/elad335/events{/privacy}","received_events_url":"https://api.github.com/users/elad335/received_events","type":"User","site_admin":false},"repo":{"id":109874312,"name":"rpcs3","full_name":"elad335/rpcs3","owner":{"login":"elad335","id":18193363,"avatar_url":"https://avatars0.githubusercontent.com/u/18193363?v=4","gravatar_id":"","url":"https://api.github.com/users/elad335","html_url":"https://github.com/elad335","followers_url":"https://api.github.com/users/elad335/followers","following_url":"https://api.github.com/users/elad335/following{/other_user}","gists_url":"https://api.github.com/users/elad335/gists{/gist_id}","starred_url":"https://api.github.com/users/elad335/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elad335/subscriptions","organizations_url":"https://api.github.com/users/elad335/orgs","repos_url":"https://api.github.com/users/elad335/repos","events_url":"https://api.github.com/users/elad335/events{/privacy}","received_events_url":"https://api.github.com/users/elad335/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elad335/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/elad335/rpcs3","forks_url":"https://api.github.com/repos/elad335/rpcs3/forks","keys_url":"https://api.github.com/repos/elad335/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elad335/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elad335/rpcs3/teams","hooks_url":"https://api.github.com/repos/elad335/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/elad335/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/elad335/rpcs3/events","assignees_url":"https://api.github.com/repos/elad335/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/elad335/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/elad335/rpcs3/tags","blobs_url":"https://api.github.com/repos/elad335/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elad335/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elad335/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/elad335/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elad335/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/elad335/rpcs3/languages","stargazers_url":"https://api.github.com/repos/elad335/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/elad335/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/elad335/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/elad335/rpcs3/subscription","commits_url":"https://api.github.com/repos/elad335/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/elad335/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/elad335/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/elad335/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/elad335/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/elad335/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elad335/rpcs3/merges","archive_url":"https://api.github.com/repos/elad335/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elad335/rpcs3/downloads","issues_url":"https://api.github.com/repos/elad335/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/elad335/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/elad335/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/elad335/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elad335/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/elad335/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/elad335/rpcs3/deployments","created_at":"2017-11-07T18:26:16Z","updated_at":"2018-05-28T05:22:54Z","pushed_at":"2018-05-29T11:13:28Z","git_url":"git://github.com/elad335/rpcs3.git","ssh_url":"git@github.com:elad335/rpcs3.git","clone_url":"https://github.com/elad335/rpcs3.git","svn_url":"https://github.com/elad335/rpcs3","homepage":"https://rpcs3.net/","size":48851,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"CellSpux"}},"base":{"label":"RPCS3:master","ref":"master","sha":"824340363d0c2564533156691aa8cf3d9a92ac63","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2018-05-29T10:54:40Z","pushed_at":"2018-05-29T11:13:30Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":"https://rpcs3.net/","size":49907,"stargazers_count":4998,"watchers_count":4998,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":925,"mirror_url":null,"archived":false,"open_issues_count":362,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":925,"open_issues":362,"watchers":4998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4660"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4660"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4660/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4660/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/5bc5340c728625b65cf90b0de1e5890459e76d6e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elad335"}}