{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/140","repository_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery","labels_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/140/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/140/events","html_url":"https://github.com/kubernetes-incubator/node-feature-discovery/issues/140","id":339359958,"node_id":"MDU6SXNzdWUzMzkzNTk5NTg=","number":140,"title":"Detect Kernel and OS version","user":{"login":"marquiz","id":1035625,"node_id":"MDQ6VXNlcjEwMzU2MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1035625?v=4","gravatar_id":"","url":"https://api.github.com/users/marquiz","html_url":"https://github.com/marquiz","followers_url":"https://api.github.com/users/marquiz/followers","following_url":"https://api.github.com/users/marquiz/following{/other_user}","gists_url":"https://api.github.com/users/marquiz/gists{/gist_id}","starred_url":"https://api.github.com/users/marquiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marquiz/subscriptions","organizations_url":"https://api.github.com/users/marquiz/orgs","repos_url":"https://api.github.com/users/marquiz/repos","events_url":"https://api.github.com/users/marquiz/events{/privacy}","received_events_url":"https://api.github.com/users/marquiz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-07-09T08:52:59Z","updated_at":"2018-09-28T14:47:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"These would help in placement of workloads which are dependent on certain OS or kernel version. \r\n\r\nI proposed implementing these in kubelet ([Issue #65850](https://github.com/kubernetes/kubernetes/issues/65850)), but, that request seems unlikely to be accepted. This feature could be implemented in NFD, instead.\r\n\r\nKernel version can be read from `/proc/sys/kernel/osrelease`. Kernel version would be split into multiple labels, in order to make it more practical to use as labelselectors need exact values, and, no comparison operators (i.e. \"greater than\" etc.) can be used. Suggested labels, with example values:\r\n```\r\nnode.alpha.kubernetes-incubator.io/nfd-kernel-version=4.4.0-112-generic\r\nnode.alpha.kubernetes-incubator.io/nfd-kernel-version-x=4\r\nnode.alpha.kubernetes-incubator.io/nfd-kernel-version-xy=4.4\r\nnode.alpha.kubernetes-incubator.io/nfd-kernel-version-xyz=4.4.0\r\n```\r\n\r\nAn initial RFD implementation of kernel version detection is available at:\r\nhttps://github.com/marquiz/node-feature-discovery/tree/feature/kernel-version\r\n\r\n\r\nOS version would be read from `/etc/os-release`. At least `ID` and `VERSION_ID` should be advertised, I think:\r\n```\r\nnode.alpha.kubernetes-incubator.io/nfd-os-release-ID=ubuntu\r\nnode.alpha.kubernetes-incubator.io/nfd-os-release-VERSION_ID=16.04\r\n```\r\n\r\nAn initial RFD implementation of OS version detection is available at:\r\nhttps://github.com/marquiz/node-feature-discovery/tree/feature/os-release"},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/comments/425459766","html_url":"https://github.com/kubernetes-incubator/node-feature-discovery/issues/140#issuecomment-425459766","issue_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/140","id":425459766,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTQ1OTc2Ng==","user":{"login":"lmdaly","id":22192018,"node_id":"MDQ6VXNlcjIyMTkyMDE4","avatar_url":"https://avatars2.githubusercontent.com/u/22192018?v=4","gravatar_id":"","url":"https://api.github.com/users/lmdaly","html_url":"https://github.com/lmdaly","followers_url":"https://api.github.com/users/lmdaly/followers","following_url":"https://api.github.com/users/lmdaly/following{/other_user}","gists_url":"https://api.github.com/users/lmdaly/gists{/gist_id}","starred_url":"https://api.github.com/users/lmdaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmdaly/subscriptions","organizations_url":"https://api.github.com/users/lmdaly/orgs","repos_url":"https://api.github.com/users/lmdaly/repos","events_url":"https://api.github.com/users/lmdaly/events{/privacy}","received_events_url":"https://api.github.com/users/lmdaly/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T14:47:36Z","updated_at":"2018-09-28T14:47:36Z","author_association":"NONE","body":"So the the dot would be used for different components of a label? Would this impact other labels already introduced? I think the dot is a good differentiation between what is a label to a different component vs what is a feature of a component, but want to make sure its a well understood concept across all labels. "}}
{"actor":{"display_login":"lmdaly"}}