{"action":"created","issue":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1157","repository_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1157/labels{/name}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1157/comments","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1157/events","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1157","id":346372781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjUzNzA1","number":1157,"title":"Jennyf/fix namespace","user":{"login":"jennyf19","id":19942418,"node_id":"MDQ6VXNlcjE5OTQyNDE4","avatar_url":"https://avatars2.githubusercontent.com/u/19942418?v=4","gravatar_id":"","url":"https://api.github.com/users/jennyf19","html_url":"https://github.com/jennyf19","followers_url":"https://api.github.com/users/jennyf19/followers","following_url":"https://api.github.com/users/jennyf19/following{/other_user}","gists_url":"https://api.github.com/users/jennyf19/gists{/gist_id}","starred_url":"https://api.github.com/users/jennyf19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennyf19/subscriptions","organizations_url":"https://api.github.com/users/jennyf19/orgs","repos_url":"https://api.github.com/users/jennyf19/repos","events_url":"https://api.github.com/users/jennyf19/events{/privacy}","received_events_url":"https://api.github.com/users/jennyf19/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-31T21:54:51Z","updated_at":"2018-08-01T05:03:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/pulls/1157","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1157","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1157.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1157.patch"},"body":"I used ApiReviewer to compare currently released ADAL 3.19.8 and current dev. The namespace in the Telemetry and IdToken classes were not in Core. Since I was there, I checked that all the Core files have the license header information and removed unnecessary usings.\r\nI ran the unit tests, rebuilt each individual project, and ran msbuild...will see how VSTS reacts."},"comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/comments/409450300","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1157#issuecomment-409450300","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-dotnet/issues/1157","id":409450300,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTQ1MDMwMA==","user":{"login":"henrik-me","id":34380746,"node_id":"MDQ6VXNlcjM0MzgwNzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/34380746?v=4","gravatar_id":"","url":"https://api.github.com/users/henrik-me","html_url":"https://github.com/henrik-me","followers_url":"https://api.github.com/users/henrik-me/followers","following_url":"https://api.github.com/users/henrik-me/following{/other_user}","gists_url":"https://api.github.com/users/henrik-me/gists{/gist_id}","starred_url":"https://api.github.com/users/henrik-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrik-me/subscriptions","organizations_url":"https://api.github.com/users/henrik-me/orgs","repos_url":"https://api.github.com/users/henrik-me/repos","events_url":"https://api.github.com/users/henrik-me/events{/privacy}","received_events_url":"https://api.github.com/users/henrik-me/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T05:03:50Z","updated_at":"2018-08-01T05:03:50Z","author_association":"CONTRIBUTOR","body":">     public class Telemetry\r\n\r\nyes, it should not be available to ADAL, that's the real fix. However I wonder how people are supposed to hook up to the telemetry events. If you make this one internal users can't. Also unit tests will not catch this as we have internals visible in the utests. Do we have any test apps which uses Telemetry? We might have to use a similar approach as what Bogdan used for the Exceptions, ensuring we can inject the telemetry class from the Module Initializer he created.\r\n\r\n---\r\nIn reply to: [409416173](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1157#issuecomment-409416173) [](ancestors = 409416173,409415744,409415240)\r\n\r\n---\r\nRefers to: core/src/Telemetry.cs:38 in a7d013a. [](commit_id = a7d013a2962302494969a79851ed4cc5c1207abc, deletion_comment = False)"}}
{"actor":{"display_login":"henrik-me"}}