{"action":"created","comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/240041572","pull_request_review_id":182983006,"id":240041572,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDA0MTU3Mg==","diff_hunk":"@@ -376,6 +376,7 @@ func (m *InputScript) GetSigScript() []byte {\n }\n \n type InputScriptResp struct {\n+\t// / The set of fully valid input scripts requested.","path":"lnrpc/signrpc/signer.pb.go","position":4,"original_position":4,"commit_id":"0b5f44cb90a1d82803a60e25be653c873b607777","original_commit_id":"0b5f44cb90a1d82803a60e25be653c873b607777","user":{"login":"xsb","id":148317,"node_id":"MDQ6VXNlcjE0ODMxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/148317?v=4","gravatar_id":"","url":"https://api.github.com/users/xsb","html_url":"https://github.com/xsb","followers_url":"https://api.github.com/users/xsb/followers","following_url":"https://api.github.com/users/xsb/following{/other_user}","gists_url":"https://api.github.com/users/xsb/gists{/gist_id}","starred_url":"https://api.github.com/users/xsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsb/subscriptions","organizations_url":"https://api.github.com/users/xsb/orgs","repos_url":"https://api.github.com/users/xsb/repos","events_url":"https://api.github.com/users/xsb/events{/privacy}","received_events_url":"https://api.github.com/users/xsb/received_events","type":"User","site_admin":false},"body":"After following the new instructions I have a clean result on `make rpc`, this line is not part of the output in my setup.","created_at":"2018-12-09T15:31:49Z","updated_at":"2018-12-09T15:32:08Z","html_url":"https://github.com/lightningnetwork/lnd/pull/2299#discussion_r240041572","pull_request_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments/240041572"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/2299#discussion_r240041572"},"pull_request":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299"}}},"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299","id":237135042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTM1MDQy","html_url":"https://github.com/lightningnetwork/lnd/pull/2299","diff_url":"https://github.com/lightningnetwork/lnd/pull/2299.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/2299.patch","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2299","number":2299,"state":"open","locked":false,"title":"lnrpc: update protobuf generation installation instructions.","user":{"login":"Bluetegu","id":1525690,"node_id":"MDQ6VXNlcjE1MjU2OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1525690?v=4","gravatar_id":"","url":"https://api.github.com/users/Bluetegu","html_url":"https://github.com/Bluetegu","followers_url":"https://api.github.com/users/Bluetegu/followers","following_url":"https://api.github.com/users/Bluetegu/following{/other_user}","gists_url":"https://api.github.com/users/Bluetegu/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluetegu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluetegu/subscriptions","organizations_url":"https://api.github.com/users/Bluetegu/orgs","repos_url":"https://api.github.com/users/Bluetegu/repos","events_url":"https://api.github.com/users/Bluetegu/events{/privacy}","received_events_url":"https://api.github.com/users/Bluetegu/received_events","type":"User","site_admin":false},"body":"The installation instructions for protobuf are no longer accurate, and if followed, would lead to creation of a different set of proto definitions on latest master, and errors in installations of the grpc-gateway tools. \r\n\r\nThe two main reasons for the errors are:\r\n\r\n1. Instructions for installation of the  google.golang.org/genproto package are not included in the README file. Installing the latest version cause failure when installing the grpc-gateway packages. That is, when running 'go install ./protoc-gen-grpc-gateway ./protoc-gen-swagger' the following errors appear:\r\n../../../google.golang.org/genproto/googleapis/api/annotations/http.pb.go:63:26: undefined: proto.InternalMessageInfo\r\n\r\nTo fix this, instructions for installing the package were added to the last commit that was still based on protobuf: v3.4.0.\r\n\r\n2. The 'golang/protobuf' installation includes running make. Running make with go version of 1.10 and up installs protoc-gen-go which slightly differs in fmt, leading to differences in generated proto definitions of the sort:\r\n-type isPolicyUpdateRequest_Scope interface {\r\n-\tisPolicyUpdateRequest_Scope()\r\n-}\r\n+type isPolicyUpdateRequest_Scope interface{ isPolicyUpdateRequest_Scope() }\r\n \r\n To fix this without creating differences in the generated proto definitions, a newer commit was selected that addresses this specific issue. This is the commit message text:\r\n\r\ncommit bbd03ef6da3a115852eaf24c8a1c46aeb39aa175\r\nAuthor: Chris Manghane <cmang@golang.org>\r\nDate:   Fri Feb 2 10:43:18 2018 -0800\r\n\r\n    proto, protoc-gen-go: fix vet and gofmt errors for Go 1.10 (#508)\r\n    \r\n    In Go 1.10, go vet and gofmt have changed their output in a way to breaks the current build and test cycle.\r\n    \r\n    gofmt turns a one-line definition of a single-method interface into three lines; this causes a golden\r\n    comparison test to produce different results between Go 1.9 and Go 1.10.\r\n    go vet is now run by default with go test, which uncovered a bad Stringer argument in extension_test.go.\r\n    Tested on Go1.10rc1 and Go1.9.3.\r\n\r\nNow when running make rpc on latest master the definitions stay as they are, apart from an additional comment which are automatically added to the new sub server.\r\n\r\nIt would be great if others would verify that the new instructions work.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-12-09T14:44:21Z","updated_at":"2018-12-09T15:32:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f418a4290bb0d560b34dc5d1f1c87ba19bf82893","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299/commits","review_comments_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299/comments","review_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2299/comments","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/0b5f44cb90a1d82803a60e25be653c873b607777","head":{"label":"Bluetegu:make-make-rpc-great-again","ref":"make-make-rpc-great-again","sha":"0b5f44cb90a1d82803a60e25be653c873b607777","user":{"login":"Bluetegu","id":1525690,"node_id":"MDQ6VXNlcjE1MjU2OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1525690?v=4","gravatar_id":"","url":"https://api.github.com/users/Bluetegu","html_url":"https://github.com/Bluetegu","followers_url":"https://api.github.com/users/Bluetegu/followers","following_url":"https://api.github.com/users/Bluetegu/following{/other_user}","gists_url":"https://api.github.com/users/Bluetegu/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluetegu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluetegu/subscriptions","organizations_url":"https://api.github.com/users/Bluetegu/orgs","repos_url":"https://api.github.com/users/Bluetegu/repos","events_url":"https://api.github.com/users/Bluetegu/events{/privacy}","received_events_url":"https://api.github.com/users/Bluetegu/received_events","type":"User","site_admin":false},"repo":{"id":132870721,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4NzA3MjE=","name":"lnd","full_name":"Bluetegu/lnd","private":false,"owner":{"login":"Bluetegu","id":1525690,"node_id":"MDQ6VXNlcjE1MjU2OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1525690?v=4","gravatar_id":"","url":"https://api.github.com/users/Bluetegu","html_url":"https://github.com/Bluetegu","followers_url":"https://api.github.com/users/Bluetegu/followers","following_url":"https://api.github.com/users/Bluetegu/following{/other_user}","gists_url":"https://api.github.com/users/Bluetegu/gists{/gist_id}","starred_url":"https://api.github.com/users/Bluetegu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bluetegu/subscriptions","organizations_url":"https://api.github.com/users/Bluetegu/orgs","repos_url":"https://api.github.com/users/Bluetegu/repos","events_url":"https://api.github.com/users/Bluetegu/events{/privacy}","received_events_url":"https://api.github.com/users/Bluetegu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bluetegu/lnd","description":"Lightning Network Daemon ⚡️","fork":true,"url":"https://api.github.com/repos/Bluetegu/lnd","forks_url":"https://api.github.com/repos/Bluetegu/lnd/forks","keys_url":"https://api.github.com/repos/Bluetegu/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bluetegu/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bluetegu/lnd/teams","hooks_url":"https://api.github.com/repos/Bluetegu/lnd/hooks","issue_events_url":"https://api.github.com/repos/Bluetegu/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/Bluetegu/lnd/events","assignees_url":"https://api.github.com/repos/Bluetegu/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/Bluetegu/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/Bluetegu/lnd/tags","blobs_url":"https://api.github.com/repos/Bluetegu/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bluetegu/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bluetegu/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bluetegu/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bluetegu/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/Bluetegu/lnd/languages","stargazers_url":"https://api.github.com/repos/Bluetegu/lnd/stargazers","contributors_url":"https://api.github.com/repos/Bluetegu/lnd/contributors","subscribers_url":"https://api.github.com/repos/Bluetegu/lnd/subscribers","subscription_url":"https://api.github.com/repos/Bluetegu/lnd/subscription","commits_url":"https://api.github.com/repos/Bluetegu/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bluetegu/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bluetegu/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bluetegu/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bluetegu/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/Bluetegu/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bluetegu/lnd/merges","archive_url":"https://api.github.com/repos/Bluetegu/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bluetegu/lnd/downloads","issues_url":"https://api.github.com/repos/Bluetegu/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/Bluetegu/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/Bluetegu/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/Bluetegu/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bluetegu/lnd/labels{/name}","releases_url":"https://api.github.com/repos/Bluetegu/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/Bluetegu/lnd/deployments","created_at":"2018-05-10T08:21:35Z","updated_at":"2018-10-11T09:28:18Z","pushed_at":"2018-12-09T14:15:49Z","git_url":"git://github.com/Bluetegu/lnd.git","ssh_url":"git@github.com:Bluetegu/lnd.git","clone_url":"https://github.com/Bluetegu/lnd.git","svn_url":"https://github.com/Bluetegu/lnd","homepage":"","size":22883,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightningnetwork:master","ref":"master","sha":"5451211d1947de5b2376aff5eb39c6e9f969cbbb","user":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":49765480,"node_id":"MDEwOlJlcG9zaXRvcnk0OTc2NTQ4MA==","name":"lnd","full_name":"lightningnetwork/lnd","private":false,"owner":{"login":"lightningnetwork","id":13424735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDI0NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13424735?v=4","gravatar_id":"","url":"https://api.github.com/users/lightningnetwork","html_url":"https://github.com/lightningnetwork","followers_url":"https://api.github.com/users/lightningnetwork/followers","following_url":"https://api.github.com/users/lightningnetwork/following{/other_user}","gists_url":"https://api.github.com/users/lightningnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/lightningnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightningnetwork/subscriptions","organizations_url":"https://api.github.com/users/lightningnetwork/orgs","repos_url":"https://api.github.com/users/lightningnetwork/repos","events_url":"https://api.github.com/users/lightningnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/lightningnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightningnetwork/lnd","description":"Lightning Network Daemon ⚡️","fork":false,"url":"https://api.github.com/repos/lightningnetwork/lnd","forks_url":"https://api.github.com/repos/lightningnetwork/lnd/forks","keys_url":"https://api.github.com/repos/lightningnetwork/lnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightningnetwork/lnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightningnetwork/lnd/teams","hooks_url":"https://api.github.com/repos/lightningnetwork/lnd/hooks","issue_events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/events{/number}","events_url":"https://api.github.com/repos/lightningnetwork/lnd/events","assignees_url":"https://api.github.com/repos/lightningnetwork/lnd/assignees{/user}","branches_url":"https://api.github.com/repos/lightningnetwork/lnd/branches{/branch}","tags_url":"https://api.github.com/repos/lightningnetwork/lnd/tags","blobs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightningnetwork/lnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightningnetwork/lnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightningnetwork/lnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightningnetwork/lnd/statuses/{sha}","languages_url":"https://api.github.com/repos/lightningnetwork/lnd/languages","stargazers_url":"https://api.github.com/repos/lightningnetwork/lnd/stargazers","contributors_url":"https://api.github.com/repos/lightningnetwork/lnd/contributors","subscribers_url":"https://api.github.com/repos/lightningnetwork/lnd/subscribers","subscription_url":"https://api.github.com/repos/lightningnetwork/lnd/subscription","commits_url":"https://api.github.com/repos/lightningnetwork/lnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightningnetwork/lnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightningnetwork/lnd/contents/{+path}","compare_url":"https://api.github.com/repos/lightningnetwork/lnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightningnetwork/lnd/merges","archive_url":"https://api.github.com/repos/lightningnetwork/lnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightningnetwork/lnd/downloads","issues_url":"https://api.github.com/repos/lightningnetwork/lnd/issues{/number}","pulls_url":"https://api.github.com/repos/lightningnetwork/lnd/pulls{/number}","milestones_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones{/number}","notifications_url":"https://api.github.com/repos/lightningnetwork/lnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/labels{/name}","releases_url":"https://api.github.com/repos/lightningnetwork/lnd/releases{/id}","deployments_url":"https://api.github.com/repos/lightningnetwork/lnd/deployments","created_at":"2016-01-16T08:19:33Z","updated_at":"2018-12-09T11:01:43Z","pushed_at":"2018-12-09T14:44:22Z","git_url":"git://github.com/lightningnetwork/lnd.git","ssh_url":"git@github.com:lightningnetwork/lnd.git","clone_url":"https://github.com/lightningnetwork/lnd.git","svn_url":"https://github.com/lightningnetwork/lnd","homepage":"","size":23875,"stargazers_count":3269,"watchers_count":3269,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":836,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":836,"open_issues":331,"watchers":3269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299"},"html":{"href":"https://github.com/lightningnetwork/lnd/pull/2299"},"issue":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/2299"},"comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/issues/2299/comments"},"review_comments":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299/comments"},"review_comment":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2299/commits"},"statuses":{"href":"https://api.github.com/repos/lightningnetwork/lnd/statuses/0b5f44cb90a1d82803a60e25be653c873b607777"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xsb"}}