{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/2409","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/2409/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/2409/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/2409/events","html_url":"https://github.com/solidusio/solidus/pull/2409","id":277454670,"number":2409,"title":"Move Spree::Taxon#applicable_filters","user":{"login":"cbrunsdon","id":279013,"avatar_url":"https://avatars1.githubusercontent.com/u/279013?v=4","gravatar_id":"","url":"https://api.github.com/users/cbrunsdon","html_url":"https://github.com/cbrunsdon","followers_url":"https://api.github.com/users/cbrunsdon/followers","following_url":"https://api.github.com/users/cbrunsdon/following{/other_user}","gists_url":"https://api.github.com/users/cbrunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrunsdon/subscriptions","organizations_url":"https://api.github.com/users/cbrunsdon/orgs","repos_url":"https://api.github.com/users/cbrunsdon/repos","events_url":"https://api.github.com/users/cbrunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/cbrunsdon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-28T16:43:11Z","updated_at":"2018-03-28T18:24:26Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/2409","html_url":"https://github.com/solidusio/solidus/pull/2409","diff_url":"https://github.com/solidusio/solidus/pull/2409.diff","patch_url":"https://github.com/solidusio/solidus/pull/2409.patch"},"body":"How we handle product filters in core is pretty janky, as they're only used by our frontend but interwoven through core.\r\n\r\nAs is clear from [the documentation of product_filters](https://github.com/solidusio/solidus/blob/master/core/lib/spree/core/product_filters.rb):\r\n\r\n> THIS FILE SHOULD BE OVER-RIDDEN IN YOUR SITE EXTENSION!\r\n>   the exact code probably won't be useful, though you're welcome to modify and reuse\r\n>   the current contents are mainly for testing and documentation\r\n\r\nBy moving the `Spree::Taxon#applicable_filters` call (which was untested) into the frontend, we can eventually remove the applicable_filters call in `Spree::Taxon` (along with its `@note This method is meant to be overridden on a store by store basis.`), which is just as easy to customize in a helper.\r\n\r\nWith #applicable_filters removed, we can then remove the product_filters requirement of Spree::Taxon."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/376987458","html_url":"https://github.com/solidusio/solidus/pull/2409#issuecomment-376987458","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/2409","id":376987458,"user":{"login":"kennyadsl","id":167946,"avatar_url":"https://avatars3.githubusercontent.com/u/167946?v=4","gravatar_id":"","url":"https://api.github.com/users/kennyadsl","html_url":"https://github.com/kennyadsl","followers_url":"https://api.github.com/users/kennyadsl/followers","following_url":"https://api.github.com/users/kennyadsl/following{/other_user}","gists_url":"https://api.github.com/users/kennyadsl/gists{/gist_id}","starred_url":"https://api.github.com/users/kennyadsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennyadsl/subscriptions","organizations_url":"https://api.github.com/users/kennyadsl/orgs","repos_url":"https://api.github.com/users/kennyadsl/repos","events_url":"https://api.github.com/users/kennyadsl/events{/privacy}","received_events_url":"https://api.github.com/users/kennyadsl/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T18:24:26Z","updated_at":"2018-03-28T18:24:26Z","author_association":"MEMBER","body":"There's a conflict to be fixed, anyway I'm good with this change, thanks!"}}
{"actor":{"display_login":"kennyadsl"}}