{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/206403451","pull_request_review_id":141810622,"id":206403451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjQwMzQ1MQ==","diff_hunk":"@@ -38,7 +31,7 @@\n  */\n @Slf4j\n public class Pinger implements AutoCloseable {\n-    private static final double PING_INTERVAL_FACTOR = 0.5; //ping interval = factor * txn lease time.\n+    private static final double PING_INTERVAL_FACTOR = 0.25; //ping interval = factor * txn lease time.","path":"client/src/main/java/io/pravega/client/stream/impl/Pinger.java","position":37,"original_position":37,"commit_id":"d9e540bf992acf55cc74cce802454785ccb057b7","original_commit_id":"d9e540bf992acf55cc74cce802454785ccb057b7","user":{"login":"shiveshr","id":13659022,"node_id":"MDQ6VXNlcjEzNjU5MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"body":"For low txn lease times, this could make pings lot more aggressive, which will take up additional compute resources on both controller and client. \r\nWe should either have a floor on the ping interval so that we know that we are not hammering the server with very aggressive pings. \r\nThe intent here is to make sure that \"at least\" one ping per txn-lease-time period is sent so that transaction's lease gets renewed. So maybe 0.5 factor suffices, and we could just add retry block on failed pings (and only for retryable failures).  ","created_at":"2018-07-31T06:07:41Z","updated_at":"2018-07-31T06:07:41Z","html_url":"https://github.com/pravega/pravega/pull/2806#discussion_r206403451","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/2806","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/206403451"},"html":{"href":"https://github.com/pravega/pravega/pull/2806#discussion_r206403451"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2806"}}},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/2806","id":205003673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDAzNjcz","html_url":"https://github.com/pravega/pravega/pull/2806","diff_url":"https://github.com/pravega/pravega/pull/2806.diff","patch_url":"https://github.com/pravega/pravega/pull/2806.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/2806","number":2806,"state":"open","locked":false,"title":"Issue 2805: Improve resilience of Pinger","user":{"login":"tkaitchuck","id":4756752,"node_id":"MDQ6VXNlcjQ3NTY3NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>\r\n\r\n**Change log description**\r\n* Log and suppress exceptions when pinging transactions.\r\n* Change PING_INTERVAL_FACTOR from 0.5 to 0.25\r\n\r\n**Purpose of the change**\r\nFixes #2805\r\n\r\n**What the code does**\r\nRefactors pingTransactions() to handle unexpected exceptions rather than letting them reach the thread pool which would cancel the recurring task.\r\nChanges the ping interval.\r\n","created_at":"2018-07-31T05:58:42Z","updated_at":"2018-07-31T06:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff83cc7310a4fb629211999795273a3bc532605c","assignee":{"login":"shrids","id":11114165,"node_id":"MDQ6VXNlcjExMTE0MTY1","avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false},"assignees":[{"login":"shrids","id":11114165,"node_id":"MDQ6VXNlcjExMTE0MTY1","avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shrids","id":11114165,"node_id":"MDQ6VXNlcjExMTE0MTY1","avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":539728119,"node_id":"MDU6TGFiZWw1Mzk3MjgxMTk=","url":"https://api.github.com/repos/pravega/pravega/labels/area/transaction","name":"area/transaction","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/2806/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/2806/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/2806/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/d9e540bf992acf55cc74cce802454785ccb057b7","head":{"label":"tkaitchuck:txnPingFixes","ref":"txnPingFixes","sha":"d9e540bf992acf55cc74cce802454785ccb057b7","user":{"login":"tkaitchuck","id":4756752,"node_id":"MDQ6VXNlcjQ3NTY3NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"repo":{"id":90919636,"node_id":"MDEwOlJlcG9zaXRvcnk5MDkxOTYzNg==","name":"pravega-1","full_name":"tkaitchuck/pravega-1","owner":{"login":"tkaitchuck","id":4756752,"node_id":"MDQ6VXNlcjQ3NTY3NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkaitchuck/pravega-1","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/tkaitchuck/pravega-1","forks_url":"https://api.github.com/repos/tkaitchuck/pravega-1/forks","keys_url":"https://api.github.com/repos/tkaitchuck/pravega-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkaitchuck/pravega-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkaitchuck/pravega-1/teams","hooks_url":"https://api.github.com/repos/tkaitchuck/pravega-1/hooks","issue_events_url":"https://api.github.com/repos/tkaitchuck/pravega-1/issues/events{/number}","events_url":"https://api.github.com/repos/tkaitchuck/pravega-1/events","assignees_url":"https://api.github.com/repos/tkaitchuck/pravega-1/assignees{/user}","branches_url":"https://api.github.com/repos/tkaitchuck/pravega-1/branches{/branch}","tags_url":"https://api.github.com/repos/tkaitchuck/pravega-1/tags","blobs_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkaitchuck/pravega-1/statuses/{sha}","languages_url":"https://api.github.com/repos/tkaitchuck/pravega-1/languages","stargazers_url":"https://api.github.com/repos/tkaitchuck/pravega-1/stargazers","contributors_url":"https://api.github.com/repos/tkaitchuck/pravega-1/contributors","subscribers_url":"https://api.github.com/repos/tkaitchuck/pravega-1/subscribers","subscription_url":"https://api.github.com/repos/tkaitchuck/pravega-1/subscription","commits_url":"https://api.github.com/repos/tkaitchuck/pravega-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkaitchuck/pravega-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkaitchuck/pravega-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkaitchuck/pravega-1/contents/{+path}","compare_url":"https://api.github.com/repos/tkaitchuck/pravega-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkaitchuck/pravega-1/merges","archive_url":"https://api.github.com/repos/tkaitchuck/pravega-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkaitchuck/pravega-1/downloads","issues_url":"https://api.github.com/repos/tkaitchuck/pravega-1/issues{/number}","pulls_url":"https://api.github.com/repos/tkaitchuck/pravega-1/pulls{/number}","milestones_url":"https://api.github.com/repos/tkaitchuck/pravega-1/milestones{/number}","notifications_url":"https://api.github.com/repos/tkaitchuck/pravega-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkaitchuck/pravega-1/labels{/name}","releases_url":"https://api.github.com/repos/tkaitchuck/pravega-1/releases{/id}","deployments_url":"https://api.github.com/repos/tkaitchuck/pravega-1/deployments","created_at":"2017-05-11T00:19:21Z","updated_at":"2018-06-29T15:52:23Z","pushed_at":"2018-07-31T05:56:02Z","git_url":"git://github.com/tkaitchuck/pravega-1.git","ssh_url":"git@github.com:tkaitchuck/pravega-1.git","clone_url":"https://github.com/tkaitchuck/pravega-1.git","svn_url":"https://github.com/tkaitchuck/pravega-1","homepage":"http://pravega.io","size":24814,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"5360823c28acdc4c8ba8e33be3e40c74974abb49","user":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"node_id":"MDEwOlJlcG9zaXRvcnk2MzA5NjgyMg==","name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2018-07-27T20:09:42Z","pushed_at":"2018-07-31T05:58:43Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":26135,"stargazers_count":230,"watchers_count":230,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":350,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":80,"open_issues":350,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2806"},"html":{"href":"https://github.com/pravega/pravega/pull/2806"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/2806"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/2806/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2806/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2806/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/d9e540bf992acf55cc74cce802454785ccb057b7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shiveshr"}}