{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4159","repository_url":"https://api.github.com/repos/xamarin/xamarin-macios","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4159/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4159/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4159/events","html_url":"https://github.com/xamarin/xamarin-macios/pull/4159","id":327668438,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDA0NjEy","number":4159,"title":"Add support for building on Jenkins.","user":{"login":"rolfbjarne","id":249268,"node_id":"MDQ6VXNlcjI0OTI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/249268?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"labels":[{"id":948085339,"node_id":"MDU6TGFiZWw5NDgwODUzMzk=","url":"https://api.github.com/repos/xamarin/xamarin-macios/labels/build-package","name":"build-package","color":"fbca04","default":false},{"id":390089067,"node_id":"MDU6TGFiZWwzOTAwODkwNjc=","url":"https://api.github.com/repos/xamarin/xamarin-macios/labels/do-not-merge","name":"do-not-merge","color":"006b75","default":false},{"id":483439665,"node_id":"MDU6TGFiZWw0ODM0Mzk2NjU=","url":"https://api.github.com/repos/xamarin/xamarin-macios/labels/skip-all-tests","name":"skip-all-tests","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-05-30T10:25:16Z","updated_at":"2018-06-01T23:03:41Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/4159","html_url":"https://github.com/xamarin/xamarin-macios/pull/4159","diff_url":"https://github.com/xamarin/xamarin-macios/pull/4159.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/4159.patch"},"body":"Add support for building on internal Jenkins.\r\n\r\nJenkins has been configured to build every branch on xamarin/xamarin-macios that contains a `jenkins/Jenkinsfile`, which means it will start working as soon as this PR is merged.\r\n\r\nResults will be posted as statuses on each commit, which can be viewed using the url `https://github.com/xamarin/xamarin-macios/commits/<branch>`:\r\n\r\n![screenshot 2018-06-01 11 12 57](https://user-images.githubusercontent.com/249268/40832932-c3b05eb0-658c-11e8-9670-8de5fcc23407.png)\r\n\r\n* The `continuous-integration/jenkins/branch` status links to the jenkins job.\r\n* The other two are XI and XM packages (the `Jenkins-` prefix will be removed once we officially switch from Wrench to Jenkins).\r\n\r\nMore detailed information will be added as a comment to each commit, which can be seen by clicking on the commit and scrolling to the bottom (url of the format `https://github.com/xamarin/xamarin-macios/commit/<sha1>`)\r\n\r\n![screenshot 2018-06-01 11 14 33](https://user-images.githubusercontent.com/249268/40833014-fd8772f4-658c-11e8-8a35-5df46bfb16c7.png)\r\n\r\nUnfortunately GitHub does not display the commit statuses when viewing a single commit, so to view those statuses you'll have to view the list of commits (the `/commits/` url). Tip: it's possible to use `<sha1>` instead of `<branch>` (and vice versa for that matter) if you're interested in the statuses of a particular commit.\r\n\r\nPull requests will also be built (only from contributors with write access), but by default nothing will be done (the job will exit immediately, although a green check mark will still show up). Jenkins will **not** add a comment in the pull request in this case.\r\n\r\nHowever, if the label `build-package` [1] is set for a pull request, the internal jenkins job will run (it will do everything except the local xharness test run: this includes creating and publishing packages, creating various diffs, run tests on older macOS versions, test docs, etc). A detailed comment will also be added to the pull request (see below for multiple examples), which means that there will be two Jenkins comments: one for the public Jenkins which builds every PR, and one for the internal Jenkins [2].\r\n\r\n[1] I don't quite like the name of the label, because it doesn't get even close to explain all that will actually happen, but `run-on-internal-jenkins-and-create-package` is a bit too long IMHO... Also it's non-obvious that this is the label to apply if the reason for executing on the internal jenkins is some other reason (for instance to test a maccore bump). Other ideas:\r\n\r\n* `run-internal-jenkins`: doesn't make it obvious that a package will be created (which is probably the most common reason to want to run on internal jenkins)\r\n* We could have multiple labels that mean the same thing: `build-package`, `internal-build`, `run-internal-jenkins`, etc, but it's redundant and I don't quite like it either.\r\n* Any other ideas?\r\n\r\n[2] I'm noticing now that these two look quite similar and this might end up confusing (the main difference is that the comment from the public jenkins will say **Build success/failure** and **Build comment file:** at the top. If something goes wrong the failure will also show up differently). Should this be made clearer?"},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments/394031302","html_url":"https://github.com/xamarin/xamarin-macios/pull/4159#issuecomment-394031302","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/4159","id":394031302,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDAzMTMwMg==","user":{"login":"rolfbjarne","id":249268,"node_id":"MDQ6VXNlcjI0OTI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/249268?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T23:03:41Z","updated_at":"2018-06-01T23:03:41Z","author_association":"MEMBER","body":"🔥 [Jenkins job](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4159/22/display/redirect) (on internal Jenkins) failed in stage 'Running XM tests on '10.7'' 🔥 : hudson.AbortException: script returned exit code 2\n\n✅ [Build succeeded](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4159/22//console)\n✅ [API Diff (from stable)](http://xamarin-storage/jenkins/xamarin-macios/PR-4159/b735c2f3e8cf7b53ea75ce91ac1ac1945c87130a/22/jenkins-results/api-diff/index.html)\n✅ [API Diff (from PR only)](http://xamarin-storage/jenkins/xamarin-macios/PR-4159/b735c2f3e8cf7b53ea75ce91ac1ac1945c87130a/22/jenkins-results/apicomparison/index.html) (no change)\n✅ [Generator Diff](http://xamarin-storage/jenkins/xamarin-macios/PR-4159/b735c2f3e8cf7b53ea75ce91ac1ac1945c87130a/22/jenkins-results/generator-diff/index.html) (only version changes)\nℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.\n🔥 [Xamarin.Mac tests on 10.9 failed](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4159/22/display/redirect) 🔥\n🔥 [Xamarin.Mac tests on 10.10 failed](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4159/22/display/redirect) 🔥\n🔥 [Xamarin.Mac tests on 10.8 failed](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4159/22/display/redirect) 🔥\n🔥 [Xamarin.Mac tests on 10.7 failed](http://xamarin-jenkins.guest.corp.microsoft.com:8080/job/macios/job/PR-4159/22/display/redirect) 🔥\n"}}
{"actor":{"display_login":"rolfbjarne"}}