{"action":"created","comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/183423936","pull_request_review_id":114419186,"id":183423936,"diff_hunk":"@@ -86,9 +96,11 @@ line, which is needed. In order to make Qt available you need to\n add a symbol link (do something like\n ln -s <Qt location>/<version>/<type>/bin/qmake /usr/local/bin/qmake\n \n-QtWebKit is needed, but no longer part of Qt5, so you need to download it and compile.\n-We want to replace QtWebKit, but at the moment the print process depends on functions\n-only available in QtWebKit\n+QtWebKit is needed, if you want to print, but no longer part of Qt5,\n+so you need to download it and compile. We want to replace QtWebKit,\n+but at the moment the print process depends on functions only available\n+in QtWebKit. In case you just want to test without print possibility\n+omit this step.","path":"INSTALL","position":128,"original_position":42,"commit_id":"3ae2dba44e5fafd9b0fbf9598c34d5a8a3b41f42","original_commit_id":"3ae2dba44e5fafd9b0fbf9598c34d5a8a3b41f42","user":{"login":"janiversen","id":6185391,"avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"body":"Yes I planned on doing that in a separate commit.","created_at":"2018-04-23T14:51:52Z","updated_at":"2018-04-23T14:51:52Z","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1217#discussion_r183423936","pull_request_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/183423936"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1217#discussion_r183423936"},"pull_request":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217"}},"in_reply_to_id":183419056},"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217","id":183358709,"html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1217","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1217.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1217.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1217","number":1217,"state":"open","locked":false,"title":"Updated INSTALL, based on first time building experience.","user":{"login":"janiversen","id":6185391,"avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"body":"INSTALL is updated to reflect how to install/build subusurface\r\non Mac. It has also been updated with several generic parts.\r\n\r\n3 parts are still outstanding (to come soon):\r\nQtWebKit, need to document how to download/build\r\nMac, final touches\r\niOS, need to document the build process\r\n\r\nSigned-off-by: Jan Iversen <jani@apache.org>\r\n\r\n<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Code cleanup\r\n- [ ] Build system change\r\n- [x ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\nI decided to file this pull-request, so you all had a chance of reviewing the general\r\nsections of the INSTALL file.\r\n\r\nI have been very careful to document the steps needed (on my Mac) to get subsurface\r\ncompiled, without depending on previous installed software. I still have a few finishing\r\ntouches outstanding for the Mac build (problem with libtool, QtWebKit), and then I will\r\nmove on to the iOS build.\r\n\r\nI have tried to integrate the information I have been given in multiple mails, Thanks for \r\nusing energy to explain things that are logical to the experienced developer.\r\n\r\nMy English is nowhere perfect, so please feel free to update the text as you see fit.\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\nUpdated INSTALL to reflect current build procedure\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\nI did on purpose not add it to CHANGELOG.md, as I am unsure if you want to document\r\ndeveloper only change in the release notes.\r\n\r\nBtw. some other projects generate CHANGELOG.md automatically by extracting all commit texts.\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\nNo user experience change\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n\r\nSigned-off-by: Jan Iversen <jani@apache.org>","created_at":"2018-04-23T08:25:12Z","updated_at":"2018-04-23T14:51:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc47ca29feef9d8b103b00b04a05e658106f125","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1217/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/3ae2dba44e5fafd9b0fbf9598c34d5a8a3b41f42","head":{"label":"janiversen:jani","ref":"jani","sha":"3ae2dba44e5fafd9b0fbf9598c34d5a8a3b41f42","user":{"login":"janiversen","id":6185391,"avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"repo":{"id":130397967,"name":"subsurface","full_name":"janiversen/subsurface","owner":{"login":"janiversen","id":6185391,"avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janiversen/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":true,"url":"https://api.github.com/repos/janiversen/subsurface","forks_url":"https://api.github.com/repos/janiversen/subsurface/forks","keys_url":"https://api.github.com/repos/janiversen/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janiversen/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janiversen/subsurface/teams","hooks_url":"https://api.github.com/repos/janiversen/subsurface/hooks","issue_events_url":"https://api.github.com/repos/janiversen/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/janiversen/subsurface/events","assignees_url":"https://api.github.com/repos/janiversen/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/janiversen/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/janiversen/subsurface/tags","blobs_url":"https://api.github.com/repos/janiversen/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janiversen/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janiversen/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/janiversen/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janiversen/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/janiversen/subsurface/languages","stargazers_url":"https://api.github.com/repos/janiversen/subsurface/stargazers","contributors_url":"https://api.github.com/repos/janiversen/subsurface/contributors","subscribers_url":"https://api.github.com/repos/janiversen/subsurface/subscribers","subscription_url":"https://api.github.com/repos/janiversen/subsurface/subscription","commits_url":"https://api.github.com/repos/janiversen/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/janiversen/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/janiversen/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/janiversen/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/janiversen/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/janiversen/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janiversen/subsurface/merges","archive_url":"https://api.github.com/repos/janiversen/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janiversen/subsurface/downloads","issues_url":"https://api.github.com/repos/janiversen/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/janiversen/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/janiversen/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/janiversen/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janiversen/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/janiversen/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/janiversen/subsurface/deployments","created_at":"2018-04-20T18:11:15Z","updated_at":"2018-04-22T16:42:46Z","pushed_at":"2018-04-23T11:16:47Z","git_url":"git://github.com/janiversen/subsurface.git","ssh_url":"git@github.com:janiversen/subsurface.git","clone_url":"https://github.com/janiversen/subsurface.git","svn_url":"https://github.com/janiversen/subsurface","homepage":"https://subsurface-divelog.org","size":88843,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"50b8044d56ea28c7c3714a8fc859c133ea6717a2","user":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-04-23T02:16:23Z","pushed_at":"2018-04-23T11:16:49Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":88834,"stargazers_count":1357,"watchers_count":1357,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":347,"open_issues":75,"watchers":1357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1217"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1217"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1217/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1217/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/3ae2dba44e5fafd9b0fbf9598c34d5a8a3b41f42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janiversen"}}