{"action":"created","comment":{"url":"https://api.github.com/repos/divio/django-cms/pulls/comments/231823462","pull_request_review_id":172876985,"id":231823462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTgyMzQ2Mg==","diff_hunk":"@@ -140,6 +140,14 @@ def configure_cms_apps(apps_with_features):\n                 configure_app(app_config.cms_config)\n \n \n+def ready_cms_apps(apps_with_features):\n+    \"\"\"Run ready() methods on every registered cms extension,\n+    so that final checks can happen after all apps have been configured\n+    \"\"\"\n+    for app_with_feature in apps_with_features:\n+        app_with_feature.cms_extension.ready()","path":"cms/app_registration.py","position":9,"original_position":9,"commit_id":"72354244550b044902ce0e02cdb7b4f639d9281d","original_commit_id":"72354244550b044902ce0e02cdb7b4f639d9281d","user":{"login":"Aiky30","id":12543977,"node_id":"MDQ6VXNlcjEyNTQzOTc3","avatar_url":"https://avatars2.githubusercontent.com/u/12543977?v=4","gravatar_id":"","url":"https://api.github.com/users/Aiky30","html_url":"https://github.com/Aiky30","followers_url":"https://api.github.com/users/Aiky30/followers","following_url":"https://api.github.com/users/Aiky30/following{/other_user}","gists_url":"https://api.github.com/users/Aiky30/gists{/gist_id}","starred_url":"https://api.github.com/users/Aiky30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aiky30/subscriptions","organizations_url":"https://api.github.com/users/Aiky30/orgs","repos_url":"https://api.github.com/users/Aiky30/repos","events_url":"https://api.github.com/users/Aiky30/events{/privacy}","received_events_url":"https://api.github.com/users/Aiky30/received_events","type":"User","site_admin":false},"body":"@chaosk It would be nice to see all of the other apps configs at this point, this could help prevent apps having to use monkeypatching / hacking as much as they are by having exposure to their other apps and their own registered configs.","created_at":"2018-11-08T09:53:37Z","updated_at":"2018-11-08T09:53:59Z","html_url":"https://github.com/divio/django-cms/pull/6554#discussion_r231823462","pull_request_url":"https://api.github.com/repos/divio/django-cms/pulls/6554","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments/231823462"},"html":{"href":"https://github.com/divio/django-cms/pull/6554#discussion_r231823462"},"pull_request":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6554"}}},"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/6554","id":229103428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTAzNDI4","html_url":"https://github.com/divio/django-cms/pull/6554","diff_url":"https://github.com/divio/django-cms/pull/6554.diff","patch_url":"https://github.com/divio/django-cms/pull/6554.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/6554","number":6554,"state":"open","locked":false,"title":"Add CMSAppExtension.ready which is called after all cms app configs are loaded","user":{"login":"chaosk","id":99521,"node_id":"MDQ6VXNlcjk5NTIx","avatar_url":"https://avatars2.githubusercontent.com/u/99521?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosk","html_url":"https://github.com/chaosk","followers_url":"https://api.github.com/users/chaosk/followers","following_url":"https://api.github.com/users/chaosk/following{/other_user}","gists_url":"https://api.github.com/users/chaosk/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosk/subscriptions","organizations_url":"https://api.github.com/users/chaosk/orgs","repos_url":"https://api.github.com/users/chaosk/repos","events_url":"https://api.github.com/users/chaosk/events{/privacy}","received_events_url":"https://api.github.com/users/chaosk/received_events","type":"User","site_admin":false},"body":"\r\n\r\n<!--\r\n    If this is a security-related patch stop immediately!\r\n\r\n    See http://docs.django-cms.org/en/latest/contributing/development-policies.html\r\n-->\r\n\r\n\r\n### Summary\r\n\r\nFixes #\r\n\r\n\r\n\r\n### Links to related discussion\r\n\r\n\r\n\r\n### Proposed changes in this pull request\r\n\r\n\r\n### Documentation checklist\r\n\r\n* [ ] I have updated CHANGELOG.txt if appropriate\r\n* [ ] I have updated the release notes document if appropriate, with:\r\n    * [ ] general notes\r\n    * [ ] bug-fixes\r\n    * [ ] improvements/new features\r\n    * [ ] backwards-incompatible changes\r\n    * [ ] required upgrade steps\r\n    * [ ] names of contributors\r\n* [ ] I have updated other documentation\r\n* [ ] I have added my name to the AUTHORS file\r\n* [ ] This PR's documentation has been approved by Daniele Procida\r\n","created_at":"2018-11-07T17:11:28Z","updated_at":"2018-11-08T09:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"441e8080adc7e2af452dcaf582d6c1d03fdd60d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kinkerl","id":71950,"node_id":"MDQ6VXNlcjcxOTUw","avatar_url":"https://avatars1.githubusercontent.com/u/71950?v=4","gravatar_id":"","url":"https://api.github.com/users/kinkerl","html_url":"https://github.com/kinkerl","followers_url":"https://api.github.com/users/kinkerl/followers","following_url":"https://api.github.com/users/kinkerl/following{/other_user}","gists_url":"https://api.github.com/users/kinkerl/gists{/gist_id}","starred_url":"https://api.github.com/users/kinkerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinkerl/subscriptions","organizations_url":"https://api.github.com/users/kinkerl/orgs","repos_url":"https://api.github.com/users/kinkerl/repos","events_url":"https://api.github.com/users/kinkerl/events{/privacy}","received_events_url":"https://api.github.com/users/kinkerl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/6554/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/6554/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/6554/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/72354244550b044902ce0e02cdb7b4f639d9281d","head":{"label":"chaosk:feature/appextension-ready","ref":"feature/appextension-ready","sha":"72354244550b044902ce0e02cdb7b4f639d9281d","user":{"login":"chaosk","id":99521,"node_id":"MDQ6VXNlcjk5NTIx","avatar_url":"https://avatars2.githubusercontent.com/u/99521?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosk","html_url":"https://github.com/chaosk","followers_url":"https://api.github.com/users/chaosk/followers","following_url":"https://api.github.com/users/chaosk/following{/other_user}","gists_url":"https://api.github.com/users/chaosk/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosk/subscriptions","organizations_url":"https://api.github.com/users/chaosk/orgs","repos_url":"https://api.github.com/users/chaosk/repos","events_url":"https://api.github.com/users/chaosk/events{/privacy}","received_events_url":"https://api.github.com/users/chaosk/received_events","type":"User","site_admin":false},"repo":{"id":132455455,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTU0NTU=","name":"django-cms","full_name":"chaosk/django-cms","private":false,"owner":{"login":"chaosk","id":99521,"node_id":"MDQ6VXNlcjk5NTIx","avatar_url":"https://avatars2.githubusercontent.com/u/99521?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosk","html_url":"https://github.com/chaosk","followers_url":"https://api.github.com/users/chaosk/followers","following_url":"https://api.github.com/users/chaosk/following{/other_user}","gists_url":"https://api.github.com/users/chaosk/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosk/subscriptions","organizations_url":"https://api.github.com/users/chaosk/orgs","repos_url":"https://api.github.com/users/chaosk/repos","events_url":"https://api.github.com/users/chaosk/events{/privacy}","received_events_url":"https://api.github.com/users/chaosk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chaosk/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":true,"url":"https://api.github.com/repos/chaosk/django-cms","forks_url":"https://api.github.com/repos/chaosk/django-cms/forks","keys_url":"https://api.github.com/repos/chaosk/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaosk/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaosk/django-cms/teams","hooks_url":"https://api.github.com/repos/chaosk/django-cms/hooks","issue_events_url":"https://api.github.com/repos/chaosk/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/chaosk/django-cms/events","assignees_url":"https://api.github.com/repos/chaosk/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/chaosk/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/chaosk/django-cms/tags","blobs_url":"https://api.github.com/repos/chaosk/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaosk/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaosk/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaosk/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaosk/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/chaosk/django-cms/languages","stargazers_url":"https://api.github.com/repos/chaosk/django-cms/stargazers","contributors_url":"https://api.github.com/repos/chaosk/django-cms/contributors","subscribers_url":"https://api.github.com/repos/chaosk/django-cms/subscribers","subscription_url":"https://api.github.com/repos/chaosk/django-cms/subscription","commits_url":"https://api.github.com/repos/chaosk/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaosk/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaosk/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaosk/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaosk/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/chaosk/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaosk/django-cms/merges","archive_url":"https://api.github.com/repos/chaosk/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaosk/django-cms/downloads","issues_url":"https://api.github.com/repos/chaosk/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/chaosk/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/chaosk/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/chaosk/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaosk/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/chaosk/django-cms/releases{/id}","deployments_url":"https://api.github.com/repos/chaosk/django-cms/deployments","created_at":"2018-05-07T12:10:25Z","updated_at":"2018-05-07T12:10:31Z","pushed_at":"2018-11-07T17:09:21Z","git_url":"git://github.com/chaosk/django-cms.git","ssh_url":"git@github.com:chaosk/django-cms.git","clone_url":"https://github.com/chaosk/django-cms.git","svn_url":"https://github.com/chaosk/django-cms","homepage":"http://www.django-cms.org","size":80984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"divio:release/4.0.x","ref":"release/4.0.x","sha":"4e4d1cb1f9415b0e1fb9bb5a13b6f5697376cbe0","user":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1ODA=","name":"django-cms","full_name":"divio/django-cms","private":false,"owner":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","deployments_url":"https://api.github.com/repos/divio/django-cms/deployments","created_at":"2009-03-05T10:14:18Z","updated_at":"2018-11-08T07:01:05Z","pushed_at":"2018-11-07T18:16:05Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":80994,"stargazers_count":6312,"watchers_count":6312,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2204,"mirror_url":null,"archived":false,"open_issues_count":252,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2204,"open_issues":252,"watchers":6312,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6554"},"html":{"href":"https://github.com/divio/django-cms/pull/6554"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/6554"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/6554/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6554/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6554/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/72354244550b044902ce0e02cdb7b4f639d9281d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Aiky30"}}