{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/251","repository_url":"https://api.github.com/repos/kubernetes-sigs/kustomize","labels_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/251/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/251/events","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/251","id":350212516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTE4NDg2","number":251,"title":"Add --command-timeout option for handling secrets","user":{"login":"ivan4th","id":190448,"node_id":"MDQ6VXNlcjE5MDQ0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/190448?v=4","gravatar_id":"","url":"https://api.github.com/users/ivan4th","html_url":"https://github.com/ivan4th","followers_url":"https://api.github.com/users/ivan4th/followers","following_url":"https://api.github.com/users/ivan4th/following{/other_user}","gists_url":"https://api.github.com/users/ivan4th/gists{/gist_id}","starred_url":"https://api.github.com/users/ivan4th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivan4th/subscriptions","organizations_url":"https://api.github.com/users/ivan4th/orgs","repos_url":"https://api.github.com/users/ivan4th/repos","events_url":"https://api.github.com/users/ivan4th/events{/privacy}","received_events_url":"https://api.github.com/users/ivan4th/received_events","type":"User","site_admin":false},"labels":[{"id":930398993,"node_id":"MDU6TGFiZWw5MzAzOTg5OTM=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":934259944,"node_id":"MDU6TGFiZWw5MzQyNTk5NDQ=","url":"https://api.github.com/repos/kubernetes-sigs/kustomize/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-13T22:11:52Z","updated_at":"2018-08-13T22:42:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/pulls/251","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/251","diff_url":"https://github.com/kubernetes-sigs/kustomize/pull/251.diff","patch_url":"https://github.com/kubernetes-sigs/kustomize/pull/251.patch"},"body":"This PR adds `--command-timeout` option for `build` and `diff` commands.\r\nA typical use case for it is a command in `secretGenerator` that requires the user to type a passphrase to e.g. decrypt some kind of .gpg file with secrets, which may happen when kustomize is run manually for testing as opposed to being run as part of a CI job.\r\nAnother possibility is some kind of command that may take more than 5 seconds because of network latency and so on.\r\nI'm not quite sure this is a correct approach, and also it's a bit hard to test, so please let me know what do you think about adding this option."},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/comments/412690000","html_url":"https://github.com/kubernetes-sigs/kustomize/pull/251#issuecomment-412690000","issue_url":"https://api.github.com/repos/kubernetes-sigs/kustomize/issues/251","id":412690000,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjY5MDAwMA==","user":{"login":"Liujingfang1","id":8498608,"node_id":"MDQ6VXNlcjg0OTg2MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8498608?v=4","gravatar_id":"","url":"https://api.github.com/users/Liujingfang1","html_url":"https://github.com/Liujingfang1","followers_url":"https://api.github.com/users/Liujingfang1/followers","following_url":"https://api.github.com/users/Liujingfang1/following{/other_user}","gists_url":"https://api.github.com/users/Liujingfang1/gists{/gist_id}","starred_url":"https://api.github.com/users/Liujingfang1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liujingfang1/subscriptions","organizations_url":"https://api.github.com/users/Liujingfang1/orgs","repos_url":"https://api.github.com/users/Liujingfang1/repos","events_url":"https://api.github.com/users/Liujingfang1/events{/privacy}","received_events_url":"https://api.github.com/users/Liujingfang1/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T22:42:56Z","updated_at":"2018-08-13T22:42:56Z","author_association":"COLLABORATOR","body":"@ivan4th We don't want `kustomize build` to accept any flags which affects the output as described in https://github.com/kubernetes-sigs/kustomize/blob/master/docs/eschewedFeatures.md\r\n\r\nTo set a timeout for the secretGenerators, you can add the timeout in secretGenerator commands. You can get some examples of setting that following these links\r\nhttps://stackoverflow.com/questions/687948/timeout-a-command-in-bash-without-unnecessary-delay\r\nhttps://unix.stackexchange.com/questions/405337/bash-if-command-doesnt-finish-in-x-time\r\n\r\nTo enter a password without manual tying, you also have multiple ways. In bash,  you can use '<<<'.\r\nNot to protect your security, you can set some user_id or password only for your CI job and only use it in CI jobs. "}}
{"actor":{"display_login":"Liujingfang1"}}