{"action":"created","issue":{"url":"https://api.github.com/repos/meetfranz/franz/issues/362","repository_url":"https://api.github.com/repos/meetfranz/franz","labels_url":"https://api.github.com/repos/meetfranz/franz/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/meetfranz/franz/issues/362/comments","events_url":"https://api.github.com/repos/meetfranz/franz/issues/362/events","html_url":"https://github.com/meetfranz/franz/pull/362","id":277595258,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU1MjI1Njk5","number":362,"title":"[PR] Dark Mode","user":{"login":"JasonEtco","id":10660468,"node_id":"MDQ6VXNlcjEwNjYwNDY4","avatar_url":"https://avatars1.githubusercontent.com/u/10660468?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonEtco","html_url":"https://github.com/JasonEtco","followers_url":"https://api.github.com/users/JasonEtco/followers","following_url":"https://api.github.com/users/JasonEtco/following{/other_user}","gists_url":"https://api.github.com/users/JasonEtco/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonEtco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonEtco/subscriptions","organizations_url":"https://api.github.com/users/JasonEtco/orgs","repos_url":"https://api.github.com/users/JasonEtco/repos","events_url":"https://api.github.com/users/JasonEtco/events{/privacy}","received_events_url":"https://api.github.com/users/JasonEtco/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-11-29T01:13:19Z","updated_at":"2018-10-12T13:11:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/meetfranz/franz/pulls/362","html_url":"https://github.com/meetfranz/franz/pull/362","diff_url":"https://github.com/meetfranz/franz/pull/362.diff","patch_url":"https://github.com/meetfranz/franz/pull/362.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n### Description\r\nDark Mode 🦇 🌔 🎉 This is an MVP of what should eventually be a more holistic, app-wide change (right now it just changes the sidebar colors). I've added a toggle in the settings under Appearance, and modified the colors in the sidebar appropriately. I do think that this should be merged in the meantime, since building out the \"dark theme\" will be much easier once the logic has been added.\r\n\r\n**Note**: I'm not sure how the i18n stuff works within this project. In the settings it renders as `!!!Dark Mode`, which I understand to mean that there is no available translation?\r\n\r\n<img width=\"365\" alt=\"image\" src=\"https://user-images.githubusercontent.com/10660468/33352719-3e1dde1c-d478-11e7-9a38-88779d788389.png\">\r\n\r\n\r\n### Motivation and Context\r\nFixes #49. It's been the only thing that hasn't totally sold me on Franz since this afternoon when I was first introduced to it, so I'm happy it wasn't too difficult to implement 😄 \r\n\r\n### How Has This Been Tested?\r\nThere aren't any tests in the repo, so I've just meandered around on my own within the app.\r\n\r\n### Screenshots (if appropriate):\r\n<img width=\"1371\" alt=\"image\" src=\"https://user-images.githubusercontent.com/10660468/33352622-ce7e4a9c-d477-11e7-9c1d-134a9fc994e2.png\">\r\n\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project (run `$ yarn lint`).\r\n- [x] I have updated the documentation accordingly.\r\n\r\n☝️ Not sure if this should be documented?\r\n"},"comment":{"url":"https://api.github.com/repos/meetfranz/franz/issues/comments/429320565","html_url":"https://github.com/meetfranz/franz/pull/362#issuecomment-429320565","issue_url":"https://api.github.com/repos/meetfranz/franz/issues/362","id":429320565,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTMyMDU2NQ==","user":{"login":"Luminus","id":248077,"node_id":"MDQ6VXNlcjI0ODA3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/248077?v=4","gravatar_id":"","url":"https://api.github.com/users/Luminus","html_url":"https://github.com/Luminus","followers_url":"https://api.github.com/users/Luminus/followers","following_url":"https://api.github.com/users/Luminus/following{/other_user}","gists_url":"https://api.github.com/users/Luminus/gists{/gist_id}","starred_url":"https://api.github.com/users/Luminus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luminus/subscriptions","organizations_url":"https://api.github.com/users/Luminus/orgs","repos_url":"https://api.github.com/users/Luminus/repos","events_url":"https://api.github.com/users/Luminus/events{/privacy}","received_events_url":"https://api.github.com/users/Luminus/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T13:11:58Z","updated_at":"2018-10-12T13:11:58Z","author_association":"NONE","body":"Howdy folks, just checking to see if this is going to get merged."}}
{"actor":{"display_login":"Luminus"}}