{"action":"created","comment":{"url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/comments/172115055","pull_request_review_id":101076711,"id":172115055,"diff_hunk":"@@ -158,7 +159,7 @@ public void onClick(DialogInterface dialogInterface, int i) {\n \n     private void checkPermissions(boolean fromOnActivityResult) {\n \n-        ArrayList<String> needPermissions = new ArrayList<>();\n+        List<String> needPermissions = new ArrayList<>();","path":"tedpermission/src/main/java/com/gun0912/tedpermission/TedPermissionActivity.java","position":13,"original_position":13,"commit_id":"6d7d0c59d21aa502076b22367d6e721abc704aa1","original_commit_id":"6d7d0c59d21aa502076b22367d6e721abc704aa1","user":{"login":"dotkebi","id":8197507,"avatar_url":"https://avatars1.githubusercontent.com/u/8197507?v=4","gravatar_id":"","url":"https://api.github.com/users/dotkebi","html_url":"https://github.com/dotkebi","followers_url":"https://api.github.com/users/dotkebi/followers","following_url":"https://api.github.com/users/dotkebi/following{/other_user}","gists_url":"https://api.github.com/users/dotkebi/gists{/gist_id}","starred_url":"https://api.github.com/users/dotkebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotkebi/subscriptions","organizations_url":"https://api.github.com/users/dotkebi/orgs","repos_url":"https://api.github.com/users/dotkebi/repos","events_url":"https://api.github.com/users/dotkebi/events{/privacy}","received_events_url":"https://api.github.com/users/dotkebi/received_events","type":"User","site_admin":false},"body":"@JSpiner \r\n\r\n* Why `List <String>`\r\nOnly use `add` method of` Collection`. There is no part that uses method implemented in ArrayList in particular.\r\n\r\nTherefore, it can only use `Collection` in your method implementation, but the requestPermissions signature has to be cast to` List <String> `, so if I limits it to a minimum condition, `List` is most appropriate.\r\n\r\n* Type casting problems,\r\nFirst, checkPermissions (boolean fromOnActivityResult) is hard to override because it is `private`.\r\nIt is a type to pass to the parameter of `requestPermissions`, so I think it is not necessary to consider it.","created_at":"2018-03-05T08:28:59Z","updated_at":"2018-03-05T08:29:00Z","html_url":"https://github.com/ParkSangGwon/TedPermission/pull/80#discussion_r172115055","pull_request_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/comments/172115055"},"html":{"href":"https://github.com/ParkSangGwon/TedPermission/pull/80#discussion_r172115055"},"pull_request":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80"}},"in_reply_to_id":171118453},"pull_request":{"url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80","id":170945309,"html_url":"https://github.com/ParkSangGwon/TedPermission/pull/80","diff_url":"https://github.com/ParkSangGwon/TedPermission/pull/80.diff","patch_url":"https://github.com/ParkSangGwon/TedPermission/pull/80.patch","issue_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues/80","number":80,"state":"open","locked":false,"title":"#75 ArrayList to List","user":{"login":"dotkebi","id":8197507,"avatar_url":"https://avatars1.githubusercontent.com/u/8197507?v=4","gravatar_id":"","url":"https://api.github.com/users/dotkebi","html_url":"https://github.com/dotkebi","followers_url":"https://api.github.com/users/dotkebi/followers","following_url":"https://api.github.com/users/dotkebi/following{/other_user}","gists_url":"https://api.github.com/users/dotkebi/gists{/gist_id}","starred_url":"https://api.github.com/users/dotkebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotkebi/subscriptions","organizations_url":"https://api.github.com/users/dotkebi/orgs","repos_url":"https://api.github.com/users/dotkebi/repos","events_url":"https://api.github.com/users/dotkebi/events{/privacy}","received_events_url":"https://api.github.com/users/dotkebi/received_events","type":"User","site_admin":false},"body":"PermissionList.onPermissionDenied(ArrayList<String>) 정의를 List<String>으로 수정","created_at":"2018-02-23T06:57:10Z","updated_at":"2018-03-05T08:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76f06f617328af9c97ad86ebc34cb8a74988c696","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80/commits","review_comments_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80/comments","review_comment_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues/80/comments","statuses_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/statuses/6d7d0c59d21aa502076b22367d6e721abc704aa1","head":{"label":"dotkebi:arraylistToList","ref":"arraylistToList","sha":"6d7d0c59d21aa502076b22367d6e721abc704aa1","user":{"login":"dotkebi","id":8197507,"avatar_url":"https://avatars1.githubusercontent.com/u/8197507?v=4","gravatar_id":"","url":"https://api.github.com/users/dotkebi","html_url":"https://github.com/dotkebi","followers_url":"https://api.github.com/users/dotkebi/followers","following_url":"https://api.github.com/users/dotkebi/following{/other_user}","gists_url":"https://api.github.com/users/dotkebi/gists{/gist_id}","starred_url":"https://api.github.com/users/dotkebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotkebi/subscriptions","organizations_url":"https://api.github.com/users/dotkebi/orgs","repos_url":"https://api.github.com/users/dotkebi/repos","events_url":"https://api.github.com/users/dotkebi/events{/privacy}","received_events_url":"https://api.github.com/users/dotkebi/received_events","type":"User","site_admin":false},"repo":{"id":122584090,"name":"TedPermission","full_name":"dotkebi/TedPermission","owner":{"login":"dotkebi","id":8197507,"avatar_url":"https://avatars1.githubusercontent.com/u/8197507?v=4","gravatar_id":"","url":"https://api.github.com/users/dotkebi","html_url":"https://github.com/dotkebi","followers_url":"https://api.github.com/users/dotkebi/followers","following_url":"https://api.github.com/users/dotkebi/following{/other_user}","gists_url":"https://api.github.com/users/dotkebi/gists{/gist_id}","starred_url":"https://api.github.com/users/dotkebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotkebi/subscriptions","organizations_url":"https://api.github.com/users/dotkebi/orgs","repos_url":"https://api.github.com/users/dotkebi/repos","events_url":"https://api.github.com/users/dotkebi/events{/privacy}","received_events_url":"https://api.github.com/users/dotkebi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotkebi/TedPermission","description":"Easy check permission library for Android Marshmallow","fork":true,"url":"https://api.github.com/repos/dotkebi/TedPermission","forks_url":"https://api.github.com/repos/dotkebi/TedPermission/forks","keys_url":"https://api.github.com/repos/dotkebi/TedPermission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotkebi/TedPermission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotkebi/TedPermission/teams","hooks_url":"https://api.github.com/repos/dotkebi/TedPermission/hooks","issue_events_url":"https://api.github.com/repos/dotkebi/TedPermission/issues/events{/number}","events_url":"https://api.github.com/repos/dotkebi/TedPermission/events","assignees_url":"https://api.github.com/repos/dotkebi/TedPermission/assignees{/user}","branches_url":"https://api.github.com/repos/dotkebi/TedPermission/branches{/branch}","tags_url":"https://api.github.com/repos/dotkebi/TedPermission/tags","blobs_url":"https://api.github.com/repos/dotkebi/TedPermission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotkebi/TedPermission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotkebi/TedPermission/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotkebi/TedPermission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotkebi/TedPermission/statuses/{sha}","languages_url":"https://api.github.com/repos/dotkebi/TedPermission/languages","stargazers_url":"https://api.github.com/repos/dotkebi/TedPermission/stargazers","contributors_url":"https://api.github.com/repos/dotkebi/TedPermission/contributors","subscribers_url":"https://api.github.com/repos/dotkebi/TedPermission/subscribers","subscription_url":"https://api.github.com/repos/dotkebi/TedPermission/subscription","commits_url":"https://api.github.com/repos/dotkebi/TedPermission/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotkebi/TedPermission/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotkebi/TedPermission/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotkebi/TedPermission/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotkebi/TedPermission/contents/{+path}","compare_url":"https://api.github.com/repos/dotkebi/TedPermission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotkebi/TedPermission/merges","archive_url":"https://api.github.com/repos/dotkebi/TedPermission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotkebi/TedPermission/downloads","issues_url":"https://api.github.com/repos/dotkebi/TedPermission/issues{/number}","pulls_url":"https://api.github.com/repos/dotkebi/TedPermission/pulls{/number}","milestones_url":"https://api.github.com/repos/dotkebi/TedPermission/milestones{/number}","notifications_url":"https://api.github.com/repos/dotkebi/TedPermission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotkebi/TedPermission/labels{/name}","releases_url":"https://api.github.com/repos/dotkebi/TedPermission/releases{/id}","deployments_url":"https://api.github.com/repos/dotkebi/TedPermission/deployments","created_at":"2018-02-23T06:50:02Z","updated_at":"2018-02-23T06:50:04Z","pushed_at":"2018-02-27T08:26:09Z","git_url":"git://github.com/dotkebi/TedPermission.git","ssh_url":"git@github.com:dotkebi/TedPermission.git","clone_url":"https://github.com/dotkebi/TedPermission.git","svn_url":"https://github.com/dotkebi/TedPermission","homepage":"","size":528,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParkSangGwon:master","ref":"master","sha":"3407be95a8a0ca14ce68129fc71a485ed61f1970","user":{"login":"ParkSangGwon","id":8275048,"avatar_url":"https://avatars1.githubusercontent.com/u/8275048?v=4","gravatar_id":"","url":"https://api.github.com/users/ParkSangGwon","html_url":"https://github.com/ParkSangGwon","followers_url":"https://api.github.com/users/ParkSangGwon/followers","following_url":"https://api.github.com/users/ParkSangGwon/following{/other_user}","gists_url":"https://api.github.com/users/ParkSangGwon/gists{/gist_id}","starred_url":"https://api.github.com/users/ParkSangGwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParkSangGwon/subscriptions","organizations_url":"https://api.github.com/users/ParkSangGwon/orgs","repos_url":"https://api.github.com/users/ParkSangGwon/repos","events_url":"https://api.github.com/users/ParkSangGwon/events{/privacy}","received_events_url":"https://api.github.com/users/ParkSangGwon/received_events","type":"User","site_admin":false},"repo":{"id":51969435,"name":"TedPermission","full_name":"ParkSangGwon/TedPermission","owner":{"login":"ParkSangGwon","id":8275048,"avatar_url":"https://avatars1.githubusercontent.com/u/8275048?v=4","gravatar_id":"","url":"https://api.github.com/users/ParkSangGwon","html_url":"https://github.com/ParkSangGwon","followers_url":"https://api.github.com/users/ParkSangGwon/followers","following_url":"https://api.github.com/users/ParkSangGwon/following{/other_user}","gists_url":"https://api.github.com/users/ParkSangGwon/gists{/gist_id}","starred_url":"https://api.github.com/users/ParkSangGwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParkSangGwon/subscriptions","organizations_url":"https://api.github.com/users/ParkSangGwon/orgs","repos_url":"https://api.github.com/users/ParkSangGwon/repos","events_url":"https://api.github.com/users/ParkSangGwon/events{/privacy}","received_events_url":"https://api.github.com/users/ParkSangGwon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ParkSangGwon/TedPermission","description":"Easy check permission library for Android Marshmallow","fork":false,"url":"https://api.github.com/repos/ParkSangGwon/TedPermission","forks_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/forks","keys_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/teams","hooks_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/hooks","issue_events_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues/events{/number}","events_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/events","assignees_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/assignees{/user}","branches_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/branches{/branch}","tags_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/tags","blobs_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/statuses/{sha}","languages_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/languages","stargazers_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/stargazers","contributors_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/contributors","subscribers_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/subscribers","subscription_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/subscription","commits_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/contents/{+path}","compare_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/merges","archive_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/downloads","issues_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues{/number}","pulls_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls{/number}","milestones_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/milestones{/number}","notifications_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/labels{/name}","releases_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/releases{/id}","deployments_url":"https://api.github.com/repos/ParkSangGwon/TedPermission/deployments","created_at":"2016-02-18T01:37:51Z","updated_at":"2018-03-04T18:24:47Z","pushed_at":"2018-03-04T22:47:43Z","git_url":"git://github.com/ParkSangGwon/TedPermission.git","ssh_url":"git@github.com:ParkSangGwon/TedPermission.git","clone_url":"https://github.com/ParkSangGwon/TedPermission.git","svn_url":"https://github.com/ParkSangGwon/TedPermission","homepage":"","size":530,"stargazers_count":898,"watchers_count":898,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":137,"open_issues":8,"watchers":898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80"},"html":{"href":"https://github.com/ParkSangGwon/TedPermission/pull/80"},"issue":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues/80"},"comments":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/ParkSangGwon/TedPermission/statuses/6d7d0c59d21aa502076b22367d6e721abc704aa1"}},"author_association":"NONE"}}
{"actor":{"display_login":"dotkebi"}}