{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/209574348","pull_request_review_id":145611176,"id":209574348,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTU3NDM0OA==","diff_hunk":"@@ -69,21 +69,27 @@ type byPlugSnapAndName []*snap.PlugInfo\n func (c byPlugSnapAndName) Len() int      { return len(c) }\n func (c byPlugSnapAndName) Swap(i, j int) { c[i], c[j] = c[j], c[i] }\n func (c byPlugSnapAndName) Less(i, j int) bool {\n-\tif c[i].Snap.InstanceName() != c[j].Snap.InstanceName() {\n-\t\treturn c[i].Snap.InstanceName() < c[j].Snap.InstanceName()\n+\tif c[i].Snap.SnapName() != c[j].Snap.SnapName() {\n+\t\treturn c[i].Snap.SnapName() < c[j].Snap.SnapName()\n \t}\n-\treturn c[i].Name < c[j].Name\n+\tif c[i].Name != c[j].Name {\n+\t\treturn c[i].Name < c[j].Name\n+\t}\n+\treturn c[i].Snap.InstanceKey < c[j].Snap.InstanceKey","path":"interfaces/sorting.go","position":13,"original_position":13,"commit_id":"65bace4e7a8e50ccb9b24b7a7fb416cb59381e30","original_commit_id":"4a120b9fc85dbc94c1c9639940ebbd65ca06f5fc","user":{"login":"bboozzoo","id":41870,"node_id":"MDQ6VXNlcjQxODcw","avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"body":"Now that I read it again I see it makes sense. `foo` & `foo_bar` are different snaps after all.","created_at":"2018-08-13T11:25:31Z","updated_at":"2018-08-13T11:25:31Z","html_url":"https://github.com/snapcore/snapd/pull/5614#discussion_r209574348","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/5614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/209574348"},"html":{"href":"https://github.com/snapcore/snapd/pull/5614#discussion_r209574348"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5614"}},"in_reply_to_id":209542018},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/5614","id":207234157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjM0MTU3","html_url":"https://github.com/snapcore/snapd/pull/5614","diff_url":"https://github.com/snapcore/snapd/pull/5614.diff","patch_url":"https://github.com/snapcore/snapd/pull/5614.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/5614","number":5614,"state":"open","locked":false,"title":"interfaces: parallel instances support, extend unit tests","user":{"login":"bboozzoo","id":41870,"node_id":"MDQ6VXNlcjQxODcw","avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"body":"Allow adding slots/plugs from snaps with instance keys. Extend unit tests to\r\ncover parallel instances of snaps.\r\n","created_at":"2018-08-09T08:12:11Z","updated_at":"2018-08-13T11:25:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27e5227194ce12d7141194fd59cd29ae1be25674","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1010194691,"node_id":"MDU6TGFiZWwxMDEwMTk0Njkx","url":"https://api.github.com/repos/snapcore/snapd/labels/Parallel%20installs","name":"Parallel installs","color":"40afd1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/5614/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/5614/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/5614/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/65bace4e7a8e50ccb9b24b7a7fb416cb59381e30","head":{"label":"bboozzoo:bboozzoo/parallel-install-ifaces-repo","ref":"bboozzoo/parallel-install-ifaces-repo","sha":"65bace4e7a8e50ccb9b24b7a7fb416cb59381e30","user":{"login":"bboozzoo","id":41870,"node_id":"MDQ6VXNlcjQxODcw","avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"repo":{"id":109232638,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMzI2Mzg=","name":"snapd","full_name":"bboozzoo/snapd","owner":{"login":"bboozzoo","id":41870,"node_id":"MDQ6VXNlcjQxODcw","avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboozzoo/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/bboozzoo/snapd","forks_url":"https://api.github.com/repos/bboozzoo/snapd/forks","keys_url":"https://api.github.com/repos/bboozzoo/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboozzoo/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboozzoo/snapd/teams","hooks_url":"https://api.github.com/repos/bboozzoo/snapd/hooks","issue_events_url":"https://api.github.com/repos/bboozzoo/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/bboozzoo/snapd/events","assignees_url":"https://api.github.com/repos/bboozzoo/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/bboozzoo/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/bboozzoo/snapd/tags","blobs_url":"https://api.github.com/repos/bboozzoo/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboozzoo/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboozzoo/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboozzoo/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboozzoo/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/bboozzoo/snapd/languages","stargazers_url":"https://api.github.com/repos/bboozzoo/snapd/stargazers","contributors_url":"https://api.github.com/repos/bboozzoo/snapd/contributors","subscribers_url":"https://api.github.com/repos/bboozzoo/snapd/subscribers","subscription_url":"https://api.github.com/repos/bboozzoo/snapd/subscription","commits_url":"https://api.github.com/repos/bboozzoo/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboozzoo/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboozzoo/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboozzoo/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboozzoo/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/bboozzoo/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboozzoo/snapd/merges","archive_url":"https://api.github.com/repos/bboozzoo/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboozzoo/snapd/downloads","issues_url":"https://api.github.com/repos/bboozzoo/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/bboozzoo/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/bboozzoo/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/bboozzoo/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboozzoo/snapd/labels{/name}","releases_url":"https://api.github.com/repos/bboozzoo/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/bboozzoo/snapd/deployments","created_at":"2017-11-02T07:37:26Z","updated_at":"2018-06-11T06:24:20Z","pushed_at":"2018-08-13T10:08:14Z","git_url":"git://github.com/bboozzoo/snapd.git","ssh_url":"git@github.com:bboozzoo/snapd.git","clone_url":"https://github.com/bboozzoo/snapd.git","svn_url":"https://github.com/bboozzoo/snapd","homepage":"","size":70043,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"2e32cf522c6cfd7de2f572dae74dc63d2ced3a42","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-08-13T08:41:35Z","pushed_at":"2018-08-13T11:18:02Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":69235,"stargazers_count":984,"watchers_count":984,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":244,"open_issues":45,"watchers":984,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5614"},"html":{"href":"https://github.com/snapcore/snapd/pull/5614"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/5614"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/5614/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5614/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5614/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/65bace4e7a8e50ccb9b24b7a7fb416cb59381e30"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bboozzoo"}}