{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/12135","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/12135/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/12135/comments","events_url":"https://api.github.com/repos/facebook/react/issues/12135/events","html_url":"https://github.com/facebook/react/pull/12135","id":293667882,"number":12135,"title":"Extend input type check in selection capabilities (#12062)","user":{"login":"spirosikmd","id":1057324,"avatar_url":"https://avatars3.githubusercontent.com/u/1057324?v=4","gravatar_id":"","url":"https://api.github.com/users/spirosikmd","html_url":"https://github.com/spirosikmd","followers_url":"https://api.github.com/users/spirosikmd/followers","following_url":"https://api.github.com/users/spirosikmd/following{/other_user}","gists_url":"https://api.github.com/users/spirosikmd/gists{/gist_id}","starred_url":"https://api.github.com/users/spirosikmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spirosikmd/subscriptions","organizations_url":"https://api.github.com/users/spirosikmd/orgs","repos_url":"https://api.github.com/users/spirosikmd/repos","events_url":"https://api.github.com/users/spirosikmd/events{/privacy}","received_events_url":"https://api.github.com/users/spirosikmd/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"state":"open","locked":false,"assignee":{"login":"aweary","id":6886061,"avatar_url":"https://avatars2.githubusercontent.com/u/6886061?v=4","gravatar_id":"","url":"https://api.github.com/users/aweary","html_url":"https://github.com/aweary","followers_url":"https://api.github.com/users/aweary/followers","following_url":"https://api.github.com/users/aweary/following{/other_user}","gists_url":"https://api.github.com/users/aweary/gists{/gist_id}","starred_url":"https://api.github.com/users/aweary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweary/subscriptions","organizations_url":"https://api.github.com/users/aweary/orgs","repos_url":"https://api.github.com/users/aweary/repos","events_url":"https://api.github.com/users/aweary/events{/privacy}","received_events_url":"https://api.github.com/users/aweary/received_events","type":"User","site_admin":false},"assignees":[{"login":"aweary","id":6886061,"avatar_url":"https://avatars2.githubusercontent.com/u/6886061?v=4","gravatar_id":"","url":"https://api.github.com/users/aweary","html_url":"https://github.com/aweary","followers_url":"https://api.github.com/users/aweary/followers","following_url":"https://api.github.com/users/aweary/following{/other_user}","gists_url":"https://api.github.com/users/aweary/gists{/gist_id}","starred_url":"https://api.github.com/users/aweary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweary/subscriptions","organizations_url":"https://api.github.com/users/aweary/orgs","repos_url":"https://api.github.com/users/aweary/repos","events_url":"https://api.github.com/users/aweary/events{/privacy}","received_events_url":"https://api.github.com/users/aweary/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-02-01T20:12:40Z","updated_at":"2018-02-15T20:34:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/12135","html_url":"https://github.com/facebook/react/pull/12135","diff_url":"https://github.com/facebook/react/pull/12135.diff","patch_url":"https://github.com/facebook/react/pull/12135.patch"},"body":"When an email input was replaced by a disabled text input on the same\r\nDOM position, an error would occur when trying to `setSelection`. The\r\nreason was that in `getSelectionInformation` the `selectionRange` was\r\nset to `null` as `hasSelectionCapabilities` was returning `false` for\r\nan `email` input type.\r\n\r\n`email` and `tel` input types do have selection capabilities, so in\r\nthat case, `hasSelectionCapabilities` should return `true`.\r\n\r\nFix #12062 "},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/366053258","html_url":"https://github.com/facebook/react/pull/12135#issuecomment-366053258","issue_url":"https://api.github.com/repos/facebook/react/issues/12135","id":366053258,"user":{"login":"spirosikmd","id":1057324,"avatar_url":"https://avatars3.githubusercontent.com/u/1057324?v=4","gravatar_id":"","url":"https://api.github.com/users/spirosikmd","html_url":"https://github.com/spirosikmd","followers_url":"https://api.github.com/users/spirosikmd/followers","following_url":"https://api.github.com/users/spirosikmd/following{/other_user}","gists_url":"https://api.github.com/users/spirosikmd/gists{/gist_id}","starred_url":"https://api.github.com/users/spirosikmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spirosikmd/subscriptions","organizations_url":"https://api.github.com/users/spirosikmd/orgs","repos_url":"https://api.github.com/users/spirosikmd/repos","events_url":"https://api.github.com/users/spirosikmd/events{/privacy}","received_events_url":"https://api.github.com/users/spirosikmd/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T20:34:54Z","updated_at":"2018-02-15T20:34:54Z","author_association":"NONE","body":"Hey @aweary! \r\n\r\nThank you for the tip! I added the `url` type as well. According to the HTML spec, `url` does have selection capabilities.\r\n\r\nRegarding the `scripts/rollup/results.json`. Should I revert my changes to avoid conflicts? Or is it a requirement for each PR to update this file?"}}
{"actor":{"display_login":"spirosikmd"}}