{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/200891361","pull_request_review_id":135288230,"id":200891361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDg5MTM2MQ==","diff_hunk":"@@ -259,31 +243,57 @@ int things_wifi_changed_call_func(int state, char *ap_name, char *ip_addr)\n \n static void *__attribute__((optimize(\"O0\"))) t_things_wifi_join_loop(void *args)\n {\n+\tbool* is_wifi_retry_connect = (bool*) args;\n+\n+\tif ((*is_wifi_retry_connect) == true) {\n+\t\tTHINGS_LOG_E(TAG, \"Retry to connect to home ap.\");\n+\t\tthings_network_connect_home_ap();\n+\t} else {\n #ifdef CONFIG_NETUTILS_NTPCLIENT\n-\tsync_time_from_ntp(10);\n+\t\tsync_time_from_ntp(10);\n #else\n-\tTHINGS_LOG_V(TAG, \"CONFIG_NETUTILS_NTPCLIENT is not set\");\n+\t\tTHINGS_LOG_V(TAG, \"CONFIG_NETUTILS_NTPCLIENT is not set\");\n #endif\n+\t\twifi_manager_info_s wifi_info;\n+\t\twifi_manager_get_info(&wifi_info);\n \n-\twifi_manager_info_s wifi_info;\n-\twifi_manager_get_info(&wifi_info);\n-\n-\tthings_wifi_changed_call_func(1, wifi_info.ssid, wifi_info.ip4_address);\n+\t\tthings_wifi_changed_call_func(1, wifi_info.ssid, wifi_info.ip4_address);\n+\t}\n \n \treturn NULL;\n }\n \n void things_wifi_sta_connected(wifi_manager_result_e res)\n {\n+\tbool is_wifi_retry_connect = false;\n+\n \tif (res == WIFI_MANAGER_FAIL) {\n \t\tTHINGS_LOG_E(TAG, \"Failed to connect to the AP\");\n-\t\treturn;\n+\n+\t\tif (!dm_is_es_complete()) {\n+\t\t\tg_retry_connect_cnt++;\n+\n+\t\t\tif (g_retry_connect_cnt <= MAX_WIFI_CONNECT_RETRY_COUNT) {\n+\t\t\t\tis_wifi_retry_connect = true;\n+\t\t\t\tTHINGS_LOG_V(TAG, \"(%d) Retry to connect ap during easy-setup.\", g_retry_connect_cnt);\n+\t\t\t} else {\n+\t\t\t\treturn;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tis_wifi_retry_connect = true;\n+\t\t\tTHINGS_LOG_V(TAG, \"Retry to connect ap during normal time.\");\n+\t\t}\n+\t} else {\n+\t\tis_wifi_retry_connect = false;","path":"framework/src/st_things/things_stack/utils/things_network.c","position":120,"original_position":120,"commit_id":"654484c7cc20c68a2ac4124050a0a80aeb0ebc39","original_commit_id":"654484c7cc20c68a2ac4124050a0a80aeb0ebc39","user":{"login":"Hyunjun85","id":36025642,"node_id":"MDQ6VXNlcjM2MDI1NjQy","avatar_url":"https://avatars1.githubusercontent.com/u/36025642?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyunjun85","html_url":"https://github.com/Hyunjun85","followers_url":"https://api.github.com/users/Hyunjun85/followers","following_url":"https://api.github.com/users/Hyunjun85/following{/other_user}","gists_url":"https://api.github.com/users/Hyunjun85/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyunjun85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyunjun85/subscriptions","organizations_url":"https://api.github.com/users/Hyunjun85/orgs","repos_url":"https://api.github.com/users/Hyunjun85/repos","events_url":"https://api.github.com/users/Hyunjun85/events{/privacy}","received_events_url":"https://api.github.com/users/Hyunjun85/received_events","type":"User","site_admin":false},"body":"dm_is_es_complete means the all steps of easy-setup was done.\r\nWhile running the easy-setup, the codes should retry only 3 times then has to return a fail because the mobile can receive about failured message.","created_at":"2018-07-09T06:30:36Z","updated_at":"2018-07-09T06:30:36Z","html_url":"https://github.com/Samsung/TizenRT/pull/1908#discussion_r200891361","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/200891361"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1908#discussion_r200891361"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908"}},"in_reply_to_id":200592373},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908","id":199657261,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjU3MjYx","html_url":"https://github.com/Samsung/TizenRT/pull/1908","diff_url":"https://github.com/Samsung/TizenRT/pull/1908.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/1908.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1908","number":1908,"state":"open","locked":false,"title":"framework/st_things] fix an bug which can not connect any AP after rebooted","user":{"login":"Hyunjun85","id":36025642,"node_id":"MDQ6VXNlcjM2MDI1NjQy","avatar_url":"https://avatars1.githubusercontent.com/u/36025642?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyunjun85","html_url":"https://github.com/Hyunjun85","followers_url":"https://api.github.com/users/Hyunjun85/followers","following_url":"https://api.github.com/users/Hyunjun85/following{/other_user}","gists_url":"https://api.github.com/users/Hyunjun85/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyunjun85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyunjun85/subscriptions","organizations_url":"https://api.github.com/users/Hyunjun85/orgs","repos_url":"https://api.github.com/users/Hyunjun85/repos","events_url":"https://api.github.com/users/Hyunjun85/events{/privacy}","received_events_url":"https://api.github.com/users/Hyunjun85/received_events","type":"User","site_admin":false},"body":"It has a bug which It returned an error when tried to connect removed WIFI after just booted and then does not try the auto reconnection.\r\n\r\nSo, through commit, things can try to connect ap until the AP discovered.","created_at":"2018-07-06T06:35:10Z","updated_at":"2018-07-09T06:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b09e10e8f5f9f17b4ae976657da9c9d4696005b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1908/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/654484c7cc20c68a2ac4124050a0a80aeb0ebc39","head":{"label":"Hyunjun85:reconnection","ref":"reconnection","sha":"654484c7cc20c68a2ac4124050a0a80aeb0ebc39","user":{"login":"Hyunjun85","id":36025642,"node_id":"MDQ6VXNlcjM2MDI1NjQy","avatar_url":"https://avatars1.githubusercontent.com/u/36025642?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyunjun85","html_url":"https://github.com/Hyunjun85","followers_url":"https://api.github.com/users/Hyunjun85/followers","following_url":"https://api.github.com/users/Hyunjun85/following{/other_user}","gists_url":"https://api.github.com/users/Hyunjun85/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyunjun85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyunjun85/subscriptions","organizations_url":"https://api.github.com/users/Hyunjun85/orgs","repos_url":"https://api.github.com/users/Hyunjun85/repos","events_url":"https://api.github.com/users/Hyunjun85/events{/privacy}","received_events_url":"https://api.github.com/users/Hyunjun85/received_events","type":"User","site_admin":false},"repo":{"id":120400758,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MDA3NTg=","name":"TizenRT","full_name":"Hyunjun85/TizenRT","owner":{"login":"Hyunjun85","id":36025642,"node_id":"MDQ6VXNlcjM2MDI1NjQy","avatar_url":"https://avatars1.githubusercontent.com/u/36025642?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyunjun85","html_url":"https://github.com/Hyunjun85","followers_url":"https://api.github.com/users/Hyunjun85/followers","following_url":"https://api.github.com/users/Hyunjun85/following{/other_user}","gists_url":"https://api.github.com/users/Hyunjun85/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyunjun85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyunjun85/subscriptions","organizations_url":"https://api.github.com/users/Hyunjun85/orgs","repos_url":"https://api.github.com/users/Hyunjun85/repos","events_url":"https://api.github.com/users/Hyunjun85/events{/privacy}","received_events_url":"https://api.github.com/users/Hyunjun85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hyunjun85/TizenRT","description":"Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/Hyunjun85/TizenRT","forks_url":"https://api.github.com/repos/Hyunjun85/TizenRT/forks","keys_url":"https://api.github.com/repos/Hyunjun85/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hyunjun85/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hyunjun85/TizenRT/teams","hooks_url":"https://api.github.com/repos/Hyunjun85/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Hyunjun85/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Hyunjun85/TizenRT/events","assignees_url":"https://api.github.com/repos/Hyunjun85/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Hyunjun85/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Hyunjun85/TizenRT/tags","blobs_url":"https://api.github.com/repos/Hyunjun85/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hyunjun85/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hyunjun85/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hyunjun85/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hyunjun85/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Hyunjun85/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Hyunjun85/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Hyunjun85/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Hyunjun85/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Hyunjun85/TizenRT/subscription","commits_url":"https://api.github.com/repos/Hyunjun85/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hyunjun85/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hyunjun85/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hyunjun85/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hyunjun85/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Hyunjun85/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hyunjun85/TizenRT/merges","archive_url":"https://api.github.com/repos/Hyunjun85/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hyunjun85/TizenRT/downloads","issues_url":"https://api.github.com/repos/Hyunjun85/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Hyunjun85/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Hyunjun85/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Hyunjun85/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hyunjun85/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Hyunjun85/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Hyunjun85/TizenRT/deployments","created_at":"2018-02-06T04:16:26Z","updated_at":"2018-07-06T01:54:56Z","pushed_at":"2018-07-06T06:46:50Z","git_url":"git://github.com/Hyunjun85/TizenRT.git","ssh_url":"git@github.com:Hyunjun85/TizenRT.git","clone_url":"https://github.com/Hyunjun85/TizenRT.git","svn_url":"https://github.com/Hyunjun85/TizenRT","homepage":"","size":100628,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"a8b3c3e4ce8e5c7943dccdaa8045f30d57f19b7d","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"node_id":"MDEwOlJlcG9zaXRvcnk4MjUxNzI1Mg==","name":"TizenRT","full_name":"Samsung/TizenRT","owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2018-07-09T05:29:20Z","pushed_at":"2018-07-09T06:18:08Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":100506,"stargazers_count":182,"watchers_count":182,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":215,"open_issues":42,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1908"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1908"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1908/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1908/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/654484c7cc20c68a2ac4124050a0a80aeb0ebc39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Hyunjun85"}}