{"action":"created","comment":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/238796873","pull_request_review_id":181427657,"id":238796873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODc5Njg3Mw==","diff_hunk":"@@ -0,0 +1,18 @@\n+import typescript from \"rollup-plugin-typescript2\";","path":"packages/common-types/rollup.config.js","position":1,"original_position":1,"commit_id":"f06ee6fca19dea0e6208e21b051989bf74e7526e","original_commit_id":"f06ee6fca19dea0e6208e21b051989bf74e7526e","user":{"login":"mvanderh","id":8631205,"node_id":"MDQ6VXNlcjg2MzEyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8631205?v=4","gravatar_id":"","url":"https://api.github.com/users/mvanderh","html_url":"https://github.com/mvanderh","followers_url":"https://api.github.com/users/mvanderh/followers","following_url":"https://api.github.com/users/mvanderh/following{/other_user}","gists_url":"https://api.github.com/users/mvanderh/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanderh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanderh/subscriptions","organizations_url":"https://api.github.com/users/mvanderh/orgs","repos_url":"https://api.github.com/users/mvanderh/repos","events_url":"https://api.github.com/users/mvanderh/events{/privacy}","received_events_url":"https://api.github.com/users/mvanderh/received_events","type":"User","site_admin":false},"body":"Specifically the jest module resolver breaks.\r\n\r\nAlso we need it regardless because common-types has to expose enum values\r\n","created_at":"2018-12-04T19:05:17Z","updated_at":"2018-12-04T19:05:18Z","html_url":"https://github.com/counterfactual/monorepo/pull/311#discussion_r238796873","pull_request_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/238796873"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/311#discussion_r238796873"},"pull_request":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/311"}},"in_reply_to_id":238791542},"pull_request":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/311","id":235881820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1ODgxODIw","html_url":"https://github.com/counterfactual/monorepo/pull/311","diff_url":"https://github.com/counterfactual/monorepo/pull/311.diff","patch_url":"https://github.com/counterfactual/monorepo/pull/311.patch","issue_url":"https://api.github.com/repos/counterfactual/monorepo/issues/311","number":311,"state":"open","locked":false,"title":"[common-types] Move common types to their own package","user":{"login":"mvanderh","id":8631205,"node_id":"MDQ6VXNlcjg2MzEyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8631205?v=4","gravatar_id":"","url":"https://api.github.com/users/mvanderh","html_url":"https://github.com/mvanderh","followers_url":"https://api.github.com/users/mvanderh/followers","following_url":"https://api.github.com/users/mvanderh/following{/other_user}","gists_url":"https://api.github.com/users/mvanderh/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanderh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanderh/subscriptions","organizations_url":"https://api.github.com/users/mvanderh/orgs","repos_url":"https://api.github.com/users/mvanderh/repos","events_url":"https://api.github.com/users/mvanderh/events{/privacy}","received_events_url":"https://api.github.com/users/mvanderh/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nSome types are used by multiple Counterfactual packages:\r\n- Node Protocol messages\r\n- Data Types (AppInstanceInfo etc)\r\n- Simple type aliases such as Address, Bytes32\r\n\r\nThese types are moved to a new package called common-types.\r\n\r\n**Question**: Are there other common types that should be moved?","created_at":"2018-12-04T16:48:32Z","updated_at":"2018-12-04T19:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a0407874a609736e31fb23570ede9378c93cb8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"snario","id":1933029,"node_id":"MDQ6VXNlcjE5MzMwMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1933029?v=4","gravatar_id":"","url":"https://api.github.com/users/snario","html_url":"https://github.com/snario","followers_url":"https://api.github.com/users/snario/followers","following_url":"https://api.github.com/users/snario/following{/other_user}","gists_url":"https://api.github.com/users/snario/gists{/gist_id}","starred_url":"https://api.github.com/users/snario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snario/subscriptions","organizations_url":"https://api.github.com/users/snario/orgs","repos_url":"https://api.github.com/users/snario/repos","events_url":"https://api.github.com/users/snario/events{/privacy}","received_events_url":"https://api.github.com/users/snario/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/311/commits","review_comments_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/311/comments","review_comment_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/issues/311/comments","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/f06ee6fca19dea0e6208e21b051989bf74e7526e","head":{"label":"counterfactual:mitch/move-common-types","ref":"mitch/move-common-types","sha":"f06ee6fca19dea0e6208e21b051989bf74e7526e","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2018-12-04T15:32:26Z","pushed_at":"2018-12-04T19:04:03Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":5210,"stargazers_count":122,"watchers_count":122,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":26,"watchers":122,"default_branch":"master"}},"base":{"label":"counterfactual:master","ref":"master","sha":"675c617f8435d6c53ea2b7152821f2076f5bc615","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2018-12-04T15:32:26Z","pushed_at":"2018-12-04T19:04:03Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":5210,"stargazers_count":122,"watchers_count":122,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":26,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/311"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/311"},"issue":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/311"},"comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/counterfactual/monorepo/statuses/f06ee6fca19dea0e6208e21b051989bf74e7526e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mvanderh"}}