{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1586","repository_url":"https://api.github.com/repos/Yoast/YoastSEO.js","labels_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1586/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1586/comments","events_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1586/events","html_url":"https://github.com/Yoast/YoastSEO.js/pull/1586","id":339360969,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDMyMzE2","number":1586,"title":"Fix apostrophes in word boundaries","user":{"login":"igorschoester","id":35524806,"node_id":"MDQ6VXNlcjM1NTI0ODA2","avatar_url":"https://avatars1.githubusercontent.com/u/35524806?v=4","gravatar_id":"","url":"https://api.github.com/users/igorschoester","html_url":"https://github.com/igorschoester","followers_url":"https://api.github.com/users/igorschoester/followers","following_url":"https://api.github.com/users/igorschoester/following{/other_user}","gists_url":"https://api.github.com/users/igorschoester/gists{/gist_id}","starred_url":"https://api.github.com/users/igorschoester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorschoester/subscriptions","organizations_url":"https://api.github.com/users/igorschoester/orgs","repos_url":"https://api.github.com/users/igorschoester/repos","events_url":"https://api.github.com/users/igorschoester/events{/privacy}","received_events_url":"https://api.github.com/users/igorschoester/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-09T08:55:57Z","updated_at":"2018-07-10T12:34:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1586","html_url":"https://github.com/Yoast/YoastSEO.js/pull/1586","diff_url":"https://github.com/Yoast/YoastSEO.js/pull/1586.diff","patch_url":"https://github.com/Yoast/YoastSEO.js/pull/1586.patch"},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Fixes a bug that caused keywords to be incorrectly recognized within possessive forms (e.g. `Natalia` in `Natalia's fix`.\r\n\r\n## Relevant technical choices:\r\n\r\n* Adjusted `matchTextWithArray` to use `matchTextToWord`.\r\n* Match single quotes only when it is on the edge of a word boundary. This is to not count possessives like: `Natalia's fix`.\r\n\r\n## Not fixed in this PR\r\n\r\nThe original text is changed. Then the matches are being found. However the index AND the actual match are not lining up with the original text at all. The markings are done by searching for the original text and replacing it. But the original text is not the original text!\r\nIn `stringProcessing/matchTextWithWord.js` you can see an place where the original text is changed before the matches are run.\r\n\r\n## Test instructions\r\n\r\nThis PR can be tested by following these steps:\r\n\r\n* Add a text with at least 200 words and set the focus keyword to `Natalia`. Add `Natalia's` in the text. No keyword occurrence should be found."},"comment":{"url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/comments/403805875","html_url":"https://github.com/Yoast/YoastSEO.js/pull/1586#issuecomment-403805875","issue_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1586","id":403805875,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzgwNTg3NQ==","user":{"login":"manuelaugustin","id":27805437,"node_id":"MDQ6VXNlcjI3ODA1NDM3","avatar_url":"https://avatars1.githubusercontent.com/u/27805437?v=4","gravatar_id":"","url":"https://api.github.com/users/manuelaugustin","html_url":"https://github.com/manuelaugustin","followers_url":"https://api.github.com/users/manuelaugustin/followers","following_url":"https://api.github.com/users/manuelaugustin/following{/other_user}","gists_url":"https://api.github.com/users/manuelaugustin/gists{/gist_id}","starred_url":"https://api.github.com/users/manuelaugustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuelaugustin/subscriptions","organizations_url":"https://api.github.com/users/manuelaugustin/orgs","repos_url":"https://api.github.com/users/manuelaugustin/repos","events_url":"https://api.github.com/users/manuelaugustin/events{/privacy}","received_events_url":"https://api.github.com/users/manuelaugustin/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T12:34:33Z","updated_at":"2018-07-10T12:34:33Z","author_association":"CONTRIBUTOR","body":"CR & acceptance test done 👍"}}
{"actor":{"display_login":"manuelaugustin"}}