{"action":"created","comment":{"url":"https://api.github.com/repos/magda-io/magda/pulls/comments/228786285","pull_request_review_id":169133847,"id":228786285,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc4NjI4NQ==","diff_hunk":"@@ -50,6 +50,80 @@ export const headerNavigation: any = {\n     required: [\"order\"]\n };\n \n+export const footerCategoryItem: any = {\n+    type: \"object\",\n+    properties: {\n+        order: {\n+            type: \"number\",\n+            default: 1\n+        },\n+        label: {\n+            type: \"string\",\n+            minLength: 1\n+        },\n+        links: {\n+            type: \"array\",\n+            items: {\n+                type: \"array\",\n+                minItems: 2,","path":"magda-content-api/src/schemas.ts","position":19,"original_position":19,"commit_id":"e5cd926e1ce7603949ffbd2eaefaad231c3660b7","original_commit_id":"e5cd926e1ce7603949ffbd2eaefaad231c3660b7","user":{"login":"nahidakbar","id":3362993,"node_id":"MDQ6VXNlcjMzNjI5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3362993?v=4","gravatar_id":"","url":"https://api.github.com/users/nahidakbar","html_url":"https://github.com/nahidakbar","followers_url":"https://api.github.com/users/nahidakbar/followers","following_url":"https://api.github.com/users/nahidakbar/following{/other_user}","gists_url":"https://api.github.com/users/nahidakbar/gists{/gist_id}","starred_url":"https://api.github.com/users/nahidakbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nahidakbar/subscriptions","organizations_url":"https://api.github.com/users/nahidakbar/orgs","repos_url":"https://api.github.com/users/nahidakbar/repos","events_url":"https://api.github.com/users/nahidakbar/events{/privacy}","received_events_url":"https://api.github.com/users/nahidakbar/received_events","type":"User","site_admin":false},"body":"Why this length limit range?","created_at":"2018-10-29T03:05:00Z","updated_at":"2018-10-29T03:05:01Z","html_url":"https://github.com/magda-io/magda/pull/1809#discussion_r228786285","pull_request_url":"https://api.github.com/repos/magda-io/magda/pulls/1809","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/magda-io/magda/pulls/comments/228786285"},"html":{"href":"https://github.com/magda-io/magda/pull/1809#discussion_r228786285"},"pull_request":{"href":"https://api.github.com/repos/magda-io/magda/pulls/1809"}}},"pull_request":{"url":"https://api.github.com/repos/magda-io/magda/pulls/1809","id":225922871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTIyODcx","html_url":"https://github.com/magda-io/magda/pull/1809","diff_url":"https://github.com/magda-io/magda/pull/1809.diff","patch_url":"https://github.com/magda-io/magda/pull/1809.patch","issue_url":"https://api.github.com/repos/magda-io/magda/issues/1809","number":1809,"state":"open","locked":false,"title":"Issue/1756 Make footer configurable","user":{"login":"t83714","id":674387,"node_id":"MDQ6VXNlcjY3NDM4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/674387?v=4","gravatar_id":"","url":"https://api.github.com/users/t83714","html_url":"https://github.com/t83714","followers_url":"https://api.github.com/users/t83714/followers","following_url":"https://api.github.com/users/t83714/following{/other_user}","gists_url":"https://api.github.com/users/t83714/gists{/gist_id}","starred_url":"https://api.github.com/users/t83714/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t83714/subscriptions","organizations_url":"https://api.github.com/users/t83714/orgs","repos_url":"https://api.github.com/users/t83714/repos","events_url":"https://api.github.com/users/t83714/events{/privacy}","received_events_url":"https://api.github.com/users/t83714/received_events","type":"User","site_admin":false},"body":"### What this PR does\r\n\r\nFixes #1756 \r\n\r\nChanges:\r\n- this PR merged https://github.com/magda-io/magda/pull/1804 as it includes the latest changes for content API\r\n- Move fetch content to `AppContainer` in order to cover footer as well\r\n- fixed: error every child should have a key in `HeaderNav`\r\n- Configurable footer related changes\r\n\r\nTest site available at:\r\n\r\nhttps://issue-1756.dev.magda.io/\r\n\r\nTo test DTA config, please remove any content with id starts with `footer/`. And then use dta upgrade SQL to import DTA config (Relevant PR: https://github.com/magda-io/magda-config-data.gov.au/pull/11).\r\n\r\n### Checklist\r\n\r\n-   [x] unit tests aren't applicable\r\n-   [x] I've updated CHANGES.md with what I changed.\r\n-   [x] I've linked this PR to an issue in ZenHub (core dev team only)\r\n-   [ ] I've assigned this PR to someone (if you don't know who to assign it to, pick @AlexGilleran)\r\n","created_at":"2018-10-25T22:22:33Z","updated_at":"2018-10-29T03:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15952a5024aec520c6874e730a5963ddc3fad603","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magda-io/magda/pulls/1809/commits","review_comments_url":"https://api.github.com/repos/magda-io/magda/pulls/1809/comments","review_comment_url":"https://api.github.com/repos/magda-io/magda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magda-io/magda/issues/1809/comments","statuses_url":"https://api.github.com/repos/magda-io/magda/statuses/e5cd926e1ce7603949ffbd2eaefaad231c3660b7","head":{"label":"magda-io:issue/1756","ref":"issue/1756","sha":"e5cd926e1ce7603949ffbd2eaefaad231c3660b7","user":{"login":"magda-io","id":40348684,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzQ4Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/40348684?v=4","gravatar_id":"","url":"https://api.github.com/users/magda-io","html_url":"https://github.com/magda-io","followers_url":"https://api.github.com/users/magda-io/followers","following_url":"https://api.github.com/users/magda-io/following{/other_user}","gists_url":"https://api.github.com/users/magda-io/gists{/gist_id}","starred_url":"https://api.github.com/users/magda-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magda-io/subscriptions","organizations_url":"https://api.github.com/users/magda-io/orgs","repos_url":"https://api.github.com/users/magda-io/repos","events_url":"https://api.github.com/users/magda-io/events{/privacy}","received_events_url":"https://api.github.com/users/magda-io/received_events","type":"Organization","site_admin":false},"repo":{"id":66343967,"node_id":"MDEwOlJlcG9zaXRvcnk2NjM0Mzk2Nw==","name":"magda","full_name":"magda-io/magda","private":false,"owner":{"login":"magda-io","id":40348684,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzQ4Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/40348684?v=4","gravatar_id":"","url":"https://api.github.com/users/magda-io","html_url":"https://github.com/magda-io","followers_url":"https://api.github.com/users/magda-io/followers","following_url":"https://api.github.com/users/magda-io/following{/other_user}","gists_url":"https://api.github.com/users/magda-io/gists{/gist_id}","starred_url":"https://api.github.com/users/magda-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magda-io/subscriptions","organizations_url":"https://api.github.com/users/magda-io/orgs","repos_url":"https://api.github.com/users/magda-io/repos","events_url":"https://api.github.com/users/magda-io/events{/privacy}","received_events_url":"https://api.github.com/users/magda-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magda-io/magda","description":"Easily discover government data","fork":false,"url":"https://api.github.com/repos/magda-io/magda","forks_url":"https://api.github.com/repos/magda-io/magda/forks","keys_url":"https://api.github.com/repos/magda-io/magda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magda-io/magda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magda-io/magda/teams","hooks_url":"https://api.github.com/repos/magda-io/magda/hooks","issue_events_url":"https://api.github.com/repos/magda-io/magda/issues/events{/number}","events_url":"https://api.github.com/repos/magda-io/magda/events","assignees_url":"https://api.github.com/repos/magda-io/magda/assignees{/user}","branches_url":"https://api.github.com/repos/magda-io/magda/branches{/branch}","tags_url":"https://api.github.com/repos/magda-io/magda/tags","blobs_url":"https://api.github.com/repos/magda-io/magda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magda-io/magda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magda-io/magda/git/refs{/sha}","trees_url":"https://api.github.com/repos/magda-io/magda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magda-io/magda/statuses/{sha}","languages_url":"https://api.github.com/repos/magda-io/magda/languages","stargazers_url":"https://api.github.com/repos/magda-io/magda/stargazers","contributors_url":"https://api.github.com/repos/magda-io/magda/contributors","subscribers_url":"https://api.github.com/repos/magda-io/magda/subscribers","subscription_url":"https://api.github.com/repos/magda-io/magda/subscription","commits_url":"https://api.github.com/repos/magda-io/magda/commits{/sha}","git_commits_url":"https://api.github.com/repos/magda-io/magda/git/commits{/sha}","comments_url":"https://api.github.com/repos/magda-io/magda/comments{/number}","issue_comment_url":"https://api.github.com/repos/magda-io/magda/issues/comments{/number}","contents_url":"https://api.github.com/repos/magda-io/magda/contents/{+path}","compare_url":"https://api.github.com/repos/magda-io/magda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magda-io/magda/merges","archive_url":"https://api.github.com/repos/magda-io/magda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magda-io/magda/downloads","issues_url":"https://api.github.com/repos/magda-io/magda/issues{/number}","pulls_url":"https://api.github.com/repos/magda-io/magda/pulls{/number}","milestones_url":"https://api.github.com/repos/magda-io/magda/milestones{/number}","notifications_url":"https://api.github.com/repos/magda-io/magda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magda-io/magda/labels{/name}","releases_url":"https://api.github.com/repos/magda-io/magda/releases{/id}","deployments_url":"https://api.github.com/repos/magda-io/magda/deployments","created_at":"2016-08-23T07:27:25Z","updated_at":"2018-10-28T23:18:27Z","pushed_at":"2018-10-29T01:10:59Z","git_url":"git://github.com/magda-io/magda.git","ssh_url":"git@github.com:magda-io/magda.git","clone_url":"https://github.com/magda-io/magda.git","svn_url":"https://github.com/magda-io/magda","homepage":"https://magda.io","size":180201,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":173,"watchers":51,"default_branch":"master"}},"base":{"label":"magda-io:master","ref":"master","sha":"3e43dbffd26224d977e3b893bffad248faf4f39f","user":{"login":"magda-io","id":40348684,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzQ4Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/40348684?v=4","gravatar_id":"","url":"https://api.github.com/users/magda-io","html_url":"https://github.com/magda-io","followers_url":"https://api.github.com/users/magda-io/followers","following_url":"https://api.github.com/users/magda-io/following{/other_user}","gists_url":"https://api.github.com/users/magda-io/gists{/gist_id}","starred_url":"https://api.github.com/users/magda-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magda-io/subscriptions","organizations_url":"https://api.github.com/users/magda-io/orgs","repos_url":"https://api.github.com/users/magda-io/repos","events_url":"https://api.github.com/users/magda-io/events{/privacy}","received_events_url":"https://api.github.com/users/magda-io/received_events","type":"Organization","site_admin":false},"repo":{"id":66343967,"node_id":"MDEwOlJlcG9zaXRvcnk2NjM0Mzk2Nw==","name":"magda","full_name":"magda-io/magda","private":false,"owner":{"login":"magda-io","id":40348684,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzQ4Njg0","avatar_url":"https://avatars2.githubusercontent.com/u/40348684?v=4","gravatar_id":"","url":"https://api.github.com/users/magda-io","html_url":"https://github.com/magda-io","followers_url":"https://api.github.com/users/magda-io/followers","following_url":"https://api.github.com/users/magda-io/following{/other_user}","gists_url":"https://api.github.com/users/magda-io/gists{/gist_id}","starred_url":"https://api.github.com/users/magda-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magda-io/subscriptions","organizations_url":"https://api.github.com/users/magda-io/orgs","repos_url":"https://api.github.com/users/magda-io/repos","events_url":"https://api.github.com/users/magda-io/events{/privacy}","received_events_url":"https://api.github.com/users/magda-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magda-io/magda","description":"Easily discover government data","fork":false,"url":"https://api.github.com/repos/magda-io/magda","forks_url":"https://api.github.com/repos/magda-io/magda/forks","keys_url":"https://api.github.com/repos/magda-io/magda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magda-io/magda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magda-io/magda/teams","hooks_url":"https://api.github.com/repos/magda-io/magda/hooks","issue_events_url":"https://api.github.com/repos/magda-io/magda/issues/events{/number}","events_url":"https://api.github.com/repos/magda-io/magda/events","assignees_url":"https://api.github.com/repos/magda-io/magda/assignees{/user}","branches_url":"https://api.github.com/repos/magda-io/magda/branches{/branch}","tags_url":"https://api.github.com/repos/magda-io/magda/tags","blobs_url":"https://api.github.com/repos/magda-io/magda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magda-io/magda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magda-io/magda/git/refs{/sha}","trees_url":"https://api.github.com/repos/magda-io/magda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magda-io/magda/statuses/{sha}","languages_url":"https://api.github.com/repos/magda-io/magda/languages","stargazers_url":"https://api.github.com/repos/magda-io/magda/stargazers","contributors_url":"https://api.github.com/repos/magda-io/magda/contributors","subscribers_url":"https://api.github.com/repos/magda-io/magda/subscribers","subscription_url":"https://api.github.com/repos/magda-io/magda/subscription","commits_url":"https://api.github.com/repos/magda-io/magda/commits{/sha}","git_commits_url":"https://api.github.com/repos/magda-io/magda/git/commits{/sha}","comments_url":"https://api.github.com/repos/magda-io/magda/comments{/number}","issue_comment_url":"https://api.github.com/repos/magda-io/magda/issues/comments{/number}","contents_url":"https://api.github.com/repos/magda-io/magda/contents/{+path}","compare_url":"https://api.github.com/repos/magda-io/magda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magda-io/magda/merges","archive_url":"https://api.github.com/repos/magda-io/magda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magda-io/magda/downloads","issues_url":"https://api.github.com/repos/magda-io/magda/issues{/number}","pulls_url":"https://api.github.com/repos/magda-io/magda/pulls{/number}","milestones_url":"https://api.github.com/repos/magda-io/magda/milestones{/number}","notifications_url":"https://api.github.com/repos/magda-io/magda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magda-io/magda/labels{/name}","releases_url":"https://api.github.com/repos/magda-io/magda/releases{/id}","deployments_url":"https://api.github.com/repos/magda-io/magda/deployments","created_at":"2016-08-23T07:27:25Z","updated_at":"2018-10-28T23:18:27Z","pushed_at":"2018-10-29T01:10:59Z","git_url":"git://github.com/magda-io/magda.git","ssh_url":"git@github.com:magda-io/magda.git","clone_url":"https://github.com/magda-io/magda.git","svn_url":"https://github.com/magda-io/magda","homepage":"https://magda.io","size":180201,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":173,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magda-io/magda/pulls/1809"},"html":{"href":"https://github.com/magda-io/magda/pull/1809"},"issue":{"href":"https://api.github.com/repos/magda-io/magda/issues/1809"},"comments":{"href":"https://api.github.com/repos/magda-io/magda/issues/1809/comments"},"review_comments":{"href":"https://api.github.com/repos/magda-io/magda/pulls/1809/comments"},"review_comment":{"href":"https://api.github.com/repos/magda-io/magda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magda-io/magda/pulls/1809/commits"},"statuses":{"href":"https://api.github.com/repos/magda-io/magda/statuses/e5cd926e1ce7603949ffbd2eaefaad231c3660b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nahidakbar"}}