{"action":"created","comment":{"url":"https://api.github.com/repos/turbinelabs/rotor/pulls/comments/212696951","pull_request_review_id":149388497,"id":212696951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY5Njk1MQ==","diff_hunk":"@@ -226,7 +226,7 @@ func mkEnvoyVirtualHost(\n \t\tcorsPolicy = mkEnvoyCorsPolicy(cleanDomainConfig.Domain.CorsConfig)\n \t}\n \n-\tdomains := []string{cleanDomainConfig.Domain.Name}\n+\tdomains := []string{cleanDomainConfig.Domain.Addr()}","path":"xds/adapter/rds.go","position":5,"original_position":5,"commit_id":"4581717dd5964ac15e8a78009612518a4ef1eaef","original_commit_id":"4581717dd5964ac15e8a78009612518a4ef1eaef","user":{"login":"9len","id":362808,"node_id":"MDQ6VXNlcjM2MjgwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/362808?v=4","gravatar_id":"","url":"https://api.github.com/users/9len","html_url":"https://github.com/9len","followers_url":"https://api.github.com/users/9len/followers","following_url":"https://api.github.com/users/9len/following{/other_user}","gists_url":"https://api.github.com/users/9len/gists{/gist_id}","starred_url":"https://api.github.com/users/9len/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9len/subscriptions","organizations_url":"https://api.github.com/users/9len/orgs","repos_url":"https://api.github.com/users/9len/repos","events_url":"https://api.github.com/users/9len/events{/privacy}","received_events_url":"https://api.github.com/users/9len/received_events","type":"User","site_admin":false},"body":"Can you talk about why you made this change, and what problem you're fixing? it's not clear from your review description.","created_at":"2018-08-24T17:19:56Z","updated_at":"2018-08-24T17:27:48Z","html_url":"https://github.com/turbinelabs/rotor/pull/25#discussion_r212696951","pull_request_url":"https://api.github.com/repos/turbinelabs/rotor/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/turbinelabs/rotor/pulls/comments/212696951"},"html":{"href":"https://github.com/turbinelabs/rotor/pull/25#discussion_r212696951"},"pull_request":{"href":"https://api.github.com/repos/turbinelabs/rotor/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/turbinelabs/rotor/pulls/25","id":210765552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzY1NTUy","html_url":"https://github.com/turbinelabs/rotor/pull/25","diff_url":"https://github.com/turbinelabs/rotor/pull/25.diff","patch_url":"https://github.com/turbinelabs/rotor/pull/25.patch","issue_url":"https://api.github.com/repos/turbinelabs/rotor/issues/25","number":25,"state":"open","locked":false,"title":" add support for custom `url` tag from Consul","user":{"login":"phedoreanu","id":1611001,"node_id":"MDQ6VXNlcjE2MTEwMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1611001?v=4","gravatar_id":"","url":"https://api.github.com/users/phedoreanu","html_url":"https://github.com/phedoreanu","followers_url":"https://api.github.com/users/phedoreanu/followers","following_url":"https://api.github.com/users/phedoreanu/following{/other_user}","gists_url":"https://api.github.com/users/phedoreanu/gists{/gist_id}","starred_url":"https://api.github.com/users/phedoreanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phedoreanu/subscriptions","organizations_url":"https://api.github.com/users/phedoreanu/orgs","repos_url":"https://api.github.com/users/phedoreanu/repos","events_url":"https://api.github.com/users/phedoreanu/events{/privacy}","received_events_url":"https://api.github.com/users/phedoreanu/received_events","type":"User","site_admin":false},"body":"This PR opens up a way to have customisable public facing URLs for `envoy` to listen on.","created_at":"2018-08-24T14:57:42Z","updated_at":"2018-08-24T17:27:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5ce3d5a1523dee0a2c9af3f1db8ad876c9c10dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/turbinelabs/rotor/pulls/25/commits","review_comments_url":"https://api.github.com/repos/turbinelabs/rotor/pulls/25/comments","review_comment_url":"https://api.github.com/repos/turbinelabs/rotor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/turbinelabs/rotor/issues/25/comments","statuses_url":"https://api.github.com/repos/turbinelabs/rotor/statuses/4581717dd5964ac15e8a78009612518a4ef1eaef","head":{"label":"spoud:master","ref":"master","sha":"4581717dd5964ac15e8a78009612518a4ef1eaef","user":{"login":"spoud","id":38279969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Mjc5OTY5","avatar_url":"https://avatars1.githubusercontent.com/u/38279969?v=4","gravatar_id":"","url":"https://api.github.com/users/spoud","html_url":"https://github.com/spoud","followers_url":"https://api.github.com/users/spoud/followers","following_url":"https://api.github.com/users/spoud/following{/other_user}","gists_url":"https://api.github.com/users/spoud/gists{/gist_id}","starred_url":"https://api.github.com/users/spoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spoud/subscriptions","organizations_url":"https://api.github.com/users/spoud/orgs","repos_url":"https://api.github.com/users/spoud/repos","events_url":"https://api.github.com/users/spoud/events{/privacy}","received_events_url":"https://api.github.com/users/spoud/received_events","type":"Organization","site_admin":false},"repo":{"id":145785068,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3ODUwNjg=","name":"rotor","full_name":"spoud/rotor","owner":{"login":"spoud","id":38279969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Mjc5OTY5","avatar_url":"https://avatars1.githubusercontent.com/u/38279969?v=4","gravatar_id":"","url":"https://api.github.com/users/spoud","html_url":"https://github.com/spoud","followers_url":"https://api.github.com/users/spoud/followers","following_url":"https://api.github.com/users/spoud/following{/other_user}","gists_url":"https://api.github.com/users/spoud/gists{/gist_id}","starred_url":"https://api.github.com/users/spoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spoud/subscriptions","organizations_url":"https://api.github.com/users/spoud/orgs","repos_url":"https://api.github.com/users/spoud/repos","events_url":"https://api.github.com/users/spoud/events{/privacy}","received_events_url":"https://api.github.com/users/spoud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spoud/rotor","description":null,"fork":true,"url":"https://api.github.com/repos/spoud/rotor","forks_url":"https://api.github.com/repos/spoud/rotor/forks","keys_url":"https://api.github.com/repos/spoud/rotor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spoud/rotor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spoud/rotor/teams","hooks_url":"https://api.github.com/repos/spoud/rotor/hooks","issue_events_url":"https://api.github.com/repos/spoud/rotor/issues/events{/number}","events_url":"https://api.github.com/repos/spoud/rotor/events","assignees_url":"https://api.github.com/repos/spoud/rotor/assignees{/user}","branches_url":"https://api.github.com/repos/spoud/rotor/branches{/branch}","tags_url":"https://api.github.com/repos/spoud/rotor/tags","blobs_url":"https://api.github.com/repos/spoud/rotor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spoud/rotor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spoud/rotor/git/refs{/sha}","trees_url":"https://api.github.com/repos/spoud/rotor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spoud/rotor/statuses/{sha}","languages_url":"https://api.github.com/repos/spoud/rotor/languages","stargazers_url":"https://api.github.com/repos/spoud/rotor/stargazers","contributors_url":"https://api.github.com/repos/spoud/rotor/contributors","subscribers_url":"https://api.github.com/repos/spoud/rotor/subscribers","subscription_url":"https://api.github.com/repos/spoud/rotor/subscription","commits_url":"https://api.github.com/repos/spoud/rotor/commits{/sha}","git_commits_url":"https://api.github.com/repos/spoud/rotor/git/commits{/sha}","comments_url":"https://api.github.com/repos/spoud/rotor/comments{/number}","issue_comment_url":"https://api.github.com/repos/spoud/rotor/issues/comments{/number}","contents_url":"https://api.github.com/repos/spoud/rotor/contents/{+path}","compare_url":"https://api.github.com/repos/spoud/rotor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spoud/rotor/merges","archive_url":"https://api.github.com/repos/spoud/rotor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spoud/rotor/downloads","issues_url":"https://api.github.com/repos/spoud/rotor/issues{/number}","pulls_url":"https://api.github.com/repos/spoud/rotor/pulls{/number}","milestones_url":"https://api.github.com/repos/spoud/rotor/milestones{/number}","notifications_url":"https://api.github.com/repos/spoud/rotor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spoud/rotor/labels{/name}","releases_url":"https://api.github.com/repos/spoud/rotor/releases{/id}","deployments_url":"https://api.github.com/repos/spoud/rotor/deployments","created_at":"2018-08-23T01:48:12Z","updated_at":"2018-08-24T15:24:12Z","pushed_at":"2018-08-24T15:33:24Z","git_url":"git://github.com/spoud/rotor.git","ssh_url":"git@github.com:spoud/rotor.git","clone_url":"https://github.com/spoud/rotor.git","svn_url":"https://github.com/spoud/rotor","homepage":null,"size":5693,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"turbinelabs:master","ref":"master","sha":"559d2ca3cfd34f9df6c575169880e9e5d1960a84","user":{"login":"turbinelabs","id":12767820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzY3ODIw","avatar_url":"https://avatars0.githubusercontent.com/u/12767820?v=4","gravatar_id":"","url":"https://api.github.com/users/turbinelabs","html_url":"https://github.com/turbinelabs","followers_url":"https://api.github.com/users/turbinelabs/followers","following_url":"https://api.github.com/users/turbinelabs/following{/other_user}","gists_url":"https://api.github.com/users/turbinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/turbinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbinelabs/subscriptions","organizations_url":"https://api.github.com/users/turbinelabs/orgs","repos_url":"https://api.github.com/users/turbinelabs/repos","events_url":"https://api.github.com/users/turbinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/turbinelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":133552986,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NTI5ODY=","name":"rotor","full_name":"turbinelabs/rotor","owner":{"login":"turbinelabs","id":12767820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzY3ODIw","avatar_url":"https://avatars0.githubusercontent.com/u/12767820?v=4","gravatar_id":"","url":"https://api.github.com/users/turbinelabs","html_url":"https://github.com/turbinelabs","followers_url":"https://api.github.com/users/turbinelabs/followers","following_url":"https://api.github.com/users/turbinelabs/following{/other_user}","gists_url":"https://api.github.com/users/turbinelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/turbinelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbinelabs/subscriptions","organizations_url":"https://api.github.com/users/turbinelabs/orgs","repos_url":"https://api.github.com/users/turbinelabs/repos","events_url":"https://api.github.com/users/turbinelabs/events{/privacy}","received_events_url":"https://api.github.com/users/turbinelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/turbinelabs/rotor","description":null,"fork":false,"url":"https://api.github.com/repos/turbinelabs/rotor","forks_url":"https://api.github.com/repos/turbinelabs/rotor/forks","keys_url":"https://api.github.com/repos/turbinelabs/rotor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turbinelabs/rotor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turbinelabs/rotor/teams","hooks_url":"https://api.github.com/repos/turbinelabs/rotor/hooks","issue_events_url":"https://api.github.com/repos/turbinelabs/rotor/issues/events{/number}","events_url":"https://api.github.com/repos/turbinelabs/rotor/events","assignees_url":"https://api.github.com/repos/turbinelabs/rotor/assignees{/user}","branches_url":"https://api.github.com/repos/turbinelabs/rotor/branches{/branch}","tags_url":"https://api.github.com/repos/turbinelabs/rotor/tags","blobs_url":"https://api.github.com/repos/turbinelabs/rotor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turbinelabs/rotor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turbinelabs/rotor/git/refs{/sha}","trees_url":"https://api.github.com/repos/turbinelabs/rotor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turbinelabs/rotor/statuses/{sha}","languages_url":"https://api.github.com/repos/turbinelabs/rotor/languages","stargazers_url":"https://api.github.com/repos/turbinelabs/rotor/stargazers","contributors_url":"https://api.github.com/repos/turbinelabs/rotor/contributors","subscribers_url":"https://api.github.com/repos/turbinelabs/rotor/subscribers","subscription_url":"https://api.github.com/repos/turbinelabs/rotor/subscription","commits_url":"https://api.github.com/repos/turbinelabs/rotor/commits{/sha}","git_commits_url":"https://api.github.com/repos/turbinelabs/rotor/git/commits{/sha}","comments_url":"https://api.github.com/repos/turbinelabs/rotor/comments{/number}","issue_comment_url":"https://api.github.com/repos/turbinelabs/rotor/issues/comments{/number}","contents_url":"https://api.github.com/repos/turbinelabs/rotor/contents/{+path}","compare_url":"https://api.github.com/repos/turbinelabs/rotor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turbinelabs/rotor/merges","archive_url":"https://api.github.com/repos/turbinelabs/rotor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turbinelabs/rotor/downloads","issues_url":"https://api.github.com/repos/turbinelabs/rotor/issues{/number}","pulls_url":"https://api.github.com/repos/turbinelabs/rotor/pulls{/number}","milestones_url":"https://api.github.com/repos/turbinelabs/rotor/milestones{/number}","notifications_url":"https://api.github.com/repos/turbinelabs/rotor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turbinelabs/rotor/labels{/name}","releases_url":"https://api.github.com/repos/turbinelabs/rotor/releases{/id}","deployments_url":"https://api.github.com/repos/turbinelabs/rotor/deployments","created_at":"2018-05-15T17:50:27Z","updated_at":"2018-08-23T08:01:52Z","pushed_at":"2018-08-24T15:33:25Z","git_url":"git://github.com/turbinelabs/rotor.git","ssh_url":"git@github.com:turbinelabs/rotor.git","clone_url":"https://github.com/turbinelabs/rotor.git","svn_url":"https://github.com/turbinelabs/rotor","homepage":null,"size":5844,"stargazers_count":145,"watchers_count":145,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":4,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/turbinelabs/rotor/pulls/25"},"html":{"href":"https://github.com/turbinelabs/rotor/pull/25"},"issue":{"href":"https://api.github.com/repos/turbinelabs/rotor/issues/25"},"comments":{"href":"https://api.github.com/repos/turbinelabs/rotor/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/turbinelabs/rotor/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/turbinelabs/rotor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/turbinelabs/rotor/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/turbinelabs/rotor/statuses/4581717dd5964ac15e8a78009612518a4ef1eaef"}},"author_association":"NONE"}}
{"actor":{"display_login":"9len"}}