{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/1167","repository_url":"https://api.github.com/repos/Microsoft/react-native-code-push","labels_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/1167/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/1167/comments","events_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/1167/events","html_url":"https://github.com/Microsoft/react-native-code-push/issues/1167","id":292763621,"number":1167,"title":"no rollback when not call notifyAppReady","user":{"login":"fatfatson","id":5842874,"avatar_url":"https://avatars3.githubusercontent.com/u/5842874?v=4","gravatar_id":"","url":"https://api.github.com/users/fatfatson","html_url":"https://github.com/fatfatson","followers_url":"https://api.github.com/users/fatfatson/followers","following_url":"https://api.github.com/users/fatfatson/following{/other_user}","gists_url":"https://api.github.com/users/fatfatson/gists{/gist_id}","starred_url":"https://api.github.com/users/fatfatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatfatson/subscriptions","organizations_url":"https://api.github.com/users/fatfatson/orgs","repos_url":"https://api.github.com/users/fatfatson/repos","events_url":"https://api.github.com/users/fatfatson/events{/privacy}","received_events_url":"https://api.github.com/users/fatfatson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-01-30T12:23:40Z","updated_at":"2018-02-15T16:05:20Z","closed_at":null,"author_association":"NONE","body":"### Steps to Reproduce\r\n1.query&download&install an update manually\r\n2.restart app\r\n3.getUpdateMetadata shows current is in the new version\r\n\r\n### Expected Behavior\r\naccording to the docs, it should be rollbacked if I install update manually and don't call notifyAppReady.\r\n\r\n### Actual Behavior\r\nrollback not happen.\r\n\r\n### Reproducible Demo\r\n```\r\nasync startUpdate() {\r\n\t\tif (!this.state.localPackage) {\r\n\t\t\t//this.setState({ showUpdating: true });\r\n\t\t\tvar localPackage = await this.state.availableUpdate.download(({ receivedBytes, totalBytes }) => {\r\n\t\t\t\tconsole.log(receivedBytes, totalBytes);\r\n\t\t\t\tif (this._isUnmount) return;\r\n\t\t\t\tthis.setState({\r\n\t\t\t\t\tdownloadProgress: receivedBytes / totalBytes,\r\n\t\t\t\t});\r\n\t\t\t});\r\n\r\n\t\t\tif (this._isUnmount) return;\r\n\t\t\tconsole.log('download ok', localPackage);\r\n\t\t\tthis.setState({ localPackage });\r\n\t\t}\r\n\r\n\t\tif (this._isUnmount) return;\r\n\t\tvar ok = await this.waitAlert();\r\n\t\tif (!ok) return;\r\n\r\n\t\tawait this.state.localPackage.install();\r\n\t\tconsole.log('install ok!');\r\n\t}\r\n```\r\n\r\n\r\n### Environment\r\n\r\n* react-native-code-push version:^5.2.0-beta\r\n* react-native version:^0.51.0\r\n* iOS/Android/Windows version:Android 7.0 API24\r\n* Does this reproduce on a debug build or release build? All\r\n* Does this reproduce on a simulator, or only on a physical device? All\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/comments/365974182","html_url":"https://github.com/Microsoft/react-native-code-push/issues/1167#issuecomment-365974182","issue_url":"https://api.github.com/repos/Microsoft/react-native-code-push/issues/1167","id":365974182,"user":{"login":"iTOYS","id":4017593,"avatar_url":"https://avatars0.githubusercontent.com/u/4017593?v=4","gravatar_id":"","url":"https://api.github.com/users/iTOYS","html_url":"https://github.com/iTOYS","followers_url":"https://api.github.com/users/iTOYS/followers","following_url":"https://api.github.com/users/iTOYS/following{/other_user}","gists_url":"https://api.github.com/users/iTOYS/gists{/gist_id}","starred_url":"https://api.github.com/users/iTOYS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTOYS/subscriptions","organizations_url":"https://api.github.com/users/iTOYS/orgs","repos_url":"https://api.github.com/users/iTOYS/repos","events_url":"https://api.github.com/users/iTOYS/events{/privacy}","received_events_url":"https://api.github.com/users/iTOYS/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T16:05:20Z","updated_at":"2018-02-15T16:05:20Z","author_association":"MEMBER","body":"Hi @fatfatson,\r\nThanks fo reporting!\r\nCould you please attach archive with sample project to reproduce?\r\n\r\nThanks!"}}
{"actor":{"display_login":"iTOYS"}}