{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9990","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9990/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9990/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9990/events","html_url":"https://github.com/matplotlib/matplotlib/pull/9990","id":281639977,"number":9990,"title":"Fix and document lightsource argument in mplot3d","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"labels":[{"id":116757,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/mplot3d","name":"mplot3d","color":"02e10c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/25","html_url":"https://github.com/matplotlib/matplotlib/milestone/25","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/25/labels","id":2189521,"number":25,"title":"v2.2","description":"","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":855,"closed_issues":419,"state":"open","created_at":"2016-12-11T20:54:18Z","updated_at":"2018-02-09T03:46:22Z","due_on":"2018-01-30T08:00:00Z","closed_at":null},"comments":1,"created_at":"2017-12-13T06:36:15Z","updated_at":"2018-02-09T03:58:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/9990","html_url":"https://github.com/matplotlib/matplotlib/pull/9990","diff_url":"https://github.com/matplotlib/matplotlib/pull/9990.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/9990.patch"},"body":"<!--Thank you so much for your PR! To help us review, fill out the form\r\nto the best of your ability.  Please make use of the development guide at\r\nhttps://matplotlib.org/devdocs/devel/index.html\r\n\r\nFor help with git and github workflow, please see https://matplotlib.org/devel/gitwash/development_workflow.html\r\n\r\nPlease do not create the PR out of master, but out of a separate branch. -->\r\n\r\n<!--Provide a general summary of your changes in the title above, for\r\nexample \"Raises ValueError on Non-Numeric Input to set_xlim\".  Please avoid\r\nnon-descriptive titles such as \"Addresses issue #8576\".-->\r\n\r\n<!--If you are contributing fixes to docstrings, please pay attention to\r\nhttp://matplotlib.org/devel/documenting_mpl.html#formatting.  In particular,\r\nnote the difference between using single backquotes, double backquotes, and\r\nasterisks in the markup.-->\r\n\r\n## PR Summary\r\n\r\nFixes the problems in #8877, where the `lightsource` argument is broken in silly ways.\r\n\r\nThis has been sitting in my working tree a while now, but is freshly rebased.\r\n\r\n## PR Checklist\r\n\r\n- [ ] Has Pytest style unit tests\r\n- [ ] Code is PEP 8 compliant\r\n- [ ] New features are documented, with examples if plot related\r\n- [ ] Documentation is sphinx and numpydoc compliant\r\n- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way\r\n\r\n<!--We understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in.  Please let us know if the reviews are unclear or the\r\nrecommended next step seems overly demanding , or if you would like help in\r\naddressing a reviewer's comments.  And please ping us if you've been waiting\r\ntoo long to hear back on your PR.-->\r\n"},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/364328515","html_url":"https://github.com/matplotlib/matplotlib/pull/9990#issuecomment-364328515","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9990","id":364328515,"user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T03:58:18Z","updated_at":"2018-02-09T03:58:18Z","author_association":"CONTRIBUTOR","body":"I think this will conflict with #10001 too."}}
{"actor":{"display_login":"eric-wieser"}}