{"action":"closed","number":255,"pull_request":{"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/255","id":229811228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODExMjI4","html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/255","diff_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/255.diff","patch_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/255.patch","issue_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/255","number":255,"state":"closed","locked":false,"title":"ENH Capture depleted material with underscores ","user":{"login":"drewejohnson","id":19477741,"node_id":"MDQ6VXNlcjE5NDc3NzQx","avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"body":"Closes #58 by allowing the DepletionReader to work with materials containing underscores. Had to move away from the regular expression parsing because some variables contain underscores, while some don't. Added a bunch of variables into `serpentTools/parsers/_collections.py`. These variables are used in the process of figuring out what to strip out from the variable name to obtain the actual name of the material.\r\n\r\nAdded some tests to ensure that we can indeed do this, as well as some tests for \r\nutilities that break up the material names.\r\n\r\n- [x] PR fits the [project scope](http://serpent-tools.readthedocs.io/en/latest/develop/contributing.html#project-scope)\r\n- [x] Code to be committed is [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) and matches the [code style](http://serpent-tools.readthedocs.io/en/latest/develop/codestyle.html#code-style) of the project\r\n- [x] New and/or changed features are [well documented](http://serpent-tools.readthedocs.io/en/latest/develop/documentation.html#documentation) and have adequate testing\r\n\r\n## TODO\r\n- [x] Add this PR to changelog\r\n- [x] Find places where we say we can't do this and remove them","created_at":"2018-11-09T20:31:52Z","updated_at":"2018-11-09T20:45:40Z","closed_at":"2018-11-09T20:45:40Z","merged_at":"2018-11-09T20:45:40Z","merge_commit_sha":"32bacab4ed31a82a59806c74072328d57e915070","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":939138223,"node_id":"MDU6TGFiZWw5MzkxMzgyMjM=","url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels/API%20-%20Compatible","name":"API - Compatible","color":"006b75","default":false},{"id":686433628,"node_id":"MDU6TGFiZWw2ODY0MzM2Mjg=","url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":954629878,"node_id":"MDU6TGFiZWw5NTQ2Mjk4Nzg=","url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels/testing","name":"testing","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/255/commits","review_comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/255/comments","review_comment_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/255/comments","statuses_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/1345ff385fd260055364447f30b36c8c43fc3875","head":{"label":"drewejohnson:dep-underscores","ref":"dep-underscores","sha":"1345ff385fd260055364447f30b36c8c43fc3875","user":{"login":"drewejohnson","id":19477741,"node_id":"MDQ6VXNlcjE5NDc3NzQx","avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"repo":{"id":122671573,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NzE1NzM=","name":"serpent-tools","full_name":"drewejohnson/serpent-tools","private":false,"owner":{"login":"drewejohnson","id":19477741,"node_id":"MDQ6VXNlcjE5NDc3NzQx","avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drewejohnson/serpent-tools","description":"A suite of parsers designed to make interacting with SERPENT output files simple and flawless","fork":true,"url":"https://api.github.com/repos/drewejohnson/serpent-tools","forks_url":"https://api.github.com/repos/drewejohnson/serpent-tools/forks","keys_url":"https://api.github.com/repos/drewejohnson/serpent-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drewejohnson/serpent-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drewejohnson/serpent-tools/teams","hooks_url":"https://api.github.com/repos/drewejohnson/serpent-tools/hooks","issue_events_url":"https://api.github.com/repos/drewejohnson/serpent-tools/issues/events{/number}","events_url":"https://api.github.com/repos/drewejohnson/serpent-tools/events","assignees_url":"https://api.github.com/repos/drewejohnson/serpent-tools/assignees{/user}","branches_url":"https://api.github.com/repos/drewejohnson/serpent-tools/branches{/branch}","tags_url":"https://api.github.com/repos/drewejohnson/serpent-tools/tags","blobs_url":"https://api.github.com/repos/drewejohnson/serpent-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drewejohnson/serpent-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drewejohnson/serpent-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/drewejohnson/serpent-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drewejohnson/serpent-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/drewejohnson/serpent-tools/languages","stargazers_url":"https://api.github.com/repos/drewejohnson/serpent-tools/stargazers","contributors_url":"https://api.github.com/repos/drewejohnson/serpent-tools/contributors","subscribers_url":"https://api.github.com/repos/drewejohnson/serpent-tools/subscribers","subscription_url":"https://api.github.com/repos/drewejohnson/serpent-tools/subscription","commits_url":"https://api.github.com/repos/drewejohnson/serpent-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/drewejohnson/serpent-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/drewejohnson/serpent-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/drewejohnson/serpent-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/drewejohnson/serpent-tools/contents/{+path}","compare_url":"https://api.github.com/repos/drewejohnson/serpent-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drewejohnson/serpent-tools/merges","archive_url":"https://api.github.com/repos/drewejohnson/serpent-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drewejohnson/serpent-tools/downloads","issues_url":"https://api.github.com/repos/drewejohnson/serpent-tools/issues{/number}","pulls_url":"https://api.github.com/repos/drewejohnson/serpent-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/drewejohnson/serpent-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/drewejohnson/serpent-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drewejohnson/serpent-tools/labels{/name}","releases_url":"https://api.github.com/repos/drewejohnson/serpent-tools/releases{/id}","deployments_url":"https://api.github.com/repos/drewejohnson/serpent-tools/deployments","created_at":"2018-02-23T20:53:48Z","updated_at":"2018-10-26T14:19:14Z","pushed_at":"2018-11-09T20:39:10Z","git_url":"git://github.com/drewejohnson/serpent-tools.git","ssh_url":"git@github.com:drewejohnson/serpent-tools.git","clone_url":"https://github.com/drewejohnson/serpent-tools.git","svn_url":"https://github.com/drewejohnson/serpent-tools","homepage":null,"size":8380,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CORE-GATECH-GROUP:develop","ref":"develop","sha":"4a3905f47d1844915de7c18e8f55dd4bbe50b1c9","user":{"login":"CORE-GATECH-GROUP","id":26622918,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjIyOTE4","avatar_url":"https://avatars3.githubusercontent.com/u/26622918?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH-GROUP","html_url":"https://github.com/CORE-GATECH-GROUP","followers_url":"https://api.github.com/users/CORE-GATECH-GROUP/followers","following_url":"https://api.github.com/users/CORE-GATECH-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH-GROUP/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH-GROUP/orgs","repos_url":"https://api.github.com/users/CORE-GATECH-GROUP/repos","events_url":"https://api.github.com/users/CORE-GATECH-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":102786755,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3ODY3NTU=","name":"serpent-tools","full_name":"CORE-GATECH-GROUP/serpent-tools","private":false,"owner":{"login":"CORE-GATECH-GROUP","id":26622918,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjIyOTE4","avatar_url":"https://avatars3.githubusercontent.com/u/26622918?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH-GROUP","html_url":"https://github.com/CORE-GATECH-GROUP","followers_url":"https://api.github.com/users/CORE-GATECH-GROUP/followers","following_url":"https://api.github.com/users/CORE-GATECH-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH-GROUP/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH-GROUP/orgs","repos_url":"https://api.github.com/users/CORE-GATECH-GROUP/repos","events_url":"https://api.github.com/users/CORE-GATECH-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH-GROUP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools","description":"A suite of parsers designed to make interacting with SERPENT output files simple and flawless","fork":false,"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools","forks_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/forks","keys_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/teams","hooks_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/hooks","issue_events_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/events{/number}","events_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/events","assignees_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/assignees{/user}","branches_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/branches{/branch}","tags_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/tags","blobs_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/languages","stargazers_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/stargazers","contributors_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/contributors","subscribers_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/subscribers","subscription_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/subscription","commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/contents/{+path}","compare_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/merges","archive_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/downloads","issues_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues{/number}","pulls_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels{/name}","releases_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/releases{/id}","deployments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/deployments","created_at":"2017-09-07T21:19:39Z","updated_at":"2018-11-09T13:14:59Z","pushed_at":"2018-11-09T20:45:40Z","git_url":"git://github.com/CORE-GATECH-GROUP/serpent-tools.git","ssh_url":"git@github.com:CORE-GATECH-GROUP/serpent-tools.git","clone_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools.git","svn_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools","homepage":"http://serpent-tools.readthedocs.io/en/latest/","size":8568,"stargazers_count":7,"watchers_count":7,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":14,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/255"},"html":{"href":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/255"},"issue":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/255"},"comments":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/1345ff385fd260055364447f30b36c8c43fc3875"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"drewejohnson","id":19477741,"node_id":"MDQ6VXNlcjE5NDc3NzQx","avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":155,"deletions":85,"changed_files":6}}
{"actor":{"display_login":"drewejohnson"}}