{"action":"created","issue":{"url":"https://api.github.com/repos/CosmosOS/Cosmos/issues/908","repository_url":"https://api.github.com/repos/CosmosOS/Cosmos","labels_url":"https://api.github.com/repos/CosmosOS/Cosmos/issues/908/labels{/name}","comments_url":"https://api.github.com/repos/CosmosOS/Cosmos/issues/908/comments","events_url":"https://api.github.com/repos/CosmosOS/Cosmos/issues/908/events","html_url":"https://github.com/CosmosOS/Cosmos/pull/908","id":300030401,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcxMjMyNzM4","number":908,"title":"[WIP] Created plugs to make Hashtable work (at least when an object is key).","user":{"login":"fanoI","id":8480388,"node_id":"MDQ6VXNlcjg0ODAzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/8480388?v=4","gravatar_id":"","url":"https://api.github.com/users/fanoI","html_url":"https://github.com/fanoI","followers_url":"https://api.github.com/users/fanoI/followers","following_url":"https://api.github.com/users/fanoI/following{/other_user}","gists_url":"https://api.github.com/users/fanoI/gists{/gist_id}","starred_url":"https://api.github.com/users/fanoI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanoI/subscriptions","organizations_url":"https://api.github.com/users/fanoI/orgs","repos_url":"https://api.github.com/users/fanoI/repos","events_url":"https://api.github.com/users/fanoI/events{/privacy}","received_events_url":"https://api.github.com/users/fanoI/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-25T14:29:24Z","updated_at":"2018-08-28T15:09:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CosmosOS/Cosmos/pulls/908","html_url":"https://github.com/CosmosOS/Cosmos/pull/908","diff_url":"https://github.com/CosmosOS/Cosmos/pull/908.diff","patch_url":"https://github.com/CosmosOS/Cosmos/pull/908.patch"},"body":"There are issue however:\r\n1. IL2CPU modifications are needed (see the PR for the list of the PR of IL2CPU to merge to make this usable)\r\n2. Some fix in IL2CPU seems to give problems with Dictionary (VMT problem again?)\r\n3. Hashtable with valuetype as key doesn't work (ContainsKey() always return false)\r\n\r\nThese IL2CPU PR are needed to test this PR:\r\nhttps://github.com/CosmosOS/IL2CPU/pull/47 (OK merged)\r\nhttps://github.com/CosmosOS/IL2CPU/pull/48  (OK merged)\r\nhttps://github.com/CosmosOS/IL2CPU/issues/37 (OK merged)\r\nhttps://github.com/CosmosOS/IL2CPU/pull/69\r\nhttps://github.com/CosmosOS/IL2CPU/pull/70"},"comment":{"url":"https://api.github.com/repos/CosmosOS/Cosmos/issues/comments/416623838","html_url":"https://github.com/CosmosOS/Cosmos/pull/908#issuecomment-416623838","issue_url":"https://api.github.com/repos/CosmosOS/Cosmos/issues/908","id":416623838,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjYyMzgzOA==","user":{"login":"fanoI","id":8480388,"node_id":"MDQ6VXNlcjg0ODAzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/8480388?v=4","gravatar_id":"","url":"https://api.github.com/users/fanoI","html_url":"https://github.com/fanoI","followers_url":"https://api.github.com/users/fanoI/followers","following_url":"https://api.github.com/users/fanoI/following{/other_user}","gists_url":"https://api.github.com/users/fanoI/gists{/gist_id}","starred_url":"https://api.github.com/users/fanoI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanoI/subscriptions","organizations_url":"https://api.github.com/users/fanoI/orgs","repos_url":"https://api.github.com/users/fanoI/repos","events_url":"https://api.github.com/users/fanoI/events{/privacy}","received_events_url":"https://api.github.com/users/fanoI/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T15:09:53Z","updated_at":"2018-08-28T15:09:53Z","author_association":"CONTRIBUTOR","body":"With this update the problems with ValueTypes as keys are resolved after https://github.com/CosmosOS/IL2CPU/pull/69 and https://github.com/CosmosOS/IL2CPU/pull/70 it should be ready to be merged."}}
{"actor":{"display_login":"fanoI"}}