{"action":"closed","number":2284,"pull_request":{"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/2284","id":238165397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTY1Mzk3","html_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/2284","diff_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/2284.diff","patch_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/2284.patch","issue_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/2284","number":2284,"state":"closed","locked":false,"title":"fix(form-group): allow label alignment on label when not horizontal","user":{"login":"tmorehouse","id":2781561,"node_id":"MDQ6VXNlcjI3ODE1NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2781561?v=4","gravatar_id":"","url":"https://api.github.com/users/tmorehouse","html_url":"https://github.com/tmorehouse","followers_url":"https://api.github.com/users/tmorehouse/followers","following_url":"https://api.github.com/users/tmorehouse/following{/other_user}","gists_url":"https://api.github.com/users/tmorehouse/gists{/gist_id}","starred_url":"https://api.github.com/users/tmorehouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmorehouse/subscriptions","organizations_url":"https://api.github.com/users/tmorehouse/orgs","repos_url":"https://api.github.com/users/tmorehouse/repos","events_url":"https://api.github.com/users/tmorehouse/events{/privacy}","received_events_url":"https://api.github.com/users/tmorehouse/received_events","type":"User","site_admin":false},"body":"<!-- PULL REQUEST TEMPLATE -->\r\n## Description of Pull Request:\r\n\r\nThe `<label>` element in non-horizontal form group has `display: inline-block` which prevents label alignment from working in non-horizontal form-groups.\r\n\r\nThis addresses the issue by adding class `d-block` to the `<label>` when non-horizontal.\r\n\r\n## PR checklist:\r\n\r\n<!-- (Update \"[ ]\" to \"[x]\" to check a box) -->\r\n\r\n**What kind of change does this PR introduce?** (check at least one)\r\n- [x] Bugfix\r\n- [ ] Feature\r\n- [ ] Enhancement to an existing feature\r\n- [ ] ARIA accessibility\r\n- [ ] Documentation update\r\n- [ ] Other, please describe:\r\n\r\n**Does this PR introduce a breaking change?** (check one)\r\n- [ ] Yes\r\n- [x] No\r\n\r\nIf yes, please describe the impact:\r\n\r\n\r\n**The PR fulfills these requirements:**\r\n- [x] It's submitted to the `dev` branch, **not** the `master` branch\r\n- [ ] When resolving a specific issue, it's referenced in the PR's title (i.e. `fixes #xxxx[,#xxxx]`, where \"xxxx\" is the issue number)\r\n- [x] The PR should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.\r\n- [x] PR titles should following the [**Conventional Commits**](https://www.conventionalcommits.org/) naming convention (i.e. \"fix(alert): not alerting during SSR render\", \"docs(badge): Updated pill examples, fix typos\", \"chore: fix typo in docs\", etc). **This is very important, as the `CHANGELOG` is generated from these messages.**\r\n\r\n**If new features/enhancement/fixes are added or changed:**\r\n- [ ] Includes documentation updates (including updating the component's `package.json` for slot and event changes)\r\n- [ ] New/updated tests are included and passing (if required)\r\n- [x] Existing test suites are passing\r\n- [ ] The changes have not impacted the functionality of other components or directives \r\n- [ ] ARIA Accessibility has been taken into consideration (does it affect screen reader users or keyboard only users? clickable items should be in the tab index, etc)\r\n\r\n**If adding a new feature, or changing the functionality of an existing feature, the PR's description above includes:**\r\n- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)\r\n\r\n","created_at":"2018-12-12T20:04:18Z","updated_at":"2018-12-12T20:09:38Z","closed_at":"2018-12-12T20:09:38Z","merged_at":"2018-12-12T20:09:38Z","merge_commit_sha":"c306b185d81b54ef188744242a944af520599efb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/2284/commits","review_comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/2284/comments","review_comment_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/2284/comments","statuses_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/26ab791a483148fc0c544d8deca61a363a34c7ec","head":{"label":"bootstrap-vue:tmorehouse/formpgroup-label","ref":"tmorehouse/formpgroup-label","sha":"26ab791a483148fc0c544d8deca61a363a34c7ec","user":{"login":"bootstrap-vue","id":22965283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTY1Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"repo":{"id":70342215,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM0MjIxNQ==","name":"bootstrap-vue","full_name":"bootstrap-vue/bootstrap-vue","private":false,"owner":{"login":"bootstrap-vue","id":22965283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTY1Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bootstrap-vue/bootstrap-vue","description":"BootstrapVue provides one of the most comprehensive implementations of Bootstrap 4 components and grid system for Vue.js and with extensive and automated WAI-ARIA accessibility markup.","fork":false,"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue","forks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/forks","keys_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/teams","hooks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/hooks","issue_events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/events{/number}","events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/events","assignees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/assignees{/user}","branches_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/branches{/branch}","tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/tags","blobs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/languages","stargazers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/stargazers","contributors_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contributors","subscribers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscribers","subscription_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscription","commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contents/{+path}","compare_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/merges","archive_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/downloads","issues_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues{/number}","pulls_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/labels{/name}","releases_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/releases{/id}","deployments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/deployments","created_at":"2016-10-08T15:59:35Z","updated_at":"2018-12-12T20:05:25Z","pushed_at":"2018-12-12T20:09:38Z","git_url":"git://github.com/bootstrap-vue/bootstrap-vue.git","ssh_url":"git@github.com:bootstrap-vue/bootstrap-vue.git","clone_url":"https://github.com/bootstrap-vue/bootstrap-vue.git","svn_url":"https://github.com/bootstrap-vue/bootstrap-vue","homepage":"https://bootstrap-vue.js.org","size":6239,"stargazers_count":7209,"watchers_count":7209,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":988,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":988,"open_issues":66,"watchers":7209,"default_branch":"dev"}},"base":{"label":"bootstrap-vue:dev","ref":"dev","sha":"ab29d53dc71fa4b86dbb6882c068711e604a93aa","user":{"login":"bootstrap-vue","id":22965283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTY1Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"repo":{"id":70342215,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM0MjIxNQ==","name":"bootstrap-vue","full_name":"bootstrap-vue/bootstrap-vue","private":false,"owner":{"login":"bootstrap-vue","id":22965283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyOTY1Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bootstrap-vue/bootstrap-vue","description":"BootstrapVue provides one of the most comprehensive implementations of Bootstrap 4 components and grid system for Vue.js and with extensive and automated WAI-ARIA accessibility markup.","fork":false,"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue","forks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/forks","keys_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/teams","hooks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/hooks","issue_events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/events{/number}","events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/events","assignees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/assignees{/user}","branches_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/branches{/branch}","tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/tags","blobs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/languages","stargazers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/stargazers","contributors_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contributors","subscribers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscribers","subscription_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscription","commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contents/{+path}","compare_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/merges","archive_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/downloads","issues_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues{/number}","pulls_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/labels{/name}","releases_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/releases{/id}","deployments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/deployments","created_at":"2016-10-08T15:59:35Z","updated_at":"2018-12-12T20:05:25Z","pushed_at":"2018-12-12T20:09:38Z","git_url":"git://github.com/bootstrap-vue/bootstrap-vue.git","ssh_url":"git@github.com:bootstrap-vue/bootstrap-vue.git","clone_url":"https://github.com/bootstrap-vue/bootstrap-vue.git","svn_url":"https://github.com/bootstrap-vue/bootstrap-vue","homepage":"https://bootstrap-vue.js.org","size":6239,"stargazers_count":7209,"watchers_count":7209,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":988,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":988,"open_issues":66,"watchers":7209,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/2284"},"html":{"href":"https://github.com/bootstrap-vue/bootstrap-vue/pull/2284"},"issue":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/2284"},"comments":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/2284/comments"},"review_comments":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/2284/comments"},"review_comment":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/2284/commits"},"statuses":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/26ab791a483148fc0c544d8deca61a363a34c7ec"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tmorehouse","id":2781561,"node_id":"MDQ6VXNlcjI3ODE1NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2781561?v=4","gravatar_id":"","url":"https://api.github.com/users/tmorehouse","html_url":"https://github.com/tmorehouse","followers_url":"https://api.github.com/users/tmorehouse/followers","following_url":"https://api.github.com/users/tmorehouse/following{/other_user}","gists_url":"https://api.github.com/users/tmorehouse/gists{/gist_id}","starred_url":"https://api.github.com/users/tmorehouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmorehouse/subscriptions","organizations_url":"https://api.github.com/users/tmorehouse/orgs","repos_url":"https://api.github.com/users/tmorehouse/repos","events_url":"https://api.github.com/users/tmorehouse/events{/privacy}","received_events_url":"https://api.github.com/users/tmorehouse/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"tmorehouse"}}