{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/samblau/pymatgen/pulls/6","id":214395745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Mzk1NzQ1","html_url":"https://github.com/samblau/pymatgen/pull/6","diff_url":"https://github.com/samblau/pymatgen/pull/6.diff","patch_url":"https://github.com/samblau/pymatgen/pull/6.patch","issue_url":"https://api.github.com/repos/samblau/pymatgen/issues/6","number":6,"state":"closed","locked":false,"title":"Bug fix - MoleculeGraph.split_molecule_subgraphs","user":{"login":"espottesmith","id":17201238,"node_id":"MDQ6VXNlcjE3MjAxMjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17201238?v=4","gravatar_id":"","url":"https://api.github.com/users/espottesmith","html_url":"https://github.com/espottesmith","followers_url":"https://api.github.com/users/espottesmith/followers","following_url":"https://api.github.com/users/espottesmith/following{/other_user}","gists_url":"https://api.github.com/users/espottesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/espottesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espottesmith/subscriptions","organizations_url":"https://api.github.com/users/espottesmith/orgs","repos_url":"https://api.github.com/users/espottesmith/repos","events_url":"https://api.github.com/users/espottesmith/events{/privacy}","received_events_url":"https://api.github.com/users/espottesmith/received_events","type":"User","site_admin":false},"body":"Previously, MoleculeGraph.split_molecule_subgraphs used an inelegant remapping algorithm to link the graph data and Molecule data after a split. Occasionally, this mapping failed, causing MoleculeGraph.molecule and MoleculeGraph.graph to have different atoms at different indices. This pull request fixes this bug by removing the remapping algorithm and replacing it with one that relies on MoleculeGraph.set_node_attributes (which automatically links Molecule and node information). Additionally, some tests have been added to make MoleculeGraph more robust (this is still a work in progress).","created_at":"2018-09-10T18:00:20Z","updated_at":"2018-09-11T23:30:38Z","closed_at":"2018-09-11T23:30:38Z","merged_at":"2018-09-11T23:30:38Z","merge_commit_sha":"6b8aa0bd502ec452c4ee6c2ac08d953177563ab7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samblau/pymatgen/pulls/6/commits","review_comments_url":"https://api.github.com/repos/samblau/pymatgen/pulls/6/comments","review_comment_url":"https://api.github.com/repos/samblau/pymatgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samblau/pymatgen/issues/6/comments","statuses_url":"https://api.github.com/repos/samblau/pymatgen/statuses/6773697211d1627852df0f150942cbe4a6436f63","head":{"label":"espottesmith:bug_fixing_blau","ref":"bug_fixing_blau","sha":"6773697211d1627852df0f150942cbe4a6436f63","user":{"login":"espottesmith","id":17201238,"node_id":"MDQ6VXNlcjE3MjAxMjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17201238?v=4","gravatar_id":"","url":"https://api.github.com/users/espottesmith","html_url":"https://github.com/espottesmith","followers_url":"https://api.github.com/users/espottesmith/followers","following_url":"https://api.github.com/users/espottesmith/following{/other_user}","gists_url":"https://api.github.com/users/espottesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/espottesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espottesmith/subscriptions","organizations_url":"https://api.github.com/users/espottesmith/orgs","repos_url":"https://api.github.com/users/espottesmith/repos","events_url":"https://api.github.com/users/espottesmith/events{/privacy}","received_events_url":"https://api.github.com/users/espottesmith/received_events","type":"User","site_admin":false},"repo":{"id":136955788,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5NTU3ODg=","name":"pymatgen","full_name":"espottesmith/pymatgen","owner":{"login":"espottesmith","id":17201238,"node_id":"MDQ6VXNlcjE3MjAxMjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17201238?v=4","gravatar_id":"","url":"https://api.github.com/users/espottesmith","html_url":"https://github.com/espottesmith","followers_url":"https://api.github.com/users/espottesmith/followers","following_url":"https://api.github.com/users/espottesmith/following{/other_user}","gists_url":"https://api.github.com/users/espottesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/espottesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espottesmith/subscriptions","organizations_url":"https://api.github.com/users/espottesmith/orgs","repos_url":"https://api.github.com/users/espottesmith/repos","events_url":"https://api.github.com/users/espottesmith/events{/privacy}","received_events_url":"https://api.github.com/users/espottesmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/espottesmith/pymatgen","description":"Python Materials Genomics (pymatgen) is a robust materials analysis code that defines core object representations for structures and molecules with support for many electronic structure codes. It is currently the core analysis code powering the Materials Project.","fork":true,"url":"https://api.github.com/repos/espottesmith/pymatgen","forks_url":"https://api.github.com/repos/espottesmith/pymatgen/forks","keys_url":"https://api.github.com/repos/espottesmith/pymatgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espottesmith/pymatgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espottesmith/pymatgen/teams","hooks_url":"https://api.github.com/repos/espottesmith/pymatgen/hooks","issue_events_url":"https://api.github.com/repos/espottesmith/pymatgen/issues/events{/number}","events_url":"https://api.github.com/repos/espottesmith/pymatgen/events","assignees_url":"https://api.github.com/repos/espottesmith/pymatgen/assignees{/user}","branches_url":"https://api.github.com/repos/espottesmith/pymatgen/branches{/branch}","tags_url":"https://api.github.com/repos/espottesmith/pymatgen/tags","blobs_url":"https://api.github.com/repos/espottesmith/pymatgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espottesmith/pymatgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espottesmith/pymatgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/espottesmith/pymatgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espottesmith/pymatgen/statuses/{sha}","languages_url":"https://api.github.com/repos/espottesmith/pymatgen/languages","stargazers_url":"https://api.github.com/repos/espottesmith/pymatgen/stargazers","contributors_url":"https://api.github.com/repos/espottesmith/pymatgen/contributors","subscribers_url":"https://api.github.com/repos/espottesmith/pymatgen/subscribers","subscription_url":"https://api.github.com/repos/espottesmith/pymatgen/subscription","commits_url":"https://api.github.com/repos/espottesmith/pymatgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/espottesmith/pymatgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/espottesmith/pymatgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/espottesmith/pymatgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/espottesmith/pymatgen/contents/{+path}","compare_url":"https://api.github.com/repos/espottesmith/pymatgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espottesmith/pymatgen/merges","archive_url":"https://api.github.com/repos/espottesmith/pymatgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espottesmith/pymatgen/downloads","issues_url":"https://api.github.com/repos/espottesmith/pymatgen/issues{/number}","pulls_url":"https://api.github.com/repos/espottesmith/pymatgen/pulls{/number}","milestones_url":"https://api.github.com/repos/espottesmith/pymatgen/milestones{/number}","notifications_url":"https://api.github.com/repos/espottesmith/pymatgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espottesmith/pymatgen/labels{/name}","releases_url":"https://api.github.com/repos/espottesmith/pymatgen/releases{/id}","deployments_url":"https://api.github.com/repos/espottesmith/pymatgen/deployments","created_at":"2018-06-11T16:56:40Z","updated_at":"2018-08-30T20:26:31Z","pushed_at":"2018-09-10T18:57:48Z","git_url":"git://github.com/espottesmith/pymatgen.git","ssh_url":"git@github.com:espottesmith/pymatgen.git","clone_url":"https://github.com/espottesmith/pymatgen.git","svn_url":"https://github.com/espottesmith/pymatgen","homepage":"http://www.pymatgen.org","size":490903,"stargazers_count":0,"watchers_count":0,"language":"Propeller Spin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samblau:qchem","ref":"qchem","sha":"203cae7770f25ca2691dd8f35b3eb14920f4e1e0","user":{"login":"samblau","id":7431223,"node_id":"MDQ6VXNlcjc0MzEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7431223?v=4","gravatar_id":"","url":"https://api.github.com/users/samblau","html_url":"https://github.com/samblau","followers_url":"https://api.github.com/users/samblau/followers","following_url":"https://api.github.com/users/samblau/following{/other_user}","gists_url":"https://api.github.com/users/samblau/gists{/gist_id}","starred_url":"https://api.github.com/users/samblau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samblau/subscriptions","organizations_url":"https://api.github.com/users/samblau/orgs","repos_url":"https://api.github.com/users/samblau/repos","events_url":"https://api.github.com/users/samblau/events{/privacy}","received_events_url":"https://api.github.com/users/samblau/received_events","type":"User","site_admin":false},"repo":{"id":119748546,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3NDg1NDY=","name":"pymatgen","full_name":"samblau/pymatgen","owner":{"login":"samblau","id":7431223,"node_id":"MDQ6VXNlcjc0MzEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7431223?v=4","gravatar_id":"","url":"https://api.github.com/users/samblau","html_url":"https://github.com/samblau","followers_url":"https://api.github.com/users/samblau/followers","following_url":"https://api.github.com/users/samblau/following{/other_user}","gists_url":"https://api.github.com/users/samblau/gists{/gist_id}","starred_url":"https://api.github.com/users/samblau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samblau/subscriptions","organizations_url":"https://api.github.com/users/samblau/orgs","repos_url":"https://api.github.com/users/samblau/repos","events_url":"https://api.github.com/users/samblau/events{/privacy}","received_events_url":"https://api.github.com/users/samblau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samblau/pymatgen","description":"Python Materials Genomics (pymatgen) is a robust materials analysis code that defines core object representations for structures and molecules with support for many electronic structure codes. It is currently the core analysis code powering the Materials Project.","fork":true,"url":"https://api.github.com/repos/samblau/pymatgen","forks_url":"https://api.github.com/repos/samblau/pymatgen/forks","keys_url":"https://api.github.com/repos/samblau/pymatgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samblau/pymatgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samblau/pymatgen/teams","hooks_url":"https://api.github.com/repos/samblau/pymatgen/hooks","issue_events_url":"https://api.github.com/repos/samblau/pymatgen/issues/events{/number}","events_url":"https://api.github.com/repos/samblau/pymatgen/events","assignees_url":"https://api.github.com/repos/samblau/pymatgen/assignees{/user}","branches_url":"https://api.github.com/repos/samblau/pymatgen/branches{/branch}","tags_url":"https://api.github.com/repos/samblau/pymatgen/tags","blobs_url":"https://api.github.com/repos/samblau/pymatgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samblau/pymatgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samblau/pymatgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/samblau/pymatgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samblau/pymatgen/statuses/{sha}","languages_url":"https://api.github.com/repos/samblau/pymatgen/languages","stargazers_url":"https://api.github.com/repos/samblau/pymatgen/stargazers","contributors_url":"https://api.github.com/repos/samblau/pymatgen/contributors","subscribers_url":"https://api.github.com/repos/samblau/pymatgen/subscribers","subscription_url":"https://api.github.com/repos/samblau/pymatgen/subscription","commits_url":"https://api.github.com/repos/samblau/pymatgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/samblau/pymatgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/samblau/pymatgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/samblau/pymatgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/samblau/pymatgen/contents/{+path}","compare_url":"https://api.github.com/repos/samblau/pymatgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samblau/pymatgen/merges","archive_url":"https://api.github.com/repos/samblau/pymatgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samblau/pymatgen/downloads","issues_url":"https://api.github.com/repos/samblau/pymatgen/issues{/number}","pulls_url":"https://api.github.com/repos/samblau/pymatgen/pulls{/number}","milestones_url":"https://api.github.com/repos/samblau/pymatgen/milestones{/number}","notifications_url":"https://api.github.com/repos/samblau/pymatgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samblau/pymatgen/labels{/name}","releases_url":"https://api.github.com/repos/samblau/pymatgen/releases{/id}","deployments_url":"https://api.github.com/repos/samblau/pymatgen/deployments","created_at":"2018-01-31T21:55:22Z","updated_at":"2018-08-22T22:09:15Z","pushed_at":"2018-09-11T23:30:38Z","git_url":"git://github.com/samblau/pymatgen.git","ssh_url":"git@github.com:samblau/pymatgen.git","clone_url":"https://github.com/samblau/pymatgen.git","svn_url":"https://github.com/samblau/pymatgen","homepage":"http://www.pymatgen.org","size":492076,"stargazers_count":0,"watchers_count":0,"language":"Propeller Spin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samblau/pymatgen/pulls/6"},"html":{"href":"https://github.com/samblau/pymatgen/pull/6"},"issue":{"href":"https://api.github.com/repos/samblau/pymatgen/issues/6"},"comments":{"href":"https://api.github.com/repos/samblau/pymatgen/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/samblau/pymatgen/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/samblau/pymatgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samblau/pymatgen/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/samblau/pymatgen/statuses/6773697211d1627852df0f150942cbe4a6436f63"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"samblau","id":7431223,"node_id":"MDQ6VXNlcjc0MzEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/7431223?v=4","gravatar_id":"","url":"https://api.github.com/users/samblau","html_url":"https://github.com/samblau","followers_url":"https://api.github.com/users/samblau/followers","following_url":"https://api.github.com/users/samblau/following{/other_user}","gists_url":"https://api.github.com/users/samblau/gists{/gist_id}","starred_url":"https://api.github.com/users/samblau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samblau/subscriptions","organizations_url":"https://api.github.com/users/samblau/orgs","repos_url":"https://api.github.com/users/samblau/repos","events_url":"https://api.github.com/users/samblau/events{/privacy}","received_events_url":"https://api.github.com/users/samblau/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":103,"deletions":81,"changed_files":2}}
{"actor":{"display_login":"samblau"}}