{"action":"created","issue":{"url":"https://api.github.com/repos/react-community/react-native-maps/issues/2396","repository_url":"https://api.github.com/repos/react-community/react-native-maps","labels_url":"https://api.github.com/repos/react-community/react-native-maps/issues/2396/labels{/name}","comments_url":"https://api.github.com/repos/react-community/react-native-maps/issues/2396/comments","events_url":"https://api.github.com/repos/react-community/react-native-maps/issues/2396/events","html_url":"https://github.com/react-community/react-native-maps/pull/2396","id":344261194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjk4ODM4","number":2396,"title":"Enable custom configuration for iOS maps","user":{"login":"wbyoung","id":57162,"node_id":"MDQ6VXNlcjU3MTYy","avatar_url":"https://avatars1.githubusercontent.com/u/57162?v=4","gravatar_id":"","url":"https://api.github.com/users/wbyoung","html_url":"https://github.com/wbyoung","followers_url":"https://api.github.com/users/wbyoung/followers","following_url":"https://api.github.com/users/wbyoung/following{/other_user}","gists_url":"https://api.github.com/users/wbyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/wbyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbyoung/subscriptions","organizations_url":"https://api.github.com/users/wbyoung/orgs","repos_url":"https://api.github.com/users/wbyoung/repos","events_url":"https://api.github.com/users/wbyoung/events{/privacy}","received_events_url":"https://api.github.com/users/wbyoung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-07-25T01:44:19Z","updated_at":"2018-08-23T09:10:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/react-community/react-native-maps/pulls/2396","html_url":"https://github.com/react-community/react-native-maps/pull/2396","diff_url":"https://github.com/react-community/react-native-maps/pull/2396.diff","patch_url":"https://github.com/react-community/react-native-maps/pull/2396.patch"},"body":"This allows setting up the library to work with Google Maps on iOS via `react-native link` instead of only via CocoaPods.\r\n\r\nBecause Google-Maps-iOS-Utils is not distributed as a binary (at this time), it disables functionality that depends on this library and raises an exception that points to the reason why there's a problem.\r\n\r\nAdditionally:\r\n\r\n- A missing file has been added back into the AirMaps.xcodeproj project.\r\n- The use of `Google-Maps-iOS-Utils` is now based on conditional configuration as well.\r\n\r\n### Does any other open PR do the same thing?\r\n\r\nYes, in a sense. https://github.com/react-community/react-native-maps/pull/2310 is related, and I believe it should be closed in favor of this request.\r\n\r\n### What issue is this PR fixing?\r\n\r\nhttps://github.com/react-community/react-native-maps/issues/2159, https://github.com/react-community/react-native-maps/issues/2270, https://github.com/react-community/react-native-maps/issues/2289, https://github.com/react-community/react-native-maps/issues/2066 (for users who are upgrading from an older version & perhaps others).\r\n\r\n### How did you test this PR?\r\n\r\nI tried using it with and without the included script being run to ensure that it compiles and links properly. I did not, however, test it with CocoaPods and will request that someone who has that configured ensure that everything still works as expected with Google Maps enabled (and without) when using CocoaPods.\r\n"},"comment":{"url":"https://api.github.com/repos/react-community/react-native-maps/issues/comments/415347314","html_url":"https://github.com/react-community/react-native-maps/pull/2396#issuecomment-415347314","issue_url":"https://api.github.com/repos/react-community/react-native-maps/issues/2396","id":415347314,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTM0NzMxNA==","user":{"login":"chrise86","id":616956,"node_id":"MDQ6VXNlcjYxNjk1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/616956?v=4","gravatar_id":"","url":"https://api.github.com/users/chrise86","html_url":"https://github.com/chrise86","followers_url":"https://api.github.com/users/chrise86/followers","following_url":"https://api.github.com/users/chrise86/following{/other_user}","gists_url":"https://api.github.com/users/chrise86/gists{/gist_id}","starred_url":"https://api.github.com/users/chrise86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrise86/subscriptions","organizations_url":"https://api.github.com/users/chrise86/orgs","repos_url":"https://api.github.com/users/chrise86/repos","events_url":"https://api.github.com/users/chrise86/events{/privacy}","received_events_url":"https://api.github.com/users/chrise86/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T09:10:19Z","updated_at":"2018-08-23T09:10:19Z","author_association":"NONE","body":"@wbyoung I tried this and it all compiles and runs fine, but when trying to use a marker it produces the following error:\r\n\r\n```\r\nInvariant Violation: Invariant Violation: requireNativeComponent:\"AIRMapMarker\" was not found in the UIManager.\r\n```"}}
{"actor":{"display_login":"chrise86"}}