{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/242559964","pull_request_review_id":186097554,"id":242559964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjU1OTk2NA==","diff_hunk":"@@ -25,16 +25,9 @@ exports[`ShortcutsModal renders when enabled 1`] = `\n           <span>\n             <span\n               className=\"keystroke\"\n-              key=\"Ctrl\"\n+              key=\"Ctrl+B\"","path":"src/components/test/__snapshots__/ShortcutsModal.spec.js.snap","position":5,"original_position":5,"commit_id":"9d0688fe4a537245e3fc40e9eca19c6b9f5ef9b0","original_commit_id":"9d0688fe4a537245e3fc40e9eca19c6b9f5ef9b0","user":{"login":"bomsy","id":792924,"node_id":"MDQ6VXNlcjc5MjkyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/792924?v=4","gravatar_id":"","url":"https://api.github.com/users/bomsy","html_url":"https://github.com/bomsy","followers_url":"https://api.github.com/users/bomsy/followers","following_url":"https://api.github.com/users/bomsy/following{/other_user}","gists_url":"https://api.github.com/users/bomsy/gists{/gist_id}","starred_url":"https://api.github.com/users/bomsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bomsy/subscriptions","organizations_url":"https://api.github.com/users/bomsy/orgs","repos_url":"https://api.github.com/users/bomsy/repos","events_url":"https://api.github.com/users/bomsy/events{/privacy}","received_events_url":"https://api.github.com/users/bomsy/received_events","type":"User","site_admin":false},"body":"sure ... having a look","created_at":"2018-12-18T14:35:41Z","updated_at":"2018-12-18T14:35:41Z","html_url":"https://github.com/devtools-html/debugger.html/pull/7507#discussion_r242559964","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/242559964"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/7507#discussion_r242559964"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507"}},"in_reply_to_id":242420799},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507","id":238632953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjMyOTUz","html_url":"https://github.com/devtools-html/debugger.html/pull/7507","diff_url":"https://github.com/devtools-html/debugger.html/pull/7507.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/7507.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/7507","number":7507,"state":"open","locked":false,"title":"Add a + notation in between shortcut labels","user":{"login":"Art-Vanderlay","id":9763064,"node_id":"MDQ6VXNlcjk3NjMwNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9763064?v=4","gravatar_id":"","url":"https://api.github.com/users/Art-Vanderlay","html_url":"https://github.com/Art-Vanderlay","followers_url":"https://api.github.com/users/Art-Vanderlay/followers","following_url":"https://api.github.com/users/Art-Vanderlay/following{/other_user}","gists_url":"https://api.github.com/users/Art-Vanderlay/gists{/gist_id}","starred_url":"https://api.github.com/users/Art-Vanderlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Art-Vanderlay/subscriptions","organizations_url":"https://api.github.com/users/Art-Vanderlay/orgs","repos_url":"https://api.github.com/users/Art-Vanderlay/repos","events_url":"https://api.github.com/users/Art-Vanderlay/events{/privacy}","received_events_url":"https://api.github.com/users/Art-Vanderlay/received_events","type":"User","site_admin":false},"body":"Fixes #7492 \r\n\r\nHere's the Pull Request Doc\r\nhttps://firefox-dev.tools/debugger.html/docs/pull-requests.html\r\n\r\n### Summary of Changes\r\n\r\nReplaced empty spaces in `formatKeyShortcut` function with '+' notation.\r\n\r\n### Test Plan\r\n\r\n- Start debugger locally with `yarn start`\r\n- Open http://localhost:8000 and launch Firefox\r\n\r\nHere's the Debugger's Testing doc\r\nhttps://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.\r\nFeel free to improve it!\r\n\r\n### Screenshots/Videos (OPTIONAL)\r\n\r\n![cropdebugger](https://user-images.githubusercontent.com/9763064/49989272-cd260680-ffcd-11e8-87c8-a97436125006.png)","created_at":"2018-12-14T07:28:52Z","updated_at":"2018-12-18T14:35:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9cc7cd6b7d62652603d3f7d0400f6aa7d46e5bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731965110,"node_id":"MDU6TGFiZWw3MzE5NjUxMTA=","url":"https://api.github.com/repos/devtools-html/debugger.html/labels/pr-wip","name":"pr-wip","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/7507/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/9d0688fe4a537245e3fc40e9eca19c6b9f5ef9b0","head":{"label":"Art-Vanderlay:Test","ref":"Test","sha":"9d0688fe4a537245e3fc40e9eca19c6b9f5ef9b0","user":{"login":"Art-Vanderlay","id":9763064,"node_id":"MDQ6VXNlcjk3NjMwNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9763064?v=4","gravatar_id":"","url":"https://api.github.com/users/Art-Vanderlay","html_url":"https://github.com/Art-Vanderlay","followers_url":"https://api.github.com/users/Art-Vanderlay/followers","following_url":"https://api.github.com/users/Art-Vanderlay/following{/other_user}","gists_url":"https://api.github.com/users/Art-Vanderlay/gists{/gist_id}","starred_url":"https://api.github.com/users/Art-Vanderlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Art-Vanderlay/subscriptions","organizations_url":"https://api.github.com/users/Art-Vanderlay/orgs","repos_url":"https://api.github.com/users/Art-Vanderlay/repos","events_url":"https://api.github.com/users/Art-Vanderlay/events{/privacy}","received_events_url":"https://api.github.com/users/Art-Vanderlay/received_events","type":"User","site_admin":false},"repo":{"id":161729612,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3Mjk2MTI=","name":"debugger.html","full_name":"Art-Vanderlay/debugger.html","private":false,"owner":{"login":"Art-Vanderlay","id":9763064,"node_id":"MDQ6VXNlcjk3NjMwNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/9763064?v=4","gravatar_id":"","url":"https://api.github.com/users/Art-Vanderlay","html_url":"https://github.com/Art-Vanderlay","followers_url":"https://api.github.com/users/Art-Vanderlay/followers","following_url":"https://api.github.com/users/Art-Vanderlay/following{/other_user}","gists_url":"https://api.github.com/users/Art-Vanderlay/gists{/gist_id}","starred_url":"https://api.github.com/users/Art-Vanderlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Art-Vanderlay/subscriptions","organizations_url":"https://api.github.com/users/Art-Vanderlay/orgs","repos_url":"https://api.github.com/users/Art-Vanderlay/repos","events_url":"https://api.github.com/users/Art-Vanderlay/events{/privacy}","received_events_url":"https://api.github.com/users/Art-Vanderlay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Art-Vanderlay/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":true,"url":"https://api.github.com/repos/Art-Vanderlay/debugger.html","forks_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/forks","keys_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/teams","hooks_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/events","assignees_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/tags","blobs_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/languages","stargazers_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/subscription","commits_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/merges","archive_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/downloads","issues_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/Art-Vanderlay/debugger.html/deployments","created_at":"2018-12-14T04:01:24Z","updated_at":"2018-12-14T04:01:29Z","pushed_at":"2018-12-18T05:46:07Z","git_url":"git://github.com/Art-Vanderlay/debugger.html.git","ssh_url":"git@github.com:Art-Vanderlay/debugger.html.git","clone_url":"https://github.com/Art-Vanderlay/debugger.html.git","svn_url":"https://github.com/Art-Vanderlay/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":30238,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"95da2351f2f3629924c41ba7eaf05d110a48d8c3","user":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"node_id":"MDEwOlJlcG9zaXRvcnk1NDU4NTQxOA==","name":"debugger.html","full_name":"devtools-html/debugger.html","private":false,"owner":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2018-12-18T13:04:00Z","pushed_at":"2018-12-18T14:14:48Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"git@github.com:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":30264,"stargazers_count":4123,"watchers_count":4123,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":744,"mirror_url":null,"archived":false,"open_issues_count":253,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":744,"open_issues":253,"watchers":4123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/7507"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/7507"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/7507/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/7507/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/9d0688fe4a537245e3fc40e9eca19c6b9f5ef9b0"}},"author_association":"NONE"}}
{"actor":{"display_login":"bomsy"}}