{"push_id":3115408872,"size":8,"distinct_size":1,"ref":"refs/heads/master","head":"f29543ca5d015c8bf3f6ff0d905892bbf87562e2","before":"1bc6191ec6819eb291b338bdea7823f6d057bc01","commits":[{"sha":"587f8a5b72824b73b0543a33841a6437ceb0b981","author":{"name":"Martin Thomson","email":"cbb634a356687f1e0c945fac477c747c51f612e2@gmail.com"},"message":"Refactor DetectLostPackets\n\nThis had a couple of problems that I think this addresses, and some that\nit doesn't.\n\nThe first is that it isn't clear what is being iterated over and in what\norder.  I think that the point here is to iterate over sent_packets,\nstarting with the oldest.  Correct me if that is wrong.  In any case,\nthis change doesn't assume an iteration order.  The only reason the\niteration order is important is in setting loss_time, which needs to be\nthe earliest time (assuming that I'm right).\n\nThis simplifies the function, by setting thresholds at the top and doing\na simple comparison.\n\nI've added a note about loss_time potentially being in the past.\n\nThe problem that remains is that this appeared to iterate only over\npackets that have a packet number less than the largest acknowledged.\nI've added that condition to the loop, but I don't think that it's\nright.  I think that it's just redundant - and while an implementation\nmight stop its iteration at the largest acknowledged to save cycles,\nthis function will operate the same without the extra check.\n\nIt's also not clear whether the greater than comparisons here were\ncorrect.  If you assume that firing of the timer cannot take zero time,\nthis is never an issue, but with discrete intervals on time values,\nthat's not always going to happen.  As setup, this code could be called\nat exactly loss_time for a packet, in which case that packet will not be\ndeclared lost.  I think that this wants >= in the time comparison for\nthat reason.\n\nFinally, should the early retransmit timer be configurable?  Should it\nbe set based on kTimeReorderingThreshold?","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/587f8a5b72824b73b0543a33841a6437ceb0b981"},{"sha":"29f5fdf72186f71d0d34d487dac8b18a30584e13","author":{"name":"Martin Thomson","email":"cbb634a356687f1e0c945fac477c747c51f612e2@gmail.com"},"message":"Review changes","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/29f5fdf72186f71d0d34d487dac8b18a30584e13"},{"sha":"db6929a33d31de152198f6560aad31a0ed53f359","author":{"name":"Martin Thomson","email":"cbb634a356687f1e0c945fac477c747c51f612e2@gmail.com"},"message":"Use <= for cutoffs","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/db6929a33d31de152198f6560aad31a0ed53f359"},{"sha":"02a164ee1e8e208e414896124c15c627f79dcea8","author":{"name":"Jana Iyengar","email":"2736a23aa6607986a927784699e89fa4f898aac2@gmail.com"},"message":"Fixes some broken bits","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/02a164ee1e8e208e414896124c15c627f79dcea8"},{"sha":"71e06d391739652c1ed965873f530bb496f8aecd","author":{"name":"Jana Iyengar","email":"2736a23aa6607986a927784699e89fa4f898aac2@gmail.com"},"message":"lint","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/71e06d391739652c1ed965873f530bb496f8aecd"},{"sha":"cdaef0e2036dc9da2c972a9ec0d2c795559c3206","author":{"name":"Jana Iyengar","email":"2736a23aa6607986a927784699e89fa4f898aac2@gmail.com"},"message":"cleanup and consistent parens","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/cdaef0e2036dc9da2c972a9ec0d2c795559c3206"},{"sha":"e50cf51845fdfb8357e974bdc2ad4134d3829663","author":{"name":"ianswett","email":"d0beebe1cc6bf26271a9be3677d3be973038c6b8@users.noreply.github.com"},"message":"Update draft-ietf-quic-recovery.md\n\nMove and update Martin's comments","distinct":false,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/e50cf51845fdfb8357e974bdc2ad4134d3829663"},{"sha":"f29543ca5d015c8bf3f6ff0d905892bbf87562e2","author":{"name":"janaiyengar","email":"2736a23aa6607986a927784699e89fa4f898aac2@gmail.com"},"message":"Merge pull request #2066 from quicwg/refactor-loss_time\n\nRefactor DetectLostPackets","distinct":true,"url":"https://api.github.com/repos/quicwg/base-drafts/commits/f29543ca5d015c8bf3f6ff0d905892bbf87562e2"}]}
{"actor":{"display_login":"janaiyengar"}}