{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/197356072","pull_request_review_id":131084725,"id":197356072,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzM1NjA3Mg==","diff_hunk":"@@ -67,6 +67,23 @@ if(WITH_MGR)\n   elseif(NOT WITH_PYTHON3 AND MGR_PYTHON_VERSION_MAJOR EQUAL 3)\n     message(FATAL_ERROR \"mgr plugins require python3 binding\")\n   endif()\n+\n+  if (USE_OPENSSL)\n+    execute_process(\n+      COMMAND ${PYTHON${PYTHON_VERSION}_EXECUTABLE} -c \"import ssl; print('.'.join(map(str,ssl.OPENSSL_VERSION_INFO[0:3])))\"\n+      RESULT_VARIABLE PYSSL_RESULT\n+      OUTPUT_VARIABLE PYSSL_VER\n+      ERROR_QUIET\n+      )\n+    if (NOT ${PYSSL_RESULT})\n+      if (NOT (OPENSSL_VERSION VERSION_EQUAL PYSSL_VER))\n+        message(FATAL_ERROR \"Python and Ceph link to different openssl versions: ${PYSSL_VER} vs ${OPENSSL_VERSION}\")\n+      endif()\n+    else()\n+      message(WARNING \"could not determine ssl version of python crypto lib\")","path":"src/pybind/CMakeLists.txt","position":17,"original_position":17,"commit_id":"c739536063d20efca0bbf57477dfe5b61cc4fae7","original_commit_id":"c739536063d20efca0bbf57477dfe5b61cc4fae7","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"nit,\r\n\r\n> could not determine the OpenSSL version used by python ssl module\r\n\r\nalso, could make this `FATAL`, as per https://docs.python.org/2/library/ssl.html and https://docs.python.org/3/library/ssl.html. we *should* always have zero retcode of the command line above.","created_at":"2018-06-22T07:01:01Z","updated_at":"2018-06-22T07:01:01Z","html_url":"https://github.com/ceph/ceph/pull/22659#discussion_r197356072","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/22659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/197356072"},"html":{"href":"https://github.com/ceph/ceph/pull/22659#discussion_r197356072"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22659"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/22659","id":196420848,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDIwODQ4","html_url":"https://github.com/ceph/ceph/pull/22659","diff_url":"https://github.com/ceph/ceph/pull/22659.diff","patch_url":"https://github.com/ceph/ceph/pull/22659.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/22659","number":22659,"state":"open","locked":false,"title":"build: mgr: check for python's ssl version linkage","user":{"login":"theanalyst","id":1433152,"node_id":"MDQ6VXNlcjE0MzMxNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"body":"If multiple openssl versions are present, it can so happen that system python\r\nlibrary is linked to an old openssl and openssl development headers point to a\r\nnew openssl. This would later cause segmentation fault for ceph-mgr when ssl\r\nmodule is used for commands like self signed certificate as ceph-mgr itself\r\nwould've loaded a different openssl version already, due to the recent msgr change\r\nmoving from NSS to openssl. Detect this condition at build time so this\r\nincompatibility can be fixed\r\n\r\nFixes: http://tracker.ceph.com/issues/24282\r\nSigned-off-by: Abhishek Lekshmanan <abhishek@suse.com>","created_at":"2018-06-21T11:28:45Z","updated_at":"2018-06-22T07:01:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bb31709a595f80d184a9ec1d69eaa516fd0cef6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cbodley","id":1928002,"node_id":"MDQ6VXNlcjE5MjgwMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1928002?v=4","gravatar_id":"","url":"https://api.github.com/users/cbodley","html_url":"https://github.com/cbodley","followers_url":"https://api.github.com/users/cbodley/followers","following_url":"https://api.github.com/users/cbodley/following{/other_user}","gists_url":"https://api.github.com/users/cbodley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbodley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbodley/subscriptions","organizations_url":"https://api.github.com/users/cbodley/orgs","repos_url":"https://api.github.com/users/cbodley/repos","events_url":"https://api.github.com/users/cbodley/events{/privacy}","received_events_url":"https://api.github.com/users/cbodley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":199293022,"node_id":"MDU6TGFiZWwxOTkyOTMwMjI=","url":"https://api.github.com/repos/ceph/ceph/labels/build/ops","name":"build/ops","color":"fcff00","default":false},{"id":454906768,"node_id":"MDU6TGFiZWw0NTQ5MDY3Njg=","url":"https://api.github.com/repos/ceph/ceph/labels/mgr","name":"mgr","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/22659/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/22659/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/22659/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/c739536063d20efca0bbf57477dfe5b61cc4fae7","head":{"label":"theanalyst:cmake-pybind-ssl","ref":"cmake-pybind-ssl","sha":"c739536063d20efca0bbf57477dfe5b61cc4fae7","user":{"login":"theanalyst","id":1433152,"node_id":"MDQ6VXNlcjE0MzMxNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"repo":{"id":21639729,"node_id":"MDEwOlJlcG9zaXRvcnkyMTYzOTcyOQ==","name":"ceph","full_name":"theanalyst/ceph","owner":{"login":"theanalyst","id":1433152,"node_id":"MDQ6VXNlcjE0MzMxNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theanalyst/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/theanalyst/ceph","forks_url":"https://api.github.com/repos/theanalyst/ceph/forks","keys_url":"https://api.github.com/repos/theanalyst/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theanalyst/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theanalyst/ceph/teams","hooks_url":"https://api.github.com/repos/theanalyst/ceph/hooks","issue_events_url":"https://api.github.com/repos/theanalyst/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/theanalyst/ceph/events","assignees_url":"https://api.github.com/repos/theanalyst/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/theanalyst/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/theanalyst/ceph/tags","blobs_url":"https://api.github.com/repos/theanalyst/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theanalyst/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theanalyst/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/theanalyst/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theanalyst/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/theanalyst/ceph/languages","stargazers_url":"https://api.github.com/repos/theanalyst/ceph/stargazers","contributors_url":"https://api.github.com/repos/theanalyst/ceph/contributors","subscribers_url":"https://api.github.com/repos/theanalyst/ceph/subscribers","subscription_url":"https://api.github.com/repos/theanalyst/ceph/subscription","commits_url":"https://api.github.com/repos/theanalyst/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/theanalyst/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/theanalyst/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/theanalyst/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/theanalyst/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/theanalyst/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theanalyst/ceph/merges","archive_url":"https://api.github.com/repos/theanalyst/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theanalyst/ceph/downloads","issues_url":"https://api.github.com/repos/theanalyst/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/theanalyst/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/theanalyst/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/theanalyst/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theanalyst/ceph/labels{/name}","releases_url":"https://api.github.com/repos/theanalyst/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/theanalyst/ceph/deployments","created_at":"2014-07-09T04:45:38Z","updated_at":"2018-03-19T17:58:01Z","pushed_at":"2018-06-21T11:53:51Z","git_url":"git://github.com/theanalyst/ceph.git","ssh_url":"git@github.com:theanalyst/ceph.git","clone_url":"https://github.com/theanalyst/ceph.git","svn_url":"https://github.com/theanalyst/ceph","homepage":"http://ceph.com","size":299434,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"80a51c9714a621a5bc6bb05b8e15244fd43994ec","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-06-22T05:51:44Z","pushed_at":"2018-06-22T06:02:18Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":291653,"stargazers_count":4637,"watchers_count":4637,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2491,"mirror_url":null,"archived":false,"open_issues_count":669,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2491,"open_issues":669,"watchers":4637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22659"},"html":{"href":"https://github.com/ceph/ceph/pull/22659"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/22659"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/22659/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22659/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22659/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/c739536063d20efca0bbf57477dfe5b61cc4fae7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tchaikov"}}