{"action":"created","comment":{"url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/comments/185377776","pull_request_review_id":116752824,"id":185377776,"diff_hunk":"@@ -3,15 +3,21 @@\n from setuptools import setup, find_packages\n \n here = os.path.abspath(os.path.dirname(__file__))\n-README = open(os.path.join(here, 'README.rst')).read()\n-CHANGES = open(os.path.join(here, 'CHANGES.txt')).read()\n+try:\n+    with open(os.path.join(here, 'README.rst')) as f:\n+        README = f.read()\n+    with open(os.path.join(here, 'CHANGES.txt')) as f:\n+        CHANGES = f.read()\n+except IOError:\n+    README = CHANGES = ''\n \n requires = [\n     'pyramid>=1.3a9',","path":"setup.py","position":15,"original_position":15,"commit_id":"13f5a7c485a5547588a84e4ed3da653aa0d2864f","original_commit_id":"13f5a7c485a5547588a84e4ed3da653aa0d2864f","user":{"login":"bertjwregeer","id":649426,"avatar_url":"https://avatars3.githubusercontent.com/u/649426?v=4","gravatar_id":"","url":"https://api.github.com/users/bertjwregeer","html_url":"https://github.com/bertjwregeer","followers_url":"https://api.github.com/users/bertjwregeer/followers","following_url":"https://api.github.com/users/bertjwregeer/following{/other_user}","gists_url":"https://api.github.com/users/bertjwregeer/gists{/gist_id}","starred_url":"https://api.github.com/users/bertjwregeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertjwregeer/subscriptions","organizations_url":"https://api.github.com/users/bertjwregeer/orgs","repos_url":"https://api.github.com/users/bertjwregeer/repos","events_url":"https://api.github.com/users/bertjwregeer/events{/privacy}","received_events_url":"https://api.github.com/users/bertjwregeer/received_events","type":"User","site_admin":false},"body":"Please update pin to not rely on alpha releases.","created_at":"2018-05-02T01:51:54Z","updated_at":"2018-05-02T01:51:54Z","html_url":"https://github.com/Pylons/pyramid_ldap/pull/21#discussion_r185377776","pull_request_url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/comments/185377776"},"html":{"href":"https://github.com/Pylons/pyramid_ldap/pull/21#discussion_r185377776"},"pull_request":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21","id":185294029,"html_url":"https://github.com/Pylons/pyramid_ldap/pull/21","diff_url":"https://github.com/Pylons/pyramid_ldap/pull/21.diff","patch_url":"https://github.com/Pylons/pyramid_ldap/pull/21.patch","issue_url":"https://api.github.com/repos/Pylons/pyramid_ldap/issues/21","number":21,"state":"open","locked":false,"title":"Python3 compat","user":{"login":"ericrasmussen","id":1214815,"avatar_url":"https://avatars1.githubusercontent.com/u/1214815?v=4","gravatar_id":"","url":"https://api.github.com/users/ericrasmussen","html_url":"https://github.com/ericrasmussen","followers_url":"https://api.github.com/users/ericrasmussen/followers","following_url":"https://api.github.com/users/ericrasmussen/following{/other_user}","gists_url":"https://api.github.com/users/ericrasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrasmussen/subscriptions","organizations_url":"https://api.github.com/users/ericrasmussen/orgs","repos_url":"https://api.github.com/users/ericrasmussen/repos","events_url":"https://api.github.com/users/ericrasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/ericrasmussen/received_events","type":"User","site_admin":false},"body":"this PR adds python 2/3 compatibility and properly escapes the login and password values in the authenticate method","created_at":"2018-05-01T22:39:09Z","updated_at":"2018-05-02T01:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69f8f814dbb9a772b8070245fc5f9f59100ab826","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pylons/pyramid_ldap/issues/21/comments","statuses_url":"https://api.github.com/repos/Pylons/pyramid_ldap/statuses/13f5a7c485a5547588a84e4ed3da653aa0d2864f","head":{"label":"ericrasmussen:python3-compat","ref":"python3-compat","sha":"13f5a7c485a5547588a84e4ed3da653aa0d2864f","user":{"login":"ericrasmussen","id":1214815,"avatar_url":"https://avatars1.githubusercontent.com/u/1214815?v=4","gravatar_id":"","url":"https://api.github.com/users/ericrasmussen","html_url":"https://github.com/ericrasmussen","followers_url":"https://api.github.com/users/ericrasmussen/followers","following_url":"https://api.github.com/users/ericrasmussen/following{/other_user}","gists_url":"https://api.github.com/users/ericrasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrasmussen/subscriptions","organizations_url":"https://api.github.com/users/ericrasmussen/orgs","repos_url":"https://api.github.com/users/ericrasmussen/repos","events_url":"https://api.github.com/users/ericrasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/ericrasmussen/received_events","type":"User","site_admin":false},"repo":{"id":130915506,"name":"pyramid_ldap","full_name":"ericrasmussen/pyramid_ldap","owner":{"login":"ericrasmussen","id":1214815,"avatar_url":"https://avatars1.githubusercontent.com/u/1214815?v=4","gravatar_id":"","url":"https://api.github.com/users/ericrasmussen","html_url":"https://github.com/ericrasmussen","followers_url":"https://api.github.com/users/ericrasmussen/followers","following_url":"https://api.github.com/users/ericrasmussen/following{/other_user}","gists_url":"https://api.github.com/users/ericrasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrasmussen/subscriptions","organizations_url":"https://api.github.com/users/ericrasmussen/orgs","repos_url":"https://api.github.com/users/ericrasmussen/repos","events_url":"https://api.github.com/users/ericrasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/ericrasmussen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericrasmussen/pyramid_ldap","description":"LDAP authentication policy for Pyramid","fork":true,"url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap","forks_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/forks","keys_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/teams","hooks_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/hooks","issue_events_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/issues/events{/number}","events_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/events","assignees_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/assignees{/user}","branches_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/branches{/branch}","tags_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/tags","blobs_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/languages","stargazers_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/stargazers","contributors_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/contributors","subscribers_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/subscribers","subscription_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/subscription","commits_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/contents/{+path}","compare_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/merges","archive_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/downloads","issues_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/issues{/number}","pulls_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/labels{/name}","releases_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/releases{/id}","deployments_url":"https://api.github.com/repos/ericrasmussen/pyramid_ldap/deployments","created_at":"2018-04-24T21:25:00Z","updated_at":"2018-04-24T21:25:02Z","pushed_at":"2018-05-01T23:19:37Z","git_url":"git://github.com/ericrasmussen/pyramid_ldap.git","ssh_url":"git@github.com:ericrasmussen/pyramid_ldap.git","clone_url":"https://github.com/ericrasmussen/pyramid_ldap.git","svn_url":"https://github.com/ericrasmussen/pyramid_ldap","homepage":"","size":60,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pylons:master","ref":"master","sha":"0ee977810cad269b4e977e08e5598ea8409dc963","user":{"login":"Pylons","id":452227,"avatar_url":"https://avatars1.githubusercontent.com/u/452227?v=4","gravatar_id":"","url":"https://api.github.com/users/Pylons","html_url":"https://github.com/Pylons","followers_url":"https://api.github.com/users/Pylons/followers","following_url":"https://api.github.com/users/Pylons/following{/other_user}","gists_url":"https://api.github.com/users/Pylons/gists{/gist_id}","starred_url":"https://api.github.com/users/Pylons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pylons/subscriptions","organizations_url":"https://api.github.com/users/Pylons/orgs","repos_url":"https://api.github.com/users/Pylons/repos","events_url":"https://api.github.com/users/Pylons/events{/privacy}","received_events_url":"https://api.github.com/users/Pylons/received_events","type":"Organization","site_admin":false},"repo":{"id":3875401,"name":"pyramid_ldap","full_name":"Pylons/pyramid_ldap","owner":{"login":"Pylons","id":452227,"avatar_url":"https://avatars1.githubusercontent.com/u/452227?v=4","gravatar_id":"","url":"https://api.github.com/users/Pylons","html_url":"https://github.com/Pylons","followers_url":"https://api.github.com/users/Pylons/followers","following_url":"https://api.github.com/users/Pylons/following{/other_user}","gists_url":"https://api.github.com/users/Pylons/gists{/gist_id}","starred_url":"https://api.github.com/users/Pylons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pylons/subscriptions","organizations_url":"https://api.github.com/users/Pylons/orgs","repos_url":"https://api.github.com/users/Pylons/repos","events_url":"https://api.github.com/users/Pylons/events{/privacy}","received_events_url":"https://api.github.com/users/Pylons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pylons/pyramid_ldap","description":"LDAP authentication policy for Pyramid","fork":false,"url":"https://api.github.com/repos/Pylons/pyramid_ldap","forks_url":"https://api.github.com/repos/Pylons/pyramid_ldap/forks","keys_url":"https://api.github.com/repos/Pylons/pyramid_ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pylons/pyramid_ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pylons/pyramid_ldap/teams","hooks_url":"https://api.github.com/repos/Pylons/pyramid_ldap/hooks","issue_events_url":"https://api.github.com/repos/Pylons/pyramid_ldap/issues/events{/number}","events_url":"https://api.github.com/repos/Pylons/pyramid_ldap/events","assignees_url":"https://api.github.com/repos/Pylons/pyramid_ldap/assignees{/user}","branches_url":"https://api.github.com/repos/Pylons/pyramid_ldap/branches{/branch}","tags_url":"https://api.github.com/repos/Pylons/pyramid_ldap/tags","blobs_url":"https://api.github.com/repos/Pylons/pyramid_ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pylons/pyramid_ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pylons/pyramid_ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pylons/pyramid_ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pylons/pyramid_ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/Pylons/pyramid_ldap/languages","stargazers_url":"https://api.github.com/repos/Pylons/pyramid_ldap/stargazers","contributors_url":"https://api.github.com/repos/Pylons/pyramid_ldap/contributors","subscribers_url":"https://api.github.com/repos/Pylons/pyramid_ldap/subscribers","subscription_url":"https://api.github.com/repos/Pylons/pyramid_ldap/subscription","commits_url":"https://api.github.com/repos/Pylons/pyramid_ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pylons/pyramid_ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pylons/pyramid_ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pylons/pyramid_ldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pylons/pyramid_ldap/contents/{+path}","compare_url":"https://api.github.com/repos/Pylons/pyramid_ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pylons/pyramid_ldap/merges","archive_url":"https://api.github.com/repos/Pylons/pyramid_ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pylons/pyramid_ldap/downloads","issues_url":"https://api.github.com/repos/Pylons/pyramid_ldap/issues{/number}","pulls_url":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/Pylons/pyramid_ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/Pylons/pyramid_ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pylons/pyramid_ldap/labels{/name}","releases_url":"https://api.github.com/repos/Pylons/pyramid_ldap/releases{/id}","deployments_url":"https://api.github.com/repos/Pylons/pyramid_ldap/deployments","created_at":"2012-03-30T09:58:03Z","updated_at":"2017-02-20T19:54:59Z","pushed_at":"2018-05-01T23:19:38Z","git_url":"git://github.com/Pylons/pyramid_ldap.git","ssh_url":"git@github.com:Pylons/pyramid_ldap.git","clone_url":"https://github.com/Pylons/pyramid_ldap.git","svn_url":"https://github.com/Pylons/pyramid_ldap","homepage":"","size":49,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13,"open_issues":14,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21"},"html":{"href":"https://github.com/Pylons/pyramid_ldap/pull/21"},"issue":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/issues/21"},"comments":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Pylons/pyramid_ldap/statuses/13f5a7c485a5547588a84e4ed3da653aa0d2864f"}},"author_association":"NONE"}}
{"actor":{"display_login":"bertjwregeer"}}