{"action":"created","issue":{"url":"https://api.github.com/repos/nlopes/slack/issues/293","repository_url":"https://api.github.com/repos/nlopes/slack","labels_url":"https://api.github.com/repos/nlopes/slack/issues/293/labels{/name}","comments_url":"https://api.github.com/repos/nlopes/slack/issues/293/comments","events_url":"https://api.github.com/repos/nlopes/slack/issues/293/events","html_url":"https://github.com/nlopes/slack/pull/293","id":311435444,"number":293,"title":"Events API support","user":{"login":"ACollectionOfAtoms","id":7197998,"avatar_url":"https://avatars2.githubusercontent.com/u/7197998?v=4","gravatar_id":"","url":"https://api.github.com/users/ACollectionOfAtoms","html_url":"https://github.com/ACollectionOfAtoms","followers_url":"https://api.github.com/users/ACollectionOfAtoms/followers","following_url":"https://api.github.com/users/ACollectionOfAtoms/following{/other_user}","gists_url":"https://api.github.com/users/ACollectionOfAtoms/gists{/gist_id}","starred_url":"https://api.github.com/users/ACollectionOfAtoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACollectionOfAtoms/subscriptions","organizations_url":"https://api.github.com/users/ACollectionOfAtoms/orgs","repos_url":"https://api.github.com/users/ACollectionOfAtoms/repos","events_url":"https://api.github.com/users/ACollectionOfAtoms/events{/privacy}","received_events_url":"https://api.github.com/users/ACollectionOfAtoms/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-04-05T00:30:35Z","updated_at":"2018-05-08T20:14:51Z","closed_at":"2018-05-06T22:34:22Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nlopes/slack/pulls/293","html_url":"https://github.com/nlopes/slack/pull/293","diff_url":"https://github.com/nlopes/slack/pull/293.diff","patch_url":"https://github.com/nlopes/slack/pull/293.patch"},"body":"Here's another attempt at https://github.com/nlopes/slack/issues/94 (I started on this work before I realized https://github.com/nlopes/slack/pull/283 was open /shrug)\r\n\r\nI'll be honest I'm still learning Go! But I needed the Events API capability for a project and so thought I would share my work. \r\n\r\nWould GREATLY appreciate feedback (because you know, still learning Go). \r\n\r\nI tried to keep the API as similar as possible to parsing RTM events. \r\n\r\n@james-lawrence when you said in #94 :\r\n> - don't implement the handler, that is application dependent.\r\n> - do implement the data structures and utility functions to reduce the http handler to a few lines.\r\n\r\nI'm pretty sure I got the \"don't implement the handler\" part but not so sure about the second bullet point.\r\n\r\nAnyway there is an [EXAMPLE](https://github.com/nlopes/slack/compare/master...ACollectionOfAtoms:events-api?expand=1#diff-70197fda1fff6e1e38fedb4fb8f269faR15)\r\n\r\nI'm very open to refactoring as needed (as it's a Go-learning experience for me) and of course if this PR isn't up to snuff that's cool with me too; still would appreciate feedback. "},"comment":{"url":"https://api.github.com/repos/nlopes/slack/issues/comments/387528317","html_url":"https://github.com/nlopes/slack/pull/293#issuecomment-387528317","issue_url":"https://api.github.com/repos/nlopes/slack/issues/293","id":387528317,"user":{"login":"ACollectionOfAtoms","id":7197998,"avatar_url":"https://avatars2.githubusercontent.com/u/7197998?v=4","gravatar_id":"","url":"https://api.github.com/users/ACollectionOfAtoms","html_url":"https://github.com/ACollectionOfAtoms","followers_url":"https://api.github.com/users/ACollectionOfAtoms/followers","following_url":"https://api.github.com/users/ACollectionOfAtoms/following{/other_user}","gists_url":"https://api.github.com/users/ACollectionOfAtoms/gists{/gist_id}","starred_url":"https://api.github.com/users/ACollectionOfAtoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ACollectionOfAtoms/subscriptions","organizations_url":"https://api.github.com/users/ACollectionOfAtoms/orgs","repos_url":"https://api.github.com/users/ACollectionOfAtoms/repos","events_url":"https://api.github.com/users/ACollectionOfAtoms/events{/privacy}","received_events_url":"https://api.github.com/users/ACollectionOfAtoms/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T20:14:51Z","updated_at":"2018-05-08T20:14:51Z","author_association":"CONTRIBUTOR","body":"BTW @pa3ng @nac2791 @sjqnn and anyone else who was waiting for this PR to be merged, if you run into any issues with the Events API please feel free to open an issue and ping me in it! "}}
{"actor":{"display_login":"ACollectionOfAtoms"}}