{"action":"created","issue":{"url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/issues/18","repository_url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws","labels_url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/issues/18/comments","events_url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/issues/18/events","html_url":"https://github.com/Icinga/icingaweb2-module-aws/pull/18","id":306380249,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1ODM4NjY2","number":18,"title":"Fetch instance state (e.g. 'running'/'stopped') for EC2 instances.","user":{"login":"pprkut","id":56635,"node_id":"MDQ6VXNlcjU2NjM1","avatar_url":"https://avatars2.githubusercontent.com/u/56635?v=4","gravatar_id":"","url":"https://api.github.com/users/pprkut","html_url":"https://github.com/pprkut","followers_url":"https://api.github.com/users/pprkut/followers","following_url":"https://api.github.com/users/pprkut/following{/other_user}","gists_url":"https://api.github.com/users/pprkut/gists{/gist_id}","starred_url":"https://api.github.com/users/pprkut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pprkut/subscriptions","organizations_url":"https://api.github.com/users/pprkut/orgs","repos_url":"https://api.github.com/users/pprkut/repos","events_url":"https://api.github.com/users/pprkut/events{/privacy}","received_events_url":"https://api.github.com/users/pprkut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-19T09:06:08Z","updated_at":"2018-07-04T13:17:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/pulls/18","html_url":"https://github.com/Icinga/icingaweb2-module-aws/pull/18","diff_url":"https://github.com/Icinga/icingaweb2-module-aws/pull/18.diff","patch_url":"https://github.com/Icinga/icingaweb2-module-aws/pull/18.patch"},"body":"This is a similar solution to the one in #12, but a little simpler and more flexible.\r\nBy just storing the state name the user has the choice on what to do with that information.\r\nUsing the 'Replace' property modifier to replace 'running' with 'false', and then using the\r\n'MakeBoolean' property modifier to turn the values into booleans ('false' -> false and everything else to true),\r\nthe same behavior can be achieved as in #12."},"comment":{"url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/issues/comments/402476480","html_url":"https://github.com/Icinga/icingaweb2-module-aws/pull/18#issuecomment-402476480","issue_url":"https://api.github.com/repos/Icinga/icingaweb2-module-aws/issues/18","id":402476480,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjQ3NjQ4MA==","user":{"login":"marek-obuchowicz","id":712751,"node_id":"MDQ6VXNlcjcxMjc1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/712751?v=4","gravatar_id":"","url":"https://api.github.com/users/marek-obuchowicz","html_url":"https://github.com/marek-obuchowicz","followers_url":"https://api.github.com/users/marek-obuchowicz/followers","following_url":"https://api.github.com/users/marek-obuchowicz/following{/other_user}","gists_url":"https://api.github.com/users/marek-obuchowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-obuchowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-obuchowicz/subscriptions","organizations_url":"https://api.github.com/users/marek-obuchowicz/orgs","repos_url":"https://api.github.com/users/marek-obuchowicz/repos","events_url":"https://api.github.com/users/marek-obuchowicz/events{/privacy}","received_events_url":"https://api.github.com/users/marek-obuchowicz/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T13:17:11Z","updated_at":"2018-07-04T13:17:11Z","author_association":"NONE","body":"Is there anything preventing this PR from being merged? We find it not good that the \"terminated\" instances are still fetched and considered \"valid\", we have to wait until they get deleted by AWS (happens after an hour or more). This makes monitoring of autoscaling groups or another dynamic environments not optimal. With this PR we could filter out instances in \"Terminated\" state from being imported."}}
{"actor":{"display_login":"marek-obuchowicz"}}