{"action":"created","issue":{"url":"https://api.github.com/repos/etianen/django-reversion/issues/742","repository_url":"https://api.github.com/repos/etianen/django-reversion","labels_url":"https://api.github.com/repos/etianen/django-reversion/issues/742/labels{/name}","comments_url":"https://api.github.com/repos/etianen/django-reversion/issues/742/comments","events_url":"https://api.github.com/repos/etianen/django-reversion/issues/742/events","html_url":"https://github.com/etianen/django-reversion/pull/742","id":343164185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODkzMDI5","number":742,"title":"Add extra fields to create_revision interface","user":{"login":"massover","id":7320967,"node_id":"MDQ6VXNlcjczMjA5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/7320967?v=4","gravatar_id":"","url":"https://api.github.com/users/massover","html_url":"https://github.com/massover","followers_url":"https://api.github.com/users/massover/followers","following_url":"https://api.github.com/users/massover/following{/other_user}","gists_url":"https://api.github.com/users/massover/gists{/gist_id}","starred_url":"https://api.github.com/users/massover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massover/subscriptions","organizations_url":"https://api.github.com/users/massover/orgs","repos_url":"https://api.github.com/users/massover/repos","events_url":"https://api.github.com/users/massover/events{/privacy}","received_events_url":"https://api.github.com/users/massover/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-20T16:06:11Z","updated_at":"2018-07-20T17:17:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/etianen/django-reversion/pulls/742","html_url":"https://github.com/etianen/django-reversion/pull/742","diff_url":"https://github.com/etianen/django-reversion/pull/742.diff","patch_url":"https://github.com/etianen/django-reversion/pull/742.patch"},"body":"This is a continuation of https://github.com/etianen/django-reversion/pull/731\r\n\r\n> Unfortunately, I've had to revert this pull request.\r\n> Extra fields should be added to create_revision(), not _create_revision_context(), which is a private  API.\r\n\r\nIf I understood this correctly, I added the the feature to the `create_revision` as that is the public api. I did also have to modify `_create_revision_context()` in order to allow the `create_revision` update to work, as per your original suggestion:\r\n\r\n> Nice idea!\r\n> \r\n> I think that this should be implemented inside the _create_revision_context function, since then the calls to set_meta, set_comment etc only need to be implemeted in one place.\r\n\r\nAlso added documentation."},"comment":{"url":"https://api.github.com/repos/etianen/django-reversion/issues/comments/406667393","html_url":"https://github.com/etianen/django-reversion/pull/742#issuecomment-406667393","issue_url":"https://api.github.com/repos/etianen/django-reversion/issues/742","id":406667393,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjY2NzM5Mw==","user":{"login":"etianen","id":148744,"node_id":"MDQ6VXNlcjE0ODc0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/148744?v=4","gravatar_id":"","url":"https://api.github.com/users/etianen","html_url":"https://github.com/etianen","followers_url":"https://api.github.com/users/etianen/followers","following_url":"https://api.github.com/users/etianen/following{/other_user}","gists_url":"https://api.github.com/users/etianen/gists{/gist_id}","starred_url":"https://api.github.com/users/etianen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etianen/subscriptions","organizations_url":"https://api.github.com/users/etianen/orgs","repos_url":"https://api.github.com/users/etianen/repos","events_url":"https://api.github.com/users/etianen/events{/privacy}","received_events_url":"https://api.github.com/users/etianen/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T17:17:02Z","updated_at":"2018-07-20T17:17:02Z","author_association":"OWNER","body":"Thanks!\r\nI'll review this when I get back from holiday, in just over a week. :)"}}
{"actor":{"display_login":"etianen"}}