{"action":"created","issue":{"url":"https://api.github.com/repos/adjoint-io/uplink/issues/24","repository_url":"https://api.github.com/repos/adjoint-io/uplink","labels_url":"https://api.github.com/repos/adjoint-io/uplink/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/adjoint-io/uplink/issues/24/comments","events_url":"https://api.github.com/repos/adjoint-io/uplink/issues/24/events","html_url":"https://github.com/adjoint-io/uplink/issues/24","id":297290698,"number":24,"title":"What address types should be in the phantom type?","user":{"login":"frasermince","id":3620683,"avatar_url":"https://avatars0.githubusercontent.com/u/3620683?v=4","gravatar_id":"","url":"https://api.github.com/users/frasermince","html_url":"https://github.com/frasermince","followers_url":"https://api.github.com/users/frasermince/followers","following_url":"https://api.github.com/users/frasermince/following{/other_user}","gists_url":"https://api.github.com/users/frasermince/gists{/gist_id}","starred_url":"https://api.github.com/users/frasermince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasermince/subscriptions","organizations_url":"https://api.github.com/users/frasermince/orgs","repos_url":"https://api.github.com/users/frasermince/repos","events_url":"https://api.github.com/users/frasermince/events{/privacy}","received_events_url":"https://api.github.com/users/frasermince/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-15T00:11:05Z","updated_at":"2018-02-15T22:35:26Z","closed_at":null,"author_association":"NONE","body":"I'm taking a look at adding phantom types to distinguish address types as per https://github.com/adjoint-io/uplink/blob/master/src/Address.hs#L94. What are the various address types? I assume one is Digest SHA3_256? Are there others? Am I understanding the problem correctly?"},"comment":{"url":"https://api.github.com/repos/adjoint-io/uplink/issues/comments/366084839","html_url":"https://github.com/adjoint-io/uplink/issues/24#issuecomment-366084839","issue_url":"https://api.github.com/repos/adjoint-io/uplink/issues/24","id":366084839,"user":{"login":"frasermince","id":3620683,"avatar_url":"https://avatars0.githubusercontent.com/u/3620683?v=4","gravatar_id":"","url":"https://api.github.com/users/frasermince","html_url":"https://github.com/frasermince","followers_url":"https://api.github.com/users/frasermince/followers","following_url":"https://api.github.com/users/frasermince/following{/other_user}","gists_url":"https://api.github.com/users/frasermince/gists{/gist_id}","starred_url":"https://api.github.com/users/frasermince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasermince/subscriptions","organizations_url":"https://api.github.com/users/frasermince/orgs","repos_url":"https://api.github.com/users/frasermince/repos","events_url":"https://api.github.com/users/frasermince/events{/privacy}","received_events_url":"https://api.github.com/users/frasermince/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T22:35:26Z","updated_at":"2018-02-15T22:35:26Z","author_association":"NONE","body":"Okay! I may at least give it a shot! So far the only issue I'm really running into is in the script files. I see we are parsing a LAddress and then later specifying what kind of address it actually is. I'm guessing we can't know at the parse what kind of address it is? How do we handle it when we don't know the type of address yet? I can write LAddress Address but I can't know what the phantom type would be in this case. https://github.com/adjoint-io/uplink/blob/master/src/Script.hs#L199 Unless we can use the replAddressLit parser for every address in the code (which I suspect is not the case). https://github.com/adjoint-io/uplink/blob/master/src/Script/Parser.hs#L200"}}
{"actor":{"display_login":"frasermince"}}