{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/191631632","pull_request_review_id":124237521,"id":191631632,"diff_hunk":"@@ -21,7 +21,18 @@\n               glyph=\"role\"\n               size=14\n               class=\"has-text-grey-light\"\n-            }}<span class=\"has-text-weight-semibold\">{{item.id}}</span></a>\n+            }}<span class=\"has-text-weight-semibold\">{{item.name}}</span></a>\n+          <div class=\"has-text-grey is-size-8\">\n+            {{item.id}}\n+          </div>\n+        </div>\n+        <div class=\"column is-3 is-hidden-mobile\">\n+          {{#if (eq item.identityType \"entity\")}}\n+            {{#if item.aliases.length}}\n+              {{pluralize item.aliases.length \"alias\"}}\n+            {{/if}}\n+          {{else}}","path":"ui/app/templates/vault/cluster/access/identity/index.hbs","position":24,"original_position":24,"commit_id":"6a1d08efea3dababd383feb3d5ea7d2f61cf95e8","original_commit_id":"6a1d08efea3dababd383feb3d5ea7d2f61cf95e8","user":{"login":"meirish","id":39469,"avatar_url":"https://avatars3.githubusercontent.com/u/39469?v=4","gravatar_id":"","url":"https://api.github.com/users/meirish","html_url":"https://github.com/meirish","followers_url":"https://api.github.com/users/meirish/followers","following_url":"https://api.github.com/users/meirish/following{/other_user}","gists_url":"https://api.github.com/users/meirish/gists{/gist_id}","starred_url":"https://api.github.com/users/meirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirish/subscriptions","organizations_url":"https://api.github.com/users/meirish/orgs","repos_url":"https://api.github.com/users/meirish/repos","events_url":"https://api.github.com/users/meirish/events{/privacy}","received_events_url":"https://api.github.com/users/meirish/received_events","type":"User","site_admin":false},"body":"Oh left that in from groups, can take out the outer if entirely until we land other groups stuff.","created_at":"2018-05-30T03:09:52Z","updated_at":"2018-05-30T03:09:52Z","html_url":"https://github.com/hashicorp/vault/pull/4655#discussion_r191631632","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/4655","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/191631632"},"html":{"href":"https://github.com/hashicorp/vault/pull/4655#discussion_r191631632"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4655"}},"in_reply_to_id":191630359},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/4655","id":191317071,"html_url":"https://github.com/hashicorp/vault/pull/4655","diff_url":"https://github.com/hashicorp/vault/pull/4655.diff","patch_url":"https://github.com/hashicorp/vault/pull/4655.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/4655","number":4655,"state":"closed","locked":false,"title":"UI identity lists","user":{"login":"meirish","id":39469,"avatar_url":"https://avatars3.githubusercontent.com/u/39469?v=4","gravatar_id":"","url":"https://api.github.com/users/meirish","html_url":"https://github.com/meirish","followers_url":"https://api.github.com/users/meirish/followers","following_url":"https://api.github.com/users/meirish/following{/other_user}","gists_url":"https://api.github.com/users/meirish/gists{/gist_id}","starred_url":"https://api.github.com/users/meirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirish/subscriptions","organizations_url":"https://api.github.com/users/meirish/orgs","repos_url":"https://api.github.com/users/meirish/repos","events_url":"https://api.github.com/users/meirish/events{/privacy}","received_events_url":"https://api.github.com/users/meirish/received_events","type":"User","site_admin":false},"body":"This uses the new `key_info` block on identity list endpoints to make the Identity UI (Access > Entities and Access > Groups) nicer to navigate and reason about. Groups now also show a \"Parent Groups\" tab that lists the groups a group is a member of.\r\n\r\n![screen shot 2018-05-29 at 9 19 43 pm](https://user-images.githubusercontent.com/39469/40695423-d36844ba-6386-11e8-8e1f-f64b0a702a46.png)\r\n![screen shot 2018-05-29 at 9 20 21 pm](https://user-images.githubusercontent.com/39469/40695424-d3776a62-6386-11e8-9a5e-fec878c1f9ad.png)\r\n![screen shot 2018-05-29 at 9 20 29 pm](https://user-images.githubusercontent.com/39469/40695425-d384f0e2-6386-11e8-80be-6cd33f01a0d7.png)\r\n![screen shot 2018-05-29 at 9 21 07 pm](https://user-images.githubusercontent.com/39469/40695426-d393c220-6386-11e8-9037-323d93a481ab.png)\r\n\r\n\r\n\r\nAlso makes a visual adjustment to the tabs subnav to be closer to the designs.","created_at":"2018-05-30T02:26:38Z","updated_at":"2018-05-30T03:09:52Z","closed_at":"2018-05-30T02:56:16Z","merged_at":"2018-05-30T02:56:16Z","merge_commit_sha":"61501209aef48917185adcd8f9ab6d9732057ffa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/hashicorp/vault/milestones/35","html_url":"https://github.com/hashicorp/vault/milestone/35","labels_url":"https://api.github.com/repos/hashicorp/vault/milestones/35/labels","id":3281750,"number":35,"title":"0.10.2","description":null,"creator":{"login":"jefferai","id":28627,"avatar_url":"https://avatars0.githubusercontent.com/u/28627?v=4","gravatar_id":"","url":"https://api.github.com/users/jefferai","html_url":"https://github.com/jefferai","followers_url":"https://api.github.com/users/jefferai/followers","following_url":"https://api.github.com/users/jefferai/following{/other_user}","gists_url":"https://api.github.com/users/jefferai/gists{/gist_id}","starred_url":"https://api.github.com/users/jefferai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefferai/subscriptions","organizations_url":"https://api.github.com/users/jefferai/orgs","repos_url":"https://api.github.com/users/jefferai/repos","events_url":"https://api.github.com/users/jefferai/events{/privacy}","received_events_url":"https://api.github.com/users/jefferai/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":94,"state":"open","created_at":"2018-04-19T19:03:22Z","updated_at":"2018-05-30T02:56:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/4655/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/4655/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/4655/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/6a1d08efea3dababd383feb3d5ea7d2f61cf95e8","head":{"label":"hashicorp:ui-identity-lists","ref":"ui-identity-lists","sha":"6a1d08efea3dababd383feb3d5ea7d2f61cf95e8","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-05-30T02:56:27Z","pushed_at":"2018-05-30T02:56:20Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":52604,"stargazers_count":9272,"watchers_count":9272,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1381,"mirror_url":null,"archived":false,"open_issues_count":239,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1381,"open_issues":239,"watchers":9272,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"1dc0793b5e7b9a22aa9aa8a088e3108fabfdccde","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-05-30T02:56:27Z","pushed_at":"2018-05-30T02:56:20Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":52604,"stargazers_count":9272,"watchers_count":9272,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1381,"mirror_url":null,"archived":false,"open_issues_count":239,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1381,"open_issues":239,"watchers":9272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4655"},"html":{"href":"https://github.com/hashicorp/vault/pull/4655"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/4655"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/4655/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4655/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4655/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/6a1d08efea3dababd383feb3d5ea7d2f61cf95e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"meirish"}}