{"action":"created","issue":{"url":"https://api.github.com/repos/bincrafters/community/issues/243","repository_url":"https://api.github.com/repos/bincrafters/community","labels_url":"https://api.github.com/repos/bincrafters/community/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/bincrafters/community/issues/243/comments","events_url":"https://api.github.com/repos/bincrafters/community/issues/243/events","html_url":"https://github.com/bincrafters/community/issues/243","id":320011183,"number":243,"title":"Inclusion request review for libzip","user":{"login":"danimtb","id":10808592,"avatar_url":"https://avatars1.githubusercontent.com/u/10808592?v=4","gravatar_id":"","url":"https://api.github.com/users/danimtb","html_url":"https://github.com/danimtb","followers_url":"https://api.github.com/users/danimtb/followers","following_url":"https://api.github.com/users/danimtb/following{/other_user}","gists_url":"https://api.github.com/users/danimtb/gists{/gist_id}","starred_url":"https://api.github.com/users/danimtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danimtb/subscriptions","organizations_url":"https://api.github.com/users/danimtb/orgs","repos_url":"https://api.github.com/users/danimtb/repos","events_url":"https://api.github.com/users/danimtb/events{/privacy}","received_events_url":"https://api.github.com/users/danimtb/received_events","type":"User","site_admin":false},"labels":[{"id":869378321,"url":"https://api.github.com/repos/bincrafters/community/labels/conan-center","name":"conan-center","color":"247bcc","default":false}],"state":"open","locked":false,"assignee":{"login":"uilianries","id":4870173,"avatar_url":"https://avatars0.githubusercontent.com/u/4870173?v=4","gravatar_id":"","url":"https://api.github.com/users/uilianries","html_url":"https://github.com/uilianries","followers_url":"https://api.github.com/users/uilianries/followers","following_url":"https://api.github.com/users/uilianries/following{/other_user}","gists_url":"https://api.github.com/users/uilianries/gists{/gist_id}","starred_url":"https://api.github.com/users/uilianries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uilianries/subscriptions","organizations_url":"https://api.github.com/users/uilianries/orgs","repos_url":"https://api.github.com/users/uilianries/repos","events_url":"https://api.github.com/users/uilianries/events{/privacy}","received_events_url":"https://api.github.com/users/uilianries/received_events","type":"User","site_admin":false},"assignees":[{"login":"uilianries","id":4870173,"avatar_url":"https://avatars0.githubusercontent.com/u/4870173?v=4","gravatar_id":"","url":"https://api.github.com/users/uilianries","html_url":"https://github.com/uilianries","followers_url":"https://api.github.com/users/uilianries/followers","following_url":"https://api.github.com/users/uilianries/following{/other_user}","gists_url":"https://api.github.com/users/uilianries/gists{/gist_id}","starred_url":"https://api.github.com/users/uilianries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uilianries/subscriptions","organizations_url":"https://api.github.com/users/uilianries/orgs","repos_url":"https://api.github.com/users/uilianries/repos","events_url":"https://api.github.com/users/uilianries/events{/privacy}","received_events_url":"https://api.github.com/users/uilianries/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-03T17:26:48Z","updated_at":"2018-05-08T15:35:42Z","closed_at":null,"author_association":"NONE","body":"## Inclusion Request Review\r\n\r\nThis is a review for [libzip/1.4.0@bincrafters/stable (bincrafters/public-conan)](https://github.com/bincrafters/conan-libzip) inclusion request to conan-center.\r\nThis review follows the [inclusion guidelines or third party libraries](http://docs.conan.io/en/latest/uploading_packages/bintray/conan_center_guide.html#inclusion-guidelines-for-third-party-libraries).\r\n\r\n### Package\r\nlibzip/1.4.0@bincrafters/stable (It also applies to 1.5.1 and 1.2.0)\r\n\r\n### Checks and Comments\r\n\r\n#### Recipe quality\r\n- [x] Git public repository\r\n- [x] Recipe fields\r\n- [x] Linter\r\n- [x] Updated\r\n- [x] Clean\r\n- [ ] test_package\r\n- [x] Raise errors on invalid configurations\r\n- [x] LICENSE of the recipe\r\n- [x] LICENSE of the library\r\n\r\n#### CI Integration\r\n- [x] Provide at least one CI configuration (header only)\r\n- [x] (If not header only) CI configurations for Linux/MacOSX/Windows\r\n\r\n#### Bintray Package Information\r\n- [x] Description\r\n- [x] Licenses\r\n- [x] Tags\r\n- [x] Maturity\r\n- [x] Website (if any)\r\n- [x] Issue tracker\r\n- [x] Version control\r\n\r\n### Additional comments\r\n\r\nCan't detect cpp sources but the conanfile doesn't remove ``compiler.libcxx``\r\n\r\nSuggestion: \r\n```\r\ndef configure(self):\r\n    del self.settings.compiler.libcxx\r\n```\r\n\r\nPlease consider improving the C code en the *test_package* to really test some functionality of the library and ensure it is consuming the package well."},"comment":{"url":"https://api.github.com/repos/bincrafters/community/issues/comments/387445173","html_url":"https://github.com/bincrafters/community/issues/243#issuecomment-387445173","issue_url":"https://api.github.com/repos/bincrafters/community/issues/243","id":387445173,"user":{"login":"danimtb","id":10808592,"avatar_url":"https://avatars1.githubusercontent.com/u/10808592?v=4","gravatar_id":"","url":"https://api.github.com/users/danimtb","html_url":"https://github.com/danimtb","followers_url":"https://api.github.com/users/danimtb/followers","following_url":"https://api.github.com/users/danimtb/following{/other_user}","gists_url":"https://api.github.com/users/danimtb/gists{/gist_id}","starred_url":"https://api.github.com/users/danimtb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danimtb/subscriptions","organizations_url":"https://api.github.com/users/danimtb/orgs","repos_url":"https://api.github.com/users/danimtb/repos","events_url":"https://api.github.com/users/danimtb/events{/privacy}","received_events_url":"https://api.github.com/users/danimtb/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T15:35:42Z","updated_at":"2018-05-08T15:35:42Z","author_association":"NONE","body":"Ok, no I see it.\r\n\r\nSo after that is fixed, you would have to add bzip2 dependency in the conanfile, now bzip2 is missing in the requires."}}
{"actor":{"display_login":"danimtb"}}