{"action":"created","issue":{"url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/issues/48","repository_url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg","labels_url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/issues/48/comments","events_url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/issues/48/events","html_url":"https://github.com/sihil/hiera-eyaml-gpg/pull/48","id":383128004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjcxMzQ1","number":48,"title":"Use Puppet::Util::Execution for RubyGpg","user":{"login":"seanmil","id":26917,"node_id":"MDQ6VXNlcjI2OTE3","avatar_url":"https://avatars1.githubusercontent.com/u/26917?v=4","gravatar_id":"","url":"https://api.github.com/users/seanmil","html_url":"https://github.com/seanmil","followers_url":"https://api.github.com/users/seanmil/followers","following_url":"https://api.github.com/users/seanmil/following{/other_user}","gists_url":"https://api.github.com/users/seanmil/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmil/subscriptions","organizations_url":"https://api.github.com/users/seanmil/orgs","repos_url":"https://api.github.com/users/seanmil/repos","events_url":"https://api.github.com/users/seanmil/events{/privacy}","received_events_url":"https://api.github.com/users/seanmil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-21T13:53:13Z","updated_at":"2018-11-21T16:15:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/pulls/48","html_url":"https://github.com/sihil/hiera-eyaml-gpg/pull/48","diff_url":"https://github.com/sihil/hiera-eyaml-gpg/pull/48.diff","patch_url":"https://github.com/sihil/hiera-eyaml-gpg/pull/48.patch"},"body":"I don't know if this should be merged or not, but I am providing it at least as a reference for anyone else who might encounter this problem.\r\n\r\nRubyGpg is used when Gpgme isn't available, which will always be the case for Puppetserver-based execution. However, when running from Puppetserver `Puppet::Util::Execution.execute()` should be used to invoke external commands and RubyGpg does not do that.\r\n\r\nThis patch basically monkeypatches RubyGpg so that `Puppet::Util::Execution.execute()` is used, which will address issues on Puppetserver deployments (particularly ones with large heap sizes).\r\n\r\nProbably a better way to go about this would be some more fundamental changes so that RubyGpg isn't needed (and therefore doesn't need to be monkeypatched) but that was beyond the scope of what I was ready to take on.\r\n\r\nNote that this patch modifies the command passed in with an appended tempfile path instead of passing the key in on `stdin` (which I feel would be a cleaner way of handling it) because of this Puppet bug: https://tickets.puppetlabs.com/browse/PUP-9304"},"comment":{"url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/issues/comments/440723561","html_url":"https://github.com/sihil/hiera-eyaml-gpg/pull/48#issuecomment-440723561","issue_url":"https://api.github.com/repos/sihil/hiera-eyaml-gpg/issues/48","id":440723561,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDcyMzU2MQ==","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T16:15:39Z","updated_at":"2018-11-21T16:15:39Z","author_association":"NONE","body":"This fixes https://tickets.puppetlabs.com/browse/SERVER-2021 for me.\r\n\r\nThanks @seanmil!"}}
{"actor":{"display_login":"alexjfisher"}}