{"action":"created","comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/170436730","pull_request_review_id":99127538,"id":170436730,"diff_hunk":"@@ -1230,7 +1294,18 @@ void Planner::_buffer_steps(const int32_t (&target)[ABCE], float fr_mm_s, const\n   }\n   block->acceleration_steps_per_s2 = accel;\n   block->acceleration = accel / steps_per_mm;\n-  block->acceleration_rate = (long)(accel * 16777216.0 / (HAL_STEPPER_TIMER_RATE)); // 16777216 = <<24\n+  block->acceleration_rate = (long)(accel * 16777216.0 / ((F_CPU) * 0.125)); // * 8.388608","path":"Marlin/src/module/planner.cpp","position":155,"original_position":155,"commit_id":"2d9e65fe0e8c2d45ebdad5e1bef9888bf9ef3e3f","original_commit_id":"2d9e65fe0e8c2d45ebdad5e1bef9888bf9ef3e3f","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"body":"Oops, that was a foolish oversight from using paste and not re-checking. I patched it this morning, and the line below.","created_at":"2018-02-24T23:57:24Z","updated_at":"2018-02-24T23:57:24Z","html_url":"https://github.com/MarlinFirmware/Marlin/pull/9712#discussion_r170436730","pull_request_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/170436730"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/9712#discussion_r170436730"},"pull_request":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712"}},"in_reply_to_id":170412172},"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712","id":169878524,"html_url":"https://github.com/MarlinFirmware/Marlin/pull/9712","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/9712.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/9712.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/9712","number":9712,"state":"closed","locked":false,"title":"[2.0.x] LIN_ADVANCE v1.5","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"body":"Based on #9700 by @Sebastianv650 \r\n\r\n---\r\nCleanup, squash and rebase of development branch, see #9379.\r\n\r\nChanges to v1.0:\r\n- K is now a meaningful value with the unit [mm of filament compression needed per 1mm/s extrusion speed] or [mm/mm/s].\r\n- Load inside stepper ISR reduced as no calculations are needed there any more. Instead, the extruder runs at a fixed speed offset during pressure adjustment. Therefore this version runs faster.\r\n- `LIN_ADVANCE` now respects hardware limitations set in `Configuration.h`, namely extruder jerk. If the pressure corrections would need faster adjustments than allowed by extruder jerk limit, the acceleration for this print move is limited to a value which allows to use extruder jerk speed as the upper limit.\r\n- The pressure adjustment moves doesn't lead to a rattling extruder as it was in v1.0 as the extruder is now running at a smooth speed instead of jerking between multiples of extruder print speed.\r\n- This smooth extruder operation and respecting of jerk limits ensures no extruder steps are skipped.\r\n\r\nKeep in mind that:\r\n- High K values (soft filament, bowden printers) will lead to print acceleration reduction. This is unavoidable to keep extruder speed in allowed ranges. You can't expect it's possible to draw a great piece of art with a cooked noodle - there is a reason why the handle of a brush is made from wood.\r\n\r\nTodo, required in short term:\r\n- Update Marlin documentation","created_at":"2018-02-19T05:00:11Z","updated_at":"2018-02-24T23:57:24Z","closed_at":"2018-02-23T06:53:30Z","merged_at":"2018-02-23T06:53:30Z","merge_commit_sha":"2bd252b50149c860cf37d488762abcf70a83f78d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":92052497,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Improvement","name":"Improvement","color":"009800","default":false},{"id":196934261,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Bugfix","name":"PR: Bugfix","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/9712/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/2d9e65fe0e8c2d45ebdad5e1bef9888bf9ef3e3f","head":{"label":"thinkyhead:bf2_lin_advance_1.5","ref":"bf2_lin_advance_1.5","sha":"2d9e65fe0e8c2d45ebdad5e1bef9888bf9ef3e3f","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"repo":{"id":24809835,"name":"Marlin","full_name":"thinkyhead/Marlin","owner":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thinkyhead/Marlin","description":"This fork is a primary contributor to the MarlinFirmware/Marlin release branch, frequently pushing bug fixes, new features, and code cleanup. See the Wiki page for details. If any of the experimental branches here look interesting please contribute! Branches with \"i3_millie\" in the name include all the latest goodies, optimized for my RAMPS-based Prusa i3.","fork":true,"url":"https://api.github.com/repos/thinkyhead/Marlin","forks_url":"https://api.github.com/repos/thinkyhead/Marlin/forks","keys_url":"https://api.github.com/repos/thinkyhead/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thinkyhead/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thinkyhead/Marlin/teams","hooks_url":"https://api.github.com/repos/thinkyhead/Marlin/hooks","issue_events_url":"https://api.github.com/repos/thinkyhead/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/thinkyhead/Marlin/events","assignees_url":"https://api.github.com/repos/thinkyhead/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/thinkyhead/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/thinkyhead/Marlin/tags","blobs_url":"https://api.github.com/repos/thinkyhead/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thinkyhead/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thinkyhead/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/thinkyhead/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thinkyhead/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/thinkyhead/Marlin/languages","stargazers_url":"https://api.github.com/repos/thinkyhead/Marlin/stargazers","contributors_url":"https://api.github.com/repos/thinkyhead/Marlin/contributors","subscribers_url":"https://api.github.com/repos/thinkyhead/Marlin/subscribers","subscription_url":"https://api.github.com/repos/thinkyhead/Marlin/subscription","commits_url":"https://api.github.com/repos/thinkyhead/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/thinkyhead/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/thinkyhead/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/thinkyhead/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/thinkyhead/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/thinkyhead/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thinkyhead/Marlin/merges","archive_url":"https://api.github.com/repos/thinkyhead/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thinkyhead/Marlin/downloads","issues_url":"https://api.github.com/repos/thinkyhead/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/thinkyhead/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/thinkyhead/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/thinkyhead/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thinkyhead/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/thinkyhead/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/thinkyhead/Marlin/deployments","created_at":"2014-10-05T06:17:14Z","updated_at":"2017-11-10T13:17:26Z","pushed_at":"2018-02-24T23:08:23Z","git_url":"git://github.com/thinkyhead/Marlin.git","ssh_url":"git@github.com:thinkyhead/Marlin.git","clone_url":"https://github.com/thinkyhead/Marlin.git","svn_url":"https://github.com/thinkyhead/Marlin","homepage":"http://www.thinkyhead.com/","size":63273,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":0,"watchers":13,"default_branch":"bugfix-1.1.x"}},"base":{"label":"MarlinFirmware:bugfix-2.0.x","ref":"bugfix-2.0.x","sha":"8c1a82c32765dda9a6cc6f204c713e3e81310f73","user":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":2200856,"name":"Marlin","full_name":"MarlinFirmware/Marlin","owner":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarlinFirmware/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/Marlin","forks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/Marlin/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/Marlin/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/Marlin/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/Marlin/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/deployments","created_at":"2011-08-13T08:07:20Z","updated_at":"2018-02-24T23:00:31Z","pushed_at":"2018-02-24T23:08:24Z","git_url":"git://github.com/MarlinFirmware/Marlin.git","ssh_url":"git@github.com:MarlinFirmware/Marlin.git","clone_url":"https://github.com/MarlinFirmware/Marlin.git","svn_url":"https://github.com/MarlinFirmware/Marlin","homepage":"http://www.marlinfw.org/","size":65872,"stargazers_count":3443,"watchers_count":3443,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5168,"mirror_url":null,"archived":false,"open_issues_count":454,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":5168,"open_issues":454,"watchers":3443,"default_branch":"1.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/9712"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/9712"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/9712/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/9712/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/2d9e65fe0e8c2d45ebdad5e1bef9888bf9ef3e3f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"thinkyhead"}}