{"action":"created","comment":{"url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments/224863689","pull_request_review_id":164341867,"id":224863689,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDg2MzY4OQ==","diff_hunk":"@@ -55,11 +66,18 @@ module Fauxpaas\n       )\n     end\n \n+    before(:each) do\n+      Fauxpaas.config.tap do |canister|\n+        canister.register(:release_time_format) { Fauxpaas.settings.release_time_format }\n+      end\n+    end","path":"spec/logged_release_spec.rb","position":39,"original_position":39,"commit_id":"c443e7fdca3278d5701da2e923679cf146d04c0c","original_commit_id":"f2a443492fa687bafa5ae701bd8e37b3190c37ff","user":{"login":"malakai97","id":3486429,"node_id":"MDQ6VXNlcjM0ODY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3486429?v=4","gravatar_id":"","url":"https://api.github.com/users/malakai97","html_url":"https://github.com/malakai97","followers_url":"https://api.github.com/users/malakai97/followers","following_url":"https://api.github.com/users/malakai97/following{/other_user}","gists_url":"https://api.github.com/users/malakai97/gists{/gist_id}","starred_url":"https://api.github.com/users/malakai97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malakai97/subscriptions","organizations_url":"https://api.github.com/users/malakai97/orgs","repos_url":"https://api.github.com/users/malakai97/repos","events_url":"https://api.github.com/users/malakai97/events{/privacy}","received_events_url":"https://api.github.com/users/malakai97/received_events","type":"User","site_admin":false},"body":"No, see my other comment.","created_at":"2018-10-12T17:38:37Z","updated_at":"2018-10-12T17:38:37Z","html_url":"https://github.com/mlibrary/fauxpaas/pull/74#discussion_r224863689","pull_request_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments/224863689"},"html":{"href":"https://github.com/mlibrary/fauxpaas/pull/74#discussion_r224863689"},"pull_request":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74"}},"in_reply_to_id":224640342},"pull_request":{"url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74","id":222296052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjk2MDUy","html_url":"https://github.com/mlibrary/fauxpaas/pull/74","diff_url":"https://github.com/mlibrary/fauxpaas/pull/74.diff","patch_url":"https://github.com/mlibrary/fauxpaas/pull/74.patch","issue_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/74","number":74,"state":"open","locked":false,"title":"Add id field to LoggedRelease, LoggedReleases","user":{"login":"malakai97","id":3486429,"node_id":"MDQ6VXNlcjM0ODY0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/3486429?v=4","gravatar_id":"","url":"https://api.github.com/users/malakai97","html_url":"https://github.com/malakai97","followers_url":"https://api.github.com/users/malakai97/followers","following_url":"https://api.github.com/users/malakai97/following{/other_user}","gists_url":"https://api.github.com/users/malakai97/gists{/gist_id}","starred_url":"https://api.github.com/users/malakai97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malakai97/subscriptions","organizations_url":"https://api.github.com/users/malakai97/orgs","repos_url":"https://api.github.com/users/malakai97/repos","events_url":"https://api.github.com/users/malakai97/events{/privacy}","received_events_url":"https://api.github.com/users/malakai97/received_events","type":"User","site_admin":false},"body":"Resolves AEIM-1574\r\n\r\n* Adds support for the id field to LoggedRelease, LoggedReleases\r\n* Foregoes displaying the timestamp because the id is a timestamp\r\n* LoggedRelease.from_hash can interpret a hash that is missing an id\r\n  field, inferring from the timestamp.\r\n* Supply the release time format in settings.yml\r\n\r\nAlso adds a `version` field to the LoggedRelease. This field is essentially a comment, but by convention we always set it to the reference they supplied, the default branch name if they didn't supply one, or the sha of the source if neither of those two are available (which happens when we're loading an older version of a release from a yaml file).","created_at":"2018-10-11T22:16:10Z","updated_at":"2018-10-12T17:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb652a60433f9963e81cf230380ab8b9470e4719","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74/commits","review_comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74/comments","review_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/74/comments","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/c443e7fdca3278d5701da2e923679cf146d04c0c","head":{"label":"mlibrary:aeim-1574/logged_release_id","ref":"aeim-1574/logged_release_id","sha":"c443e7fdca3278d5701da2e923679cf146d04c0c","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102662551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2NjI1NTE=","name":"fauxpaas","full_name":"mlibrary/fauxpaas","private":false,"owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mlibrary/fauxpaas","description":"Deployment tooling for Ruby projects at MLibrary","fork":false,"url":"https://api.github.com/repos/mlibrary/fauxpaas","forks_url":"https://api.github.com/repos/mlibrary/fauxpaas/forks","keys_url":"https://api.github.com/repos/mlibrary/fauxpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/fauxpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/fauxpaas/teams","hooks_url":"https://api.github.com/repos/mlibrary/fauxpaas/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/fauxpaas/events","assignees_url":"https://api.github.com/repos/mlibrary/fauxpaas/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/fauxpaas/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/tags","blobs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/fauxpaas/languages","stargazers_url":"https://api.github.com/repos/mlibrary/fauxpaas/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/fauxpaas/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscription","commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/fauxpaas/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/fauxpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/fauxpaas/merges","archive_url":"https://api.github.com/repos/mlibrary/fauxpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/fauxpaas/downloads","issues_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/fauxpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/fauxpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/fauxpaas/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/fauxpaas/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/fauxpaas/deployments","created_at":"2017-09-06T22:01:59Z","updated_at":"2018-10-12T17:23:22Z","pushed_at":"2018-10-12T17:35:24Z","git_url":"git://github.com/mlibrary/fauxpaas.git","ssh_url":"git@github.com:mlibrary/fauxpaas.git","clone_url":"https://github.com/mlibrary/fauxpaas.git","svn_url":"https://github.com/mlibrary/fauxpaas","homepage":"","size":523,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"mlibrary:develop","ref":"develop","sha":"f71d37fe38b0c566f8a80010af9d3413966c32b9","user":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102662551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2NjI1NTE=","name":"fauxpaas","full_name":"mlibrary/fauxpaas","private":false,"owner":{"login":"mlibrary","id":2494481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTQ0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/2494481?v=4","gravatar_id":"","url":"https://api.github.com/users/mlibrary","html_url":"https://github.com/mlibrary","followers_url":"https://api.github.com/users/mlibrary/followers","following_url":"https://api.github.com/users/mlibrary/following{/other_user}","gists_url":"https://api.github.com/users/mlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/mlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlibrary/subscriptions","organizations_url":"https://api.github.com/users/mlibrary/orgs","repos_url":"https://api.github.com/users/mlibrary/repos","events_url":"https://api.github.com/users/mlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/mlibrary/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mlibrary/fauxpaas","description":"Deployment tooling for Ruby projects at MLibrary","fork":false,"url":"https://api.github.com/repos/mlibrary/fauxpaas","forks_url":"https://api.github.com/repos/mlibrary/fauxpaas/forks","keys_url":"https://api.github.com/repos/mlibrary/fauxpaas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlibrary/fauxpaas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlibrary/fauxpaas/teams","hooks_url":"https://api.github.com/repos/mlibrary/fauxpaas/hooks","issue_events_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/events{/number}","events_url":"https://api.github.com/repos/mlibrary/fauxpaas/events","assignees_url":"https://api.github.com/repos/mlibrary/fauxpaas/assignees{/user}","branches_url":"https://api.github.com/repos/mlibrary/fauxpaas/branches{/branch}","tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/tags","blobs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/{sha}","languages_url":"https://api.github.com/repos/mlibrary/fauxpaas/languages","stargazers_url":"https://api.github.com/repos/mlibrary/fauxpaas/stargazers","contributors_url":"https://api.github.com/repos/mlibrary/fauxpaas/contributors","subscribers_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscribers","subscription_url":"https://api.github.com/repos/mlibrary/fauxpaas/subscription","commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlibrary/fauxpaas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlibrary/fauxpaas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlibrary/fauxpaas/contents/{+path}","compare_url":"https://api.github.com/repos/mlibrary/fauxpaas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlibrary/fauxpaas/merges","archive_url":"https://api.github.com/repos/mlibrary/fauxpaas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlibrary/fauxpaas/downloads","issues_url":"https://api.github.com/repos/mlibrary/fauxpaas/issues{/number}","pulls_url":"https://api.github.com/repos/mlibrary/fauxpaas/pulls{/number}","milestones_url":"https://api.github.com/repos/mlibrary/fauxpaas/milestones{/number}","notifications_url":"https://api.github.com/repos/mlibrary/fauxpaas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlibrary/fauxpaas/labels{/name}","releases_url":"https://api.github.com/repos/mlibrary/fauxpaas/releases{/id}","deployments_url":"https://api.github.com/repos/mlibrary/fauxpaas/deployments","created_at":"2017-09-06T22:01:59Z","updated_at":"2018-10-12T17:23:22Z","pushed_at":"2018-10-12T17:35:24Z","git_url":"git://github.com/mlibrary/fauxpaas.git","ssh_url":"git@github.com:mlibrary/fauxpaas.git","clone_url":"https://github.com/mlibrary/fauxpaas.git","svn_url":"https://github.com/mlibrary/fauxpaas","homepage":"","size":523,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74"},"html":{"href":"https://github.com/mlibrary/fauxpaas/pull/74"},"issue":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/issues/74"},"comments":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/mlibrary/fauxpaas/statuses/c443e7fdca3278d5701da2e923679cf146d04c0c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"malakai97"}}