{"action":"created","comment":{"url":"https://api.github.com/repos/scalacenter/bloop/pulls/comments/234399118","pull_request_review_id":176043871,"id":234399118,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDM5OTExOA==","diff_hunk":"@@ -536,35 +622,62 @@ class BspProtocolSpec {\n               val json = taskFinish.data.get\n               bsp.CompileReport.decodeCompileReport(json.hcursor) match {\n                 case Right(report) =>\n+\n                   if (isMainProject(report.target)) {\n                     if (receivedReports == 0) {\n-                      // This is the batch compilation which should have a warning and no errors\n+                      val received = findDiagnosticsReport(report.target, receivedReports)\n+                      val expected =\n+                        \"TextDocumentIdentifier(Uri(file:/Users/jvican/Code/bloop/frontend/src/test/resources/cross-test-build-0.6/test-project/shared/src/main/scala/hello/App.scala)) List(Diagnostic(Range(Position(5,8),Position(5,8)),Some(Warning),None,None,local val in method main is never used,None)) (reset = true)\"\n+                      Assert.assertEquals(expected, received)\n                       receivedReports += 1\n-                      Assert.assertEquals(s\"Warnings in $MainProject != 1\", 1, report.warnings)\n-                      Assert.assertEquals(s\"Errors in $MainProject != 0\", 0, report.errors)\n-                      //Assert.assertTrue(s\"Duration in $MainProject == 0\", report.time != 0)\n                     } else if (receivedReports == 1) {\n-                      // This is the incremental compile which should have errors\n+                      // Check that we only receive one error\n+                      val received = findDiagnosticsReport(report.target, receivedReports)\n+                      // We don't expect a warning here because the client is supposed to reuse the previous diagnostic (we *didn't* send a notification for that file with reset=true)\n+                      val expected =\n+                        \"TextDocumentIdentifier(Uri(file:/Users/jvican/Code/bloop/frontend/src/test/resources/cross-test-build-0.6/test-project/jvm/src/main/scala/TestIncrementalCompilation.scala)) List(Diagnostic(Range(Position(3,13),Position(3,13)),Some(Error),None,None,']' expected but ')' found.,None)) (reset = true)\"\n+                      Assert.assertEquals(expected, received)\n                       receivedReports += 1\n-                      Assert.assertTrue(\n-                        s\"Expected errors in incremental cycle of $MainProject\",\n-                        report.errors > 0\n+                    } else if (receivedReports == 2) {\n+                      // The following operation is a no-op, so we should get an empty diagnostic with reset enabled to delete the previous error\n+                      val received = findDiagnosticsReport(report.target, receivedReports)\n+                      val expected =\n+                        \"TextDocumentIdentifier(Uri(file:/Users/jvican/Code/bloop/frontend/src/test/resources/cross-test-build-0.6/test-project/jvm/src/main/scala/TestIncrementalCompilation.scala)) List() (reset = true)\"","path":"frontend/src/test/scala/bloop/bsp/BspProtocolSpec.scala","position":null,"original_position":269,"commit_id":"e5a999a98ef21c0bd3221969a2ca1e6a959b823f","original_commit_id":"fbfe1c5a3396c242d6e65108bc451f5a1c75a0d7","user":{"login":"olafurpg","id":1408093,"node_id":"MDQ6VXNlcjE0MDgwOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1408093?v=4","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"body":"Uri should stay absolute in the server, comment was only to make it relative in this expect test.","created_at":"2018-11-17T06:53:40Z","updated_at":"2018-11-17T06:53:40Z","html_url":"https://github.com/scalacenter/bloop/pull/722#discussion_r234399118","pull_request_url":"https://api.github.com/repos/scalacenter/bloop/pulls/722","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/comments/234399118"},"html":{"href":"https://github.com/scalacenter/bloop/pull/722#discussion_r234399118"},"pull_request":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/722"}},"in_reply_to_id":234361860},"pull_request":{"url":"https://api.github.com/repos/scalacenter/bloop/pulls/722","id":231634304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjM0MzA0","html_url":"https://github.com/scalacenter/bloop/pull/722","diff_url":"https://github.com/scalacenter/bloop/pull/722.diff","patch_url":"https://github.com/scalacenter/bloop/pull/722.patch","issue_url":"https://api.github.com/repos/scalacenter/bloop/issues/722","number":722,"state":"open","locked":false,"title":"Migrate to bsp v2 partially","user":{"login":"jvican","id":2462974,"node_id":"MDQ6VXNlcjI0NjI5NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"We disable tests for `test` and `run` for now, only focusing on the most\r\nimportant BSP tasks to ease the migration in the BSP clients,\r\nconcretely diagnostics, `sources` and compile. There is a lot of\r\ninformation in the commit messages.","created_at":"2018-11-16T19:36:40Z","updated_at":"2018-11-17T06:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"068826be3733ae3493ed82d5e7c2362ba73b79da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalacenter/bloop/pulls/722/commits","review_comments_url":"https://api.github.com/repos/scalacenter/bloop/pulls/722/comments","review_comment_url":"https://api.github.com/repos/scalacenter/bloop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalacenter/bloop/issues/722/comments","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/e5a999a98ef21c0bd3221969a2ca1e6a959b823f","head":{"label":"scalacenter:topic/bsp-v2","ref":"topic/bsp-v2","sha":"e5a999a98ef21c0bd3221969a2ca1e6a959b823f","user":{"login":"scalacenter","id":16118980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTE4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":110334159,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzMzQxNTk=","name":"bloop","full_name":"scalacenter/bloop","private":false,"owner":{"login":"scalacenter","id":16118980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTE4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scalacenter/bloop","description":"Scala build server and command-line tool for fast developer workflows","fork":false,"url":"https://api.github.com/repos/scalacenter/bloop","forks_url":"https://api.github.com/repos/scalacenter/bloop/forks","keys_url":"https://api.github.com/repos/scalacenter/bloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bloop/teams","hooks_url":"https://api.github.com/repos/scalacenter/bloop/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bloop/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bloop/events","assignees_url":"https://api.github.com/repos/scalacenter/bloop/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bloop/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bloop/tags","blobs_url":"https://api.github.com/repos/scalacenter/bloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bloop/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bloop/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bloop/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bloop/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bloop/subscription","commits_url":"https://api.github.com/repos/scalacenter/bloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bloop/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bloop/merges","archive_url":"https://api.github.com/repos/scalacenter/bloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bloop/downloads","issues_url":"https://api.github.com/repos/scalacenter/bloop/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bloop/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bloop/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bloop/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bloop/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bloop/deployments","created_at":"2017-11-11T09:39:34Z","updated_at":"2018-11-16T10:45:51Z","pushed_at":"2018-11-16T23:33:26Z","git_url":"git://github.com/scalacenter/bloop.git","ssh_url":"git@github.com:scalacenter/bloop.git","clone_url":"https://github.com/scalacenter/bloop.git","svn_url":"https://github.com/scalacenter/bloop","homepage":"https://scalacenter.github.io/bloop/","size":6939,"stargazers_count":317,"watchers_count":317,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":70,"watchers":317,"default_branch":"master"}},"base":{"label":"scalacenter:master","ref":"master","sha":"f36ae3d33540c15cc792a575ef5e43ba752a7e67","user":{"login":"scalacenter","id":16118980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTE4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":110334159,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzMzQxNTk=","name":"bloop","full_name":"scalacenter/bloop","private":false,"owner":{"login":"scalacenter","id":16118980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTE4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scalacenter/bloop","description":"Scala build server and command-line tool for fast developer workflows","fork":false,"url":"https://api.github.com/repos/scalacenter/bloop","forks_url":"https://api.github.com/repos/scalacenter/bloop/forks","keys_url":"https://api.github.com/repos/scalacenter/bloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bloop/teams","hooks_url":"https://api.github.com/repos/scalacenter/bloop/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bloop/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bloop/events","assignees_url":"https://api.github.com/repos/scalacenter/bloop/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bloop/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bloop/tags","blobs_url":"https://api.github.com/repos/scalacenter/bloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bloop/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bloop/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bloop/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bloop/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bloop/subscription","commits_url":"https://api.github.com/repos/scalacenter/bloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bloop/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bloop/merges","archive_url":"https://api.github.com/repos/scalacenter/bloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bloop/downloads","issues_url":"https://api.github.com/repos/scalacenter/bloop/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bloop/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bloop/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bloop/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bloop/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bloop/deployments","created_at":"2017-11-11T09:39:34Z","updated_at":"2018-11-16T10:45:51Z","pushed_at":"2018-11-16T23:33:26Z","git_url":"git://github.com/scalacenter/bloop.git","ssh_url":"git@github.com:scalacenter/bloop.git","clone_url":"https://github.com/scalacenter/bloop.git","svn_url":"https://github.com/scalacenter/bloop","homepage":"https://scalacenter.github.io/bloop/","size":6939,"stargazers_count":317,"watchers_count":317,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":70,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/722"},"html":{"href":"https://github.com/scalacenter/bloop/pull/722"},"issue":{"href":"https://api.github.com/repos/scalacenter/bloop/issues/722"},"comments":{"href":"https://api.github.com/repos/scalacenter/bloop/issues/722/comments"},"review_comments":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/722/comments"},"review_comment":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/722/commits"},"statuses":{"href":"https://api.github.com/repos/scalacenter/bloop/statuses/e5a999a98ef21c0bd3221969a2ca1e6a959b823f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"olafurpg"}}