{"action":"closed","number":3927,"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3927","id":203249581,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjQ5NTgx","html_url":"https://github.com/envoyproxy/envoy/pull/3927","diff_url":"https://github.com/envoyproxy/envoy/pull/3927.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3927.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3927","number":3927,"state":"closed","locked":false,"title":"stats: add symbol table for future stat name encoding","user":{"login":"ambuc","id":6856318,"node_id":"MDQ6VXNlcjY4NTYzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6856318?v=4","gravatar_id":"","url":"https://api.github.com/users/ambuc","html_url":"https://github.com/ambuc","followers_url":"https://api.github.com/users/ambuc/followers","following_url":"https://api.github.com/users/ambuc/following{/other_user}","gists_url":"https://api.github.com/users/ambuc/gists{/gist_id}","starred_url":"https://api.github.com/users/ambuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambuc/subscriptions","organizations_url":"https://api.github.com/users/ambuc/orgs","repos_url":"https://api.github.com/users/ambuc/repos","events_url":"https://api.github.com/users/ambuc/events{/privacy}","received_events_url":"https://api.github.com/users/ambuc/received_events","type":"User","site_admin":false},"body":"*Description*: Add symbol table implementation, to be used for encoding heap-allocated stat names in the future. The symbol table grows and shrinks dynamically with the number of unique string segments in it, and guarantees `x = decode(encode(x))` for as long as at least one instance of each string segment in `x` exists. Implicitly splits on period-delimited stat names. Does not enforce stat name length or string segment length.\r\n\r\n*Risk Level*: Low, adds library but does not add dependencies on it anywhere.\r\n*Testing*: See `//test/common/stats:symbol_table_test`.\r\n*Docs Changes*: None\r\n*Release Notes*: None","created_at":"2018-07-23T15:04:47Z","updated_at":"2018-08-28T16:31:34Z","closed_at":"2018-08-28T16:31:34Z","merged_at":"2018-08-28T16:31:34Z","merge_commit_sha":"53f8944f7a3109de21131635793ce5282ac0295e","assignee":{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3927/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3927/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3927/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/efd3c6f96aa802983326c1d09010cc43ccde0af6","head":{"label":"ambuc:symbol-table","ref":"symbol-table","sha":"efd3c6f96aa802983326c1d09010cc43ccde0af6","user":{"login":"ambuc","id":6856318,"node_id":"MDQ6VXNlcjY4NTYzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6856318?v=4","gravatar_id":"","url":"https://api.github.com/users/ambuc","html_url":"https://github.com/ambuc","followers_url":"https://api.github.com/users/ambuc/followers","following_url":"https://api.github.com/users/ambuc/following{/other_user}","gists_url":"https://api.github.com/users/ambuc/gists{/gist_id}","starred_url":"https://api.github.com/users/ambuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambuc/subscriptions","organizations_url":"https://api.github.com/users/ambuc/orgs","repos_url":"https://api.github.com/users/ambuc/repos","events_url":"https://api.github.com/users/ambuc/events{/privacy}","received_events_url":"https://api.github.com/users/ambuc/received_events","type":"User","site_admin":false},"repo":{"id":127915168,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc5MTUxNjg=","name":"envoy","full_name":"ambuc/envoy","owner":{"login":"ambuc","id":6856318,"node_id":"MDQ6VXNlcjY4NTYzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6856318?v=4","gravatar_id":"","url":"https://api.github.com/users/ambuc","html_url":"https://github.com/ambuc","followers_url":"https://api.github.com/users/ambuc/followers","following_url":"https://api.github.com/users/ambuc/following{/other_user}","gists_url":"https://api.github.com/users/ambuc/gists{/gist_id}","starred_url":"https://api.github.com/users/ambuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambuc/subscriptions","organizations_url":"https://api.github.com/users/ambuc/orgs","repos_url":"https://api.github.com/users/ambuc/repos","events_url":"https://api.github.com/users/ambuc/events{/privacy}","received_events_url":"https://api.github.com/users/ambuc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ambuc/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/ambuc/envoy","forks_url":"https://api.github.com/repos/ambuc/envoy/forks","keys_url":"https://api.github.com/repos/ambuc/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambuc/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambuc/envoy/teams","hooks_url":"https://api.github.com/repos/ambuc/envoy/hooks","issue_events_url":"https://api.github.com/repos/ambuc/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/ambuc/envoy/events","assignees_url":"https://api.github.com/repos/ambuc/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/ambuc/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/ambuc/envoy/tags","blobs_url":"https://api.github.com/repos/ambuc/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambuc/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambuc/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambuc/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambuc/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/ambuc/envoy/languages","stargazers_url":"https://api.github.com/repos/ambuc/envoy/stargazers","contributors_url":"https://api.github.com/repos/ambuc/envoy/contributors","subscribers_url":"https://api.github.com/repos/ambuc/envoy/subscribers","subscription_url":"https://api.github.com/repos/ambuc/envoy/subscription","commits_url":"https://api.github.com/repos/ambuc/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambuc/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambuc/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambuc/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambuc/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/ambuc/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambuc/envoy/merges","archive_url":"https://api.github.com/repos/ambuc/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambuc/envoy/downloads","issues_url":"https://api.github.com/repos/ambuc/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/ambuc/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/ambuc/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/ambuc/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambuc/envoy/labels{/name}","releases_url":"https://api.github.com/repos/ambuc/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/ambuc/envoy/deployments","created_at":"2018-04-03T13:47:30Z","updated_at":"2018-08-28T12:51:53Z","pushed_at":"2018-08-28T14:34:50Z","git_url":"git://github.com/ambuc/envoy.git","ssh_url":"git@github.com:ambuc/envoy.git","clone_url":"https://github.com/ambuc/envoy.git","svn_url":"https://github.com/ambuc/envoy","homepage":"https://envoyproxy.github.io/","size":19810,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"da1857d59b500515dd07c691364b8201cb4201e4","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-08-28T14:34:04Z","pushed_at":"2018-08-28T16:31:34Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":19762,"stargazers_count":6354,"watchers_count":6354,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":835,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":835,"open_issues":327,"watchers":6354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3927"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3927"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3927"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3927/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3927/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3927/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/efd3c6f96aa802983326c1d09010cc43ccde0af6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"comments":13,"review_comments":124,"maintainer_can_modify":false,"commits":41,"additions":489,"deletions":0,"changed_files":7}}
{"actor":{"display_login":"htuch"}}