{"action":"created","comment":{"url":"https://api.github.com/repos/geomstats/rgeomstats/pulls/comments/236086168","pull_request_review_id":178093448,"id":236086168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA4NjE2OA==","diff_hunk":"@@ -95,3 +95,43 @@ test_that(\"Tests Vector From Skew Matrix\", {\n   vec.from.skew.matrix <- so3$VectorFromSkewMatrix(skew.mat = skew.mat)\n   expect_equivalent(vec, vec.from.skew.matrix)\n })\n+\n+test_that(\"Tests Vector From Skew Matrix\", {\n+  so3 <- SpecialOrthogonalGroup$new(n = 3)\n+  rot.mat <- array(c(1, 0, 0,\n+                     0, cos(.12), sin(.12),\n+                     0, -sin(.12), cos(.12)), dim = c(3, 3))\n+  rot.vec <- so3$RotationVectorFromMatrix(rot.mat)\n+  expected <- ToNdarray(array(c(.12, 0, 0)), to.ndim = 2)","path":"tests/testthat/test_special_orthogonal_group.R","position":11,"original_position":11,"commit_id":"bef16dbbbc92f482e158e8470fae2819fa4c24bc","original_commit_id":"bef16dbbbc92f482e158e8470fae2819fa4c24bc","user":{"login":"lundjack","id":35204227,"node_id":"MDQ6VXNlcjM1MjA0MjI3","avatar_url":"https://avatars3.githubusercontent.com/u/35204227?v=4","gravatar_id":"","url":"https://api.github.com/users/lundjack","html_url":"https://github.com/lundjack","followers_url":"https://api.github.com/users/lundjack/followers","following_url":"https://api.github.com/users/lundjack/following{/other_user}","gists_url":"https://api.github.com/users/lundjack/gists{/gist_id}","starred_url":"https://api.github.com/users/lundjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lundjack/subscriptions","organizations_url":"https://api.github.com/users/lundjack/orgs","repos_url":"https://api.github.com/users/lundjack/repos","events_url":"https://api.github.com/users/lundjack/events{/privacy}","received_events_url":"https://api.github.com/users/lundjack/received_events","type":"User","site_admin":false},"body":"So this was confusing me at first as well -- and I think the way I have the code written makes it very confusing.  The array function populates a matrix by columns and not rows.   So the rotation matrix is actually \r\n     [,1]      [,2]       [,3]\r\n[1,]    1 0.0000000  0.0000000\r\n[2,]    0 0.9928086 -0.1197122\r\n[3,]    0 0.1197122  0.9928086\r\n\r\nMaybe I will try to use rbind() to make it more readable and intuitive in the future","created_at":"2018-11-25T19:18:47Z","updated_at":"2018-11-25T19:18:47Z","html_url":"https://github.com/geomstats/rgeomstats/pull/23#discussion_r236086168","pull_request_url":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/geomstats/rgeomstats/pulls/comments/236086168"},"html":{"href":"https://github.com/geomstats/rgeomstats/pull/23#discussion_r236086168"},"pull_request":{"href":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23"}},"in_reply_to_id":236080208},"pull_request":{"url":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23","id":233339745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzM5NzQ1","html_url":"https://github.com/geomstats/rgeomstats/pull/23","diff_url":"https://github.com/geomstats/rgeomstats/pull/23.diff","patch_url":"https://github.com/geomstats/rgeomstats/pull/23.patch","issue_url":"https://api.github.com/repos/geomstats/rgeomstats/issues/23","number":23,"state":"open","locked":false,"title":"Special Orthogonal Group functions","user":{"login":"lundjack","id":35204227,"node_id":"MDQ6VXNlcjM1MjA0MjI3","avatar_url":"https://avatars3.githubusercontent.com/u/35204227?v=4","gravatar_id":"","url":"https://api.github.com/users/lundjack","html_url":"https://github.com/lundjack","followers_url":"https://api.github.com/users/lundjack/followers","following_url":"https://api.github.com/users/lundjack/following{/other_user}","gists_url":"https://api.github.com/users/lundjack/gists{/gist_id}","starred_url":"https://api.github.com/users/lundjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lundjack/subscriptions","organizations_url":"https://api.github.com/users/lundjack/orgs","repos_url":"https://api.github.com/users/lundjack/repos","events_url":"https://api.github.com/users/lundjack/events{/privacy}","received_events_url":"https://api.github.com/users/lundjack/received_events","type":"User","site_admin":false},"body":"Rotation Vector From Matrix\r\nMatrix From Rotation Vector\r\nCompose\r\nInverse\r\nRandom Uniform\r\nGroup Exp From Identity\r\nGroup Log From Identity","created_at":"2018-11-24T20:56:50Z","updated_at":"2018-11-25T19:18:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7f46364c8c96b0f4803c2e18681cc5ea878f743","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23/commits","review_comments_url":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23/comments","review_comment_url":"https://api.github.com/repos/geomstats/rgeomstats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geomstats/rgeomstats/issues/23/comments","statuses_url":"https://api.github.com/repos/geomstats/rgeomstats/statuses/bef16dbbbc92f482e158e8470fae2819fa4c24bc","head":{"label":"geomstats:riemannian_metric_1","ref":"riemannian_metric_1","sha":"bef16dbbbc92f482e158e8470fae2819fa4c24bc","user":{"login":"geomstats","id":39272386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMzg2","avatar_url":"https://avatars0.githubusercontent.com/u/39272386?v=4","gravatar_id":"","url":"https://api.github.com/users/geomstats","html_url":"https://github.com/geomstats","followers_url":"https://api.github.com/users/geomstats/followers","following_url":"https://api.github.com/users/geomstats/following{/other_user}","gists_url":"https://api.github.com/users/geomstats/gists{/gist_id}","starred_url":"https://api.github.com/users/geomstats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomstats/subscriptions","organizations_url":"https://api.github.com/users/geomstats/orgs","repos_url":"https://api.github.com/users/geomstats/repos","events_url":"https://api.github.com/users/geomstats/events{/privacy}","received_events_url":"https://api.github.com/users/geomstats/received_events","type":"Organization","site_admin":false},"repo":{"id":148679523,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2Nzk1MjM=","name":"rgeomstats","full_name":"geomstats/rgeomstats","private":false,"owner":{"login":"geomstats","id":39272386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMzg2","avatar_url":"https://avatars0.githubusercontent.com/u/39272386?v=4","gravatar_id":"","url":"https://api.github.com/users/geomstats","html_url":"https://github.com/geomstats","followers_url":"https://api.github.com/users/geomstats/followers","following_url":"https://api.github.com/users/geomstats/following{/other_user}","gists_url":"https://api.github.com/users/geomstats/gists{/gist_id}","starred_url":"https://api.github.com/users/geomstats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomstats/subscriptions","organizations_url":"https://api.github.com/users/geomstats/orgs","repos_url":"https://api.github.com/users/geomstats/repos","events_url":"https://api.github.com/users/geomstats/events{/privacy}","received_events_url":"https://api.github.com/users/geomstats/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geomstats/rgeomstats","description":"Geomstats for R","fork":false,"url":"https://api.github.com/repos/geomstats/rgeomstats","forks_url":"https://api.github.com/repos/geomstats/rgeomstats/forks","keys_url":"https://api.github.com/repos/geomstats/rgeomstats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geomstats/rgeomstats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geomstats/rgeomstats/teams","hooks_url":"https://api.github.com/repos/geomstats/rgeomstats/hooks","issue_events_url":"https://api.github.com/repos/geomstats/rgeomstats/issues/events{/number}","events_url":"https://api.github.com/repos/geomstats/rgeomstats/events","assignees_url":"https://api.github.com/repos/geomstats/rgeomstats/assignees{/user}","branches_url":"https://api.github.com/repos/geomstats/rgeomstats/branches{/branch}","tags_url":"https://api.github.com/repos/geomstats/rgeomstats/tags","blobs_url":"https://api.github.com/repos/geomstats/rgeomstats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geomstats/rgeomstats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geomstats/rgeomstats/git/refs{/sha}","trees_url":"https://api.github.com/repos/geomstats/rgeomstats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geomstats/rgeomstats/statuses/{sha}","languages_url":"https://api.github.com/repos/geomstats/rgeomstats/languages","stargazers_url":"https://api.github.com/repos/geomstats/rgeomstats/stargazers","contributors_url":"https://api.github.com/repos/geomstats/rgeomstats/contributors","subscribers_url":"https://api.github.com/repos/geomstats/rgeomstats/subscribers","subscription_url":"https://api.github.com/repos/geomstats/rgeomstats/subscription","commits_url":"https://api.github.com/repos/geomstats/rgeomstats/commits{/sha}","git_commits_url":"https://api.github.com/repos/geomstats/rgeomstats/git/commits{/sha}","comments_url":"https://api.github.com/repos/geomstats/rgeomstats/comments{/number}","issue_comment_url":"https://api.github.com/repos/geomstats/rgeomstats/issues/comments{/number}","contents_url":"https://api.github.com/repos/geomstats/rgeomstats/contents/{+path}","compare_url":"https://api.github.com/repos/geomstats/rgeomstats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geomstats/rgeomstats/merges","archive_url":"https://api.github.com/repos/geomstats/rgeomstats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geomstats/rgeomstats/downloads","issues_url":"https://api.github.com/repos/geomstats/rgeomstats/issues{/number}","pulls_url":"https://api.github.com/repos/geomstats/rgeomstats/pulls{/number}","milestones_url":"https://api.github.com/repos/geomstats/rgeomstats/milestones{/number}","notifications_url":"https://api.github.com/repos/geomstats/rgeomstats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geomstats/rgeomstats/labels{/name}","releases_url":"https://api.github.com/repos/geomstats/rgeomstats/releases{/id}","deployments_url":"https://api.github.com/repos/geomstats/rgeomstats/deployments","created_at":"2018-09-13T18:19:33Z","updated_at":"2018-11-19T02:52:22Z","pushed_at":"2018-11-24T20:56:50Z","git_url":"git://github.com/geomstats/rgeomstats.git","ssh_url":"git@github.com:geomstats/rgeomstats.git","clone_url":"https://github.com/geomstats/rgeomstats.git","svn_url":"https://github.com/geomstats/rgeomstats","homepage":null,"size":8380,"stargazers_count":1,"watchers_count":1,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"geomstats:master","ref":"master","sha":"e17a1201ef91ddd4704e9d2ad3039005125fd791","user":{"login":"geomstats","id":39272386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMzg2","avatar_url":"https://avatars0.githubusercontent.com/u/39272386?v=4","gravatar_id":"","url":"https://api.github.com/users/geomstats","html_url":"https://github.com/geomstats","followers_url":"https://api.github.com/users/geomstats/followers","following_url":"https://api.github.com/users/geomstats/following{/other_user}","gists_url":"https://api.github.com/users/geomstats/gists{/gist_id}","starred_url":"https://api.github.com/users/geomstats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomstats/subscriptions","organizations_url":"https://api.github.com/users/geomstats/orgs","repos_url":"https://api.github.com/users/geomstats/repos","events_url":"https://api.github.com/users/geomstats/events{/privacy}","received_events_url":"https://api.github.com/users/geomstats/received_events","type":"Organization","site_admin":false},"repo":{"id":148679523,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2Nzk1MjM=","name":"rgeomstats","full_name":"geomstats/rgeomstats","private":false,"owner":{"login":"geomstats","id":39272386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMzg2","avatar_url":"https://avatars0.githubusercontent.com/u/39272386?v=4","gravatar_id":"","url":"https://api.github.com/users/geomstats","html_url":"https://github.com/geomstats","followers_url":"https://api.github.com/users/geomstats/followers","following_url":"https://api.github.com/users/geomstats/following{/other_user}","gists_url":"https://api.github.com/users/geomstats/gists{/gist_id}","starred_url":"https://api.github.com/users/geomstats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geomstats/subscriptions","organizations_url":"https://api.github.com/users/geomstats/orgs","repos_url":"https://api.github.com/users/geomstats/repos","events_url":"https://api.github.com/users/geomstats/events{/privacy}","received_events_url":"https://api.github.com/users/geomstats/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geomstats/rgeomstats","description":"Geomstats for R","fork":false,"url":"https://api.github.com/repos/geomstats/rgeomstats","forks_url":"https://api.github.com/repos/geomstats/rgeomstats/forks","keys_url":"https://api.github.com/repos/geomstats/rgeomstats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geomstats/rgeomstats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geomstats/rgeomstats/teams","hooks_url":"https://api.github.com/repos/geomstats/rgeomstats/hooks","issue_events_url":"https://api.github.com/repos/geomstats/rgeomstats/issues/events{/number}","events_url":"https://api.github.com/repos/geomstats/rgeomstats/events","assignees_url":"https://api.github.com/repos/geomstats/rgeomstats/assignees{/user}","branches_url":"https://api.github.com/repos/geomstats/rgeomstats/branches{/branch}","tags_url":"https://api.github.com/repos/geomstats/rgeomstats/tags","blobs_url":"https://api.github.com/repos/geomstats/rgeomstats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geomstats/rgeomstats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geomstats/rgeomstats/git/refs{/sha}","trees_url":"https://api.github.com/repos/geomstats/rgeomstats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geomstats/rgeomstats/statuses/{sha}","languages_url":"https://api.github.com/repos/geomstats/rgeomstats/languages","stargazers_url":"https://api.github.com/repos/geomstats/rgeomstats/stargazers","contributors_url":"https://api.github.com/repos/geomstats/rgeomstats/contributors","subscribers_url":"https://api.github.com/repos/geomstats/rgeomstats/subscribers","subscription_url":"https://api.github.com/repos/geomstats/rgeomstats/subscription","commits_url":"https://api.github.com/repos/geomstats/rgeomstats/commits{/sha}","git_commits_url":"https://api.github.com/repos/geomstats/rgeomstats/git/commits{/sha}","comments_url":"https://api.github.com/repos/geomstats/rgeomstats/comments{/number}","issue_comment_url":"https://api.github.com/repos/geomstats/rgeomstats/issues/comments{/number}","contents_url":"https://api.github.com/repos/geomstats/rgeomstats/contents/{+path}","compare_url":"https://api.github.com/repos/geomstats/rgeomstats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geomstats/rgeomstats/merges","archive_url":"https://api.github.com/repos/geomstats/rgeomstats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geomstats/rgeomstats/downloads","issues_url":"https://api.github.com/repos/geomstats/rgeomstats/issues{/number}","pulls_url":"https://api.github.com/repos/geomstats/rgeomstats/pulls{/number}","milestones_url":"https://api.github.com/repos/geomstats/rgeomstats/milestones{/number}","notifications_url":"https://api.github.com/repos/geomstats/rgeomstats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geomstats/rgeomstats/labels{/name}","releases_url":"https://api.github.com/repos/geomstats/rgeomstats/releases{/id}","deployments_url":"https://api.github.com/repos/geomstats/rgeomstats/deployments","created_at":"2018-09-13T18:19:33Z","updated_at":"2018-11-19T02:52:22Z","pushed_at":"2018-11-24T20:56:50Z","git_url":"git://github.com/geomstats/rgeomstats.git","ssh_url":"git@github.com:geomstats/rgeomstats.git","clone_url":"https://github.com/geomstats/rgeomstats.git","svn_url":"https://github.com/geomstats/rgeomstats","homepage":null,"size":8380,"stargazers_count":1,"watchers_count":1,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23"},"html":{"href":"https://github.com/geomstats/rgeomstats/pull/23"},"issue":{"href":"https://api.github.com/repos/geomstats/rgeomstats/issues/23"},"comments":{"href":"https://api.github.com/repos/geomstats/rgeomstats/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/geomstats/rgeomstats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geomstats/rgeomstats/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/geomstats/rgeomstats/statuses/bef16dbbbc92f482e158e8470fae2819fa4c24bc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lundjack"}}