{"action":"opened","issue":{"url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2550","repository_url":"https://api.github.com/repos/ag-grid/ag-grid","labels_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2550/labels{/name}","comments_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2550/comments","events_url":"https://api.github.com/repos/ag-grid/ag-grid/issues/2550/events","html_url":"https://github.com/ag-grid/ag-grid/issues/2550","id":347866639,"node_id":"MDU6SXNzdWUzNDc4NjY2Mzk=","number":2550,"title":"tabToNextCell return wrong value in edit mode","user":{"login":"tonyjiang88215","id":8650041,"node_id":"MDQ6VXNlcjg2NTAwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8650041?v=4","gravatar_id":"","url":"https://api.github.com/users/tonyjiang88215","html_url":"https://github.com/tonyjiang88215","followers_url":"https://api.github.com/users/tonyjiang88215/followers","following_url":"https://api.github.com/users/tonyjiang88215/following{/other_user}","gists_url":"https://api.github.com/users/tonyjiang88215/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyjiang88215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyjiang88215/subscriptions","organizations_url":"https://api.github.com/users/tonyjiang88215/orgs","repos_url":"https://api.github.com/users/tonyjiang88215/repos","events_url":"https://api.github.com/users/tonyjiang88215/events{/privacy}","received_events_url":"https://api.github.com/users/tonyjiang88215/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-06T10:26:57Z","updated_at":"2018-08-06T10:26:57Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING\r\n-->\r\n\r\n**I'm submitting a ...**  (check one with \"x\")\r\n```\r\n[x] bug report => search github for a similar issue or PR before submitting\r\n[ ] feature request\r\n[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid/blob/master/CONTRIBUTING.md#question\r\n```\r\n\r\n**Current behavior**\r\n<!-- Describe how the bug manifests. -->\r\nI use the tabToNextCell return value to determine if there is any next editable cell. When I use floatingBottom, when the last editable cell in the middle area is in edit mode, press tab, tabToNextCell will return true, and the focus will be positioned in the first row of the floatingBottom area. However, I am in the source code rowRenderer.ts line 1117, which returns true if the next cell is editable. This makes me wonder, in the edit state, if the current cell is already the last editable cell, what will be returned by calling tabToNextCell.\r\n\r\n**Expected behavior**\r\n<!-- Describe what the behavior would be without the bug. -->\r\nIf the current cell is already the last editable cell and is currently in edit mode, then calling TabToNextCell should return false\r\n\r\n**Minimal reproduction of the problem with instructions**\r\n<!--\r\nIf the current behavior is a bug or you can illustrate your feature request better with an example,\r\nplease provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://plnkr.co or similar (you can use this template as a starting point: https://plnkr.co/edit/369YrrgCVrnPjD528OtT).\r\n-->\r\nThere is a row of data in the middle area and the floatingBottom area. Set the floattingBottom line through colDef to be uneditable, start editing the last cell in the middle area, and then press the tab key.\r\n\r\n**What is the motivation / use case for changing the behavior?**\r\n<!-- Describe the motivation or the concrete use case -->\r\nThe return value of tabToNextCell can be used to determine if there is a next editable cell.\r\n\r\n**Please tell us about your environment:**\r\n<!-- Operating system, IDE, package manager, HTTP server, ... -->\r\nMac OS Sierra 10.12.6\r\n\r\n* **ag-Grid version:** X.X.X\r\n<!-- Check whether this is still an issue in the most recent ag-Grid version -->\r\n18.1.2\r\n\r\n\r\n* **Browser:**\r\n<!-- Run `navigator.userAgent` in console of all of the browsers where this could be reproduced -->\r\nMozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36\r\n\r\n* **Language:** [all | TypeScript X.X | ES6/7 | ES5]\r\nTypeScript 2.9.1\r\n\r\n"}}
{"actor":{"display_login":"tonyjiang88215"}}