{"action":"created","issue":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/896","repository_url":"https://api.github.com/repos/amethyst/amethyst","labels_url":"https://api.github.com/repos/amethyst/amethyst/issues/896/labels{/name}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/896/comments","events_url":"https://api.github.com/repos/amethyst/amethyst/issues/896/events","html_url":"https://github.com/amethyst/amethyst/pull/896","id":352796323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDE1MTI0","number":896,"title":"Use Cow<'static, str> in Named","user":{"login":"randomPoison","id":1900829,"node_id":"MDQ6VXNlcjE5MDA4Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1900829?v=4","gravatar_id":"","url":"https://api.github.com/users/randomPoison","html_url":"https://github.com/randomPoison","followers_url":"https://api.github.com/users/randomPoison/followers","following_url":"https://api.github.com/users/randomPoison/following{/other_user}","gists_url":"https://api.github.com/users/randomPoison/gists{/gist_id}","starred_url":"https://api.github.com/users/randomPoison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomPoison/subscriptions","organizations_url":"https://api.github.com/users/randomPoison/orgs","repos_url":"https://api.github.com/users/randomPoison/repos","events_url":"https://api.github.com/users/randomPoison/events{/privacy}","received_events_url":"https://api.github.com/users/randomPoison/received_events","type":"User","site_admin":false},"labels":[{"id":725482404,"node_id":"MDU6TGFiZWw3MjU0ODI0MDQ=","url":"https://api.github.com/repos/amethyst/amethyst/labels/project:%20core","name":"project: core","color":"0e8a16","default":false},{"id":681253081,"node_id":"MDU6TGFiZWw2ODEyNTMwODE=","url":"https://api.github.com/repos/amethyst/amethyst/labels/status:%20ready","name":"status: ready","color":"bfe5bf","default":false},{"id":302199478,"node_id":"MDU6TGFiZWwzMDIxOTk0Nzg=","url":"https://api.github.com/repos/amethyst/amethyst/labels/type:%20improvement","name":"type: improvement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-22T04:07:24Z","updated_at":"2018-08-22T15:46:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/896","html_url":"https://github.com/amethyst/amethyst/pull/896","diff_url":"https://github.com/amethyst/amethyst/pull/896.diff","patch_url":"https://github.com/amethyst/amethyst/pull/896.patch"},"body":"Switch `Named` to represent the name using `Cow<'static, str>` instead of `&'static str` so that we can use `Named` for dynamically-generated names and names loaded from data files. The motivator here is that I would like to use `Named` for loading node names from glTF files, but it would have to support storing the names as `String`. Using `Cow<'static, str>` allows us to store `String` names without requiring an allocation if the users simply wants to use a string constant for the name.\r\n\r\nI also added more documentation for `Named`, including a bunch of examples.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/amethyst/amethyst/896)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/comments/415079983","html_url":"https://github.com/amethyst/amethyst/pull/896#issuecomment-415079983","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/896","id":415079983,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTA3OTk4Mw==","user":{"login":"Moxinilian","id":30992420,"node_id":"MDQ6VXNlcjMwOTkyNDIw","avatar_url":"https://avatars0.githubusercontent.com/u/30992420?v=4","gravatar_id":"","url":"https://api.github.com/users/Moxinilian","html_url":"https://github.com/Moxinilian","followers_url":"https://api.github.com/users/Moxinilian/followers","following_url":"https://api.github.com/users/Moxinilian/following{/other_user}","gists_url":"https://api.github.com/users/Moxinilian/gists{/gist_id}","starred_url":"https://api.github.com/users/Moxinilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moxinilian/subscriptions","organizations_url":"https://api.github.com/users/Moxinilian/orgs","repos_url":"https://api.github.com/users/Moxinilian/repos","events_url":"https://api.github.com/users/Moxinilian/events{/privacy}","received_events_url":"https://api.github.com/users/Moxinilian/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T15:46:05Z","updated_at":"2018-08-22T15:46:05Z","author_association":"MEMBER","body":"I think having a constant size pre-allocated string might indeed be a better solution."}}
{"actor":{"display_login":"Moxinilian"}}