{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/197896737","pull_request_review_id":131729870,"id":197896737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg5NjczNw==","diff_hunk":"@@ -180,6 +186,11 @@ static int uart_nrfx_fifo_fill(struct device *dev,\n {\n \tu8_t num_tx = 0;\n \n+\t/* First byte was sent, from now on relay on NRF_UART_EVENT_TXDRDY event\n+\t * status.","path":"drivers/serial/uart_nrfx_uart.c","position":25,"original_position":25,"commit_id":"a7005dbf841969649510ae91cea2c977c54dad82","original_commit_id":"a7005dbf841969649510ae91cea2c977c54dad82","user":{"login":"ioannisg","id":2333931,"node_id":"MDQ6VXNlcjIzMzM5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2333931?v=4","gravatar_id":"","url":"https://api.github.com/users/ioannisg","html_url":"https://github.com/ioannisg","followers_url":"https://api.github.com/users/ioannisg/followers","following_url":"https://api.github.com/users/ioannisg/following{/other_user}","gists_url":"https://api.github.com/users/ioannisg/gists{/gist_id}","starred_url":"https://api.github.com/users/ioannisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioannisg/subscriptions","organizations_url":"https://api.github.com/users/ioannisg/orgs","repos_url":"https://api.github.com/users/ioannisg/repos","events_url":"https://api.github.com/users/ioannisg/events{/privacy}","received_events_url":"https://api.github.com/users/ioannisg/received_events","type":"User","site_admin":false},"body":"Same comment as above","created_at":"2018-06-25T18:29:14Z","updated_at":"2018-06-25T18:42:16Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8552#discussion_r197896737","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/197896737"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/8552#discussion_r197896737"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552","id":197121386,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTIxMzg2","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8552","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8552.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8552.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8552","number":8552,"state":"open","locked":false,"title":"drivers: uart: nrf: fixing interrupt driven API","user":{"login":"jarz-nordic","id":34125330,"node_id":"MDQ6VXNlcjM0MTI1MzMw","avatar_url":"https://avatars1.githubusercontent.com/u/34125330?v=4","gravatar_id":"","url":"https://api.github.com/users/jarz-nordic","html_url":"https://github.com/jarz-nordic","followers_url":"https://api.github.com/users/jarz-nordic/followers","following_url":"https://api.github.com/users/jarz-nordic/following{/other_user}","gists_url":"https://api.github.com/users/jarz-nordic/gists{/gist_id}","starred_url":"https://api.github.com/users/jarz-nordic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarz-nordic/subscriptions","organizations_url":"https://api.github.com/users/jarz-nordic/orgs","repos_url":"https://api.github.com/users/jarz-nordic/repos","events_url":"https://api.github.com/users/jarz-nordic/events{/privacy}","received_events_url":"https://api.github.com/users/jarz-nordic/received_events","type":"User","site_admin":false},"body":"Implemented API functions: uart_nrfx_irq_tx_complete\r\nand uart_nrfx_irq_tx_ready were returning not correct\r\nvalues.\r\n\r\n1. uart_nrfx_irq_tx_complete was returning wrong\r\nvalue once first byte was send.\r\n2. uart_nrfx_irq_tx_ready was returning wrong\r\nvalue before first byte was send.\r\n\r\nSigned-off-by: Jakub Rzeszutko <jakub.rzeszutko@nordicsemi.no>","created_at":"2018-06-25T13:56:14Z","updated_at":"2018-06-25T18:42:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0405c33401cd39c18cc2480d5887320b7e65ce2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":725894905,"node_id":"MDU6TGFiZWw3MjU4OTQ5MDU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/nRF","name":"nRF","color":"39a9db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8552/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/a7005dbf841969649510ae91cea2c977c54dad82","head":{"label":"jarz-nordic:uart_fix_interrupt_driven_api","ref":"uart_fix_interrupt_driven_api","sha":"a7005dbf841969649510ae91cea2c977c54dad82","user":{"login":"jarz-nordic","id":34125330,"node_id":"MDQ6VXNlcjM0MTI1MzMw","avatar_url":"https://avatars1.githubusercontent.com/u/34125330?v=4","gravatar_id":"","url":"https://api.github.com/users/jarz-nordic","html_url":"https://github.com/jarz-nordic","followers_url":"https://api.github.com/users/jarz-nordic/followers","following_url":"https://api.github.com/users/jarz-nordic/following{/other_user}","gists_url":"https://api.github.com/users/jarz-nordic/gists{/gist_id}","starred_url":"https://api.github.com/users/jarz-nordic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarz-nordic/subscriptions","organizations_url":"https://api.github.com/users/jarz-nordic/orgs","repos_url":"https://api.github.com/users/jarz-nordic/repos","events_url":"https://api.github.com/users/jarz-nordic/events{/privacy}","received_events_url":"https://api.github.com/users/jarz-nordic/received_events","type":"User","site_admin":false},"repo":{"id":133949792,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5NDk3OTI=","name":"zephyr","full_name":"jarz-nordic/zephyr","owner":{"login":"jarz-nordic","id":34125330,"node_id":"MDQ6VXNlcjM0MTI1MzMw","avatar_url":"https://avatars1.githubusercontent.com/u/34125330?v=4","gravatar_id":"","url":"https://api.github.com/users/jarz-nordic","html_url":"https://github.com/jarz-nordic","followers_url":"https://api.github.com/users/jarz-nordic/followers","following_url":"https://api.github.com/users/jarz-nordic/following{/other_user}","gists_url":"https://api.github.com/users/jarz-nordic/gists{/gist_id}","starred_url":"https://api.github.com/users/jarz-nordic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarz-nordic/subscriptions","organizations_url":"https://api.github.com/users/jarz-nordic/orgs","repos_url":"https://api.github.com/users/jarz-nordic/repos","events_url":"https://api.github.com/users/jarz-nordic/events{/privacy}","received_events_url":"https://api.github.com/users/jarz-nordic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jarz-nordic/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/jarz-nordic/zephyr","forks_url":"https://api.github.com/repos/jarz-nordic/zephyr/forks","keys_url":"https://api.github.com/repos/jarz-nordic/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarz-nordic/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarz-nordic/zephyr/teams","hooks_url":"https://api.github.com/repos/jarz-nordic/zephyr/hooks","issue_events_url":"https://api.github.com/repos/jarz-nordic/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/jarz-nordic/zephyr/events","assignees_url":"https://api.github.com/repos/jarz-nordic/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/jarz-nordic/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/jarz-nordic/zephyr/tags","blobs_url":"https://api.github.com/repos/jarz-nordic/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarz-nordic/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarz-nordic/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarz-nordic/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarz-nordic/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/jarz-nordic/zephyr/languages","stargazers_url":"https://api.github.com/repos/jarz-nordic/zephyr/stargazers","contributors_url":"https://api.github.com/repos/jarz-nordic/zephyr/contributors","subscribers_url":"https://api.github.com/repos/jarz-nordic/zephyr/subscribers","subscription_url":"https://api.github.com/repos/jarz-nordic/zephyr/subscription","commits_url":"https://api.github.com/repos/jarz-nordic/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarz-nordic/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarz-nordic/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarz-nordic/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarz-nordic/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/jarz-nordic/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarz-nordic/zephyr/merges","archive_url":"https://api.github.com/repos/jarz-nordic/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarz-nordic/zephyr/downloads","issues_url":"https://api.github.com/repos/jarz-nordic/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/jarz-nordic/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/jarz-nordic/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/jarz-nordic/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarz-nordic/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/jarz-nordic/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/jarz-nordic/zephyr/deployments","created_at":"2018-05-18T12:12:27Z","updated_at":"2018-06-22T08:40:41Z","pushed_at":"2018-06-25T13:55:13Z","git_url":"git://github.com/jarz-nordic/zephyr.git","ssh_url":"git@github.com:jarz-nordic/zephyr.git","clone_url":"https://github.com/jarz-nordic/zephyr.git","svn_url":"https://github.com/jarz-nordic/zephyr","homepage":"https://zephyrproject.org/doc","size":114501,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"daef3cc5bebe99f43f48513d5d4ebff1e0ddeae5","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-06-25T17:35:20Z","pushed_at":"2018-06-25T18:30:57Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":114652,"stargazers_count":917,"watchers_count":917,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":659,"mirror_url":null,"archived":false,"open_issues_count":933,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":659,"open_issues":933,"watchers":917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/8552"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8552"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8552/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8552/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/a7005dbf841969649510ae91cea2c977c54dad82"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ioannisg"}}