{"action":"created","issue":{"url":"https://api.github.com/repos/ccorcos/meteor-subs-cache/issues/59","repository_url":"https://api.github.com/repos/ccorcos/meteor-subs-cache","labels_url":"https://api.github.com/repos/ccorcos/meteor-subs-cache/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/ccorcos/meteor-subs-cache/issues/59/comments","events_url":"https://api.github.com/repos/ccorcos/meteor-subs-cache/issues/59/events","html_url":"https://github.com/ccorcos/meteor-subs-cache/issues/59","id":326304303,"node_id":"MDU6SXNzdWUzMjYzMDQzMDM=","number":59,"title":"Subscriptions should always be stopped if the cacheLimit is reached","user":{"login":"santiagopuentep","id":137173,"node_id":"MDQ6VXNlcjEzNzE3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/137173?v=4","gravatar_id":"","url":"https://api.github.com/users/santiagopuentep","html_url":"https://github.com/santiagopuentep","followers_url":"https://api.github.com/users/santiagopuentep/followers","following_url":"https://api.github.com/users/santiagopuentep/following{/other_user}","gists_url":"https://api.github.com/users/santiagopuentep/gists{/gist_id}","starred_url":"https://api.github.com/users/santiagopuentep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiagopuentep/subscriptions","organizations_url":"https://api.github.com/users/santiagopuentep/orgs","repos_url":"https://api.github.com/users/santiagopuentep/repos","events_url":"https://api.github.com/users/santiagopuentep/events{/privacy}","received_events_url":"https://api.github.com/users/santiagopuentep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-24T21:36:40Z","updated_at":"2018-08-17T22:35:34Z","closed_at":null,"author_association":"NONE","body":"The subscriptions should be stopped when the cacheLimit is reached even if the expireAfter has not expired yet.\r\n\r\nWithout this it the cacheLimit is useless when the expireAfter is set to something other than -1 because the subscriptions keep pilling up indefinitely."},"comment":{"url":"https://api.github.com/repos/ccorcos/meteor-subs-cache/issues/comments/414004708","html_url":"https://github.com/ccorcos/meteor-subs-cache/issues/59#issuecomment-414004708","issue_url":"https://api.github.com/repos/ccorcos/meteor-subs-cache/issues/59","id":414004708,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDAwNDcwOA==","user":{"login":"paranoico","id":16200983,"node_id":"MDQ6VXNlcjE2MjAwOTgz","avatar_url":"https://avatars3.githubusercontent.com/u/16200983?v=4","gravatar_id":"","url":"https://api.github.com/users/paranoico","html_url":"https://github.com/paranoico","followers_url":"https://api.github.com/users/paranoico/followers","following_url":"https://api.github.com/users/paranoico/following{/other_user}","gists_url":"https://api.github.com/users/paranoico/gists{/gist_id}","starred_url":"https://api.github.com/users/paranoico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paranoico/subscriptions","organizations_url":"https://api.github.com/users/paranoico/orgs","repos_url":"https://api.github.com/users/paranoico/repos","events_url":"https://api.github.com/users/paranoico/events{/privacy}","received_events_url":"https://api.github.com/users/paranoico/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T22:35:34Z","updated_at":"2018-08-17T22:35:34Z","author_association":"COLLABORATOR","body":"Good points you have there, regarding each one:\r\n\r\na) If user can chose to not stop oldest subs on limit reach, then to me it is the same like setting expireAfter = -1, isn't it?\r\n\r\nb) The only way app can decide when to stop sub is calling the stop method, otherwise how can the app make an automatic decision?\r\n\r\nc) If sub is just rejected then it should behaviour like a normal Meteor subscription, to me it leaks to an unpredictable behaviour or at least a difficult one to debug, how can we avoid this? May be a master cached collection where last state of everyone is record, but anyway it could be hard to debug, isn't it?\r\n"}}
{"actor":{"display_login":"paranoico"}}