{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/34711","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/34711/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/34711/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/34711/events","html_url":"https://github.com/Microsoft/vscode/issues/34711","id":259248749,"node_id":"MDU6SXNzdWUyNTkyNDg3NDk=","number":34711,"title":"workspaceContains starts a search over full workspace, including .git/, node_modules/","user":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"labels":[{"id":433482510,"node_id":"MDU6TGFiZWw0MzM0ODI1MTA=","url":"https://api.github.com/repos/Microsoft/vscode/labels/extension-host","name":"extension-host","color":"1d76db","default":false},{"id":272689392,"node_id":"MDU6TGFiZWwyNzI2ODkzOTI=","url":"https://api.github.com/repos/Microsoft/vscode/labels/feature-request","name":"feature-request","color":"dcdcdc","default":false},{"id":467708547,"node_id":"MDU6TGFiZWw0Njc3MDg1NDc=","url":"https://api.github.com/repos/Microsoft/vscode/labels/perf","name":"perf","color":"eb6420","default":false},{"id":738780536,"node_id":"MDU6TGFiZWw3Mzg3ODA1MzY=","url":"https://api.github.com/repos/Microsoft/vscode/labels/perf-startup","name":"perf-startup","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"assignees":[{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},{"login":"alexandrudima","id":5047891,"node_id":"MDQ6VXNlcjUwNDc4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5047891?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrudima","html_url":"https://github.com/alexandrudima","followers_url":"https://api.github.com/users/alexandrudima/followers","following_url":"https://api.github.com/users/alexandrudima/following{/other_user}","gists_url":"https://api.github.com/users/alexandrudima/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrudima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrudima/subscriptions","organizations_url":"https://api.github.com/users/alexandrudima/orgs","repos_url":"https://api.github.com/users/alexandrudima/repos","events_url":"https://api.github.com/users/alexandrudima/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrudima/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/74","html_url":"https://github.com/Microsoft/vscode/milestone/74","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/74/labels","id":3505354,"node_id":"MDk6TWlsZXN0b25lMzUwNTM1NA==","number":74,"title":"August 2018","description":"","creator":{"login":"isidorn","id":1926584,"node_id":"MDQ6VXNlcjE5MjY1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false},"open_issues":195,"closed_issues":229,"state":"open","created_at":"2018-07-18T09:23:10Z","updated_at":"2018-08-20T18:30:43Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"comments":29,"created_at":"2017-09-20T17:53:29Z","updated_at":"2018-08-20T20:41:58Z","closed_at":null,"author_association":"MEMBER","body":"https://github.com/Microsoft/vscode/issues/34487 made one improvement by batching workspaceContains searches.\r\n\r\nKeeping this one open to consider excluding .git and node_modules in a smart way, which could give a huge improvement.\r\n\r\ncc @jrieken @alexandrudima \r\n\r\n>>> We should include the exclude settings, or hardcode an exclusion to a few folders.\r\n>>\r\n>> So, how do you then active on .git/HEAD?\r\n>\r\n> Maybe add some smartness to search .git/ or node_modules/ if it's explicitly mentioned in the workspaceContains: search glob?"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/414456042","html_url":"https://github.com/Microsoft/vscode/issues/34711#issuecomment-414456042","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/34711","id":414456042,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQ1NjA0Mg==","user":{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T20:41:58Z","updated_at":"2018-08-20T20:41:58Z","author_association":"MEMBER","body":"Telling rg to use fewer threads is also something we can do. I don't know how that fits into the extension api though."}}
{"actor":{"display_login":"roblourens"}}