{"action":"created","comment":{"url":"https://api.github.com/repos/igmhub/picca/pulls/comments/192797075","pull_request_review_id":125640629,"id":192797075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc5NzA3NQ==","diff_hunk":"@@ -9,83 +9,97 @@\n from picca import constants, xcf, io, prep_del, utils\n from picca.data import forest\n \n-def corr_func(p):\n-    xcf.fill_neighs(p)\n-    tmp = xcf.xcf(p)\n-    return tmp\n+def corr_func(pixels):\n+    \"\"\"Send correlation on one processor for a list of healpix\n+    \n+    Args:\n+        pixels (list of int): list of healpix to compute\n+            the correlation on.\n+\n+    Returs:\n+        cor (list of scipy array): list of array with the\n+            computed correlation and other attributes.\n+    \n+    \"\"\"\n+    xcf.fill_neighs(pixels)\n+    cor = xcf.xcf(pixels)\n+    return cor\n \n if __name__ == '__main__':\n \n-    parser = argparse.ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter)\n+    parser = argparse.ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter,\n+        description='Compute the cross-correlation between a catalog of objects and a delta field.')\n \n-    parser.add_argument('--out', type = str, default = None, required=True,\n-                        help = 'output file name')\n+    parser.add_argument('--out', type=str, default=None, required=True,\n+        help = 'Output file name')\n \n-    parser.add_argument('--in-dir', type = str, default = None, required=True,\n-                        help = 'data directory')\n+    parser.add_argument('--in-dir', type=str, default=None, required=True,\n+        help = 'Directory to delta files')\n \n-    parser.add_argument('--drq', type = str, default = None, required=True,\n-                        help = 'drq')\n+    parser.add_argument('--from-image', type=str, default=None, required=False,\n+        help = 'Read delta from image format', nargs='*')\n \n-    parser.add_argument('--rp-max', type = float, default = 200., required=False,\n-                        help = 'max rp [h^-1 Mpc]')\n+    parser.add_argument('--drq', type=str, default=None, required=True,\n+        help = 'Catalog of objects in DRQ format')\n \n-    parser.add_argument('--rp-min', type = float, default = -200., required=False,\n-                        help = 'min rp [h^-1 Mpc]')\n+    parser.add_argument('--rp-min', type=float, default=-200., required=False,\n+        help = 'Min r-parallel [h^-1 Mpc]')\n \n-    parser.add_argument('--rt-max', type = float, default = 200., required=False,\n-                        help = 'max rt [h^-1 Mpc]')\n+    parser.add_argument('--rp-max', type=float, default=200., required=False,\n+        help = 'Max r-parallel [h^-1 Mpc]')\n \n-    parser.add_argument('--np', type = int, default = 100, required=False,\n-                        help = 'number of r-parallel bins')\n+    parser.add_argument('--rt-max', type=float, default=200., required=False,\n+        help = 'Max r-transverse [h^-1 Mpc]')\n \n-    parser.add_argument('--nt', type = int, default = 50, required=False,\n-                        help = 'number of r-transverse bins')\n+    parser.add_argument('--np', type=int, default=100, required=False,\n+        help = 'Number of r-parallel bins')\n \n-    parser.add_argument('--lambda-abs', type = str, default = 'LYA', required=False,\n-                        help = 'name of the absorption in picca.constants')\n+    parser.add_argument('--nt', type=int, default=50, required=False,\n+        help = 'Number of r-transverse bins')\n \n-    parser.add_argument('--fid-Om', type = float, default = 0.315, required=False,\n-                    help = 'Om of fiducial cosmology')\n+    parser.add_argument('--z-min-obj', type=float, default=None, required=False,\n+        help = 'Min redshift for object field')\n \n-    parser.add_argument('--nside', type = int, default = 16, required=False,\n-                    help = 'healpix nside')\n+    parser.add_argument('--z-max-obj', type=float, default=None, required=False,\n+        help = 'Max redshift for object field')\n \n-    parser.add_argument('--nproc', type = int, default = None, required=False,\n-                    help = 'number of processors')\n+    parser.add_argument('--z-cut-min', type = float, default=0., required=False,\n+        help = 'Use only pairs of forest x object with the mean of the last absorber \\\n+        redshift and the object redshift higher than z-cut-min')","path":"bin/do_xcf.py","position":89,"original_position":89,"commit_id":"0d287177cd905959f7f5c651b053b6b037b25792","original_commit_id":"0d287177cd905959f7f5c651b053b6b037b25792","user":{"login":"mblomqvist","id":2251656,"node_id":"MDQ6VXNlcjIyNTE2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2251656?v=4","gravatar_id":"","url":"https://api.github.com/users/mblomqvist","html_url":"https://github.com/mblomqvist","followers_url":"https://api.github.com/users/mblomqvist/followers","following_url":"https://api.github.com/users/mblomqvist/following{/other_user}","gists_url":"https://api.github.com/users/mblomqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/mblomqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mblomqvist/subscriptions","organizations_url":"https://api.github.com/users/mblomqvist/orgs","repos_url":"https://api.github.com/users/mblomqvist/repos","events_url":"https://api.github.com/users/mblomqvist/events{/privacy}","received_events_url":"https://api.github.com/users/mblomqvist/received_events","type":"User","site_admin":false},"body":"larger than","created_at":"2018-06-04T16:09:27Z","updated_at":"2018-06-04T16:12:29Z","html_url":"https://github.com/igmhub/picca/pull/446#discussion_r192797075","pull_request_url":"https://api.github.com/repos/igmhub/picca/pulls/446","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/igmhub/picca/pulls/comments/192797075"},"html":{"href":"https://github.com/igmhub/picca/pull/446#discussion_r192797075"},"pull_request":{"href":"https://api.github.com/repos/igmhub/picca/pulls/446"}}},"pull_request":{"url":"https://api.github.com/repos/igmhub/picca/pulls/446","id":192441467,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNDQxNDY3","html_url":"https://github.com/igmhub/picca/pull/446","diff_url":"https://github.com/igmhub/picca/pull/446.diff","patch_url":"https://github.com/igmhub/picca/pull/446.patch","issue_url":"https://api.github.com/repos/igmhub/picca/issues/446","number":446,"state":"open","locked":false,"title":"Better documentation","user":{"login":"londumas","id":3166436,"node_id":"MDQ6VXNlcjMxNjY0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3166436?v=4","gravatar_id":"","url":"https://api.github.com/users/londumas","html_url":"https://github.com/londumas","followers_url":"https://api.github.com/users/londumas/followers","following_url":"https://api.github.com/users/londumas/following{/other_user}","gists_url":"https://api.github.com/users/londumas/gists{/gist_id}","starred_url":"https://api.github.com/users/londumas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/londumas/subscriptions","organizations_url":"https://api.github.com/users/londumas/orgs","repos_url":"https://api.github.com/users/londumas/repos","events_url":"https://api.github.com/users/londumas/events{/privacy}","received_events_url":"https://api.github.com/users/londumas/received_events","type":"User","site_admin":false},"body":"Here is a commit at a proposition of better documentation.\r\nMy goal is for us to agree on one file and then go very fast on the rest of them.\r\nPlease @ngbusca and @mblomqvist, tell me what you think about name of variables\r\nand comments.\r\nStep toward fixing https://github.com/igmhub/picca/issues/434","created_at":"2018-06-04T15:14:28Z","updated_at":"2018-06-04T16:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d557a4b072606c5984be5434203b3c2edc5a6120","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ngbusca","id":4727509,"node_id":"MDQ6VXNlcjQ3Mjc1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/4727509?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbusca","html_url":"https://github.com/ngbusca","followers_url":"https://api.github.com/users/ngbusca/followers","following_url":"https://api.github.com/users/ngbusca/following{/other_user}","gists_url":"https://api.github.com/users/ngbusca/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbusca/subscriptions","organizations_url":"https://api.github.com/users/ngbusca/orgs","repos_url":"https://api.github.com/users/ngbusca/repos","events_url":"https://api.github.com/users/ngbusca/events{/privacy}","received_events_url":"https://api.github.com/users/ngbusca/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/igmhub/picca/pulls/446/commits","review_comments_url":"https://api.github.com/repos/igmhub/picca/pulls/446/comments","review_comment_url":"https://api.github.com/repos/igmhub/picca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igmhub/picca/issues/446/comments","statuses_url":"https://api.github.com/repos/igmhub/picca/statuses/0d287177cd905959f7f5c651b053b6b037b25792","head":{"label":"igmhub:better_documentation","ref":"better_documentation","sha":"0d287177cd905959f7f5c651b053b6b037b25792","user":{"login":"igmhub","id":24413275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NDEzMjc1","avatar_url":"https://avatars2.githubusercontent.com/u/24413275?v=4","gravatar_id":"","url":"https://api.github.com/users/igmhub","html_url":"https://github.com/igmhub","followers_url":"https://api.github.com/users/igmhub/followers","following_url":"https://api.github.com/users/igmhub/following{/other_user}","gists_url":"https://api.github.com/users/igmhub/gists{/gist_id}","starred_url":"https://api.github.com/users/igmhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igmhub/subscriptions","organizations_url":"https://api.github.com/users/igmhub/orgs","repos_url":"https://api.github.com/users/igmhub/repos","events_url":"https://api.github.com/users/igmhub/events{/privacy}","received_events_url":"https://api.github.com/users/igmhub/received_events","type":"Organization","site_admin":false},"repo":{"id":75860294,"node_id":"MDEwOlJlcG9zaXRvcnk3NTg2MDI5NA==","name":"picca","full_name":"igmhub/picca","owner":{"login":"igmhub","id":24413275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NDEzMjc1","avatar_url":"https://avatars2.githubusercontent.com/u/24413275?v=4","gravatar_id":"","url":"https://api.github.com/users/igmhub","html_url":"https://github.com/igmhub","followers_url":"https://api.github.com/users/igmhub/followers","following_url":"https://api.github.com/users/igmhub/following{/other_user}","gists_url":"https://api.github.com/users/igmhub/gists{/gist_id}","starred_url":"https://api.github.com/users/igmhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igmhub/subscriptions","organizations_url":"https://api.github.com/users/igmhub/orgs","repos_url":"https://api.github.com/users/igmhub/repos","events_url":"https://api.github.com/users/igmhub/events{/privacy}","received_events_url":"https://api.github.com/users/igmhub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/igmhub/picca","description":"set of tools for continuum fitting, correlation function calculation, cosmological fits...","fork":false,"url":"https://api.github.com/repos/igmhub/picca","forks_url":"https://api.github.com/repos/igmhub/picca/forks","keys_url":"https://api.github.com/repos/igmhub/picca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igmhub/picca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igmhub/picca/teams","hooks_url":"https://api.github.com/repos/igmhub/picca/hooks","issue_events_url":"https://api.github.com/repos/igmhub/picca/issues/events{/number}","events_url":"https://api.github.com/repos/igmhub/picca/events","assignees_url":"https://api.github.com/repos/igmhub/picca/assignees{/user}","branches_url":"https://api.github.com/repos/igmhub/picca/branches{/branch}","tags_url":"https://api.github.com/repos/igmhub/picca/tags","blobs_url":"https://api.github.com/repos/igmhub/picca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igmhub/picca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igmhub/picca/git/refs{/sha}","trees_url":"https://api.github.com/repos/igmhub/picca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igmhub/picca/statuses/{sha}","languages_url":"https://api.github.com/repos/igmhub/picca/languages","stargazers_url":"https://api.github.com/repos/igmhub/picca/stargazers","contributors_url":"https://api.github.com/repos/igmhub/picca/contributors","subscribers_url":"https://api.github.com/repos/igmhub/picca/subscribers","subscription_url":"https://api.github.com/repos/igmhub/picca/subscription","commits_url":"https://api.github.com/repos/igmhub/picca/commits{/sha}","git_commits_url":"https://api.github.com/repos/igmhub/picca/git/commits{/sha}","comments_url":"https://api.github.com/repos/igmhub/picca/comments{/number}","issue_comment_url":"https://api.github.com/repos/igmhub/picca/issues/comments{/number}","contents_url":"https://api.github.com/repos/igmhub/picca/contents/{+path}","compare_url":"https://api.github.com/repos/igmhub/picca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igmhub/picca/merges","archive_url":"https://api.github.com/repos/igmhub/picca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igmhub/picca/downloads","issues_url":"https://api.github.com/repos/igmhub/picca/issues{/number}","pulls_url":"https://api.github.com/repos/igmhub/picca/pulls{/number}","milestones_url":"https://api.github.com/repos/igmhub/picca/milestones{/number}","notifications_url":"https://api.github.com/repos/igmhub/picca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igmhub/picca/labels{/name}","releases_url":"https://api.github.com/repos/igmhub/picca/releases{/id}","deployments_url":"https://api.github.com/repos/igmhub/picca/deployments","created_at":"2016-12-07T17:36:47Z","updated_at":"2018-06-01T21:08:57Z","pushed_at":"2018-06-04T15:36:44Z","git_url":"git://github.com/igmhub/picca.git","ssh_url":"git@github.com:igmhub/picca.git","clone_url":"https://github.com/igmhub/picca.git","svn_url":"https://github.com/igmhub/picca","homepage":null,"size":125156,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":36,"watchers":1,"default_branch":"master"}},"base":{"label":"igmhub:master","ref":"master","sha":"8d10512b8ee852810c7b5f1b466d84930313ea3c","user":{"login":"igmhub","id":24413275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NDEzMjc1","avatar_url":"https://avatars2.githubusercontent.com/u/24413275?v=4","gravatar_id":"","url":"https://api.github.com/users/igmhub","html_url":"https://github.com/igmhub","followers_url":"https://api.github.com/users/igmhub/followers","following_url":"https://api.github.com/users/igmhub/following{/other_user}","gists_url":"https://api.github.com/users/igmhub/gists{/gist_id}","starred_url":"https://api.github.com/users/igmhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igmhub/subscriptions","organizations_url":"https://api.github.com/users/igmhub/orgs","repos_url":"https://api.github.com/users/igmhub/repos","events_url":"https://api.github.com/users/igmhub/events{/privacy}","received_events_url":"https://api.github.com/users/igmhub/received_events","type":"Organization","site_admin":false},"repo":{"id":75860294,"node_id":"MDEwOlJlcG9zaXRvcnk3NTg2MDI5NA==","name":"picca","full_name":"igmhub/picca","owner":{"login":"igmhub","id":24413275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NDEzMjc1","avatar_url":"https://avatars2.githubusercontent.com/u/24413275?v=4","gravatar_id":"","url":"https://api.github.com/users/igmhub","html_url":"https://github.com/igmhub","followers_url":"https://api.github.com/users/igmhub/followers","following_url":"https://api.github.com/users/igmhub/following{/other_user}","gists_url":"https://api.github.com/users/igmhub/gists{/gist_id}","starred_url":"https://api.github.com/users/igmhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igmhub/subscriptions","organizations_url":"https://api.github.com/users/igmhub/orgs","repos_url":"https://api.github.com/users/igmhub/repos","events_url":"https://api.github.com/users/igmhub/events{/privacy}","received_events_url":"https://api.github.com/users/igmhub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/igmhub/picca","description":"set of tools for continuum fitting, correlation function calculation, cosmological fits...","fork":false,"url":"https://api.github.com/repos/igmhub/picca","forks_url":"https://api.github.com/repos/igmhub/picca/forks","keys_url":"https://api.github.com/repos/igmhub/picca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igmhub/picca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igmhub/picca/teams","hooks_url":"https://api.github.com/repos/igmhub/picca/hooks","issue_events_url":"https://api.github.com/repos/igmhub/picca/issues/events{/number}","events_url":"https://api.github.com/repos/igmhub/picca/events","assignees_url":"https://api.github.com/repos/igmhub/picca/assignees{/user}","branches_url":"https://api.github.com/repos/igmhub/picca/branches{/branch}","tags_url":"https://api.github.com/repos/igmhub/picca/tags","blobs_url":"https://api.github.com/repos/igmhub/picca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igmhub/picca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igmhub/picca/git/refs{/sha}","trees_url":"https://api.github.com/repos/igmhub/picca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igmhub/picca/statuses/{sha}","languages_url":"https://api.github.com/repos/igmhub/picca/languages","stargazers_url":"https://api.github.com/repos/igmhub/picca/stargazers","contributors_url":"https://api.github.com/repos/igmhub/picca/contributors","subscribers_url":"https://api.github.com/repos/igmhub/picca/subscribers","subscription_url":"https://api.github.com/repos/igmhub/picca/subscription","commits_url":"https://api.github.com/repos/igmhub/picca/commits{/sha}","git_commits_url":"https://api.github.com/repos/igmhub/picca/git/commits{/sha}","comments_url":"https://api.github.com/repos/igmhub/picca/comments{/number}","issue_comment_url":"https://api.github.com/repos/igmhub/picca/issues/comments{/number}","contents_url":"https://api.github.com/repos/igmhub/picca/contents/{+path}","compare_url":"https://api.github.com/repos/igmhub/picca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igmhub/picca/merges","archive_url":"https://api.github.com/repos/igmhub/picca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igmhub/picca/downloads","issues_url":"https://api.github.com/repos/igmhub/picca/issues{/number}","pulls_url":"https://api.github.com/repos/igmhub/picca/pulls{/number}","milestones_url":"https://api.github.com/repos/igmhub/picca/milestones{/number}","notifications_url":"https://api.github.com/repos/igmhub/picca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igmhub/picca/labels{/name}","releases_url":"https://api.github.com/repos/igmhub/picca/releases{/id}","deployments_url":"https://api.github.com/repos/igmhub/picca/deployments","created_at":"2016-12-07T17:36:47Z","updated_at":"2018-06-01T21:08:57Z","pushed_at":"2018-06-04T15:36:44Z","git_url":"git://github.com/igmhub/picca.git","ssh_url":"git@github.com:igmhub/picca.git","clone_url":"https://github.com/igmhub/picca.git","svn_url":"https://github.com/igmhub/picca","homepage":null,"size":125156,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":36,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igmhub/picca/pulls/446"},"html":{"href":"https://github.com/igmhub/picca/pull/446"},"issue":{"href":"https://api.github.com/repos/igmhub/picca/issues/446"},"comments":{"href":"https://api.github.com/repos/igmhub/picca/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/igmhub/picca/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/igmhub/picca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igmhub/picca/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/igmhub/picca/statuses/0d287177cd905959f7f5c651b053b6b037b25792"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mblomqvist"}}