{"action":"created","issue":{"url":"https://api.github.com/repos/node-nock/nock/issues/859","repository_url":"https://api.github.com/repos/node-nock/nock","labels_url":"https://api.github.com/repos/node-nock/nock/issues/859/labels{/name}","comments_url":"https://api.github.com/repos/node-nock/nock/issues/859/comments","events_url":"https://api.github.com/repos/node-nock/nock/issues/859/events","html_url":"https://github.com/node-nock/nock/pull/859","id":215694552,"number":859,"title":"Fix request timeout not working","user":{"login":"aleung","id":271538,"avatar_url":"https://avatars1.githubusercontent.com/u/271538?v=4","gravatar_id":"","url":"https://api.github.com/users/aleung","html_url":"https://github.com/aleung","followers_url":"https://api.github.com/users/aleung/followers","following_url":"https://api.github.com/users/aleung/following{/other_user}","gists_url":"https://api.github.com/users/aleung/gists{/gist_id}","starred_url":"https://api.github.com/users/aleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleung/subscriptions","organizations_url":"https://api.github.com/users/aleung/orgs","repos_url":"https://api.github.com/users/aleung/repos","events_url":"https://api.github.com/users/aleung/events{/privacy}","received_events_url":"https://api.github.com/users/aleung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-03-21T10:42:15Z","updated_at":"2018-02-22T01:56:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/node-nock/nock/pulls/859","html_url":"https://github.com/node-nock/nock/pull/859","diff_url":"https://github.com/node-nock/nock/pull/859.diff","patch_url":"https://github.com/node-nock/nock/pull/859.patch"},"body":"This is a follow-up PR of #802 and #839. It fixed #754 and #739.\r\n"},"comment":{"url":"https://api.github.com/repos/node-nock/nock/issues/comments/367541476","html_url":"https://github.com/node-nock/nock/pull/859#issuecomment-367541476","issue_url":"https://api.github.com/repos/node-nock/nock/issues/859","id":367541476,"user":{"login":"gr2m","id":39992,"avatar_url":"https://avatars3.githubusercontent.com/u/39992?v=4","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T01:56:33Z","updated_at":"2018-02-22T01:56:33Z","author_association":"OWNER","body":"I think I would remove these library tests altogether:\r\nhttps://github.com/node-nock/nock/issues/832 /cc @ianwsperber \r\n\r\nInstead, if folks are interested to monitor compatibility with the request library of their liking, they can create separate repositories, pin the nock version, and have greenkeeper make sure that their tests are always run against latest nock. If something breaks they can help fix it.\r\n\r\nI'm trying to make nock easier to maintain and that is quite a burden we put on who ever is maintaining nock right now. Unless there are any objections I'll move forward and remove these tests and also install the latest `request` version instead of pinning the version, and have greenkeeper make sure for us that our tests pass as new versions get released"}}
{"actor":{"display_login":"gr2m"}}