{"action":"created","issue":{"url":"https://api.github.com/repos/Segs/Segs/issues/363","repository_url":"https://api.github.com/repos/Segs/Segs","labels_url":"https://api.github.com/repos/Segs/Segs/issues/363/labels{/name}","comments_url":"https://api.github.com/repos/Segs/Segs/issues/363/comments","events_url":"https://api.github.com/repos/Segs/Segs/issues/363/events","html_url":"https://github.com/Segs/Segs/pull/363","id":316314504,"number":363,"title":"Added MySQL support in dbtool.","user":{"login":"dracc","id":1279635,"avatar_url":"https://avatars0.githubusercontent.com/u/1279635?v=4","gravatar_id":"","url":"https://api.github.com/users/dracc","html_url":"https://github.com/dracc","followers_url":"https://api.github.com/users/dracc/followers","following_url":"https://api.github.com/users/dracc/following{/other_user}","gists_url":"https://api.github.com/users/dracc/gists{/gist_id}","starred_url":"https://api.github.com/users/dracc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dracc/subscriptions","organizations_url":"https://api.github.com/users/dracc/orgs","repos_url":"https://api.github.com/users/dracc/repos","events_url":"https://api.github.com/users/dracc/events{/privacy}","received_events_url":"https://api.github.com/users/dracc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-20T15:33:44Z","updated_at":"2018-04-22T17:41:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Segs/Segs/pulls/363","html_url":"https://github.com/Segs/Segs/pull/363","diff_url":"https://github.com/Segs/Segs/pull/363.diff","patch_url":"https://github.com/Segs/Segs/pull/363.patch"},"body":"Additions/modifications proposed in this pull request:\r\n- dbtool now cares about settings.cfg\r\n- dbtool always selects db_driver and db_name from settings.cfg\r\n- If db_driver != QSQLITE, db_host, db_port, db_user and db_pass from settings.cfg is used\r\n- Both database creation and user addition works\r\n\r\nLeft to do:\r\n- ~~dbtool will not work if selected MySQL database is not available~~\r\n- ~~dbtool will not work if a MySQL table already exists~~\r\n- ~~dbtool does not check if MySQL database is available before trying to execute queries~~\r\n- dbtool does not fetch settings file name dynamically (i.e. \"settings.cfg\" is hard coded)\r\n\r\nUpdated: If user has permissions, new databases will be created.\r\nIf -force is provided, old tables will be dropped and new ones created."},"comment":{"url":"https://api.github.com/repos/Segs/Segs/issues/comments/383398859","html_url":"https://github.com/Segs/Segs/pull/363#issuecomment-383398859","issue_url":"https://api.github.com/repos/Segs/Segs/issues/363","id":383398859,"user":{"login":"broxen","id":10159505,"avatar_url":"https://avatars2.githubusercontent.com/u/10159505?v=4","gravatar_id":"","url":"https://api.github.com/users/broxen","html_url":"https://github.com/broxen","followers_url":"https://api.github.com/users/broxen/followers","following_url":"https://api.github.com/users/broxen/following{/other_user}","gists_url":"https://api.github.com/users/broxen/gists{/gist_id}","starred_url":"https://api.github.com/users/broxen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broxen/subscriptions","organizations_url":"https://api.github.com/users/broxen/orgs","repos_url":"https://api.github.com/users/broxen/repos","events_url":"https://api.github.com/users/broxen/events{/privacy}","received_events_url":"https://api.github.com/users/broxen/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T17:41:34Z","updated_at":"2018-04-22T17:41:34Z","author_association":"COLLABORATOR","body":"As a quick note: you can solve your final todo regarding setting file name, by creating a cmdline option for a custom file, and falling back on the hardcoded settings.cfg if non provided. You can see how we do this in authserver's main cmdline args."}}
{"actor":{"display_login":"broxen"}}