{"action":"created","comment":{"url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/comments/211077662","pull_request_review_id":147432554,"id":211077662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA3NzY2Mg==","diff_hunk":"@@ -0,0 +1,52 @@\n+<?php\n+\n+namespace HttpSignatures;\n+\n+class RsaAlgorithm implements AlgorithmInterface\n+{\n+    /** @var string */\n+    private $digestName;\n+\n+    /**\n+     * @param string $digestName\n+     */\n+    public function __construct($digestName)\n+    {\n+        $this->digestName = $digestName;\n+    }\n+\n+    /**\n+     * @return string\n+     */\n+    public function name()\n+    {\n+        return sprintf('rsa-%s', $this->digestName);\n+    }\n+\n+    /**\n+     * @param string $key\n+     * @param string $data\n+     *\n+     * @return string\n+     */\n+    public function sign($key, $data)\n+    {\n+        switch ($this->digestName) {\n+          case 'sha256':\n+            $algo = OPENSSL_ALGO_SHA256;\n+            break;\n+          case 'sha1':","path":"src/RsaAlgorithm.php","position":38,"original_position":38,"commit_id":"e1403b98cdd0832f089d4019e7cd525587d0102d","original_commit_id":"e1403b98cdd0832f089d4019e7cd525587d0102d","user":{"login":"aaronpk","id":113001,"node_id":"MDQ6VXNlcjExMzAwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/113001?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronpk","html_url":"https://github.com/aaronpk","followers_url":"https://api.github.com/users/aaronpk/followers","following_url":"https://api.github.com/users/aaronpk/following{/other_user}","gists_url":"https://api.github.com/users/aaronpk/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronpk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronpk/subscriptions","organizations_url":"https://api.github.com/users/aaronpk/orgs","repos_url":"https://api.github.com/users/aaronpk/repos","events_url":"https://api.github.com/users/aaronpk/events{/privacy}","received_events_url":"https://api.github.com/users/aaronpk/received_events","type":"User","site_admin":false},"body":"Shouldn't this `sha1` be replaced with the 384 and 512 that are listed in `src/Algorithm.php` above?","created_at":"2018-08-18T14:38:23Z","updated_at":"2018-08-18T14:38:23Z","html_url":"https://github.com/99designs/http-signatures-php/pull/35#discussion_r211077662","pull_request_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/comments/211077662"},"html":{"href":"https://github.com/99designs/http-signatures-php/pull/35#discussion_r211077662"},"pull_request":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35","id":209267502,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjY3NTAy","html_url":"https://github.com/99designs/http-signatures-php/pull/35","diff_url":"https://github.com/99designs/http-signatures-php/pull/35.diff","patch_url":"https://github.com/99designs/http-signatures-php/pull/35.patch","issue_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/35","number":35,"state":"open","locked":false,"title":"RSA Signing Support","user":{"login":"liamdennehy","id":4996358,"node_id":"MDQ6VXNlcjQ5OTYzNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4996358?v=4","gravatar_id":"","url":"https://api.github.com/users/liamdennehy","html_url":"https://github.com/liamdennehy","followers_url":"https://api.github.com/users/liamdennehy/followers","following_url":"https://api.github.com/users/liamdennehy/following{/other_user}","gists_url":"https://api.github.com/users/liamdennehy/gists{/gist_id}","starred_url":"https://api.github.com/users/liamdennehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamdennehy/subscriptions","organizations_url":"https://api.github.com/users/liamdennehy/orgs","repos_url":"https://api.github.com/users/liamdennehy/repos","events_url":"https://api.github.com/users/liamdennehy/events{/privacy}","received_events_url":"https://api.github.com/users/liamdennehy/received_events","type":"User","site_admin":false},"body":"I am slowly learning the test framework so this is coming along at a slower pace.\r\n\r\nWill attempt to extend to RSA verification too.","created_at":"2018-08-17T22:01:51Z","updated_at":"2018-08-18T14:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6457dedfbf59edd309805ff01b3e55eac0896c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35/commits","review_comments_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35/comments","review_comment_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/35/comments","statuses_url":"https://api.github.com/repos/99designs/http-signatures-php/statuses/e1403b98cdd0832f089d4019e7cd525587d0102d","head":{"label":"liamdennehy:rsa","ref":"rsa","sha":"e1403b98cdd0832f089d4019e7cd525587d0102d","user":{"login":"liamdennehy","id":4996358,"node_id":"MDQ6VXNlcjQ5OTYzNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4996358?v=4","gravatar_id":"","url":"https://api.github.com/users/liamdennehy","html_url":"https://github.com/liamdennehy","followers_url":"https://api.github.com/users/liamdennehy/followers","following_url":"https://api.github.com/users/liamdennehy/following{/other_user}","gists_url":"https://api.github.com/users/liamdennehy/gists{/gist_id}","starred_url":"https://api.github.com/users/liamdennehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamdennehy/subscriptions","organizations_url":"https://api.github.com/users/liamdennehy/orgs","repos_url":"https://api.github.com/users/liamdennehy/repos","events_url":"https://api.github.com/users/liamdennehy/events{/privacy}","received_events_url":"https://api.github.com/users/liamdennehy/received_events","type":"User","site_admin":false},"repo":{"id":145169735,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNjk3MzU=","name":"http-signatures-php","full_name":"liamdennehy/http-signatures-php","owner":{"login":"liamdennehy","id":4996358,"node_id":"MDQ6VXNlcjQ5OTYzNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4996358?v=4","gravatar_id":"","url":"https://api.github.com/users/liamdennehy","html_url":"https://github.com/liamdennehy","followers_url":"https://api.github.com/users/liamdennehy/followers","following_url":"https://api.github.com/users/liamdennehy/following{/other_user}","gists_url":"https://api.github.com/users/liamdennehy/gists{/gist_id}","starred_url":"https://api.github.com/users/liamdennehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamdennehy/subscriptions","organizations_url":"https://api.github.com/users/liamdennehy/orgs","repos_url":"https://api.github.com/users/liamdennehy/repos","events_url":"https://api.github.com/users/liamdennehy/events{/privacy}","received_events_url":"https://api.github.com/users/liamdennehy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liamdennehy/http-signatures-php","description":"Sign and verify PSR-7 HTTP messages in PHP.","fork":true,"url":"https://api.github.com/repos/liamdennehy/http-signatures-php","forks_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/forks","keys_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/teams","hooks_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/hooks","issue_events_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/issues/events{/number}","events_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/events","assignees_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/assignees{/user}","branches_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/branches{/branch}","tags_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/tags","blobs_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/statuses/{sha}","languages_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/languages","stargazers_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/stargazers","contributors_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/contributors","subscribers_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/subscribers","subscription_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/subscription","commits_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/contents/{+path}","compare_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/merges","archive_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/downloads","issues_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/issues{/number}","pulls_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/pulls{/number}","milestones_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/milestones{/number}","notifications_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/labels{/name}","releases_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/releases{/id}","deployments_url":"https://api.github.com/repos/liamdennehy/http-signatures-php/deployments","created_at":"2018-08-17T21:53:54Z","updated_at":"2018-08-17T21:53:56Z","pushed_at":"2018-08-18T11:50:25Z","git_url":"git://github.com/liamdennehy/http-signatures-php.git","ssh_url":"git@github.com:liamdennehy/http-signatures-php.git","clone_url":"https://github.com/liamdennehy/http-signatures-php.git","svn_url":"https://github.com/liamdennehy/http-signatures-php","homepage":"","size":79,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"99designs:master","ref":"master","sha":"c1f7d3a39366a79bfa66c53dbe1a51b7a57c703c","user":{"login":"99designs","id":17182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTgy","avatar_url":"https://avatars1.githubusercontent.com/u/17182?v=4","gravatar_id":"","url":"https://api.github.com/users/99designs","html_url":"https://github.com/99designs","followers_url":"https://api.github.com/users/99designs/followers","following_url":"https://api.github.com/users/99designs/following{/other_user}","gists_url":"https://api.github.com/users/99designs/gists{/gist_id}","starred_url":"https://api.github.com/users/99designs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/99designs/subscriptions","organizations_url":"https://api.github.com/users/99designs/orgs","repos_url":"https://api.github.com/users/99designs/repos","events_url":"https://api.github.com/users/99designs/events{/privacy}","received_events_url":"https://api.github.com/users/99designs/received_events","type":"Organization","site_admin":false},"repo":{"id":22449072,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0OTA3Mg==","name":"http-signatures-php","full_name":"99designs/http-signatures-php","owner":{"login":"99designs","id":17182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTgy","avatar_url":"https://avatars1.githubusercontent.com/u/17182?v=4","gravatar_id":"","url":"https://api.github.com/users/99designs","html_url":"https://github.com/99designs","followers_url":"https://api.github.com/users/99designs/followers","following_url":"https://api.github.com/users/99designs/following{/other_user}","gists_url":"https://api.github.com/users/99designs/gists{/gist_id}","starred_url":"https://api.github.com/users/99designs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/99designs/subscriptions","organizations_url":"https://api.github.com/users/99designs/orgs","repos_url":"https://api.github.com/users/99designs/repos","events_url":"https://api.github.com/users/99designs/events{/privacy}","received_events_url":"https://api.github.com/users/99designs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/99designs/http-signatures-php","description":"Sign and verify PSR-7 HTTP messages in PHP.","fork":false,"url":"https://api.github.com/repos/99designs/http-signatures-php","forks_url":"https://api.github.com/repos/99designs/http-signatures-php/forks","keys_url":"https://api.github.com/repos/99designs/http-signatures-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/99designs/http-signatures-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/99designs/http-signatures-php/teams","hooks_url":"https://api.github.com/repos/99designs/http-signatures-php/hooks","issue_events_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/events{/number}","events_url":"https://api.github.com/repos/99designs/http-signatures-php/events","assignees_url":"https://api.github.com/repos/99designs/http-signatures-php/assignees{/user}","branches_url":"https://api.github.com/repos/99designs/http-signatures-php/branches{/branch}","tags_url":"https://api.github.com/repos/99designs/http-signatures-php/tags","blobs_url":"https://api.github.com/repos/99designs/http-signatures-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/99designs/http-signatures-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/99designs/http-signatures-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/99designs/http-signatures-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/99designs/http-signatures-php/statuses/{sha}","languages_url":"https://api.github.com/repos/99designs/http-signatures-php/languages","stargazers_url":"https://api.github.com/repos/99designs/http-signatures-php/stargazers","contributors_url":"https://api.github.com/repos/99designs/http-signatures-php/contributors","subscribers_url":"https://api.github.com/repos/99designs/http-signatures-php/subscribers","subscription_url":"https://api.github.com/repos/99designs/http-signatures-php/subscription","commits_url":"https://api.github.com/repos/99designs/http-signatures-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/99designs/http-signatures-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/99designs/http-signatures-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/99designs/http-signatures-php/contents/{+path}","compare_url":"https://api.github.com/repos/99designs/http-signatures-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/99designs/http-signatures-php/merges","archive_url":"https://api.github.com/repos/99designs/http-signatures-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/99designs/http-signatures-php/downloads","issues_url":"https://api.github.com/repos/99designs/http-signatures-php/issues{/number}","pulls_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls{/number}","milestones_url":"https://api.github.com/repos/99designs/http-signatures-php/milestones{/number}","notifications_url":"https://api.github.com/repos/99designs/http-signatures-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/99designs/http-signatures-php/labels{/name}","releases_url":"https://api.github.com/repos/99designs/http-signatures-php/releases{/id}","deployments_url":"https://api.github.com/repos/99designs/http-signatures-php/deployments","created_at":"2014-07-30T23:44:34Z","updated_at":"2018-07-30T03:48:08Z","pushed_at":"2018-08-18T11:50:26Z","git_url":"git://github.com/99designs/http-signatures-php.git","ssh_url":"git@github.com:99designs/http-signatures-php.git","clone_url":"https://github.com/99designs/http-signatures-php.git","svn_url":"https://github.com/99designs/http-signatures-php","homepage":"","size":75,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":8,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35"},"html":{"href":"https://github.com/99designs/http-signatures-php/pull/35"},"issue":{"href":"https://api.github.com/repos/99designs/http-signatures-php/issues/35"},"comments":{"href":"https://api.github.com/repos/99designs/http-signatures-php/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/99designs/http-signatures-php/statuses/e1403b98cdd0832f089d4019e7cd525587d0102d"}},"author_association":"NONE"}}
{"actor":{"display_login":"aaronpk"}}