{"action":"created","issue":{"url":"https://api.github.com/repos/javaee/glassfish/issues/1171","repository_url":"https://api.github.com/repos/javaee/glassfish","labels_url":"https://api.github.com/repos/javaee/glassfish/issues/1171/labels{/name}","comments_url":"https://api.github.com/repos/javaee/glassfish/issues/1171/comments","events_url":"https://api.github.com/repos/javaee/glassfish/issues/1171/events","html_url":"https://github.com/javaee/glassfish/issues/1171","id":223010889,"node_id":"MDU6SXNzdWUyMjMwMTA4ODk=","number":1171,"title":"Make ddl generation default mode consistent","user":{"login":"glassfishrobot","id":6104758,"node_id":"MDQ6VXNlcjYxMDQ3NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6104758?v=4","gravatar_id":"","url":"https://api.github.com/users/glassfishrobot","html_url":"https://github.com/glassfishrobot","followers_url":"https://api.github.com/users/glassfishrobot/followers","following_url":"https://api.github.com/users/glassfishrobot/following{/other_user}","gists_url":"https://api.github.com/users/glassfishrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/glassfishrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassfishrobot/subscriptions","organizations_url":"https://api.github.com/users/glassfishrobot/orgs","repos_url":"https://api.github.com/users/glassfishrobot/repos","events_url":"https://api.github.com/users/glassfishrobot/events{/privacy}","received_events_url":"https://api.github.com/users/glassfishrobot/received_events","type":"User","site_admin":false},"labels":[{"id":587834553,"node_id":"MDU6TGFiZWw1ODc4MzQ1NTM=","url":"https://api.github.com/repos/javaee/glassfish/labels/Component:%20entity-persistence","name":"Component: entity-persistence","color":"2d03c1","default":false},{"id":587848769,"node_id":"MDU6TGFiZWw1ODc4NDg3Njk=","url":"https://api.github.com/repos/javaee/glassfish/labels/ERR:%20Assignee","name":"ERR: Assignee","color":"ededed","default":false},{"id":587834363,"node_id":"MDU6TGFiZWw1ODc4MzQzNjM=","url":"https://api.github.com/repos/javaee/glassfish/labels/Priority:%20Minor","name":"Priority: Minor","color":"5bf7b9","default":false},{"id":587834333,"node_id":"MDU6TGFiZWw1ODc4MzQzMzM=","url":"https://api.github.com/repos/javaee/glassfish/labels/Type:%20Bug","name":"Type: Bug","color":"fcbfc5","default":false}],"state":"open","locked":false,"assignee":{"login":"yaminikb","id":22960808,"node_id":"MDQ6VXNlcjIyOTYwODA4","avatar_url":"https://avatars0.githubusercontent.com/u/22960808?v=4","gravatar_id":"","url":"https://api.github.com/users/yaminikb","html_url":"https://github.com/yaminikb","followers_url":"https://api.github.com/users/yaminikb/followers","following_url":"https://api.github.com/users/yaminikb/following{/other_user}","gists_url":"https://api.github.com/users/yaminikb/gists{/gist_id}","starred_url":"https://api.github.com/users/yaminikb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaminikb/subscriptions","organizations_url":"https://api.github.com/users/yaminikb/orgs","repos_url":"https://api.github.com/users/yaminikb/repos","events_url":"https://api.github.com/users/yaminikb/events{/privacy}","received_events_url":"https://api.github.com/users/yaminikb/received_events","type":"User","site_admin":false},"assignees":[{"login":"yaminikb","id":22960808,"node_id":"MDQ6VXNlcjIyOTYwODA4","avatar_url":"https://avatars0.githubusercontent.com/u/22960808?v=4","gravatar_id":"","url":"https://api.github.com/users/yaminikb","html_url":"https://github.com/yaminikb","followers_url":"https://api.github.com/users/yaminikb/followers","following_url":"https://api.github.com/users/yaminikb/following{/other_user}","gists_url":"https://api.github.com/users/yaminikb/gists{/gist_id}","starred_url":"https://api.github.com/users/yaminikb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaminikb/subscriptions","organizations_url":"https://api.github.com/users/yaminikb/orgs","repos_url":"https://api.github.com/users/yaminikb/repos","events_url":"https://api.github.com/users/yaminikb/events{/privacy}","received_events_url":"https://api.github.com/users/yaminikb/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2006-09-20T07:56:22Z","updated_at":"2018-09-14T11:10:28Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently TopLink's ddlGeneration mode is different when running with\ncreateEntityManagerFactory than it is for createContinerEntityManagerFactory.\n\nDEFAULT_DDL_GENERATION_MODE = DDL_SQL_SCRIPT_GENERATION\n\nThis default mode was set in the early days of the GlassFish integration before\nthe createContainerEntityManagerFactory(PersistenceUnitInfo info, Map\nproperties) had a map of properties available.\n\nWhen running with createEntityManagerFactory() we override the default by\nsetting an inSEMode flag and when running in SE mode, we effectively use:\nDDL_BOTH_GENERATION\n\nWe need to remove the inSEMode flag and always use the setting provided to\nTopLink.\n\nWe should also change the default to: DDL_DATABASE_GENERATION since this will\nallow most users to work by default.\n\nIn order for GlassFish DDL generation to continue to work, GlassFish will have\nto pass the toplink.ddl-generation.output-mode=sql-script to the properties map\nprovided in createContainerEntityManagerFactory(). A separate bug will be\nfiled for that issue and it will be linked to this one.\n#### Environment\nOperating System: All\nPlatform: All\n#### Affected Versions\n[9.0pe]"},"comment":{"url":"https://api.github.com/repos/javaee/glassfish/issues/comments/421325862","html_url":"https://github.com/javaee/glassfish/issues/1171#issuecomment-421325862","issue_url":"https://api.github.com/repos/javaee/glassfish/issues/1171","id":421325862,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTMyNTg2Mg==","user":{"login":"glassfishrobot","id":6104758,"node_id":"MDQ6VXNlcjYxMDQ3NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6104758?v=4","gravatar_id":"","url":"https://api.github.com/users/glassfishrobot","html_url":"https://github.com/glassfishrobot","followers_url":"https://api.github.com/users/glassfishrobot/followers","following_url":"https://api.github.com/users/glassfishrobot/following{/other_user}","gists_url":"https://api.github.com/users/glassfishrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/glassfishrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassfishrobot/subscriptions","organizations_url":"https://api.github.com/users/glassfishrobot/orgs","repos_url":"https://api.github.com/users/glassfishrobot/repos","events_url":"https://api.github.com/users/glassfishrobot/events{/privacy}","received_events_url":"https://api.github.com/users/glassfishrobot/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T11:10:28Z","updated_at":"2018-09-14T11:10:28Z","author_association":"CONTRIBUTOR","body":"**Closing this as this issue is migrated to** https://github.com/eclipse-ee4j/glassfish/issues/1168"}}
{"actor":{"display_login":"glassfishrobot"}}