{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/19063","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/19063/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19063/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/19063/events","html_url":"https://github.com/openshift/origin/pull/19063","id":307683502,"number":19063,"title":"Make NewCommandStartNode() handle SIGTERM and SIGINT","user":{"login":"frobware","id":943903,"avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":223479084,"url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":640548301,"url":"https://api.github.com/repos/openshift/origin/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"sjenning","id":493891,"avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjenning","id":493891,"avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":29,"created_at":"2018-03-22T15:05:24Z","updated_at":"2018-04-11T15:43:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/19063","html_url":"https://github.com/openshift/origin/pull/19063","diff_url":"https://github.com/openshift/origin/pull/19063.diff","patch_url":"https://github.com/openshift/origin/pull/19063.patch"},"body":"This commit threads a stop channel into NewCommandOpenShift() so that\r\nSIGTERM and SIGINT can be handled gracefully.\r\n\r\nThis commit only updates NewCommandStartNode() to handle the stop\r\nchannel, which is only signalled on receipt of either SIGTERM or\r\nSIGINT. Existing usages of NewCommandStart*() (e.g., StartMaster(),\r\nStartNetwork(), StartEtcdServer(), StartTemplateServiceBroker(), et\r\nal) remain as is.\r\n\r\nNow when you run:\r\n\r\n    # systemctl stop atomic-openshift-node\r\n    # systemctl status atomic-openshift-node\r\n\r\nit has the opportunity to unwind and return EXIT_SUCCESS (i.e., 0).\r\n\r\nFor example:\r\n\r\n    Process: 6801 ExecStart=/usr/bin/openshift start node \\\r\n        --config=${CONFIG_FILE} $OPTIONS (code=exited, status=0/SUCCESS)\r\n\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1557851"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/380499829","html_url":"https://github.com/openshift/origin/pull/19063#issuecomment-380499829","issue_url":"https://api.github.com/repos/openshift/origin/issues/19063","id":380499829,"user":{"login":"frobware","id":943903,"avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T15:43:56Z","updated_at":"2018-04-11T15:43:56Z","author_association":"CONTRIBUTOR","body":"> Last test ran after the fix merged but clearly lacks the change based on the logs.\r\n> /retest\r\n\r\nLooks like it failed again. But the latest failure could be just flaky so trying again.\r\n\r\n/test gcp"}}
{"actor":{"display_login":"frobware"}}