{"action":"created","comment":{"url":"https://api.github.com/repos/lytics/pathforajs/pulls/comments/180956303","pull_request_review_id":111468955,"id":180956303,"diff_hunk":"@@ -333,4 +334,8 @@ export default function constructWidgetLayout (widget, config) {\n   if (config.msg) {\n     widgetMessage.innerHTML = config.msg;\n   }\n+\n+  if (config.footerText) {\n+    widgetFooter.innerHTML = config.footerText;","path":"src/rollup/widgets/construct-widget-layout.js","position":16,"original_position":16,"commit_id":"5379f075a3496cbdca70379a4f3cdd6b5e6e1e54","original_commit_id":"5379f075a3496cbdca70379a4f3cdd6b5e6e1e54","user":{"login":"markhayden","id":2042008,"avatar_url":"https://avatars2.githubusercontent.com/u/2042008?v=4","gravatar_id":"","url":"https://api.github.com/users/markhayden","html_url":"https://github.com/markhayden","followers_url":"https://api.github.com/users/markhayden/followers","following_url":"https://api.github.com/users/markhayden/following{/other_user}","gists_url":"https://api.github.com/users/markhayden/gists{/gist_id}","starred_url":"https://api.github.com/users/markhayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhayden/subscriptions","organizations_url":"https://api.github.com/users/markhayden/orgs","repos_url":"https://api.github.com/users/markhayden/repos","events_url":"https://api.github.com/users/markhayden/events{/privacy}","received_events_url":"https://api.github.com/users/markhayden/received_events","type":"User","site_admin":false},"body":"should be able to add lots of tests for this. one to ensure the div gets populated properly when there is text to drop in and another to ensure that it does not get added at all for widgets with no `footerText`. both on every type of widget it can effect. could also test empty string vs missing undefined key if you want to go wild. ","created_at":"2018-04-12T03:29:50Z","updated_at":"2018-04-12T03:39:25Z","html_url":"https://github.com/lytics/pathforajs/pull/293#discussion_r180956303","pull_request_url":"https://api.github.com/repos/lytics/pathforajs/pulls/293","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lytics/pathforajs/pulls/comments/180956303"},"html":{"href":"https://github.com/lytics/pathforajs/pull/293#discussion_r180956303"},"pull_request":{"href":"https://api.github.com/repos/lytics/pathforajs/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/lytics/pathforajs/pulls/293","id":181053473,"html_url":"https://github.com/lytics/pathforajs/pull/293","diff_url":"https://github.com/lytics/pathforajs/pull/293.diff","patch_url":"https://github.com/lytics/pathforajs/pull/293.patch","issue_url":"https://api.github.com/repos/lytics/pathforajs/issues/293","number":293,"state":"open","locked":false,"title":"Footer feature","user":{"login":"kristinh12","id":23467663,"avatar_url":"https://avatars0.githubusercontent.com/u/23467663?v=4","gravatar_id":"","url":"https://api.github.com/users/kristinh12","html_url":"https://github.com/kristinh12","followers_url":"https://api.github.com/users/kristinh12/followers","following_url":"https://api.github.com/users/kristinh12/following{/other_user}","gists_url":"https://api.github.com/users/kristinh12/gists{/gist_id}","starred_url":"https://api.github.com/users/kristinh12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristinh12/subscriptions","organizations_url":"https://api.github.com/users/kristinh12/orgs","repos_url":"https://api.github.com/users/kristinh12/repos","events_url":"https://api.github.com/users/kristinh12/events{/privacy}","received_events_url":"https://api.github.com/users/kristinh12/received_events","type":"User","site_admin":false},"body":"Closes: https://github.com/lytics/pathforajs/issues/287\r\n\r\n-added a div with the class pf-widget-footer to modals and slideouts\r\n-in construct-widget-layout.js I set the text to the footerText setting\r\n-updated the docs to include this new setting (let me know if I should add it somewhere else)\r\n-added css for pf-widget-footer in widgets-general.less and slideouts.less\r\n\r\nSome images of the footer:\r\n![screen shot 2018-04-11 at 3 03 42 pm](https://user-images.githubusercontent.com/23467663/38648072-45e40780-3da4-11e8-95c9-73df5d0626a8.png)\r\n\r\n![screen shot 2018-04-11 at 4 09 00 pm](https://user-images.githubusercontent.com/23467663/38648081-4a0c1082-3da4-11e8-8408-a8638ee9bbb3.png)\r\n","created_at":"2018-04-11T23:23:06Z","updated_at":"2018-04-12T03:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b03f94dc6ab056b21a479c5ddb0631db6277ed4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sarahyablok","id":5973633,"avatar_url":"https://avatars1.githubusercontent.com/u/5973633?v=4","gravatar_id":"","url":"https://api.github.com/users/sarahyablok","html_url":"https://github.com/sarahyablok","followers_url":"https://api.github.com/users/sarahyablok/followers","following_url":"https://api.github.com/users/sarahyablok/following{/other_user}","gists_url":"https://api.github.com/users/sarahyablok/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahyablok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahyablok/subscriptions","organizations_url":"https://api.github.com/users/sarahyablok/orgs","repos_url":"https://api.github.com/users/sarahyablok/repos","events_url":"https://api.github.com/users/sarahyablok/events{/privacy}","received_events_url":"https://api.github.com/users/sarahyablok/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lytics/pathforajs/pulls/293/commits","review_comments_url":"https://api.github.com/repos/lytics/pathforajs/pulls/293/comments","review_comment_url":"https://api.github.com/repos/lytics/pathforajs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lytics/pathforajs/issues/293/comments","statuses_url":"https://api.github.com/repos/lytics/pathforajs/statuses/5379f075a3496cbdca70379a4f3cdd6b5e6e1e54","head":{"label":"lytics:footer-feature","ref":"footer-feature","sha":"5379f075a3496cbdca70379a4f3cdd6b5e6e1e54","user":{"login":"lytics","id":1951824,"avatar_url":"https://avatars0.githubusercontent.com/u/1951824?v=4","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"repo":{"id":35165967,"name":"pathforajs","full_name":"lytics/pathforajs","owner":{"login":"lytics","id":1951824,"avatar_url":"https://avatars0.githubusercontent.com/u/1951824?v=4","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lytics/pathforajs","description":"Web personalization SDK","fork":false,"url":"https://api.github.com/repos/lytics/pathforajs","forks_url":"https://api.github.com/repos/lytics/pathforajs/forks","keys_url":"https://api.github.com/repos/lytics/pathforajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lytics/pathforajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lytics/pathforajs/teams","hooks_url":"https://api.github.com/repos/lytics/pathforajs/hooks","issue_events_url":"https://api.github.com/repos/lytics/pathforajs/issues/events{/number}","events_url":"https://api.github.com/repos/lytics/pathforajs/events","assignees_url":"https://api.github.com/repos/lytics/pathforajs/assignees{/user}","branches_url":"https://api.github.com/repos/lytics/pathforajs/branches{/branch}","tags_url":"https://api.github.com/repos/lytics/pathforajs/tags","blobs_url":"https://api.github.com/repos/lytics/pathforajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lytics/pathforajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lytics/pathforajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lytics/pathforajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lytics/pathforajs/statuses/{sha}","languages_url":"https://api.github.com/repos/lytics/pathforajs/languages","stargazers_url":"https://api.github.com/repos/lytics/pathforajs/stargazers","contributors_url":"https://api.github.com/repos/lytics/pathforajs/contributors","subscribers_url":"https://api.github.com/repos/lytics/pathforajs/subscribers","subscription_url":"https://api.github.com/repos/lytics/pathforajs/subscription","commits_url":"https://api.github.com/repos/lytics/pathforajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lytics/pathforajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lytics/pathforajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lytics/pathforajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lytics/pathforajs/contents/{+path}","compare_url":"https://api.github.com/repos/lytics/pathforajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lytics/pathforajs/merges","archive_url":"https://api.github.com/repos/lytics/pathforajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lytics/pathforajs/downloads","issues_url":"https://api.github.com/repos/lytics/pathforajs/issues{/number}","pulls_url":"https://api.github.com/repos/lytics/pathforajs/pulls{/number}","milestones_url":"https://api.github.com/repos/lytics/pathforajs/milestones{/number}","notifications_url":"https://api.github.com/repos/lytics/pathforajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lytics/pathforajs/labels{/name}","releases_url":"https://api.github.com/repos/lytics/pathforajs/releases{/id}","deployments_url":"https://api.github.com/repos/lytics/pathforajs/deployments","created_at":"2015-05-06T15:11:09Z","updated_at":"2018-03-23T23:14:40Z","pushed_at":"2018-04-11T23:24:29Z","git_url":"git://github.com/lytics/pathforajs.git","ssh_url":"git@github.com:lytics/pathforajs.git","clone_url":"https://github.com/lytics/pathforajs.git","svn_url":"https://github.com/lytics/pathforajs","homepage":"https://www.lytics.com/","size":8050,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":24,"watchers":5,"default_branch":"develop"}},"base":{"label":"lytics:develop","ref":"develop","sha":"c111d607cec157382bdcc4ce1a1d9eb84d2b31ae","user":{"login":"lytics","id":1951824,"avatar_url":"https://avatars0.githubusercontent.com/u/1951824?v=4","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"repo":{"id":35165967,"name":"pathforajs","full_name":"lytics/pathforajs","owner":{"login":"lytics","id":1951824,"avatar_url":"https://avatars0.githubusercontent.com/u/1951824?v=4","gravatar_id":"","url":"https://api.github.com/users/lytics","html_url":"https://github.com/lytics","followers_url":"https://api.github.com/users/lytics/followers","following_url":"https://api.github.com/users/lytics/following{/other_user}","gists_url":"https://api.github.com/users/lytics/gists{/gist_id}","starred_url":"https://api.github.com/users/lytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lytics/subscriptions","organizations_url":"https://api.github.com/users/lytics/orgs","repos_url":"https://api.github.com/users/lytics/repos","events_url":"https://api.github.com/users/lytics/events{/privacy}","received_events_url":"https://api.github.com/users/lytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lytics/pathforajs","description":"Web personalization SDK","fork":false,"url":"https://api.github.com/repos/lytics/pathforajs","forks_url":"https://api.github.com/repos/lytics/pathforajs/forks","keys_url":"https://api.github.com/repos/lytics/pathforajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lytics/pathforajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lytics/pathforajs/teams","hooks_url":"https://api.github.com/repos/lytics/pathforajs/hooks","issue_events_url":"https://api.github.com/repos/lytics/pathforajs/issues/events{/number}","events_url":"https://api.github.com/repos/lytics/pathforajs/events","assignees_url":"https://api.github.com/repos/lytics/pathforajs/assignees{/user}","branches_url":"https://api.github.com/repos/lytics/pathforajs/branches{/branch}","tags_url":"https://api.github.com/repos/lytics/pathforajs/tags","blobs_url":"https://api.github.com/repos/lytics/pathforajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lytics/pathforajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lytics/pathforajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lytics/pathforajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lytics/pathforajs/statuses/{sha}","languages_url":"https://api.github.com/repos/lytics/pathforajs/languages","stargazers_url":"https://api.github.com/repos/lytics/pathforajs/stargazers","contributors_url":"https://api.github.com/repos/lytics/pathforajs/contributors","subscribers_url":"https://api.github.com/repos/lytics/pathforajs/subscribers","subscription_url":"https://api.github.com/repos/lytics/pathforajs/subscription","commits_url":"https://api.github.com/repos/lytics/pathforajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lytics/pathforajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lytics/pathforajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lytics/pathforajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lytics/pathforajs/contents/{+path}","compare_url":"https://api.github.com/repos/lytics/pathforajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lytics/pathforajs/merges","archive_url":"https://api.github.com/repos/lytics/pathforajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lytics/pathforajs/downloads","issues_url":"https://api.github.com/repos/lytics/pathforajs/issues{/number}","pulls_url":"https://api.github.com/repos/lytics/pathforajs/pulls{/number}","milestones_url":"https://api.github.com/repos/lytics/pathforajs/milestones{/number}","notifications_url":"https://api.github.com/repos/lytics/pathforajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lytics/pathforajs/labels{/name}","releases_url":"https://api.github.com/repos/lytics/pathforajs/releases{/id}","deployments_url":"https://api.github.com/repos/lytics/pathforajs/deployments","created_at":"2015-05-06T15:11:09Z","updated_at":"2018-03-23T23:14:40Z","pushed_at":"2018-04-11T23:24:29Z","git_url":"git://github.com/lytics/pathforajs.git","ssh_url":"git@github.com:lytics/pathforajs.git","clone_url":"https://github.com/lytics/pathforajs.git","svn_url":"https://github.com/lytics/pathforajs","homepage":"https://www.lytics.com/","size":8050,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":24,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lytics/pathforajs/pulls/293"},"html":{"href":"https://github.com/lytics/pathforajs/pull/293"},"issue":{"href":"https://api.github.com/repos/lytics/pathforajs/issues/293"},"comments":{"href":"https://api.github.com/repos/lytics/pathforajs/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/lytics/pathforajs/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/lytics/pathforajs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lytics/pathforajs/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/lytics/pathforajs/statuses/5379f075a3496cbdca70379a4f3cdd6b5e6e1e54"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markhayden"}}