{"action":"created","comment":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments/216216177","pull_request_review_id":153641895,"id":216216177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIxNjE3Nw==","diff_hunk":"@@ -0,0 +1,42 @@\n+#pragma once\n+\n+#include \"../Point.h\"\n+#include \"../Rect.h\"\n+#include <vector>\n+#include <cstdint>\n+\n+struct Animation {\n+\tstruct Frame {\n+\t\tstruct SubFrame {","path":"src/Sprites/Animation.h","position":null,"original_position":10,"commit_id":"11e4d4afc91fd1744bca107330cbae461536f521","original_commit_id":"4a7d4644b68b0c6c45df0fbce92b4fbd31dc8558","user":{"login":"DanRStevens","id":16793474,"node_id":"MDQ6VXNlcjE2NzkzNDc0","avatar_url":"https://avatars2.githubusercontent.com/u/16793474?v=4","gravatar_id":"","url":"https://api.github.com/users/DanRStevens","html_url":"https://github.com/DanRStevens","followers_url":"https://api.github.com/users/DanRStevens/followers","following_url":"https://api.github.com/users/DanRStevens/following{/other_user}","gists_url":"https://api.github.com/users/DanRStevens/gists{/gist_id}","starred_url":"https://api.github.com/users/DanRStevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanRStevens/subscriptions","organizations_url":"https://api.github.com/users/DanRStevens/orgs","repos_url":"https://api.github.com/users/DanRStevens/repos","events_url":"https://api.github.com/users/DanRStevens/events{/privacy}","received_events_url":"https://api.github.com/users/DanRStevens/received_events","type":"User","site_admin":false},"body":"I suggest renaming `SubFrame` to `Layer`. That would more closely match terminology in popular graphics packages.\r\n\r\nBack in the day, I was never very happy with the original naming of that field. At the time, I didn't feel I had proper terminology to really describe what it was about. Now I'm thinking `Layer` is a much more obvious name.","created_at":"2018-09-10T07:05:24Z","updated_at":"2018-09-10T07:53:49Z","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/177#discussion_r216216177","pull_request_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments/216216177"},"html":{"href":"https://github.com/OutpostUniverse/OP2Utility/pull/177#discussion_r216216177"},"pull_request":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177","id":213674223,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjc0MjIz","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/177","diff_url":"https://github.com/OutpostUniverse/OP2Utility/pull/177.diff","patch_url":"https://github.com/OutpostUniverse/OP2Utility/pull/177.patch","issue_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/177","number":177,"state":"open","locked":false,"title":"Allow reading sprites","user":{"login":"Brett208","id":15183337,"node_id":"MDQ6VXNlcjE1MTgzMzM3","avatar_url":"https://avatars3.githubusercontent.com/u/15183337?v=4","gravatar_id":"","url":"https://api.github.com/users/Brett208","html_url":"https://github.com/Brett208","followers_url":"https://api.github.com/users/Brett208/followers","following_url":"https://api.github.com/users/Brett208/following{/other_user}","gists_url":"https://api.github.com/users/Brett208/gists{/gist_id}","starred_url":"https://api.github.com/users/Brett208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brett208/subscriptions","organizations_url":"https://api.github.com/users/Brett208/orgs","repos_url":"https://api.github.com/users/Brett208/repos","events_url":"https://api.github.com/users/Brett208/events{/privacy}","received_events_url":"https://api.github.com/users/Brett208/received_events","type":"User","site_admin":false},"body":"This branch is to allow reading OP2_ART.prt files into memory. The read function works until reading first frameCount from from Animation. After reading the frameCount, values are incorrect. I'm unable to correct this on my own and need some help. \r\n\r\nThe code is contained in a subdirectory call Sprites. Class is name ArtFile, ArtReader, and ArtWriter. I'm open to suggestions here on naming.\r\n\r\n - Write function is incomplete and untested, so I would ignore it for now until reading is good.\r\n - I cannot get the private functions prototypes of ArtReader and ArtWriter to wrap in an anonymous namespace. Also, why are we wrapping MapReader/MapWriter private functions in an anonymous namespace?\r\n - I'm trying to remove the noise from ArtFile. So things like file headers and container sizes are not recorded in it. Instead, these are created by the writer or discarded by the reader to create ArtFile. This should reduce the amount of unneeded variables that have to be sifted through in ArtFile.\r\n\r\nThanks,\r\n-Brett","created_at":"2018-09-06T16:13:59Z","updated_at":"2018-09-10T07:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc1b70f96596f0731e1f138de08f8cab5b122cfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177/commits","review_comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177/comments","review_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/177/comments","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/11e4d4afc91fd1744bca107330cbae461536f521","head":{"label":"OutpostUniverse:Allow-Reading-Sprites","ref":"Allow-Reading-Sprites","sha":"11e4d4afc91fd1744bca107330cbae461536f521","user":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":102311838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMTE4Mzg=","name":"OP2Utility","full_name":"OutpostUniverse/OP2Utility","owner":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutpostUniverse/OP2Utility","description":"C++ library for working with Outpost 2 related files and tasks.","fork":false,"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","forks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/forks","keys_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/teams","hooks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/hooks","issue_events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/events{/number}","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/events","assignees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/assignees{/user}","branches_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/branches{/branch}","tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/tags","blobs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/{sha}","languages_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/languages","stargazers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/stargazers","contributors_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contributors","subscribers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscribers","subscription_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscription","commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contents/{+path}","compare_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/merges","archive_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/downloads","issues_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues{/number}","pulls_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls{/number}","milestones_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/milestones{/number}","notifications_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels{/name}","releases_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/releases{/id}","deployments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/deployments","created_at":"2017-09-04T02:46:27Z","updated_at":"2018-09-05T15:45:34Z","pushed_at":"2018-09-10T00:43:05Z","git_url":"git://github.com/OutpostUniverse/OP2Utility.git","ssh_url":"git@github.com:OutpostUniverse/OP2Utility.git","clone_url":"https://github.com/OutpostUniverse/OP2Utility.git","svn_url":"https://github.com/OutpostUniverse/OP2Utility","homepage":"","size":650,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":23,"watchers":1,"default_branch":"master"}},"base":{"label":"OutpostUniverse:master","ref":"master","sha":"56a9fc7a06ee190299f9447faee800b7b5358e2e","user":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":102311838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMTE4Mzg=","name":"OP2Utility","full_name":"OutpostUniverse/OP2Utility","owner":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutpostUniverse/OP2Utility","description":"C++ library for working with Outpost 2 related files and tasks.","fork":false,"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","forks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/forks","keys_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/teams","hooks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/hooks","issue_events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/events{/number}","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/events","assignees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/assignees{/user}","branches_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/branches{/branch}","tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/tags","blobs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/{sha}","languages_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/languages","stargazers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/stargazers","contributors_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contributors","subscribers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscribers","subscription_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscription","commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contents/{+path}","compare_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/merges","archive_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/downloads","issues_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues{/number}","pulls_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls{/number}","milestones_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/milestones{/number}","notifications_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels{/name}","releases_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/releases{/id}","deployments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/deployments","created_at":"2017-09-04T02:46:27Z","updated_at":"2018-09-05T15:45:34Z","pushed_at":"2018-09-10T00:43:05Z","git_url":"git://github.com/OutpostUniverse/OP2Utility.git","ssh_url":"git@github.com:OutpostUniverse/OP2Utility.git","clone_url":"https://github.com/OutpostUniverse/OP2Utility.git","svn_url":"https://github.com/OutpostUniverse/OP2Utility","homepage":"","size":650,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":23,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177"},"html":{"href":"https://github.com/OutpostUniverse/OP2Utility/pull/177"},"issue":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/177"},"comments":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/11e4d4afc91fd1744bca107330cbae461536f521"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"DanRStevens"}}