{"action":"created","comment":{"url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/comments/220425294","pull_request_review_id":158829643,"id":220425294,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDQyNTI5NA==","diff_hunk":"@@ -993,6 +993,44 @@ def test_check_handle_timedout_buy(default_conf, ticker, limit_buy_order_old, fe\n     assert nb_trades == 0\n \n \n+def test_check_handle_timedout_buy_exception(default_conf, ticker, limit_buy_order_old,","path":"freqtrade/tests/test_freqtradebot.py","position":4,"original_position":4,"commit_id":"88ccdc03660ffeac25e033a07bce27807cd07e0e","original_commit_id":"88ccdc03660ffeac25e033a07bce27807cd07e0e","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"body":"i am not sure it's a typo - what would be the correct word?\r\n... it checks if it \"timed out\" (so historic tense) - at least that's my assumption as to why the original function is called this way","created_at":"2018-09-26T04:45:04Z","updated_at":"2018-09-26T04:45:04Z","html_url":"https://github.com/freqtrade/freqtrade/pull/1238#discussion_r220425294","pull_request_url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/freqtrade/freqtrade/pulls/comments/220425294"},"html":{"href":"https://github.com/freqtrade/freqtrade/pull/1238#discussion_r220425294"},"pull_request":{"href":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238"}},"in_reply_to_id":220371527},"pull_request":{"url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238","id":218081723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDgxNzIz","html_url":"https://github.com/freqtrade/freqtrade/pull/1238","diff_url":"https://github.com/freqtrade/freqtrade/pull/1238.diff","patch_url":"https://github.com/freqtrade/freqtrade/pull/1238.patch","issue_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1238","number":1238,"state":"open","locked":false,"title":"Fix exception when order cannot be found","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"body":"## Summary\r\nProperly handle exception if the order can't be found by id.\r\n\r\n\r\nSolve the issue: #1237\r\n\r\n## Quick changelog\r\n\r\n- Catch reraised exception\r\n\r\n## What's new?\r\n\r\nccxt raises `OrderNotFound` - which is a sub-class of `InvalidOrder`, which we reraise as `Dependencyexception`.\r\nTherefore, freqtrade has to catch this exception to avoid crashing (see issue for details).","created_at":"2018-09-25T18:47:55Z","updated_at":"2018-09-26T04:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b35d15017bd1299c27308eb399d927d25025828e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238/commits","review_comments_url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238/comments","review_comment_url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1238/comments","statuses_url":"https://api.github.com/repos/freqtrade/freqtrade/statuses/88ccdc03660ffeac25e033a07bce27807cd07e0e","head":{"label":"freqtrade:fix/buyexception","ref":"fix/buyexception","sha":"88ccdc03660ffeac25e033a07bce27807cd07e0e","user":{"login":"freqtrade","id":37536846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTM2ODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/37536846?v=4","gravatar_id":"","url":"https://api.github.com/users/freqtrade","html_url":"https://github.com/freqtrade","followers_url":"https://api.github.com/users/freqtrade/followers","following_url":"https://api.github.com/users/freqtrade/following{/other_user}","gists_url":"https://api.github.com/users/freqtrade/gists{/gist_id}","starred_url":"https://api.github.com/users/freqtrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freqtrade/subscriptions","organizations_url":"https://api.github.com/users/freqtrade/orgs","repos_url":"https://api.github.com/users/freqtrade/repos","events_url":"https://api.github.com/users/freqtrade/events{/privacy}","received_events_url":"https://api.github.com/users/freqtrade/received_events","type":"Organization","site_admin":false},"repo":{"id":91629816,"node_id":"MDEwOlJlcG9zaXRvcnk5MTYyOTgxNg==","name":"freqtrade","full_name":"freqtrade/freqtrade","private":false,"owner":{"login":"freqtrade","id":37536846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTM2ODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/37536846?v=4","gravatar_id":"","url":"https://api.github.com/users/freqtrade","html_url":"https://github.com/freqtrade","followers_url":"https://api.github.com/users/freqtrade/followers","following_url":"https://api.github.com/users/freqtrade/following{/other_user}","gists_url":"https://api.github.com/users/freqtrade/gists{/gist_id}","starred_url":"https://api.github.com/users/freqtrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freqtrade/subscriptions","organizations_url":"https://api.github.com/users/freqtrade/orgs","repos_url":"https://api.github.com/users/freqtrade/repos","events_url":"https://api.github.com/users/freqtrade/events{/privacy}","received_events_url":"https://api.github.com/users/freqtrade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freqtrade/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/freqtrade/freqtrade","forks_url":"https://api.github.com/repos/freqtrade/freqtrade/forks","keys_url":"https://api.github.com/repos/freqtrade/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freqtrade/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freqtrade/freqtrade/teams","hooks_url":"https://api.github.com/repos/freqtrade/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/freqtrade/freqtrade/events","assignees_url":"https://api.github.com/repos/freqtrade/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/freqtrade/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/freqtrade/freqtrade/tags","blobs_url":"https://api.github.com/repos/freqtrade/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freqtrade/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freqtrade/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/freqtrade/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freqtrade/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/freqtrade/freqtrade/languages","stargazers_url":"https://api.github.com/repos/freqtrade/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/freqtrade/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/freqtrade/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/freqtrade/freqtrade/subscription","commits_url":"https://api.github.com/repos/freqtrade/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/freqtrade/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/freqtrade/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/freqtrade/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/freqtrade/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freqtrade/freqtrade/merges","archive_url":"https://api.github.com/repos/freqtrade/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freqtrade/freqtrade/downloads","issues_url":"https://api.github.com/repos/freqtrade/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/freqtrade/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/freqtrade/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/freqtrade/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freqtrade/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/freqtrade/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/freqtrade/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-09-26T04:38:41Z","pushed_at":"2018-09-26T04:38:40Z","git_url":"git://github.com/freqtrade/freqtrade.git","ssh_url":"git@github.com:freqtrade/freqtrade.git","clone_url":"https://github.com/freqtrade/freqtrade.git","svn_url":"https://github.com/freqtrade/freqtrade","homepage":null,"size":32840,"stargazers_count":1157,"watchers_count":1157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":346,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":346,"open_issues":77,"watchers":1157,"default_branch":"develop"}},"base":{"label":"freqtrade:develop","ref":"develop","sha":"d04247cd9ea1180a960365ec08f66c115cd092c6","user":{"login":"freqtrade","id":37536846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTM2ODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/37536846?v=4","gravatar_id":"","url":"https://api.github.com/users/freqtrade","html_url":"https://github.com/freqtrade","followers_url":"https://api.github.com/users/freqtrade/followers","following_url":"https://api.github.com/users/freqtrade/following{/other_user}","gists_url":"https://api.github.com/users/freqtrade/gists{/gist_id}","starred_url":"https://api.github.com/users/freqtrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freqtrade/subscriptions","organizations_url":"https://api.github.com/users/freqtrade/orgs","repos_url":"https://api.github.com/users/freqtrade/repos","events_url":"https://api.github.com/users/freqtrade/events{/privacy}","received_events_url":"https://api.github.com/users/freqtrade/received_events","type":"Organization","site_admin":false},"repo":{"id":91629816,"node_id":"MDEwOlJlcG9zaXRvcnk5MTYyOTgxNg==","name":"freqtrade","full_name":"freqtrade/freqtrade","private":false,"owner":{"login":"freqtrade","id":37536846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTM2ODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/37536846?v=4","gravatar_id":"","url":"https://api.github.com/users/freqtrade","html_url":"https://github.com/freqtrade","followers_url":"https://api.github.com/users/freqtrade/followers","following_url":"https://api.github.com/users/freqtrade/following{/other_user}","gists_url":"https://api.github.com/users/freqtrade/gists{/gist_id}","starred_url":"https://api.github.com/users/freqtrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freqtrade/subscriptions","organizations_url":"https://api.github.com/users/freqtrade/orgs","repos_url":"https://api.github.com/users/freqtrade/repos","events_url":"https://api.github.com/users/freqtrade/events{/privacy}","received_events_url":"https://api.github.com/users/freqtrade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freqtrade/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/freqtrade/freqtrade","forks_url":"https://api.github.com/repos/freqtrade/freqtrade/forks","keys_url":"https://api.github.com/repos/freqtrade/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freqtrade/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freqtrade/freqtrade/teams","hooks_url":"https://api.github.com/repos/freqtrade/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/freqtrade/freqtrade/events","assignees_url":"https://api.github.com/repos/freqtrade/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/freqtrade/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/freqtrade/freqtrade/tags","blobs_url":"https://api.github.com/repos/freqtrade/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freqtrade/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freqtrade/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/freqtrade/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freqtrade/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/freqtrade/freqtrade/languages","stargazers_url":"https://api.github.com/repos/freqtrade/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/freqtrade/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/freqtrade/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/freqtrade/freqtrade/subscription","commits_url":"https://api.github.com/repos/freqtrade/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/freqtrade/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/freqtrade/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/freqtrade/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/freqtrade/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freqtrade/freqtrade/merges","archive_url":"https://api.github.com/repos/freqtrade/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freqtrade/freqtrade/downloads","issues_url":"https://api.github.com/repos/freqtrade/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/freqtrade/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/freqtrade/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/freqtrade/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freqtrade/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/freqtrade/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/freqtrade/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-09-26T04:38:41Z","pushed_at":"2018-09-26T04:38:40Z","git_url":"git://github.com/freqtrade/freqtrade.git","ssh_url":"git@github.com:freqtrade/freqtrade.git","clone_url":"https://github.com/freqtrade/freqtrade.git","svn_url":"https://github.com/freqtrade/freqtrade","homepage":null,"size":32840,"stargazers_count":1157,"watchers_count":1157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":346,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":346,"open_issues":77,"watchers":1157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238"},"html":{"href":"https://github.com/freqtrade/freqtrade/pull/1238"},"issue":{"href":"https://api.github.com/repos/freqtrade/freqtrade/issues/1238"},"comments":{"href":"https://api.github.com/repos/freqtrade/freqtrade/issues/1238/comments"},"review_comments":{"href":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238/comments"},"review_comment":{"href":"https://api.github.com/repos/freqtrade/freqtrade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1238/commits"},"statuses":{"href":"https://api.github.com/repos/freqtrade/freqtrade/statuses/88ccdc03660ffeac25e033a07bce27807cd07e0e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xmatthias"}}