{"push_id":2561525114,"size":11,"distinct_size":6,"ref":"refs/heads/add-poller-docs","head":"4fea7184dc2ea19d28dcb6f6be943a42d1a04d0c","before":"31832ee5d06e619bbd78e5e91ce4239bc1b84dd1","commits":[{"sha":"f218478237e91580db8d5f4e4f504e079cc73a1a","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: test_heartbeats use no test framework\n\nSolution: migrate to unity","distinct":false,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/f218478237e91580db8d5f4e4f504e079cc73a1a"},{"sha":"ba9274c39a8884ce242c40d015c52e0e2fc74ba9","author":{"name":"Luca Boccassi","email":"678b97863301219a7659ccb717573825b33ce6a7@gmail.com"},"message":"Problem: test_heartbeats mocked ZMQ_REP is hacky and fragile\n\nSolution: remove it, it doesn't add much value anyway","distinct":false,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/ba9274c39a8884ce242c40d015c52e0e2fc74ba9"},{"sha":"5482b1ca458942f9b5ef59cfb03779018127ac2c","author":{"name":"Luca Boccassi","email":"678b97863301219a7659ccb717573825b33ce6a7@gmail.com"},"message":"Problem: heartbeat command parsing does not check command name size\n\nSolution: treat the first byte of the command body as the size of the\ncommand name, rather than as an id, to comply with ZMTP 3.1.\nThis was not an actual problem at runtime since both heartbeat\ncommands have a size of 4, which was treated like an id.\nBut once SUBSCRIBE/UNSUBSCRIBE get implemented it needs to be checked.","distinct":false,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/5482b1ca458942f9b5ef59cfb03779018127ac2c"},{"sha":"b331caad069ca99a73ba951d466b42cd1f599f59","author":{"name":"Luca Boccassi","email":"678b97863301219a7659ccb717573825b33ce6a7@gmail.com"},"message":"Problem: ZMTP 3.1 PING Context not implemented\n\nSolution: if a PING message contains a context, echo it back in the\nPONG message. In order to do so, create the PONG message when PING\nis received and store it in the engine.\nAfter the PING the engine goes straight to encoding and sending, so\nthere can always be at most one pending PING.\nAdd tests for various contexts.","distinct":false,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/b331caad069ca99a73ba951d466b42cd1f599f59"},{"sha":"be66eacf5c689c3ff0685335e515a6affef62673","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: test_heartbeats still using plain assertions\n\nSolution: migrate to unity assertions","distinct":false,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/be66eacf5c689c3ff0685335e515a6affef62673"},{"sha":"0a037a74319438caa28621795324f071c9d138cf","author":{"name":"Luca Boccassi","email":"678b97863301219a7659ccb717573825b33ce6a7@gmail.com"},"message":"Merge pull request #3097 from sigiesec/ping-context\n\nZMTP 3.1 PING Context not implemented","distinct":true,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/0a037a74319438caa28621795324f071c9d138cf"},{"sha":"00d25b78734b2253bd7914121188e0f6343a23ba","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: inconsistent behaviour of zmq_poller_add and zmq_poller_add_fd in case of memory exhaustion\n\nSolution: always return -1 with errno == ENOMEM","distinct":true,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/00d25b78734b2253bd7914121188e0f6343a23ba"},{"sha":"2cd147e5ff935e95a0153b175510b89741f37391","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: misleading comment for calling zmq_poller_add with events == 0\n\nSolution: change comment, and add test case for zmq_poller_modify with events == 0","distinct":true,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/2cd147e5ff935e95a0153b175510b89741f37391"},{"sha":"213254cca5846a9fe5b2283dd5792694a1c1bba8","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: inconsistent behaviour of zmq_poller_new in case of memory exhaustion\n\nSolution: return NULL and set errno to ENOMEM","distinct":true,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/213254cca5846a9fe5b2283dd5792694a1c1bba8"},{"sha":"f4b1cae082075f92bda8cd52ba1886621b692ec5","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: no documentation for zmq_poller_*\n\nSolution: add initial documentation","distinct":true,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/f4b1cae082075f92bda8cd52ba1886621b692ec5"},{"sha":"4fea7184dc2ea19d28dcb6f6be943a42d1a04d0c","author":{"name":"Simon Giesecke","email":"2557fdbcaea51433734305b61bb667f0c549a5a2@btc-ag.com"},"message":"Problem: man zmq_poller_* not working\n\nSolution: add symlinks to zmq_poller.txt","distinct":true,"url":"https://api.github.com/repos/sigiesec/libzmq/commits/4fea7184dc2ea19d28dcb6f6be943a42d1a04d0c"}]}
{"actor":{"display_login":"sigiesec"}}