{"action":"created","comment":{"url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments/181337801","pull_request_review_id":111947219,"id":181337801,"diff_hunk":"@@ -59,7 +59,9 @@ protected void waitUntilReady() {\n                 super.waitUntilReady();\n                 ready.set(true);\n             }\n-        }.forResponsePredicate(s -> s.equals(GOOD_RESPONSE_BODY));\n+        }\n+        .forResponsePredicate(s -> s.equals(GOOD_RESPONSE_BODY))","path":"core/src/test/java/org/testcontainers/junit/wait/strategy/HttpWaitStrategyTest.java","position":58,"original_position":45,"commit_id":"808dcf82584815aa0ab4fc41bdf1554babcf4bad","original_commit_id":"370c35a322dd09562b7dcd4977c06cc8d05466ff","user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars3.githubusercontent.com/u/274222?v=4","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-04-13T09:46:58Z","updated_at":"2018-04-13T09:46:58Z","html_url":"https://github.com/testcontainers/testcontainers-java/pull/630#discussion_r181337801","pull_request_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments/181337801"},"html":{"href":"https://github.com/testcontainers/testcontainers-java/pull/630#discussion_r181337801"},"pull_request":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630"}},"in_reply_to_id":181333650},"pull_request":{"url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630","id":178729800,"html_url":"https://github.com/testcontainers/testcontainers-java/pull/630","diff_url":"https://github.com/testcontainers/testcontainers-java/pull/630.diff","patch_url":"https://github.com/testcontainers/testcontainers-java/pull/630.patch","issue_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/630","number":630,"state":"open","locked":false,"title":"Support multiple HTTP status codes for HttpWaitStrategy","user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars3.githubusercontent.com/u/274222?v=4","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"body":"In the context of elasticsearch test containers module, I'd like to\r\nadd an ElasticsearchWaitStrategy class which extends the HttpWaitStrategy\r\nwith some default settings so it will be even easier for a end user to\r\nstart an ElasticsearchTestContainer.\r\n\r\nAnyway, in this context, I found helpful that the HttpWaitStrategy expects\r\nmore than on status code.\r\n\r\nFor example, you can imagine running elasticsearch in secure mode or\r\nwithout any security. In which cases the elasticsearch service might answer 200 or 401.\r\n\r\nThis commit proposes this change.","created_at":"2018-04-01T13:48:18Z","updated_at":"2018-04-13T09:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c5352910b425b83ad36f457df2ee2117c9e49e3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rnorth","id":132175,"avatar_url":"https://avatars1.githubusercontent.com/u/132175?v=4","gravatar_id":"","url":"https://api.github.com/users/rnorth","html_url":"https://github.com/rnorth","followers_url":"https://api.github.com/users/rnorth/followers","following_url":"https://api.github.com/users/rnorth/following{/other_user}","gists_url":"https://api.github.com/users/rnorth/gists{/gist_id}","starred_url":"https://api.github.com/users/rnorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnorth/subscriptions","organizations_url":"https://api.github.com/users/rnorth/orgs","repos_url":"https://api.github.com/users/rnorth/repos","events_url":"https://api.github.com/users/rnorth/events{/privacy}","received_events_url":"https://api.github.com/users/rnorth/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":819284860,"url":"https://api.github.com/repos/testcontainers/testcontainers-java/labels/type/feature","name":"type/feature","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/testcontainers/testcontainers-java/milestones/32","html_url":"https://github.com/testcontainers/testcontainers-java/milestone/32","labels_url":"https://api.github.com/repos/testcontainers/testcontainers-java/milestones/32/labels","id":3249732,"number":32,"title":"next","description":"","creator":{"login":"bsideup","id":1050762,"avatar_url":"https://avatars3.githubusercontent.com/u/1050762?v=4","gravatar_id":"","url":"https://api.github.com/users/bsideup","html_url":"https://github.com/bsideup","followers_url":"https://api.github.com/users/bsideup/followers","following_url":"https://api.github.com/users/bsideup/following{/other_user}","gists_url":"https://api.github.com/users/bsideup/gists{/gist_id}","starred_url":"https://api.github.com/users/bsideup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsideup/subscriptions","organizations_url":"https://api.github.com/users/bsideup/orgs","repos_url":"https://api.github.com/users/bsideup/repos","events_url":"https://api.github.com/users/bsideup/events{/privacy}","received_events_url":"https://api.github.com/users/bsideup/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2018-04-07T17:03:54Z","updated_at":"2018-04-12T19:15:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630/commits","review_comments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630/comments","review_comment_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/630/comments","statuses_url":"https://api.github.com/repos/testcontainers/testcontainers-java/statuses/808dcf82584815aa0ab4fc41bdf1554babcf4bad","head":{"label":"dadoonet:pr/http-multiple-ports","ref":"pr/http-multiple-ports","sha":"808dcf82584815aa0ab4fc41bdf1554babcf4bad","user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars3.githubusercontent.com/u/274222?v=4","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"repo":{"id":108531528,"name":"testcontainers-java","full_name":"dadoonet/testcontainers-java","owner":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars3.githubusercontent.com/u/274222?v=4","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dadoonet/testcontainers-java","description":"TestContainers is a Java 8 library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.","fork":true,"url":"https://api.github.com/repos/dadoonet/testcontainers-java","forks_url":"https://api.github.com/repos/dadoonet/testcontainers-java/forks","keys_url":"https://api.github.com/repos/dadoonet/testcontainers-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dadoonet/testcontainers-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dadoonet/testcontainers-java/teams","hooks_url":"https://api.github.com/repos/dadoonet/testcontainers-java/hooks","issue_events_url":"https://api.github.com/repos/dadoonet/testcontainers-java/issues/events{/number}","events_url":"https://api.github.com/repos/dadoonet/testcontainers-java/events","assignees_url":"https://api.github.com/repos/dadoonet/testcontainers-java/assignees{/user}","branches_url":"https://api.github.com/repos/dadoonet/testcontainers-java/branches{/branch}","tags_url":"https://api.github.com/repos/dadoonet/testcontainers-java/tags","blobs_url":"https://api.github.com/repos/dadoonet/testcontainers-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dadoonet/testcontainers-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dadoonet/testcontainers-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/dadoonet/testcontainers-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dadoonet/testcontainers-java/statuses/{sha}","languages_url":"https://api.github.com/repos/dadoonet/testcontainers-java/languages","stargazers_url":"https://api.github.com/repos/dadoonet/testcontainers-java/stargazers","contributors_url":"https://api.github.com/repos/dadoonet/testcontainers-java/contributors","subscribers_url":"https://api.github.com/repos/dadoonet/testcontainers-java/subscribers","subscription_url":"https://api.github.com/repos/dadoonet/testcontainers-java/subscription","commits_url":"https://api.github.com/repos/dadoonet/testcontainers-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/dadoonet/testcontainers-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/dadoonet/testcontainers-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/dadoonet/testcontainers-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/dadoonet/testcontainers-java/contents/{+path}","compare_url":"https://api.github.com/repos/dadoonet/testcontainers-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dadoonet/testcontainers-java/merges","archive_url":"https://api.github.com/repos/dadoonet/testcontainers-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dadoonet/testcontainers-java/downloads","issues_url":"https://api.github.com/repos/dadoonet/testcontainers-java/issues{/number}","pulls_url":"https://api.github.com/repos/dadoonet/testcontainers-java/pulls{/number}","milestones_url":"https://api.github.com/repos/dadoonet/testcontainers-java/milestones{/number}","notifications_url":"https://api.github.com/repos/dadoonet/testcontainers-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dadoonet/testcontainers-java/labels{/name}","releases_url":"https://api.github.com/repos/dadoonet/testcontainers-java/releases{/id}","deployments_url":"https://api.github.com/repos/dadoonet/testcontainers-java/deployments","created_at":"2017-10-27T10:14:33Z","updated_at":"2018-04-01T13:48:05Z","pushed_at":"2018-04-13T09:46:44Z","git_url":"git://github.com/dadoonet/testcontainers-java.git","ssh_url":"git@github.com:dadoonet/testcontainers-java.git","clone_url":"https://github.com/dadoonet/testcontainers-java.git","svn_url":"https://github.com/dadoonet/testcontainers-java","homepage":"https://testcontainers.org","size":1886,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"testcontainers:master","ref":"master","sha":"fd1a0798cfdcbbacd91c061313edc2d8ff54d8cf","user":{"login":"testcontainers","id":13393021,"avatar_url":"https://avatars2.githubusercontent.com/u/13393021?v=4","gravatar_id":"","url":"https://api.github.com/users/testcontainers","html_url":"https://github.com/testcontainers","followers_url":"https://api.github.com/users/testcontainers/followers","following_url":"https://api.github.com/users/testcontainers/following{/other_user}","gists_url":"https://api.github.com/users/testcontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/testcontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testcontainers/subscriptions","organizations_url":"https://api.github.com/users/testcontainers/orgs","repos_url":"https://api.github.com/users/testcontainers/repos","events_url":"https://api.github.com/users/testcontainers/events{/privacy}","received_events_url":"https://api.github.com/users/testcontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":33816473,"name":"testcontainers-java","full_name":"testcontainers/testcontainers-java","owner":{"login":"testcontainers","id":13393021,"avatar_url":"https://avatars2.githubusercontent.com/u/13393021?v=4","gravatar_id":"","url":"https://api.github.com/users/testcontainers","html_url":"https://github.com/testcontainers","followers_url":"https://api.github.com/users/testcontainers/followers","following_url":"https://api.github.com/users/testcontainers/following{/other_user}","gists_url":"https://api.github.com/users/testcontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/testcontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testcontainers/subscriptions","organizations_url":"https://api.github.com/users/testcontainers/orgs","repos_url":"https://api.github.com/users/testcontainers/repos","events_url":"https://api.github.com/users/testcontainers/events{/privacy}","received_events_url":"https://api.github.com/users/testcontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/testcontainers/testcontainers-java","description":"Testcontainers is a Java 8 library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.","fork":false,"url":"https://api.github.com/repos/testcontainers/testcontainers-java","forks_url":"https://api.github.com/repos/testcontainers/testcontainers-java/forks","keys_url":"https://api.github.com/repos/testcontainers/testcontainers-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/testcontainers/testcontainers-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/testcontainers/testcontainers-java/teams","hooks_url":"https://api.github.com/repos/testcontainers/testcontainers-java/hooks","issue_events_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/events{/number}","events_url":"https://api.github.com/repos/testcontainers/testcontainers-java/events","assignees_url":"https://api.github.com/repos/testcontainers/testcontainers-java/assignees{/user}","branches_url":"https://api.github.com/repos/testcontainers/testcontainers-java/branches{/branch}","tags_url":"https://api.github.com/repos/testcontainers/testcontainers-java/tags","blobs_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/testcontainers/testcontainers-java/statuses/{sha}","languages_url":"https://api.github.com/repos/testcontainers/testcontainers-java/languages","stargazers_url":"https://api.github.com/repos/testcontainers/testcontainers-java/stargazers","contributors_url":"https://api.github.com/repos/testcontainers/testcontainers-java/contributors","subscribers_url":"https://api.github.com/repos/testcontainers/testcontainers-java/subscribers","subscription_url":"https://api.github.com/repos/testcontainers/testcontainers-java/subscription","commits_url":"https://api.github.com/repos/testcontainers/testcontainers-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/testcontainers/testcontainers-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/testcontainers/testcontainers-java/contents/{+path}","compare_url":"https://api.github.com/repos/testcontainers/testcontainers-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/testcontainers/testcontainers-java/merges","archive_url":"https://api.github.com/repos/testcontainers/testcontainers-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/testcontainers/testcontainers-java/downloads","issues_url":"https://api.github.com/repos/testcontainers/testcontainers-java/issues{/number}","pulls_url":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls{/number}","milestones_url":"https://api.github.com/repos/testcontainers/testcontainers-java/milestones{/number}","notifications_url":"https://api.github.com/repos/testcontainers/testcontainers-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/testcontainers/testcontainers-java/labels{/name}","releases_url":"https://api.github.com/repos/testcontainers/testcontainers-java/releases{/id}","deployments_url":"https://api.github.com/repos/testcontainers/testcontainers-java/deployments","created_at":"2015-04-12T12:44:59Z","updated_at":"2018-04-13T09:32:22Z","pushed_at":"2018-04-13T09:46:46Z","git_url":"git://github.com/testcontainers/testcontainers-java.git","ssh_url":"git@github.com:testcontainers/testcontainers-java.git","clone_url":"https://github.com/testcontainers/testcontainers-java.git","svn_url":"https://github.com/testcontainers/testcontainers-java","homepage":"https://testcontainers.org","size":1915,"stargazers_count":1057,"watchers_count":1057,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":183,"open_issues":108,"watchers":1057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630"},"html":{"href":"https://github.com/testcontainers/testcontainers-java/pull/630"},"issue":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/630"},"comments":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/testcontainers/testcontainers-java/statuses/808dcf82584815aa0ab4fc41bdf1554babcf4bad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dadoonet"}}