{"action":"closed","number":239,"pull_request":{"url":"https://api.github.com/repos/kengz/SLM-Lab/pulls/239","id":231980579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTgwNTc5","html_url":"https://github.com/kengz/SLM-Lab/pull/239","diff_url":"https://github.com/kengz/SLM-Lab/pull/239.diff","patch_url":"https://github.com/kengz/SLM-Lab/pull/239.patch","issue_url":"https://api.github.com/repos/kengz/SLM-Lab/issues/239","number":239,"state":"closed","locked":false,"title":"V3 improvements: DQN speedup, generic variable scheduler, env max tick","user":{"login":"kengz","id":8209263,"node_id":"MDQ6VXNlcjgyMDkyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8209263?v=4","gravatar_id":"","url":"https://api.github.com/users/kengz","html_url":"https://github.com/kengz","followers_url":"https://api.github.com/users/kengz/followers","following_url":"https://api.github.com/users/kengz/following{/other_user}","gists_url":"https://api.github.com/users/kengz/gists{/gist_id}","starred_url":"https://api.github.com/users/kengz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kengz/subscriptions","organizations_url":"https://api.github.com/users/kengz/orgs","repos_url":"https://api.github.com/users/kengz/repos","events_url":"https://api.github.com/users/kengz/events{/privacy}","received_events_url":"https://api.github.com/users/kengz/received_events","type":"User","site_admin":false},"body":"## DQN\r\n- rewrite DQN loss for 2x speedup and code simplicity. extend to SARSA\r\n- retire MultitaskDQN for HydraDQN\r\n\r\n## Memory\r\n- add `OnpolicyConcatReplay`\r\n- standardize `preprocess_state` logic in onpolicy memories\r\n\r\n## Variable Scheduler (breaking spec changes)\r\n- implement variable decay class `VarScheduler` similar to pytorch's LR scheduler. use clock with flexible scheduling units `epi` or `total_t`\r\n- retire `action_policy_update`, update agent spec to `explore_var_spec`\r\n- generalize `entropy_coef_spec`to be similar to `explore_var_spec`, add spec accordingly\r\n- update all specs\r\n\r\n## Math util\r\n- move decay methods to `math_util.py`\r\n- move `math_util.py` from `algorithm/` to `lib/`\r\n\r\n## env max tick (breaking spec changes)\r\n- spec/variable renamings:\r\n  - `max_episode` to `max_epi`\r\n  - `max_timestep` to `max_t`\r\n  - `save_epi_frequency` to `save_frequency`\r\n  - `traininig_min_timestep` to `training_start_step`\r\n- allow env to stop based on `max_epi` as well as `max_total_t`. propagate clock unit usage\r\n- allow `save_frequency` to use the same units accordingly\r\n- update Pong and Beamrider to use `max_total_t` as end-condition\r\n\r\n## Update Ray to reenable CUDA in search\r\n- update ray from `0.3.1` to `0.5.3` to address broken GPU with pytorch 1.0.0\r\n- to fix CUDA not discovered in Ray worker, have to manually set CUDA devices at ray remote function due to poor design.","created_at":"2018-11-19T13:53:02Z","updated_at":"2018-11-28T17:38:49Z","closed_at":"2018-11-28T17:38:49Z","merged_at":"2018-11-28T17:38:49Z","merge_commit_sha":"de19d682e0ac7ed934615bbacbdc3bbdd138874e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kengz/SLM-Lab/pulls/239/commits","review_comments_url":"https://api.github.com/repos/kengz/SLM-Lab/pulls/239/comments","review_comment_url":"https://api.github.com/repos/kengz/SLM-Lab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kengz/SLM-Lab/issues/239/comments","statuses_url":"https://api.github.com/repos/kengz/SLM-Lab/statuses/777fbf8c2876c9c144cf0737bcf2090031b3ef16","head":{"label":"kengz:v3-pong","ref":"v3-pong","sha":"777fbf8c2876c9c144cf0737bcf2090031b3ef16","user":{"login":"kengz","id":8209263,"node_id":"MDQ6VXNlcjgyMDkyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8209263?v=4","gravatar_id":"","url":"https://api.github.com/users/kengz","html_url":"https://github.com/kengz","followers_url":"https://api.github.com/users/kengz/followers","following_url":"https://api.github.com/users/kengz/following{/other_user}","gists_url":"https://api.github.com/users/kengz/gists{/gist_id}","starred_url":"https://api.github.com/users/kengz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kengz/subscriptions","organizations_url":"https://api.github.com/users/kengz/orgs","repos_url":"https://api.github.com/users/kengz/repos","events_url":"https://api.github.com/users/kengz/events{/privacy}","received_events_url":"https://api.github.com/users/kengz/received_events","type":"User","site_admin":false},"repo":{"id":105591065,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTEwNjU=","name":"SLM-Lab","full_name":"kengz/SLM-Lab","private":false,"owner":{"login":"kengz","id":8209263,"node_id":"MDQ6VXNlcjgyMDkyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8209263?v=4","gravatar_id":"","url":"https://api.github.com/users/kengz","html_url":"https://github.com/kengz","followers_url":"https://api.github.com/users/kengz/followers","following_url":"https://api.github.com/users/kengz/following{/other_user}","gists_url":"https://api.github.com/users/kengz/gists{/gist_id}","starred_url":"https://api.github.com/users/kengz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kengz/subscriptions","organizations_url":"https://api.github.com/users/kengz/orgs","repos_url":"https://api.github.com/users/kengz/repos","events_url":"https://api.github.com/users/kengz/events{/privacy}","received_events_url":"https://api.github.com/users/kengz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kengz/SLM-Lab","description":"Modular Deep Reinforcement Learning framework in PyTorch.","fork":false,"url":"https://api.github.com/repos/kengz/SLM-Lab","forks_url":"https://api.github.com/repos/kengz/SLM-Lab/forks","keys_url":"https://api.github.com/repos/kengz/SLM-Lab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kengz/SLM-Lab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kengz/SLM-Lab/teams","hooks_url":"https://api.github.com/repos/kengz/SLM-Lab/hooks","issue_events_url":"https://api.github.com/repos/kengz/SLM-Lab/issues/events{/number}","events_url":"https://api.github.com/repos/kengz/SLM-Lab/events","assignees_url":"https://api.github.com/repos/kengz/SLM-Lab/assignees{/user}","branches_url":"https://api.github.com/repos/kengz/SLM-Lab/branches{/branch}","tags_url":"https://api.github.com/repos/kengz/SLM-Lab/tags","blobs_url":"https://api.github.com/repos/kengz/SLM-Lab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kengz/SLM-Lab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kengz/SLM-Lab/git/refs{/sha}","trees_url":"https://api.github.com/repos/kengz/SLM-Lab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kengz/SLM-Lab/statuses/{sha}","languages_url":"https://api.github.com/repos/kengz/SLM-Lab/languages","stargazers_url":"https://api.github.com/repos/kengz/SLM-Lab/stargazers","contributors_url":"https://api.github.com/repos/kengz/SLM-Lab/contributors","subscribers_url":"https://api.github.com/repos/kengz/SLM-Lab/subscribers","subscription_url":"https://api.github.com/repos/kengz/SLM-Lab/subscription","commits_url":"https://api.github.com/repos/kengz/SLM-Lab/commits{/sha}","git_commits_url":"https://api.github.com/repos/kengz/SLM-Lab/git/commits{/sha}","comments_url":"https://api.github.com/repos/kengz/SLM-Lab/comments{/number}","issue_comment_url":"https://api.github.com/repos/kengz/SLM-Lab/issues/comments{/number}","contents_url":"https://api.github.com/repos/kengz/SLM-Lab/contents/{+path}","compare_url":"https://api.github.com/repos/kengz/SLM-Lab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kengz/SLM-Lab/merges","archive_url":"https://api.github.com/repos/kengz/SLM-Lab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kengz/SLM-Lab/downloads","issues_url":"https://api.github.com/repos/kengz/SLM-Lab/issues{/number}","pulls_url":"https://api.github.com/repos/kengz/SLM-Lab/pulls{/number}","milestones_url":"https://api.github.com/repos/kengz/SLM-Lab/milestones{/number}","notifications_url":"https://api.github.com/repos/kengz/SLM-Lab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kengz/SLM-Lab/labels{/name}","releases_url":"https://api.github.com/repos/kengz/SLM-Lab/releases{/id}","deployments_url":"https://api.github.com/repos/kengz/SLM-Lab/deployments","created_at":"2017-10-02T22:20:22Z","updated_at":"2018-11-26T18:53:26Z","pushed_at":"2018-11-28T17:38:49Z","git_url":"git://github.com/kengz/SLM-Lab.git","ssh_url":"git@github.com:kengz/SLM-Lab.git","clone_url":"https://github.com/kengz/SLM-Lab.git","svn_url":"https://github.com/kengz/SLM-Lab","homepage":"https://kengz.gitbooks.io/slm-lab/content/","size":2142,"stargazers_count":407,"watchers_count":407,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":60,"open_issues":1,"watchers":407,"default_branch":"master"}},"base":{"label":"kengz:v3-beta","ref":"v3-beta","sha":"e0a0f5de6812a873fcdaa97e49e24c9a6502d09b","user":{"login":"kengz","id":8209263,"node_id":"MDQ6VXNlcjgyMDkyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8209263?v=4","gravatar_id":"","url":"https://api.github.com/users/kengz","html_url":"https://github.com/kengz","followers_url":"https://api.github.com/users/kengz/followers","following_url":"https://api.github.com/users/kengz/following{/other_user}","gists_url":"https://api.github.com/users/kengz/gists{/gist_id}","starred_url":"https://api.github.com/users/kengz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kengz/subscriptions","organizations_url":"https://api.github.com/users/kengz/orgs","repos_url":"https://api.github.com/users/kengz/repos","events_url":"https://api.github.com/users/kengz/events{/privacy}","received_events_url":"https://api.github.com/users/kengz/received_events","type":"User","site_admin":false},"repo":{"id":105591065,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU1OTEwNjU=","name":"SLM-Lab","full_name":"kengz/SLM-Lab","private":false,"owner":{"login":"kengz","id":8209263,"node_id":"MDQ6VXNlcjgyMDkyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8209263?v=4","gravatar_id":"","url":"https://api.github.com/users/kengz","html_url":"https://github.com/kengz","followers_url":"https://api.github.com/users/kengz/followers","following_url":"https://api.github.com/users/kengz/following{/other_user}","gists_url":"https://api.github.com/users/kengz/gists{/gist_id}","starred_url":"https://api.github.com/users/kengz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kengz/subscriptions","organizations_url":"https://api.github.com/users/kengz/orgs","repos_url":"https://api.github.com/users/kengz/repos","events_url":"https://api.github.com/users/kengz/events{/privacy}","received_events_url":"https://api.github.com/users/kengz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kengz/SLM-Lab","description":"Modular Deep Reinforcement Learning framework in PyTorch.","fork":false,"url":"https://api.github.com/repos/kengz/SLM-Lab","forks_url":"https://api.github.com/repos/kengz/SLM-Lab/forks","keys_url":"https://api.github.com/repos/kengz/SLM-Lab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kengz/SLM-Lab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kengz/SLM-Lab/teams","hooks_url":"https://api.github.com/repos/kengz/SLM-Lab/hooks","issue_events_url":"https://api.github.com/repos/kengz/SLM-Lab/issues/events{/number}","events_url":"https://api.github.com/repos/kengz/SLM-Lab/events","assignees_url":"https://api.github.com/repos/kengz/SLM-Lab/assignees{/user}","branches_url":"https://api.github.com/repos/kengz/SLM-Lab/branches{/branch}","tags_url":"https://api.github.com/repos/kengz/SLM-Lab/tags","blobs_url":"https://api.github.com/repos/kengz/SLM-Lab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kengz/SLM-Lab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kengz/SLM-Lab/git/refs{/sha}","trees_url":"https://api.github.com/repos/kengz/SLM-Lab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kengz/SLM-Lab/statuses/{sha}","languages_url":"https://api.github.com/repos/kengz/SLM-Lab/languages","stargazers_url":"https://api.github.com/repos/kengz/SLM-Lab/stargazers","contributors_url":"https://api.github.com/repos/kengz/SLM-Lab/contributors","subscribers_url":"https://api.github.com/repos/kengz/SLM-Lab/subscribers","subscription_url":"https://api.github.com/repos/kengz/SLM-Lab/subscription","commits_url":"https://api.github.com/repos/kengz/SLM-Lab/commits{/sha}","git_commits_url":"https://api.github.com/repos/kengz/SLM-Lab/git/commits{/sha}","comments_url":"https://api.github.com/repos/kengz/SLM-Lab/comments{/number}","issue_comment_url":"https://api.github.com/repos/kengz/SLM-Lab/issues/comments{/number}","contents_url":"https://api.github.com/repos/kengz/SLM-Lab/contents/{+path}","compare_url":"https://api.github.com/repos/kengz/SLM-Lab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kengz/SLM-Lab/merges","archive_url":"https://api.github.com/repos/kengz/SLM-Lab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kengz/SLM-Lab/downloads","issues_url":"https://api.github.com/repos/kengz/SLM-Lab/issues{/number}","pulls_url":"https://api.github.com/repos/kengz/SLM-Lab/pulls{/number}","milestones_url":"https://api.github.com/repos/kengz/SLM-Lab/milestones{/number}","notifications_url":"https://api.github.com/repos/kengz/SLM-Lab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kengz/SLM-Lab/labels{/name}","releases_url":"https://api.github.com/repos/kengz/SLM-Lab/releases{/id}","deployments_url":"https://api.github.com/repos/kengz/SLM-Lab/deployments","created_at":"2017-10-02T22:20:22Z","updated_at":"2018-11-26T18:53:26Z","pushed_at":"2018-11-28T17:38:49Z","git_url":"git://github.com/kengz/SLM-Lab.git","ssh_url":"git@github.com:kengz/SLM-Lab.git","clone_url":"https://github.com/kengz/SLM-Lab.git","svn_url":"https://github.com/kengz/SLM-Lab","homepage":"https://kengz.gitbooks.io/slm-lab/content/","size":2142,"stargazers_count":407,"watchers_count":407,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":60,"open_issues":1,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kengz/SLM-Lab/pulls/239"},"html":{"href":"https://github.com/kengz/SLM-Lab/pull/239"},"issue":{"href":"https://api.github.com/repos/kengz/SLM-Lab/issues/239"},"comments":{"href":"https://api.github.com/repos/kengz/SLM-Lab/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/kengz/SLM-Lab/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/kengz/SLM-Lab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kengz/SLM-Lab/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/kengz/SLM-Lab/statuses/777fbf8c2876c9c144cf0737bcf2090031b3ef16"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kengz","id":8209263,"node_id":"MDQ6VXNlcjgyMDkyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/8209263?v=4","gravatar_id":"","url":"https://api.github.com/users/kengz","html_url":"https://github.com/kengz","followers_url":"https://api.github.com/users/kengz/followers","following_url":"https://api.github.com/users/kengz/following{/other_user}","gists_url":"https://api.github.com/users/kengz/gists{/gist_id}","starred_url":"https://api.github.com/users/kengz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kengz/subscriptions","organizations_url":"https://api.github.com/users/kengz/orgs","repos_url":"https://api.github.com/users/kengz/repos","events_url":"https://api.github.com/users/kengz/events{/privacy}","received_events_url":"https://api.github.com/users/kengz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":78,"additions":4089,"deletions":2786,"changed_files":52}}
{"actor":{"display_login":"kengz"}}