{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6247","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6247/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6247/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6247/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6247","id":250688100,"node_id":"MDExOlB1bGxSZXF1ZXN0MTM2MDY5NTg4","number":6247,"title":"Windows calc engine integration","user":{"login":"vidanovic","id":5805892,"node_id":"MDQ6VXNlcjU4MDU4OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5805892?v=4","gravatar_id":"","url":"https://api.github.com/users/vidanovic","html_url":"https://github.com/vidanovic","followers_url":"https://api.github.com/users/vidanovic/followers","following_url":"https://api.github.com/users/vidanovic/following{/other_user}","gists_url":"https://api.github.com/users/vidanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/vidanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidanovic/subscriptions","organizations_url":"https://api.github.com/users/vidanovic/orgs","repos_url":"https://api.github.com/users/vidanovic/repos","events_url":"https://api.github.com/users/vidanovic/events{/privacy}","received_events_url":"https://api.github.com/users/vidanovic/received_events","type":"User","site_admin":false},"labels":[{"id":429517840,"node_id":"MDU6TGFiZWw0Mjk1MTc4NDA=","url":"https://api.github.com/repos/NREL/EnergyPlus/labels/IDDChange","name":"IDDChange","color":"006b75","default":false},{"id":179739851,"node_id":"MDU6TGFiZWwxNzk3Mzk4NTE=","url":"https://api.github.com/repos/NREL/EnergyPlus/labels/NewFeature","name":"NewFeature","color":"db5700","default":false},{"id":244051192,"node_id":"MDU6TGFiZWwyNDQwNTExOTI=","url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Refactoring","name":"Refactoring","color":"0000FF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/8","html_url":"https://github.com/NREL/EnergyPlus/milestone/8","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/8/labels","id":3115951,"node_id":"MDk6TWlsZXN0b25lMzExNTk1MQ==","number":8,"title":"EnergyPlus Next","description":"","creator":{"login":"Myoldmopar","id":849824,"node_id":"MDQ6VXNlcjg0OTgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":4,"state":"open","created_at":"2018-02-14T10:31:29Z","updated_at":"2018-05-30T17:50:05Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"comments":56,"created_at":"2017-08-16T16:34:45Z","updated_at":"2018-05-31T20:59:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6247","html_url":"https://github.com/NREL/EnergyPlus/pull/6247","diff_url":"https://github.com/NREL/EnergyPlus/pull/6247.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6247.patch"},"body":"Pull request overview\r\n---------------------\r\nPlease change this line to a description of the pull request, with useful supporting information including whether it is a new feature, or fixes a defect, a cross reference to any defects addressed in this PR, the type of changes to be made, and whether diffs are expected/justified based on this change.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: Most of shading devices in Winkelmann part of code are incorrectly calculated (for one that are tested at least). WindowsCalc-Engine uses generic approach for all shading devices.\r\n   - Refactoring: Window routines (heat transfer and optical properties) are now hosted in separate GitHub (https://github.com/LBNL-ETA/Windows-CalcEngine). This is where changes should be done and tests updated. Refactoring was done for Winkelmann and BSDF window types.\r\n   - NewFeature: No new functionality features are posted in this version.\r\n   - Performance: Code is totally refactored and because of that performance should be different.\r\n   - DoNoPublish: /\r\n   - IDF changes are introduced to differ between use of interior (current) and exterior (WindowsCalc-Engine) engines.\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/393678231","html_url":"https://github.com/NREL/EnergyPlus/pull/6247#issuecomment-393678231","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6247","id":393678231,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzY3ODIzMQ==","user":{"login":"jasondegraw","id":4623433,"node_id":"MDQ6VXNlcjQ2MjM0MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/4623433?v=4","gravatar_id":"","url":"https://api.github.com/users/jasondegraw","html_url":"https://github.com/jasondegraw","followers_url":"https://api.github.com/users/jasondegraw/followers","following_url":"https://api.github.com/users/jasondegraw/following{/other_user}","gists_url":"https://api.github.com/users/jasondegraw/gists{/gist_id}","starred_url":"https://api.github.com/users/jasondegraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasondegraw/subscriptions","organizations_url":"https://api.github.com/users/jasondegraw/orgs","repos_url":"https://api.github.com/users/jasondegraw/repos","events_url":"https://api.github.com/users/jasondegraw/events{/privacy}","received_events_url":"https://api.github.com/users/jasondegraw/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T20:59:35Z","updated_at":"2018-05-31T20:59:35Z","author_association":"MEMBER","body":"@Myoldmopar @vidanovic I would have commented sooner, but I've been seeing intermittent angry unicorns since the iteration call. I'm going to second @mbadams5 on the use of shared pointers, and I'm not a fan of the use of exceptions in the main code. I thought the consensus was to keep the main code exception free."}}
{"actor":{"display_login":"jasondegraw"}}