{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/223595373","pull_request_review_id":162758690,"id":223595373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzU5NTM3Mw==","diff_hunk":"@@ -118,6 +118,9 @@ type beatConfig struct {\n \tPipeline   pipeline.Config `config:\",inline\"`\n \tMonitoring *common.Config  `config:\"xpack.monitoring\"`\n \n+\t// central managmenet settings\n+\tManagement *common.Config `config:\"xpack.management\"`","path":"libbeat/cmd/instance/beat.go","position":5,"original_position":5,"commit_id":"7c44949e9ff14ac7629534fd2fc6a923b61d21f2","original_commit_id":"7c44949e9ff14ac7629534fd2fc6a923b61d21f2","user":{"login":"ruflin","id":244900,"node_id":"MDQ6VXNlcjI0NDkwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/244900?v=4","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"Should we really prefix the `management` setting by `xpack`. What about just making it `management`? I think long term it should also disappear from monitoring.","created_at":"2018-10-09T08:03:21Z","updated_at":"2018-10-09T08:11:04Z","html_url":"https://github.com/elastic/beats/pull/8597#discussion_r223595373","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/8597","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/223595373"},"html":{"href":"https://github.com/elastic/beats/pull/8597#discussion_r223595373"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/8597"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/8597","id":221253971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjUzOTcx","html_url":"https://github.com/elastic/beats/pull/8597","diff_url":"https://github.com/elastic/beats/pull/8597.diff","patch_url":"https://github.com/elastic/beats/pull/8597.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/8597","number":8597,"state":"open","locked":false,"title":"Move central management settings to beat config file","user":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"body":"This change moves central management settings to the beat config, instead of having its own internal file.\r\n\r\nIn order to make this work well, `enroll` command will override existing settings to:\r\n\r\n1. Put its own settings in the file.\r\n2. Remove existing settings for centrally managed configurations, as they won't be allowed any longer\r\n\r\nBefore overriding the existing config, the `enroll` command will ask for confirmation and do a backup of it in all cases.","created_at":"2018-10-08T21:56:37Z","updated_at":"2018-10-09T08:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1df8c7f90421fa2d85f45f60d785bccdfbc0d198","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":216798909,"node_id":"MDU6TGFiZWwyMTY3OTg5MDk=","url":"https://api.github.com/repos/elastic/beats/labels/in%20progress","name":"in progress","color":"207de5","default":false},{"id":360592718,"node_id":"MDU6TGFiZWwzNjA1OTI3MTg=","url":"https://api.github.com/repos/elastic/beats/labels/needs_backport","name":"needs_backport","color":"1d76db","default":false},{"id":228068770,"node_id":"MDU6TGFiZWwyMjgwNjg3NzA=","url":"https://api.github.com/repos/elastic/beats/labels/review","name":"review","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/8597/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/8597/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/8597/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/7c44949e9ff14ac7629534fd2fc6a923b61d21f2","head":{"label":"exekias:enroll-settings-to-main","ref":"enroll-settings-to-main","sha":"7c44949e9ff14ac7629534fd2fc6a923b61d21f2","user":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"repo":{"id":84233728,"node_id":"MDEwOlJlcG9zaXRvcnk4NDIzMzcyOA==","name":"beats","full_name":"exekias/beats","private":false,"owner":{"login":"exekias","id":299804,"node_id":"MDQ6VXNlcjI5OTgwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/299804?v=4","gravatar_id":"","url":"https://api.github.com/users/exekias","html_url":"https://github.com/exekias","followers_url":"https://api.github.com/users/exekias/followers","following_url":"https://api.github.com/users/exekias/following{/other_user}","gists_url":"https://api.github.com/users/exekias/gists{/gist_id}","starred_url":"https://api.github.com/users/exekias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exekias/subscriptions","organizations_url":"https://api.github.com/users/exekias/orgs","repos_url":"https://api.github.com/users/exekias/repos","events_url":"https://api.github.com/users/exekias/events{/privacy}","received_events_url":"https://api.github.com/users/exekias/received_events","type":"User","site_admin":false},"html_url":"https://github.com/exekias/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/exekias/beats","forks_url":"https://api.github.com/repos/exekias/beats/forks","keys_url":"https://api.github.com/repos/exekias/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exekias/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exekias/beats/teams","hooks_url":"https://api.github.com/repos/exekias/beats/hooks","issue_events_url":"https://api.github.com/repos/exekias/beats/issues/events{/number}","events_url":"https://api.github.com/repos/exekias/beats/events","assignees_url":"https://api.github.com/repos/exekias/beats/assignees{/user}","branches_url":"https://api.github.com/repos/exekias/beats/branches{/branch}","tags_url":"https://api.github.com/repos/exekias/beats/tags","blobs_url":"https://api.github.com/repos/exekias/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exekias/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exekias/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/exekias/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exekias/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/exekias/beats/languages","stargazers_url":"https://api.github.com/repos/exekias/beats/stargazers","contributors_url":"https://api.github.com/repos/exekias/beats/contributors","subscribers_url":"https://api.github.com/repos/exekias/beats/subscribers","subscription_url":"https://api.github.com/repos/exekias/beats/subscription","commits_url":"https://api.github.com/repos/exekias/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/exekias/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/exekias/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/exekias/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/exekias/beats/contents/{+path}","compare_url":"https://api.github.com/repos/exekias/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exekias/beats/merges","archive_url":"https://api.github.com/repos/exekias/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exekias/beats/downloads","issues_url":"https://api.github.com/repos/exekias/beats/issues{/number}","pulls_url":"https://api.github.com/repos/exekias/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/exekias/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/exekias/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exekias/beats/labels{/name}","releases_url":"https://api.github.com/repos/exekias/beats/releases{/id}","deployments_url":"https://api.github.com/repos/exekias/beats/deployments","created_at":"2017-03-07T18:42:42Z","updated_at":"2017-03-07T18:42:47Z","pushed_at":"2018-10-08T21:16:17Z","git_url":"git://github.com/exekias/beats.git","ssh_url":"git@github.com:exekias/beats.git","clone_url":"https://github.com/exekias/beats.git","svn_url":"https://github.com/exekias/beats","homepage":"https://www.elastic.co/products/beats","size":92470,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"cff3e40cfedb9521d7249caaa569668de203dc59","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU1NDczOQ==","name":"beats","full_name":"elastic/beats","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2018-10-09T07:52:30Z","pushed_at":"2018-10-08T21:56:37Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":100250,"stargazers_count":6228,"watchers_count":6228,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1942,"mirror_url":null,"archived":false,"open_issues_count":936,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1942,"open_issues":936,"watchers":6228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/8597"},"html":{"href":"https://github.com/elastic/beats/pull/8597"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/8597"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/8597/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/8597/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/8597/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/7c44949e9ff14ac7629534fd2fc6a923b61d21f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ruflin"}}