{"action":"created","issue":{"url":"https://api.github.com/repos/ShipSoft/FairShip/issues/87","repository_url":"https://api.github.com/repos/ShipSoft/FairShip","labels_url":"https://api.github.com/repos/ShipSoft/FairShip/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/ShipSoft/FairShip/issues/87/comments","events_url":"https://api.github.com/repos/ShipSoft/FairShip/issues/87/events","html_url":"https://github.com/ShipSoft/FairShip/pull/87","id":315864232,"number":87,"title":"Latest Muon flux files","user":{"login":"evanherwijnen","id":7581486,"avatar_url":"https://avatars0.githubusercontent.com/u/7581486?v=4","gravatar_id":"","url":"https://api.github.com/users/evanherwijnen","html_url":"https://github.com/evanherwijnen","followers_url":"https://api.github.com/users/evanherwijnen/followers","following_url":"https://api.github.com/users/evanherwijnen/following{/other_user}","gists_url":"https://api.github.com/users/evanherwijnen/gists{/gist_id}","starred_url":"https://api.github.com/users/evanherwijnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanherwijnen/subscriptions","organizations_url":"https://api.github.com/users/evanherwijnen/orgs","repos_url":"https://api.github.com/users/evanherwijnen/repos","events_url":"https://api.github.com/users/evanherwijnen/events{/privacy}","received_events_url":"https://api.github.com/users/evanherwijnen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-04-19T12:54:14Z","updated_at":"2018-04-24T06:42:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ShipSoft/FairShip/pulls/87","html_url":"https://github.com/ShipSoft/FairShip/pull/87","diff_url":"https://github.com/ShipSoft/FairShip/pull/87.diff","patch_url":"https://github.com/ShipSoft/FairShip/pull/87.patch"},"body":"Including Goilath field map, new target and run_MufluxfixedTarget, updated geometry, drifttube scintillators"},"comment":{"url":"https://api.github.com/repos/ShipSoft/FairShip/issues/comments/383821124","html_url":"https://github.com/ShipSoft/FairShip/pull/87#issuecomment-383821124","issue_url":"https://api.github.com/repos/ShipSoft/FairShip/issues/87","id":383821124,"user":{"login":"ThomasRuf","id":7068505,"avatar_url":"https://avatars0.githubusercontent.com/u/7068505?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasRuf","html_url":"https://github.com/ThomasRuf","followers_url":"https://api.github.com/users/ThomasRuf/followers","following_url":"https://api.github.com/users/ThomasRuf/following{/other_user}","gists_url":"https://api.github.com/users/ThomasRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasRuf/subscriptions","organizations_url":"https://api.github.com/users/ThomasRuf/orgs","repos_url":"https://api.github.com/users/ThomasRuf/repos","events_url":"https://api.github.com/users/ThomasRuf/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasRuf/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T06:42:55Z","updated_at":"2018-04-24T06:42:55Z","author_association":"CONTRIBUTOR","body":"Some more questions:\r\n- why do we need two field map files?  field/GoliathFieldMap.root  files/GoliathFieldMap.root  \r\n\r\n- run_simScript:\r\n   can we remove print \"pID= \",pID ?\r\n  Estart and Eend are nowhere used as far as I can see. There is no explanation what they are, what units. \r\n\r\n- ShipTargetStation.cxx: still worried about the changes:\r\n   Double_t zPos =  -4.59; \r\n  //Double_t zPos =  fTargetZ - fTargetLength/2.; \r\n  top->AddNode(tTarget, 1, new TGeoTranslation(0, 0,fTargetZ - fTargetLength/2. + totLength+2.5)); \r\nDon't understand these numbers, 4.59, 2.5. Why old zPos now commented?\r\n\r\nMy worry: this might contradict the value for start of target encoded in geometry_config.py, and the while muon background simulation will break down.\r\n\r\n"}}
{"actor":{"display_login":"ThomasRuf"}}