{"action":"created","comment":{"url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments/202942266","pull_request_review_id":137731837,"id":202942266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjk0MjI2Ng==","diff_hunk":"@@ -234,75 +106,48 @@ class Signal(object):\n             _multiplex ('Multiplexor' or Number of Multiplex)\n     \"\"\"\n \n-    def __init__(self, name, **kwargs):\n-        self.mux_val = None\n-        self.is_multiplexer = False\n+    name = attr.ib(default = \"\")\n+#    float_factory = attr.ib(default=defaultFloatFactory)","path":"canmatrix/canmatrix.py","position":null,"original_position":194,"commit_id":"1a78b59033407b66e25997f01fe966d59ac0b788","original_commit_id":"d39007573d11ab5739371fd1ed2736ce90ae01df","user":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"body":"\r\nWhat about making decimal to the default for all format-modules also.\r\nOne could add an option to change the behaviour. \r\nBut are there any Problems expected while using decimal instead of float?\r\nWouldn't it be the best to habe decimal everywhere in canmatrix?\r\n\r\nWhat do you think?","created_at":"2018-07-17T08:53:17Z","updated_at":"2018-07-17T08:53:17Z","html_url":"https://github.com/ebroecker/canmatrix/pull/163#discussion_r202942266","pull_request_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments/202942266"},"html":{"href":"https://github.com/ebroecker/canmatrix/pull/163#discussion_r202942266"},"pull_request":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163"}},"in_reply_to_id":202674652},"pull_request":{"url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163","id":198702184,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzAyMTg0","html_url":"https://github.com/ebroecker/canmatrix/pull/163","diff_url":"https://github.com/ebroecker/canmatrix/pull/163.diff","patch_url":"https://github.com/ebroecker/canmatrix/pull/163.patch","issue_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/163","number":163,"state":"open","locked":false,"title":"Attr PR - for discussing the changes","user":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"body":"This PR is only for discussing the changes.","created_at":"2018-07-02T14:44:58Z","updated_at":"2018-07-17T08:53:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c33683d6994bf3f23152187baeebbaad15ce00b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163/commits","review_comments_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163/comments","review_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/163/comments","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/1a78b59033407b66e25997f01fe966d59ac0b788","head":{"label":"ebroecker:attr","ref":"attr","sha":"1a78b59033407b66e25997f01fe966d59ac0b788","user":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"repo":{"id":9304497,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NDk3","name":"canmatrix","full_name":"ebroecker/canmatrix","owner":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebroecker/canmatrix","description":"Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...","fork":false,"url":"https://api.github.com/repos/ebroecker/canmatrix","forks_url":"https://api.github.com/repos/ebroecker/canmatrix/forks","keys_url":"https://api.github.com/repos/ebroecker/canmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebroecker/canmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebroecker/canmatrix/teams","hooks_url":"https://api.github.com/repos/ebroecker/canmatrix/hooks","issue_events_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/ebroecker/canmatrix/events","assignees_url":"https://api.github.com/repos/ebroecker/canmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/ebroecker/canmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/ebroecker/canmatrix/tags","blobs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebroecker/canmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebroecker/canmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/ebroecker/canmatrix/languages","stargazers_url":"https://api.github.com/repos/ebroecker/canmatrix/stargazers","contributors_url":"https://api.github.com/repos/ebroecker/canmatrix/contributors","subscribers_url":"https://api.github.com/repos/ebroecker/canmatrix/subscribers","subscription_url":"https://api.github.com/repos/ebroecker/canmatrix/subscription","commits_url":"https://api.github.com/repos/ebroecker/canmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebroecker/canmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebroecker/canmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/ebroecker/canmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebroecker/canmatrix/merges","archive_url":"https://api.github.com/repos/ebroecker/canmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebroecker/canmatrix/downloads","issues_url":"https://api.github.com/repos/ebroecker/canmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/ebroecker/canmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/ebroecker/canmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebroecker/canmatrix/labels{/name}","releases_url":"https://api.github.com/repos/ebroecker/canmatrix/releases{/id}","deployments_url":"https://api.github.com/repos/ebroecker/canmatrix/deployments","created_at":"2013-04-08T19:08:14Z","updated_at":"2018-07-17T06:22:23Z","pushed_at":"2018-07-16T20:46:38Z","git_url":"git://github.com/ebroecker/canmatrix.git","ssh_url":"git@github.com:ebroecker/canmatrix.git","clone_url":"https://github.com/ebroecker/canmatrix.git","svn_url":"https://github.com/ebroecker/canmatrix","homepage":"","size":3237,"stargazers_count":193,"watchers_count":193,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":106,"open_issues":34,"watchers":193,"default_branch":"development"}},"base":{"label":"ebroecker:development","ref":"development","sha":"6109292e9e821c7e53bbd3bca6d8208079b1613a","user":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"repo":{"id":9304497,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NDk3","name":"canmatrix","full_name":"ebroecker/canmatrix","owner":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebroecker/canmatrix","description":"Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...","fork":false,"url":"https://api.github.com/repos/ebroecker/canmatrix","forks_url":"https://api.github.com/repos/ebroecker/canmatrix/forks","keys_url":"https://api.github.com/repos/ebroecker/canmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebroecker/canmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebroecker/canmatrix/teams","hooks_url":"https://api.github.com/repos/ebroecker/canmatrix/hooks","issue_events_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/ebroecker/canmatrix/events","assignees_url":"https://api.github.com/repos/ebroecker/canmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/ebroecker/canmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/ebroecker/canmatrix/tags","blobs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebroecker/canmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebroecker/canmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/ebroecker/canmatrix/languages","stargazers_url":"https://api.github.com/repos/ebroecker/canmatrix/stargazers","contributors_url":"https://api.github.com/repos/ebroecker/canmatrix/contributors","subscribers_url":"https://api.github.com/repos/ebroecker/canmatrix/subscribers","subscription_url":"https://api.github.com/repos/ebroecker/canmatrix/subscription","commits_url":"https://api.github.com/repos/ebroecker/canmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebroecker/canmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebroecker/canmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/ebroecker/canmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebroecker/canmatrix/merges","archive_url":"https://api.github.com/repos/ebroecker/canmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebroecker/canmatrix/downloads","issues_url":"https://api.github.com/repos/ebroecker/canmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/ebroecker/canmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/ebroecker/canmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebroecker/canmatrix/labels{/name}","releases_url":"https://api.github.com/repos/ebroecker/canmatrix/releases{/id}","deployments_url":"https://api.github.com/repos/ebroecker/canmatrix/deployments","created_at":"2013-04-08T19:08:14Z","updated_at":"2018-07-17T06:22:23Z","pushed_at":"2018-07-16T20:46:38Z","git_url":"git://github.com/ebroecker/canmatrix.git","ssh_url":"git@github.com:ebroecker/canmatrix.git","clone_url":"https://github.com/ebroecker/canmatrix.git","svn_url":"https://github.com/ebroecker/canmatrix","homepage":"","size":3237,"stargazers_count":193,"watchers_count":193,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":106,"open_issues":34,"watchers":193,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163"},"html":{"href":"https://github.com/ebroecker/canmatrix/pull/163"},"issue":{"href":"https://api.github.com/repos/ebroecker/canmatrix/issues/163"},"comments":{"href":"https://api.github.com/repos/ebroecker/canmatrix/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/ebroecker/canmatrix/statuses/1a78b59033407b66e25997f01fe966d59ac0b788"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ebroecker"}}