{"action":"created","comment":{"url":"https://api.github.com/repos/gwastro/pycbc/pulls/comments/182529630","pull_request_review_id":113343289,"id":182529630,"diff_hunk":"@@ -367,10 +370,11 @@ def from_cli(opt, dyn_range_fac=1, precision='single',\n         else:\n             logging.info(\"Making colored noise\")\n             from pycbc.noise.reproduceable import colored_noise\n+            lowfreq = opt.strain_high_pass if opt.strain_high_pass else 10.","path":"pycbc/strain.py","position":14,"original_position":14,"commit_id":"374253dd87a10a648964c15f85251fbfa12e1f8e","original_commit_id":"374253dd87a10a648964c15f85251fbfa12e1f8e","user":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars1.githubusercontent.com/u/2206534?v=4","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"body":"@titodalcanton @micamu Maybe we should change this now to be the low frequency cutoff? Does that feel more consistent? The point is we need some frequency below (although at might be ok) the flow. Either we need a new explicit option, or we use something they should already be setting which is consistent.","created_at":"2018-04-18T18:40:05Z","updated_at":"2018-04-18T18:40:05Z","html_url":"https://github.com/gwastro/pycbc/pull/2140#discussion_r182529630","pull_request_url":"https://api.github.com/repos/gwastro/pycbc/pulls/2140","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gwastro/pycbc/pulls/comments/182529630"},"html":{"href":"https://github.com/gwastro/pycbc/pull/2140#discussion_r182529630"},"pull_request":{"href":"https://api.github.com/repos/gwastro/pycbc/pulls/2140"}}},"pull_request":{"url":"https://api.github.com/repos/gwastro/pycbc/pulls/2140","id":182562550,"html_url":"https://github.com/gwastro/pycbc/pull/2140","diff_url":"https://github.com/gwastro/pycbc/pull/2140.diff","patch_url":"https://github.com/gwastro/pycbc/pull/2140.patch","issue_url":"https://api.github.com/repos/gwastro/pycbc/issues/2140","number":2140,"state":"open","locked":false,"title":"Make understandable which options are missing for fake strain","user":{"login":"micamu","id":13962481,"avatar_url":"https://avatars1.githubusercontent.com/u/13962481?v=4","gravatar_id":"","url":"https://api.github.com/users/micamu","html_url":"https://github.com/micamu","followers_url":"https://api.github.com/users/micamu/followers","following_url":"https://api.github.com/users/micamu/following{/other_user}","gists_url":"https://api.github.com/users/micamu/gists{/gist_id}","starred_url":"https://api.github.com/users/micamu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micamu/subscriptions","organizations_url":"https://api.github.com/users/micamu/orgs","repos_url":"https://api.github.com/users/micamu/repos","events_url":"https://api.github.com/users/micamu/events{/privacy}","received_events_url":"https://api.github.com/users/micamu/received_events","type":"User","site_admin":false},"body":"Currently, pycbc_condition_strain is a bit cryptic for new users trying to generate a fake strain:\r\n\r\n* if the user chooses a fake-strain option but does not provide a low-frequency-cutoff, the code fails at generating the PSD complaining about not being able to divide a 'NoneType' and a 'float'. In this PR I have added a sanity check in the strain module, such that it will raise a ValueError asking for the low-frequency-cutoff if a fake-strain option has been selected without the frequency option. This will make it easier to understand why the code failed.\r\n\r\n* if the user chooses a fake-strain option different from zero noise, the strain-high-pass option is required to be passed as low frequency cutoff for the colored_noise function. Again it raises the same error as in the previous case if no strain-high-pass is provided, making it difficult to understand what is missing. However, the colored_noise function has a default low_frequency_cutoff=10 (or 1 depending on the acceptance of PR #2139), so that in principle the user wouldn't necessarily need to provide a strain-high-pass. Furthermore, as it currently is, the default in colored_noise is overwritten by 'None' if the user does not provide the strain-high-pass option, hence the error. In this PR I made the low_frequency_cutoff for the colored_noise function to be either the opt.strain_high_pass given by the user or the default 10. Hz if not provided by the user. Therefore, it will not fail if the user does not provide strain-high-pass, but it also gives the option to select a different strain-high-pass than the default.","created_at":"2018-04-18T18:19:30Z","updated_at":"2018-04-18T18:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7c7db4d6b4caa41853f228d99ca7d595eb942d2","assignee":{"login":"titodalcanton","id":11317236,"avatar_url":"https://avatars1.githubusercontent.com/u/11317236?v=4","gravatar_id":"","url":"https://api.github.com/users/titodalcanton","html_url":"https://github.com/titodalcanton","followers_url":"https://api.github.com/users/titodalcanton/followers","following_url":"https://api.github.com/users/titodalcanton/following{/other_user}","gists_url":"https://api.github.com/users/titodalcanton/gists{/gist_id}","starred_url":"https://api.github.com/users/titodalcanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titodalcanton/subscriptions","organizations_url":"https://api.github.com/users/titodalcanton/orgs","repos_url":"https://api.github.com/users/titodalcanton/repos","events_url":"https://api.github.com/users/titodalcanton/events{/privacy}","received_events_url":"https://api.github.com/users/titodalcanton/received_events","type":"User","site_admin":false},"assignees":[{"login":"titodalcanton","id":11317236,"avatar_url":"https://avatars1.githubusercontent.com/u/11317236?v=4","gravatar_id":"","url":"https://api.github.com/users/titodalcanton","html_url":"https://github.com/titodalcanton","followers_url":"https://api.github.com/users/titodalcanton/followers","following_url":"https://api.github.com/users/titodalcanton/following{/other_user}","gists_url":"https://api.github.com/users/titodalcanton/gists{/gist_id}","starred_url":"https://api.github.com/users/titodalcanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titodalcanton/subscriptions","organizations_url":"https://api.github.com/users/titodalcanton/orgs","repos_url":"https://api.github.com/users/titodalcanton/repos","events_url":"https://api.github.com/users/titodalcanton/events{/privacy}","received_events_url":"https://api.github.com/users/titodalcanton/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cdcapano","id":8258446,"avatar_url":"https://avatars0.githubusercontent.com/u/8258446?v=4","gravatar_id":"","url":"https://api.github.com/users/cdcapano","html_url":"https://github.com/cdcapano","followers_url":"https://api.github.com/users/cdcapano/followers","following_url":"https://api.github.com/users/cdcapano/following{/other_user}","gists_url":"https://api.github.com/users/cdcapano/gists{/gist_id}","starred_url":"https://api.github.com/users/cdcapano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdcapano/subscriptions","organizations_url":"https://api.github.com/users/cdcapano/orgs","repos_url":"https://api.github.com/users/cdcapano/repos","events_url":"https://api.github.com/users/cdcapano/events{/privacy}","received_events_url":"https://api.github.com/users/cdcapano/received_events","type":"User","site_admin":false},{"login":"titodalcanton","id":11317236,"avatar_url":"https://avatars1.githubusercontent.com/u/11317236?v=4","gravatar_id":"","url":"https://api.github.com/users/titodalcanton","html_url":"https://github.com/titodalcanton","followers_url":"https://api.github.com/users/titodalcanton/followers","following_url":"https://api.github.com/users/titodalcanton/following{/other_user}","gists_url":"https://api.github.com/users/titodalcanton/gists{/gist_id}","starred_url":"https://api.github.com/users/titodalcanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titodalcanton/subscriptions","organizations_url":"https://api.github.com/users/titodalcanton/orgs","repos_url":"https://api.github.com/users/titodalcanton/repos","events_url":"https://api.github.com/users/titodalcanton/events{/privacy}","received_events_url":"https://api.github.com/users/titodalcanton/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gwastro/pycbc/pulls/2140/commits","review_comments_url":"https://api.github.com/repos/gwastro/pycbc/pulls/2140/comments","review_comment_url":"https://api.github.com/repos/gwastro/pycbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gwastro/pycbc/issues/2140/comments","statuses_url":"https://api.github.com/repos/gwastro/pycbc/statuses/374253dd87a10a648964c15f85251fbfa12e1f8e","head":{"label":"micamu:clarify_errors","ref":"clarify_errors","sha":"374253dd87a10a648964c15f85251fbfa12e1f8e","user":{"login":"micamu","id":13962481,"avatar_url":"https://avatars1.githubusercontent.com/u/13962481?v=4","gravatar_id":"","url":"https://api.github.com/users/micamu","html_url":"https://github.com/micamu","followers_url":"https://api.github.com/users/micamu/followers","following_url":"https://api.github.com/users/micamu/following{/other_user}","gists_url":"https://api.github.com/users/micamu/gists{/gist_id}","starred_url":"https://api.github.com/users/micamu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micamu/subscriptions","organizations_url":"https://api.github.com/users/micamu/orgs","repos_url":"https://api.github.com/users/micamu/repos","events_url":"https://api.github.com/users/micamu/events{/privacy}","received_events_url":"https://api.github.com/users/micamu/received_events","type":"User","site_admin":false},"repo":{"id":42664154,"name":"pycbc","full_name":"micamu/pycbc","owner":{"login":"micamu","id":13962481,"avatar_url":"https://avatars1.githubusercontent.com/u/13962481?v=4","gravatar_id":"","url":"https://api.github.com/users/micamu","html_url":"https://github.com/micamu","followers_url":"https://api.github.com/users/micamu/followers","following_url":"https://api.github.com/users/micamu/following{/other_user}","gists_url":"https://api.github.com/users/micamu/gists{/gist_id}","starred_url":"https://api.github.com/users/micamu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micamu/subscriptions","organizations_url":"https://api.github.com/users/micamu/orgs","repos_url":"https://api.github.com/users/micamu/repos","events_url":"https://api.github.com/users/micamu/events{/privacy}","received_events_url":"https://api.github.com/users/micamu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micamu/pycbc","description":"Python CBC Tools","fork":true,"url":"https://api.github.com/repos/micamu/pycbc","forks_url":"https://api.github.com/repos/micamu/pycbc/forks","keys_url":"https://api.github.com/repos/micamu/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micamu/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micamu/pycbc/teams","hooks_url":"https://api.github.com/repos/micamu/pycbc/hooks","issue_events_url":"https://api.github.com/repos/micamu/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/micamu/pycbc/events","assignees_url":"https://api.github.com/repos/micamu/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/micamu/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/micamu/pycbc/tags","blobs_url":"https://api.github.com/repos/micamu/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micamu/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micamu/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/micamu/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micamu/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/micamu/pycbc/languages","stargazers_url":"https://api.github.com/repos/micamu/pycbc/stargazers","contributors_url":"https://api.github.com/repos/micamu/pycbc/contributors","subscribers_url":"https://api.github.com/repos/micamu/pycbc/subscribers","subscription_url":"https://api.github.com/repos/micamu/pycbc/subscription","commits_url":"https://api.github.com/repos/micamu/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/micamu/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/micamu/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/micamu/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/micamu/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/micamu/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micamu/pycbc/merges","archive_url":"https://api.github.com/repos/micamu/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micamu/pycbc/downloads","issues_url":"https://api.github.com/repos/micamu/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/micamu/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/micamu/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/micamu/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micamu/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/micamu/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/micamu/pycbc/deployments","created_at":"2015-09-17T15:22:49Z","updated_at":"2016-07-28T12:45:11Z","pushed_at":"2018-04-18T18:02:06Z","git_url":"git://github.com/micamu/pycbc.git","ssh_url":"git@github.com:micamu/pycbc.git","clone_url":"https://github.com/micamu/pycbc.git","svn_url":"https://github.com/micamu/pycbc","homepage":null,"size":54854,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gwastro:master","ref":"master","sha":"fe95ea9f38f4e587ace3f110cf95903a9b7af9f8","user":{"login":"gwastro","id":11262917,"avatar_url":"https://avatars3.githubusercontent.com/u/11262917?v=4","gravatar_id":"","url":"https://api.github.com/users/gwastro","html_url":"https://github.com/gwastro","followers_url":"https://api.github.com/users/gwastro/followers","following_url":"https://api.github.com/users/gwastro/following{/other_user}","gists_url":"https://api.github.com/users/gwastro/gists{/gist_id}","starred_url":"https://api.github.com/users/gwastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwastro/subscriptions","organizations_url":"https://api.github.com/users/gwastro/orgs","repos_url":"https://api.github.com/users/gwastro/repos","events_url":"https://api.github.com/users/gwastro/events{/privacy}","received_events_url":"https://api.github.com/users/gwastro/received_events","type":"Organization","site_admin":false},"repo":{"id":31596861,"name":"pycbc","full_name":"gwastro/pycbc","owner":{"login":"gwastro","id":11262917,"avatar_url":"https://avatars3.githubusercontent.com/u/11262917?v=4","gravatar_id":"","url":"https://api.github.com/users/gwastro","html_url":"https://github.com/gwastro","followers_url":"https://api.github.com/users/gwastro/followers","following_url":"https://api.github.com/users/gwastro/following{/other_user}","gists_url":"https://api.github.com/users/gwastro/gists{/gist_id}","starred_url":"https://api.github.com/users/gwastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwastro/subscriptions","organizations_url":"https://api.github.com/users/gwastro/orgs","repos_url":"https://api.github.com/users/gwastro/repos","events_url":"https://api.github.com/users/gwastro/events{/privacy}","received_events_url":"https://api.github.com/users/gwastro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gwastro/pycbc","description":"Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.  ","fork":false,"url":"https://api.github.com/repos/gwastro/pycbc","forks_url":"https://api.github.com/repos/gwastro/pycbc/forks","keys_url":"https://api.github.com/repos/gwastro/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwastro/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwastro/pycbc/teams","hooks_url":"https://api.github.com/repos/gwastro/pycbc/hooks","issue_events_url":"https://api.github.com/repos/gwastro/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/gwastro/pycbc/events","assignees_url":"https://api.github.com/repos/gwastro/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/gwastro/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/gwastro/pycbc/tags","blobs_url":"https://api.github.com/repos/gwastro/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwastro/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwastro/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwastro/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwastro/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/gwastro/pycbc/languages","stargazers_url":"https://api.github.com/repos/gwastro/pycbc/stargazers","contributors_url":"https://api.github.com/repos/gwastro/pycbc/contributors","subscribers_url":"https://api.github.com/repos/gwastro/pycbc/subscribers","subscription_url":"https://api.github.com/repos/gwastro/pycbc/subscription","commits_url":"https://api.github.com/repos/gwastro/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwastro/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwastro/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwastro/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwastro/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/gwastro/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwastro/pycbc/merges","archive_url":"https://api.github.com/repos/gwastro/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwastro/pycbc/downloads","issues_url":"https://api.github.com/repos/gwastro/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/gwastro/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/gwastro/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/gwastro/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwastro/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/gwastro/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/gwastro/pycbc/deployments","created_at":"2015-03-03T12:19:19Z","updated_at":"2018-04-18T14:52:53Z","pushed_at":"2018-04-18T18:19:30Z","git_url":"git://github.com/gwastro/pycbc.git","ssh_url":"git@github.com:gwastro/pycbc.git","clone_url":"https://github.com/gwastro/pycbc.git","svn_url":"https://github.com/gwastro/pycbc","homepage":"http://pycbc.org","size":163176,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":130,"open_issues":73,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gwastro/pycbc/pulls/2140"},"html":{"href":"https://github.com/gwastro/pycbc/pull/2140"},"issue":{"href":"https://api.github.com/repos/gwastro/pycbc/issues/2140"},"comments":{"href":"https://api.github.com/repos/gwastro/pycbc/issues/2140/comments"},"review_comments":{"href":"https://api.github.com/repos/gwastro/pycbc/pulls/2140/comments"},"review_comment":{"href":"https://api.github.com/repos/gwastro/pycbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gwastro/pycbc/pulls/2140/commits"},"statuses":{"href":"https://api.github.com/repos/gwastro/pycbc/statuses/374253dd87a10a648964c15f85251fbfa12e1f8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ahnitz"}}