{"action":"created","comment":{"url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/comments/236355450","pull_request_review_id":178324037,"id":236355450,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjM1NTQ1MA==","diff_hunk":"@@ -40,6 +40,11 @@ public function getViewHelperConfig()\n                     /** @var Rollout $rollout */\n                     $rollout = $serviceLocator->get('zf2_rollout');\n                     return new View\\Helper\\IsActive($rollout);\n+                },\n+                'rollout_description' => function (AbstractPluginManager $pluginManager) {\n+                    $serviceLocator = $pluginManager->getServiceLocator();\n+                    $rollout = $serviceLocator->get('zf2_rollout_config');\n+                    return new View\\Helper\\Description($rollout);","path":"src/Module.php","position":8,"original_position":8,"commit_id":"e6560c0db79845c20eee6daab4d0d70e3fd29555","original_commit_id":"e6560c0db79845c20eee6daab4d0d70e3fd29555","user":{"login":"tonivdv","id":1267658,"node_id":"MDQ6VXNlcjEyNjc2NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1267658?v=4","gravatar_id":"","url":"https://api.github.com/users/tonivdv","html_url":"https://github.com/tonivdv","followers_url":"https://api.github.com/users/tonivdv/followers","following_url":"https://api.github.com/users/tonivdv/following{/other_user}","gists_url":"https://api.github.com/users/tonivdv/gists{/gist_id}","starred_url":"https://api.github.com/users/tonivdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonivdv/subscriptions","organizations_url":"https://api.github.com/users/tonivdv/orgs","repos_url":"https://api.github.com/users/tonivdv/repos","events_url":"https://api.github.com/users/tonivdv/events{/privacy}","received_events_url":"https://api.github.com/users/tonivdv/received_events","type":"User","site_admin":false},"body":"That doesn't seem valid ... it will inject all configurations, while it should only inject the features ... Seeing the code of the Description helper this cannot work as it assumes to receive what is inside the 'features' key","created_at":"2018-11-26T17:38:09Z","updated_at":"2018-11-26T17:43:16Z","html_url":"https://github.com/adlogix/zf2-opensoft-rollout/pull/5#discussion_r236355450","pull_request_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/comments/236355450"},"html":{"href":"https://github.com/adlogix/zf2-opensoft-rollout/pull/5#discussion_r236355450"},"pull_request":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5","id":233541772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTQxNzcy","html_url":"https://github.com/adlogix/zf2-opensoft-rollout/pull/5","diff_url":"https://github.com/adlogix/zf2-opensoft-rollout/pull/5.diff","patch_url":"https://github.com/adlogix/zf2-opensoft-rollout/pull/5.patch","issue_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/5","number":5,"state":"open","locked":false,"title":"Support the description on the features.","user":{"login":"laudeco","id":3658458,"node_id":"MDQ6VXNlcjM2NTg0NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3658458?v=4","gravatar_id":"","url":"https://api.github.com/users/laudeco","html_url":"https://github.com/laudeco","followers_url":"https://api.github.com/users/laudeco/followers","following_url":"https://api.github.com/users/laudeco/following{/other_user}","gists_url":"https://api.github.com/users/laudeco/gists{/gist_id}","starred_url":"https://api.github.com/users/laudeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laudeco/subscriptions","organizations_url":"https://api.github.com/users/laudeco/orgs","repos_url":"https://api.github.com/users/laudeco/repos","events_url":"https://api.github.com/users/laudeco/events{/privacy}","received_events_url":"https://api.github.com/users/laudeco/received_events","type":"User","site_admin":false},"body":"Support the description of a feature in the configuration and provide an helper to be able to fetch the description of a feature (null if the description is not found).","created_at":"2018-11-26T12:32:41Z","updated_at":"2018-11-26T17:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee3710163580325e024ace91a6f7e2224c811686","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5/commits","review_comments_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5/comments","review_comment_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/5/comments","statuses_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/statuses/e6560c0db79845c20eee6daab4d0d70e3fd29555","head":{"label":"adlogix:feature/description","ref":"feature/description","sha":"e6560c0db79845c20eee6daab4d0d70e3fd29555","user":{"login":"adlogix","id":584264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NDI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/584264?v=4","gravatar_id":"","url":"https://api.github.com/users/adlogix","html_url":"https://github.com/adlogix","followers_url":"https://api.github.com/users/adlogix/followers","following_url":"https://api.github.com/users/adlogix/following{/other_user}","gists_url":"https://api.github.com/users/adlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/adlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlogix/subscriptions","organizations_url":"https://api.github.com/users/adlogix/orgs","repos_url":"https://api.github.com/users/adlogix/repos","events_url":"https://api.github.com/users/adlogix/events{/privacy}","received_events_url":"https://api.github.com/users/adlogix/received_events","type":"Organization","site_admin":false},"repo":{"id":68789654,"node_id":"MDEwOlJlcG9zaXRvcnk2ODc4OTY1NA==","name":"zf2-opensoft-rollout","full_name":"adlogix/zf2-opensoft-rollout","private":false,"owner":{"login":"adlogix","id":584264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NDI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/584264?v=4","gravatar_id":"","url":"https://api.github.com/users/adlogix","html_url":"https://github.com/adlogix","followers_url":"https://api.github.com/users/adlogix/followers","following_url":"https://api.github.com/users/adlogix/following{/other_user}","gists_url":"https://api.github.com/users/adlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/adlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlogix/subscriptions","organizations_url":"https://api.github.com/users/adlogix/orgs","repos_url":"https://api.github.com/users/adlogix/repos","events_url":"https://api.github.com/users/adlogix/events{/privacy}","received_events_url":"https://api.github.com/users/adlogix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adlogix/zf2-opensoft-rollout","description":"ZF2 module for the Opensoft Rollout library","fork":false,"url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout","forks_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/forks","keys_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/teams","hooks_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/hooks","issue_events_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/events{/number}","events_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/events","assignees_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/assignees{/user}","branches_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/branches{/branch}","tags_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/tags","blobs_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/refs{/sha}","trees_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/statuses/{sha}","languages_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/languages","stargazers_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/stargazers","contributors_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/contributors","subscribers_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/subscribers","subscription_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/subscription","commits_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/commits{/sha}","git_commits_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/commits{/sha}","comments_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/comments{/number}","issue_comment_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/comments{/number}","contents_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/contents/{+path}","compare_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/merges","archive_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/downloads","issues_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues{/number}","pulls_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls{/number}","milestones_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/milestones{/number}","notifications_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/labels{/name}","releases_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/releases{/id}","deployments_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/deployments","created_at":"2016-09-21T07:03:24Z","updated_at":"2018-07-03T14:33:01Z","pushed_at":"2018-11-26T14:15:55Z","git_url":"git://github.com/adlogix/zf2-opensoft-rollout.git","ssh_url":"git@github.com:adlogix/zf2-opensoft-rollout.git","clone_url":"https://github.com/adlogix/zf2-opensoft-rollout.git","svn_url":"https://github.com/adlogix/zf2-opensoft-rollout","homepage":null,"size":127,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"adlogix:master","ref":"master","sha":"39b2912b15825e5aad707b57830f3d4e21f318af","user":{"login":"adlogix","id":584264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NDI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/584264?v=4","gravatar_id":"","url":"https://api.github.com/users/adlogix","html_url":"https://github.com/adlogix","followers_url":"https://api.github.com/users/adlogix/followers","following_url":"https://api.github.com/users/adlogix/following{/other_user}","gists_url":"https://api.github.com/users/adlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/adlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlogix/subscriptions","organizations_url":"https://api.github.com/users/adlogix/orgs","repos_url":"https://api.github.com/users/adlogix/repos","events_url":"https://api.github.com/users/adlogix/events{/privacy}","received_events_url":"https://api.github.com/users/adlogix/received_events","type":"Organization","site_admin":false},"repo":{"id":68789654,"node_id":"MDEwOlJlcG9zaXRvcnk2ODc4OTY1NA==","name":"zf2-opensoft-rollout","full_name":"adlogix/zf2-opensoft-rollout","private":false,"owner":{"login":"adlogix","id":584264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NDI2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/584264?v=4","gravatar_id":"","url":"https://api.github.com/users/adlogix","html_url":"https://github.com/adlogix","followers_url":"https://api.github.com/users/adlogix/followers","following_url":"https://api.github.com/users/adlogix/following{/other_user}","gists_url":"https://api.github.com/users/adlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/adlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlogix/subscriptions","organizations_url":"https://api.github.com/users/adlogix/orgs","repos_url":"https://api.github.com/users/adlogix/repos","events_url":"https://api.github.com/users/adlogix/events{/privacy}","received_events_url":"https://api.github.com/users/adlogix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adlogix/zf2-opensoft-rollout","description":"ZF2 module for the Opensoft Rollout library","fork":false,"url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout","forks_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/forks","keys_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/teams","hooks_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/hooks","issue_events_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/events{/number}","events_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/events","assignees_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/assignees{/user}","branches_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/branches{/branch}","tags_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/tags","blobs_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/refs{/sha}","trees_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/statuses/{sha}","languages_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/languages","stargazers_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/stargazers","contributors_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/contributors","subscribers_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/subscribers","subscription_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/subscription","commits_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/commits{/sha}","git_commits_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/git/commits{/sha}","comments_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/comments{/number}","issue_comment_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/comments{/number}","contents_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/contents/{+path}","compare_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/merges","archive_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/downloads","issues_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues{/number}","pulls_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls{/number}","milestones_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/milestones{/number}","notifications_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/labels{/name}","releases_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/releases{/id}","deployments_url":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/deployments","created_at":"2016-09-21T07:03:24Z","updated_at":"2018-07-03T14:33:01Z","pushed_at":"2018-11-26T14:15:55Z","git_url":"git://github.com/adlogix/zf2-opensoft-rollout.git","ssh_url":"git@github.com:adlogix/zf2-opensoft-rollout.git","clone_url":"https://github.com/adlogix/zf2-opensoft-rollout.git","svn_url":"https://github.com/adlogix/zf2-opensoft-rollout","homepage":null,"size":127,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5"},"html":{"href":"https://github.com/adlogix/zf2-opensoft-rollout/pull/5"},"issue":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/5"},"comments":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/adlogix/zf2-opensoft-rollout/statuses/e6560c0db79845c20eee6daab4d0d70e3fd29555"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tonivdv"}}