{"action":"created","issue":{"url":"https://api.github.com/repos/openego/eTraGo/issues/133","repository_url":"https://api.github.com/repos/openego/eTraGo","labels_url":"https://api.github.com/repos/openego/eTraGo/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/openego/eTraGo/issues/133/comments","events_url":"https://api.github.com/repos/openego/eTraGo/issues/133/events","html_url":"https://github.com/openego/eTraGo/issues/133","id":299335418,"node_id":"MDU6SXNzdWUyOTkzMzU0MTg=","number":133,"title":"data_manipulation_sh(network) fails to find biggest indices","user":{"login":"jankaeh","id":33579567,"node_id":"MDQ6VXNlcjMzNTc5NTY3","avatar_url":"https://avatars1.githubusercontent.com/u/33579567?v=4","gravatar_id":"","url":"https://api.github.com/users/jankaeh","html_url":"https://github.com/jankaeh","followers_url":"https://api.github.com/users/jankaeh/followers","following_url":"https://api.github.com/users/jankaeh/following{/other_user}","gists_url":"https://api.github.com/users/jankaeh/gists{/gist_id}","starred_url":"https://api.github.com/users/jankaeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jankaeh/subscriptions","organizations_url":"https://api.github.com/users/jankaeh/orgs","repos_url":"https://api.github.com/users/jankaeh/repos","events_url":"https://api.github.com/users/jankaeh/events{/privacy}","received_events_url":"https://api.github.com/users/jankaeh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-22T12:30:43Z","updated_at":"2018-08-29T13:53:27Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I don't know if I'm the only one stumbling over this, but the code of the function data_manipulation_sh(network) at eTraGo/utilities.py does not find the biggest index correctly on my System.\r\n\r\nThis code does not find the maximum of the indices correctly if they are str, because '9' is bigger than '1', '9999' is bigger than '10000':\r\nnew_bus = str(int(network.buses.index.max())+1)\r\n\r\nI changed the lines 296-298 to:\r\n    new_bus = str(network.buses.index.astype(np.int64).max()+1)\r\n    new_trafo = str(network.transformers.index.astype(np.int64).max()+1)\r\n    new_line = str(network.lines.index.astype(np.int64).max()+1)\r\n\r\nMaybe it's more robust."},"comment":{"url":"https://api.github.com/repos/openego/eTraGo/issues/comments/416961920","html_url":"https://github.com/openego/eTraGo/issues/133#issuecomment-416961920","issue_url":"https://api.github.com/repos/openego/eTraGo/issues/133","id":416961920,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjk2MTkyMA==","user":{"login":"wolfbunke","id":14540685,"node_id":"MDQ6VXNlcjE0NTQwNjg1","avatar_url":"https://avatars2.githubusercontent.com/u/14540685?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfbunke","html_url":"https://github.com/wolfbunke","followers_url":"https://api.github.com/users/wolfbunke/followers","following_url":"https://api.github.com/users/wolfbunke/following{/other_user}","gists_url":"https://api.github.com/users/wolfbunke/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfbunke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfbunke/subscriptions","organizations_url":"https://api.github.com/users/wolfbunke/orgs","repos_url":"https://api.github.com/users/wolfbunke/repos","events_url":"https://api.github.com/users/wolfbunke/events{/privacy}","received_events_url":"https://api.github.com/users/wolfbunke/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T13:53:27Z","updated_at":"2018-08-29T13:53:27Z","author_association":"MEMBER","body":"@ulfmueller, is this relevant for the 0.7 Release?"}}
{"actor":{"display_login":"wolfbunke"}}