{"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/kobo/pulls/comments/228435454","pull_request_review_id":168707854,"id":228435454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODQzNTQ1NA==","diff_hunk":"@@ -227,7 +229,7 @@ def get_tasks_to_assign(request):\n def get_awaited_tasks(request, awaited_task_list):\n     task_list = []\n     for task in Task.objects.filter(awaited=True, parent__in=[ i[\"id\"] for i in awaited_task_list ]):#.order_by(\"-exclusive\", \"-awaited\", \"id\")[:50]:\n-        task_info = task.export()\n+        task_info = task.export(False)","path":"kobo/hub/xmlrpc/worker.py","position":23,"original_position":23,"commit_id":"4269626f21d5a95208d9f7c23d0fec8f3b527955","original_commit_id":"4269626f21d5a95208d9f7c23d0fec8f3b527955","user":{"login":"alexandrevicenzi","id":2637672,"node_id":"MDQ6VXNlcjI2Mzc2NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2637672?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrevicenzi","html_url":"https://github.com/alexandrevicenzi","followers_url":"https://api.github.com/users/alexandrevicenzi/followers","following_url":"https://api.github.com/users/alexandrevicenzi/following{/other_user}","gists_url":"https://api.github.com/users/alexandrevicenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrevicenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrevicenzi/subscriptions","organizations_url":"https://api.github.com/users/alexandrevicenzi/orgs","repos_url":"https://api.github.com/users/alexandrevicenzi/repos","events_url":"https://api.github.com/users/alexandrevicenzi/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrevicenzi/received_events","type":"User","site_admin":false},"body":"No problem, I can create an issue for that.","created_at":"2018-10-26T07:56:04Z","updated_at":"2018-10-26T07:56:04Z","html_url":"https://github.com/release-engineering/kobo/pull/63#discussion_r228435454","pull_request_url":"https://api.github.com/repos/release-engineering/kobo/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/comments/228435454"},"html":{"href":"https://github.com/release-engineering/kobo/pull/63#discussion_r228435454"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/63"}},"in_reply_to_id":228409425},"pull_request":{"url":"https://api.github.com/repos/release-engineering/kobo/pulls/63","id":223948526,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTQ4NTI2","html_url":"https://github.com/release-engineering/kobo/pull/63","diff_url":"https://github.com/release-engineering/kobo/pull/63.diff","patch_url":"https://github.com/release-engineering/kobo/pull/63.patch","issue_url":"https://api.github.com/repos/release-engineering/kobo/issues/63","number":63,"state":"open","locked":false,"title":"tests: Unit tests for TaskManager.","user":{"login":"alexandrevicenzi","id":2637672,"node_id":"MDQ6VXNlcjI2Mzc2NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2637672?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrevicenzi","html_url":"https://github.com/alexandrevicenzi","followers_url":"https://api.github.com/users/alexandrevicenzi/followers","following_url":"https://api.github.com/users/alexandrevicenzi/following{/other_user}","gists_url":"https://api.github.com/users/alexandrevicenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrevicenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrevicenzi/subscriptions","organizations_url":"https://api.github.com/users/alexandrevicenzi/orgs","repos_url":"https://api.github.com/users/alexandrevicenzi/repos","events_url":"https://api.github.com/users/alexandrevicenzi/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrevicenzi/received_events","type":"User","site_admin":false},"body":"@rohanpm as we discussed this is the unit test for TaskManager. There are more tests to be written, but I want feedback before writing more cases.\r\n\r\nFew things are mocked, but the test uses the worker as if it is a real RPC service, but without any RPC calls.\r\n\r\nWhile writing tests I noticed that `update_worker` wasn't updating the worker, so I fixed it.","created_at":"2018-10-18T13:05:24Z","updated_at":"2018-10-26T07:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed73e01906b4c087fa647f3a4a2765b2156505c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/kobo/pulls/63/commits","review_comments_url":"https://api.github.com/repos/release-engineering/kobo/pulls/63/comments","review_comment_url":"https://api.github.com/repos/release-engineering/kobo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/kobo/issues/63/comments","statuses_url":"https://api.github.com/repos/release-engineering/kobo/statuses/4269626f21d5a95208d9f7c23d0fec8f3b527955","head":{"label":"alexandrevicenzi:test-taskmanager","ref":"test-taskmanager","sha":"4269626f21d5a95208d9f7c23d0fec8f3b527955","user":{"login":"alexandrevicenzi","id":2637672,"node_id":"MDQ6VXNlcjI2Mzc2NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2637672?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrevicenzi","html_url":"https://github.com/alexandrevicenzi","followers_url":"https://api.github.com/users/alexandrevicenzi/followers","following_url":"https://api.github.com/users/alexandrevicenzi/following{/other_user}","gists_url":"https://api.github.com/users/alexandrevicenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrevicenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrevicenzi/subscriptions","organizations_url":"https://api.github.com/users/alexandrevicenzi/orgs","repos_url":"https://api.github.com/users/alexandrevicenzi/repos","events_url":"https://api.github.com/users/alexandrevicenzi/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrevicenzi/received_events","type":"User","site_admin":false},"repo":{"id":152251350,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyNTEzNTA=","name":"kobo","full_name":"alexandrevicenzi/kobo","private":false,"owner":{"login":"alexandrevicenzi","id":2637672,"node_id":"MDQ6VXNlcjI2Mzc2NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2637672?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrevicenzi","html_url":"https://github.com/alexandrevicenzi","followers_url":"https://api.github.com/users/alexandrevicenzi/followers","following_url":"https://api.github.com/users/alexandrevicenzi/following{/other_user}","gists_url":"https://api.github.com/users/alexandrevicenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrevicenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrevicenzi/subscriptions","organizations_url":"https://api.github.com/users/alexandrevicenzi/orgs","repos_url":"https://api.github.com/users/alexandrevicenzi/repos","events_url":"https://api.github.com/users/alexandrevicenzi/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrevicenzi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexandrevicenzi/kobo","description":"A pile of python modules used by Red Hat release engineering to build their tools.","fork":true,"url":"https://api.github.com/repos/alexandrevicenzi/kobo","forks_url":"https://api.github.com/repos/alexandrevicenzi/kobo/forks","keys_url":"https://api.github.com/repos/alexandrevicenzi/kobo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandrevicenzi/kobo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandrevicenzi/kobo/teams","hooks_url":"https://api.github.com/repos/alexandrevicenzi/kobo/hooks","issue_events_url":"https://api.github.com/repos/alexandrevicenzi/kobo/issues/events{/number}","events_url":"https://api.github.com/repos/alexandrevicenzi/kobo/events","assignees_url":"https://api.github.com/repos/alexandrevicenzi/kobo/assignees{/user}","branches_url":"https://api.github.com/repos/alexandrevicenzi/kobo/branches{/branch}","tags_url":"https://api.github.com/repos/alexandrevicenzi/kobo/tags","blobs_url":"https://api.github.com/repos/alexandrevicenzi/kobo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandrevicenzi/kobo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandrevicenzi/kobo/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandrevicenzi/kobo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandrevicenzi/kobo/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandrevicenzi/kobo/languages","stargazers_url":"https://api.github.com/repos/alexandrevicenzi/kobo/stargazers","contributors_url":"https://api.github.com/repos/alexandrevicenzi/kobo/contributors","subscribers_url":"https://api.github.com/repos/alexandrevicenzi/kobo/subscribers","subscription_url":"https://api.github.com/repos/alexandrevicenzi/kobo/subscription","commits_url":"https://api.github.com/repos/alexandrevicenzi/kobo/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandrevicenzi/kobo/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandrevicenzi/kobo/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandrevicenzi/kobo/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandrevicenzi/kobo/contents/{+path}","compare_url":"https://api.github.com/repos/alexandrevicenzi/kobo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandrevicenzi/kobo/merges","archive_url":"https://api.github.com/repos/alexandrevicenzi/kobo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandrevicenzi/kobo/downloads","issues_url":"https://api.github.com/repos/alexandrevicenzi/kobo/issues{/number}","pulls_url":"https://api.github.com/repos/alexandrevicenzi/kobo/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandrevicenzi/kobo/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandrevicenzi/kobo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandrevicenzi/kobo/labels{/name}","releases_url":"https://api.github.com/repos/alexandrevicenzi/kobo/releases{/id}","deployments_url":"https://api.github.com/repos/alexandrevicenzi/kobo/deployments","created_at":"2018-10-09T12:57:52Z","updated_at":"2018-10-10T08:19:36Z","pushed_at":"2018-10-25T14:32:32Z","git_url":"git://github.com/alexandrevicenzi/kobo.git","ssh_url":"git@github.com:alexandrevicenzi/kobo.git","clone_url":"https://github.com/alexandrevicenzi/kobo.git","svn_url":"https://github.com/alexandrevicenzi/kobo","homepage":null,"size":527,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:master","ref":"master","sha":"aa2491a1417a0a3dcea02afa0798b7572287c522","user":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":52263225,"node_id":"MDEwOlJlcG9zaXRvcnk1MjI2MzIyNQ==","name":"kobo","full_name":"release-engineering/kobo","private":false,"owner":{"login":"release-engineering","id":9591189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTExODk=","avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/release-engineering/kobo","description":"A pile of python modules used by Red Hat release engineering to build their tools.","fork":false,"url":"https://api.github.com/repos/release-engineering/kobo","forks_url":"https://api.github.com/repos/release-engineering/kobo/forks","keys_url":"https://api.github.com/repos/release-engineering/kobo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/kobo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/kobo/teams","hooks_url":"https://api.github.com/repos/release-engineering/kobo/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/kobo/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/kobo/events","assignees_url":"https://api.github.com/repos/release-engineering/kobo/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/kobo/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/kobo/tags","blobs_url":"https://api.github.com/repos/release-engineering/kobo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/kobo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/kobo/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/kobo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/kobo/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/kobo/languages","stargazers_url":"https://api.github.com/repos/release-engineering/kobo/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/kobo/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/kobo/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/kobo/subscription","commits_url":"https://api.github.com/repos/release-engineering/kobo/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/kobo/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/kobo/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/kobo/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/kobo/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/kobo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/kobo/merges","archive_url":"https://api.github.com/repos/release-engineering/kobo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/kobo/downloads","issues_url":"https://api.github.com/repos/release-engineering/kobo/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/kobo/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/kobo/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/kobo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/kobo/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/kobo/releases{/id}","deployments_url":"https://api.github.com/repos/release-engineering/kobo/deployments","created_at":"2016-02-22T09:45:26Z","updated_at":"2018-10-26T05:39:30Z","pushed_at":"2018-10-26T05:39:28Z","git_url":"git://github.com/release-engineering/kobo.git","ssh_url":"git@github.com:release-engineering/kobo.git","clone_url":"https://github.com/release-engineering/kobo.git","svn_url":"https://github.com/release-engineering/kobo","homepage":null,"size":520,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/63"},"html":{"href":"https://github.com/release-engineering/kobo/pull/63"},"issue":{"href":"https://api.github.com/repos/release-engineering/kobo/issues/63"},"comments":{"href":"https://api.github.com/repos/release-engineering/kobo/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/kobo/statuses/4269626f21d5a95208d9f7c23d0fec8f3b527955"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexandrevicenzi"}}