{"action":"created","comment":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/237194066","pull_request_review_id":179433726,"id":237194066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE5NDA2Ng==","diff_hunk":"@@ -1,23 +1,19 @@\n-import {\n-  INodeProvider,\n-  NodeMessage,\n-  NodeMessageType,\n-  NodeQueryData,\n-  QueryType\n-} from \"@counterfactual/node-provider\";\n-\n import cuid from \"cuid\";\n \n import { AppInstance } from \"./app-instance\";\n+import {\n+  GetAppInstancesResult,\n+  INodeProvider,\n+  NodeErrorType,\n+  NodeEventName,\n+  NodeMessage,\n+  NodeMethodName,\n+  NodeMethodParams,\n+  NodeMethodResponse\n+} from \"./types\";\n \n-export enum CounterfactualEventType {\n-  INSTALL = \"cf_install\",\n-  PROPOSE_INSTALL = \"cf_proposeInstall\",\n-  REJECT_INSTALL = \"cf_rejectInstall\"\n-}\n-\n-export interface CounterfactualEvent {\n-  readonly eventType: CounterfactualEventType;\n+export interface CfEvent {","path":"packages/cf.js/src/provider.ts","position":22,"original_position":31,"commit_id":"b91245802bd57e4dfa8c504b3343a1bf6a5969b5","original_commit_id":"ca780036291e799ae9771959d86bef419d340990","user":{"login":"joelalejandro","id":118913,"node_id":"MDQ6VXNlcjExODkxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/118913?v=4","gravatar_id":"","url":"https://api.github.com/users/joelalejandro","html_url":"https://github.com/joelalejandro","followers_url":"https://api.github.com/users/joelalejandro/followers","following_url":"https://api.github.com/users/joelalejandro/following{/other_user}","gists_url":"https://api.github.com/users/joelalejandro/gists{/gist_id}","starred_url":"https://api.github.com/users/joelalejandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelalejandro/subscriptions","organizations_url":"https://api.github.com/users/joelalejandro/orgs","repos_url":"https://api.github.com/users/joelalejandro/repos","events_url":"https://api.github.com/users/joelalejandro/events{/privacy}","received_events_url":"https://api.github.com/users/joelalejandro/received_events","type":"User","site_admin":false},"body":"@mvanderh `DappEvent`? I mean, these are events triggered from within the iframe, right?","created_at":"2018-11-28T17:52:20Z","updated_at":"2018-11-28T17:52:20Z","html_url":"https://github.com/counterfactual/monorepo/pull/274#discussion_r237194066","pull_request_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/274","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments/237194066"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/274#discussion_r237194066"},"pull_request":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/274"}},"in_reply_to_id":237060880},"pull_request":{"url":"https://api.github.com/repos/counterfactual/monorepo/pulls/274","id":234066886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDY2ODg2","html_url":"https://github.com/counterfactual/monorepo/pull/274","diff_url":"https://github.com/counterfactual/monorepo/pull/274.diff","patch_url":"https://github.com/counterfactual/monorepo/pull/274.patch","issue_url":"https://api.github.com/repos/counterfactual/monorepo/issues/274","number":274,"state":"open","locked":false,"title":"[CFjs] Types for Node protocol methods: getAppInstances, proposeInstall","user":{"login":"mvanderh","id":8631205,"node_id":"MDQ6VXNlcjg2MzEyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8631205?v=4","gravatar_id":"","url":"https://api.github.com/users/mvanderh","html_url":"https://github.com/mvanderh","followers_url":"https://api.github.com/users/mvanderh/followers","following_url":"https://api.github.com/users/mvanderh/following{/other_user}","gists_url":"https://api.github.com/users/mvanderh/gists{/gist_id}","starred_url":"https://api.github.com/users/mvanderh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvanderh/subscriptions","organizations_url":"https://api.github.com/users/mvanderh/orgs","repos_url":"https://api.github.com/users/mvanderh/repos","events_url":"https://api.github.com/users/mvanderh/events{/privacy}","received_events_url":"https://api.github.com/users/mvanderh/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n- Move all Node protocol types to CFjs node-protocol.ts\r\n- Enum types for all methods and events\r\n- All types around methods: getAppInstances, proposeInstall\r\n- Update Provider to work\r\n- Some types reorg\r\n","created_at":"2018-11-27T21:30:45Z","updated_at":"2018-11-28T17:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0109c2763c849705cd0d6c7263f410ddbc3663c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/274/commits","review_comments_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/274/comments","review_comment_url":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/issues/274/comments","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/b91245802bd57e4dfa8c504b3343a1bf6a5969b5","head":{"label":"counterfactual:mitch/node-protocol-message-types","ref":"mitch/node-protocol-message-types","sha":"b91245802bd57e4dfa8c504b3343a1bf6a5969b5","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2018-11-27T15:54:11Z","pushed_at":"2018-11-28T17:46:45Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":4645,"stargazers_count":121,"watchers_count":121,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":26,"watchers":121,"default_branch":"master"}},"base":{"label":"counterfactual:master","ref":"master","sha":"d9be8524a691c45b6aac1b5e1cf2ff81059203df","user":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"repo":{"id":143227440,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyMjc0NDA=","name":"monorepo","full_name":"counterfactual/monorepo","private":false,"owner":{"login":"counterfactual","id":33231299,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjMxMjk5","avatar_url":"https://avatars3.githubusercontent.com/u/33231299?v=4","gravatar_id":"","url":"https://api.github.com/users/counterfactual","html_url":"https://github.com/counterfactual","followers_url":"https://api.github.com/users/counterfactual/followers","following_url":"https://api.github.com/users/counterfactual/following{/other_user}","gists_url":"https://api.github.com/users/counterfactual/gists{/gist_id}","starred_url":"https://api.github.com/users/counterfactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/counterfactual/subscriptions","organizations_url":"https://api.github.com/users/counterfactual/orgs","repos_url":"https://api.github.com/users/counterfactual/repos","events_url":"https://api.github.com/users/counterfactual/events{/privacy}","received_events_url":"https://api.github.com/users/counterfactual/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/counterfactual/monorepo","description":"Home for all packages related to the Counterfactual project","fork":false,"url":"https://api.github.com/repos/counterfactual/monorepo","forks_url":"https://api.github.com/repos/counterfactual/monorepo/forks","keys_url":"https://api.github.com/repos/counterfactual/monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/counterfactual/monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/counterfactual/monorepo/teams","hooks_url":"https://api.github.com/repos/counterfactual/monorepo/hooks","issue_events_url":"https://api.github.com/repos/counterfactual/monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/counterfactual/monorepo/events","assignees_url":"https://api.github.com/repos/counterfactual/monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/counterfactual/monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/counterfactual/monorepo/tags","blobs_url":"https://api.github.com/repos/counterfactual/monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/counterfactual/monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/counterfactual/monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/counterfactual/monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/counterfactual/monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/counterfactual/monorepo/languages","stargazers_url":"https://api.github.com/repos/counterfactual/monorepo/stargazers","contributors_url":"https://api.github.com/repos/counterfactual/monorepo/contributors","subscribers_url":"https://api.github.com/repos/counterfactual/monorepo/subscribers","subscription_url":"https://api.github.com/repos/counterfactual/monorepo/subscription","commits_url":"https://api.github.com/repos/counterfactual/monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/counterfactual/monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/counterfactual/monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/counterfactual/monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/counterfactual/monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/counterfactual/monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/counterfactual/monorepo/merges","archive_url":"https://api.github.com/repos/counterfactual/monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/counterfactual/monorepo/downloads","issues_url":"https://api.github.com/repos/counterfactual/monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/counterfactual/monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/counterfactual/monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/counterfactual/monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/counterfactual/monorepo/labels{/name}","releases_url":"https://api.github.com/repos/counterfactual/monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/counterfactual/monorepo/deployments","created_at":"2018-08-02T01:43:08Z","updated_at":"2018-11-27T15:54:11Z","pushed_at":"2018-11-28T17:46:45Z","git_url":"git://github.com/counterfactual/monorepo.git","ssh_url":"git@github.com:counterfactual/monorepo.git","clone_url":"https://github.com/counterfactual/monorepo.git","svn_url":"https://github.com/counterfactual/monorepo","homepage":"https://counterfactual.com","size":4645,"stargazers_count":121,"watchers_count":121,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":26,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/274"},"html":{"href":"https://github.com/counterfactual/monorepo/pull/274"},"issue":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/274"},"comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/counterfactual/monorepo/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/counterfactual/monorepo/statuses/b91245802bd57e4dfa8c504b3343a1bf6a5969b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joelalejandro"}}