{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/7437","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7437/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7437/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7437/events","html_url":"https://github.com/kubernetes/test-infra/issues/7437","id":309073978,"number":7437,"title":"tools: a number of targets are not cached and make bazel test //... slow","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-27T18:01:51Z","updated_at":"2018-03-27T18:28:09Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The majority of targets are cached without issue, but a couple (notably `pylint`) make `bazel test //...` really slow and annoying. Here's a run with one `BAZEL.build` file changed between this run and the last one:\r\n\r\n```\r\n$ bazel test //...\r\nINFO: Analysed 2110 targets (538 packages loaded).\r\nINFO: Found 1987 targets and 123 test targets...\r\nINFO: Elapsed time: 87.446s, Critical Path: 68.61s\r\nINFO: Build completed successfully, 121 total actions\r\n//boskos:go_default_test                                        (cached) PASSED in 1.4s\r\n\r\n...\r\n\r\n//velodrome/transform/plugins:go_default_test                   (cached) PASSED in 1.2s\r\n//hack:verify-pylint                                                     PASSED in 64.3s\r\n//hack:verify-spelling                                                   PASSED in 14.6s\r\n//hack:verify_boilerplate                                                PASSED in 3.8s\r\n\r\nExecuted 3 out of 123 tests: 123 tests pass.\r\nThere were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.\r\n```\r\n\r\nWe should figure out how to make `pylint` and `spelling` and `boilerplate` incremental or faster. \r\n\r\n/cc @ixdy @BenTheElder @rmmh "},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/376627678","html_url":"https://github.com/kubernetes/test-infra/issues/7437#issuecomment-376627678","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7437","id":376627678,"user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T18:28:08Z","updated_at":"2018-03-27T18:28:08Z","author_association":"MEMBER","body":"https://github.com/kubernetes/test-infra/pull/7041 took care of all of that\nshort of making them manual. you can run bazel test ... with --config=unit\nor --config=lint\n\nOn Tue, Mar 27, 2018 at 11:23 AM Jeff Grafton <notifications@github.com>\nwrote:\n\n> The verify tests will cache, but only if nothing in your repo has changed.\n>\n> They're pretty un-bazely in that they depend on //:all-srcs, which\n> depends on the entire tree; this isn't really a use-case for which bazel is\n> designed. As a result, they have to be re-run anytime any file in the repo\n> changes.\n>\n> There was a proposed PR (kubernetes/repo-infra#46\n> <https://github.com/kubernetes/repo-infra/pull/46>) to try to improve\n> things slightly so we can have //:all-go-srcs and //:all-py-srcs etc,\n> though this starts to get unwieldy pretty quickly.\n>\n> In the past, we've tagged these as manual, so bazel test ... doesn't run\n> them automatically. This has caused some complaints, since then the checks\n> might fail in PR tests, since you didn't remember to run them locally.\n>\n> (I personally think we shouldn't be running them with bazel test ...;\n> maybe we can tag them as verify and then by default skip them, but allow\n> a bazel test --config=verify which includes them, perhaps.)\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kubernetes/test-infra/issues/7437#issuecomment-376626299>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AA4Bq4Yl-vJQk2RNjONwyYPrmSUtSmYyks5tioO6gaJpZM4S9YJl>\n> .\n>\n"}}
{"actor":{"display_login":"BenTheElder"}}