{"action":"created","comment":{"url":"https://api.github.com/repos/google/protobuf/pulls/comments/204130462","pull_request_review_id":139160546,"id":204130462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDEzMDQ2Mg==","diff_hunk":"@@ -668,7 +670,9 @@ public void testMapNullValueIsRejected() throws Exception {\n               + \"  \\\"int32ToMessageMap\\\": {\\\"2\\\": null}\\n\"\n               + \"}\",\n           builder);\n-      fail();\n+      assertEquals(0, builder.getInt32ToEnumMapMap().size());","path":"java/util/src/test/java/com/google/protobuf/util/JsonFormatTest.java","position":24,"original_position":24,"commit_id":"03d7ed84e343a306a6dc17b13198e1f3662e65c7","original_commit_id":"03d7ed84e343a306a6dc17b13198e1f3662e65c7","user":{"login":"xfxyjwf","id":8551050,"node_id":"MDQ6VXNlcjg1NTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8551050?v=4","gravatar_id":"","url":"https://api.github.com/users/xfxyjwf","html_url":"https://github.com/xfxyjwf","followers_url":"https://api.github.com/users/xfxyjwf/followers","following_url":"https://api.github.com/users/xfxyjwf/following{/other_user}","gists_url":"https://api.github.com/users/xfxyjwf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxyjwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxyjwf/subscriptions","organizations_url":"https://api.github.com/users/xfxyjwf/orgs","repos_url":"https://api.github.com/users/xfxyjwf/repos","events_url":"https://api.github.com/users/xfxyjwf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxyjwf/received_events","type":"User","site_admin":false},"body":"Please don't change this test for non-enum map values. As I suggested above, add a new method instead (do not split the code from the existing \"testMapNullValueIsRejected()\" method.","created_at":"2018-07-20T18:22:08Z","updated_at":"2018-07-20T18:22:44Z","html_url":"https://github.com/google/protobuf/pull/4825#discussion_r204130462","pull_request_url":"https://api.github.com/repos/google/protobuf/pulls/4825","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments/204130462"},"html":{"href":"https://github.com/google/protobuf/pull/4825#discussion_r204130462"},"pull_request":{"href":"https://api.github.com/repos/google/protobuf/pulls/4825"}}},"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/4825","id":197028771,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDI4Nzcx","html_url":"https://github.com/google/protobuf/pull/4825","diff_url":"https://github.com/google/protobuf/pull/4825.diff","patch_url":"https://github.com/google/protobuf/pull/4825.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/4825","number":4825,"state":"open","locked":false,"title":"Ignore unknown enum received in json when ignoreUnknownFields flag is set","user":{"login":"vijay-bhatt","id":21289244,"node_id":"MDQ6VXNlcjIxMjg5MjQ0","avatar_url":"https://avatars2.githubusercontent.com/u/21289244?v=4","gravatar_id":"","url":"https://api.github.com/users/vijay-bhatt","html_url":"https://github.com/vijay-bhatt","followers_url":"https://api.github.com/users/vijay-bhatt/followers","following_url":"https://api.github.com/users/vijay-bhatt/following{/other_user}","gists_url":"https://api.github.com/users/vijay-bhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/vijay-bhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijay-bhatt/subscriptions","organizations_url":"https://api.github.com/users/vijay-bhatt/orgs","repos_url":"https://api.github.com/users/vijay-bhatt/repos","events_url":"https://api.github.com/users/vijay-bhatt/events{/privacy}","received_events_url":"https://api.github.com/users/vijay-bhatt/received_events","type":"User","site_admin":false},"body":"Ignore unknown enum received in json when ignoreUnknownFields flag is set.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/protobuf/4825)\n<!-- Reviewable:end -->\n","created_at":"2018-06-25T07:51:45Z","updated_at":"2018-07-20T18:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b31b6423edfee85569ebdf4e1119d7c1f69a6173","assignee":{"login":"xfxyjwf","id":8551050,"node_id":"MDQ6VXNlcjg1NTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8551050?v=4","gravatar_id":"","url":"https://api.github.com/users/xfxyjwf","html_url":"https://github.com/xfxyjwf","followers_url":"https://api.github.com/users/xfxyjwf/followers","following_url":"https://api.github.com/users/xfxyjwf/following{/other_user}","gists_url":"https://api.github.com/users/xfxyjwf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxyjwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxyjwf/subscriptions","organizations_url":"https://api.github.com/users/xfxyjwf/orgs","repos_url":"https://api.github.com/users/xfxyjwf/repos","events_url":"https://api.github.com/users/xfxyjwf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxyjwf/received_events","type":"User","site_admin":false},"assignees":[{"login":"xfxyjwf","id":8551050,"node_id":"MDQ6VXNlcjg1NTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8551050?v=4","gravatar_id":"","url":"https://api.github.com/users/xfxyjwf","html_url":"https://github.com/xfxyjwf","followers_url":"https://api.github.com/users/xfxyjwf/followers","following_url":"https://api.github.com/users/xfxyjwf/following{/other_user}","gists_url":"https://api.github.com/users/xfxyjwf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxyjwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxyjwf/subscriptions","organizations_url":"https://api.github.com/users/xfxyjwf/orgs","repos_url":"https://api.github.com/users/xfxyjwf/repos","events_url":"https://api.github.com/users/xfxyjwf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxyjwf/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":151794609,"node_id":"MDU6TGFiZWwxNTE3OTQ2MDk=","url":"https://api.github.com/repos/google/protobuf/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":250677115,"node_id":"MDU6TGFiZWwyNTA2NzcxMTU=","url":"https://api.github.com/repos/google/protobuf/labels/java","name":"java","color":"fad8c7","default":false},{"id":872654459,"node_id":"MDU6TGFiZWw4NzI2NTQ0NTk=","url":"https://api.github.com/repos/google/protobuf/labels/wait%20for%20user%20action","name":"wait for user action","color":"9a57ed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/4825/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/4825/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/4825/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/03d7ed84e343a306a6dc17b13198e1f3662e65c7","head":{"label":"vijay-bhatt:master","ref":"master","sha":"03d7ed84e343a306a6dc17b13198e1f3662e65c7","user":{"login":"vijay-bhatt","id":21289244,"node_id":"MDQ6VXNlcjIxMjg5MjQ0","avatar_url":"https://avatars2.githubusercontent.com/u/21289244?v=4","gravatar_id":"","url":"https://api.github.com/users/vijay-bhatt","html_url":"https://github.com/vijay-bhatt","followers_url":"https://api.github.com/users/vijay-bhatt/followers","following_url":"https://api.github.com/users/vijay-bhatt/following{/other_user}","gists_url":"https://api.github.com/users/vijay-bhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/vijay-bhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijay-bhatt/subscriptions","organizations_url":"https://api.github.com/users/vijay-bhatt/orgs","repos_url":"https://api.github.com/users/vijay-bhatt/repos","events_url":"https://api.github.com/users/vijay-bhatt/events{/privacy}","received_events_url":"https://api.github.com/users/vijay-bhatt/received_events","type":"User","site_admin":false},"repo":{"id":138499543,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0OTk1NDM=","name":"protobuf","full_name":"vijay-bhatt/protobuf","owner":{"login":"vijay-bhatt","id":21289244,"node_id":"MDQ6VXNlcjIxMjg5MjQ0","avatar_url":"https://avatars2.githubusercontent.com/u/21289244?v=4","gravatar_id":"","url":"https://api.github.com/users/vijay-bhatt","html_url":"https://github.com/vijay-bhatt","followers_url":"https://api.github.com/users/vijay-bhatt/followers","following_url":"https://api.github.com/users/vijay-bhatt/following{/other_user}","gists_url":"https://api.github.com/users/vijay-bhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/vijay-bhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijay-bhatt/subscriptions","organizations_url":"https://api.github.com/users/vijay-bhatt/orgs","repos_url":"https://api.github.com/users/vijay-bhatt/repos","events_url":"https://api.github.com/users/vijay-bhatt/events{/privacy}","received_events_url":"https://api.github.com/users/vijay-bhatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vijay-bhatt/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/vijay-bhatt/protobuf","forks_url":"https://api.github.com/repos/vijay-bhatt/protobuf/forks","keys_url":"https://api.github.com/repos/vijay-bhatt/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vijay-bhatt/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vijay-bhatt/protobuf/teams","hooks_url":"https://api.github.com/repos/vijay-bhatt/protobuf/hooks","issue_events_url":"https://api.github.com/repos/vijay-bhatt/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/vijay-bhatt/protobuf/events","assignees_url":"https://api.github.com/repos/vijay-bhatt/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/vijay-bhatt/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/vijay-bhatt/protobuf/tags","blobs_url":"https://api.github.com/repos/vijay-bhatt/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vijay-bhatt/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vijay-bhatt/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/vijay-bhatt/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vijay-bhatt/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/vijay-bhatt/protobuf/languages","stargazers_url":"https://api.github.com/repos/vijay-bhatt/protobuf/stargazers","contributors_url":"https://api.github.com/repos/vijay-bhatt/protobuf/contributors","subscribers_url":"https://api.github.com/repos/vijay-bhatt/protobuf/subscribers","subscription_url":"https://api.github.com/repos/vijay-bhatt/protobuf/subscription","commits_url":"https://api.github.com/repos/vijay-bhatt/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/vijay-bhatt/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/vijay-bhatt/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/vijay-bhatt/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/vijay-bhatt/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/vijay-bhatt/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vijay-bhatt/protobuf/merges","archive_url":"https://api.github.com/repos/vijay-bhatt/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vijay-bhatt/protobuf/downloads","issues_url":"https://api.github.com/repos/vijay-bhatt/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/vijay-bhatt/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/vijay-bhatt/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/vijay-bhatt/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vijay-bhatt/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/vijay-bhatt/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/vijay-bhatt/protobuf/deployments","created_at":"2018-06-24T16:54:05Z","updated_at":"2018-07-17T11:07:26Z","pushed_at":"2018-07-17T11:07:14Z","git_url":"git://github.com/vijay-bhatt/protobuf.git","ssh_url":"git@github.com:vijay-bhatt/protobuf.git","clone_url":"https://github.com/vijay-bhatt/protobuf.git","svn_url":"https://github.com/vijay-bhatt/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":47446,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"fc243c15fb0a691d3fc0896803939c2a535b6a8c","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM1NzU4OA==","name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2018-07-20T17:47:17Z","pushed_at":"2018-07-20T18:16:15Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":48333,"stargazers_count":27757,"watchers_count":27757,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7785,"mirror_url":null,"archived":false,"open_issues_count":428,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7785,"open_issues":428,"watchers":27757,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/4825"},"html":{"href":"https://github.com/google/protobuf/pull/4825"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/4825"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/4825/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/4825/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/4825/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/03d7ed84e343a306a6dc17b13198e1f3662e65c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"xfxyjwf"}}