{"action":"created","issue":{"url":"https://api.github.com/repos/scylladb/scylla-ami/issues/35","repository_url":"https://api.github.com/repos/scylladb/scylla-ami","labels_url":"https://api.github.com/repos/scylladb/scylla-ami/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/scylladb/scylla-ami/issues/35/comments","events_url":"https://api.github.com/repos/scylladb/scylla-ami/issues/35/events","html_url":"https://github.com/scylladb/scylla-ami/issues/35","id":326349553,"node_id":"MDU6SXNzdWUzMjYzNDk1NTM=","number":35,"title":"Cluster Name ignored on setup","user":{"login":"CarlGill","id":22015306,"node_id":"MDQ6VXNlcjIyMDE1MzA2","avatar_url":"https://avatars0.githubusercontent.com/u/22015306?v=4","gravatar_id":"","url":"https://api.github.com/users/CarlGill","html_url":"https://github.com/CarlGill","followers_url":"https://api.github.com/users/CarlGill/followers","following_url":"https://api.github.com/users/CarlGill/following{/other_user}","gists_url":"https://api.github.com/users/CarlGill/gists{/gist_id}","starred_url":"https://api.github.com/users/CarlGill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarlGill/subscriptions","organizations_url":"https://api.github.com/users/CarlGill/orgs","repos_url":"https://api.github.com/users/CarlGill/repos","events_url":"https://api.github.com/users/CarlGill/events{/privacy}","received_events_url":"https://api.github.com/users/CarlGill/received_events","type":"User","site_admin":false},"labels":[{"id":262716763,"node_id":"MDU6TGFiZWwyNjI3MTY3NjM=","url":"https://api.github.com/repos/scylladb/scylla-ami/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-25T01:22:15Z","updated_at":"2018-07-04T19:12:07Z","closed_at":null,"author_association":"NONE","body":"It appears the clustername that is passed through to ds2_configure.py, ends up being commented out and unused.\r\n\r\nExample scylla config after ds2_configure.py has completed:\r\n\r\n```\r\n# The name of the cluster. This is mainly used to prevent machines in\r\n# one logical cluster from joining another.\r\n# It is recommended to change the default value when creating a new cluster.\r\n# You can NOT modify this value for an existing cluster\r\n#cluster_name: example_cluster_name\r\n```\r\n\r\n```\r\nFrom the system table:\r\n cluster_name | host_id\r\n--------------+--------------------------------------\r\n              | 257865d9-446f-42d3-a362-3a714a29806d\r\n```\r\n\r\nThe worrisome part is there is no failure, and my cluster ends up starting up fine, and had I not been fighting with getting the ec2snitch to work ( Restrictive Security groups ), I would not have been looking.\r\n\r\nI believe we just need to ensure that `#` is replaced.  I will put up a PR shortly.  But I wanted to make sure there was no sane reason to leave it alone.\r\n\r\nhttps://github.com/scylladb/scylla-ami/blob/025644dfd8f50c7d424c9985476c69695d0e6f89/ds2_configure.py#L432-L434"},"comment":{"url":"https://api.github.com/repos/scylladb/scylla-ami/issues/comments/402545183","html_url":"https://github.com/scylladb/scylla-ami/issues/35#issuecomment-402545183","issue_url":"https://api.github.com/repos/scylladb/scylla-ami/issues/35","id":402545183,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjU0NTE4Mw==","user":{"login":"tzach","id":170200,"node_id":"MDQ6VXNlcjE3MDIwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/170200?v=4","gravatar_id":"","url":"https://api.github.com/users/tzach","html_url":"https://github.com/tzach","followers_url":"https://api.github.com/users/tzach/followers","following_url":"https://api.github.com/users/tzach/following{/other_user}","gists_url":"https://api.github.com/users/tzach/gists{/gist_id}","starred_url":"https://api.github.com/users/tzach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzach/subscriptions","organizations_url":"https://api.github.com/users/tzach/orgs","repos_url":"https://api.github.com/users/tzach/repos","events_url":"https://api.github.com/users/tzach/events{/privacy}","received_events_url":"https://api.github.com/users/tzach/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T19:12:07Z","updated_at":"2018-07-04T19:12:07Z","author_association":"NONE","body":"More users are hitting this\r\n"}}
{"actor":{"display_login":"tzach"}}