{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7211","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7211/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7211/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7211/events","html_url":"https://github.com/mapbox/mapbox-gl-js/issues/7211","id":354707004,"node_id":"MDU6SXNzdWUzNTQ3MDcwMDQ=","number":7211,"title":"Labels are not shown at the same zoom level as before v.0.48.0","user":{"login":"IvanVoevodin","id":26249043,"node_id":"MDQ6VXNlcjI2MjQ5MDQz","avatar_url":"https://avatars0.githubusercontent.com/u/26249043?v=4","gravatar_id":"","url":"https://api.github.com/users/IvanVoevodin","html_url":"https://github.com/IvanVoevodin","followers_url":"https://api.github.com/users/IvanVoevodin/followers","following_url":"https://api.github.com/users/IvanVoevodin/following{/other_user}","gists_url":"https://api.github.com/users/IvanVoevodin/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanVoevodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanVoevodin/subscriptions","organizations_url":"https://api.github.com/users/IvanVoevodin/orgs","repos_url":"https://api.github.com/users/IvanVoevodin/repos","events_url":"https://api.github.com/users/IvanVoevodin/events{/privacy}","received_events_url":"https://api.github.com/users/IvanVoevodin/received_events","type":"User","site_admin":false},"labels":[{"id":868200948,"node_id":"MDU6TGFiZWw4NjgyMDA5NDg=","url":"https://api.github.com/repos/mapbox/mapbox-gl-js/labels/needs%20investigation%20:mag:","name":"needs investigation :mag:","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"ChrisLoer","id":375121,"node_id":"MDQ6VXNlcjM3NTEyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/375121?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisLoer","html_url":"https://github.com/ChrisLoer","followers_url":"https://api.github.com/users/ChrisLoer/followers","following_url":"https://api.github.com/users/ChrisLoer/following{/other_user}","gists_url":"https://api.github.com/users/ChrisLoer/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisLoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisLoer/subscriptions","organizations_url":"https://api.github.com/users/ChrisLoer/orgs","repos_url":"https://api.github.com/users/ChrisLoer/repos","events_url":"https://api.github.com/users/ChrisLoer/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisLoer/received_events","type":"User","site_admin":false},"assignees":[{"login":"ChrisLoer","id":375121,"node_id":"MDQ6VXNlcjM3NTEyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/375121?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisLoer","html_url":"https://github.com/ChrisLoer","followers_url":"https://api.github.com/users/ChrisLoer/followers","following_url":"https://api.github.com/users/ChrisLoer/following{/other_user}","gists_url":"https://api.github.com/users/ChrisLoer/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisLoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisLoer/subscriptions","organizations_url":"https://api.github.com/users/ChrisLoer/orgs","repos_url":"https://api.github.com/users/ChrisLoer/repos","events_url":"https://api.github.com/users/ChrisLoer/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisLoer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-08-28T12:24:08Z","updated_at":"2018-09-05T21:59:08Z","closed_at":null,"author_association":"NONE","body":"For now we use the version of Mapbox 0.47.0, in some cases we have a pretty long labels. In the new version of Mapbox 0.48.0 we see a regression associated with the fact that for all the same settings, the label at the same zoom level is not displayed, and to display it you need to zoom in to line.\r\n\r\n**Mapbox 0.47.0**\r\n![mapbox show label 0 47 0 - jsfiddle](https://user-images.githubusercontent.com/26249043/44722593-97bce200-aade-11e8-992a-4ad6430d9337.png)\r\n**Mapbox 0.48.0**\r\n![mapbox show label 0 48 0 - jsfiddle](https://user-images.githubusercontent.com/26249043/44722594-97bce200-aade-11e8-8b33-0ace39277e69.png)\r\n\r\n**mapbox-gl-js version**: 0.48.0\r\n\r\n### Link to Demonstration\r\n\r\nHere’s the JSFiddle \r\nfor v.0.47.0: https://jsfiddle.net/iv_vo/g6q1rzot/\r\nfor v.0.48.0: https://jsfiddle.net/iv_vo/qrombvhf/\r\n\r\n### Expected Behavior\r\nLabels are shown at the same zoom level as before\r\n### Actual Behavior\r\nLabels are not shown at the same zoom level as before"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/418895294","html_url":"https://github.com/mapbox/mapbox-gl-js/issues/7211#issuecomment-418895294","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7211","id":418895294,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODg5NTI5NA==","user":{"login":"ChrisLoer","id":375121,"node_id":"MDQ6VXNlcjM3NTEyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/375121?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisLoer","html_url":"https://github.com/ChrisLoer","followers_url":"https://api.github.com/users/ChrisLoer/followers","following_url":"https://api.github.com/users/ChrisLoer/following{/other_user}","gists_url":"https://api.github.com/users/ChrisLoer/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisLoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisLoer/subscriptions","organizations_url":"https://api.github.com/users/ChrisLoer/orgs","repos_url":"https://api.github.com/users/ChrisLoer/repos","events_url":"https://api.github.com/users/ChrisLoer/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisLoer/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T21:59:08Z","updated_at":"2018-09-05T21:59:08Z","author_association":"CONTRIBUTOR","body":"I think this was exposed by https://github.com/mapbox/mapbox-gl-js/pull/6945 -- before that change, the label would (kind of incorrectly?) pass the `checkMaxAngle` test.\r\n\r\nBut I think the underlying problem is that we shouldn't be doing the `checkMaxAngle` test at all with `text-rotation-alignment: viewport`, since the label doesn't actually follow the line. I haven't thought much at all about how the combination of `symbol-placement: line` and `text-rotation-alignment: viewport` should work: are there use cases we'd break by relaxing the `checkMaxAngle` check?"}}
{"actor":{"display_login":"ChrisLoer"}}