{"action":"created","comment":{"url":"https://api.github.com/repos/infoscout/dynsettings/pulls/comments/187117938","pull_request_review_id":118833853,"id":187117938,"diff_hunk":"@@ -0,0 +1,111 @@\n+from django.db.utils import DatabaseError\n+from django.test import TestCase\n+\n+import mock\n+from mock import patch\n+\n+from dynsettings.models import Bucket, BucketSetting, Setting, SettingCache\n+\n+\n+class SettingTestCase(TestCase):\n+    \"\"\"\n+    Verify Setting class methods operate correctly\n+    \"\"\"\n+\n+    def setUp(self):\n+        self.setting_instance = Setting(\n+            key='TEST', data_type=('STRING', 'String')\n+        )\n+\n+    def test__unicode__(self):\n+        self.assertEqual(self.setting_instance.__unicode__(), 'TEST')\n+\n+    def test__nonzero__(self):\n+        self.assertEqual(self.setting_instance.__nonzero__(), True)\n+\n+\n+class BucketTestCase(TestCase):\n+    \"\"\"\n+    Verify Bucket class returns correct unicode representation\n+    \"\"\"\n+\n+    def setUp(self):\n+        self.bucket_instance = Bucket(key='TEST')\n+\n+    def test__unicode__(self):\n+        self.assertEqual(self.bucket_instance.__unicode__(), 'TEST')\n+\n+\n+class SettingCacheValueTestCase(TestCase):\n+    \"\"\"\n+    Verify SettingCache stores values as expected\n+    \"\"\"\n+\n+    def setUp(self):\n+        self.cache_instance = SettingCache()\n+        self.cache_instance._test_values['TEST'] = 'testing'\n+\n+    def tearDown(self):\n+        # reset cache for each test so loaded resets\n+        SettingCache.reset()\n+        del self.cache_instance._test_values['TEST']","path":"dynsettings/tests/test_models.py","position":50,"original_position":51,"commit_id":"1da62e744ecf8a623c702a8bb1a6bcea47395df5","original_commit_id":"1cf587a8c16dd27f073d638becb786dd32e591a5","user":{"login":"RevolutionTech","id":6820092,"avatar_url":"https://avatars2.githubusercontent.com/u/6820092?v=4","gravatar_id":"","url":"https://api.github.com/users/RevolutionTech","html_url":"https://github.com/RevolutionTech","followers_url":"https://api.github.com/users/RevolutionTech/followers","following_url":"https://api.github.com/users/RevolutionTech/following{/other_user}","gists_url":"https://api.github.com/users/RevolutionTech/gists{/gist_id}","starred_url":"https://api.github.com/users/RevolutionTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RevolutionTech/subscriptions","organizations_url":"https://api.github.com/users/RevolutionTech/orgs","repos_url":"https://api.github.com/users/RevolutionTech/repos","events_url":"https://api.github.com/users/RevolutionTech/events{/privacy}","received_events_url":"https://api.github.com/users/RevolutionTech/received_events","type":"User","site_admin":false},"body":"Thanks for checking it out! That's totally okay if it doesn't work.","created_at":"2018-05-09T17:35:36Z","updated_at":"2018-05-09T17:35:36Z","html_url":"https://github.com/infoscout/dynsettings/pull/1#discussion_r187117938","pull_request_url":"https://api.github.com/repos/infoscout/dynsettings/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infoscout/dynsettings/pulls/comments/187117938"},"html":{"href":"https://github.com/infoscout/dynsettings/pull/1#discussion_r187117938"},"pull_request":{"href":"https://api.github.com/repos/infoscout/dynsettings/pulls/1"}},"in_reply_to_id":186819434},"pull_request":{"url":"https://api.github.com/repos/infoscout/dynsettings/pulls/1","id":186704673,"html_url":"https://github.com/infoscout/dynsettings/pull/1","diff_url":"https://github.com/infoscout/dynsettings/pull/1.diff","patch_url":"https://github.com/infoscout/dynsettings/pull/1.patch","issue_url":"https://api.github.com/repos/infoscout/dynsettings/issues/1","number":1,"state":"open","locked":false,"title":"Testing","user":{"login":"amsowie","id":32368939,"avatar_url":"https://avatars1.githubusercontent.com/u/32368939?v=4","gravatar_id":"","url":"https://api.github.com/users/amsowie","html_url":"https://github.com/amsowie","followers_url":"https://api.github.com/users/amsowie/followers","following_url":"https://api.github.com/users/amsowie/following{/other_user}","gists_url":"https://api.github.com/users/amsowie/gists{/gist_id}","starred_url":"https://api.github.com/users/amsowie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amsowie/subscriptions","organizations_url":"https://api.github.com/users/amsowie/orgs","repos_url":"https://api.github.com/users/amsowie/repos","events_url":"https://api.github.com/users/amsowie/events{/privacy}","received_events_url":"https://api.github.com/users/amsowie/received_events","type":"User","site_admin":false},"body":"On line 120 in models.py, I had to change the import call because of our refactoring. Please let me know if this was a good way to do it or not. Also- I kept the spacing in test_value_conversion in groups of three because it looked weird visually with the space before the assert, but I'm not sure if it's actually okay looking.","created_at":"2018-05-08T17:35:01Z","updated_at":"2018-05-09T17:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46dee3daaf2b2b1b69eb388014f9638123b6fc17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infoscout/dynsettings/pulls/1/commits","review_comments_url":"https://api.github.com/repos/infoscout/dynsettings/pulls/1/comments","review_comment_url":"https://api.github.com/repos/infoscout/dynsettings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infoscout/dynsettings/issues/1/comments","statuses_url":"https://api.github.com/repos/infoscout/dynsettings/statuses/1da62e744ecf8a623c702a8bb1a6bcea47395df5","head":{"label":"infoscout:testing","ref":"testing","sha":"1da62e744ecf8a623c702a8bb1a6bcea47395df5","user":{"login":"infoscout","id":2794714,"avatar_url":"https://avatars1.githubusercontent.com/u/2794714?v=4","gravatar_id":"","url":"https://api.github.com/users/infoscout","html_url":"https://github.com/infoscout","followers_url":"https://api.github.com/users/infoscout/followers","following_url":"https://api.github.com/users/infoscout/following{/other_user}","gists_url":"https://api.github.com/users/infoscout/gists{/gist_id}","starred_url":"https://api.github.com/users/infoscout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoscout/subscriptions","organizations_url":"https://api.github.com/users/infoscout/orgs","repos_url":"https://api.github.com/users/infoscout/repos","events_url":"https://api.github.com/users/infoscout/events{/privacy}","received_events_url":"https://api.github.com/users/infoscout/received_events","type":"Organization","site_admin":false},"repo":{"id":10090378,"name":"dynsettings","full_name":"infoscout/dynsettings","owner":{"login":"infoscout","id":2794714,"avatar_url":"https://avatars1.githubusercontent.com/u/2794714?v=4","gravatar_id":"","url":"https://api.github.com/users/infoscout","html_url":"https://github.com/infoscout","followers_url":"https://api.github.com/users/infoscout/followers","following_url":"https://api.github.com/users/infoscout/following{/other_user}","gists_url":"https://api.github.com/users/infoscout/gists{/gist_id}","starred_url":"https://api.github.com/users/infoscout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoscout/subscriptions","organizations_url":"https://api.github.com/users/infoscout/orgs","repos_url":"https://api.github.com/users/infoscout/repos","events_url":"https://api.github.com/users/infoscout/events{/privacy}","received_events_url":"https://api.github.com/users/infoscout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infoscout/dynsettings","description":"Stores key/value settings in database, allowing for live updating of settings","fork":false,"url":"https://api.github.com/repos/infoscout/dynsettings","forks_url":"https://api.github.com/repos/infoscout/dynsettings/forks","keys_url":"https://api.github.com/repos/infoscout/dynsettings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infoscout/dynsettings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infoscout/dynsettings/teams","hooks_url":"https://api.github.com/repos/infoscout/dynsettings/hooks","issue_events_url":"https://api.github.com/repos/infoscout/dynsettings/issues/events{/number}","events_url":"https://api.github.com/repos/infoscout/dynsettings/events","assignees_url":"https://api.github.com/repos/infoscout/dynsettings/assignees{/user}","branches_url":"https://api.github.com/repos/infoscout/dynsettings/branches{/branch}","tags_url":"https://api.github.com/repos/infoscout/dynsettings/tags","blobs_url":"https://api.github.com/repos/infoscout/dynsettings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infoscout/dynsettings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infoscout/dynsettings/git/refs{/sha}","trees_url":"https://api.github.com/repos/infoscout/dynsettings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infoscout/dynsettings/statuses/{sha}","languages_url":"https://api.github.com/repos/infoscout/dynsettings/languages","stargazers_url":"https://api.github.com/repos/infoscout/dynsettings/stargazers","contributors_url":"https://api.github.com/repos/infoscout/dynsettings/contributors","subscribers_url":"https://api.github.com/repos/infoscout/dynsettings/subscribers","subscription_url":"https://api.github.com/repos/infoscout/dynsettings/subscription","commits_url":"https://api.github.com/repos/infoscout/dynsettings/commits{/sha}","git_commits_url":"https://api.github.com/repos/infoscout/dynsettings/git/commits{/sha}","comments_url":"https://api.github.com/repos/infoscout/dynsettings/comments{/number}","issue_comment_url":"https://api.github.com/repos/infoscout/dynsettings/issues/comments{/number}","contents_url":"https://api.github.com/repos/infoscout/dynsettings/contents/{+path}","compare_url":"https://api.github.com/repos/infoscout/dynsettings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infoscout/dynsettings/merges","archive_url":"https://api.github.com/repos/infoscout/dynsettings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infoscout/dynsettings/downloads","issues_url":"https://api.github.com/repos/infoscout/dynsettings/issues{/number}","pulls_url":"https://api.github.com/repos/infoscout/dynsettings/pulls{/number}","milestones_url":"https://api.github.com/repos/infoscout/dynsettings/milestones{/number}","notifications_url":"https://api.github.com/repos/infoscout/dynsettings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infoscout/dynsettings/labels{/name}","releases_url":"https://api.github.com/repos/infoscout/dynsettings/releases{/id}","deployments_url":"https://api.github.com/repos/infoscout/dynsettings/deployments","created_at":"2013-05-16T00:00:56Z","updated_at":"2016-03-04T23:21:56Z","pushed_at":"2018-05-09T00:09:36Z","git_url":"git://github.com/infoscout/dynsettings.git","ssh_url":"git@github.com:infoscout/dynsettings.git","clone_url":"https://github.com/infoscout/dynsettings.git","svn_url":"https://github.com/infoscout/dynsettings","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"infoscout:master","ref":"master","sha":"a4cb918678153c0a8da346b3ae2052d3a06222ab","user":{"login":"infoscout","id":2794714,"avatar_url":"https://avatars1.githubusercontent.com/u/2794714?v=4","gravatar_id":"","url":"https://api.github.com/users/infoscout","html_url":"https://github.com/infoscout","followers_url":"https://api.github.com/users/infoscout/followers","following_url":"https://api.github.com/users/infoscout/following{/other_user}","gists_url":"https://api.github.com/users/infoscout/gists{/gist_id}","starred_url":"https://api.github.com/users/infoscout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoscout/subscriptions","organizations_url":"https://api.github.com/users/infoscout/orgs","repos_url":"https://api.github.com/users/infoscout/repos","events_url":"https://api.github.com/users/infoscout/events{/privacy}","received_events_url":"https://api.github.com/users/infoscout/received_events","type":"Organization","site_admin":false},"repo":{"id":10090378,"name":"dynsettings","full_name":"infoscout/dynsettings","owner":{"login":"infoscout","id":2794714,"avatar_url":"https://avatars1.githubusercontent.com/u/2794714?v=4","gravatar_id":"","url":"https://api.github.com/users/infoscout","html_url":"https://github.com/infoscout","followers_url":"https://api.github.com/users/infoscout/followers","following_url":"https://api.github.com/users/infoscout/following{/other_user}","gists_url":"https://api.github.com/users/infoscout/gists{/gist_id}","starred_url":"https://api.github.com/users/infoscout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infoscout/subscriptions","organizations_url":"https://api.github.com/users/infoscout/orgs","repos_url":"https://api.github.com/users/infoscout/repos","events_url":"https://api.github.com/users/infoscout/events{/privacy}","received_events_url":"https://api.github.com/users/infoscout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infoscout/dynsettings","description":"Stores key/value settings in database, allowing for live updating of settings","fork":false,"url":"https://api.github.com/repos/infoscout/dynsettings","forks_url":"https://api.github.com/repos/infoscout/dynsettings/forks","keys_url":"https://api.github.com/repos/infoscout/dynsettings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infoscout/dynsettings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infoscout/dynsettings/teams","hooks_url":"https://api.github.com/repos/infoscout/dynsettings/hooks","issue_events_url":"https://api.github.com/repos/infoscout/dynsettings/issues/events{/number}","events_url":"https://api.github.com/repos/infoscout/dynsettings/events","assignees_url":"https://api.github.com/repos/infoscout/dynsettings/assignees{/user}","branches_url":"https://api.github.com/repos/infoscout/dynsettings/branches{/branch}","tags_url":"https://api.github.com/repos/infoscout/dynsettings/tags","blobs_url":"https://api.github.com/repos/infoscout/dynsettings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infoscout/dynsettings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infoscout/dynsettings/git/refs{/sha}","trees_url":"https://api.github.com/repos/infoscout/dynsettings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infoscout/dynsettings/statuses/{sha}","languages_url":"https://api.github.com/repos/infoscout/dynsettings/languages","stargazers_url":"https://api.github.com/repos/infoscout/dynsettings/stargazers","contributors_url":"https://api.github.com/repos/infoscout/dynsettings/contributors","subscribers_url":"https://api.github.com/repos/infoscout/dynsettings/subscribers","subscription_url":"https://api.github.com/repos/infoscout/dynsettings/subscription","commits_url":"https://api.github.com/repos/infoscout/dynsettings/commits{/sha}","git_commits_url":"https://api.github.com/repos/infoscout/dynsettings/git/commits{/sha}","comments_url":"https://api.github.com/repos/infoscout/dynsettings/comments{/number}","issue_comment_url":"https://api.github.com/repos/infoscout/dynsettings/issues/comments{/number}","contents_url":"https://api.github.com/repos/infoscout/dynsettings/contents/{+path}","compare_url":"https://api.github.com/repos/infoscout/dynsettings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infoscout/dynsettings/merges","archive_url":"https://api.github.com/repos/infoscout/dynsettings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infoscout/dynsettings/downloads","issues_url":"https://api.github.com/repos/infoscout/dynsettings/issues{/number}","pulls_url":"https://api.github.com/repos/infoscout/dynsettings/pulls{/number}","milestones_url":"https://api.github.com/repos/infoscout/dynsettings/milestones{/number}","notifications_url":"https://api.github.com/repos/infoscout/dynsettings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infoscout/dynsettings/labels{/name}","releases_url":"https://api.github.com/repos/infoscout/dynsettings/releases{/id}","deployments_url":"https://api.github.com/repos/infoscout/dynsettings/deployments","created_at":"2013-05-16T00:00:56Z","updated_at":"2016-03-04T23:21:56Z","pushed_at":"2018-05-09T00:09:36Z","git_url":"git://github.com/infoscout/dynsettings.git","ssh_url":"git@github.com:infoscout/dynsettings.git","clone_url":"https://github.com/infoscout/dynsettings.git","svn_url":"https://github.com/infoscout/dynsettings","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infoscout/dynsettings/pulls/1"},"html":{"href":"https://github.com/infoscout/dynsettings/pull/1"},"issue":{"href":"https://api.github.com/repos/infoscout/dynsettings/issues/1"},"comments":{"href":"https://api.github.com/repos/infoscout/dynsettings/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/infoscout/dynsettings/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/infoscout/dynsettings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infoscout/dynsettings/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/infoscout/dynsettings/statuses/1da62e744ecf8a623c702a8bb1a6bcea47395df5"}},"author_association":"NONE"}}
{"actor":{"display_login":"RevolutionTech"}}