{"action":"created","issue":{"url":"https://api.github.com/repos/colehurwitz31/spikeinterface/issues/28","repository_url":"https://api.github.com/repos/colehurwitz31/spikeinterface","labels_url":"https://api.github.com/repos/colehurwitz31/spikeinterface/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/colehurwitz31/spikeinterface/issues/28/comments","events_url":"https://api.github.com/repos/colehurwitz31/spikeinterface/issues/28/events","html_url":"https://github.com/colehurwitz31/spikeinterface/issues/28","id":368223795,"node_id":"MDU6SXNzdWUzNjgyMjM3OTU=","number":28,"title":"Unit Tests insufficient for getSnippets and getTraces","user":{"login":"colehurwitz31","id":31068646,"node_id":"MDQ6VXNlcjMxMDY4NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/31068646?v=4","gravatar_id":"","url":"https://api.github.com/users/colehurwitz31","html_url":"https://github.com/colehurwitz31","followers_url":"https://api.github.com/users/colehurwitz31/followers","following_url":"https://api.github.com/users/colehurwitz31/following{/other_user}","gists_url":"https://api.github.com/users/colehurwitz31/gists{/gist_id}","starred_url":"https://api.github.com/users/colehurwitz31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colehurwitz31/subscriptions","organizations_url":"https://api.github.com/users/colehurwitz31/orgs","repos_url":"https://api.github.com/users/colehurwitz31/repos","events_url":"https://api.github.com/users/colehurwitz31/events{/privacy}","received_events_url":"https://api.github.com/users/colehurwitz31/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-09T13:57:03Z","updated_at":"2018-10-09T13:59:49Z","closed_at":null,"author_association":"OWNER","body":"Currently, the unit tests only check if the getSnippets and getTraces functions are equal for two recording extractors. However, the functionality could be the same for both, but still be wrong. I think I just removed a bug from getSnippets which was not being caught since the core implementation was wrong for buffering near the ends of files."},"comment":{"url":"https://api.github.com/repos/colehurwitz31/spikeinterface/issues/comments/428203066","html_url":"https://github.com/colehurwitz31/spikeinterface/issues/28#issuecomment-428203066","issue_url":"https://api.github.com/repos/colehurwitz31/spikeinterface/issues/28","id":428203066,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODIwMzA2Ng==","user":{"login":"colehurwitz31","id":31068646,"node_id":"MDQ6VXNlcjMxMDY4NjQ2","avatar_url":"https://avatars3.githubusercontent.com/u/31068646?v=4","gravatar_id":"","url":"https://api.github.com/users/colehurwitz31","html_url":"https://github.com/colehurwitz31","followers_url":"https://api.github.com/users/colehurwitz31/followers","following_url":"https://api.github.com/users/colehurwitz31/following{/other_user}","gists_url":"https://api.github.com/users/colehurwitz31/gists{/gist_id}","starred_url":"https://api.github.com/users/colehurwitz31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colehurwitz31/subscriptions","organizations_url":"https://api.github.com/users/colehurwitz31/orgs","repos_url":"https://api.github.com/users/colehurwitz31/repos","events_url":"https://api.github.com/users/colehurwitz31/events{/privacy}","received_events_url":"https://api.github.com/users/colehurwitz31/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T13:59:49Z","updated_at":"2018-10-09T13:59:49Z","author_association":"OWNER","body":"Or at least the getSnippets test is insufficient as the previous code should not have been working for end of file issues.\r\n\r\nI just changed:\r\n\r\n```\r\nif snippet_range[1] >= num_frames:\r\n                    snippet_buffer[1] -= snippet_range[1] + num_frames\r\n                    snippet_range[1] -= snippet_range[1] + num_frames\r\n```\r\n\r\nto:\r\n\r\n```\r\nif snippet_range[1] >= num_frames:\r\n                    snippet_buffer[1] -= snippet_range[1] - num_frames\r\n                    snippet_range[1] -= snippet_range[1] - num_frames\r\n```\r\n"}}
{"actor":{"display_login":"colehurwitz31"}}