{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/202337956","pull_request_review_id":137021191,"id":202337956,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjMzNzk1Ng==","diff_hunk":"@@ -66,6 +67,57 @@ public override IEnumerable<TimeFunction> TimeFunctions(bool requiresRoundtrippi\n                 DateTimeKind.Utc);\n         }\n \n+        [Fact]\n+        public void CopyToMillisecondPresent()\n+        {\n+            FileInfo input = new FileInfo(Path.Combine(TestDirectory, GetTestFileName()));\n+            input.Create().Dispose();\n+\n+            string driveFormat = new DriveInfo(input.DirectoryName).DriveFormat;\n+            if (!driveFormat.Equals(HFS, StringComparison.InvariantCultureIgnoreCase))\n+            {\n+                for (int i = 0; i < 5; i++)\n+                {\n+                    if (input.LastWriteTime.Millisecond != 0)\n+                        break;\n+\n+                    // This case should only happen 1/1000 times, unless the OS/Filesystem does\n+                    // not support millisecond granularity.\n+\n+                    // If it's 1/1000, or low granularity, this may help:\n+                    Thread.Sleep(1234);\n+                    input = new FileInfo(Path.Combine(TestDirectory, GetTestFileName()));\n+                    input.Create().Dispose();\n+                }\n+\n+                FileInfo output = new FileInfo(Path.Combine(TestDirectory, GetTestFileName(), input.Name));\n+                Assert.Equal(0, output.LastWriteTime.Millisecond);\n+                output.Directory.Create();\n+                output = input.CopyTo(output.FullName, true);\n+\n+                Assert.NotEqual(0, input.LastWriteTime.Millisecond);\n+                Assert.NotEqual(0, output.LastWriteTime.Millisecond);","path":"src/System.IO.FileSystem/tests/FileInfo/GetSetTimes.cs","position":41,"original_position":41,"commit_id":"493dacf9a5f07dc29fb0350876cf15a7aea06f78","original_commit_id":"493dacf9a5f07dc29fb0350876cf15a7aea06f78","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to check that Assert.Equal(input.LastWriteTime, output.LastWriteTime)?","created_at":"2018-07-13T12:47:26Z","updated_at":"2018-07-13T12:47:26Z","html_url":"https://github.com/dotnet/corefx/pull/31046#discussion_r202337956","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/31046","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/202337956"},"html":{"href":"https://github.com/dotnet/corefx/pull/31046#discussion_r202337956"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31046"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/31046","id":201188616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTg4NjE2","html_url":"https://github.com/dotnet/corefx/pull/31046","diff_url":"https://github.com/dotnet/corefx/pull/31046.diff","patch_url":"https://github.com/dotnet/corefx/pull/31046.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/31046","number":31046,"state":"open","locked":false,"title":"[release/2.1] Fix Granularity for copy operation on unix","user":{"login":"Anipik","id":10516582,"node_id":"MDQ6VXNlcjEwNTE2NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10516582?v=4","gravatar_id":"","url":"https://api.github.com/users/Anipik","html_url":"https://github.com/Anipik","followers_url":"https://api.github.com/users/Anipik/followers","following_url":"https://api.github.com/users/Anipik/following{/other_user}","gists_url":"https://api.github.com/users/Anipik/gists{/gist_id}","starred_url":"https://api.github.com/users/Anipik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anipik/subscriptions","organizations_url":"https://api.github.com/users/Anipik/orgs","repos_url":"https://api.github.com/users/Anipik/repos","events_url":"https://api.github.com/users/Anipik/events{/privacy}","received_events_url":"https://api.github.com/users/Anipik/received_events","type":"User","site_admin":false},"body":"Related Issue https://github.com/dotnet/corefx/issues/12403\r\nRelated PR https://github.com/dotnet/corefx/pull/30996\r\n\r\nWill contact the shiproom regarding this soon (after ci is green)","created_at":"2018-07-13T05:06:35Z","updated_at":"2018-07-13T12:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"553e1e59c369bf7e4ff1671669b3a964982c221d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/31046/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/31046/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/31046/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/493dacf9a5f07dc29fb0350876cf15a7aea06f78","head":{"label":"Anipik:releaseFixTest","ref":"releaseFixTest","sha":"493dacf9a5f07dc29fb0350876cf15a7aea06f78","user":{"login":"Anipik","id":10516582,"node_id":"MDQ6VXNlcjEwNTE2NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10516582?v=4","gravatar_id":"","url":"https://api.github.com/users/Anipik","html_url":"https://github.com/Anipik","followers_url":"https://api.github.com/users/Anipik/followers","following_url":"https://api.github.com/users/Anipik/following{/other_user}","gists_url":"https://api.github.com/users/Anipik/gists{/gist_id}","starred_url":"https://api.github.com/users/Anipik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anipik/subscriptions","organizations_url":"https://api.github.com/users/Anipik/orgs","repos_url":"https://api.github.com/users/Anipik/repos","events_url":"https://api.github.com/users/Anipik/events{/privacy}","received_events_url":"https://api.github.com/users/Anipik/received_events","type":"User","site_admin":false},"repo":{"id":104249984,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQyNDk5ODQ=","name":"corefx","full_name":"Anipik/corefx","owner":{"login":"Anipik","id":10516582,"node_id":"MDQ6VXNlcjEwNTE2NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10516582?v=4","gravatar_id":"","url":"https://api.github.com/users/Anipik","html_url":"https://github.com/Anipik","followers_url":"https://api.github.com/users/Anipik/followers","following_url":"https://api.github.com/users/Anipik/following{/other_user}","gists_url":"https://api.github.com/users/Anipik/gists{/gist_id}","starred_url":"https://api.github.com/users/Anipik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anipik/subscriptions","organizations_url":"https://api.github.com/users/Anipik/orgs","repos_url":"https://api.github.com/users/Anipik/repos","events_url":"https://api.github.com/users/Anipik/events{/privacy}","received_events_url":"https://api.github.com/users/Anipik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Anipik/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/Anipik/corefx","forks_url":"https://api.github.com/repos/Anipik/corefx/forks","keys_url":"https://api.github.com/repos/Anipik/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anipik/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anipik/corefx/teams","hooks_url":"https://api.github.com/repos/Anipik/corefx/hooks","issue_events_url":"https://api.github.com/repos/Anipik/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Anipik/corefx/events","assignees_url":"https://api.github.com/repos/Anipik/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Anipik/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Anipik/corefx/tags","blobs_url":"https://api.github.com/repos/Anipik/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anipik/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anipik/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anipik/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anipik/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Anipik/corefx/languages","stargazers_url":"https://api.github.com/repos/Anipik/corefx/stargazers","contributors_url":"https://api.github.com/repos/Anipik/corefx/contributors","subscribers_url":"https://api.github.com/repos/Anipik/corefx/subscribers","subscription_url":"https://api.github.com/repos/Anipik/corefx/subscription","commits_url":"https://api.github.com/repos/Anipik/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anipik/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anipik/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anipik/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anipik/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Anipik/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anipik/corefx/merges","archive_url":"https://api.github.com/repos/Anipik/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anipik/corefx/downloads","issues_url":"https://api.github.com/repos/Anipik/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Anipik/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Anipik/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Anipik/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anipik/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Anipik/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/Anipik/corefx/deployments","created_at":"2017-09-20T17:59:22Z","updated_at":"2018-07-13T04:51:39Z","pushed_at":"2018-07-13T05:03:25Z","git_url":"git://github.com/Anipik/corefx.git","ssh_url":"git@github.com:Anipik/corefx.git","clone_url":"https://github.com/Anipik/corefx.git","svn_url":"https://github.com/Anipik/corefx","homepage":"https://github.com/dotnet/core","size":182850,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:release/2.1","ref":"release/2.1","sha":"44454c1cba74632430e71a7222f2cf627991c217","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-07-13T11:51:19Z","pushed_at":"2018-07-13T11:55:18Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":183668,"stargazers_count":14365,"watchers_count":14365,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4156,"mirror_url":null,"archived":false,"open_issues_count":2398,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4156,"open_issues":2398,"watchers":14365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31046"},"html":{"href":"https://github.com/dotnet/corefx/pull/31046"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31046"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/31046/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31046/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/31046/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/493dacf9a5f07dc29fb0350876cf15a7aea06f78"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stephentoub"}}