{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/5106","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/5106/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/5106/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/5106/events","html_url":"https://github.com/kubernetes/kops/pull/5106","id":320458096,"number":5106,"title":"Add `useRawManifest` hook option to install `manifest` as a hook unmodified","user":{"login":"geekofalltrades","id":6486742,"avatar_url":"https://avatars1.githubusercontent.com/u/6486742?v=4","gravatar_id":"","url":"https://api.github.com/users/geekofalltrades","html_url":"https://github.com/geekofalltrades","followers_url":"https://api.github.com/users/geekofalltrades/followers","following_url":"https://api.github.com/users/geekofalltrades/following{/other_user}","gists_url":"https://api.github.com/users/geekofalltrades/gists{/gist_id}","starred_url":"https://api.github.com/users/geekofalltrades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekofalltrades/subscriptions","organizations_url":"https://api.github.com/users/geekofalltrades/orgs","repos_url":"https://api.github.com/users/geekofalltrades/repos","events_url":"https://api.github.com/users/geekofalltrades/events{/privacy}","received_events_url":"https://api.github.com/users/geekofalltrades/received_events","type":"User","site_admin":false},"labels":[{"id":485059331,"url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":583153471,"url":"https://api.github.com/repos/kubernetes/kops/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676485644,"url":"https://api.github.com/repos/kubernetes/kops/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-04T23:32:29Z","updated_at":"2018-05-04T23:34:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/5106","html_url":"https://github.com/kubernetes/kops/pull/5106","diff_url":"https://github.com/kubernetes/kops/pull/5106.diff","patch_url":"https://github.com/kubernetes/kops/pull/5106.patch"},"body":"Fixes #4764 \r\n\r\nI've added a `useRawManifest` option to the hook spec which causes the `manifest` to\r\nbe installed as a systemd unit with no modifications.\r\n\r\nI've also changed the logic around naming of the unit files. Where previously the hook\r\nsystem would append \".service\" to the name of the unit file if it didn't end in \".service\" or\r\n\".timer\", it now instead checks for any valid systemd unit file extension. It still appends\r\n\".service\" if no valid extension is found, to maintain backwards compatibility. Note that\r\nthis could break backwards-compatibility for users who are relying on the \".service\"\r\nextension for hooks with names that overlap the set of systemd extensions; for example,\r\na hook named \"my-hook.slice\" will no longer be installed as \"my-hook.slice.service\",\r\nbecause \".slice\" is a valid unit file extension.\r\n\r\nThe change is accompanied by updated documentation and unit tests around the\r\nextension change.\r\n\r\nWe're using this change in our fork to add systemd-managed swapfiles to some of our\r\nnodes."},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/386760277","html_url":"https://github.com/kubernetes/kops/pull/5106#issuecomment-386760277","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/5106","id":386760277,"user":{"login":"geekofalltrades","id":6486742,"avatar_url":"https://avatars1.githubusercontent.com/u/6486742?v=4","gravatar_id":"","url":"https://api.github.com/users/geekofalltrades","html_url":"https://github.com/geekofalltrades","followers_url":"https://api.github.com/users/geekofalltrades/followers","following_url":"https://api.github.com/users/geekofalltrades/following{/other_user}","gists_url":"https://api.github.com/users/geekofalltrades/gists{/gist_id}","starred_url":"https://api.github.com/users/geekofalltrades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekofalltrades/subscriptions","organizations_url":"https://api.github.com/users/geekofalltrades/orgs","repos_url":"https://api.github.com/users/geekofalltrades/repos","events_url":"https://api.github.com/users/geekofalltrades/events{/privacy}","received_events_url":"https://api.github.com/users/geekofalltrades/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T23:34:28Z","updated_at":"2018-05-04T23:34:28Z","author_association":"NONE","body":"ExtraHop Networks have signed the linuxfoundation CLA. I'm unsure what steps I specifically need to take to demonstrate that I'm authorized to submit this PR."}}
{"actor":{"display_login":"geekofalltrades"}}