{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/171538223","pull_request_review_id":100406188,"id":171538223,"diff_hunk":"@@ -0,0 +1,127 @@\n+cmake_minimum_required(VERSION 3.1)\n+\n+# Check to see if we are inside ROOT\n+if(EXISTS \"${CMAKE_CURRENT_SOURCE_DIR}/../../../build/version_number\")\n+    option(MAKE_STANDALONE \"Copy in the files from the main ROOT files\" ON)\n+    message(STATUS \"Copying in files from ROOT sources to standalone directory\")\n+else()\n+    option(MAKE_STANDALONE \"Copy in the files from the main ROOT files\" OFF)\n+endif()\n+\n+# This file adds copy_standalone\n+include(copy_standalone.cmake)\n+\n+# If MAKE_STANDALONE, copy these files in\n+copy_standalone(../../../build . version_number)\n+copy_standalone(../../.. . LICENSE LGPL2_1.txt)\n+\n+file(READ ${CMAKE_SOURCE_DIR}/version_number versionstr)\n+string(STRIP ${versionstr} versionstr)\n+string(REGEX REPLACE \"([0-9]+[.][0-9]+)[/]([0-9]+)\" \"\\\\1.\\\\2\" versionstr ${versionstr})\n+\n+project(Minuit2\n+    VERSION ${versionstr}\n+    LANGUAGES CXX)\n+\n+\n+# Inherit default from parent project if not main project\n+if(CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)","path":"math/minuit2/standalone/CMakeLists.txt","position":28,"original_position":28,"commit_id":"0446bd1ff44d603177631262ba8e10914ed0e138","original_commit_id":"0446bd1ff44d603177631262ba8e10914ed0e138","user":{"login":"henryiii","id":4616906,"avatar_url":"https://avatars1.githubusercontent.com/u/4616906?v=4","gravatar_id":"","url":"https://api.github.com/users/henryiii","html_url":"https://github.com/henryiii","followers_url":"https://api.github.com/users/henryiii/followers","following_url":"https://api.github.com/users/henryiii/following{/other_user}","gists_url":"https://api.github.com/users/henryiii/gists{/gist_id}","starred_url":"https://api.github.com/users/henryiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryiii/subscriptions","organizations_url":"https://api.github.com/users/henryiii/orgs","repos_url":"https://api.github.com/users/henryiii/repos","events_url":"https://api.github.com/users/henryiii/events{/privacy}","received_events_url":"https://api.github.com/users/henryiii/received_events","type":"User","site_admin":false},"body":"No, building as part of a project that is not ROOT is supported, using `add_subdirectory(Minuit2)`. ","created_at":"2018-03-01T12:03:41Z","updated_at":"2018-03-01T12:03:41Z","html_url":"https://github.com/root-project/root/pull/1680#discussion_r171538223","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/1680","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/171538223"},"html":{"href":"https://github.com/root-project/root/pull/1680#discussion_r171538223"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/1680"}},"in_reply_to_id":171513761},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1680","id":171932144,"html_url":"https://github.com/root-project/root/pull/1680","diff_url":"https://github.com/root-project/root/pull/1680.diff","patch_url":"https://github.com/root-project/root/pull/1680.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/1680","number":1680,"state":"open","locked":false,"title":"Adding new version of Minuit2 standalone with CMake build","user":{"login":"henryiii","id":4616906,"avatar_url":"https://avatars1.githubusercontent.com/u/4616906?v=4","gravatar_id":"","url":"https://api.github.com/users/henryiii","html_url":"https://github.com/henryiii","followers_url":"https://api.github.com/users/henryiii/followers","following_url":"https://api.github.com/users/henryiii/following{/other_user}","gists_url":"https://api.github.com/users/henryiii/gists{/gist_id}","starred_url":"https://api.github.com/users/henryiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryiii/subscriptions","organizations_url":"https://api.github.com/users/henryiii/orgs","repos_url":"https://api.github.com/users/henryiii/repos","events_url":"https://api.github.com/users/henryiii/events{/privacy}","received_events_url":"https://api.github.com/users/henryiii/received_events","type":"User","site_admin":false},"body":"This adds a new standalone Minuit2 build system built in CMake to replace the old one that no longer works. The following features are part of the design:\r\n\r\n* Full featured CMake build, based on https://github.com/GooFit/Minuit2\r\n    - Only requires CMake 3.1+\r\n    - Support for adding as a subdirectory, using from build directory, or installing\r\n    - Support for CPack\r\n    - Options for MPI and OpenMP\r\n    - Support for macOS, Linux (and potentially Windows)\r\n* No changes to ROOT outside of new `/math/minuit2/standalone` folder\r\n    - Version captured from ROOT\r\n    - `make purge` can remove copied files\r\n* No need for extra \"prepare\" shell scripts, everything is done cross-platform through CMake and CPack\r\n* Eventually can remove broken scripts in `/math/minuit2/build`(this is a full replacement)\r\n* Helpful `README.md` and `DEVELOP.md` files\r\n\r\n### To produce a source distribution:\r\nMake sure you have CMake 3.1+ (ROOT requires 3.4.3+, so that's likely). Then, from `/math/minuit2/standalone/build` run:\r\n\r\n```bash\r\ncmake .. -DMAKE_STANDALONE=ON\r\nmake package_source\r\n```\r\n\r\nThe `MAKE_STANDALONE` part is optional; CMake will detect it is in the ROOT source and will activate this option for you.\r\n\r\n### You can also build Minuit2 for testing with:\r\n\r\n```\r\nmake\r\n```\r\n\r\n### And you can make a prebuilt binary package with:\r\n\r\n```\r\nmake package\r\n```\r\n\r\n(Standard CPack option for different generators apply.)\r\n\r\n### Maintenence\r\n\r\nAll CMake files are stored in the `standalone` directory. If new files are needed by Minuit2 due to additions to ROOT, they should be added to the source files lists in `/math/minuit2/standalone/src/Math/CMakeLists.txt` and `/math/minuit2/standalone/src/Minuit2/CMakeLists.txt` (depending on if it's a new Math or Minuit2 requirement).\r\n\r\n\r\n### Windows\r\nThis *almost* works on Windows; adding one missing `#include <string>` to ROOT fixes the build on Windows; and you can even then create binary installers for Windows trivially. (Though \"package_source\" does not seem to be supported on Windows). I can add that fix as a separate patch. For now, this is the procedure on Windows:\r\n\r\nFirst, install Visual Studio 17, Git, CMake, and NSIS. Then from the `standalone/build directory` of your ROOT checkout, run:\r\n\r\n```\r\n\"C:\\Program Files\\CMake\\bin\\cmake.exe\" ..\r\n\"C:\\Program Files\\CMake\\bin\\cmake.exe\" --build .\r\n\"C:\\Program Files\\CMake\\bin\\cmake.exe\" --build . --target package\r\n```\r\n\r\nThis creates a `.exe` installer file.","created_at":"2018-02-28T11:54:16Z","updated_at":"2018-03-01T12:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e4377f650304ead34a0dceaa0fd958767975ebf","assignee":{"login":"amadio","id":249404,"avatar_url":"https://avatars2.githubusercontent.com/u/249404?v=4","gravatar_id":"","url":"https://api.github.com/users/amadio","html_url":"https://github.com/amadio","followers_url":"https://api.github.com/users/amadio/followers","following_url":"https://api.github.com/users/amadio/following{/other_user}","gists_url":"https://api.github.com/users/amadio/gists{/gist_id}","starred_url":"https://api.github.com/users/amadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amadio/subscriptions","organizations_url":"https://api.github.com/users/amadio/orgs","repos_url":"https://api.github.com/users/amadio/repos","events_url":"https://api.github.com/users/amadio/events{/privacy}","received_events_url":"https://api.github.com/users/amadio/received_events","type":"User","site_admin":false},"assignees":[{"login":"amadio","id":249404,"avatar_url":"https://avatars2.githubusercontent.com/u/249404?v=4","gravatar_id":"","url":"https://api.github.com/users/amadio","html_url":"https://github.com/amadio","followers_url":"https://api.github.com/users/amadio/followers","following_url":"https://api.github.com/users/amadio/following{/other_user}","gists_url":"https://api.github.com/users/amadio/gists{/gist_id}","starred_url":"https://api.github.com/users/amadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amadio/subscriptions","organizations_url":"https://api.github.com/users/amadio/orgs","repos_url":"https://api.github.com/users/amadio/repos","events_url":"https://api.github.com/users/amadio/events{/privacy}","received_events_url":"https://api.github.com/users/amadio/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lmoneta","id":5213559,"avatar_url":"https://avatars1.githubusercontent.com/u/5213559?v=4","gravatar_id":"","url":"https://api.github.com/users/lmoneta","html_url":"https://github.com/lmoneta","followers_url":"https://api.github.com/users/lmoneta/followers","following_url":"https://api.github.com/users/lmoneta/following{/other_user}","gists_url":"https://api.github.com/users/lmoneta/gists{/gist_id}","starred_url":"https://api.github.com/users/lmoneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmoneta/subscriptions","organizations_url":"https://api.github.com/users/lmoneta/orgs","repos_url":"https://api.github.com/users/lmoneta/repos","events_url":"https://api.github.com/users/lmoneta/events{/privacy}","received_events_url":"https://api.github.com/users/lmoneta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/1680/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/1680/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/1680/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/0446bd1ff44d603177631262ba8e10914ed0e138","head":{"label":"henryiii:minuit2standalone","ref":"minuit2standalone","sha":"0446bd1ff44d603177631262ba8e10914ed0e138","user":{"login":"henryiii","id":4616906,"avatar_url":"https://avatars1.githubusercontent.com/u/4616906?v=4","gravatar_id":"","url":"https://api.github.com/users/henryiii","html_url":"https://github.com/henryiii","followers_url":"https://api.github.com/users/henryiii/followers","following_url":"https://api.github.com/users/henryiii/following{/other_user}","gists_url":"https://api.github.com/users/henryiii/gists{/gist_id}","starred_url":"https://api.github.com/users/henryiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryiii/subscriptions","organizations_url":"https://api.github.com/users/henryiii/orgs","repos_url":"https://api.github.com/users/henryiii/repos","events_url":"https://api.github.com/users/henryiii/events{/privacy}","received_events_url":"https://api.github.com/users/henryiii/received_events","type":"User","site_admin":false},"repo":{"id":122329204,"name":"root","full_name":"henryiii/root","owner":{"login":"henryiii","id":4616906,"avatar_url":"https://avatars1.githubusercontent.com/u/4616906?v=4","gravatar_id":"","url":"https://api.github.com/users/henryiii","html_url":"https://github.com/henryiii","followers_url":"https://api.github.com/users/henryiii/followers","following_url":"https://api.github.com/users/henryiii/following{/other_user}","gists_url":"https://api.github.com/users/henryiii/gists{/gist_id}","starred_url":"https://api.github.com/users/henryiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryiii/subscriptions","organizations_url":"https://api.github.com/users/henryiii/orgs","repos_url":"https://api.github.com/users/henryiii/repos","events_url":"https://api.github.com/users/henryiii/events{/privacy}","received_events_url":"https://api.github.com/users/henryiii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henryiii/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/henryiii/root","forks_url":"https://api.github.com/repos/henryiii/root/forks","keys_url":"https://api.github.com/repos/henryiii/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henryiii/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henryiii/root/teams","hooks_url":"https://api.github.com/repos/henryiii/root/hooks","issue_events_url":"https://api.github.com/repos/henryiii/root/issues/events{/number}","events_url":"https://api.github.com/repos/henryiii/root/events","assignees_url":"https://api.github.com/repos/henryiii/root/assignees{/user}","branches_url":"https://api.github.com/repos/henryiii/root/branches{/branch}","tags_url":"https://api.github.com/repos/henryiii/root/tags","blobs_url":"https://api.github.com/repos/henryiii/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henryiii/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henryiii/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/henryiii/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henryiii/root/statuses/{sha}","languages_url":"https://api.github.com/repos/henryiii/root/languages","stargazers_url":"https://api.github.com/repos/henryiii/root/stargazers","contributors_url":"https://api.github.com/repos/henryiii/root/contributors","subscribers_url":"https://api.github.com/repos/henryiii/root/subscribers","subscription_url":"https://api.github.com/repos/henryiii/root/subscription","commits_url":"https://api.github.com/repos/henryiii/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/henryiii/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/henryiii/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/henryiii/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/henryiii/root/contents/{+path}","compare_url":"https://api.github.com/repos/henryiii/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henryiii/root/merges","archive_url":"https://api.github.com/repos/henryiii/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henryiii/root/downloads","issues_url":"https://api.github.com/repos/henryiii/root/issues{/number}","pulls_url":"https://api.github.com/repos/henryiii/root/pulls{/number}","milestones_url":"https://api.github.com/repos/henryiii/root/milestones{/number}","notifications_url":"https://api.github.com/repos/henryiii/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henryiii/root/labels{/name}","releases_url":"https://api.github.com/repos/henryiii/root/releases{/id}","deployments_url":"https://api.github.com/repos/henryiii/root/deployments","created_at":"2018-02-21T11:42:43Z","updated_at":"2018-02-21T11:43:44Z","pushed_at":"2018-03-01T10:14:46Z","git_url":"git://github.com/henryiii/root.git","ssh_url":"git@github.com:henryiii/root.git","clone_url":"https://github.com/henryiii/root.git","svn_url":"https://github.com/henryiii/root","homepage":"","size":684670,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"463aecee387b285b296f8f72d5673115ac653df9","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-03-01T05:54:48Z","pushed_at":"2018-03-01T10:30:57Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":684667,"stargazers_count":511,"watchers_count":511,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":366,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":366,"open_issues":51,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/1680"},"html":{"href":"https://github.com/root-project/root/pull/1680"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/1680"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/1680/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/1680/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/1680/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/0446bd1ff44d603177631262ba8e10914ed0e138"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"henryiii"}}