{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/comments/182287966","pull_request_review_id":113052357,"id":182287966,"diff_hunk":"@@ -105,8 +105,8 @@ def trigger\n       when Win32::TaskScheduler::TASK_TIME_TRIGGER_ONCE\n         puppet_trigger['schedule'] = 'once'\n       end\n-      puppet_trigger['start_date'] = self.class.normalized_date(trigger['start_year'], trigger['start_month'], trigger['start_day'])\n-      puppet_trigger['start_time'] = self.class.normalized_time(trigger['start_hour'], trigger['start_minute'])\n+      puppet_trigger['start_date'] = PuppetX::PuppetLabs::ScheduledTask::Trigger::V1.normalized_date(trigger['start_year'], trigger['start_month'], trigger['start_day'])","path":"lib/puppet/provider/scheduled_task/taskscheduler_api2.rb","position":null,"original_position":6,"commit_id":"5f010885b68496e63fc1b57d70efb6db66290c8e","original_commit_id":"8d98fb9d4596728535a023b99a574225b01ef47d","user":{"login":"glennsarti","id":5819622,"avatar_url":"https://avatars0.githubusercontent.com/u/5819622?v=4","gravatar_id":"","url":"https://api.github.com/users/glennsarti","html_url":"https://github.com/glennsarti","followers_url":"https://api.github.com/users/glennsarti/followers","following_url":"https://api.github.com/users/glennsarti/following{/other_user}","gists_url":"https://api.github.com/users/glennsarti/gists{/gist_id}","starred_url":"https://api.github.com/users/glennsarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennsarti/subscriptions","organizations_url":"https://api.github.com/users/glennsarti/orgs","repos_url":"https://api.github.com/users/glennsarti/repos","events_url":"https://api.github.com/users/glennsarti/events{/privacy}","received_events_url":"https://api.github.com/users/glennsarti/received_events","type":"User","site_admin":false},"body":"Typo in commit message ((MODULES-6895) Move normalized helpers to V1 class): \"codd\" -> \"code\"","created_at":"2018-04-18T01:41:11Z","updated_at":"2018-04-18T02:04:13Z","html_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task/pull/21#discussion_r182287966","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/comments/182287966"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-scheduled_task/pull/21#discussion_r182287966"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21","id":176642846,"html_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task/pull/21","diff_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task/pull/21.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task/pull/21.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues/21","number":21,"state":"open","locked":false,"title":"(WIP)(MODULES-6895) Refactor provider code to Trigger","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":" - Move the bitfield_from_days_of_week method from the provider code\r\n   to the Trigger helpers, specifically adding the helper to a new\r\n   Day class.\r\n\r\n   Include V1 TASK_XXX day constants in the Day class so that its\r\n   not necessary to refer to WIN32::TaskScheduler constants, which\r\n   requires loading Windows guarded code\r\n\r\n   Simplify name -> constant lookup by using a Hash\r\n\r\n - Adjust single spec looking for Puppet::Error, given the Day class\r\n   cannot use those errors and must use ArgumentError instead.","created_at":"2018-03-22T00:08:43Z","updated_at":"2018-04-18T02:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30d68e8482587ed0cde87ed46949c8f87a5f764d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues/21/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/statuses/5f010885b68496e63fc1b57d70efb6db66290c8e","head":{"label":"Iristyle:MODULES-6895-refactor-provider-helpers-to-Trigger","ref":"MODULES-6895-refactor-provider-helpers-to-Trigger","sha":"5f010885b68496e63fc1b57d70efb6db66290c8e","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"repo":{"id":113514543,"name":"puppetlabs-scheduled_task","full_name":"Iristyle/puppetlabs-scheduled_task","owner":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Iristyle/puppetlabs-scheduled_task","description":"Manage Scheduled Tasks on Windows 2008 and above","fork":true,"url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task","forks_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/forks","keys_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/teams","hooks_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/hooks","issue_events_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/issues/events{/number}","events_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/events","assignees_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/assignees{/user}","branches_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/branches{/branch}","tags_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/tags","blobs_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/git/refs{/sha}","trees_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/statuses/{sha}","languages_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/languages","stargazers_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/stargazers","contributors_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/contributors","subscribers_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/subscribers","subscription_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/subscription","commits_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/commits{/sha}","git_commits_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/git/commits{/sha}","comments_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/comments{/number}","issue_comment_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/issues/comments{/number}","contents_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/contents/{+path}","compare_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/merges","archive_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/downloads","issues_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/issues{/number}","pulls_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/pulls{/number}","milestones_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/milestones{/number}","notifications_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/labels{/name}","releases_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/releases{/id}","deployments_url":"https://api.github.com/repos/Iristyle/puppetlabs-scheduled_task/deployments","created_at":"2017-12-08T00:59:24Z","updated_at":"2017-12-08T00:59:26Z","pushed_at":"2018-04-17T18:53:57Z","git_url":"git://github.com/Iristyle/puppetlabs-scheduled_task.git","ssh_url":"git@github.com:Iristyle/puppetlabs-scheduled_task.git","clone_url":"https://github.com/Iristyle/puppetlabs-scheduled_task.git","svn_url":"https://github.com/Iristyle/puppetlabs-scheduled_task","homepage":null,"size":401,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"a890f347387d7677496a365a64ac642328ffd7c4","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":113345451,"name":"puppetlabs-scheduled_task","full_name":"puppetlabs/puppetlabs-scheduled_task","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task","description":"Manage Scheduled Tasks on Windows 2008 and above","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/deployments","created_at":"2017-12-06T17:14:34Z","updated_at":"2018-04-16T18:44:26Z","pushed_at":"2018-04-17T18:53:59Z","git_url":"git://github.com/puppetlabs/puppetlabs-scheduled_task.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-scheduled_task.git","clone_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task.git","svn_url":"https://github.com/puppetlabs/puppetlabs-scheduled_task","homepage":null,"size":360,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-scheduled_task/pull/21"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues/21"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-scheduled_task/statuses/5f010885b68496e63fc1b57d70efb6db66290c8e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"glennsarti"}}