{"action":"closed","issue":{"url":"https://api.github.com/repos/socketio/socket.io/issues/3190","repository_url":"https://api.github.com/repos/socketio/socket.io","labels_url":"https://api.github.com/repos/socketio/socket.io/issues/3190/labels{/name}","comments_url":"https://api.github.com/repos/socketio/socket.io/issues/3190/comments","events_url":"https://api.github.com/repos/socketio/socket.io/issues/3190/events","html_url":"https://github.com/socketio/socket.io/issues/3190","id":301996480,"number":3190,"title":"io.origins() does not take an array of strings ","user":{"login":"stnwk","id":2981250,"avatar_url":"https://avatars0.githubusercontent.com/u/2981250?v=4","gravatar_id":"","url":"https://api.github.com/users/stnwk","html_url":"https://github.com/stnwk","followers_url":"https://api.github.com/users/stnwk/followers","following_url":"https://api.github.com/users/stnwk/following{/other_user}","gists_url":"https://api.github.com/users/stnwk/gists{/gist_id}","starred_url":"https://api.github.com/users/stnwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stnwk/subscriptions","organizations_url":"https://api.github.com/users/stnwk/orgs","repos_url":"https://api.github.com/users/stnwk/repos","events_url":"https://api.github.com/users/stnwk/events{/privacy}","received_events_url":"https://api.github.com/users/stnwk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-03T13:00:15Z","updated_at":"2018-03-05T10:22:54Z","closed_at":"2018-03-05T10:22:53Z","author_association":"NONE","body":"### You want to:\r\n\r\n* [x] report a *bug*\r\n* [ ] request a *feature*\r\n\r\n### Current behaviour\r\nIn the documentation it states, that `io.origins()` takes an array of strings/origins (see example https://socket.io/docs/server-api/#server-origins-value), when in fact it does not. It only works when providing a string instead of an array.\r\n\r\n### Steps to reproduce (if the current behaviour is a bug)\r\nSetting \r\n```jsx\r\nio.origins(['http://localhost:3000'])\r\n```\r\nand then connecting from `localhost:3000` does not work.\r\n\r\nIt only works when setting `io.origins('http://localhost:3000')`\r\n\r\n### Expected behaviour\r\n\r\n\r\n### Setup\r\n- OS: macOS High Sierra 10.13.3\r\n- browser: Chrome 64.0.3282.186\r\n- socket.io version: 2.0.4\r\n"}}
{"actor":{"display_login":"stnwk"}}