{"action":"opened","issue":{"url":"https://api.github.com/repos/jetstack/tarmak/issues/368","repository_url":"https://api.github.com/repos/jetstack/tarmak","labels_url":"https://api.github.com/repos/jetstack/tarmak/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/tarmak/issues/368/comments","events_url":"https://api.github.com/repos/jetstack/tarmak/issues/368/events","html_url":"https://github.com/jetstack/tarmak/issues/368","id":341467733,"node_id":"MDU6SXNzdWUzNDE0Njc3MzM=","number":368,"title":"Add labels & taints option to instance pool config","user":{"login":"charlieegan3","id":1774239,"node_id":"MDQ6VXNlcjE3NzQyMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1774239?v=4","gravatar_id":"","url":"https://api.github.com/users/charlieegan3","html_url":"https://github.com/charlieegan3","followers_url":"https://api.github.com/users/charlieegan3/followers","following_url":"https://api.github.com/users/charlieegan3/following{/other_user}","gists_url":"https://api.github.com/users/charlieegan3/gists{/gist_id}","starred_url":"https://api.github.com/users/charlieegan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlieegan3/subscriptions","organizations_url":"https://api.github.com/users/charlieegan3/orgs","repos_url":"https://api.github.com/users/charlieegan3/repos","events_url":"https://api.github.com/users/charlieegan3/events{/privacy}","received_events_url":"https://api.github.com/users/charlieegan3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-16T10:37:51Z","updated_at":"2018-07-16T10:37:51Z","closed_at":null,"author_association":"MEMBER","body":"**Is this a BUG REPORT or FEATURE REQUEST?**:\r\n/kind feature\r\n\r\n**What happened**:\r\nIt is not possible to add Taints or Labels to nodes in Tarmak instance pools from tarmak.yaml.\r\n\r\n**What you expected to happen**:\r\nI'd expect to be able to configure it something like this:\r\n\r\n```\r\n  instancePools:\r\n  - image: centos-puppet-agent\r\n    maxCount: 1\r\n    metadata:\r\n      creationTimestamp: \"2018-05-09T11:27:35Z\"\r\n      name: worker\r\n    minCount: 3\r\n    ***\r\n    labels:\r\n    - key: label_name\r\n      value: label_value\r\n    taints\r\n    - key: taint_name\r\n      value: taint_value\r\n      effect: taint_effect\r\n    ***\r\n    size: large\r\n    type: worker\r\n    ...\r\n```\r\n\r\n**Anything else we need to know?**:\r\n\r\nWe already have this in the puppet config here: https://github.com/jetstack/tarmak/tree/master/puppet/modules/kubernetes#node_labels\r\n\r\nWe also appear to have taints down as a kubelet param here: https://github.com/jetstack/tarmak/blob/master/puppet/modules/kubernetes/templates/kubelet.service.erb#L17\r\n\r\n"}}
{"actor":{"display_login":"charlieegan3"}}