{"action":"created","comment":{"url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/comments/174534280","pull_request_review_id":103909217,"id":174534280,"diff_hunk":"@@ -153,72 +223,73 @@ protected function config()\n     {\n         return array(\n             'paypal' => array(\n+                'is_form' => false,\n                 'tab' => $this->l('PayPal'),\n                 'fields' => array(\n                     array(\n                         'name' => 'enable_method',\n-                        'label' => $this->l('Enable'),\n+                        _LABEL_ => $this->l('Enable'),\n                         'default' => '0',\n                         'type' => 'onoff'\n                     ),\n                     array(\n-                        'name' => 'wirecard_server_url',\n-                        'label' => $this->l('URL of Wirecard server'),\n+                        'name' => '_WIRECARD_TEST_URL_',\n+                        _LABEL_ => $this->l('_WIRECARD_LABEL_URL_TEXT_'),\n                         'type' => 'text',\n                         'default' => 'https://api-test.wirecard.com',\n                         'required' => true,\n                         'sanitize' => 'trim'\n                     ),\n                     array(\n                         'name' => 'maid',\n-                        'label' => $this->l('MAID'),\n+                        _LABEL_ => $this->l('MAID'),\n                         'type' => 'text',\n                         'default' => '9abf05c1-c266-46ae-8eac-7f87ca97af28',\n                         'required' => true,\n                         'sanitize' => 'trim'\n                     ),\n                     array(\n-                        'name' => 'secret',\n-                        'label' => $this->l('Secret'),\n+                        'name' => _SECRET_,\n+                        _LABEL_ => $this->l(_SECRET_),\n                         'type' => 'text',\n                         'default' => 'dbc5a498-9a66-43b9-bf1d-a618dd399684',\n                         'required' => true,\n                         'sanitize' => 'trim'\n                     ),\n                     array(\n-                        'name' => 'http_user',\n-                        'label' => $this->l('HTTP user'),\n+                        'name' => _HTTP_USER_,\n+                        _LABEL_ => $this->l('HTTP user'),","path":"wirecardpaymentgateway/wirecardpaymentgateway.php","position":210,"original_position":210,"commit_id":"71f2a0b75830a7270dc12ac303b880bad6945aec","original_commit_id":"71f2a0b75830a7270dc12ac303b880bad6945aec","user":{"login":"wirecard-bot","id":19989513,"avatar_url":"https://avatars1.githubusercontent.com/u/19989513?v=4","gravatar_id":"","url":"https://api.github.com/users/wirecard-bot","html_url":"https://github.com/wirecard-bot","followers_url":"https://api.github.com/users/wirecard-bot/followers","following_url":"https://api.github.com/users/wirecard-bot/following{/other_user}","gists_url":"https://api.github.com/users/wirecard-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wirecard-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wirecard-bot/subscriptions","organizations_url":"https://api.github.com/users/wirecard-bot/orgs","repos_url":"https://api.github.com/users/wirecard-bot/repos","events_url":"https://api.github.com/users/wirecard-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wirecard-bot/received_events","type":"User","site_admin":false},"body":"![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Define a constant instead of duplicating this literal \"HTTP user\" 6 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS1192)\n","created_at":"2018-03-14T17:00:02Z","updated_at":"2018-03-14T17:00:02Z","html_url":"https://github.com/wirecard/prestashop-ee/pull/35#discussion_r174534280","pull_request_url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/comments/174534280"},"html":{"href":"https://github.com/wirecard/prestashop-ee/pull/35#discussion_r174534280"},"pull_request":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35","id":171255297,"html_url":"https://github.com/wirecard/prestashop-ee/pull/35","diff_url":"https://github.com/wirecard/prestashop-ee/pull/35.diff","patch_url":"https://github.com/wirecard/prestashop-ee/pull/35.patch","issue_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35","number":35,"state":"open","locked":false,"title":"#34 Refactored Code to move out of controller","user":{"login":"just-in-m","id":35484291,"avatar_url":"https://avatars3.githubusercontent.com/u/35484291?v=4","gravatar_id":"","url":"https://api.github.com/users/just-in-m","html_url":"https://github.com/just-in-m","followers_url":"https://api.github.com/users/just-in-m/followers","following_url":"https://api.github.com/users/just-in-m/following{/other_user}","gists_url":"https://api.github.com/users/just-in-m/gists{/gist_id}","starred_url":"https://api.github.com/users/just-in-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/just-in-m/subscriptions","organizations_url":"https://api.github.com/users/just-in-m/orgs","repos_url":"https://api.github.com/users/just-in-m/repos","events_url":"https://api.github.com/users/just-in-m/events{/privacy}","received_events_url":"https://api.github.com/users/just-in-m/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-25T22:25:33Z","updated_at":"2018-03-14T17:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32a7de9bf4d7f1a12d731c6a8566a2fce882d0c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35/commits","review_comments_url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35/comments","review_comment_url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35/comments","statuses_url":"https://api.github.com/repos/wirecard/prestashop-ee/statuses/71f2a0b75830a7270dc12ac303b880bad6945aec","head":{"label":"wirecard:paypal-creditcard-sepa","ref":"paypal-creditcard-sepa","sha":"71f2a0b75830a7270dc12ac303b880bad6945aec","user":{"login":"wirecard","id":15652686,"avatar_url":"https://avatars3.githubusercontent.com/u/15652686?v=4","gravatar_id":"","url":"https://api.github.com/users/wirecard","html_url":"https://github.com/wirecard","followers_url":"https://api.github.com/users/wirecard/followers","following_url":"https://api.github.com/users/wirecard/following{/other_user}","gists_url":"https://api.github.com/users/wirecard/gists{/gist_id}","starred_url":"https://api.github.com/users/wirecard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wirecard/subscriptions","organizations_url":"https://api.github.com/users/wirecard/orgs","repos_url":"https://api.github.com/users/wirecard/repos","events_url":"https://api.github.com/users/wirecard/events{/privacy}","received_events_url":"https://api.github.com/users/wirecard/received_events","type":"Organization","site_admin":false},"repo":{"id":117562792,"name":"prestashop-ee","full_name":"wirecard/prestashop-ee","owner":{"login":"wirecard","id":15652686,"avatar_url":"https://avatars3.githubusercontent.com/u/15652686?v=4","gravatar_id":"","url":"https://api.github.com/users/wirecard","html_url":"https://github.com/wirecard","followers_url":"https://api.github.com/users/wirecard/followers","following_url":"https://api.github.com/users/wirecard/following{/other_user}","gists_url":"https://api.github.com/users/wirecard/gists{/gist_id}","starred_url":"https://api.github.com/users/wirecard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wirecard/subscriptions","organizations_url":"https://api.github.com/users/wirecard/orgs","repos_url":"https://api.github.com/users/wirecard/repos","events_url":"https://api.github.com/users/wirecard/events{/privacy}","received_events_url":"https://api.github.com/users/wirecard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wirecard/prestashop-ee","description":null,"fork":false,"url":"https://api.github.com/repos/wirecard/prestashop-ee","forks_url":"https://api.github.com/repos/wirecard/prestashop-ee/forks","keys_url":"https://api.github.com/repos/wirecard/prestashop-ee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wirecard/prestashop-ee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wirecard/prestashop-ee/teams","hooks_url":"https://api.github.com/repos/wirecard/prestashop-ee/hooks","issue_events_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/events{/number}","events_url":"https://api.github.com/repos/wirecard/prestashop-ee/events","assignees_url":"https://api.github.com/repos/wirecard/prestashop-ee/assignees{/user}","branches_url":"https://api.github.com/repos/wirecard/prestashop-ee/branches{/branch}","tags_url":"https://api.github.com/repos/wirecard/prestashop-ee/tags","blobs_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/refs{/sha}","trees_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wirecard/prestashop-ee/statuses/{sha}","languages_url":"https://api.github.com/repos/wirecard/prestashop-ee/languages","stargazers_url":"https://api.github.com/repos/wirecard/prestashop-ee/stargazers","contributors_url":"https://api.github.com/repos/wirecard/prestashop-ee/contributors","subscribers_url":"https://api.github.com/repos/wirecard/prestashop-ee/subscribers","subscription_url":"https://api.github.com/repos/wirecard/prestashop-ee/subscription","commits_url":"https://api.github.com/repos/wirecard/prestashop-ee/commits{/sha}","git_commits_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/commits{/sha}","comments_url":"https://api.github.com/repos/wirecard/prestashop-ee/comments{/number}","issue_comment_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/comments{/number}","contents_url":"https://api.github.com/repos/wirecard/prestashop-ee/contents/{+path}","compare_url":"https://api.github.com/repos/wirecard/prestashop-ee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wirecard/prestashop-ee/merges","archive_url":"https://api.github.com/repos/wirecard/prestashop-ee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wirecard/prestashop-ee/downloads","issues_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues{/number}","pulls_url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls{/number}","milestones_url":"https://api.github.com/repos/wirecard/prestashop-ee/milestones{/number}","notifications_url":"https://api.github.com/repos/wirecard/prestashop-ee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wirecard/prestashop-ee/labels{/name}","releases_url":"https://api.github.com/repos/wirecard/prestashop-ee/releases{/id}","deployments_url":"https://api.github.com/repos/wirecard/prestashop-ee/deployments","created_at":"2018-01-15T15:32:09Z","updated_at":"2018-02-01T09:10:50Z","pushed_at":"2018-03-14T16:57:13Z","git_url":"git://github.com/wirecard/prestashop-ee.git","ssh_url":"git@github.com:wirecard/prestashop-ee.git","clone_url":"https://github.com/wirecard/prestashop-ee.git","svn_url":"https://github.com/wirecard/prestashop-ee","homepage":null,"size":4361,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"wirecard:master","ref":"master","sha":"6c575742e218b5c1dcb7786c25f51e7990c95fb9","user":{"login":"wirecard","id":15652686,"avatar_url":"https://avatars3.githubusercontent.com/u/15652686?v=4","gravatar_id":"","url":"https://api.github.com/users/wirecard","html_url":"https://github.com/wirecard","followers_url":"https://api.github.com/users/wirecard/followers","following_url":"https://api.github.com/users/wirecard/following{/other_user}","gists_url":"https://api.github.com/users/wirecard/gists{/gist_id}","starred_url":"https://api.github.com/users/wirecard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wirecard/subscriptions","organizations_url":"https://api.github.com/users/wirecard/orgs","repos_url":"https://api.github.com/users/wirecard/repos","events_url":"https://api.github.com/users/wirecard/events{/privacy}","received_events_url":"https://api.github.com/users/wirecard/received_events","type":"Organization","site_admin":false},"repo":{"id":117562792,"name":"prestashop-ee","full_name":"wirecard/prestashop-ee","owner":{"login":"wirecard","id":15652686,"avatar_url":"https://avatars3.githubusercontent.com/u/15652686?v=4","gravatar_id":"","url":"https://api.github.com/users/wirecard","html_url":"https://github.com/wirecard","followers_url":"https://api.github.com/users/wirecard/followers","following_url":"https://api.github.com/users/wirecard/following{/other_user}","gists_url":"https://api.github.com/users/wirecard/gists{/gist_id}","starred_url":"https://api.github.com/users/wirecard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wirecard/subscriptions","organizations_url":"https://api.github.com/users/wirecard/orgs","repos_url":"https://api.github.com/users/wirecard/repos","events_url":"https://api.github.com/users/wirecard/events{/privacy}","received_events_url":"https://api.github.com/users/wirecard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wirecard/prestashop-ee","description":null,"fork":false,"url":"https://api.github.com/repos/wirecard/prestashop-ee","forks_url":"https://api.github.com/repos/wirecard/prestashop-ee/forks","keys_url":"https://api.github.com/repos/wirecard/prestashop-ee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wirecard/prestashop-ee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wirecard/prestashop-ee/teams","hooks_url":"https://api.github.com/repos/wirecard/prestashop-ee/hooks","issue_events_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/events{/number}","events_url":"https://api.github.com/repos/wirecard/prestashop-ee/events","assignees_url":"https://api.github.com/repos/wirecard/prestashop-ee/assignees{/user}","branches_url":"https://api.github.com/repos/wirecard/prestashop-ee/branches{/branch}","tags_url":"https://api.github.com/repos/wirecard/prestashop-ee/tags","blobs_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/refs{/sha}","trees_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wirecard/prestashop-ee/statuses/{sha}","languages_url":"https://api.github.com/repos/wirecard/prestashop-ee/languages","stargazers_url":"https://api.github.com/repos/wirecard/prestashop-ee/stargazers","contributors_url":"https://api.github.com/repos/wirecard/prestashop-ee/contributors","subscribers_url":"https://api.github.com/repos/wirecard/prestashop-ee/subscribers","subscription_url":"https://api.github.com/repos/wirecard/prestashop-ee/subscription","commits_url":"https://api.github.com/repos/wirecard/prestashop-ee/commits{/sha}","git_commits_url":"https://api.github.com/repos/wirecard/prestashop-ee/git/commits{/sha}","comments_url":"https://api.github.com/repos/wirecard/prestashop-ee/comments{/number}","issue_comment_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/comments{/number}","contents_url":"https://api.github.com/repos/wirecard/prestashop-ee/contents/{+path}","compare_url":"https://api.github.com/repos/wirecard/prestashop-ee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wirecard/prestashop-ee/merges","archive_url":"https://api.github.com/repos/wirecard/prestashop-ee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wirecard/prestashop-ee/downloads","issues_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues{/number}","pulls_url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls{/number}","milestones_url":"https://api.github.com/repos/wirecard/prestashop-ee/milestones{/number}","notifications_url":"https://api.github.com/repos/wirecard/prestashop-ee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wirecard/prestashop-ee/labels{/name}","releases_url":"https://api.github.com/repos/wirecard/prestashop-ee/releases{/id}","deployments_url":"https://api.github.com/repos/wirecard/prestashop-ee/deployments","created_at":"2018-01-15T15:32:09Z","updated_at":"2018-02-01T09:10:50Z","pushed_at":"2018-03-14T16:57:13Z","git_url":"git://github.com/wirecard/prestashop-ee.git","ssh_url":"git@github.com:wirecard/prestashop-ee.git","clone_url":"https://github.com/wirecard/prestashop-ee.git","svn_url":"https://github.com/wirecard/prestashop-ee","homepage":null,"size":4361,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35"},"html":{"href":"https://github.com/wirecard/prestashop-ee/pull/35"},"issue":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35"},"comments":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/wirecard/prestashop-ee/statuses/71f2a0b75830a7270dc12ac303b880bad6945aec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wirecard-bot"}}