{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/test-unit/pulls/comments/191046303","pull_request_review_id":123554452,"id":191046303,"diff_hunk":"@@ -0,0 +1,140 @@\n+<?php\n+/**\n+ * @package\t    Joomla.UnitTest\n+ * @subpackage  Version\n+ *\n+ * @copyright   Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.\n+ * @license\t    GNU General Public License version 2 or later; see LICENSE.txt\n+ */\n+\n+/**\n+ * Test class for CheckJoomlaUpdatesCommand.\n+ *\n+ * @package     Joomla.UnitTest\n+ * @subpackage  Version\n+ * @since       3.0\n+ */\n+\n+use Joomla\\CMS\\Console\\CheckJoomlaUpdatesCommand;\n+\n+class CheckJoomlaUpdatesCommandTest extends \\PHPUnit\\Framework\\TestCase\n+{\n+\t/**\n+\t * Object under test\n+\t *\n+\t * @var    CheckJoomlaUpdatesCommand\n+\t * @since  3.0\n+\t */\n+\tprotected $object;\n+\n+\t/**\n+\t * Sets up the fixture, for example, opens a network connection.\n+\t * This method is called before a test is executed.\n+\t *\n+\t * @return  void\n+\t *\n+\t * @since   3.0\n+\t */\n+\tprotected function setUp()\n+\t{\n+\t\t$this->object = new CheckJoomlaUpdatesCommand;\n+\t}\n+\n+\t/**\n+\t * Overrides the parent tearDown method.\n+\t *\n+\t * @return  void\n+\t *\n+\t * @see     \\PHPUnit\\Framework\\TestCase::tearDown()\n+\t * @since   3.6\n+\t */\n+\tprotected function tearDown()\n+\t{\n+\t\tunset($this->object);\n+\t\tparent::tearDown();\n+\t}\n+\n+\t/**\n+\t * Check if Update Information Contains required information\n+\t *\n+\t * @since version 4.0\n+\t */\n+\tpublic function testIfUpdateInformationContainsRequiredParameters()\n+\t{\n+\t\t$updateInfo = $this->object->getUpdateInformation();\n+\t\t$this->assertArrayHasKey('installed', $updateInfo, 'The current version is not defined.');\n+\t\t$this->assertArrayHasKey('latest', $updateInfo, 'The latest Version must be defined.');\n+\t\t$this->assertArrayHasKey('object', $updateInfo, 'Update details information should be set.');\n+\t\t$this->assertArrayHasKey('hasUpdate', $updateInfo);\n+\t}\n+\n+\t/**\n+\t * Test if installed version returned from Update Information is JVersion\n+\t *\n+\t * @since version 4.0\n+\t */\n+\tpublic function testIfJversionIsInstalledVersion()\n+\t{\n+\t\t$this->assertEquals(\\JVERSION, $updateInfo['installed']);\n+\t}\n+\n+\t/**\n+\t * Tests if the name of the command is 'check-updates'\n+\t *\n+\t * @since version 4.0\n+\t */\n+\tpublic function testIfCommandNameIsSpecifiedProperly()\n+\t{\n+\t\t$this->assertEquals('check-updates', $this->object->getName(), 'The Command name should be check-updates');\n+\t}\n+\n+\t/**\n+\t *  Tests if the name of the Command is set\n+\t *\n+\t * @since version 4.0\n+\t */\n+\tpublic function testIfCommandHasName()\n+\t{\n+\t\t$this->assertNotNull($this->object->getName(), 'The command must contain a name');\n+\t}\n+\n+\t/**\n+\t * Tests if the command has help information\n+\t *\n+\t * @since version 4.0\n+\t */\n+\tpublic function testIfCommandHasHelp()\n+\t{\n+\t\t$this->assertNotNull($this->object->getProcessedHelp(), 'The command must contain a name');\n+\t}\n+\n+\t/**\n+\t * Test if execute methood is implemented\n+\t *\n+\t * @since version 4.0\n+\t */\n+\tpublic function testIfCommandImplementsExecutemethod()\n+\t{","path":"suites/libraries/cms/console/CheckJoomlaUpdatesCommandTest.php","position":117,"original_position":117,"commit_id":"9e8159d636ef34c28be6911fc11bbc02fdabdada","original_commit_id":"9e8159d636ef34c28be6911fc11bbc02fdabdada","user":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars0.githubusercontent.com/u/467356?v=4","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"body":"Execute is part of the interface so this test is obsolete","created_at":"2018-05-26T11:18:22Z","updated_at":"2018-05-26T11:18:23Z","html_url":"https://github.com/joomla/test-unit/pull/5#discussion_r191046303","pull_request_url":"https://api.github.com/repos/joomla/test-unit/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/joomla/test-unit/pulls/comments/191046303"},"html":{"href":"https://github.com/joomla/test-unit/pull/5#discussion_r191046303"},"pull_request":{"href":"https://api.github.com/repos/joomla/test-unit/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/test-unit/pulls/5","id":190736326,"html_url":"https://github.com/joomla/test-unit/pull/5","diff_url":"https://github.com/joomla/test-unit/pull/5.diff","patch_url":"https://github.com/joomla/test-unit/pull/5.patch","issue_url":"https://api.github.com/repos/joomla/test-unit/issues/5","number":5,"state":"open","locked":false,"title":"Added Unit test for CLI Update - check-updates command","user":{"login":"bosunski","id":15146515,"avatar_url":"https://avatars2.githubusercontent.com/u/15146515?v=4","gravatar_id":"","url":"https://api.github.com/users/bosunski","html_url":"https://github.com/bosunski","followers_url":"https://api.github.com/users/bosunski/followers","following_url":"https://api.github.com/users/bosunski/following{/other_user}","gists_url":"https://api.github.com/users/bosunski/gists{/gist_id}","starred_url":"https://api.github.com/users/bosunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosunski/subscriptions","organizations_url":"https://api.github.com/users/bosunski/orgs","repos_url":"https://api.github.com/users/bosunski/repos","events_url":"https://api.github.com/users/bosunski/events{/privacy}","received_events_url":"https://api.github.com/users/bosunski/received_events","type":"User","site_admin":false},"body":"Added Unit Test for Joomla\\CMS\\Console\\CheckJoomlaUpdatesCommand","created_at":"2018-05-26T10:36:50Z","updated_at":"2018-05-26T11:18:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc08409fdd3c44b284f795c6a9ef98180a8afa2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/test-unit/pulls/5/commits","review_comments_url":"https://api.github.com/repos/joomla/test-unit/pulls/5/comments","review_comment_url":"https://api.github.com/repos/joomla/test-unit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/test-unit/issues/5/comments","statuses_url":"https://api.github.com/repos/joomla/test-unit/statuses/9e8159d636ef34c28be6911fc11bbc02fdabdada","head":{"label":"bosunski:develop","ref":"develop","sha":"9e8159d636ef34c28be6911fc11bbc02fdabdada","user":{"login":"bosunski","id":15146515,"avatar_url":"https://avatars2.githubusercontent.com/u/15146515?v=4","gravatar_id":"","url":"https://api.github.com/users/bosunski","html_url":"https://github.com/bosunski","followers_url":"https://api.github.com/users/bosunski/followers","following_url":"https://api.github.com/users/bosunski/following{/other_user}","gists_url":"https://api.github.com/users/bosunski/gists{/gist_id}","starred_url":"https://api.github.com/users/bosunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosunski/subscriptions","organizations_url":"https://api.github.com/users/bosunski/orgs","repos_url":"https://api.github.com/users/bosunski/repos","events_url":"https://api.github.com/users/bosunski/events{/privacy}","received_events_url":"https://api.github.com/users/bosunski/received_events","type":"User","site_admin":false},"repo":{"id":133865143,"name":"test-unit","full_name":"bosunski/test-unit","owner":{"login":"bosunski","id":15146515,"avatar_url":"https://avatars2.githubusercontent.com/u/15146515?v=4","gravatar_id":"","url":"https://api.github.com/users/bosunski","html_url":"https://github.com/bosunski","followers_url":"https://api.github.com/users/bosunski/followers","following_url":"https://api.github.com/users/bosunski/following{/other_user}","gists_url":"https://api.github.com/users/bosunski/gists{/gist_id}","starred_url":"https://api.github.com/users/bosunski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosunski/subscriptions","organizations_url":"https://api.github.com/users/bosunski/orgs","repos_url":"https://api.github.com/users/bosunski/repos","events_url":"https://api.github.com/users/bosunski/events{/privacy}","received_events_url":"https://api.github.com/users/bosunski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bosunski/test-unit","description":"Unit Tests for Joomla","fork":true,"url":"https://api.github.com/repos/bosunski/test-unit","forks_url":"https://api.github.com/repos/bosunski/test-unit/forks","keys_url":"https://api.github.com/repos/bosunski/test-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosunski/test-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosunski/test-unit/teams","hooks_url":"https://api.github.com/repos/bosunski/test-unit/hooks","issue_events_url":"https://api.github.com/repos/bosunski/test-unit/issues/events{/number}","events_url":"https://api.github.com/repos/bosunski/test-unit/events","assignees_url":"https://api.github.com/repos/bosunski/test-unit/assignees{/user}","branches_url":"https://api.github.com/repos/bosunski/test-unit/branches{/branch}","tags_url":"https://api.github.com/repos/bosunski/test-unit/tags","blobs_url":"https://api.github.com/repos/bosunski/test-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosunski/test-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosunski/test-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosunski/test-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosunski/test-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/bosunski/test-unit/languages","stargazers_url":"https://api.github.com/repos/bosunski/test-unit/stargazers","contributors_url":"https://api.github.com/repos/bosunski/test-unit/contributors","subscribers_url":"https://api.github.com/repos/bosunski/test-unit/subscribers","subscription_url":"https://api.github.com/repos/bosunski/test-unit/subscription","commits_url":"https://api.github.com/repos/bosunski/test-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosunski/test-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosunski/test-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosunski/test-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosunski/test-unit/contents/{+path}","compare_url":"https://api.github.com/repos/bosunski/test-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosunski/test-unit/merges","archive_url":"https://api.github.com/repos/bosunski/test-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosunski/test-unit/downloads","issues_url":"https://api.github.com/repos/bosunski/test-unit/issues{/number}","pulls_url":"https://api.github.com/repos/bosunski/test-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/bosunski/test-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/bosunski/test-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosunski/test-unit/labels{/name}","releases_url":"https://api.github.com/repos/bosunski/test-unit/releases{/id}","deployments_url":"https://api.github.com/repos/bosunski/test-unit/deployments","created_at":"2018-05-17T20:29:16Z","updated_at":"2018-05-17T20:29:18Z","pushed_at":"2018-05-26T10:33:48Z","git_url":"git://github.com/bosunski/test-unit.git","ssh_url":"git@github.com:bosunski/test-unit.git","clone_url":"https://github.com/bosunski/test-unit.git","svn_url":"https://github.com/bosunski/test-unit","homepage":null,"size":1835,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.0-dev"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"bd0f70d9ad26e9cd3abc49bb025dbf732e8259ed","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":104734555,"name":"test-unit","full_name":"joomla/test-unit","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/test-unit","description":"Unit Tests for Joomla","fork":false,"url":"https://api.github.com/repos/joomla/test-unit","forks_url":"https://api.github.com/repos/joomla/test-unit/forks","keys_url":"https://api.github.com/repos/joomla/test-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/test-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/test-unit/teams","hooks_url":"https://api.github.com/repos/joomla/test-unit/hooks","issue_events_url":"https://api.github.com/repos/joomla/test-unit/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/test-unit/events","assignees_url":"https://api.github.com/repos/joomla/test-unit/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/test-unit/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/test-unit/tags","blobs_url":"https://api.github.com/repos/joomla/test-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/test-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/test-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/test-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/test-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/test-unit/languages","stargazers_url":"https://api.github.com/repos/joomla/test-unit/stargazers","contributors_url":"https://api.github.com/repos/joomla/test-unit/contributors","subscribers_url":"https://api.github.com/repos/joomla/test-unit/subscribers","subscription_url":"https://api.github.com/repos/joomla/test-unit/subscription","commits_url":"https://api.github.com/repos/joomla/test-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/test-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/test-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/test-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/test-unit/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/test-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/test-unit/merges","archive_url":"https://api.github.com/repos/joomla/test-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/test-unit/downloads","issues_url":"https://api.github.com/repos/joomla/test-unit/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/test-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/test-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/test-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/test-unit/labels{/name}","releases_url":"https://api.github.com/repos/joomla/test-unit/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/test-unit/deployments","created_at":"2017-09-25T10:11:44Z","updated_at":"2018-05-15T10:32:41Z","pushed_at":"2018-05-26T10:36:51Z","git_url":"git://github.com/joomla/test-unit.git","ssh_url":"git@github.com:joomla/test-unit.git","clone_url":"https://github.com/joomla/test-unit.git","svn_url":"https://github.com/joomla/test-unit","homepage":null,"size":1833,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":3,"open_issues":2,"watchers":0,"default_branch":"4.0-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/test-unit/pulls/5"},"html":{"href":"https://github.com/joomla/test-unit/pull/5"},"issue":{"href":"https://api.github.com/repos/joomla/test-unit/issues/5"},"comments":{"href":"https://api.github.com/repos/joomla/test-unit/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/test-unit/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/test-unit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/test-unit/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/test-unit/statuses/9e8159d636ef34c28be6911fc11bbc02fdabdada"}},"author_association":"NONE"}}
{"actor":{"display_login":"rdeutz"}}