{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/14319","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/14319/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14319/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/14319/events","html_url":"https://github.com/xbmc/xbmc/pull/14319","id":351845336,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzI2OTM2","number":14319,"title":"[Addons][GUI] Make realtime streams unresumable","user":{"login":"enen92","id":7375276,"node_id":"MDQ6VXNlcjczNzUyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7375276?v=4","gravatar_id":"","url":"https://api.github.com/users/enen92","html_url":"https://github.com/enen92","followers_url":"https://api.github.com/users/enen92/followers","following_url":"https://api.github.com/users/enen92/following{/other_user}","gists_url":"https://api.github.com/users/enen92/gists{/gist_id}","starred_url":"https://api.github.com/users/enen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enen92/subscriptions","organizations_url":"https://api.github.com/users/enen92/orgs","repos_url":"https://api.github.com/users/enen92/repos","events_url":"https://api.github.com/users/enen92/events{/privacy}","received_events_url":"https://api.github.com/users/enen92/received_events","type":"User","site_admin":false},"labels":[{"id":276939482,"node_id":"MDU6TGFiZWwyNzY5Mzk0ODI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/Addons","name":"Addons","color":"009800","default":false},{"id":277024112,"node_id":"MDU6TGFiZWwyNzcwMjQxMTI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/Rendering%20GUI","name":"Rendering GUI","color":"009800","default":false},{"id":13096702,"node_id":"MDU6TGFiZWwxMzA5NjcwMg==","url":"https://api.github.com/repos/xbmc/xbmc/labels/Wiki-Needed","name":"Wiki-Needed","color":"5319e7","default":false},{"id":400751192,"node_id":"MDU6TGFiZWw0MDA3NTExOTI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-18T19:29:55Z","updated_at":"2018-08-18T21:45:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14319","html_url":"https://github.com/xbmc/xbmc/pull/14319","diff_url":"https://github.com/xbmc/xbmc/pull/14319.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14319.patch"},"body":"## Description\r\nStreams flagged as realtime (i.e. with the property `isrealtimestream` set) should not be resumable.\r\n\r\n## Motivation and Context\r\nAddon developers need more control over the context menu items and resumable marks that are shown in the GUI. If we are playing a livestream, resume points will be automatically set by Kodi and the ability to resume the stream from the last played position will be available after the stream is stopped. Attempting to resume a realtime stream can cause all sort of issues. Currently, some addon developers are using `xbmc.Player().play()` in plugins instead of `setResolvedUrl` (a hack) just as a means to avoid the default contextmenu items/ resume points. \r\nRef: https://forum.kodi.tv/showthread.php?tid=270648&pid=2759631#pid2759631\r\n\r\nPinging @ksooo apart from Fernet as I don't know if this has any implications in PVR.\r\n\r\n## How Has This Been Tested?\r\nCompiled and runtime tested. Addon with playable listitems with `isrealtimestream` property set did not show the resume context menu items nor the IsResumable icon as expected.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [x] **Bug fix** (non-breaking change which fixes an issue)\r\n- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)\r\n- [x] **Improvement** (non-breaking change which improves existing functionality)\r\n- [ ] **New feature** (non-breaking change which adds functionality)\r\n- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)\r\n- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)\r\n- [ ] **None of the above** (please explain below)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `X` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project \r\n- [x] My change requires a change to the documentation, either Doxygen or wiki\r\n- [x] I have updated the documentation accordingly\r\n- [x] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document\r\n- [ ] I have added tests to cover my change\r\n- [x] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/414088134","html_url":"https://github.com/xbmc/xbmc/pull/14319#issuecomment-414088134","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14319","id":414088134,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDA4ODEzNA==","user":{"login":"FernetMenta","id":576009,"node_id":"MDQ6VXNlcjU3NjAwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/576009?v=4","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"created_at":"2018-08-18T21:45:12Z","updated_at":"2018-08-18T21:45:12Z","author_association":"MEMBER","body":"You abuse the property \"realtime\". realtime only means that the steam comes in the same speed as it can be played back."}}
{"actor":{"display_login":"FernetMenta"}}