{"action":"created","issue":{"url":"https://api.github.com/repos/enpassio/Databinding/issues/6","repository_url":"https://api.github.com/repos/enpassio/Databinding","labels_url":"https://api.github.com/repos/enpassio/Databinding/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/enpassio/Databinding/issues/6/comments","events_url":"https://api.github.com/repos/enpassio/Databinding/issues/6/events","html_url":"https://github.com/enpassio/Databinding/issues/6","id":384872412,"node_id":"MDU6SXNzdWUzODQ4NzI0MTI=","number":6,"title":" second sample","user":{"login":"OyaCanli","id":33556367,"node_id":"MDQ6VXNlcjMzNTU2MzY3","avatar_url":"https://avatars1.githubusercontent.com/u/33556367?v=4","gravatar_id":"","url":"https://api.github.com/users/OyaCanli","html_url":"https://github.com/OyaCanli","followers_url":"https://api.github.com/users/OyaCanli/followers","following_url":"https://api.github.com/users/OyaCanli/following{/other_user}","gists_url":"https://api.github.com/users/OyaCanli/gists{/gist_id}","starred_url":"https://api.github.com/users/OyaCanli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OyaCanli/subscriptions","organizations_url":"https://api.github.com/users/OyaCanli/orgs","repos_url":"https://api.github.com/users/OyaCanli/repos","events_url":"https://api.github.com/users/OyaCanli/events{/privacy}","received_events_url":"https://api.github.com/users/OyaCanli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-27T16:14:25Z","updated_at":"2018-11-30T17:03:54Z","closed_at":null,"author_association":"MEMBER","body":"So up to now, we have been saying that we want another databinding sample with network connection. Let's discuss the details of it.\r\n-Are we using NewsApi ?\r\n-How do we deal with network request? Retrofit? Raw http request?\r\n-How will be the structure? Will we again show a list of items in recyclerview and a detail page?\r\n-Normally, it is not good practice to make network request from main activity. It would be better to put it in ViewModel or a singleton Repository. But shall we avoid those for simplicity?"},"comment":{"url":"https://api.github.com/repos/enpassio/Databinding/issues/comments/443270214","html_url":"https://github.com/enpassio/Databinding/issues/6#issuecomment-443270214","issue_url":"https://api.github.com/repos/enpassio/Databinding/issues/6","id":443270214,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzI3MDIxNA==","user":{"login":"OyaCanli","id":33556367,"node_id":"MDQ6VXNlcjMzNTU2MzY3","avatar_url":"https://avatars1.githubusercontent.com/u/33556367?v=4","gravatar_id":"","url":"https://api.github.com/users/OyaCanli","html_url":"https://github.com/OyaCanli","followers_url":"https://api.github.com/users/OyaCanli/followers","following_url":"https://api.github.com/users/OyaCanli/following{/other_user}","gists_url":"https://api.github.com/users/OyaCanli/gists{/gist_id}","starred_url":"https://api.github.com/users/OyaCanli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OyaCanli/subscriptions","organizations_url":"https://api.github.com/users/OyaCanli/orgs","repos_url":"https://api.github.com/users/OyaCanli/repos","events_url":"https://api.github.com/users/OyaCanli/events{/privacy}","received_events_url":"https://api.github.com/users/OyaCanli/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T17:03:54Z","updated_at":"2018-11-30T17:03:54Z","author_association":"MEMBER","body":"Ok. Let's go with http request. Frankly, I had found myself the underlying mechanisms of http request complicated as well. But it was a chunk of code that we could copy paste and reuse, so it was easy in that sense. \r\n\r\nI have been playing with viewmodels for a while, I'm comfortable with that. For passing the viewmodel to databinding vs passing directly the item, I'm not sure whichis better in fact. I guess it depends on case. I have seen both in google samples. I'll check them out again and compare. And we'll discuss it more as the project takes shape and we know more details. "}}
{"actor":{"display_login":"OyaCanli"}}