{"action":"created","issue":{"url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/issues/759","repository_url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal","labels_url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/issues/759/labels{/name}","comments_url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/issues/759/comments","events_url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/issues/759/events","html_url":"https://github.com/ocadotechnology/codeforlife-portal/pull/759","id":336672598,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDY5Nzk5","number":759,"title":"Invite a teacher resolves issue #745","user":{"login":"PrenSJ","id":40356543,"node_id":"MDQ6VXNlcjQwMzU2NTQz","avatar_url":"https://avatars1.githubusercontent.com/u/40356543?v=4","gravatar_id":"","url":"https://api.github.com/users/PrenSJ","html_url":"https://github.com/PrenSJ","followers_url":"https://api.github.com/users/PrenSJ/followers","following_url":"https://api.github.com/users/PrenSJ/following{/other_user}","gists_url":"https://api.github.com/users/PrenSJ/gists{/gist_id}","starred_url":"https://api.github.com/users/PrenSJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrenSJ/subscriptions","organizations_url":"https://api.github.com/users/PrenSJ/orgs","repos_url":"https://api.github.com/users/PrenSJ/repos","events_url":"https://api.github.com/users/PrenSJ/events{/privacy}","received_events_url":"https://api.github.com/users/PrenSJ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-28T15:32:34Z","updated_at":"2018-06-29T11:18:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/pulls/759","html_url":"https://github.com/ocadotechnology/codeforlife-portal/pull/759","diff_url":"https://github.com/ocadotechnology/codeforlife-portal/pull/759.diff","patch_url":"https://github.com/ocadotechnology/codeforlife-portal/pull/759.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/issues/comments/401325283","html_url":"https://github.com/ocadotechnology/codeforlife-portal/pull/759#issuecomment-401325283","issue_url":"https://api.github.com/repos/ocadotechnology/codeforlife-portal/issues/759","id":401325283,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTMyNTI4Mw==","user":{"login":"PrenSJ","id":40356543,"node_id":"MDQ6VXNlcjQwMzU2NTQz","avatar_url":"https://avatars1.githubusercontent.com/u/40356543?v=4","gravatar_id":"","url":"https://api.github.com/users/PrenSJ","html_url":"https://github.com/PrenSJ","followers_url":"https://api.github.com/users/PrenSJ/followers","following_url":"https://api.github.com/users/PrenSJ/following{/other_user}","gists_url":"https://api.github.com/users/PrenSJ/gists{/gist_id}","starred_url":"https://api.github.com/users/PrenSJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrenSJ/subscriptions","organizations_url":"https://api.github.com/users/PrenSJ/orgs","repos_url":"https://api.github.com/users/PrenSJ/repos","events_url":"https://api.github.com/users/PrenSJ/events{/privacy}","received_events_url":"https://api.github.com/users/PrenSJ/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T11:18:20Z","updated_at":"2018-06-29T11:18:20Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 7 of 8 files reviewed, 7 unresolved discussions (waiting on @riaJha97 and @PrenSJ)\n\n---\n\n*[portal/urls.py, line 128 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA5U64-IysPb-e6Pi4:-LGAA7Q00fU9sBWeGlHR:b-896fix) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/080cc6830291b20431ed9f7a1a5bee0b42d25d89/portal/urls.py#L128)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nYou don't need this url right? This is already being rendered inside the view\n</blockquote></details>\n\nDone.\n\n---\n\n*[portal/forms/invite_teacher.py, line 42 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA5buw1dC7WfGrg7BV:-LGAAK9B8LB463rWHeJm:b-896fix) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/080cc6830291b20431ed9f7a1a5bee0b42d25d89/portal/forms/invite_teacher.py#L42)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nCould you rename this variable to email_regex? (Sorry just python convention) \n</blockquote></details>\n\nDone.\n\n---\n\n*[portal/static/portal/sass/partials/_forms.scss, line 232 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA71IuBhCFOkW0bQFE:-LGAE6pV5iHNkrgoFUhf:b-896fix) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/080cc6830291b20431ed9f7a1a5bee0b42d25d89/portal/static/portal/sass/partials/_forms.scss#L232)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nI don't know enough about css but the convention doesn't seem right. If you have a look at some of the classes above this file (eg: form--register or form--news-signup) and try to follow them? you could start by renaming the class name so that it matches the other forms :)\n</blockquote></details>\n\nDone.\n\n---\n\n*[portal/templates/portal/email_invitation_sent.html, line 25 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA7_pd6_eE_VrgVR0J:-LGAEMaxAWmMa_-FVTOA:b462d4o) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/080cc6830291b20431ed9f7a1a5bee0b42d25d89/portal/templates/portal/email_invitation_sent.html#L25)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nn missing in invitation :) \nDoes this page show up okay when ran locally? The apostrophe looks odd. I'm pretty sure we've used apostrophes in other html pages. Maybe you could have a look at how they're being used elsewhere?\n</blockquote></details>\n\nthe apostrophe works fine when run locally \n\n---\n\n*[portal/views/teacher/teach.py, line 65 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA4ygb57-mgKBY5IMY:-LGAF4Tp6Rp7CBll1Yi1:b-896fix) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/0071c7376a258f413dccb29e424673394039354c/portal/views/teacher/teach.py#L65)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nYou've removed this import, which is why the build is failing. Can you add it back in?\n</blockquote></details>\n\nDone.\n\n---\n\n*[portal/views/teacher/teach.py, line 906 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA8VtzCsuHXBNhwCIg:-LGAFNAc5fBSqNFv9RBL:b-896fix) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/080cc6830291b20431ed9f7a1a5bee0b42d25d89/portal/views/teacher/teach.py#L906)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nCan you reformat this bit so everything starting from the curly braces is in one line?\n</blockquote></details>\n\nDone.\n\n---\n\n*[portal/views/teacher/teach.py, line 910 at r1](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759#-LGA8dSG47FPYKli70KG:-LGAFbeH3vfHLUGPGsdD:b-896fix) ([raw file](https://github.com/ocadotechnology/codeforlife-portal/blob/080cc6830291b20431ed9f7a1a5bee0b42d25d89/portal/views/teacher/teach.py#L910)):*\n<details><summary><i>Previously, riaJha97 wrote…</i></summary><blockquote>\n\nCan you rename this to invite_teacher_form? (Sorry).\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/ocadotechnology/codeforlife-portal/759)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"PrenSJ"}}