{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/3379","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/3379/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/3379/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/3379/events","html_url":"https://github.com/eclipse/omr/pull/3379","id":392623165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODUyNzk4","number":3379,"title":"Revert \"Multiple ddrgen fixes\"","user":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"labels":[{"id":335772606,"node_id":"MDU6TGFiZWwzMzU3NzI2MDY=","url":"https://api.github.com/repos/eclipse/omr/labels/bug","name":"bug","color":"fc2929","default":true},{"id":464802722,"node_id":"MDU6TGFiZWw0NjQ4MDI3MjI=","url":"https://api.github.com/repos/eclipse/omr/labels/diagnostic%20support","name":"diagnostic support","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-19T14:22:12Z","updated_at":"2018-12-19T14:45:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/3379","html_url":"https://github.com/eclipse/omr/pull/3379","diff_url":"https://github.com/eclipse/omr/pull/3379.diff","patch_url":"https://github.com/eclipse/omr/pull/3379.patch"},"body":"Reverts eclipse/omr#3355\r\n\r\nAn OpenJ9 contributor created the initial PR to address some issues with how ddrgen understands types.  Unfortunately, the changes introduced some issues in our builds when OpenJ9 upgraded to the  OMR version with the changes.\r\n\r\nWe haven't gotten to the bottom of the why the changes are incorrect yet but they seem to trigger a corner case resulting in incorrect behaviour.  See example below.\r\n\r\nI'm requesting that these changes be reverted as they've introduced functional issues that affect OpenJ9's ability to take new OMR levels and may cause issues for any other ddrgen users.\r\n\r\nWe'll follow up on getting the changes fixed and re-delivered in the new year.\r\n\r\nExample problem:\r\n```\r\n [OUT] > Problem running command:\r\n [OUT] U64 contains value larger than Long.MAX_VALUE\r\n [OUT] > \r\n```\r\nhttps://ci.eclipse.org/openj9/job/Test-sanity.functional-JDK8-linux_390-64_cmprssptrs/527/"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/448620359","html_url":"https://github.com/eclipse/omr/pull/3379#issuecomment-448620359","issue_url":"https://api.github.com/repos/eclipse/omr/issues/3379","id":448620359,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODYyMDM1OQ==","user":{"login":"Leonardo2718","id":6710130,"node_id":"MDQ6VXNlcjY3MTAxMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6710130?v=4","gravatar_id":"","url":"https://api.github.com/users/Leonardo2718","html_url":"https://github.com/Leonardo2718","followers_url":"https://api.github.com/users/Leonardo2718/followers","following_url":"https://api.github.com/users/Leonardo2718/following{/other_user}","gists_url":"https://api.github.com/users/Leonardo2718/gists{/gist_id}","starred_url":"https://api.github.com/users/Leonardo2718/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leonardo2718/subscriptions","organizations_url":"https://api.github.com/users/Leonardo2718/orgs","repos_url":"https://api.github.com/users/Leonardo2718/repos","events_url":"https://api.github.com/users/Leonardo2718/events{/privacy}","received_events_url":"https://api.github.com/users/Leonardo2718/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T14:45:46Z","updated_at":"2018-12-19T14:45:46Z","author_association":"CONTRIBUTOR","body":"@genie-omr build all"}}
{"actor":{"display_login":"Leonardo2718"}}