{"action":"created","issue":{"url":"https://api.github.com/repos/ppy/osu-framework/issues/1881","repository_url":"https://api.github.com/repos/ppy/osu-framework","labels_url":"https://api.github.com/repos/ppy/osu-framework/issues/1881/labels{/name}","comments_url":"https://api.github.com/repos/ppy/osu-framework/issues/1881/comments","events_url":"https://api.github.com/repos/ppy/osu-framework/issues/1881/events","html_url":"https://github.com/ppy/osu-framework/pull/1881","id":358149664,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTkyMjg5","number":1881,"title":"Fix broken texture coordinates in PathDrawNode/CircularProgressDrawNode","user":{"login":"marcan","id":98387,"node_id":"MDQ6VXNlcjk4Mzg3","avatar_url":"https://avatars0.githubusercontent.com/u/98387?v=4","gravatar_id":"","url":"https://api.github.com/users/marcan","html_url":"https://github.com/marcan","followers_url":"https://api.github.com/users/marcan/followers","following_url":"https://api.github.com/users/marcan/following{/other_user}","gists_url":"https://api.github.com/users/marcan/gists{/gist_id}","starred_url":"https://api.github.com/users/marcan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcan/subscriptions","organizations_url":"https://api.github.com/users/marcan/orgs","repos_url":"https://api.github.com/users/marcan/repos","events_url":"https://api.github.com/users/marcan/events{/privacy}","received_events_url":"https://api.github.com/users/marcan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-09-07T17:26:32Z","updated_at":"2018-09-09T08:45:21Z","closed_at":"2018-09-09T08:44:55Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/1881","html_url":"https://github.com/ppy/osu-framework/pull/1881","diff_url":"https://github.com/ppy/osu-framework/pull/1881.diff","patch_url":"https://github.com/ppy/osu-framework/pull/1881.patch"},"body":"Fix broken texture coordinates in PathDrawNode/CircularProgressDrawNode\r\n\r\nThis wound up being a recursive spiral of fail. The pattern `1 / Texture.{Width,Height}` is broken because those properties are integers, and  everything rounds to zero. Except for 1x1 textures where it doesn't round. But this whole code was broken for texture atlases because it was computing coordinates without taking the atlas into account, assuming it was a single texture. But it happened to work for WhitePixel because 1 - 1 = 0 and so the bottom right coord moved (by what the code thought was one pixel, but in reality was the whole atlas) to the top left corner, which is where the white pixel is.\r\n\r\nBlergh.\r\n\r\n* closes (potentially) ppy/osu#3215\r\n\r\n#### original PR\r\n\r\n> The pattern `1 / Texture.{Width,Height}` is broken because those\r\n> properties are integers, and thus the division truncates to zero.\r\n> \r\n> * closes (potentially) ppy/osu#3215"},"comment":{"url":"https://api.github.com/repos/ppy/osu-framework/issues/comments/419700299","html_url":"https://github.com/ppy/osu-framework/pull/1881#issuecomment-419700299","issue_url":"https://api.github.com/repos/ppy/osu-framework/issues/1881","id":419700299,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTcwMDI5OQ==","user":{"login":"Tom94","id":4923655,"node_id":"MDQ6VXNlcjQ5MjM2NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4923655?v=4","gravatar_id":"","url":"https://api.github.com/users/Tom94","html_url":"https://github.com/Tom94","followers_url":"https://api.github.com/users/Tom94/followers","following_url":"https://api.github.com/users/Tom94/following{/other_user}","gists_url":"https://api.github.com/users/Tom94/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom94/subscriptions","organizations_url":"https://api.github.com/users/Tom94/orgs","repos_url":"https://api.github.com/users/Tom94/repos","events_url":"https://api.github.com/users/Tom94/events{/privacy}","received_events_url":"https://api.github.com/users/Tom94/received_events","type":"User","site_admin":false},"created_at":"2018-09-09T08:45:21Z","updated_at":"2018-09-09T08:45:21Z","author_association":"COLLABORATOR","body":"Thanks for the fix!"}}
{"actor":{"display_login":"Tom94"}}