{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments/212553912","pull_request_review_id":149210823,"id":212553912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjU1MzkxMg==","diff_hunk":"@@ -84,10 +92,28 @@ func main() {\n \t\t}\n \t}\n \n-\t// TODO(marun) Make configurable and default to a namespace provided via the downward api\n-\tfedNamespace := util.DefaultFederationSystemNamespace\n-\tclusterNamespace := util.MulticlusterPublicNamespace\n+\t// Allow federation and cluster namespaces to be overridden by\n+\t// environment variables to allow the namespaces to be set to the\n+\t// pod namespace via the downward api.\n+\tfedNamespaceFromEnv := os.Getenv(\"FEDERATION_NAMESPACE\")\n+\tif len(fedNamespaceFromEnv) > 0 {\n+\t\tfedNamespace = fedNamespaceFromEnv\n+\t}\n+\tlog.Printf(\"Federation namespace: %s\", fedNamespace)\n+\n+\tclusterNamespaceFromEnv := os.Getenv(\"CLUSTER_REGISTRY_NAMESPACE\")","path":"cmd/controller-manager/main.go","position":38,"original_position":38,"commit_id":"02da0f74ea5a93724c9c8cf96486baab197388ee","original_commit_id":"0ba5bba25dc279d0575a8fde2d1a2bfc3f2228f4","user":{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"body":"s/clusterNamespaceFromEnv/registryNamespaceFromEnv","created_at":"2018-08-24T08:17:13Z","updated_at":"2018-08-24T08:27:24Z","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/216#discussion_r212553912","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments/212553912"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/216#discussion_r212553912"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216","id":209670985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjcwOTg1","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/216","diff_url":"https://github.com/kubernetes-sigs/federation-v2/pull/216.diff","patch_url":"https://github.com/kubernetes-sigs/federation-v2/pull/216.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/216","number":216,"state":"open","locked":false,"title":"Support deploying namespaced control plane","user":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"body":"Note most of the line additions of this PR are in `hack/install-namespaced.yaml`.\r\n\r\nTargets #197 ","created_at":"2018-08-20T23:33:42Z","updated_at":"2018-08-24T08:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aad2b5e48ee0dab4bb7d57783df829381b549e84","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pmorie","id":366488,"node_id":"MDQ6VXNlcjM2NjQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/366488?v=4","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},{"login":"font","id":3596535,"node_id":"MDQ6VXNlcjM1OTY1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3596535?v=4","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},{"login":"shashidharatd","id":8734900,"node_id":"MDQ6VXNlcjg3MzQ5MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/8734900?v=4","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":909764227,"node_id":"MDU6TGFiZWw5MDk3NjQyMjc=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":888036019,"node_id":"MDU6TGFiZWw4ODgwMzYwMTk=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":888036092,"node_id":"MDU6TGFiZWw4ODgwMzYwOTI=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/216/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/02da0f74ea5a93724c9c8cf96486baab197388ee","head":{"label":"marun:install-namespaced","ref":"install-namespaced","sha":"02da0f74ea5a93724c9c8cf96486baab197388ee","user":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"repo":{"id":130527783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA1Mjc3ODM=","name":"federation-v2","full_name":"marun/federation-v2","owner":{"login":"marun","id":451477,"node_id":"MDQ6VXNlcjQ1MTQ3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/451477?v=4","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marun/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":true,"url":"https://api.github.com/repos/marun/federation-v2","forks_url":"https://api.github.com/repos/marun/federation-v2/forks","keys_url":"https://api.github.com/repos/marun/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marun/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marun/federation-v2/teams","hooks_url":"https://api.github.com/repos/marun/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/marun/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/marun/federation-v2/events","assignees_url":"https://api.github.com/repos/marun/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/marun/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/marun/federation-v2/tags","blobs_url":"https://api.github.com/repos/marun/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marun/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marun/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/marun/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marun/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/marun/federation-v2/languages","stargazers_url":"https://api.github.com/repos/marun/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/marun/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/marun/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/marun/federation-v2/subscription","commits_url":"https://api.github.com/repos/marun/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/marun/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/marun/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/marun/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/marun/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/marun/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marun/federation-v2/merges","archive_url":"https://api.github.com/repos/marun/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marun/federation-v2/downloads","issues_url":"https://api.github.com/repos/marun/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/marun/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/marun/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/marun/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marun/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/marun/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/marun/federation-v2/deployments","created_at":"2018-04-22T02:15:08Z","updated_at":"2018-08-17T18:15:13Z","pushed_at":"2018-08-24T01:26:45Z","git_url":"git://github.com/marun/federation-v2.git","ssh_url":"git@github.com:marun/federation-v2.git","clone_url":"https://github.com/marun/federation-v2.git","svn_url":"https://github.com/marun/federation-v2","homepage":"","size":63052,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"378b101f44c745dd2f69c3548a1c1c78dd034097","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":116825580,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjU1ODA=","name":"federation-v2","full_name":"kubernetes-sigs/federation-v2","owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2","forks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/deployments","created_at":"2018-01-09T14:21:03Z","updated_at":"2018-08-23T19:46:21Z","pushed_at":"2018-08-24T01:26:46Z","git_url":"git://github.com/kubernetes-sigs/federation-v2.git","ssh_url":"git@github.com:kubernetes-sigs/federation-v2.git","clone_url":"https://github.com/kubernetes-sigs/federation-v2.git","svn_url":"https://github.com/kubernetes-sigs/federation-v2","homepage":"","size":63041,"stargazers_count":57,"watchers_count":57,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":53,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/216"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/216"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/02da0f74ea5a93724c9c8cf96486baab197388ee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gyliu513"}}