{"action":"opened","number":664,"pull_request":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/664","id":200457806,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDU3ODA2","html_url":"https://github.com/openzfs/openzfs/pull/664","diff_url":"https://github.com/openzfs/openzfs/pull/664.diff","patch_url":"https://github.com/openzfs/openzfs/pull/664.patch","issue_url":"https://api.github.com/repos/openzfs/openzfs/issues/664","number":664,"state":"open","locked":false,"title":"9647 Introduce ZFS Read/Write kstats","user":{"login":"sdimitro","id":2281588,"node_id":"MDQ6VXNlcjIyODE1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2281588?v=4","gravatar_id":"","url":"https://api.github.com/users/sdimitro","html_url":"https://github.com/sdimitro","followers_url":"https://api.github.com/users/sdimitro/followers","following_url":"https://api.github.com/users/sdimitro/following{/other_user}","gists_url":"https://api.github.com/users/sdimitro/gists{/gist_id}","starred_url":"https://api.github.com/users/sdimitro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdimitro/subscriptions","organizations_url":"https://api.github.com/users/sdimitro/orgs","repos_url":"https://api.github.com/users/sdimitro/repos","events_url":"https://api.github.com/users/sdimitro/events{/privacy}","received_events_url":"https://api.github.com/users/sdimitro/received_events","type":"User","site_admin":false},"body":"Reviewed by: Sara Hartse <sara.hartse@delphix.com>\r\nReviewed by: Sebastien Roy <sebastien.roy@delphix.com>\r\nReviewed by: Matthew Ahrens <mahrens@delphix.com>\r\nReviewed by: George Wilson <gwilson@zfsmail.com>\r\n\r\nThere are use-cases when we want to look into dataset performance\r\n(reads/writes) in ZFS and create high-level tooling for it.\r\n\r\nIn illumos we already have some of these kstats already in the VFS\r\nlayer (module:unix - name:vopstats_<fs_id of dataset here>). That\r\nsaid we want to introduce kstats specific to ZFS for the following\r\nreasons:\r\n[1] The current kstats don't support R/W to ZVOL's as these code\r\n    paths don't go through VFS.\r\n[2] The VFS version of these statistics are not surrounded by locks\r\n    on purpose so performance of this hot paths doesn't take a hit.\r\n    That's generally fine but it also means that the values are not\r\n    fully accurate. In this new version of kstats we can take\r\n    advantage of the aggsum_t counters (already used for ARC related\r\n    kstats) which would take care of most of that overhead.\r\n[3] Linux does not have the VFS kstats of illumos in its own VFS\r\n    layer, and they would have to implement this feature anyway. Thus\r\n    it would be nice to have the codebase being consistent among\r\n    variants.\r\n\r\nUpstream Bugs: DLPX-58996, DLPX-59190\r\n\r\nCloses XXX","created_at":"2018-07-10T16:40:28Z","updated_at":"2018-07-10T16:40:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzfs/openzfs/pulls/664/commits","review_comments_url":"https://api.github.com/repos/openzfs/openzfs/pulls/664/comments","review_comment_url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzfs/openzfs/issues/664/comments","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/5325299aa9c522720e3dea8c29445c3a1ddac62d","head":{"label":"sdimitro:openzfs-DLPX-58996","ref":"openzfs-DLPX-58996","sha":"5325299aa9c522720e3dea8c29445c3a1ddac62d","user":{"login":"sdimitro","id":2281588,"node_id":"MDQ6VXNlcjIyODE1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2281588?v=4","gravatar_id":"","url":"https://api.github.com/users/sdimitro","html_url":"https://github.com/sdimitro","followers_url":"https://api.github.com/users/sdimitro/followers","following_url":"https://api.github.com/users/sdimitro/following{/other_user}","gists_url":"https://api.github.com/users/sdimitro/gists{/gist_id}","starred_url":"https://api.github.com/users/sdimitro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdimitro/subscriptions","organizations_url":"https://api.github.com/users/sdimitro/orgs","repos_url":"https://api.github.com/users/sdimitro/repos","events_url":"https://api.github.com/users/sdimitro/events{/privacy}","received_events_url":"https://api.github.com/users/sdimitro/received_events","type":"User","site_admin":false},"repo":{"id":87977491,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzk3NzQ5MQ==","name":"openzfs","full_name":"sdimitro/openzfs","owner":{"login":"sdimitro","id":2281588,"node_id":"MDQ6VXNlcjIyODE1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/2281588?v=4","gravatar_id":"","url":"https://api.github.com/users/sdimitro","html_url":"https://github.com/sdimitro","followers_url":"https://api.github.com/users/sdimitro/followers","following_url":"https://api.github.com/users/sdimitro/following{/other_user}","gists_url":"https://api.github.com/users/sdimitro/gists{/gist_id}","starred_url":"https://api.github.com/users/sdimitro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdimitro/subscriptions","organizations_url":"https://api.github.com/users/sdimitro/orgs","repos_url":"https://api.github.com/users/sdimitro/repos","events_url":"https://api.github.com/users/sdimitro/events{/privacy}","received_events_url":"https://api.github.com/users/sdimitro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdimitro/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/sdimitro/openzfs","forks_url":"https://api.github.com/repos/sdimitro/openzfs/forks","keys_url":"https://api.github.com/repos/sdimitro/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdimitro/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdimitro/openzfs/teams","hooks_url":"https://api.github.com/repos/sdimitro/openzfs/hooks","issue_events_url":"https://api.github.com/repos/sdimitro/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/sdimitro/openzfs/events","assignees_url":"https://api.github.com/repos/sdimitro/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/sdimitro/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/sdimitro/openzfs/tags","blobs_url":"https://api.github.com/repos/sdimitro/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdimitro/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdimitro/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdimitro/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdimitro/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/sdimitro/openzfs/languages","stargazers_url":"https://api.github.com/repos/sdimitro/openzfs/stargazers","contributors_url":"https://api.github.com/repos/sdimitro/openzfs/contributors","subscribers_url":"https://api.github.com/repos/sdimitro/openzfs/subscribers","subscription_url":"https://api.github.com/repos/sdimitro/openzfs/subscription","commits_url":"https://api.github.com/repos/sdimitro/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdimitro/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdimitro/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdimitro/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdimitro/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/sdimitro/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdimitro/openzfs/merges","archive_url":"https://api.github.com/repos/sdimitro/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdimitro/openzfs/downloads","issues_url":"https://api.github.com/repos/sdimitro/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/sdimitro/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/sdimitro/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/sdimitro/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdimitro/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/sdimitro/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/sdimitro/openzfs/deployments","created_at":"2017-04-11T20:41:07Z","updated_at":"2018-07-10T16:26:49Z","pushed_at":"2018-07-10T16:38:28Z","git_url":"git://github.com/sdimitro/openzfs.git","ssh_url":"git@github.com:sdimitro/openzfs.git","clone_url":"https://github.com/sdimitro/openzfs.git","svn_url":"https://github.com/sdimitro/openzfs","homepage":"http://open-zfs.org","size":297065,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzfs:master","ref":"master","sha":"3e70629a059e1ee3fefdc547ba506d37f2708d94","user":{"login":"openzfs","id":4510897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTA4OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4510897?v=4","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"repo":{"id":44220580,"node_id":"MDEwOlJlcG9zaXRvcnk0NDIyMDU4MA==","name":"openzfs","full_name":"openzfs/openzfs","owner":{"login":"openzfs","id":4510897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTA4OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4510897?v=4","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfs/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/openzfs/openzfs","forks_url":"https://api.github.com/repos/openzfs/openzfs/forks","keys_url":"https://api.github.com/repos/openzfs/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfs/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfs/openzfs/teams","hooks_url":"https://api.github.com/repos/openzfs/openzfs/hooks","issue_events_url":"https://api.github.com/repos/openzfs/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/openzfs/openzfs/events","assignees_url":"https://api.github.com/repos/openzfs/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/openzfs/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/openzfs/openzfs/tags","blobs_url":"https://api.github.com/repos/openzfs/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfs/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfs/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfs/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfs/openzfs/languages","stargazers_url":"https://api.github.com/repos/openzfs/openzfs/stargazers","contributors_url":"https://api.github.com/repos/openzfs/openzfs/contributors","subscribers_url":"https://api.github.com/repos/openzfs/openzfs/subscribers","subscription_url":"https://api.github.com/repos/openzfs/openzfs/subscription","commits_url":"https://api.github.com/repos/openzfs/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfs/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfs/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfs/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzfs/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/openzfs/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfs/openzfs/merges","archive_url":"https://api.github.com/repos/openzfs/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfs/openzfs/downloads","issues_url":"https://api.github.com/repos/openzfs/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/openzfs/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfs/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfs/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfs/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/openzfs/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/openzfs/openzfs/deployments","created_at":"2015-10-14T03:03:50Z","updated_at":"2018-07-07T17:57:08Z","pushed_at":"2018-07-10T15:44:43Z","git_url":"git://github.com/openzfs/openzfs.git","ssh_url":"git@github.com:openzfs/openzfs.git","clone_url":"https://github.com/openzfs/openzfs.git","svn_url":"https://github.com/openzfs/openzfs","homepage":"http://open-zfs.org","size":303070,"stargazers_count":220,"watchers_count":220,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":37,"license":null,"forks":65,"open_issues":37,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/664"},"html":{"href":"https://github.com/openzfs/openzfs/pull/664"},"issue":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/664"},"comments":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/664/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/664/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/664/commits"},"statuses":{"href":"https://api.github.com/repos/openzfs/openzfs/statuses/5325299aa9c522720e3dea8c29445c3a1ddac62d"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":434,"deletions":116,"changed_files":10}}
{"actor":{"display_login":"sdimitro"}}