{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/204625538","pull_request_review_id":139736892,"id":204625538,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDYyNTUzOA==","diff_hunk":"@@ -0,0 +1,50 @@\n+/******************************************************************\n+ *\n+ * Copyright 2018 Samsung Electronics All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ *\n+ ******************************************************************/\n+\n+#ifndef __MEDIA_STREAMBUFFERWRITER_H\n+#define __MEDIA_STREAMBUFFERWRITER_H\n+\n+#include <memory>\n+#include <media/BufferWriterInterface.h>\n+\n+namespace media {\n+namespace stream {\n+class StreamBuffer;\n+\n+class StreamBufferWriter\n+\t: public BufferWriterInterface\n+{\n+public:\n+    StreamBufferWriter();\n+\n+public:\n+    virtual size_t write(unsigned char *buf, size_t size, bool sync = true) override;\n+    virtual size_t sizeOfSpace() override;\n+\n+public:\n+    void setStream(std::shared_ptr<StreamBuffer> stream);","path":"framework/src/media/StreamBufferWriter.h","position":40,"original_position":40,"commit_id":"2ad4b6d5cd1cefa49ec17f64ab3398c685324982","original_commit_id":"2ad4b6d5cd1cefa49ec17f64ab3398c685324982","user":{"login":"junmin-kim","id":25811851,"node_id":"MDQ6VXNlcjI1ODExODUx","avatar_url":"https://avatars0.githubusercontent.com/u/25811851?v=4","gravatar_id":"","url":"https://api.github.com/users/junmin-kim","html_url":"https://github.com/junmin-kim","followers_url":"https://api.github.com/users/junmin-kim/followers","following_url":"https://api.github.com/users/junmin-kim/following{/other_user}","gists_url":"https://api.github.com/users/junmin-kim/gists{/gist_id}","starred_url":"https://api.github.com/users/junmin-kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmin-kim/subscriptions","organizations_url":"https://api.github.com/users/junmin-kim/orgs","repos_url":"https://api.github.com/users/junmin-kim/repos","events_url":"https://api.github.com/users/junmin-kim/events{/privacy}","received_events_url":"https://api.github.com/users/junmin-kim/received_events","type":"User","site_admin":false},"body":"Please use the tab to align the indent","created_at":"2018-07-24T05:14:15Z","updated_at":"2018-07-24T05:14:15Z","html_url":"https://github.com/Samsung/TizenRT/pull/1960#discussion_r204625538","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/204625538"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1960#discussion_r204625538"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960","id":203282011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjgyMDEx","html_url":"https://github.com/Samsung/TizenRT/pull/1960","diff_url":"https://github.com/Samsung/TizenRT/pull/1960.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/1960.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960","number":1960,"state":"open","locked":false,"title":"Add stream buffer and listener for DataSource","user":{"login":"zhouxinhe","id":38490562,"node_id":"MDQ6VXNlcjM4NDkwNTYy","avatar_url":"https://avatars2.githubusercontent.com/u/38490562?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouxinhe","html_url":"https://github.com/zhouxinhe","followers_url":"https://api.github.com/users/zhouxinhe/followers","following_url":"https://api.github.com/users/zhouxinhe/following{/other_user}","gists_url":"https://api.github.com/users/zhouxinhe/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouxinhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouxinhe/subscriptions","organizations_url":"https://api.github.com/users/zhouxinhe/orgs","repos_url":"https://api.github.com/users/zhouxinhe/repos","events_url":"https://api.github.com/users/zhouxinhe/events{/privacy}","received_events_url":"https://api.github.com/users/zhouxinhe/received_events","type":"User","site_admin":false},"body":"@Taejun-Kwon \r\n- Add a API `rb_reset()` to reset ring-buffer.\r\n- Add StreamBuffer and StreamBufferReader/Writer for stream buffer reading/writing.\r\n- Modify Input/OutputDataSource to hold a stream buffer for each DataSource.\r\n- Add API `getId()` for both mediaplayer & mediarecorder to get ID. (May be changed in future.)\r\n- Add a non-virtual method in MediaRecorderObserverInterface for BufferOutputDataSource.\r\n- More listeners for mediaplayer/mediarecorder will be add in future.","created_at":"2018-07-23T16:57:11Z","updated_at":"2018-07-24T05:14:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae2d423b310f676d4da9d821169def929ab4fbea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/2ad4b6d5cd1cefa49ec17f64ab3398c685324982","head":{"label":"zhouxinhe:stream-buffer","ref":"stream-buffer","sha":"2ad4b6d5cd1cefa49ec17f64ab3398c685324982","user":{"login":"zhouxinhe","id":38490562,"node_id":"MDQ6VXNlcjM4NDkwNTYy","avatar_url":"https://avatars2.githubusercontent.com/u/38490562?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouxinhe","html_url":"https://github.com/zhouxinhe","followers_url":"https://api.github.com/users/zhouxinhe/followers","following_url":"https://api.github.com/users/zhouxinhe/following{/other_user}","gists_url":"https://api.github.com/users/zhouxinhe/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouxinhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouxinhe/subscriptions","organizations_url":"https://api.github.com/users/zhouxinhe/orgs","repos_url":"https://api.github.com/users/zhouxinhe/repos","events_url":"https://api.github.com/users/zhouxinhe/events{/privacy}","received_events_url":"https://api.github.com/users/zhouxinhe/received_events","type":"User","site_admin":false},"repo":{"id":139673965,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2NzM5NjU=","name":"TizenRT","full_name":"zhouxinhe/TizenRT","owner":{"login":"zhouxinhe","id":38490562,"node_id":"MDQ6VXNlcjM4NDkwNTYy","avatar_url":"https://avatars2.githubusercontent.com/u/38490562?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouxinhe","html_url":"https://github.com/zhouxinhe","followers_url":"https://api.github.com/users/zhouxinhe/followers","following_url":"https://api.github.com/users/zhouxinhe/following{/other_user}","gists_url":"https://api.github.com/users/zhouxinhe/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouxinhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouxinhe/subscriptions","organizations_url":"https://api.github.com/users/zhouxinhe/orgs","repos_url":"https://api.github.com/users/zhouxinhe/repos","events_url":"https://api.github.com/users/zhouxinhe/events{/privacy}","received_events_url":"https://api.github.com/users/zhouxinhe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhouxinhe/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/zhouxinhe/TizenRT","forks_url":"https://api.github.com/repos/zhouxinhe/TizenRT/forks","keys_url":"https://api.github.com/repos/zhouxinhe/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhouxinhe/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhouxinhe/TizenRT/teams","hooks_url":"https://api.github.com/repos/zhouxinhe/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/zhouxinhe/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/zhouxinhe/TizenRT/events","assignees_url":"https://api.github.com/repos/zhouxinhe/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/zhouxinhe/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/zhouxinhe/TizenRT/tags","blobs_url":"https://api.github.com/repos/zhouxinhe/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhouxinhe/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhouxinhe/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhouxinhe/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhouxinhe/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/zhouxinhe/TizenRT/languages","stargazers_url":"https://api.github.com/repos/zhouxinhe/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/zhouxinhe/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/zhouxinhe/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/zhouxinhe/TizenRT/subscription","commits_url":"https://api.github.com/repos/zhouxinhe/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhouxinhe/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhouxinhe/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhouxinhe/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhouxinhe/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/zhouxinhe/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhouxinhe/TizenRT/merges","archive_url":"https://api.github.com/repos/zhouxinhe/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhouxinhe/TizenRT/downloads","issues_url":"https://api.github.com/repos/zhouxinhe/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/zhouxinhe/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/zhouxinhe/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/zhouxinhe/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhouxinhe/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/zhouxinhe/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/zhouxinhe/TizenRT/deployments","created_at":"2018-07-04T05:47:07Z","updated_at":"2018-07-23T12:26:25Z","pushed_at":"2018-07-23T15:52:14Z","git_url":"git://github.com/zhouxinhe/TizenRT.git","ssh_url":"git@github.com:zhouxinhe/TizenRT.git","clone_url":"https://github.com/zhouxinhe/TizenRT.git","svn_url":"https://github.com/zhouxinhe/TizenRT","homepage":"","size":100710,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"dde0e8d681564871c416fc56335374aeb43a53d3","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"node_id":"MDEwOlJlcG9zaXRvcnk4MjUxNzI1Mg==","name":"TizenRT","full_name":"Samsung/TizenRT","owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2018-07-24T04:56:17Z","pushed_at":"2018-07-24T04:56:11Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":100687,"stargazers_count":184,"watchers_count":184,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":219,"open_issues":46,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1960"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1960"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1960/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/2ad4b6d5cd1cefa49ec17f64ab3398c685324982"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"junmin-kim"}}