{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/33668","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/33668/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/33668/comments","events_url":"https://api.github.com/repos/rails/rails/issues/33668/events","html_url":"https://github.com/rails/rails/pull/33668","id":352264316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjE4NzI3","number":33668,"title":"Ensure references creates id before type","user":{"login":"al2o3cr","id":1191,"node_id":"MDQ6VXNlcjExOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1191?v=4","gravatar_id":"","url":"https://api.github.com/users/al2o3cr","html_url":"https://github.com/al2o3cr","followers_url":"https://api.github.com/users/al2o3cr/followers","following_url":"https://api.github.com/users/al2o3cr/following{/other_user}","gists_url":"https://api.github.com/users/al2o3cr/gists{/gist_id}","starred_url":"https://api.github.com/users/al2o3cr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al2o3cr/subscriptions","organizations_url":"https://api.github.com/users/al2o3cr/orgs","repos_url":"https://api.github.com/users/al2o3cr/repos","events_url":"https://api.github.com/users/al2o3cr/events{/privacy}","received_events_url":"https://api.github.com/users/al2o3cr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"assignees":[{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-08-20T19:25:12Z","updated_at":"2018-08-20T20:21:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/33668","html_url":"https://github.com/rails/rails/pull/33668","diff_url":"https://github.com/rails/rails/pull/33668.diff","patch_url":"https://github.com/rails/rails/pull/33668.patch"},"body":"Prior to https://github.com/rails/rails/commit/d26704a15f88d384dd282425daa832affdb5f8c1, using `references` with `polymorphic: true` in a migration created an id column before creating the  corresponding type column.\r\n\r\nAfter that commit, the order is reversed.\r\n\r\nThis PR restores the previous order and adds a test to prevent regressions.\r\n\r\nI'm not aware of any production impact for the column ordering change, but it broke the schema linting on github/github.\r\n\r\n/cc @tenderlove @eileencodes "},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/414449923","html_url":"https://github.com/rails/rails/pull/33668#issuecomment-414449923","issue_url":"https://api.github.com/repos/rails/rails/issues/33668","id":414449923,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQ0OTkyMw==","user":{"login":"al2o3cr","id":1191,"node_id":"MDQ6VXNlcjExOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1191?v=4","gravatar_id":"","url":"https://api.github.com/users/al2o3cr","html_url":"https://github.com/al2o3cr","followers_url":"https://api.github.com/users/al2o3cr/followers","following_url":"https://api.github.com/users/al2o3cr/following{/other_user}","gists_url":"https://api.github.com/users/al2o3cr/gists{/gist_id}","starred_url":"https://api.github.com/users/al2o3cr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/al2o3cr/subscriptions","organizations_url":"https://api.github.com/users/al2o3cr/orgs","repos_url":"https://api.github.com/users/al2o3cr/repos","events_url":"https://api.github.com/users/al2o3cr/events{/privacy}","received_events_url":"https://api.github.com/users/al2o3cr/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T20:21:07Z","updated_at":"2018-08-20T20:21:07Z","author_association":"CONTRIBUTOR","body":"Added some tweaks to ensure the changes from https://github.com/rails/rails/commit/3fea23171248fb419925501492d174a1ae419ff8 and https://github.com/rails/rails/pull/14143 aren't disturbed by this."}}
{"actor":{"display_login":"al2o3cr"}}