{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/comments/193202121","pull_request_review_id":126128363,"id":193202121,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzIwMjEyMQ==","diff_hunk":"@@ -37,6 +40,19 @@ function getUpdatedSelections(editor: vscode.TextEditor, position: vscode.Positi\n \t\treturn;\n \t}\n \n+\t// check if this node is a script representing an HTML template. If so, parse the inside as HTML and select appropriate node\n+\tif (currentNode.name === 'script' &&\n+\t\t(position.isAfter(currentNode.open.end) && position.isBefore(currentNode.close.start)) &&\n+\t\t(currentNode.attributes &&\n+\t\t\tcurrentNode.attributes.some(x => x.name.toString() === 'type'\n+\t\t\t\t&& allowedMimeTypesInScriptTag.indexOf(x.value.toString()) > -1))) {\n+\n+\t\tlet buffer = new DocumentStreamReader(editor.document, currentNode.open.end, new vscode.Range(currentNode.open.end, currentNode.close.start));\n+\t\tlet scriptInnerNodes = parse(buffer);","path":"extensions/emmet/src/matchTag.ts","position":25,"original_position":25,"commit_id":"637b3caf908b74f02a6a7b0e0e6511acdc3d8512","original_commit_id":"637b3caf908b74f02a6a7b0e0e6511acdc3d8512","user":{"login":"ramya-rao-a","id":16890566,"node_id":"MDQ6VXNlcjE2ODkwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/16890566?v=4","gravatar_id":"","url":"https://api.github.com/users/ramya-rao-a","html_url":"https://github.com/ramya-rao-a","followers_url":"https://api.github.com/users/ramya-rao-a/followers","following_url":"https://api.github.com/users/ramya-rao-a/following{/other_user}","gists_url":"https://api.github.com/users/ramya-rao-a/gists{/gist_id}","starred_url":"https://api.github.com/users/ramya-rao-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramya-rao-a/subscriptions","organizations_url":"https://api.github.com/users/ramya-rao-a/orgs","repos_url":"https://api.github.com/users/ramya-rao-a/repos","events_url":"https://api.github.com/users/ramya-rao-a/events{/privacy}","received_events_url":"https://api.github.com/users/ramya-rao-a/received_events","type":"User","site_admin":false},"body":"`parse` can throw exceptions. Let's try/catch this","created_at":"2018-06-05T19:59:19Z","updated_at":"2018-06-05T19:59:32Z","html_url":"https://github.com/Microsoft/vscode/pull/51173#discussion_r193202121","pull_request_url":"https://api.github.com/repos/Microsoft/vscode/pulls/51173","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/comments/193202121"},"html":{"href":"https://github.com/Microsoft/vscode/pull/51173#discussion_r193202121"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/51173"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/51173","id":192817605,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODE3NjA1","html_url":"https://github.com/Microsoft/vscode/pull/51173","diff_url":"https://github.com/Microsoft/vscode/pull/51173.diff","patch_url":"https://github.com/Microsoft/vscode/pull/51173.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/51173","number":51173,"state":"open","locked":false,"title":"Allow Emmet \"Go to matching pair\" to work inside script tags","user":{"login":"JacksonKearl","id":8586769,"node_id":"MDQ6VXNlcjg1ODY3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/8586769?v=4","gravatar_id":"","url":"https://api.github.com/users/JacksonKearl","html_url":"https://github.com/JacksonKearl","followers_url":"https://api.github.com/users/JacksonKearl/followers","following_url":"https://api.github.com/users/JacksonKearl/following{/other_user}","gists_url":"https://api.github.com/users/JacksonKearl/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonKearl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonKearl/subscriptions","organizations_url":"https://api.github.com/users/JacksonKearl/orgs","repos_url":"https://api.github.com/users/JacksonKearl/repos","events_url":"https://api.github.com/users/JacksonKearl/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonKearl/received_events","type":"User","site_admin":false},"body":"Fixes #36905.","created_at":"2018-06-05T19:50:57Z","updated_at":"2018-06-05T19:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d80235ff848308572d30822cb9373e160d48cae9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode/pulls/51173/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode/pulls/51173/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/51173/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/637b3caf908b74f02a6a7b0e0e6511acdc3d8512","head":{"label":"JacksonKearl:master","ref":"master","sha":"637b3caf908b74f02a6a7b0e0e6511acdc3d8512","user":{"login":"JacksonKearl","id":8586769,"node_id":"MDQ6VXNlcjg1ODY3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/8586769?v=4","gravatar_id":"","url":"https://api.github.com/users/JacksonKearl","html_url":"https://github.com/JacksonKearl","followers_url":"https://api.github.com/users/JacksonKearl/followers","following_url":"https://api.github.com/users/JacksonKearl/following{/other_user}","gists_url":"https://api.github.com/users/JacksonKearl/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonKearl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonKearl/subscriptions","organizations_url":"https://api.github.com/users/JacksonKearl/orgs","repos_url":"https://api.github.com/users/JacksonKearl/repos","events_url":"https://api.github.com/users/JacksonKearl/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonKearl/received_events","type":"User","site_admin":false},"repo":{"id":116727947,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3Mjc5NDc=","name":"vscode","full_name":"JacksonKearl/vscode","owner":{"login":"JacksonKearl","id":8586769,"node_id":"MDQ6VXNlcjg1ODY3Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/8586769?v=4","gravatar_id":"","url":"https://api.github.com/users/JacksonKearl","html_url":"https://github.com/JacksonKearl","followers_url":"https://api.github.com/users/JacksonKearl/followers","following_url":"https://api.github.com/users/JacksonKearl/following{/other_user}","gists_url":"https://api.github.com/users/JacksonKearl/gists{/gist_id}","starred_url":"https://api.github.com/users/JacksonKearl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacksonKearl/subscriptions","organizations_url":"https://api.github.com/users/JacksonKearl/orgs","repos_url":"https://api.github.com/users/JacksonKearl/repos","events_url":"https://api.github.com/users/JacksonKearl/events{/privacy}","received_events_url":"https://api.github.com/users/JacksonKearl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacksonKearl/vscode","description":"Visual Studio Code","fork":true,"url":"https://api.github.com/repos/JacksonKearl/vscode","forks_url":"https://api.github.com/repos/JacksonKearl/vscode/forks","keys_url":"https://api.github.com/repos/JacksonKearl/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacksonKearl/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacksonKearl/vscode/teams","hooks_url":"https://api.github.com/repos/JacksonKearl/vscode/hooks","issue_events_url":"https://api.github.com/repos/JacksonKearl/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/JacksonKearl/vscode/events","assignees_url":"https://api.github.com/repos/JacksonKearl/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/JacksonKearl/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/JacksonKearl/vscode/tags","blobs_url":"https://api.github.com/repos/JacksonKearl/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacksonKearl/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacksonKearl/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacksonKearl/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacksonKearl/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/JacksonKearl/vscode/languages","stargazers_url":"https://api.github.com/repos/JacksonKearl/vscode/stargazers","contributors_url":"https://api.github.com/repos/JacksonKearl/vscode/contributors","subscribers_url":"https://api.github.com/repos/JacksonKearl/vscode/subscribers","subscription_url":"https://api.github.com/repos/JacksonKearl/vscode/subscription","commits_url":"https://api.github.com/repos/JacksonKearl/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacksonKearl/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacksonKearl/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacksonKearl/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacksonKearl/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/JacksonKearl/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacksonKearl/vscode/merges","archive_url":"https://api.github.com/repos/JacksonKearl/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacksonKearl/vscode/downloads","issues_url":"https://api.github.com/repos/JacksonKearl/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/JacksonKearl/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/JacksonKearl/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/JacksonKearl/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacksonKearl/vscode/labels{/name}","releases_url":"https://api.github.com/repos/JacksonKearl/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/JacksonKearl/vscode/deployments","created_at":"2018-01-08T21:04:54Z","updated_at":"2018-06-05T19:48:48Z","pushed_at":"2018-06-05T19:48:46Z","git_url":"git://github.com/JacksonKearl/vscode.git","ssh_url":"git@github.com:JacksonKearl/vscode.git","clone_url":"https://github.com/JacksonKearl/vscode.git","svn_url":"https://github.com/JacksonKearl/vscode","homepage":"https://code.visualstudio.com","size":138736,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f921e1910fd7bd22adbfe57a6974602231a71417","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41881900,"node_id":"MDEwOlJlcG9zaXRvcnk0MTg4MTkwMA==","name":"vscode","full_name":"Microsoft/vscode","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode","description":"Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode","forks_url":"https://api.github.com/repos/Microsoft/vscode/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode/deployments","created_at":"2015-09-03T20:23:38Z","updated_at":"2018-06-05T19:57:05Z","pushed_at":"2018-06-05T19:52:36Z","git_url":"git://github.com/Microsoft/vscode.git","ssh_url":"git@github.com:Microsoft/vscode.git","clone_url":"https://github.com/Microsoft/vscode.git","svn_url":"https://github.com/Microsoft/vscode","homepage":"https://code.visualstudio.com","size":140355,"stargazers_count":51869,"watchers_count":51869,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6859,"mirror_url":null,"archived":false,"open_issues_count":4829,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6859,"open_issues":4829,"watchers":51869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/51173"},"html":{"href":"https://github.com/Microsoft/vscode/pull/51173"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/51173"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/51173/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/51173/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/51173/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode/statuses/637b3caf908b74f02a6a7b0e0e6511acdc3d8512"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ramya-rao-a"}}