{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/177168853","pull_request_review_id":106991765,"id":177168853,"diff_hunk":"@@ -565,6 +582,27 @@ Best Practices for Writing Tests\n         vm.ReportFailed()\n     }\n \n+\n+Ginkgo Extensions\n+~~~~~~~~~~~~~~~~~~\n+\n+In cilium, some Ginkgo features are extended to cover some uses cases that are\n+useful for how cilium run test\n+\n+BeforeAll\n+^^^^^^^^^^\n+\n+This function will run before all BeforeEach within a describe or context. This\n+function is the new ``SetUp`` or initalize function for our Ginkgo test.\n+\n+AfterAll\n+^^^^^^^^^\n+\n+This function will run after all ``AfterEeach`` functions defined in a Describe or\n+Context. This function is the ``tearDown`` or the ``finilize`` function. The best","path":"Documentation/contributing.rst","position":57,"original_position":57,"commit_id":"dfca6f257f62b0b31fd1f7df57c27e1a903afff8","original_commit_id":"dfca6f257f62b0b31fd1f7df57c27e1a903afff8","user":{"login":"ianvernon","id":3858271,"avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"body":"Change to: A good use case for using `AfterAll` is to remove containers or pods that are needed for multiple `It`s.","created_at":"2018-03-26T17:17:16Z","updated_at":"2018-03-26T17:17:25Z","html_url":"https://github.com/cilium/cilium/pull/3310#discussion_r177168853","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/3310","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/177168853"},"html":{"href":"https://github.com/cilium/cilium/pull/3310#discussion_r177168853"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3310"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/3310","id":177388233,"html_url":"https://github.com/cilium/cilium/pull/3310","diff_url":"https://github.com/cilium/cilium/pull/3310.diff","patch_url":"https://github.com/cilium/cilium/pull/3310.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/3310","number":3310,"state":"open","locked":false,"title":"Documentation: Add Packer-ci-build project and Ginkgo Helpers","user":{"login":"eloycoto","id":868013,"avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Eloy Coto <eloy.coto@gmail.com>\r\n\r\n","created_at":"2018-03-26T09:27:59Z","updated_at":"2018-03-26T17:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"922eb2e87d7cb3f5a44c8177a972f247194229b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":709779088,"url":"https://api.github.com/repos/cilium/cilium/labels/area/CI","name":"area/CI","color":"bfd4f2","default":false},{"id":665378286,"url":"https://api.github.com/repos/cilium/cilium/labels/area/documentation","name":"area/documentation","color":"1d76db","default":false},{"id":403149902,"url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/3310/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/3310/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/3310/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/dfca6f257f62b0b31fd1f7df57c27e1a903afff8","head":{"label":"eloycoto:DocCI","ref":"DocCI","sha":"dfca6f257f62b0b31fd1f7df57c27e1a903afff8","user":{"login":"eloycoto","id":868013,"avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"repo":{"id":93093102,"name":"cilium","full_name":"eloycoto/cilium","owner":{"login":"eloycoto","id":868013,"avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eloycoto/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/eloycoto/cilium","forks_url":"https://api.github.com/repos/eloycoto/cilium/forks","keys_url":"https://api.github.com/repos/eloycoto/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eloycoto/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eloycoto/cilium/teams","hooks_url":"https://api.github.com/repos/eloycoto/cilium/hooks","issue_events_url":"https://api.github.com/repos/eloycoto/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/eloycoto/cilium/events","assignees_url":"https://api.github.com/repos/eloycoto/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/eloycoto/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/eloycoto/cilium/tags","blobs_url":"https://api.github.com/repos/eloycoto/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eloycoto/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eloycoto/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eloycoto/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eloycoto/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/eloycoto/cilium/languages","stargazers_url":"https://api.github.com/repos/eloycoto/cilium/stargazers","contributors_url":"https://api.github.com/repos/eloycoto/cilium/contributors","subscribers_url":"https://api.github.com/repos/eloycoto/cilium/subscribers","subscription_url":"https://api.github.com/repos/eloycoto/cilium/subscription","commits_url":"https://api.github.com/repos/eloycoto/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eloycoto/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eloycoto/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eloycoto/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eloycoto/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/eloycoto/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eloycoto/cilium/merges","archive_url":"https://api.github.com/repos/eloycoto/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eloycoto/cilium/downloads","issues_url":"https://api.github.com/repos/eloycoto/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/eloycoto/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/eloycoto/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/eloycoto/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eloycoto/cilium/labels{/name}","releases_url":"https://api.github.com/repos/eloycoto/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/eloycoto/cilium/deployments","created_at":"2017-06-01T19:40:10Z","updated_at":"2017-06-01T19:40:13Z","pushed_at":"2018-03-26T16:02:39Z","git_url":"git://github.com/eloycoto/cilium.git","ssh_url":"git@github.com:eloycoto/cilium.git","clone_url":"https://github.com/eloycoto/cilium.git","svn_url":"https://github.com/eloycoto/cilium","homepage":"","size":65846,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"f43c706d28e3545e92d0ccd06e0de12e2e74b9c2","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-03-26T14:35:58Z","pushed_at":"2018-03-26T16:22:21Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":43530,"stargazers_count":1691,"watchers_count":1691,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":159,"open_issues":403,"watchers":1691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3310"},"html":{"href":"https://github.com/cilium/cilium/pull/3310"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/3310"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/3310/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3310/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/3310/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/dfca6f257f62b0b31fd1f7df57c27e1a903afff8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ianvernon"}}