{"action":"created","comment":{"url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/comments/168477742","pull_request_review_id":96848801,"id":168477742,"diff_hunk":"@@ -86,33 +86,37 @@ - (void)removeParticipantView:(TVIVideoView *)view identity:(NSString *)identity\n \n - (void)addParticipantView:(TVIVideoView *)view identity:(NSString *)identity  trackId:(NSString *)trackId {\n   // Lookup for the participant in the room\n-  for (TVIParticipant *participant in self.room.participants) {\n+  for (TVIRemoteParticipant *participant in self.room.remoteParticipants) {\n     if ([participant.identity isEqualToString:identity]) {\n-\n       // Lookup for the given trackId\n-      for (TVIVideoTrack *videoTrack in participant.videoTracks) {\n-        [videoTrack addRenderer:view];\n+      for (TVIRemoteVideoTrackPublication *videoTrackPublication in participant.videoTracks) {\n+        [videoTrackPublication.videoTrack addRenderer:view];\n       }\n     }\n   }\n }\n \n+- (void)logMessage:(NSString *)msg {","path":"ios/RCTTWVideoModule.m","position":27,"original_position":27,"commit_id":"ccab01c8bc5b03f754f77d4c38cba0d2e282c25b","original_commit_id":"ccab01c8bc5b03f754f77d4c38cba0d2e282c25b","user":{"login":"bilby91","id":2201079,"avatar_url":"https://avatars0.githubusercontent.com/u/2201079?v=4","gravatar_id":"","url":"https://api.github.com/users/bilby91","html_url":"https://github.com/bilby91","followers_url":"https://api.github.com/users/bilby91/followers","following_url":"https://api.github.com/users/bilby91/following{/other_user}","gists_url":"https://api.github.com/users/bilby91/gists{/gist_id}","starred_url":"https://api.github.com/users/bilby91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilby91/subscriptions","organizations_url":"https://api.github.com/users/bilby91/orgs","repos_url":"https://api.github.com/users/bilby91/repos","events_url":"https://api.github.com/users/bilby91/events{/privacy}","received_events_url":"https://api.github.com/users/bilby91/received_events","type":"User","site_admin":false},"body":"If we are going to add logging, user's should be able to turn it on/off. Maybe we can do this in a separate PR and remove the logging for the moment and just focus on 2.0","created_at":"2018-02-15T13:42:39Z","updated_at":"2018-02-15T13:48:46Z","html_url":"https://github.com/blackuy/react-native-twilio-video-webrtc/pull/85#discussion_r168477742","pull_request_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/comments/168477742"},"html":{"href":"https://github.com/blackuy/react-native-twilio-video-webrtc/pull/85#discussion_r168477742"},"pull_request":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85","id":164852599,"html_url":"https://github.com/blackuy/react-native-twilio-video-webrtc/pull/85","diff_url":"https://github.com/blackuy/react-native-twilio-video-webrtc/pull/85.diff","patch_url":"https://github.com/blackuy/react-native-twilio-video-webrtc/pull/85.patch","issue_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues/85","number":85,"state":"open","locked":false,"title":"Initial implementation of twilio-video ios sdk 2.0.0","user":{"login":"cipriancaba","id":695515,"avatar_url":"https://avatars1.githubusercontent.com/u/695515?v=4","gravatar_id":"","url":"https://api.github.com/users/cipriancaba","html_url":"https://github.com/cipriancaba","followers_url":"https://api.github.com/users/cipriancaba/followers","following_url":"https://api.github.com/users/cipriancaba/following{/other_user}","gists_url":"https://api.github.com/users/cipriancaba/gists{/gist_id}","starred_url":"https://api.github.com/users/cipriancaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipriancaba/subscriptions","organizations_url":"https://api.github.com/users/cipriancaba/orgs","repos_url":"https://api.github.com/users/cipriancaba/repos","events_url":"https://api.github.com/users/cipriancaba/events{/privacy}","received_events_url":"https://api.github.com/users/cipriancaba/received_events","type":"User","site_admin":false},"body":"Just added the new dependency and updated some of the methods.. Not everything was implemented as I didn't want to modify the API of the library as that requires a separate discussion\r\n\r\nPlease note that this is work in progress and should be seen as a kickstart for #64 ","created_at":"2018-01-24T13:46:15Z","updated_at":"2018-02-15T13:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cb73f400f153687cdbe9aecfc9417ff8ad51c5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85/commits","review_comments_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85/comments","review_comment_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues/85/comments","statuses_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/statuses/ccab01c8bc5b03f754f77d4c38cba0d2e282c25b","head":{"label":"cipriancaba:update-to-twilio-sdk-2.0.0","ref":"update-to-twilio-sdk-2.0.0","sha":"ccab01c8bc5b03f754f77d4c38cba0d2e282c25b","user":{"login":"cipriancaba","id":695515,"avatar_url":"https://avatars1.githubusercontent.com/u/695515?v=4","gravatar_id":"","url":"https://api.github.com/users/cipriancaba","html_url":"https://github.com/cipriancaba","followers_url":"https://api.github.com/users/cipriancaba/followers","following_url":"https://api.github.com/users/cipriancaba/following{/other_user}","gists_url":"https://api.github.com/users/cipriancaba/gists{/gist_id}","starred_url":"https://api.github.com/users/cipriancaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipriancaba/subscriptions","organizations_url":"https://api.github.com/users/cipriancaba/orgs","repos_url":"https://api.github.com/users/cipriancaba/repos","events_url":"https://api.github.com/users/cipriancaba/events{/privacy}","received_events_url":"https://api.github.com/users/cipriancaba/received_events","type":"User","site_admin":false},"repo":{"id":108547062,"name":"react-native-twilio-video-webrtc","full_name":"cipriancaba/react-native-twilio-video-webrtc","owner":{"login":"cipriancaba","id":695515,"avatar_url":"https://avatars1.githubusercontent.com/u/695515?v=4","gravatar_id":"","url":"https://api.github.com/users/cipriancaba","html_url":"https://github.com/cipriancaba","followers_url":"https://api.github.com/users/cipriancaba/followers","following_url":"https://api.github.com/users/cipriancaba/following{/other_user}","gists_url":"https://api.github.com/users/cipriancaba/gists{/gist_id}","starred_url":"https://api.github.com/users/cipriancaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cipriancaba/subscriptions","organizations_url":"https://api.github.com/users/cipriancaba/orgs","repos_url":"https://api.github.com/users/cipriancaba/repos","events_url":"https://api.github.com/users/cipriancaba/events{/privacy}","received_events_url":"https://api.github.com/users/cipriancaba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cipriancaba/react-native-twilio-video-webrtc","description":"Twilio Video (WebRTC) for React Native","fork":true,"url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc","forks_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/forks","keys_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/teams","hooks_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/hooks","issue_events_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/events","assignees_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/tags","blobs_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/languages","stargazers_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/stargazers","contributors_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/contributors","subscribers_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/subscribers","subscription_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/subscription","commits_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/merges","archive_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/downloads","issues_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/releases{/id}","deployments_url":"https://api.github.com/repos/cipriancaba/react-native-twilio-video-webrtc/deployments","created_at":"2017-10-27T13:04:28Z","updated_at":"2017-10-27T13:04:30Z","pushed_at":"2018-01-24T13:42:50Z","git_url":"git://github.com/cipriancaba/react-native-twilio-video-webrtc.git","ssh_url":"git@github.com:cipriancaba/react-native-twilio-video-webrtc.git","clone_url":"https://github.com/cipriancaba/react-native-twilio-video-webrtc.git","svn_url":"https://github.com/cipriancaba/react-native-twilio-video-webrtc","homepage":"","size":21303,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blackuy:master","ref":"master","sha":"5260f385936fd89ffc1286b9fc4bd76ae93514ba","user":{"login":"blackuy","id":25539583,"avatar_url":"https://avatars1.githubusercontent.com/u/25539583?v=4","gravatar_id":"","url":"https://api.github.com/users/blackuy","html_url":"https://github.com/blackuy","followers_url":"https://api.github.com/users/blackuy/followers","following_url":"https://api.github.com/users/blackuy/following{/other_user}","gists_url":"https://api.github.com/users/blackuy/gists{/gist_id}","starred_url":"https://api.github.com/users/blackuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackuy/subscriptions","organizations_url":"https://api.github.com/users/blackuy/orgs","repos_url":"https://api.github.com/users/blackuy/repos","events_url":"https://api.github.com/users/blackuy/events{/privacy}","received_events_url":"https://api.github.com/users/blackuy/received_events","type":"Organization","site_admin":false},"repo":{"id":72937356,"name":"react-native-twilio-video-webrtc","full_name":"blackuy/react-native-twilio-video-webrtc","owner":{"login":"blackuy","id":25539583,"avatar_url":"https://avatars1.githubusercontent.com/u/25539583?v=4","gravatar_id":"","url":"https://api.github.com/users/blackuy","html_url":"https://github.com/blackuy","followers_url":"https://api.github.com/users/blackuy/followers","following_url":"https://api.github.com/users/blackuy/following{/other_user}","gists_url":"https://api.github.com/users/blackuy/gists{/gist_id}","starred_url":"https://api.github.com/users/blackuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackuy/subscriptions","organizations_url":"https://api.github.com/users/blackuy/orgs","repos_url":"https://api.github.com/users/blackuy/repos","events_url":"https://api.github.com/users/blackuy/events{/privacy}","received_events_url":"https://api.github.com/users/blackuy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blackuy/react-native-twilio-video-webrtc","description":"Twilio Video (WebRTC) for React Native","fork":false,"url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc","forks_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/forks","keys_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/teams","hooks_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/hooks","issue_events_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/events","assignees_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/tags","blobs_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/languages","stargazers_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/stargazers","contributors_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/contributors","subscribers_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/subscribers","subscription_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/subscription","commits_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/merges","archive_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/downloads","issues_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/labels{/name}","releases_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/releases{/id}","deployments_url":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/deployments","created_at":"2016-11-05T16:07:50Z","updated_at":"2018-02-09T18:52:45Z","pushed_at":"2018-02-15T12:42:56Z","git_url":"git://github.com/blackuy/react-native-twilio-video-webrtc.git","ssh_url":"git@github.com:blackuy/react-native-twilio-video-webrtc.git","clone_url":"https://github.com/blackuy/react-native-twilio-video-webrtc.git","svn_url":"https://github.com/blackuy/react-native-twilio-video-webrtc","homepage":"","size":21254,"stargazers_count":71,"watchers_count":71,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":42,"open_issues":16,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85"},"html":{"href":"https://github.com/blackuy/react-native-twilio-video-webrtc/pull/85"},"issue":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues/85"},"comments":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/blackuy/react-native-twilio-video-webrtc/statuses/ccab01c8bc5b03f754f77d4c38cba0d2e282c25b"}},"author_association":"NONE"}}
{"actor":{"display_login":"bilby91"}}