{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/244","id":185870819,"html_url":"https://github.com/sillsdev/web-languageforge/pull/244","diff_url":"https://github.com/sillsdev/web-languageforge/pull/244.diff","patch_url":"https://github.com/sillsdev/web-languageforge/pull/244.patch","issue_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/244","number":244,"state":"closed","locked":false,"title":"Allow comments to appear directly on the main entry","user":{"login":"nigel-wells","id":17464863,"avatar_url":"https://avatars0.githubusercontent.com/u/17464863?v=4","gravatar_id":"","url":"https://api.github.com/users/nigel-wells","html_url":"https://github.com/nigel-wells","followers_url":"https://api.github.com/users/nigel-wells/followers","following_url":"https://api.github.com/users/nigel-wells/following{/other_user}","gists_url":"https://api.github.com/users/nigel-wells/gists{/gist_id}","starred_url":"https://api.github.com/users/nigel-wells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigel-wells/subscriptions","organizations_url":"https://api.github.com/users/nigel-wells/orgs","repos_url":"https://api.github.com/users/nigel-wells/repos","events_url":"https://api.github.com/users/nigel-wells/events{/privacy}","received_events_url":"https://api.github.com/users/nigel-wells/received_events","type":"User","site_admin":false},"body":"Relates to https://trello.com/c/5nmjsPhK\r\n\r\n3 E2E tests are failing - same as `master`\r\n\r\nNew comments can not be posted directly against the entry - view only. Replying is allowed for any comments that do appear on the entry.\r\n\r\nIf no comments are set on the entry then the comment bubble is hidden. No point showing it as clicking it would effectively do nothing as you can't comment.\r\n\r\nHave tested with a comment on the entry that has no `contextGuid` set. I've not been able to test with a real sync though - hopefully it is fine though. So long as the `contextGuid` is undefined OR an empty string then it will be fine. Otherwise, if the sync wants to be updated, the `contextGuid` can be set to `\"entry\"`\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sillsdev/web-languageforge/244)\n<!-- Reviewable:end -->\n","created_at":"2018-05-04T00:31:18Z","updated_at":"2018-05-04T03:37:45Z","closed_at":"2018-05-04T03:37:45Z","merged_at":"2018-05-04T03:37:44Z","merge_commit_sha":"d0adca401813dc28579fa02dd8a121c4d8be57be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/244/commits","review_comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/244/comments","review_comment_url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/244/comments","statuses_url":"https://api.github.com/repos/sillsdev/web-languageforge/statuses/7e4a0fbbe824d6a221646f252c44cd4105972234","head":{"label":"sillsdev:apex/entry-comments","ref":"apex/entry-comments","sha":"7e4a0fbbe824d6a221646f252c44cd4105972234","user":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars1.githubusercontent.com/u/1095739?v=4","gravatar_id":"","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"repo":{"id":16717528,"name":"web-languageforge","full_name":"sillsdev/web-languageforge","owner":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars1.githubusercontent.com/u/1095739?v=4","gravatar_id":"","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sillsdev/web-languageforge","description":"Online Collaborative Dictionary Building on the Web and Phone","fork":false,"url":"https://api.github.com/repos/sillsdev/web-languageforge","forks_url":"https://api.github.com/repos/sillsdev/web-languageforge/forks","keys_url":"https://api.github.com/repos/sillsdev/web-languageforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sillsdev/web-languageforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sillsdev/web-languageforge/teams","hooks_url":"https://api.github.com/repos/sillsdev/web-languageforge/hooks","issue_events_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/events{/number}","events_url":"https://api.github.com/repos/sillsdev/web-languageforge/events","assignees_url":"https://api.github.com/repos/sillsdev/web-languageforge/assignees{/user}","branches_url":"https://api.github.com/repos/sillsdev/web-languageforge/branches{/branch}","tags_url":"https://api.github.com/repos/sillsdev/web-languageforge/tags","blobs_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sillsdev/web-languageforge/statuses/{sha}","languages_url":"https://api.github.com/repos/sillsdev/web-languageforge/languages","stargazers_url":"https://api.github.com/repos/sillsdev/web-languageforge/stargazers","contributors_url":"https://api.github.com/repos/sillsdev/web-languageforge/contributors","subscribers_url":"https://api.github.com/repos/sillsdev/web-languageforge/subscribers","subscription_url":"https://api.github.com/repos/sillsdev/web-languageforge/subscription","commits_url":"https://api.github.com/repos/sillsdev/web-languageforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/sillsdev/web-languageforge/contents/{+path}","compare_url":"https://api.github.com/repos/sillsdev/web-languageforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sillsdev/web-languageforge/merges","archive_url":"https://api.github.com/repos/sillsdev/web-languageforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sillsdev/web-languageforge/downloads","issues_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues{/number}","pulls_url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls{/number}","milestones_url":"https://api.github.com/repos/sillsdev/web-languageforge/milestones{/number}","notifications_url":"https://api.github.com/repos/sillsdev/web-languageforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sillsdev/web-languageforge/labels{/name}","releases_url":"https://api.github.com/repos/sillsdev/web-languageforge/releases{/id}","deployments_url":"https://api.github.com/repos/sillsdev/web-languageforge/deployments","created_at":"2014-02-11T03:04:26Z","updated_at":"2018-05-04T02:29:54Z","pushed_at":"2018-05-04T03:37:44Z","git_url":"git://github.com/sillsdev/web-languageforge.git","ssh_url":"git@github.com:sillsdev/web-languageforge.git","clone_url":"https://github.com/sillsdev/web-languageforge.git","svn_url":"https://github.com/sillsdev/web-languageforge","homepage":"https://languageforge.org","size":309149,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":4,"watchers":19,"default_branch":"master"}},"base":{"label":"sillsdev:master","ref":"master","sha":"5bd264b90a42a9a5de2ecb5f1b68ab1d64d668d3","user":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars1.githubusercontent.com/u/1095739?v=4","gravatar_id":"","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"repo":{"id":16717528,"name":"web-languageforge","full_name":"sillsdev/web-languageforge","owner":{"login":"sillsdev","id":1095739,"avatar_url":"https://avatars1.githubusercontent.com/u/1095739?v=4","gravatar_id":"","url":"https://api.github.com/users/sillsdev","html_url":"https://github.com/sillsdev","followers_url":"https://api.github.com/users/sillsdev/followers","following_url":"https://api.github.com/users/sillsdev/following{/other_user}","gists_url":"https://api.github.com/users/sillsdev/gists{/gist_id}","starred_url":"https://api.github.com/users/sillsdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sillsdev/subscriptions","organizations_url":"https://api.github.com/users/sillsdev/orgs","repos_url":"https://api.github.com/users/sillsdev/repos","events_url":"https://api.github.com/users/sillsdev/events{/privacy}","received_events_url":"https://api.github.com/users/sillsdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sillsdev/web-languageforge","description":"Online Collaborative Dictionary Building on the Web and Phone","fork":false,"url":"https://api.github.com/repos/sillsdev/web-languageforge","forks_url":"https://api.github.com/repos/sillsdev/web-languageforge/forks","keys_url":"https://api.github.com/repos/sillsdev/web-languageforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sillsdev/web-languageforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sillsdev/web-languageforge/teams","hooks_url":"https://api.github.com/repos/sillsdev/web-languageforge/hooks","issue_events_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/events{/number}","events_url":"https://api.github.com/repos/sillsdev/web-languageforge/events","assignees_url":"https://api.github.com/repos/sillsdev/web-languageforge/assignees{/user}","branches_url":"https://api.github.com/repos/sillsdev/web-languageforge/branches{/branch}","tags_url":"https://api.github.com/repos/sillsdev/web-languageforge/tags","blobs_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sillsdev/web-languageforge/statuses/{sha}","languages_url":"https://api.github.com/repos/sillsdev/web-languageforge/languages","stargazers_url":"https://api.github.com/repos/sillsdev/web-languageforge/stargazers","contributors_url":"https://api.github.com/repos/sillsdev/web-languageforge/contributors","subscribers_url":"https://api.github.com/repos/sillsdev/web-languageforge/subscribers","subscription_url":"https://api.github.com/repos/sillsdev/web-languageforge/subscription","commits_url":"https://api.github.com/repos/sillsdev/web-languageforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/sillsdev/web-languageforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/sillsdev/web-languageforge/contents/{+path}","compare_url":"https://api.github.com/repos/sillsdev/web-languageforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sillsdev/web-languageforge/merges","archive_url":"https://api.github.com/repos/sillsdev/web-languageforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sillsdev/web-languageforge/downloads","issues_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues{/number}","pulls_url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls{/number}","milestones_url":"https://api.github.com/repos/sillsdev/web-languageforge/milestones{/number}","notifications_url":"https://api.github.com/repos/sillsdev/web-languageforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sillsdev/web-languageforge/labels{/name}","releases_url":"https://api.github.com/repos/sillsdev/web-languageforge/releases{/id}","deployments_url":"https://api.github.com/repos/sillsdev/web-languageforge/deployments","created_at":"2014-02-11T03:04:26Z","updated_at":"2018-05-04T02:29:54Z","pushed_at":"2018-05-04T03:37:44Z","git_url":"git://github.com/sillsdev/web-languageforge.git","ssh_url":"git@github.com:sillsdev/web-languageforge.git","clone_url":"https://github.com/sillsdev/web-languageforge.git","svn_url":"https://github.com/sillsdev/web-languageforge","homepage":"https://languageforge.org","size":309149,"stargazers_count":19,"watchers_count":19,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":4,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/244"},"html":{"href":"https://github.com/sillsdev/web-languageforge/pull/244"},"issue":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/issues/244"},"comments":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/sillsdev/web-languageforge/statuses/7e4a0fbbe824d6a221646f252c44cd4105972234"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"megahirt","id":3444521,"avatar_url":"https://avatars2.githubusercontent.com/u/3444521?v=4","gravatar_id":"","url":"https://api.github.com/users/megahirt","html_url":"https://github.com/megahirt","followers_url":"https://api.github.com/users/megahirt/followers","following_url":"https://api.github.com/users/megahirt/following{/other_user}","gists_url":"https://api.github.com/users/megahirt/gists{/gist_id}","starred_url":"https://api.github.com/users/megahirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megahirt/subscriptions","organizations_url":"https://api.github.com/users/megahirt/orgs","repos_url":"https://api.github.com/users/megahirt/repos","events_url":"https://api.github.com/users/megahirt/events{/privacy}","received_events_url":"https://api.github.com/users/megahirt/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":4,"changed_files":8}}
{"actor":{"display_login":"megahirt"}}