{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/208467683","pull_request_review_id":144275471,"id":208467683,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQ2NzY4Mw==","diff_hunk":"@@ -49,21 +63,149 @@ createWallet wallet (V1.NewWallet (V1.BackupPhrase mnemonic) mbSpendingPassword\n                       Left kernelError ->\n                           return (Left $ CreateWalletError kernelError)\n                       Right hdRoot -> do\n-                          let (hasSpendingPassword, mbLastUpdate) =\n-                                  case hdRoot ^. HD.hdRootHasPassword of\n-                                       HD.NoSpendingPassword -> (False, Nothing)\n-                                       HD.HasSpendingPassword lastUpdate -> (True, Just (lastUpdate ^. fromDb))\n-                          now <- liftIO getCurrentTimestamp\n-                          let lastUpdate = fromMaybe now mbLastUpdate\n-                          let createdAt  = hdRoot ^. HD.hdRootCreatedAt . fromDb\n-                          let walletId = hdRoot ^. HD.hdRootId . to (sformat build . _fromDb . HD.getHdRootId)\n-                          return $ Right V1.Wallet {\n-                              walId                         = (V1.WalletId walletId)\n-                            , walName                       = v1WalletName\n-                            , walBalance                    = V1 (mkCoin 0)\n-                            , walHasSpendingPassword        = hasSpendingPassword\n-                            , walSpendingPasswordLastUpdate = V1 lastUpdate\n-                            , walCreatedAt                  = V1 createdAt\n-                            , walAssuranceLevel             = v1AssuranceLevel\n-                            , walSyncState                  = V1.Synced\n-                          }\n+                          let rootId = hdRoot ^. HD.hdRootId\n+                          -- Populate this wallet with an account by default\n+                          newAccount <- liftIO $ Kernel.createAccount spendingPassword\n+                                                                      (HD.AccountName \"Default account\")\n+                                                                      (WalletIdHdRnd rootId)\n+                                                                      wallet\n+                          case newAccount of\n+                               Left accCreationFailed ->\n+                                   return (Left $ CreateWalletFirstAccountCreationFailed accCreationFailed)\n+                               Right _ -> do\n+                                   let (hasSpendingPassword, mbLastUpdate) =\n+                                           case hdRoot ^. HD.hdRootHasPassword of\n+                                                HD.NoSpendingPassword -> (False, Nothing)\n+                                                HD.HasSpendingPassword lu -> (True, Just (lu ^. fromDb))\n+                                   now <- liftIO getCurrentTimestamp\n+                                   let lastUpdate = fromMaybe now mbLastUpdate\n+                                   let createdAt  = hdRoot ^. HD.hdRootCreatedAt . fromDb\n+                                   let walletId = hdRoot ^. HD.hdRootId . to (sformat build . _fromDb . HD.getHdRootId)\n+                                   return $ Right V1.Wallet {\n+                                       walId                         = (V1.WalletId walletId)\n+                                     , walName                       = v1WalletName\n+                                     , walBalance                    = V1 (mkCoin 0)\n+                                     , walHasSpendingPassword        = hasSpendingPassword\n+                                     , walSpendingPasswordLastUpdate = V1 lastUpdate\n+                                     , walCreatedAt                  = V1 createdAt\n+                                     , walAssuranceLevel             = v1AssuranceLevel\n+                                     , walSyncState                  = V1.Synced\n+                                   }\n+\n+-- | Updates the 'SpendingPassword' for this wallet.\n+updateWallet :: MonadIO m\n+             => Kernel.PassiveWallet\n+             -> V1.WalletId\n+             -> V1.WalletUpdate\n+             -> m (Either UpdateWalletError V1.Wallet)\n+updateWallet wallet (V1.WalletId wId) (V1.WalletUpdate v1Level v1Name) = do\n+    case decodeTextAddress wId of\n+        Left _ -> return $ Left (UpdateWalletWalletIdDecodingFailed wId)\n+        Right rootAddr -> do\n+           let hdRootId = HD.HdRootId . InDb $ rootAddr\n+               newLevel = fromV1AssuranceLevel v1Level\n+               newName  = HD.WalletName v1Name\n+           res <- liftIO $ Kernel.updateHdWallet wallet hdRootId newLevel newName\n+           case res of\n+                Left e  -> return $ Left (UpdateWalletError (V1 e))\n+                Right (db, updatedWallet) ->\n+                    return $ Right $ toV1Wallet db updatedWallet\n+\n+-- | Updates the 'SpendingPassword' for this wallet.\n+updateWalletPassword :: MonadIO m\n+                     => Kernel.PassiveWallet\n+                     -> V1.WalletId\n+                     -> V1.PasswordUpdate\n+                     -> m (Either UpdateWalletPasswordError V1.Wallet)\n+updateWalletPassword wallet (V1.WalletId wId) (V1.PasswordUpdate (V1 oldPwd) (V1 newPwd)) =\n+    case decodeTextAddress wId of\n+        Left _ -> return $ Left (UpdateWalletPasswordWalletIdDecodingFailed wId)\n+        Right rootAddr -> do\n+           let hdRootId = HD.HdRootId . InDb $ rootAddr\n+           res <- liftIO $ Kernel.updatePassword wallet hdRootId oldPwd newPwd\n+           case res of\n+                Left e  -> return $ Left (UpdateWalletPasswordError e)\n+                Right (db, updatedWallet) ->\n+                    return $ Right $ toV1Wallet db updatedWallet\n+\n+-- | Updates the 'SpendingPassword' for this wallet.\n+deleteWallet :: MonadIO m\n+             => Kernel.PassiveWallet\n+             -> V1.WalletId\n+             -> m (Either DeleteWalletError ())\n+deleteWallet wallet (V1.WalletId wId) =\n+    case decodeTextAddress wId of\n+        Left _ -> return $ Left (DeleteWalletWalletIdDecodingFailed wId)\n+        Right rootAddr -> do\n+           let hdRootId = HD.HdRootId . InDb $ rootAddr\n+           res <- liftIO $ Kernel.deleteHdWallet wallet hdRootId\n+           case res of\n+                Left e   -> return $ Left (DeleteWalletError (V1 e))\n+                Right () -> return $ Right ()\n+\n+-- | Gets a specific wallet.\n+getWallet :: Kernel.DB\n+          -> V1.WalletId\n+          -> Either GetWalletError V1.Wallet\n+getWallet db (V1.WalletId wId) =\n+    case decodeTextAddress wId of\n+        Left _ -> Left (GetWalletWalletIdDecodingFailed wId)\n+        Right rootAddr -> do\n+           let hdRootId = HD.HdRootId . InDb $ rootAddr\n+           case readHdRoot hdRootId (hdWallets db) of\n+                Left dbErr -> Left (GetWalletError (V1 dbErr))\n+                Right w    -> Right (toV1Wallet db w)\n+\n+-- | Gets all the wallets known to this edge node.\n+getWallets :: Kernel.DB -> IxSet V1.Wallet\n+getWallets db =\n+    let allRoots = readAllHdRoots (hdWallets db)\n+    in IxSet.fromList . map (toV1Wallet db) . IxSet.toList $ allRoots\n+\n+{------------------------------------------------------------------------------\n+  General utility functions on the wallets.\n+------------------------------------------------------------------------------}\n+\n+-- | Converts an 'HdRoot' into a V1 'Wallet.\n+toV1Wallet :: Kernel.DB -> HD.HdRoot -> V1.Wallet\n+toV1Wallet db hdRoot =\n+    let (hasSpendingPassword, mbLastUpdate) =\n+            case hdRoot ^. HD.hdRootHasPassword of\n+                 HD.NoSpendingPassword     -> (False, Nothing)\n+                 HD.HasSpendingPassword lu -> (True, Just (lu ^. fromDb))\n+        -- In case the wallet has no spending password, its last update\n+        -- matches this wallet creation time.\n+        rootId = hdRoot ^. HD.hdRootId\n+        createdAt  = hdRoot ^. HD.hdRootCreatedAt . fromDb\n+        lastUpdate = fromMaybe createdAt mbLastUpdate\n+        walletId   = sformat build . _fromDb . HD.getHdRootId $ rootId\n+        v1AssuranceLevel = case hdRoot ^. HD.hdRootAssurance of\n+                               HD.AssuranceLevelNormal -> V1.NormalAssurance\n+                               HD.AssuranceLevelStrict -> V1.StrictAssurance\n+    in V1.Wallet {\n+        walId                         = (V1.WalletId walletId)\n+      , walName                       = hdRoot ^. HD.hdRootName\n+                                                . to HD.getWalletName\n+      , walBalance                    = V1 (walletTotalBalance db rootId)\n+      , walHasSpendingPassword        = hasSpendingPassword\n+      , walSpendingPasswordLastUpdate = V1 lastUpdate\n+      , walCreatedAt                  = V1 createdAt\n+      , walAssuranceLevel             = v1AssuranceLevel\n+      -- FIXME(adn) Do this as part of CBR-243.\n+      , walSyncState                  = V1.Synced\n+    }\n+\n+-- | Converts from the @V1@ 'AssuranceLevel' to the HD one.\n+fromV1AssuranceLevel :: V1.AssuranceLevel -> HD.AssuranceLevel\n+fromV1AssuranceLevel V1.NormalAssurance = HD.AssuranceLevelNormal\n+fromV1AssuranceLevel V1.StrictAssurance = HD.AssuranceLevelStrict\n+\n+-- | Computes the total balance for this wallet, given its 'HdRootId'.","path":"wallet-new/src/Cardano/Wallet/WalletLayer/Kernel/Wallets.hs","position":200,"original_position":200,"commit_id":"d968c6e86cf0416c942ca0347e72bead48b99cb3","original_commit_id":"d968c6e86cf0416c942ca0347e72bead48b99cb3","user":{"login":"edsko","id":935288,"node_id":"MDQ6VXNlcjkzNTI4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/935288?v=4","gravatar_id":"","url":"https://api.github.com/users/edsko","html_url":"https://github.com/edsko","followers_url":"https://api.github.com/users/edsko/followers","following_url":"https://api.github.com/users/edsko/following{/other_user}","gists_url":"https://api.github.com/users/edsko/gists{/gist_id}","starred_url":"https://api.github.com/users/edsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsko/subscriptions","organizations_url":"https://api.github.com/users/edsko/orgs","repos_url":"https://api.github.com/users/edsko/repos","events_url":"https://api.github.com/users/edsko/events{/privacy}","received_events_url":"https://api.github.com/users/edsko/received_events","type":"User","site_admin":false},"body":"This shouldn't live here but in the appropriate `.Read` module.","created_at":"2018-08-08T06:24:53Z","updated_at":"2018-08-08T06:26:22Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3347#discussion_r208467683","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/208467683"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/3347#discussion_r208467683"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347","id":205997944,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTk3OTQ0","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3347","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/3347.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/3347.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3347","number":3347,"state":"open","locked":false,"title":"[CBR-350] Wallets handlers implemented with the new data layer","user":{"login":"adinapoli-iohk","id":29383371,"node_id":"MDQ6VXNlcjI5MzgzMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/29383371?v=4","gravatar_id":"","url":"https://api.github.com/users/adinapoli-iohk","html_url":"https://github.com/adinapoli-iohk","followers_url":"https://api.github.com/users/adinapoli-iohk/followers","following_url":"https://api.github.com/users/adinapoli-iohk/following{/other_user}","gists_url":"https://api.github.com/users/adinapoli-iohk/gists{/gist_id}","starred_url":"https://api.github.com/users/adinapoli-iohk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adinapoli-iohk/subscriptions","organizations_url":"https://api.github.com/users/adinapoli-iohk/orgs","repos_url":"https://api.github.com/users/adinapoli-iohk/repos","events_url":"https://api.github.com/users/adinapoli-iohk/events{/privacy}","received_events_url":"https://api.github.com/users/adinapoli-iohk/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR delivers the full range of Servant handlers for `/api/v1/wallets` implemented with the new data layer. @edsko It should be all straightforward coding although I suspect there are some bits to focus on when the review time will come. In no particular order:\r\n\r\n- I have changed the implementation of `IxSet.Foldable` which avoids a needless destruction of the native IxSet into a list. What we get for free is that we have now a hopefully reasonable implementation of `foldr` and thanks to that `foldM` for free, which I have relied upon in my \"cascade-deletion\" code;\r\n\r\n- When deleting a wallet, we do this in a cascading style: we also delete all the associated accounts and transitively all the associated addresses. If you squint a bit, you will see that the implementations of `deleteHdWallet` and `deleteHdAccount` differs on the order in which we delete things. Strangely enough, in `deleteHdAccount` if I was deleting the account first and invoking `deleteHdAddress` after, the kernel was rightly informing me that the address I was trying to delete was dangling and didn't have any associated account. Conversely, when I was trying to delete a wallet, the order of deletion is `root -> accounts` but strangely enough my tests didn't complain, almost as if `zoomHdAccountId` is not checking properly for the existence of the `hdRoot`. Any clue?\r\n\r\n- In preparation for CBR-347, I have used a pattern like `IxSet.foldl' (IxSet.insert (map toV1Type input)) IxSet.emptyIxSet` to avoid the deconstruction and reconstruction of the original IxSet containing kernel data, which shaves some CPU cycles I guess.\r\n\r\n- I had to remove the bogus dummy wallet that @matt-noonan introduced in his original work on the wallet worker, as it was causing a test to fail due to the fact it was effectively creating an extra wallet that was causing my `getWallets` invariants to fail.\r\n\r\nComprehensive testing is provided.\r\n\r\n## Linked issue\r\n\r\n\r\n\r\n## Type of change\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: -->\r\n- [ ] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [x] 🛠 New feature (non-breaking change which adds functionality)\r\n- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [ ] 🔨 New or improved tests for existing code\r\n- [ ] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n<!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: --->\r\n- [x] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [x] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n\r\n## Testing checklist\r\n<!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. -->\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## QA Steps\r\n<!--- Which are the steps needed to test this feature, if any? -->\r\n\r\n## Screenshots (if available)\r\n<!--- Upload a GIF, an asciinema video or an image demoing the feature -->\r\n","created_at":"2018-08-03T11:06:27Z","updated_at":"2018-08-08T06:26:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d05843187cbcf8ec6435bf20013a1ab102341ff2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3347/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/d968c6e86cf0416c942ca0347e72bead48b99cb3","head":{"label":"input-output-hk:feature/cbr-350-wallets-handlers","ref":"feature/cbr-350-wallets-handlers","sha":"d968c6e86cf0416c942ca0347e72bead48b99cb3","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkxMzk5Nw==","name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-08-08T05:55:57Z","pushed_at":"2018-08-08T03:14:24Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":114190,"stargazers_count":2801,"watchers_count":2801,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":477,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":477,"open_issues":186,"watchers":2801,"default_branch":"develop"}},"base":{"label":"input-output-hk:develop","ref":"develop","sha":"3a6e31af089b80270e5dbd66b072786741450d6b","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkxMzk5Nw==","name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-08-08T05:55:57Z","pushed_at":"2018-08-08T03:14:24Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":114190,"stargazers_count":2801,"watchers_count":2801,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":477,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":477,"open_issues":186,"watchers":2801,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/3347"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3347"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3347/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3347/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/d968c6e86cf0416c942ca0347e72bead48b99cb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"edsko"}}