{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/169263476","pull_request_review_id":97759133,"id":169263476,"diff_hunk":"@@ -54,6 +54,29 @@ outputs:\n     description: Floating IPs of the nodes\n     value: { get_attr: [ infra_nodes, floating_ip ] }\n \n+  api_ip:\n+    description: IP address for the API/UI endpoint\n+{% if openshift_openstack_use_lbaas_load_balancer %}\n+    # TODO(shadower): Handle setups without floating IPs\n+    value: { get_attr: [lb_floating_ip, floating_ip_address] }\n+{% elif openshift_openstack_use_vm_load_balancer %}\n+    value: { get_attr: [loadbalancer, resource.0, floating_ip] }\n+{% else %}\n+    value: { get_attr: [masters, resource.0, floating_ip] }\n+{% endif %}\n+\n+  apps_ip:\n+    description: IP address of the apps/router endpoint\n+{% if openshift_openstack_use_lbaas_load_balancer %}\n+    value: { get_attr: [lb_floating_ip, floating_ip_address] }\n+{% elif openshift_openstack_use_vm_load_balancer %}\n+    # NOTE(shadower): The VM-based loadbalancer only supports master nodes","path":"roles/openshift_openstack/templates/heat_stack.yaml.j2","position":20,"original_position":20,"commit_id":"7a9a5aad16a4cfe3cfbffa7314f45b2c99895cae","original_commit_id":"7a9a5aad16a4cfe3cfbffa7314f45b2c99895cae","user":{"login":"bogdando","id":2795820,"avatar_url":"https://avatars0.githubusercontent.com/u/2795820?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdando","html_url":"https://github.com/bogdando","followers_url":"https://api.github.com/users/bogdando/followers","following_url":"https://api.github.com/users/bogdando/following{/other_user}","gists_url":"https://api.github.com/users/bogdando/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdando/subscriptions","organizations_url":"https://api.github.com/users/bogdando/orgs","repos_url":"https://api.github.com/users/bogdando/repos","events_url":"https://api.github.com/users/bogdando/events{/privacy}","received_events_url":"https://api.github.com/users/bogdando/received_events","type":"User","site_admin":false},"body":"this prolly worth of a note in the docs","created_at":"2018-02-20T09:46:38Z","updated_at":"2018-02-20T09:46:38Z","html_url":"https://github.com/openshift/openshift-ansible/pull/7209#discussion_r169263476","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/169263476"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/7209#discussion_r169263476"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209","id":170138437,"html_url":"https://github.com/openshift/openshift-ansible/pull/7209","diff_url":"https://github.com/openshift/openshift-ansible/pull/7209.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/7209.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7209","number":7209,"state":"open","locked":false,"title":"Add the OpenStack load balancer deployment options","user":{"login":"tomassedovic","id":104339,"avatar_url":"https://avatars1.githubusercontent.com/u/104339?v=4","gravatar_id":"","url":"https://api.github.com/users/tomassedovic","html_url":"https://github.com/tomassedovic","followers_url":"https://api.github.com/users/tomassedovic/followers","following_url":"https://api.github.com/users/tomassedovic/following{/other_user}","gists_url":"https://api.github.com/users/tomassedovic/gists{/gist_id}","starred_url":"https://api.github.com/users/tomassedovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomassedovic/subscriptions","organizations_url":"https://api.github.com/users/tomassedovic/orgs","repos_url":"https://api.github.com/users/tomassedovic/repos","events_url":"https://api.github.com/users/tomassedovic/events{/privacy}","received_events_url":"https://api.github.com/users/tomassedovic/received_events","type":"User","site_admin":false},"body":"This adds a support for automatically creating and configuring an LBaas\r\nv2 (Octavia) as well as the VM-based fallback.\r\n\r\nHealth checks and additional protocol support will be added in follow-up\r\npatches.","created_at":"2018-02-20T09:28:23Z","updated_at":"2018-02-20T09:46:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c58c35b00e7a76141d616bcb457f8acb5eb4160","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":681679137,"url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7209/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7a9a5aad16a4cfe3cfbffa7314f45b2c99895cae","head":{"label":"tomassedovic:lbaas","ref":"lbaas","sha":"7a9a5aad16a4cfe3cfbffa7314f45b2c99895cae","user":{"login":"tomassedovic","id":104339,"avatar_url":"https://avatars1.githubusercontent.com/u/104339?v=4","gravatar_id":"","url":"https://api.github.com/users/tomassedovic","html_url":"https://github.com/tomassedovic","followers_url":"https://api.github.com/users/tomassedovic/followers","following_url":"https://api.github.com/users/tomassedovic/following{/other_user}","gists_url":"https://api.github.com/users/tomassedovic/gists{/gist_id}","starred_url":"https://api.github.com/users/tomassedovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomassedovic/subscriptions","organizations_url":"https://api.github.com/users/tomassedovic/orgs","repos_url":"https://api.github.com/users/tomassedovic/repos","events_url":"https://api.github.com/users/tomassedovic/events{/privacy}","received_events_url":"https://api.github.com/users/tomassedovic/received_events","type":"User","site_admin":false},"repo":{"id":43000596,"name":"openshift-ansible","full_name":"tomassedovic/openshift-ansible","owner":{"login":"tomassedovic","id":104339,"avatar_url":"https://avatars1.githubusercontent.com/u/104339?v=4","gravatar_id":"","url":"https://api.github.com/users/tomassedovic","html_url":"https://github.com/tomassedovic","followers_url":"https://api.github.com/users/tomassedovic/followers","following_url":"https://api.github.com/users/tomassedovic/following{/other_user}","gists_url":"https://api.github.com/users/tomassedovic/gists{/gist_id}","starred_url":"https://api.github.com/users/tomassedovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomassedovic/subscriptions","organizations_url":"https://api.github.com/users/tomassedovic/orgs","repos_url":"https://api.github.com/users/tomassedovic/repos","events_url":"https://api.github.com/users/tomassedovic/events{/privacy}","received_events_url":"https://api.github.com/users/tomassedovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomassedovic/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/tomassedovic/openshift-ansible","forks_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/forks","keys_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/events","assignees_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/merges","archive_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/tomassedovic/openshift-ansible/deployments","created_at":"2015-09-23T12:51:00Z","updated_at":"2015-09-23T12:51:02Z","pushed_at":"2018-02-20T09:27:46Z","git_url":"git://github.com/tomassedovic/openshift-ansible.git","ssh_url":"git@github.com:tomassedovic/openshift-ansible.git","clone_url":"https://github.com/tomassedovic/openshift-ansible.git","svn_url":"https://github.com/tomassedovic/openshift-ansible","homepage":"","size":20222,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a060e22db378d0b1ab6d08a27ecc6031ca1b320e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2018-02-20T04:26:22Z","pushed_at":"2018-02-20T09:41:50Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":24328,"stargazers_count":760,"watchers_count":760,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1171,"mirror_url":null,"archived":false,"open_issues_count":772,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1171,"open_issues":772,"watchers":760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/7209"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/7209"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/7209/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7209/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7a9a5aad16a4cfe3cfbffa7314f45b2c99895cae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bogdando"}}