{"action":"created","comment":{"url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/comments/179616043","pull_request_review_id":109896382,"id":179616043,"diff_hunk":"@@ -1,6 +1,6 @@\n module AssignmentsHelper\n-\tMAX = 26**4-1; # the maximum number that can be hashed to\n-    CODESTRING = \"ydlgknmzxjbctfiaqsrwoevuhp\"; # random ordering of the alphabet","path":"app/helpers/assignments_helper.rb","position":3,"original_position":3,"commit_id":"bf562231c3efa3d657274c661b76d9dcaf079039","original_commit_id":"a87f3b99b31733d5e9d0602d3a5bf1df1f880b13","user":{"login":"kcwoolverton","id":23412579,"avatar_url":"https://avatars0.githubusercontent.com/u/23412579?v=4","gravatar_id":"","url":"https://api.github.com/users/kcwoolverton","html_url":"https://github.com/kcwoolverton","followers_url":"https://api.github.com/users/kcwoolverton/followers","following_url":"https://api.github.com/users/kcwoolverton/following{/other_user}","gists_url":"https://api.github.com/users/kcwoolverton/gists{/gist_id}","starred_url":"https://api.github.com/users/kcwoolverton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcwoolverton/subscriptions","organizations_url":"https://api.github.com/users/kcwoolverton/orgs","repos_url":"https://api.github.com/users/kcwoolverton/repos","events_url":"https://api.github.com/users/kcwoolverton/events{/privacy}","received_events_url":"https://api.github.com/users/kcwoolverton/received_events","type":"User","site_admin":false},"body":"Oh that's interesting. Fair enough.","created_at":"2018-04-05T22:16:45Z","updated_at":"2018-04-05T22:16:45Z","html_url":"https://github.com/CS121-KBOP/classroom-dashboard/pull/54#discussion_r179616043","pull_request_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/comments/179616043"},"html":{"href":"https://github.com/CS121-KBOP/classroom-dashboard/pull/54#discussion_r179616043"},"pull_request":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54"}},"in_reply_to_id":178705755},"pull_request":{"url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54","id":178978837,"html_url":"https://github.com/CS121-KBOP/classroom-dashboard/pull/54","diff_url":"https://github.com/CS121-KBOP/classroom-dashboard/pull/54.diff","patch_url":"https://github.com/CS121-KBOP/classroom-dashboard/pull/54.patch","issue_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/54","number":54,"state":"open","locked":false,"title":"Removed inappropriate words from assignment hashes","user":{"login":"Omicron3141","id":1074799,"avatar_url":"https://avatars3.githubusercontent.com/u/1074799?v=4","gravatar_id":"","url":"https://api.github.com/users/Omicron3141","html_url":"https://github.com/Omicron3141","followers_url":"https://api.github.com/users/Omicron3141/followers","following_url":"https://api.github.com/users/Omicron3141/following{/other_user}","gists_url":"https://api.github.com/users/Omicron3141/gists{/gist_id}","starred_url":"https://api.github.com/users/Omicron3141/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Omicron3141/subscriptions","organizations_url":"https://api.github.com/users/Omicron3141/orgs","repos_url":"https://api.github.com/users/Omicron3141/repos","events_url":"https://api.github.com/users/Omicron3141/events{/privacy}","received_events_url":"https://api.github.com/users/Omicron3141/received_events","type":"User","site_admin":false},"body":"A quick and dirty solution: I removed all vowels from the hashes. We still allow some sketchy codes, like \"nfck\" which could be seen as inappropriate, but it should be good enough. We still have 160,000 possible hashes, and we can always move up to 5 letters if needed.","created_at":"2018-04-03T02:34:04Z","updated_at":"2018-04-05T22:16:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67e6a893374087d270a5983f8b870324ee4d9f59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54/commits","review_comments_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54/comments","review_comment_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/54/comments","statuses_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/statuses/bf562231c3efa3d657274c661b76d9dcaf079039","head":{"label":"CS121-KBOP:hash_stoplist","ref":"hash_stoplist","sha":"bf562231c3efa3d657274c661b76d9dcaf079039","user":{"login":"CS121-KBOP","id":36551258,"avatar_url":"https://avatars1.githubusercontent.com/u/36551258?v=4","gravatar_id":"","url":"https://api.github.com/users/CS121-KBOP","html_url":"https://github.com/CS121-KBOP","followers_url":"https://api.github.com/users/CS121-KBOP/followers","following_url":"https://api.github.com/users/CS121-KBOP/following{/other_user}","gists_url":"https://api.github.com/users/CS121-KBOP/gists{/gist_id}","starred_url":"https://api.github.com/users/CS121-KBOP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS121-KBOP/subscriptions","organizations_url":"https://api.github.com/users/CS121-KBOP/orgs","repos_url":"https://api.github.com/users/CS121-KBOP/repos","events_url":"https://api.github.com/users/CS121-KBOP/events{/privacy}","received_events_url":"https://api.github.com/users/CS121-KBOP/received_events","type":"Organization","site_admin":false},"repo":{"id":121800833,"name":"classroom-dashboard","full_name":"CS121-KBOP/classroom-dashboard","owner":{"login":"CS121-KBOP","id":36551258,"avatar_url":"https://avatars1.githubusercontent.com/u/36551258?v=4","gravatar_id":"","url":"https://api.github.com/users/CS121-KBOP","html_url":"https://github.com/CS121-KBOP","followers_url":"https://api.github.com/users/CS121-KBOP/followers","following_url":"https://api.github.com/users/CS121-KBOP/following{/other_user}","gists_url":"https://api.github.com/users/CS121-KBOP/gists{/gist_id}","starred_url":"https://api.github.com/users/CS121-KBOP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS121-KBOP/subscriptions","organizations_url":"https://api.github.com/users/CS121-KBOP/orgs","repos_url":"https://api.github.com/users/CS121-KBOP/repos","events_url":"https://api.github.com/users/CS121-KBOP/events{/privacy}","received_events_url":"https://api.github.com/users/CS121-KBOP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS121-KBOP/classroom-dashboard","description":"A Ruby on Rails webapp for managing classroom engagement for HMC CS121","fork":false,"url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard","forks_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/forks","keys_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/teams","hooks_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/hooks","issue_events_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/events","assignees_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/tags","blobs_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/languages","stargazers_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/stargazers","contributors_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/contributors","subscribers_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/subscribers","subscription_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/subscription","commits_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/merges","archive_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/downloads","issues_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/deployments","created_at":"2018-02-16T21:07:37Z","updated_at":"2018-03-28T23:20:34Z","pushed_at":"2018-04-05T19:34:28Z","git_url":"git://github.com/CS121-KBOP/classroom-dashboard.git","ssh_url":"git@github.com:CS121-KBOP/classroom-dashboard.git","clone_url":"https://github.com/CS121-KBOP/classroom-dashboard.git","svn_url":"https://github.com/CS121-KBOP/classroom-dashboard","homepage":"","size":11456,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"base":{"label":"CS121-KBOP:dev","ref":"dev","sha":"2efb1837c9d529a11478507b11b68b0589112379","user":{"login":"CS121-KBOP","id":36551258,"avatar_url":"https://avatars1.githubusercontent.com/u/36551258?v=4","gravatar_id":"","url":"https://api.github.com/users/CS121-KBOP","html_url":"https://github.com/CS121-KBOP","followers_url":"https://api.github.com/users/CS121-KBOP/followers","following_url":"https://api.github.com/users/CS121-KBOP/following{/other_user}","gists_url":"https://api.github.com/users/CS121-KBOP/gists{/gist_id}","starred_url":"https://api.github.com/users/CS121-KBOP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS121-KBOP/subscriptions","organizations_url":"https://api.github.com/users/CS121-KBOP/orgs","repos_url":"https://api.github.com/users/CS121-KBOP/repos","events_url":"https://api.github.com/users/CS121-KBOP/events{/privacy}","received_events_url":"https://api.github.com/users/CS121-KBOP/received_events","type":"Organization","site_admin":false},"repo":{"id":121800833,"name":"classroom-dashboard","full_name":"CS121-KBOP/classroom-dashboard","owner":{"login":"CS121-KBOP","id":36551258,"avatar_url":"https://avatars1.githubusercontent.com/u/36551258?v=4","gravatar_id":"","url":"https://api.github.com/users/CS121-KBOP","html_url":"https://github.com/CS121-KBOP","followers_url":"https://api.github.com/users/CS121-KBOP/followers","following_url":"https://api.github.com/users/CS121-KBOP/following{/other_user}","gists_url":"https://api.github.com/users/CS121-KBOP/gists{/gist_id}","starred_url":"https://api.github.com/users/CS121-KBOP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS121-KBOP/subscriptions","organizations_url":"https://api.github.com/users/CS121-KBOP/orgs","repos_url":"https://api.github.com/users/CS121-KBOP/repos","events_url":"https://api.github.com/users/CS121-KBOP/events{/privacy}","received_events_url":"https://api.github.com/users/CS121-KBOP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS121-KBOP/classroom-dashboard","description":"A Ruby on Rails webapp for managing classroom engagement for HMC CS121","fork":false,"url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard","forks_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/forks","keys_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/teams","hooks_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/hooks","issue_events_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/events","assignees_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/tags","blobs_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/languages","stargazers_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/stargazers","contributors_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/contributors","subscribers_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/subscribers","subscription_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/subscription","commits_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/merges","archive_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/downloads","issues_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/deployments","created_at":"2018-02-16T21:07:37Z","updated_at":"2018-03-28T23:20:34Z","pushed_at":"2018-04-05T19:34:28Z","git_url":"git://github.com/CS121-KBOP/classroom-dashboard.git","ssh_url":"git@github.com:CS121-KBOP/classroom-dashboard.git","clone_url":"https://github.com/CS121-KBOP/classroom-dashboard.git","svn_url":"https://github.com/CS121-KBOP/classroom-dashboard","homepage":"","size":11456,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54"},"html":{"href":"https://github.com/CS121-KBOP/classroom-dashboard/pull/54"},"issue":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/54"},"comments":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/CS121-KBOP/classroom-dashboard/statuses/bf562231c3efa3d657274c661b76d9dcaf079039"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kcwoolverton"}}