{"action":"created","comment":{"url":"https://api.github.com/repos/dlang-community/D-YAML/pulls/comments/176878757","pull_request_review_id":106665966,"id":176878757,"diff_hunk":"@@ -265,7 +265,7 @@ struct Node\n         }\n         /// Ditto.\n         // Overload for types where we can make this nothrow.\n-        this(T)(T value, const string tag = null) @trusted pure nothrow\n+        this(T)(T value, const string tag = null) @trusted","path":"source/dyaml/node.d","position":23,"original_position":32,"commit_id":"10ae170a44e87ae567392cb752936e79148238c8","original_commit_id":"284cf965b8d22d525265017c96de3c159ae05d9d","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"IIRC once one attribute is specified manually, the compile won't infer the rest.","created_at":"2018-03-23T22:27:35Z","updated_at":"2018-03-23T22:37:46Z","html_url":"https://github.com/dlang-community/D-YAML/pull/98#discussion_r176878757","pull_request_url":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dlang-community/D-YAML/pulls/comments/176878757"},"html":{"href":"https://github.com/dlang-community/D-YAML/pull/98#discussion_r176878757"},"pull_request":{"href":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98","id":177191765,"html_url":"https://github.com/dlang-community/D-YAML/pull/98","diff_url":"https://github.com/dlang-community/D-YAML/pull/98.diff","patch_url":"https://github.com/dlang-community/D-YAML/pull/98.patch","issue_url":"https://api.github.com/repos/dlang-community/D-YAML/issues/98","number":98,"state":"open","locked":false,"title":"Major attribute upgrade","user":{"login":"Herringway","id":905162,"avatar_url":"https://avatars0.githubusercontent.com/u/905162?v=4","gravatar_id":"","url":"https://api.github.com/users/Herringway","html_url":"https://github.com/Herringway","followers_url":"https://api.github.com/users/Herringway/followers","following_url":"https://api.github.com/users/Herringway/following{/other_user}","gists_url":"https://api.github.com/users/Herringway/gists{/gist_id}","starred_url":"https://api.github.com/users/Herringway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Herringway/subscriptions","organizations_url":"https://api.github.com/users/Herringway/orgs","repos_url":"https://api.github.com/users/Herringway/repos","events_url":"https://api.github.com/users/Herringway/events{/privacy}","received_events_url":"https://api.github.com/users/Herringway/received_events","type":"User","site_admin":false},"body":"Kind of a big PR, but here we go:\r\n- Upgraded many `@system` and `@trusted` functions to `@safe`\r\n- Removed attributes where they can be inferred\r\n- Added attributes to unittests\r\n- Reworked test suite a little to support being mostly `@safe`\r\n- Removed ineffectual `@system` calls (GC disabling, assumeSafeAppend on unsliced arrays)\r\n\r\nThere is one breaking change that I'm aware of in this PR: dyaml.representer.Representer.addRepresenter now requires a `@safe` function as a parameter.\r\n\r\nMore can be done, but it would require some larger refactoring that I felt was out of scope here. Even more will be able to be marked `@safe` in a future version of phobos - the Array container is currently not `@safe`, but it looks like it will be soon.","created_at":"2018-03-23T21:49:02Z","updated_at":"2018-03-23T22:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13e9675f2050c55aafe21a66c818f0e214249299","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98/commits","review_comments_url":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98/comments","review_comment_url":"https://api.github.com/repos/dlang-community/D-YAML/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang-community/D-YAML/issues/98/comments","statuses_url":"https://api.github.com/repos/dlang-community/D-YAML/statuses/10ae170a44e87ae567392cb752936e79148238c8","head":{"label":"Herringway:redundant-removal","ref":"redundant-removal","sha":"10ae170a44e87ae567392cb752936e79148238c8","user":{"login":"Herringway","id":905162,"avatar_url":"https://avatars0.githubusercontent.com/u/905162?v=4","gravatar_id":"","url":"https://api.github.com/users/Herringway","html_url":"https://github.com/Herringway","followers_url":"https://api.github.com/users/Herringway/followers","following_url":"https://api.github.com/users/Herringway/following{/other_user}","gists_url":"https://api.github.com/users/Herringway/gists{/gist_id}","starred_url":"https://api.github.com/users/Herringway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Herringway/subscriptions","organizations_url":"https://api.github.com/users/Herringway/orgs","repos_url":"https://api.github.com/users/Herringway/repos","events_url":"https://api.github.com/users/Herringway/events{/privacy}","received_events_url":"https://api.github.com/users/Herringway/received_events","type":"User","site_admin":false},"repo":{"id":43112916,"name":"D-YAML","full_name":"Herringway/D-YAML","owner":{"login":"Herringway","id":905162,"avatar_url":"https://avatars0.githubusercontent.com/u/905162?v=4","gravatar_id":"","url":"https://api.github.com/users/Herringway","html_url":"https://github.com/Herringway","followers_url":"https://api.github.com/users/Herringway/followers","following_url":"https://api.github.com/users/Herringway/following{/other_user}","gists_url":"https://api.github.com/users/Herringway/gists{/gist_id}","starred_url":"https://api.github.com/users/Herringway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Herringway/subscriptions","organizations_url":"https://api.github.com/users/Herringway/orgs","repos_url":"https://api.github.com/users/Herringway/repos","events_url":"https://api.github.com/users/Herringway/events{/privacy}","received_events_url":"https://api.github.com/users/Herringway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Herringway/D-YAML","description":"YAML parser and emitter for the D programming language","fork":true,"url":"https://api.github.com/repos/Herringway/D-YAML","forks_url":"https://api.github.com/repos/Herringway/D-YAML/forks","keys_url":"https://api.github.com/repos/Herringway/D-YAML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Herringway/D-YAML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Herringway/D-YAML/teams","hooks_url":"https://api.github.com/repos/Herringway/D-YAML/hooks","issue_events_url":"https://api.github.com/repos/Herringway/D-YAML/issues/events{/number}","events_url":"https://api.github.com/repos/Herringway/D-YAML/events","assignees_url":"https://api.github.com/repos/Herringway/D-YAML/assignees{/user}","branches_url":"https://api.github.com/repos/Herringway/D-YAML/branches{/branch}","tags_url":"https://api.github.com/repos/Herringway/D-YAML/tags","blobs_url":"https://api.github.com/repos/Herringway/D-YAML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Herringway/D-YAML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Herringway/D-YAML/git/refs{/sha}","trees_url":"https://api.github.com/repos/Herringway/D-YAML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Herringway/D-YAML/statuses/{sha}","languages_url":"https://api.github.com/repos/Herringway/D-YAML/languages","stargazers_url":"https://api.github.com/repos/Herringway/D-YAML/stargazers","contributors_url":"https://api.github.com/repos/Herringway/D-YAML/contributors","subscribers_url":"https://api.github.com/repos/Herringway/D-YAML/subscribers","subscription_url":"https://api.github.com/repos/Herringway/D-YAML/subscription","commits_url":"https://api.github.com/repos/Herringway/D-YAML/commits{/sha}","git_commits_url":"https://api.github.com/repos/Herringway/D-YAML/git/commits{/sha}","comments_url":"https://api.github.com/repos/Herringway/D-YAML/comments{/number}","issue_comment_url":"https://api.github.com/repos/Herringway/D-YAML/issues/comments{/number}","contents_url":"https://api.github.com/repos/Herringway/D-YAML/contents/{+path}","compare_url":"https://api.github.com/repos/Herringway/D-YAML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Herringway/D-YAML/merges","archive_url":"https://api.github.com/repos/Herringway/D-YAML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Herringway/D-YAML/downloads","issues_url":"https://api.github.com/repos/Herringway/D-YAML/issues{/number}","pulls_url":"https://api.github.com/repos/Herringway/D-YAML/pulls{/number}","milestones_url":"https://api.github.com/repos/Herringway/D-YAML/milestones{/number}","notifications_url":"https://api.github.com/repos/Herringway/D-YAML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Herringway/D-YAML/labels{/name}","releases_url":"https://api.github.com/repos/Herringway/D-YAML/releases{/id}","deployments_url":"https://api.github.com/repos/Herringway/D-YAML/deployments","created_at":"2015-09-25T06:12:27Z","updated_at":"2018-03-22T20:27:19Z","pushed_at":"2018-03-23T22:31:43Z","git_url":"git://github.com/Herringway/D-YAML.git","ssh_url":"git@github.com:Herringway/D-YAML.git","clone_url":"https://github.com/Herringway/D-YAML.git","svn_url":"https://github.com/Herringway/D-YAML","homepage":"http://defenestrate.eu/docs/dyaml/","size":3425,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang-community:master","ref":"master","sha":"d60db0c7dff116297b57d5a390776f7f33e9cf00","user":{"login":"dlang-community","id":24511724,"avatar_url":"https://avatars1.githubusercontent.com/u/24511724?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang-community","html_url":"https://github.com/dlang-community","followers_url":"https://api.github.com/users/dlang-community/followers","following_url":"https://api.github.com/users/dlang-community/following{/other_user}","gists_url":"https://api.github.com/users/dlang-community/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang-community/subscriptions","organizations_url":"https://api.github.com/users/dlang-community/orgs","repos_url":"https://api.github.com/users/dlang-community/repos","events_url":"https://api.github.com/users/dlang-community/events{/privacy}","received_events_url":"https://api.github.com/users/dlang-community/received_events","type":"Organization","site_admin":false},"repo":{"id":2216701,"name":"D-YAML","full_name":"dlang-community/D-YAML","owner":{"login":"dlang-community","id":24511724,"avatar_url":"https://avatars1.githubusercontent.com/u/24511724?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang-community","html_url":"https://github.com/dlang-community","followers_url":"https://api.github.com/users/dlang-community/followers","following_url":"https://api.github.com/users/dlang-community/following{/other_user}","gists_url":"https://api.github.com/users/dlang-community/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang-community/subscriptions","organizations_url":"https://api.github.com/users/dlang-community/orgs","repos_url":"https://api.github.com/users/dlang-community/repos","events_url":"https://api.github.com/users/dlang-community/events{/privacy}","received_events_url":"https://api.github.com/users/dlang-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang-community/D-YAML","description":"YAML parser and emitter for the D programming language","fork":false,"url":"https://api.github.com/repos/dlang-community/D-YAML","forks_url":"https://api.github.com/repos/dlang-community/D-YAML/forks","keys_url":"https://api.github.com/repos/dlang-community/D-YAML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang-community/D-YAML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang-community/D-YAML/teams","hooks_url":"https://api.github.com/repos/dlang-community/D-YAML/hooks","issue_events_url":"https://api.github.com/repos/dlang-community/D-YAML/issues/events{/number}","events_url":"https://api.github.com/repos/dlang-community/D-YAML/events","assignees_url":"https://api.github.com/repos/dlang-community/D-YAML/assignees{/user}","branches_url":"https://api.github.com/repos/dlang-community/D-YAML/branches{/branch}","tags_url":"https://api.github.com/repos/dlang-community/D-YAML/tags","blobs_url":"https://api.github.com/repos/dlang-community/D-YAML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang-community/D-YAML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang-community/D-YAML/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang-community/D-YAML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang-community/D-YAML/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang-community/D-YAML/languages","stargazers_url":"https://api.github.com/repos/dlang-community/D-YAML/stargazers","contributors_url":"https://api.github.com/repos/dlang-community/D-YAML/contributors","subscribers_url":"https://api.github.com/repos/dlang-community/D-YAML/subscribers","subscription_url":"https://api.github.com/repos/dlang-community/D-YAML/subscription","commits_url":"https://api.github.com/repos/dlang-community/D-YAML/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang-community/D-YAML/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang-community/D-YAML/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang-community/D-YAML/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang-community/D-YAML/contents/{+path}","compare_url":"https://api.github.com/repos/dlang-community/D-YAML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang-community/D-YAML/merges","archive_url":"https://api.github.com/repos/dlang-community/D-YAML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang-community/D-YAML/downloads","issues_url":"https://api.github.com/repos/dlang-community/D-YAML/issues{/number}","pulls_url":"https://api.github.com/repos/dlang-community/D-YAML/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang-community/D-YAML/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang-community/D-YAML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang-community/D-YAML/labels{/name}","releases_url":"https://api.github.com/repos/dlang-community/D-YAML/releases{/id}","deployments_url":"https://api.github.com/repos/dlang-community/D-YAML/deployments","created_at":"2011-08-16T16:08:27Z","updated_at":"2018-03-22T18:12:00Z","pushed_at":"2018-03-23T22:31:45Z","git_url":"git://github.com/dlang-community/D-YAML.git","ssh_url":"git@github.com:dlang-community/D-YAML.git","clone_url":"https://github.com/dlang-community/D-YAML.git","svn_url":"https://github.com/dlang-community/D-YAML","homepage":"https://rawgit.com/dlang-community/D-YAML/master/doc/html/index.html","size":3357,"stargazers_count":82,"watchers_count":82,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":25,"open_issues":13,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98"},"html":{"href":"https://github.com/dlang-community/D-YAML/pull/98"},"issue":{"href":"https://api.github.com/repos/dlang-community/D-YAML/issues/98"},"comments":{"href":"https://api.github.com/repos/dlang-community/D-YAML/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang-community/D-YAML/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang-community/D-YAML/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/dlang-community/D-YAML/statuses/10ae170a44e87ae567392cb752936e79148238c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wilzbach"}}