{"action":"created","issue":{"url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/1195","repository_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth","labels_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/1195/labels{/name}","comments_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/1195/comments","events_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/1195/events","html_url":"https://github.com/benedmunds/CodeIgniter-Ion-Auth/issues/1195","id":306571235,"number":1195,"title":"bcrypt / hash function evolution","user":{"login":"Indigo744","id":7137528,"avatar_url":"https://avatars3.githubusercontent.com/u/7137528?v=4","gravatar_id":"","url":"https://api.github.com/users/Indigo744","html_url":"https://github.com/Indigo744","followers_url":"https://api.github.com/users/Indigo744/followers","following_url":"https://api.github.com/users/Indigo744/following{/other_user}","gists_url":"https://api.github.com/users/Indigo744/gists{/gist_id}","starred_url":"https://api.github.com/users/Indigo744/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Indigo744/subscriptions","organizations_url":"https://api.github.com/users/Indigo744/orgs","repos_url":"https://api.github.com/users/Indigo744/repos","events_url":"https://api.github.com/users/Indigo744/events{/privacy}","received_events_url":"https://api.github.com/users/Indigo744/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-19T18:01:29Z","updated_at":"2018-03-19T20:53:43Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Dear @benedmunds \r\n\r\nFirst and foremost, thank you again for this lib. I use it extensively and I love it  :smile: This is why I try to give back by proposing updates and enhancement when I find the time.\r\n\r\nThe usage of the specific bcrypt library has always bugged me. Of course I've audited the code and found out that it was OK using `crypt()` and such, but I keep thinking that it could be better.\r\n\r\nI found out that I was not the only one (see related issues #1176 and #1169). \r\n\r\nAnother thing is using `crypt()` function will not allow us to provide an option to use the new ARGON2 algorithm, which is available in PHP 7.2 but only for the `password_hash()` function.\r\n\r\nHence I would like to make a PR to move to using `password_*` functions.\r\n\r\nBut before starting to work on it, I have a couple of questions I would like to pass by you first:\r\n1. Should PHP < 5.5 still be supported? [According to Wikipedia](https://en.wikipedia.org/wiki/PHP#Release_history), PHP 5.3 is not supported since 2014, and PHP 5.5 since 2016... \r\nShould an Auth library really support this old version?\r\n2. If PHP < 5.5 is needed, should we use [password_compat](https://github.com/ircmaxell/password_compat)? \r\nHow should we load it? Copy/pasting the code would seem easy, but it would be troublesome to maintain (checking for updates regularly, etc...). \r\nAlso, CI 3 offers their own polyfills (see `core/compat/password.php`) so it would be quite redundant...\r\nSo maybe we should simply redirect users to this lib and recommends them to install it? I really wonder the number of users with CI 2 and PHP < 5.5...\r\n\r\nThanks for your insights."},"comment":{"url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/comments/374372143","html_url":"https://github.com/benedmunds/CodeIgniter-Ion-Auth/issues/1195#issuecomment-374372143","issue_url":"https://api.github.com/repos/benedmunds/CodeIgniter-Ion-Auth/issues/1195","id":374372143,"user":{"login":"Indigo744","id":7137528,"avatar_url":"https://avatars3.githubusercontent.com/u/7137528?v=4","gravatar_id":"","url":"https://api.github.com/users/Indigo744","html_url":"https://github.com/Indigo744","followers_url":"https://api.github.com/users/Indigo744/followers","following_url":"https://api.github.com/users/Indigo744/following{/other_user}","gists_url":"https://api.github.com/users/Indigo744/gists{/gist_id}","starred_url":"https://api.github.com/users/Indigo744/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Indigo744/subscriptions","organizations_url":"https://api.github.com/users/Indigo744/orgs","repos_url":"https://api.github.com/users/Indigo744/repos","events_url":"https://api.github.com/users/Indigo744/events{/privacy}","received_events_url":"https://api.github.com/users/Indigo744/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T20:53:43Z","updated_at":"2018-03-19T20:53:43Z","author_association":"CONTRIBUTOR","body":"By the way, what are your thoughts on [my comment about sha1 support](https://github.com/benedmunds/CodeIgniter-Ion-Auth/issues/1195#issuecomment-374360036)? "}}
{"actor":{"display_login":"Indigo744"}}