{"push_id":2302020792,"size":11,"distinct_size":2,"ref":"refs/heads/50-clean-salt-files","head":"0334bcffab29d95f9cd840760c4191d8934fb545","before":"cad4ca2d8bcfa7a5907caa6f57608c80d728f387","commits":[{"sha":"3581888b91486ca3df67bf4601314344a0417023","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Creates \"flake8\" Makefile target\n\nRuns flake8 to lint all Python files. Deferring to the `flake8` commands\non which files are Python, rather than explicitly passing a whitelist of\nfiles to lint.\n\nUsers must install at least v3.3.0 of flake8; older versions, such as\n2.5.5 (currently available in the Fedora 25 EOL repos), are not\nsufficient for the file discovery logic. As a stopgap, we can pass \".\"\nfor the current working directory to flake8, which will force even older\nversions to traverse for file discovery.\n\nNote that we're *not* setting the `assert-dom0` target as a dependency,\nsince dom0 will not have flake8 installed by default. It's reasonable\nfor the dev env to have it, and we'll make sure the linting checks run\nin CI.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/3581888b91486ca3df67bf4601314344a0417023"},{"sha":"3a71054be064686b7d6566f80dbdb19c87670e68","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Flake8 linting of Python test suite\n\nMostly whitespace violations, cleaned up with consistent indentation\nthroughout. All files under the tests/ directory now pass flake8\nlinting.\n\nThere are a few minor exceptions added, to permit lines longer than 80\ncharacters to aid in readability, e.g. filepaths.\n\nFound one major error, in the decryption tests: two tests sharing the same\nname, so there was clobbering going on. Resolved. Hurray, linting!","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/3a71054be064686b7d6566f80dbdb19c87670e68"},{"sha":"9ceaa38af614b8326e7200862e3efe818472b22b","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Flake8 linting of Python scripts\n\nThe Python scripts that handle state monitoring inside the SD Journalist\nVM now conform to flake8 linting standards. The changes were minimal.\nPermitted a longer-80-char line to preserve readability on a URL.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/9ceaa38af614b8326e7200862e3efe818472b22b"},{"sha":"bd79c062e536afb44f1382f728474394ac073664","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Flake8 linting of base tests (E741)\n\nSingle commit for resolution of the E741 violation, which states that\n\"l\" (i.e. lowercase L) should not be used as a variable name, since it\ncan be mistaken visually for a \"1\" (i.e. the number one). That's a bit\nof a stretch in my mind, but hey, let's trust the linter.\n\nThe first version of flake8 including this check is v3.5.0. Older\nversions will silently ignore the violation.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/bd79c062e536afb44f1382f728474394ac073664"},{"sha":"3dd734309c2b4f3559fa5473c1d23eaa73346765","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Flake8 linting of base tests (E722)\n\nThere was a bare except in the _reboot function, which would mask errors\nof any kind. As stipulated by Flake8 E722, \"except\" blocks should catch\nexplicitly declared exceptions. Since this codeback isn't currently used\nanywhere—it's commented out in the setUp def—let's remove the\nnoncompliant try/except block and watch for errors down the road. When\nobserved, we'll catch the errors by name and handle appropriately.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/3dd734309c2b4f3559fa5473c1d23eaa73346765"},{"sha":"b77b772ec7a4e2de4b58a6a7e2b14133f1db6cad","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Runs flake8 linting in CI\n\nUsing a clean Debian Stretch container image and customizing it slightly\nto pull in flake8 via pip. Not currently pinning any pip lib versions,\ne.g. via requirements.txt, although we'll surely want to in the future.\n\nNot using any of the FPF-maintained container images for CI [0], since\nthey all assume Python3, and the Qubes management code is all still\nPython2 for the time being.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/b77b772ec7a4e2de4b58a6a7e2b14133f1db6cad"},{"sha":"c907d2d59ab7384da943ac58441f4b3a56237cb1","author":{"name":"Conor Schaefer","email":"78281d988d4914dba0b09ea6fb297a84abd92288@users.noreply.github.com"},"message":"Merge pull request #62 from freedomofpress/56-linting-flake8\n\nLints all Python files via flake8","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/c907d2d59ab7384da943ac58441f4b3a56237cb1"},{"sha":"642793f23f51775f79f5038b6e9752ad59c4beed","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Creates platform tests for VM base OS\n\nPartial progress toward #48.\n\nTrying to write pass/fail tests for supported platforms for all VMs.\nAiming for a hard fail on EOL Fedora 25, in support of migration to Fedora\n26, but focusing on the test structure for now.\n\nThe hardcoded copypasta in the form of the VM list is not DRY, and\nsuggests to me we should consider a more declarative format for the test\nassumptions, e.g. a single YAML file describing the VM layout and\nattributes, which all tests can import once and reuse.","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/642793f23f51775f79f5038b6e9752ad59c4beed"},{"sha":"0a22f34e87fb80b20adcc0404b8c6782dc022263","author":{"name":"Conor Schaefer","email":"78281d988d4914dba0b09ea6fb297a84abd92288@users.noreply.github.com"},"message":"Merge pull request #63 from freedomofpress/48-preliminary-platform-tests\n\nPreliminary tests for platform (App VM base OS)","distinct":false,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/0a22f34e87fb80b20adcc0404b8c6782dc022263"},{"sha":"e36a20651a5b643e9e391dc6d45391383b2ea09e","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"Adds \"clean-salt\" Makefile target\n\nWe already have \"prep-salt\", but we noticed in #50 that simply adding new files\nisn't always backwards-compatible: some legacy files can persist in /srv/salt,\ncausing problems with non-unique salt IDs when newer versions of the config are run.\n\nLet's purge all SD-Workstation-related Salt configs prior to writing the new,\ncurrent ones each time. Note that the \"clean-salt\" action runs as part of the\ngeneral \"clean\" step, *not* as a dependency of \"prep-salt\", since prep-salt runs\nprior to each and every VM creation.","distinct":true,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/e36a20651a5b643e9e391dc6d45391383b2ea09e"},{"sha":"0334bcffab29d95f9cd840760c4191d8934fb545","author":{"name":"Conor Schaefer","email":"bd5f35ce7a6f74df66338e30eb7d51ed0d617b12@freedom.press"},"message":"More judicious SD-specific clean-salt step\n\nAs @joshuathayer pointed out during review, the \"remove all symlinks\"\napproach to Salt top files wasn't restricted to SecureDrop-specific VM\nconfigs, which would have broken non-SD VM configurations. As long as\nthe configs are prefixed with \"sd-\", as all currently are, then they'll\nbe cleaned up here.\n\nConsider also removing all broken symlinks via:\n\n    sudo find /srv/salt/_tops -type l ! -exec test -e {} \\; -delete\n\nNot doing so now because haven't tested sufficiently.","distinct":true,"url":"https://api.github.com/repos/freedomofpress/securedrop-workstation/commits/0334bcffab29d95f9cd840760c4191d8934fb545"}]}
{"actor":{"display_login":"conorsch"}}