{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/10324","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/10324/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/10324/comments","events_url":"https://api.github.com/repos/helm/charts/issues/10324/events","html_url":"https://github.com/helm/charts/pull/10324","id":395094864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjQwNTU4","number":10324,"title":"Track upstream v3-release tag, use loopback IP for probes","user":{"login":"hakamadare","id":154395,"node_id":"MDQ6VXNlcjE1NDM5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/154395?v=4","gravatar_id":"","url":"https://api.github.com/users/hakamadare","html_url":"https://github.com/hakamadare","followers_url":"https://api.github.com/users/hakamadare/followers","following_url":"https://api.github.com/users/hakamadare/following{/other_user}","gists_url":"https://api.github.com/users/hakamadare/gists{/gist_id}","starred_url":"https://api.github.com/users/hakamadare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakamadare/subscriptions","organizations_url":"https://api.github.com/users/hakamadare/orgs","repos_url":"https://api.github.com/users/hakamadare/repos","events_url":"https://api.github.com/users/hakamadare/events{/privacy}","received_events_url":"https://api.github.com/users/hakamadare/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":676475149,"node_id":"MDU6TGFiZWw2NzY0NzUxNDk=","url":"https://api.github.com/repos/helm/charts/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-01T16:10:45Z","updated_at":"2019-01-01T16:10:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/10324","html_url":"https://github.com/helm/charts/pull/10324","diff_url":"https://github.com/helm/charts/pull/10324.diff","patch_url":"https://github.com/helm/charts/pull/10324.patch"},"body":"#### What this PR does / why we need it:\r\n\r\n@ewbankkit \r\n\r\nThis addresses two issues that I encountered when using this chart to\r\ndeploy kiam v3 on EKS:\r\n1. kiam v3.0 was released 2018-12-06 per\r\nhttps://github.com/uswitch/kiam/blob/master/CHANGELOG.md, it probably\r\ndoesn't make sense to track a RC tag\r\n2. Liveness/readiness probes need to use `127.0.0.1` rather than\r\n`localhost` (see uswitch/kiam#163) because of a TLS change\r\n\r\nSigned-off-by: Steve Huff <shuff@vecna.org>\r\n\r\n#### Which issue this PR fixes\r\n  - fixes #9790 \r\n\r\n#### Special notes for your reviewer:\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/450740344","html_url":"https://github.com/helm/charts/pull/10324#issuecomment-450740344","issue_url":"https://api.github.com/repos/helm/charts/issues/10324","id":450740344,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDc0MDM0NA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-01-01T16:10:52Z","updated_at":"2019-01-01T16:10:52Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/helm/charts/pull/10324#\" title=\"Author self-approved\">hakamadare</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **scottrigby**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @scottrigby` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/helm/charts/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"scottrigby\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}