{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments/197020767","pull_request_review_id":130678202,"id":197020767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzAyMDc2Nw==","diff_hunk":"@@ -53,12 +53,6 @@\n       ]\n     },\n     \"AWS::RDS::DBInstance\": {\n-      \"DBSnapshotIdentifier\": [","path":"src/cfnlint/data/AdditionalSpecs/Exclusive.json","position":4,"original_position":4,"commit_id":"4a20b0d9780e8f66d3fd861ab230c53c275e1d5c","original_commit_id":"4a20b0d9780e8f66d3fd861ab230c53c275e1d5c","user":{"login":"kddejong","id":36457093,"node_id":"MDQ6VXNlcjM2NDU3MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/36457093?v=4","gravatar_id":"","url":"https://api.github.com/users/kddejong","html_url":"https://github.com/kddejong","followers_url":"https://api.github.com/users/kddejong/followers","following_url":"https://api.github.com/users/kddejong/following{/other_user}","gists_url":"https://api.github.com/users/kddejong/gists{/gist_id}","starred_url":"https://api.github.com/users/kddejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddejong/subscriptions","organizations_url":"https://api.github.com/users/kddejong/orgs","repos_url":"https://api.github.com/users/kddejong/repos","events_url":"https://api.github.com/users/kddejong/events{/privacy}","received_events_url":"https://api.github.com/users/kddejong/received_events","type":"User","site_admin":false},"body":"This needs to be converted to another check as DBSnapshotIdentifier can be an empty string which means CloudFormation will use the Username and Password fields.","created_at":"2018-06-21T06:13:20Z","updated_at":"2018-06-21T06:13:21Z","html_url":"https://github.com/awslabs/cfn-python-lint/pull/121#discussion_r197020767","pull_request_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments/197020767"},"html":{"href":"https://github.com/awslabs/cfn-python-lint/pull/121#discussion_r197020767"},"pull_request":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121","id":194709066,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzA5MDY2","html_url":"https://github.com/awslabs/cfn-python-lint/pull/121","diff_url":"https://github.com/awslabs/cfn-python-lint/pull/121.diff","patch_url":"https://github.com/awslabs/cfn-python-lint/pull/121.patch","issue_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/121","number":121,"state":"open","locked":false,"title":"Process templates playing out condition scenarios - Work In Progress","user":{"login":"kddejong","id":36457093,"node_id":"MDQ6VXNlcjM2NDU3MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/36457093?v=4","gravatar_id":"","url":"https://api.github.com/users/kddejong","html_url":"https://github.com/kddejong","followers_url":"https://api.github.com/users/kddejong/followers","following_url":"https://api.github.com/users/kddejong/following{/other_user}","gists_url":"https://api.github.com/users/kddejong/gists{/gist_id}","starred_url":"https://api.github.com/users/kddejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddejong/subscriptions","organizations_url":"https://api.github.com/users/kddejong/orgs","repos_url":"https://api.github.com/users/kddejong/repos","events_url":"https://api.github.com/users/kddejong/events{/privacy}","received_events_url":"https://api.github.com/users/kddejong/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n#112 \r\n\r\n*Description of changes:*\r\n- Play out the condition scenarios to make testing conditions easier.\r\n\r\nBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.\r\n","created_at":"2018-06-13T20:42:06Z","updated_at":"2018-06-21T06:13:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"573a4401022aac716fff11c3cb213195d1731726","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121/commits","review_comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121/comments","review_comment_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/121/comments","statuses_url":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/4a20b0d9780e8f66d3fd861ab230c53c275e1d5c","head":{"label":"kddejong:Feature/BetterConditions","ref":"Feature/BetterConditions","sha":"4a20b0d9780e8f66d3fd861ab230c53c275e1d5c","user":{"login":"kddejong","id":36457093,"node_id":"MDQ6VXNlcjM2NDU3MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/36457093?v=4","gravatar_id":"","url":"https://api.github.com/users/kddejong","html_url":"https://github.com/kddejong","followers_url":"https://api.github.com/users/kddejong/followers","following_url":"https://api.github.com/users/kddejong/following{/other_user}","gists_url":"https://api.github.com/users/kddejong/gists{/gist_id}","starred_url":"https://api.github.com/users/kddejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddejong/subscriptions","organizations_url":"https://api.github.com/users/kddejong/orgs","repos_url":"https://api.github.com/users/kddejong/repos","events_url":"https://api.github.com/users/kddejong/events{/privacy}","received_events_url":"https://api.github.com/users/kddejong/received_events","type":"User","site_admin":false},"repo":{"id":130252071,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyNTIwNzE=","name":"cfn-python-lint","full_name":"kddejong/cfn-python-lint","owner":{"login":"kddejong","id":36457093,"node_id":"MDQ6VXNlcjM2NDU3MDkz","avatar_url":"https://avatars3.githubusercontent.com/u/36457093?v=4","gravatar_id":"","url":"https://api.github.com/users/kddejong","html_url":"https://github.com/kddejong","followers_url":"https://api.github.com/users/kddejong/followers","following_url":"https://api.github.com/users/kddejong/following{/other_user}","gists_url":"https://api.github.com/users/kddejong/gists{/gist_id}","starred_url":"https://api.github.com/users/kddejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kddejong/subscriptions","organizations_url":"https://api.github.com/users/kddejong/orgs","repos_url":"https://api.github.com/users/kddejong/repos","events_url":"https://api.github.com/users/kddejong/events{/privacy}","received_events_url":"https://api.github.com/users/kddejong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kddejong/cfn-python-lint","description":"CloudFormation Linter","fork":true,"url":"https://api.github.com/repos/kddejong/cfn-python-lint","forks_url":"https://api.github.com/repos/kddejong/cfn-python-lint/forks","keys_url":"https://api.github.com/repos/kddejong/cfn-python-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kddejong/cfn-python-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kddejong/cfn-python-lint/teams","hooks_url":"https://api.github.com/repos/kddejong/cfn-python-lint/hooks","issue_events_url":"https://api.github.com/repos/kddejong/cfn-python-lint/issues/events{/number}","events_url":"https://api.github.com/repos/kddejong/cfn-python-lint/events","assignees_url":"https://api.github.com/repos/kddejong/cfn-python-lint/assignees{/user}","branches_url":"https://api.github.com/repos/kddejong/cfn-python-lint/branches{/branch}","tags_url":"https://api.github.com/repos/kddejong/cfn-python-lint/tags","blobs_url":"https://api.github.com/repos/kddejong/cfn-python-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kddejong/cfn-python-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kddejong/cfn-python-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/kddejong/cfn-python-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kddejong/cfn-python-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/kddejong/cfn-python-lint/languages","stargazers_url":"https://api.github.com/repos/kddejong/cfn-python-lint/stargazers","contributors_url":"https://api.github.com/repos/kddejong/cfn-python-lint/contributors","subscribers_url":"https://api.github.com/repos/kddejong/cfn-python-lint/subscribers","subscription_url":"https://api.github.com/repos/kddejong/cfn-python-lint/subscription","commits_url":"https://api.github.com/repos/kddejong/cfn-python-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/kddejong/cfn-python-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/kddejong/cfn-python-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/kddejong/cfn-python-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/kddejong/cfn-python-lint/contents/{+path}","compare_url":"https://api.github.com/repos/kddejong/cfn-python-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kddejong/cfn-python-lint/merges","archive_url":"https://api.github.com/repos/kddejong/cfn-python-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kddejong/cfn-python-lint/downloads","issues_url":"https://api.github.com/repos/kddejong/cfn-python-lint/issues{/number}","pulls_url":"https://api.github.com/repos/kddejong/cfn-python-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/kddejong/cfn-python-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/kddejong/cfn-python-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kddejong/cfn-python-lint/labels{/name}","releases_url":"https://api.github.com/repos/kddejong/cfn-python-lint/releases{/id}","deployments_url":"https://api.github.com/repos/kddejong/cfn-python-lint/deployments","created_at":"2018-04-19T17:47:45Z","updated_at":"2018-05-29T19:00:29Z","pushed_at":"2018-06-21T06:11:13Z","git_url":"git://github.com/kddejong/cfn-python-lint.git","ssh_url":"git@github.com:kddejong/cfn-python-lint.git","clone_url":"https://github.com/kddejong/cfn-python-lint.git","svn_url":"https://github.com/kddejong/cfn-python-lint","homepage":null,"size":819,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"17510d3f451ea19b8647af139c3238ecf5be8afc","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":129005655,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwMDU2NTU=","name":"cfn-python-lint","full_name":"awslabs/cfn-python-lint","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/cfn-python-lint","description":"CloudFormation Linter","fork":false,"url":"https://api.github.com/repos/awslabs/cfn-python-lint","forks_url":"https://api.github.com/repos/awslabs/cfn-python-lint/forks","keys_url":"https://api.github.com/repos/awslabs/cfn-python-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/cfn-python-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/cfn-python-lint/teams","hooks_url":"https://api.github.com/repos/awslabs/cfn-python-lint/hooks","issue_events_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/cfn-python-lint/events","assignees_url":"https://api.github.com/repos/awslabs/cfn-python-lint/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/cfn-python-lint/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/cfn-python-lint/tags","blobs_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/cfn-python-lint/languages","stargazers_url":"https://api.github.com/repos/awslabs/cfn-python-lint/stargazers","contributors_url":"https://api.github.com/repos/awslabs/cfn-python-lint/contributors","subscribers_url":"https://api.github.com/repos/awslabs/cfn-python-lint/subscribers","subscription_url":"https://api.github.com/repos/awslabs/cfn-python-lint/subscription","commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/cfn-python-lint/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/cfn-python-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/cfn-python-lint/merges","archive_url":"https://api.github.com/repos/awslabs/cfn-python-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/cfn-python-lint/downloads","issues_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/cfn-python-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/cfn-python-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/cfn-python-lint/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/cfn-python-lint/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/deployments","created_at":"2018-04-10T23:16:16Z","updated_at":"2018-06-20T21:56:26Z","pushed_at":"2018-06-21T06:11:15Z","git_url":"git://github.com/awslabs/cfn-python-lint.git","ssh_url":"git@github.com:awslabs/cfn-python-lint.git","clone_url":"https://github.com/awslabs/cfn-python-lint.git","svn_url":"https://github.com/awslabs/cfn-python-lint","homepage":null,"size":803,"stargazers_count":106,"watchers_count":106,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":17,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121"},"html":{"href":"https://github.com/awslabs/cfn-python-lint/pull/121"},"issue":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/121"},"comments":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/4a20b0d9780e8f66d3fd861ab230c53c275e1d5c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kddejong"}}