{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments/242293424","pull_request_review_id":184929348,"id":242293424,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjI5MzQyNA==","diff_hunk":"@@ -100,16 +88,12 @@ func TestLCOWUVMStart_KernelDirect_InitRd(t *testing.T) {\n }\n \n func testLCOWTimeUVMStart(t *testing.T, kernelDirect bool, rfsType uvm.PreferredRootFSType) {\n-\tvar vpmemCount uint32 = 32\n \tfor i := 0; i < 3; i++ {\n-\t\topts := &uvm.OptionsLCOW{\n-\t\t\tOptions: &uvm.Options{\n-\t\t\t\tID: t.Name(),\n-\t\t\t},\n-\t\t\tVPMemDeviceCount:    &vpmemCount,\n-\t\t\tPreferredRootFSType: &rfsType,\n-\t\t\tKernelDirect:        kernelDirect,\n-\t\t}\n+\t\topts := uvm.NewDefaultOptionsLCOW(t.Name(), \"\")\n+\t\topts.KernelDirect = kernelDirect\n+\t\topts.VPMemDeviceCount = 32\n+\t\topts.PreferredRootFSType = rfsType","path":"functional/lcow_test.go","position":60,"original_position":60,"commit_id":"d144c3909d961ceda03c8a7fb749968ba4d0d96f","original_commit_id":"d144c3909d961ceda03c8a7fb749968ba4d0d96f","user":{"login":"kevpar","id":315397,"node_id":"MDQ6VXNlcjMxNTM5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/315397?v=4","gravatar_id":"","url":"https://api.github.com/users/kevpar","html_url":"https://github.com/kevpar","followers_url":"https://api.github.com/users/kevpar/followers","following_url":"https://api.github.com/users/kevpar/following{/other_user}","gists_url":"https://api.github.com/users/kevpar/gists{/gist_id}","starred_url":"https://api.github.com/users/kevpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevpar/subscriptions","organizations_url":"https://api.github.com/users/kevpar/orgs","repos_url":"https://api.github.com/users/kevpar/repos","events_url":"https://api.github.com/users/kevpar/events{/privacy}","received_events_url":"https://api.github.com/users/kevpar/received_events","type":"User","site_admin":false},"body":"Change root FS name to rootfs.vhd if `rfsType` is VHD.","created_at":"2018-12-17T19:53:32Z","updated_at":"2018-12-17T19:58:06Z","html_url":"https://github.com/Microsoft/hcsshim/pull/426#discussion_r242293424","pull_request_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments/242293424"},"html":{"href":"https://github.com/Microsoft/hcsshim/pull/426#discussion_r242293424"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426","id":238564246,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTY0MjQ2","html_url":"https://github.com/Microsoft/hcsshim/pull/426","diff_url":"https://github.com/Microsoft/hcsshim/pull/426.diff","patch_url":"https://github.com/Microsoft/hcsshim/pull/426.patch","issue_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/426","number":426,"state":"open","locked":false,"title":"Simplify WCOW/LCOW opts passing","user":{"login":"jterry75","id":5858142,"node_id":"MDQ6VXNlcjU4NTgxNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5858142?v=4","gravatar_id":"","url":"https://api.github.com/users/jterry75","html_url":"https://github.com/jterry75","followers_url":"https://api.github.com/users/jterry75/followers","following_url":"https://api.github.com/users/jterry75/following{/other_user}","gists_url":"https://api.github.com/users/jterry75/gists{/gist_id}","starred_url":"https://api.github.com/users/jterry75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jterry75/subscriptions","organizations_url":"https://api.github.com/users/jterry75/orgs","repos_url":"https://api.github.com/users/jterry75/repos","events_url":"https://api.github.com/users/jterry75/events{/privacy}","received_events_url":"https://api.github.com/users/jterry75/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>","created_at":"2018-12-13T23:19:06Z","updated_at":"2018-12-17T19:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"105c82b80d77d61eb7fc4dde85e7773091f21289","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426/commits","review_comments_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426/comments","review_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/426/comments","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/d144c3909d961ceda03c8a7fb749968ba4d0d96f","head":{"label":"Microsoft:simplify_uvm_ots","ref":"simplify_uvm_ots","sha":"d144c3909d961ceda03c8a7fb749968ba4d0d96f","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38258831,"node_id":"MDEwOlJlcG9zaXRvcnkzODI1ODgzMQ==","name":"hcsshim","full_name":"Microsoft/hcsshim","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/hcsshim","description":"Windows - Host Compute Service Shim","fork":false,"url":"https://api.github.com/repos/Microsoft/hcsshim","forks_url":"https://api.github.com/repos/Microsoft/hcsshim/forks","keys_url":"https://api.github.com/repos/Microsoft/hcsshim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/hcsshim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/hcsshim/teams","hooks_url":"https://api.github.com/repos/Microsoft/hcsshim/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/hcsshim/events","assignees_url":"https://api.github.com/repos/Microsoft/hcsshim/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/hcsshim/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/hcsshim/tags","blobs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/hcsshim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/hcsshim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/hcsshim/languages","stargazers_url":"https://api.github.com/repos/Microsoft/hcsshim/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/hcsshim/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/hcsshim/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/hcsshim/subscription","commits_url":"https://api.github.com/repos/Microsoft/hcsshim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/hcsshim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/hcsshim/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/hcsshim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/hcsshim/merges","archive_url":"https://api.github.com/repos/Microsoft/hcsshim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/hcsshim/downloads","issues_url":"https://api.github.com/repos/Microsoft/hcsshim/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/hcsshim/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/hcsshim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/hcsshim/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/hcsshim/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/hcsshim/deployments","created_at":"2015-06-29T16:44:26Z","updated_at":"2018-12-17T19:01:05Z","pushed_at":"2018-12-17T19:01:02Z","git_url":"git://github.com/Microsoft/hcsshim.git","ssh_url":"git@github.com:Microsoft/hcsshim.git","clone_url":"https://github.com/Microsoft/hcsshim.git","svn_url":"https://github.com/Microsoft/hcsshim","homepage":null,"size":1408,"stargazers_count":155,"watchers_count":155,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":26,"watchers":155,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2bf3a7ac42318aacfffd0805be705ff2e4d1138f","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38258831,"node_id":"MDEwOlJlcG9zaXRvcnkzODI1ODgzMQ==","name":"hcsshim","full_name":"Microsoft/hcsshim","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/hcsshim","description":"Windows - Host Compute Service Shim","fork":false,"url":"https://api.github.com/repos/Microsoft/hcsshim","forks_url":"https://api.github.com/repos/Microsoft/hcsshim/forks","keys_url":"https://api.github.com/repos/Microsoft/hcsshim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/hcsshim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/hcsshim/teams","hooks_url":"https://api.github.com/repos/Microsoft/hcsshim/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/hcsshim/events","assignees_url":"https://api.github.com/repos/Microsoft/hcsshim/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/hcsshim/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/hcsshim/tags","blobs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/hcsshim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/hcsshim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/hcsshim/languages","stargazers_url":"https://api.github.com/repos/Microsoft/hcsshim/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/hcsshim/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/hcsshim/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/hcsshim/subscription","commits_url":"https://api.github.com/repos/Microsoft/hcsshim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/hcsshim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/hcsshim/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/hcsshim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/hcsshim/merges","archive_url":"https://api.github.com/repos/Microsoft/hcsshim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/hcsshim/downloads","issues_url":"https://api.github.com/repos/Microsoft/hcsshim/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/hcsshim/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/hcsshim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/hcsshim/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/hcsshim/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/hcsshim/deployments","created_at":"2015-06-29T16:44:26Z","updated_at":"2018-12-17T19:01:05Z","pushed_at":"2018-12-17T19:01:02Z","git_url":"git://github.com/Microsoft/hcsshim.git","ssh_url":"git@github.com:Microsoft/hcsshim.git","clone_url":"https://github.com/Microsoft/hcsshim.git","svn_url":"https://github.com/Microsoft/hcsshim","homepage":null,"size":1408,"stargazers_count":155,"watchers_count":155,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":26,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426"},"html":{"href":"https://github.com/Microsoft/hcsshim/pull/426"},"issue":{"href":"https://api.github.com/repos/Microsoft/hcsshim/issues/426"},"comments":{"href":"https://api.github.com/repos/Microsoft/hcsshim/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/hcsshim/statuses/d144c3909d961ceda03c8a7fb749968ba4d0d96f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kevpar"}}