{"action":"created","comment":{"url":"https://api.github.com/repos/dhermes/py-crc32c/pulls/comments/231960414","pull_request_review_id":173045422,"id":231960414,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTk2MDQxNA==","diff_hunk":"@@ -12,6 +12,7 @@\n import functools\n import itertools\n \n+import mock","path":"tests/test___init__.py","position":4,"original_position":4,"commit_id":"44a0277c2c689d44a258f1e1dec641a9eb2ad549","original_commit_id":"44a0277c2c689d44a258f1e1dec641a9eb2ad549","user":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"@tseaver You should use `unittest.mock` (which means this would move to the stdlib imports section too). I usually use a [hack][1] for Python 2.7, so we can forget about it when 2020 comes:\r\n\r\n```python\r\n# conftest.py\r\nif six.PY2:\r\n    import mock\r\n\r\n    unittest.mock = mock\r\n    sys.modules[\"unittest.mock\"] = unittest.mock\r\n```\r\n\r\n[1]: https://github.com/dhermes/bezier/blob/7c5b72e823cb8a88dbc81ea2581ba9e5fa204eba/tests/conftest.py#L27-L31","created_at":"2018-11-08T16:23:16Z","updated_at":"2018-11-08T16:38:46Z","html_url":"https://github.com/dhermes/py-crc32c/pull/6#discussion_r231960414","pull_request_url":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dhermes/py-crc32c/pulls/comments/231960414"},"html":{"href":"https://github.com/dhermes/py-crc32c/pull/6#discussion_r231960414"},"pull_request":{"href":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6","id":229421452,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDIxNDUy","html_url":"https://github.com/dhermes/py-crc32c/pull/6","diff_url":"https://github.com/dhermes/py-crc32c/pull/6.diff","patch_url":"https://github.com/dhermes/py-crc32c/pull/6.patch","issue_url":"https://api.github.com/repos/dhermes/py-crc32c/issues/6","number":6,"state":"open","locked":false,"title":"Add 'Checksum.consume' method, wrapping chunks read from a stream","user":{"login":"tseaver","id":242750,"node_id":"MDQ6VXNlcjI0Mjc1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/242750?v=4","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-08T16:07:56Z","updated_at":"2018-11-08T16:38:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4f2c5ee632a1962c60df8b1c0c855a6535b36af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6/commits","review_comments_url":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6/comments","review_comment_url":"https://api.github.com/repos/dhermes/py-crc32c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhermes/py-crc32c/issues/6/comments","statuses_url":"https://api.github.com/repos/dhermes/py-crc32c/statuses/44a0277c2c689d44a258f1e1dec641a9eb2ad549","head":{"label":"dhermes:add-helper-consume","ref":"add-helper-consume","sha":"44a0277c2c689d44a258f1e1dec641a9eb2ad549","user":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":154538689,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1Mzg2ODk=","name":"py-crc32c","full_name":"dhermes/py-crc32c","private":false,"owner":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dhermes/py-crc32c","description":"Python / CFFI wrapper for google/crc32c","fork":false,"url":"https://api.github.com/repos/dhermes/py-crc32c","forks_url":"https://api.github.com/repos/dhermes/py-crc32c/forks","keys_url":"https://api.github.com/repos/dhermes/py-crc32c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/py-crc32c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/py-crc32c/teams","hooks_url":"https://api.github.com/repos/dhermes/py-crc32c/hooks","issue_events_url":"https://api.github.com/repos/dhermes/py-crc32c/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/py-crc32c/events","assignees_url":"https://api.github.com/repos/dhermes/py-crc32c/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/py-crc32c/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/py-crc32c/tags","blobs_url":"https://api.github.com/repos/dhermes/py-crc32c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/py-crc32c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/py-crc32c/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/py-crc32c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/py-crc32c/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/py-crc32c/languages","stargazers_url":"https://api.github.com/repos/dhermes/py-crc32c/stargazers","contributors_url":"https://api.github.com/repos/dhermes/py-crc32c/contributors","subscribers_url":"https://api.github.com/repos/dhermes/py-crc32c/subscribers","subscription_url":"https://api.github.com/repos/dhermes/py-crc32c/subscription","commits_url":"https://api.github.com/repos/dhermes/py-crc32c/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/py-crc32c/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/py-crc32c/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/py-crc32c/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhermes/py-crc32c/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/py-crc32c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/py-crc32c/merges","archive_url":"https://api.github.com/repos/dhermes/py-crc32c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/py-crc32c/downloads","issues_url":"https://api.github.com/repos/dhermes/py-crc32c/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/py-crc32c/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/py-crc32c/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/py-crc32c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/py-crc32c/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/py-crc32c/releases{/id}","deployments_url":"https://api.github.com/repos/dhermes/py-crc32c/deployments","created_at":"2018-10-24T17:08:25Z","updated_at":"2018-11-08T15:26:04Z","pushed_at":"2018-11-08T16:07:57Z","git_url":"git://github.com/dhermes/py-crc32c.git","ssh_url":"git@github.com:dhermes/py-crc32c.git","clone_url":"https://github.com/dhermes/py-crc32c.git","svn_url":"https://github.com/dhermes/py-crc32c","homepage":"","size":259,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"dhermes:master","ref":"master","sha":"d22192c6e3a2e550c98a0066a2db8d3053abef3f","user":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":154538689,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1Mzg2ODk=","name":"py-crc32c","full_name":"dhermes/py-crc32c","private":false,"owner":{"login":"dhermes","id":520669,"node_id":"MDQ6VXNlcjUyMDY2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dhermes/py-crc32c","description":"Python / CFFI wrapper for google/crc32c","fork":false,"url":"https://api.github.com/repos/dhermes/py-crc32c","forks_url":"https://api.github.com/repos/dhermes/py-crc32c/forks","keys_url":"https://api.github.com/repos/dhermes/py-crc32c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/py-crc32c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/py-crc32c/teams","hooks_url":"https://api.github.com/repos/dhermes/py-crc32c/hooks","issue_events_url":"https://api.github.com/repos/dhermes/py-crc32c/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/py-crc32c/events","assignees_url":"https://api.github.com/repos/dhermes/py-crc32c/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/py-crc32c/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/py-crc32c/tags","blobs_url":"https://api.github.com/repos/dhermes/py-crc32c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/py-crc32c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/py-crc32c/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/py-crc32c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/py-crc32c/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/py-crc32c/languages","stargazers_url":"https://api.github.com/repos/dhermes/py-crc32c/stargazers","contributors_url":"https://api.github.com/repos/dhermes/py-crc32c/contributors","subscribers_url":"https://api.github.com/repos/dhermes/py-crc32c/subscribers","subscription_url":"https://api.github.com/repos/dhermes/py-crc32c/subscription","commits_url":"https://api.github.com/repos/dhermes/py-crc32c/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/py-crc32c/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/py-crc32c/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/py-crc32c/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhermes/py-crc32c/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/py-crc32c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/py-crc32c/merges","archive_url":"https://api.github.com/repos/dhermes/py-crc32c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/py-crc32c/downloads","issues_url":"https://api.github.com/repos/dhermes/py-crc32c/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/py-crc32c/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/py-crc32c/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/py-crc32c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/py-crc32c/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/py-crc32c/releases{/id}","deployments_url":"https://api.github.com/repos/dhermes/py-crc32c/deployments","created_at":"2018-10-24T17:08:25Z","updated_at":"2018-11-08T15:26:04Z","pushed_at":"2018-11-08T16:07:57Z","git_url":"git://github.com/dhermes/py-crc32c.git","ssh_url":"git@github.com:dhermes/py-crc32c.git","clone_url":"https://github.com/dhermes/py-crc32c.git","svn_url":"https://github.com/dhermes/py-crc32c","homepage":"","size":259,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6"},"html":{"href":"https://github.com/dhermes/py-crc32c/pull/6"},"issue":{"href":"https://api.github.com/repos/dhermes/py-crc32c/issues/6"},"comments":{"href":"https://api.github.com/repos/dhermes/py-crc32c/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/dhermes/py-crc32c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhermes/py-crc32c/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/dhermes/py-crc32c/statuses/44a0277c2c689d44a258f1e1dec641a9eb2ad549"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dhermes"}}