{"action":"created","comment":{"url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments/202586980","pull_request_review_id":137314728,"id":202586980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU4Njk4MA==","diff_hunk":"@@ -1055,6 +1055,17 @@ void mutation_log::check_valid_start_offset(gpid gpid, int64_t valid_start_offse\n     }\n }\n \n+int64_t mutation_log::total_size() const\n+{\n+    zauto_lock l(_lock);\n+    return total_size_no_lock();\n+}\n+\n+int64_t mutation_log::total_size_no_lock() const\n+{\n+    return _log_files.size() > 0 ? _global_end_offset - _global_start_offset : 0;","path":"src/dist/replication/lib/mutation_log.cpp","position":12,"original_position":12,"commit_id":"607630b6c7c8ae2f9132e719952913946b2e2942","original_commit_id":"607630b6c7c8ae2f9132e719952913946b2e2942","user":{"login":"shengofsun","id":1041832,"node_id":"MDQ6VXNlcjEwNDE4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041832?v=4","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"body":"另外原来的size函数留着还有用吗？","created_at":"2018-07-16T07:04:52Z","updated_at":"2018-07-16T07:04:52Z","html_url":"https://github.com/XiaoMi/rdsn/pull/135#discussion_r202586980","pull_request_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments/202586980"},"html":{"href":"https://github.com/XiaoMi/rdsn/pull/135#discussion_r202586980"},"pull_request":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135"}},"in_reply_to_id":202586803},"pull_request":{"url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135","id":201551895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTUxODk1","html_url":"https://github.com/XiaoMi/rdsn/pull/135","diff_url":"https://github.com/XiaoMi/rdsn/pull/135.diff","patch_url":"https://github.com/XiaoMi/rdsn/pull/135.patch","issue_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/135","number":135,"state":"open","locked":false,"title":"bugfix: fix bug of calculating shared log size","user":{"login":"qinzuoyan","id":528445,"node_id":"MDQ6VXNlcjUyODQ0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/528445?v=4","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"body":"to fix #133 ","created_at":"2018-07-16T06:49:37Z","updated_at":"2018-07-16T07:04:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df649dc776a748d2fa343ff75c6796d9cf0d3f96","assignee":null,"assignees":[],"requested_reviewers":[{"login":"neverchanje","id":6970676,"node_id":"MDQ6VXNlcjY5NzA2NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6970676?v=4","gravatar_id":"","url":"https://api.github.com/users/neverchanje","html_url":"https://github.com/neverchanje","followers_url":"https://api.github.com/users/neverchanje/followers","following_url":"https://api.github.com/users/neverchanje/following{/other_user}","gists_url":"https://api.github.com/users/neverchanje/gists{/gist_id}","starred_url":"https://api.github.com/users/neverchanje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverchanje/subscriptions","organizations_url":"https://api.github.com/users/neverchanje/orgs","repos_url":"https://api.github.com/users/neverchanje/repos","events_url":"https://api.github.com/users/neverchanje/events{/privacy}","received_events_url":"https://api.github.com/users/neverchanje/received_events","type":"User","site_admin":false},{"login":"acelyc111","id":10775040,"node_id":"MDQ6VXNlcjEwNzc1MDQw","avatar_url":"https://avatars1.githubusercontent.com/u/10775040?v=4","gravatar_id":"","url":"https://api.github.com/users/acelyc111","html_url":"https://github.com/acelyc111","followers_url":"https://api.github.com/users/acelyc111/followers","following_url":"https://api.github.com/users/acelyc111/following{/other_user}","gists_url":"https://api.github.com/users/acelyc111/gists{/gist_id}","starred_url":"https://api.github.com/users/acelyc111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acelyc111/subscriptions","organizations_url":"https://api.github.com/users/acelyc111/orgs","repos_url":"https://api.github.com/users/acelyc111/repos","events_url":"https://api.github.com/users/acelyc111/events{/privacy}","received_events_url":"https://api.github.com/users/acelyc111/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":703964212,"node_id":"MDU6TGFiZWw3MDM5NjQyMTI=","url":"https://api.github.com/repos/XiaoMi/rdsn/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135/commits","review_comments_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135/comments","review_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/135/comments","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/607630b6c7c8ae2f9132e719952913946b2e2942","head":{"label":"XiaoMi:qinzuoyan1","ref":"qinzuoyan1","sha":"607630b6c7c8ae2f9132e719952913946b2e2942","user":{"login":"XiaoMi","id":1309360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"repo":{"id":104966876,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5NjY4NzY=","name":"rdsn","full_name":"XiaoMi/rdsn","owner":{"login":"XiaoMi","id":1309360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XiaoMi/rdsn","description":null,"fork":false,"url":"https://api.github.com/repos/XiaoMi/rdsn","forks_url":"https://api.github.com/repos/XiaoMi/rdsn/forks","keys_url":"https://api.github.com/repos/XiaoMi/rdsn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XiaoMi/rdsn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XiaoMi/rdsn/teams","hooks_url":"https://api.github.com/repos/XiaoMi/rdsn/hooks","issue_events_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/events{/number}","events_url":"https://api.github.com/repos/XiaoMi/rdsn/events","assignees_url":"https://api.github.com/repos/XiaoMi/rdsn/assignees{/user}","branches_url":"https://api.github.com/repos/XiaoMi/rdsn/branches{/branch}","tags_url":"https://api.github.com/repos/XiaoMi/rdsn/tags","blobs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XiaoMi/rdsn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/refs{/sha}","trees_url":"https://api.github.com/repos/XiaoMi/rdsn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/{sha}","languages_url":"https://api.github.com/repos/XiaoMi/rdsn/languages","stargazers_url":"https://api.github.com/repos/XiaoMi/rdsn/stargazers","contributors_url":"https://api.github.com/repos/XiaoMi/rdsn/contributors","subscribers_url":"https://api.github.com/repos/XiaoMi/rdsn/subscribers","subscription_url":"https://api.github.com/repos/XiaoMi/rdsn/subscription","commits_url":"https://api.github.com/repos/XiaoMi/rdsn/commits{/sha}","git_commits_url":"https://api.github.com/repos/XiaoMi/rdsn/git/commits{/sha}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/comments{/number}","issue_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/comments{/number}","contents_url":"https://api.github.com/repos/XiaoMi/rdsn/contents/{+path}","compare_url":"https://api.github.com/repos/XiaoMi/rdsn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XiaoMi/rdsn/merges","archive_url":"https://api.github.com/repos/XiaoMi/rdsn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XiaoMi/rdsn/downloads","issues_url":"https://api.github.com/repos/XiaoMi/rdsn/issues{/number}","pulls_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls{/number}","milestones_url":"https://api.github.com/repos/XiaoMi/rdsn/milestones{/number}","notifications_url":"https://api.github.com/repos/XiaoMi/rdsn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XiaoMi/rdsn/labels{/name}","releases_url":"https://api.github.com/repos/XiaoMi/rdsn/releases{/id}","deployments_url":"https://api.github.com/repos/XiaoMi/rdsn/deployments","created_at":"2017-09-27T03:19:21Z","updated_at":"2018-07-16T06:56:13Z","pushed_at":"2018-07-16T06:56:11Z","git_url":"git://github.com/XiaoMi/rdsn.git","ssh_url":"git@github.com:XiaoMi/rdsn.git","clone_url":"https://github.com/XiaoMi/rdsn.git","svn_url":"https://github.com/XiaoMi/rdsn","homepage":null,"size":79255,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":30,"watchers":39,"default_branch":"master"}},"base":{"label":"XiaoMi:master","ref":"master","sha":"6ce6d435ef226f38c07f18d3caeda54460a1a61d","user":{"login":"XiaoMi","id":1309360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"repo":{"id":104966876,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5NjY4NzY=","name":"rdsn","full_name":"XiaoMi/rdsn","owner":{"login":"XiaoMi","id":1309360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDkzNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XiaoMi/rdsn","description":null,"fork":false,"url":"https://api.github.com/repos/XiaoMi/rdsn","forks_url":"https://api.github.com/repos/XiaoMi/rdsn/forks","keys_url":"https://api.github.com/repos/XiaoMi/rdsn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XiaoMi/rdsn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XiaoMi/rdsn/teams","hooks_url":"https://api.github.com/repos/XiaoMi/rdsn/hooks","issue_events_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/events{/number}","events_url":"https://api.github.com/repos/XiaoMi/rdsn/events","assignees_url":"https://api.github.com/repos/XiaoMi/rdsn/assignees{/user}","branches_url":"https://api.github.com/repos/XiaoMi/rdsn/branches{/branch}","tags_url":"https://api.github.com/repos/XiaoMi/rdsn/tags","blobs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XiaoMi/rdsn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/refs{/sha}","trees_url":"https://api.github.com/repos/XiaoMi/rdsn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/{sha}","languages_url":"https://api.github.com/repos/XiaoMi/rdsn/languages","stargazers_url":"https://api.github.com/repos/XiaoMi/rdsn/stargazers","contributors_url":"https://api.github.com/repos/XiaoMi/rdsn/contributors","subscribers_url":"https://api.github.com/repos/XiaoMi/rdsn/subscribers","subscription_url":"https://api.github.com/repos/XiaoMi/rdsn/subscription","commits_url":"https://api.github.com/repos/XiaoMi/rdsn/commits{/sha}","git_commits_url":"https://api.github.com/repos/XiaoMi/rdsn/git/commits{/sha}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/comments{/number}","issue_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/comments{/number}","contents_url":"https://api.github.com/repos/XiaoMi/rdsn/contents/{+path}","compare_url":"https://api.github.com/repos/XiaoMi/rdsn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XiaoMi/rdsn/merges","archive_url":"https://api.github.com/repos/XiaoMi/rdsn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XiaoMi/rdsn/downloads","issues_url":"https://api.github.com/repos/XiaoMi/rdsn/issues{/number}","pulls_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls{/number}","milestones_url":"https://api.github.com/repos/XiaoMi/rdsn/milestones{/number}","notifications_url":"https://api.github.com/repos/XiaoMi/rdsn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XiaoMi/rdsn/labels{/name}","releases_url":"https://api.github.com/repos/XiaoMi/rdsn/releases{/id}","deployments_url":"https://api.github.com/repos/XiaoMi/rdsn/deployments","created_at":"2017-09-27T03:19:21Z","updated_at":"2018-07-16T06:56:13Z","pushed_at":"2018-07-16T06:56:11Z","git_url":"git://github.com/XiaoMi/rdsn.git","ssh_url":"git@github.com:XiaoMi/rdsn.git","clone_url":"https://github.com/XiaoMi/rdsn.git","svn_url":"https://github.com/XiaoMi/rdsn","homepage":null,"size":79255,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":30,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135"},"html":{"href":"https://github.com/XiaoMi/rdsn/pull/135"},"issue":{"href":"https://api.github.com/repos/XiaoMi/rdsn/issues/135"},"comments":{"href":"https://api.github.com/repos/XiaoMi/rdsn/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/XiaoMi/rdsn/statuses/607630b6c7c8ae2f9132e719952913946b2e2942"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"shengofsun"}}