{"action":"created","issue":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/6913","repository_url":"https://api.github.com/repos/pytorch/pytorch","labels_url":"https://api.github.com/repos/pytorch/pytorch/issues/6913/labels{/name}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/6913/comments","events_url":"https://api.github.com/repos/pytorch/pytorch/issues/6913/events","html_url":"https://github.com/pytorch/pytorch/pull/6913","id":317408403,"number":6913,"title":"Make all of TH and THC C++.","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-24T21:51:26Z","updated_at":"2018-04-25T03:52:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/6913","html_url":"https://github.com/pytorch/pytorch/pull/6913","diff_url":"https://github.com/pytorch/pytorch/pull/6913.diff","patch_url":"https://github.com/pytorch/pytorch/pull/6913.patch"},"body":"Changelist:\r\n\r\n- Move *.c to *.cpp\r\n- Change includes of \"*.c\" to \"*.cpp\"\r\n- A bunch of cmake configuration modifying CMAKE_C_FLAGS changed\r\n  to CMAKE_CXX_FLAGS\r\n- Removal of all extern \"C\"\r\n\r\nThis formally removes support for old-style C FFI support via torch.utils.ffi,\r\nbecause you won't be able to build a C extension against non-extern \"C\" headers\r\nanymore.\r\n\r\nSigned-off-by: Edward Z. Yang <ezyang@fb.com>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/comments/384152960","html_url":"https://github.com/pytorch/pytorch/pull/6913#issuecomment-384152960","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/6913","id":384152960,"user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T03:52:41Z","updated_at":"2018-04-25T03:52:41Z","author_association":"CONTRIBUTOR","body":"GCC 7.2 probably missing an extern \"C\" around one of the includes. c.f. https://bugs.python.org/issue23644"}}
{"actor":{"display_login":"ezyang"}}