{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/36","id":201255440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjU1NDQw","html_url":"https://github.com/8select/shopware-plugin-sob/pull/36","diff_url":"https://github.com/8select/shopware-plugin-sob/pull/36.diff","patch_url":"https://github.com/8select/shopware-plugin-sob/pull/36.patch","issue_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/36","number":36,"state":"closed","locked":false,"title":"CSE-954 fix wrong tab selection","user":{"login":"jbreckel","id":9253219,"node_id":"MDQ6VXNlcjkyNTMyMTk=","avatar_url":"https://avatars2.githubusercontent.com/u/9253219?v=4","gravatar_id":"","url":"https://api.github.com/users/jbreckel","html_url":"https://github.com/jbreckel","followers_url":"https://api.github.com/users/jbreckel/followers","following_url":"https://api.github.com/users/jbreckel/following{/other_user}","gists_url":"https://api.github.com/users/jbreckel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbreckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbreckel/subscriptions","organizations_url":"https://api.github.com/users/jbreckel/orgs","repos_url":"https://api.github.com/users/jbreckel/repos","events_url":"https://api.github.com/users/jbreckel/events{/privacy}","received_events_url":"https://api.github.com/users/jbreckel/received_events","type":"User","site_admin":false},"body":"**Jira Issue**\r\n\r\nhttps://8select.atlassian.net/browse/CSE-954\r\n\r\n**Summary**\r\n\r\n* deduplicate wgt-ldr loading\r\n* query for tabs and content with `querySelector` to avoid duplicated code for `before` and `after` config\r\n\r\n<!--\r\nYou can assign a team-member to review the PR.\r\nIf you are confident that no critical system breaks you can merge without a review.\r\n-->\r\n**Checklist**\r\n\r\n- [x] PR title is prefixed with Jira Issue Id - e.g. CSE-42\r\n- [x] Add feature / bug label\r\n- [x] Unit tests for new / changed logic exist OR no logic changes are passing\r\n","created_at":"2018-07-13T10:49:02Z","updated_at":"2018-07-16T08:19:38Z","closed_at":"2018-07-16T08:19:38Z","merged_at":"2018-07-16T08:19:38Z","merge_commit_sha":"cebc87940c942b52d01405b579f3aa21ea84155f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"voodoods","id":1707307,"node_id":"MDQ6VXNlcjE3MDczMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1707307?v=4","gravatar_id":"","url":"https://api.github.com/users/voodoods","html_url":"https://github.com/voodoods","followers_url":"https://api.github.com/users/voodoods/followers","following_url":"https://api.github.com/users/voodoods/following{/other_user}","gists_url":"https://api.github.com/users/voodoods/gists{/gist_id}","starred_url":"https://api.github.com/users/voodoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voodoods/subscriptions","organizations_url":"https://api.github.com/users/voodoods/orgs","repos_url":"https://api.github.com/users/voodoods/repos","events_url":"https://api.github.com/users/voodoods/events{/privacy}","received_events_url":"https://api.github.com/users/voodoods/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":933350494,"node_id":"MDU6TGFiZWw5MzMzNTA0OTQ=","url":"https://api.github.com/repos/8select/shopware-plugin-sob/labels/bug","name":"bug","color":"ff0000","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/36/commits","review_comments_url":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/36/comments","review_comment_url":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/comments{/number}","comments_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/36/comments","statuses_url":"https://api.github.com/repos/8select/shopware-plugin-sob/statuses/d4a55f0520b76f195cb269b83d74f825d4fd9485","head":{"label":"8select:CSE-954-fix-wrong-tab-selection","ref":"CSE-954-fix-wrong-tab-selection","sha":"d4a55f0520b76f195cb269b83d74f825d4fd9485","user":{"login":"8select","id":16205986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjA1OTg2","avatar_url":"https://avatars3.githubusercontent.com/u/16205986?v=4","gravatar_id":"","url":"https://api.github.com/users/8select","html_url":"https://github.com/8select","followers_url":"https://api.github.com/users/8select/followers","following_url":"https://api.github.com/users/8select/following{/other_user}","gists_url":"https://api.github.com/users/8select/gists{/gist_id}","starred_url":"https://api.github.com/users/8select/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/8select/subscriptions","organizations_url":"https://api.github.com/users/8select/orgs","repos_url":"https://api.github.com/users/8select/repos","events_url":"https://api.github.com/users/8select/events{/privacy}","received_events_url":"https://api.github.com/users/8select/received_events","type":"Organization","site_admin":false},"repo":{"id":133458195,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NTgxOTU=","name":"shopware-plugin-sob","full_name":"8select/shopware-plugin-sob","owner":{"login":"8select","id":16205986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjA1OTg2","avatar_url":"https://avatars3.githubusercontent.com/u/16205986?v=4","gravatar_id":"","url":"https://api.github.com/users/8select","html_url":"https://github.com/8select","followers_url":"https://api.github.com/users/8select/followers","following_url":"https://api.github.com/users/8select/following{/other_user}","gists_url":"https://api.github.com/users/8select/gists{/gist_id}","starred_url":"https://api.github.com/users/8select/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/8select/subscriptions","organizations_url":"https://api.github.com/users/8select/orgs","repos_url":"https://api.github.com/users/8select/repos","events_url":"https://api.github.com/users/8select/events{/privacy}","received_events_url":"https://api.github.com/users/8select/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/8select/shopware-plugin-sob","description":null,"fork":false,"url":"https://api.github.com/repos/8select/shopware-plugin-sob","forks_url":"https://api.github.com/repos/8select/shopware-plugin-sob/forks","keys_url":"https://api.github.com/repos/8select/shopware-plugin-sob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/8select/shopware-plugin-sob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/8select/shopware-plugin-sob/teams","hooks_url":"https://api.github.com/repos/8select/shopware-plugin-sob/hooks","issue_events_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/events{/number}","events_url":"https://api.github.com/repos/8select/shopware-plugin-sob/events","assignees_url":"https://api.github.com/repos/8select/shopware-plugin-sob/assignees{/user}","branches_url":"https://api.github.com/repos/8select/shopware-plugin-sob/branches{/branch}","tags_url":"https://api.github.com/repos/8select/shopware-plugin-sob/tags","blobs_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/refs{/sha}","trees_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/8select/shopware-plugin-sob/statuses/{sha}","languages_url":"https://api.github.com/repos/8select/shopware-plugin-sob/languages","stargazers_url":"https://api.github.com/repos/8select/shopware-plugin-sob/stargazers","contributors_url":"https://api.github.com/repos/8select/shopware-plugin-sob/contributors","subscribers_url":"https://api.github.com/repos/8select/shopware-plugin-sob/subscribers","subscription_url":"https://api.github.com/repos/8select/shopware-plugin-sob/subscription","commits_url":"https://api.github.com/repos/8select/shopware-plugin-sob/commits{/sha}","git_commits_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/commits{/sha}","comments_url":"https://api.github.com/repos/8select/shopware-plugin-sob/comments{/number}","issue_comment_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/comments{/number}","contents_url":"https://api.github.com/repos/8select/shopware-plugin-sob/contents/{+path}","compare_url":"https://api.github.com/repos/8select/shopware-plugin-sob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/8select/shopware-plugin-sob/merges","archive_url":"https://api.github.com/repos/8select/shopware-plugin-sob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/8select/shopware-plugin-sob/downloads","issues_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues{/number}","pulls_url":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls{/number}","milestones_url":"https://api.github.com/repos/8select/shopware-plugin-sob/milestones{/number}","notifications_url":"https://api.github.com/repos/8select/shopware-plugin-sob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/8select/shopware-plugin-sob/labels{/name}","releases_url":"https://api.github.com/repos/8select/shopware-plugin-sob/releases{/id}","deployments_url":"https://api.github.com/repos/8select/shopware-plugin-sob/deployments","created_at":"2018-05-15T04:16:32Z","updated_at":"2018-07-13T12:36:18Z","pushed_at":"2018-07-16T08:19:38Z","git_url":"git://github.com/8select/shopware-plugin-sob.git","ssh_url":"git@github.com:8select/shopware-plugin-sob.git","clone_url":"https://github.com/8select/shopware-plugin-sob.git","svn_url":"https://github.com/8select/shopware-plugin-sob","homepage":null,"size":2267,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"8select:master","ref":"master","sha":"42660067f541ec683758809fd05dd3d22e401a01","user":{"login":"8select","id":16205986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjA1OTg2","avatar_url":"https://avatars3.githubusercontent.com/u/16205986?v=4","gravatar_id":"","url":"https://api.github.com/users/8select","html_url":"https://github.com/8select","followers_url":"https://api.github.com/users/8select/followers","following_url":"https://api.github.com/users/8select/following{/other_user}","gists_url":"https://api.github.com/users/8select/gists{/gist_id}","starred_url":"https://api.github.com/users/8select/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/8select/subscriptions","organizations_url":"https://api.github.com/users/8select/orgs","repos_url":"https://api.github.com/users/8select/repos","events_url":"https://api.github.com/users/8select/events{/privacy}","received_events_url":"https://api.github.com/users/8select/received_events","type":"Organization","site_admin":false},"repo":{"id":133458195,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NTgxOTU=","name":"shopware-plugin-sob","full_name":"8select/shopware-plugin-sob","owner":{"login":"8select","id":16205986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjA1OTg2","avatar_url":"https://avatars3.githubusercontent.com/u/16205986?v=4","gravatar_id":"","url":"https://api.github.com/users/8select","html_url":"https://github.com/8select","followers_url":"https://api.github.com/users/8select/followers","following_url":"https://api.github.com/users/8select/following{/other_user}","gists_url":"https://api.github.com/users/8select/gists{/gist_id}","starred_url":"https://api.github.com/users/8select/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/8select/subscriptions","organizations_url":"https://api.github.com/users/8select/orgs","repos_url":"https://api.github.com/users/8select/repos","events_url":"https://api.github.com/users/8select/events{/privacy}","received_events_url":"https://api.github.com/users/8select/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/8select/shopware-plugin-sob","description":null,"fork":false,"url":"https://api.github.com/repos/8select/shopware-plugin-sob","forks_url":"https://api.github.com/repos/8select/shopware-plugin-sob/forks","keys_url":"https://api.github.com/repos/8select/shopware-plugin-sob/keys{/key_id}","collaborators_url":"https://api.github.com/repos/8select/shopware-plugin-sob/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/8select/shopware-plugin-sob/teams","hooks_url":"https://api.github.com/repos/8select/shopware-plugin-sob/hooks","issue_events_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/events{/number}","events_url":"https://api.github.com/repos/8select/shopware-plugin-sob/events","assignees_url":"https://api.github.com/repos/8select/shopware-plugin-sob/assignees{/user}","branches_url":"https://api.github.com/repos/8select/shopware-plugin-sob/branches{/branch}","tags_url":"https://api.github.com/repos/8select/shopware-plugin-sob/tags","blobs_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/refs{/sha}","trees_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/trees{/sha}","statuses_url":"https://api.github.com/repos/8select/shopware-plugin-sob/statuses/{sha}","languages_url":"https://api.github.com/repos/8select/shopware-plugin-sob/languages","stargazers_url":"https://api.github.com/repos/8select/shopware-plugin-sob/stargazers","contributors_url":"https://api.github.com/repos/8select/shopware-plugin-sob/contributors","subscribers_url":"https://api.github.com/repos/8select/shopware-plugin-sob/subscribers","subscription_url":"https://api.github.com/repos/8select/shopware-plugin-sob/subscription","commits_url":"https://api.github.com/repos/8select/shopware-plugin-sob/commits{/sha}","git_commits_url":"https://api.github.com/repos/8select/shopware-plugin-sob/git/commits{/sha}","comments_url":"https://api.github.com/repos/8select/shopware-plugin-sob/comments{/number}","issue_comment_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/comments{/number}","contents_url":"https://api.github.com/repos/8select/shopware-plugin-sob/contents/{+path}","compare_url":"https://api.github.com/repos/8select/shopware-plugin-sob/compare/{base}...{head}","merges_url":"https://api.github.com/repos/8select/shopware-plugin-sob/merges","archive_url":"https://api.github.com/repos/8select/shopware-plugin-sob/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/8select/shopware-plugin-sob/downloads","issues_url":"https://api.github.com/repos/8select/shopware-plugin-sob/issues{/number}","pulls_url":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls{/number}","milestones_url":"https://api.github.com/repos/8select/shopware-plugin-sob/milestones{/number}","notifications_url":"https://api.github.com/repos/8select/shopware-plugin-sob/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/8select/shopware-plugin-sob/labels{/name}","releases_url":"https://api.github.com/repos/8select/shopware-plugin-sob/releases{/id}","deployments_url":"https://api.github.com/repos/8select/shopware-plugin-sob/deployments","created_at":"2018-05-15T04:16:32Z","updated_at":"2018-07-13T12:36:18Z","pushed_at":"2018-07-16T08:19:38Z","git_url":"git://github.com/8select/shopware-plugin-sob.git","ssh_url":"git@github.com:8select/shopware-plugin-sob.git","clone_url":"https://github.com/8select/shopware-plugin-sob.git","svn_url":"https://github.com/8select/shopware-plugin-sob","homepage":null,"size":2267,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/36"},"html":{"href":"https://github.com/8select/shopware-plugin-sob/pull/36"},"issue":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/36"},"comments":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/8select/shopware-plugin-sob/statuses/d4a55f0520b76f195cb269b83d74f825d4fd9485"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jbreckel","id":9253219,"node_id":"MDQ6VXNlcjkyNTMyMTk=","avatar_url":"https://avatars2.githubusercontent.com/u/9253219?v=4","gravatar_id":"","url":"https://api.github.com/users/jbreckel","html_url":"https://github.com/jbreckel","followers_url":"https://api.github.com/users/jbreckel/followers","following_url":"https://api.github.com/users/jbreckel/following{/other_user}","gists_url":"https://api.github.com/users/jbreckel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbreckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbreckel/subscriptions","organizations_url":"https://api.github.com/users/jbreckel/orgs","repos_url":"https://api.github.com/users/jbreckel/repos","events_url":"https://api.github.com/users/jbreckel/events{/privacy}","received_events_url":"https://api.github.com/users/jbreckel/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":62,"deletions":113,"changed_files":4}}
{"actor":{"display_login":"jbreckel"}}