{"action":"created","comment":{"url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/comments/226473218","pull_request_review_id":166304989,"id":226473218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ3MzIxOA==","diff_hunk":"@@ -120,26 +80,28 @@ implementing the `DDMFormFieldType` service (`service=...`).\n `DDMFormFieldType` Components can have several properties:\n \n `ddm.form.field.type.description`\n-: It's an optional property which describes the field type. Its localized value appears in the sidebar of the form builder, just below the `ddm.form.field.type.label`.\n+: An optional property describing the field type. Its localized value appears in\n+the form builder's sidebar, just below the field's label.\n \n `ddm.form.field.type.display.order`\n-: Integer that defines the field type's position in the sidebar.\n+: An Integer defining the field type's position in the sidebar.\n \n `ddm.form.field.type.icon`\n-: The icon to be used for the field type. Choosing one of the \n-[Lexicon icons](https://lexicondesign.io/docs/patterns/icons.html) makes your form\n-field blends in with the existing form field types.\n+: The icon for the field type. Choosing one of the \n+[Lexicon icons](https://lexicondesign.io/docs/patterns/icons.html) \n+makes your form field blends in with the existing form field types.\n \n `ddm.form.field.type.js.class.name`\n-: The field type's JavaScript class name--the JavaScript file is used to define\n-the field type's behavior.\n+: The field type's JavaScript class name---the JavaScript file defines the field\n+type's behavior.\n \n `ddm.form.field.type.js.module`\n-: The name of the JavaScript module--provided to the Form engine so the module\n+: The name of the JavaScript module is provided to the Form engine so the module","path":"develop/tutorials/articles/260-forms/01-form-field-types/01-creating-form-field-types.markdown","position":99,"original_position":142,"commit_id":"5ecdeb2d8dac2e4314aa098cb878f280afe81d41","original_commit_id":"5ecdeb2d8dac2e4314aa098cb878f280afe81d41","user":{"login":"rbohl","id":1728666,"node_id":"MDQ6VXNlcjE3Mjg2NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1728666?v=4","gravatar_id":"","url":"https://api.github.com/users/rbohl","html_url":"https://github.com/rbohl","followers_url":"https://api.github.com/users/rbohl/followers","following_url":"https://api.github.com/users/rbohl/following{/other_user}","gists_url":"https://api.github.com/users/rbohl/gists{/gist_id}","starred_url":"https://api.github.com/users/rbohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbohl/subscriptions","organizations_url":"https://api.github.com/users/rbohl/orgs","repos_url":"https://api.github.com/users/rbohl/repos","events_url":"https://api.github.com/users/rbohl/events{/privacy}","received_events_url":"https://api.github.com/users/rbohl/received_events","type":"User","site_admin":false},"body":"I don't think so. This is more direct.\r\n","created_at":"2018-10-18T21:33:15Z","updated_at":"2018-10-18T21:33:15Z","html_url":"https://github.com/natocesarrego/liferay-docs/pull/29#discussion_r226473218","pull_request_url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/comments/226473218"},"html":{"href":"https://github.com/natocesarrego/liferay-docs/pull/29#discussion_r226473218"},"pull_request":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29"}},"in_reply_to_id":222446058},"pull_request":{"url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29","id":219714419,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzE0NDE5","html_url":"https://github.com/natocesarrego/liferay-docs/pull/29","diff_url":"https://github.com/natocesarrego/liferay-docs/pull/29.diff","patch_url":"https://github.com/natocesarrego/liferay-docs/pull/29.patch","issue_url":"https://api.github.com/repos/natocesarrego/liferay-docs/issues/29","number":29,"state":"open","locked":false,"title":"LRDOCS-4617, form field types (getting closer)","user":{"login":"rbohl","id":1728666,"node_id":"MDQ6VXNlcjE3Mjg2NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1728666?v=4","gravatar_id":"","url":"https://api.github.com/users/rbohl","html_url":"https://github.com/rbohl","followers_url":"https://api.github.com/users/rbohl/followers","following_url":"https://api.github.com/users/rbohl/following{/other_user}","gists_url":"https://api.github.com/users/rbohl/gists{/gist_id}","starred_url":"https://api.github.com/users/rbohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbohl/subscriptions","organizations_url":"https://api.github.com/users/rbohl/orgs","repos_url":"https://api.github.com/users/rbohl/repos","events_url":"https://api.github.com/users/rbohl/events{/privacy}","received_events_url":"https://api.github.com/users/rbohl/received_events","type":"User","site_admin":false},"body":"https://issues.liferay.com/browse/LRDOCS-4617, see my edits and let me know if it looks good so far. I think there are 2 things left to do. 1. Clear up the instructions on creating from a Blade template, and 2. Breaking them up or cutting them down to be shorter. I've tried to shorten them a little without losing any details.","created_at":"2018-10-02T14:00:25Z","updated_at":"2018-10-18T21:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb5c48aca79d4a67089a37b46373313efa20c2cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29/commits","review_comments_url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29/comments","review_comment_url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/natocesarrego/liferay-docs/issues/29/comments","statuses_url":"https://api.github.com/repos/natocesarrego/liferay-docs/statuses/5ecdeb2d8dac2e4314aa098cb878f280afe81d41","head":{"label":"rbohl:LRDOCS-4617-field-types-rewritten","ref":"LRDOCS-4617-field-types-rewritten","sha":"5ecdeb2d8dac2e4314aa098cb878f280afe81d41","user":{"login":"rbohl","id":1728666,"node_id":"MDQ6VXNlcjE3Mjg2NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1728666?v=4","gravatar_id":"","url":"https://api.github.com/users/rbohl","html_url":"https://github.com/rbohl","followers_url":"https://api.github.com/users/rbohl/followers","following_url":"https://api.github.com/users/rbohl/following{/other_user}","gists_url":"https://api.github.com/users/rbohl/gists{/gist_id}","starred_url":"https://api.github.com/users/rbohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbohl/subscriptions","organizations_url":"https://api.github.com/users/rbohl/orgs","repos_url":"https://api.github.com/users/rbohl/repos","events_url":"https://api.github.com/users/rbohl/events{/privacy}","received_events_url":"https://api.github.com/users/rbohl/received_events","type":"User","site_admin":false},"repo":{"id":7737083,"node_id":"MDEwOlJlcG9zaXRvcnk3NzM3MDgz","name":"liferay-docs","full_name":"rbohl/liferay-docs","private":false,"owner":{"login":"rbohl","id":1728666,"node_id":"MDQ6VXNlcjE3Mjg2NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1728666?v=4","gravatar_id":"","url":"https://api.github.com/users/rbohl","html_url":"https://github.com/rbohl","followers_url":"https://api.github.com/users/rbohl/followers","following_url":"https://api.github.com/users/rbohl/following{/other_user}","gists_url":"https://api.github.com/users/rbohl/gists{/gist_id}","starred_url":"https://api.github.com/users/rbohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbohl/subscriptions","organizations_url":"https://api.github.com/users/rbohl/orgs","repos_url":"https://api.github.com/users/rbohl/repos","events_url":"https://api.github.com/users/rbohl/events{/privacy}","received_events_url":"https://api.github.com/users/rbohl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rbohl/liferay-docs","description":null,"fork":true,"url":"https://api.github.com/repos/rbohl/liferay-docs","forks_url":"https://api.github.com/repos/rbohl/liferay-docs/forks","keys_url":"https://api.github.com/repos/rbohl/liferay-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbohl/liferay-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbohl/liferay-docs/teams","hooks_url":"https://api.github.com/repos/rbohl/liferay-docs/hooks","issue_events_url":"https://api.github.com/repos/rbohl/liferay-docs/issues/events{/number}","events_url":"https://api.github.com/repos/rbohl/liferay-docs/events","assignees_url":"https://api.github.com/repos/rbohl/liferay-docs/assignees{/user}","branches_url":"https://api.github.com/repos/rbohl/liferay-docs/branches{/branch}","tags_url":"https://api.github.com/repos/rbohl/liferay-docs/tags","blobs_url":"https://api.github.com/repos/rbohl/liferay-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbohl/liferay-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbohl/liferay-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbohl/liferay-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbohl/liferay-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/rbohl/liferay-docs/languages","stargazers_url":"https://api.github.com/repos/rbohl/liferay-docs/stargazers","contributors_url":"https://api.github.com/repos/rbohl/liferay-docs/contributors","subscribers_url":"https://api.github.com/repos/rbohl/liferay-docs/subscribers","subscription_url":"https://api.github.com/repos/rbohl/liferay-docs/subscription","commits_url":"https://api.github.com/repos/rbohl/liferay-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbohl/liferay-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbohl/liferay-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbohl/liferay-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbohl/liferay-docs/contents/{+path}","compare_url":"https://api.github.com/repos/rbohl/liferay-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbohl/liferay-docs/merges","archive_url":"https://api.github.com/repos/rbohl/liferay-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbohl/liferay-docs/downloads","issues_url":"https://api.github.com/repos/rbohl/liferay-docs/issues{/number}","pulls_url":"https://api.github.com/repos/rbohl/liferay-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/rbohl/liferay-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/rbohl/liferay-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbohl/liferay-docs/labels{/name}","releases_url":"https://api.github.com/repos/rbohl/liferay-docs/releases{/id}","deployments_url":"https://api.github.com/repos/rbohl/liferay-docs/deployments","created_at":"2013-01-21T17:42:24Z","updated_at":"2018-10-16T22:34:58Z","pushed_at":"2018-10-18T02:38:23Z","git_url":"git://github.com/rbohl/liferay-docs.git","ssh_url":"git@github.com:rbohl/liferay-docs.git","clone_url":"https://github.com/rbohl/liferay-docs.git","svn_url":"https://github.com/rbohl/liferay-docs","homepage":"","size":771408,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"natocesarrego:master","ref":"master","sha":"651f2b30b7ebaaa7be692fd24f1ac095180082ab","user":{"login":"natocesarrego","id":6729287,"node_id":"MDQ6VXNlcjY3MjkyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/6729287?v=4","gravatar_id":"","url":"https://api.github.com/users/natocesarrego","html_url":"https://github.com/natocesarrego","followers_url":"https://api.github.com/users/natocesarrego/followers","following_url":"https://api.github.com/users/natocesarrego/following{/other_user}","gists_url":"https://api.github.com/users/natocesarrego/gists{/gist_id}","starred_url":"https://api.github.com/users/natocesarrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natocesarrego/subscriptions","organizations_url":"https://api.github.com/users/natocesarrego/orgs","repos_url":"https://api.github.com/users/natocesarrego/repos","events_url":"https://api.github.com/users/natocesarrego/events{/privacy}","received_events_url":"https://api.github.com/users/natocesarrego/received_events","type":"User","site_admin":false},"repo":{"id":87459098,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ1OTA5OA==","name":"liferay-docs","full_name":"natocesarrego/liferay-docs","private":false,"owner":{"login":"natocesarrego","id":6729287,"node_id":"MDQ6VXNlcjY3MjkyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/6729287?v=4","gravatar_id":"","url":"https://api.github.com/users/natocesarrego","html_url":"https://github.com/natocesarrego","followers_url":"https://api.github.com/users/natocesarrego/followers","following_url":"https://api.github.com/users/natocesarrego/following{/other_user}","gists_url":"https://api.github.com/users/natocesarrego/gists{/gist_id}","starred_url":"https://api.github.com/users/natocesarrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natocesarrego/subscriptions","organizations_url":"https://api.github.com/users/natocesarrego/orgs","repos_url":"https://api.github.com/users/natocesarrego/repos","events_url":"https://api.github.com/users/natocesarrego/events{/privacy}","received_events_url":"https://api.github.com/users/natocesarrego/received_events","type":"User","site_admin":false},"html_url":"https://github.com/natocesarrego/liferay-docs","description":null,"fork":true,"url":"https://api.github.com/repos/natocesarrego/liferay-docs","forks_url":"https://api.github.com/repos/natocesarrego/liferay-docs/forks","keys_url":"https://api.github.com/repos/natocesarrego/liferay-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natocesarrego/liferay-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natocesarrego/liferay-docs/teams","hooks_url":"https://api.github.com/repos/natocesarrego/liferay-docs/hooks","issue_events_url":"https://api.github.com/repos/natocesarrego/liferay-docs/issues/events{/number}","events_url":"https://api.github.com/repos/natocesarrego/liferay-docs/events","assignees_url":"https://api.github.com/repos/natocesarrego/liferay-docs/assignees{/user}","branches_url":"https://api.github.com/repos/natocesarrego/liferay-docs/branches{/branch}","tags_url":"https://api.github.com/repos/natocesarrego/liferay-docs/tags","blobs_url":"https://api.github.com/repos/natocesarrego/liferay-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natocesarrego/liferay-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natocesarrego/liferay-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/natocesarrego/liferay-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natocesarrego/liferay-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/natocesarrego/liferay-docs/languages","stargazers_url":"https://api.github.com/repos/natocesarrego/liferay-docs/stargazers","contributors_url":"https://api.github.com/repos/natocesarrego/liferay-docs/contributors","subscribers_url":"https://api.github.com/repos/natocesarrego/liferay-docs/subscribers","subscription_url":"https://api.github.com/repos/natocesarrego/liferay-docs/subscription","commits_url":"https://api.github.com/repos/natocesarrego/liferay-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/natocesarrego/liferay-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/natocesarrego/liferay-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/natocesarrego/liferay-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/natocesarrego/liferay-docs/contents/{+path}","compare_url":"https://api.github.com/repos/natocesarrego/liferay-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natocesarrego/liferay-docs/merges","archive_url":"https://api.github.com/repos/natocesarrego/liferay-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natocesarrego/liferay-docs/downloads","issues_url":"https://api.github.com/repos/natocesarrego/liferay-docs/issues{/number}","pulls_url":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/natocesarrego/liferay-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/natocesarrego/liferay-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natocesarrego/liferay-docs/labels{/name}","releases_url":"https://api.github.com/repos/natocesarrego/liferay-docs/releases{/id}","deployments_url":"https://api.github.com/repos/natocesarrego/liferay-docs/deployments","created_at":"2017-04-06T17:58:24Z","updated_at":"2018-10-16T22:33:54Z","pushed_at":"2018-10-16T22:33:53Z","git_url":"git://github.com/natocesarrego/liferay-docs.git","ssh_url":"git@github.com:natocesarrego/liferay-docs.git","clone_url":"https://github.com/natocesarrego/liferay-docs.git","svn_url":"https://github.com/natocesarrego/liferay-docs","homepage":"","size":771786,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29"},"html":{"href":"https://github.com/natocesarrego/liferay-docs/pull/29"},"issue":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/issues/29"},"comments":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/natocesarrego/liferay-docs/statuses/5ecdeb2d8dac2e4314aa098cb878f280afe81d41"}},"author_association":"NONE"}}
{"actor":{"display_login":"rbohl"}}