{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/20172","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/20172/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/20172/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/20172/events","html_url":"https://github.com/ceph/ceph/pull/20172","id":292544546,"number":20172,"title":"mon: centralized config","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"labels":[{"id":144329561,"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":134774006,"url":"https://api.github.com/repos/ceph/ceph/labels/feature","name":"feature","color":"00ff24","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-01-29T20:13:07Z","updated_at":"2018-02-26T15:30:14Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/20172","html_url":"https://github.com/ceph/ceph/pull/20172","diff_url":"https://github.com/ceph/ceph/pull/20172.diff","patch_url":"https://github.com/ceph/ceph/pull/20172.patch"},"body":"FUTURE TODO (later PR)\r\n- clean up tell|daemon config set output (gross json that makes no sense)\r\n- converge with mgr module config options\r\n- convert ConfigKeyService to a PaxosService (and unify with ConfigMonitor?)\r\n\r\nTODO\r\n- [x] use normal monclient auth for initial config\r\n- [x] incorporate into global_init/common_init infrastructure\r\n- [x] --no-mon-config argument\r\n- [x] ceph config set WHO KEY VALUE\r\n- [x] ceph config get WHO\r\n- [x] ceph config get WHO KEY (includes default value)\r\n- [x] ceph config dump\r\n- [x] ceph config show WHO\r\n- [x] ceph config show-with-defaults WHO\r\n- [x] ceph config show WHO KEY\r\n- [x] ceph config help\r\n- [x] report mgr running config to mgr\r\n- [x] annotate conf-only options (paxos_* maybe?)\r\n- [x] make ConfigMonitor refresh more efficient than reparsing all config\r\n- [x] show config option level in dump, get output\r\n- [x] ceph config assimilate-conf -i old-ceph.conf -o new-ceph.conf\r\n- [x] sort out ceph-conf behavior\r\n- [x] 'option can be changed' in get and/or show (json?) output\r\n- [x] docs\r\n- [x] tests"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/368540713","html_url":"https://github.com/ceph/ceph/pull/20172#issuecomment-368540713","issue_url":"https://api.github.com/repos/ceph/ceph/issues/20172","id":368540713,"user":{"login":"jcsp","id":944640,"avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T15:30:14Z","updated_at":"2018-02-26T15:30:14Z","author_association":"CONTRIBUTOR","body":"We have a lot of Option::FLAG_NO_MON_UPDATE on settings that intuitively should be live-adjustable (things like mon_osd_full_ratio).  I guess this is a plumbing thing, because of monitors not being MonClients to themselves, and we need another pathway to make \"ceph config set...\" work for these settings?\r\n\r\nSettings like admin_socket, erasure_code_dir, plugin_dir, run_dir (i.e. strings without handlers) generate lots of spam (`-1 set_mon_vals failed to set admin_socket =`), including from the CLI itself, if they've been set in the central monitor config."}}
{"actor":{"display_login":"jcsp"}}