{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/bookmarks/issues/503","repository_url":"https://api.github.com/repos/nextcloud/bookmarks","labels_url":"https://api.github.com/repos/nextcloud/bookmarks/issues/503/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/bookmarks/issues/503/comments","events_url":"https://api.github.com/repos/nextcloud/bookmarks/issues/503/events","html_url":"https://github.com/nextcloud/bookmarks/pull/503","id":328708277,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTc2NDUx","number":503,"title":"Allow Sorting","user":{"login":"chiotisn","id":22836597,"node_id":"MDQ6VXNlcjIyODM2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/22836597?v=4","gravatar_id":"","url":"https://api.github.com/users/chiotisn","html_url":"https://github.com/chiotisn","followers_url":"https://api.github.com/users/chiotisn/followers","following_url":"https://api.github.com/users/chiotisn/following{/other_user}","gists_url":"https://api.github.com/users/chiotisn/gists{/gist_id}","starred_url":"https://api.github.com/users/chiotisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiotisn/subscriptions","organizations_url":"https://api.github.com/users/chiotisn/orgs","repos_url":"https://api.github.com/users/chiotisn/repos","events_url":"https://api.github.com/users/chiotisn/events{/privacy}","received_events_url":"https://api.github.com/users/chiotisn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nextcloud/bookmarks/milestones/6","html_url":"https://github.com/nextcloud/bookmarks/milestone/6","labels_url":"https://api.github.com/repos/nextcloud/bookmarks/milestones/6/labels","id":3391854,"node_id":"MDk6TWlsZXN0b25lMzM5MTg1NA==","number":6,"title":"0.12","description":null,"creator":{"login":"blizzz","id":2184312,"node_id":"MDQ6VXNlcjIxODQzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2184312?v=4","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2018-05-31T21:10:10Z","updated_at":"2018-06-08T19:23:41Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-06-02T03:15:52Z","updated_at":"2018-06-10T20:05:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nextcloud/bookmarks/pulls/503","html_url":"https://github.com/nextcloud/bookmarks/pull/503","diff_url":"https://github.com/nextcloud/bookmarks/pull/503.diff","patch_url":"https://github.com/nextcloud/bookmarks/pull/503.patch"},"body":"My work, so far, in sorting functionality (#3). \r\n\r\nIt works, however, I have problem with running the tests with phpunit (I have post my problem at issue #3)\r\nI will also write a test for findBookmarks function in lib/Bookmarks and I will remove all these \"sqlSortColumn\" attributes in the controllers that are not needed anymore.\r\n\r\nWhat do you think? Should I fix/improve/add something?"},"comment":{"url":"https://api.github.com/repos/nextcloud/bookmarks/issues/comments/396078068","html_url":"https://github.com/nextcloud/bookmarks/pull/503#issuecomment-396078068","issue_url":"https://api.github.com/repos/nextcloud/bookmarks/issues/503","id":396078068,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA3ODA2OA==","user":{"login":"chiotisn","id":22836597,"node_id":"MDQ6VXNlcjIyODM2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/22836597?v=4","gravatar_id":"","url":"https://api.github.com/users/chiotisn","html_url":"https://github.com/chiotisn","followers_url":"https://api.github.com/users/chiotisn/followers","following_url":"https://api.github.com/users/chiotisn/following{/other_user}","gists_url":"https://api.github.com/users/chiotisn/gists{/gist_id}","starred_url":"https://api.github.com/users/chiotisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiotisn/subscriptions","organizations_url":"https://api.github.com/users/chiotisn/orgs","repos_url":"https://api.github.com/users/chiotisn/repos","events_url":"https://api.github.com/users/chiotisn/events{/privacy}","received_events_url":"https://api.github.com/users/chiotisn/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T20:05:40Z","updated_at":"2018-06-10T20:05:40Z","author_association":"NONE","body":"@marcelklehr I added \"sortby\" attribute at the endpoint call again. I could fix the problem I have mentioned above (sortby has no value at the first request) by adding a \"sorting\" attribute/flag at the [loadingState](https://github.com/nextcloud/bookmarks/blob/master/js/models/Bookmarks.js#L14) set to false until Settings get sorting value from server. \r\nThis way, fetching will happen only once and there will be a spinner on screen. However, page loading will take one more second to load. I don't think that this solution is necessary, because sorting is implemented completely by the comparator. I just mention it in case the problem with the sortby option and the endpoint is important. "}}
{"actor":{"display_login":"chiotisn"}}