{"action":"created","issue":{"url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/174","repository_url":"https://api.github.com/repos/mattrubin/OneTimePassword","labels_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/174/comments","events_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/174/events","html_url":"https://github.com/mattrubin/OneTimePassword/pull/174","id":316527356,"number":174,"title":"Remove the cross-module Generator initializer, and fix invalid tests","user":{"login":"mattrubin","id":532638,"avatar_url":"https://avatars2.githubusercontent.com/u/532638?v=4","gravatar_id":"","url":"https://api.github.com/users/mattrubin","html_url":"https://github.com/mattrubin","followers_url":"https://api.github.com/users/mattrubin/followers","following_url":"https://api.github.com/users/mattrubin/following{/other_user}","gists_url":"https://api.github.com/users/mattrubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrubin/subscriptions","organizations_url":"https://api.github.com/users/mattrubin/orgs","repos_url":"https://api.github.com/users/mattrubin/repos","events_url":"https://api.github.com/users/mattrubin/events{/privacy}","received_events_url":"https://api.github.com/users/mattrubin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-21T21:34:22Z","updated_at":"2018-04-21T21:46:55Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/mattrubin/OneTimePassword/pulls/174","html_url":"https://github.com/mattrubin/OneTimePassword/pull/174","diff_url":"https://github.com/mattrubin/OneTimePassword/pull/174.diff","patch_url":"https://github.com/mattrubin/OneTimePassword/pull/174.patch"},"body":"Cross-module struct initializers which set properties directly are deprecated in Swift 4.1, and will be an error in Swift 5.\r\n\r\nThe fact that a custom initializer was needed to construct the invalid Generators used by the test is indicative of a design flaw in the tests. If creating an invalid Generator with the library's default API is not possible, then testing such impossible-to-create invalid Generators is unnecessary. It is enough to test that attempts to create these invalid generators will fail."},"comment":{"url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/comments/383333788","html_url":"https://github.com/mattrubin/OneTimePassword/pull/174#issuecomment-383333788","issue_url":"https://api.github.com/repos/mattrubin/OneTimePassword/issues/174","id":383333788,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-04-21T21:46:55Z","updated_at":"2018-04-21T21:46:55Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174?src=pr&el=h1) Report\n> Merging [#174](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174?src=pr&el=desc) into [develop](https://codecov.io/gh/mattrubin/OneTimePassword/commit/859880f6d58dd637a4d18f6c80a12182775306a7?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174/graphs/tree.svg?width=650&height=150&src=pr&token=795UYfPSjV)](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff            @@\n##           develop     #174   +/-   ##\n========================================\n  Coverage    97.19%   97.19%           \n========================================\n  Files            6        6           \n  Lines          392      392           \n========================================\n  Hits           381      381           \n  Misses          11       11\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174?src=pr&el=footer). Last update [859880f...a722b66](https://codecov.io/gh/mattrubin/OneTimePassword/pull/174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}