{"action":"created","comment":{"url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/comments/195518380","pull_request_review_id":128902514,"id":195518380,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTUxODM4MA==","diff_hunk":"@@ -12,3 +12,41 @@ func TestDoesServiceMatchRule(t *testing.T) {\n \t\tassert.False(t, DoesServiceMatchRule(endpoint, \"== ++ abc 1jj +\"))\n \t})\n }\n+\n+func TestMapFunctions(t *testing.T) {\n+\tinterfacemap := map[interface{}]interface{}{\"hello\": \"world\", \"good\": \"bye\"}\n+\tstringmap := map[string]interface{}{\"hello\": \"world\", \"good\": \"bye\"}\n+\tt.Run(\"Get()\", func(t *testing.T) {\n+\t\tvar val interface{}\n+\t\tvar err error\n+\t\t_, err = ruleFunctions[\"Get\"](stringmap, \"hello\")\n+\t\tassert.Error(t, err, \"should error out when wrong map type is used\")\n+\n+\t\t_, err = ruleFunctions[\"Get\"](interfacemap, 3)\n+\t\tassert.Error(t, err, \"should error out when wrong key type is used\")","path":"internal/core/services/rules_test.go","position":15,"original_position":15,"commit_id":"586dee824a88f64cad602d0582f745c42335f51a","original_commit_id":"586dee824a88f64cad602d0582f745c42335f51a","user":{"login":"keitwb","id":614344,"node_id":"MDQ6VXNlcjYxNDM0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/614344?v=4","gravatar_id":"","url":"https://api.github.com/users/keitwb","html_url":"https://github.com/keitwb","followers_url":"https://api.github.com/users/keitwb/followers","following_url":"https://api.github.com/users/keitwb/following{/other_user}","gists_url":"https://api.github.com/users/keitwb/gists{/gist_id}","starred_url":"https://api.github.com/users/keitwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keitwb/subscriptions","organizations_url":"https://api.github.com/users/keitwb/orgs","repos_url":"https://api.github.com/users/keitwb/repos","events_url":"https://api.github.com/users/keitwb/events{/privacy}","received_events_url":"https://api.github.com/users/keitwb/received_events","type":"User","site_admin":false},"body":"This is a separate test case.  You can still share the common fixture data but still use separate `t.Run` invocations to break these down properly.","created_at":"2018-06-14T18:02:50Z","updated_at":"2018-06-14T18:05:05Z","html_url":"https://github.com/signalfx/signalfx-agent/pull/335#discussion_r195518380","pull_request_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/comments/195518380"},"html":{"href":"https://github.com/signalfx/signalfx-agent/pull/335#discussion_r195518380"},"pull_request":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335","id":194938223,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTM4MjIz","html_url":"https://github.com/signalfx/signalfx-agent/pull/335","diff_url":"https://github.com/signalfx/signalfx-agent/pull/335.diff","patch_url":"https://github.com/signalfx/signalfx-agent/pull/335.patch","issue_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/335","number":335,"state":"open","locked":false,"title":"Get func fix","user":{"login":"charliesignalfx","id":18558634,"node_id":"MDQ6VXNlcjE4NTU4NjM0","avatar_url":"https://avatars0.githubusercontent.com/u/18558634?v=4","gravatar_id":"","url":"https://api.github.com/users/charliesignalfx","html_url":"https://github.com/charliesignalfx","followers_url":"https://api.github.com/users/charliesignalfx/followers","following_url":"https://api.github.com/users/charliesignalfx/following{/other_user}","gists_url":"https://api.github.com/users/charliesignalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/charliesignalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliesignalfx/subscriptions","organizations_url":"https://api.github.com/users/charliesignalfx/orgs","repos_url":"https://api.github.com/users/charliesignalfx/repos","events_url":"https://api.github.com/users/charliesignalfx/events{/privacy}","received_events_url":"https://api.github.com/users/charliesignalfx/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-14T15:47:01Z","updated_at":"2018-06-14T18:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73c3fb39f81b94c8e11d5151d72aeef574cb421a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jchengsfx","id":36963516,"node_id":"MDQ6VXNlcjM2OTYzNTE2","avatar_url":"https://avatars2.githubusercontent.com/u/36963516?v=4","gravatar_id":"","url":"https://api.github.com/users/jchengsfx","html_url":"https://github.com/jchengsfx","followers_url":"https://api.github.com/users/jchengsfx/followers","following_url":"https://api.github.com/users/jchengsfx/following{/other_user}","gists_url":"https://api.github.com/users/jchengsfx/gists{/gist_id}","starred_url":"https://api.github.com/users/jchengsfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchengsfx/subscriptions","organizations_url":"https://api.github.com/users/jchengsfx/orgs","repos_url":"https://api.github.com/users/jchengsfx/repos","events_url":"https://api.github.com/users/jchengsfx/events{/privacy}","received_events_url":"https://api.github.com/users/jchengsfx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335/commits","review_comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335/comments","review_comment_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/335/comments","statuses_url":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/586dee824a88f64cad602d0582f745c42335f51a","head":{"label":"signalfx:get-func-fix","ref":"get-func-fix","sha":"586dee824a88f64cad602d0582f745c42335f51a","user":{"login":"signalfx","id":8184587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODQ1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8184587?v=4","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":80042799,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA0Mjc5OQ==","name":"signalfx-agent","full_name":"signalfx/signalfx-agent","owner":{"login":"signalfx","id":8184587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODQ1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8184587?v=4","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-agent","description":"The SignalFx SmartAgent","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-agent","forks_url":"https://api.github.com/repos/signalfx/signalfx-agent/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-agent/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-agent/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-agent/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-agent/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-agent/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-agent/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-agent/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-agent/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-agent/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-agent/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-agent/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-agent/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-agent/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-agent/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-agent/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-agent/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-agent/deployments","created_at":"2017-01-25T18:17:17Z","updated_at":"2018-06-12T20:19:01Z","pushed_at":"2018-06-14T17:54:52Z","git_url":"git://github.com/signalfx/signalfx-agent.git","ssh_url":"git@github.com:signalfx/signalfx-agent.git","clone_url":"https://github.com/signalfx/signalfx-agent.git","svn_url":"https://github.com/signalfx/signalfx-agent","homepage":"https://signalfx.com","size":9255,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"0a878de5bdc22e4fb00bc4e5f270ab150401b30f","user":{"login":"signalfx","id":8184587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODQ1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8184587?v=4","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":80042799,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA0Mjc5OQ==","name":"signalfx-agent","full_name":"signalfx/signalfx-agent","owner":{"login":"signalfx","id":8184587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODQ1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8184587?v=4","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-agent","description":"The SignalFx SmartAgent","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-agent","forks_url":"https://api.github.com/repos/signalfx/signalfx-agent/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-agent/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-agent/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-agent/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-agent/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-agent/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-agent/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-agent/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-agent/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-agent/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-agent/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-agent/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-agent/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-agent/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-agent/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-agent/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-agent/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-agent/deployments","created_at":"2017-01-25T18:17:17Z","updated_at":"2018-06-12T20:19:01Z","pushed_at":"2018-06-14T17:54:52Z","git_url":"git://github.com/signalfx/signalfx-agent.git","ssh_url":"git@github.com:signalfx/signalfx-agent.git","clone_url":"https://github.com/signalfx/signalfx-agent.git","svn_url":"https://github.com/signalfx/signalfx-agent","homepage":"https://signalfx.com","size":9255,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335"},"html":{"href":"https://github.com/signalfx/signalfx-agent/pull/335"},"issue":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/issues/335"},"comments":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/586dee824a88f64cad602d0582f745c42335f51a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"keitwb"}}