{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/21181","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/21181/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21181/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/21181/events","html_url":"https://github.com/nodejs/node/issues/21181","id":330065157,"node_id":"MDU6SXNzdWUzMzAwNjUxNTc=","number":21181,"title":"v8.deserialize triggers Buffer constructor deprecation warning","user":{"login":"Conduitry","id":16696352,"node_id":"MDQ6VXNlcjE2Njk2MzUy","avatar_url":"https://avatars1.githubusercontent.com/u/16696352?v=4","gravatar_id":"","url":"https://api.github.com/users/Conduitry","html_url":"https://github.com/Conduitry","followers_url":"https://api.github.com/users/Conduitry/followers","following_url":"https://api.github.com/users/Conduitry/following{/other_user}","gists_url":"https://api.github.com/users/Conduitry/gists{/gist_id}","starred_url":"https://api.github.com/users/Conduitry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conduitry/subscriptions","organizations_url":"https://api.github.com/users/Conduitry/orgs","repos_url":"https://api.github.com/users/Conduitry/repos","events_url":"https://api.github.com/users/Conduitry/events{/privacy}","received_events_url":"https://api.github.com/users/Conduitry/received_events","type":"User","site_admin":false},"labels":[{"id":176191361,"node_id":"MDU6TGFiZWwxNzYxOTEzNjE=","url":"https://api.github.com/repos/nodejs/node/labels/V8%20Engine","name":"V8 Engine","color":"0052cc","default":false},{"id":155267414,"node_id":"MDU6TGFiZWwxNTUyNjc0MTQ=","url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7","default":false},{"id":151728674,"node_id":"MDU6TGFiZWwxNTE3Mjg2NzQ=","url":"https://api.github.com/repos/nodejs/node/labels/confirmed-bug","name":"confirmed-bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-06T23:18:00Z","updated_at":"2018-06-07T10:52:29Z","closed_at":null,"author_association":"NONE","body":"* **Version**: Observed on 10.4.0, presumably occurs on all 10+\r\n* **Platform**: All\r\n\r\nDeserializing a representation of an expression that contained a `Buffer` displays`(node:15176) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.`\r\n\r\nReproduce with`v8.deserialize(v8.serialize(Buffer.alloc(0)))`.\r\n\r\nIt looks like `DefaultDeserializer ._readHostObject()` needs a special case for buffers."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/395378525","html_url":"https://github.com/nodejs/node/issues/21181#issuecomment-395378525","issue_url":"https://api.github.com/repos/nodejs/node/issues/21181","id":395378525,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTM3ODUyNQ==","user":{"login":"ryzokuken","id":13121330,"node_id":"MDQ6VXNlcjEzMTIxMzMw","avatar_url":"https://avatars3.githubusercontent.com/u/13121330?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzokuken","html_url":"https://github.com/ryzokuken","followers_url":"https://api.github.com/users/ryzokuken/followers","following_url":"https://api.github.com/users/ryzokuken/following{/other_user}","gists_url":"https://api.github.com/users/ryzokuken/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzokuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzokuken/subscriptions","organizations_url":"https://api.github.com/users/ryzokuken/orgs","repos_url":"https://api.github.com/users/ryzokuken/repos","events_url":"https://api.github.com/users/ryzokuken/events{/privacy}","received_events_url":"https://api.github.com/users/ryzokuken/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T10:52:29Z","updated_at":"2018-06-07T10:52:29Z","author_association":"MEMBER","body":"@Conduitry line to be blamed for this: https://github.com/nodejs/node/blob/c9d9bf1cb06a9f490669b107a28eb9c628aeeb23/lib/v8.js#L189\r\n\r\n/cc @nodejs/buffer @ChALkeR do we break character and hide the warning? I hope not. There's got to be a way to achieve the same functionality without using the `Buffer` constructor."}}
{"actor":{"display_login":"ryzokuken"}}