{"action":"closed","number":2563,"pull_request":{"url":"https://api.github.com/repos/haraka/Haraka/pulls/2563","id":237976400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTc2NDAw","html_url":"https://github.com/haraka/Haraka/pull/2563","diff_url":"https://github.com/haraka/Haraka/pull/2563.diff","patch_url":"https://github.com/haraka/Haraka/pull/2563.patch","issue_url":"https://api.github.com/repos/haraka/Haraka/issues/2563","number":2563,"state":"closed","locked":false,"title":"handle arrays in .ini files","user":{"login":"sloatjustin","id":45811513,"node_id":"MDQ6VXNlcjQ1ODExNTEz","avatar_url":"https://avatars2.githubusercontent.com/u/45811513?v=4","gravatar_id":"","url":"https://api.github.com/users/sloatjustin","html_url":"https://github.com/sloatjustin","followers_url":"https://api.github.com/users/sloatjustin/followers","following_url":"https://api.github.com/users/sloatjustin/following{/other_user}","gists_url":"https://api.github.com/users/sloatjustin/gists{/gist_id}","starred_url":"https://api.github.com/users/sloatjustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloatjustin/subscriptions","organizations_url":"https://api.github.com/users/sloatjustin/orgs","repos_url":"https://api.github.com/users/sloatjustin/repos","events_url":"https://api.github.com/users/sloatjustin/events{/privacy}","received_events_url":"https://api.github.com/users/sloatjustin/received_events","type":"User","site_admin":false},"body":"msimerson commented in a pull request https://github.com/haraka/Haraka/pull/1333#issuecomment-184313920\r\n\r\n    One thing that might be worth changing is the way the host pool is\r\n    configured. A method that already has widespread use is to specify an array\r\n    for the host value instead of a string. This would necessitate extending our\r\n    ini parser to recognize the array syntax.\r\n\r\nThe syntax looks like this. There is no \"official\" .ini syntax for arrays, but\r\nthis seems to be common.\r\n\r\n    hosts[] = first_host\r\n    hosts[] = second_host\r\n    hosts[] = third_host\r\n\r\nThis squashed merge from the feature branch also includes\r\n\r\ncommit e778a5420b4703c2679a291974c334e2daa021bc\r\nAuthor: Kevin M. Goess <kgoess@craigslist.org>\r\nDate:   Thu Feb 18 09:28:25 2016 -0800\r\n\r\n    whitespace fix for eslint\r\n\r\ncommit 669b0d94ac39dd31612493505516ca38eebe63f0\r\nAuthor: Kevin M. Goess <kgoess@craigslist.org>\r\nDate:   Thu Feb 18 09:21:50 2016 -0800\r\n\r\n    fix test for .ini arrays\r\n\r\n    hand-applying msimerson's 86e69a316cd\r\n\r\nFixes #\r\n\r\nChanges proposed in this pull request:\r\n- \r\n- \r\n\r\nChecklist:\r\n- [ ] docs updated\r\n- [ ] tests updated\r\n- [ ] [Changes](https://github.com/haraka/Haraka/blob/master/Changes.md) updated\r\n","created_at":"2018-12-12T10:01:47Z","updated_at":"2018-12-12T18:04:51Z","closed_at":"2018-12-12T18:04:50Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haraka/Haraka/pulls/2563/commits","review_comments_url":"https://api.github.com/repos/haraka/Haraka/pulls/2563/comments","review_comment_url":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haraka/Haraka/issues/2563/comments","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/2071925a4e9269ca0f88722d41f9e580611945e9","head":{"label":"craigslist:master","ref":"master","sha":"2071925a4e9269ca0f88722d41f9e580611945e9","user":{"login":"craigslist","id":155336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTMzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/155336?v=4","gravatar_id":"","url":"https://api.github.com/users/craigslist","html_url":"https://github.com/craigslist","followers_url":"https://api.github.com/users/craigslist/followers","following_url":"https://api.github.com/users/craigslist/following{/other_user}","gists_url":"https://api.github.com/users/craigslist/gists{/gist_id}","starred_url":"https://api.github.com/users/craigslist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigslist/subscriptions","organizations_url":"https://api.github.com/users/craigslist/orgs","repos_url":"https://api.github.com/users/craigslist/repos","events_url":"https://api.github.com/users/craigslist/events{/privacy}","received_events_url":"https://api.github.com/users/craigslist/received_events","type":"Organization","site_admin":false},"repo":{"id":51097454,"node_id":"MDEwOlJlcG9zaXRvcnk1MTA5NzQ1NA==","name":"Haraka","full_name":"craigslist/Haraka","private":false,"owner":{"login":"craigslist","id":155336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTMzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/155336?v=4","gravatar_id":"","url":"https://api.github.com/users/craigslist","html_url":"https://github.com/craigslist","followers_url":"https://api.github.com/users/craigslist/followers","following_url":"https://api.github.com/users/craigslist/following{/other_user}","gists_url":"https://api.github.com/users/craigslist/gists{/gist_id}","starred_url":"https://api.github.com/users/craigslist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigslist/subscriptions","organizations_url":"https://api.github.com/users/craigslist/orgs","repos_url":"https://api.github.com/users/craigslist/repos","events_url":"https://api.github.com/users/craigslist/events{/privacy}","received_events_url":"https://api.github.com/users/craigslist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/craigslist/Haraka","description":"An event driven SMTP server","fork":true,"url":"https://api.github.com/repos/craigslist/Haraka","forks_url":"https://api.github.com/repos/craigslist/Haraka/forks","keys_url":"https://api.github.com/repos/craigslist/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craigslist/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craigslist/Haraka/teams","hooks_url":"https://api.github.com/repos/craigslist/Haraka/hooks","issue_events_url":"https://api.github.com/repos/craigslist/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/craigslist/Haraka/events","assignees_url":"https://api.github.com/repos/craigslist/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/craigslist/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/craigslist/Haraka/tags","blobs_url":"https://api.github.com/repos/craigslist/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craigslist/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craigslist/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/craigslist/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craigslist/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/craigslist/Haraka/languages","stargazers_url":"https://api.github.com/repos/craigslist/Haraka/stargazers","contributors_url":"https://api.github.com/repos/craigslist/Haraka/contributors","subscribers_url":"https://api.github.com/repos/craigslist/Haraka/subscribers","subscription_url":"https://api.github.com/repos/craigslist/Haraka/subscription","commits_url":"https://api.github.com/repos/craigslist/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/craigslist/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/craigslist/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/craigslist/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/craigslist/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/craigslist/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craigslist/Haraka/merges","archive_url":"https://api.github.com/repos/craigslist/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craigslist/Haraka/downloads","issues_url":"https://api.github.com/repos/craigslist/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/craigslist/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/craigslist/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/craigslist/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craigslist/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/craigslist/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/craigslist/Haraka/deployments","created_at":"2016-02-04T18:52:12Z","updated_at":"2018-10-28T02:41:31Z","pushed_at":"2017-03-30T22:44:06Z","git_url":"git://github.com/craigslist/Haraka.git","ssh_url":"git@github.com:craigslist/Haraka.git","clone_url":"https://github.com/craigslist/Haraka.git","svn_url":"https://github.com/craigslist/Haraka","homepage":"http://haraka.github.io/","size":5013,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"haraka:master","ref":"master","sha":"de29e32e09862a2c4e81e90ad9067c555f57a92f","user":{"login":"haraka","id":1111229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTEyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1111229?v=4","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"repo":{"id":1464380,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0Mzgw","name":"Haraka","full_name":"haraka/Haraka","private":false,"owner":{"login":"haraka","id":1111229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTEyMjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1111229?v=4","gravatar_id":"","url":"https://api.github.com/users/haraka","html_url":"https://github.com/haraka","followers_url":"https://api.github.com/users/haraka/followers","following_url":"https://api.github.com/users/haraka/following{/other_user}","gists_url":"https://api.github.com/users/haraka/gists{/gist_id}","starred_url":"https://api.github.com/users/haraka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haraka/subscriptions","organizations_url":"https://api.github.com/users/haraka/orgs","repos_url":"https://api.github.com/users/haraka/repos","events_url":"https://api.github.com/users/haraka/events{/privacy}","received_events_url":"https://api.github.com/users/haraka/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/haraka/Haraka","description":"A fast, highly extensible, and event driven SMTP server","fork":false,"url":"https://api.github.com/repos/haraka/Haraka","forks_url":"https://api.github.com/repos/haraka/Haraka/forks","keys_url":"https://api.github.com/repos/haraka/Haraka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haraka/Haraka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haraka/Haraka/teams","hooks_url":"https://api.github.com/repos/haraka/Haraka/hooks","issue_events_url":"https://api.github.com/repos/haraka/Haraka/issues/events{/number}","events_url":"https://api.github.com/repos/haraka/Haraka/events","assignees_url":"https://api.github.com/repos/haraka/Haraka/assignees{/user}","branches_url":"https://api.github.com/repos/haraka/Haraka/branches{/branch}","tags_url":"https://api.github.com/repos/haraka/Haraka/tags","blobs_url":"https://api.github.com/repos/haraka/Haraka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haraka/Haraka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haraka/Haraka/git/refs{/sha}","trees_url":"https://api.github.com/repos/haraka/Haraka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haraka/Haraka/statuses/{sha}","languages_url":"https://api.github.com/repos/haraka/Haraka/languages","stargazers_url":"https://api.github.com/repos/haraka/Haraka/stargazers","contributors_url":"https://api.github.com/repos/haraka/Haraka/contributors","subscribers_url":"https://api.github.com/repos/haraka/Haraka/subscribers","subscription_url":"https://api.github.com/repos/haraka/Haraka/subscription","commits_url":"https://api.github.com/repos/haraka/Haraka/commits{/sha}","git_commits_url":"https://api.github.com/repos/haraka/Haraka/git/commits{/sha}","comments_url":"https://api.github.com/repos/haraka/Haraka/comments{/number}","issue_comment_url":"https://api.github.com/repos/haraka/Haraka/issues/comments{/number}","contents_url":"https://api.github.com/repos/haraka/Haraka/contents/{+path}","compare_url":"https://api.github.com/repos/haraka/Haraka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haraka/Haraka/merges","archive_url":"https://api.github.com/repos/haraka/Haraka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haraka/Haraka/downloads","issues_url":"https://api.github.com/repos/haraka/Haraka/issues{/number}","pulls_url":"https://api.github.com/repos/haraka/Haraka/pulls{/number}","milestones_url":"https://api.github.com/repos/haraka/Haraka/milestones{/number}","notifications_url":"https://api.github.com/repos/haraka/Haraka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haraka/Haraka/labels{/name}","releases_url":"https://api.github.com/repos/haraka/Haraka/releases{/id}","deployments_url":"https://api.github.com/repos/haraka/Haraka/deployments","created_at":"2011-03-10T17:00:20Z","updated_at":"2018-12-12T14:40:00Z","pushed_at":"2018-12-12T10:01:48Z","git_url":"git://github.com/haraka/Haraka.git","ssh_url":"git@github.com:haraka/Haraka.git","clone_url":"https://github.com/haraka/Haraka.git","svn_url":"https://github.com/haraka/Haraka","homepage":"https://haraka.github.io","size":7877,"stargazers_count":3101,"watchers_count":3101,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":510,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":510,"open_issues":29,"watchers":3101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/2563"},"html":{"href":"https://github.com/haraka/Haraka/pull/2563"},"issue":{"href":"https://api.github.com/repos/haraka/Haraka/issues/2563"},"comments":{"href":"https://api.github.com/repos/haraka/Haraka/issues/2563/comments"},"review_comments":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/2563/comments"},"review_comment":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haraka/Haraka/pulls/2563/commits"},"statuses":{"href":"https://api.github.com/repos/haraka/Haraka/statuses/2071925a4e9269ca0f88722d41f9e580611945e9"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":39,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"msimerson"}}