{"action":"closed","issue":{"url":"https://api.github.com/repos/HyperionGray/trio-websocket/issues/4","repository_url":"https://api.github.com/repos/HyperionGray/trio-websocket","labels_url":"https://api.github.com/repos/HyperionGray/trio-websocket/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/HyperionGray/trio-websocket/issues/4/comments","events_url":"https://api.github.com/repos/HyperionGray/trio-websocket/issues/4/events","html_url":"https://github.com/HyperionGray/trio-websocket/issues/4","id":355781785,"node_id":"MDU6SXNzdWUzNTU3ODE3ODU=","number":4,"title":"Allow more control over the handshake?","user":{"login":"njsmith","id":609896,"node_id":"MDQ6VXNlcjYwOTg5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/609896?v=4","gravatar_id":"","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following{/other_user}","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mehaase","id":320904,"node_id":"MDQ6VXNlcjMyMDkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/320904?v=4","gravatar_id":"","url":"https://api.github.com/users/mehaase","html_url":"https://github.com/mehaase","followers_url":"https://api.github.com/users/mehaase/followers","following_url":"https://api.github.com/users/mehaase/following{/other_user}","gists_url":"https://api.github.com/users/mehaase/gists{/gist_id}","starred_url":"https://api.github.com/users/mehaase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehaase/subscriptions","organizations_url":"https://api.github.com/users/mehaase/orgs","repos_url":"https://api.github.com/users/mehaase/repos","events_url":"https://api.github.com/users/mehaase/events{/privacy}","received_events_url":"https://api.github.com/users/mehaase/received_events","type":"User","site_admin":false},"assignees":[{"login":"mehaase","id":320904,"node_id":"MDQ6VXNlcjMyMDkwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/320904?v=4","gravatar_id":"","url":"https://api.github.com/users/mehaase","html_url":"https://github.com/mehaase","followers_url":"https://api.github.com/users/mehaase/followers","following_url":"https://api.github.com/users/mehaase/following{/other_user}","gists_url":"https://api.github.com/users/mehaase/gists{/gist_id}","starred_url":"https://api.github.com/users/mehaase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehaase/subscriptions","organizations_url":"https://api.github.com/users/mehaase/orgs","repos_url":"https://api.github.com/users/mehaase/repos","events_url":"https://api.github.com/users/mehaase/events{/privacy}","received_events_url":"https://api.github.com/users/mehaase/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-30T22:52:42Z","updated_at":"2018-10-23T19:38:50Z","closed_at":"2018-10-23T19:38:50Z","author_association":"COLLABORATOR","body":"The websocket protocol allows some options during the handshake that currently aren't exposed:\r\n\r\n* The client can propose a list of possible \"subprotocols\"\r\n\r\n* The client can send arbitrary HTTP headers (e.g., authorization headers)\r\n\r\n* The server can see the list of possible subprotocols and headers\r\n\r\n* The server can pick a subprotocol to use\r\n\r\n* The server can include arbitrary headers when accepting the connection\r\n\r\n* The server can reject the connection with some kind of HTTP 4xx response, including headers and body\r\n\r\nNot all of these are actually exposed through wsproto currently (e.g. see https://github.com/python-hyper/wsproto/issues/61), but it would be good to at least leave the door open to supporting them later. In particular, I'm a bit nervous about the server API, since it does the handshake automatically before the user's handler has a chance to do anything."}}
{"actor":{"display_login":"mehaase"}}