{"action":"created","issue":{"url":"https://api.github.com/repos/coredns/coredns/issues/1829","repository_url":"https://api.github.com/repos/coredns/coredns","labels_url":"https://api.github.com/repos/coredns/coredns/issues/1829/labels{/name}","comments_url":"https://api.github.com/repos/coredns/coredns/issues/1829/comments","events_url":"https://api.github.com/repos/coredns/coredns/issues/1829/events","html_url":"https://github.com/coredns/coredns/pull/1829","id":325606369,"number":1829,"title":"Revert pkg/nonwriter changes","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-23T08:44:40Z","updated_at":"2018-05-23T08:44:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coredns/coredns/pulls/1829","html_url":"https://github.com/coredns/coredns/pull/1829","diff_url":"https://github.com/coredns/coredns/pull/1829.diff","patch_url":"https://github.com/coredns/coredns/pull/1829.patch"},"body":"The DoH work (#1619) made changes to pkg/nonwriter.Writer that in\r\nhindsight were not backwards compatible; it added override for the\r\nLocalAddr() and RemoteAddr(). Instead of rolling back that PR, this PR\r\nreverts those changes and creates a DoHWriter for use in the\r\nhttps-server.go side of things.\r\n\r\nThis was only caught in the integration test making this hard to catch,\r\nso we add a upstream_file_test.go that tries (doesn't work yet) to test\r\nthis in the unit tests as well. Esp. helpful when 'git bisecting'.\r\n\r\nFixes #1826"},"comment":{"url":"https://api.github.com/repos/coredns/coredns/issues/comments/391269490","html_url":"https://github.com/coredns/coredns/pull/1829#issuecomment-391269490","issue_url":"https://api.github.com/repos/coredns/coredns/issues/1829","id":391269490,"user":{"login":"corbot[bot]","id":39114087,"avatar_url":"https://avatars3.githubusercontent.com/u/21110084?v=4","gravatar_id":"","url":"https://api.github.com/users/corbot%5Bbot%5D","html_url":"https://github.com/apps/corbot","followers_url":"https://api.github.com/users/corbot%5Bbot%5D/followers","following_url":"https://api.github.com/users/corbot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/corbot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/corbot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corbot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/corbot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/corbot%5Bbot%5D/repos","events_url":"https://api.github.com/users/corbot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/corbot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-05-23T08:44:44Z","updated_at":"2018-05-23T08:44:44Z","author_association":"NONE","body":"Thank you for your contribution. I've just checked the *OWNERS* files to find a suitable reviewer. This search was successful and I've asked **superq** (via `/OWNERS`) for a review."}}
{"actor":{"display_login":"corbot"}}