{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/233536860","pull_request_review_id":174974381,"id":233536860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzUzNjg2MA==","diff_hunk":"@@ -0,0 +1,44 @@\n+// Package overlayutils provides utility functions for overlay networks\n+package overlayutils\n+\n+import (\n+\t\"fmt\"\n+\t\"sync\"\n+)\n+\n+var (\n+\tvxlanUDPPort uint32\n+\tmutex        sync.Mutex\n+)\n+\n+func init() {\n+\tvxlanUDPPort = 4789\n+}\n+\n+// ConfigVxlanUDPPort configures vxlan udp port number.\n+func ConfigVxlanUDPPort(vxlanPort uint32) error {\n+\tmutex.Lock()\n+\tdefer mutex.Unlock()\n+\t// if the value comes as 0 by any reason we set it to default value 4789\n+\tif vxlanPort == 0 {\n+\t\tvxlanPort = 4789\n+\t}\n+\t// IANA procedures for each range in detail\n+\t// The Well Known Ports, aka the System Ports, from 0-1023\n+\t// The Registered Ports, aka the User Ports, from 1024-49151\n+\t// The Dynamic Ports, aka the Private Ports, from 49152-65535\n+\t// So we can allow range between 1024 to 49151\n+\tif vxlanPort < 1024 || vxlanPort > 49151 {\n+\t\treturn fmt.Errorf(\"ConfigVxlanUDPPort Vxlan UDP port number is not in valid range %d\", vxlanPort)\n+\t}\n+\tvxlanUDPPort = vxlanPort\n+\n+\treturn nil\n+}\n+\n+// GetVxlanUDPPort returns Vxlan UDP port number\n+func GetVxlanUDPPort() uint32 {","path":"vendor/github.com/docker/libnetwork/drivers/overlay/overlayutils/utils.go","position":40,"original_position":40,"commit_id":"fb0f901b3d664d98ecb448b1f17e036d1886a4b7","original_commit_id":"cde1092288dfaf9d48e019c7740fe8a0271a3b03","user":{"login":"thaJeztah","id":1804568,"node_id":"MDQ6VXNlcjE4MDQ1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"It's not a blocker for me; my eye just fell on this one","created_at":"2018-11-14T17:06:13Z","updated_at":"2018-11-14T17:06:13Z","html_url":"https://github.com/moby/moby/pull/38102#discussion_r233536860","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/38102","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/233536860"},"html":{"href":"https://github.com/moby/moby/pull/38102#discussion_r233536860"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/38102"}},"in_reply_to_id":233018788},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/38102","id":226730805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzMwODA1","html_url":"https://github.com/moby/moby/pull/38102","diff_url":"https://github.com/moby/moby/pull/38102.diff","patch_url":"https://github.com/moby/moby/pull/38102.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/38102","number":38102,"state":"open","locked":false,"title":"VXLAN UDP Port configuration support","user":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"body":"    This PR chnages allow user to configure VxLAN UDP\r\n    port number. By default we use 4789 port number. But this commit\r\n    will allow user to configure port number during swarm init.\r\n    VxLAN port can't be modified after swarm init.\r\n\r\nSigned-off-by: selansen <elango.siva@docker.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n","created_at":"2018-10-29T22:12:17Z","updated_at":"2018-11-14T17:06:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfa76382fd4f95ad64a8a82fa770dff26696f0d2","assignee":{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"assignees":[{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":237472034,"node_id":"MDU6TGFiZWwyMzc0NzIwMzQ=","url":"https://api.github.com/repos/moby/moby/labels/area/networking","name":"area/networking","color":"fbca04","default":false},{"id":392678049,"node_id":"MDU6TGFiZWwzOTI2NzgwNDk=","url":"https://api.github.com/repos/moby/moby/labels/area/swarm","name":"area/swarm","color":"fbca04","default":false},{"id":237472255,"node_id":"MDU6TGFiZWwyMzc0NzIyNTU=","url":"https://api.github.com/repos/moby/moby/labels/impact/api","name":"impact/api","color":"bfe5bf","default":false},{"id":237472270,"node_id":"MDU6TGFiZWwyMzc0NzIyNzA=","url":"https://api.github.com/repos/moby/moby/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf","default":false},{"id":450032382,"node_id":"MDU6TGFiZWw0NTAwMzIzODI=","url":"https://api.github.com/repos/moby/moby/labels/impact/documentation","name":"impact/documentation","color":"bfe5bf","default":false},{"id":175375318,"node_id":"MDU6TGFiZWwxNzUzNzUzMTg=","url":"https://api.github.com/repos/moby/moby/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/38102/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/38102/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/38102/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/fb0f901b3d664d98ecb448b1f17e036d1886a4b7","head":{"label":"selansen:master","ref":"master","sha":"fb0f901b3d664d98ecb448b1f17e036d1886a4b7","user":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"repo":{"id":112528409,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1Mjg0MDk=","name":"moby","full_name":"selansen/moby","private":false,"owner":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/selansen/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/selansen/moby","forks_url":"https://api.github.com/repos/selansen/moby/forks","keys_url":"https://api.github.com/repos/selansen/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selansen/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selansen/moby/teams","hooks_url":"https://api.github.com/repos/selansen/moby/hooks","issue_events_url":"https://api.github.com/repos/selansen/moby/issues/events{/number}","events_url":"https://api.github.com/repos/selansen/moby/events","assignees_url":"https://api.github.com/repos/selansen/moby/assignees{/user}","branches_url":"https://api.github.com/repos/selansen/moby/branches{/branch}","tags_url":"https://api.github.com/repos/selansen/moby/tags","blobs_url":"https://api.github.com/repos/selansen/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selansen/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selansen/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/selansen/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selansen/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/selansen/moby/languages","stargazers_url":"https://api.github.com/repos/selansen/moby/stargazers","contributors_url":"https://api.github.com/repos/selansen/moby/contributors","subscribers_url":"https://api.github.com/repos/selansen/moby/subscribers","subscription_url":"https://api.github.com/repos/selansen/moby/subscription","commits_url":"https://api.github.com/repos/selansen/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/selansen/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/selansen/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/selansen/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/selansen/moby/contents/{+path}","compare_url":"https://api.github.com/repos/selansen/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selansen/moby/merges","archive_url":"https://api.github.com/repos/selansen/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selansen/moby/downloads","issues_url":"https://api.github.com/repos/selansen/moby/issues{/number}","pulls_url":"https://api.github.com/repos/selansen/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/selansen/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/selansen/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selansen/moby/labels{/name}","releases_url":"https://api.github.com/repos/selansen/moby/releases{/id}","deployments_url":"https://api.github.com/repos/selansen/moby/deployments","created_at":"2017-11-29T21:13:12Z","updated_at":"2018-11-13T23:36:38Z","pushed_at":"2018-11-13T23:36:13Z","git_url":"git://github.com/selansen/moby.git","ssh_url":"git@github.com:selansen/moby.git","clone_url":"https://github.com/selansen/moby.git","svn_url":"https://github.com/selansen/moby","homepage":"https://mobyproject.org/","size":139795,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"758255791e25767aeeb5b2509e2d54f9ec91b242","user":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"node_id":"MDEwOlJlcG9zaXRvcnk3NjkxNjMx","name":"moby","full_name":"moby/moby","private":false,"owner":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-11-14T15:54:18Z","pushed_at":"2018-11-14T16:59:09Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":139780,"stargazers_count":51061,"watchers_count":51061,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14858,"mirror_url":null,"archived":false,"open_issues_count":3470,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14858,"open_issues":3470,"watchers":51061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/38102"},"html":{"href":"https://github.com/moby/moby/pull/38102"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/38102"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/38102/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/38102/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/38102/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/fb0f901b3d664d98ecb448b1f17e036d1886a4b7"}},"author_association":"NONE"}}
{"actor":{"display_login":"thaJeztah"}}