{"action":"created","issue":{"url":"https://api.github.com/repos/git-lfs/git-lfs/issues/3291","repository_url":"https://api.github.com/repos/git-lfs/git-lfs","labels_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/3291/labels{/name}","comments_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/3291/comments","events_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/3291/events","html_url":"https://github.com/git-lfs/git-lfs/issues/3291","id":364724995,"node_id":"MDU6SXNzdWUzNjQ3MjQ5OTU=","number":3291,"title":"Strip developer prefix from shipped binaries","user":{"login":"ttaylorr","id":443245,"node_id":"MDQ6VXNlcjQ0MzI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/443245?v=4","gravatar_id":"","url":"https://api.github.com/users/ttaylorr","html_url":"https://github.com/ttaylorr","followers_url":"https://api.github.com/users/ttaylorr/followers","following_url":"https://api.github.com/users/ttaylorr/following{/other_user}","gists_url":"https://api.github.com/users/ttaylorr/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaylorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaylorr/subscriptions","organizations_url":"https://api.github.com/users/ttaylorr/orgs","repos_url":"https://api.github.com/users/ttaylorr/repos","events_url":"https://api.github.com/users/ttaylorr/events{/privacy}","received_events_url":"https://api.github.com/users/ttaylorr/received_events","type":"User","site_admin":true},"labels":[{"id":57558054,"node_id":"MDU6TGFiZWw1NzU1ODA1NA==","url":"https://api.github.com/repos/git-lfs/git-lfs/labels/bug","name":"bug","color":"fc2929","default":true},{"id":481567637,"node_id":"MDU6TGFiZWw0ODE1Njc2Mzc=","url":"https://api.github.com/repos/git-lfs/git-lfs/labels/proposal","name":"proposal","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-28T03:08:53Z","updated_at":"2018-09-28T22:28:05Z","closed_at":null,"author_association":"MEMBER","body":"We get many issues that contain a stack trace with many `/Users/ttaylorr/github/git-lfs`'s scattered throughout. This is the result of Go's default behavior to build into the binary the source locations of all `*.go` files that we compile.\r\n\r\nLet's use the `-trimprefix` gc and asm flag (via `-gcflags` and `-asmflags`, respectively) to remove this prefix so that when we run `make bin/git-lfs{,.exe}` we have stack traces that don't contain these.\r\n\r\nI tried to write this patch myself, but was confused why it didn't work, so I'm making a note of it here in the hopes that someone on @git-lfs/core will have a better idea than I. I think that we may have to patch Go upstream to ignore multiple paths, since we have both our non-GOPATH source checkout location, and the modules cache, both of which should be ignored.\r\n\r\nLet me know what you think is a sensible behavior.\r\n\r\n##\r\n\r\n/cc @git-lfs/core  "},"comment":{"url":"https://api.github.com/repos/git-lfs/git-lfs/issues/comments/425583392","html_url":"https://github.com/git-lfs/git-lfs/issues/3291#issuecomment-425583392","issue_url":"https://api.github.com/repos/git-lfs/git-lfs/issues/3291","id":425583392,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTU4MzM5Mg==","user":{"login":"ttaylorr","id":443245,"node_id":"MDQ6VXNlcjQ0MzI0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/443245?v=4","gravatar_id":"","url":"https://api.github.com/users/ttaylorr","html_url":"https://github.com/ttaylorr","followers_url":"https://api.github.com/users/ttaylorr/followers","following_url":"https://api.github.com/users/ttaylorr/following{/other_user}","gists_url":"https://api.github.com/users/ttaylorr/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaylorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaylorr/subscriptions","organizations_url":"https://api.github.com/users/ttaylorr/orgs","repos_url":"https://api.github.com/users/ttaylorr/repos","events_url":"https://api.github.com/users/ttaylorr/events{/privacy}","received_events_url":"https://api.github.com/users/ttaylorr/received_events","type":"User","site_admin":true},"created_at":"2018-09-28T22:28:05Z","updated_at":"2018-09-28T22:28:05Z","author_association":"MEMBER","body":"It looks like it is this [1] that would need to change in order to grow\nsupport for ':'-separated path prefixes.\n\n[1]: https://github.com/golang/go/blob/go1.11/src/cmd/internal/objabi/line.go#L57\n"}}
{"actor":{"display_login":"ttaylorr"}}