{"action":"created","comment":{"url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/comments/190792562","pull_request_review_id":123246021,"id":190792562,"diff_hunk":"@@ -35,12 +48,12 @@ output \"security_group_ids\" {\n \n output \"role\" {\n   description = \"Name of AWS IAM Role associated with creating instance\"\n-  value       = \"${join(\"\", aws_iam_role.default.*.name)}\"\n+  value       = \"${join(\",\", aws_iam_role.default.*.name)}\"\n }\n \n output \"alarm\" {\n   description = \"CloudWatch Alarm ID\"\n-  value       = \"${join(\"\", aws_cloudwatch_metric_alarm.default.*.id)}\"\n+  value       = \"${join(\",\", aws_cloudwatch_metric_alarm.default.*.id)}\"","path":"outputs.tf","position":68,"original_position":64,"commit_id":"19704dde9b12b17440fbe1deb2bad6ce94eeec3d","original_commit_id":"314f4e4041190300af6fb076c61824ec7777e669","user":{"login":"osterman","id":52489,"avatar_url":"https://avatars3.githubusercontent.com/u/52489?v=4","gravatar_id":"","url":"https://api.github.com/users/osterman","html_url":"https://github.com/osterman","followers_url":"https://api.github.com/users/osterman/followers","following_url":"https://api.github.com/users/osterman/following{/other_user}","gists_url":"https://api.github.com/users/osterman/gists{/gist_id}","starred_url":"https://api.github.com/users/osterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osterman/subscriptions","organizations_url":"https://api.github.com/users/osterman/orgs","repos_url":"https://api.github.com/users/osterman/repos","events_url":"https://api.github.com/users/osterman/events{/privacy}","received_events_url":"https://api.github.com/users/osterman/received_events","type":"User","site_admin":false},"body":"We cannot use an empty string or all the IDs will be squashed together if `count > 1`","created_at":"2018-05-25T05:12:02Z","updated_at":"2018-05-25T05:12:02Z","html_url":"https://github.com/cloudposse/terraform-aws-ec2-instance/pull/28#discussion_r190792562","pull_request_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/comments/190792562"},"html":{"href":"https://github.com/cloudposse/terraform-aws-ec2-instance/pull/28#discussion_r190792562"},"pull_request":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28"}},"in_reply_to_id":189777940},"pull_request":{"url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28","id":188293802,"html_url":"https://github.com/cloudposse/terraform-aws-ec2-instance/pull/28","diff_url":"https://github.com/cloudposse/terraform-aws-ec2-instance/pull/28.diff","patch_url":"https://github.com/cloudposse/terraform-aws-ec2-instance/pull/28.patch","issue_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues/28","number":28,"state":"open","locked":false,"title":"Allows multiple instances to be created. Allows ssh key generation.","user":{"login":"Jamie-BitFlight","id":25075504,"avatar_url":"https://avatars3.githubusercontent.com/u/25075504?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamie-BitFlight","html_url":"https://github.com/Jamie-BitFlight","followers_url":"https://api.github.com/users/Jamie-BitFlight/followers","following_url":"https://api.github.com/users/Jamie-BitFlight/following{/other_user}","gists_url":"https://api.github.com/users/Jamie-BitFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamie-BitFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamie-BitFlight/subscriptions","organizations_url":"https://api.github.com/users/Jamie-BitFlight/orgs","repos_url":"https://api.github.com/users/Jamie-BitFlight/repos","events_url":"https://api.github.com/users/Jamie-BitFlight/events{/privacy}","received_events_url":"https://api.github.com/users/Jamie-BitFlight/received_events","type":"User","site_admin":false},"body":"## what\r\n* Allow multiple instances to be created\r\n* Allows multiple instances to be created. \r\n* Allows ssh key generation\r\n\r\n## why\r\n* As per request https://github.com/cloudposse/terraform-aws-ec2-instance/issues/27","created_at":"2018-05-16T01:00:36Z","updated_at":"2018-05-25T05:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9448e47ea5801e77acc42b513ab6e25b1f98d0f","assignee":{"login":"aknysh","id":7356997,"avatar_url":"https://avatars0.githubusercontent.com/u/7356997?v=4","gravatar_id":"","url":"https://api.github.com/users/aknysh","html_url":"https://github.com/aknysh","followers_url":"https://api.github.com/users/aknysh/followers","following_url":"https://api.github.com/users/aknysh/following{/other_user}","gists_url":"https://api.github.com/users/aknysh/gists{/gist_id}","starred_url":"https://api.github.com/users/aknysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknysh/subscriptions","organizations_url":"https://api.github.com/users/aknysh/orgs","repos_url":"https://api.github.com/users/aknysh/repos","events_url":"https://api.github.com/users/aknysh/events{/privacy}","received_events_url":"https://api.github.com/users/aknysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"aknysh","id":7356997,"avatar_url":"https://avatars0.githubusercontent.com/u/7356997?v=4","gravatar_id":"","url":"https://api.github.com/users/aknysh","html_url":"https://github.com/aknysh","followers_url":"https://api.github.com/users/aknysh/followers","following_url":"https://api.github.com/users/aknysh/following{/other_user}","gists_url":"https://api.github.com/users/aknysh/gists{/gist_id}","starred_url":"https://api.github.com/users/aknysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknysh/subscriptions","organizations_url":"https://api.github.com/users/aknysh/orgs","repos_url":"https://api.github.com/users/aknysh/repos","events_url":"https://api.github.com/users/aknysh/events{/privacy}","received_events_url":"https://api.github.com/users/aknysh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28/commits","review_comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28/comments","review_comment_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues/28/comments","statuses_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/statuses/19704dde9b12b17440fbe1deb2bad6ce94eeec3d","head":{"label":"Jamie-BitFlight:master","ref":"master","sha":"19704dde9b12b17440fbe1deb2bad6ce94eeec3d","user":{"login":"Jamie-BitFlight","id":25075504,"avatar_url":"https://avatars3.githubusercontent.com/u/25075504?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamie-BitFlight","html_url":"https://github.com/Jamie-BitFlight","followers_url":"https://api.github.com/users/Jamie-BitFlight/followers","following_url":"https://api.github.com/users/Jamie-BitFlight/following{/other_user}","gists_url":"https://api.github.com/users/Jamie-BitFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamie-BitFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamie-BitFlight/subscriptions","organizations_url":"https://api.github.com/users/Jamie-BitFlight/orgs","repos_url":"https://api.github.com/users/Jamie-BitFlight/repos","events_url":"https://api.github.com/users/Jamie-BitFlight/events{/privacy}","received_events_url":"https://api.github.com/users/Jamie-BitFlight/received_events","type":"User","site_admin":false},"repo":{"id":133575320,"name":"terraform-aws-ec2-instance","full_name":"Jamie-BitFlight/terraform-aws-ec2-instance","owner":{"login":"Jamie-BitFlight","id":25075504,"avatar_url":"https://avatars3.githubusercontent.com/u/25075504?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamie-BitFlight","html_url":"https://github.com/Jamie-BitFlight","followers_url":"https://api.github.com/users/Jamie-BitFlight/followers","following_url":"https://api.github.com/users/Jamie-BitFlight/following{/other_user}","gists_url":"https://api.github.com/users/Jamie-BitFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamie-BitFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamie-BitFlight/subscriptions","organizations_url":"https://api.github.com/users/Jamie-BitFlight/orgs","repos_url":"https://api.github.com/users/Jamie-BitFlight/repos","events_url":"https://api.github.com/users/Jamie-BitFlight/events{/privacy}","received_events_url":"https://api.github.com/users/Jamie-BitFlight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jamie-BitFlight/terraform-aws-ec2-instance","description":"Terraform Module for providing a general EC2 instance provisioned by Ansible","fork":true,"url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance","forks_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/forks","keys_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/teams","hooks_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/hooks","issue_events_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/issues/events{/number}","events_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/events","assignees_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/assignees{/user}","branches_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/branches{/branch}","tags_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/tags","blobs_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/statuses/{sha}","languages_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/languages","stargazers_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/stargazers","contributors_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/contributors","subscribers_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/subscribers","subscription_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/subscription","commits_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/contents/{+path}","compare_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/merges","archive_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/downloads","issues_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/issues{/number}","pulls_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/pulls{/number}","milestones_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/milestones{/number}","notifications_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/labels{/name}","releases_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/releases{/id}","deployments_url":"https://api.github.com/repos/Jamie-BitFlight/terraform-aws-ec2-instance/deployments","created_at":"2018-05-15T21:28:32Z","updated_at":"2018-05-22T13:17:49Z","pushed_at":"2018-05-22T13:17:47Z","git_url":"git://github.com/Jamie-BitFlight/terraform-aws-ec2-instance.git","ssh_url":"git@github.com:Jamie-BitFlight/terraform-aws-ec2-instance.git","clone_url":"https://github.com/Jamie-BitFlight/terraform-aws-ec2-instance.git","svn_url":"https://github.com/Jamie-BitFlight/terraform-aws-ec2-instance","homepage":"https://cloudposse.com/","size":68,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudposse:master","ref":"master","sha":"b5ded90561c6057dc7e8de1f7a7829eeba6ad3ed","user":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":99026235,"name":"terraform-aws-ec2-instance","full_name":"cloudposse/terraform-aws-ec2-instance","owner":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudposse/terraform-aws-ec2-instance","description":"Terraform Module for providing a general EC2 instance provisioned by Ansible","fork":false,"url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance","forks_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/forks","keys_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/teams","hooks_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/events","assignees_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/tags","blobs_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/languages","stargazers_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/subscription","commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/merges","archive_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/downloads","issues_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/deployments","created_at":"2017-08-01T17:24:54Z","updated_at":"2018-05-08T19:17:53Z","pushed_at":"2018-05-22T13:17:49Z","git_url":"git://github.com/cloudposse/terraform-aws-ec2-instance.git","ssh_url":"git@github.com:cloudposse/terraform-aws-ec2-instance.git","clone_url":"https://github.com/cloudposse/terraform-aws-ec2-instance.git","svn_url":"https://github.com/cloudposse/terraform-aws-ec2-instance","homepage":"https://cloudposse.com/","size":47,"stargazers_count":7,"watchers_count":7,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28"},"html":{"href":"https://github.com/cloudposse/terraform-aws-ec2-instance/pull/28"},"issue":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues/28"},"comments":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-ec2-instance/statuses/19704dde9b12b17440fbe1deb2bad6ce94eeec3d"}},"author_association":"NONE"}}
{"actor":{"display_login":"osterman"}}