{"action":"created","issue":{"url":"https://api.github.com/repos/react-native-community/react-native-side-menu/issues/276","repository_url":"https://api.github.com/repos/react-native-community/react-native-side-menu","labels_url":"https://api.github.com/repos/react-native-community/react-native-side-menu/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/react-native-community/react-native-side-menu/issues/276/comments","events_url":"https://api.github.com/repos/react-native-community/react-native-side-menu/issues/276/events","html_url":"https://github.com/react-native-community/react-native-side-menu/pull/276","id":223597844,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE3MTI4MTY1","number":276,"title":"Rerender child components when the parent changes this.props.isOpen","user":{"login":"ndbroadbent","id":139536,"node_id":"MDQ6VXNlcjEzOTUzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/139536?v=4","gravatar_id":"","url":"https://api.github.com/users/ndbroadbent","html_url":"https://github.com/ndbroadbent","followers_url":"https://api.github.com/users/ndbroadbent/followers","following_url":"https://api.github.com/users/ndbroadbent/following{/other_user}","gists_url":"https://api.github.com/users/ndbroadbent/gists{/gist_id}","starred_url":"https://api.github.com/users/ndbroadbent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndbroadbent/subscriptions","organizations_url":"https://api.github.com/users/ndbroadbent/orgs","repos_url":"https://api.github.com/users/ndbroadbent/repos","events_url":"https://api.github.com/users/ndbroadbent/events{/privacy}","received_events_url":"https://api.github.com/users/ndbroadbent/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-22T22:42:16Z","updated_at":"2018-07-26T09:07:38Z","closed_at":"2017-07-09T21:45:13Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/react-native-community/react-native-side-menu/pulls/276","html_url":"https://github.com/react-native-community/react-native-side-menu/pull/276","diff_url":"https://github.com/react-native-community/react-native-side-menu/pull/276.diff","patch_url":"https://github.com/react-native-community/react-native-side-menu/pull/276.patch"},"body":"Instead of checking for `this.isOpen !== props.isOpen`, we need to check for `this.props.isOpen !== props.isOpen`, so that the parent component can ~~close the menu~~ force child components to re-render by updating the `isOpen` prop. \r\n\r\n(`this.isOpen` and `this.props.isOpen` can get out of sync.)"},"comment":{"url":"https://api.github.com/repos/react-native-community/react-native-side-menu/issues/comments/408030726","html_url":"https://github.com/react-native-community/react-native-side-menu/pull/276#issuecomment-408030726","issue_url":"https://api.github.com/repos/react-native-community/react-native-side-menu/issues/276","id":408030726,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODAzMDcyNg==","user":{"login":"AlexCatch","id":13490042,"node_id":"MDQ6VXNlcjEzNDkwMDQy","avatar_url":"https://avatars1.githubusercontent.com/u/13490042?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexCatch","html_url":"https://github.com/AlexCatch","followers_url":"https://api.github.com/users/AlexCatch/followers","following_url":"https://api.github.com/users/AlexCatch/following{/other_user}","gists_url":"https://api.github.com/users/AlexCatch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexCatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexCatch/subscriptions","organizations_url":"https://api.github.com/users/AlexCatch/orgs","repos_url":"https://api.github.com/users/AlexCatch/repos","events_url":"https://api.github.com/users/AlexCatch/events{/privacy}","received_events_url":"https://api.github.com/users/AlexCatch/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T09:07:38Z","updated_at":"2018-07-26T09:07:38Z","author_association":"NONE","body":"It would make more sense to have a single source of truth. We either keep the open state entirely in the side menu or we keep it entirely in the parent component, it's not generally recommended to copy props like it is.\r\n\r\nIt also requires you to call ```forceUpdate``` as it's set as a property of the side menu and not inside state, is there a reason why it isn't stored in the component state?\r\n"}}
{"actor":{"display_login":"AlexCatch"}}