{"action":"created","issue":{"url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6451","repository_url":"https://api.github.com/repos/NativeScript/NativeScript","labels_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6451/labels{/name}","comments_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6451/comments","events_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6451/events","html_url":"https://github.com/NativeScript/NativeScript/pull/6451","id":373495819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDEzMTA2","number":6451,"title":"feat(android-ios-http): change  toFile functionality","user":{"login":"gezn","id":1752890,"node_id":"MDQ6VXNlcjE3NTI4OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1752890?v=4","gravatar_id":"","url":"https://api.github.com/users/gezn","html_url":"https://github.com/gezn","followers_url":"https://api.github.com/users/gezn/followers","following_url":"https://api.github.com/users/gezn/following{/other_user}","gists_url":"https://api.github.com/users/gezn/gists{/gist_id}","starred_url":"https://api.github.com/users/gezn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gezn/subscriptions","organizations_url":"https://api.github.com/users/gezn/orgs","repos_url":"https://api.github.com/users/gezn/repos","events_url":"https://api.github.com/users/gezn/events{/privacy}","received_events_url":"https://api.github.com/users/gezn/received_events","type":"User","site_admin":false},"labels":[{"id":203722174,"node_id":"MDU6TGFiZWwyMDM3MjIxNzQ=","url":"https://api.github.com/repos/NativeScript/NativeScript/labels/cla:%20yes","name":"cla: yes","color":"007241","default":false},{"id":203720953,"node_id":"MDU6TGFiZWwyMDM3MjA5NTM=","url":"https://api.github.com/repos/NativeScript/NativeScript/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"vakrilov","id":4092076,"node_id":"MDQ6VXNlcjQwOTIwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4092076?v=4","gravatar_id":"","url":"https://api.github.com/users/vakrilov","html_url":"https://github.com/vakrilov","followers_url":"https://api.github.com/users/vakrilov/followers","following_url":"https://api.github.com/users/vakrilov/following{/other_user}","gists_url":"https://api.github.com/users/vakrilov/gists{/gist_id}","starred_url":"https://api.github.com/users/vakrilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakrilov/subscriptions","organizations_url":"https://api.github.com/users/vakrilov/orgs","repos_url":"https://api.github.com/users/vakrilov/repos","events_url":"https://api.github.com/users/vakrilov/events{/privacy}","received_events_url":"https://api.github.com/users/vakrilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"vakrilov","id":4092076,"node_id":"MDQ6VXNlcjQwOTIwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4092076?v=4","gravatar_id":"","url":"https://api.github.com/users/vakrilov","html_url":"https://github.com/vakrilov","followers_url":"https://api.github.com/users/vakrilov/followers","following_url":"https://api.github.com/users/vakrilov/following{/other_user}","gists_url":"https://api.github.com/users/vakrilov/gists{/gist_id}","starred_url":"https://api.github.com/users/vakrilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakrilov/subscriptions","organizations_url":"https://api.github.com/users/vakrilov/orgs","repos_url":"https://api.github.com/users/vakrilov/repos","events_url":"https://api.github.com/users/vakrilov/events{/privacy}","received_events_url":"https://api.github.com/users/vakrilov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-10-24T13:54:43Z","updated_at":"2018-11-19T14:36:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6451","html_url":"https://github.com/NativeScript/NativeScript/pull/6451","diff_url":"https://github.com/NativeScript/NativeScript/pull/6451.diff","patch_url":"https://github.com/NativeScript/NativeScript/pull/6451.patch"},"body":"When using the response.content.toFile the dir for the file should be created it not exists instead of throwing an error\r\n\r\n<!--\r\nWe, the rest of the NativeScript community, thank you for your\r\ncontribution! \r\nTo help the rest of the community review your change, please follow the instructions in the template.\r\n-->\r\n\r\n<!-- PULL REQUEST TEMPLATE -->\r\n<!-- (Update \"[ ]\" to \"[x]\" to check a box) -->\r\n\r\n## PR Checklist\r\n\r\n- [x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.\r\n- [x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.\r\n- [x] You have signed the [CLA](http://www.nativescript.org/cla).\r\n- [x] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.\r\n- [x] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.\r\n\r\n## What is the current behavior?\r\nhttps://github.com/NativeScript/NativeScript/issues/3870\r\n\r\n## What is the new behavior?\r\nhttps://github.com/NativeScript/NativeScript/issues/3870\r\nas described on the issue, in the new behavior it just tries to create the dir in case it doesn't exists before writing the file\r\n\r\nFixes #[3870].\r\n\r\n\r\n \r\nBREAKING CHANGES:\r\n\r\nno breaking changes \r\n\r\n\r\nthis is my first contribution\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NativeScript/NativeScript/issues/comments/439913525","html_url":"https://github.com/NativeScript/NativeScript/pull/6451#issuecomment-439913525","issue_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6451","id":439913525,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTkxMzUyNQ==","user":{"login":"radeva","id":5549757,"node_id":"MDQ6VXNlcjU1NDk3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5549757?v=4","gravatar_id":"","url":"https://api.github.com/users/radeva","html_url":"https://github.com/radeva","followers_url":"https://api.github.com/users/radeva/followers","following_url":"https://api.github.com/users/radeva/following{/other_user}","gists_url":"https://api.github.com/users/radeva/gists{/gist_id}","starred_url":"https://api.github.com/users/radeva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeva/subscriptions","organizations_url":"https://api.github.com/users/radeva/orgs","repos_url":"https://api.github.com/users/radeva/repos","events_url":"https://api.github.com/users/radeva/events{/privacy}","received_events_url":"https://api.github.com/users/radeva/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T14:36:42Z","updated_at":"2018-11-19T14:36:42Z","author_association":"CONTRIBUTOR","body":"Hi @gezn ,\r\n\r\nCongratulations on being one of the winners in the {N} First-time contributors contest! \r\n\r\nYou can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: \r\n👉Your full name \r\n👉Your email \r\n👉Your country or residence \r\n\r\nBest regards,\r\nThe NativeScript Team\r\n"}}
{"actor":{"display_login":"radeva"}}