{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/documentation/pulls/comments/182095814","pull_request_review_id":112839105,"id":182095814,"diff_hunk":"@@ -0,0 +1,104 @@\n+---\n+title: as_count() monitor evaluation changes\n+kind: faq\n+---\n+\n+## Overview\n+\n+Currently monitors that have the `as_count` modifier use a separate evaluation path than other monitors. In certain use-cases this this can result in unexpected behavior. We intend to migrate all monitors with `as_count` to the same evaluation path as other monitors, but this doc explains the underlying issue and will guide you through the migration process.\n+\n+Let's call the current evaluation path for `as_count` monitors `current_eva_path` and the new one `new_eva_path`.  \n+","path":"content/monitors/faq/as-count-monitor-evaluation.md","position":11,"original_position":11,"commit_id":"0bbd168f29fe3ac7f6b38650b12ff1d9bf0c4f4a","original_commit_id":"0bbd168f29fe3ac7f6b38650b12ff1d9bf0c4f4a","user":{"login":"niamster","id":211000,"avatar_url":"https://avatars3.githubusercontent.com/u/211000?v=4","gravatar_id":"","url":"https://api.github.com/users/niamster","html_url":"https://github.com/niamster","followers_url":"https://api.github.com/users/niamster/followers","following_url":"https://api.github.com/users/niamster/following{/other_user}","gists_url":"https://api.github.com/users/niamster/gists{/gist_id}","starred_url":"https://api.github.com/users/niamster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niamster/subscriptions","organizations_url":"https://api.github.com/users/niamster/orgs","repos_url":"https://api.github.com/users/niamster/repos","events_url":"https://api.github.com/users/niamster/events{/privacy}","received_events_url":"https://api.github.com/users/niamster/received_events","type":"User","site_admin":false},"body":"I would suggest to name `old/new_eval_path`","created_at":"2018-04-17T14:36:10Z","updated_at":"2018-04-17T14:54:21Z","html_url":"https://github.com/DataDog/documentation/pull/2343#discussion_r182095814","pull_request_url":"https://api.github.com/repos/DataDog/documentation/pulls/2343","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/comments/182095814"},"html":{"href":"https://github.com/DataDog/documentation/pull/2343#discussion_r182095814"},"pull_request":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/2343"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/documentation/pulls/2343","id":181432551,"html_url":"https://github.com/DataDog/documentation/pull/2343","diff_url":"https://github.com/DataDog/documentation/pull/2343.diff","patch_url":"https://github.com/DataDog/documentation/pull/2343.patch","issue_url":"https://api.github.com/repos/DataDog/documentation/issues/2343","number":2343,"state":"closed","locked":false,"title":"as_count monitor query doc","user":{"login":"l0k0ms","id":3624790,"avatar_url":"https://avatars3.githubusercontent.com/u/3624790?v=4","gravatar_id":"","url":"https://api.github.com/users/l0k0ms","html_url":"https://github.com/l0k0ms","followers_url":"https://api.github.com/users/l0k0ms/followers","following_url":"https://api.github.com/users/l0k0ms/following{/other_user}","gists_url":"https://api.github.com/users/l0k0ms/gists{/gist_id}","starred_url":"https://api.github.com/users/l0k0ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0k0ms/subscriptions","organizations_url":"https://api.github.com/users/l0k0ms/orgs","repos_url":"https://api.github.com/users/l0k0ms/repos","events_url":"https://api.github.com/users/l0k0ms/events{/privacy}","received_events_url":"https://api.github.com/users/l0k0ms/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nCurrently, if a user creates a monitor with a query of the format SUM(A).as_count() / SUM(B).as_count(), it won't actually work the way the customer expects.\r\n\r\nThe long-term plan is to display a warning in the monitor-creation UI, and to ideally guide them through a better creation flow.\r\n\r\nIn the meantime though, it's super confusing to everyone (particularly users), and we encounter this issue all the time. \r\n\r\n### Preview link\r\n\r\nhttps://docs-staging.datadoghq.com/gus/monitor-kb/monitors/faq/as-count-monitor-evaluation/\r\n","created_at":"2018-04-13T09:27:20Z","updated_at":"2018-04-17T14:54:21Z","closed_at":"2018-04-17T02:12:59Z","merged_at":"2018-04-17T02:12:59Z","merge_commit_sha":"63a20740e01e760e26e8cc6ca072e6459499af6a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"awang","id":163404,"avatar_url":"https://avatars3.githubusercontent.com/u/163404?v=4","gravatar_id":"","url":"https://api.github.com/users/awang","html_url":"https://github.com/awang","followers_url":"https://api.github.com/users/awang/followers","following_url":"https://api.github.com/users/awang/following{/other_user}","gists_url":"https://api.github.com/users/awang/gists{/gist_id}","starred_url":"https://api.github.com/users/awang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awang/subscriptions","organizations_url":"https://api.github.com/users/awang/orgs","repos_url":"https://api.github.com/users/awang/repos","events_url":"https://api.github.com/users/awang/events{/privacy}","received_events_url":"https://api.github.com/users/awang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":794805742,"url":"https://api.github.com/repos/DataDog/documentation/labels/KB/FAQ","name":"KB/FAQ","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/documentation/pulls/2343/commits","review_comments_url":"https://api.github.com/repos/DataDog/documentation/pulls/2343/comments","review_comment_url":"https://api.github.com/repos/DataDog/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/documentation/issues/2343/comments","statuses_url":"https://api.github.com/repos/DataDog/documentation/statuses/0bbd168f29fe3ac7f6b38650b12ff1d9bf0c4f4a","head":{"label":"DataDog:gus/monitor-kb","ref":"gus/monitor-kb","sha":"0bbd168f29fe3ac7f6b38650b12ff1d9bf0c4f4a","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":2967233,"name":"documentation","full_name":"DataDog/documentation","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/documentation","description":"The source for Datadog's documentation site.","fork":false,"url":"https://api.github.com/repos/DataDog/documentation","forks_url":"https://api.github.com/repos/DataDog/documentation/forks","keys_url":"https://api.github.com/repos/DataDog/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/documentation/teams","hooks_url":"https://api.github.com/repos/DataDog/documentation/hooks","issue_events_url":"https://api.github.com/repos/DataDog/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/documentation/events","assignees_url":"https://api.github.com/repos/DataDog/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/documentation/tags","blobs_url":"https://api.github.com/repos/DataDog/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/documentation/languages","stargazers_url":"https://api.github.com/repos/DataDog/documentation/stargazers","contributors_url":"https://api.github.com/repos/DataDog/documentation/contributors","subscribers_url":"https://api.github.com/repos/DataDog/documentation/subscribers","subscription_url":"https://api.github.com/repos/DataDog/documentation/subscription","commits_url":"https://api.github.com/repos/DataDog/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/documentation/merges","archive_url":"https://api.github.com/repos/DataDog/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/documentation/downloads","issues_url":"https://api.github.com/repos/DataDog/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/documentation/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/documentation/deployments","created_at":"2011-12-12T20:32:29Z","updated_at":"2018-04-17T07:31:54Z","pushed_at":"2018-04-17T12:42:11Z","git_url":"git://github.com/DataDog/documentation.git","ssh_url":"git@github.com:DataDog/documentation.git","clone_url":"https://github.com/DataDog/documentation.git","svn_url":"https://github.com/DataDog/documentation","homepage":"http://docs.datadoghq.com","size":218926,"stargazers_count":47,"watchers_count":47,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":94,"open_issues":6,"watchers":47,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"7d979ea5cc63c304eb7921b7055fcacdde960ecc","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":2967233,"name":"documentation","full_name":"DataDog/documentation","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/documentation","description":"The source for Datadog's documentation site.","fork":false,"url":"https://api.github.com/repos/DataDog/documentation","forks_url":"https://api.github.com/repos/DataDog/documentation/forks","keys_url":"https://api.github.com/repos/DataDog/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/documentation/teams","hooks_url":"https://api.github.com/repos/DataDog/documentation/hooks","issue_events_url":"https://api.github.com/repos/DataDog/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/documentation/events","assignees_url":"https://api.github.com/repos/DataDog/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/documentation/tags","blobs_url":"https://api.github.com/repos/DataDog/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/documentation/languages","stargazers_url":"https://api.github.com/repos/DataDog/documentation/stargazers","contributors_url":"https://api.github.com/repos/DataDog/documentation/contributors","subscribers_url":"https://api.github.com/repos/DataDog/documentation/subscribers","subscription_url":"https://api.github.com/repos/DataDog/documentation/subscription","commits_url":"https://api.github.com/repos/DataDog/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/documentation/merges","archive_url":"https://api.github.com/repos/DataDog/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/documentation/downloads","issues_url":"https://api.github.com/repos/DataDog/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/documentation/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/documentation/deployments","created_at":"2011-12-12T20:32:29Z","updated_at":"2018-04-17T07:31:54Z","pushed_at":"2018-04-17T12:42:11Z","git_url":"git://github.com/DataDog/documentation.git","ssh_url":"git@github.com:DataDog/documentation.git","clone_url":"https://github.com/DataDog/documentation.git","svn_url":"https://github.com/DataDog/documentation","homepage":"http://docs.datadoghq.com","size":218926,"stargazers_count":47,"watchers_count":47,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":94,"open_issues":6,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/2343"},"html":{"href":"https://github.com/DataDog/documentation/pull/2343"},"issue":{"href":"https://api.github.com/repos/DataDog/documentation/issues/2343"},"comments":{"href":"https://api.github.com/repos/DataDog/documentation/issues/2343/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/2343/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/2343/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/documentation/statuses/0bbd168f29fe3ac7f6b38650b12ff1d9bf0c4f4a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"niamster"}}