{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/phdrs/pulls/comments/222296431","pull_request_review_id":161147173,"id":222296431,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjI5NjQzMQ==","diff_hunk":"@@ -0,0 +1,15 @@\n+language: rust\n+rust: stable\n+cache: cargo\n+\n+before_script:\n+    - export PATH=\"$PATH:$HOME/.cargo/bin\"\n+\n+script:\n+    # By installing rustfmt, auto-generated code becomes more readable.","path":".travis.yml","position":9,"original_position":9,"commit_id":"0a7bc0c24e0f40d18030256378520f2d94ff5bb1","original_commit_id":"0a7bc0c24e0f40d18030256378520f2d94ff5bb1","user":{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"body":"A possible comment might be something like \"We need to use rustfmt on auto-generated code: without it, code is put on a single line, which then causes Travis to crash because ...\".","created_at":"2018-10-03T12:55:22Z","updated_at":"2018-10-03T12:55:23Z","html_url":"https://github.com/softdevteam/phdrs/pull/1#discussion_r222296431","pull_request_url":"https://api.github.com/repos/softdevteam/phdrs/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/phdrs/pulls/comments/222296431"},"html":{"href":"https://github.com/softdevteam/phdrs/pull/1#discussion_r222296431"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/phdrs/pulls/1"}},"in_reply_to_id":222294726},"pull_request":{"url":"https://api.github.com/repos/softdevteam/phdrs/pulls/1","id":216021406,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDIxNDA2","html_url":"https://github.com/softdevteam/phdrs/pull/1","diff_url":"https://github.com/softdevteam/phdrs/pull/1.diff","patch_url":"https://github.com/softdevteam/phdrs/pull/1.patch","issue_url":"https://api.github.com/repos/softdevteam/phdrs/issues/1","number":1,"state":"open","locked":false,"title":"A small Rust wrapper around `dl_iterate_phdr(3)`.","user":{"login":"vext01","id":604955,"node_id":"MDQ6VXNlcjYwNDk1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/604955?v=4","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"body":"Let's start getting some Yorick stuff out of private repos.\r\n\r\nStarting with the easy stuff, this is a little library to make it painless to inspect the program headers from Rust. I wrote it some time ago, and spent some time today tidying it up for code review.\r\n\r\nIn Yorick, we use this to know which object (compilation unit) a virtual address from a PT trace comes from.\r\n\r\nOne auto-generated test block us from merging this. I raised an issue for this a while back, but upstream have not yet had a chance to look: https://github.com/rust-lang-nursery/rust-bindgen/issues/1370\r\n\r\nWe can still do the code review.\r\n\r\nCheers","created_at":"2018-09-17T15:24:14Z","updated_at":"2018-10-03T12:55:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8be6b36f314f527428a46a9afadae6d258e25109","assignee":{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/phdrs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/softdevteam/phdrs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/softdevteam/phdrs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/phdrs/issues/1/comments","statuses_url":"https://api.github.com/repos/softdevteam/phdrs/statuses/0a7bc0c24e0f40d18030256378520f2d94ff5bb1","head":{"label":"softdevteam:initial","ref":"initial","sha":"0a7bc0c24e0f40d18030256378520f2d94ff5bb1","user":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":149144491,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxNDQ0OTE=","name":"phdrs","full_name":"softdevteam/phdrs","private":false,"owner":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/softdevteam/phdrs","description":"A Rust wrapper around `dl_iterate_phdr(3)`","fork":false,"url":"https://api.github.com/repos/softdevteam/phdrs","forks_url":"https://api.github.com/repos/softdevteam/phdrs/forks","keys_url":"https://api.github.com/repos/softdevteam/phdrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/phdrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/phdrs/teams","hooks_url":"https://api.github.com/repos/softdevteam/phdrs/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/phdrs/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/phdrs/events","assignees_url":"https://api.github.com/repos/softdevteam/phdrs/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/phdrs/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/phdrs/tags","blobs_url":"https://api.github.com/repos/softdevteam/phdrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/phdrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/phdrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/phdrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/phdrs/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/phdrs/languages","stargazers_url":"https://api.github.com/repos/softdevteam/phdrs/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/phdrs/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/phdrs/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/phdrs/subscription","commits_url":"https://api.github.com/repos/softdevteam/phdrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/phdrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/phdrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/phdrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/phdrs/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/phdrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/phdrs/merges","archive_url":"https://api.github.com/repos/softdevteam/phdrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/phdrs/downloads","issues_url":"https://api.github.com/repos/softdevteam/phdrs/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/phdrs/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/phdrs/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/phdrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/phdrs/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/phdrs/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/phdrs/deployments","created_at":"2018-09-17T15:12:10Z","updated_at":"2018-09-17T15:14:36Z","pushed_at":"2018-10-03T11:34:02Z","git_url":"git://github.com/softdevteam/phdrs.git","ssh_url":"git@github.com:softdevteam/phdrs.git","clone_url":"https://github.com/softdevteam/phdrs.git","svn_url":"https://github.com/softdevteam/phdrs","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"e314401a963a2e943e68257bb063070a3d0a95c0","user":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":149144491,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxNDQ0OTE=","name":"phdrs","full_name":"softdevteam/phdrs","private":false,"owner":{"login":"softdevteam","id":10271085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjcxMDg1","avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/softdevteam/phdrs","description":"A Rust wrapper around `dl_iterate_phdr(3)`","fork":false,"url":"https://api.github.com/repos/softdevteam/phdrs","forks_url":"https://api.github.com/repos/softdevteam/phdrs/forks","keys_url":"https://api.github.com/repos/softdevteam/phdrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/phdrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/phdrs/teams","hooks_url":"https://api.github.com/repos/softdevteam/phdrs/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/phdrs/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/phdrs/events","assignees_url":"https://api.github.com/repos/softdevteam/phdrs/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/phdrs/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/phdrs/tags","blobs_url":"https://api.github.com/repos/softdevteam/phdrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/phdrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/phdrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/phdrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/phdrs/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/phdrs/languages","stargazers_url":"https://api.github.com/repos/softdevteam/phdrs/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/phdrs/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/phdrs/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/phdrs/subscription","commits_url":"https://api.github.com/repos/softdevteam/phdrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/phdrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/phdrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/phdrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/phdrs/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/phdrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/phdrs/merges","archive_url":"https://api.github.com/repos/softdevteam/phdrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/phdrs/downloads","issues_url":"https://api.github.com/repos/softdevteam/phdrs/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/phdrs/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/phdrs/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/phdrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/phdrs/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/phdrs/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/phdrs/deployments","created_at":"2018-09-17T15:12:10Z","updated_at":"2018-09-17T15:14:36Z","pushed_at":"2018-10-03T11:34:02Z","git_url":"git://github.com/softdevteam/phdrs.git","ssh_url":"git@github.com:softdevteam/phdrs.git","clone_url":"https://github.com/softdevteam/phdrs.git","svn_url":"https://github.com/softdevteam/phdrs","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/phdrs/pulls/1"},"html":{"href":"https://github.com/softdevteam/phdrs/pull/1"},"issue":{"href":"https://api.github.com/repos/softdevteam/phdrs/issues/1"},"comments":{"href":"https://api.github.com/repos/softdevteam/phdrs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/phdrs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/phdrs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/phdrs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/phdrs/statuses/0a7bc0c24e0f40d18030256378520f2d94ff5bb1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ltratt"}}