{"action":"created","issue":{"url":"https://api.github.com/repos/wp-cli/wp-cli/issues/4969","repository_url":"https://api.github.com/repos/wp-cli/wp-cli","labels_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/4969/labels{/name}","comments_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/4969/comments","events_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/4969/events","html_url":"https://github.com/wp-cli/wp-cli/issues/4969","id":369350153,"node_id":"MDU6SXNzdWUzNjkzNTAxNTM=","number":4969,"title":"Storing a lot of environment variables","user":{"login":"szepeviktor","id":952007,"node_id":"MDQ6VXNlcjk1MjAwNw==","avatar_url":"https://avatars3.githubusercontent.com/u/952007?v=4","gravatar_id":"","url":"https://api.github.com/users/szepeviktor","html_url":"https://github.com/szepeviktor","followers_url":"https://api.github.com/users/szepeviktor/followers","following_url":"https://api.github.com/users/szepeviktor/following{/other_user}","gists_url":"https://api.github.com/users/szepeviktor/gists{/gist_id}","starred_url":"https://api.github.com/users/szepeviktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szepeviktor/subscriptions","organizations_url":"https://api.github.com/users/szepeviktor/orgs","repos_url":"https://api.github.com/users/szepeviktor/repos","events_url":"https://api.github.com/users/szepeviktor/events{/privacy}","received_events_url":"https://api.github.com/users/szepeviktor/received_events","type":"User","site_admin":false},"labels":[{"id":418990665,"node_id":"MDU6TGFiZWw0MTg5OTA2NjU=","url":"https://api.github.com/repos/wp-cli/wp-cli/labels/feature-request","name":"feature-request","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-12T00:00:53Z","updated_at":"2018-10-24T12:15:24Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"It seems to be wp-cli.yml cannot hold envs.\r\nWe use a WP installation depending on many envs.\r\nNow I keep `putenv()`-s in\r\n\r\n```yaml\r\nrequire:\r\n  - /home/user/website/wp-cli-envs.php\r\n```\r\n\r\nCould we implement this?\r\n\r\n```yaml\r\nenv:\r\n  DB_NAME: \"instahuu\"\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/wp-cli/wp-cli/issues/comments/432631133","html_url":"https://github.com/wp-cli/wp-cli/issues/4969#issuecomment-432631133","issue_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/4969","id":432631133,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjYzMTEzMw==","user":{"login":"schlessera","id":83631,"node_id":"MDQ6VXNlcjgzNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/83631?v=4","gravatar_id":"","url":"https://api.github.com/users/schlessera","html_url":"https://github.com/schlessera","followers_url":"https://api.github.com/users/schlessera/followers","following_url":"https://api.github.com/users/schlessera/following{/other_user}","gists_url":"https://api.github.com/users/schlessera/gists{/gist_id}","starred_url":"https://api.github.com/users/schlessera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlessera/subscriptions","organizations_url":"https://api.github.com/users/schlessera/orgs","repos_url":"https://api.github.com/users/schlessera/repos","events_url":"https://api.github.com/users/schlessera/events{/privacy}","received_events_url":"https://api.github.com/users/schlessera/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T12:15:24Z","updated_at":"2018-10-24T12:15:24Z","author_association":"MEMBER","body":"Trying to discuss through this to find out whether we're actually improving something here...\r\n\r\nSo you have your environment variables as real environment variables on your server, not inside of a `.env` file. That is generally how you should set up a production server, whereas you'd be fine with a `.env` file on development machines. All fine here if the servers you are referring to are production machines and you access them over SSH.\r\n\r\nHowever, what you have proposed above to add an `env:` section to `wp-cli.yml` would have the same security drawbacks than a regular `.env` file, only that is then specifically tied to a WP-CLI implementation, instead of the more standard `.env` file convention.\r\n\r\nThe only way to avoid reintroducing the drawback of a `.env` with such a config change would be to have the `env:` section in your global user config `~/.wp-cli.yml` under aliases. However, that means that you have all sorts of project internals for all of your sites inside of one global config. Are you sure that would improve your situation?"}}
{"actor":{"display_login":"schlessera"}}