{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments/174144944","pull_request_review_id":103446346,"id":174144944,"diff_hunk":"@@ -104,6 +113,11 @@ public TagAnalysis validate(Node node) {\n             if (concept == null) {\n                 analysis.addError(Context.getMessageSourceService().getMessage(\"htmlformentry.error.invalidConcept\",\n                     new Object[] { conceptId }, null));\n+            } else {\n+                Collection<ConceptAnswer> conceptAnswers = concept.getAnswers();\n+                for (ConceptAnswer ca : conceptAnswers) {","path":"api/src/main/java/org/openmrs/module/htmlformentry/handler/ObsTagHandler.java","position":36,"original_position":36,"commit_id":"eaf3a3d1e07326842cb10fc5771e97680c5ddd39","original_commit_id":"eaf3a3d1e07326842cb10fc5771e97680c5ddd39","user":{"login":"mogoodrich","id":1163015,"avatar_url":"https://avatars1.githubusercontent.com/u/1163015?v=4","gravatar_id":"","url":"https://api.github.com/users/mogoodrich","html_url":"https://github.com/mogoodrich","followers_url":"https://api.github.com/users/mogoodrich/followers","following_url":"https://api.github.com/users/mogoodrich/following{/other_user}","gists_url":"https://api.github.com/users/mogoodrich/gists{/gist_id}","starred_url":"https://api.github.com/users/mogoodrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogoodrich/subscriptions","organizations_url":"https://api.github.com/users/mogoodrich/orgs","repos_url":"https://api.github.com/users/mogoodrich/repos","events_url":"https://api.github.com/users/mogoodrich/events{/privacy}","received_events_url":"https://api.github.com/users/mogoodrich/received_events","type":"User","site_admin":false},"body":"I think that you might run into a NPE exception here in some cases... some observations are numeric or free-text (you enter a number or a text value), so they don't have \"answeConceptIds\"... this should be null-safe, or perhaps you only need to do this if on of the \"answer*\" node attributes has been specified.","created_at":"2018-03-13T14:13:13Z","updated_at":"2018-03-13T15:03:01Z","html_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/133#discussion_r174144944","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments/174144944"},"html":{"href":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/133#discussion_r174144944"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133","id":174178827,"html_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/133","diff_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/133.diff","patch_url":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/133.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/133","number":133,"state":"open","locked":false,"title":"HTML-366 Form Schema Preview should show a warning if an answer is not legal for its question","user":{"login":"piyush9620","id":16319579,"avatar_url":"https://avatars1.githubusercontent.com/u/16319579?v=4","gravatar_id":"","url":"https://api.github.com/users/piyush9620","html_url":"https://github.com/piyush9620","followers_url":"https://api.github.com/users/piyush9620/followers","following_url":"https://api.github.com/users/piyush9620/following{/other_user}","gists_url":"https://api.github.com/users/piyush9620/gists{/gist_id}","starred_url":"https://api.github.com/users/piyush9620/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyush9620/subscriptions","organizations_url":"https://api.github.com/users/piyush9620/orgs","repos_url":"https://api.github.com/users/piyush9620/repos","events_url":"https://api.github.com/users/piyush9620/events{/privacy}","received_events_url":"https://api.github.com/users/piyush9620/received_events","type":"User","site_admin":false},"body":"https://issues.openmrs.org/browse/HTML-366","created_at":"2018-03-10T16:57:22Z","updated_at":"2018-03-13T15:03:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b510b25f0bc7c309f5ebccd7029195743249521f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/133/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/statuses/eaf3a3d1e07326842cb10fc5771e97680c5ddd39","head":{"label":"piyush9620:HTML-366","ref":"HTML-366","sha":"eaf3a3d1e07326842cb10fc5771e97680c5ddd39","user":{"login":"piyush9620","id":16319579,"avatar_url":"https://avatars1.githubusercontent.com/u/16319579?v=4","gravatar_id":"","url":"https://api.github.com/users/piyush9620","html_url":"https://github.com/piyush9620","followers_url":"https://api.github.com/users/piyush9620/followers","following_url":"https://api.github.com/users/piyush9620/following{/other_user}","gists_url":"https://api.github.com/users/piyush9620/gists{/gist_id}","starred_url":"https://api.github.com/users/piyush9620/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyush9620/subscriptions","organizations_url":"https://api.github.com/users/piyush9620/orgs","repos_url":"https://api.github.com/users/piyush9620/repos","events_url":"https://api.github.com/users/piyush9620/events{/privacy}","received_events_url":"https://api.github.com/users/piyush9620/received_events","type":"User","site_admin":false},"repo":{"id":124400821,"name":"openmrs-module-htmlformentry","full_name":"piyush9620/openmrs-module-htmlformentry","owner":{"login":"piyush9620","id":16319579,"avatar_url":"https://avatars1.githubusercontent.com/u/16319579?v=4","gravatar_id":"","url":"https://api.github.com/users/piyush9620","html_url":"https://github.com/piyush9620","followers_url":"https://api.github.com/users/piyush9620/followers","following_url":"https://api.github.com/users/piyush9620/following{/other_user}","gists_url":"https://api.github.com/users/piyush9620/gists{/gist_id}","starred_url":"https://api.github.com/users/piyush9620/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyush9620/subscriptions","organizations_url":"https://api.github.com/users/piyush9620/orgs","repos_url":"https://api.github.com/users/piyush9620/repos","events_url":"https://api.github.com/users/piyush9620/events{/privacy}","received_events_url":"https://api.github.com/users/piyush9620/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piyush9620/openmrs-module-htmlformentry","description":"HTML Form Entry module","fork":true,"url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry","forks_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/forks","keys_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/teams","hooks_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/hooks","issue_events_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/issues/events{/number}","events_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/events","assignees_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/assignees{/user}","branches_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/branches{/branch}","tags_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/tags","blobs_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/statuses/{sha}","languages_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/languages","stargazers_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/stargazers","contributors_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/contributors","subscribers_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/subscribers","subscription_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/subscription","commits_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/contents/{+path}","compare_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/merges","archive_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/downloads","issues_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/issues{/number}","pulls_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/pulls{/number}","milestones_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/milestones{/number}","notifications_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/labels{/name}","releases_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/releases{/id}","deployments_url":"https://api.github.com/repos/piyush9620/openmrs-module-htmlformentry/deployments","created_at":"2018-03-08T14:11:00Z","updated_at":"2018-03-08T14:11:02Z","pushed_at":"2018-03-10T17:48:45Z","git_url":"git://github.com/piyush9620/openmrs-module-htmlformentry.git","ssh_url":"git@github.com:piyush9620/openmrs-module-htmlformentry.git","clone_url":"https://github.com/piyush9620/openmrs-module-htmlformentry.git","svn_url":"https://github.com/piyush9620/openmrs-module-htmlformentry","homepage":"https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module","size":25610,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"6f86a0f38f11ce2ac975b5aab9a10bce569213ad","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":2680621,"name":"openmrs-module-htmlformentry","full_name":"openmrs/openmrs-module-htmlformentry","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-htmlformentry","description":"HTML Form Entry module","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/deployments","created_at":"2011-10-31T13:06:47Z","updated_at":"2018-03-13T14:13:13Z","pushed_at":"2018-03-12T20:08:40Z","git_url":"git://github.com/openmrs/openmrs-module-htmlformentry.git","ssh_url":"git@github.com:openmrs/openmrs-module-htmlformentry.git","clone_url":"https://github.com/openmrs/openmrs-module-htmlformentry.git","svn_url":"https://github.com/openmrs/openmrs-module-htmlformentry","homepage":"https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module","size":25612,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":160,"open_issues":1,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133"},"html":{"href":"https://github.com/openmrs/openmrs-module-htmlformentry/pull/133"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/133"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-htmlformentry/statuses/eaf3a3d1e07326842cb10fc5771e97680c5ddd39"}},"author_association":"NONE"}}
{"actor":{"display_login":"mogoodrich"}}