{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/ml-cpp/pulls/comments/237827778","pull_request_review_id":180223037,"id":237827778,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgyNzc3OA==","diff_hunk":"@@ -101,6 +103,14 @@ int main(int argc, char** argv) {\n     // TODO Actually use the specification to create the data frame and run the analysis\n     ml::api::CDataFrameAnalysisSpecification dataFrameAnalysisSpecification{\n         makeDataFrameAnalysisSpecification(configFile)};\n+    if (dataFrameAnalysisSpecification.bad()) {\n+        LOG_FATAL(\"Failed to parse analysis specification\");\n+        return EXIT_FAILURE;\n+    }\n+    if (dataFrameAnalysisSpecification.threads() > 1) {\n+        ml::core::startDefaultAsyncExecutor(dataFrameAnalysisSpecification.threads() - 1);","path":"bin/data_frame_analyzer/Main.cc","position":25,"original_position":25,"commit_id":"42ebe9d25e400a6e15784b4d7aa5b3862c8f2d6d","original_commit_id":"42ebe9d25e400a6e15784b4d7aa5b3862c8f2d6d","user":{"login":"droberts195","id":7405510,"node_id":"MDQ6VXNlcjc0MDU1MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7405510?v=4","gravatar_id":"","url":"https://api.github.com/users/droberts195","html_url":"https://github.com/droberts195","followers_url":"https://api.github.com/users/droberts195/followers","following_url":"https://api.github.com/users/droberts195/following{/other_user}","gists_url":"https://api.github.com/users/droberts195/gists{/gist_id}","starred_url":"https://api.github.com/users/droberts195/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droberts195/subscriptions","organizations_url":"https://api.github.com/users/droberts195/orgs","repos_url":"https://api.github.com/users/droberts195/repos","events_url":"https://api.github.com/users/droberts195/events{/privacy}","received_events_url":"https://api.github.com/users/droberts195/received_events","type":"User","site_admin":false},"body":"Makes sense.  Thanks.","created_at":"2018-11-30T11:20:00Z","updated_at":"2018-11-30T11:20:00Z","html_url":"https://github.com/elastic/ml-cpp/pull/322#discussion_r237827778","pull_request_url":"https://api.github.com/repos/elastic/ml-cpp/pulls/322","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/ml-cpp/pulls/comments/237827778"},"html":{"href":"https://github.com/elastic/ml-cpp/pull/322#discussion_r237827778"},"pull_request":{"href":"https://api.github.com/repos/elastic/ml-cpp/pulls/322"}},"in_reply_to_id":237816279},"pull_request":{"url":"https://api.github.com/repos/elastic/ml-cpp/pulls/322","id":234686910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Njg2OTEw","html_url":"https://github.com/elastic/ml-cpp/pull/322","diff_url":"https://github.com/elastic/ml-cpp/pull/322.diff","patch_url":"https://github.com/elastic/ml-cpp/pull/322.patch","issue_url":"https://api.github.com/repos/elastic/ml-cpp/issues/322","number":322,"state":"open","locked":false,"title":"[FEATURE][ML] Infrastructure for parallelising data frame analyses","user":{"login":"tveasey","id":7591487,"node_id":"MDQ6VXNlcjc1OTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7591487?v=4","gravatar_id":"","url":"https://api.github.com/users/tveasey","html_url":"https://github.com/tveasey","followers_url":"https://api.github.com/users/tveasey/followers","following_url":"https://api.github.com/users/tveasey/following{/other_user}","gists_url":"https://api.github.com/users/tveasey/gists{/gist_id}","starred_url":"https://api.github.com/users/tveasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tveasey/subscriptions","organizations_url":"https://api.github.com/users/tveasey/orgs","repos_url":"https://api.github.com/users/tveasey/repos","events_url":"https://api.github.com/users/tveasey/events{/privacy}","received_events_url":"https://api.github.com/users/tveasey/received_events","type":"User","site_admin":false},"body":"This is a second attempt at #321. See that PR for additional background.\r\n\r\nAfter trying and failing to get transwarp to compile successfully with the Windows compiler we're using and investigating a couple of other alternatives, I decided in the end it was easier to just implement our own cutdown primitives for a thread pool and executors. These were all I was actually using from that library in the first instance.\r\n\r\nNote this thread pool significantly outperforms our old implementation (for example CJsonOutputStreamWrapperTest::testConcurrentWrite drops from around 450ms to around 160ms). I think this is mainly due to a better strategy for avoiding contention between worker threads, although it also moves objects around.\r\n\r\n(@droberts195 and @hendrikmuhs I believe I captured all your comments from the last PR.)","created_at":"2018-11-29T15:46:37Z","updated_at":"2018-11-30T11:20:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48236b2de4460f6f4aec43098125aa4db5998d52","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/ml-cpp/pulls/322/commits","review_comments_url":"https://api.github.com/repos/elastic/ml-cpp/pulls/322/comments","review_comment_url":"https://api.github.com/repos/elastic/ml-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/ml-cpp/issues/322/comments","statuses_url":"https://api.github.com/repos/elastic/ml-cpp/statuses/42ebe9d25e400a6e15784b4d7aa5b3862c8f2d6d","head":{"label":"tveasey:infrastructure/concurrency-2","ref":"infrastructure/concurrency-2","sha":"42ebe9d25e400a6e15784b4d7aa5b3862c8f2d6d","user":{"login":"tveasey","id":7591487,"node_id":"MDQ6VXNlcjc1OTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7591487?v=4","gravatar_id":"","url":"https://api.github.com/users/tveasey","html_url":"https://github.com/tveasey","followers_url":"https://api.github.com/users/tveasey/followers","following_url":"https://api.github.com/users/tveasey/following{/other_user}","gists_url":"https://api.github.com/users/tveasey/gists{/gist_id}","starred_url":"https://api.github.com/users/tveasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tveasey/subscriptions","organizations_url":"https://api.github.com/users/tveasey/orgs","repos_url":"https://api.github.com/users/tveasey/repos","events_url":"https://api.github.com/users/tveasey/events{/privacy}","received_events_url":"https://api.github.com/users/tveasey/received_events","type":"User","site_admin":false},"repo":{"id":131006689,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwMDY2ODk=","name":"ml-cpp-1","full_name":"tveasey/ml-cpp-1","private":false,"owner":{"login":"tveasey","id":7591487,"node_id":"MDQ6VXNlcjc1OTE0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7591487?v=4","gravatar_id":"","url":"https://api.github.com/users/tveasey","html_url":"https://github.com/tveasey","followers_url":"https://api.github.com/users/tveasey/followers","following_url":"https://api.github.com/users/tveasey/following{/other_user}","gists_url":"https://api.github.com/users/tveasey/gists{/gist_id}","starred_url":"https://api.github.com/users/tveasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tveasey/subscriptions","organizations_url":"https://api.github.com/users/tveasey/orgs","repos_url":"https://api.github.com/users/tveasey/repos","events_url":"https://api.github.com/users/tveasey/events{/privacy}","received_events_url":"https://api.github.com/users/tveasey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tveasey/ml-cpp-1","description":"Machine learning C++ code","fork":true,"url":"https://api.github.com/repos/tveasey/ml-cpp-1","forks_url":"https://api.github.com/repos/tveasey/ml-cpp-1/forks","keys_url":"https://api.github.com/repos/tveasey/ml-cpp-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tveasey/ml-cpp-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tveasey/ml-cpp-1/teams","hooks_url":"https://api.github.com/repos/tveasey/ml-cpp-1/hooks","issue_events_url":"https://api.github.com/repos/tveasey/ml-cpp-1/issues/events{/number}","events_url":"https://api.github.com/repos/tveasey/ml-cpp-1/events","assignees_url":"https://api.github.com/repos/tveasey/ml-cpp-1/assignees{/user}","branches_url":"https://api.github.com/repos/tveasey/ml-cpp-1/branches{/branch}","tags_url":"https://api.github.com/repos/tveasey/ml-cpp-1/tags","blobs_url":"https://api.github.com/repos/tveasey/ml-cpp-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tveasey/ml-cpp-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tveasey/ml-cpp-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tveasey/ml-cpp-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tveasey/ml-cpp-1/statuses/{sha}","languages_url":"https://api.github.com/repos/tveasey/ml-cpp-1/languages","stargazers_url":"https://api.github.com/repos/tveasey/ml-cpp-1/stargazers","contributors_url":"https://api.github.com/repos/tveasey/ml-cpp-1/contributors","subscribers_url":"https://api.github.com/repos/tveasey/ml-cpp-1/subscribers","subscription_url":"https://api.github.com/repos/tveasey/ml-cpp-1/subscription","commits_url":"https://api.github.com/repos/tveasey/ml-cpp-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tveasey/ml-cpp-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tveasey/ml-cpp-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tveasey/ml-cpp-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tveasey/ml-cpp-1/contents/{+path}","compare_url":"https://api.github.com/repos/tveasey/ml-cpp-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tveasey/ml-cpp-1/merges","archive_url":"https://api.github.com/repos/tveasey/ml-cpp-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tveasey/ml-cpp-1/downloads","issues_url":"https://api.github.com/repos/tveasey/ml-cpp-1/issues{/number}","pulls_url":"https://api.github.com/repos/tveasey/ml-cpp-1/pulls{/number}","milestones_url":"https://api.github.com/repos/tveasey/ml-cpp-1/milestones{/number}","notifications_url":"https://api.github.com/repos/tveasey/ml-cpp-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tveasey/ml-cpp-1/labels{/name}","releases_url":"https://api.github.com/repos/tveasey/ml-cpp-1/releases{/id}","deployments_url":"https://api.github.com/repos/tveasey/ml-cpp-1/deployments","created_at":"2018-04-25T12:58:29Z","updated_at":"2018-04-25T12:58:35Z","pushed_at":"2018-11-30T10:56:54Z","git_url":"git://github.com/tveasey/ml-cpp-1.git","ssh_url":"git@github.com:tveasey/ml-cpp-1.git","clone_url":"https://github.com/tveasey/ml-cpp-1.git","svn_url":"https://github.com/tveasey/ml-cpp-1","homepage":"","size":11855,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:feature/analysis-pipeline","ref":"feature/analysis-pipeline","sha":"d5045d30237ba43c8d46e63da20c04c82f39006a","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":122193808,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxOTM4MDg=","name":"ml-cpp","full_name":"elastic/ml-cpp","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/ml-cpp","description":"Machine learning C++ code","fork":false,"url":"https://api.github.com/repos/elastic/ml-cpp","forks_url":"https://api.github.com/repos/elastic/ml-cpp/forks","keys_url":"https://api.github.com/repos/elastic/ml-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/ml-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/ml-cpp/teams","hooks_url":"https://api.github.com/repos/elastic/ml-cpp/hooks","issue_events_url":"https://api.github.com/repos/elastic/ml-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/ml-cpp/events","assignees_url":"https://api.github.com/repos/elastic/ml-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/ml-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/ml-cpp/tags","blobs_url":"https://api.github.com/repos/elastic/ml-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/ml-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/ml-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/ml-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/ml-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/ml-cpp/languages","stargazers_url":"https://api.github.com/repos/elastic/ml-cpp/stargazers","contributors_url":"https://api.github.com/repos/elastic/ml-cpp/contributors","subscribers_url":"https://api.github.com/repos/elastic/ml-cpp/subscribers","subscription_url":"https://api.github.com/repos/elastic/ml-cpp/subscription","commits_url":"https://api.github.com/repos/elastic/ml-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/ml-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/ml-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/ml-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/ml-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/ml-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/ml-cpp/merges","archive_url":"https://api.github.com/repos/elastic/ml-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/ml-cpp/downloads","issues_url":"https://api.github.com/repos/elastic/ml-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/ml-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/ml-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/ml-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/ml-cpp/labels{/name}","releases_url":"https://api.github.com/repos/elastic/ml-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/ml-cpp/deployments","created_at":"2018-02-20T12:13:16Z","updated_at":"2018-11-30T05:45:03Z","pushed_at":"2018-11-30T10:58:04Z","git_url":"git://github.com/elastic/ml-cpp.git","ssh_url":"git@github.com:elastic/ml-cpp.git","clone_url":"https://github.com/elastic/ml-cpp.git","svn_url":"https://github.com/elastic/ml-cpp","homepage":"","size":10736,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":23,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/ml-cpp/pulls/322"},"html":{"href":"https://github.com/elastic/ml-cpp/pull/322"},"issue":{"href":"https://api.github.com/repos/elastic/ml-cpp/issues/322"},"comments":{"href":"https://api.github.com/repos/elastic/ml-cpp/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/ml-cpp/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/ml-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/ml-cpp/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/ml-cpp/statuses/42ebe9d25e400a6e15784b4d7aa5b3862c8f2d6d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"droberts195"}}