{"action":"opened","number":22228,"pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/22228","id":238804072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODA0MDcy","html_url":"https://github.com/woocommerce/woocommerce/pull/22228","diff_url":"https://github.com/woocommerce/woocommerce/pull/22228.diff","patch_url":"https://github.com/woocommerce/woocommerce/pull/22228.patch","issue_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/22228","number":22228,"state":"open","locked":false,"title":"strip slashes from POSTed attribute values on product edit","user":{"login":"rrennick","id":343847,"node_id":"MDQ6VXNlcjM0Mzg0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/343847?v=4","gravatar_id":"","url":"https://api.github.com/users/rrennick","html_url":"https://github.com/rrennick","followers_url":"https://api.github.com/users/rrennick/followers","following_url":"https://api.github.com/users/rrennick/following{/other_user}","gists_url":"https://api.github.com/users/rrennick/gists{/gist_id}","starred_url":"https://api.github.com/users/rrennick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrennick/subscriptions","organizations_url":"https://api.github.com/users/rrennick/orgs","repos_url":"https://api.github.com/users/rrennick/repos","events_url":"https://api.github.com/users/rrennick/events{/privacy}","received_events_url":"https://api.github.com/users/rrennick/received_events","type":"User","site_admin":false},"body":"### All Submissions:\r\n\r\n* [x] Have you followed the [WooCommerce Contributing guideline](https://github.com/woocommerce/woocommerce/blob/master/.github/CONTRIBUTING.md)?\r\n* [x] Does your code follow the [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/)?\r\n* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?\r\n\r\n### Changes proposed in this Pull Request:\r\n\r\nStrip slashes early in ajax save of product attributes. The slashes were being stripped from the values string when being saved to the DB so this issue only affected the display of the attributes after the ajax save. The attribute values string contains the slashes in the in-memory copy used for the ajax rendering of the attributes tab.\r\n\r\nCloses #22147 .\r\n\r\n### How to test the changes in this Pull Request:\r\n\r\n1. Edit a product\r\n2. Add a local attribute with values containing one or more `'`.\r\n3. After saving the attribute changes the attribute values should display correctly.\r\n\r\n### Other information:\r\n\r\n* [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n* [ ] Have you written new tests for your changes, as applicable?\r\n* [ ] Have you successfully ran tests with your changes locally?\r\n\r\n<!-- Mark completed items with an [x] -->\r\n\r\n### Changelog entry\r\n\r\n> Fix: allow apostrophes in product attribute values list.\r\n","created_at":"2018-12-14T18:23:08Z","updated_at":"2018-12-14T18:23:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/22228/commits","review_comments_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/22228/comments","review_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/22228/comments","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/6fc0c5d4b04615458d11d4bd60721e19aff79a66","head":{"label":"Prospress:fix/22147","ref":"fix/22147","sha":"6fc0c5d4b04615458d11d4bd60721e19aff79a66","user":{"login":"Prospress","id":7764284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NjQyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7764284?v=4","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"repo":{"id":150304272,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMDQyNzI=","name":"woocommerce","full_name":"Prospress/woocommerce","private":false,"owner":{"login":"Prospress","id":7764284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NjQyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7764284?v=4","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Prospress/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":true,"url":"https://api.github.com/repos/Prospress/woocommerce","forks_url":"https://api.github.com/repos/Prospress/woocommerce/forks","keys_url":"https://api.github.com/repos/Prospress/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prospress/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prospress/woocommerce/teams","hooks_url":"https://api.github.com/repos/Prospress/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/Prospress/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/Prospress/woocommerce/events","assignees_url":"https://api.github.com/repos/Prospress/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/Prospress/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/Prospress/woocommerce/tags","blobs_url":"https://api.github.com/repos/Prospress/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prospress/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prospress/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prospress/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prospress/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/Prospress/woocommerce/languages","stargazers_url":"https://api.github.com/repos/Prospress/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/Prospress/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/Prospress/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/Prospress/woocommerce/subscription","commits_url":"https://api.github.com/repos/Prospress/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prospress/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prospress/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prospress/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prospress/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/Prospress/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prospress/woocommerce/merges","archive_url":"https://api.github.com/repos/Prospress/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prospress/woocommerce/downloads","issues_url":"https://api.github.com/repos/Prospress/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/Prospress/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/Prospress/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/Prospress/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prospress/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/Prospress/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/Prospress/woocommerce/deployments","created_at":"2018-09-25T17:32:07Z","updated_at":"2018-12-14T17:50:32Z","pushed_at":"2018-12-14T18:15:12Z","git_url":"git://github.com/Prospress/woocommerce.git","ssh_url":"git@github.com:Prospress/woocommerce.git","clone_url":"https://github.com/Prospress/woocommerce.git","svn_url":"https://github.com/Prospress/woocommerce","homepage":"http://www.woocommerce.com/","size":151237,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"woocommerce:master","ref":"master","sha":"f13a0bc9eb49dad87b93e5b3ac019838e43b1404","user":{"login":"woocommerce","id":473596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc5OTIw","name":"woocommerce","full_name":"woocommerce/woocommerce","private":false,"owner":{"login":"woocommerce","id":473596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/woocommerce/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce","forks_url":"https://api.github.com/repos/woocommerce/woocommerce/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce/deployments","created_at":"2011-08-09T15:12:11Z","updated_at":"2018-12-14T01:28:26Z","pushed_at":"2018-12-14T12:47:09Z","git_url":"git://github.com/woocommerce/woocommerce.git","ssh_url":"git@github.com:woocommerce/woocommerce.git","clone_url":"https://github.com/woocommerce/woocommerce.git","svn_url":"https://github.com/woocommerce/woocommerce","homepage":"http://www.woocommerce.com/","size":151487,"stargazers_count":4916,"watchers_count":4916,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4890,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4890,"open_issues":289,"watchers":4916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/22228"},"html":{"href":"https://github.com/woocommerce/woocommerce/pull/22228"},"issue":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/22228"},"comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/22228/comments"},"review_comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/22228/comments"},"review_comment":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/22228/commits"},"statuses":{"href":"https://api.github.com/repos/woocommerce/woocommerce/statuses/6fc0c5d4b04615458d11d4bd60721e19aff79a66"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":80,"deletions":74,"changed_files":1}}
{"actor":{"display_login":"rrennick"}}