{"action":"created","issue":{"url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/issues/22","repository_url":"https://api.github.com/repos/CommandLineHeroes/hero-engine","labels_url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/issues/22/comments","events_url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/issues/22/events","html_url":"https://github.com/CommandLineHeroes/hero-engine/pull/22","id":369749637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjE1OTI5","number":22,"title":"add prettier code formatting and linting for import/export values","user":{"login":"mwcz","id":364615,"node_id":"MDQ6VXNlcjM2NDYxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/364615?v=4","gravatar_id":"","url":"https://api.github.com/users/mwcz","html_url":"https://github.com/mwcz","followers_url":"https://api.github.com/users/mwcz/followers","following_url":"https://api.github.com/users/mwcz/following{/other_user}","gists_url":"https://api.github.com/users/mwcz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcz/subscriptions","organizations_url":"https://api.github.com/users/mwcz/orgs","repos_url":"https://api.github.com/users/mwcz/repos","events_url":"https://api.github.com/users/mwcz/events{/privacy}","received_events_url":"https://api.github.com/users/mwcz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-13T00:36:22Z","updated_at":"2018-10-19T14:42:19Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/pulls/22","html_url":"https://github.com/CommandLineHeroes/hero-engine/pull/22","diff_url":"https://github.com/CommandLineHeroes/hero-engine/pull/22.diff","patch_url":"https://github.com/CommandLineHeroes/hero-engine/pull/22.patch"},"body":"This adds prettier code formatting.  It will be applied when `eslint --fix` is run.  It also adds `eslint-plugin-import` which lints imports and exports.  For example if you try to `import { fooBlah } from \"./lib.js\"` and lib.js doens't have a fooBlah export, eslint will error.\r\n\r\nIt also adds husky and lint-staged to allow linting to happen when a file is staged in git. There was already a precommit npm script but precommit requires husky and (optionally) lint-staged to be installed in order to work.  npm itself doesn't have a precommit script."},"comment":{"url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/issues/comments/431386881","html_url":"https://github.com/CommandLineHeroes/hero-engine/pull/22#issuecomment-431386881","issue_url":"https://api.github.com/repos/CommandLineHeroes/hero-engine/issues/22","id":431386881,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTM4Njg4MQ==","user":{"login":"mwcz","id":364615,"node_id":"MDQ6VXNlcjM2NDYxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/364615?v=4","gravatar_id":"","url":"https://api.github.com/users/mwcz","html_url":"https://github.com/mwcz","followers_url":"https://api.github.com/users/mwcz/followers","following_url":"https://api.github.com/users/mwcz/following{/other_user}","gists_url":"https://api.github.com/users/mwcz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcz/subscriptions","organizations_url":"https://api.github.com/users/mwcz/orgs","repos_url":"https://api.github.com/users/mwcz/repos","events_url":"https://api.github.com/users/mwcz/events{/privacy}","received_events_url":"https://api.github.com/users/mwcz/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T14:42:19Z","updated_at":"2018-10-19T14:42:19Z","author_association":"MEMBER","body":"@blalasaadri I also wanted to add the examples dir, but it required cleanup I wasn't ready to do yet (time constraints).  Part of the problem is the `lib` dir, which has files we definitely don't want to lint.  I'll update this PR with a `.eslintignore` file to exclude `lib`."}}
{"actor":{"display_login":"mwcz"}}