{"action":"created","issue":{"url":"https://api.github.com/repos/r9y9/wavenet_vocoder/issues/22","repository_url":"https://api.github.com/repos/r9y9/wavenet_vocoder","labels_url":"https://api.github.com/repos/r9y9/wavenet_vocoder/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/r9y9/wavenet_vocoder/issues/22/comments","events_url":"https://api.github.com/repos/r9y9/wavenet_vocoder/issues/22/events","html_url":"https://github.com/r9y9/wavenet_vocoder/issues/22","id":299845027,"number":22,"title":"+0.01 in audio._amp_to_db(x) ???","user":{"login":"duvtedudug","id":298918,"avatar_url":"https://avatars3.githubusercontent.com/u/298918?v=4","gravatar_id":"","url":"https://api.github.com/users/duvtedudug","html_url":"https://github.com/duvtedudug","followers_url":"https://api.github.com/users/duvtedudug/followers","following_url":"https://api.github.com/users/duvtedudug/following{/other_user}","gists_url":"https://api.github.com/users/duvtedudug/gists{/gist_id}","starred_url":"https://api.github.com/users/duvtedudug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duvtedudug/subscriptions","organizations_url":"https://api.github.com/users/duvtedudug/orgs","repos_url":"https://api.github.com/users/duvtedudug/repos","events_url":"https://api.github.com/users/duvtedudug/events{/privacy}","received_events_url":"https://api.github.com/users/duvtedudug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-23T20:46:37Z","updated_at":"2018-02-24T07:55:11Z","closed_at":null,"author_association":"NONE","body":"What is the reason for raising the floor of the spectrogram in the amp to db function?\r\n\r\nDid this give better sound quality?\r\n\r\n```\r\ndef _amp_to_db(x):\r\n    return 20 * np.log10(np.maximum(1e-5, x + 0.01))  # why the + 0.01??\r\n\r\n\r\ndef _db_to_amp(x):\r\n    return np.power(10.0, x * 0.05) # - 0.01 should be at end there??\r\n```\r\n\r\nAnd a small point, should the inverse function not have - 0.01 at the end to compensate for this?\r\n\r\nThanks in advance!"},"comment":{"url":"https://api.github.com/repos/r9y9/wavenet_vocoder/issues/comments/368209145","html_url":"https://github.com/r9y9/wavenet_vocoder/issues/22#issuecomment-368209145","issue_url":"https://api.github.com/repos/r9y9/wavenet_vocoder/issues/22","id":368209145,"user":{"login":"r9y9","id":1220272,"avatar_url":"https://avatars1.githubusercontent.com/u/1220272?v=4","gravatar_id":"","url":"https://api.github.com/users/r9y9","html_url":"https://github.com/r9y9","followers_url":"https://api.github.com/users/r9y9/followers","following_url":"https://api.github.com/users/r9y9/following{/other_user}","gists_url":"https://api.github.com/users/r9y9/gists{/gist_id}","starred_url":"https://api.github.com/users/r9y9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r9y9/subscriptions","organizations_url":"https://api.github.com/users/r9y9/orgs","repos_url":"https://api.github.com/users/r9y9/repos","events_url":"https://api.github.com/users/r9y9/events{/privacy}","received_events_url":"https://api.github.com/users/r9y9/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T07:55:11Z","updated_at":"2018-02-24T07:55:11Z","author_association":"OWNER","body":"This is a method mentioned in the secton 2.2 of the Tacotron2 paper (https://arxiv.org/pdf/1712.05884.pdf) to limit dynamic range of mel-spectrum values.\r\n\r\n> And a small point, should the inverse function not have - 0.01 at the end to compensate for this?\r\n\r\nI think you are right. I forgot to do that, though it's never used in the repository. Will fix this in https://github.com/r9y9/deepvoice3_pytorch, Thanks!"}}
{"actor":{"display_login":"r9y9"}}