{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/165713147","pull_request_review_id":93701295,"id":165713147,"diff_hunk":"@@ -501,42 +529,42 @@ func createScreenGraph(for test: XCTestCase, with app: XCUIApplication) -> MMScr\n         screenState.tap(table.cells[\"ChangePasscode\"], to: ChangePasscodeSettings, if: \"passcode != nil\")\n     }\n \n-    func typePasscode(_ passCode: String) {\n-        passCode.forEach { char in\n+    func type(_ text: String) {","path":"XCUITests/FxScreenGraph.swift","position":62,"original_position":62,"commit_id":"e1e8071f6d3915319ef4cecacb8f1f8bf8c478a6","original_commit_id":"e1e8071f6d3915319ef4cecacb8f1f8bf8c478a6","user":{"login":"jhugman","id":99338,"avatar_url":"https://avatars0.githubusercontent.com/u/99338?v=4","gravatar_id":"","url":"https://api.github.com/users/jhugman","html_url":"https://github.com/jhugman","followers_url":"https://api.github.com/users/jhugman/followers","following_url":"https://api.github.com/users/jhugman/following{/other_user}","gists_url":"https://api.github.com/users/jhugman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhugman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhugman/subscriptions","organizations_url":"https://api.github.com/users/jhugman/orgs","repos_url":"https://api.github.com/users/jhugman/repos","events_url":"https://api.github.com/users/jhugman/events{/privacy}","received_events_url":"https://api.github.com/users/jhugman/received_events","type":"User","site_admin":false},"body":"I had suggested: \r\n```swift\r\nfunc type(text: String) {}\r\n```\r\n\r\nin line with Swift 4's naming conventions. This would mean callers type\r\n\r\n```swift\r\ntype(text: \"\")\r\n```\r\n\r\ninstead of \r\n\r\n\r\n```swift\r\ntype(\"\")\r\n```","created_at":"2018-02-02T17:52:59Z","updated_at":"2018-02-02T17:58:14Z","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3609#discussion_r165713147","pull_request_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/165713147"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/3609#discussion_r165713147"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609","id":166010022,"html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3609","diff_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3609.diff","patch_url":"https://github.com/mozilla-mobile/firefox-ios/pull/3609.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3609","number":3609,"state":"open","locked":false,"title":"Bug 1432468 - New XCUITest FxAccount/Sync UI Tests","user":{"login":"isabelrios","id":1897507,"avatar_url":"https://avatars2.githubusercontent.com/u/1897507?v=4","gravatar_id":"","url":"https://api.github.com/users/isabelrios","html_url":"https://github.com/isabelrios","followers_url":"https://api.github.com/users/isabelrios/followers","following_url":"https://api.github.com/users/isabelrios/following{/other_user}","gists_url":"https://api.github.com/users/isabelrios/gists{/gist_id}","starred_url":"https://api.github.com/users/isabelrios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabelrios/subscriptions","organizations_url":"https://api.github.com/users/isabelrios/orgs","repos_url":"https://api.github.com/users/isabelrios/repos","events_url":"https://api.github.com/users/isabelrios/events{/privacy}","received_events_url":"https://api.github.com/users/isabelrios/received_events","type":"User","site_admin":false},"body":"This PR is for  adding a few tests to check the User Interface of the Sync option and how it behaves under basic scenarios (not possible to create an E2E scenario due the account creation and confirmation)\r\n\r\n-testUIFromSettings ()\r\n-testPlaceholderValues ()\r\n-testTypeOnGivenFields()\r\n-testCreateAnAccountLink()\r\n-testShowPassword()\r\n\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1432468","created_at":"2018-01-30T15:19:15Z","updated_at":"2018-02-02T17:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97f97849d5579e7f569527a75a1eb5fc5dc3a1ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3609/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/e1e8071f6d3915319ef4cecacb8f1f8bf8c478a6","head":{"label":"mozilla-mobile:isabelrios/Bug1432468-NewXCUITestFxASyncUITests","ref":"isabelrios/Bug1432468-NewXCUITestFxASyncUITests","sha":"e1e8071f6d3915319ef4cecacb8f1f8bf8c478a6","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2018-02-02T17:35:06Z","pushed_at":"2018-02-02T17:52:47Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":567773,"stargazers_count":7797,"watchers_count":7797,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1702,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1702,"open_issues":52,"watchers":7797,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"4cd9bcda706d743c87b569ac5bf4160e7482895d","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2018-02-02T17:35:06Z","pushed_at":"2018-02-02T17:52:47Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":567773,"stargazers_count":7797,"watchers_count":7797,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1702,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1702,"open_issues":52,"watchers":7797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/3609"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3609"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/3609/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/3609/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/e1e8071f6d3915319ef4cecacb8f1f8bf8c478a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhugman"}}