{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/207385887","pull_request_review_id":142990394,"id":207385887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzM4NTg4Nw==","diff_hunk":"@@ -353,6 +353,21 @@ protected void assertSlicePosition(Block block, int position, Slice expectedSlic\n         }\n     }\n \n+    protected static void assertEstimatedDataSizeForStats(BlockBuilder blockBuilder, Slice[] expectedSliceValues)","path":"presto-main/src/test/java/com/facebook/presto/block/AbstractTestBlock.java","position":4,"original_position":4,"commit_id":"b48e185080dda5ad4c68b60141e6ab183858c187","original_commit_id":"963251efdc45d76de60b3e1190b20baf9a5c3e81","user":{"login":"wenleix","id":799346,"node_id":"MDQ6VXNlcjc5OTM0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/799346?v=4","gravatar_id":"","url":"https://api.github.com/users/wenleix","html_url":"https://github.com/wenleix","followers_url":"https://api.github.com/users/wenleix/followers","following_url":"https://api.github.com/users/wenleix/following{/other_user}","gists_url":"https://api.github.com/users/wenleix/gists{/gist_id}","starred_url":"https://api.github.com/users/wenleix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenleix/subscriptions","organizations_url":"https://api.github.com/users/wenleix/orgs","repos_url":"https://api.github.com/users/wenleix/repos","events_url":"https://api.github.com/users/wenleix/events{/privacy}","received_events_url":"https://api.github.com/users/wenleix/received_events","type":"User","site_admin":false},"body":"Move this method to the end of the class. \r\n\r\n","created_at":"2018-08-02T21:50:04Z","updated_at":"2018-08-02T21:53:28Z","html_url":"https://github.com/prestodb/presto/pull/11150#discussion_r207385887","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/11150","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/207385887"},"html":{"href":"https://github.com/prestodb/presto/pull/11150#discussion_r207385887"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11150"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/11150","id":204507897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTA3ODk3","html_url":"https://github.com/prestodb/presto/pull/11150","diff_url":"https://github.com/prestodb/presto/pull/11150.diff","patch_url":"https://github.com/prestodb/presto/pull/11150.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/11150","number":11150,"state":"open","locked":false,"title":"Add internal aggregations over estimated in-memory data size for stats","user":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"body":"These aggregation are needed for `MAX_VALUE_SIZE` and `TOTAL_VALUES_SIZE` statistics computation. The PR that adds this 2 statistics will be opened once the #11054 and the #11107 are merged.","created_at":"2018-07-27T18:33:23Z","updated_at":"2018-08-02T21:53:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1a8cd30fc824317ea82c900809ab4fbfc18f721","assignee":{"login":"haozhun","id":2020503,"node_id":"MDQ6VXNlcjIwMjA1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2020503?v=4","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"assignees":[{"login":"haozhun","id":2020503,"node_id":"MDQ6VXNlcjIwMjA1MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2020503?v=4","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"findepi","id":144328,"node_id":"MDQ6VXNlcjE0NDMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/11150/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/11150/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/11150/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/b48e185080dda5ad4c68b60141e6ab183858c187","head":{"label":"arhimondr:data-size-aggregations","ref":"data-size-aggregations","sha":"b48e185080dda5ad4c68b60141e6ab183858c187","user":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"repo":{"id":37681604,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY4MTYwNA==","name":"presto","full_name":"arhimondr/presto","owner":{"login":"arhimondr","id":5570988,"node_id":"MDQ6VXNlcjU1NzA5ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5570988?v=4","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arhimondr/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/arhimondr/presto","forks_url":"https://api.github.com/repos/arhimondr/presto/forks","keys_url":"https://api.github.com/repos/arhimondr/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arhimondr/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arhimondr/presto/teams","hooks_url":"https://api.github.com/repos/arhimondr/presto/hooks","issue_events_url":"https://api.github.com/repos/arhimondr/presto/issues/events{/number}","events_url":"https://api.github.com/repos/arhimondr/presto/events","assignees_url":"https://api.github.com/repos/arhimondr/presto/assignees{/user}","branches_url":"https://api.github.com/repos/arhimondr/presto/branches{/branch}","tags_url":"https://api.github.com/repos/arhimondr/presto/tags","blobs_url":"https://api.github.com/repos/arhimondr/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arhimondr/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arhimondr/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/arhimondr/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arhimondr/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/arhimondr/presto/languages","stargazers_url":"https://api.github.com/repos/arhimondr/presto/stargazers","contributors_url":"https://api.github.com/repos/arhimondr/presto/contributors","subscribers_url":"https://api.github.com/repos/arhimondr/presto/subscribers","subscription_url":"https://api.github.com/repos/arhimondr/presto/subscription","commits_url":"https://api.github.com/repos/arhimondr/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/arhimondr/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/arhimondr/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/arhimondr/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/arhimondr/presto/contents/{+path}","compare_url":"https://api.github.com/repos/arhimondr/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arhimondr/presto/merges","archive_url":"https://api.github.com/repos/arhimondr/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arhimondr/presto/downloads","issues_url":"https://api.github.com/repos/arhimondr/presto/issues{/number}","pulls_url":"https://api.github.com/repos/arhimondr/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/arhimondr/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/arhimondr/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arhimondr/presto/labels{/name}","releases_url":"https://api.github.com/repos/arhimondr/presto/releases{/id}","deployments_url":"https://api.github.com/repos/arhimondr/presto/deployments","created_at":"2015-06-18T19:57:44Z","updated_at":"2016-03-18T00:24:50Z","pushed_at":"2018-08-02T18:36:30Z","git_url":"git://github.com/arhimondr/presto.git","ssh_url":"git@github.com:arhimondr/presto.git","clone_url":"https://github.com/arhimondr/presto.git","svn_url":"https://github.com/arhimondr/presto","homepage":"https://prestodb.io","size":95258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"0284f2538b6101733928f9c20c9348f9f9eb597b","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-08-02T21:34:45Z","pushed_at":"2018-08-02T21:49:45Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":95613,"stargazers_count":7853,"watchers_count":7853,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2673,"mirror_url":null,"archived":false,"open_issues_count":1331,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2673,"open_issues":1331,"watchers":7853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11150"},"html":{"href":"https://github.com/prestodb/presto/pull/11150"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/11150"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/11150/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11150/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/11150/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/b48e185080dda5ad4c68b60141e6ab183858c187"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wenleix"}}