{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/2815","repository_url":"https://api.github.com/repos/dcos/dcos-ui","labels_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2815/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2815/comments","events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2815/events","html_url":"https://github.com/dcos/dcos-ui/pull/2815","id":303443827,"number":2815,"title":"refactor(githooks): move and improve post-checkout checks into validate-engines","user":{"login":"juliangieseke","id":530632,"avatar_url":"https://avatars2.githubusercontent.com/u/530632?v=4","gravatar_id":"","url":"https://api.github.com/users/juliangieseke","html_url":"https://github.com/juliangieseke","followers_url":"https://api.github.com/users/juliangieseke/followers","following_url":"https://api.github.com/users/juliangieseke/following{/other_user}","gists_url":"https://api.github.com/users/juliangieseke/gists{/gist_id}","starred_url":"https://api.github.com/users/juliangieseke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliangieseke/subscriptions","organizations_url":"https://api.github.com/users/juliangieseke/orgs","repos_url":"https://api.github.com/users/juliangieseke/repos","events_url":"https://api.github.com/users/juliangieseke/events{/privacy}","received_events_url":"https://api.github.com/users/juliangieseke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-08T11:14:52Z","updated_at":"2018-03-14T23:41:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/2815","html_url":"https://github.com/dcos/dcos-ui/pull/2815","diff_url":"https://github.com/dcos/dcos-ui/pull/2815.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/2815.patch"},"body":"the current version of this check complains about node version 9.x being incorrect (it needs 8.9.4). this fixes this issue and also moves the checks into our validate-engines script.\r\n\r\nto test this, please checkout this branch with latest node version (should NOT complain), then downgrade node to v4 and try `npm start` (should complain)"},"comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments/373211203","html_url":"https://github.com/dcos/dcos-ui/pull/2815#issuecomment-373211203","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/2815","id":373211203,"user":{"login":"ahoskins","id":1527504,"avatar_url":"https://avatars3.githubusercontent.com/u/1527504?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoskins","html_url":"https://github.com/ahoskins","followers_url":"https://api.github.com/users/ahoskins/followers","following_url":"https://api.github.com/users/ahoskins/following{/other_user}","gists_url":"https://api.github.com/users/ahoskins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoskins/subscriptions","organizations_url":"https://api.github.com/users/ahoskins/orgs","repos_url":"https://api.github.com/users/ahoskins/repos","events_url":"https://api.github.com/users/ahoskins/events{/privacy}","received_events_url":"https://api.github.com/users/ahoskins/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T23:41:20Z","updated_at":"2018-03-14T23:41:20Z","author_association":"MEMBER","body":"It's interesting what's happening here. So I switch my global node 4.4 successfully. Then if you notice, my PATH doesn't include node_modules/bin. But then, when invoking the script, it appends .node_modules/bin to my path, causing it to use the correct node version in the script. \r\n\r\n![image 2018-03-14 at 4 37 54 pm](https://user-images.githubusercontent.com/1527504/37436672-3fe351a6-27a6-11e8-9e6c-6683d1c4844d.png)\r\n"}}
{"actor":{"display_login":"ahoskins"}}