{"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments/239519812","pull_request_review_id":182326316,"id":239519812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUxOTgxMg==","diff_hunk":"@@ -0,0 +1,101 @@\n+/*\n+ * Copyright 2018, TeamDev. All rights reserved.\n+ *\n+ * Redistribution and use in source and/or binary forms, with or without\n+ * modification, must retain the above copyright notice and the following\n+ * disclaimer.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+package io.spine.server.entity;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import com.google.protobuf.Message;\n+import com.google.protobuf.Message.Builder;\n+import io.spine.annotation.Internal;\n+import io.spine.core.EventEnvelope;\n+import io.spine.core.Version;\n+import io.spine.server.event.EventDispatch;\n+import io.spine.server.model.Nothing;\n+import io.spine.validate.ValidatingBuilder;\n+\n+/**\n+ * A transaction that supports event {@linkplain EventPlayer playing}.\n+ *\n+ * <p>Event playing is a process of applying the events to the certain entity with no expected","path":"server/src/main/java/io/spine/server/entity/EventPlayingTransaction.java","position":36,"original_position":36,"commit_id":"2540a82e19bf46db4a115bf8d3a8e44b98466db9","original_commit_id":"2540a82e19bf46db4a115bf8d3a8e44b98466db9","user":{"login":"armiol","id":82468,"node_id":"MDQ6VXNlcjgyNDY4","avatar_url":"https://avatars0.githubusercontent.com/u/82468?v=4","gravatar_id":"","url":"https://api.github.com/users/armiol","html_url":"https://github.com/armiol","followers_url":"https://api.github.com/users/armiol/followers","following_url":"https://api.github.com/users/armiol/following{/other_user}","gists_url":"https://api.github.com/users/armiol/gists{/gist_id}","starred_url":"https://api.github.com/users/armiol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armiol/subscriptions","organizations_url":"https://api.github.com/users/armiol/orgs","repos_url":"https://api.github.com/users/armiol/repos","events_url":"https://api.github.com/users/armiol/events{/privacy}","received_events_url":"https://api.github.com/users/armiol/received_events","type":"User","site_admin":false},"body":"Let's remove this sentence. It's clear from the referenced `EventPlayer`.","created_at":"2018-12-06T16:27:16Z","updated_at":"2018-12-06T16:55:44Z","html_url":"https://github.com/SpineEventEngine/core-java/pull/893#discussion_r239519812","pull_request_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments/239519812"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/893#discussion_r239519812"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893","id":234297332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Mjk3MzMy","html_url":"https://github.com/SpineEventEngine/core-java/pull/893","diff_url":"https://github.com/SpineEventEngine/core-java/pull/893.diff","patch_url":"https://github.com/SpineEventEngine/core-java/pull/893.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/893","number":893,"state":"open","locked":false,"title":"Add version update for `ProcessManager` instances","user":{"login":"dmitrykuzmin","id":5636313,"node_id":"MDQ6VXNlcjU2MzYzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5636313?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrykuzmin","html_url":"https://github.com/dmitrykuzmin","followers_url":"https://api.github.com/users/dmitrykuzmin/followers","following_url":"https://api.github.com/users/dmitrykuzmin/following{/other_user}","gists_url":"https://api.github.com/users/dmitrykuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrykuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrykuzmin/subscriptions","organizations_url":"https://api.github.com/users/dmitrykuzmin/orgs","repos_url":"https://api.github.com/users/dmitrykuzmin/repos","events_url":"https://api.github.com/users/dmitrykuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrykuzmin/received_events","type":"User","site_admin":false},"body":"This PR handles issue #880.\r\n\r\nPreviously, the entity versioning didn't work for the `ProcessManager` implementations.\r\n\r\nNow, the version of the `ProcessManager` is incremented by one upon any command or event dispatched to it (as process managers can update their state in command handlers, unlike aggregates).\r\n\r\nThe other side of the changes is that now `ProcessManager` state must be consistent with the model requirements upon handling any command. \r\n\r\nFor instance, if the `QuizProcman` receives a command `PmStartQuiz`, and the `id` field of procman is required, the handler method should set the ID from the command right away and not wait until `PmQuizStarted` event.\r\n\r\nThis is done because the version update requires the entity state to be valid.","created_at":"2018-11-28T14:30:53Z","updated_at":"2018-12-06T16:55:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d20c44b2e3c94ec12a5a0e1567f1c0cc5eb3130d","assignee":{"login":"dmitrykuzmin","id":5636313,"node_id":"MDQ6VXNlcjU2MzYzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5636313?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrykuzmin","html_url":"https://github.com/dmitrykuzmin","followers_url":"https://api.github.com/users/dmitrykuzmin/followers","following_url":"https://api.github.com/users/dmitrykuzmin/following{/other_user}","gists_url":"https://api.github.com/users/dmitrykuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrykuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrykuzmin/subscriptions","organizations_url":"https://api.github.com/users/dmitrykuzmin/orgs","repos_url":"https://api.github.com/users/dmitrykuzmin/repos","events_url":"https://api.github.com/users/dmitrykuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrykuzmin/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmitrykuzmin","id":5636313,"node_id":"MDQ6VXNlcjU2MzYzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5636313?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrykuzmin","html_url":"https://github.com/dmitrykuzmin","followers_url":"https://api.github.com/users/dmitrykuzmin/followers","following_url":"https://api.github.com/users/dmitrykuzmin/following{/other_user}","gists_url":"https://api.github.com/users/dmitrykuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrykuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrykuzmin/subscriptions","organizations_url":"https://api.github.com/users/dmitrykuzmin/orgs","repos_url":"https://api.github.com/users/dmitrykuzmin/repos","events_url":"https://api.github.com/users/dmitrykuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrykuzmin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/893/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/2540a82e19bf46db4a115bf8d3a8e44b98466db9","head":{"label":"SpineEventEngine:update-procman-version","ref":"update-procman-version","sha":"2540a82e19bf46db4a115bf8d3a8e44b98466db9","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"node_id":"MDEwOlJlcG9zaXRvcnkzODMxMTkwNg==","name":"core-java","full_name":"SpineEventEngine/core-java","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2018-12-05T20:34:55Z","pushed_at":"2018-12-06T16:00:23Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"git@github.com:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":105672,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":107,"watchers":12,"default_branch":"master"}},"base":{"label":"SpineEventEngine:master","ref":"master","sha":"3d99f6fde3644fb808f079becc3d9012af364825","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":38311906,"node_id":"MDEwOlJlcG9zaXRvcnkzODMxMTkwNg==","name":"core-java","full_name":"SpineEventEngine/core-java","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/core-java","description":"The Java implementation of the framework core.","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/core-java","forks_url":"https://api.github.com/repos/SpineEventEngine/core-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/core-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/core-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/core-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/core-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/core-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/core-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/core-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/core-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/core-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/core-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/core-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/core-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/core-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/core-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/core-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/core-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/core-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/core-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/core-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/core-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/core-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/core-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/core-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/core-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/core-java/deployments","created_at":"2015-06-30T13:50:58Z","updated_at":"2018-12-05T20:34:55Z","pushed_at":"2018-12-06T16:00:23Z","git_url":"git://github.com/SpineEventEngine/core-java.git","ssh_url":"git@github.com:SpineEventEngine/core-java.git","clone_url":"https://github.com/SpineEventEngine/core-java.git","svn_url":"https://github.com/SpineEventEngine/core-java","homepage":null,"size":105672,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":107,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893"},"html":{"href":"https://github.com/SpineEventEngine/core-java/pull/893"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/893"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/core-java/statuses/2540a82e19bf46db4a115bf8d3a8e44b98466db9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"armiol"}}