{"action":"closed","number":1304,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1304","id":228685726,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Njg1NzI2","html_url":"https://github.com/ArkEcosystem/core/pull/1304","diff_url":"https://github.com/ArkEcosystem/core/pull/1304.diff","patch_url":"https://github.com/ArkEcosystem/core/pull/1304.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1304","number":1304,"state":"closed","locked":false,"title":"refactor: add additional checks for transactions types","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\n\r\n#1301 introduces validity checks for transactions in the transaction pool, which currently invalidate second signature and delegate registration transactions. This PR adds methods to check if there are pending transactions of the afore mentioned types already, which can be used in the `switch/case` statement used in #1301.\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/developers/guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n<!--\r\n\r\n## Further comments\r\n\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n","created_at":"2018-11-06T13:09:46Z","updated_at":"2018-11-06T13:49:15Z","closed_at":"2018-11-06T13:49:15Z","merged_at":"2018-11-06T13:49:15Z","merge_commit_sha":"228867a1aad9566451ef4e1d02baa72492644c3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1304/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1304/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1304/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/34da260331d2c7d7a159d0ceed4284eeb7f401cb","head":{"label":"dated:transaction-checks","ref":"transaction-checks","sha":"34da260331d2c7d7a159d0ceed4284eeb7f401cb","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"repo":{"id":146429094,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0MjkwOTQ=","name":"core","full_name":"dated/core","private":false,"owner":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dated/core","description":"The Ark Blockchain :fireworks:","fork":true,"url":"https://api.github.com/repos/dated/core","forks_url":"https://api.github.com/repos/dated/core/forks","keys_url":"https://api.github.com/repos/dated/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dated/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dated/core/teams","hooks_url":"https://api.github.com/repos/dated/core/hooks","issue_events_url":"https://api.github.com/repos/dated/core/issues/events{/number}","events_url":"https://api.github.com/repos/dated/core/events","assignees_url":"https://api.github.com/repos/dated/core/assignees{/user}","branches_url":"https://api.github.com/repos/dated/core/branches{/branch}","tags_url":"https://api.github.com/repos/dated/core/tags","blobs_url":"https://api.github.com/repos/dated/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dated/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dated/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dated/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dated/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dated/core/languages","stargazers_url":"https://api.github.com/repos/dated/core/stargazers","contributors_url":"https://api.github.com/repos/dated/core/contributors","subscribers_url":"https://api.github.com/repos/dated/core/subscribers","subscription_url":"https://api.github.com/repos/dated/core/subscription","commits_url":"https://api.github.com/repos/dated/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dated/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dated/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dated/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dated/core/contents/{+path}","compare_url":"https://api.github.com/repos/dated/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dated/core/merges","archive_url":"https://api.github.com/repos/dated/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dated/core/downloads","issues_url":"https://api.github.com/repos/dated/core/issues{/number}","pulls_url":"https://api.github.com/repos/dated/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dated/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dated/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dated/core/labels{/name}","releases_url":"https://api.github.com/repos/dated/core/releases{/id}","deployments_url":"https://api.github.com/repos/dated/core/deployments","created_at":"2018-08-28T10:12:39Z","updated_at":"2018-11-06T12:38:51Z","pushed_at":"2018-11-06T13:31:19Z","git_url":"git://github.com/dated/core.git","ssh_url":"git@github.com:dated/core.git","clone_url":"https://github.com/dated/core.git","svn_url":"https://github.com/dated/core","homepage":"https://ark.io","size":9944,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ArkEcosystem:develop","ref":"develop","sha":"3a864b0389c6ce011023e2bda14eb94703138499","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":111684364,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2ODQzNjQ=","name":"core","full_name":"ArkEcosystem/core","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/core","description":"The Ark Blockchain :fireworks:. Check https://docs.ark.io/guidebook/ for more information.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/core","forks_url":"https://api.github.com/repos/ArkEcosystem/core/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/core/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/core/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/core/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/core/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/core/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/core/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/core/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/core/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/core/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/core/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/core/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/core/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/core/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/core/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/core/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/core/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/core/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/core/deployments","created_at":"2017-11-22T12:57:35Z","updated_at":"2018-11-06T12:24:06Z","pushed_at":"2018-11-06T13:49:14Z","git_url":"git://github.com/ArkEcosystem/core.git","ssh_url":"git@github.com:ArkEcosystem/core.git","clone_url":"https://github.com/ArkEcosystem/core.git","svn_url":"https://github.com/ArkEcosystem/core","homepage":"https://ark.io","size":9893,"stargazers_count":90,"watchers_count":90,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":8,"watchers":90,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1304"},"html":{"href":"https://github.com/ArkEcosystem/core/pull/1304"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/1304"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/1304/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1304/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1304/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/core/statuses/34da260331d2c7d7a159d0ceed4284eeb7f401cb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":70,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"faustbrian"}}