{"action":"created","issue":{"url":"https://api.github.com/repos/pcdshub/hutch-python/issues/159","repository_url":"https://api.github.com/repos/pcdshub/hutch-python","labels_url":"https://api.github.com/repos/pcdshub/hutch-python/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/pcdshub/hutch-python/issues/159/comments","events_url":"https://api.github.com/repos/pcdshub/hutch-python/issues/159/events","html_url":"https://github.com/pcdshub/hutch-python/pull/159","id":376604013,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Nzg1ODYz","number":159,"title":"FIX: Fix tree_namespace","user":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-01T23:03:38Z","updated_at":"2018-11-05T04:35:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pcdshub/hutch-python/pulls/159","html_url":"https://github.com/pcdshub/hutch-python/pull/159","diff_url":"https://github.com/pcdshub/hutch-python/pull/159.diff","patch_url":"https://github.com/pcdshub/hutch-python/pull/159.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nFix a bug in this very dangerous feature... I rewrote `tree_namespace` to prevent objects from disappearing and being overwritten.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nPreviously, you could define something like `daq_repeat` in `beamline.py` and it would end up creating a new tree namespace named `daq` in the main environment, overwriting the real `daq` object. Now, we will graft `daq_repeat` onto the real `daq` object instead of overwriting it.\r\n\r\ncloses #149 \r\ncloses #150 \r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nAdded tests that failed before the change"},"comment":{"url":"https://api.github.com/repos/pcdshub/hutch-python/issues/comments/435752783","html_url":"https://github.com/pcdshub/hutch-python/pull/159#issuecomment-435752783","issue_url":"https://api.github.com/repos/pcdshub/hutch-python/issues/159","id":435752783,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTc1Mjc4Mw==","user":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T04:35:31Z","updated_at":"2018-11-05T04:35:31Z","author_association":"CONTRIBUTOR","body":"1. Agreed on less confusion\r\n2. I did some profiling, this PR accidentally speeds up the loading considerably! (factor of 2). But it's still pretty slow (about 3s for XPP). It seems like a lot of time is being wasted by running it on \"everything\". If we can target the \"eligible\" objects in an efficient way it should drop to negligible time spent making the group.\r\n\r\nI'm proposing the following groups, based on existing PVs:\r\nfee, amo, sxr, hx2, xpp, hxx, pbt, xrt, xcs, cxi, mfx, mec, las\r\n\r\nAnything obvious I missed?"}}
{"actor":{"display_login":"ZLLentz"}}