{"action":"created","comment":{"url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments/244385107","pull_request_review_id":188350133,"id":244385107,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDM4NTEwNw==","diff_hunk":"@@ -59,21 +58,32 @@ public typealias AKMIDICallback = (MIDIByte, MIDIByte, MIDIByte) -> Void\n         didSet {\n             do {\n                 try updateSessionCategoryAndOptions()\n-                output?.connect(to: finalMixer)\n-                engine.connect(finalMixer.avAudioNode, to: engine.outputNode)\n \n-                } catch {\n+                // if the assigned output is already a mixer, avoid creating an additional mixer and just use\n+                // that input as the finalMixer\n+                if let mixerInput = output as? AKMixer {\n+                    finalMixer = mixerInput\n+                } else {\n+                    // otherwise at this point create the finalMixer and add the input to it\n+                    let mixer = AKMixer()\n+                    output?.connect(to: mixer)\n+                    finalMixer = mixer\n+                }\n+                guard let finalMixer = finalMixer else { return }\n+                engine.connect(finalMixer.avAudioNode, to: engine.outputNode, format: AKSettings.audioFormat)\n+\n+            } catch {\n                 AKLog(\"Could not set output: \\(error)\")\n             }\n         }\n     }\n \n     #if os(macOS)\n-    /// Enumerate the list of available devices.\n-    @objc public static var devices: [AKDevice]? {\n-        EZAudioUtilities.setShouldExitOnCheckResultFail(false)\n-        return EZAudioDevice.devices().map { AKDevice(ezAudioDevice: $0 as! EZAudioDevice) }\n-    }\n+        /// Enumerate the list of available devices.\n+        @objc public static var devices: [AKDevice]? {\n+            EZAudioUtilities.setShouldExitOnCheckResultFail(false)\n+            return EZAudioDevice.devices().map { AKDevice(ezAudioDevice: $0 as! EZAudioDevice) }","path":"AudioKit/Common/Internals/AudioKit.swift","position":90,"original_position":90,"commit_id":"e775786402a51d39d611573e78ffac512a3f0d9e","original_commit_id":"e775786402a51d39d611573e78ffac512a3f0d9e","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Force Cast Violation: Force casts should be avoided. (force_cast)","created_at":"2018-12-28T18:56:31Z","updated_at":"2018-12-28T18:56:31Z","html_url":"https://github.com/AudioKit/AudioKit/pull/1618#discussion_r244385107","pull_request_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments/244385107"},"html":{"href":"https://github.com/AudioKit/AudioKit/pull/1618#discussion_r244385107"},"pull_request":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618"}}},"pull_request":{"url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618","id":241380260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzgwMjYw","html_url":"https://github.com/AudioKit/AudioKit/pull/1618","diff_url":"https://github.com/AudioKit/AudioKit/pull/1618.diff","patch_url":"https://github.com/AudioKit/AudioKit/pull/1618.patch","issue_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/1618","number":1618,"state":"open","locked":false,"title":"AKPlayer.pauseTime, and AudioKit.output -> finalMixer","user":{"login":"ryanfrancesconi","id":2917795,"node_id":"MDQ6VXNlcjI5MTc3OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2917795?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanfrancesconi","html_url":"https://github.com/ryanfrancesconi","followers_url":"https://api.github.com/users/ryanfrancesconi/followers","following_url":"https://api.github.com/users/ryanfrancesconi/following{/other_user}","gists_url":"https://api.github.com/users/ryanfrancesconi/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanfrancesconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanfrancesconi/subscriptions","organizations_url":"https://api.github.com/users/ryanfrancesconi/orgs","repos_url":"https://api.github.com/users/ryanfrancesconi/repos","events_url":"https://api.github.com/users/ryanfrancesconi/events{/privacy}","received_events_url":"https://api.github.com/users/ryanfrancesconi/received_events","type":"User","site_admin":false},"body":"This PR is mainly for the pause bug in AKPlayer. I've also included recent changes I made to AudioKit.output. This may be debatable from certain perspectives, or not. Please look at the alteration of AudioKit.finalMixer?\r\n","created_at":"2018-12-28T18:56:25Z","updated_at":"2018-12-28T18:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d64308c9361aebbc6ce65ed9019aa988b71cd83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618/commits","review_comments_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618/comments","review_comment_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/1618/comments","statuses_url":"https://api.github.com/repos/AudioKit/AudioKit/statuses/e775786402a51d39d611573e78ffac512a3f0d9e","head":{"label":"ryanfrancesconi:develop","ref":"develop","sha":"e775786402a51d39d611573e78ffac512a3f0d9e","user":{"login":"ryanfrancesconi","id":2917795,"node_id":"MDQ6VXNlcjI5MTc3OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2917795?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanfrancesconi","html_url":"https://github.com/ryanfrancesconi","followers_url":"https://api.github.com/users/ryanfrancesconi/followers","following_url":"https://api.github.com/users/ryanfrancesconi/following{/other_user}","gists_url":"https://api.github.com/users/ryanfrancesconi/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanfrancesconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanfrancesconi/subscriptions","organizations_url":"https://api.github.com/users/ryanfrancesconi/orgs","repos_url":"https://api.github.com/users/ryanfrancesconi/repos","events_url":"https://api.github.com/users/ryanfrancesconi/events{/privacy}","received_events_url":"https://api.github.com/users/ryanfrancesconi/received_events","type":"User","site_admin":false},"repo":{"id":119120304,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMjAzMDQ=","name":"AudioKit","full_name":"ryanfrancesconi/AudioKit","private":false,"owner":{"login":"ryanfrancesconi","id":2917795,"node_id":"MDQ6VXNlcjI5MTc3OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2917795?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanfrancesconi","html_url":"https://github.com/ryanfrancesconi","followers_url":"https://api.github.com/users/ryanfrancesconi/followers","following_url":"https://api.github.com/users/ryanfrancesconi/following{/other_user}","gists_url":"https://api.github.com/users/ryanfrancesconi/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanfrancesconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanfrancesconi/subscriptions","organizations_url":"https://api.github.com/users/ryanfrancesconi/orgs","repos_url":"https://api.github.com/users/ryanfrancesconi/repos","events_url":"https://api.github.com/users/ryanfrancesconi/events{/privacy}","received_events_url":"https://api.github.com/users/ryanfrancesconi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ryanfrancesconi/AudioKit","description":"Swift audio synthesis, processing, & analysis platform for iOS, macOS and tvOS","fork":true,"url":"https://api.github.com/repos/ryanfrancesconi/AudioKit","forks_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/forks","keys_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/teams","hooks_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/events","assignees_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/tags","blobs_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/languages","stargazers_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/subscription","commits_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/merges","archive_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/downloads","issues_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/ryanfrancesconi/AudioKit/deployments","created_at":"2018-01-27T01:08:15Z","updated_at":"2018-01-27T01:08:21Z","pushed_at":"2018-12-28T18:54:21Z","git_url":"git://github.com/ryanfrancesconi/AudioKit.git","ssh_url":"git@github.com:ryanfrancesconi/AudioKit.git","clone_url":"https://github.com/ryanfrancesconi/AudioKit.git","svn_url":"https://github.com/ryanfrancesconi/AudioKit","homepage":"http://audiokit.io/","size":217575,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AudioKit:develop","ref":"develop","sha":"676fb777b219541a5c3f0d2dd73bfb52c2a4ad22","user":{"login":"AudioKit","id":6593633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1OTM2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6593633?v=4","gravatar_id":"","url":"https://api.github.com/users/AudioKit","html_url":"https://github.com/AudioKit","followers_url":"https://api.github.com/users/AudioKit/followers","following_url":"https://api.github.com/users/AudioKit/following{/other_user}","gists_url":"https://api.github.com/users/AudioKit/gists{/gist_id}","starred_url":"https://api.github.com/users/AudioKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudioKit/subscriptions","organizations_url":"https://api.github.com/users/AudioKit/orgs","repos_url":"https://api.github.com/users/AudioKit/repos","events_url":"https://api.github.com/users/AudioKit/events{/privacy}","received_events_url":"https://api.github.com/users/AudioKit/received_events","type":"Organization","site_admin":false},"repo":{"id":16096528,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5NjUyOA==","name":"AudioKit","full_name":"AudioKit/AudioKit","private":false,"owner":{"login":"AudioKit","id":6593633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1OTM2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6593633?v=4","gravatar_id":"","url":"https://api.github.com/users/AudioKit","html_url":"https://github.com/AudioKit","followers_url":"https://api.github.com/users/AudioKit/followers","following_url":"https://api.github.com/users/AudioKit/following{/other_user}","gists_url":"https://api.github.com/users/AudioKit/gists{/gist_id}","starred_url":"https://api.github.com/users/AudioKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudioKit/subscriptions","organizations_url":"https://api.github.com/users/AudioKit/orgs","repos_url":"https://api.github.com/users/AudioKit/repos","events_url":"https://api.github.com/users/AudioKit/events{/privacy}","received_events_url":"https://api.github.com/users/AudioKit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AudioKit/AudioKit","description":"Swift audio synthesis, processing, & analysis platform for iOS, macOS and tvOS","fork":false,"url":"https://api.github.com/repos/AudioKit/AudioKit","forks_url":"https://api.github.com/repos/AudioKit/AudioKit/forks","keys_url":"https://api.github.com/repos/AudioKit/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AudioKit/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AudioKit/AudioKit/teams","hooks_url":"https://api.github.com/repos/AudioKit/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/AudioKit/AudioKit/events","assignees_url":"https://api.github.com/repos/AudioKit/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/AudioKit/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/AudioKit/AudioKit/tags","blobs_url":"https://api.github.com/repos/AudioKit/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AudioKit/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AudioKit/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/AudioKit/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AudioKit/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/AudioKit/AudioKit/languages","stargazers_url":"https://api.github.com/repos/AudioKit/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/AudioKit/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/AudioKit/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/AudioKit/AudioKit/subscription","commits_url":"https://api.github.com/repos/AudioKit/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/AudioKit/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/AudioKit/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/AudioKit/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/AudioKit/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/AudioKit/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AudioKit/AudioKit/merges","archive_url":"https://api.github.com/repos/AudioKit/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AudioKit/AudioKit/downloads","issues_url":"https://api.github.com/repos/AudioKit/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/AudioKit/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/AudioKit/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/AudioKit/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AudioKit/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/AudioKit/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/AudioKit/AudioKit/deployments","created_at":"2014-01-21T08:16:07Z","updated_at":"2018-12-28T12:23:35Z","pushed_at":"2018-12-28T18:56:25Z","git_url":"git://github.com/AudioKit/AudioKit.git","ssh_url":"git@github.com:AudioKit/AudioKit.git","clone_url":"https://github.com/AudioKit/AudioKit.git","svn_url":"https://github.com/AudioKit/AudioKit","homepage":"http://audiokit.io/","size":219214,"stargazers_count":6175,"watchers_count":6175,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":937,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":937,"open_issues":16,"watchers":6175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618"},"html":{"href":"https://github.com/AudioKit/AudioKit/pull/1618"},"issue":{"href":"https://api.github.com/repos/AudioKit/AudioKit/issues/1618"},"comments":{"href":"https://api.github.com/repos/AudioKit/AudioKit/issues/1618/comments"},"review_comments":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618/comments"},"review_comment":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AudioKit/AudioKit/pulls/1618/commits"},"statuses":{"href":"https://api.github.com/repos/AudioKit/AudioKit/statuses/e775786402a51d39d611573e78ffac512a3f0d9e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}