{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/comments/192812370","pull_request_review_id":125660396,"id":192812370,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjgxMjM3MA==","diff_hunk":"@@ -48,42 +57,72 @@ public override void SetProperties(ModifierProperties properties)\n \t\t\t_options = (SpawnPrefabOptions)properties;\n \t\t}\n \n+\t\tpublic override void FeaturePreProcess(VectorFeatureUnity feature)\n+\t\t{\n+\t\t\tint index = -1;\n+\t\t\tforeach (var point in _prefabLocations)\n+\t\t\t{\n+\t\t\t\ttry\n+\t\t\t\t{\n+\t\t\t\t\tindex++;\n+\t\t\t\t\tvar coord = Conversions.StringToLatLon(point);\n+\t\t\t\t\tif (feature.ContainsLatLon(coord))\n+\t\t\t\t\t{\n+\t\t\t\t\t\tif (feature.Data.Id != 0)\n+\t\t\t\t\t\t{\n+\t\t\t\t\t\t\tif (_featureId[index] == null)\n+\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t_featureId[index] = new List<string>();\n+\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t_tempFeatureId = feature.Data.Id.ToString();\n+\t\t\t\t\t\t\t_featureId[index].Add(_tempFeatureId.Substring(0, _tempFeatureId.Length - 3));","path":"sdkproject/Assets/Mapbox/Unity/MeshGeneration/Modifiers/MeshModifiers/ReplaceFeatureModifier.cs","position":50,"original_position":50,"commit_id":"1f1edb0afb51ed17a7d67e21898dde3e0732d817","original_commit_id":"1f1edb0afb51ed17a7d67e21898dde3e0732d817","user":{"login":"morgane","id":104024,"node_id":"MDQ6VXNlcjEwNDAyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/104024?v=4","gravatar_id":"","url":"https://api.github.com/users/morgane","html_url":"https://github.com/morgane","followers_url":"https://api.github.com/users/morgane/followers","following_url":"https://api.github.com/users/morgane/following{/other_user}","gists_url":"https://api.github.com/users/morgane/gists{/gist_id}","starred_url":"https://api.github.com/users/morgane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgane/subscriptions","organizations_url":"https://api.github.com/users/morgane/orgs","repos_url":"https://api.github.com/users/morgane/repos","events_url":"https://api.github.com/users/morgane/events{/privacy}","received_events_url":"https://api.github.com/users/morgane/received_events","type":"User","site_admin":false},"body":"Why `- 3`?","created_at":"2018-06-04T16:58:50Z","updated_at":"2018-06-04T16:58:50Z","html_url":"https://github.com/mapbox/mapbox-unity-sdk/pull/836#discussion_r192812370","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/comments/192812370"},"html":{"href":"https://github.com/mapbox/mapbox-unity-sdk/pull/836#discussion_r192812370"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836","id":192306424,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzA2NDI0","html_url":"https://github.com/mapbox/mapbox-unity-sdk/pull/836","diff_url":"https://github.com/mapbox/mapbox-unity-sdk/pull/836.diff","patch_url":"https://github.com/mapbox/mapbox-unity-sdk/pull/836.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/836","number":836,"state":"open","locked":false,"title":"Feature replacement bugfix","user":{"login":"atripathi-mb","id":32286016,"node_id":"MDQ6VXNlcjMyMjg2MDE2","avatar_url":"https://avatars2.githubusercontent.com/u/32286016?v=4","gravatar_id":"","url":"https://api.github.com/users/atripathi-mb","html_url":"https://github.com/atripathi-mb","followers_url":"https://api.github.com/users/atripathi-mb/followers","following_url":"https://api.github.com/users/atripathi-mb/following{/other_user}","gists_url":"https://api.github.com/users/atripathi-mb/gists{/gist_id}","starred_url":"https://api.github.com/users/atripathi-mb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atripathi-mb/subscriptions","organizations_url":"https://api.github.com/users/atripathi-mb/orgs","repos_url":"https://api.github.com/users/atripathi-mb/repos","events_url":"https://api.github.com/users/atripathi-mb/events{/privacy}","received_events_url":"https://api.github.com/users/atripathi-mb/received_events","type":"User","site_admin":false},"body":"**Related issue**\r\n\r\nFixes feature replacement algorithm dependency on the order in which features were processed. \r\n\r\n**Description of changes**\r\nMoved IReplacement injection to VectorLayerVisualizer. \r\nAdded a preProcess step to feature processing. \r\nAdded utility methods to make code more readable. \r\n\r\n**Reviewers**\r\n\r\n@jim-martin @apavani @brnkhy @morgane \r\n","created_at":"2018-06-04T06:12:10Z","updated_at":"2018-06-04T16:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e18840d8e6f11e64ae4d25c83407c11a8d0f2630","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/836/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/statuses/1f1edb0afb51ed17a7d67e21898dde3e0732d817","head":{"label":"mapbox:feature-replacement-bugfix","ref":"feature-replacement-bugfix","sha":"1f1edb0afb51ed17a7d67e21898dde3e0732d817","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":86383171,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM4MzE3MQ==","name":"mapbox-unity-sdk","full_name":"mapbox/mapbox-unity-sdk","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-unity-sdk","description":"Mapbox Unity SDK - https://www.mapbox.com/unity/","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk","forks_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/deployments","created_at":"2017-03-27T20:55:00Z","updated_at":"2018-06-01T04:24:45Z","pushed_at":"2018-06-04T14:43:21Z","git_url":"git://github.com/mapbox/mapbox-unity-sdk.git","ssh_url":"git@github.com:mapbox/mapbox-unity-sdk.git","clone_url":"https://github.com/mapbox/mapbox-unity-sdk.git","svn_url":"https://github.com/mapbox/mapbox-unity-sdk","homepage":null,"size":431953,"stargazers_count":242,"watchers_count":242,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":66,"open_issues":82,"watchers":242,"default_branch":"develop"}},"base":{"label":"mapbox:release/v1.4.3","ref":"release/v1.4.3","sha":"f1bc0ed573e43cb0a2ea82e0808de8ac5a170318","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":86383171,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM4MzE3MQ==","name":"mapbox-unity-sdk","full_name":"mapbox/mapbox-unity-sdk","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-unity-sdk","description":"Mapbox Unity SDK - https://www.mapbox.com/unity/","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk","forks_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/deployments","created_at":"2017-03-27T20:55:00Z","updated_at":"2018-06-01T04:24:45Z","pushed_at":"2018-06-04T14:43:21Z","git_url":"git://github.com/mapbox/mapbox-unity-sdk.git","ssh_url":"git@github.com:mapbox/mapbox-unity-sdk.git","clone_url":"https://github.com/mapbox/mapbox-unity-sdk.git","svn_url":"https://github.com/mapbox/mapbox-unity-sdk","homepage":null,"size":431953,"stargazers_count":242,"watchers_count":242,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":66,"open_issues":82,"watchers":242,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836"},"html":{"href":"https://github.com/mapbox/mapbox-unity-sdk/pull/836"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/836"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-unity-sdk/statuses/1f1edb0afb51ed17a7d67e21898dde3e0732d817"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"morgane"}}