{"action":"created","comment":{"url":"https://api.github.com/repos/darchr/gem5/pulls/comments/216777553","pull_request_review_id":154295555,"id":216777553,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc3NzU1Mw==","diff_hunk":"@@ -757,6 +870,22 @@ SDCPUThread::populateDependencies(shared_ptr<InflightInst> inst_ptr)\n \n     // END ISA explicit serialization\n \n+    if (static_inst->isNonSpeculative()) {\n+        const shared_ptr<InflightInst> last_inst = *(++inflightInsts.rbegin());\n+\n+\n+        if (!(last_inst->isCommitted() || last_inst->isSquashed()))","path":"src/cpu/flexcpu/simple_dataflow_thread.cc","position":220,"original_position":220,"commit_id":"29d924fb0dd0dc8ba291a7521bc3ada82e2d6e86","original_commit_id":"29d924fb0dd0dc8ba291a7521bc3ada82e2d6e86","user":{"login":"powerjg","id":109596,"node_id":"MDQ6VXNlcjEwOTU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/109596?v=4","gravatar_id":"","url":"https://api.github.com/users/powerjg","html_url":"https://github.com/powerjg","followers_url":"https://api.github.com/users/powerjg/followers","following_url":"https://api.github.com/users/powerjg/following{/other_user}","gists_url":"https://api.github.com/users/powerjg/gists{/gist_id}","starred_url":"https://api.github.com/users/powerjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerjg/subscriptions","organizations_url":"https://api.github.com/users/powerjg/orgs","repos_url":"https://api.github.com/users/powerjg/repos","events_url":"https://api.github.com/users/powerjg/events{/privacy}","received_events_url":"https://api.github.com/users/powerjg/received_events","type":"User","site_admin":false},"body":"(not in this patch) We should factor this out into a named function (e.g., `instCompleted(last_inst)`). I'm not sure what the right name is :). I've just seen this condition written multiple times, so it makes me think it should be a function.","created_at":"2018-09-11T18:40:18Z","updated_at":"2018-09-11T18:46:56Z","html_url":"https://github.com/darchr/gem5/pull/28#discussion_r216777553","pull_request_url":"https://api.github.com/repos/darchr/gem5/pulls/28","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/darchr/gem5/pulls/comments/216777553"},"html":{"href":"https://github.com/darchr/gem5/pull/28#discussion_r216777553"},"pull_request":{"href":"https://api.github.com/repos/darchr/gem5/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/darchr/gem5/pulls/28","id":214697810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Njk3ODEw","html_url":"https://github.com/darchr/gem5/pull/28","diff_url":"https://github.com/darchr/gem5/pull/28.diff","patch_url":"https://github.com/darchr/gem5/pull/28.patch","issue_url":"https://api.github.com/repos/darchr/gem5/issues/28","number":28,"state":"open","locked":false,"title":"temp,flexcpu: Add BP functionality [ci skip]","user":{"login":"powerjg","id":109596,"node_id":"MDQ6VXNlcjEwOTU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/109596?v=4","gravatar_id":"","url":"https://api.github.com/users/powerjg","html_url":"https://github.com/powerjg","followers_url":"https://api.github.com/users/powerjg/followers","following_url":"https://api.github.com/users/powerjg/following{/other_user}","gists_url":"https://api.github.com/users/powerjg/gists{/gist_id}","starred_url":"https://api.github.com/users/powerjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerjg/subscriptions","organizations_url":"https://api.github.com/users/powerjg/orgs","repos_url":"https://api.github.com/users/powerjg/repos","events_url":"https://api.github.com/users/powerjg/events{/privacy}","received_events_url":"https://api.github.com/users/powerjg/received_events","type":"User","site_admin":false},"body":"I know you're not ready for this PR, but I'd like to make some comments on the code.","created_at":"2018-09-11T16:50:02Z","updated_at":"2018-09-11T18:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e2d65eacc28d74c6bfbc59fc9696d2b14cd82e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"animalvgamer","id":1676773,"node_id":"MDQ6VXNlcjE2NzY3NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1676773?v=4","gravatar_id":"","url":"https://api.github.com/users/animalvgamer","html_url":"https://github.com/animalvgamer","followers_url":"https://api.github.com/users/animalvgamer/followers","following_url":"https://api.github.com/users/animalvgamer/following{/other_user}","gists_url":"https://api.github.com/users/animalvgamer/gists{/gist_id}","starred_url":"https://api.github.com/users/animalvgamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/animalvgamer/subscriptions","organizations_url":"https://api.github.com/users/animalvgamer/orgs","repos_url":"https://api.github.com/users/animalvgamer/repos","events_url":"https://api.github.com/users/animalvgamer/events{/privacy}","received_events_url":"https://api.github.com/users/animalvgamer/received_events","type":"User","site_admin":false},{"login":"ayaz91","id":8238145,"node_id":"MDQ6VXNlcjgyMzgxNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8238145?v=4","gravatar_id":"","url":"https://api.github.com/users/ayaz91","html_url":"https://github.com/ayaz91","followers_url":"https://api.github.com/users/ayaz91/followers","following_url":"https://api.github.com/users/ayaz91/following{/other_user}","gists_url":"https://api.github.com/users/ayaz91/gists{/gist_id}","starred_url":"https://api.github.com/users/ayaz91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayaz91/subscriptions","organizations_url":"https://api.github.com/users/ayaz91/orgs","repos_url":"https://api.github.com/users/ayaz91/repos","events_url":"https://api.github.com/users/ayaz91/events{/privacy}","received_events_url":"https://api.github.com/users/ayaz91/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/darchr/gem5/pulls/28/commits","review_comments_url":"https://api.github.com/repos/darchr/gem5/pulls/28/comments","review_comment_url":"https://api.github.com/repos/darchr/gem5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darchr/gem5/issues/28/comments","statuses_url":"https://api.github.com/repos/darchr/gem5/statuses/29d924fb0dd0dc8ba291a7521bc3ada82e2d6e86","head":{"label":"darchr:bradley/flexcpu-bp","ref":"bradley/flexcpu-bp","sha":"29d924fb0dd0dc8ba291a7521bc3ada82e2d6e86","user":{"login":"darchr","id":32246645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ2NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/32246645?v=4","gravatar_id":"","url":"https://api.github.com/users/darchr","html_url":"https://github.com/darchr","followers_url":"https://api.github.com/users/darchr/followers","following_url":"https://api.github.com/users/darchr/following{/other_user}","gists_url":"https://api.github.com/users/darchr/gists{/gist_id}","starred_url":"https://api.github.com/users/darchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darchr/subscriptions","organizations_url":"https://api.github.com/users/darchr/orgs","repos_url":"https://api.github.com/users/darchr/repos","events_url":"https://api.github.com/users/darchr/events{/privacy}","received_events_url":"https://api.github.com/users/darchr/received_events","type":"Organization","site_admin":false},"repo":{"id":105194107,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxOTQxMDc=","name":"gem5","full_name":"darchr/gem5","owner":{"login":"darchr","id":32246645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ2NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/32246645?v=4","gravatar_id":"","url":"https://api.github.com/users/darchr","html_url":"https://github.com/darchr","followers_url":"https://api.github.com/users/darchr/followers","following_url":"https://api.github.com/users/darchr/following{/other_user}","gists_url":"https://api.github.com/users/darchr/gists{/gist_id}","starred_url":"https://api.github.com/users/darchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darchr/subscriptions","organizations_url":"https://api.github.com/users/darchr/orgs","repos_url":"https://api.github.com/users/darchr/repos","events_url":"https://api.github.com/users/darchr/events{/privacy}","received_events_url":"https://api.github.com/users/darchr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darchr/gem5","description":"Fork of main gem5 repo: https://gem5.googlesource.com/public/gem5/","fork":false,"url":"https://api.github.com/repos/darchr/gem5","forks_url":"https://api.github.com/repos/darchr/gem5/forks","keys_url":"https://api.github.com/repos/darchr/gem5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darchr/gem5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darchr/gem5/teams","hooks_url":"https://api.github.com/repos/darchr/gem5/hooks","issue_events_url":"https://api.github.com/repos/darchr/gem5/issues/events{/number}","events_url":"https://api.github.com/repos/darchr/gem5/events","assignees_url":"https://api.github.com/repos/darchr/gem5/assignees{/user}","branches_url":"https://api.github.com/repos/darchr/gem5/branches{/branch}","tags_url":"https://api.github.com/repos/darchr/gem5/tags","blobs_url":"https://api.github.com/repos/darchr/gem5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darchr/gem5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darchr/gem5/git/refs{/sha}","trees_url":"https://api.github.com/repos/darchr/gem5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darchr/gem5/statuses/{sha}","languages_url":"https://api.github.com/repos/darchr/gem5/languages","stargazers_url":"https://api.github.com/repos/darchr/gem5/stargazers","contributors_url":"https://api.github.com/repos/darchr/gem5/contributors","subscribers_url":"https://api.github.com/repos/darchr/gem5/subscribers","subscription_url":"https://api.github.com/repos/darchr/gem5/subscription","commits_url":"https://api.github.com/repos/darchr/gem5/commits{/sha}","git_commits_url":"https://api.github.com/repos/darchr/gem5/git/commits{/sha}","comments_url":"https://api.github.com/repos/darchr/gem5/comments{/number}","issue_comment_url":"https://api.github.com/repos/darchr/gem5/issues/comments{/number}","contents_url":"https://api.github.com/repos/darchr/gem5/contents/{+path}","compare_url":"https://api.github.com/repos/darchr/gem5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darchr/gem5/merges","archive_url":"https://api.github.com/repos/darchr/gem5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darchr/gem5/downloads","issues_url":"https://api.github.com/repos/darchr/gem5/issues{/number}","pulls_url":"https://api.github.com/repos/darchr/gem5/pulls{/number}","milestones_url":"https://api.github.com/repos/darchr/gem5/milestones{/number}","notifications_url":"https://api.github.com/repos/darchr/gem5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darchr/gem5/labels{/name}","releases_url":"https://api.github.com/repos/darchr/gem5/releases{/id}","deployments_url":"https://api.github.com/repos/darchr/gem5/deployments","created_at":"2017-09-28T20:04:58Z","updated_at":"2018-09-06T21:05:46Z","pushed_at":"2018-09-11T16:50:03Z","git_url":"git://github.com/darchr/gem5.git","ssh_url":"git@github.com:darchr/gem5.git","clone_url":"https://github.com/darchr/gem5.git","svn_url":"https://github.com/darchr/gem5","homepage":null,"size":161478,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"darchr:flexcpu","ref":"flexcpu","sha":"03b66341ea80dcb05e33e5e9f79f300509d51bf6","user":{"login":"darchr","id":32246645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ2NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/32246645?v=4","gravatar_id":"","url":"https://api.github.com/users/darchr","html_url":"https://github.com/darchr","followers_url":"https://api.github.com/users/darchr/followers","following_url":"https://api.github.com/users/darchr/following{/other_user}","gists_url":"https://api.github.com/users/darchr/gists{/gist_id}","starred_url":"https://api.github.com/users/darchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darchr/subscriptions","organizations_url":"https://api.github.com/users/darchr/orgs","repos_url":"https://api.github.com/users/darchr/repos","events_url":"https://api.github.com/users/darchr/events{/privacy}","received_events_url":"https://api.github.com/users/darchr/received_events","type":"Organization","site_admin":false},"repo":{"id":105194107,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxOTQxMDc=","name":"gem5","full_name":"darchr/gem5","owner":{"login":"darchr","id":32246645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjQ2NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/32246645?v=4","gravatar_id":"","url":"https://api.github.com/users/darchr","html_url":"https://github.com/darchr","followers_url":"https://api.github.com/users/darchr/followers","following_url":"https://api.github.com/users/darchr/following{/other_user}","gists_url":"https://api.github.com/users/darchr/gists{/gist_id}","starred_url":"https://api.github.com/users/darchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darchr/subscriptions","organizations_url":"https://api.github.com/users/darchr/orgs","repos_url":"https://api.github.com/users/darchr/repos","events_url":"https://api.github.com/users/darchr/events{/privacy}","received_events_url":"https://api.github.com/users/darchr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darchr/gem5","description":"Fork of main gem5 repo: https://gem5.googlesource.com/public/gem5/","fork":false,"url":"https://api.github.com/repos/darchr/gem5","forks_url":"https://api.github.com/repos/darchr/gem5/forks","keys_url":"https://api.github.com/repos/darchr/gem5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darchr/gem5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darchr/gem5/teams","hooks_url":"https://api.github.com/repos/darchr/gem5/hooks","issue_events_url":"https://api.github.com/repos/darchr/gem5/issues/events{/number}","events_url":"https://api.github.com/repos/darchr/gem5/events","assignees_url":"https://api.github.com/repos/darchr/gem5/assignees{/user}","branches_url":"https://api.github.com/repos/darchr/gem5/branches{/branch}","tags_url":"https://api.github.com/repos/darchr/gem5/tags","blobs_url":"https://api.github.com/repos/darchr/gem5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darchr/gem5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darchr/gem5/git/refs{/sha}","trees_url":"https://api.github.com/repos/darchr/gem5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darchr/gem5/statuses/{sha}","languages_url":"https://api.github.com/repos/darchr/gem5/languages","stargazers_url":"https://api.github.com/repos/darchr/gem5/stargazers","contributors_url":"https://api.github.com/repos/darchr/gem5/contributors","subscribers_url":"https://api.github.com/repos/darchr/gem5/subscribers","subscription_url":"https://api.github.com/repos/darchr/gem5/subscription","commits_url":"https://api.github.com/repos/darchr/gem5/commits{/sha}","git_commits_url":"https://api.github.com/repos/darchr/gem5/git/commits{/sha}","comments_url":"https://api.github.com/repos/darchr/gem5/comments{/number}","issue_comment_url":"https://api.github.com/repos/darchr/gem5/issues/comments{/number}","contents_url":"https://api.github.com/repos/darchr/gem5/contents/{+path}","compare_url":"https://api.github.com/repos/darchr/gem5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darchr/gem5/merges","archive_url":"https://api.github.com/repos/darchr/gem5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darchr/gem5/downloads","issues_url":"https://api.github.com/repos/darchr/gem5/issues{/number}","pulls_url":"https://api.github.com/repos/darchr/gem5/pulls{/number}","milestones_url":"https://api.github.com/repos/darchr/gem5/milestones{/number}","notifications_url":"https://api.github.com/repos/darchr/gem5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darchr/gem5/labels{/name}","releases_url":"https://api.github.com/repos/darchr/gem5/releases{/id}","deployments_url":"https://api.github.com/repos/darchr/gem5/deployments","created_at":"2017-09-28T20:04:58Z","updated_at":"2018-09-06T21:05:46Z","pushed_at":"2018-09-11T16:50:03Z","git_url":"git://github.com/darchr/gem5.git","ssh_url":"git@github.com:darchr/gem5.git","clone_url":"https://github.com/darchr/gem5.git","svn_url":"https://github.com/darchr/gem5","homepage":null,"size":161478,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darchr/gem5/pulls/28"},"html":{"href":"https://github.com/darchr/gem5/pull/28"},"issue":{"href":"https://api.github.com/repos/darchr/gem5/issues/28"},"comments":{"href":"https://api.github.com/repos/darchr/gem5/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/darchr/gem5/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/darchr/gem5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darchr/gem5/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/darchr/gem5/statuses/29d924fb0dd0dc8ba291a7521bc3ada82e2d6e86"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"powerjg"}}