{"action":"opened","number":17316,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/17316","id":206509934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTA5OTM0","html_url":"https://github.com/ampproject/amphtml/pull/17316","diff_url":"https://github.com/ampproject/amphtml/pull/17316.diff","patch_url":"https://github.com/ampproject/amphtml/pull/17316.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/17316","number":17316,"state":"open","locked":false,"title":"✅ video-player-* unit tests: don't wait for iframe to fully load","user":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/ampproject/amphtml/issues/17309 \r\n\r\nFor unit tests, there is no need to wait for the `iframe` loading the player to fully load. Waiting causes flakes since the source of `iframe` is external and many factors such as network and server speeds can impact it.\r\n","created_at":"2018-08-06T20:36:57Z","updated_at":"2018-08-06T20:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17316/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/17316/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/17316/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/e805e508f76574bf01acbfb319ffe722a3b4ed60","head":{"label":"aghassemi:videotests","ref":"videotests","sha":"e805e508f76574bf01acbfb319ffe722a3b4ed60","user":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"repo":{"id":62757350,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjc1NzM1MA==","name":"amphtml","full_name":"aghassemi/amphtml","owner":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aghassemi/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/aghassemi/amphtml","forks_url":"https://api.github.com/repos/aghassemi/amphtml/forks","keys_url":"https://api.github.com/repos/aghassemi/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aghassemi/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aghassemi/amphtml/teams","hooks_url":"https://api.github.com/repos/aghassemi/amphtml/hooks","issue_events_url":"https://api.github.com/repos/aghassemi/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/aghassemi/amphtml/events","assignees_url":"https://api.github.com/repos/aghassemi/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/aghassemi/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/aghassemi/amphtml/tags","blobs_url":"https://api.github.com/repos/aghassemi/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aghassemi/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aghassemi/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/aghassemi/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aghassemi/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/aghassemi/amphtml/languages","stargazers_url":"https://api.github.com/repos/aghassemi/amphtml/stargazers","contributors_url":"https://api.github.com/repos/aghassemi/amphtml/contributors","subscribers_url":"https://api.github.com/repos/aghassemi/amphtml/subscribers","subscription_url":"https://api.github.com/repos/aghassemi/amphtml/subscription","commits_url":"https://api.github.com/repos/aghassemi/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/aghassemi/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/aghassemi/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/aghassemi/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/aghassemi/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/aghassemi/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aghassemi/amphtml/merges","archive_url":"https://api.github.com/repos/aghassemi/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aghassemi/amphtml/downloads","issues_url":"https://api.github.com/repos/aghassemi/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/aghassemi/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/aghassemi/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/aghassemi/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aghassemi/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/aghassemi/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/aghassemi/amphtml/deployments","created_at":"2016-07-06T22:26:50Z","updated_at":"2017-04-11T01:59:03Z","pushed_at":"2018-08-06T20:34:57Z","git_url":"git://github.com/aghassemi/amphtml.git","ssh_url":"git@github.com:aghassemi/amphtml.git","clone_url":"https://github.com/aghassemi/amphtml.git","svn_url":"https://github.com/aghassemi/amphtml","homepage":"https://ampproject.org","size":591134,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"ea37aa053ce07621f8f2201fbfda788c7981b792","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-08-06T19:48:07Z","pushed_at":"2018-08-06T20:34:13Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":494577,"stargazers_count":11824,"watchers_count":11824,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2518,"mirror_url":null,"archived":false,"open_issues_count":1314,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2518,"open_issues":1314,"watchers":11824,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17316"},"html":{"href":"https://github.com/ampproject/amphtml/pull/17316"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17316"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/17316/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17316/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/17316/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/e805e508f76574bf01acbfb319ffe722a3b4ed60"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":7,"changed_files":6}}
{"actor":{"display_login":"aghassemi"}}