{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/217764281","pull_request_review_id":155562429,"id":217764281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzc2NDI4MQ==","diff_hunk":"@@ -42,7 +42,8 @@ class Authenticator {\n   // Authenticator factory function.\n   static AuthenticatorPtr create(const ::google::jwt_verify::CheckAudience* check_audience,\n                                  const absl::optional<std::string>& provider, bool allow_failed,\n-                                 JwksCache& jwks_cache, Upstream::ClusterManager& cluster_manager);\n+                                 JwksCache& jwks_cache, Upstream::ClusterManager& cluster_manager,","path":"source/extensions/filters/http/jwt_authn/authenticator.h","position":null,"original_position":15,"commit_id":"4bfe5d6ace2f7e95668eb5a1f5dbcce85b713893","original_commit_id":"4bfe5d6ace2f7e95668eb5a1f5dbcce85b713893","user":{"login":"qiwzhang","id":11790727,"node_id":"MDQ6VXNlcjExNzkwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"do we still need cluster_manager?   I through it is only needed for JwksFetcher.","created_at":"2018-09-14T16:07:44Z","updated_at":"2018-09-14T16:07:45Z","html_url":"https://github.com/envoyproxy/envoy/pull/4101#discussion_r217764281","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/217764281"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4101#discussion_r217764281"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101","id":207460722,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDYwNzIy","html_url":"https://github.com/envoyproxy/envoy/pull/4101","diff_url":"https://github.com/envoyproxy/envoy/pull/4101.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4101.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4101","number":4101,"state":"open","locked":false,"title":"Add rule requirement feature to jwt_authn filter","user":{"login":"potatop","id":2287016,"node_id":"MDQ6VXNlcjIyODcwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2287016?v=4","gravatar_id":"","url":"https://api.github.com/users/potatop","html_url":"https://github.com/potatop","followers_url":"https://api.github.com/users/potatop/followers","following_url":"https://api.github.com/users/potatop/following{/other_user}","gists_url":"https://api.github.com/users/potatop/gists{/gist_id}","starred_url":"https://api.github.com/users/potatop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatop/subscriptions","organizations_url":"https://api.github.com/users/potatop/orgs","repos_url":"https://api.github.com/users/potatop/repos","events_url":"https://api.github.com/users/potatop/events{/privacy}","received_events_url":"https://api.github.com/users/potatop/received_events","type":"User","site_admin":false},"body":"*Title*: Add rule requirement feature to jwt_authn filter\r\n\r\n*Description*: Add rule requirement feature based on config proto and discussions in #3381.\r\nRequires type provider_and_audiences, requires_any, and requires_all is not implemented.\r\n\r\n*Risk Level*: Medium\r\n\r\n*Testing*: unit test and manual","created_at":"2018-08-09T22:24:41Z","updated_at":"2018-09-14T16:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f040238d0f1da1b3f5b4292153fbac2a80e228b","assignee":{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4101/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/4bfe5d6ace2f7e95668eb5a1f5dbcce85b713893","head":{"label":"potatop:jwt_authn_per_route_filter","ref":"jwt_authn_per_route_filter","sha":"4bfe5d6ace2f7e95668eb5a1f5dbcce85b713893","user":{"login":"potatop","id":2287016,"node_id":"MDQ6VXNlcjIyODcwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2287016?v=4","gravatar_id":"","url":"https://api.github.com/users/potatop","html_url":"https://github.com/potatop","followers_url":"https://api.github.com/users/potatop/followers","following_url":"https://api.github.com/users/potatop/following{/other_user}","gists_url":"https://api.github.com/users/potatop/gists{/gist_id}","starred_url":"https://api.github.com/users/potatop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatop/subscriptions","organizations_url":"https://api.github.com/users/potatop/orgs","repos_url":"https://api.github.com/users/potatop/repos","events_url":"https://api.github.com/users/potatop/events{/privacy}","received_events_url":"https://api.github.com/users/potatop/received_events","type":"User","site_admin":false},"repo":{"id":143797401,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3OTc0MDE=","name":"envoy","full_name":"potatop/envoy","owner":{"login":"potatop","id":2287016,"node_id":"MDQ6VXNlcjIyODcwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2287016?v=4","gravatar_id":"","url":"https://api.github.com/users/potatop","html_url":"https://github.com/potatop","followers_url":"https://api.github.com/users/potatop/followers","following_url":"https://api.github.com/users/potatop/following{/other_user}","gists_url":"https://api.github.com/users/potatop/gists{/gist_id}","starred_url":"https://api.github.com/users/potatop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatop/subscriptions","organizations_url":"https://api.github.com/users/potatop/orgs","repos_url":"https://api.github.com/users/potatop/repos","events_url":"https://api.github.com/users/potatop/events{/privacy}","received_events_url":"https://api.github.com/users/potatop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/potatop/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/potatop/envoy","forks_url":"https://api.github.com/repos/potatop/envoy/forks","keys_url":"https://api.github.com/repos/potatop/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/potatop/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/potatop/envoy/teams","hooks_url":"https://api.github.com/repos/potatop/envoy/hooks","issue_events_url":"https://api.github.com/repos/potatop/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/potatop/envoy/events","assignees_url":"https://api.github.com/repos/potatop/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/potatop/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/potatop/envoy/tags","blobs_url":"https://api.github.com/repos/potatop/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/potatop/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/potatop/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/potatop/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/potatop/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/potatop/envoy/languages","stargazers_url":"https://api.github.com/repos/potatop/envoy/stargazers","contributors_url":"https://api.github.com/repos/potatop/envoy/contributors","subscribers_url":"https://api.github.com/repos/potatop/envoy/subscribers","subscription_url":"https://api.github.com/repos/potatop/envoy/subscription","commits_url":"https://api.github.com/repos/potatop/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/potatop/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/potatop/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/potatop/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/potatop/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/potatop/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/potatop/envoy/merges","archive_url":"https://api.github.com/repos/potatop/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/potatop/envoy/downloads","issues_url":"https://api.github.com/repos/potatop/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/potatop/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/potatop/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/potatop/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/potatop/envoy/labels{/name}","releases_url":"https://api.github.com/repos/potatop/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/potatop/envoy/deployments","created_at":"2018-08-07T00:21:57Z","updated_at":"2018-08-19T12:46:32Z","pushed_at":"2018-09-14T14:18:18Z","git_url":"git://github.com/potatop/envoy.git","ssh_url":"git@github.com:potatop/envoy.git","clone_url":"https://github.com/potatop/envoy.git","svn_url":"https://github.com/potatop/envoy","homepage":"https://www.envoyproxy.io","size":20494,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"b0ff481411e553c5d0250505f26f2df2d639d1b2","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-09-14T14:48:52Z","pushed_at":"2018-09-14T16:04:59Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":20369,"stargazers_count":6526,"watchers_count":6526,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":871,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":871,"open_issues":331,"watchers":6526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4101"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4101"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4101/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4101/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/4bfe5d6ace2f7e95668eb5a1f5dbcce85b713893"}},"author_association":"NONE"}}
{"actor":{"display_login":"qiwzhang"}}