{"push_id":2994435612,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"f6122547d77444a027119c3c2b7f2602a5acde53","before":"78ab675bd8aa7c2a497651bc7681f5286c1cc8b3","commits":[{"sha":"f6122547d77444a027119c3c2b7f2602a5acde53","author":{"name":"epriestley","email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com"},"message":"When a lease triggers a resource allocation for a resource which must activate, awaken the lease task after the resource activates\n\nSummary:\nDepends on D19753. Ref T13210. This is a small optimization that saves us from waiting up to 15 seconds for a yield.\n\nWhen there are no Working Copy resources and a new lease comes in, we'll allocate one and yield until it activates.\n\nIf activating it (SSH'ing and running `git clone`) takes less than 15 seconds, the resource will activate (say, at T+4) but the lease won't update again for a while (say, until T+15). This leaves us with a pointless wait (in this example, we're sitting around for 9 seconds when we could move forward).\n\nTo improve this a little bit, let resources wake up the lease update tasks that triggered allocation after they activate. In the best case, that task runs ~15 seconds sooner. In the worst case, the awaken is just a no-op.\n\nWith a more-full queue, this has a smaller effect (it's likely something else will run and be able to use the resource in those 9 seconds).\n\nWith already-activated resources, this has no effect (when resources are already activated, we can lease immediately).\n\nTest Plan:\n  - Cleaned up all working copy resources.\n  - Requested a new \"A\" working copy.\n  - Before patch: got a working copy after 17-18 seconds, most of which was spent yielded.\n  - After patch: got a working copy after 3-4 seconds.\n\nReviewers: amckinley\n\nReviewed By: amckinley\n\nSubscribers: PHID-OPKG-gm6ozazyms6q6i22gyam\n\nManiphest Tasks: T13210\n\nDifferential Revision: https://secure.phabricator.com/D19754","distinct":true,"url":"https://api.github.com/repos/phacility/phabricator/commits/f6122547d77444a027119c3c2b7f2602a5acde53"}]}
{"actor":{"display_login":"phacility-bot"}}